[Webkit-unassigned] [Bug 27918] commit-queue mode for bugzilla-tool

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27918


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34032|review?                     |review-
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-08-03 19:40:29 PDT ---
(From update of attachment 34032)
We could key this choice off of an option some day:
6         for bug_id in bug_ids:
147              print "%s" % tool.bugs.bug_url_for_bug_id(bug_id)
 147             print "%s" % bug_id

Danger Danger will robinson!
 366         options.force_clean = True

I don't think we should --force-clean automagically.

Seems we should check the value of ['commit-queue'] here:
 239             if 'commit-queue' in attachment and not
attachment['is_obsolete']:

attachment.get('commit-queue', False) might do the trick.  I think
['commit-queue'] might throw an exception.

Otherwise looks good.  We need to fix the "destroying your current work state"
problem by forcing --force-clean.  We need to require something to be passed
before we go destroying data.

You should be aware of the proposed refactoring in:
https://bugs.webkit.org/show_bug.cgi?id=26715

(I really should split out the refactoring bits into a separate patch and get
it landed.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.