[Webkit-unassigned] [Bug 27961] bugzilla-tool land-patches needs --queue mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 3 16:52:08 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27961


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34019|review?                     |review+
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-08-03 16:52:07 PDT ---
(From update of attachment 34019)
get_path_from_webkit_script

should be webkit_script_path I think.  we don't tend to prefix getters with
"get"

Isn't there a ! operator in python?
not options.commit_queue
 318                 cls.run_webkit_tests(launch_safari=not
options.commit_queue)
reads a little odd with "not" to my eyes.

Otherwise looks good!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list