[Webkit-unassigned] [Bug 27436] gobject bindings need access to keyCode on KeyboardEvents!

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27436





--- Comment #20 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-08-03 16:41:57 PDT ---
(In reply to comment #12)
> (In reply to comment #8)
> > > I think Mark wanted a different solution for c bindings in general,
> 
> Yes, I'm after a more general solution than picking a single function and
> #if'ing the rest out.  As I've mentioned in bug 27435, there are other
> situations in which this is necessary.

 [answered there]

>  Since a general solution would obviate
> the need for #if'ing in IDL files I would prefer to see it explored before we
> go landing changes that add #if's.

 * a general solution would require across-the-board changes [to
CodeGenerator.pm], including to CodeGeneratorGObject.pm.  if they're willing to
do that.

 * that means that someone would need to look at code that's in webkit svn
_and_ code that's not.  if they're willing to do that.

 * it could be months before an updated solution is discussed and ready [if in
fact one is needed at all - see #27435 answer]

 on balance, therefore, i would consider it a wiser move to tolerate #ifdefs,
warts and all, land the CodeGeneratorGObject and _then_ look at all of the
CodeGenerators all at once.

 if it's _really_ a problem to have an "un-finalised" c-based gobject API out
there, then there are plenty of ways to stop people from using it whilst
matters are discussed, whilst also not impeding people who are willing to use
what's there, regardless.

 putting in a #ifdef DO_NOT_USE_GOBJECT_API_ONLY_AT_OWN_RISK_NOT_FINALISED_YET
 is the most obvious one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.