[Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27425





--- Comment #17 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-08-03 15:59:04 PDT ---
(In reply to comment #16)
> (From update of attachment 34008 [details])
> This is *much* better!

 goood :)

> Why is HTMLName.cpp compiled by inclusion in the element factory wrapper? That
> seems wrong.  We should at least add a FIXME there.
> 
> Why are we skipping DATAGRID?
> 612         # skip DATAGRID for now
>  613         next if ($conditional eq 'DATAGRID');

 because i don't have Gdom headers for anything that's DATAGRID based.

> In general this looks great though! r- mostly for the datagrid hack.

 ack.

>  I would
> much prefer that some of this is turned into subroutines instead of inline
> ifdefs.  Also we need to explicitly check for GDOM, it can't be the "other
> default". :)

 ack.

 end-of-day.  will look at these again tomorrow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.