[Webkit-unassigned] [Bug 27436] gobject bindings need access to keyCode on KeyboardEvents!

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 3 12:51:53 PDT 2009


--- Comment #17 from Mark Rowe (bdash) <mrowe at apple.com>  2009-08-03 12:51:52 PDT ---
(In reply to comment #16)
> Sounds like either I have the ! reversed in my example text above, or I'm
> misunderstanding the issue.  Are you saying that it would not be
> good/possible/sufficient to replace the proposed !JAVASCRIPT && GOBJECT && ...
> with a single define?

In some places that overloading is used, such as XHR, the IDL contains a single
version of the method that is annotated with [Custom] to indicate that a custom
JS implementation of the binding for that method will be provided.  That custom
implementation typically introspects the arguments that were provided and
dispatches to the appropriate method on the wrapped DOM object.

In most cases, functions that are #if'd in the IDLs to exclude them from
JavaScript are not done so for a reason related to overloading, so changing
them to be wrapped by a define related to overloading would not be appropriate.

In the case of initKeyboardEvent it's not clear why one variant is excluded
from JavaScript.  The variant without altGraph was added in
<http://trac.webkit.org/changeset/16277/trunk/WebCore/dom/KeyboardEvent.idl> by
Sam without much explanation.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list