[Webkit-unassigned] [Bug 27946] New: PluginView.h included in Page.cpp breaks Chromium build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 3 10:36:29 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27946

           Summary: PluginView.h included in Page.cpp breaks Chromium
                    build
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Plug-ins
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tony at chromium.org
                CC: jhoneycutt at apple.com


In r46649, an include for PluginView.h was added to Page.cpp.  Chromium doesn't
use PluginView.h so this causes a build break for us.

I'm not sure what the right fix is, but simply removing the include seems to
allow Chromium to compile since the pointer never needs to be dereferenced.

I'll upload a patch with an if !PLATFORM(CHROMIUM), although I'm not sure
that's the right way to fix this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list