[Webkit-unassigned] [Bug 27906] [chromium] MessagePort construction fails in worker process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27906





--- Comment #10 from John Abd-El-Malek <jam at chromium.org>  2009-08-03 10:18:38 PDT ---
(In reply to comment #8)
> Drive by comments, 

Thanks, replies below.

> 
> In WebCore/bindings/v8/V8DOMWrapper.cpp
> 
>  520     // These objects can be constructed under WorkerContextExecutionProxy,
> need special handling
>  521     // as V8Proxy::retrieve() will crash then.
> 
> I can't parse this (maybe there is a typo).

you're right, it wasn't that clear.  updated.
> 
> Line 523-526 seems like it should be indented by one more space.
> 

done

> 
> 
> In WebCore/bindings/v8/WorkerContextExecutionProxy.cpp,
> 
> 219 #define MAKE_CASE(TYPE, NAME) case V8ClassIndex::TYPE:
>  220         ACTIVE_DOM_OBJECT_TYPES(MAKE_CASE)
>  221         isActiveDomObject = true;
>  222 #undef MAKE_CASE
> 
> 
> Shouldn't there be a break right after line 221 (or else something that says
> fall through)?

The code I copied this from (V8DOMWrapper::setJSWrapperForActiveDOMObject)
didn't have it.  It doesn't make a difference either way, since it'll fall
through to the default case which breaks, but I added it anyways.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.