[Webkit-unassigned] [Bug 27906] [chromium] MessagePort construction fails in worker process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27906


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |levin at chromium.org




--- Comment #8 from David Levin <levin at chromium.org>  2009-08-03 10:09:26 PDT ---
Drive by comments, 

In WebCore/bindings/v8/V8DOMWrapper.cpp

 520     // These objects can be constructed under WorkerContextExecutionProxy,
need special handling
 521     // as V8Proxy::retrieve() will crash then.

I can't parse this (maybe there is a typo).

Line 523-526 seems like it should be indented by one more space.



In WebCore/bindings/v8/WorkerContextExecutionProxy.cpp,

219 #define MAKE_CASE(TYPE, NAME) case V8ClassIndex::TYPE:
 220         ACTIVE_DOM_OBJECT_TYPES(MAKE_CASE)
 221         isActiveDomObject = true;
 222 #undef MAKE_CASE


Shouldn't there be a break right after line 221 (or else something that says
fall through)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.