[Webkit-unassigned] [Bug 27939] WebInspector: Extract style editing into a separate file that is going to be loaded in page context.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 3 10:02:58 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27939





--- Comment #6 from Pavel Feldman <pfeldman at chromium.org>  2009-08-03 10:02:57 PDT ---
(In reply to comment #5)
> (From update of attachment 33973 [details])
> are we going to have different rules for the InjectedScript.js file?  Will that
> be the only way to get script into the page's context?  I think it's good to
> divide things out like this so that it's easier to make sure the Inspector is
> "secure" long term.  My line of questioning mostly leads to the question of if
> this is going to be the only injected script file, and if InjectedScript.js is
> the right name if it's not.

InjectedScript is going to be the only file containing the code that has access
to the running page. All data is going to be serialized on the way to/from this
injected script. It should not be too large (~1.5KLOC). I am not sure if that
is a good name for it anyway, so I am open to suggestions.

While I am looking for the advice on how to organize this new context:
a) Continue extracting properties and search-related requests there
b) Create a separate html file referencing this script only and open it
similarly to the front-end itself
c) Wait and see what Sam suggests
d) Something else?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list