[Webkit-unassigned] [Bug 27424] adding ConvertToGCharPrivate.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27424





--- Comment #10 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-08-03 08:35:36 PDT ---
(In reply to comment #9)
> (From update of attachment 33388 [details])
> Most of the rest of WebCore follows the "copy rule", which would name these
> with "copy" in their name since you're copying the data, or create.
> 
> copyAsGchar()
> or
> createGcharFromString()
> 
> I've never seen this:
> 23 /*
>  24  * added under bug #27424 - 19jul2009
>  25  */
> 
> Seems superfluous, given that we have a version control system.

 gone.  i'm pseudo-maintaining external revision control, and worked out a
better manual system [copy what people do with the ChangeLog entries.  duh].

> So overall these look fine.  I'm not a huge fan of the convert name, but it's
> also not a dealbreaker.

 renamed to copyAsGchar to fit into WebCore rules.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.