[Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 3 06:40:23 PDT 2009


Luke Kenneth Casson Leighton <lkcl at lkcl.net> changed:

           What    |Removed                     |Added
  Attachment #33053|0                           |1
        is obsolete|                            |
  Attachment #33972|                            |review?
               Flag|                            |

--- Comment #4 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-08-03 06:40:22 PDT ---
Created an attachment (id=33972)
 --> (https://bugs.webkit.org/attachment.cgi?id=33972)
corrections noted from other reviews (e.g. removal of args on prototypes)

please note: the ordering of the #includes is noted as being out-of-order
[strictly speaking] but there is a comment advising that they are not
out-of-order, they're grouped together by purpose.  the reason is because this
file is equivalent to and was constructed out of many JS*Binding*.cpp files. 
if ever this one file GDOMBindings.cpp is split down into many files, it will
be extra work for developers to re-construct the header dependencies of the

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list