[Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 3 01:50:09 PDT 2009


--- Comment #3 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-08-03 01:50:09 PDT ---
(In reply to comment #2)
> (From update of attachment 33059 [details])
> WebCore avoids using superfluous argument names in headers:
>  91     gpointer toGDOM(DOMWindow* doc);
>  92     gpointer toGDOM(Document* doc);
>  93     gpointer toGDOM(XMLHttpRequest* obj);

 oh?  ah.  didn't know that. hmmm, i might have a few of those.. hmmm...

> We don't commit commented out code:
>  407     //WebKitWebFramePrivate* priv = frame->priv;

 ack.  hmm, what about #ifdef TODO?

> Name:
>  2536 2008-11-30  lkcl  <lkcl at lkcl.net>
> Otherwise looks fine.  I mean, I'm not really a gtk expert.  There are style
> violations, but I assume this stuff is more supposed to be more gtk style than
> webkit style, not sure.

 yes.  makes for a bit of a mess, but hey :)

 btw, erik: _whatever_ you do, don't land this one until the other patches are
landed.  i've specified the dependency ordering in the bugreports.

 if this one goes in before anything else does it will _royally_ mess things
up, as there are functions which don't exist yet.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list