[Webkit-unassigned] [Bug 27439] [Gtk] crash when closing page from javascript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27439





--- Comment #11 from Jan Alonzo <jmalonzo at gmail.com>  2009-08-02 03:06:18 PDT ---
(In reply to comment #10)
> (In reply to comment #9)
> > Now it's kinda mandatory. How does a WebView created by create-web-view get
> > freed prior to when this signal was introduced?
> > 
> 
> Well, in the general case it's handled by the client, since it's the client who
> created the view right? 

Right.

> But in the case of the windows destroyed by
> window.close() the code that emits the signal would destroy the view itself, so
> in theory you didn't need to do anything (although this is probably too
> simplistic anyway, since for popups in new windows you'd need to get rid of the
> toplevel anyway...).


> > Maybe add something like "free the WebView you created in create-web-view"?
> 
> Yeah, I read that, but I meant explaining explicitly that you have to free/hide
> the view in the callback yourself. 'Recommended' sounds a bit like 'it would be
> good if you do it, but you don't have to', but I don't think that's the case
> now?

Right. I'll mention that it's mandatory.

> Also, I think it would be good to have a test (or tests) about this (we can do
> it after we land the patch though).

I'll try to come up an updated patch with test in the next couple of days.
Thanks for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.