[Webkit-unassigned] [Bug 27931] [commit+] JSNodeCustom should call document() instead of scriptExecutionContext()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 2 02:50:46 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27931


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33947|review+                     |review-
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2009-08-02 02:50:45 PDT ---
(From update of attachment 33947)
On reflection, I don't think this patch is right.

Document is derived from ScriptExecutionContext, so there's no need to overload
toJSDOMGlobalObject to take a Document*. The JSNodeCustom.cpp change can stand
alone. No need to change JSDOMGLobalObject.h and .cpp.

I'm changing my review to review-.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list