[Webkit-unassigned] [Bug 27439] [Gtk] crash when closing page from javascript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27439





--- Comment #9 from Jan Alonzo <jmalonzo at gmail.com>  2009-08-02 00:55:31 PDT ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > (In reply to comment #5)
> > > > Created an attachment (id=33933)
 --> (https://bugs.webkit.org/attachment.cgi?id=33933) [details] [details] [details] [details]
> > > > Patch v1
> > > 
> > > Doesn't crash anymore, but window does not close either :(
> > 
> > Embedders need to listen to close-web-view to either destroy or hide their
> > windows which I don't think ephy does atm.
> 
> Wouldn't it be with this patch *mandatory* that you handle the signal?

Now it's kinda mandatory. How does a WebView created by create-web-view get
freed prior to when this signal was introduced?

> Otherwise you'd leak the view object, which used to be unreffed by
> closeWindowSoon until now. If that's the case you should make the documentation
> more specific about that.

I did.

      *
+     * It is also recommended that #WebKitWebView::close-web-view be handled
+     * to hide the #WebKitWebView.
+     *

Maybe add something like "free the WebView you created in create-web-view"?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.