From bugzilla-daemon at webkit.org Sat Aug 1 00:10:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 1 Aug 2009 00:10:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22123] QtWebKit should not apply color scheme to QWebPage In-Reply-To: References: Message-ID: <20090801071047.5EA00343ED45@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22123 Antti Kaijanm?ki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |antti at kaijanmaki.net --- Comment #3 from Antti Kaijanm?ki 2009-08-01 00:10:46 PDT --- In my opinion QtWebKit should obey the color scheme. There would be no problem if QtWebkit would use Text Color from the scheme. Now it takes only Background Color and uses (hard coded?) dark colors for text rendering which leads to poor readability. >From https://bugs.launchpad.net/ubuntu/+source/qt4-x11/+bug/407340 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 1 00:23:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 1 Aug 2009 00:23:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27820] [commit+] Adding layout test for Unicode in Example Bug
-- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 01:59:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 01:59:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27973] REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs In-Reply-To: References: Message-ID: <20090804085940.446DA3458C3E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27973 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Eric Seidel 2009-08-04 01:59:38 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool Committed r46754 M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool r46754 = 3d81d05269c879e0aac096ceee849d47735726dd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46754 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 01:59:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 01:59:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27975] [v8] Fix crash in collection-null-like-arguments In-Reply-To: References: Message-ID: <20090804085950.525D13458C61@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27975 Christian Plesner Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34049| |review? Flag| | --- Comment #1 from Christian Plesner Hansen 2009-08-04 01:59:49 PDT --- Created an attachment (id=34049) --> (https://bugs.webkit.org/attachment.cgi?id=34049) Initial -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:01:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:01:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27975] [v8] Fix crash in collection-null-like-arguments In-Reply-To: References: Message-ID: <20090804090102.711673458C8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27975 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34049|review? |review- Flag| | --- Comment #2 from Adam Barth 2009-08-04 02:01:01 PDT --- (From update of attachment 34049) ChangeLog? LayoutTest? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:02:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:02:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27974] bugzilla-tool --commit-queue should validate commit-queue setter is a committer In-Reply-To: References: Message-ID: <20090804090232.6BB2B3458CCB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27974 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34046|review? |review+ Flag| | --- Comment #2 from Eric Seidel 2009-08-04 02:02:31 PDT --- (From update of attachment 34046) LGTM! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:03:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:03:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27975] [v8] Fix crash in collection-null-like-arguments In-Reply-To: References: Message-ID: <20090804090349.947953458D03@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27975 --- Comment #3 from Christian Plesner Hansen 2009-08-04 02:03:48 PDT --- Good point, sorry... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:08:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:08:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] New: bugzilla-tool unit tests need a test harness Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27977 Summary: bugzilla-tool unit tests need a test harness Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abarth at webkit.org CC: eric at webkit.org, ddkilzer at webkit.org Turns out to be trivial. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:08:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:08:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27975] [v8] Fix crash in collection-null-like-arguments In-Reply-To: References: Message-ID: <20090804090837.896F73458D7F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27975 Christian Plesner Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34049|review- | Flag| | Attachment #34049|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:08:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:08:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27975] [v8] Fix crash in collection-null-like-arguments In-Reply-To: References: Message-ID: <20090804090843.B59763458D92@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27975 Christian Plesner Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34050| |review? Flag| | --- Comment #4 from Christian Plesner Hansen 2009-08-04 02:08:42 PDT --- Created an attachment (id=34050) --> (https://bugs.webkit.org/attachment.cgi?id=34050) Added ChangeLog -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:09:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:09:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804090931.257CC3458DB9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34051| |review? Flag| | --- Comment #1 from Adam Barth 2009-08-04 02:09:30 PDT --- Created an attachment (id=34051) --> (https://bugs.webkit.org/attachment.cgi?id=34051) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:12:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:12:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27975] [v8] Fix crash in collection-null-like-arguments In-Reply-To: References: Message-ID: <20090804091216.09AC03458E2B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27975 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34050|review? |review+, commit-queue+ Flag| | --- Comment #5 from Adam Barth 2009-08-04 02:12:14 PDT --- (From update of attachment 34050) Thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:21:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:21:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27969] bugzilla-tool has too many fatal errors In-Reply-To: References: Message-ID: <20090804092140.D41573458EEB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27969 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Adam Barth 2009-08-04 02:21:40 PDT --- http://trac.webkit.org/changeset/46753 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:23:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:23:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27974] bugzilla-tool --commit-queue should validate commit-queue setter is a committer In-Reply-To: References: Message-ID: <20090804092329.BFEA43458F17@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27974 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34046| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:27:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:27:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27974] bugzilla-tool --commit-queue should validate commit-queue setter is a committer In-Reply-To: References: Message-ID: <20090804092703.621AD3458F73@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27974 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Adam Barth 2009-08-04 02:27:02 PDT --- Sending WebKitTools/ChangeLog Sending WebKitTools/Scripts/modules/bugzilla.py Sending WebKitTools/Scripts/modules/bugzilla_unittest.py Transmitting file data ... Committed revision 46755. http://trac.webkit.org/changeset/46755 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:29:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:29:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27975] [v8] Fix crash in collection-null-like-arguments In-Reply-To: References: Message-ID: <20090804092910.0CB413458FB9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27975 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34050|review+ | Flag| | --- Comment #6 from Adam Barth 2009-08-04 02:29:08 PDT --- (From update of attachment 34050) Clearing review flag on attachment: 34050 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/V8Binding.cpp Committed r46756 M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla_unittest.py M WebKitTools/Scripts/modules/bugzilla.py r46755 = b917198eebcb893beceb9ea46db5aebffa61305f (trunk) M WebCore/ChangeLog M WebCore/bindings/v8/V8Binding.cpp r46756 = a965b2f2f1a669e8644387516dcde8ea650d6111 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46756 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:29:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:29:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27975] [v8] Fix crash in collection-null-like-arguments In-Reply-To: References: Message-ID: <20090804092913.E5EF03458FCB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27975 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |abarth at webkit.org Resolution| |FIXED --- Comment #7 from Adam Barth 2009-08-04 02:29:12 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:44:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:44:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27978] New: getBoundingClientRect method of DOM element return wrong value for some page Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27978 Summary: getBoundingClientRect method of DOM element return wrong value for some page Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows Vista Status: UNCONFIRMED Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: tiansjun at hotmail.com http://www.gamespot.com/pc/strategy/sinsofasolarempire/review.html I try to get the clinet rectangle of this page by invoking "getBoundingClientRect" on the element. But it returns an rectangle with zero height. I also inspect this page in safari4.0.2 and arora8.0, both give height=0 for element. The Qwebframe::contentSize() can give a non-empty result for this page. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 02:44:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 02:44:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27953] -[NSWorkspace openURL:] causing issues In-Reply-To: References: Message-ID: <20090804094436.EE273345917A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27953 --- Comment #2 from importedfromspace at googlemail.com 2009-08-04 02:44:36 PDT --- A quick test seems to show that this only happens to me when it is run from Xcode. When the app is launched from the Finder it does not show this problem. Other than the launchd message 04/08/2009 10:35:41 com.apple.launchd[77] ([0x0-0x417417].org.webkit.nightly.WebKit[7427]) Exited abnormally: Interrupt the only message logged from WebKit is the "WebKit r46726 initialized." message. WebKit r46726 Mac OS X 10.5.7 (9J61) Safari 4.0.2. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 03:15:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 03:15:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] New: Cannot scroll for box-reflect:right Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27979 Summary: Cannot scroll for box-reflect:right Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hamaji at chromium.org Created an attachment (id=34052) --> (https://bugs.webkit.org/attachment.cgi?id=34052) Test case See the attached test case. For vertical reflection, we can move scrollbar to see the reflected image. However, we don't see a scrollbar for horizontal reflection. I'll send a patch soon later. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 03:20:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 03:20:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 10341] SVGs fail to render intermittently (on reload) In-Reply-To: References: Message-ID: <20090804102014.0C0793459441@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=10341 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krit at webkit.org Blocks| |26389 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 03:20:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 03:20:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26389] SVG Filters implementation In-Reply-To: References: Message-ID: <20090804102014.D8947345944D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26389 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10341 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 03:21:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 03:21:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27490] Web Sockets Test Infrastructure Part 1/3: Server In-Reply-To: References: Message-ID: <20090804102101.99E803459464@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27490 Yuzo Fujishima changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33157|review? | Flag| | Attachment #33157|0 |1 is obsolete| | Attachment #34053| |review? Flag| | --- Comment #5 from Yuzo Fujishima 2009-08-04 03:21:00 PDT --- Created an attachment (id=34053) --> (https://bugs.webkit.org/attachment.cgi?id=34053) Web Socket Server for LayoutTests, derived from Python's SimpleHTTPServer To enable both same-origin (http://) and cross-origin (file://) testing, and also to make testing a little bit more realistic, I've rewritten the test Web Socket server to derive from Python's SimpleHTTPServer. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 03:22:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 03:22:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804102228.94C0B34594B5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34054| |review? Flag| | --- Comment #1 from Shinichiro Hamaji 2009-08-04 03:22:28 PDT --- Created an attachment (id=34054) --> (https://bugs.webkit.org/attachment.cgi?id=34054) Patch v1 --- 7 files changed, 67 insertions(+), 3 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 03:24:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 03:24:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27491] Web Sockets Test Infrastructure Part 2/3: Patch to run-webkit-tests In-Reply-To: References: Message-ID: <20090804102408.09D9234594F0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27491 Yuzo Fujishima changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33159|review? | Flag| | Attachment #33159|0 |1 is obsolete| | Attachment #34055| |review? Flag| | --- Comment #6 from Yuzo Fujishima 2009-08-04 03:24:07 PDT --- Created an attachment (id=34055) --> (https://bugs.webkit.org/attachment.cgi?id=34055) Patch to run-webkit-test to use Web Socket Server for both http and file schemes. This should enable both same-origin (http://) and cross-origin(file://) testing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 03:26:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 03:26:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27492] Web Sockets Test Infrastructure Part 3/3: Example test In-Reply-To: References: Message-ID: <20090804102613.442193459531@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27492 Yuzo Fujishima changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33162|review? | Flag| | Attachment #33162|0 |1 is obsolete| | Attachment #34056| |review? Flag| | --- Comment #3 from Yuzo Fujishima 2009-08-04 03:26:11 PDT --- Created an attachment (id=34056) --> (https://bugs.webkit.org/attachment.cgi?id=34056) Example Web Socket Tests, same-origin and cross-origin. New example tests for the new test server. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 03:27:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 03:27:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804102726.998FF3459569@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34054|review? | Flag| | Attachment #34054|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 03:27:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 03:27:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804102730.ED7633459572@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34057| |review? Flag| | --- Comment #2 from Shinichiro Hamaji 2009-08-04 03:27:30 PDT --- Created an attachment (id=34057) --> (https://bugs.webkit.org/attachment.cgi?id=34057) Patch v2 --- 7 files changed, 67 insertions(+), 3 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 03:28:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 03:28:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804102818.3470F345957E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 --- Comment #3 from Shinichiro Hamaji 2009-08-04 03:28:17 PDT --- I should have sent a png image in the patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 04:38:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 04:38:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] New: Give an ability to WebKit to free statically allocated pointers before quit Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27980 Summary: Give an ability to WebKit to free statically allocated pointers before quit Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Enhancement Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: zherczeg at inf.u-szeged.hu For this enhancement we should keep in mind, that freeing statically allocated pointers takes time, which may delay the quit process. This may not be desired in standalone web browsers. However, sometimes it is good to free statically allocated pointers but this method should not have a performance impact when it is disabled. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 04:39:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 04:39:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804113913.E20FC3459E6C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Zoltan Herczeg changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34058| |review? Flag| | --- Comment #1 from Zoltan Herczeg 2009-08-04 04:39:13 PDT --- Created an attachment (id=34058) --> (https://bugs.webkit.org/attachment.cgi?id=34058) First draft patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 04:57:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 04:57:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804115705.84CCF345A00B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #2 from Zoltan Herczeg 2009-08-04 04:57:04 PDT --- (In reply to comment #1) > Created an attachment (id=34058) --> (https://bugs.webkit.org/attachment.cgi?id=34058) [details] > First draft patch This patch is intended to be a draft. I would like to hear your opinion about this solution: - two new files are added to wtf directory: StaticPtr.h and StaticPtr.cpp - enabling FREE_STATIC_PTRS allows to free the pointers in a reversed creation order - Although c++ supports automatic destructors, I think it would not be wise to free the pointers in random order. - StdLibExtras.h is overwritten to support these pointers - Since heap.destroy() must be called for JSGlobalData before delete, I created a new derived class, because template specialization created multiple definitions for StaticPtr::free() (See JSDOMWindowBase.cpp -> commonJSGlobalData()) - I am sure this patch should be cut to multiple parts. Do you have any suggestions for this? - Some destructors are only defined, but never implemented. Why? (~ImageLoadEventSender(), ~FontCache()) - And an iteresting observation: some AtomicStrings are defined as const, and some are not, but all of them seems like fixed strings. Should we change all of their type to "const AtomicString"? This patch works with Qt port nicely (after some fixes). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 05:11:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 05:11:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27255] Geolocation incorrectly calls error callback in case of exception in success callback In-Reply-To: References: Message-ID: <20090804121125.53BE2345A19B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27255 --- Comment #5 from Andrei Popescu 2009-08-04 05:11:24 PDT --- Hi, The spec currently says: "UNKNOWN_ERROR (numeric value 0) The location acquisition process failed due to an error not covered by the definition of any other error code in this interface." http://dev.w3.org/geo/api/spec-source.html#unknown_error So UNKNOWN denotes an error in acquiring a position (it is a catch-all value for any situation not covered by the other error codes). If the UA is executing the success callback, then it means that the position was successfully acquired so, as far as the UA is concerned, the job is done. It can, of course, happen that the success callback throws an exception but I think this is a problem with the user code and not the Geolocation API implementation. As such, error callback should not be invoked. Instead, I think an error event should be raised and window.onerror should be invoked (if defined) or the error should be logged to the JS console. Andrei -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 05:25:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 05:25:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27893] run-webkit-tests Skipped Only mode includes tests that are skipped by other flags. In-Reply-To: References: Message-ID: <20090804122535.C83CE345A2F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27893 --- Comment #3 from Mike Fenton 2009-08-04 05:25:35 PDT --- I tend to agree, however, I didn't want to remove the old functionality entirely. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 05:41:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 05:41:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27893] run-webkit-tests Skipped Only mode includes tests that are skipped by other flags. In-Reply-To: References: Message-ID: <20090804124140.A941D345A429@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27893 --- Comment #4 from Adam Treat 2009-08-04 05:41:39 PDT --- I happen to agree with Eric. This is a bug fix pure and simple. No need for --only-all which is confusing to me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 05:59:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 05:59:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27981] New: [SOUP] Content sniffing always on Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27981 Summary: [SOUP] Content sniffing always on Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: adam.bergkvist at ericsson.com The Soup backend always does content sniffing without checking ResourceHandle::shouldContentSniff(). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 06:06:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 06:06:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27981] [SOUP] Content sniffing always on In-Reply-To: References: Message-ID: <20090804130610.1BD55345A67D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27981 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Gtk Status|UNCONFIRMED |NEW CC| |jmalonzo at gmail.com Ever Confirmed|0 |1 --- Comment #1 from Jan Alonzo 2009-08-04 06:06:09 PDT --- (In reply to comment #0) > The Soup backend always does content sniffing without checking > ResourceHandle::shouldContentSniff(). FYI, libsoup feature for this to be doable -http://bugzilla.gnome.org/show_bug.cgi?id=574773. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 06:59:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 06:59:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090804135953.BFFB3345AB9F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33569|review? | Flag| | Attachment #33569|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:11:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:11:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27538] Qt memory consumption on site with many images In-Reply-To: References: Message-ID: <20090804141131.B7575345AD0B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27538 --- Comment #15 from Kenneth Rohde Christiansen 2009-08-04 07:11:30 PDT --- Any update on these patches? Holger, why are these patches not up for review? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:20:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:20:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090804142022.C721B345AE29@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 --- Comment #19 from Luke Kenneth Casson Leighton 2009-08-04 07:20:20 PDT --- (In reply to comment #17) > (In reply to comment #16) > > (From update of attachment 34008 [details] [details]) > > This is *much* better! > > goood :) > > > Why is HTMLName.cpp compiled by inclusion in the element factory wrapper? That > > seems wrong. We should at least add a FIXME there. > > > > Why are we skipping DATAGRID? > > 612 # skip DATAGRID for now > > 613 next if ($conditional eq 'DATAGRID'); > > because i don't have Gdom headers for anything that's DATAGRID based. ok - i gave this a shot - getting the CodeGeneratorGObject.pm to auto-generate GdomHTMLDataGridElement.cpp,h etc. and they depend on the existence of GdomDataGridDataSource.cpp,h. these files do not exist. and... they're not auto-generated, they must be created manually. i'm done with extra workload - adding extra functionality - until this series of patches is in, or unless there's a damn good reason. so, that means that i'm not willing to create GdomDataGridDataSource at this time (from looking at WebCore/bindings/JS/JSDataGridDataSource.cpp,h). therefore, to reduce workload, a small and simple hack is needed, to skip anything that is #ifdef DATAGRID. this simple hack will still allow people to create JS-based DATAGRID bindings, and a working web browser, but they will just not have gobject bindings to datagrid. DATAGRID can be looked at _after_ the series of gobject patches are landed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:25:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:25:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27982] New: textfield focus does not work in listed URL Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27982 Summary: textfield focus does not work in listed URL Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh URL: http://en.wikipedia.org/wiki/San_Francisco,_California ?useskin=modern OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hartman at videolan.org See also: https://bugzilla.wikimedia.org/show_bug.cgi?id=19194 For some reason the searchfield of mediawiki's modern skin does not receive focus when you click on it. It DOES receive focus if explicitly told so through JS or by using an access key (ctrl-alt-f). The links in the same column do work, and this problem is only notable on Webkit browsers, the skin works just fine on all the other browsers. The problem is probably due to "overlapping" content divs or something. If you select the text of the article content, you can notice that the selected text includes all the left margin, overlapping the sidebar that contains the searchfield. P.S. likely this can be fixed in some way in HTML, i'm open for suggestions, but it's still a bug i think. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:34:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:34:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27893] run-webkit-tests Skipped Only mode includes tests that are skipped by other flags. In-Reply-To: References: Message-ID: <20090804143415.84A63345AF94@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27893 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33899|review? | Flag| | Attachment #33899|0 |1 is obsolete| | Attachment #34059| |review? Flag| | --- Comment #5 from Mike Fenton 2009-08-04 07:34:14 PDT --- Created an attachment (id=34059) --> (https://bugs.webkit.org/attachment.cgi?id=34059) Updated patch without skipped=only-all mode I've updated the patch to strictly fix the --skipped=only mode. No only-all mode is included in this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:38:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:38:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090804143806.9DBB9345B00F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Luke Kenneth Casson Leighton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33999|0 |1 is obsolete| | Attachment #34008|0 |1 is obsolete| | Attachment #34060| |review?(eric at webkit.org) Flag| | --- Comment #20 from Luke Kenneth Casson Leighton 2009-08-04 07:38:05 PDT --- Created an attachment (id=34060) --> (https://bugs.webkit.org/attachment.cgi?id=34060) answers review comments. ok explanation for DATAGRID skip is in previous comment: summary - too much knock-on effect / consequences / increase in workload. i made JS the default so that it was not necessary to modify GNUmakefile.am. necessary modifications to GNUmakefile.am now included. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:42:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:42:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27973] REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs In-Reply-To: References: Message-ID: <20090804144241.7BD12345B090@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27973 --- Comment #7 from David Kilzer (ddkilzer) 2009-08-04 07:42:39 PDT --- (From update of attachment 34047) >+ The trailing comma (suppresses newlines) was lost in r46700. Heh...I thought the trailing comma was a typo. That's one of the weirdest language behaviors I've ever seen. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:45:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:45:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804144519.9F467345B0D6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 David Kilzer (ddkilzer) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34051|review? |review- Flag| | --- Comment #2 from David Kilzer (ddkilzer) 2009-08-04 07:45:18 PDT --- (From update of attachment 34051) I think you're missing some files from this patch. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:45:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:45:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27983] New: Explicitly include limits.h header when using INT_MAX and INT_MIN Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27983 Summary: Explicitly include limits.h header when using INT_MAX and INT_MIN Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Platform AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ben at meyerhome.net Explicitly include limits.h header when using INT_MAX and INT_MIN to prevent build breakage when limits.h isn't included elsewhere by a port -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:46:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:46:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27983] Explicitly include limits.h header when using INT_MAX and INT_MIN In-Reply-To: References: Message-ID: <20090804144643.D6E61345B10E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27983 Benjamin Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34061| |review? Flag| | --- Comment #1 from Benjamin Meyer 2009-08-04 07:46:43 PDT --- Created an attachment (id=34061) --> (https://bugs.webkit.org/attachment.cgi?id=34061) the patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:47:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:47:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804144715.EBCDA345B136@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 --- Comment #3 from David Kilzer (ddkilzer) 2009-08-04 07:47:15 PDT --- (In reply to comment #2) > (From update of attachment 34051 [details]) > I think you're missing some files from this patch. :) Specifically: bugzilla_unittest.py committers_unittest.py And "commiters_unittest" is misspelled in run-bugzilla-tool-tests: > from modules.commiters_unittest import CommittersTest -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:50:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:50:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27983] Explicitly include limits.h header when using INT_MAX and INT_MIN In-Reply-To: References: Message-ID: <20090804145046.CA863345B1B2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27983 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34061|review? |review+ Flag| | --- Comment #2 from Adam Treat 2009-08-04 07:50:46 PDT --- (From update of attachment 34061) > From a82bc9d1cc1bb8aced54074bf3152c6f84ab560a Mon Sep 17 00:00:00 2001 > #include > +#include > #include Change the order of includes as is alphabetically first before and then r+. You can change this when landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:54:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:54:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27804] [Qt] QWebFrame::requestedUrl method can mis-behave in case of unhandled sslErrors. In-Reply-To: References: Message-ID: <20090804145401.BDF69345B22C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27804 Antonio Gomes (tonikitoo) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34062| |review? Flag| | Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |tonikitoo at gmail.com |kit.org | --- Comment #4 from Antonio Gomes (tonikitoo) 2009-08-04 07:54:01 PDT --- Created an attachment (id=34062) --> (https://bugs.webkit.org/attachment.cgi?id=34062) v0.2 - fix + autotest added an autotest for the case. in the autotest, it forces a SSLError to be catch and check if the requestedUrl value matches the expected. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:58:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:58:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27893] run-webkit-tests Skipped Only mode includes tests that are skipped by other flags. In-Reply-To: References: Message-ID: <20090804145840.03FBB345B2AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27893 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34059|review? |review- Flag| | --- Comment #6 from Adam Treat 2009-08-04 07:58:39 PDT --- (From update of attachment 34059) > +2009-07-31 Mike Fenton > + > + Reviewed by NOBODY (OOPS!). > + > + Change --skipped=only mode to use $ignoreDirectories to only > + run tests that configured by the script, or by the default > + values used in the script. I think the ChangeLog could do a better job of explaining what is happening here. Basically, you want --skipped=only to honor the --no-http flag. That is not currently happening. If I understand things correctly, your patch explicitly fixes this by making --skipped=only honor the ignoreDirectories, one of which is 'http' if --no-http is passed. Spell this out as the explicit goal in the ChangeLog and how it was accomplished. Also, it is not clear to me that this patch accomplishes what the bug report says it does: to make --skipped=only honor *all* other flags. It seems that this bugfix was rather narrowly tailored to --no-http. Which is fine! But it is good to be clear about this. > +sub ignoreFileByDirectory { > + my($filePath) = @_; > + foreach my $ignoredDir (keys %ignoredDirectories) { > + if ($filePath =~ m/^$ignoredDir/) { > + return 1; > + } > + } Perhaps 'fileShouldBeIgnored' instead to be more descriptive? r- for ChangeLog mostly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 07:59:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 07:59:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27983] Explicitly include limits.h header when using INT_MAX and INT_MIN In-Reply-To: References: Message-ID: <20090804145918.31739345B2CE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27983 Benjamin Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:13:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:13:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27885] Add QNX as supported platform In-Reply-To: References: Message-ID: <20090804151338.0CF44345B428@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27885 --- Comment #1 from Simon Hausmann 2009-08-04 08:13:37 PDT --- (From update of attachment 33880) The patch looks good to me, but I'm wondering about the hunk below: > @@ -544,8 +567,9 @@ static inline void* currentThreadStackBa > #endif > int rc = pthread_attr_getstack(&sattr, &stackBase, &stackSize); > (void)rc; // FIXME: Deal with error code somehow? Seems fatal. > - ASSERT(stackBase); > pthread_attr_destroy(&sattr); > +#endif > + ASSERT(stackBase); > stackThread = thread; > } > return static_cast(stackBase) + stackSize; Why did you move the ASSERT? :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:13:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:13:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27885] Add QNX as supported platform In-Reply-To: References: Message-ID: <20090804151355.207BC345B440@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27885 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hausmann at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:14:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:14:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27538] Qt memory consumption on site with many images In-Reply-To: References: Message-ID: <20090804151400.8F71A345B44A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27538 --- Comment #16 from Holger Freyther 2009-08-04 08:13:59 PDT --- (In reply to comment #15) > Any update on these patches? Holger, why are these patches not up for review? Look at what you said at comment #8. Besides that there are some things I want to and need to do first.. 1.) finish unrelated paid work.. 2.) be able to measure the change. 2.1) measure total memory comsumption, measure peak. 2.2) measure time to go through a benchmark of loading and rendering pages with images. 2.3) setup testing so everyone can redo these benchmarks. For 2nd) I have landed two benchmark tests, we need a system to collect and compare the data though, hook up memprof or memusage... have you seen the chromium system? we need something like this too and now is the time to have it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:20:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:20:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804152053.7420C345B50C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |treat at kde.org --- Comment #3 from Adam Treat 2009-08-04 08:20:52 PDT --- I have grave doubts about the ability of this to work for all static pointers. In particular I think the global static AtomicStrings in HTMLNames will cause problems. Before seeing something like this go in I'd want to see it work for all the global statics and know that it wouldn't be a maintenance burden to keep it working when new ones are added or the order of them changed, etc. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:23:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:23:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804152355.89FD2345B554@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |levin at chromium.org --- Comment #4 from David Levin 2009-08-04 08:23:53 PDT --- How about making it all just a bugzilla-tool command (e.g bugzilla-tool self-test) or naming it bugzilla-tool-tests so that it will sort right next to bugzilla-tool. I learned about several tools by going through the files in this directory. Note that you can put imports inside of a block, if you're concerned about globally importing the unit test items. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:27:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:27:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27893] run-webkit-tests Skipped Only mode includes tests that are skipped by other flags. In-Reply-To: References: Message-ID: <20090804152735.72BD8345B5C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27893 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34059|0 |1 is obsolete| | Attachment #34064| |review? Flag| | --- Comment #7 from Mike Fenton 2009-08-04 08:27:34 PDT --- Created an attachment (id=34064) --> (https://bugs.webkit.org/attachment.cgi?id=34064) Updated changeLog and rename of function. This patch makes the suggested changes to the previous patch. 1) Rename the function. 2) Update the changelog to more clearly identify the reason for the change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:35:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:35:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27893] run-webkit-tests Skipped Only mode includes tests that are skipped by other flags. In-Reply-To: References: Message-ID: <20090804153506.19084345B6BB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27893 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34064|review? |review+, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:38:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:38:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090804153837.13F75345B720@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34065| |review? Flag| | --- Comment #9 from Yong Li 2009-08-04 08:38:36 PDT --- Created an attachment (id=34065) --> (https://bugs.webkit.org/attachment.cgi?id=34065) remove the change to setLetterSpacing() -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:39:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:39:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090804153927.8E8AF345B76E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 --- Comment #10 from Yong Li 2009-08-04 08:39:27 PDT --- (In reply to comment #8) > (From update of attachment 34012 [details]) > > +#if PLATFORM(WINCE) > > + // Some sites set the spacing to -1 to make text more compact. But WinMobile already > > + // compacts the text to save on screen space, so this makes it overlap. If the spacing is > > + // negative, widen is slightly to counteract this. > > + void setLetterSpacing(short s) { m_letterSpacing = s < 0 ? s + 1 : s; } > > +#else > > I don?t think this is the right place to make this platform-specific > adjustment. It will also affect computed style. This change has been removed from the patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:40:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:40:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804154028.C4F75345B795@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 --- Comment #5 from Eric Seidel 2009-08-04 08:40:27 PDT --- Agreed, this is probably easiest done as a bugzilla-tool command. Unless we're going to make it run all the unit tests in modules. Also, I need to fix commiters_unittest, I realized shortly after I committed it that I misspelled the file name. :( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:42:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:42:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090804154237.C53F1345B7DF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 --- Comment #9 from Carol Szabo 2009-08-04 08:42:36 PDT --- I chose Mozilla's behavior because it would yield the same item selected after reset as it was when the form first loaded and it was conforming to the spec. If I were to choose IE's behavior I would have either caused a different option to be selected after reset than after load or I would have had to change the behavior at page load also. As Ian 'Hixie' commented, my choice seems to match the behavior specified for load, assuming that options are viewed as added in textual order to the select element. In my humble opinion the case my patch is trying to address is an unusual and unimportant case anyway. It deals with a web page that is coded incorrectly. The biggest problem the bug caused is confusion on the user that the selection box may allow multiple selection. Choosing any single value after reset would have solved that. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:43:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:43:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27973] REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs In-Reply-To: References: Message-ID: <20090804154343.109CB345B81D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27973 --- Comment #8 from Eric Seidel 2009-08-04 08:43:41 PDT --- The comma is the tuple operator in python. So I assume print detects this by detecting if it's passed a list/tuple instead of a string. http://mail.python.org/pipermail/python-list/2005-July/332230.html talks more about this strange behavior. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:44:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:44:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27984] New: cpp_style.py lacks checks for pointer and reference declaration style. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27984 Summary: cpp_style.py lacks checks for pointer and reference declaration style. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mike.fenton at torchmobile.com CC: treat at kde.org Based on webkit style guidelines the following pointer declaration is correct. TypeName* variableName; where as TypeName *variableName; is not. The same applies to reference. cpp_style.py requires an update to correct test for these two style guidelines. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:46:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:46:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27985] New: ASSERTION FAILED: m_frame->document()->parsing() Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27985 Summary: ASSERTION FAILED: m_frame->document()->parsing() Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: Kelemen.Balazs.3 at stud.u-szeged.hu ASSERTION FAILED: m_frame->document()->parsing() (../../../WebCore/loader/FrameLoader.cpp:1778 void WebCore::FrameLoader::addData(const char*, int)) When I run QtLauncher as QtLauncher -r a_big_url_list, it always hits this assert. In a specific order of the urls in the file it asserts at the same url. If I load that url on it's own it is not asserting. If I reorder the urls in the list it asserts on a different url. Strange... In Release builds, the symptom is that the page stops loading. I do not know if it is a qtwebkit related problem or an internal one. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:50:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:50:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804155021.9C952345B8E5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34057|review? | Flag| | Attachment #34057|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:50:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:50:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804155026.63C1F345B8F2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34066| |review? Flag| | --- Comment #4 from Shinichiro Hamaji 2009-08-04 08:50:25 PDT --- Created an attachment (id=34066) --> (https://bugs.webkit.org/attachment.cgi?id=34066) Patch v3 --- 9 files changed, 96 insertions(+), 4 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:50:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:50:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27985] ASSERTION FAILED: m_frame->document()->parsing() In-Reply-To: References: Message-ID: <20090804155039.75348345B8FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27985 --- Comment #1 from Kelemen Bal?zs 2009-08-04 08:50:38 PDT --- Created an attachment (id=34067) --> (https://bugs.webkit.org/attachment.cgi?id=34067) Url list - for reproducing the bug Unfortunately reproducing need much time. The assert raise at the 81th url for me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:51:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:51:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27985] ASSERTION FAILED: m_frame->document()->parsing() In-Reply-To: References: Message-ID: <20090804155110.05DBA345B90F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27985 Kelemen Bal?zs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hausmann at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:51:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:51:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090804155158.0AA9A345B92F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34060|review?(eric at webkit.org) |review- Flag| | --- Comment #21 from Eric Seidel 2009-08-04 08:51:56 PDT --- (From update of attachment 34060) I wasn't clear, sorry. I agree that JS should be default. I just wanted all the places where you assumed !JS was Gdom to turn into explicit GDom checks. passing no --bindingType can/should default to JS. Otherwise you'd have to change lots more files here. :) 327 if ($binding eq 'Gdom') { 328 # skip DATAGRID for now 329 next if ($conditional eq 'DATAGRID'); 330 } Those can all go away if you just remove DATAGRID from the list of tags at the start, no? Removing it once instead of skipping it in every for loop seems like a cleaner solution, or? Also, don't you all have ENABLE_DATAGRID off anyway? Won't make_names just print #defines around all the DATAGRID stuff which will be compiled out? $F really should have a better name, per our style guidelines: http://webkit.org/coding/coding-style.html. Since you're just moving existing code, I guess it's OK as is though. So the GNUMakefile.am changes are fine, but not required if you restore the JS default. This in general looks great. I think we still can fix the DATAGRID with a cleaner hack. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:52:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:52:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804155246.B8D4A345B943@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 David Kilzer (ddkilzer) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |ddkilzer at webkit.org Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:52:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:52:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804155254.2ED5E345B951@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 --- Comment #5 from Shinichiro Hamaji 2009-08-04 08:52:53 PDT --- Sorry, I forgot to add the html file of layout test and the change of expected results. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:56:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:56:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27952] cssgrammar.cpp fails to compile with RVCT compiler In-Reply-To: References: Message-ID: <20090804155631.D1625345B9C2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27952 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34033|review? |review- Flag| | --- Comment #2 from Eric Seidel 2009-08-04 08:56:31 PDT --- (From update of attachment 34033) This is going to copy the string. that's an extra malloc during parsing, and likely a slowdown. :( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:59:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:59:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804155934.965F4345BA26@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #4 from David Kilzer (ddkilzer) 2009-08-04 08:59:33 PDT --- I think enabling/disabling static pointer destruction should also be controllable by a runtime option as well (once enabled with the compile-time option). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 08:59:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 08:59:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27986] New: sunspider contains error on --parse-only path Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27986 Summary: sunspider contains error on --parse-only path Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: andhow at gmail.com Running 'sunspider --shell=$(MYSHELL) --parse-only' produces empty results. I traced the error down to an undefined reference in sunspider-standalone-driver.js, line 36, which contains an undefined reference to 'checkSyntax'. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:06:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:06:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804160637.C8DD4345BAF0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #5 from Eric Seidel 2009-08-04 09:06:36 PDT --- if I remember correctly, Mac OS X's "leaks" tool, correctly ignores static pointer leaks. Can't valgrind do the same? with DEFINE_STATIC_LOCAL we even put them all into a custom section, which should make them super-easy to ignore. ;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:08:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:08:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090804160857.A15E6345BB51@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33820|review? | Flag| | Attachment #33820|0 |1 is obsolete| | Attachment #34068| |review? Flag| | --- Comment #25 from Yong Li 2009-08-04 09:08:56 PDT --- Created an attachment (id=34068) --> (https://bugs.webkit.org/attachment.cgi?id=34068) 7) Color, Gradient, Image call startAnimation() first -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:12:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:12:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804161205.67853345BBB7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34066|review? |review+ Flag| | --- Comment #6 from Eric Seidel 2009-08-04 09:12:05 PDT --- (From update of attachment 34066) Looks good to me. We could probably even make this a dumpAsText test. But this is also OK as is. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:13:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:13:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090804161353.DEBF5345BC13@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 --- Comment #26 from Yong Li 2009-08-04 09:13:52 PDT --- (In reply to comment #24) Yes, the image frame sink stuff is a very big change. We tried to separate it out to avoid affecting other platforms badly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:14:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:14:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27955] let check-webkit-style look at changes staged in the git index In-Reply-To: References: Message-ID: <20090804161459.AA7D5345BC45@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27955 --- Comment #5 from Joe Mason 2009-08-04 09:14:58 PDT --- Oops, sorry. Should have updated before working on this. I think this approach is still needed with the latest version, though. "Does --git-commit=HEAD work for you?" No, that doesn't do quite what I want. "The problem with adding --git-index is that it won't work well if you've done changes locally that aren't in the index. For example, suppose you change lines 10-14 in the index and then delete lines 5-9 in your local file system. The checker uses the local files so it gives you style messages for lines 10-14 in the local file which is wrong." Actually, I just realized that this isn't a bug, it's exactly what I want it to do! The reason is that when I go to fix the file, I'll be editing the local version. I care about which lines the errors are on in the local version, not what's staged to the index. (I just don't want to get warnings about changes that aren't staged yet.) Consider the following example: I'm working on a feature that involves adding a 5 line function to the beginning of file A, and making various changes to file B. It's not finished yet, when I get an urgent request to rewrite an unrelated function in file A. I make changes to lines 100-105 in file A (which, because of my 5 lines added earlier, correspond to lines 95-100 in HEAD, which is the upstream version of the file). I use "git add -i" to stage only lines 100-105 of file A to the index, and run check-webkit-style. Ideally I want it to only give errors for the changes acually in the index, because that's all that I'm going to commit. --git-commit=HEAD will check all changes between HEAD and the working copy, including all the ones I haven't added to the index. I think I could use a list of files to check only file A, but it would still look at both changes in that file. --git-index would look only at the changes in the index. So far so good. Now, if it found a problem on the second line of my patch (that's line 96 in the index, line 101 in my working copy), what line should it report that on? Well, I'm going to fix it by editing my working copy, and then adding the new change to the index with "git add -i" again. So line 101 is more useful. Which is immaterial as I can't actually get it to work with the new version: git diff --cached reports lines numbers relative to the index, so an error message on line 101 is just filtered out because it doesn't appear in the diff. (This probably happened in the old version too and I just didn't test enough.) So --git-commit=HEAD and manually filter out the changes I don't care about will have to do for now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:18:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:18:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26916] bugzilla-tool needs unit tests (scm_unittest.py and bugzilla_unittest.py) In-Reply-To: References: Message-ID: <20090804161805.90B72345BCA7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26916 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|bugzilla-tool needs PyUnit |bugzilla-tool needs unit |testing. |tests (scm_unittest.py and | |bugzilla_unittest.py) --- Comment #1 from Eric Seidel 2009-08-04 09:18:04 PDT --- I've added a few tests. I'll keep this around for adding the scm_unittest.py (which are the tricky ones). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:19:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:19:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27955] let check-webkit-style look at changes staged in the git index In-Reply-To: References: Message-ID: <20090804161920.CD854345BCD3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27955 Joe Mason changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:23:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:23:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27955] let check-webkit-style look at changes staged in the git index In-Reply-To: References: Message-ID: <20090804162306.24AD1345BD52@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27955 Joe Mason changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34006|0 |1 is obsolete| | --- Comment #6 from Joe Mason 2009-08-04 09:23:05 PDT --- Created an attachment (id=34069) --> (https://bugs.webkit.org/attachment.cgi?id=34069) patch to latest check-webkit-style - does not deal well with added/removed lines not in index Attaching my latest (nonworking) patch for reference. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:30:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:30:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804163025.8D497345BDFA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 --- Comment #7 from Shinichiro Hamaji 2009-08-04 09:30:25 PDT --- (In reply to comment #6) > (From update of attachment 34066 [details]) > Looks good to me. We could probably even make this a dumpAsText test. But > this is also OK as is. This test is checking if scrollbar exists (if the size of reflected images are considered, the scrollbar should apprear). I think this kind of test can be done by dumpAsText test. Or, can we get overflowWidth from JavaScript? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:31:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:31:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804163140.A9B2E345BE28@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #6 from Zoltan Herczeg 2009-08-04 09:31:39 PDT --- (In reply to comment #4) I think this would be an easy feature since WTF::StaticPtrBase::freeStaticPtrs() must be called from the code itself. With a runtime option we can easly prevent the call of this function. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:36:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:36:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090804163652.8A141345BEB4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23154 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:38:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:38:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804163845.3A5F3345BEF9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #7 from Zoltan Herczeg 2009-08-04 09:38:44 PDT --- (In reply to comment #5) The problem is with the transitive allocations. Valgrind does not track the use of 'this' pointers. Let A be a static object, and it allocates a B object, which also allocates a C object. A()->B()->C() In this case valgrind cannot see that B and C are belongs to the A object, and report them as memory errors. Perhaps it would be too time consuming to detect these situations. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:42:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:42:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804164221.F2CC9345BF72@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 --- Comment #6 from Adam Barth 2009-08-04 09:42:20 PDT --- I'm confused about what I should do to move forward with this patch. The "missing files" are already in the repo. The misspelling is already there too. I guess I could rename the file in the same patch. Do we want to make this a bugzillatool command? I was thinking we'd want to integrate the testing with the buildbot and I'm not sure how to make that easiest. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:46:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:46:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27955] let check-webkit-style look at changes staged in the git index In-Reply-To: References: Message-ID: <20090804164646.23801345BFEC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27955 --- Comment #7 from David Levin 2009-08-04 09:46:44 PDT --- I think you got it. The key problem is that error messages will be filtered according to the lines in the patch, but those lines may have moved in the current file. A patch that says only line 10 changed will only get error messages for that line even though that line is now at line 16 in your local file system. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:47:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:47:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27305] [WINCE] add WinCE-specific unicode implementation In-Reply-To: References: Message-ID: <20090804164711.39C37345C000@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27305 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34014|review? |review- Flag| | --- Comment #8 from Eric Seidel 2009-08-04 09:47:10 PDT --- (From update of attachment 34014) I don't think we should check in these generated files. I think the wince port should use a support library instead to follow the model of the other ports in the tree. Alternatively, we could find a way to generate these files at compile time. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:49:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:49:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27305] [WINCE] add WinCE-specific unicode implementation In-Reply-To: References: Message-ID: <20090804164940.C243B345C05A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27305 --- Comment #9 from Eric Seidel 2009-08-04 09:49:40 PDT --- (From update of attachment 34013) The project isn't KJS anymore. :) KJS_UNICODE_WINCE_H Do we know the ICU license to be compatible with WebCore? Why is it OK to re-license ICU code under LGPL as you seem to have done? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:50:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:50:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804165059.3970D345C080@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 --- Comment #7 from Eric Seidel 2009-08-04 09:50:58 PDT --- Ignore the mispelling and dave's confusion about the missing files. I think this should be either made into a general "run all the unit tests we have" command, or a self-test command on bugzilla. Either way is fine with me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:52:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:52:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804165209.79594345C0AA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34066|review+ | Flag| | Attachment #34066|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:52:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:52:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804165213.ADDA4345C0B1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34071| |review? Flag| | --- Comment #8 from Shinichiro Hamaji 2009-08-04 09:52:13 PDT --- Created an attachment (id=34071) --> (https://bugs.webkit.org/attachment.cgi?id=34071) Patch v4 --- 8 files changed, 106 insertions(+), 4 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:53:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:53:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27255] Geolocation incorrectly calls error callback in case of exception in success callback In-Reply-To: References: Message-ID: <20090804165305.B33C1345C0DD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27255 Greg Bolsinga changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #6 from Greg Bolsinga 2009-08-04 09:53:05 PDT --- (In reply to comment #5) > It can, of course, happen that the success callback throws an exception but I > think this is a problem with the user code and not the Geolocation API > implementation. As such, error callback should not be invoked. Instead, I think > an error event should be raised and window.onerror should be invoked (if > defined) or the error should be logged to the JS console. Great. I think the code already will report the exception in that way, so this patch implements what you describe above. I'm not a reviewer, however. I'm going to move the bug to "NEW", in hope it gets reviewed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:53:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:53:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090804165347.88EE4345C0FE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 --- Comment #9 from Shinichiro Hamaji 2009-08-04 09:53:47 PDT --- > This test is checking if scrollbar exists (if the size of reflected images are > considered, the scrollbar should apprear). I think this kind of test can be > done by dumpAsText test. Or, can we get overflowWidth from JavaScript? Ah, I've found the way. I could change the position of scroll bar to see if the scroll bar is working. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:54:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:54:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27984] cpp_style.py lacks checks for pointer and reference declaration style. In-Reply-To: References: Message-ID: <20090804165411.7FB53345C10B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27984 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34072| |review? Flag| | --- Comment #1 from Mike Fenton 2009-08-04 09:54:10 PDT --- Created an attachment (id=34072) --> (https://bugs.webkit.org/attachment.cgi?id=34072) Patch for cpp_style.py to check for pointer and reference marker placement. Patch checks for TypeName *variableName. In order to eliminate false positives, and added check to see if an = sign comes before the * or & has been added to eliminate matches like. int a = b * c; -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 09:56:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 09:56:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804165654.11EB4345C149@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Kelemen Bal?zs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Kelemen.Balazs.3 at stud.u-sze | |ged.hu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 10:08:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 10:08:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27988] New: word-spacing style seems not to be honored Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27988 Summary: word-spacing style seems not to be honored Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.w3.org/Style/CSS/Test/CSS1/current/sec541.h tm OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: carol.szabo at nokia.com Apparently the word-spacing style is ignored. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 10:10:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 10:10:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090804171001.CF997345C2D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Jay Campan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcampan at google.com --- Comment #6 from Jay Campan 2009-08-04 10:10:00 PDT --- Some answers: >1. why all those browsers either assume the popup item's directionality as LTR >or based on heuristics? Is there any specific reason? Should the popup item be >displayed using the input field's directionality? I am not sure why that is the behavior of all browsers. It suspect just like in Chrome this is just not implemented and defaults to LTR. I think that the popup item should be using the input field's directionality. >2. What should be the correct behavior in Mac, should I leave Chrome as it is >to be consistent with Safari in Mac. Or should I change it to be the same as >FireFox in Mac? (FireFox always do text truncation to keep the item width the >same as input field width, and it always assumes text item as LTR >directionality, no matter in Windows or Mac)? How about Linux? I think Chrome on all platforms should limit the size of the popup to the size of the input field and use truncation. >3. Jay mentioned that we do not want to restrict the width of combo-box >( combobox. So we want different behavior for the 2 cases: combox, no width restriction, autofill, width restricted to the input field's width. The directionality of the combobox should be consistent with field's directionality as well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 10:16:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 10:16:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804171623.D2059345C364@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 --- Comment #8 from Adam Barth 2009-08-04 10:16:22 PDT --- (In reply to comment #7) > I think this should be either made into a general "run all the unit tests we > have" command, or a self-test command on bugzilla. Either way is fine with me. Running all the unit tests seems more future-proof to me. I'll update the patch in a bit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 10:20:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 10:20:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804172052.840A2345C3FB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 --- Comment #9 from David Kilzer (ddkilzer) 2009-08-04 10:20:51 PDT --- (In reply to comment #7) > Ignore the mispelling and dave's confusion about the missing files. Sorry, I was looking at an outdated repository. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 10:24:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 10:24:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27952] cssgrammar.cpp fails to compile with RVCT compiler In-Reply-To: References: Message-ID: <20090804172443.42F57345C487@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27952 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |darin at apple.com Platform|PC |All AssignedTo|webkit-unassigned at lists.web |laszlo.1.gombos at nokia.com |kit.org | Ever Confirmed|0 |1 --- Comment #3 from Darin Adler 2009-08-04 10:24:42 PDT --- (In reply to comment #2) > (From update of attachment 34033 [details]) > This is going to copy the string. that's an extra malloc during parsing, and > likely a slowdown. :( The old code already copies the string. This is bad. The best fix that fixes both compiling and improves performance is to create a charactersEqualIgnoringCase function that works with a character pointer and length. This would be like the other "characters" functions in PlatformString.h. We could also overload equalIgnoringCase for CSSParserString; that would just be a convenience that would make it slightly easier to read. Code to do this is already present in StringImpl.cpp; it should be relatively straightforward to refactor it. In the mean time I actually see nothing wrong with Laszlo's initial patch, except that there is a stray space after "selector". But I'd love it if we could get rid of the stray memory allocation here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 10:26:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 10:26:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090804172634.8B832345C4B9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #10 from Darin Adler 2009-08-04 10:26:33 PDT --- (In reply to comment #9) > I chose Mozilla's behavior because it would yield the same item selected after > reset as it was when the form first loaded and it was conforming to the spec. Since Mozilla's behavior matches both what HTML5 specifies and what value we would have when the page was first loaded, then it seems like the right thing to do, even though it does not match IE. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 10:31:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 10:31:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090804173154.251B9345C54F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34007|review? |review- Flag| | --- Comment #11 from Darin Adler 2009-08-04 10:31:52 PDT --- (From update of attachment 34007) This patch looks wrong. As written all it does is rename the boolean to "isOptionSelected" and add a new, never-used "selectedOption". > + selectedOption=optionElement; Missing spaces around the "=" here. > + > \ No newline at end of file Please add the newline. > Property changes on: LayoutTests/fast/forms/select-reset-multiple-selections-4-single-selection.html > ___________________________________________________________________ > Added: svn:executable > + * Please don't check in executable .html files. You can fix this by using chmod -x before adding the file to Subversion, or svn pd svn:executable after adding the file to Subversion. review- because the code change as posted doesn't seem to do anything! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 10:43:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 10:43:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090804174346.283B4345C6AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 --- Comment #27 from Peter Kasting 2009-08-04 10:43:45 PDT --- (In reply to comment #26) > Yes, the image frame sink stuff is a very big change. We tried to separate it > out to avoid affecting other platforms badly. FWIW, I'm in the midst of actively working on the Image subsystem, and I have speculative plans to split RGBA32Buffer out of ImageDecoder.h, rename it, and move it to graphics/ in a week or two. That might make it slightly easier to modify so that it will work for WinCE too (or it might not help much, not sure). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 10:49:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 10:49:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27989] New: AX: textUnderElement() should use a TextIterator instead of concatenating nodes Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27989 Summary: AX: textUnderElement() should use a TextIterator instead of concatenating nodes Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cfleizach at apple.com Generally speaking it seems that the textUnderElement ought to contain the same kind of whitespace-collapsing logic that the normal rendering code does. This could be done by using the TextIterator instead of walking the nodes and concatenating them all. Not sure what bug it will cause that this just appends the DOM, but I suspect it will cause problems, especially when there are -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 10:50:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 10:50:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27989] AX: textUnderElement() should use a TextIterator instead of concatenating nodes In-Reply-To: References: Message-ID: <20090804175002.35BD1345C73E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27989 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |cfleizach at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:00:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:00:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27984] cpp_style.py lacks checks for pointer and reference declaration style. In-Reply-To: References: Message-ID: <20090804180029.15E8A345C829@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27984 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |levin at chromium.org Ever Confirmed|0 |1 --- Comment #2 from David Levin 2009-08-04 11:00:27 PDT --- It would be good to run over the current code base (or at least WebCore/dom, WebCore/css) to check for false positives. Maybe it should use parenthesis also as a clue. myFunction(a * b); Of course, there is the counter example, for (int* a = ptr;... but I suspect this is more rare. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:00:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:00:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18456] segmentation fault crash on Acid3 test 64 and 79 under Linux In-Reply-To: References: Message-ID: <20090804180048.39A88345C839@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18456 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |krit at webkit.org Resolution| |WORKSFORME --- Comment #15 from Dirk Schulze 2009-08-04 11:00:45 PDT --- It works for me too and I haven't heard of crashes for a long time now. Please reopen the bug if someone still see a crash. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:01:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:01:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090804180154.4B4B4345C877@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #1 from Darin Adler 2009-08-04 11:01:52 PDT --- My first thought is that given this understanding we must be able to create a test case that demonstrates the deadlock. Can we do this? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:05:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:05:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090804180518.E61B0345C8DE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #2 from Dumitru Daniliuc 2009-08-04 11:05:17 PDT --- Created an attachment (id=34075) --> (https://bugs.webkit.org/attachment.cgi?id=34075) test case that demonstrates the problem (In reply to comment #1) > My first thought is that given this understanding we must be able to create a > test case that demonstrates the deadlock. Can we do this? yes. attached. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:08:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:08:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27984] cpp_style.py lacks checks for pointer and reference declaration style. In-Reply-To: References: Message-ID: <20090804180843.AE96C345C96A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27984 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34072|review? |review- Flag| | --- Comment #3 from David Levin 2009-08-04 11:08:42 PDT --- (From update of attachment 34072) This needs unit tests (added to cpp_style_unittests.py) Also, you could combine the regex and put them in a (named) group and then use the result from the group in the printed error message. Lastly, this guideline only applies to C++ code. The tool also runs on C files and the guideline is reversed in that case. (int *i;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:13:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:13:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090804181325.52C4C345CA26@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 --- Comment #28 from Yong Li 2009-08-04 11:13:24 PDT --- (In reply to comment #27) > (In reply to comment #26) > > Yes, the image frame sink stuff is a very big change. We tried to separate it > > out to avoid affecting other platforms badly. > > FWIW, I'm in the midst of actively working on the Image subsystem, and I have > speculative plans to split RGBA32Buffer out of ImageDecoder.h, rename it, and > move it to graphics/ in a week or two. That might make it slightly easier to > modify so that it will work for WinCE too (or it might not help much, not > sure). It's good to split RGBA32Buffer out, create more generic interface as image decoding buffer, and allow different implementations for different ports or products. Actually our ImageFrameSink is such an interface, and it should be very easy to implement ImageFrameSink with current RGBA32Buffer or Vector. Would you please consider making new RGBA32Buffer as close to ImageFrameSink.h as possible? That could make merging my code easier :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:25:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:25:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090804182541.CBC32345CB43@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 --- Comment #29 from George Staikos 2009-08-04 11:25:41 PDT --- (In reply to comment #28) > It's good to split RGBA32Buffer out, create more generic interface as image > decoding buffer, and allow different implementations for different ports or > products. Actually our ImageFrameSink is such an interface, and it should be > very easy to implement ImageFrameSink with current RGBA32Buffer or > Vector. Would you please consider making new RGBA32Buffer as close to > ImageFrameSink.h as possible? That could make merging my code easier :) If Peter wants to have this, and your patch provides this, then breaking it out into a separate patch should be sufficient to solve everyones' problems I think. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:33:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:33:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26715] bugzilla-tool should automate rollouts In-Reply-To: References: Message-ID: <20090804183343.69411345CC0D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26715 --- Comment #10 from Eric Seidel 2009-08-04 11:33:41 PDT --- Some testing code for later: def _parse_revision_to_commit_mappings(self, stderr): revision_to_commit_mapping = {} for line in stderr.split_lines(): match = line.match("^(?Pr\d+) = (?P\w+)$") if match: revision_to_commit_mapping[match.group('revision')] = match.group('commit_id') return revision_to_commit_mapping -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:37:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:37:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27893] run-webkit-tests Skipped Only mode includes tests that are skipped by other flags. In-Reply-To: References: Message-ID: <20090804183743.33933345CC99@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27893 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34064|commit-queue? |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:40:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:40:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804184003.08BFD345CD16@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34058|review? |review- Flag| | --- Comment #8 from Darin Adler 2009-08-04 11:40:01 PDT --- (From update of attachment 34058) I think it's a good idea to make our globals more consistent. But probably not such a great idea to start what could be a massive project without a good idea how we'll keep test this and keep it working as each global is added. Is the goal here to make memory leak debugging tools work better? Or is there value beyond that? Could you write a document about how to use StaticPtr correctly? I'd like to review that to get an idea how we would make sure we were using it properly on various platforms. Would we consider it a coding style violation to make a global that doesn't use StaticPtr? As part of this are you proposing that DEFINE_STATIC_LOCAL be the only legal way to make global variables? I do not want to sign up everyone on the project to write a lot of code to deallocate every last object if this code isn't actually useful to someone on one of the ports. I need to hear more justification about why to take on all this additional complexity. Making all the global data structures practical to delete is an enormous task that this patch barely scratches the surface of. An excellent economy in the project at the moment is that we don't try to write all the deallocation code for all the global objects. > wtf/RefCountedLeakCounter.cpp \ > wtf/TypeTraits.cpp \ > + wtf/StaticPtr.cpp \ > wtf/unicode/CollatorDefault.cpp \ I believe this is supposed to be in alphabetic order, so it should come before TypeTraits.cpp. > +#include "config.h" > + > +#include "StaticPtr.h" Extra blank line here. > + StaticPtrBase() { > +#if ENABLE(FREE_STATIC_PTRS) > + m_next = head(); > + m_head = this; > +#endif > + }; Extra semicolon here. I think this would might read better if the inline implementation was outside the class definition since it has an #if in it. There's no reason we have to have the ifdef in here. But a better alternative would be to just leave out the constructor definition entirely when FREE_STATIC_PTRS is not enabled. If there are no constructor definitions then the class automatically will have an empty default constructor which is what we want. > + StaticPtr(PtrType ptr) : StaticPtrBase(), m_ptr(ptr) { }; > + StaticPtr() : StaticPtrBase(), m_ptr(0) { }; > + ~StaticPtr() { }; No need to explicitly initialize StaticPtrBase since there are no constructor arguments. Extra semicolons here. No need to explicitly declare the destructor -- this is the same as the compiler-generated constructor and it's much better style to not declare it. > + PtrType operator=(PtrType); This seems like bad style. Since values stored in this pointer will be freed, I think we want this to use some explicit style like OwnPtr rather than plain assignment. > + ValueType& operator=(ValueType&); This seems quite strange. Why do we need to allow assignment to the pointer of a non-const pointer of value type? This seems very dangerous, since the value type will later be destroyed. > + PtrType operator&(); > + PtrType operator&() const; Do we need this operator? What coding style is going to require this? > + // Condition operators > + bool operator!(); Should be const. Please look at OwnPtr for some ideas on how to make this class work. This should be much closer to OwnPtr which has exactly the same semantic. > +protected: I believe these members should be private, not protected. > +#if !PLATFORM(QT) > delete data; > +#endif This seems clearly wrong. Did you mean this to be a FREE_STATIC_PTRS ifdef? > + StaticGlobalData() : WTF::StaticPtr() { }; This constructor is entirely unnecessary. > +protected: Should be private, not protected. > +#if ENABLE(FREE_STATIC_PTRS) > + virtual void free() { > + m_ptr->heap.destroy(); > + delete m_ptr; > + } > +#endif Incorrect brace style here. > +ALWAYS_INLINE JSGlobalData* StaticGlobalData::operator=(JSGlobalData* value) > +{ > + m_ptr = value; > +} Seems poor to use plain assignment of a raw pointer for an operation that transfers ownership. > - return globalData; > + return &globalData; This line of code seems wrong. You want a JSGlobalData*, not a StaticGlobalData*. This is a poor use of operator overloading. review- for now based on the specific problems with the patch, but I do also have project-direction concerns here, although I am not using reviewer power to try to enforce those. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:40:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:40:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 3749] XHTML 1.1 Ruby Annotation In-Reply-To: References: Message-ID: <20090804184023.A19A1345CD36@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=3749 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abarth at webkit.org --- Comment #25 from Adam Barth 2009-08-04 11:40:21 PDT --- The commit queue might not be smart enough yet to handle multiple patches on the same bug, but we'll see. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:46:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:46:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090804184624.0D4D9345CDE4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 --- Comment #30 from Peter Kasting 2009-08-04 11:46:23 PDT --- (In reply to comment #28) > It's good to split RGBA32Buffer out, create more generic interface as image > decoding buffer, and allow different implementations for different ports or > products. The very first patch will just move it somewhere without changing the implementation. The next thing I'd like to do afterward is take a hard look at your ImageFrameSink and see if I can figure out how to add those capabilities to the existing cross-plaform code in a way that doesn't require tons of #ifdefs. > it should be > very easy to implement ImageFrameSink with current RGBA32Buffer Yes, one possibility before this functionality gets included directly (or perhaps in place of doing that?) would be to make your ImageFrameSink a subclass of this other class and simply extend it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:47:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:47:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804184728.B59BE345CE14@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26916 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:47:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:47:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26916] bugzilla-tool needs unit tests (scm_unittest.py and bugzilla_unittest.py) In-Reply-To: References: Message-ID: <20090804184730.94B23345CE30@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26916 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27977 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 11:58:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 11:58:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26916] bugzilla-tool needs unit tests (scm_unittest.py and bugzilla_unittest.py) In-Reply-To: References: Message-ID: <20090804185805.9212D345CF3C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26916 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34078| |review? Flag| | --- Comment #2 from Eric Seidel 2009-08-04 11:58:04 PDT --- Created an attachment (id=34078) --> (https://bugs.webkit.org/attachment.cgi?id=34078) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:06:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:06:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27893] run-webkit-tests Skipped Only mode includes tests that are skipped by other flags. In-Reply-To: References: Message-ID: <20090804190615.76CE0345CFFE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27893 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34064|review+ | Flag| | --- Comment #8 from Adam Barth 2009-08-04 12:06:14 PDT --- (From update of attachment 34064) Clearing review flag on attachment: 34064 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests Committed r46771 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests r46771 = 042145e38e9fb864caea4ce6b7799aa60e67b093 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46771 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:06:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:06:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27893] run-webkit-tests Skipped Only mode includes tests that are skipped by other flags. In-Reply-To: References: Message-ID: <20090804190618.DA408345D00E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27893 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |abarth at webkit.org Resolution| |FIXED --- Comment #9 from Adam Barth 2009-08-04 12:06:18 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:08:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:08:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27991] New: bugzilla_unitest.py needs to know how to run a local bugzilla instance Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27991 Summary: bugzilla_unitest.py needs to know how to run a local bugzilla instance Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: ddkilzer at webkit.org bugzilla_unitest.py needs to know how to run a local bugzilla instance I've never set up bugzilla before. :) But I do believe it should be possible for us to run a local instance from our python unit tests so that we can test the functions in bugzilla.py against a live instance. I ran ./BugsSite/checksetup.pl once to learn that we'll need a whole bunch of perl modules installed on any machine that wants to run bugzilla. :( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:08:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:08:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26916] bugzilla-tool needs scm unit tests In-Reply-To: References: Message-ID: <20090804190838.D5327345D07A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26916 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|bugzilla-tool needs unit |bugzilla-tool needs scm |tests (scm_unittest.py and |unit tests |bugzilla_unittest.py) | --- Comment #3 from Eric Seidel 2009-08-04 12:08:37 PDT --- I've broken off the bugzilla bits into bug 27991. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:10:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:10:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26916] bugzilla-tool needs scm unit tests In-Reply-To: References: Message-ID: <20090804191051.18D70345D0E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26916 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34078|review? |review+ Flag| | --- Comment #4 from Adam Barth 2009-08-04 12:10:49 PDT --- (From update of attachment 34078) This looks like a good start. We'll need to do more eventually, but I like the idea of building a fake repo in the tmp directory. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:11:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:11:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27991] bugzilla_unitest.py needs to know how to run a local bugzilla instance In-Reply-To: References: Message-ID: <20090804191117.4D074345D10C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27991 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27977 --- Comment #1 from Eric Seidel 2009-08-04 12:11:16 PDT --- This doesn't block bug 27977, but is related. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:11:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:11:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804191118.3F9C4345D11A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27991 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:17:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:17:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20329] CSS3 Box shadow property pushes outside the bounds of the page causing horizontal scrollbars In-Reply-To: References: Message-ID: <20090804191726.42B3E345D1EA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20329 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED CC| |hyatt at apple.com AssignedTo|webkit-unassigned at lists.web |hyatt at apple.com |kit.org | Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:17:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:17:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27569] [CSS3 Backgrounds and Borders] Tracking bug for spec compliance In-Reply-To: References: Message-ID: <20090804191750.4102C345D214@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27569 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20329 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:18:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:18:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26916] bugzilla-tool needs scm unit tests In-Reply-To: References: Message-ID: <20090804191816.22E12345D23A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26916 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Eric Seidel 2009-08-04 12:18:14 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/scm.py A WebKitTools/Scripts/modules/scm_unittest.py Committed r46772 M WebKitTools/ChangeLog A WebKitTools/Scripts/modules/scm_unittest.py M WebKitTools/Scripts/modules/scm.py r46772 = 2216d9a41da59a3e65c137e9fdd39b75776a7286 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46772 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:18:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:18:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804191817.90332345D252@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Bug 27977 depends on bug 26916, which changed state. Bug 26916 Summary: bugzilla-tool needs scm unit tests https://bugs.webkit.org/show_bug.cgi?id=26916 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:22:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:22:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804192231.7630A345D2FC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #9 from Zoltan Herczeg 2009-08-04 12:22:29 PDT --- (In reply to comment #8) > (From update of attachment 34058 [details]) > I think it's a good idea to make our globals more consistent. Thank you! > But probably not such a great idea to start what could be a massive project > without a good idea how we'll keep test this and keep it working as each global > is added. Totally agree. It is not my custom to submit a patch in such draft phase, but I feel this project is more about finding a way to define globals which everyone _likes_, than the actual code itself. I know this is risky, may never be a successful project, but it is worth a try, isn't it? :) I will fix typos and answer to all your questions tomorrow. Once again, thank you for your detailed feedback! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:27:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:27:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27993] New: AXSliders are missing required attributes and actions Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27993 Summary: AXSliders are missing required attributes and actions Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cfleizach at apple.com AXSliders are missing required attributes and actions. following attribute: AXOrientation and the following actions: AXIncrement AXDecrement -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:27:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:27:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27993] AXSliders are missing required attributes and actions In-Reply-To: References: Message-ID: <20090804192728.C0819345D3B4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27993 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |cfleizach at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 12:49:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 12:49:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26380] SVG Filters and big sized filterRegions In-Reply-To: References: Message-ID: <20090804194903.735F4345D626@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26380 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31267|0 |1 is obsolete| | Attachment #34081| |review? Flag| | --- Comment #4 from Dirk Schulze 2009-08-04 12:49:02 PDT --- Created an attachment (id=34081) --> (https://bugs.webkit.org/attachment.cgi?id=34081) big svg filter constant for maximum filter size. At ~3000x3000 px a difference at calculating is sensible. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:02:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:02:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090804200253.7D266345D7ED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #10 from David Kilzer (ddkilzer) 2009-08-04 13:02:51 PDT --- (In reply to comment #8) > (From update of attachment 34058 [details]) > I do not want to sign up everyone on the project to write a lot of code to > deallocate every last object if this code isn't actually useful to someone on > one of the ports. I need to hear more justification about why to take on all > this additional complexity. Making all the global data structures practical to > delete is an enormous task that this patch barely scratches the surface of. Being able to "reset" WebCore to its pre-cached-local-statics state would be useful for the iPhone OS port. We don't care about tearing down objects when exiting a process, but being able to clear out the cached static variables on-demand would be useful. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:04:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:04:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27991] bugzilla_unitest.py needs to know how to run a local bugzilla instance In-Reply-To: References: Message-ID: <20090804200425.58C89345D823@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27991 --- Comment #2 from David Kilzer (ddkilzer) 2009-08-04 13:04:24 PDT --- (In reply to comment #0) > I ran ./BugsSite/checksetup.pl once to learn that we'll need a whole bunch of > perl modules installed on any machine that wants to run bugzilla. :( You also need a database (PostgreSQL, MySQL or Oracle). Having bugs in the database would be handy as well, but you might be able to come up with a way to mirror a small subset of bugs from bugs.webkit.org with the WebServices API. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:07:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:07:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27490] Web Sockets Test Infrastructure Part 1/3: Server In-Reply-To: References: Message-ID: <20090804200715.A9F5A345D877@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27490 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34053|review? |review- Flag| | --- Comment #6 from Mark Rowe (bdash) 2009-08-04 13:07:14 PDT --- (From update of attachment 34053) Two big issues jump out at me: 1) Coding style. Python code in WebKit typically follows the standard Python style guidelines as documented in PEP 8 at http://www.python.org/dev/peps/pep-0008/. This includes using four spaces for indentation, lower_case_and_underscores for function and method names, and so forth. I think we're more than happy to ignore the 80 character line length limit as we do elsewhere in WebKit source. 2) The script have a hardcoded #! line that refers to Python 2.4. Tiger only ships with Python 2.3, so a test harness will need to be compatible with that version. I've not studied the code closely enough to determine whether there are 2.4 features used in the code or if it's just the shebang line that is the problem. The "websocket_" prefix on the file names also seems redundant given that this all lives inside a websocket directory. I'll try and take a closer look at the substance of the patch soon, but it's clear at this point that it needs revision. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:08:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:08:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27490] Web Sockets Test Infrastructure Part 1/3: Server In-Reply-To: References: Message-ID: <20090804200806.05B77345D88D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27490 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrowe at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:12:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:12:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27991] bugzilla_unitest.py needs to know how to run a local bugzilla instance In-Reply-To: References: Message-ID: <20090804201242.ADB90345D931@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27991 --- Comment #3 from Eric Seidel 2009-08-04 13:12:41 PDT --- We can easily dump some bugs into some fixture files though. I bet it's possible to run mysql with some flat-file backends. I had thought mysql came installed on mac os x, but I guess not. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:15:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:15:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27490] Web Sockets Test Infrastructure Part 1/3: Server In-Reply-To: References: Message-ID: <20090804201544.D73D8345D999@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27490 --- Comment #7 from Alexey Proskuryakov 2009-08-04 13:15:43 PDT --- +DEFAULT_WS_PORT = 81 This doesn't look like a great default, given that the server would need root privileges to take this port. + WebSocketHTTPRequestHandler.protocol_version = 'HTTP/1.0' Why 1.0? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:27:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:27:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090804202753.1AC95345DB05@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 --- Comment #22 from Luke Kenneth Casson Leighton 2009-08-04 13:27:51 PDT --- (In reply to comment #21) > (From update of attachment 34060 [details]) > I wasn't clear, sorry. I agree that JS should be default. I just wanted all > the places where you assumed !JS was Gdom to turn into explicit GDom checks. done. yep. > passing no --bindingType can/should default to JS. Otherwise you'd have to > change lots more files here. :) ack. whew. > 327 if ($binding eq 'Gdom') { > 328 # skip DATAGRID for now > 329 next if ($conditional eq 'DATAGRID'); > 330 } > > Those can all go away if you just remove DATAGRID from the list of tags at the > start, no? yes - good idea, but my perl skills don't extend to doing that. cut-and-paste if it's already in the same perl file (or in any other one i've encountered, which aren't many) i can manage. i even managed to look up how to do includes recently... ... but that's about it, really. the only reason CodeGeneratorGObject.pm works is because the other CodeGenerator*.pm files were complex enough to contain everything that i needed. > Removing it once instead of skipping it in every for loop seems > like a cleaner solution, or? Also, don't you all have ENABLE_DATAGRID off > anyway? no - it appears to be on by default. and, anyone enabling it will end up with a compile-time error, because the CodeGeneratorGObject.pm isn't equipped to auto-generate GdomHTMLDataGrid{Row,Col,Element}.{cpp,h}, and neither is the infrastructure there to support it. > Won't make_names just print #defines around all the DATAGRID stuff > which will be compiled out? yes - but then suppose someone _does_ want JS-based DATAGRID support, and doesn't care about GObject or doesn't care about DATAGRID not being in GObject bindings? > $F really should have a better name, per our style guidelines: > http://webkit.org/coding/coding-style.html. Since you're just moving existing > code, I guess it's OK as is though. ack. whew. > So the GNUMakefile.am changes are fine, but not required if you restore the JS > default. going. prefer not to hack GNUmakefile.am right now, i have a number of other mods to it that i'm keeping track of. > This in general looks great. I think we still can fix the DATAGRID with a > cleaner hack. not with my level of perl skills, though. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:35:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:35:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090804203510.0FFD8345DBEF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 --- Comment #23 from Eric Seidel 2009-08-04 13:35:09 PDT --- Is DATAGRID off for the gtk port? What happens when you try to generate DATAGRID files? Why are they different from other HTML elements? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:37:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:37:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26785] Page not rendered/aligned correctly on left side In-Reply-To: References: Message-ID: <20090804203706.5A2F3345DC3D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26785 --- Comment #5 from Dimitris Apostolou 2009-08-04 13:37:05 PDT --- Still here with 5530.19, r46770 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:37:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:37:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24061] Returning to previous page link from print view does not work in Jira In-Reply-To: References: Message-ID: <20090804203741.2AE50345DC53@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24061 --- Comment #16 from Dimitris Apostolou 2009-08-04 13:37:40 PDT --- Still here with 5530.19, r46770 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:40:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:40:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090804204057.7A060345DCAD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 --- Comment #24 from Luke Kenneth Casson Leighton 2009-08-04 13:40:56 PDT --- > > 327 if ($binding eq 'Gdom') { > > 328 # skip DATAGRID for now > > 329 next if ($conditional eq 'DATAGRID'); > > 330 } > > > > Those can all go away if you just remove DATAGRID from the list of tags at the > > start, no? > > yes - good idea, but my perl skills don't extend to doing that. looking at tagHandler, it looks like this gets called several times per tag e.g. once for interfaceName, another time for conditional. so... you would only discover that you shouldn't _have_ the tag _after_ it's been created (once you encounter conditional = 'DATAGRID'. which means iterating, after the fact, over $tags and re-creating $realtags excluding anything conditional=DATAGRID. ... yuk? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:47:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:47:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090804204741.7066E345DD54@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 --- Comment #25 from Luke Kenneth Casson Leighton 2009-08-04 13:47:40 PDT --- (In reply to comment #23) > Is DATAGRID off for the gtk port? > > What happens when you try to generate DATAGRID files? Why are they different > from other HTML elements? they inherit from / have-as-members a base class / DOM object which is neither auto-generated nor already existing in the Gdom* codebase: DataGridDataSource. in the JS case, this has been catered for, in the past ten months (since the original work was done in nov 2008) by creating WebCore/bindings/js/JSDataGridDataSource.{cpp,h}, and by adding WebCore/bindings/js/JSDataGridColumnListCustom.cpp and much more. none of which i want to duplicate / get involved with, right now. all of this is one of the key reasons behind submitting a static manually-generated file. at least then, as the rest of webkit continues to move forward, leaving the GObject bindings behind, i don't have so much work to do to keep up. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:53:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:53:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23993] Underline formatting bleeds into other formatting during delete/backspace In-Reply-To: References: Message-ID: <20090804205342.C8463345DE53@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23993 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P2 |P3 OS/Version|Mac OS X 10.5 |All --- Comment #6 from Ryosuke Niwa 2009-08-04 13:53:41 PDT --- This is another bug with ReplaceSelectionCommand as Justin suggested, we need to adjust where we insert the fragment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 13:54:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 13:54:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090804205448.019B0345DE74@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Carol Szabo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34007|0 |1 is obsolete| | Attachment #34082| |review? Flag| | --- Comment #12 from Carol Szabo 2009-08-04 13:54:46 PDT --- Created an attachment (id=34082) --> (https://bugs.webkit.org/attachment.cgi?id=34082) Removed the executable flag from the html file and added newline at the end of that file -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:02:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:02:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090804210207.3A6F4345DF4A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 --- Comment #13 from Carol Szabo 2009-08-04 14:02:06 PDT --- (In reply to comment #11) > (From update of attachment 34007 [details]) > This patch looks wrong. As written all it does is rename the boolean to > "isOptionSelected" and add a new, never-used "selectedOption". > > > + selectedOption=optionElement; > Darin, I think that you missed these lines: if (!items[i]->getAttribute(HTMLNames::selectedAttr).isNull()) { + if (selectedOption && !data.multiple()) + selectedOption->setSelectedState(false); optionElement->setSelectedState(true); - optionSelected = true; + selectedOption = optionElement; + isOptionSelected = true; They are intended to unselect the previously selected options if the select box is not a multiple selection box. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:05:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:05:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090804210550.669E0345DFDD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Carol Szabo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34082|review? | Flag| | Attachment #34082|0 |1 is obsolete| | --- Comment #14 from Carol Szabo 2009-08-04 14:05:49 PDT --- Created an attachment (id=34083) --> (https://bugs.webkit.org/attachment.cgi?id=34083) Fixed coding style issue. I apologize for the repeated coding style offenses. The check-webkit-coding-style script does not run on my system so I have to manually check my style and apparently I am not very good at it. I promise to make a better effort next time. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:22:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:22:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] New: LayoutTests are too slow Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27995 Summary: LayoutTests are too slow Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org LayoutTests are too slow I will post patches here to make them less slow. Current worst 10 offenders: 9.58 secs: editing/selection/move-left-right.html 9.37 secs: fast/js/array-filter.html 7.71 secs: editing/selection/extend-selection.html 6.82 secs: fast/js/sort-randomly.html 6.25 secs: http/tests/cache/subresource-expiration.html 5.77 secs: fast/js/array-enumerators-functions.html 5.41 secs: fast/events/click-count.html 5.39 secs: fast/js/toString-and-valueOf-override.html 5.26 secs: fast/js/try-catch-crash.html 5.05 secs: http/tests/navigation/slowmetaredirect-basic.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:23:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:23:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090804212305.10A20345E207@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 --- Comment #15 from Darin Adler 2009-08-04 14:23:04 PDT --- (From update of attachment 34083) > + selectedOption = optionElement; > + isOptionSelected = true; I suggest eliminating the isOptionSelected boolean. It's the same as a null check on selectedOption now. > - if (!optionSelected && firstOption && data.usesMenuList()) > + if (!isOptionSelected && firstOption && data.usesMenuList()) Here you would just say !selectedOption. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:24:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:24:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090804212422.48790345E230@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34085| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-04 14:24:21 PDT --- Created an attachment (id=34085) --> (https://bugs.webkit.org/attachment.cgi?id=34085) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:25:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:25:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090804212523.9F246345E26E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34085|Patch v1 |Fix description| |fast/events/click-count.htm | |l -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:25:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:25:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090804212546.AD6F0345E288@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34085|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:36:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:36:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27874] Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp In-Reply-To: References: Message-ID: <20090804213637.01B5D345E3BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27874 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |barraclough at apple.com Resolution|FIXED | --- Comment #4 from Gavin Barraclough 2009-08-04 14:36:35 PDT --- Unfortunately this change break the v8 tests (as run in the sunspider command-line harness), so reverted for now in r46778. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:37:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:37:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27998] New: http/tests/cache/subresource-expiration.html uses 4.5 seconds of delay Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27998 Summary: http/tests/cache/subresource-expiration.html uses 4.5 seconds of delay Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: darin at apple.com, koivisto at iki.fi Blocks: 27995 http/tests/cache/subresource-expiration.html uses 4.5 seconds of delay These were added in: http://trac.webkit.org/changeset/45003 Current runtime of this test is 6.25s on my machine. That's about 1% of total LayoutTest runtime. :( Is the delay really necessary? { testHeaders: { 'Cache-control': 'max-age=1', }, delay: 1.5, expectedResult: 'Uncached', }, { testHeaders: { 'Last-modified': '[now-3600s]', }, delay: 1.5, expectedResult: 'Cached', }, { testHeaders: { 'Last-modified': '[now-10s]', }, delay: 1.5, expectedResult: 'Uncached', }, -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:37:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:37:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090804213746.180B0345E3F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27998 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:38:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:38:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27874] Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp In-Reply-To: References: Message-ID: <20090804213833.26E5A345E418@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27874 --- Comment #5 from Eric Seidel 2009-08-04 14:38:32 PDT --- Can you define "break"? :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:44:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:44:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090804214404.80654345E4AF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 --- Comment #2 from Eric Seidel 2009-08-04 14:44:03 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/fast/events/click-count.html Committed r46779 M LayoutTests/ChangeLog M LayoutTests/fast/events/click-count.html r46779 = e94d8b69e0213dc93223db07ffb9f9f66204ff85 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46779 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:47:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:47:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27874] Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp In-Reply-To: References: Message-ID: <20090804214703.1B0F5345E505@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27874 --- Comment #6 from Gavin Barraclough 2009-08-04 14:47:02 PDT --- Long hang spinning the cpu, then a crash. Smells like something going off the deep end of the stack, but I'm afraid I don't really have time to debug this regression further right now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:50:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:50:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090804215017.6CAC8345E592@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Carol Szabo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34083|0 |1 is obsolete| | Attachment #34088| |review? Flag| | --- Comment #16 from Carol Szabo 2009-08-04 14:50:16 PDT --- Created an attachment (id=34088) --> (https://bugs.webkit.org/attachment.cgi?id=34088) Implemented Darin's suggestion in comment #15 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:51:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:51:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27999] New: SNS online banking: confirming transaction only works in debug mode Message-ID: https://bugs.webkit.org/show_bug.cgi?id=27999 Summary: SNS online banking: confirming transaction only works in debug mode Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.snsbank.nl/ OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: reinouts at gnome.org The online banking application of the SNS Bank works mostly fine in Epiphany/Webkit. The only thing that doesn't work is the final confirmation of a money transfer order. When I click the 'Verzenden' button ('Send') nothing happens. I was trying to debug this with WEBKIT_DEBUG=Network and, to my surprise, confirming transactions works in debug mode! Back in normal mode, it fails. I have reproduced this a couple of times now. Here's a capture of the network traffic logged to the console when the Verzenden button is clicked (I've edited a serial number in one URL for security reasons): > POST /secure/Bankieren/scripts/verzendlijst/verzendlijst_checksum.asp HTTP/1.1 > Soup-Debug-Timestamp: 1249422138 > Soup-Debug: SoupSessionAsync 1 (0x1b40010), SoupMessage 149 (0x1b46bf0), SoupSocket 2 (0x1b4a240) > Host: www.snsbank.nl > Origin: https://www.snsbank.nl > User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; nl-nl) AppleWebKit/531.2+ (KHTML, like Gecko) Safari/531.2+ > Accept: application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5 > Referer: https://www.snsbank.nl/secure/Bankieren/scripts/verzendlijst/verzendlijst_checksum.asp > Content-Type: application/x-www-form-urlencoded > Accept-Encoding: identity > Cookie: SNS_PERSIS=13256587161247846416870--1440x900; ASPSESSIONIDCQRCQBRQ=JMNOJLMDECCPJJGKBKNOBOHG; __utmz=229395038.1247846419.1.1.utmcsr=(direct)|utmccn=(direct)|utmcmd=(none); __utma=229395038.4006138691315477500.1247846419.1248026643.1248760636.3; MfPers=200907171800107413; MfTrack=200908042338297622 > > SequenceNo=11516012&SignMethod=digipas&DigipassSerial=88888888&signature1=691466&actie=VERZEND < HTTP/1.1 302 Object moved < Soup-Debug-Timestamp: 1249422138 < Soup-Debug: SoupMessage 149 (0x1b46bf0) < Date: Tue, 04 Aug 2009 21:42:12 GMT < Server: Microsoft-IIS/6.0 < X-Powered-By: ASP.NET < X-UA-Compatible: IE=EmulateIE7 < pragma: no-cache < cache-control: private < Location: verzendlijst.asp?SendOk=True&errmesg=1+opdracht%28en%29+verzonden < Content-Length: 190 < Content-Type: text/html < Expires: Mon, 03 Aug 2009 21:42:12 GMT < cache-control: no-cache > GET /secure/Bankieren/scripts/verzendlijst/verzendlijst.asp?SendOk=True&errmesg=1+opdracht%28en%29+verzonden HTTP/1.1 > Soup-Debug-Timestamp: 1249422138 > Soup-Debug: SoupSessionAsync 1 (0x1b40010), SoupMessage 149 (0x1b46bf0), SoupSocket 2 (0x1b4a240), restarted > Host: www.snsbank.nl > Origin: https://www.snsbank.nl > User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; nl-nl) AppleWebKit/531.2+ (KHTML, like Gecko) Safari/531.2+ > Accept: application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5 > Referer: https://www.snsbank.nl/secure/Bankieren/scripts/verzendlijst/verzendlijst_checksum.asp > Accept-Encoding: identity > Cookie: SNS_PERSIS=13256587161247846416870--1440x900; ASPSESSIONIDCQRCQBRQ=JMNOJLMDECCPJJGKBKNOBOHG; __utmz=229395038.1247846419.1.1.utmcsr=(direct)|utmccn=(direct)|utmcmd=(none); __utma=229395038.4006138691315477500.1247846419.1248026643.1248760636.3; MfPers=200907171800107413; MfTrack=200908042338297622 < HTTP/1.1 200 OK < Soup-Debug-Timestamp: 1249422138 < Soup-Debug: SoupMessage 149 (0x1b46bf0) < Date: Tue, 04 Aug 2009 21:42:12 GMT < Server: Microsoft-IIS/6.0 < X-Powered-By: ASP.NET < X-UA-Compatible: IE=EmulateIE7 < pragma: no-cache < cache-control: private < Content-Length: 9872 < Content-Type: text/html < Expires: Mon, 03 Aug 2009 21:42:12 GMT < cache-control: no-cache -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:52:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:52:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804215224.6DAA3345E5D8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34051|review- | Flag| | Attachment #34051|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 14:52:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 14:52:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804215233.C7F93345E5F3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34089| |review? Flag| | --- Comment #10 from Adam Barth 2009-08-04 14:52:32 PDT --- Created an attachment (id=34089) --> (https://bugs.webkit.org/attachment.cgi?id=34089) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:00:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:00:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804220016.76BEA345E6BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34089|review? | Flag| | Attachment #34089|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:00:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:00:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804220027.24B88345E6D5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34090| |review? Flag| | --- Comment #11 from Adam Barth 2009-08-04 15:00:26 PDT --- Created an attachment (id=34090) --> (https://bugs.webkit.org/attachment.cgi?id=34090) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:02:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:02:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804220201.00AD0345E739@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34090|review? | Flag| | Attachment #34090|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:02:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:02:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804220205.DC637345E754@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34091| |review? Flag| | --- Comment #12 from Adam Barth 2009-08-04 15:02:04 PDT --- Created an attachment (id=34091) --> (https://bugs.webkit.org/attachment.cgi?id=34091) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:05:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:05:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804220550.2890E345E7E4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34091|review? |review+, commit-queue+ Flag| | --- Comment #13 from Eric Seidel 2009-08-04 15:05:49 PDT --- (From update of attachment 34091) LGTM. I wonder if people will complain about run-w being stolen for tab-complete by this script. ;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:07:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:07:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804220722.EFA1E345E848@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 --- Comment #14 from Adam Barth 2009-08-04 15:07:21 PDT --- (In reply to comment #13) > (From update of attachment 34091 [details]) > LGTM. I wonder if people will complain about run-w being stolen for > tab-complete by this script. ;) abarth at dhcp-45-156:~/svn/webkit4$ ./WebKitTools/Scripts/run-webkit- run-webkit-app run-webkit-nightly.cmd run-webkit-unittests run-webkit-httpd run-webkit-tests It doesn't add any tab-complete problems. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:08:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:08:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090804220827.B8B03345E866@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 --- Comment #3 from Mark Rowe (bdash) 2009-08-04 15:08:27 PDT --- Is this bug going to be used for investigating which tests are slow or for fixing individual tests? If the latter, it's fast going to get confusing with multiple patches. I'd suggest that you spin off separate bugs for tests that you're fixing rather than attaching them here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:15:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:15:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27999] [Gtk] SNS online banking: confirming transaction only works in debug mode In-Reply-To: References: Message-ID: <20090804221513.95446345E913@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27999 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SNS online banking: |[Gtk] SNS online banking: |confirming transaction only |confirming transaction only |works in debug mode |works in debug mode -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:16:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:16:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28001] New: should not trim initial value to maxLength Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28001 Summary: should not trim initial value to maxLength Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://software.hixie.ch/utilities/js/live-dom-viewer/ saved/190 OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pkasting at google.com Blocks: 27454 In WebKit, displays a textfield containing "foo". In Firefox, IE, and Opera, it displays "foobar". We should match this. (Testcase at the URL above.) This probably also applies to values set by scripting the DOM. When the value is longer than maxLength, and the user attempts to modify the value in place, IE and Firefox apply the following algorithm: * Delete the selected character(s) * If the value is now shorter than maxLength, insert characters from the user's attempted insertion value, stopping when the length of the element's value equals maxLength. Opera is stranger; its first step is: * If deleting the selected character(s) will not make the resulting value shorter than maxLength, abort without doing anything; otherwise, delete the selected character(s) and proceed. As a result, when the element contains "foobar" with maxLength 3, and the clipboard contains "zyx": * On IE and Firefox, selecting "r" and typing a key or pasting will delete "r". On Opera, this will do nothing. * On IE and Firefox, selecting "foo" and typing a key or pasting will delete "foo". On Opera, this will do nothing. * On all three browsers, selecting "ooba" and pasting will result in "fzr". I think the IE and Firefox behavior, while at first stranger, is more consistent. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:22:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:22:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27988] word-spacing style seems not to be honored In-Reply-To: References: Message-ID: <20090804222205.A85E1345E9B3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27988 --- Comment #1 from Mark Rowe (bdash) 2009-08-04 15:22:05 PDT --- With which port of WebKit? The page renders as expected on Mac OS X. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:22:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:22:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28001] should not trim initial value to maxLength In-Reply-To: References: Message-ID: <20090804222230.8DCC0345E9C9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28001 --- Comment #1 from Peter Kasting 2009-08-04 15:22:30 PDT --- Note: WebKit already does the second step above, where it pastes in as much as will fit. To see this, visit the example URL, select one character of "foo", and try pasting "maxLength". You'll see the selected character replaced by "m". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:25:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:25:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] New: Add pkasting to bugzilla-tool as a committer Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28002 Summary: Add pkasting to bugzilla-tool as a committer Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abarth at webkit.org CC: eric at webkit.org, pkasting at google.com Peter asked to be added to the bugzilla-tool list of committers. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:28:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:28:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804222825.043C0345EA5D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34093| |review? Flag| | --- Comment #1 from Adam Barth 2009-08-04 15:28:24 PDT --- Created an attachment (id=34093) --> (https://bugs.webkit.org/attachment.cgi?id=34093) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:30:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:30:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090804223040.3A72C345EA89@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34088|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:31:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:31:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804223114.529CC345EAAD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34093|review? |review+ Flag| | --- Comment #2 from Darin Adler 2009-08-04 15:31:13 PDT --- (From update of attachment 34093) Does this kind of change need review? r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:33:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:33:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804223359.58C5F345EAEB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34093| |commit-queue+ Flag| | --- Comment #3 from Adam Barth 2009-08-04 15:33:58 PDT --- (From update of attachment 34093) Not sure. I can make these changes unreviewed in the future if you like. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:36:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:36:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23993] Underline formatting bleeds into other formatting during delete/backspace In-Reply-To: References: Message-ID: <20090804223631.1E505345EB65@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23993 --- Comment #7 from Ryosuke Niwa 2009-08-04 15:36:29 PDT --- Around the line 865, we have insertNodeAtAndUpdateNodesInserted(refNode, insertionPos); And refNode->showTreeForThis() results in: SPAN 0x1af7ee50 CLASS=Apple-style-span STYLE=border-collapse: separate; color: rgb(0, 0, 0); font-family: Times; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; #text 0x1af7f170 "world" Is it even correct to have "-webkit-text-decoration: none" here? If so, when are you taking care of it? handleStyleSpans? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:42:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:42:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28003] New: Cleanup: ResourceResponse should be a class, not a struct Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28003 Summary: Cleanup: ResourceResponse should be a class, not a struct Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: michaeln at google.com This 'struct' really should be a 'class'. Here's how things are defined for various ports... C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\cf\ResourceRequest.h(37): struct ResourceRequest : ResourceRequestBase { C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\curl\ResourceRequest.h(36): struct ResourceRequest : ResourceRequestBase { C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\qt\ResourceRequest.h(38): struct ResourceRequest : ResourceRequestBase { C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\soup\ResourceRequest.h(36): struct ResourceRequest : ResourceRequestBase { C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\chromium\ResourceRequest.h(38): struct ResourceRequest : public ResourceRequestBase { C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\mac\ResourceRequest.h(41): class ResourceRequest : public ResourceRequestBase { Here's how many of the forward declarations are declared... C:\chrome\1\src\third_party\WebKit\WebCore\history\HistoryItem.h(53):struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\inspector\InspectorController.h(67):struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\inspector\InspectorResource.h(54): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\appcache\ApplicationCache.h(45):struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\appcache\ApplicationCacheHost.h(51): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\DocumentThreadableLoader.h(42): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\FrameLoaderClient.h(65): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\MainResourceLoader.h(43): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\SubresourceLoader.h(36): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\SubresourceLoaderClient.h(36):struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\ThreadableLoader.h(41): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\WorkerThreadableLoader.h(50): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\cf\ResourceRequestCFNet.h(33): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\ResourceHandleClient.h(53): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\ResourceRequestBase.h(49): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\platform\CrossThreadCopier.h(44): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\xml\XMLHttpRequest.h(37):struct ResourceRequest; -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:43:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:43:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28001] should not trim initial value to maxLength In-Reply-To: References: Message-ID: <20090804224304.9A46F345EBF8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28001 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |micdesim at gmail.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:46:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:46:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804224635.F2060345EC58@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34091|review+ | Flag| | --- Comment #15 from Adam Barth 2009-08-04 15:46:34 PDT --- (From update of attachment 34091) Clearing review flag on attachment: 34091 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog A WebKitTools/Scripts/run-webkit-unittests Committed r46781 M WebKit/wx/WebKitSupport/InspectorClientWx.cpp M WebKit/wx/WebKitSupport/InspectorClientWx.h M WebKit/wx/ChangeLog r46780 = dc5b52be13b15b6b4e3e9773f1780412f01881f2 (trunk) M WebKitTools/ChangeLog A WebKitTools/Scripts/run-webkit-unittests r46781 = 2282d863ec463529cb2b4182d652cb02ba484a38 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46781 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:46:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:46:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804224640.A0160345EC76@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #16 from Adam Barth 2009-08-04 15:46:39 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:53:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:53:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26915] [HTML5][Forms] Part 1 of datalist&list: element support In-Reply-To: References: Message-ID: <20090804225321.ECF10345ED2D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26915 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com, | |pkasting at google.com --- Comment #13 from Peter Kasting 2009-08-04 15:53:21 PDT --- dhyatt was working on support, he should be CCed on all bugs about it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:54:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:54:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090804225419.E637E345ED84@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com, | |pkasting at google.com --- Comment #8 from Peter Kasting 2009-08-04 15:54:18 PDT --- dhyatt was working on support, he should be CCed on all bugs about it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:55:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:55:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090804225552.BC21E345EDB4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27756, 27794, 27800 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:55:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:55:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090804225554.1DEE3345EDCA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19264 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:55:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:55:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27794] [HTML5][Forms] Part 3 of datalist&list: Introduce new pseudo selector, new appearance, and new control part for the list attribute support In-Reply-To: References: Message-ID: <20090804225554.9CD08345EDD2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27794 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19264 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:55:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:55:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27800] [HTML5][Forms] Part 4 of datalist&list: Move controlClip from RenderTextControlSingleLine to TextControlElements.cpp In-Reply-To: References: Message-ID: <20090804225554.E8921345EDD8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27800 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19264 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:58:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:58:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090804225826.C97B2345EE20@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC|pkasting at google.com | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:58:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:58:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26915] [HTML5][Forms] Part 1 of datalist&list: element support In-Reply-To: References: Message-ID: <20090804225840.D64A6345EE30@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26915 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC|pkasting at google.com | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:59:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:59:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27794] [HTML5][Forms] Part 3 of datalist&list: Introduce new pseudo selector, new appearance, and new control part for the list attribute support In-Reply-To: References: Message-ID: <20090804225919.AFFC9345EE42@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27794 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com --- Comment #2 from Peter Kasting 2009-08-04 15:59:19 PDT --- dhyatt was working on support, he should be CCed on all bugs about it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:59:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:59:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27800] [HTML5][Forms] Part 4 of datalist&list: Move controlClip from RenderTextControlSingleLine to TextControlElements.cpp In-Reply-To: References: Message-ID: <20090804225927.9FE17345EE52@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27800 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com --- Comment #2 from Peter Kasting 2009-08-04 15:59:27 PDT --- dhyatt was working on support, he should be CCed on all bugs about it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:59:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:59:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27247] [HTML5][Forms] [HTML5][Forms] Part 5 of datalist&list: UI of `list' attribute of In-Reply-To: References: Message-ID: <20090804225936.A5668345EE66@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27247 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com --- Comment #5 from Peter Kasting 2009-08-04 15:59:35 PDT --- dhyatt was working on support, he should be CCed on all bugs about it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:03:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:03:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27985] ASSERTION FAILED: m_frame->document()->parsing() In-Reply-To: References: Message-ID: <20090804230304.CADC8345EEC0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27985 Antonio Gomes (tonikitoo) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tonikitoo at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:03:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:03:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804230343.8D094345EED6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 --- Comment #4 from Peter Kasting 2009-08-04 16:03:42 PDT --- *** Bug 28000 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:06:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:06:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090804230609.306CB345EF2E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Kevin Ollivier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33374|review? | Flag| | Attachment #33374|0 |1 is obsolete| | Attachment #34096| |review? Flag| | --- Comment #20 from Kevin Ollivier 2009-08-04 16:06:07 PDT --- Created an attachment (id=34096) --> (https://bugs.webkit.org/attachment.cgi?id=34096) Changes to build-webkit needed for wx to use the waf build process - second patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:16:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:16:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27393] Optimize string operations in GraphicsLayerCA In-Reply-To: References: Message-ID: <20090804231643.D97F2345F06D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27393 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #1 from Simon Fraser (smfr) 2009-08-04 16:16:43 PDT --- Fixed via bug 27884. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:20:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:20:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28004] New: [chromium] setting listeners on MessagePorts doesn't work in the worker process Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28004 Summary: [chromium] setting listeners on MessagePorts doesn't work in the worker process Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Platform AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jam at chromium.org Bindings need to be updated. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:24:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:24:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28004] [chromium] setting listeners on MessagePorts doesn't work in the worker process In-Reply-To: References: Message-ID: <20090804232447.72D3A345F13C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28004 John Abd-El-Malek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34098| |review? Flag| | --- Comment #1 from John Abd-El-Malek 2009-08-04 16:24:47 PDT --- Created an attachment (id=34098) --> (https://bugs.webkit.org/attachment.cgi?id=34098) Proposed patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:31:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:31:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804233135.49B91345F1ED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34093|review+ | Flag| | --- Comment #5 from Adam Barth 2009-08-04 16:31:34 PDT --- (From update of attachment 34093) Clearing review flag on attachment: 34093 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/committers.py Committed r46785 M WebCore/ChangeLog M WebCore/bindings/v8/V8AbstractEventListener.cpp M WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp r46784 = 07e35744c34059ea6688b9761498f8e35a9d77d7 (trunk) M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/committers.py r46785 = b3c485049ce83fed61111e10ce0a46f8b5c31c41 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46785 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:31:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:31:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804233138.9E153345F1FF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Adam Barth 2009-08-04 16:31:37 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:48:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:48:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28003] Cleanup: ResourceResponse should be a class, not a struct In-Reply-To: References: Message-ID: <20090804234801.0332F345F413@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28003 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |ap at webkit.org Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:55:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:55:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27986] sunspider contains error on --parse-only path In-Reply-To: References: Message-ID: <20090804235547.719EF345F4C1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27986 Jeff Walden (remove +bwo to email) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwalden+bwo at mit.edu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:07:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:07:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23993] Underline formatting bleeds into other formatting during delete/backspace In-Reply-To: References: Message-ID: <20090805000711.84C1E345F5B1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23993 --- Comment #8 from Ryosuke Niwa 2009-08-04 17:07:10 PDT --- Justin and I talked on IRC, and it's maybe sensible to delete all style-spans and reapply ApplyStyleCommand because we need to push down text decoration and other styles and apply them again. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:12:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:12:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26981] Keyframe animations on border don't always work. In-Reply-To: References: Message-ID: <20090805001258.2261D345F63E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26981 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME --- Comment #1 from Simon Fraser (smfr) 2009-08-04 17:12:57 PDT --- This is actually working as designed. The border animations don't show because border-style is not set outside the keyframes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:14:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:14:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28006] New: REGRESSION: run-webkit-tests errors out if you have two copies of perl installed Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28006 Summary: REGRESSION: run-webkit-tests errors out if you have two copies of perl installed Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org REGRESSION: run-webkit-tests errors out if you have two copies of perl installed -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:15:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:15:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28006] REGRESSION: run-webkit-tests errors out if you have two copies of perl installed In-Reply-To: References: Message-ID: <20090805001517.2FC63345F68D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28006 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34102| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-04 17:15:16 PDT --- Created an attachment (id=34102) --> (https://bugs.webkit.org/attachment.cgi?id=34102) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:15:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:15:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28006] REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH In-Reply-To: References: Message-ID: <20090805001555.14398345F6A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28006 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Platform|PC |Macintosh Summary|REGRESSION: |REGRESSION: |run-webkit-tests errors out |run-webkit-tests crashes if |if you have two copies of |you have non-system perl in |perl installed |PATH -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:16:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:16:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26981] Keyframe animations on border don't always work. In-Reply-To: References: Message-ID: <20090805001609.C44EA345F6BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26981 --- Comment #2 from Simon Fraser (smfr) 2009-08-04 17:16:09 PDT --- Created an attachment (id=34103) --> (https://bugs.webkit.org/attachment.cgi?id=34103) LayoutTest for posterity -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:16:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:16:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28006] REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH In-Reply-To: References: Message-ID: <20090805001642.9B1FA345F6E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28006 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34102|review? |review+ Flag| | --- Comment #2 from Mark Rowe (bdash) 2009-08-04 17:16:41 PDT --- (From update of attachment 34102) r=me. Can you update the ChangeLog to use the more accurate title please? :-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:22:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:22:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28006] REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH In-Reply-To: References: Message-ID: <20090805002205.7E4FD345F782@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28006 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-04 17:22:04 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/DumpRenderTree/mac/PerlSupport/Makefile Committed r46787 M WebKit/mac/ChangeLog M WebKit/mac/WebView/WebDataSource.mm M WebCore/ChangeLog M WebCore/WebCore.base.exp M WebCore/html/HTMLHtmlElement.cpp M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/loader/FrameLoader.cpp M WebCore/loader/DocumentLoader.h M WebCore/loader/ResourceLoader.cpp M WebCore/loader/appcache/ApplicationCacheStorage.h M WebCore/loader/appcache/ApplicationCacheGroup.cpp M WebCore/loader/appcache/ApplicationCacheHost.cpp M WebCore/loader/appcache/DOMApplicationCache.cpp M WebCore/loader/appcache/ApplicationCacheGroup.h M WebCore/loader/appcache/ApplicationCacheHost.h M WebCore/loader/appcache/ApplicationCacheStorage.cpp M WebCore/loader/appcache/DOMApplicationCache.h M WebCore/loader/MainResourceLoader.cpp M WebCore/loader/DocumentLoader.cpp r46786 = f5b167df15909cc5ebf8b6b6769d05671556829f (trunk) M WebKitTools/DumpRenderTree/mac/PerlSupport/Makefile M WebKitTools/ChangeLog r46787 = 854e0f64b2ef7dc4c570b1ae7009a2ef61432b4b (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46787 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:35:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:35:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 3749] XHTML 1.1 Ruby Annotation In-Reply-To: References: Message-ID: <20090805003553.2E5B5345F976@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=3749 --- Comment #26 from Roland Steiner 2009-08-04 17:35:50 PDT --- Re-reading the bug description, and given the change of focus in my implementation towards HTML5, I wonder if it wouldn't be more correct to open a new bug entry "HTML5 Ruby Annotation" (?). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:56:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:56:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code In-Reply-To: References: Message-ID: <20090805005611.2B9A2345FC13@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27967 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34104| |review? Flag| | --- Comment #1 from Dumitru Daniliuc 2009-08-04 17:56:09 PDT --- Created an attachment (id=34104) --> (https://bugs.webkit.org/attachment.cgi?id=34104) SQLTransactionClient Introducing SQLTransactionClient, a "listener" interface that allows us to remove dependencies on DatabaseTracker and OriginQuotaManager from SQLTransaction. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:57:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:57:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805005706.823A2345FC32@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 --- Comment #4 from Eric Seidel 2009-08-04 17:57:05 PDT --- Created an attachment (id=34105) --> (https://bugs.webkit.org/attachment.cgi?id=34105) slowest 1000 tests (Debug build on a Mac Pro) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:00:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:00:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28007] New: Cannot focus area element of an image map Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28007 Summary: Cannot focus area element of an image map Product: WebKit Version: 528+ (Nightly build) Platform: All URL: http://www.w3schools.com/TAGS/tryit_view.asp?filename= tryhtml_areamap OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: arv at chromium.org It is currently impossible to tab or click to focus an area element of an image map. Area elements are semantically just links so they should be focusable by default (just like a elements) This works in Firefox and IE. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:07:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:07:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27247] [HTML5][Forms] Part 5 of datalist&list: UI of `list' attribute of In-Reply-To: References: Message-ID: <20090805010711.003FD345FD29@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27247 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[HTML5][Forms] |[HTML5][Forms] Part 5 of |[HTML5][Forms] Part 5 of |datalist&list: UI of `list' |datalist&list: UI of `list' |attribute of |attribute of | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:11:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:11:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805011153.D9CFF345FD9B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34085|review+ | Flag| | Attachment #34085|0 |1 is obsolete| | --- Comment #5 from Eric Seidel 2009-08-04 18:11:53 PDT --- (From update of attachment 34085) @bdash: agreed. I'll make this a meta bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:12:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:12:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805011232.3506C345FDAD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 --- Comment #6 from Eric Seidel 2009-08-04 18:12:31 PDT --- This bug only serves a temporary purpose. It can be closed when most of the dependent bugs are closed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:14:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:14:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28008] New: fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28008 Summary: fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org Blocks: 27995 fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay This layout test is from another era. I've updated it to be dumpAsText and not need a 5-second delay to test dragging. I validated that I didn't break the test by temporarily removing the "disabled" flag from the and checking that the drag succeeded (i.e. the test failed) with disabled removed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:14:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:14:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805011438.49414345FDE1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28008 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:16:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:16:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28008] fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay In-Reply-To: References: Message-ID: <20090805011628.79CBC345FE14@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28008 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34106| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-04 18:16:27 PDT --- Created an attachment (id=34106) --> (https://bugs.webkit.org/attachment.cgi?id=34106) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:17:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:17:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28008] fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay In-Reply-To: References: Message-ID: <20090805011741.C2893345FE3C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28008 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34106|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:24:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:24:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805012438.C2C19345FEC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 --- Comment #7 from Eric Seidel 2009-08-04 18:24:37 PDT --- Created an attachment (id=34108) --> (https://bugs.webkit.org/attachment.cgi?id=34108) slowest 1000 tests (Release build on a Mac Pro) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:25:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:25:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27998] http/tests/cache/subresource-expiration.html uses 4.5 seconds of delay In-Reply-To: References: Message-ID: <20090805012558.29AA5345FEE2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27998 --- Comment #1 from Eric Seidel 2009-08-04 18:25:57 PDT --- Actually, this is the slowest test in Release mode :( 6.22 secs: http/tests/cache/subresource-expiration.html See list https://bugs.webkit.org/attachment.cgi?id=34108 on bug 27995. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:34:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:34:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28008] fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay In-Reply-To: References: Message-ID: <20090805013450.39250345FFB7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28008 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Eric Seidel 2009-08-04 18:34:49 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.png D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/win/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/ChangeLog A LayoutTests/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/fast/forms/textfield-drag-into-disabled.html Committed r46790 D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.png D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum D LayoutTests/platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/win/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/ChangeLog A LayoutTests/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/fast/forms/textfield-drag-into-disabled.html r46790 = 0e2037c9047382a8aee9bdbd132f550c58725acd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46790 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:34:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:34:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805013450.D0AE6345FFC1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Bug 27995 depends on bug 28008, which changed state. Bug 28008 Summary: fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay https://bugs.webkit.org/show_bug.cgi?id=28008 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:42:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:42:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28009] New: Browser app is forced to terminate when access to a site with a 10MB gif image Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28009 Summary: Browser app is forced to terminate when access to a site with a 10MB gif image Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Other Status: UNCONFIRMED Severity: Critical Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ugashi35 at gmail.com Steps to reproduce: 1.Access to a site with a 10MB gif image 2.Wait for completed loading the site Browser Version: Mozilla/5.0(Linux U; Android 1.5; en-us; sdk Build/CUPCAKE) AppleWebkit/528.5(KHTML,like Gecko) Version/3.1.2 Mobile Safari/525.20.1 Actual behavior: Browser app is forced to terminate during loading a page *This site is possible to complete loading with the Safari browser(Ver. 530.17) Expected result: The browser app is not forced to terminate, at least display the error pop up before terminate -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:02:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:02:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28010] New: willCacheResponse tests should be split from the main dumpResourceLoadCallbacks() dumps Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28010 Summary: willCacheResponse tests should be split from the main dumpResourceLoadCallbacks() dumps Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: beidson at apple.com willCacheResponse tests should be split from the main dumpResourceLoadCallbacks() dumps. >From email on webkit-dev: On Aug 4, 2009, at 5:35 PM, Darin Fisher wrote: There is a Mac-only willCacheResponse notification that gets recorded by several of the layout tests when layoutTestController.dumpResourceLoadCallbacks(true) is called. However, this notification which originates at the ResourceHandle level is currently #if PLATFORM(MAC). I noticed that the tests which depend on this notification are currently skipped on platform/win. For Chromium, we have simply rebaselined with the willCacheResponse events excluded. Having a separate baseline is unfortunate and not running the tests on platform/win seems even worse. I wonder if it wouldn't be better to exclude willCacheResponse by default, and then only enable it selectively for tests that are about testing it. That way, we can un-skip the other tests that only fail on non-Mac as a side-effect of this notification not being supported. We could also try to support willCacheResponse on all platforms, but that seems like a lot of work for little gain. Afterall, it is a notification that WebKit doesn't itself care about. It is just something provided to the embedder of the WebKit Framework on Mac. I didn't see any bugs on file about this issue. -Darin My reply: willCacheResponse was lumped in with dumpResourceLoadCallbacks() solely for convenience based on the situation at the time. As you point out, it is only interesting for embedders of mainline WebKit on Mac. My two proposals are to either split off a new dumpWillCacheResponse() callback or change dumpResourceLoadCallbacks() to take a second argument that is false by default. I slightly prefer the latter. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:17:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:17:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26787] REGRESSION (r45064): Drop caret remains in text control after the mouse exits In-Reply-To: References: Message-ID: <20090805021700.BB0F634603F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26787 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abarth at webkit.org AssignedTo|webkit-unassigned at lists.web |eric at webkit.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:18:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:18:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090805021831.0D75F3460427@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34088| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:28:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:28:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 3749] XHTML 1.1 Ruby Annotation In-Reply-To: References: Message-ID: <20090805022858.ADD613460523@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=3749 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #27 from Eric Seidel 2009-08-04 19:28:57 PDT --- Too big for me to review, but possibly Hyatt can help you. No need to set commit-queue=? I'm sure Adam will write up some docs on commit-queue soon. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:30:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:30:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090805023052.41B9B3460567@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34088|commit-queue+ |commit-queue- Flag| | --- Comment #17 from Adam Barth 2009-08-04 19:30:51 PDT --- (From update of attachment 34088) I don't know what this error means, but the commit queue can't handle this patch: patching file WebCore/dom/SelectElement.cpp patch: **** malformed patch at line 15: @@ -502,8 +503,11 @@ void SelectElement::reset(SelectElementD -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:45:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:45:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805024545.87F0E346074A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33993|review? |review- Flag| | --- Comment #9 from Eric Seidel 2009-08-04 19:45:44 PDT --- (From update of attachment 33993) These are two separate changes. 1. to change queue to evaluate. 2. to fix ScheduledAction. I don't really know what this does, but I trust you do: 51 m_context.makeWeak(); These changes look both fine, but should be split into two. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 20:14:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 20:14:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805031446.65B7E3460A6D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33993|review- | Flag| | Attachment #33993|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 20:14:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 20:14:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805031450.F2D513460A8C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34113| |review? Flag| | --- Comment #10 from Adam Barth 2009-08-04 20:14:49 PDT --- Created an attachment (id=34113) --> (https://bugs.webkit.org/attachment.cgi?id=34113) Rename queueScriptInIsolatedWorld --- 18 files changed, 47 insertions(+), 17 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 20:14:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 20:14:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805031455.DD9FC3460AAF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34114| |review? Flag| | --- Comment #11 from Adam Barth 2009-08-04 20:14:54 PDT --- Created an attachment (id=34114) --> (https://bugs.webkit.org/attachment.cgi?id=34114) Scheduled action --- 10 files changed, 129 insertions(+), 18 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 20:25:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 20:25:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28011] New: Javascript core in webkit seems not work under 2 "window.location" issued Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28011 Summary: Javascript core in webkit seems not work under 2 "window.location" issued Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Critical Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yu.tsunghua at gmail.com CC: yu.tsunghua at gmail.com Dear Webkit Experts: Right now we are using Linux x86 + qt embedded 4.5.2 to build a VOD client. The problem what we met is that if contiguous two "window.location=" be issued in a javascript code section, QT webkit moudle seems can't send out the first one window.location. in other word, the first window.location was overwrite by the second one. the first window.location is an RTSP URL. the second is an HTTP URL. we build a test enviroment to simulate the whole process. here is the followings. 1. for first page, just an index page. index.html RTSP 2. for second page, launch the rtsp url via javascript in body tag onload action. rtsp.html RTSP URL Test 3. for third page, just show the current program end. In On Back Page Back Page when we using the QWebView to test the three pages, we can't get the RTSP URL request via qt's way. and we got the trolltech's expert advise to seek webkit experts to find out a workaround way to address this problem. the trolltech's expert tell us the problem seems come from the webkit's javascript core. would any body to do us a favor to show us how to trace the window.location was be handled? we want to know where the window.location was be handled and add some debug message to see what is really happened. Thanks in advance. Best Regards, Albert -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 20:28:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 20:28:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28011] Javascript core in webkit seems not work under 2 "window.location" issued In-Reply-To: References: Message-ID: <20090805032805.F1CC63460BC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28011 --- Comment #1 from AlbertYu 2009-08-04 20:28:05 PDT --- Created an attachment (id=34115) --> (https://bugs.webkit.org/attachment.cgi?id=34115) A test web page for webkit -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 21:20:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 21:20:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805042035.172A43461093@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34113|review? |review+ Flag| | --- Comment #12 from Eric Seidel 2009-08-04 21:20:33 PDT --- (From update of attachment 34113) LGTM. I assume this has a corresponding change in Chromium's test_shell? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 21:21:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 21:21:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805042152.2B93634610CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34114|review? |review+ Flag| | --- Comment #13 from Eric Seidel 2009-08-04 21:21:50 PDT --- (From update of attachment 34114) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 21:54:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 21:54:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27968] [HTML5][Forms] UI In-Reply-To: References: Message-ID: <20090805045448.A21A734613F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27968 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27451 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 23:16:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 23:16:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805061653.7DBF63461B3C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |abarth at webkit.org |kit.org | --- Comment #14 from Adam Barth 2009-08-04 23:16:52 PDT --- Assigned for landing. Landing this is a tricky dance. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 23:46:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 23:46:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28010] willCacheResponse tests should be split from the main dumpResourceLoadCallbacks() dumps In-Reply-To: References: Message-ID: <20090805064643.2E9103461E06@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28010 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fishd at chromium.org --- Comment #1 from Darin Fisher (:fishd, Google) 2009-08-04 23:46:42 PDT --- I'm happy to help implement this, and either of your suggestions are fine by me. Would we only enable willCacheResponse for the http/tests/misc/willCacheResponse-delegate-callback.html layout test? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 00:17:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 00:17:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27874] Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp In-Reply-To: References: Message-ID: <20090805071719.6B48B346215C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27874 --- Comment #7 from Zoltan Horvath 2009-08-05 00:17:18 PDT --- Weird. Was it on a MAC, wasn't it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 00:28:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 00:28:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090805072820.25E76346225A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Charles Wei changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34119| |review?(zimmermann at kde.org) Flag| | --- Comment #27 from Charles Wei 2009-08-05 00:28:17 PDT --- Created an attachment (id=34119) --> (https://bugs.webkit.org/attachment.cgi?id=34119) new patch with seperate .in file for the new WCSS properties. This is a new patch for the code changes, the most important change is that it seperates the WCSS specific CSS properties in a seperate .in file, and can be conditionally picked up by webkit with ENABLE(WCSS) . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 00:32:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 00:32:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28008] fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay In-Reply-To: References: Message-ID: <20090805073211.60A3834622C4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28008 --- Comment #3 from Mark Rowe (bdash) 2009-08-05 00:32:10 PDT --- Another good example of why bug 26920 should be addressed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 00:44:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 00:44:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28012] New: WebKit crashes because of Slashdot.org main page Javascript. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28012 Summary: WebKit crashes because of Slashdot.org main page Javascript. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Critical Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: red47514f7 at yandex.ru CC: red47514f7 at yandex.ru If I wget http://slashdot.org/ and just open it in a WebKit-based browser, everything is OK; of course, JavaScript loaded by relative URLs is not working. If I open http://slashdot.org/ in a webkit browser built against latest nightly (I tried two different browsers - uzbl and midori, both have the same regression when the same browser code is linked against too fresh WebKit instead of slightly older one), I see the Slashdot scripts composing a page, for a brief moment I even see nearly-complete rendering and then browser crashes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:03:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:03:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28013] New: Add my name to committers.py Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28013 Summary: Add my name to committers.py Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jorlow at chromium.org CC: abarth at webkit.org Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34120| |review? Flag| | Created an attachment (id=34120) --> (https://bugs.webkit.org/attachment.cgi?id=34120) Patch v1 Add my name to committers.py -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:06:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:06:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28013] Add my name to committers.py In-Reply-To: References: Message-ID: <20090805080654.789433462636@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28013 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34120|review? | Flag| | Attachment #34120|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:07:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:07:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28013] Add my name to committers.py In-Reply-To: References: Message-ID: <20090805080712.A30F93462649@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28013 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34122| |review? Flag| | --- Comment #1 from Jeremy Orlow 2009-08-05 01:07:11 PDT --- Created an attachment (id=34122) --> (https://bugs.webkit.org/attachment.cgi?id=34122) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:07:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:07:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28013] Add my name to committers.py In-Reply-To: References: Message-ID: <20090805080748.3D8E23462667@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28013 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |jorlow at chromium.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:14:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:14:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27929] [Gtk] macros in webkit.m4 should be defined once only In-Reply-To: References: Message-ID: <20090805081434.4A35D346274A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27929 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |xan.lopez at gmail.com Resolution|FIXED | --- Comment #4 from Xan Lopez 2009-08-05 01:14:33 PDT --- I had to revert this, since it was making us build debug images by default... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:14:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:14:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27929] [Gtk] macros in webkit.m4 should be defined once only In-Reply-To: References: Message-ID: <20090805081451.59C343462760@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27929 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33946|review+ | Flag| | --- Comment #5 from Xan Lopez 2009-08-05 01:14:51 PDT --- (From update of attachment 33946) Clearing flags. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:42:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:42:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28015] New: [Chromium] @font-face is not supported on Linux Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28015 Summary: [Chromium] @font-face is not supported on Linux Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yusukes at chromium.org (copied from http://crbug.com/18490) Chrome Version: r21365 URLs (if applicable) : http://www.alistapart.com/d/cssatten/poen.html Behavior in Chrome for Windows (optional): no problem CSS3 Web font (aka @font-face, dynamic font, or remote font) is not supported on Chromium Linux, even when --enable-remote-fonts command line flag is used. What steps will reproduce the problem? 1. start chromium for linux with --enable-remote-fonts 2. visit http://www.alistapart.com/d/cssatten/poen.html What is the expected result? The page is rendered using web fonts (scrrenshot:http://www.alistapart.com/d/cssatten/poen.png). What happens instead? The page is rendered without using web fonts (screenshot: http://www.alistapart.com/d/cssatten/nowf.png). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:52:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:52:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27490] Web Sockets Test Infrastructure Part 1/3: Server In-Reply-To: References: Message-ID: <20090805085215.0659D3462ACF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27490 Yuzo Fujishima changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34053|0 |1 is obsolete| | Attachment #34124| |review? Flag| | --- Comment #8 from Yuzo Fujishima 2009-08-05 01:52:13 PDT --- Created an attachment (id=34124) --> (https://bugs.webkit.org/attachment.cgi?id=34124) Web Socket Server, in desired coding style, with shorter file names. Thank you for your reviews. - I've changed the coding style to conform with PEP 8. - I've changed the #! line and other parts of the code such that the scripts will run with Python 2.3 and later. (I've tested with Python 2.3, 2.4, and 2.5) - I've removed 'websocket_' from the file names except for websocket_http_server.py, for which the prefix is meaningful, IMHO. - I've changed the protocol_version to HTTP/1.1. - I've defined two kinds of "default port". One is as defined by the spec. The other is for testing. Yuzo -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 02:18:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 02:18:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090805091832.D52EA3462D6B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #7 from Aharon (Vladimir) Lanin 2009-08-05 02:18:31 PDT --- To prevent confusion on the directionality issue, I would suggest using simpler test strings: "hi!" and "??!". The directionality is LTR if the exclamation mark comes out on the right, and RTL if it comes out on the left. > 1. In windows, Safari, FireFox, and IE all behave the same. They all display > the items in the popup list in left-to-right direction, no matter whether the > input field is an LTR or RTL field. That is not the result that I get: Firefox 3.0.11: always in browser language directionality (i.e. LTR) Safari 4.0.2: always in element directionality (i.e. RTL for the test page) Opera 9.64: did not auto-complete IE 7: did not auto-complete Thus, Firefox, Safari, and Chrome on Windows all do different things. It is important to point out that displaying a value in the right directionality is not a nice-to-have. In the wrong directionality, the value often comes out simply garbled. For example, displaying "17 Main St." as ".Main St 17", which is what comes out when it is displayed RTL, is simply wrong. BTW, the current Chrome bug that the drop-down is always left-aligned, even for a dir=rtl align=right element, is also a bug. No one else does that. Chrome has the same bug for elements. There are Chrome bugs on the wrong alignment for both autofill and , a webpage should be using auto-detect script to detect/display its text directionality automatically? If the auto-detect only applies to display text in pop-up list, that will cause in-consistency of the text displayed in input (or page: https://bugs.webkit.org/attachment.cgi?id=14607&action=view If you select the 2nd item, you can see the text displayed in the option box (with "English" at very right) and text displayed in the pop-up list ("English" displayed at the very left) are laid-out different. The text in option box is displayed as LTR (because the dir of but not in autofill). Thanks, Xiaomei > Failing that, Safari's approach of using > the element's current directionality for all the items in the dropdown is still > pretty much ok, since the likelihood that any given user will have entered both > LTR and RTL values for a single field is not very high. In fact, it is in fact > probably the better approach when the page does not have the directionality > auto-detection scripts I mentioned earlier. > But Firefox's approach of always > using the browser language's directionality is totally nonsensical: RTL pages > taking consistently RTL inputs will always have the dropdown values garbled. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:45:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:45:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27874] Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp In-Reply-To: References: Message-ID: <20090805194507.7C51E3467938@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27874 --- Comment #9 from Gavin Barraclough 2009-08-05 12:45:06 PDT --- It might be worth noting that these mallocs and frees will just go away at some point ??these will be replaced with a stack-based allocator, though I don't have a timescale for this right now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:46:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:46:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090805194633.F0349346797B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #9 from Xiaomei Ji 2009-08-05 12:46:32 PDT --- Created an attachment (id=34161) --> (https://bugs.webkit.org/attachment.cgi?id=34161) Safari 4.0.2 display "!BA" -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:46:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:46:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19161] wrong font size when css font-family includes monospace In-Reply-To: References: Message-ID: <20090805194650.7E99B34679A6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19161 --- Comment #18 from Eric Seidel 2009-08-05 12:46:47 PDT --- Created an attachment (id=34162) --> (https://bugs.webkit.org/attachment.cgi?id=34162) First (somewhat blind) stab at this. --- 2 files changed, 18 insertions(+), 23 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:54:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:54:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28004] [chromium] setting listeners on MessagePorts doesn't work in the worker process In-Reply-To: References: Message-ID: <20090805195459.8E3FC3467B13@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28004 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34098|review? |review+, commit-queue+ Flag| | --- Comment #2 from Dimitri Glazkov (Google) 2009-08-05 12:54:59 PDT --- (From update of attachment 34098) > + return PassRefPtr(); return 0; will work just fine, too. Why are we duplicating these in *Custom files? The logic is the same. Can we possibly use a template or generate these? If you're not up to mucking with this, can you file a bug about this? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:55:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:55:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28004] [chromium] setting listeners on MessagePorts doesn't work in the worker process In-Reply-To: References: Message-ID: <20090805195544.761873467B27@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28004 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dglazkov at chromium.org AssignedTo|webkit-unassigned at lists.web |dglazkov at chromium.org |kit.org | --- Comment #3 from Dimitri Glazkov (Google) 2009-08-05 12:55:43 PDT --- Assigned for landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:56:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:56:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090805195657.AD6D63467B77@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34127|review? |review+ Flag| | --- Comment #90 from Gavin Barraclough 2009-08-05 12:56:52 PDT --- (From update of attachment 34127) Zoltan, did I see you get commit rights to svn? Leaving this for you to land, if I'm wrong & you need this landing for you then ping me & will be happy to do so. G. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:57:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:57:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805195748.AC9383467B9D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 --- Comment #8 from Mark Rowe (bdash) 2009-08-05 12:57:47 PDT --- I sped up http/tests/misc/DOMContentLoaded-event.html and http/tests/navigation/multiple-back-forward-entries.html dramatically in r46808. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:58:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:58:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28024] Need AtomicStrings for the various font family names In-Reply-To: References: Message-ID: <20090805195833.593A13467BC5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28024 --- Comment #1 from Eric Seidel 2009-08-05 12:58:32 PDT --- Turns out that the various Names::init() calls are made from Frame(...), I'm surprised by this. It's probably "wrong" in that we could have a Page which wanted to use the various Names* calls before the first Frame was created... but oh well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:01:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:01:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090805200142.4CFC03467C67@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34128|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:06:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:06:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090805200611.11E263467D2B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Luke Kenneth Casson Leighton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34060|0 |1 is obsolete| | Attachment #34164| |review?(eric at webkit.org) Flag| | --- Comment #26 from Luke Kenneth Casson Leighton 2009-08-05 13:06:08 PDT --- Created an attachment (id=34164) --> (https://bugs.webkit.org/attachment.cgi?id=34164) tidier workaround for skipping DataGrid hiya eric, ok what do you think of this, i put in an explanation and a FIXME to say it's got to go at some point, but the main thing is that the skip test is just a single function, not a dog's dinner cut/paste job. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:07:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:07:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27999] [Gtk] SNS online banking: confirming transaction only works in debug mode In-Reply-To: References: Message-ID: <20090805200741.A36053467D61@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27999 --- Comment #2 from Dan Winship 2009-08-05 13:07:40 PDT --- does WEBKIT_DEBUG=Network do anything besides attach a SoupLogger? I can't think of any reason why SoupLogger would change its behavior... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:11:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:11:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090805201130.DF79F3467DEB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34164|review?(eric at webkit.org) |review+ Flag| | --- Comment #27 from Eric Seidel 2009-08-05 13:11:28 PDT --- (From update of attachment 34164) OK, looks fine. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:18:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:18:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27895] [XSSAuditor] Inline Event Handler with single-line JavaScript comment can bypass XSSAuditor In-Reply-To: References: Message-ID: <20090805201838.461993467EF2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27895 Daniel Bates changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33902|0 |1 is obsolete| | --- Comment #3 from Daniel Bates 2009-08-05 13:18:37 PDT --- Created an attachment (id=34165) --> (https://bugs.webkit.org/attachment.cgi?id=34165) Proposed Patch 1 with HTML Base href fix This is an updated version of the original proposed patch with base href fix. I'll file this under a separate bug, but for comparison with the alternative patch that will follow, I have left this fix in for now. Also, the change logs in this patch do not reflect the addition of the base href fix. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:19:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:19:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27895] [XSSAuditor] Inline Event Handler with single-line JavaScript comment can bypass XSSAuditor In-Reply-To: References: Message-ID: <20090805201953.893693467F29@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27895 --- Comment #4 from Daniel Bates 2009-08-05 13:19:52 PDT --- Created an attachment (id=34166) --> (https://bugs.webkit.org/attachment.cgi?id=34166) Alternative patch - as per Adam's suggestion An alternative patch for this issue as suggested by Adam. Includes Base href fix. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:21:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:21:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090805202146.993603468002@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 --- Comment #91 from Gabor Loki 2009-08-05 13:21:41 PDT --- (In reply to comment #90) > Zoltan, did I see you get commit rights to svn? Not yet. You mistake him for Zoltan Horvath. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:24:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:24:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090805202451.9587634680A4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laszlo.1.gombos at nokia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:24:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:24:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22547] Problem Rendering In-Reply-To: References: Message-ID: <20090805202458.469A134680AF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22547 --- Comment #4 from Daniel Upstone 2009-08-05 13:24:57 PDT --- Created an attachment (id=34168) --> (https://bugs.webkit.org/attachment.cgi?id=34168) Expanded to explain the real problem. I've expanded the test case to explain the real problem here. This is actually related to the freedom of table-layout: auto provided to UAs. They're not required to provide the same results as other UAs, so webkit isn't doing anything wrong here. But it does appear that webkit intends to match the (poor) behaviour displayed by other browsers in this test case and doesn't due to a bug with nesting tables. Hopefully what i've provided explains the problem clearly enough. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:25:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:25:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090805202510.CBF0734680DB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 --- Comment #92 from Gavin Barraclough 2009-08-05 13:25:07 PDT --- cheers Gabor, Akos also pointer out my mistake, I'll get this landed for you guys later today. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:27:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:27:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22547] Problem Rendering In-Reply-To: References: Message-ID: <20090805202738.96E1F346816E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22547 Daniel Upstone changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34168|0 |1 is obsolete| | --- Comment #5 from Daniel Upstone 2009-08-05 13:27:37 PDT --- Created an attachment (id=34169) --> (https://bugs.webkit.org/attachment.cgi?id=34169) Correction Sorry, that previous attachment had markup problems >_< -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:35:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:35:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27514] add support for watched expressions In-Reply-To: References: Message-ID: <20090805203510.64C733468253@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27514 --- Comment #5 from Patrick Mueller 2009-08-05 13:35:09 PDT --- Created an attachment (id=34170) --> (https://bugs.webkit.org/attachment.cgi?id=34170) patch containing work so far a mostly working version of the watch expressions based off of revision 46507 (slightly old). Not ready for review, but thought I'd get the work up here, in a state where folks can play with it. Couple of things to add: - refresh list when debugger pauses, when the call stack frame changes - provide a better gesture for delete; currently you edit the expression, delete all the text. Some kind of hover enabled button, like CSS properties checkboxes? - save / reload watched expressions between debugger invocations Not sure what to do with the "Add" button; kinda sticks out. Maybe a slightly smaller font? Not sure if we want to keep the "Refresh" button, but I think so; there is no way I can think of that we could keep the list updated while an application is running (not paused), without just refreshing it every so often. Which doesn't make any sense. But someone may want to refresh the values without pausing the application. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:49:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:49:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28021] WINCE PORT: enable CachedFont In-Reply-To: References: Message-ID: <20090805204901.73050346842C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28021 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE --- Comment #3 from Yong Li 2009-08-05 13:49:01 PDT --- will be modified and merged to bug 27734 *** This bug has been marked as a duplicate of bug 27734 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:49:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:49:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090805204902.188313468436@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 --- Comment #11 from Yong Li 2009-08-05 13:49:01 PDT --- *** Bug 28021 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:52:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:52:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27851] Fix compiler warning In-Reply-To: References: Message-ID: <20090805205206.69DA234684A6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27851 Evan Martin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |evan at chromium.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 13:53:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 13:53:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27851] mutil-char constant warning in BMPImageDecoder.cpp under gcc In-Reply-To: References: Message-ID: <20090805205320.D431A34684E5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27851 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org Summary|Fix compiler warning |mutil-char constant warning | |in BMPImageDecoder.cpp | |under gcc -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 14:04:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 14:04:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27851] mutil-char constant warning in BMPImageDecoder.cpp under gcc In-Reply-To: References: Message-ID: <20090805210442.85742346863E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27851 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33803|0 |1 is obsolete| | Attachment #34171| |review? Flag| | Status|REOPENED |ASSIGNED AssignedTo|webkit-unassigned at lists.web |pkasting at google.com |kit.org | --- Comment #6 from Peter Kasting 2009-08-05 14:04:40 PDT --- Created an attachment (id=34171) --> (https://bugs.webkit.org/attachment.cgi?id=34171) Fix two different warnings The original patch was sound. I think the test failures encountered must have been due to flakiness or another change. Verified that this still decodes BMPs OK. I also fixed another warning I just introduced (sorry!). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 14:07:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 14:07:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27874] Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp In-Reply-To: References: Message-ID: <20090805210711.272FE34686EB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27874 --- Comment #10 from Gavin Barraclough 2009-08-05 14:07:10 PDT --- (In reply to comment #7) > Weird. Was it on a MAC, wasn't it? This is on Mac, testing the YARR interpreter by setting: #define ENABLE_YARR 1 #define ENABLE_YARR_JIT 0 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 14:07:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 14:07:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090805210749.0D7703468712@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34065|review? | Flag| | Attachment #34065|0 |1 is obsolete| | Attachment #34173| |review? Flag| | --- Comment #12 from Yong Li 2009-08-05 14:07:47 PDT --- Created an attachment (id=34173) --> (https://bugs.webkit.org/attachment.cgi?id=34173) include changes to CachedFont.cpp layering violations removed according to Dan Bernstein's suggestion -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 14:13:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 14:13:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code In-Reply-To: References: Message-ID: <20090805211329.8292D34687EF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27967 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34104|review? |review- Flag| | --- Comment #2 from Dimitri Glazkov (Google) 2009-08-05 14:13:28 PDT --- (From update of attachment 34104) I think you should just name SQLTransactionClient implementation SQLTransactionClient.cpp. There's no need to do an extra suffix. If you intend to provide a separate implementation in Chromium, you can provide it in platform/chromium and name it SQLTransactionClientChromium.cpp. Overall, the idea sounds great! > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 46789) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,47 @@ > +2009-08-04 Dumitru Daniliuc > + > + Reviewed by NOBODY (OOPS!). > + > + Added a "listener" interface to SQLTransaction that allows us to You can just say a client to SQLTransaction. It's a common term here. > > > > + RelativePath="..\storage\SQLTransactionClient.h" > + > > + > + + RelativePath="..\storage\SQLTransactionClientImpl.cpp" > + > > + > + RelativePath="..\storage\SQLTransactionErrorCallback.h" > > > You will need to make changes to all build systems that currently use SQLTransaction. > Index: WebCore/storage/Database.cpp > =================================================================== > --- WebCore/storage/Database.cpp (revision 46789) > +++ WebCore/storage/Database.cpp (working copy) > @@ -50,6 +50,7 @@ > #include "SQLiteFileSystem.h" > #include "SQLiteStatement.h" > #include "SQLResultSet.h" > +#include "SQLTransactionClient.h" > #include > #endif > > @@ -136,6 +137,7 @@ Database::Database(Document* document, c > , m_deleted(false) > , m_stopped(false) > , m_opened(false) > + , m_transactionClient(new SQLTransactionClient()) What's the point of a client if you don't pass it in as an argument? > Index: WebCore/storage/SQLTransactionClientImpl.cpp > =================================================================== > +namespace WebCore { > + > +void SQLTransactionClient::databaseChanged(Database* database) { > + DatabaseTracker::tracker().scheduleNotifyDatabaseChanged(database->securityOriginCopy().get(), database->stringIdentifier()); 4 spaces, brace on new line. > +void SQLTransactionClient::databaseSizeChanged(Database* database) { brace on new line. > +bool SQLTransactionClient::databaseExceedsQuota(Database* database) { brace on new line. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 14:41:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 14:41:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090805214113.676FF3468BD4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34173|review? | Flag| | Attachment #34173|0 |1 is obsolete| | --- Comment #13 from Yong Li 2009-08-05 14:41:12 PDT --- Created an attachment (id=34178) --> (https://bugs.webkit.org/attachment.cgi?id=34178) remove unnecessary lines in FontCache.h -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 14:41:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 14:41:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090805214123.EC98D3468BE4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34178| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 14:51:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 14:51:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28027] New: Files with accents with names are submitted incorrectly due to use of precomposed Unicode Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28027 Summary: Files with accents with names are submitted incorrectly due to use of precomposed Unicode Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ap at webkit.org Steps to reproduce: 1) Mount an NFS share from a non-Mac system. 2) Create a file with an accent in its name (e.g. ?-???.txt) 3) Attach this file to a new e-mail message in Yahoo Mail. Results: the process never finishes, the spinner keeps spinning. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:00:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:00:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27059] Exclude Symbian platform from define of MIDDLE_ENDIAN In-Reply-To: References: Message-ID: <20090805220008.7BE453468EA7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27059 Norbert Leser changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32418|0 |1 is obsolete| | Attachment #34180| |review? Flag| | --- Comment #2 from Norbert Leser 2009-08-05 15:00:06 PDT --- Created an attachment (id=34180) --> (https://bugs.webkit.org/attachment.cgi?id=34180) Update of patch file for bug #27059 I updated the patch according to the review comment. Instead of adding a !SYMBIAN condition to the already hard to decipher negative conditional clause within the ARM block, I added the proper __ARM_EABI__ flag to the SYMBIAN case. In addition, I cleaned up the condition of the else branch in the ARM block (removed redundant condition check). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:13:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:13:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090805221356.416A63469074@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Antonio Gomes (tonikitoo) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |tonikitoo at gmail.com Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:15:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:15:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28028] New: Webkit r46809 won't start under MacOS X v10.5.8 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28028 Summary: Webkit r46809 won't start under MacOS X v10.5.8 Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Major Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: peter at kortge.net Created an attachment (id=34183) --> (https://bugs.webkit.org/attachment.cgi?id=34183) Screendump in .png format Webkit r46809 puts up a message:- Mac OS X 10.5 is not supported. Nightly builds of Webkit are not supported on Mac OS X 10.5 at this time. Screendump is attached. PS: Reverting back to build r46770 works OK. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:15:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:15:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28003] Cleanup: ResourceResponse should be a class, not a struct In-Reply-To: References: Message-ID: <20090805221519.6468D34690C8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28003 Michael Nordman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34184| |review? Flag| | --- Comment #1 from Michael Nordman 2009-08-05 15:15:18 PDT --- Created an attachment (id=34184) --> (https://bugs.webkit.org/attachment.cgi?id=34184) struct -> class patch Not much here, just some house cleaning. I think I've got all of them in the webkit repository. There are a few in chrome's repository to get as well once this lands and rolls into view for us there. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:16:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:16:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28029] New: Fix DOM Storage memory leak Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28029 Summary: Fix DOM Storage memory leak Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jorlow at chromium.org CC: fishd at chromium.org Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34185| |review? Flag| | Created an attachment (id=34185) --> (https://bugs.webkit.org/attachment.cgi?id=34185) Patch v1 Forgot to use adoptRef in one place. This caused the = operator to increment the ref count when it should have just left it as is. The result of this was that StorageAreaImpl's were never being freed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:16:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:16:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28030] New: Page rendered wrong on Chrome because of
float:left Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28030 Summary: Page rendered wrong on Chrome because of
float:left Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.baixaki.com.br/perfil/522638/papeis-de-pare de/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org I Steps: Go to http://www.baixaki.com.br/perfil/522638/papeis-de-parede/ II Issue: layout issue seen III Conclusion: Issue is caused by the float:left of the
before the table. IV Other Browsers: IE7: ok FF3: ok V Nightly tested: 46809 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=13889 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:16:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:16:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28030] Page rendered wrong on Chrome because of
float:left In-Reply-To: References: Message-ID: <20090805221655.2393C346910E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28030 --- Comment #1 from jasneet 2009-08-05 15:16:54 PDT --- Created an attachment (id=34186) --> (https://bugs.webkit.org/attachment.cgi?id=34186) reduced testcase -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:17:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:17:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28030] Page rendered wrong on Chrome because of
float:left In-Reply-To: References: Message-ID: <20090805221703.A8B5C346911E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28030 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:18:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:18:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28029] Fix DOM Storage memory leak In-Reply-To: References: Message-ID: <20090805221800.6AA9D3469158@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28029 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34185|review? | Flag| | Attachment #34185|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:18:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:18:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28029] Fix DOM Storage memory leak In-Reply-To: References: Message-ID: <20090805221812.9F24A3469173@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28029 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34187| |review? Flag| | --- Comment #1 from Jeremy Orlow 2009-08-05 15:18:11 PDT --- Created an attachment (id=34187) --> (https://bugs.webkit.org/attachment.cgi?id=34187) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:20:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:20:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28027] Files with accents with names are submitted incorrectly due to use of precomposed Unicode In-Reply-To: References: Message-ID: <20090805222026.E1D1934691B2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28027 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34188| |review? Flag| | Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |ap at webkit.org |kit.org | --- Comment #1 from Alexey Proskuryakov 2009-08-05 15:20:26 PDT --- Created an attachment (id=34188) --> (https://bugs.webkit.org/attachment.cgi?id=34188) proposed fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:23:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:23:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28029] Fix DOM Storage memory leak In-Reply-To: References: Message-ID: <20090805222301.152E23469201@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28029 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34187|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:24:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:24:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28028] Webkit r46809 won't start under MacOS X v10.5.8 In-Reply-To: References: Message-ID: <20090805222410.ADB243469239@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28028 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrowe at apple.com --- Comment #1 from Mark Rowe (bdash) 2009-08-05 15:24:10 PDT --- r46809 works fine on my Mac OS X 10.5.8 machine. Do you still have the version of WebKit.app that causes this problem? Does it still reproduce? If so, please keep that version of the build around so that I can take a look at it. Does it reproduce if you re-download that build? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:24:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:24:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28028] Webkit nightlies occasionally claim not to support Mac OS X 10.5 In-Reply-To: References: Message-ID: <20090805222439.52266346924D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28028 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Webkit r46809 won't start |Webkit nightlies |under MacOS X v10.5.8 |occasionally claim not to | |support Mac OS X 10.5 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 15:48:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 15:48:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28029] Fix DOM Storage memory leak In-Reply-To: References: Message-ID: <20090805224853.9857234694AA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28029 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Jeremy Orlow 2009-08-05 15:48:52 PDT --- Sending WebCore/ChangeLog Sending WebCore/storage/StorageNamespaceImpl.cpp Transmitting file data .. Committed revision 46818. http://trac.webkit.org/changeset/46818 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:01:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:01:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28031] New: image doesn't render when width and height are defined in percentage with
as its parent elements Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28031 Summary: image doesn't render when width and height are defined in percentage with
as its parent elements Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://thedlpgroup.com/index.htm OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=34189) --> (https://bugs.webkit.org/attachment.cgi?id=34189) reduced testcase I Steps: Go to http://thedlpgroup.com/index.htm II Issue: background image not loading III Conclusion: width and height defined in percentage of image tag which is defined in
elements is causing this issue. Removing the percentage values work fine. Note: quirks mode doesn't work in IE either. IV Other Browsers: IE7: ok FF3: ok V Nightly tested: 46809 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=14949 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:01:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:01:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28031] image doesn't render when width and height are defined in percentage with
as its parent elements In-Reply-To: References: Message-ID: <20090805230122.3729A346960A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28031 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:15:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:15:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28032] New: [www.problematique.ru]: Navigation panel is not rendered Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28032 Summary: [www.problematique.ru]: Navigation panel is not rendered Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.problematique.ru/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=34190) --> (https://bugs.webkit.org/attachment.cgi?id=34190) reduced testcase I Steps: Go to http://www.problematique.ru/ II Issue: right navigation column not loading III Conclusion: the second div(red-border) is not visible in webkit because its left margin is set to -230px. while with this setting in IE and Firefox, the div floats to the end of first div (green border). IV Other Browsers: IE7: ok FF3: ok V Nightly tested: 46809 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=14246 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:15:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:15:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28032] [www.problematique.ru]: Navigation panel is not rendered In-Reply-To: References: Message-ID: <20090805231541.1F2CE34697DD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28032 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:16:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:16:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28028] Webkit nightlies occasionally claim not to support Mac OS X 10.5 In-Reply-To: References: Message-ID: <20090805231605.A29F434697EB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28028 --- Comment #2 from Peter KORTGE 2009-08-05 16:16:05 PDT --- (In reply to comment #1) > r46809 works fine on my Mac OS X 10.5.8 machine. Do you still have the version > of WebKit.app that causes this problem? Does it still reproduce? If so, > please keep that version of the build around so that I can take a look at it. > Does it reproduce if you re-download that build? Unfortunately, I deleted the updated build when it wouldn't load and reverted back to build 46770. Have now again run the "Check for Webkit Updates ..." and the r46809 patch has been applied and all works OK. May have been a problem with the updater (I was also downloading the 10.5.8 & Garage Band patches at the same time)? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:17:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:17:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090805231728.D69BF346985B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34129|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:18:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:18:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090805231823.AA2C834698B7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 --- Comment #93 from Gavin Barraclough 2009-08-05 16:18:18 PDT --- (From update of attachment 34129) (1) ensureSpaceFor The basic design of this I'm happy with, the idea of enumerating the sequences seems nice and clean, but I do have two small concerns. First is the method name - I think it could be clearer, and more explicit. The method name makes sense in the context of ARM, where you have a constant pool, but for developers on other platforms it is unclear as to the purpose of the call.I'd suggest a better name would include something like UninterruptedInstructionSequence, which would be more descriptive of *why* this is being called. Also, I'm uncomfortable with the use of magic constants that are unchecked (note that all the 'patchOffset' constants in the JIT are guarded by ASSERTs). If someone changes the code generation in a way that could break on ARM, why should have an automatic way of detecting this. I'd suggest that you can fix this by having 'begin' and 'end' methods in the MacroAssemberARM, and #ifndef NDEBUG check that the values passed are correct. I'd suggest something like this (with MacroAssemblerARM::beginUninterruptedInstructionSequence replacing MacroAssemblerARM::ensureSpace, and MacroAssemblerARM::endUninterruptedInstructionSequence called at the end of the sequence as appropriate - both method names just suggestions, I'm open to improvements), would both be more explicitly named, and would provide checking of at least one of the magic constants: void beginUninterruptedInstructionSequence(int insnSpace, int constSpace) { #ifndef NDEBUG m_uninterruptedInstructionsBegin = label(); m_uninterruptedInstructionSpace = insnSpace; #endif m_assembler.ensureSpace(insnSpace, constSpace); } void endUninterruptedInstructionSequence() { ASSERT(differenceBetween(m_uninterruptedInstructionsBegin, label()) == m_uninterruptedInstructionSpace); } #ifndef NDEBUG Label m_uninterruptedInstructionsBegin; int m_uninterruptedInstructionSpace; #endif If you could also preserve and test 'constSpace' in a similar fashion (could you record the number of entries in the pool in 'begin', and again check the difference in 'end'?), then that would be even better. (2) enableLatePatch This seems to be tied to an assembler specific internal optimization, I don't think that explicitly exposing this in common code in this fashion is the right API here. The purpose of this flag appears to be to force calls to be generated using a constant pool entry, rather than as a relative branch. A simple short-term solution would seem to replace the 'm_latePatch' bit with a flag indicating whether the JmpSrc is a jump or a call, and to only plant relative branches for jumps. With this change the calls to enableLatePatch() should be unnecessary - all calls can be repatched. (As a note on a longer term direction, we expect at some point to be able to move the Label, Jump, Call, etc classes out of AbstractMacroAssembler and into their own header, then push these types down into the assemblers so that each assembler does not need define its own JmpSrc & JmpDst types - so in the long run I think we'd expect to be able to distinguish between jumps & calls anyway). This suggested change is based on the assumption that the ability to link branches without a constant pool entry is an optimization that only really benefits jumps, not calls. I'd be resistant to introduce any additional API unless there is a demonstrable benefit here. If there is a measurable performance benefit from doing so, then I'd suggest the right place to add API would be in LinkBuffer::link(Call, FunctionPtr). Ultimately this is not about the call instruction itself being different, but the way that the link will be performed being different. I'd suggest adding a third argument to this method - ", bool isFinal = false" (I've inverted the logic from 'enable' here - I'd suggest the default behaviour should be to allow the call to be relinked, and if we do need to do so we should explicitly specify cases where optimization can take place). For calls that are *not* currently being marked as 'enableLatePatch', you could instead pass isFinal as true when linking, which should result in exactly the same code generation from the ARM JIT as you are presently producing. But I'd like to see performance numbers to back up any API change, since I do expect that the benefit is really coming from planting relative branches for jumps rather than calls. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:18:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:18:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28003] Cleanup: ResourceResponse should be a class, not a struct In-Reply-To: References: Message-ID: <20090805231836.D645334698D3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28003 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34184|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:19:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:19:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28028] Webkit nightlies occasionally claim not to support Mac OS X 10.5 In-Reply-To: References: Message-ID: <20090805231913.C56CD34698EB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28028 --- Comment #3 from Mark Rowe (bdash) 2009-08-05 16:19:13 PDT --- It seems like there must be a race condition. I've heard one or two reports of this before, but no-one has been able to reproduce which makes this tricky to investigate :-( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:21:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:21:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090805232145.9717B3469941@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Nikolas Zimmermann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34119|review?(zimmermann at kde.org) |review- Flag| | --- Comment #28 from Nikolas Zimmermann 2009-08-05 16:21:44 PDT --- (From update of attachment 34119) Hi Charles, r-, because the old review comments still apply. Still hardcoded things in CSSStyleSelector that should go in a .css file, and the RenderMarquee changes that affect HTML. These are the only remaining issues, the introduction of the new .in files look good. Have a nice day, NIko -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:21:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:21:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090805232159.A4182346995B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Nikolas Zimmermann changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zimmermann at kde.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:23:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:23:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] New: Win DRT is missing implementations for some resource load delegate callbacks Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28033 Summary: Win DRT is missing implementations for some resource load delegate callbacks Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows XP Status: NEW Keywords: InRadar Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: beidson at apple.com Win DRT is missing implementations for some resource load delegate callbacks. Has been tracked in radar by -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:23:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:23:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090805232342.B4CAB34699CD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34130|review? |review- Flag| | --- Comment #94 from Gavin Barraclough 2009-08-05 16:23:39 PDT --- (From update of attachment 34130) This patch is dependent on the call patch that I've just reviewed & asked for changes. I have no objections to this patch and expect this patch to be a simple r+ as soon as the call patch gets okayed. But since this is blocked on the other patch, and since I think you're going to need a new version of this to update some behaviour here (re the comments on the call patch), I'm going to r- for now to take this out of the review queue. G. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:31:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:31:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28009] [Android] Browser app is forced to terminate when access to a site with a 10MB gif image In-Reply-To: References: Message-ID: <20090805233138.4BD713469AD5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28009 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Browser app is forced to |[Android] Browser app is |terminate when access to a |forced to terminate when |site with a 10MB gif image |access to a site with a | |10MB gif image --- Comment #1 from Mark Rowe (bdash) 2009-08-05 16:31:37 PDT --- You're probably better off reporting this issue to the Android developers directly. I don't think they're working out of our SVN repository at this point, so they may not be following Bugzilla. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:34:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:34:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] Win DRT is missing implementations for some resource load delegate callbacks In-Reply-To: References: Message-ID: <20090805233454.920FC3469B4A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28033 Brady Eidson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34191| |review? Flag| | --- Comment #1 from Brady Eidson 2009-08-05 16:34:53 PDT --- Created an attachment (id=34191) --> (https://bugs.webkit.org/attachment.cgi?id=34191) didReceiveResponse (other missing ones can come later) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:38:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:38:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] Win DRT is missing implementations for some resource load delegate callbacks In-Reply-To: References: Message-ID: <20090805233805.1B55F3469BA5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28033 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34191|review? |review+ Flag| | --- Comment #2 from Darin Adler 2009-08-05 16:38:04 PDT --- (From update of attachment 34191) Can't we use smart pointers for the BSTR? r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:43:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:43:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] Win DRT is missing implementations for some resource load delegate callbacks In-Reply-To: References: Message-ID: <20090805234347.298BE3469C5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28033 --- Comment #3 from Brady Eidson 2009-08-05 16:43:46 PDT --- I don't think we use any sort of BSTR smart pointer anywhere else in WinDRT - Do we have one available? I know that - at least at one time - there wasn't one available. Thanks for the review! Sending LayoutTests/ChangeLog Sending LayoutTests/platform/win/Skipped Deleting LayoutTests/platform/win/http/tests/security Sending WebKitTools/ChangeLog Sending WebKitTools/DumpRenderTree/win/ResourceLoadDelegate.cpp Sending WebKitTools/DumpRenderTree/win/ResourceLoadDelegate.h Transmitting file data ..... Committed revision 46820. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:45:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:45:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27059] Exclude Symbian platform from define of MIDDLE_ENDIAN In-Reply-To: References: Message-ID: <20090805234512.B55D83469CA4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27059 --- Comment #3 from Darin Adler 2009-08-05 16:45:11 PDT --- (From update of attachment 34180) Seems unfortunate to define something that begins with two underscores, since that's supposed to be reserved for the environment, not the library. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:59:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:59:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28034] New: layout issue due to float:left of

preceding table Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28034 Summary: layout issue due to float:left of

preceding table Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.forum.magnifiquelingerie.com/viewtopic.php? f=6&t=107 OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=34192) --> (https://bugs.webkit.org/attachment.cgi?id=34192) reduced testcase I Steps: Go to http://www.forum.magnifiquelingerie.com/viewtopic.php?f=6&t=107 II Issue: posts should be aligned below Print view and more towards right side III Conclusion: The issue is caused by the float:left of the

preceding the

that has the page contents. IV Other Browsers: IE7: ok FF3: ok V Nightly tested: 46809 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=18001 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:59:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:59:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28034] layout issue due to float:left of

preceding table In-Reply-To: References: Message-ID: <20090805235923.C76FD3469E10@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28034 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 17:09:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 17:09:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28035] New: Bad rendering of web page because of image's height is set to 100% Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28035 Summary: Bad rendering of web page because of image's height is set to 100% Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://rapid.tvphp.net/?q=margulis+%22professional+pho toshop%22 OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=34193) --> (https://bugs.webkit.org/attachment.cgi?id=34193) reduced testcase I Steps: Go to http://rapid.tvphp.net/?q=margulis+%22professional+photoshop%22 II Issue: The entries are successively further and further to the right and the red arrows appear much to large as a kind of backdrop. III Conclusion: The issue is caused by the float:left of the

preceding the

that has the page contents. IV Other Browsers: IE7: ok FF3: ok V Nightly tested: 46809 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=17770 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 17:09:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 17:09:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28035] Bad rendering of web page because of image's height is set to 100% In-Reply-To: References: Message-ID: <20090806000918.01A1E3469EFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28035 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 17:36:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 17:36:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27895] [XSSAuditor] Inline Event Handler with single-line JavaScript comment can bypass XSSAuditor In-Reply-To: References: Message-ID: <20090806003659.CEC49346A1E4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27895 --- Comment #5 from Daniel Bates 2009-08-05 17:36:58 PDT --- Let "Proposed Patch 1" be called Patch 1, and "Alternative patch" be called Patch 2. I am tending to favor the Patch 1, because it has the advantage of fixing the issue without clobbering the value of the inline event handler or base href. Thus, a JavaScript DOM traversal matches the structure seen when you View Source, even though the inline event handler and base href are ignored. Additionally, it does not produce any false positives compared to Patch 2 (though, from a conversation with Adam, we can probably get away with it since such false positives are detected as part of an injection attempt). Examples: 1) Inline Event Handler http://good.webblaze.org/dbates/xsstest-printDOM.php?q=%3Cimg%20src=%22about:blank%22%20onerror=%22alert(/XSS/)%22/%3E 2) Base Href http://good.webblaze.org/dbates/xsstest-printDOM-basehref.php?q= Notice, either patch prevents the execution of the above, but Patch 1 does not nullify neither the onerror nor href attributes so the the DOM traversal matches the View Source structure. False positive for Patch 2: http://good.webblaze.org/dbates/xsstest.php?q= Because Patch 2 only looks for attributes that start with "on" and whose length is >= 5 characters (*), this is detected as an attack, even though ondummy is not a valid attribute Difference between "Proposed Patch 1" (Patch 1) and "Alternative patch" (Patch 2): Patch 1 defines a subclass of MappedAttribute, called MappedAttributeWithRawCharacters (I'm open to name suggestions) that stores the value of |m_rawAttributeBeforeValue| extracted in the HTMLTokenizer. The HTMLTokenizer creates attributes of class MappedAttributeWithRawCharacter. So, such attributes are passed along through the WebKit framework. If the attribute A corresponds to an inline event handler and A->isMappedAttributeWithRawCharacters() is true then in ScriptEventListener we cast it to MappedAttributeWithRawCharacter and pass the stored | m_rawAttributeBeforeValue| to the XSSAuditor. Similarly, we do the same in HTMLBaseElement. Patch 2 is implemented in the HTMLTokenizer. It detects attributes described by (*) or detects the href attribute of a tag. It then passes this information to the XSSAuditor. If the XSSAuditor methods return false then the corresponding attribute is set to the empty string (hence the clobbered result). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 17:40:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 17:40:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27895] [XSSAuditor] Inline Event Handler with single-line JavaScript comment can bypass XSSAuditor In-Reply-To: References: Message-ID: <20090806004016.AEBB3346A225@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27895 --- Comment #6 from Daniel Bates 2009-08-05 17:40:15 PDT --- Oh, forgot to mention. An alternative implementation of Patch 1, to get rid of the static_cast Adam brought up, is to add the method rawAttributeBeforeValue() directly to the MappedAttribute class. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 18:03:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 18:03:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27836] Stale database version persists through browser refresh In-Reply-To: References: Message-ID: <20090806010326.08EB7346A4B6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27836 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #1 from Alexey Proskuryakov 2009-08-05 18:03:25 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 18:03:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 18:03:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27836] Stale database version persists through browser refresh In-Reply-To: References: Message-ID: <20090806010351.CD623346A4C6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27836 --- Comment #2 from Alexey Proskuryakov 2009-08-05 18:03:51 PDT --- even. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 18:31:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 18:31:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] Win DRT is missing implementations for some resource load delegate callbacks In-Reply-To: References: Message-ID: <20090806013110.C148D346A729@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28033 --- Comment #4 from Brady Eidson 2009-08-05 18:31:10 PDT --- Darin reviewed this in person. Added 3 more missing methods, and removed a skipped test. Sending LayoutTests/ChangeLog Sending LayoutTests/platform/win/Skipped Sending WebKitTools/ChangeLog Sending WebKitTools/DumpRenderTree/win/FrameLoadDelegate.cpp Sending WebKitTools/DumpRenderTree/win/FrameLoadDelegate.h Transmitting file data ..... Committed revision 46824. Maybe we should leave this bugzilla open as there are still many missing delegate methods. Maybe some other tests on the skipped list are related. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:20:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:20:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] New: [Qt] Public API to configure the storage path for HTML5 localStorage Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28036 Summary: [Qt] Public API to configure the storage path for HTML5 localStorage Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: laszlo.1.gombos at nokia.com This API allows to change the path for the HTML5 localstorage per page. The proposal essentially converts the existing private API into a public API. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:27:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:27:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090806042758.5C9B2346B848@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34198| |review? Flag| | --- Comment #1 from Laszlo Gombos 2009-08-05 21:27:57 PDT --- Created an attachment (id=34198) --> (https://bugs.webkit.org/attachment.cgi?id=34198) proposed api -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:28:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:28:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090806042856.A19F8346B856@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hausmann at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:29:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:29:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090806042923.552BE346B864@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenneth.christiansen at openbo | |ssa.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:53:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:53:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] Win DRT is missing implementations for some resource load delegate callbacks In-Reply-To: References: Message-ID: <20090806045323.3D681346BA70@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28033 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |fishd at chromium.org Resolution| |FIXED AssignedTo|webkit-unassigned at lists.web |beidson at apple.com |kit.org | --- Comment #5 from Darin Fisher (:fishd, Google) 2009-08-05 21:53:21 PDT --- Looks like this can be closed as FIXED. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:55:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:55:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28003] Cleanup: ResourceResponse should be a class, not a struct In-Reply-To: References: Message-ID: <20090806045520.A5017346BA9F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28003 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34184| |commit-queue- Flag| | --- Comment #2 from Darin Fisher (:fishd, Google) 2009-08-05 21:55:19 PDT --- (From update of attachment 34184) commit-queue- because I need to land this in conjunction with a chromium patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:01:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:01:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27939] WebInspector: Extract style editing into a separate file that is going to be loaded in page context. In-Reply-To: References: Message-ID: <20090806050142.58C90346BB26@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27939 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fishd at chromium.org AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:02:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:02:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28003] Cleanup: ResourceResponse should be a class, not a struct In-Reply-To: References: Message-ID: <20090806050204.2B097346BB42@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28003 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fishd at chromium.org AssignedTo|webkit-unassigned at lists.web |michaeln at google.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:23:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:23:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090806052324.DFE12346BD5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 --- Comment #95 from Gavin Barraclough 2009-08-05 22:23:19 PDT --- Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/ARMAssembler.cpp Sending JavaScriptCore/assembler/AbstractMacroAssembler.h Sending JavaScriptCore/assembler/MacroAssemblerARM.h Sending JavaScriptCore/bytecode/CodeBlock.h Sending JavaScriptCore/jit/JIT.h Sending JavaScriptCore/jit/JITInlineMethods.h Sending JavaScriptCore/jit/JITOpcodes.cpp Sending JavaScriptCore/jit/JITStubs.cpp Sending JavaScriptCore/jit/JITStubs.h Sending JavaScriptCore/wtf/Platform.h Transmitting file data ........... Committed revision 46831. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:33:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:33:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090806053343.7E7FD346BE32@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 --- Comment #96 from Gavin Barraclough 2009-08-05 22:33:40 PDT --- Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/ARMAssembler.cpp Sending JavaScriptCore/assembler/ARMAssembler.h Sending JavaScriptCore/assembler/MacroAssemblerARM.h Sending JavaScriptCore/jit/JIT.h Transmitting file data ..... Committed revision 46832. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:34:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:34:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] New: SocketStreamHandle interface for WebSocket API Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28037 Summary: SocketStreamHandle interface for WebSocket API Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ukai at chromium.org SocketStreamHandle will be used for backend of WebSocket API. These will be added in WebCore/platform/network -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:37:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:37:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] New: WebSocket API implementation Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28038 Summary: WebSocket API implementation Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ukai at chromium.org WebSocket API implementation based on SocketStreamHandle (cf. http://bugs.webkit.org/show_bug.cgi?id=28037) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:50:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:50:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27659] IMGs don't animate in Safari In-Reply-To: References: Message-ID: <20090806055021.6CE77346BF8C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27659 --- Comment #4 from Aditya Mukherjee 2009-08-05 22:50:20 PDT --- They're being animated by Javascript (jQuery's "animate()" function). I believe it's a simple change of width and height from 0 to the final value with "setIntervals". [I hope that's the answer you were looking for?] -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:54:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:54:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28039] New: Show inherited styles for a selected DOM element Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28039 Summary: Show inherited styles for a selected DOM element Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Enhancement Priority: P3 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: aditya.vm at gmail.com When an element is selected in the "Elements" tab, the styles shown on the right are only the ones that directly affect the particular element. For example, when inspecting a "div#first", the styles shown will only be for "#first" and "div". Firebug shows all the styles that the current element inherits as well, so you would see those two, along with "body" and any other parent element. This is very useful in figuring out where a particular style is coming from when working with complicated hierarchies. I suggest Firebug's behaviour be added to Web Inspector. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:56:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:56:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28039] Show inherited styles for a selected DOM element In-Reply-To: References: Message-ID: <20090806055627.7EB53346C038@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28039 --- Comment #1 from Aditya Mukherjee 2009-08-05 22:56:27 PDT --- Created an attachment (id=34199) --> (https://bugs.webkit.org/attachment.cgi?id=34199) Web Inspector's display of styles for an element div#eyebrowwide -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:57:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:57:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28039] Show inherited styles for a selected DOM element In-Reply-To: References: Message-ID: <20090806055723.8DCDE346C04F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28039 --- Comment #2 from Aditya Mukherjee 2009-08-05 22:57:23 PDT --- Created an attachment (id=34200) --> (https://bugs.webkit.org/attachment.cgi?id=34200) Firebug's display of styles for element div#eyebrowwide -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:09:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:09:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28012] WebKit crashes because of Slashdot.org main page Javascript/CSS. In-Reply-To: References: Message-ID: <20090806060934.0855B346C1AD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28012 --- Comment #2 from red47514f7 at yandex.ru 2009-08-05 23:09:33 PDT --- Still crashes in r46809 nightly (just in case..) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:09:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:09:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28039] Show inherited styles for a selected DOM element In-Reply-To: References: Message-ID: <20090806060943.E7BA5346C1BD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28039 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com, | |timothy at hatcher.name --- Comment #3 from Timothy Hatcher 2009-08-05 23:09:43 PDT --- Hyatt, what would be the best way to get this info out of the engine? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:26:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:26:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27879] Allow custom memory allocation control for JavaScriptCore's Noncopyable class In-Reply-To: References: Message-ID: <20090806062656.7F596346C3A9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27879 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33875| |commit-queue+ Flag| | --- Comment #6 from Adam Barth 2009-08-05 23:26:54 PDT --- (From update of attachment 33875) Olliej said this was fine on IRC. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:27:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:27:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27877] Allow custom memory allocation control for JavaScriptCore's PolymorphicAccessStructureList struct In-Reply-To: References: Message-ID: <20090806062733.70A6E346C3CD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27877 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33874| |commit-queue+ Flag| | --- Comment #3 from Adam Barth 2009-08-05 23:27:32 PDT --- (From update of attachment 33874) Olliej says this one is fine too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:28:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:28:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27875] Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct In-Reply-To: References: Message-ID: <20090806062807.EB3C5346C3F3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27875 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33872| |commit-queue+ Flag| | --- Comment #3 from Adam Barth 2009-08-05 23:28:07 PDT --- (From update of attachment 33872) As is this one. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:45:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:45:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28015] [Chromium] @font-face is not supported on Linux In-Reply-To: References: Message-ID: <20090806064550.9BF8F346C68F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28015 Yusuke Sato changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34125|review? | Flag| | Attachment #34125|0 |1 is obsolete| | --- Comment #3 from Yusuke Sato 2009-08-05 23:45:49 PDT --- Created an attachment (id=34203) --> (https://bugs.webkit.org/attachment.cgi?id=34203) Proposed fix for 28015 (v2) Thanks! Replaced all defined(__linux__)s with PLATFORM(LINUX). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:46:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:46:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28015] [Chromium] @font-face is not supported on Linux In-Reply-To: References: Message-ID: <20090806064649.AF4D4346C6B3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28015 Yusuke Sato changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34203| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:58:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:58:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27875] Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct In-Reply-To: References: Message-ID: <20090806065802.2B343346C7EE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27875 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33872|review+ | Flag| | --- Comment #4 from Adam Barth 2009-08-05 23:58:00 PDT --- (From update of attachment 33872) Clearing review flag on attachment: 33872 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/parser/Nodes.h Committed r46837 M LayoutTests/platform/gtk/Skipped M LayoutTests/ChangeLog r46836 = 75353465f722f91d89afde0ce2a14f7179576a66 (trunk) M JavaScriptCore/ChangeLog M JavaScriptCore/parser/Nodes.h r46837 = c4b3d98c6a56bb0a0b54922f9c686624656ddf8e (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46837 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:58:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:58:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27875] Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct In-Reply-To: References: Message-ID: <20090806065807.74DDB346C806@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27875 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Adam Barth 2009-08-05 23:58:06 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 00:39:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 00:39:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27984] cpp_style.py lacks checks for pointer and reference declaration style. In-Reply-To: References: Message-ID: <20090806073923.9140F346CC1B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27984 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34137|review? |review- Flag| | --- Comment #5 from David Levin 2009-08-06 00:39:21 PDT --- (From update of attachment 34137) Although less comprehensive, it has far less false positives than before which is awesome. Just a few comments to consider and then we'll be all done! > diff --git a/WebKitTools/Scripts/modules/cpp_style.py b/WebKitTools/Scripts/modules/cpp_style.py > + if filename.endswith('.cpp'): > + # C++ Pointer declaration should have the * beside the type not the variable name. > + matched = search(r'^\s*\w+\s\*\w+', line) It seems like this should have the return in its as well. Also match works well here since this always starts at the beginning of the string. The second \s would match more if it were \s+ Or in code (added a word break before the return) matched = match(r'\s*\w+(? + if matched: > + error(filename, line_number, 'whitespace/declaration', 3, > + 'Pointer declaration has space between type name and * ( in %s' % matched.group(0).strip()) I don't understand the "(" in error message. All of these comments apply to the "&" block as well, so it just seems better if it were the same code like this: # C++ should have the & or * beside the type not the variable name. matched = match(r'\s*\w+(?\*|\&)\w+', line) if matched: error(filename, line_number, 'whitespace/declaration', 3, 'Reference declaration has space between type name and %s in %s' % (matched.group('pointer_operator'), matched.group(0).strip())) > + > + elif filename.endswith('.c'): > + # C Pointer declaration should have the * beside the variable not the type name. > + matched = search(r'^\s*\w+\*\s\w+', line) Suggested: matched = match(r'\s*\w+\*\s+\w+', line) > + if matched: > + error(filename, line_number, 'whitespace/declaration', 3, > + 'Pointer declaration has space between * and variable name( in %s' % matched.group(0).strip()) I don't understand the "(" in error message. > diff --git a/WebKitTools/Scripts/modules/cpp_style_unittest.py b/WebKitTools/Scripts/modules/cpp_style_unittest.py Please add test for return *b; -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 00:57:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 00:57:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28015] [Chromium] @font-face is not supported on Linux In-Reply-To: References: Message-ID: <20090806075735.7BDC7346CDB7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28015 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34203|review? |review- Flag| | --- Comment #4 from David Levin 2009-08-06 00:57:34 PDT --- (From update of attachment 34203) These are only style comments but enough adjustments to r- for now. Would you ask someone on the linux team (maybe agl@) to code review this for substance (and put their comments into this bug)? Then please wait to put your patch up for r? until you get their feedback and address it. And together with their review, I'll feel comfortable with this. > Index: WebCore/platform/graphics/chromium/FontCustomPlatformData.cpp > + return FontPlatformData(m_fontReference, > + size, > + bold && !m_fontReference->isBold(), > + italic && !m_fontReference->isItalic()); There is no line length restriction in WebKit so feel free to unwrap this but only if you think it will read better. > #else > notImplemented(); > return FontPlatformData(); > @@ -186,6 +200,51 @@ static String createUniqueFontName() > } > #endif > > +#if PLATFORM(LINUX) > +class RemoteFontStream : public SkStream { > +public: > + explicit RemoteFontStream(RefPtr buffer) Use PassRefPtr instead of RefPtr for parameters. > + virtual bool rewind() > + { > + offset_ = 0; > + return true; indent by 4 spaces. (I think check-webkit-style would catch this.) > +private: > + RefPtr buffer_; > + size_t offset_; Use m_ for member variables. Not variable_. > +#elif PLATFORM(LINUX) > + RemoteFontStream stream(buffer); > + SkTypeface* tf = SkTypeface::CreateFromStream(&stream); Use full words for variable names (not "tf"). > Index: WebCore/platform/graphics/chromium/FontCustomPlatformData.h > #define FontCustomPlatformData_h > > #include > +#include "FontRenderingMode.h" This include is out of place (check-webkit-style should catch this.) > +#elif PLATFORM(LINUX) > + explicit FontCustomPlatformData(SkTypeface* tf) > + : m_fontReference(tf) Use full words for variable names (not "tf"). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:09:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:09:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] New: commit-queue needs a master process Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28040 Summary: commit-queue needs a master process Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abarth at webkit.org CC: eric at webkit.org, ddkilzer at webkit.org To make the commit queue more robust, I'm using a master process that call bugzilla-tool. We should add the master process to the repository so other folks can use it too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:11:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:11:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090806081133.487C4346CF44@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34204| |review? Flag| | --- Comment #1 from Adam Barth 2009-08-06 01:11:32 PDT --- Created an attachment (id=34204) --> (https://bugs.webkit.org/attachment.cgi?id=34204) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:17:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:17:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090806081736.DE927346CFFE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jorlow at chromium.org --- Comment #2 from Jeremy Orlow 2009-08-06 01:17:36 PDT --- I know this is really simple at the moment, but can we please make this Python from the start? I've seen plenty of scripts start out this size and then balloon over time. The second we try to do something like integrate with the waterfall, other try bots, etc, we'll be happy we did. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:21:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:21:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090806082110.1EF55346D09E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34204|review? |review- Flag| | --- Comment #3 from Adam Barth 2009-08-06 01:21:08 PDT --- (From update of attachment 34204) Ok. It's good for me to learn more python anyway. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:26:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:26:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28015] [Chromium] @font-face is not supported on Linux In-Reply-To: References: Message-ID: <20090806082653.2A5D3346D15C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28015 --- Comment #5 from Yusuke Sato 2009-08-06 01:26:52 PDT --- Thanks for your comment. I've asked Adam to review this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:28:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:28:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090806082838.EEBEB346D1D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 --- Comment #28 from Luke Kenneth Casson Leighton 2009-08-06 01:28:37 PDT --- great. will add a TODO for #ifdef DATAGRID. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:37:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:37:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28041] New: ecma/Date/15.9.5.12-1.js fails every night at midnight Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28041 Summary: ecma/Date/15.9.5.12-1.js fails every night at midnight Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abarth at webkit.org CC: mrowe at apple.com, oliver at apple.com ecma/Date/15.9.5.12-1.js fails every night between midnight and 1am pacific. This annoys the pants off me. Can we either fix this test or turn it off? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 02:49:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 02:49:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090806094920.0FD7A346DB3E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #10 from Aharon (Vladimir) Lanin 2009-08-06 02:49:16 PDT --- (In reply to comment #8) Please see my comments inline. > I attached the display of "??!" in Safari 4.0.2 in Windows. > It is displayed as RTL (the element directionality) in input field, but it is > displayed as LTR in the pop-up list. My mistake, you are right. I was looking at the input itself - I did not get the dropdown until I entered a few more values starting the same way. > Looks IE8 supports auto-complete, but it displays "hi!" and "??!" in the pop-up > list as LTR using the test page. I don't have IE8 yet. I guess it looks like all the browsers are using the browser language directionality, which I think is just terrible. > > In my opinion, it is Chrome's current behavior re directionality here that is > > the most useful. In most cases, a text input needs to be capable of accepting > > and displaying correctly - both LTR and RTL values. > > Thus, our BiDi support > > recommendations for web pages is to add directionality auto-detection scripts > > to most inputs that after each keystroke check the directionality of the > > current input value and adjust its dir and align values accordingly. Thus, both > > LTR and RTL values could have been submitted in the past, and all need to be > > displayed correctly, so checking the directionality of each value in the > > dropdown as Chrome does is the best. > > > > Do you mean even if the text input field is marked as RTL, > it should display "hi!" in such input field as LTR? > and/or it should displayed "hi!" as LTR in the pop-up list? I meant that it should be displayed as LTR in the autofill dropdown, but RTL in the input - unless a page script changes input's dir at that point - as it does now. > If that is the case, what is the point of setting "dir" in the input field? To control how the input itself is displayed, not the dropdown. That, of course raises the logical question: if that browser does directionality auto-detection on the dropdown values, shouldn't it do it for the input itself? Jeremy raised this question outside of the dropdown context. My response was and is that this would be a good thing - but only if the page requested that the browser do so, e.g. via a new dir=auto value. There is a discussion going on re adding dir=auto or something like that to HTML5. I do not think it would be a good idea to do directionality auto-detection on input values without dir=auto, since it would interfere with the scripts that we put in to do that right now, and we would have to modify the scripts to make an exception for Chrome. Furthermore, doing auto-detection in inputs does not do anything for when the value is later displayed in another page. And I do not think it would be a good idea to implement dir=auto in Chrome before its design has been completed, since it would interfere with whatever the eventual standard will be. The reason that I do like directionality auto-detection on the autofill dropdown values is that unlike the input itself, the page has absolutely no control over these, and can not do auto-detection for them in script. > Or you mean "dir" should not be needed for autofill and , whoever prepares the HTML of the
In-Reply-To: References: Message-ID: <20090806214621.9B1F234738AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34133|review? |review- Flag| | --- Comment #2 from Eric Seidel 2009-08-06 14:46:21 PDT --- (From update of attachment 34133) If you're going to edit the generated template like this, you need to also modify make-js-test-wrappers so ignore your .js file so that it doens't try to re-gen a new version every time someone else runs make-js-test-wrappers. (Yes, I know this is all very poorly documented.) Seems silly to leave this in the output: You should see no red. 16 div: 17 18 flexbox: 19 20 table: 21 If you wrap it all in a div, you can easily remove that div before ending your script. Otherwise the change looks fine to me. r- for those nits. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 14:47:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 14:47:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090806214732.ADCDC34738E2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34135|review? |review- Flag| | --- Comment #6 from Eric Seidel 2009-08-06 14:47:32 PDT --- (From update of attachment 34135) This seems like the wrong approach. Please engage some of the other Database hackers and get them to make positive comments on the bug first before proceeding. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 14:49:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 14:49:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28051] [WINCE] make JPEGImageDecoder.cpp build for WINCE In-Reply-To: References: Message-ID: <20090806214920.8D2A73473928@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28051 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34213|review? |review+ Flag| | --- Comment #2 from Eric Seidel 2009-08-06 14:49:20 PDT --- (From update of attachment 34213) Seems OK. the copyright line seems like a strange place. Also, you're releasing this in 2009, so I don't see how you can claim copyright 2007. :) Not that it matters... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 14:58:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 14:58:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090806215826.799C23473A1D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 --- Comment #7 from Yong Li 2009-08-06 14:58:26 PDT --- (In reply to comment #6) > (From update of attachment 34135 [details]) > This seems like the wrong approach. Please engage some of the other Database > hackers and get them to make positive comments on the bug first before > proceeding. Any more information about why it's wrong approach? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:23:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:23:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24388] Web Inspector- Resources should show parameters and response In-Reply-To: References: Message-ID: <20090806222312.AA75B3473C8C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24388 Steel Fu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |steelfu at gmail.com --- Comment #1 from Steel Fu 2009-08-06 15:23:12 PDT --- Definitely would be nice. With this, I could completely rid myself of Firebug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:24:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:24:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28052] Photo browser doesn't display enlarged versions of photos In-Reply-To: References: Message-ID: <20090806222406.C2C6D3473CA6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28052 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |NeedsRadar, | |ReviewedForRadar -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:24:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:24:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28052] Photo browser doesn't display enlarged versions of photos In-Reply-To: References: Message-ID: <20090806222421.AF2943473CB6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28052 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Mark Rowe (bdash) 2009-08-06 15:24:20 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:24:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:24:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28052] Photo browser doesn't display enlarged versions of photos In-Reply-To: References: Message-ID: <20090806222423.6275D3473CC0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28052 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|NeedsRadar | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:32:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:32:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28051] [WINCE] make JPEGImageDecoder.cpp build for WINCE In-Reply-To: References: Message-ID: <20090806223252.182C23473D8C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28051 --- Comment #3 from Joe Mason 2009-08-06 15:32:51 PDT --- Well, because we wrote it in 2007... (Also, this isn't the first release - the source has been available from our web site ever since we released the first binaries. We just missed this in the first batch of patches we submitted.) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:33:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:33:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28046] Windows credentials not automatically passed to proxy/website. In-Reply-To: References: Message-ID: <20090806223305.88EDE3473DA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28046 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |NeedsRadar, | |ReviewedForRadar -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:33:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:33:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28046] Windows credentials not automatically passed to proxy/website. In-Reply-To: References: Message-ID: <20090806223317.A16A43473DA8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28046 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Mark Rowe (bdash) 2009-08-06 15:33:17 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:33:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:33:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28046] Windows credentials not automatically passed to proxy/website. In-Reply-To: References: Message-ID: <20090806223318.E23A83473DAE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28046 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|NeedsRadar | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:39:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:39:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27879] Allow custom memory allocation control for JavaScriptCore's Noncopyable class In-Reply-To: References: Message-ID: <20090806223920.EA67A3473E6F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27879 Zoltan Horvath changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33875|0 |1 is obsolete| | Attachment #34232| |review? Flag| | --- Comment #8 from Zoltan Horvath 2009-08-06 15:39:19 PDT --- Created an attachment (id=34232) --> (https://bugs.webkit.org/attachment.cgi?id=34232) updated proposed patch I didn't see the tabs in my previous patch. Anyway, I've filed this new one. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:44:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:44:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27879] Allow custom memory allocation control for JavaScriptCore's Noncopyable class In-Reply-To: References: Message-ID: <20090806224425.821123473F00@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27879 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34232|review? |review+, commit-queue+ Flag| | --- Comment #9 from Adam Barth 2009-08-06 15:44:24 PDT --- (From update of attachment 34232) Thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 16:03:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 16:03:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090806230321.DF925347408E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34075|0 |1 is obsolete| | Attachment #34233| |review? Flag| | --- Comment #3 from Dumitru Daniliuc 2009-08-06 16:03:19 PDT --- Created an attachment (id=34233) --> (https://bugs.webkit.org/attachment.cgi?id=34233) transaction coordinator + test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 16:29:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 16:29:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090806232938.DBD85347432F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34234| |review? Flag| | --- Comment #11 from Xiaomei Ji 2009-08-06 16:29:36 PDT --- Created an attachment (id=34234) --> (https://bugs.webkit.org/attachment.cgi?id=34234) patch w/ manual test Since the change only affects Chromium's
as its parent elements In-Reply-To: References: Message-ID: <20090807001712.43826347490C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28031 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Platform|PC |All Ever Confirmed|0 |1 OS/Version|Windows XP |All -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:19:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:19:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14479] Slow script warning, Safari potentially unresponsive In-Reply-To: References: Message-ID: <20090807001949.391023474942@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14479 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |oliver at apple.com Resolution| |WORKSFORME -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:22:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:22:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27978] getBoundingClientRect method of DOM element return wrong value for some page In-Reply-To: References: Message-ID: <20090807002206.213B03474982@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27978 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |ap at webkit.org, | |sam at webkit.org Platform|PC |All Ever Confirmed|0 |1 OS/Version|Windows Vista |All -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:23:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:23:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14823] Some XRegExp regular expressions are syntax errors in WebKit In-Reply-To: References: Message-ID: <20090807002354.D8A4434749C4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14823 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |oliver at apple.com Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:49:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:49:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19161] wrong font size when css font-family includes monospace In-Reply-To: References: Message-ID: <20090807004935.BEEF53475513@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19161 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |eric at webkit.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:51:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:51:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
In-Reply-To: References: Message-ID: <20090807005145.254683475555@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34133|review- | Flag| | Attachment #34133|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:51:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:51:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
In-Reply-To: References: Message-ID: <20090807005150.2840D3475560@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34237| |review? Flag| | --- Comment #3 from Shinichiro Hamaji 2009-08-06 17:51:49 PDT --- Created an attachment (id=34237) --> (https://bugs.webkit.org/attachment.cgi?id=34237) Patch v2 --- 8 files changed, 160 insertions(+), 7 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:59:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:59:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27909] WebKit cannot decode jpegs that are in CMYK or YCCK format In-Reply-To: References: Message-ID: <20090807005959.31AD53475673@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27909 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33957|review? |review- Flag| | --- Comment #10 from Eric Seidel 2009-08-06 17:59:58 PDT --- (From update of attachment 33957) This does not follow WebKit style. Maybe it's not supposed to? spacing: 481 dest.setRGBA(x, info->output_scanline - 1, c*k/255, m*k/255, y*k/255, 0xFF); spacing: 513 JSAMPLE *j1 = samples[0]; extra { }: 2 } else if (info->out_color_space == JCS_CMYK) { 523 cmyk_convert_rgb(buffer, *samples, info); 524 } else { See: http://webkit.org/coding/coding-style.html check-webkit-style should also help you. Seems cmyk_convert_rgb should ASSERT output colorspace is JCS_CMYK? You should consider throwing the rgb stuff in a similar static inline. r- for the style violiations (or lack of informations as to why we would not want to match WebKit style in this file). please run check-webkit-style, there is a diff option I'm told. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:01:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:01:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
In-Reply-To: References: Message-ID: <20090807010123.54A19347569B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34237|review? | Flag| | Attachment #34237|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:01:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:01:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
In-Reply-To: References: Message-ID: <20090807010128.0D3B334756A6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34239| |review? Flag| | --- Comment #4 from Shinichiro Hamaji 2009-08-06 18:01:27 PDT --- Created an attachment (id=34239) --> (https://bugs.webkit.org/attachment.cgi?id=34239) Patch v3 --- 8 files changed, 168 insertions(+), 7 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:03:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:03:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27920] Right click on timeline of media controls panel cause seek In-Reply-To: References: Message-ID: <20090807010316.5BD753475706@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27920 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33934|review? |review- Flag| | Attachment #33934|review? |review- Flag| | --- Comment #2 from Eric Seidel 2009-08-06 18:03:14 PDT --- (From update of attachment 33934) Looks fine. Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button. Style viloation: 1 if (window.eventSender) 12 { If you were a committer I would just r+ and you could fix this when landing. Since I don't think you are, please re-post with the two above fixes --- Comment #3 from Eric Seidel 2009-08-06 18:03:14 PDT --- (From update of attachment 33934) Looks fine. Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button. Style viloation: 1 if (window.eventSender) 12 { If you were a committer I would just r+ and you could fix this when landing. Since I don't think you are, please re-post with the two above fixes -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:03:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:03:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27920] Right click on timeline of media controls panel cause seek In-Reply-To: References: Message-ID: <20090807010316.8D5693475708@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27920 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33934|review? |review- Flag| | Attachment #33934|review? |review- Flag| | --- Comment #2 from Eric Seidel 2009-08-06 18:03:14 PDT --- (From update of attachment 33934) Looks fine. Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button. Style viloation: 1 if (window.eventSender) 12 { If you were a committer I would just r+ and you could fix this when landing. Since I don't think you are, please re-post with the two above fixes --- Comment #3 from Eric Seidel 2009-08-06 18:03:14 PDT --- (From update of attachment 33934) Looks fine. Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button. Style viloation: 1 if (window.eventSender) 12 { If you were a committer I would just r+ and you could fix this when landing. Since I don't think you are, please re-post with the two above fixes -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:05:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:05:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
In-Reply-To: References: Message-ID: <20090807010536.E054A347573E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 --- Comment #5 from Shinichiro Hamaji 2009-08-06 18:05:36 PDT --- Thanks for the quick review! I modified my patch as you commented (please just ignore Patch v2). I also modified a few things: - Change the filename of layout test. resources/overflow-scroll.js may be too general to put it into make-js-test-wrappers. - Make the color of shadow green. People may see the test is passing easily. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:09:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:09:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27879] Allow custom memory allocation control for JavaScriptCore's Noncopyable class In-Reply-To: References: Message-ID: <20090807010922.B48F034757AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27879 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34232|review+ | Flag| | --- Comment #10 from Adam Barth 2009-08-06 18:09:21 PDT --- (From update of attachment 34232) Clearing review flag on attachment: 34232 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/Noncopyable.h M WebCore/ChangeLog M WebCore/platform/graphics/wince/GraphicsContextWince.cpp M WebKit/win/COMPropertyBag.h M WebKit/win/ChangeLog Committed r46877 M JavaScriptCore/wtf/Noncopyable.h M JavaScriptCore/ChangeLog M WebKit/win/ChangeLog M WebKit/win/COMPropertyBag.h M WebCore/ChangeLog M WebCore/platform/graphics/wince/GraphicsContextWince.cpp r46877 = 5cd67bb8bf95afdfedae7a0d1f5568cc7b9ef674 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46877 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:09:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:09:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27879] Allow custom memory allocation control for JavaScriptCore's Noncopyable class In-Reply-To: References: Message-ID: <20090807010927.2AF4634757CC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27879 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #11 from Adam Barth 2009-08-06 18:09:25 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:11:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:11:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090807011110.5512F3475804@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34037|review? |review- Flag| | --- Comment #2 from Eric Seidel 2009-08-06 18:11:09 PDT --- (From update of attachment 34037) +== Rolled over to ChangeLog-2009-06-16 ==SVG Filter premultiplied color support for getImageDate/putImageData ?? is "NotPreMultiplied" the normal terminolgy? "unmultiplied"? Google seems to suggest that "straight" is the opposite of PreMultiplied I'm not sure that would be more clear here though. Unmultiplied might be clearer than NotPreMultiplied. I'm not a graphics expert though. No argument names: PassRefPtr getNotPreMultipliedImageData(const IntRect& rect) const; 73 PassRefPtr getPreMultipliedImageData(const IntRect& rect) const; they don't add anything. Likewise here: ImageData* source Seems we should add a "colorFrom..." for whatever type of pixel this is: destRows[basex] = (*pixel & 0x00FF0000) >> 16; 171 destRows[basex + 1] = (*pixel & 0x0000FF00) >> 8; 172 destRows[basex + 2] = (*pixel & 0x0000FF00); 173 destRows[basex + 3] = (*pixel & 0xFF000000) >> 24; Then we just create the Color in an if and the pixel assignment is shared. Same here: *pixel = srcRows[basex + 3] << 24 | srcRows[basex] << 16 | srcRows[basex + 1] << 8 | srcRows[basex + 2]; Better to use inlines to share more code. They also are are more self-documenting. Seems the toImage() result could be in a local: if (multiplied == NotPreMultiplied) 134 image = data.m_pixmap.toImage().convertToFormat(QImage::Format_ARGB32); 135 else 136 image = data.m_pixmap.toImage().convertToFormat(QImage::Format_ARGB32_Premultiplied) How do we test this? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:11:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:11:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090807011151.77916347582D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34240| |review? Flag| | --- Comment #12 from Xiaomei Ji 2009-08-06 18:11:49 PDT --- Created an attachment (id=34240) --> (https://bugs.webkit.org/attachment.cgi?id=34240) patch w/ manual test 1. Since the change only affects Chromium's , I leave the directionality of item in drop-down list as auto-detected (as first strong directional character's direction). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:17:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:17:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27971] Externally referenced fonts break with back button due to aggressive protection In-Reply-To: References: Message-ID: <20090807011746.DA09E3475893@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27971 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |ap at webkit.org Summary|externally referenced fonts |Externally referenced fonts |break with back button |break with back button due |(possibly incorrect |to aggressive protection |referrer) | Ever Confirmed|0 |1 --- Comment #1 from Alexey Proskuryakov 2009-08-06 18:17:46 PDT --- We do send a correct Referer on Back. The problem here is that the page references a CSS file that's different on each reload, and it has one-time URLs for fonts. I.e., each URL can only be used once, then it becomes "Not found". On Back, we don't reload the CSS, but try to reload fonts using original URLs. This happens because the page is in page cache, so neither it nor its stylesheets are reloaded on Back. But fonts (and probably other subresources) are re-requested from WebCore memory cache, which in turn tries to revalidate from network, due at all those no-cache and must-revalidate pragmas sent with original response. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:17:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:17:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090807011747.C0BE834758A1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34071|review? |review+ Flag| | --- Comment #10 from Eric Seidel 2009-08-06 18:17:47 PDT --- (From update of attachment 34071) Still extra junk at the end of the test text output. But looks fine. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:19:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:19:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090807011906.3737634758E4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34233|review? | Flag| | Attachment #34233|0 |1 is obsolete| | Attachment #34241| |review? Flag| | --- Comment #5 from Dumitru Daniliuc 2009-08-06 18:19:02 PDT --- Created an attachment (id=34241) --> (https://bugs.webkit.org/attachment.cgi?id=34241) patch + test case (In reply to comment #4) good comments! > 50 OwnPtr*> > > m_pendingTransactions; > > I think you could put RefPtr's in the Deque to eliminate the manual > refcounting. done. any way to do the same for the Deques? that is, can we wrap them into something that would delete them as soon as we exit the block of code that removes them from the hash map? > 51 Mutex m_pendingTransactionsGuard; > > I think this should only be called on a particular DB thread, is the Mutex > really needed? good catch, removed. > 47 SQLTransactionCoordinator::~SQLTransactionCoordinator() > 48 { > 49 } > > What happens to transactions that don't actually start prior to the thread > being killed. How do they get derefed? added code to clean up all pending transactions. i left it empty mostly because i wasn't sure what to do here and was hoping for some comments. is there anything else we might need to do other than cleaning up the transaction queues? > 210 void SQLTransaction::lockAquired() > 211 { > 212 m_nextStep = > &SQLTransaction::deliverOpenTransactionAndPreflightCallback; > 213 LOG(StorageAPI, "Scheduling deliverOpenTransactionAndPreflight for > transaction %p\n", this); > 214 m_database->scheduleTransactionCallback(this); > 215 } > > A the lockAcquired point, the system pings-pongs to the main thread and back > again to the db thread. What is the reason for the > 'deliverOpenTransactionAndPreflightCallback' step? I'm wondering if we can we > skip straight to the openTransactionAndPreflight step at this point, without > ping/ponging to the main thread. changed lockAquired() to call openTransactionAndPreflight() directly. i scheduled a task on the main thread only because i wanted to release the lock on SQLTransactionCoordinator::m_pendingTransactions as soon as possible (even though i guess it didn't matter, because the DB thread was doing the same amount of work in one order or another). but now that the lock is gone i don't think there's any reason to do this anymore. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:19:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:19:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27971] Externally referenced fonts break with back button due to aggressive protection In-Reply-To: References: Message-ID: <20090807011918.3E73834758EA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27971 --- Comment #2 from Alexey Proskuryakov 2009-08-06 18:19:17 PDT --- Note that this is also a performance problem, not just something that breaks this particular kind of DRM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:19:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:19:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27255] Geolocation incorrectly calls error callback in case of exception in success callback In-Reply-To: References: Message-ID: <20090807011942.C28763475900@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27255 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33532|review? |review+ Flag| | --- Comment #7 from Eric Seidel 2009-08-06 18:19:42 PDT --- (From update of attachment 33532) OK. That information/justification from the spec really should go in the ChangeLog. Please update it when landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:20:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:20:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27255] Geolocation incorrectly calls error callback in case of exception in success callback In-Reply-To: References: Message-ID: <20090807012044.C8381347591E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27255 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33532|review+ |review- Flag| | --- Comment #8 from Eric Seidel 2009-08-06 18:20:44 PDT --- (From update of attachment 33532) Oh. You can't land your own yet, can you. Please post one final patch with the justification information from the spec. Something like "these are marked [NoInterfaceObject] in the spec:" with the links you provided Thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:21:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:21:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27971] Externally referenced fonts break with back button due to aggressive protection In-Reply-To: References: Message-ID: <20090807012106.E5D8C347593E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27971 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #3 from Alexey Proskuryakov 2009-08-06 18:21:06 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:25:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:25:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27305] [WINCE] add WinCE-specific unicode implementation In-Reply-To: References: Message-ID: <20090807012536.6525734759DA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27305 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34225|review? |review- Flag| | --- Comment #12 from Eric Seidel 2009-08-06 18:25:35 PDT --- (From update of attachment 34225) Style: 1 const UChar *sourceIterator = source; 82 const UChar *sourceEnd = source + sourceLength; 83 UChar *resultIterator = result; 84 UChar *resultEnd = result + resultLength; Argument names which don't provide clarity should be removed from headers per our style: 160 bool isSpace(wchar_t c); 161 bool isLetter(wchar_t c); 162 bool isPrintableChar(wchar_t c); 163 bool isUpper(wchar_t c); 164 bool isLower(wchar_t c); 165 bool isPunct(wchar_t c); 166 bool isDigit(wchar_t c); I assume these are already covered by other tests? Thank you very much for posting this much smaller patch. Unless george is volunteering to fix these when landing, I'm going to r- this and ask you to post a copy with fixed style since you don't have commit-bit yet (to my knowledge). You will find the "check-webkit-style" script helpful in validating that the style is correct in these files. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:29:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:29:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27371] [WINCE] Add WinCE specific platform/text files to WebCore In-Reply-To: References: Message-ID: <20090807012952.5CBD93475A54@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27371 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33203|review? |review- Flag| | --- Comment #7 from Eric Seidel 2009-08-06 18:29:51 PDT --- (From update of attachment 33203) This is too large for me to review. Why are we adding: platform/text/wince/Euc_jp.cpp ? Now that you all have your magical UnicodeCE library, is this something that shoudl go in that? Does the rest of WebCore want this Euc_jp.cpp file? How is it generated, where does it come from? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:34:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:34:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27842] Implement GraphicsContext::fillRoundRect() for WINCE port In-Reply-To: References: Message-ID: <20090807013429.3D95B3475B0E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27842 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33809|review? |review- Flag| | --- Comment #7 from Eric Seidel 2009-08-06 18:34:28 PDT --- (From update of attachment 33809) No no no. This is a bunch of copy/paste code. Please use functions (static inline perhaps?) instead. George should be able to help you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:35:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:35:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
In-Reply-To: References: Message-ID: <20090807013535.CBE7A3475B1E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34239|review? |review+ Flag| | --- Comment #6 from Eric Seidel 2009-08-06 18:35:35 PDT --- (From update of attachment 34239) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:36:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:36:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27960] cygwin-downloader missing various necessary packages In-Reply-To: References: Message-ID: <20090807013615.123A03475B54@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27960 --- Comment #1 from Alexey Proskuryakov 2009-08-06 18:36:14 PDT --- I did a clean installation a couple of weeks ago, and I got the aforementioned packages with cygwin-downloader, no manual tweaking was necessary. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:36:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:36:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090807013638.BB16A3475B6A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34234|0 |1 is obsolete| | --- Comment #13 from Eric Seidel 2009-08-06 18:36:37 PDT --- (From update of attachment 34234) Please obsolete old patches when uploading new ones. bugzilla-tool will do this for you if you use it to post your patches. See bugzilla-tool post-diff and bugzilla-tool post-commits. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:38:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:38:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27960] cygwin-downloader missing various necessary packages In-Reply-To: References: Message-ID: <20090807013805.98B703475BA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27960 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME --- Comment #2 from Peter Kasting 2009-08-06 18:38:05 PDT --- OK, I'm willing to believe that something went wrong on my end somehow. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:40:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:40:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090807014004.258953475BC9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34240|review? |review- Flag| | --- Comment #14 from Eric Seidel 2009-08-06 18:40:02 PDT --- (From update of attachment 34240) This constructor will run at library load time and slow down Chromium's launch time: +static const String kEllipses = "..."; Style violation: 55 : label(label), type(type), yOffset(0), ellipsesWidth(0) { } Style: 349 if ( totalWidth > width) Style violations, no argument names when not needed: 410 void drawBidiTextWithinWidth(const Font& font, const TextRun& run, const FloatPoint& point, int width); I don't think I can actually review the code here. I would need to study these files more. r- for the style stuff. Make sure to run check-webkit-style if you haven't already. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:48:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:48:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090807014846.3BF073475CED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34096|review? |review- Flag| | --- Comment #23 from Eric Seidel 2009-08-06 18:48:45 PDT --- (From update of attachment 34096) I think the huge wx() if block shoudl be moved elsewhere. No need to make build-webkit even bigger! Maybe a function in webkitdirs.pm? Maybe some sort of ensureWafInstalled() or similar. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:52:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:52:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090807015229.452963475D67@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34141|review? |review+ Flag| | --- Comment #24 from Eric Seidel 2009-08-06 18:52:28 PDT --- (From update of attachment 34141) I don't see why wx would want to switch build systems again away from the masses. But I'm not gonna stand in your way. Nor do I have time to review these line by line. Rubber Stamp. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:52:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:52:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090807015246.7846C3475D85@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34142|review? |review+ Flag| | --- Comment #25 from Eric Seidel 2009-08-06 18:52:45 PDT --- (From update of attachment 34142) Rubber Stamp. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:55:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:55:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27424] adding ConvertToGCharPrivate.h In-Reply-To: References: Message-ID: <20090807015515.41A093475DF6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27424 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33979|review?(eric at webkit.org) |review+ Flag| | --- Comment #12 from Eric Seidel 2009-08-06 18:55:14 PDT --- (From update of attachment 33979) LGTM. I still don't understand why these are named "Private.h" -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:01:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:01:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090807020107.03EB13475EA4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33972|review? |review- Flag| | --- Comment #5 from Eric Seidel 2009-08-06 19:01:06 PDT --- (From update of attachment 33972) Bunch of Style violations. Please don't post patches with #if 0 code. There are a billion includes in this file. maybe we should split some of this out into separate files? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:01:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:01:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27427] add event listener classes for gobject bindings In-Reply-To: References: Message-ID: <20090807020151.BA3943475EB2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27427 --- Comment #2 from Eric Seidel 2009-08-06 19:01:51 PDT --- (From update of attachment 33054) Please get a gtk reviewer to review this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:02:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:02:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090807020226.1FDA23475EC0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33971|review? |review+ Flag| | --- Comment #4 from Eric Seidel 2009-08-06 19:02:25 PDT --- (From update of attachment 33971) Looks sane enough. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:03:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:03:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090807020312.5BE5C3475EDA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33965|review?(eric at webkit.org) | Flag| | --- Comment #5 from Eric Seidel 2009-08-06 19:03:11 PDT --- (From update of attachment 33965) Please get a gtk reviewer to review this. I've cleared the review flag. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:03:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:03:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27437] make HTMLAppletElement and HTMLEmbedElement compliant with de-facto JS-based standards under gobject bindings In-Reply-To: References: Message-ID: <20090807020351.45D333475EEE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27437 --- Comment #14 from Eric Seidel 2009-08-06 19:03:50 PDT --- (From update of attachment 33377) Please get Mark Rowe to sign off on this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:04:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:04:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27250] Geolocation callback function IDL files are superfluous In-Reply-To: References: Message-ID: <20090807020448.012E83475F24@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27250 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33433|review? |review- Flag| | --- Comment #6 from Eric Seidel 2009-08-06 19:04:46 PDT --- (From update of attachment 33433) Please add those comments above to the ChangeLog, with spec references. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:05:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:05:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27437] make HTMLAppletElement and HTMLEmbedElement compliant with de-facto JS-based standards under gobject bindings In-Reply-To: References: Message-ID: <20090807020530.529E43475F30@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27437 --- Comment #15 from Eric Seidel 2009-08-06 19:05:29 PDT --- (From update of attachment 33377) Please get Mark Rowe to sign off on this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:08:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:08:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27885] Add QNX as supported platform In-Reply-To: References: Message-ID: <20090807020800.78CD43475F6C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27885 --- Comment #2 from Eric Seidel 2009-08-06 19:07:59 PDT --- (From update of attachment 33880) Can't we use a ThreadingQNX abstraction here to get the stack base instead? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:14:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:14:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090807021416.08E84347602B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #6 from Eric Seidel 2009-08-06 19:14:14 PDT --- (From update of attachment 34241) Please avoid combining style cleanup with functional changes when possible. :) By the time I got to TransactionCoordinator my eyes were sagging. ;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:16:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:16:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27787] The type information about the resource loading is not forwarded to the network layer In-Reply-To: References: Message-ID: <20090807021651.F3D123476081@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27787 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #5 from Eric Seidel 2009-08-06 19:16:51 PDT --- Extra space before the :. Please run check-webkit-style if you have not already. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:22:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:22:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28050] Qt Port does not use style colour as configured for input text and menu lists In-Reply-To: References: Message-ID: <20090807022224.6D4013476101@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28050 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenneth.christiansen at openbo | |ssa.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:22:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:22:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28050] Qt Port does not use style colour as configured for input text and menu lists In-Reply-To: References: Message-ID: <20090807022256.726463476115@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28050 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hausmann at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:24:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:24:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27768] SVG feComponentTransfer needs to be implemented In-Reply-To: References: Message-ID: <20090807022404.DA68A3476133@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27768 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33662|review? |review- Flag| | --- Comment #3 from Eric Seidel 2009-08-06 19:24:04 PDT --- (From update of attachment 33662) Sad that we don't have a Color based get/set: 5 srcPixelArray->get(pixelByteOffset, r); 196 srcPixelArray->get(pixelByteOffset + 1, g); 197 srcPixelArray->get(pixelByteOffset + 2, b); 198 srcPixelArray->get(pixelByteOffset + 3, a); This should just be an array of these function pointers: 168 switch (channel) { 169 case 0: 170 transferFunction = redFunction(); 171 break; 172 case 1: 173 transferFunction = greenFunction(); 174 break; 175 case 2: 176 transferFunction = blueFunction(); 177 break; 178 case 3: 179 transferFunction = alphaFunction(); 180 break; 181 default: 182 break; 183 } probably quicker than a switch, and much, much less code. :) We need to find a way to share more of these for loops. I think that we should use function pointers indexed in an array by transferFunction.type. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:27:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:27:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090807022751.41FC73476199@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 --- Comment #32 from Kenneth Rohde Christiansen 2009-08-06 19:27:50 PDT --- Simon, didn't you actually land this last patch? Please clear tag then. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:29:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:29:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090807022930.56A7534761CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33863|review? |review- Flag| | --- Comment #9 from Eric Seidel 2009-08-06 19:29:29 PDT --- (From update of attachment 33863) This is not safe: 1811 RefPtr options = static_cast(sourceElement)->options(); (at least not if we add more list() types). I think until we add more list() types we could just make it return HTMLDataListElement*. But checking at each callsite is OK too. Seems this needs to be guarded by DATAGRID defines, no? Or do we have a DataList? This doesn't look like a complete implementation, or? I can't remember if you're a committer yet or not. so r- assuming you'll need someone else to land after you fix those nits. This doesn't seem very useful w/o UI... but this is OK to land for now if it's guarded by and ENABLE. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:30:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:30:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28050] Qt Port does not use style colour as configured for input text and menu lists In-Reply-To: References: Message-ID: <20090807023009.2095534761E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28050 --- Comment #3 from Kenneth Rohde Christiansen 2009-08-06 19:30:08 PDT --- Seems right to me. Simon do you have any objections to these patches? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:30:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:30:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28050] Qt Port does not use style colour as configured for input text and menu lists In-Reply-To: References: Message-ID: <20090807023028.EA31634761F3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28050 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:41:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:41:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27059] Exclude Symbian platform from define of MIDDLE_ENDIAN In-Reply-To: References: Message-ID: <20090807024134.B6DC83476313@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27059 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34216| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:44:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:44:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27424] adding ConvertToGCharPrivate.h In-Reply-To: References: Message-ID: <20090807024418.EEF633476361@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27424 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33979| |commit-queue- Flag| | --- Comment #13 from Adam Barth 2009-08-06 19:44:18 PDT --- (From update of attachment 33979) This file does not have the usual license block. Is that ok? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:45:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:45:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090807024556.1DA1F3476383@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34164| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:46:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:46:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090807024645.A1BFE34763A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33971| |commit-queue- Flag| | --- Comment #5 from Adam Barth 2009-08-06 19:46:45 PDT --- (From update of attachment 33971) Same question about the license block. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:47:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:47:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090807024741.C813834763B9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34071| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:48:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:48:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
In-Reply-To: References: Message-ID: <20090807024803.980A134763C9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34239| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:48:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:48:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28051] [WINCE] make JPEGImageDecoder.cpp build for WINCE In-Reply-To: References: Message-ID: <20090807024850.556B434763F3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28051 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34213| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:48:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:48:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090807024850.EAF2134763FF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34178|review? |review- Flag| | --- Comment #14 from Eric Seidel 2009-08-06 19:48:50 PDT --- (From update of attachment 34178) Please collapse this line into one nicely named define: 35 #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(WIN_OS)) || PLATFORM(WINCE) like STORE_FONT_POINTER or whatever the heck the ifdefed code does. Please add more indetifying information than just "comment above": 179 // see comment above otherwise if someone adds a comment between your two comments the latter comment will be confusing. // See comment about WINCE GDI handling near setGlyphDataForCharacter above. or something. Does WINCE only support horrizontal text? 3 #elif PLATFORM(WINCE) 64 typedef float GlyphBufferAdvance; 6065 #else A comment is need there to explain why it's just a float. No need for arg name: 51 FontCustomPlatformData* createFontCustomPlatformData(const SharedBuffer* buffer); Can you split this out? r- mostly for the unexplained advances change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:49:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:49:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090807024952.B79443476447@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ARM JIT port |[multi-patch] ARM JIT port -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:54:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:54:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27711] SVG Filter need feColorMatrix implementation In-Reply-To: References: Message-ID: <20090807025457.E46A534764E6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27711 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34041|review? |review+ Flag| | --- Comment #6 from Eric Seidel 2009-08-06 19:54:56 PDT --- (From update of attachment 34041) Sigh. We totally need Color accessors to: 127 srcPixelArray->get(pixelByteOffset, r); 128 srcPixelArray->get(pixelByteOffset + 1, g); 129 srcPixelArray->get(pixelByteOffset + 2, b); 130 srcPixelArray->get(pixelByteOffset + 3, a); Sigh. I still think function pointers would be cleaner than templates. I'll r+ this, but I definitely would prefer function pointers for this sort of thing. Modern compilers should be able to handle the jump prediction. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:06:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:06:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists In-Reply-To: References: Message-ID: <20090807030601.7F859347660C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27551 --- Comment #14 from Eric Seidel 2009-08-06 20:06:00 PDT --- (From update of attachment 33773) This patch will require buy-in from some of the Mac build experts like Mark Rowe, and whoever does build submissions for Apple these days. I think it should be possible to work this way, but I remember the export lists being a conscious choice back in the day. Please make sure you talk to Mark and ask him who the right Apple people to ask are these days. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:18:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:18:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27603] updating Document.idl to match HTML5 spec: domain read-write and access to getSelection In-Reply-To: References: Message-ID: <20090807031801.971083476741@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27603 --- Comment #6 from Eric Seidel 2009-08-06 20:18:00 PDT --- (From update of attachment 33384) I believe getSelection is intentionally avoided for Obj-C bindings, but I"m not sure. Please have an Apple person, like Mark Rowe or Tim Hatcher comment as to if this change is correct or not. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:24:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:24:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090807032433.789053476809@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34071|review+ | Flag| | Attachment #34071|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:24:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:24:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090807032438.11C2E3476810@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34244| |review? Flag| | --- Comment #11 from Shinichiro Hamaji 2009-08-06 20:24:37 PDT --- Created an attachment (id=34244) --> (https://bugs.webkit.org/attachment.cgi?id=34244) Patch v5 --- 10 files changed, 121 insertions(+), 4 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:29:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:29:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
In-Reply-To: References: Message-ID: <20090807032921.67124347686C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34239|review+ | Flag| | Attachment #34239|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:29:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:29:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
In-Reply-To: References: Message-ID: <20090807032926.D7B863476875@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34245| |review? Flag| | --- Comment #7 from Shinichiro Hamaji 2009-08-06 20:29:25 PDT --- Created an attachment (id=34245) --> (https://bugs.webkit.org/attachment.cgi?id=34245) Patch v4 --- 8 files changed, 168 insertions(+), 7 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:31:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:31:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
In-Reply-To: References: Message-ID: <20090807033102.AD3F634768A3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 --- Comment #8 from Shinichiro Hamaji 2009-08-06 20:31:02 PDT --- Oops, I used wrong email addresses... Hmm I should check why prepare-ChangeLog obtained the addresses. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:31:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:31:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27612] handling scripts can block UI In-Reply-To: References: Message-ID: <20090807033117.3870834768B9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27612 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33349|review? |review- Flag| | --- Comment #1 from Eric Seidel 2009-08-06 20:31:16 PDT --- (From update of attachment 33349) For example. When a script tag finishes loading, I think js can get a "on load" event sent. If that's true, then that event will be sent before execution instead of after execution in your port. I would have to look to confirm if there is an onload for
and upload.php When used 'upload method 2' parameter tag "input type='file'" not imported to iframe. In Opera and Mozilla both method worked. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:00:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:00:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28123] WebKit could not copy the form with this parameter in the iframe In-Reply-To: References: Message-ID: <20090811020001.40A25349B32F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28123 --- Comment #3 from Mikhail 2009-08-10 19:00:00 PDT --- Sorry in function AJAXRequest2 when copied got extra row ").contentWindow.document.getElementById( 'idElement' )" please remove it before test. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:00:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:00:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27842] Implement GraphicsContext::fillRoundRect() for WINCE port In-Reply-To: References: Message-ID: <20090811020003.08712349B33F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27842 --- Comment #21 from Eric Seidel 2009-08-10 19:00:01 PDT --- The commit queue isn't capable of any manual merging. If the commit fails, it will just be marked as commit-queue- and a committer (like yourself) will have to land it manually. "bugzilla-tool apply-patches" can help with this. If you're worry about it getting stale or needing manual intervention, probably best to just do it yourself. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:03:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:03:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090811020338.2C2E5349B3A2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #11 from TAMURA, Kent 2009-08-10 19:03:34 PDT --- Thank you for the comments! (In reply to comment #10) > (From update of attachment 32114 [details]) > Looks really good. Just a few comments. > > > +String HTMLTextAreaElement::placeholder() const > > +{ > > + return getAttribute(placeholderAttr).string(); > > +} > > + > > +void HTMLTextAreaElement::setPlaceholder(const String& value) > > +{ > > + setAttribute(placeholderAttr, value); > > +} > > These are not great. There's no need to convert to a plain string here, and in > fact it's bad for performance. The right way to do this nowadays is to just put > [Reflect] in the IDL file and not define a setPlaceholder function in the .h > and .cpp file at all, so that should be done here. Ok, I changed this to [Reflect]. > Indenting here is awkward. Fixed. > > + bool placeholderShouldBeVisible() const { return m_placeholderShouldBeVisible; } > > I think it would be a better design for the HTMLTextAreaElement to tell the I agree. When I looked at the existing placeholder code first time, I had an impression that the code was complex. I think the reason is that both of a DOM node and a renderer have flags for placeholder visibility. I have removed the flag of InputElemntData, and updated many place to tell the visibility from a DOM node to a renderer. > > + virtual void dispatchFocusEvent(); > > + virtual void dispatchBlurEvent(); > > These overrides should be private, not public, because we generally want all > functions to be as private as possible. Fixed. > > + void setPlaceholderShouldBeVisible(bool visible) { m_placeholderShouldBeVisible = visible; } > > I don't think you need this setter function. It doesn't seem to add any > abstraction. Removed. > > +void RenderTextControl::updatePlaceholderVisibility() > > +{ > > + RefPtr textBlockStyle = createInnerTextStyle(parentStyle()); > > + HTMLElement* innerText = innerTextElement(); > > + innerText->renderer()->setStyle(textBlockStyle); > > + > > + for (Node* n = innerText->firstChild(); n; n = n->traverseNextNode(innerText)) { > > + if (RenderObject* renderer = n->renderer()) > > + renderer->setStyle(textBlockStyle); > > + } > > + > > + updateFromElement(); > > +} > > I know you must moved this from one class to another, but this function needs > some comments. It's unclear why updatePlaceholderVisibility needs to update the > style of all the renderers and then call updateFromElement. A comment could > explain the relationship. Also, we could consider moving code to set the text > block style into a separate function, since the name of that function would > help document it. I have addded a new method, setInnerTextStyle(). > > - if (result.innerNode() == node() || result.innerNode() == innerTextElement()) > > + HTMLTextAreaElement* textArea = static_cast(node()); > > + if (result.innerNode() == node() > > + || !textArea->placeholderShouldBeVisible() && result.innerNode() == innerTextElement() > > + || textArea->placeholderShouldBeVisible() && result.innerNode()->isDescendantOf(innerTextElement())) > > hitInnerTextElement(result, x, y, tx, ty); > > The way the formatting makes the clauses of the if statement line up with its > body makes things like this hard to read. > > I think you could consider fixing that by using a boolean local variable; the > name of the boolean could even help document a bit. I think the code also needs > a comment. The rule here is slightly unclear unless the reader really aware of > how placeholders should behave. Done. > I'm not so sure that it's great to move the m_placeholderVisible data member > into the RenderTextControl base class. While it's true that both derived > classes use it, the base class does not. In the next patch, RenderTextControl refers m_placeholderVisible. > > +RenderStyle* RenderTextControlMultiLine::parentStyle() Renamed it to textBaseStyle(). > > +protected: > > + virtual RenderStyle* parentStyle(); > > This can and should be private instead of protected. You can override a > function with a private function, and we should make things as private as > possible. If we ever did want to derive from this class we could make it > protected at that time. Fixed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:03:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:03:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090811020338.B27A2349B3AC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Kevin Ollivier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34326|0 |1 is obsolete| | --- Comment #31 from Kevin Ollivier 2009-08-10 19:03:35 PDT --- Created an attachment (id=34533) --> (https://bugs.webkit.org/attachment.cgi?id=34533) Changes to build-webkit, with Mark's comments addressed Should have all the pointed out issues addressed now. Note that I removed the svg option defaults code entirely in this revision because I only added it to silence the SVG feature print outs at the end of the build, which themselves were removed in r46641, meaning I no longer need to worry about the values they are set term in the short term. I'll revisit the options code when I make the options more configurable for wx. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:08:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:08:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27842] Implement GraphicsContext::fillRoundRect() for WINCE port In-Reply-To: References: Message-ID: <20090811020850.E6689349B44A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27842 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34516|commit-queue+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:11:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:11:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090811021114.DA5D7349B4A5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32114|0 |1 is obsolete| | Attachment #34534| |review? Flag| | --- Comment #12 from TAMURA, Kent 2009-08-10 19:11:12 PDT --- Created an attachment (id=34534) --> (https://bugs.webkit.org/attachment.cgi?id=34534) Proposed patch (rev.4) Sorry for the large patch. * The most of changes in HTMLInputElment, InputElment, WMLInputElement are trivial. (removal of unused parameters) * We have a bug about maxlength. The patch accidentally fixes it because of RenderTextControlSingleLine::updateFromElement() change. input-text-maxlength-expected.txt had wrong expected data. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:23:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:23:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090811022359.3B190349B5BC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34512|review? | Flag| | Attachment #34512|0 |1 is obsolete| | Attachment #34535| |review? Flag| | --- Comment #19 from Dumitru Daniliuc 2009-08-10 19:23:56 PDT --- Created an attachment (id=34535) --> (https://bugs.webkit.org/attachment.cgi?id=34535) patch Addressed Michael's comments. Also, Michael suggested that it might be better to make SQLTransaction::lockAcquire() schedule an immediate task on the DB thread for SQLTransaction::openTransactionAndPreflight(), instead of directly calling this method. I agreed and made this change too, by adding a bool parameter to Database::scheduleTransactionStep() that defaults to false (true = scheduleImmediateTask(), false = scheduleTask()). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:30:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:30:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811023019.7E0F8349B69C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #19 from Xiaomei Ji 2009-08-10 19:30:16 PDT --- Hi Jay, Thanks for your comments! Please see my reply inline. (In reply to comment #18) > Here are my comments on the patch: > > WebCore/platform/chromium/PopupMenuChromium.cpp > I think it would be better to make the RTL detection behavior not dependent on > m_settings.restrictWidthOfListBox and instead being a new parameter of > m_settings. > The idea would be to keep PopupMenuChromium generic and let the client decides > which heuristic to use. Make sense. I've updated. > > In paintRow() regarding the ellipsis code. That code seems non-specific to the > autofill. Would it make sense to have > GraphicsContext::drawBidiTextWithinWidth() draw the ellipsis (may be the method > could have an extra-parameter specifying whether or not an ellipsis is > desired)? > I am assuming the ellipsis ... is the same in all languages. If it is not, may > be the extra-param could be a string of the ellipsis to use? (empty string for > no ellipsis) Make sense. I've moved the code inside GraphaicsContext::drawBidiText(WithinWidth). And per Mitz's suggestion, I used StringTruncator instead of manually truncating the string and placing ellipses. The code is much elegant. One thing to note is that in StringTruncator, horizontal ellipses (U+2026) will always be drawn when text is truncated. I think that should be fine. Thanks, Xiaomei -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:36:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:36:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811023618.7B87B349B753@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34536| |review? Flag| | --- Comment #20 from Xiaomei Ji 2009-08-10 19:36:16 PDT --- Created an attachment (id=34536) --> (https://bugs.webkit.org/attachment.cgi?id=34536) patch w/ manual test updated patch per Jay and Mitz's suggestions: 1. add a new flag to indicate in what directionality text in popup will be drawn. 2. move draw ellispses with draw truncated text from PopupMenuChromium to GraphicsContext 3. use StringTruncator to prepare truncated text along with ellipses to be drawn. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:44:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:44:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090811024445.78E98349B800@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 --- Comment #3 from Ryan Leavengood 2009-08-10 19:44:45 PDT --- Maxime, You should also add yourself above Apple in the copyright section of this code (and other code you have written or modified.) Though since Eric alread r+ this, you can make some new patches later to fix up the copyrights. Or consider also making the change Eric suggested and make a new patch. It's up to you ;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 20:01:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 20:01:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811030112.3C147349B99D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #7 from Ryan Leavengood 2009-08-10 20:01:11 PDT --- (In reply to comment #6) > (From update of attachment 34418 [details]) > What is: > 85 BPoint m_point; > here? Is it the top-left of the menu? Is it the click-point? Seems it needs > a better member name. > > Otherwise this change looks fine. r- for lack of useful name or explanation > for m_point. If you were a committer I would just ask you to rename it to > something when you landed it instead of r-ing. As far as I can tell it isn't really used. It is assigned in the ContextMenu contructor but is otherwise not used. This is probably just more cruft from the old port that I should have helped Maxime purge :/ I'm not sure this context menu code even works at all at this point. I guess it is a start though. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 20:12:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 20:12:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090811031203.5EC11349BAA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34448|review? | Flag| | Attachment #34448|0 |1 is obsolete| | Attachment #34537| |review? Flag| | --- Comment #12 from Laszlo Gombos 2009-08-10 20:12:01 PDT --- Created an attachment (id=34537) --> (https://bugs.webkit.org/attachment.cgi?id=34537) 3rd try Additional changes in the 3rd revision of the patch: - LocalStorageDatabaseEnabled enum value is now deprecated, the new name is LocalStorageEnabled - LocalStoragePath now has a default (/LocalStorage/) Here are some reasons to keep the LocalStorage name (instead of switching to WebStorage). - The LocalStorageEnabled setting does not control SessionStorage and as such WebStorageEnabled name would be misleading - WebStorage is indeed the name of the specification, but the relevant JS interface is called window.localStrorage - I believe the JS interface name is equally/more relevant - WebStorage spec is referenced not only in the HTML5 spec but also in Widgets APIs and Events spec (see http://www.w3.org/TR/widgets-apis, widget.preferences). Since the interface that is defined in this patch is only for the HTML5 LocalStorage I think the name of the interface should be also specific to HTML5 to distinguish it from other WebStorage use-cases -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 20:22:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 20:22:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811032251.C4A92349BB72@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #8 from Ryan Leavengood 2009-08-10 20:22:50 PDT --- (In reply to comment #5) > (From update of attachment 34417 [details]) > Why virtual? > #if PLATFORM(HAIKU) > 175 virtual BBitmap* getBitmap() const; > 176 #endif > > Seems it should be createBBitmap()? Or is it actually a getter? in which case > it can be just bitmap(), no? Well all the other platforms seem to use the same pattern for their native bitmap getters: #if PLATFORM(MAC) // Accessors for native image formats. virtual NSImage* getNSImage(); virtual CFDataRef getTIFFRepresentation(); #endif #if PLATFORM(CG) virtual CGImageRef getCGImageRef(); #endif #if PLATFORM(WIN) virtual bool getHBITMAP(HBITMAP); virtual bool getHBITMAPOfSize(HBITMAP, LPSIZE); #endif #if PLATFORM(GTK) virtual GdkPixbuf* getGdkPixbuf(); #endif Maybe we just need to move ours up with these, I'm not sure why it is down on that line. > We generally don't use "get" in getters: > 388 pattern getHaikuStrokeStyle(); > > haikuStrokeStyle() > > unless that's createing something in which case it should be create. It looks > like it's just returning a stack object though, so it doesn't need "create" in > the name. That is generally the philosophy in Haiku's API for getters too, but in this case this is more of a converter function (to convert WebKit stroke styles into Haiku stroke styles.) I guess haikuStrokeStyle() would still be OK in this case. Or to be explicit: convertToHaikuStrokeStyle()? > Why is this needed? > #elif PLATFORM(HAIKU) > 82 Icon(); > 8183 #endif > please explain in the ChangeLog. Declaring a default constructor for a currently unimplemented class? > Seems like a bad idea: > #elif PLATFORM(HAIKU) > 127 IntPoint(const BPoint&); > 128 operator BPoint() const; > 124129 #endif > You don't wan implicit conversion of floating point points to integer points. > > Again, probably bad idea: > #elif PLATFORM(HAIKU) > 150 IntRect(const BRect&); > 151 operator BRect() const; > 147152 #endif > > Again: > #if PLATFORM(HAIKU) > 119 IntSize(const BSize&); > 120 operator BSize() const; > 121 #endif > > (this is all assuming that B* are floating point based). Yes all the B* classes above use floats. I guess it is better to make all these explicit? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 20:24:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 20:24:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090811032415.8D702349BBA5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34537|review? | Flag| | Attachment #34537|0 |1 is obsolete| | Attachment #34538| |review? Flag| | --- Comment #13 from Laszlo Gombos 2009-08-10 20:24:14 PDT --- Created an attachment (id=34538) --> (https://bugs.webkit.org/attachment.cgi?id=34538) 4th try. Found a typo in the 3rd path, please review this one instead. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:09:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:09:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811040900.C9CFA349BFCE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 Viet-Trung Luu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viettrungluu at gmail.com --- Comment #25 from Viet-Trung Luu 2009-08-10 21:08:56 PDT --- Darin, Safari/Mac appears to generate extra mouse move events for lots of things (including, e.g., mouse downs/ups), thereby avoiding a host of bugs. When scrolling using the keyboard, in Safari/Mac, the cursor (and tooltip) disappear, thereby eliminating a bunch of problems; actually, now that Chromium/Mac also makes the cursor (and consequently the tooltip, apparently) disappear, those same problems go away. Now, unfortunately, the mouse moving code (EventHandler::mouseMoved()/handleMouseMoveEvent()) are very tightly coupled with PlatformMouseEvent. To handle "virtual mouse moves", we need to at least do either (1) send fake mouse move events (ugly, but expedient) or (2) decouple the aforementioned code so that it can handle such "virtual mouse moves" without a PlatformMouseEvent (make an "EventHandler::mouseMovedVirtually()" method or some such). In some sense, the difference between (1) and (2) is cosmetic. You could decouple so far as to push a lot of the logic down into the layout, but that would be drastic and you'd have to make the layout aware of the mouse position. My first instinct to fix the scrolling-related issues is to hook up (1) or (2) in FrameView::valueChanged() (probably inside the "if (offset != scrollOffset())"). Similarly, you could do the same in FrameView::performPostLayoutTasks() -- I think this would probably handle any possible resize-related issues. (There are also possible window-movement issues -- i.e., the window moves without the mouse moving -- though I don't know offhand where that would get hooked up.) Hooking up a fake mouse event is expedient, if a little repugnant; decoupling the code is a bit fragile and goes pretty deep. (E.g., on resize, the mouse may end up over a scrollbar, so you can't just ignore the scrollbars.) Maybe I'll come up with a patch which sends a fake mouse event, and see if it works. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:09:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:09:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811040908.3A97F349BFF0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34536|review? |review- Flag| | --- Comment #21 from mitz at webkit.org 2009-08-10 21:09:06 PDT --- (From update of attachment 34536) Switching to StringTruncator is a move in the right direction, but I don?t think the GraphicsContext changes are good or necessary. GraphicsContext is not the place to create Strings and truncate them. The logical structure where drawBidiText calls drawBidiTextWithinWidth, which calls back into drawBidiText does not make much sense either. Also, if width != -1 (that is, the caller wants truncation), calling Font::floatWidth() once seems wasteful, as the StringTruncator should have the smarts to detect the case where no truncation is necessary. I think your PopupListBox should handle the truncation, create a TextRun from the potentially-truncated String, and call drawBidiText with that. I also don?t understand why you need the ellipsesNeeded member. It seems like you could just always use the StringTruncator. It won?t truncate when unnecessary. If you find out that you need to optimize, then you can cache the actual truncated strings (rather than just a bit telling you whether to truncate). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:11:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:11:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27790] XMLHTTPRequest Status Code 0 Bug In-Reply-To: References: Message-ID: <20090811041116.8D720349C024@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27790 Steve changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|INVALID | --- Comment #2 from Steve 2009-08-10 21:11:15 PDT --- I believe that your opinion that this is not actually a bug is incorrect. jQuery and Prototype's ajax functions also experience the exact same issue I've described in this bug report. I merely used my code to have something that ran self-contained. And the code I used has a javascript closure in it that should avoid the issue you pointed out. Regardless of that however, I just went back and tried again with the very latest copy of both prototype and jquery and this bug still exists. If an ajax request created via jquery or prototype is in progress, and you reload the page at the same time, Safari will cause the error handler to fire in both libraries. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:34:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:34:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27790] XMLHTTPRequest Status Code 0 Bug In-Reply-To: References: Message-ID: <20090811043438.B56D1349C188@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27790 --- Comment #3 from Alexey Proskuryakov 2009-08-10 21:34:38 PDT --- > And the code I used has a javascript closure in it that should avoid the issue > you pointed out. You don't get a new closure each time you call a function, no. > If an ajax request created via jquery or prototype is in progress, and you > reload the page at the same time, Safari will cause the error handler to fire > in both libraries. This sounds like something different than reported originally. The linked test doesn't even have an error event handler. Please clarify what exactly you report as a bug. If it's something different than reported originally, it's best to resolve this issue as INVALID and file a new one to avoid further confusion. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:36:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:36:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28170] New: SharedWorkers do not exit when the last parent document exits Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28170 Summary: SharedWorkers do not exit when the last parent document exits Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: WebCore JavaScript AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: atwilson at google.com Depends on: 28136 The SharedWorker lifecycle is tied to the lifecycle of its associated documents. When the last document associated with a SharedWorker exits, the worker needs to be shut down. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:51:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:51:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28170] SharedWorkers do not exit when the last parent document exits In-Reply-To: References: Message-ID: <20090811045103.B3D07349C2BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28170 Andrew Wilson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34539| |review? Flag| | AssignedTo|webkit-unassigned at lists.web |atwilson at google.com |kit.org | --- Comment #1 from Andrew Wilson 2009-08-10 21:51:03 PDT --- Created an attachment (id=34539) --> (https://bugs.webkit.org/attachment.cgi?id=34539) proposed patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:26:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:26:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811052615.70D3C349C57A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 --- Comment #26 from Viet-Trung Luu 2009-08-10 22:26:12 PDT --- Created an attachment (id=34540) --> (https://bugs.webkit.org/attachment.cgi?id=34540) Quick and dirty patch, as per my comments. For commentary only; no changelog entries. Only tested on Chromium/Mac. Hmm. The effect seems to be different from what happens in Safari/Mac (not for scrolling with arrow keys, but with trackpad/mousewheel -- see ). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:29:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:29:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27904] notImplemented() is too subtle In-Reply-To: References: Message-ID: <20090811052945.9AC6B349C5DC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27904 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:37:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:37:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27790] XMLHTTPRequest Status Code 0 Bug In-Reply-To: References: Message-ID: <20090811053751.73890349C652@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27790 Steve changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:40:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:40:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28123] WebKit could not copy the form with this parameter in the iframe In-Reply-To: References: Message-ID: <20090811054026.5ED50349C694@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28123 --- Comment #4 from Alexey Proskuryakov 2009-08-10 22:40:25 PDT --- Created an attachment (id=34541) --> (https://bugs.webkit.org/attachment.cgi?id=34541) reduction OK, I think that this is a reduction of the issue at hand. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:44:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:44:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20968] Crash in JSC::ProgramNode::~ProgramNode() in r36712 In-Reply-To: References: Message-ID: <20090811054411.375F7349C6F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20968 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WORKSFORME --- Comment #2 from Alexey Proskuryakov 2009-08-10 22:44:10 PDT --- JavaScriptCore has been all but rewritten since the bug was filed, so it doesn't look useful now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:45:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:45:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28123] File input value is not cloned by importNode() In-Reply-To: References: Message-ID: <20090811054514.D8E57349C6FE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28123 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 |P2 Status|UNCONFIRMED |NEW Component|JavaScriptCore |Forms Platform|PC |All Summary|WebKit could not copy the |File input value is not |form with this parameter in |cloned by importNode() |the iframe | Ever Confirmed|0 |1 OS/Version|Windows Server 2003 |All -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 23:43:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 23:43:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17730] Allows Windows version to use Curl In-Reply-To: References: Message-ID: <20090811064315.AA30C349CB25@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17730 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #13 from Brent Fulgham 2009-08-10 23:43:13 PDT --- This bug is no longer relevant. The cURL components are now fully building and running under the redistributable Windows port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 23:54:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 23:54:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20098] Cairo building - curl errors ResourceHandleManager.cpp In-Reply-To: References: Message-ID: <20090811065405.7AEFB349CC11@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20098 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from Brent Fulgham 2009-08-10 23:54:04 PDT --- I believe this bug is corrected in the current release. Please reopen if you continue to encounter this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 23:56:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 23:56:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18471] Fix WebDownload.cpp compile problems for cairo/curl build In-Reply-To: References: Message-ID: <20090811065614.94833349CC3D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18471 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED CC| |bfulgham at webkit.org AssignedTo|webkit-unassigned at lists.web |bfulgham at webkit.org |kit.org | Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 23:56:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 23:56:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20732] -lws2_32 not -lWs2_32 In-Reply-To: References: Message-ID: <20090811065653.01259349CC67@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20732 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bfulgham at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 00:12:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 00:12:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28146] Allow Inspector's Number.toString to print low-resolution values In-Reply-To: References: Message-ID: <20090811071221.11BE0349CDE8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28146 --- Comment #3 from Mikhail Naganov 2009-08-11 00:12:19 PDT --- I'm working on the heap profiling page for Chromium. I have one place where I'm displaying memory stats (as a subtitle for memory snapshot items), and there I don't need excessive precision provided by the default version of Number.bytesToString. That's why I decided to provide 'low-res' argument to it. You can check out the current look of the Heap page here: http://build.chromium.org/buildbot/continuous/mac/2009-08-10/22915/chrome-mac.zip As I'm planning to upstream it to WebKit some day, so let's discuss it. The current view is very simple, I have more functionality to add. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 00:37:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 00:37:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] New: fix a typo in platform/graphics/skia/PlatformContextSkia.cpp Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28172 Summary: fix a typo in platform/graphics/skia/PlatformContextSkia.cpp Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hamaji at chromium.org If has the following line: #ifdef SK_DEBUGx The macro should be SK_DEBUG, I think. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 00:38:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 00:38:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] fix a typo in platform/graphics/skia/PlatformContextSkia.cpp In-Reply-To: References: Message-ID: <20090811073843.6B15D349D0A1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28172 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34543| |review? Flag| | --- Comment #1 from Shinichiro Hamaji 2009-08-11 00:38:42 PDT --- Created an attachment (id=34543) --> (https://bugs.webkit.org/attachment.cgi?id=34543) Patch v1 --- 2 files changed, 13 insertions(+), 1 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 00:41:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 00:41:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] fix a typo in platform/graphics/skia/PlatformContextSkia.cpp In-Reply-To: References: Message-ID: <20090811074142.406BE349D0DC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28172 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34543|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 01:09:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 01:09:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27899] [Gtk] Expose a database API In-Reply-To: References: Message-ID: <20090811080914.EB1D3349D39C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27899 --- Comment #2 from Martin Robinson 2009-08-11 01:09:14 PDT --- Created an attachment (id=34544) --> (https://bugs.webkit.org/attachment.cgi?id=34544) First pass at a database API I'm attaching my first pass to solicit comments from more experienced people. I'd love to get some feedback before I start preparing this patch for review. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 01:49:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 01:49:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090811084917.E657F349D69D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 Ariya Hidayat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ariya.hidayat at trolltech.com --- Comment #5 from Ariya Hidayat 2009-08-11 01:49:16 PDT --- I just added pixel tests support some time ago, so it is possible to add a test case to this patch. Check e.g. LayoutTests/fast/canvas/shadow-offset-* tests. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 02:32:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 02:32:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090811093237.6258C349DAB6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 Ariya Hidayat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34521|review? |review- Flag| | --- Comment #6 from Ariya Hidayat 2009-08-11 02:32:36 PDT --- (From update of attachment 34521) r- for now because of the missing pixel tests. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 02:42:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 02:42:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090811094221.6D683349DBAE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34545| |review? Flag| | --- Comment #1 from Fumitoshi Ukai 2009-08-11 02:42:20 PDT --- Created an attachment (id=34545) --> (https://bugs.webkit.org/attachment.cgi?id=34545) Add SocketStreamHandle interface --- 13 files changed, 736 insertions(+), 1 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 02:44:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 02:44:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28173] New: [GTK] Remove keyring optional features Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28173 Summary: [GTK] Remove keyring optional features Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: xan.lopez at gmail.com Per bug #26242, providing optional keyring support in webkitgtk+ itself can be quite problematic for distributors and application developers, and would force us to ship a runtime introspection system to see the features the library you are using has enabled. For that reason I propose to move the keyring support to libsoup instead, which already has a system like that, and where applications will be able to trivially choose to enable it or not. The only downside of this is that we'll need to figure out a way to store auth data from forms in keyring from applications/libsoup, since webkit won't be able to depend on it directly. I think that will be doable though, since other ports are already doing it. Attached is a first patch to use the extra auth support available in the 'keyring' branch in libsoup git. If this is approved we'll commit both this patch and that branch to master at the same time. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 02:51:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 02:51:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28173] [GTK] Remove keyring optional features In-Reply-To: References: Message-ID: <20090811095122.07A5A349DCAB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28173 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34546| |review? Flag| | AssignedTo|webkit-unassigned at lists.web |xan.lopez at gmail.com |kit.org | --- Comment #1 from Xan Lopez 2009-08-11 02:51:21 PDT --- Created an attachment (id=34546) --> (https://bugs.webkit.org/attachment.cgi?id=34546) removekeyring.patch Remove optional keyring support from WebKit, move it to libsoup. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 03:05:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 03:05:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090811100519.C9D3A349DE1A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34548| |review? Flag| | --- Comment #1 from Fumitoshi Ukai 2009-08-11 03:05:19 PDT --- Created an attachment (id=34548) --> (https://bugs.webkit.org/attachment.cgi?id=34548) WebSocket API implementation. depends on bug 28037 --- 20 files changed, 1277 insertions(+), 71 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 04:19:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 04:19:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090811111933.AA756349E6B2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 --- Comment #7 from Ariya Hidayat 2009-08-11 04:19:32 PDT --- Sorry, I pasted the wrong path. The pixel tests for this should be in LayoutTests/platform/mac/fast/box-shadow/ instead. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 04:39:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 04:39:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26390] WebKitGtk+/JavaScriptCore segfault on a specific page when built with gcc 4.4 In-Reply-To: References: Message-ID: <20090811113944.20A1B349E898@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26390 Adrian Bunk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #2 from Adrian Bunk 2009-08-11 04:39:42 PDT --- Just checked the status of this issue: Crashes still happen with 1.1.10. No crashes with 1.1.11 and 1.1.12. It seems whatever caused it was fixed in WebKitGTK+ 1.1.11. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 04:42:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 04:42:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811114218.D0061349E8EC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Zoltan Herczeg changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34265|review? | Flag| | Attachment #34265|0 |1 is obsolete| | Attachment #34549| |review?(darin at apple.com) Flag| | --- Comment #18 from Zoltan Herczeg 2009-08-11 04:42:13 PDT --- Created an attachment (id=34549) --> (https://bugs.webkit.org/attachment.cgi?id=34549) Fourth patch Actually WebCore is much better written than I expected, so uniforming the constant pointer handling is not that hard. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 04:45:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 04:45:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811114537.9ADCD349E964@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #19 from Zoltan Herczeg 2009-08-11 04:45:35 PDT --- After starting and quiting from QtLauncher, the leak reduced from: ==18154== LEAK SUMMARY: ==18154== definitely lost: 66,632 bytes in 496 blocks. ==18154== possibly lost: 25,536 bytes in 7 blocks. ==18154== still reachable: 241,690 bytes in 5,595 blocks. ==18154== suppressed: 0 bytes in 0 blocks. Number of loss records: 295 To: ==6905== LEAK SUMMARY: ==6905== definitely lost: 344 bytes in 2 blocks. ==6905== indirectly lost: 20 bytes in 1 blocks. ==6905== possibly lost: 744 bytes in 3 blocks. ==6905== still reachable: 117,418 bytes in 2,859 blocks. ==6905== suppressed: 0 bytes in 0 blocks. Number of loss records: 131 And 50k from this space is a debug structure used by StructureID-s. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:12:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:12:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28016] Web page freezes Qt Webkit In-Reply-To: References: Message-ID: <20090811121251.DE73A34A6B68@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28016 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laszlo.1.gombos at nokia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:13:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:13:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090811121335.0DEB134A72BF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laszlo.1.gombos at nokia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:27:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:27:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090811122748.3A31934ADB14@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34410|0 |1 is obsolete| | Attachment #34550| |review? Flag| | --- Comment #4 from Maxime Simon 2009-08-11 05:27:46 PDT --- Created an attachment (id=34550) --> (https://bugs.webkit.org/attachment.cgi?id=34550) Patch to add the ScrollbarTheme files for Haiku. Make some changes as suggested by Eric and Ryan, even if the previous patches was r+. I also made some style cleanup. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:49:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:49:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28174] New: Profile view status bar buttons are blank Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28174 Summary: Profile view status bar buttons are blank Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mnaganov at chromium.org CC: timothy at hatcher.name, pfeldman at chromium.org This bug was introduced in r46979. Profile view buttons (those shown below a profile view) wasn't updated to use createStatusBarButton method. As a result, they are blank. Trying to fix it naively, I've found that as profile view doesn't have a reference to a Profiles panel, it would need to access the createStatusBarButton function through WebInspector.panels.profiler, which isn't good. So I've decided to encapsulate glyph-based buttons into a new class. As an additional benifit, this allowed to encapsulate toggling and hiding functionality. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:55:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:55:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811125526.DDCD734AE66D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #9 from Maxime Simon 2009-08-11 05:55:25 PDT --- (In reply to comment #8) > (In reply to comment #5) > > (From update of attachment 34417 [details] [details]) > > Why virtual? > > #if PLATFORM(HAIKU) > > 175 virtual BBitmap* getBitmap() const; > > 176 #endif > > > > Seems it should be createBBitmap()? Or is it actually a getter? in which case > > it can be just bitmap(), no? > > Well all the other platforms seem to use the same pattern for their native > bitmap getters: > [?] > > Maybe we just need to move ours up with these, I'm not sure why it is down on > that line. Even if we keep the "get" prefix, we should rename this function from getBitmap to getBBitmap (I can't see why I removed the B). Concerning the virtual, all other ports use it? (Yes I like mimicry.) > > Why is this needed? > > #elif PLATFORM(HAIKU) > > 82 Icon(); > > 8183 #endif > > please explain in the ChangeLog. > > Declaring a default constructor for a currently unimplemented class? Actually, I didn't check why we have this constructor. :-/ > > Seems like a bad idea: > > #elif PLATFORM(HAIKU) > > 127 IntPoint(const BPoint&); > > 128 operator BPoint() const; > > 124129 #endif > > You don't wan implicit conversion of floating point points to integer points. > > > > Again, probably bad idea: > > #elif PLATFORM(HAIKU) > > 150 IntRect(const BRect&); > > 151 operator BRect() const; > > 147152 #endif > > > > Again: > > #if PLATFORM(HAIKU) > > 119 IntSize(const BSize&); > > 120 operator BSize() const; > > 121 #endif > > > > (this is all assuming that B* are floating point based). > > Yes all the B* classes above use floats. I guess it is better to make all these > explicit? I changed this, it will be included in the next patches. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:55:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:55:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811125554.8B9A934AE693@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hamaji at chromium.org --- Comment #3 from Shinichiro Hamaji 2009-08-11 05:55:52 PDT --- I'd like to help this! Before I actually start, I'd like to check if I understand the requirements correctly. I think the first step of this bug is moving all resources/*.js files which aren't excluded by the list in make-js-test-wrappers into somewhere, fix all layout tests so that they reference the new location, and make-js-test-wrappers look the destination directory. Am I understanding correctly? Also, I'd like to know the better name for them. Maybe "js" or "scripts" ? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:59:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:59:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28174] Profile view status bar buttons are blank In-Reply-To: References: Message-ID: <20090811125919.58D3C34AE6EE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28174 Mikhail Naganov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34552| |review? Flag| | --- Comment #1 from Mikhail Naganov 2009-08-11 05:59:18 PDT --- Created an attachment (id=34552) --> (https://bugs.webkit.org/attachment.cgi?id=34552) Proposed change -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 06:21:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 06:21:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28175] New: HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28175 Summary: HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: laszlo.1.gombos at nokia.com The path separators in the path that is being passed to sqlite is not the native OS path; instead it is always the "/" - the Qt universal directory separator. Most OS (even Windows I think) understands the "/" separator - but not Symbian. The problem could be solved by calling QDir::toNativeSeparators() before the path is passed to the OS. The problem and the possible solution was brought to my attention by David Leong. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 06:27:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 06:27:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28175] HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit In-Reply-To: References: Message-ID: <20090811132744.C28E234AEA57@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28175 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34553| |review? Flag| | --- Comment #1 from Laszlo Gombos 2009-08-11 06:27:44 PDT --- Created an attachment (id=34553) --> (https://bugs.webkit.org/attachment.cgi?id=34553) proposed patch. WebCore::pathByAppendingComponent() seems to be a good place to call QDir::toNativeSeparators before the path is passed to the OS. All the path construction to sqlite DBs are going trough this function. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 06:42:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 06:42:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090811134251.436D234AEBE3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 --- Comment #14 from Kenneth Rohde Christiansen 2009-08-11 06:42:50 PDT --- I guess on Mac you should add the organization name to the path? like mentioned in the docs for QString QDesktopServices::storageLocation ( StandardLocation type ) Any mac guy have some input? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 06:48:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 06:48:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090811134852.DEBEA34AEC8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 --- Comment #15 from Kenneth Rohde Christiansen 2009-08-11 06:48:52 PDT --- (From update of attachment 34538) > + // Set HTML5 Application Cache default location > + QWebSettings::setOfflineWebApplicationCachePath(defaultCachePath()); I think we want to append /ApplicationCache or so. Simon, how do we hide the deprecated methods from the docs? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:08:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:08:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811140844.17B8334AEE86@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #10 from Maxime Simon 2009-08-11 07:08:42 PDT --- (In reply to comment #7) > (In reply to comment #6) > > (From update of attachment 34418 [details] [details]) > > What is: > > 85 BPoint m_point; > > here? Is it the top-left of the menu? Is it the click-point? Seems it needs > > a better member name. > > > > Otherwise this change looks fine. r- for lack of useful name or explanation > > for m_point. If you were a committer I would just ask you to rename it to > > something when you landed it instead of r-ing. > > As far as I can tell it isn't really used. It is assigned in the ContextMenu > contructor but is otherwise not used. This is probably just more cruft from the > old port that I should have helped Maxime purge :/ > > I'm not sure this context menu code even works at all at this point. I guess it > is a start though. Indeed, it's an unused variable. I removed it. It calculated the origin of each BMenuItem (if I'm right). But it seems not to be necessary now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:09:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:09:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090811140952.6799D34AEEA6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 --- Comment #8 from Ariya Hidayat 2009-08-11 07:09:50 PDT --- But of course, for the Qt port, we need LayoutTests/platform/qt/fast/box-shadow for the pixel test result. The actual test is in LayoutTests/fast/box-shadow/. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:19:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:19:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27842] Implement GraphicsContext::fillRoundRect() for WINCE port In-Reply-To: References: Message-ID: <20090811141947.4D67034AEFD2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27842 Crystal Zhang changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #22 from Crystal Zhang 2009-08-11 07:19:45 PDT --- Has been fixed and committed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:22:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:22:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811142237.8D33434AF039@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34418|0 |1 is obsolete| | Attachment #34554| |review? Flag| | --- Comment #11 from Maxime Simon 2009-08-11 07:22:36 PDT --- Created an attachment (id=34554) --> (https://bugs.webkit.org/attachment.cgi?id=34554) Patch to modify some WebCore/platform/ files to allow the Haiku port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:23:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:23:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28176] New: "document.documentElement.removeAttribute("style"); " occasionally silently fails. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28176 Summary: "document.documentElement.removeAttribute("style");" occasionally silently fails. Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptGlue AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: vincent at shoopz.com This bug happens on both releases of Safari 3.2.3 (Windows XP/Intel) and Safari 4.0.2 (Mac OS X 10.5.8/Intel and Windows XP/Intel). When first loaded my script does ----------------------------- document.documentElement.style.display = "none"; ----------------------------- to delay the display of the page. Later it does ----------------------------- document.documentElement.removeAttribute("style"); ----------------------------- This makes the page display correctly on IE 7,8 and FF3 but on Safari 3 and 4 the page stays blank as if the instruction had been discarded. This bug mysteriously disapears if the page is loaded while the Error Console is enabled under Safari 4 (both Win and Mac). In that case the page displays correctly. Suggested workaround: replacing the above line with ----------------------------- document.documentElement.style.display = ""; ----------------------------- makes it work, both with and without the Error Console enabled. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:28:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:28:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28176] "document.documentElement.removeAttribute("style"); " occasionally silently fails. In-Reply-To: References: Message-ID: <20090811142829.E992634AF0ED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28176 Jean-Noel Rivasseau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elvanor at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:34:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:34:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811143455.F3DCE34AF1A9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 --- Comment #5 from Maxime Simon 2009-08-11 07:34:54 PDT --- (In reply to comment #3) > Why does FontPlatformData use FontDescription at all? the Mac version doesn't > at least. Shouldn't this just wrap a BFont? At least the gtk port does it. But with some simple tests it seems that the type of FontDescription is always NoFamily. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:36:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:36:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090811143631.2BB3334AF1E6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34504|review? | Flag| | Attachment #34504|0 |1 is obsolete| | Attachment #34555| |review? Flag| | --- Comment #3 from Mike Fenton 2009-08-11 07:36:30 PDT --- Created an attachment (id=34555) --> (https://bugs.webkit.org/attachment.cgi?id=34555) Fix missing brace in previous patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:41:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:41:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28147] Qt build skips fast/borders/border-radius-split-inline.html when it is unnecessary In-Reply-To: References: Message-ID: <20090811144117.0C80434AF27C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28147 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34477|review? |review+, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:44:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:44:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811144454.9016134AF2E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34421|0 |1 is obsolete| | Attachment #34556| |review? Flag| | --- Comment #6 from Maxime Simon 2009-08-11 07:44:53 PDT --- Created an attachment (id=34556) --> (https://bugs.webkit.org/attachment.cgi?id=34556) Patch to add four font-specific files to WebCore/platform/graphics/haiku/. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:51:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:51:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090811145159.5E4E534AF3A0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34500|review? |review- Flag| | --- Comment #4 from Adam Treat 2009-08-11 07:51:58 PDT --- (From update of attachment 34500) This is awesome! I imagine this will fix quite a few tests :) A few comments: > + } else { > + qDebug() << ">>>>>>>>> keyDown" << string; Is this necessary? > + // map special keycode strings used by the tests to something that works for Qt/X11 > + if (string == "leftArrow") { string == QLatin1String("leftArrow") I think. r- to change. And then I'll land :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:55:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:55:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811145554.7FFBD34AF41F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34554|review? |review- Flag| | --- Comment #12 from Eric Seidel 2009-08-11 07:55:52 PDT --- (From update of attachment 34554) m_ for member variables: #if PLATFORM(MAC) 213218 WidgetPrivate* m_data; 219 #elif PLATFORM(HAIKU) 220 WidgetPrivate* data; 214221 #endif Otherwise this looks fine. If you were a committer I would r+ this and you could fix and land it yourself. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:58:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:58:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811145818.E438734AF484@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34554|0 |1 is obsolete| | Attachment #34557| |review? Flag| | --- Comment #13 from Maxime Simon 2009-08-11 07:58:17 PDT --- Created an attachment (id=34557) --> (https://bugs.webkit.org/attachment.cgi?id=34557) Patch to modify some WebCore/platform/ files to allow the Haiku port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:59:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:59:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090811145936.4F3F734AF4D3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 --- Comment #97 from Gabor Loki 2009-08-11 07:59:28 PDT --- Created an attachment (id=34558) --> (https://bugs.webkit.org/attachment.cgi?id=34558) a -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:01:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:01:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811150100.CF5EC34AF523@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34557|review? |review- Flag| | --- Comment #14 from Eric Seidel 2009-08-11 08:00:59 PDT --- (From update of attachment 34557) 220 WidgetPrivate* m_data; WidgetPrivate is never declared... so that won't compile, or? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:02:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:02:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811150216.E934034AF551@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34557|review- |review+, commit-queue+ Flag| | --- Comment #15 from Eric Seidel 2009-08-11 08:02:16 PDT --- (From update of attachment 34557) Nevermind. Looks fine. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:04:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:04:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811150415.7D4A734AF5A5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #16 from Maxime Simon 2009-08-11 08:04:14 PDT --- (In reply to comment #14) > (From update of attachment 34557 [details]) > 220 WidgetPrivate* m_data; > > WidgetPrivate is never declared... so that won't compile, or? Indeed? As I was changing data to m_data I saw that WidgetPrivate is never declared, but what it compiles without problem anyway? :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:05:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:05:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811150558.D2E6934AF5E5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #17 from Eric Seidel 2009-08-11 08:05:57 PDT --- It's forward declared at the top of the file. I hope you're not just adding these members because other ports have them? Code should only be added when it's actually used.... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:07:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:07:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811150742.7FB8B34AF62F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #18 from Maxime Simon 2009-08-11 08:07:41 PDT --- (In reply to comment #17) > It's forward declared at the top of the file. > > I hope you're not just adding these members because other ports have them? > Code should only be added when it's actually used.... No, that's because we used to have it. Since then I modify the port I forgot to remove it. I'll submit a new patch without this WidgetPrivate. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:10:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:10:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811151050.78D5F34AF699@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #19 from Eric Seidel 2009-08-11 08:10:49 PDT --- It seems like you all are close to having all of your files upstreamed. Have you started work on build-webkit integration and a DumpRenderTree? Having working layout tests (aka having a DumpRenderTree implementation) is an essential part of being a port which is long-term successful. w/o layout tests the port will be broken again in a matter of weeks. :( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:14:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:14:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811151412.F24E434AF72D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #20 from Maxime Simon 2009-08-11 08:14:11 PDT --- (In reply to comment #19) > It seems like you all are close to having all of your files upstreamed. Have > you started work on build-webkit integration and a DumpRenderTree? Having > working layout tests (aka having a DumpRenderTree implementation) is an > essential part of being a port which is long-term successful. w/o layout tests > the port will be broken again in a matter of weeks. :( I have a working version of DumpRenderTree but I didn't implement all the tests. Concerning build-webkit I didn't make anything. Currently we are using Jamfiles, but we want to change this and use GYP instead (we must write a backend to generate Jamfiles). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:18:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:18:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811151815.86DF234AF7CC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34557|0 |1 is obsolete| | Attachment #34559| |review? Flag| | --- Comment #21 from Maxime Simon 2009-08-11 08:18:14 PDT --- Created an attachment (id=34559) --> (https://bugs.webkit.org/attachment.cgi?id=34559) Patch to modify some WebCore/platform/ files to allow the Haiku port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:22:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:22:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090811152227.2A78A34AF879@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gabor Loki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34129|0 |1 is obsolete| | Attachment #34130|0 |1 is obsolete| | Attachment #34558|0 |1 is obsolete| | Attachment #34560| |review? Flag| | --- Comment #98 from Gabor Loki 2009-08-11 08:22:20 PDT --- Created an attachment (id=34560) --> (https://bugs.webkit.org/attachment.cgi?id=34560) Add optimize call and property access support for ARM JIT I have done the requested changes from comment #93. - The 'latePatch' method is removed. It looks like that forcing the address of calls on constant pool does not hurt much. Wash on SunSpider (slightly slower but not statistically significant). - The {BEGIN,END}_UNINTERRUPTED_SEQUENCE macros have been introduced for tightly coupled sequences. I try to keep the code as platform independent as possible. - The optimize call and property access patches are combined. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:27:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:27:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811152749.51A1C34AF917@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 --- Comment #7 from Maxime Simon 2009-08-11 08:27:48 PDT --- (In reply to comment #4) > It seems the handling of m_smallCapsFontData is wrong on other ports. But I'm > not convinced your handling is correct either. It certainly is strange that > SimpleFontData.cpp would try to delete it too. I took a look on other ports. It seems that gtk, win, wince, wx and mac are handling m_smallCapsFontData the same way I do (if I'm right). But in fact it could be wrong. > What is an "escapement"? Wow a B-only term it seems: > http://www.acm.uiuc.edu/bug/Be%20Book/The%20Interface%20Kit/Font.html Eh Eh, an escapement is the B-term to design the width of a glyph. ;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:34:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:34:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811153439.C0FF634AF9BB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 --- Comment #8 from Maxime Simon 2009-08-11 08:34:38 PDT --- (In reply to comment #4) > Shouldn't char* out be char[4]& out? I tried with char[4]& but it didn't compile. I got this output "error: 'out' was not declared in this scope." > Why is the const_cast needed? > 79 GlyphBufferGlyph* glyphs = > const_cast(glyphBuffer.glyphs(from)); This const_cast is needed because the glyphBuffer argument of the function is const, and the glyphs we are creating will be modified. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:38:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:38:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090811153848.B73BC34AFA29@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 --- Comment #2 from David Levin 2009-08-11 08:38:47 PDT --- (From update of attachment 34545) Simply a style pass. I looked at this and saw a few style issues to clean up. > diff --git a/WebCore/platform/network/SocketStreamErrorBase.h b/WebCore/platform/network/SocketStreamErrorBase.h > + class SocketStreamErrorBase { > + public: public:, private:, protected: should be aligned with "class". There are multiple instances but I'm only commenting on this one. > + SocketStreamErrorBase() > + : m_errorCode(0) > + , m_isNull(true) These should only be indented 4 spaces (not 8). There are multiple instances but I'm only commenting on this one. > diff --git a/WebCore/platform/network/SocketStreamHandle.h b/WebCore/platform/network/SocketStreamHandle.h > + virtual int platformSend(const char*, int); Please include parameter names for this method. Parameter names are omitted when they don't add information. In this case, they would add information. > diff --git a/WebCore/platform/network/SocketStreamHandleBase.cpp b/WebCore/platform/network/SocketStreamHandleBase.cpp > +bool SocketStreamHandleBase::send(const char* buf, int size) s/buf/buffer/ Use full words for variables. > + int num_written = 0; s/num_written/bytesWritten/ bad casing. > +void SocketStreamHandleBase::setClient(SocketStreamHandleClient* client) > +{ Consider adding asserts here. Can this be called in any state? Can it be called after a client has already been set? > +bool SocketStreamHandleBase::sendPendingData() > +{ > + if (m_state != Open) > + return false; > + if (m_buffer.isEmpty()) > + return false; > + int num_written = platformSend(m_buffer.data(), m_buffer.size()); s/num_written/bytesWritten/ bad casing. > + Vector remaining_data; s/remaining_data/remainingData/ bad casing. > + remaining_data.append(m_buffer.data() + num_written, > + m_buffer.size() - num_written); Indentation mistake. > diff --git a/WebCore/platform/network/SocketStreamHandleBase.h b/WebCore/platform/network/SocketStreamHandleBase.h > + virtual ~SocketStreamHandleBase() {} s/{}/{ }/ Add a space in the {} > + bool send(const char*, int); Please include parameter names for this method. > + virtual int platformSend(const char*, int) = 0; Please include parameter names for this method. > diff --git a/WebCore/platform/network/SocketStreamHandleClient.h b/WebCore/platform/network/SocketStreamHandleClient.h > + virtual void willSendData(SocketStreamHandle*, const char*, int) { } Please include parameter names for the char* and int. > + virtual void didReceivedData(SocketStreamHandle*, const char*, int) { } Please include parameter names for the char* and int. > diff --git a/WebCore/platform/network/mac/SocketStreamError.h b/WebCore/platform/network/mac/SocketStreamError.h > + SocketStreamError() {} s/{}/{ }/ > diff --git a/WebCore/platform/network/mac/SocketStreamHandleMac.mm b/WebCore/platform/network/mac/SocketStreamHandleMac.mm > + SocketStreamHandleInternal() {} > + ~SocketStreamHandleInternal() {} s/{}/{ }/ > diff --git a/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp b/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp > +class SocketStreamHandleInternal { > +public: > + SocketStreamHandleInternal() {} > + ~SocketStreamHandleInternal() {} s/{}/{ }/ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:44:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:44:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811154430.BC08234AFACB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34422|0 |1 is obsolete| | Attachment #34561| |review? Flag| | --- Comment #9 from Maxime Simon 2009-08-11 08:44:30 PDT --- Created an attachment (id=34561) --> (https://bugs.webkit.org/attachment.cgi?id=34561) Patch to add four other font-specific files to WebCore/platform/graphics/haiku/. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:49:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:49:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090811154950.6BA6A34AFB34@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34500|0 |1 is obsolete| | Attachment #34562| |review? Flag| | --- Comment #5 from Mike Fenton 2009-08-11 08:49:49 PDT --- Created an attachment (id=34562) --> (https://bugs.webkit.org/attachment.cgi?id=34562) Revised code change wrapping strings with QLatin1String() -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:50:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:50:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811155040.D2EEC34AFB5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yong.li at torchmobile.com --- Comment #20 from Yong Li 2009-08-11 08:50:37 PDT --- Is there a specified webkit name pattern for global variables? In this patch, I've seen both "foo" (same as local variables) and "gFoo". I use "g_Foo" in my code, but Eric says it's wrong. So what pattern should be used for global variables? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:51:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:51:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811155129.6D8E334AFBA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #21 from Yong Li 2009-08-11 08:51:27 PDT --- (In reply to comment #20) > Is there a specified webkit name pattern for global variables? In this patch, > I've seen both "foo" (same as local variables) and "gFoo". I use "g_Foo" in my > code, but Eric says it's wrong. So what pattern should be used for global > variables? correction: should be "g_foo" -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:03:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:03:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090811160350.59D0434AFD3D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 --- Comment #3 from David Levin 2009-08-11 09:03:49 PDT --- (From update of attachment 34545) Two more style comments: > + /* static */ WebKit doesn't do this. > + int SocketStreamHandle::platformSend(const char *, int) * goes near the type -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:04:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:04:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28129] [Haiku] Adding three new files to WebCore/platform/haiku. In-Reply-To: References: Message-ID: <20090811160415.7352334AFD52@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28129 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34419|0 |1 is obsolete| | Attachment #34563| |review? Flag| | --- Comment #3 from Maxime Simon 2009-08-11 09:04:14 PDT --- Created an attachment (id=34563) --> (https://bugs.webkit.org/attachment.cgi?id=34563) Patch to add three new files to WebCore/platform/haiku/ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:04:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:04:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28177] New: WebInspector: Migrate to DOMAgent (serialized access to DOM) Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28177 Summary: WebInspector: Migrate to DOMAgent (serialized access to DOM) Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pfeldman at chromium.org CC: timothy at hatcher.name This is a large change that wires all the pieces of the migration together. What we already have: - There is a InspectorDOMAgent / DOMAgent infrastructure that replicates DOM structure to the Web Inspector's Elements Pane. - There is a Styles and Properties sidebar panels that interact with the page in serialized way. What is missing: 1) We are using quarantined nodes, not DOMAgent yet 2) Console evaluation and console.log push quarantined JS objects into the frontend. They should push proxy objects instead This change is supposed to fix these. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:08:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:08:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090811160812.1212A34AFDEA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34545|review? |review- Flag| | --- Comment #4 from Alexey Proskuryakov 2009-08-11 09:08:11 PDT --- (From update of attachment 34545) > + if (num_written < size) > + m_buffer.append(buf + num_written, size - num_written); I think that we need a (large) upper limit on buffer size - it's too easy to send data faster than network permits, exhausting system memory and making the system unresponsive. Certainly, there are many other ways to exhaust memory via JavaScript, so it would be just a safety net, not a real security measure. > + remaining_data.append(m_buffer.data() + num_written, > + m_buffer.size() - num_written); As David pointed out, this is an indentation mistake - but there's no need to split the line anyway, it's quite short. Looks good to me in general. I'm not sure if I'm not stepping on Dave's toes here, but r- to address the comments. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:12:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:12:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090811161238.6F66834AFE7D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34550|review? | Flag| | Attachment #34550|0 |1 is obsolete| | Attachment #34564| |review? Flag| | --- Comment #5 from Maxime Simon 2009-08-11 09:12:37 PDT --- Created an attachment (id=34564) --> (https://bugs.webkit.org/attachment.cgi?id=34564) Patch to add the ScrollbarTheme files for Haiku. Sorry, the previous had a mistake. I changed scrollbar->height() to scrollbar->width(), so it didn't display correctly the back button. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:13:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:13:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28177] WebInspector: Migrate to DOMAgent (serialized access to DOM) In-Reply-To: References: Message-ID: <20090811161311.B712534AFE96@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28177 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34565| |review? Flag| | Status|UNCONFIRMED |ASSIGNED AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | Ever Confirmed|0 |1 --- Comment #1 from Pavel Feldman 2009-08-11 09:13:10 PDT --- Created an attachment (id=34565) --> (https://bugs.webkit.org/attachment.cgi?id=34565) Step1: Most of the work done. Call for your comments. The general idea of this patch is that we stop pushing live objects into the frontend upon evaluation and console.dir requests. It also migrates to WebInspector.DOMAgent. Patch is not complete: - it does not implement DOM search - it breaks commandLineAPI's inspect(o). But it already has a lot of changes and I would like to get initial feedback on it. I am fixing the ones above in the meanwhile. What will happen after this change: - More bugfixes if I miss anything - Move search worker into the InjectedScript - Look at debugging, database and the rest of the places that still push live objects into the frontend - Move InjectedScript into the isolated context and get rid of all the "quarantine*" calls and support. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:16:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:16:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811161627.ABB2534AFF12@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34559|review? |review+, commit-queue+ Flag| | --- Comment #22 from Eric Seidel 2009-08-11 09:16:26 PDT --- (From update of attachment 34559) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:17:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:17:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090811161732.292C634AFF46@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |levin at chromium.org Ever Confirmed|0 |1 --- Comment #5 from David Levin 2009-08-11 09:17:30 PDT --- > I'm not sure if I'm not stepping on Dave's toes... Not at all. I simply noticed some styling issues and thought I'd point them out (in case he was able to get to them before the "real" review). I should have made this more clear. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:30:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:30:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28146] Allow Inspector's Number.toString to print low-resolution values In-Reply-To: References: Message-ID: <20090811163008.0C87434B00BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28146 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34450|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:33:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:33:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28174] Profile view status bar buttons are blank In-Reply-To: References: Message-ID: <20090811163310.99D9634B010A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28174 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34552|review? |review- Flag| | --- Comment #2 from Timothy Hatcher 2009-08-11 09:33:10 PDT --- (From update of attachment 34552) I like the new class, but it should go into it's own file and not part of Panel.js. Also I think toggled would be a better name for the getter/setter than toggledOn. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:34:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:34:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811163406.A3F2D34B0145@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34420|0 |1 is obsolete| | Attachment #34566| |review? Flag| | --- Comment #3 from Maxime Simon 2009-08-11 09:34:05 PDT --- Created an attachment (id=34566) --> (https://bugs.webkit.org/attachment.cgi?id=34566) Patch to add four image-specific files to WebCore/platform/graphics/. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:37:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:37:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090811163732.8DD7434B0174@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34567| |review? Flag| | --- Comment #1 from George Wright 2009-08-11 09:37:31 PDT --- Created an attachment (id=34567) --> (https://bugs.webkit.org/attachment.cgi?id=34567) Fix zooming This patch makes the canvas element parser add CSS properties for the width and height in the same manner as the image element parser does, thus allowing the canvas to scale properly. It also removes a superfluous zoomedSize declaration which is never used. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:43:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:43:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811164325.2076434B0232@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34568| |review? Flag| | --- Comment #4 from Maxime Simon 2009-08-11 09:43:24 PDT --- Created an attachment (id=34568) --> (https://bugs.webkit.org/attachment.cgi?id=34568) Patch to add GraphicsContext to WebCore/platform/graphics/haiku. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:44:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:44:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] New: WINCE PORT: implement MediaPlayerProxy Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28178 Summary: WINCE PORT: implement MediaPlayerProxy Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Platform AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yong.li at torchmobile.com CC: staikos at kde.org, treat at kde.org, crystal.zhang at torchmobile.com separated from bug 27511 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:44:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:44:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] WINCE PORT: implement MediaPlayerProxy In-Reply-To: References: Message-ID: <20090811164455.2344B34B0272@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28178 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27511 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:44:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:44:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090811164456.CCB1A34B0286@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28178 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:45:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:45:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090811164515.98C3634B02A2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34396|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:48:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:48:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28147] Qt build skips fast/borders/border-radius-split-inline.html when it is unnecessary In-Reply-To: References: Message-ID: <20090811164852.31DD534B0314@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28147 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34477|review+, commit-queue? | Flag| | Attachment #34477|0 |1 is obsolete| | --- Comment #4 from Kenneth Rohde Christiansen 2009-08-11 09:48:51 PDT --- (From update of attachment 34477) Landed in 47034 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:49:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:49:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] WINCE PORT: implement MediaPlayerProxy In-Reply-To: References: Message-ID: <20090811164908.BC05B34B0321@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28178 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34569| |review? Flag| | --- Comment #1 from Yong Li 2009-08-11 09:49:08 PDT --- Created an attachment (id=34569) --> (https://bugs.webkit.org/attachment.cgi?id=34569) The patch with more coding style modification including George's suggestions. explicit Vector::clear() on local Vector objects are removed because they are not necessary. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:49:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:49:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28147] Qt build skips fast/borders/border-radius-split-inline.html when it is unnecessary In-Reply-To: References: Message-ID: <20090811164911.896F734B032D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28147 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |kenneth.christiansen at openbo | |ssa.org Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:49:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:49:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811164920.333B934B033B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #23 from Eric Seidel 2009-08-11 09:49:18 PDT --- I've updated https://trac.webkit.org/wiki/SuccessfulPortHowTo for Haiku (and other ports) benefit. You should feel encouraged to update it further! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:50:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:50:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811165033.C7DD534B0381@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34549|review?(darin at apple.com) |review- Flag| | --- Comment #22 from Darin Adler 2009-08-11 09:50:30 PDT --- (From update of attachment 34549) > +#include "wtf/StaticPtr.h" Includes of wtf from WebCore use angle brackets. , not "wtf/StaticPtr.h". > +static WTF::StaticPtr sharedInstancePtr; This won't work with the restrictions we need to work as a Mac OS X framework. We can't have any static destructors in our Mac OS X system frameworks as a matter of policy to make process exit fast. No objects with destructors as globals or statics. That's the reason for the DEFINE_STATIC_LOCAL macro. A major reason this patch is unacceptable is that this creates many global objects with destructors. I didn't review further because that's a major problem with the current version. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:50:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:50:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28150] WINCE PORT: Image Encoders In-Reply-To: References: Message-ID: <20090811165052.4D3AC34B039D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28150 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pkasting at google.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:51:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:51:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27255] Geolocation incorrectly calls error callback in case of exception in success callback In-Reply-To: References: Message-ID: <20090811165113.30B8934B03B5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27255 --- Comment #10 from Eric Seidel 2009-08-11 09:51:12 PDT --- (From update of attachment 33532) This needs a layout test. Otherwise it looks fine. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:51:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:51:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090811165141.9A3E734B03D7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34548|review? |review- Flag| | --- Comment #2 from Alexey Proskuryakov 2009-08-11 09:51:40 PDT --- (From update of attachment 34548) + $(WebCore)/websockets \ $(WebCore)/svg \ $(WebCore)/websockets \ It's already there. + WebCore/websockets/WebSocketRequest.cpp \ + WebCore/websockets/WebSocketRequest.h \ + WebCore/websockets/WebSocketResponse.cpp \ + WebCore/websockets/WebSocketResponse.h This looks quite wrong - WebSocket does not use a request/response model, so such class names are highly misguiding. +#if ENABLE(WEB_SOCKETS) +#include "JSWebSocket.h" +#include "WebSocket.h" In some places, generated files are included without guards, and in others, with guards. The guards are only needed if the headers are not generated in ports that do not have this feature enabled - otherwise, similar guards within headers themselves would do the job. There's never a need to protect e.g. WebSocket.h with external include guards. +bool IsValidProtocolString(const WebCore::String& protocol) This should be static, and inside the WebCore namespace. We don't normally use anonymous namespaces. + // FIXME: need dispatchEvent? Absolutely - it will dispatch to handlers installed via addEventListener(), as opposed to setting socket.onopen or similar. +bool CheckWebSocketHandshake(const WebCore::WebSocketRequest &req, const WebCore::WebSocketResponse& resp) Capitalization, argument naming, '&' positioning. This should also be static. There are many style issues in protocol implementation, I'm not pointing out most, because they are the same as in other patches. + // FIXME: handle overflow. Please do! +KURL WebSocketRequest::URLoverHTTP() const In WebKit style, this would be urlOverHTTP. I'm not sure what this is use for though, hopefully an even better name can be found. + if (url().hasFragmentIdentifier()) { + builder.append("#"); + builder.append(url().fragmentIdentifier()); + } What are fragment identifiers good for when using WebSockets? Seems that they should be forbidden, or dropped immediately when passed in. +const char* WebSocketResponse::parseHeader(const char* start, const char* end, Vector >* headers) Are WebSockets headers case sensitive? Otherwise, it may be better to use HTTPHeaderMap. I didn't closely review all the code; please fix style, possibly using check-webkit-style script. The direction looks good to me, except for request/response classes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:52:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:52:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090811165218.B6CBD34B041F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenneth.christiansen at openbo | |ssa.org --- Comment #99 from Kenneth Rohde Christiansen 2009-08-11 09:52:12 PDT --- Aint the two r+ patches already committed? If so, please clear the flag. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:52:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:52:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811165226.74E5734B0437@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org, | |yong.li at torchmobile.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:53:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:53:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090811165300.633C334B044F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34567|review? |review- Flag| | --- Comment #2 from Dave Hyatt 2009-08-11 09:52:59 PDT --- (From update of attachment 34567) I think it's better to patch the initial intrinsic size on the rendering side. I don't think you have to touch the DOM element. This patch is flawed since it doesn't zoom omitted attributes (that should default to 300 and 150 but then be zoomed). Need a test case also obviously. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:54:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:54:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811165445.6118434B04AC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 --- Comment #2 from Eric Seidel 2009-08-11 09:54:44 PDT --- (From update of attachment 34519) You mentioned in the other bug, that BufferedImage could be implemented by BitmapImage by implementing a BitmapImage(NativeImagePtr) constructor. Why would we not want to do that? I expect you could encounter later porting problems being the only port with a special BitmapImage-like-thing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:59:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:59:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811165919.2C62434B0527@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34570| |review? Flag| | --- Comment #5 from Maxime Simon 2009-08-11 09:59:18 PDT --- Created an attachment (id=34570) --> (https://bugs.webkit.org/attachment.cgi?id=34570) Patch to add ImageSource to WebCore/platform/graphics/haiku. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:02:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:02:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27255] Geolocation incorrectly calls error callback in case of exception in success callback In-Reply-To: References: Message-ID: <20090811170229.2CF0134B0581@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27255 --- Comment #11 from steveblock at google.com 2009-08-11 10:02:28 PDT --- > This needs a layout test. Adding a layout test for this change requires a mock implementation of GeolocationService such that we can guarantee that the success callback is called. I plan to add such a mock implementation (and hooks for DumpRenderTree) as part of Bug 27716, but it might take a while to get the whole framework in place. Would it be OK to submit this patch now, but leave the bug open to add the layout tests once the mock GeolocationService is in place? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:04:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:04:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811170433.5099434B05E1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 --- Comment #3 from Yong Li 2009-08-11 10:04:31 PDT --- (In reply to comment #2) > (From update of attachment 34519 [details]) > You mentioned in the other bug, that BufferedImage could be implemented by > BitmapImage by implementing a BitmapImage(NativeImagePtr) constructor. Why > would we not want to do that? I expect you could encounter later porting > problems being the only port with a special BitmapImage-like-thing. Because I think that is ugly. BitmapImage is too powerful. It is designed to receive encoded image data, decode the data with ImageSource, display the frames even they are just partially decoded, and animate with multiple frames and correct time intervals... All of these are not necessary for ImageBuffer. ImageBuffer just holds a single-frame flat decoded buffer (or platform native image). That's why ImageBuffer::image() returns Image* but not BitmapImage*, because BitmapImage is much more than necessary. So I think other ports should also do the similiar thing: using a light class like BufferedImage. It is very simple, and doesn't required too much coding. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:04:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:04:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811170458.6516334B05F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pkasting at google.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:13:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:13:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811171347.AF87C34B0736@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 --- Comment #4 from Yong Li 2009-08-11 10:13:46 PDT --- Furthermore, I think the best way is let ImageBuffer be a subclass of Image. It's just used for rendering purpose -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:13:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:13:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090811171340.29C1934B0728@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34105|0 |1 is obsolete| | Attachment #34108|0 |1 is obsolete| | --- Comment #9 from Eric Seidel 2009-08-11 10:13:38 PDT --- Created an attachment (id=34573) --> (https://bugs.webkit.org/attachment.cgi?id=34573) r47037, slowest 1000 tests (Release build on a Mac Pro) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:14:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:14:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27998] http/tests/cache/subresource-expiration.html uses 4.5 seconds of delay In-Reply-To: References: Message-ID: <20090811171432.0005D34B076D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27998 --- Comment #2 from Eric Seidel 2009-08-11 10:14:31 PDT --- Yup, still the slowest test by over a second. :) https://bugs.webkit.org/attachment.cgi?id=34573 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:20:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:20:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811172014.47F0034B0817@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #4 from Darin Adler 2009-08-11 10:20:12 PDT --- (In reply to comment #3) > I think the first step of this bug is moving all resources/*.js files which > aren't excluded by the list in make-js-test-wrappers into somewhere, fix all > layout tests so that they reference the new location, and make-js-test-wrappers > look the destination directory. Am I understanding correctly? > > Also, I'd like to know the better name for them. Maybe "js" or "scripts" ? I think "scripts" is not a good name, because the whole point is that these are "script tests", not just scripts. Maybe "jstests" is OK, or "js-tests" or "script-tests". The way I'd do it is: 1) Change make-js-test-wrappers to work for tests in directories either named "resources" or the new name. 2) Move one test with "svn mv". Run make-js-test-wrappers. Check in the new top level .html file and the test in the new location. 3) If everything went well after (2), then repeat (2) for all other tests. As you say above, all the resources/*.js files that are not in the excluded list. 4) Remove the support for directories named "resources" in make-js-test-wrappers and remove the exception list as well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:20:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:20:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] New: Shortcuts on webpages don't work if the Qt application has the same shortcut Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28179 Summary: Shortcuts on webpages don't work if the Qt application has the same shortcut Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ben at meyerhome.net Google docs has the shortcut Ctrl+s to save your document, but if the application using QWebPage has a shortcut for Ctrl+S (Save As typically) the QWebPage will not get the key press and the QShortcut will be fired instead. Manualtest: Using arora where ctrl+s is set to Save As Notes: This was the Google Docs bug reported in the Arora review on cnet http://crave.cnet.co.uk/software/0,39029471,49303237-3,00.htm -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:22:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:22:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27904] notImplemented() is too subtle In-Reply-To: References: Message-ID: <20090811172221.B650234B0855@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27904 --- Comment #3 from Alexey Proskuryakov 2009-08-11 10:22:20 PDT --- My understanding is that even ports that are quite mature still hit notImplemented() fairly often - in particular, on notification calls for Web Inspector and such. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:23:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:23:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811172341.52F7134B08AF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #5 from Eric Seidel 2009-08-11 10:23:39 PDT --- Obviously step 2 can be scripted once it's tested. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:24:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:24:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811172417.5B6CD34B08CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #6 from Eric Seidel 2009-08-11 10:24:15 PDT --- I vote for "script-tests" as the name. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:25:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:25:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811172503.9C78034B08EE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #7 from Eric Seidel 2009-08-11 10:25:02 PDT --- (Although eventually we'll want to rename make-js-test-wrappers if we use "script-tests".) Thanks again for looking at this! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:25:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:25:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090811172505.0336E34B08FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 Benjamin Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34575| |review? Flag| | --- Comment #1 from Benjamin Meyer 2009-08-11 10:25:04 PDT --- Created an attachment (id=34575) --> (https://bugs.webkit.org/attachment.cgi?id=34575) possible fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:25:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:25:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090811172519.22E2F34B0909@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 Benjamin Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hausmann at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:25:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:25:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090811172537.CCF5234B0919@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 Benjamin Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenneth.christiansen at openbo | |ssa.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:26:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:26:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811172607.7680A34B0932@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34417|0 |1 is obsolete| | Attachment #34576| |review? Flag| | --- Comment #24 from Maxime Simon 2009-08-11 10:26:05 PDT --- Created an attachment (id=34576) --> (https://bugs.webkit.org/attachment.cgi?id=34576) Patch to modify some WebCore/platform/graphics files to allow the Haiku port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:27:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:27:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811172708.79E9034B0962@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 --- Comment #5 from Eric Seidel 2009-08-11 10:27:07 PDT --- ImageBuffer and Image are used for different things. ImageBuffer is a bag of bytes, designed to store image data, and used for things which need direct access to bit maps. Image is an opaque image pointer which could be backed by an ImageBuffer, or any other sort of storage. Image might also not even be a bitmap image (in the case of SVG or PDF), so it might not have a fixed size. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:28:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:28:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811172857.A5D5234B0998@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #25 from Maxime Simon 2009-08-11 10:28:56 PDT --- (In reply to comment #24) > Created an attachment (id=34576) --> (https://bugs.webkit.org/attachment.cgi?id=34576) [details] > Patch to modify some WebCore/platform/graphics files to allow the Haiku port. I forgot some comments on this patch, - I renamed getBitmap to getBBitmap. - I didn't change the getHaikuStrokeStyle name. - I put some explanations for the empty Icon constructor. - I changed the Int* constructors so they are explicit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:29:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:29:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090811172911.9715134B09A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34577| |review? Flag| | --- Comment #6 from Mike Fenton 2009-08-11 10:29:10 PDT --- Created an attachment (id=34577) --> (https://bugs.webkit.org/attachment.cgi?id=34577) Remove working tests from qt/Skipped associated with DRT update. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:29:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:29:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811172945.DF30F34B09BD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34576|review? |review+, commit-queue+ Flag| | --- Comment #26 from Eric Seidel 2009-08-11 10:29:45 PDT --- (From update of attachment 34576) Looks OK. I thought you decided Icon() was not used? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:29:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:29:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] WINCE PORT: implement MediaPlayerProxy In-Reply-To: References: Message-ID: <20090811172951.427D534B09CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28178 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34569|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:29:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:29:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090811172957.D517F34B09E5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 --- Comment #2 from Kenneth Rohde Christiansen 2009-08-11 10:29:56 PDT --- Simon had some concerns about web apps being able to "overwrite" shortcuts. Would be good to see if the HTML5 have a say in this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:30:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:30:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811173020.59D3434B09FB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #27 from Eric Seidel 2009-08-11 10:30:19 PDT --- OK. re-read the ChangeLog. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:33:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:33:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20393] Add WML support to WebKit In-Reply-To: References: Message-ID: <20090811173315.85B1034B0A57@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20393 Nikolas Zimmermann changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28180 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:41:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:41:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] New: RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28181 Summary: RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. Product: WebKit Version: 528+ (Nightly build) Platform: S60 Emulator OS/Version: S60 3rd edition Status: NEW Keywords: Qt Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yongjun.zhang at nokia.com QWebView::RenderHints property makes QWebView::staticMetaObject depends on QPainter::staticMetaObject with breaks RVCT elftran linking. We have to remove this property now, until the right symbol is exported. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:49:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:49:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811174916.8F98C34B0C7C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #23 from Zoltan Herczeg 2009-08-11 10:49:13 PDT --- > This won't work with the restrictions we need to work as a Mac OS X framework. > We can't have any static destructors in our Mac OS X system frameworks as a > matter of policy to make process exit fast. No objects with destructors as > globals or statics. That's the reason for the DEFINE_STATIC_LOCAL macro. I have realized why DEFINE_STATIC_LOCAL (probably DEFINE_GLOBAL is even better example, which use placement new to hide the destructor) defined, so the destructor of WTF::StaticPtr is empty of course, and never intended to do anything... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:50:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:50:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090811175021.38EA134B0CB8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 --- Comment #3 from Benjamin Meyer 2009-08-11 10:50:20 PDT --- These two arora bug reports look like they might also be for this bug: http://code.google.com/p/arora/issues/detail?id=515 http://code.google.com/p/arora/issues/detail?id=230 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:53:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:53:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811175347.773CA34B0D33@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #8 from Darin Adler 2009-08-11 10:53:44 PDT --- (In reply to comment #7) > (Although eventually we'll want to rename make-js-test-wrappers if we use > "script-tests".) Thanks again for looking at this! I think we could rename make-js-test-wrappers to make-script-tests-wrappers right away as step (0). I also think that eventually we could teach run-webkit-tests to run these tests without checking in wrappers. But that would have a downside since it would be harder to open one of these tests directly from a browser. Further, I think that in the future we might want to run some of these tests as pure JavaScript tests, using the "jsc" command line tool instead of "DumpRenderTree" -- some can't work that way but others can't, and I wonder how we could distinguish those. Finally, I'd love to convert the Mozilla tests for JavaScript in the JavaScriptCore tree into these style tests so they all run with run-webkit-tests. Not all relevant to this task, but since you asked I thought I'd talk a bit about more of the road map in my mind. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:54:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:54:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811175405.ECCBD34B0D5F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #9 from Darin Adler 2009-08-11 10:54:04 PDT --- (In reply to comment #8) > (In reply to comment #7) > > (Although eventually we'll want to rename make-js-test-wrappers if we use > > "script-tests".) Thanks again for looking at this! > > I think we could rename make-js-test-wrappers to make-script-tests-wrappers > right away as step (0). make-script-test-wrappers -- an "s" crept in there -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:13:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:13:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811181314.E3C7534B0F65@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 --- Comment #27 from Darin Adler 2009-08-11 11:13:08 PDT --- There are at least three distinct related questions in my opinion: a) How we detect that there's a change that requires some mouse position processing. There are many different types of changes that could trigger the need for this, such as an element moving that has a CSS cursor associated with it so that it's no longer under the mouse, any kind of scrolling, or even a change to the CSS cursor property without any geometry change at all. We need a good architecture so that the new processing gets done. I don't think it necessarily has to be done right away. We could use a zero duration or small duration timer to coalesce these so that multiple changes don't require multiple attempts to process things, and so that the processing can happen after layout has occurred. In fact, when it comes to status bar messages, even changes in the keyboard state are relevant. For example, if you press the option key on the Mac, we need to recompute the status message. I believe this is currently done by simulating a "mousemove" when there is change in the state of modifier keys, done in the Mac-specific WebKit code. b) What should be seen at the DOM level. For example, if an element moved and that changes the cursor, then presumably ideally we don't want DOM event handlers to see a DOM "mousemove" event since the mouse didn't move. Or maybe we do, but if so it's an intentional choice, not just a side effect of how our code works internally. We might be willing to live with an excess "mousemove" event, but it's probably not working as designed if we send one. On the other hand, if an element moves so it's no longer under the mouse, we probably *do* want to send that object a "mouseout" event even if we would not have sent a "mousemove" event. What do we want seen at the DOM level when the option key goes down? Probably not a "mouse move" event, so that's a minor bug on the Mac that would be nice to fix. Unless we decide it's a feature rather than a bug. c) Once we detect a change, how we trigger the additional processing. It may be expedient to use what looks like a "mousemove" event to minimize refactoring of the existing code. But I think that sort of lack of clarity and logic in the code is unnecessary. We should be willing to make some changes to make this logical unless it's so difficult that it makes the problem a lot harder to fix. (In reply to comment #25) > Safari/Mac appears to generate extra mouse move events for lots of things > (including, e.g., mouse downs/ups), thereby avoiding a host of bugs. It would be very useful to determine where those events come from. Is it the Mac OS X AppKit that is providing these events? Or is it the Mac-specific WebKit code that creates them? If the former, then we should just live with them as is. If it's the latter, maybe we can solve this in a platform independent way and get rid of the unneeded code. > When > scrolling using the keyboard, in Safari/Mac, the cursor (and tooltip) > disappear, thereby eliminating a bunch of problems; actually, now that > Chromium/Mac also makes the cursor (and consequently the tooltip, apparently) > disappear, those same problems go away. This is an interesting point. It hides some problems (cursor and tooltip) but doesn't affect others at all (status bar, DOM events as seen on the web page, hover effects in the page). Why don't other platforms have this behavior? Is this really a unique feature of Mac OS X, or is this something we'd want on Windows and Unix desktop systems too? > Now, unfortunately, the mouse moving code > (EventHandler::mouseMoved()/handleMouseMoveEvent()) are very tightly coupled > with PlatformMouseEvent. To handle "virtual mouse moves", we need to at least > do either (1) send fake mouse move events (ugly, but expedient) or (2) decouple > the aforementioned code so that it can handle such "virtual mouse moves" > without a PlatformMouseEvent (make an "EventHandler::mouseMovedVirtually()" > method or some such). In some sense, the difference between (1) and (2) is > cosmetic. You could decouple so far as to push a lot of the logic down into the > layout, but that would be drastic and you'd have to make the layout aware of > the mouse position. You're talking about my issue (c) here. But I think that my issue (b) also comes up. Do we want actual mouse moves to show up in the DOM or not? I don't think this refactoring and clean-up is particularly difficult, and I'd love to see it done for code clarity either before or after this bug is fixed. I agree that it doesn't have to be done to fix the bug. > My first instinct to fix the scrolling-related issues is to hook up (1) or (2) > in FrameView::valueChanged() (probably inside the "if (offset != > scrollOffset())"). Similarly, you could do the same in > FrameView::performPostLayoutTasks() -- I think this would probably handle any > possible resize-related issues. (There are also possible window-movement issues > -- i.e., the window moves without the mouse moving -- though I don't know > offhand where that would get hooked up.) This seems to cover only a tiny fraction of problem (a). It's true that a FrameView scrolling can move an element. But also, changes to the element's geometry can move it. And overflow area scrolling can also move it. I'd like to understand our general strategy to detecting when elements move out from under the mouse. It may be that once we cover the general case we don't need anything separate for FrameView. > Hooking up a fake mouse event is expedient, if a little repugnant; decoupling > the code is a bit fragile and goes pretty deep. (E.g., on resize, the mouse may > end up over a scrollbar, so you can't just ignore the scrollbars.) My main complaint about your initial patch was that making a fake mouse event in response to a real wheel event is wrong. The major way it's wrong is (a). It's wrong to say that a wheel event is causing this. It's the *response* to the wheel event that creates the need to update things like cursors and makes you want to send a simulated mouse move event. You're focusing on issue (c), which is whether a fake mouse event is the best way to trigger the new processing. We can be flexible on this, but ideally the code is clear and not full of "fake" anything. I really don't think it's all that difficult to clean this up and make it right. The degree to which updating cursors is tied to a PlatformEvent for a mouse move event is actually pretty small in my opinion. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:15:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:15:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811181527.35C4434B0FDF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #24 from Darin Adler 2009-08-11 11:15:23 PDT --- (In reply to comment #23) > I have realized why DEFINE_STATIC_LOCAL (probably DEFINE_GLOBAL is even better > example, which use placement new to hide the destructor) defined, so the > destructor of WTF::StaticPtr is empty of course, and never intended to do > anything... Please check and see what the compiler generates for this before giving a patch that deploys it in tons of places. I'm pretty sure that an empty virtual function will indeed generate a static destructor, although a pointless empty one. There's a good chance it will even change the virtual pointer on the object. Anyway, if the technique works that's fine but it's pointless to review a patch to deploy the technique before you've tested it! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:24:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:24:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27962] Exception in land-patches In-Reply-To: References: Message-ID: <20090811182412.3CAFD34B10F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27962 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34578| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-11 11:24:10 PDT --- Created an attachment (id=34578) --> (https://bugs.webkit.org/attachment.cgi?id=34578) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:26:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:26:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27962] Exception in land-patches In-Reply-To: References: Message-ID: <20090811182635.4959034B1136@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27962 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34578|review? |review+ Flag| | --- Comment #2 from Darin Adler 2009-08-11 11:26:34 PDT --- (From update of attachment 34578) rs=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:27:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:27:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27962] Exception in land-patches In-Reply-To: References: Message-ID: <20090811182755.1E35534B1160@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27962 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-11 11:27:53 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... C WebKitTools/Scripts/run-webkit-unittests => WebKitTools/Scripts/modules/logging_unittest.py M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/logging.py M WebKitTools/Scripts/run-webkit-unittests Committed r47040 M WebKitTools/ChangeLog A WebKitTools/Scripts/modules/logging_unittest.py M WebKitTools/Scripts/modules/logging.py M WebKitTools/Scripts/run-webkit-unittests r47040 = 9ed18775ec0ae3c5667b23995d10b1874c1c65fe (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47040 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:30:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:30:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. In-Reply-To: References: Message-ID: <20090811183017.1A8B934B11C9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28181 Yongjun Zhang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34579| |review? Flag| | --- Comment #1 from Yongjun Zhang 2009-08-11 11:30:16 PDT --- Created an attachment (id=34579) --> (https://bugs.webkit.org/attachment.cgi?id=34579) don't use RenderHint property when building for symbian. It is a temporary fix, should be reverted when the right symbol is exported from QT lib. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:42:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:42:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28182] New: The setter for CSSStyleRule.selectorText doesn't actually do anything. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28182 Summary: The setter for CSSStyleRule.selectorText doesn't actually do anything. Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: andy at andymatuschak.org One might expect that calling someCSSStyleRule.selectorText = ".someOtherClass" might actually cause someCSSStyleRule's selector to change. That would be a foolish assumption indeed! See the attached sample .html; clicking the "foo" link should turn it black. Also, the rule's cssText is logged to the console after being changed from "foo" to "bar"; note that its selector is still ".foo". Firefox doesn't seem to implement this setter either, but the property is marked as readwrite in the spec: http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSStyleRule -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:44:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:44:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28182] The setter for CSSStyleRule.selectorText doesn't actually do anything. In-Reply-To: References: Message-ID: <20090811184442.1656034B136A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28182 --- Comment #1 from Andy Matuschak 2009-08-11 11:44:41 PDT --- Created an attachment (id=34581) --> (https://bugs.webkit.org/attachment.cgi?id=34581) Demonstration of selectorText's setter's fail. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:56:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:56:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27587] Searching for "=?UTF-8?Q?=E3=81=97?=" also finds "=?UTF-8?Q?=E3=81=98?=" In-Reply-To: References: Message-ID: <20090811185647.682D634B151A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27587 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #4 from Darin Adler 2009-08-11 11:56:46 PDT --- The matching is based on ICU. The folding is due to code in ICU. In the released Safari 4 the behavior is the same no matter what the user?s locale is, but in the TOT WebKit it respects the user?s locale choice so will work differently for different users. If we don?t like the behavior we can ask ICU to change its behavior, which in some cases would mean changes to the Unicode specification, or we can add workarounds to WebKit?s TextIterator class. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:57:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:57:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27202] Inspector: Cookies in Storage Panel In-Reply-To: References: Message-ID: <20090811185700.3F2FC34B1530@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34377|commit-queue+ |commit-queue- Flag| | --- Comment #13 from Eric Seidel 2009-08-11 11:56:58 PDT --- (From update of attachment 34377) Rejecting patch from commit queue: 34377 Failure, rejecting patch from commit queue. This patch will require manual landing. Patch https://bugs.webkit.org/attachment.cgi?id=34377 from bug 27202 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:58:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:58:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27202] Inspector: Cookies in Storage Panel In-Reply-To: References: Message-ID: <20090811185807.C482C34B155C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #14 from Eric Seidel 2009-08-11 11:58:06 PDT --- Here is the log. Sorry the commit-queue/bugzilla-tool is not smart enough to know how to post the log yet: patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/inspector/front-end/Cookie.js patching file WebCore/inspector/front-end/CookieItemsView.js patching file WebCore/inspector/front-end/DatabasesPanel.js patch: **** Only garbage was found in the patch input. patch -p0 "WebCore/inspector/front-end/Images/cookie.png" returned 2. Pass --force to ignore patch failures. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:00:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:00:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27065] Port QtWebKit to Symbian In-Reply-To: References: Message-ID: <20090811190045.2A45B34B15C0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27065 Yongjun Zhang changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28181 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:00:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:00:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. In-Reply-To: References: Message-ID: <20090811190046.36E2734B15CE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28181 Yongjun Zhang changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27065 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:02:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:02:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811190245.EEFF434B1616@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #25 from Yong Li 2009-08-11 12:02:42 PDT --- (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=34058) --> (https://bugs.webkit.org/attachment.cgi?id=34058) [details] [details] > > First draft patch > > This patch is intended to be a draft. I would like to hear your opinion about > this solution: > - two new files are added to wtf directory: StaticPtr.h and StaticPtr.cpp > - enabling FREE_STATIC_PTRS allows to free the pointers in a reversed > creation order > - Although c++ supports automatic destructors, I think it would not be wise > to free the pointers in random order. Why not just let ~StaticPtr() to free memory? Static objects should be destructed in the reverse order of construction, as when a static object is constructed, atexit will be pushed to onexit queue. Also, you can always destruct all static objects by calling _cexit() explicitly. The only benefit of using a chain I can see is that it destructs all object first, and then frees all the memory, so that when a destructor accesses to another destructed static object, it won't result segment fault... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:03:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:03:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811190351.DFFBD34B167A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #26 from Yong Li 2009-08-11 12:03:49 PDT --- (In reply to comment #25) > (In reply to comment #2) > > (In reply to comment #1) > > > Created an attachment (id=34058) --> (https://bugs.webkit.org/attachment.cgi?id=34058) [details] [details] [details] > > > First draft patch > > > > This patch is intended to be a draft. I would like to hear your opinion about > > this solution: > > - two new files are added to wtf directory: StaticPtr.h and StaticPtr.cpp > > - enabling FREE_STATIC_PTRS allows to free the pointers in a reversed > > creation order > > - Although c++ supports automatic destructors, I think it would not be wise > > to free the pointers in random order. > > Why not just let ~StaticPtr() to free memory? Static objects should be > destructed in the reverse order of construction, as when a static object is > constructed, atexit will be pushed to onexit queue. Also, you can always > destruct all static objects by calling _cexit() explicitly. The only benefit of > using a chain I can see is that it destructs all object first, and then frees > all the memory, so that when a destructor accesses to another destructed static > object, it won't result segment fault... correction: atexit pushes the destructor to the onexit stack -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:07:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:07:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090811190753.1AFE434B1736@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34365|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:29:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:29:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811192913.BFFF134B1AA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 --- Comment #28 from Viet-Trung Luu 2009-08-11 12:29:09 PDT --- [Just for clarity, I'm not the originator of the original patch....] (In reply to comment #27) > a) How we detect that there's a change that requires some mouse position > processing. I guess there are two approaches to this (and intermediates between the two extremes): (i) Code which does anything which causes changes which require such processing initiate the processing. Advantages: efficient (no extra checking needed). Disadvantages: need to carefully wire up lots of code. (ii) Check whether such processing is needed very often (possibly prompted by code which does anything which remotely *may* cause such a need), and do the processing if necessary. Advantages: no need to wire up other code so carefully. Disadvantages: nontrivial processing and possibly inefficient. In my quick-and-dirty patch, I've taken route (i): EventHandler::mouseMovedVirtually() is a stub which tells the EventHandler that something happened which caused the mouse to move "virtually". Currently, this immediately fires off a fake mouse event (ugh), but upon decoupling the code it could do something better; it could also be set to start a timer (to coalesce), etc. > b) What should be seen at the DOM level. [...] Right. I (as opposed to the original patch's author) wired up a fake mouse move purely out of expediency -- it's clearly not right. It forces a policy decision (send mouse move events on "virtual" mouse moves), but we shouldn't let a hack make policy. That said, sending a DOM mouse move may be desired, after all. > What do we want seen at the DOM level when the option key goes down? Probably > not a "mouse move" event, so that's a minor bug on the Mac that would be nice > to fix. Unless we decide it's a feature rather than a bug. Seems unlikely that that's a feature! I wouldn't want the option key to be hooked up to virtual mouse moves either, so that processing should probably be separated. > It may be expedient to use what looks like a "mousemove" event to minimize > refactoring of the existing code. But I think that sort of lack of clarity and > logic in the code is unnecessary. We should be willing to make some changes to > make this logical unless it's so difficult that it makes the problem a lot > harder to fix. It's a little painful since we have ugly scrollbar, etc. code which would also need to be rewired, the details which are a bit painful to get right. Currently, a lot of code is wired up to take a PlatformMouseEvent, probably unnecessarily. > It would be very useful to determine where those events come from. Is it the > Mac OS X AppKit that is providing these events? Or is it the Mac-specific > WebKit code that creates them? If the former, then we should just live with > them as is. If it's the latter, maybe we can solve this in a platform > independent way and get rid of the unneeded code. I wouldn't want to bet my life on it, but I would guess the former, or actually code in Safari itself. I don't think I've seen code that does this in WebKit (and Chromium/Mac doesn't get extra events). > > When > > scrolling using the keyboard, in Safari/Mac, the cursor (and tooltip) > > disappear, thereby eliminating a bunch of problems; [...] > > This is an interesting point. It hides some problems (cursor and tooltip) but > doesn't affect others at all (status bar, DOM events as seen on the web page, > hover effects in the page). True, and of course it doesn't help with scrolling with trackpad/mousewheel/other either. > Why don't other platforms have this behavior? Is this really a unique feature > of Mac OS X, or is this something we'd want on Windows and Unix desktop systems > too? It's standard on Mac, doesn't happen on Windows (in any browser that I know of, at least). I don't know about Unix desktops.... > I don't think this refactoring and clean-up is particularly difficult, and I'd > love to see it done for code clarity either before or after this bug is fixed. > I agree that it doesn't have to be done to fix the bug. Agreed, which is why my (even quick-and-dirty) patch is written as it is. For the mouse-related stuff (I don't know about the option key, etc.), I would separate out the code in mouseMoved() and handleMouseMoveEvent(), and have them (and mouseMovedVirtually()) call down to the common code appropriately. > This seems to cover only a tiny fraction of problem (a). It's true that a > FrameView scrolling can move an element. But also, changes to the element's > geometry can move it. And overflow area scrolling can also move it. I'd like to > understand our general strategy to detecting when elements move out from under > the mouse. It may be that once we cover the general case we don't need anything > separate for FrameView. I suppose that, adopting my tactic (i), we'd have to wire up all these other things explicitly as well. Our "general strategy for detecting when elements move out from under the mouse" rests right now entirely in EventHandler (not so great, but everything else seems mostly unaware of the mouse!), and in handleMouseMoveEvent() in particular (at least that should be changed). A further possible issue is that we may need to know whenever the mouse moves relative to anything (leaving an element); this would be the case if we want to send DOM mouse moves when scrolling, for example. > My main complaint about your initial patch was that making a fake mouse event > in response to a real wheel event is wrong. The major way it's wrong is (a). > It's wrong to say that a wheel event is causing this. It's the *response* to > the wheel event that creates the need to update things like cursors and makes > you want to send a simulated mouse move event. [Not my original patch, which is why I wired up to the scrolling instead....] So what do you think of having a separate mouseMovedVirtually() method in EventHandler? As I said, it and mouseMoved()/etc. should be refactored, but the semantics of mouseMovedVirtually() are quite clear -- whenever the mouse moves relative to any elements (without the mouse actually moving -- i.e., the elements move!), it should be called. Currently, I call it from the scrolling code, but it should be called from elsewhere as well; it may need to be made more sophisticated to work correctly in those cases, but it's a start. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:29:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:29:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20393] Add WML support to WebKit In-Reply-To: References: Message-ID: <20090811192944.DEECF34B1AD0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20393 Bug 20393 depends on bug 28180, which changed state. Bug 28180 Summary: [WML] WMLPageState is not allowed to store the active card, it needs to be done per document https://bugs.webkit.org/show_bug.cgi?id=28180 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:35:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:35:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090811193542.BD0DD34B1BB6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lyon.chen at torchmobile.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:37:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:37:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28115] Inspector: Console Drawer is Toggling instead of Staying Open In-Reply-To: References: Message-ID: <20090811193745.9A68834B1C26@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28115 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34403|review+ | Flag| | --- Comment #2 from Eric Seidel 2009-08-11 12:37:45 PDT --- (From update of attachment 34403) Clearing review flag on attachment: 34403 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/Drawer.js M WebCore/inspector/front-end/inspector.js Committed r47049 M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js M WebCore/inspector/front-end/Drawer.js r47049 = 5847ea6bf7fc1d9f761b3363a847a0978fc69389 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47049 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:37:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:37:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28115] Inspector: Console Drawer is Toggling instead of Staying Open In-Reply-To: References: Message-ID: <20090811193748.E7EA934B1C36@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28115 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-11 12:37:48 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:49:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:49:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28184] New: JavaScript: keypress not fired with DELETE key Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28184 Summary: JavaScript: keypress not fired with DELETE key Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gaddis at apple.com Created an attachment (id=34583) --> (https://bugs.webkit.org/attachment.cgi?id=34583) test case html file The scenario: Event listeners are attached to the document for keydown, keypress, and keyup events. In the attached file, input_document.html, watch the console for evidence of the events fired from inside an text input. When "1" is pressed: onkeydown charCode = 0 onkeypress charCode = 49 onkeyup charCode = 0 When DELETE is pressed: onkeydown charCode = 0 onkeyup charCode = 0 (note the missing onkeypress) Other observations: This behavior does not change when the listeners are attached to the text input. Safari 3 reports all three events: onkeydown, onkeypress, onkeyup when the DELETE key is pressed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:51:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:51:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28121] [Haiku] Modifications on JavaScriptCore. In-Reply-To: References: Message-ID: <20090811195122.340CE34B1DF7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28121 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34424|review+ | Flag| | --- Comment #8 from Eric Seidel 2009-08-11 12:51:20 PDT --- (From update of attachment 34424) Clearing review flag on attachment: 34424 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/runtime/Collector.cpp M JavaScriptCore/wtf/Platform.h M JavaScriptCore/wtf/haiku/MainThreadHaiku.cpp Committed r47050 M JavaScriptCore/runtime/Collector.cpp M JavaScriptCore/wtf/haiku/MainThreadHaiku.cpp M JavaScriptCore/wtf/Platform.h M JavaScriptCore/ChangeLog r47050 = b11f14b641a8c5357b1ee13ba14846834ae2311e (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47050 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:51:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:51:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28121] [Haiku] Modifications on JavaScriptCore. In-Reply-To: References: Message-ID: <20090811195125.64ABB34B1E07@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28121 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #9 from Eric Seidel 2009-08-11 12:51:24 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:52:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:52:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811195212.5EB6F34B1E3F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 --- Comment #29 from Darin Adler 2009-08-11 12:52:08 PDT --- Sorry for confusing you with the earlier person working on this bug! (In reply to comment #28) > So what do you think of having a separate mouseMovedVirtually() method in > EventHandler? I would name it simulateMouseMove() or simulateMouseMotion() since I don't really think "virtually" is quite as good a way of saying what the function does. > but the > semantics of mouseMovedVirtually() are quite clear -- whenever the mouse moves > relative to any elements (without the mouse actually moving -- i.e., the > elements move!), it should be called. If that?s true, then perhaps we should name it for when it should be called rather than for what it does. Maybe contentMovedUnderMouse() or something along those lines? > Currently, I call it from the scrolling > code, but it should be called from elsewhere as well; it may need to be made > more sophisticated to work correctly in those cases, but it's a start. Seems like a reasonable first step. Lets not set our sights too low though. Lets try to fix this all the way! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:58:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:58:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811195808.EEFF434B1F90@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34585| |review? Flag| | --- Comment #22 from Xiaomei Ji 2009-08-11 12:58:04 PDT --- Created an attachment (id=34585) --> (https://bugs.webkit.org/attachment.cgi?id=34585) patch w/ manual test updated per Mitz's suggestion: 1. revert changes in GraphicsContext 2. remove ellipseseNeeded in PopupItem. When restrcitWidthOfListBox, truncate string first and drawBidiText on truncated string in PopupMenuChromium. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:58:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:58:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811195843.B975234B1FB4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34536|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 13:16:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 13:16:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21945] (https://bugs.webkit.org/attachment.cgi?id=34590) 7) Keygen (Security) refactored by Yong -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:12:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:12:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28169] REGRESSION: Hang/crash in BytecodeGenerator::constRegisterFor loading simple page In-Reply-To: References: Message-ID: <20090811211250.DC63834B294D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28169 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34591| |review? Flag| | --- Comment #2 from Oliver Hunt 2009-08-11 14:12:49 PDT --- Created an attachment (id=34591) --> (https://bugs.webkit.org/attachment.cgi?id=34591) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:17:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:17:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28186] New: Web Inspector scope bar not quite right Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28186 Summary: Web Inspector scope bar not quite right Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: sam at webkit.org CC: timothy at hatcher.name The Web Inspectors new scope bar for the resources pane seems to be too dark. It could use some tweaking. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:19:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:19:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090811211912.90E1334B2AA3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 --- Comment #46 from George Staikos 2009-08-11 14:19:09 PDT --- (In reply to comment #45) > Created an attachment (id=34590) --> (https://bugs.webkit.org/attachment.cgi?id=34590) [details] > 7) Keygen (Security) > > refactored by Yong Are you sure? It looks the same to me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:20:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:20:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] New: "Double-click to add" new style button does not always show up Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28187 Summary: "Double-click to add" new style button does not always show up Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://webkit.org OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: sam at webkit.org CC: timothy at hatcher.name On http://webkit.org, the "Double-click to add" button does not show up for the body element in the elements pane. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:20:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:20:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28186] Web Inspector scope bar not quite right In-Reply-To: References: Message-ID: <20090811212040.5C9FC34B2AE7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28186 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrowe at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:20:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:20:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090811212044.183F334B2AF4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34592| |review? Flag| | --- Comment #1 from Joseph Pecoraro 2009-08-11 14:20:43 PDT --- Created an attachment (id=34592) --> (https://bugs.webkit.org/attachment.cgi?id=34592) Working on OS X Leopard This is pretty much my first experience with C++, so I'd appreciate it if you be explicit about any of the C++ mistakes I made, or build fixes that will be needed for other platforms. I changed the CookieJar.h header so I expect that I will need to fix a number of other files. Thanks in advance. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:23:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:23:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090811212330.B26E134B2B66@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck02 at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:24:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:24:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090811212414.3669C34B2B84@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck02 at gmail.com --- Comment #1 from Joseph Pecoraro 2009-08-11 14:24:13 PDT --- Seems to be due to "could not parse color" warnings. I'll work on this right now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:25:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:25:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090811212509.2BBF634B2BB2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 --- Comment #2 from Timothy Hatcher 2009-08-11 14:25:08 PDT --- Patch looks pretty good. I think rawCookies will be better named as cookies. And rename the existing cookies to cokkiesString or somthing more specific. I'll review more later and provide guidance o nwhat files to edit for other platforms. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:26:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:26:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28169] REGRESSION: Hang/crash in BytecodeGenerator::constRegisterFor loading simple page In-Reply-To: References: Message-ID: <20090811212602.E591F34B2BE0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28169 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34591|review? |review+ Flag| | --- Comment #3 from Geoffrey Garen 2009-08-11 14:26:02 PDT --- (From update of attachment 34591) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:30:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:30:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28169] REGRESSION: Hang/crash in BytecodeGenerator::constRegisterFor loading simple page In-Reply-To: References: Message-ID: <20090811213031.EF53634B2C9D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28169 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Oliver Hunt 2009-08-11 14:30:31 PDT --- Committed r47062 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:30:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:30:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] New: WINCE PORT: Path, PlatformPath Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28188 Summary: WINCE PORT: Path, PlatformPath Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Platform AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yong.li at torchmobile.com CC: staikos at kde.org, treat at kde.org taken out from 27511 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:30:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:30:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090811213058.0C82B34B2CB7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27511 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:30:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:30:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090811213059.9985F34B2CCB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28188 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:31:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:31:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] New: run-webkit-tests --quiet should not output build-dumprendertree output Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28189 Summary: run-webkit-tests --quiet should not output build-dumprendertree output Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org run-webkit-tests --quiet should not output build-dumprendertree output This required a surprising amount of perl ninjary. I will be so glad when that wicked old language is dead. :( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:31:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:31:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090811213117.427EA34B2D0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34398|review? | Flag| | Attachment #34398|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:33:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:33:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811213306.D34CB34B2D6E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34594| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-11 14:33:05 PDT --- Created an attachment (id=34594) --> (https://bugs.webkit.org/attachment.cgi?id=34594) Make run-webkit-tests --quiet actually quiet --- 2 files changed, 22 insertions(+), 3 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:38:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:38:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811213854.316D634B2E31@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34594|review? | Flag| | Attachment #34594|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:38:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:38:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811213857.3BD8334B2E3E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34596| |review? Flag| | --- Comment #2 from Eric Seidel 2009-08-11 14:38:55 PDT --- Created an attachment (id=34596) --> (https://bugs.webkit.org/attachment.cgi?id=34596) Updated patch --- 2 files changed, 21 insertions(+), 2 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:39:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:39:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090811213956.BD0A034B2E5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 --- Comment #2 from Joseph Pecoraro 2009-08-11 14:39:56 PDT --- Interesting. The incoming CSS of: url(/images/green.png) Has the string "green" inside it and "green" swatch is (incorrectly) made for it: http://tr.im/wdZz?grabup WebInspector.Color is invoked if there was a swatch on the massaged CSS value, and it throws an error because it cannot parse the following as a valid color: url(http://webkit.org/images/green-background.png) Since this affects the WebKit Nightly right now I will throw up a "quick fix" patch that catches the WebInspector.Color error and therefore takes us back to the expected old behavior with the swatch still incorrectly showing. I'll then work on cleaning this up in general. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:46:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:46:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811214617.A974B34B2F1D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #23 from Xiaomei Ji 2009-08-11 14:46:14 PDT --- Hi Mitz: One question on the ellipses appended in StringTruncator. StringTruncator always append horizontal ellipses (U+2026) along with the truncated string. Will the Unicode character cause display problem? Thanks, xiaomei -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:49:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:49:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090811214901.35BBE34B2F7A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34597| |review? Flag| | --- Comment #3 from Joseph Pecoraro 2009-08-11 14:49:00 PDT --- Created an attachment (id=34597) --> (https://bugs.webkit.org/attachment.cgi?id=34597) Quick Fix This is the quick fix for the Nightly Build. --- I think a more optimal solution would be to avoid throwing an error at all. Instead something like WebInspector.Color.parseColor() factory method which would return either 'null' or a WebInspector.Color object. That way we won't have to worry about any throw/catch. Along with the other improvements mentioned previously, including: - swatch shows up accidentally - all swatches should be clickable to toggle colors - swatches should be clickable in shorthand properties -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:50:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:50:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811215039.46E4F34B2FCE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #24 from mitz at webkit.org 2009-08-11 14:50:37 PDT --- (In reply to comment #23) > StringTruncator always append horizontal ellipses (U+2026) along with the > truncated string. Will the Unicode character cause display problem? drawBidiText() will use a fallback font if the specific font does not have a horizontal ellipses glyph. Text truncation in the render tree is also implemented using horizontal ellipses. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:53:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:53:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090811215307.D950634B3004@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34598| |review? Flag| | --- Comment #1 from Yong Li 2009-08-11 14:53:07 PDT --- Created an attachment (id=34598) --> (https://bugs.webkit.org/attachment.cgi?id=34598) the patch (modified a little) modified a little bit. added some comments to contains() -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:55:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:55:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28190] New: Remove support for a window resizer within the WebView Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28190 Summary: Remove support for a window resizer within the WebView Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: aroben at apple.com CC: hyatt at apple.com, sfalken at apple.com Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34599| |review? Flag| | Created an attachment (id=34599) --> (https://bugs.webkit.org/attachment.cgi?id=34599) Patch v1 Starting with Safari 4, there is never a window resizer inside the WebView, so we no longer need to support that functionality. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:56:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:56:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28190] Remove support for a window resizer within the WebView In-Reply-To: References: Message-ID: <20090811215611.83BEC34B304B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28190 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Mac OS X 10.5 |Windows XP -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:00:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:00:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28191] New: Mixing absolute and relative table widths causes mis-sized TDs Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28191 Summary: Mixing absolute and relative table widths causes mis-sized TDs Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://ratemyserver.net/ OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tables AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gwilson at google.com Created an attachment (id=34600) --> (https://bugs.webkit.org/attachment.cgi?id=34600) Reduction When a table contains a mix of absolute widths and relative widths in one row, and a colspan with no widths specified, the TDs mis-size themselves. Specifically, there seems to be some "extra padding" around those elements that have absolute sizes. FF3: OK IE: OK Chrome2/3: Not OK Safari 4: Not OK -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:01:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:01:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28190] Remove support for a window resizer within the WebView In-Reply-To: References: Message-ID: <20090811220107.95FAD34B30E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28190 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34599|review? |review+ Flag| | --- Comment #1 from Dave Hyatt 2009-08-11 15:01:07 PDT --- (From update of attachment 34599) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:01:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:01:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811220159.6285D34B310E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34596|review? | Flag| | Attachment #34596|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:02:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:02:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811220202.7F09334B311D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34601| |review? Flag| | --- Comment #3 from Eric Seidel 2009-08-11 15:02:01 PDT --- Created an attachment (id=34601) --> (https://bugs.webkit.org/attachment.cgi?id=34601) Update comments --- 2 files changed, 21 insertions(+), 2 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:02:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:02:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811220252.47DC634B3143@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34601|review? |review+ Flag| | --- Comment #4 from Adam Barth 2009-08-11 15:02:51 PDT --- (From update of attachment 34601) Seems reasonable, assuming the Perl magic does what it looks like it should do. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:05:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:05:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27124] [commit+] let me *edit* css styles in the web inspector. In-Reply-To: References: Message-ID: <20090811220520.24FB834B3185@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27124 ryankshaw+webkitbugzilla at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #12 from ryankshaw+webkitbugzilla at gmail.com 2009-08-11 15:05:16 PDT --- I just got the latest webkit nightly and tried it out. if you double click to create a new style rule, add something like color:red; , It makes that thing red. now, reload the page, inspect the same thing, double click to add a new style rule that is the same as before with color:red; and it does not change anything on the page, even though in the web inspector it thinks that it is because it crosses out the rule coming from the stylesheet. this shows what I am talking about: http://screencast.com/t/MsmXR6Icm -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:05:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:05:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811220538.3EA0234B319D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Eric Seidel 2009-08-11 15:05:37 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests Committed r47066 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests r47066 = 47f317d3a54a8c0eba39936bac967272116a6580 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47066 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:12:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:12:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090811221227.E68EB34B322B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 --- Comment #47 from Yong Li 2009-08-11 15:12:26 PDT --- (In reply to comment #46) > (In reply to comment #45) > > Created an attachment (id=34590) --> (https://bugs.webkit.org/attachment.cgi?id=34590) [details] [details] > > 7) Keygen (Security) > > > > refactored by Yong > > Are you sure? It looks the same to me. hm... a mistake -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:15:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:15:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] New: run-webkit-tests needs a --fail-fast option Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28192 Summary: run-webkit-tests needs a --fail-fast option Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org I'm not sure --fail-fast is the right name. But I want a mode where run-webkit-tests exits after the first failure or new result. This is useful for bugzilla-tool (or possibly some bots) when validating that everything still passes before committing. In some cases we don't care to know all of the failures, only that something failed (and want to know as fast as possible). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:17:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:17:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090811221731.1EBFA34B32F6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34590|review? | Flag| | Attachment #34590|0 |1 is obsolete| | Attachment #34602| |review? Flag| | --- Comment #48 from Yong Li 2009-08-11 15:17:29 PDT --- Created an attachment (id=34602) --> (https://bugs.webkit.org/attachment.cgi?id=34602) 7) KeyGen (modified) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:18:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:18:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090811221807.89A6934B331C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34597|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:18:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:18:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090811221808.E8A1A34B332C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34402|commit-queue+ |commit-queue- Flag| | --- Comment #17 from Eric Seidel 2009-08-11 15:18:07 PDT --- (From update of attachment 34402) This is missing new results and cannot be landed by the commit-queue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:22:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:22:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27124] [commit+] let me *edit* css styles in the web inspector. In-Reply-To: References: Message-ID: <20090811222206.9EF4434B33AF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27124 --- Comment #13 from Timothy Hatcher 2009-08-11 15:22:03 PDT --- I think what is happeneing here is that we have a reference to the style element we created for the previous page still, so we think we don't need to make a new one and just append to the old one in the previous page. This reference should be cleared in the ElementsPanel reset method. Can you file a new bug about this? (And close this bug.) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:23:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:23:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --fail-fast option In-Reply-To: References: Message-ID: <20090811222314.9957334B33DF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 --- Comment #1 from Mark Rowe (bdash) 2009-08-11 15:23:13 PDT --- The build bots would be better served by a mode that gave up after a certain number of crashes or failures. Perhaps a --exit-after-n-failures flag could fill both of these needs? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:25:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:25:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28193] New: bugzilla-tool: Re-factor shared landing logic into helper class to share more code Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28193 Summary: bugzilla-tool: Re-factor shared landing logic into helper class to share more code Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org bugzilla-tool: Re-factor shared landing logic into helper class to share more code I did this originally a part of bug 26715, but it really should be a separate issue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:25:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:25:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28127] [Haiku] Use Clipboard::create instead of its constructor. In-Reply-To: References: Message-ID: <20090811222529.DDB5234B3439@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28127 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34415|review+, commit-queue+ | Flag| | --- Comment #3 from Eric Seidel 2009-08-11 15:25:29 PDT --- (From update of attachment 34415) Clearing review flag on attachment: 34415 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/editing/haiku/EditorHaiku.cpp M WebCore/page/haiku/EventHandlerHaiku.cpp M WebCore/platform/haiku/ClipboardHaiku.cpp M WebCore/platform/haiku/DragDataHaiku.cpp Committed r47068 M WebCore/editing/haiku/EditorHaiku.cpp M WebCore/ChangeLog M WebCore/page/haiku/EventHandlerHaiku.cpp M WebCore/platform/haiku/ClipboardHaiku.cpp M WebCore/platform/haiku/DragDataHaiku.cpp r47068 = a6669f4fb846d758f172b3974b9f79bcd5242a69 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47068 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:25:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:25:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28127] [Haiku] Use Clipboard::create instead of its constructor. In-Reply-To: References: Message-ID: <20090811222534.32D3734B344D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28127 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #4 from Eric Seidel 2009-08-11 15:25:32 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:25:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:25:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26388] WebKit should allow cross-site scripts to set top.opener.location to a different URL In-Reply-To: References: Message-ID: <20090811222552.3112B34B3467@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26388 --- Comment #5 from Yuan Qi 2009-08-11 15:25:50 PDT --- Have you been able to reproduce this bug using my test case? Again, Safari appears to be only browser to have adopted this behaviour. IE8, Firefox 3.5 and Chrome all have no problems with the my bank's website. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:27:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:27:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090811222730.C187834B34A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|run-webkit-tests needs a |run-webkit-tests needs a |--fail-fast option |--exit-after-failures=N | |option --- Comment #2 from Eric Seidel 2009-08-11 15:27:29 PDT --- Excellent idea! (and that's a much better name) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:29:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:29:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24218] Safari 4 javascript window resize inconsistency In-Reply-To: References: Message-ID: <20090811222958.0328734B34E1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24218 Sam Garfield changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stopsendingmejunk at gmail.com --- Comment #6 from Sam Garfield 2009-08-11 15:29:56 PDT --- Are we sure this isn't a webkit problem? The same bug exists in webkit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:30:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:30:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28193] bugzilla-tool: Re-factor shared landing logic into helper class to share more code In-Reply-To: References: Message-ID: <20090811223009.3AD9534B34FA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28193 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34604| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-11 15:30:08 PDT --- Created an attachment (id=34604) --> (https://bugs.webkit.org/attachment.cgi?id=34604) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:33:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:33:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28193] bugzilla-tool: Re-factor shared landing logic into helper class to share more code In-Reply-To: References: Message-ID: <20090811223308.81D8C34B3560@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28193 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34604|review? |review+ Flag| | --- Comment #2 from Adam Barth 2009-08-11 15:33:07 PDT --- (From update of attachment 34604) Would be nice to factor out all the WebKit stuff into modules/webkit.py at some point. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:33:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:33:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28193] bugzilla-tool: Re-factor shared landing logic into helper class to share more code In-Reply-To: References: Message-ID: <20090811223340.C728D34B358A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28193 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-11 15:33:39 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool Committed r47069 M WebCore/editing/haiku/EditorHaiku.cpp M WebCore/ChangeLog M WebCore/page/haiku/EventHandlerHaiku.cpp M WebCore/platform/haiku/ClipboardHaiku.cpp M WebCore/platform/haiku/DragDataHaiku.cpp r47068 = a6669f4fb846d758f172b3974b9f79bcd5242a69 (trunk) M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool r47069 = 67e74353dfc8c4855ce730e06c50d05018528641 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/47069 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:34:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:34:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27124] let me *edit* css styles in the web inspector. In-Reply-To: References: Message-ID: <20090811223455.73ADD34B35D8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27124 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[commit+] let me *edit* css |let me *edit* css styles in |styles in the web |the web inspector. |inspector. | --- Comment #14 from Adam Barth 2009-08-11 15:34:51 PDT --- We don't need the [commit+] fake flag any more. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:35:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:35:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26715] bugzilla-tool should automate rollouts In-Reply-To: References: Message-ID: <20090811223535.995B834B35F8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26715 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28193 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:35:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:35:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28193] bugzilla-tool: Re-factor shared landing logic into helper class to share more code In-Reply-To: References: Message-ID: <20090811223537.3228634B360E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28193 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26715 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:37:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:37:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28195] New: Inline style wrapped in noscript not applied when added to the DOM via innerHTML Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28195 Summary: Inline style wrapped in noscript not applied when added to the DOM via innerHTML Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hohle at amazon.com CC: hohle at amazon.com Created an attachment (id=34605) --> (https://bugs.webkit.org/attachment.cgi?id=34605) HTML to reproduce issue. If an HTML fragment which contains an inline stylesheet and is wrapped in a noscript tag is added to the DOM by setting innerHTML on a DOM node in JavaScript, those styles are applied to the DOM. In my use case an external library is blindly copying HTML fragments which may have reuse elsewhere. Styles that are expected not to be applied when JavaScript is enabled are being applied due to this library using innerHTML to copy this HTML fragment. In other browsers this works as expected, but in Safari, the styles wrapped in noscript are applied causing undesired rendering. Expected behavior -------------- Styles wrapped in noscript should be ignored no matter how they are added to the DOM if JavaScript is enabled. Actual Behavior ------------ Styles wrapped in noscript added to the DOM via innerHTML are applied to the DOM. Styles wrapped in noscript are not applied if they are added to the DOM in an HTML file or via document.write Reproduction ---------- This has been reproduced in Safari 3.2.x, Safari 4.0.x, and with a current Webkit nightly. I've attached a minimal HTML file which illustrates the problem. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:39:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:39:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28195] Inline style wrapped in noscript not applied when added to the DOM via innerHTML In-Reply-To: References: Message-ID: <20090811223900.7C5E334B367A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28195 --- Comment #1 from Jonathan Hohle 2009-08-11 15:39:00 PDT --- Created an attachment (id=34606) --> (https://bugs.webkit.org/attachment.cgi?id=34606) Actual result when rendering the attached HTML. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:39:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:39:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28195] Inline style wrapped in noscript not applied when added to the DOM via innerHTML In-Reply-To: References: Message-ID: <20090811223928.3300D34B3687@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28195 --- Comment #2 from Jonathan Hohle 2009-08-11 15:39:27 PDT --- Created an attachment (id=34607) --> (https://bugs.webkit.org/attachment.cgi?id=34607) Expected result when rendering the attached HTML -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:39:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:39:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811223933.63FF734B36A5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 --- Comment #30 from Viet-Trung Luu 2009-08-11 15:39:28 PDT --- (In reply to comment #29) > Sorry for confusing you with the earlier person working on this bug! No worries. :-) > If that?s true, then perhaps we should name it for when it should be called > rather than for what it does. Maybe contentMovedUnderMouse() or something along > those lines? That sounds like a good name. > Seems like a reasonable first step. Lets not set our sights too low though. > Lets try to fix this all the way! So an issue is that, as I said, the PlatformMouseEvent's go fairly deep. In particular, we need to tell our Scrollbar's that the mouse position has changed relative to them. (This isn't true for the window scrollbars for the scrolling case, but is needed for a resize; for example, if the resize causes the mouse to be over or to leave the scrollbar, it may need to update its hover state.) Now, the stuff in Scrollbar.cpp isn't a problem, but it calls down to ScrollbarTheme ... which involves code in many places. There's also the mouse event dispatch code (going down into the DOM code), though that looks more easily manageable. Possible solutions: (1) Refactor everything, ditching PlatformMouseEvent's where possible. (Seems a bit like overkill? This would affect code in many places, including platform code.) (2) Add methods which don't require PlatformMouseEvent's alongside the current ones. (Adds either hard-to-maintain redundancy -- or complexity, if code is refactored to make things common. Not really any better than (1), since it would also touch platform code.) (3) Add an event type to PlatformMouseEvent -- "MouseEventUpdatePosition" or some such; code which cares can look for it. (Possible bugs in code which assumes all data are valid, but that would happen with fake mouse moves anyway.) (4) Generate fake PlatformMouseEvent's (with a fake MouseEventMoved). Obviously "works", but it's a pack of lies. I'm kind of inclined towards (3). For things like keyboard flags, one could similarly have "MouseEventUpdateKeys". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:52:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:52:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] New: Chromium: Show a "Playback Disabled" button on media error. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28196 Summary: Chromium: Show a "Playback Disabled" button on media error. Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P4 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: kylep at chromium.org Load and paint a mediaPlayDisabled image in RenderThemeChromiumSkia::paintMediaPlayButton() to display when the mediaElement cannot load. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:54:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:54:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090811225451.BDD2134B3830@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Kyle Prete changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34608| |review? Flag| | --- Comment #1 from Kyle Prete 2009-08-11 15:54:51 PDT --- Created an attachment (id=34608) --> (https://bugs.webkit.org/attachment.cgi?id=34608) Fix Loads and paints a disabled playback image. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:02:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:02:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090811230201.093DE34B38B5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34567|0 |1 is obsolete| | Attachment #34609| |review? Flag| | --- Comment #3 from George Wright 2009-08-11 16:02:00 PDT --- Created an attachment (id=34609) --> (https://bugs.webkit.org/attachment.cgi?id=34609) Canvas zooming fix using intrinsic coordinates New patch which updates the intrinsic coordinates instead of adding to the CSS properties. This also fixes the intrinsic coordinates not being updated for an initial style setting to a renderer. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:02:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:02:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28197] New: Changing the page encoding clears all forms Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28197 Summary: Changing the page encoding clears all forms Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Keywords: InChromiumBugs Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jshin at chromium.org 1. Type something in textarea of text input field 2. Change the character encoding 3. All forms are cleared. There's a very long standing gecko bug on this (almost 10 years old). IE also has the same issue. I was bitten by this issue multiple times here and mozilla bugzilla (before it switched to UTF-8). It's also http://crbug.com/18868 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:05:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:05:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090811230543.8610C34B3943@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34609|review? |review- Flag| | --- Comment #4 from Dave Hyatt 2009-08-11 16:05:42 PDT --- (From update of attachment 34609) Everything looks fine to me except for the if (!parent()) check in RenderReplaced::layout(). It's not clear to me why you would need that...are you sure you didn't just need to patch the intrinsicSizeChanged method for other replaced elements in a fashion similar to what you did in RenderHTMLCanvas? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:07:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:07:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] New: bugzilla-tool : various improvements for running the commit-queue Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28199 Summary: bugzilla-tool : various improvements for running the commit-queue Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org bugzilla-tool : various improvements for running the commit-queue I've been running the commit-queue today and found a bunch of little bugs in bugzilla-tool which I will post a patch here to fix. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:14:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:14:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] bugzilla-tool : various improvements for running the commit-queue In-Reply-To: References: Message-ID: <20090811231442.4079134B3A48@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28199 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34610| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-11 16:14:41 PDT --- Created an attachment (id=34610) --> (https://bugs.webkit.org/attachment.cgi?id=34610) Various little fixes for the commit-queue -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:18:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:18:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] bugzilla-tool : various improvements for running the commit-queue In-Reply-To: References: Message-ID: <20090811231839.4D52834B3AC2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28199 --- Comment #2 from Adam Barth 2009-08-11 16:18:38 PDT --- I'll review this in detail after dinner. For the moment, you should use os.devnull instead of "/dev/null" -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:25:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:25:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090811232508.AA1F634B3B7C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34608|review? |review- Flag| | --- Comment #2 from David Levin 2009-08-11 16:25:08 PDT --- (From update of attachment 34608) The diff here is odd. It should have WebCore/ prefixed before each file. I suspect that you are working from a chromium directory and that's why you have this problem. (I don't do that so I don't know the fix.) At worst fix it by hand to aid in landing your patch. > Index: ChangeLog > +2009-08-11 Kyle Prete > + > + Reviewed by NOBODY (OOPS!). > + You need the bug title and a link to the bug here. (see other changelog entries.) prepare-ChangeLog -bug # will give the you the right format. > + Use a disabled play button when the media file cannot be played. > + > + No new tests. (OOPS!) This shouldn't be here. Either add a test or indicate if existing tests cover this. > Index: rendering/RenderThemeChromiumSkia.cpp > static Image* mediaPlay = Image::loadPlatformResource("mediaPlay").releaseRef(); > static Image* mediaPause = Image::loadPlatformResource("mediaPause").releaseRef(); > + static Image* mediaPlayDisabled = Image::loadPlatformResource("mediaPlayDisabled").releaseRef(); > > + if (mediaElement->networkState() == HTMLMediaElement::NETWORK_NO_SOURCE) > + return paintMediaButtonInternal(paintInfo.context, rect, mediaPlayDisabled); This needs a 4 space indent. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:25:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:25:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28200] New: ListMarker should be included as part of the text value to parse Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28200 Summary: ListMarker should be included as part of the text value to parse Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cfleizach at apple.com If a list includes list markers, the list marker values need to be included as part of the text string. As an example, if bullet character is at the beginning of every list item, then each one of those bullet character needs to be part of the AXValue of the AXWebArea. And asking any of the text parsing SPIs, such as AXStringForRange, should include the bullet character. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:25:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:25:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090811232519.D126A34B3B94@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |levin at chromium.org Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:25:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:25:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28200] ListMarker should be included as part of the text value to parse In-Reply-To: References: Message-ID: <20090811232523.5F96934B3BB8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28200 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |cfleizach at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:38:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:38:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090811233824.9C3F934B3D2E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Viet-Trung Luu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34523|review? | Flag| | Attachment #34523|0 |1 is obsolete| | Attachment #34612| |review? Flag| | --- Comment #18 from Viet-Trung Luu 2009-08-11 16:38:20 PDT --- Created an attachment (id=34612) --> (https://bugs.webkit.org/attachment.cgi?id=34612) Updated with Jeremy's suggested comment (more or less). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:42:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:42:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090811234250.C008B34B3DDE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 --- Comment #19 from Jeremy Moskovich 2009-08-11 16:42:48 PDT --- Looks Good -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:48:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:48:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28201] New: Input fields with more than 65k characters are rendered incorrectly Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28201 Summary: Input fields with more than 65k characters are rendered incorrectly Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: vandebo-webkitbugzilla at nerdbox.net Created an attachment (id=34613) --> (https://bugs.webkit.org/attachment.cgi?id=34613) Html with >65k input field Safari and Chrome incorrectly render text fields that have more than 65,535 characters. Only the first (length mod 2^16) characters are rendered and are editable. However, when there are 2^16 or more characters in a text field, they are all properly sent to the server on submit. The attached test case demonstrates this problem. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:49:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:49:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] New: run-webkit-tests --quiet hangs Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28202 Summary: run-webkit-tests --quiet hangs Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org run-webkit-tests --quiet hangs My perl-fu is not strong. :( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:49:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:49:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] run-webkit-tests --quiet hangs In-Reply-To: References: Message-ID: <20090811234936.9B0FC34B3EB1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28202 --- Comment #1 from Eric Seidel 2009-08-11 16:49:35 PDT --- I talked this out with "buu" in #perl, and this was the best we came up with. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:50:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:50:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] run-webkit-tests --quiet hangs In-Reply-To: References: Message-ID: <20090811235051.A4C2A34B3ED8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34614| |review? Flag| | --- Comment #2 from Eric Seidel 2009-08-11 16:50:50 PDT --- Created an attachment (id=34614) --> (https://bugs.webkit.org/attachment.cgi?id=34614) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:57:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:57:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090811235726.DB66634B3F96@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Kyle Prete changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34608|0 |1 is obsolete| | Attachment #34615| |review? Flag| | --- Comment #3 from Kyle Prete 2009-08-11 16:57:25 PDT --- Created an attachment (id=34615) --> (https://bugs.webkit.org/attachment.cgi?id=34615) Fix Thanks for the review. Your comments should be covered by this revision. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:59:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:59:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090811235931.758E934B3FC2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34615|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:00:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:00:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812000002.4B3B934B3FD2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34615| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:07:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:07:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code In-Reply-To: References: Message-ID: <20090812000733.35E3A34B408C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27967 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34496|review? | Flag| | Attachment #34496|0 |1 is obsolete| | Attachment #34617| |review? Flag| | --- Comment #10 from Dumitru Daniliuc 2009-08-11 17:07:30 PDT --- Created an attachment (id=34617) --> (https://bugs.webkit.org/attachment.cgi?id=34617) patch Same patch, SQLTransactionClient's methods are no longer virtual as suggested by Michael. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:20:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:20:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090812002029.B737934B41A1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34609|0 |1 is obsolete| | Attachment #34618| |review? Flag| | --- Comment #5 from George Wright 2009-08-11 17:20:28 PDT --- Created an attachment (id=34618) --> (https://bugs.webkit.org/attachment.cgi?id=34618) Removed unnecessary null pointer check You're right - that null pointer check was an artifact left over from testing. It works fine without it. I have also added the new test which I forgot to put in my last patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:44:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:44:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27656] REGRESSION: Clicking on popup menu changes layout In-Reply-To: References: Message-ID: <20090812004431.698FF34B43E9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27656 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.fraser at apple.com --- Comment #3 from Simon Fraser (smfr) 2009-08-11 17:44:30 PDT --- It's focus, not clicking that is the issue; the focus ring is affecting layout. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:54:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:54:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812005444.4407734B457D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34592|review? |review- Flag| | --- Comment #3 from Darin Adler 2009-08-11 17:54:43 PDT --- (From update of attachment 34592) > + Vector cookies; > + Document* document = ic->inspectedPage()->mainFrame()->domWindow()->document(); > + cookies = rawCookies(document, document->cookieURL()); You should declare the cookies vector on the same line where you initialize it. But, you should not use Vector for a return value; copying it to return it is very inefficient. Instead you should name this function getRawCookies and use a Vector& as an out parameter. > + Cookie cookie = cookies[i]; To avoid making an extra copy of each cookie in the vector this can be a "const Cookie&" instead of Cookie. > + JSObject* cookieObj = constructEmptyObject(exec); We prefer not to abbreviate, so please say cookieObject. > + cookieObj->putDirect(Identifier(exec, "name"), jsString(exec, cookie.name())); > + cookieObj->putDirect(Identifier(exec, "value"), jsString(exec, cookie.value())); > + cookieObj->putDirect(Identifier(exec, "domain"), jsString(exec, cookie.domain())); > + cookieObj->putDirect(Identifier(exec, "path"), jsString(exec, cookie.path())); > + cookieObj->putDirect(Identifier(exec, "expires"), jsString(exec, cookie.expires())); > + cookieObj->putDirect(Identifier(exec, "httpOnly"), jsBoolean(cookie.isHttpOnly())); > + cookieObj->putDirect(Identifier(exec, "secure"), jsBoolean(cookie.isSecure())); > + cookieObj->putDirect(Identifier(exec, "session"), jsBoolean(cookie.isSession())); This will be relatively slow since it's going to create each of these identifiers from the constant string each time through the loop, which is a hash table lookup every time. It might be good to instead create local variables for each identifier so each will be created exactly once. On the other hand, the jsString operations are relatively costly too, so it's probably not all that important to optimize. > + result.append( cookieObj ); The spaces around the argument are not the correct style. > + // return jsNumber(exec, cookies.size()); Oops, left in this commented code! > + class Cookie { > + public: > + Cookie(const String& name, const String& value, const String& domain, > + const String& path, const String& expires, const bool httpOnly, > + const bool secure, const bool session) No need for the "const" in "const bool". Would be nice to indent this so the lines don't exactly line up with the ":". I often use indent by an extra tab stop. For a pure data holder like this, you might want to consider just using a struct instead of a class with getter functions. > class KURL; > class String; > class Document; > + class Cookie; These should be sorted alphabetically. Not sure why Document wasn't already. > #import "config.h" > +#import "Cookie.h" > #import "CookieJar.h" The new include should be added to the paragraph below, not put above the file's own header. The file's own header always comes first. > + NSString* name = [cookie name]; > + NSString* value = [cookie value]; > + NSString* domain = [cookie domain]; > + NSString* path = [cookie path]; > + NSString* expires = [[cookie expiresDate] description]; It's a bit strange to put this date into this string form, but I don't have a better suggestion at the moment. Our coding style is to put the * next to the variable name for Objective-C types like this one. > + bool httpOnly = [cookie isHTTPOnly]; > + bool secure = [cookie isSecure]; > + bool session = [cookie isSessionOnly]; > + Cookie cookieData = Cookie(name, value, domain, path, expires, httpOnly, secure, session); > + rawCookies.append(cookieData); > + } > + > + return rawCookies; You shouldn't need this return statement here. It's OK to fall through to the return outside the block exceptions macro. This patch will break all platforms other than Mac OS X. You can't land it like that, so you'll need to figure out what to do for those other platforms. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:54:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:54:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] New: [Chromium] drop down menu letter selection, skip selections Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28205 Summary: [Chromium] drop down menu letter selection, skip selections Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.njtransit.com/sf/sf_servlet.srv?hdnPageActi on=TrainSchedulesTo OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: xji at chromium.org steps to reproduce the problem? 1. go to the above website with a dropdown selection menu 2. click the drop down menu to show selections 3. press a letter (such as 'A') to skip to the selection you want 4. it will automatically skip to the 2nd corresponding lettered selection 5. continue press 'A', it selects every other item. Chromium bug: http://code.google.com/p/chromium/issues/detail?id=18950 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:55:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:55:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812005528.C292034B45A9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InChromiumBugs CC| |xji at chromium.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:56:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:56:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812005605.DE88634B45D9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34562|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:56:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:56:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812005621.C3C1034B45F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34577|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:06:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:06:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812010605.3FE1A34B4725@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34562|review+ | Flag| | --- Comment #7 from Adam Treat 2009-08-11 18:06:04 PDT --- (From update of attachment 34562) Landed with r47077, clearing review flag. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:18:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:18:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28206] New: onbeforeunload not called at window close + frame or iframe focused Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28206 Summary: onbeforeunload not called at window close + frame or iframe focused Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=34628) --> (https://bugs.webkit.org/attachment.cgi?id=34628) testcase I Steps: 1. open a page with a frameset or an iframe (attached files) 2. focus the frame 3. close the window II Issue: onbeforeunload is not executed. Related Webkit bugs https://bugs.webkit.org/show_bug.cgi?id=19418 as well as https://bugs.webkit.org/show_bug.cgi?id=21669 are about an onbeforeunload handler when it is assigned to the frame content or the iframe itself. This bug is about onbeforeonload assigned to a window which contain an iframe or a frameset. The handler is properly called if we back the document or if we load the document and immediately close the window. Yet if the contained frame or iframe is focused (using JS as in the attached reduction) when the window is closed then, the window beforeonload handler is not called. III Browsers info: Chrome 3.x : NOT OK Safari 3/Win: NOT OK Safari 3/Mac: OK Safari 4/Mac: OK Firefox 3.x: OK IE 8: OK Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=17157 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:19:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:19:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28206] onbeforeunload not called at window close + frame or iframe focused In-Reply-To: References: Message-ID: <20090812011923.095A334B574E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28206 --- Comment #1 from jasneet 2009-08-11 18:19:21 PDT --- Created an attachment (id=34629) --> (https://bugs.webkit.org/attachment.cgi?id=34629) testcase -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:19:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:19:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28206] onbeforeunload not called at window close + frame or iframe focused In-Reply-To: References: Message-ID: <20090812011934.9696034B5766@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28206 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:26:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:26:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812012649.BBFEA34B5BF7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34631| |review? Flag| | --- Comment #1 from Xiaomei Ji 2009-08-11 18:26:48 PDT --- Created an attachment (id=34631) --> (https://bugs.webkit.org/attachment.cgi?id=34631) patch w/ manual test -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:33:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:33:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28207] New: Another deadlock in the DB code Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28207 Summary: Another deadlock in the DB code Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: dumi at chromium.org CC: andersca at apple.com, beidson at apple.com, aroben at apple.com, michaeln at google.com, dglazkov at chromium.org Bug 27966 describes how 2 transactions run on 2 different handles to the same DB can deadlock the DB thread. Here's an example of how a transaction combined with a openDatabase() call can deadlock the DB thread and block the main thread at the same time: 1: var db1 = openDatabase("SomeDB", "1.0", "Blah", 10000); 2: db1.transaction(function(tx) { 3: tx.executeSql("SomeWriteStatement", [args], 4: function(result) { var db2 = openDatabase("SomeDB", "1.0", "Blah", 10000); }, 5: function(tx, error) { }); 6: }, 7: function(error) { }, 8: function() { } 9: ); Description: 1. The user opens a handle to a database (line #1). 2. The user starts running a transaction on that handle (line #2). The transaction must have a "write" statement, that will make SQLite acquire an exclusive lock on the DB file (line #3). 3. Eventually, we get to running the statement callback (line #4). 4. openDatabase() is called on the main thread (line #4). 5. The main thread creates a new SQLite connection to the same DB file, schedules a task on the DB thread (to make sure the version is correct), and blocks waiting for this task to complete (openDatabase() is a sync call according to the spec). 6. In order to check the version, the new task needs to acquire a "read" lock on the DB file first and check if the __WebKitDatabaseInfoTable__ table exists. 7. This "read" lock cannot be acquired because the transaction has an exclusive lock on the DB file. At the same time, the transaction cannot release the exclusive lock until the statement callback is executed. So the DB thread is deadlocked, and the main thread is blocked too, because it waits for the openDatabase() call to finish. Safari's debug build from trunk deadlocks for 30 seconds (SQLite's busy_timeout) and then crashes. PROPOSED FIX: It's OK for the first call to openDatabase(SomeDB, ...) to execute SQL statements, because we know there are no in-flight transactions on other DB handles to the same database. However, the 2nd, 3rd, ... calls to openDatabase(SomeDB, ...) cannot run any SQL statements without risking a deadlock. So in addition to caching the DB version (this is what WebCore does now), we need to also cache a flag that tells us if the __WebKitDatabaseInfoTable__ exists in the database. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:16:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:16:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] bugzilla-tool : various improvements for running the commit-queue In-Reply-To: References: Message-ID: <20090812021633.B1C9E34B8A78@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28199 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34610|review? |review+ Flag| | --- Comment #3 from Adam Barth 2009-08-11 19:16:32 PDT --- (From update of attachment 34610) These are all good bugs to fix. Two minor things to fix before landing: 1) "/dev/null" -> os.devnull 2) "Clearing review flag on attachment" -> this text now doesn't quite match what we're doing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:22:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:22:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26854] [GTK] Needs API to allow more control over outgoing requests In-Reply-To: References: Message-ID: <20090812022200.8433C34B8E06@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26854 --- Comment #11 from Gustavo Noronha (kov) 2009-08-11 19:21:59 PDT --- (In reply to comment #9) > I think instead of sending the identifier, we can do a WebResource lookup by > identifier and send the resource instead. Thoughts? That sounds good to me, yeah =D -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:42:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:42:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28208] New: Typo in FastMalloc.h causes build to fail Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28208 Summary: Typo in FastMalloc.h causes build to fail Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: thomas at cranksoftware.com Trying to get a stock version built for Windows I ran across this typo in WebKit/JavaScriptCore/wtf/FastMalloc.h that caused the compile to stop dead. I'm just using the stock build procedure from the website, no extra arguments, so I'm surprised this isn't hitting others. The patch is a simple typo fix in an inline declaration s -> size Patch is attached -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:43:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:43:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] New: Restrict use of FuncDeclNode & FuncExprNode to the parser. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28209 Summary: Restrict use of FuncDeclNode & FuncExprNode to the parser. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: barraclough at apple.com These objects were also being referenced from the CodeBlock. By changing this to just retain pointers to FunctionBodyNodes these classes can be restricted to use during parsing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:50:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:50:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812025055.686D234B90B6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34633| |review? Flag| | --- Comment #1 from Gavin Barraclough 2009-08-11 19:50:54 PDT --- Created an attachment (id=34633) --> (https://bugs.webkit.org/attachment.cgi?id=34633) The Patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:54:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:54:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812025458.869A034B9121@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34633|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 20:32:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 20:32:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812033234.8DB2534B9440@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34592|0 |1 is obsolete| | Attachment #34634| |review? Flag| | --- Comment #4 from Joseph Pecoraro 2009-08-11 20:32:33 PDT --- Created an attachment (id=34634) --> (https://bugs.webkit.org/attachment.cgi?id=34634) Fixed Based on Review This is an attempt at a real workable version that hopefully won't break the build. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 20:35:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 20:35:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28208] Typo in FastMalloc.h causes build to fail In-Reply-To: References: Message-ID: <20090812033546.9C32134B948E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28208 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrowe at apple.com --- Comment #1 from Mark Rowe (bdash) 2009-08-11 20:35:45 PDT --- There's no patch attached, and I don't see any references to "s" in FastMalloc.h in . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 20:40:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 20:40:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812034054.50F7834B94F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 --- Comment #5 from Joseph Pecoraro 2009-08-11 20:40:53 PDT --- (In reply to comment #3) > You should declare the cookies vector on the same line where you initialize it. > But, you should not use Vector for a return value; copying it to return it is > very inefficient. Instead you should name this function getRawCookies and use a > Vector& as an out parameter. Done. Made the Vector an out parameter, but that requires the declaration to again be on another line. > To avoid making an extra copy of each cookie in the vector this can be a "const > Cookie&" instead of Cookie. Done. > We prefer not to abbreviate, so please say cookieObject. Done. Noted. > This will be relatively slow since it's going to create each of these > identifiers from the constant string each time through the loop, which is a > hash table lookup every time. It might be good to instead create local > variables for each identifier so each will be created exactly once. On the > other hand, the jsString operations are relatively costly too, so it's probably > not all that important to optimize. Done. I moved Initializers out and made them const. > The spaces around the argument are not the correct style. Done. Including all other style fixes. > No need for the "const" in "const bool". Would be nice to indent this so the > lines don't exactly line up with the ":". I often use indent by an extra tab > stop. Done. > For a pure data holder like this, you might want to consider just using a > struct instead of a class with getter functions. Done. Made a struct. Including a new field "size" (see below). > The new include should be added to the paragraph below, not put above the > file's own header. The file's own header always comes first. Done. Noted. > It's a bit strange to put this date into this string form, but I don't have a > better suggestion at the moment. Done. Noted. > Our coding style is to put the * next to the variable name for Objective-C > types like this one. Done. Noted. > This patch will break all platforms other than Mac OS X. You can't land it like > that, so you'll need to figure out what to do for those other platforms. Attempted. I searched and identified, hopefully all, other platforms. Most don't really make support for this easy, and I have no way of testing on them at all. What is the best course of action for something like this? ------------ I added another field to the Cookie struct, "size". Firebug's "size" parameter seems to be the (size of the name + size of the value). I decided to put this into the struct, and then make it available in the constructed jsObjects for the inspector. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 20:44:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 20:44:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812034415.8B65C34B954D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #20 from Michael Nordman 2009-08-11 20:44:12 PDT --- The code LGTM. Possibly some names could be tweeked to better fit webkit conventions? In all cases, you'll need a webkit reviewer to take a peek. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 20:46:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 20:46:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812034623.A23CD34B957D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 --- Comment #6 from Joseph Pecoraro 2009-08-11 20:46:23 PDT --- Oh, one final question. Inside CookieJar.h I include . This seems to make it unnecessary to include again in each of the platform specific implementations... but I included them anyways. I could probably do the same for Cookie.h What is the proper way to go about this? - Include in just the header - Include in both the header and the implementation Seeing as it compiled for me without declaring in both places I'm guessing this is a style issue, and I'm guessing certain editors might work better with the declaration in both files. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:30:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:30:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] New: Document relation between major objects in WebCore Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28210 Summary: Document relation between major objects in WebCore Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: WebKit Website AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abarth at webkit.org We should create a page on the web site that explains the relation between the major objects in webcore, especially when those relations can be null. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:32:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:32:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] New: Can't click and drag the media controller thumb Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28211 Summary: Can't click and drag the media controller thumb Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.fraser at apple.com With TOT, the media slider doesn't move with the cursor when I mouse down and drag it over the controller. The media slider only updates it's position after I mouse up after I drag it. This is a regression on TOT since this doesn't happen on stock SL 10A342. This regression was caused by http://trac.webkit.org/changeset/46915 since it doesn't happen with previous checkin 46914. * STEPS TO REPRODUCE 1. Launch a nightly webkit build and go to http://www.mirageband.tv/Night%20and%20Day.mp3 2. Wait for entire file to load then pause it 3. Mouse down directly on the slider and drag the mouse to another section on the controller. Notice the slider doesn't move until you mouse up. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:32:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:32:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812043258.336D534B996A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.carlson at apple.com, | |simon.fraser at apple.com Platform|PC |All -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:33:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:33:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812043314.D853334B997C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Simon Fraser (smfr) 2009-08-11 21:33:14 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:34:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:34:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27920] Right click on timeline of media controls panel cause seek In-Reply-To: References: Message-ID: <20090812043400.B5E4A34B99A0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27920 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.fraser at apple.com --- Comment #9 from Simon Fraser (smfr) 2009-08-11 21:33:58 PDT --- This caused a bad regression in mouse handling (bug 28211). Please address as soon as possible, or revert this change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:36:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:36:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22280] CG GIF decoder uses too much CPU In-Reply-To: References: Message-ID: <20090812043602.F11E134B99CA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22280 Knodi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcobra at gmail.com --- Comment #13 from Knodi 2009-08-11 21:36:00 PDT --- Are you kidding me wait for OS upgrade for fix your browser freezing up on gifs?? What are you fucking microsoft?? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:39:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:39:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812043944.CFA6534B9A17@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34635| |review? Flag| | --- Comment #1 from Adam Barth 2009-08-11 21:39:43 PDT --- Created an attachment (id=34635) --> (https://bugs.webkit.org/attachment.cgi?id=34635) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:40:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:40:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812044027.98A5834B9A2C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34635|review? | Flag| | Attachment #34635|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:40:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:40:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812044037.9DA7B34B9A49@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34636| |review? Flag| | --- Comment #2 from Adam Barth 2009-08-11 21:40:36 PDT --- Created an attachment (id=34636) --> (https://bugs.webkit.org/attachment.cgi?id=34636) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:43:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:43:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812044355.7AA8834B9A9A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34637| |review? Flag| | --- Comment #6 from Oliver Hunt 2009-08-11 21:43:54 PDT --- Created an attachment (id=34637) --> (https://bugs.webkit.org/attachment.cgi?id=34637) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:48:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:48:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812044827.00A4B34B9AF6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34636|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:55:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:55:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812045501.7C40334B9B9F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34637|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:55:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:55:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812045538.A3EB834B9BC5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Adam Barth 2009-08-11 21:55:37 PDT --- Sending WebKitSite/ChangeLog Adding WebKitSite/coding/major-objects.html Transmitting file data .. Committed revision 47085. http://trac.webkit.org/changeset/47085 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:57:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:57:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812045736.EB15534B9BFB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #7 from Oliver Hunt 2009-08-11 21:57:36 PDT --- Committed r47086 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:13:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:13:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28207] Another deadlock in the DB code In-Reply-To: References: Message-ID: <20090812051328.0158C34B9D62@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28207 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:13:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:13:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812051339.A600434B9D6A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:14:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:14:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27920] Right click on timeline of media controls panel cause seek In-Reply-To: References: Message-ID: <20090812051406.5ED1C34B9D94@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27920 --- Comment #10 from Hin-Chung Lam 2009-08-11 22:14:04 PDT --- I'm looking into the regression now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:16:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:16:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28206] onbeforeunload not called at window close + frame or iframe focused In-Reply-To: References: Message-ID: <20090812051610.DF50B34B9DD0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28206 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE --- Comment #2 from Alexey Proskuryakov 2009-08-11 22:16:09 PDT --- *** This bug has been marked as a duplicate of bug 27481 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:16:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:16:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27481] onbeforeunload not called at window close + frame or iframe focused In-Reply-To: References: Message-ID: <20090812051611.EC53834B9DDE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27481 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jasneet at chromium.org --- Comment #2 from Alexey Proskuryakov 2009-08-11 22:16:09 PDT --- *** Bug 28206 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:18:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:18:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28197] Changing the page encoding clears all forms In-Reply-To: References: Message-ID: <20090812051805.913A334B9E06@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28197 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:21:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:21:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21945] (https://bugs.webkit.org/attachment.cgi?id=34638) Patch v1 --- 3 files changed, 184 insertions(+), 175 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:36:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:36:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19146] [CURL] https pages not loading. In-Reply-To: References: Message-ID: <20090812053642.3545F34BA047@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19146 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |bfulgham at webkit.org Resolution| |FIXED --- Comment #4 from Brent Fulgham 2009-08-11 22:36:41 PDT --- I believe the cause of this bug was resolved by Bug 28171. The point may be moot, now that the Linux port is using SOUP. Please reopen if the problem is still valid for your platform using the current WebKit revision. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:41:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:41:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090812054120.96C2334BA0C1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #10 from Shinichiro Hamaji 2009-08-11 22:41:18 PDT --- Filed Bug 28212 as the step 0. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:46:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:46:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812054623.6AC2C34BA136@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34638|review? |review+ Flag| | --- Comment #2 from Eric Seidel 2009-08-11 22:46:23 PDT --- (From update of attachment 34638) Assuming this is just a simple rename. LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:47:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:47:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23092] Conditionalize CFNetwork-specific logic in WebKit.dll In-Reply-To: References: Message-ID: <20090812054751.A84B534BA15A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23092 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zucker at wake3.com --- Comment #13 from Brent Fulgham 2009-08-11 22:47:50 PDT --- *** Bug 18471 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:47:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:47:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17730] Allows Windows version to use Curl In-Reply-To: References: Message-ID: <20090812054752.225A234BA160@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17730 Bug 17730 depends on bug 18471, which changed state. Bug 18471 Summary: Fix WebDownload.cpp compile problems for cairo/curl build https://bugs.webkit.org/show_bug.cgi?id=18471 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Status|ASSIGNED |RESOLVED Resolution| |DUPLICATE -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:48:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:48:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090812054818.C2FDE34BA17C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #11 from Shinichiro Hamaji 2009-08-11 22:48:17 PDT --- Thanks for the detailed comments on this task and future road maps! The steps Darin suggest sounds definitely better than my "change at once" plan. I'd like to follow the steps. The future road maps also sound nice. I'll be happy if I can help any of them. By the way, I've noticed that running make-js-test-wrappers change 4 HTMLs which are slightly modified from the original TEMPLATE. I think we need to fix this before the step 1. I'll send a patch soon later. I hope my change makes sense. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:52:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:52:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812055204.1805734BA1CC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34634|review? |review+ Flag| | --- Comment #7 from Darin Adler 2009-08-11 22:52:03 PDT --- (From update of attachment 34634) > + Document* document = ic->inspectedPage()->mainFrame()->domWindow()->document(); >From mainFrame() you can get to the document directly. No need to go through domWindow(). > + const Identifier nameIdentifier = Identifier(exec, "name"); > + const Identifier valueIdentifier = Identifier(exec, "value"); > + const Identifier domainIdentifier = Identifier(exec, "domain"); > + const Identifier pathIdentifier = Identifier(exec, "path"); > + const Identifier expiresIdentifier = Identifier(exec, "expires"); > + const Identifier sizeIdentifier = Identifier(exec, "size"); > + const Identifier httpOnlyIdentifier = Identifier(exec, "httpOnly"); > + const Identifier secureIdentifier = Identifier(exec, "secure"); > + const Identifier sessionIdentifier = Identifier(exec, "session"); You can use construction syntax instead of assignment for these. Also, no real reason to make them const. After all, almost any local variable in most programs could be marked const, and for brevity we normally don't do it unless there's a special reason to. Identifier nameIdentifier(exec, "name"); and so on. > + const String name; > + const String value; > + const String domain; > + const String path; > + const String expires; > + const bool httpOnly; > + const bool secure; > + const bool session; > + const unsigned size; Making all these data members const isn't really all that good an idea. If someone wants to use a Cookie in some non-const way, perhaps modifying one of these, then declaring it this way would get in the way, for no good reason. On the other hand, clients who don't want to modify a Cookie object get the same effect you got here by just saying "const Cookie". I'd leave off all the const on the individual members. > +void getRawCookies(const Document*, const KURL& url, Vector& rawCookies) > +{ > + rawCookies.clear(); > + BEGIN_BLOCK_OBJC_EXCEPTIONS; > + > + NSURL *cookieURL = url; > + NSArray *cookies = [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:cookieURL]; > + > + NSUInteger count = [cookies count]; For best memory use and performance, you will want to do this here: rawCookies.reserveCapacity(count); This allocates the memory for the vector rather than sizing it up each time you hit the limit while appending. It's faster and saves a bit on extra storage. Once you've done that change, it is then safe to use the slightly faster uncheckedAppend function below inside the loop instead of append. But even if you chose not to do uncheckedAppend, reserveCapacity is a good idea. > + for (NSUInteger i = 0; i < count; ++i) { > + NSHTTPCookie *cookie = (NSHTTPCookie *)[cookies objectAtIndex:i]; > + NSString *name = [cookie name]; > + NSString *value = [cookie value]; > + NSString *domain = [cookie domain]; > + NSString *path = [cookie path]; > + NSString *expires = [[cookie expiresDate] description]; > + bool httpOnly = [cookie isHTTPOnly]; > + bool secure = [cookie isSecure]; > + bool session = [cookie isSessionOnly]; > + Cookie cookieData = Cookie(name, value, domain, path, expires, httpOnly, secure, session); Again could use construction syntax here: Cookie cookieData(name, value, domain, path, expires, httpOnly, secure, session); > + rawCookies.append(cookieData); Or you could construct right in the append function call: rawCookies.uncheckedAppend(Cookie(name, value, domain, path, expires, httpOnly, secure, session)); Otherwise this looks really great. None of my comments are critical, so I'll say r=me on this version, but feel free to do a revised version if you like some of the things I propose above. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:52:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:52:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812055222.4DBF834BA1DE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED CC| |darin at apple.com AssignedTo|webkit-unassigned at lists.web |joepeck02 at gmail.com |kit.org | Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:53:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:53:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812055300.9A39B34BA202@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #4 from Darin Adler 2009-08-11 22:52:59 PDT --- This diagram shows DOMWindow between Frame and Document. But it's not really like that. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:54:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:54:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812055434.176CC34BA251@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #8 from Darin Adler 2009-08-11 22:54:33 PDT --- (From update of attachment 34637) Why not use inherits(&InternalFunction::info) instead of calling getCallData and then special-casing JSArray? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:56:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:56:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20732] -lws2_32 not -lWs2_32 In-Reply-To: References: Message-ID: <20090812055607.1396534BA299@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20732 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #1 from Brent Fulgham 2009-08-11 22:56:06 PDT --- The GTK builds no longer use cURL. The WinCairo link flags have the desired capitalization. I also double-checked the source archive and can't find any instances of -lWs2_32 anywhere, so I believe this issue has been resolved. Please reopen if you are still seeing this problem. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:56:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:56:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090812055634.CB70D34BA2B3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #12 from Eric Seidel 2009-08-11 22:56:33 PDT --- Yes, it's common the .js files get added to resources/ and not ignored in make-js-test-wrappers. That's why we're doing this! To make that problem go away. Once we have a separate directory for the script-tests then we won't need this silly ignore list. So yes, please feel encouraged to add those 4 files to the ignore list. You have my rubber-stamp already and do no need to post such a change for review. I might also add that further in my personal roadmap would be moving all of the js-test-pre.js stuff out of fast/js/resources and into a LayoutTests/script-tests-harness directory, or some other nicely-named top-level directory where we can put more of this testing framework in an easily accessible place. I would also like to add more support to make-js-test-wrappers, including some sort of template system. So that either via a comment in the script-test/my-test.js file or via a an otherwise-ignored template("name.html") call, that we can have custom templates on a per-file basis. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:56:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:56:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812055649.2DE6934BA2BD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 --- Comment #3 from Darin Adler 2009-08-11 22:56:48 PDT --- (From update of attachment 34638) Did you use "svn mv"? If not, why not? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:05:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:05:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812060500.62D1634BA361@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #9 from Oliver Hunt 2009-08-11 23:04:59 PDT --- (In reply to comment #8) > (From update of attachment 34637 [details]) > Why not use inherits(&InternalFunction::info) instead of calling getCallData > and then special-casing JSArray? The uses the IsCallable internal function -- inheriting from InternalFunction is not a sufficient check, but now i've tested firefox with a regex, /a/, they clearly are ignoring IsCallable *yay* -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:10:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:10:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812061039.A917F34BA41D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 --- Comment #4 from Shinichiro Hamaji 2009-08-11 23:10:39 PDT --- (In reply to comment #3) > (From update of attachment 34638 [details]) > Did you use "svn mv"? If not, why not? Ah, I'm using git and I used git mv and it seems to make the patch big. Is it better to use svn when we should rename files? Or, are there any equivalents in git world? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:13:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:13:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27656] REGRESSION: Clicking on popup menu changes layout In-Reply-To: References: Message-ID: <20090812061330.70D1834BA46B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27656 --- Comment #4 from Ton Voon 2009-08-11 23:13:29 PDT --- (In reply to comment #3) > It's focus, not clicking that is the issue; the focus ring is affecting layout. I don't think it is the focus ring (unless there is something happening in the background). If I add this to the CSS: input[type=text]:focus, input[type=password]:focus, textarea:focus, select:focus { outline: 0 none; } This removes the blue ring, but the layout still changes on click. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:16:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:16:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26715] bugzilla-tool should automate rollouts In-Reply-To: References: Message-ID: <20090812061606.5942734BA4B9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26715 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33930|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:16:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:16:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26715] bugzilla-tool should automate rollouts In-Reply-To: References: Message-ID: <20090812061615.1F6F334BA4D2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26715 --- Comment #11 from Eric Seidel 2009-08-11 23:16:13 PDT --- Created an attachment (id=34639) --> (https://bugs.webkit.org/attachment.cgi?id=34639) Updated to ToT --- 4 files changed, 123 insertions(+), 3 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:16:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:16:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090812061638.ED43134BA512@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Zoltan Herczeg changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34127|review+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:17:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:17:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090812061702.EEEA634BA546@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Zoltan Herczeg changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34128|review+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:23:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:23:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26755] bugzilla-tool's commit messages are lacking for patches with multiple ChangeLogs In-Reply-To: References: Message-ID: <20090812062334.BE0E534BA5E2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26755 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|eric at webkit.org |webkit-unassigned at lists.web | |kit.org --- Comment #6 from Eric Seidel 2009-08-11 23:23:33 PDT --- Ideally what will happen is we'll convert commit-log-editor to a python module and re-use it from within bugzilla-tool. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:31:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:31:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090812063104.9343134BA6AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34560|review? |review+ Flag| | --- Comment #100 from Gavin Barraclough 2009-08-11 23:30:58 PDT --- (From update of attachment 34560) > #define WTF_USE_CONSTANT_POOL 1 Gah, I'm really sorry, but I'm going to have to pick you up on an annoying technicality. We should not be defining WTF_USE_ macros outside of Platform.h (there is another example of this being done, but it's a bug. you'll see that ENABLE_, WTF_PLATFORM_, etc are only defined in Platform.h). The problem generally with defining these values in other headers is that the macros allow the value no to be defined, which could lead to unexpected behaviour. Consider, for example, if '#define ENABLE_JIT 1' was defined in JIT.h, rather than Platform.h. For any .cpp files that include JIT.h the expression 'ENABLE(JIT)' will be true, but for any files that happen not to include JIT.h this will evaluate to false. Whilst there is no bug in the way you've used this, or any clear way that it could lead to a bug in this case, I think we want to keep the design rule that the USE() etc marco are only used with values defined in Platform.h. The way that you've structured the macros (defining the value in AssemblerBufferWithConstantPool.h) seems perfectly sensible, so rather than trying to move this up into Platform.h I'd suggest you may just want to consider a quick rename & stop using the USE macro in this case - just switch '#define WTF_USE_CONSTANT_POOL 1' to something like '#define ASSEMBLER_HAS_CONSTANT_POOL 1' and replace 'USE(CONSTANT_POOL)' with 'defined(ASSEMBLER_HAS_CONSTANT_POOL)'. I'm going to call this an r+-with-changes, since everything else looks good. If you update a new patch with the macro name fixed one way or another I'll get it landed for you. BTW, I'm guessing this may be your intention already, but let's make this the last change on this ?ber-bug - from now on I think all future patch should get a bug of their own, as per normal process. cheers, G. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:34:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:34:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] New: Some HTMLs are modified by make-script-test-wrappers Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28213 Summary: Some HTMLs are modified by make-script-test-wrappers Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hamaji at chromium.org We should do either re-generate them or add them into exclude list in make-script-test-wrappers. I believe only fast/js/resources/const.js should be in the excluded list and other HTMLs should be re-generated. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:38:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:38:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812063833.9BE6134BA753@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34640| |review? Flag| | --- Comment #1 from Shinichiro Hamaji 2009-08-11 23:38:32 PDT --- Created an attachment (id=34640) --> (https://bugs.webkit.org/attachment.cgi?id=34640) Patch v1 --- 6 files changed, 28 insertions(+), 3 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:40:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:40:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812064023.3BDE234BA77A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 --- Comment #2 from Shinichiro Hamaji 2009-08-11 23:40:22 PDT --- (In reply to comment #1) > Created an attachment (id=34640) --> (https://bugs.webkit.org/attachment.cgi?id=34640) [details] Note that this patch is intended to be applied after Bug 28212. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:48:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:48:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27656] REGRESSION: Clicking on popup menu changes layout In-Reply-To: References: Message-ID: <20090812064817.B48E934BA82C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27656 --- Comment #5 from Ton Voon 2009-08-11 23:48:17 PDT --- A comment at doctype.com (http://doctype.com/questions/whats-best-way-overcome-safari-4-bug-css-tableless-form) suggests that a partial redraw could be occuring which is missing the
tag from the field prior to the popup. This appears to be correct when I run Quartz Debug. On Safari 3, the redraw flash appears over the previous text box, the popup and the button, whereas in webkit nightly, the redraw flashes for the popup and the button. It seems to me like the previous
tag is not considered for redrawing the layout on the popup click, hence missing the clear:left and the label floats are then aligned together. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 00:25:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 00:25:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090812072553.62E7634BABD3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gabor Loki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34560|0 |1 is obsolete| | Attachment #34641| |review? Flag| | --- Comment #101 from Gabor Loki 2009-08-12 00:25:49 PDT --- Created an attachment (id=34641) --> (https://bugs.webkit.org/attachment.cgi?id=34641) Add optimize call and property access support for ARM JIT v2 I have did the requested changes from comment #100 :-), and marked the attachment 34560 with obsolete flag which was r+-with-changes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 00:34:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 00:34:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28214] New: -webkit-box-shadow forces image to display at low resolution Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28214 Summary: -webkit-box-shadow forces image to display at low resolution Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: charles_ying at yahoo.com CC: simon.fraser at apple.com, cmarrin at apple.com Created an attachment (id=34642) --> (https://bugs.webkit.org/attachment.cgi?id=34642) test case and reduction In the following test reduction, having a -webkit-box-shadow on a DIV containing an image forces the image to stay at a lower resolution when zoomed in. To toggle the zoom, press the Space bar. The image in question is 300x300. The image is sized down to 50px and scaled up by a factor of 6. When the image does not have a box-shadow applied, the image shows at its native resolution of 300x300 when zoomed in. When the image has a box-shadow applied, the image shows at a pixellated 50x50 but bitmap scaled up, along with a pixellated box shadow. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 00:42:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 00:42:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28148] Requests through the SOUP layer leaks memory In-Reply-To: References: Message-ID: <20090812074246.BA2E134BAD8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28148 --- Comment #2 from John Kjellberg 2009-08-12 00:42:46 PDT --- As an additional note. Revision 41128 did not have this specific leak(but it did have the https://bugs.webkit.org/show_bug.cgi?id=26716 leak). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 01:00:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 01:00:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28146] Allow Inspector's Number.toString to print low-resolution values In-Reply-To: References: Message-ID: <20090812080025.7305834BAF8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28146 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |pfeldman at chromium.org Resolution| |FIXED --- Comment #4 from Pavel Feldman 2009-08-12 01:00:24 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/utilities.js Committed r47095 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 01:01:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 01:01:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090812080123.8669A34BAFA3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 --- Comment #5 from Simon Hausmann 2009-08-12 01:01:22 PDT --- I agree that this change a test, even an autotest would be sufficient. But more generally speaking I admit I don't like this solution: shortcutOverrideEvent is not a substitute for handling key events. Handling it means accepting or rejecting the event, but not processing the actual keys. That belongs into keyPressEvent. But with this patch it is just a matter of time until someone complains that their application shortcuts are overridden by web pages, and that's harder to control and we have to tell them to re-implement shortcutOverrideEvent? I would prefer to see Arora handle its shortcuts in a re-implementation of keyPressEvents. Another option might be to make QWebPage's behaviour of overriding all shortcuts configurable. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 01:55:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 01:55:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28076] fast/images/icon-decoding.html needs results for Qt In-Reply-To: References: Message-ID: <20090812085559.35FA434BB4FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28076 --- Comment #4 from Andras Becsi 2009-08-12 01:55:58 PDT --- Here is a patch for qt which corrects the layout test, but the imlementation should be changed higher up in QIcon and QPixmap. This is only an expected behaviour change, which is more compilant to the ICO file format description (http://www.daubnet.com/en/file-format-ico) which says: "For general purpose ICOs there should be at least one 32x32 image using the 16 Windows colors." diff --git a/src/plugins/imageformats/ico/qicohandler.cpp b/src/plugins/imageformats/ico/qicohandler.cpp index c9e04a4..77c68b7 100644 --- a/src/plugins/imageformats/ico/qicohandler.cpp +++ b/src/plugins/imageformats/ico/qicohandler.cpp @@ -802,7 +802,25 @@ bool QtIcoHandler::canRead(QIODevice *device) bool QtIcoHandler::read(QImage *image) { bool bSuccess = false; - QImage img = m_pICOReader->iconAt(m_currentIconIndex); + + QIODevice *d = device(); + + QList imgs = m_pICOReader->read(d); + QImage img = imgs[m_currentIconIndex]; + QSize requestedSize(32,32); + + if ( imgs.size() > 1 ){ + + // if we have multiple icons in the file we return the first with 32x32 resolution because it is the reference size + // FIXME: there should be a proper way of handling all the files in an ICO file higher up in the abstraction + // ie. to fill the caller QIcon with the icons in the ICO file automatically, and let the user decide which to use + for ( int i=0; i References: Message-ID: <20090812090022.74E8034BB597@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28174 Mikhail Naganov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34552|0 |1 is obsolete| | Attachment #34644| |review? Flag| | --- Comment #3 from Mikhail Naganov 2009-08-12 02:00:21 PDT --- Created an attachment (id=34644) --> (https://bugs.webkit.org/attachment.cgi?id=34644) Updated patch---comments addressed -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:02:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:02:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812090203.94F6C34BB5C7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34545|review- | Flag| | Attachment #34545|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:02:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:02:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812090209.B7B6D34BB5DE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34645| |review? Flag| | --- Comment #6 from Fumitoshi Ukai 2009-08-12 02:02:07 PDT --- Created an attachment (id=34645) --> (https://bugs.webkit.org/attachment.cgi?id=34645) Add SocketStreamHandle interface --- 13 files changed, 748 insertions(+), 1 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:03:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:03:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812090337.1C98534BB60A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 --- Comment #7 from Fumitoshi Ukai 2009-08-12 02:03:35 PDT --- Thanks for review. I believe I fixed all comments. Could you take a look again, please? Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:09:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:09:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812090940.24AFB34BB6B0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34645|review? | Flag| | Attachment #34645|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:09:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:09:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812090946.24CF534BB6C9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34646| |review? Flag| | --- Comment #8 from Fumitoshi Ukai 2009-08-12 02:09:44 PDT --- Created an attachment (id=34646) --> (https://bugs.webkit.org/attachment.cgi?id=34646) Add SocketStreamHandle interface --- 13 files changed, 748 insertions(+), 1 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:29:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:29:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812092909.0987D34BB890@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 --- Comment #2 from Hin-Chung Lam 2009-08-12 02:29:08 PDT --- Created an attachment (id=34647) --> (https://bugs.webkit.org/attachment.cgi?id=34647) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:29:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:29:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812092937.2D93934BB8A2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Hin-Chung Lam changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34647| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:33:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:33:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812093316.6D65334BB8F8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Hin-Chung Lam changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hclam at google.com --- Comment #3 from Hin-Chung Lam 2009-08-12 02:33:15 PDT --- The cause of the regression is that r46915 rejects non mouse actions and mouse actions not from left button. This logic caused trouble because it discards a lot of mouse move events during drag. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:35:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:35:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090812093534.22A4D34BB92C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 --- Comment #3 from Fumitoshi Ukai 2009-08-12 02:35:33 PDT --- (In reply to comment #2) > (From update of attachment 34548 [details]) > + $(WebCore)/websockets \ > $(WebCore)/svg \ > $(WebCore)/websockets \ > > It's already there. > > + WebCore/websockets/WebSocketRequest.cpp \ > + WebCore/websockets/WebSocketRequest.h \ > + WebCore/websockets/WebSocketResponse.cpp \ > + WebCore/websockets/WebSocketResponse.h > > This looks quite wrong - WebSocket does not use a request/response model, so > such class names are highly misguiding. Hmm, how about WebSocketClientHandshake and WebSocketServerHandshake? What name do you recommend? > > +#if ENABLE(WEB_SOCKETS) > +#include "JSWebSocket.h" > +#include "WebSocket.h" > > In some places, generated files are included without guards, and in others, > with guards. The guards are only needed if the headers are not generated in > ports that do not have this feature enabled - otherwise, similar guards within > headers themselves would do the job. > > There's never a need to protect e.g. WebSocket.h with external include guards. > > +bool IsValidProtocolString(const WebCore::String& protocol) > > This should be static, and inside the WebCore namespace. We don't normally use > anonymous namespaces. > > + // FIXME: need dispatchEvent? > > Absolutely - it will dispatch to handlers installed via addEventListener(), as > opposed to setting socket.onopen or similar. Should I add the implementation in this patch, or ok in another patch? > > +bool CheckWebSocketHandshake(const WebCore::WebSocketRequest &req, const > WebCore::WebSocketResponse& resp) > > Capitalization, argument naming, '&' positioning. This should also be static. > > There are many style issues in protocol implementation, I'm not pointing out > most, because they are the same as in other patches. > > + // FIXME: handle overflow. > > Please do! What is the good way to handle overflow? May I close the connection if too long length is detected? Do we need to set maximum length of m_buffer? (512KB or so?) > > +KURL WebSocketRequest::URLoverHTTP() const > > In WebKit style, this would be urlOverHTTP. I'm not sure what this is use for > though, hopefully an even better name can be found. > > + if (url().hasFragmentIdentifier()) { > + builder.append("#"); > + builder.append(url().fragmentIdentifier()); > + } > > What are fragment identifiers good for when using WebSockets? Seems that they > should be forbidden, or dropped immediately when passed in. Sure. > +const char* WebSocketResponse::parseHeader(const char* start, const char* end, > Vector >* headers) > > Are WebSockets headers case sensitive? Otherwise, it may be better to use > HTTPHeaderMap. Thanks for suggestion. > > I didn't closely review all the code; please fix style, possibly using > check-webkit-style script. The direction looks good to me, except for > request/response classes. I used check-webkit-style script, but it didn't catch some style issues. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:36:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:36:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090812093614.2865A34BB957@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Charles Wei changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34648| |review?(zimmermann at kde.org) Flag| | --- Comment #29 from Charles Wei 2009-08-12 02:36:11 PDT --- Created an attachment (id=34648) --> (https://bugs.webkit.org/attachment.cgi?id=34648) resubmit the patch to address comments This patch differes from the patch submitted on Aug 8 , 2009 is that : For the changes for RenderMarquee, it only applys when the WCSS and XHTMLMP are enabled, and the document is of XHTMLMP type, no impacts to the HTML documents. For the other comment from Niko to have a .css file to replace the hard-coded codes that initializes the marquee status with : *[display="-wap-marquee"] {overflow=...} Actually this doesn't work. The above universal selector works for something like display as an attribute like: There's no such an attribute for HTML/xHTML tags, actually the WCSS marquee is an extension to WCSS display and it works like this : So the universal selector *[display="-wap-marquee"] {...} doesn't work. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:38:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:38:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] New: [v8] Fix atomic string externalization crash Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28215 Summary: [v8] Fix atomic string externalization crash Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: christian.plesner.hansen at gmail.com Atomic string externalization assumes that all non-empty strings can be externalized which is untrue on 64-bit. This change fixed that. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:39:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:39:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812093956.4103E34BB9D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 Christian Plesner Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34649| |review? Flag| | --- Comment #1 from Christian Plesner Hansen 2009-08-12 02:39:55 PDT --- Created an attachment (id=34649) --> (https://bugs.webkit.org/attachment.cgi?id=34649) "Initial" -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 03:27:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 03:27:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28216] New: [CAIRO] getImageData fails on a given rect bigger than the image rect Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28216 Summary: [CAIRO] getImageData fails on a given rect bigger than the image rect Product: WebKit Version: 525.x (Safari 3.1) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: krit at webkit.org Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34650| |review? Flag| | Created an attachment (id=34650) --> (https://bugs.webkit.org/attachment.cgi?id=34650) Cairo fix of getImageData [CAIRO] getImageData fails on a given rect bigger than the image rect. I found this bug during my work on SVG feGaussianBlur. Currently only canvas could test it, but we don't allow the it there to make a bigger rect then the image rect. The problem is, that the destination image and source image were mixed up on creating the imageData. This patch just follows to the behavior of the other ports. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 03:33:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 03:33:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812103358.5E89234BBEE2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 --- Comment #5 from Dirk Schulze 2009-08-12 03:33:57 PDT --- landed in r47099. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 03:52:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 03:52:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812105251.6307634BC0CA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34651| |review? Flag| | --- Comment #6 from Dirk Schulze 2009-08-12 03:52:49 PDT --- Created an attachment (id=34651) --> (https://bugs.webkit.org/attachment.cgi?id=34651) premultiplied color support for Skia This is a untested suggestion for Skia. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 03:53:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 03:53:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812105328.B016A34BC0FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34365|review+ | Flag| | --- Comment #7 from Dirk Schulze 2009-08-12 03:53:27 PDT --- (From update of attachment 34365) clearing review flag. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:13:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:13:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28186] Web Inspector scope bar not quite right In-Reply-To: References: Message-ID: <20090812111347.7E74934BC30B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28186 Anthony Ricaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rik at webkit.org, | |webkit at mattlilek.com --- Comment #1 from Anthony Ricaud 2009-08-12 04:13:46 PDT --- I tried to find some resources to get it right but can't find them. I ended up using a demo that Matt Lillek gave me. No problem for tweaking the color, I just don't know the exact colors. If you have any pointer, I'll be glad to update that. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:14:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:14:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812111454.AE16734BC34F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 Christian Plesner Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34649|review? | Flag| | Attachment #34649|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:17:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:17:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812111754.13A1734BC4F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 Christian Plesner Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34652| |review? Flag| | --- Comment #2 from Christian Plesner Hansen 2009-08-12 04:15:00 PDT --- Created an attachment (id=34652) --> (https://bugs.webkit.org/attachment.cgi?id=34652) Tabs-fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:43:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:43:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812114316.5F7A134BC905@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33895|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:43:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:43:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812114353.A425D34BC923@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33941|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:47:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:47:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812114753.26CF434BC990@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34653| |review? Flag| | --- Comment #35 from Jakub Wieczorek 2009-08-12 04:47:50 PDT --- Created an attachment (id=34653) --> (https://bugs.webkit.org/attachment.cgi?id=34653) Remove the private classes from QWebPluginDatabase. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:49:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:49:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812114944.D058634BC9DD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34654| |review? Flag| | --- Comment #36 from Jakub Wieczorek 2009-08-12 04:49:43 PDT --- Created an attachment (id=34654) --> (https://bugs.webkit.org/attachment.cgi?id=34654) Optimize the QWebPluginInfo::supportsMimeType() function. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:51:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:51:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812115100.448A134BCA18@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34655| |review? Flag| | --- Comment #37 from Jakub Wieczorek 2009-08-12 04:50:59 PDT --- Created an attachment (id=34655) --> (https://bugs.webkit.org/attachment.cgi?id=34655) Optimize the QWebPluginInfo::mimeTypes() function. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:53:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:53:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812115345.099A934BCA86@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34656| |review? Flag| | --- Comment #38 from Jakub Wieczorek 2009-08-12 04:53:44 PDT --- Created an attachment (id=34656) --> (https://bugs.webkit.org/attachment.cgi?id=34656) Move the PluginDatabase::setPluginDirectories() function definition out of the header. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:54:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:54:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090812115449.85E1B34BCAA6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 Antonio Gomes (tonikitoo) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tonikitoo at gmail.com --- Comment #6 from Antonio Gomes (tonikitoo) 2009-08-12 04:54:48 PDT --- if i understood this bug correctly, I the path mozilla is taking to support this kind of situation: in bug https://bugzilla.mozilla.org/show_bug.cgi?id=448602 they implementing a way to verify if there is a default key listener for a given key (in this case control+s), but application could verify that before setting their own, avoiding conflicts in a safe way. we could consider implementing something similar in webkit ... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 05:01:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 05:01:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090812120141.DA17A34BCB73@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 Ariya Hidayat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34521|0 |1 is obsolete| | Attachment #34657| |review? Flag| | Status|UNCONFIRMED |NEW AssignedTo|webkit-unassigned at lists.web |ariya.hidayat at trolltech.com |kit.org | Ever Confirmed|0 |1 --- Comment #9 from Ariya Hidayat 2009-08-12 05:01:39 PDT --- Created an attachment (id=34657) --> (https://bugs.webkit.org/attachment.cgi?id=34657) Improved patch that also updates LayoutTest -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 05:44:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 05:44:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812124455.B376634BCFF3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34577|review+ | Flag| | --- Comment #9 from Adam Treat 2009-08-12 05:44:54 PDT --- (From update of attachment 34577) Clear flags as this has landed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:03:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:03:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812130338.1CF0134BD214@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34400|review? |review- Flag| | --- Comment #90 from Adam Treat 2009-08-12 06:03:32 PDT --- (From update of attachment 34400) ImageSource is no longer a forked file for each port. Rather, all ports that are use the built-in image decoders are moving to a cross-platform ImageSource.cpp file. Please refactor to use this new file and (only if necessary) add #if/#else for any behavior changes need by WINCE port for this file. See: https://bugs.webkit.org/show_bug.cgi?id=27965 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:13:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:13:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090812131356.5EAFE34BD391@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Nikolas Zimmermann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34648|review?(zimmermann at kde.org) |review+ Flag| | --- Comment #30 from Nikolas Zimmermann 2009-08-12 06:13:54 PDT --- (From update of attachment 34648) Hi Charles, patch looks great, along with your comments (regarding the impossiblity to not-hardcode the stuff.) One last question: > Index: WebCore/css/WCSSValueKeywords.in > =================================================================== > --- WebCore/css/WCSSValueKeywords.in (revision 0) > +++ WebCore/css/WCSSValueKeywords.in (revision 0) > @@ -0,0 +1 @@ > +# place holder for all WCSS specific CSS value keywords Do we need this file? I suspect you _may_ need it for the build process? If not, please remove this file completly, and reupload a patch, then I'll set "commit-queue +" as well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:28:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:28:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. In-Reply-To: References: Message-ID: <20090812132816.8DBEE34BD5AB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28181 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hausmann at webkit.org, | |laszlo.1.gombos at nokia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:32:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:32:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28208] Typo in FastMalloc.h causes build to fail In-Reply-To: References: Message-ID: <20090812133225.77D4134BD641@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28208 Thomas Fletcher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #2 from Thomas Fletcher 2009-08-12 06:32:24 PDT --- Sorry ... IE dropped the patch off for some reason. Looks like it is an irrelevant issue now though since it has been changed already in rev 47000. Sorry for the noise. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:39:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:39:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27051] Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled In-Reply-To: References: Message-ID: <20090812133907.821C634BD6EB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27051 Norbert Leser changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32410| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:57:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:57:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812135753.58B3234BD940@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 --- Comment #2 from Adam Treat 2009-08-12 06:57:52 PDT --- (From update of attachment 34598) > +Path& Path::operator=(const Path& other) > +{ > + m_path = new PlatformPath(*other.m_path); > + return *this; > +} Delete the possibly existing m_path unless &other == this? > +bool Path::hasCurrentPoint() const > +{ > + return !isEmpty(); > +} I see this is duplicated by most other ports, but not all. Perhaps it should be refactored and implemented in Path.cpp? Maybe after this goes in? About PathWince.cpp in general... I'm curious why you don't just implement methods here rather than breaking it out into another class: PlatformPathWince. Any reason or just following other ports example of having a 'native' PlatformPath type... Not a biggy, but one extra level of indirection that might not be necessary. > +// Implemented in GraphicsContextWince.cpp > +void getEllipsePointByAngle(double angle, double a, double b, float& x, float& y); > + ... > +static inline int stableRound(double d) > +{ > + if (d > 0) > + return static_cast(d + 0.5); > + > + int i = static_cast(d); > + return i - d > 0.5 ? i - 1 : i; > +} This is also implemented in GraphicsContextWince.cpp. Any reason this is duplicated here? I think this should probably be shared rather than copy&paste... > +static bool containsPoint(const FloatRect& r, const FloatPoint& p) > +{ > + return p.x() >= r.x() && p.y() >= r.y() && p.x() < r.right() && p.y() < r.bottom(); > +} This should be added to FloatRect. > +#define PI 3.14159265358979323846 This is a part of MathExtras.h. Please use that instead of duplicating. > +static void normalizeAngle(float& angle) > +{ > + while (angle < 0) > + angle += 2 * PI; > + while (angle >= 2 * PI) > + angle -= 2 * PI; > + if (angle < 0.00001) > + angle = 0; > +} This is used by addEllipse, but I'm not sure I understand. If the angles given are invalid, then why not just return or fix the calling site? > +// return 0-based value: 0 - first Quadrant ( 0 - 90 degree) > +static inline int quadrant(const PathPoint& point, const PathPoint& origPoint) > +{ > + return point.m_x < origPoint.m_x ? > + (point.m_y < origPoint.m_y ? 2 : 1) > + : (point.m_y < origPoint.m_y ? 3 : 0); > +} Heh, origin, originPoint, originalPoint? I think all three are better than 'origPoint' depending on context :) > +static void drawPolygons(HDC dc, const Vector& polygons, bool fill, const TransformationMatrix* tr) tr should be matrix or transform. Keep the variable names well named. > + MemoryAllocationCanFail canFail; Will this compile? > +void PlatformPathElement::inflateRectToContainMe(FloatRect& r, const FloatPoint& lastPoint) const Cute :) > +PlatformPath::PlatformPath() > +: m_penLifted(true) Indentation. > + // FIXME: magic number? > + quadCurve(50, m_subpaths.last(), control); What does this mean? > +} > + > + Extra space. > +#ifndef PlatformPathWince_h > +#define PlatformPathWince_h No includes? How does this work? Only forward declaration is GraphicsContext, but you are using lots more WebCore classes... General thoughts: There are some style issues and minor nitpicks, but not very many. I'm not concerned about them as much as I'd like the questions above figured out. I would also like to know if you've run this code with the relevant LayoutTests and what the results were. You mention in the ChangeLog that this could become cross-platform code for ports which do not have any native version of this functionality. That is possible, but only if the code is refactored and probably broken out into one class per file as well as aggressive layout tests confirm. Finally, the diff looks corrupted: see top of patch file. r- mostly for the above questions. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:58:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:58:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812135835.8A67434BD972@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34598|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:03:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:03:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28148] Requests through the SOUP layer leaks memory In-Reply-To: References: Message-ID: <20090812140358.6292034BDA50@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28148 Priit Laes (IRC: plaes) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amd at store20.com --- Comment #3 from Priit Laes (IRC: plaes) 2009-08-12 07:03:57 PDT --- (In reply to comment #0) > Created an attachment (id=34451) --> (https://bugs.webkit.org/attachment.cgi?id=34451) [details] > Code making one XMLHttpRequest every 0.1s > > The attached test case makes one XMLHttpRequest() call each 0.1s. As times goes > by it uses more and more memory. This will most likely also affect any type of > HTTP request made. > > I have found a code change that will stop the leak. However, that isn't really > a solution, but it might be a hint to someone that knows the code better. I > based the change on how it worked in earlier revisions of the code that didn't > have this leak. > (Why the "m_isWebSecurityEnabled" change is needed I have no idea. Only found > it by a lucky coincident) Hmm.. this is actually causing crash when closing the page after a few requests... :S -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:12:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:12:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28148] Requests through the SOUP layer leaks memory In-Reply-To: References: Message-ID: <20090812141237.7E19434BDB58@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28148 --- Comment #4 from John Kjellberg 2009-08-12 07:12:37 PDT --- (In reply to comment #3) > (In reply to comment #0) > > Created an attachment (id=34451) --> (https://bugs.webkit.org/attachment.cgi?id=34451) [details] [details] > > Code making one XMLHttpRequest every 0.1s > > > > The attached test case makes one XMLHttpRequest() call each 0.1s. As times goes > > by it uses more and more memory. This will most likely also affect any type of > > HTTP request made. > > > > I have found a code change that will stop the leak. However, that isn't really > > a solution, but it might be a hint to someone that knows the code better. I > > based the change on how it worked in earlier revisions of the code that didn't > > have this leak. > > (Why the "m_isWebSecurityEnabled" change is needed I have no idea. Only found > > it by a lucky coincident) > > Hmm.. this is actually causing crash when closing the page after a few > requests... :S That's interesting. I have been running it for quite long time and then closed the whole GtkLauncher window without any indication of a crash. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:14:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:14:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812141411.64E6534BDBA2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 --- Comment #5 from Adam Barth 2009-08-12 07:14:10 PDT --- (In reply to comment #4) > This diagram shows DOMWindow between Frame and Document. But it's not really > like that. Ok. I'll see what I can do to fix that. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:16:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:16:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28204] Not possible to build WebCore+V8 with -fno-exceptions on Mac In-Reply-To: References: Message-ID: <20090812141647.A122934BDC0C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28204 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abarth at webkit.org AssignedTo|mark at chromium.org |webkit-unassigned at lists.web | |kit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:25:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:25:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26409] [GTK] Glitches in new progress/load-status system In-Reply-To: References: Message-ID: <20090812142533.5062A34BDD49@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26409 Benjamin Otte changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |otte at gnome.org --- Comment #9 from Benjamin Otte 2009-08-12 07:25:32 PDT --- (In reply to comment #0) > - A weird 10% progress is reported for pages before the status even reaches > PROVISIONAL. Not sure where this comes from, but it should either go away or > come after PROVISIONAL or COMMITTED I think. > This is wanted behavior. See WebCore/loader/ProgressTracker.cpp. The current implementation clamps progress values to always be inside [0.1, 0.9] during an active load, so that you can actually see that something is happening. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:30:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:30:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812143046.A709834BDDD7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 --- Comment #3 from Yong Li 2009-08-12 07:30:45 PDT --- (In reply to comment #2) > (From update of attachment 34598 [details]) > > +Path& Path::operator=(const Path& other) > > +{ > > + m_path = new PlatformPath(*other.m_path); > > + return *this; > > +} > > Delete the possibly existing m_path unless &other == this? > I think you've found a bug here. Thanks! :) > > +bool Path::hasCurrentPoint() const > > +{ > > + return !isEmpty(); > > +} > > I see this is duplicated by most other ports, but not all. Perhaps it should > be refactored and implemented in Path.cpp? Maybe after this goes in? No. There's at least one port that does differently. That's why this method was introduced. And I'm not sure !isEmpty() is absolutely correct. There have been some discussions on this thing. I forgot the bug number. At the meantime, I just do this as most ports do, because I haven't got a better idea. Keeping an eye on other ports... :) > > About PathWince.cpp in general... I'm curious why you don't just implement > methods here rather than breaking it out into another class: PlatformPathWince. > Any reason or just following other ports example of having a 'native' > PlatformPath type... Not a biggy, but one extra level of indirection that > might not be necessary. I could do that. But then I would have to add a lot of members into Path.h with #if PLATFORM(WINCE), which may be harder to get r+ :) > > > +// Implemented in GraphicsContextWince.cpp > > +void getEllipsePointByAngle(double angle, double a, double b, float& x, float& y); > > + > ... > > +static inline int stableRound(double d) > > +{ > > + if (d > 0) > > + return static_cast(d + 0.5); > > + > > + int i = static_cast(d); > > + return i - d > 0.5 ? i - 1 : i; > > +} > > This is also implemented in GraphicsContextWince.cpp. Any reason this is > duplicated here? I think this should probably be shared rather than > copy&paste... Yeah... This stableRound is defined in many files. Not sure if it's a good idea to add it into MathExtra.h. The differences between stableRound() and lround() is: 1) stableRound() rounds -0.5 to 0, where lround() round -0.5 to -1. Consider the case that the transformation has a shift -1, and 0.5 changes to -0.5. With lround, the rounded value 1 changes to -1, so that the rounded shift is -2. Probably the name should be changed to lowerRound() or leftRound(). 2) stableRound() doesn't call other function like ceil() where lround() does Can we do this later? Because some landed file like GraphicsContextWince.cpp needs to be changed, too. This patch just contains new source files, and doesn't include the changes to any existing file. > > > +static bool containsPoint(const FloatRect& r, const FloatPoint& p) > > +{ > > + return p.x() >= r.x() && p.y() >= r.y() && p.x() < r.right() && p.y() < r.bottom(); > > +} > > This should be added to FloatRect. Agree with this. but can we do this later? > > > +#define PI 3.14159265358979323846 > > This is a part of MathExtras.h. Please use that instead of duplicating. Agree. > > > +static void normalizeAngle(float& angle) > > +{ > > + while (angle < 0) > > + angle += 2 * PI; > > + while (angle >= 2 * PI) > > + angle -= 2 * PI; > > + if (angle < 0.00001) > > + angle = 0; > > +} > > This is used by addEllipse, but I'm not sure I understand. If the angles given > are invalid, then why not just return or fix the calling site? Don't know if an angle bigger than 2*PI is valid or invalid. I think it should still be handled. > > + > > Extra space. > > > +#ifndef PlatformPathWince_h > > +#define PlatformPathWince_h > > No includes? How does this work? Only forward declaration is GraphicsContext, > but you are using lots more WebCore classes... > Yeah, I'll add some header files like FloatPoint.h -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:33:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:33:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812143354.26F2734BDE45@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 --- Comment #18 from steveblock at google.com 2009-08-12 07:33:52 PDT --- > This is missing new results and cannot be landed by the commit-queue. The patch includes expected results for GTK at LayoutTests/platform/gtk/fast/dom/Geolocation/enabled-expected.txt. Perhaps I misinterpreted your earlier comment ... > It's the individual platforms responsibility to manage their skipped lists and > turn on/off tests accordingly. > > I thikn it's also OK to have a "is geolocation enabled" test, expect enabled, > and check in "PASS" results on the platforms which have it, and skip it on all > other platforms. Did you mean that it's the platform's responsibility for all platforms other than mac? Should I add a 'fail' result for mac or add this test to the mac skipped list? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:51:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:51:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090812145142.21DEC34BE087@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 --- Comment #16 from Laszlo Gombos 2009-08-12 07:51:40 PDT --- (In reply to comment #15) > (From update of attachment 34538 [details]) > > + // Set HTML5 Application Cache default location > > + QWebSettings::setOfflineWebApplicationCachePath(defaultCachePath()); > I think we want to append /ApplicationCache or so. > Simon, how do we hide the deprecated methods from the docs? Kenneth, I'd like to keep this patch focused on LocalStorage. I would prefer to create a separate patch for the HTML5 Application Cache changes (which I plan to do). My proposal for deprecating follows Qt conventions I belive (see for example http://qt.gitorious.org/+qt-s60-developers/qt/qt-s60/blobs/master/src/gui/dialogs/qfiledialog.h ) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:08:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:08:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090812150833.AD64D34BE2B6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 --- Comment #7 from Benjamin Meyer 2009-08-12 08:08:32 PDT --- Some more notes from looking things up: The documentation for ShortcutOverride is very slim and I am not exactly sure how it is suppose to be used, when it is called, or if this is even the Qt way to handle this bug. Looking through Qt's source it looked like when a widget overrides a global shortcut (like many do such as QLineEdit, QComboBox etc) they should handle this event saying that they should eat the keyevent and not allow a shortcut to. Is this correct? If we could know that there is a listener for a key without having to actually pass a key event then we could accept the event on ShortcutOverride without having to send the key event. This seems like the correct approach to solving this. Tested Safari and it behaves as expected; ctrl+s doesn't do Save As, but passes it to the DOM and GoogleDocs so there might be some code in WebKit already to handle this. Simon, you mentioned that Arora could handle its shortcuts in a re-implementation of keyPressEvents. To do this were you thinking to overload ShortcutOverrideEvent, always accept the event and then in the KeyPressEvent if the key isn't accepted walk up the parent tree find all QShortcut children, and test their QKeySequence if it matches call that shortcut and return? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:20:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:20:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812152046.85E7D34BF16F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |kenneth.christiansen at openbo | |ssa.org Resolution|FIXED | --- Comment #3 from Kenneth Rohde Christiansen 2009-08-12 08:20:45 PDT --- Hi there, You commit https://trac.webkit.org/changeset/47089 JavaScriptCore: Restrict use of FuncDeclNode & FuncExprNode to the parser. https://bugs.webkit.org/show_bug.cgi?id=28209 seems to break the fast/js tests for Qt 64bit linux. The tests breaking are: fast/js/const.html expected fast/js/exception-thrown-from-function-with-lazy-activation.html fast/js/function-call-register-allocation.html fast/js/function-dot-arguments-and-caller.html fast/js/named-function-expression.html fast/js/static-scope-object.html plugins/netscape-invoke-default.html Cheers, Kenneth -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:37:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:37:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812153739.08A1A34C0300@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34647|review? |review- Flag| | --- Comment #4 from Simon Fraser (smfr) 2009-08-12 08:37:37 PDT --- (From update of attachment 34647) Patch looks reasonable but you can make a testcase; in DumpRenderTree, there is an eventSender API that you can use to synthesize mouse events. I think it's important to add a testcase so that this doesn't regress again. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:38:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:38:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812153832.202C734C0342@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34612|review? |review- Flag| | --- Comment #20 from Dimitri Glazkov (Google) 2009-08-12 08:38:28 PDT --- (From update of attachment 34612) >From the style patrol: Needs a ChangeLog entry. > +void RenderThemeChromiumMac::updateActiveState(NSCell* cell, const RenderObject* o) { Opening brace on new line. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:40:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:40:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28214] -webkit-box-shadow forces image to display at low resolution In-Reply-To: References: Message-ID: <20090812154053.0419234C038D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28214 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |simon.fraser at apple.com |kit.org | --- Comment #1 from Simon Fraser (smfr) 2009-08-12 08:40:52 PDT --- Any box decoration on the image seems to cause this (e.g. border). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:44:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:44:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812154425.42D4034C0418@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34598|0 |1 is obsolete| | Attachment #34662| |review? Flag| | --- Comment #4 from Yong Li 2009-08-12 08:44:24 PDT --- Created an attachment (id=34662) --> (https://bugs.webkit.org/attachment.cgi?id=34662) refactored modified according to Adam's suggestions. stableRound() is separated out to WinceGraphicsExtras.h Afterward, we'll let other files that define stableRound() by themself use this header file. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:44:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:44:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28126] [Haiku] Adding SharedTimer to WebCore. In-Reply-To: References: Message-ID: <20090812154426.E4AC734C0427@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28126 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34412|0 |1 is obsolete| | Attachment #34663| |review? Flag| | --- Comment #5 from Maxime Simon 2009-08-12 08:44:25 PDT --- Created an attachment (id=34663) --> (https://bugs.webkit.org/attachment.cgi?id=34663) Patch to add the SharedTimer file for Haiku. I still used a BMessageFilter, but as static variable. We now use the generic SharedTimer. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:46:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:46:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090812154638.78A0E34C046D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 --- Comment #6 from Dave Hyatt 2009-08-12 08:46:37 PDT --- (From update of attachment 34618) You are sure that other types of replaced elements aren't going to crash without a parent null check somewhere? I'd recommend browsing in a zoomed window for a bit to make sure. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:48:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:48:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812154813.F187D34C04AD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34652|review? |review+ Flag| | --- Comment #3 from Dimitri Glazkov (Google) 2009-08-12 08:48:13 PDT --- (From update of attachment 34652) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:48:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:48:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812154858.A18EE34C04E0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Viet-Trung Luu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34612|0 |1 is obsolete| | Attachment #34664| |review? Flag| | --- Comment #21 from Viet-Trung Luu 2009-08-12 08:48:55 PDT --- Created an attachment (id=34664) --> (https://bugs.webkit.org/attachment.cgi?id=34664) Changelog entry back, style fix. Ack! -- the directory from which you run svn-create-patch actually matters. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:50:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:50:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812155029.48F4B34C0535@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Viet-Trung Luu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34664|review? |review?(dglazkov at chromium.o Flag| |rg) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:53:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:53:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812155348.F3A6D34C05E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34662|review? |review+ Flag| | --- Comment #5 from Adam Treat 2009-08-12 08:53:48 PDT --- (From update of attachment 34662) Ok, please file a bug and patch for moving 'containsPoint' into FloatRect after this lands. Thanks! Otherwise, LGTM. r+ :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:54:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:54:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812155409.198B534C0604@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |dglazkov at chromium.org Resolution| |FIXED --- Comment #4 from Dimitri Glazkov (Google) 2009-08-12 08:54:08 PDT --- Landed as http://trac.webkit.org/changeset/47106. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:57:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:57:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090812155724.EF81D34C064A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 --- Comment #7 from George Wright 2009-08-12 08:57:24 PDT --- (In reply to comment #6) > (From update of attachment 34618 [details]) > You are sure that other types of replaced elements aren't going to crash > without a parent null check somewhere? I'd recommend browsing in a zoomed > window for a bit to make sure. Seems fine here. I tested it with images and media (from http://webkit.org/blog/140/html5-media-support/) and it didn't crash when zoomed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:59:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:59:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812155907.58FD434C06C2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34664|review?(dglazkov at chromium.o |review+ Flag|rg) | --- Comment #22 from Dimitri Glazkov (Google) 2009-08-12 08:59:01 PDT --- (From update of attachment 34664) r=me, based on Mac-ies' comments above. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:01:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:01:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812160114.413A934C0746@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 --- Comment #23 from Dimitri Glazkov (Google) 2009-08-12 09:01:10 PDT --- (From update of attachment 34664) r=me, based on Mac-ies' comments above. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:01:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:01:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812160137.4B3EB34C0770@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #24 from Dimitri Glazkov (Google) 2009-08-12 09:01:34 PDT --- Landed as http://trac.webkit.org/changeset/47108. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:07:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:07:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14997] Support for server-sent DOM events In-Reply-To: References: Message-ID: <20090812160710.2279734C0837@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14997 Adam Bergkvist changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34139|0 |1 is obsolete| | Attachment #34665| |review? Flag| | --- Comment #33 from Adam Bergkvist 2009-08-12 09:07:03 PDT --- Created an attachment (id=34665) --> (https://bugs.webkit.org/attachment.cgi?id=34665) updated patch Thank you for the quick review and sorry for not noticing the recent addition of the DOMConstructorObject class. Here is an updated patch that also adds EventSource to the mac and win builds (untested). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:08:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:08:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812160845.CF48134C0871@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 --- Comment #19 from Eric Seidel 2009-08-12 09:08:44 PDT --- The commit-queue runs from a mac. Should these results be the same for all platforms? If so, then they should be placed right next to the original test and platforms which want to check in platform-specific failing results can do so. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:11:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:11:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] REGRESSION: run-webkit-tests --quiet hangs In-Reply-To: References: Message-ID: <20090812161145.5F1E434C08E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|run-webkit-tests --quiet |REGRESSION: |hangs |run-webkit-tests --quiet | |hangs --- Comment #3 from Eric Seidel 2009-08-12 09:11:44 PDT --- I'm going to check this in w/o review to fix the regression that --quiet now hangs. (Alternatively I could roll out my other patch which caused it to hang.) If anyone has suggestions as to how I should improve this code, I'm happy to change it further. This code is specifically trying to avoid turning the args array back into a string. Perl doesn't seem to have an elegant way to deal with an args array *and* route stderr to /dev/null. Another way I could handle this would be to override the parent's stdout/stderr before running the normal "system" call. But that's also pretty nasty (although slightly less code). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:15:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:15:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812161552.6AC2334C0941@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 --- Comment #20 from steveblock at google.com 2009-08-12 09:15:51 PDT --- > The commit-queue runs from a mac. Should these results be the same for all > platforms? The 'pass' results should be the same for all platforms that support Geolocation. Currently, this is only GTK. On platforms that don't support Geolocation (which includes mac), all tests will fail. Should I add 'failed' results to LayoutTests/fast/dom/ and 'pass' results to LayoutTests/platform/gtk/fast/dom/Geolocation/? Or should I add the 'pass' results to LayoutTests/fast/dom/ and add 'failed' results to LayoutTests/platform/mac/fast/dom/Geolocation/ to keep the build happy? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:17:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:17:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] REGRESSION: run-webkit-tests --quiet hangs In-Reply-To: References: Message-ID: <20090812161729.4F44E34C0975@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Eric Seidel 2009-08-12 09:17:28 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests Committed r47109 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests r47109 = 86eae88a818613b99c22db8d9631abf4c36eca43 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47109 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:17:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:17:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] REGRESSION: run-webkit-tests --quiet hangs In-Reply-To: References: Message-ID: <20090812161737.3DF7034C09A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34614|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:18:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:18:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812161837.45B7234C09C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 --- Comment #21 from Eric Seidel 2009-08-12 09:18:36 PDT --- The failure case seems uninteresting. I would checkin the results next to the tests, and edit the skipped lists of all platforms you expect to fail. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:19:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:19:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812161932.94ED534C09FA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34662|0 |1 is obsolete| | Attachment #34666| |review? Flag| | --- Comment #6 from Yong Li 2009-08-12 09:19:31 PDT --- Created an attachment (id=34666) --> (https://bugs.webkit.org/attachment.cgi?id=34666) fix a bug in last patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:22:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:22:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] bugzilla-tool : various improvements for running the commit-queue In-Reply-To: References: Message-ID: <20090812162216.29DFD34C0AC2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28199 --- Comment #4 from Eric Seidel 2009-08-12 09:22:15 PDT --- Thanks. FIxed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:26:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:26:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] bugzilla-tool : various improvements for running the commit-queue In-Reply-To: References: Message-ID: <20090812162627.BDC9D34C0B6C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28199 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Eric Seidel 2009-08-12 09:26:26 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/bugzilla.py M WebKitTools/Scripts/modules/scm.py Committed r47111 M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py M WebKitTools/Scripts/modules/scm.py M WebKitTools/Scripts/bugzilla-tool r47111 = 431ef60608c95da88d3bc13bae5b7663484f029f (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47111 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:29:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:29:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812162915.3B0DE34C0BD2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34602|review? |review- Flag| | --- Comment #49 from George Staikos 2009-08-12 09:29:13 PDT --- (From update of attachment 34602) I think standard for your for(;;) is really to do: do { } while (0); Best to change to that and then your comment isn't necessary. Also you have a double semicolon in your first if (). Those minor fixes and the rest is fine with me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:33:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:33:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812163342.5EF1634C0C66@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #50 from Darin Adler 2009-08-12 09:33:40 PDT --- (In reply to comment #49) > I think standard for your for(;;) is really to do: > > do { > } while (0); for(;;) is an infinite loop. The above is not an infinite loop, it's a one time loop, so it can't be used. For infinite loops, the most common pattern in WebKit is while (true). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:34:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:34:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090812163451.0060634C0C8C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #4 from Alexey Proskuryakov 2009-08-12 09:34:49 PDT --- > Hmm, how about WebSocketClientHandshake and WebSocketServerHandshake? > What name do you recommend? That's less misleading. I was thinking of having a single class to handle handshake, not a pair of classes, but I didn't fully think it through, so it may be a bad idea. > > + // FIXME: need dispatchEvent? > > Should I add the implementation in this patch, or ok in another patch? I think it would be easiest to do it now, while this incomplete code is clearly visible in a patch - hunting it down in trunk will be more difficult. Please also make a test for addEventListener-installed listeners (as usual, to be landed once the code becomes functional). > What is the good way to handle overflow? > May I close the connection if too long length is detected? Sounds good to me. We probably want to log something to console in this case (and in other error cases that can occur in WebSocket lifetime). > Do we need to set maximum length of m_buffer? (512KB or so?) It would probably be nice to use tryFastMalloc (to close the connection instead of crashing if the server sends too large frame). If we were to add an artificial limit on received frame size, I think that it should be impractically huge, dozens of megabytes on desktop platforms - all we want is to prevent crashing the browser with an incorrect frame size, right? This doesn't seem like something that could happen during normal operation, it's just a protection from server bugs, and it makes DoS'ing the browser via WebSocket protocol more difficult. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:35:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:35:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28148] Requests through the SOUP layer leaks memory In-Reply-To: References: Message-ID: <20090812163529.A24ED34C0CC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28148 --- Comment #5 from Priit Laes (IRC: plaes) 2009-08-12 09:35:28 PDT --- This happens in epiphany when I have at least two tabs open. 1) open the example code in another tab ie. by clicking the middle button. 2) close the tab 3) Wait for crash PS. And sorry for hijacking your bug report ;) Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7f561a467760 (LWP 13232)] 0x00007f5618735d99 in WebCore::FrameLoader::loadResourceSynchronously (this=0x7f560115b850, request=, storedCredentials=WebCore::AllowStoredCredentials, error=@0x7fff47a2f930, response=@0x7fff47a2f870, data=@0x7fff47a2f960) at WebCore/loader/FrameLoader.cpp:3728 3728 documentLoader()->applicationCacheHost()->maybeLoadFallbackSynchronously(newRequest, error, response, data); (gdb) bt #0 0x00007f5618735d99 in WebCore::FrameLoader::loadResourceSynchronously (this=0x7f560115b850, request=, storedCredentials=WebCore::AllowStoredCredentials, error=@0x7fff47a2f930, response=@0x7fff47a2f870, data=@0x7fff47a2f960) at WebCore/loader/FrameLoader.cpp:3728 #1 0x00007f5618719890 in WebCore::DocumentThreadableLoader::loadResourceSynchronously (document=0x7f560110f800, request=@0x7fff47a2f9f0, client=@0x7f5601087d90, storedCredentials=WebCore::AllowStoredCredentials) at WebCore/loader/DocumentThreadableLoader.cpp:55 #2 0x00007f56188d19ea in WebCore::XMLHttpRequest::loadRequestSynchronously (this=0x7f5601087d80, request=@0x7fff47a2f9f0, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:663 #3 0x00007f56188d4e1d in WebCore::XMLHttpRequest::makeSameOriginRequest (this=0x7f5601087d80, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:510 #4 0x00007f56188d7c33 in WebCore::XMLHttpRequest::send (this=0x7f5601087d80, body=@0x7fff47a2fbb0, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:446 #5 0x00007f56188d7e0b in WebCore::XMLHttpRequest::send (this=0x7f560cfc2e60, ec=@0x0) at WebCore/xml/XMLHttpRequest.cpp:389 #6 0x00007f56184fbda6 in WebCore::JSXMLHttpRequest::send (this=0x7f5600ec7600, exec=0x7f56012900a0, args=@0x7fff47a2f930) at WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:125 #7 0x00007f5618bab0d2 in WebCore::jsXMLHttpRequestPrototypeFunctionSend (exec=0x7f56012900a0, thisValue={m_ptr = 0x7f5600ec7600}, args=@0x7fff47a2fc80) at DerivedSources/JSXMLHttpRequest.cpp:373 #8 0x00007f561a5a21d4 in ?? () #9 0x00007f5601290058 in ?? () #10 0x0000000000000001 in ?? () #11 0x000000000188fac4 in ?? () #12 0x00007f5600ec9cc0 in ?? () #13 0x00007f560107cb20 in ?? () #14 0x0000000000000000 in ?? () (gdb) bt full #0 0x00007f5618735d99 in WebCore::FrameLoader::loadResourceSynchronously (this=0x7f560115b850, request=, storedCredentials=WebCore::AllowStoredCredentials, error=@0x7fff47a2f930, response=@0x7fff47a2f870, data=@0x7fff47a2f960) at WebCore/loader/FrameLoader.cpp:3728 referrer = {m_impl = { = {}, m_ptr = 0x7f56010fdea0}} initialRequest = { = {m_url = {m_string = {m_impl = { = {}, m_ptr = 0x7f5600f37380}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 36, m_queryEnd = 36, m_fragmentEnd = 36}, m_cachePolicy = WebCore::UseProtocolCachePolicy, m_timeoutInterval = 10, m_firstPartyForCookies = {m_string = {m_impl = { = {}, m_ptr = 0x7f5601206a28}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 38, m_queryEnd = 47, m_fragmentEnd = 47}, m_httpMethod = {m_impl = { = {}, m_ptr = 0x7f5602740000}}, m_httpHeaderFields = {, WTF::HashTraits >> = { = {}, m_impl = {static m_minTableSize = 64, static m_maxLoad = , static m_minLoad = 6, m_table = 0x7f56010c4400, m_tableSize = 64, m_tableSizeMask = 63, m_keyCount = 2, m_deletedCount = 0}}, }, m_responseContentDispositionEncodingFallbackArray = { = {}, m_size = 0, m_buffer = {> = { = { = {}, }, m_buffer = 0x7f560112c320, m_capacity = 0}, }}, m_httpBody = { = {}, m_ptr = 0x0}, m_allowHTTPCookies = true, m_resourceRequestUpdated = true, m_platformRequestUpdated = false, m_reportUploadProgress = false}, } identifier = 11 newRequest = { = {m_url = {m_string = {m_impl = { = {}, m_ptr = 0x7f5600f37380}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 36, m_queryEnd = 36, m_fragmentEnd = 36}, m_cachePolicy = WebCore::UseProtocolCachePolicy, m_timeoutInterval = 10, m_firstPartyForCookies = {m_string = {m_impl = { = {}, m_ptr = 0x7f5601206a28}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 38, m_queryEnd = 47, m_fragmentEnd = 47}, m_httpMethod = {m_impl = { = {}, m_ptr = 0x7f5602740000}}, m_httpHeaderFields = {, WTF::HashTraits >> = { = {}, m_impl = {static m_minTableSize = 64, static m_maxLoad = , static m_minLoad = 6, m_table = 0x7f56011c6800, m_tableSize = 64, m_tableSizeMask = 63, m_keyCount = 2, m_deletedCount = 0}}, }, m_responseContentDispositionEncodingFallbackArray = { = {}, m_size = 0, m_buffer = {> = { = { = {}, }, m_buffer = 0x7f560112c1c8, m_capacity = 0}, }}, m_httpBody = { = {}, m_ptr = 0x0}, m_allowHTTPCookies = true, m_resourceRequestUpdated = true, m_platformRequestUpdated = false, m_reportUploadProgress = false}, } #1 0x00007f5618719890 in WebCore::DocumentThreadableLoader::loadResourceSynchronously (document=0x7f560110f800, request=@0x7fff47a2f9f0, client=@0x7f5601087d90, storedCredentials=WebCore::AllowStoredCredentials) at WebCore/loader/DocumentThreadableLoader.cpp:55 sameOriginRequest = true data = { = {}, m_size = 210, m_buffer = {> = { = { = {}, }, m_buffer = 0x7f56010f3460 "\n\n404 Not Found\n\n

Not Found

\n

The requested URL /mem_test.htm was not found on this server.

\n}} error = { = {m_domain = {m_impl = { = {}, m_ptr = 0x0}}, m_errorCode = 0, m_failingURL = { m_impl = { = {}, m_ptr = 0x0}}, m_localizedDescription = {m_impl = { = {}, m_ptr = 0x0}}, m_isNull = true, m_isCancellation = false}, } response = { = {m_url = {m_string = {m_impl = { = {}, m_ptr = 0x7f5600f37460}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 36, m_queryEnd = 36, m_fragmentEnd = 36}, m_mimeType = {m_impl = { = {}, m_ptr = 0x7f5601249cc0}}, m_expectedContentLength = 210, m_textEncodingName = {m_impl = { = {}, m_ptr = 0x7f5601250580}}, m_suggestedFilename = {m_impl = { = {}, m_ptr = 0x0}}, m_httpStatusCode = 404, m_httpStatusText = {m_impl = { = {}, m_ptr = 0x7f5601249c80}}, m_httpHeaderFields = {, WTF::HashTraits >> = { = {}, m_impl = {static m_minTableSize = 64, static m_maxLoad = , static m_minLoad = 6, m_table = 0x7f56010a9400, m_tableSize = 64, m_tableSizeMask = 63, m_keyCount = 6, m_deletedCount = 0}}, }, m_lastModifiedDate = 0, m_isNull = false, m_haveParsedCacheControlHeader = false, m_haveParsedAgeHeader = false, m_haveParsedDateHeader = false, m_haveParsedExpiresHeader = false, m_haveParsedLastModifiedHeader = false, m_cacheControlContainsNoCache = false, m_cacheControlContainsNoStore = false, m_cacheControlContainsMustRevalidate = false, m_cacheControlMaxAge = 0, m_age = 0, m_date = 0, m_expires = 0, m_lastModified = 0}, } identifier = 18446744073709551615 #2 0x00007f56188d19ea in WebCore::XMLHttpRequest::loadRequestSynchronously (this=0x7f5601087d80, request=@0x7fff47a2f9f0, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:663 No locals. #3 0x00007f56188d4e1d in WebCore::XMLHttpRequest::makeSameOriginRequest (this=0x7f5601087d80, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:510 request = { = {m_url = {m_string = {m_impl = { = {}, m_ptr = 0x7f5600f37380}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 36, m_queryEnd = 36, m_fragmentEnd = 36}, m_cachePolicy = WebCore::UseProtocolCachePolicy, m_timeoutInterval = 2147483647, m_firstPartyForCookies = {m_string = {m_impl = { = {}, m_ptr = 0x0}}, m_isValid = false, m_protocolInHTTPFamily = false, m_schemeEnd = 0, m_userStart = 0, m_userEnd = 0, m_passwordEnd = 0, m_hostEnd = 0, m_portEnd = 0, m_pathAfterLastSlash = 0, m_pathEnd = 0, m_queryEnd = 0, m_fragmentEnd = 0}, m_httpMethod = {m_impl = { = {}, m_ptr = 0x7f5602740000}}, m_httpHeaderFields = {, WTF::HashTraits >> = { = {}, m_impl = {static m_minTableSize = 64, static m_maxLoad = , static m_minLoad = 6, m_table = 0x0, m_tableSize = 0, m_tableSizeMask = 0, m_keyCount = 0, m_deletedCount = 0}}, }, m_responseContentDispositionEncodingFallbackArray = { = {}, m_size = 0, m_buffer = {> = { = { = {}, }, m_buffer = 0x0, m_capacity = 0}, }}, m_httpBody = { = {}, m_ptr = 0x0}, m_allowHTTPCookies = true, m_resourceRequestUpdated = true, m_platformRequestUpdated = false, m_reportUploadProgress = false}, } #4 0x00007f56188d7c33 in WebCore::XMLHttpRequest::send (this=0x7f5601087d80, body=@0x7fff47a2fbb0, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:446 No locals. #5 0x00007f56188d7e0b in WebCore::XMLHttpRequest::send (this=0x7f560cfc2e60, ec=@0x0) at WebCore/xml/XMLHttpRequest.cpp:389 No locals. #6 0x00007f56184fbda6 in WebCore::JSXMLHttpRequest::send (this=0x7f5600ec7600, exec=0x7f56012900a0, args=@0x7fff47a2f930) at WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:125 ec = 0 signedLineNumber = sourceID = 140734395251744 sourceURL = {m_rep = { = {}, m_ptr = 0x7f5600f6baa0}, static nullUString = 0x7f56027330f8} function = {m_ptr = 0x7f560113d7e0} #7 0x00007f5618bab0d2 in WebCore::jsXMLHttpRequestPrototypeFunctionSend (exec=0x7f56012900a0, thisValue={m_ptr = 0x7f5600ec7600}, args=@0x7fff47a2fc80) at DerivedSources/JSXMLHttpRequest.cpp:373 No locals. #8 0x00007f561a5a21d4 in ?? () -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:36:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:36:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812163645.1ED3534C0CE8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brettw at chromium.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:40:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:40:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812164003.7E8D434C0D48@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34555|commit-queue+ |commit-queue- Flag| | --- Comment #10 from Eric Seidel 2009-08-12 09:40:02 PDT --- (From update of attachment 34555) Rejecting patch 34555 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:41:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:41:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812164110.7676834C0D79@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #11 from Eric Seidel 2009-08-12 09:41:09 PDT --- ChangeLog diff is malformed. bugzilla-tool/svn-apply don't know how to fix it, hence the commit-queue rejected it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28175] HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit In-Reply-To: References: Message-ID: <20090812164205.F321F34C0DBB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28175 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34553|review+, commit-queue+ | Flag| | --- Comment #3 from Eric Seidel 2009-08-12 09:42:05 PDT --- (From update of attachment 34553) Clearing flags on attachment: 34553 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/qt/FileSystemQt.cpp Committed r47114 M WebCore/ChangeLog M WebCore/platform/qt/FileSystemQt.cpp r47114 = 7f2ff9356922227e477417a6efb09c9d854e485e (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47114 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28175] HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit In-Reply-To: References: Message-ID: <20090812164209.06AF434C0DCB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28175 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #4 from Eric Seidel 2009-08-12 09:42:08 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812164213.E2CAD34C0DE3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 --- Comment #51 from Yong Li 2009-08-12 09:42:12 PDT --- I like for (;;) so much personally :), but seems not allowed in webkit? Probably I'd better change it back to goto. Another way to avoid goto is if (...) { if (...) { ... // free resources } // free resources } I also like this way, but I'm afraid that someone will say there're too many indentations. I also planed to create wrapper classes for HCRYPTKEY and HCRYPTPROV that release resource automatically, but probably it's a waste for this single usage. Sadly, OwnPtr<> doesn't work in this case because HCRYPTKEY and HCRYPTPROV are just "void*". I considered a lot about this. I'm going to use goto, which makes everyone understand -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] WINCE PORT: implement MediaPlayerProxy In-Reply-To: References: Message-ID: <20090812164251.E0B8934C0E13@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28178 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34569|review+, commit-queue+ | Flag| | --- Comment #2 from Eric Seidel 2009-08-12 09:42:51 PDT --- (From update of attachment 34569) Clearing flags on attachment: 34569 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/graphics/wince/MediaPlayerPrivateWince.h A WebCore/platform/graphics/wince/MediaPlayerProxy.cpp A WebCore/platform/graphics/wince/MediaPlayerProxy.h Committed r47115 M WebCore/ChangeLog A WebCore/platform/graphics/wince/MediaPlayerProxy.cpp A WebCore/platform/graphics/wince/MediaPlayerPrivateWince.h A WebCore/platform/graphics/wince/MediaPlayerProxy.h r47115 = cad9e667af33d4301c670e5813e15a31752f9f45 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47115 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] WINCE PORT: implement MediaPlayerProxy In-Reply-To: References: Message-ID: <20090812164255.9EB7534C0E29@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28178 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-12 09:42:54 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812164257.8035434C0E3F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Bug 27511 depends on bug 28178, which changed state. Bug 28178 Summary: WINCE PORT: implement MediaPlayerProxy https://bugs.webkit.org/show_bug.cgi?id=28178 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:43:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:43:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090812164335.035C634C0E67@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34597|review+, commit-queue+ | Flag| | --- Comment #4 from Eric Seidel 2009-08-12 09:43:34 PDT --- (From update of attachment 34597) Clearing flags on attachment: 34597 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/StylesSidebarPane.js Committed r47116 M WebCore/ChangeLog M WebCore/inspector/front-end/StylesSidebarPane.js r47116 = 339ebebf103c8020a3164de2578c2171389b539a (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47116 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:43:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:43:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090812164338.C7D7134C0E7F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #5 from Eric Seidel 2009-08-12 09:43:37 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:44:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:44:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19131] Can't remove a breakpoint In-Reply-To: References: Message-ID: <20090812164416.24EC034C0EC1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19131 --- Comment #2 from Patrick Mueller 2009-08-12 09:44:14 PDT --- The inability to delete breakpoints continues to bug me. At one point recently, one of my source files was just splattered with blue turds as I kept moving breakpoints around, reloading the file, etc. Here's a patch to change the enable/disable breakpoint click states to enable/disable/remove. ie, as you click on the line number in a source view, the breakpoint gets added, then disabled, then removed, then added, ... This seems fairly natural to me. Another option would be to only add/remove via the click, and allow enable/disable in the new breakpoints sidebar. Not clear whether removing breakpoints from the sidebar is required - I think I'd argue that if we want to add that, we may well want more function in the sidebar like "disable all/remove all", etc, and so should look at "remove a breakpoint from sidebar" as part of a larger design effort for that sidebar. I'm happy to kosher this up as a patch, if folks agree the current patch is useful. Index: WebCore/inspector/front-end/SourceFrame.js =================================================================== --- WebCore/inspector/front-end/SourceFrame.js (revision 47011) +++ WebCore/inspector/front-end/SourceFrame.js (working copy) @@ -289,8 +289,10 @@ return; var sourceRow = event.target.enclosingNodeOrSelfWithNodeName("tr"); - if (sourceRow._breakpointObject) - sourceRow._breakpointObject.enabled = !sourceRow._breakpointObject.enabled; + if (sourceRow._breakpointObject && sourceRow._breakpointObject.enabled) + sourceRow._breakpointObject.enabled = false; + else if (sourceRow._breakpointObject) + WebInspector.panels.scripts.removeBreakpoint(sourceRow._breakpointObject); else if (this.addBreakpointDelegate) this.addBreakpointDelegate(this.lineNumberForSourceRow(sourceRow)); }, -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:46:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:46:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812164612.5439A34C0F17@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34666|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:46:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:46:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812164655.8534034C0F45@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 --- Comment #91 from Peter Kasting 2009-08-12 09:46:52 PDT --- (In reply to comment #90) > ImageSource is no longer a forked file for each port. Rather, all ports that > are use the built-in image decoders are moving to a cross-platform > ImageSource.cpp file. Please refactor to use this new file and (only if > necessary) add #if/#else for any behavior changes need by WINCE port for this > file. See: https://bugs.webkit.org/show_bug.cgi?id=27965 And if behavior differences are needed, chat with me/Adam; maybe we can find a better way than #ifdefs (one or two virtual functions, or splitting ImageSource.cpp into a couple pieces, for example). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:47:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:47:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812164707.E348B34C0F6A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34555|0 |1 is obsolete| | Attachment #34667| |review? Flag| | --- Comment #12 from Mike Fenton 2009-08-12 09:47:06 PDT --- Created an attachment (id=34667) --> (https://bugs.webkit.org/attachment.cgi?id=34667) Replacement patch with proper ChangeLog Entry Here's a fixed patch with the changeLog entry complete. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:49:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:49:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812164927.1E77134C0FD7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #10 from Luke Smith 2009-08-12 09:49:26 PDT --- What was the test against FF? RegExp should return false to IsCallable. Safari and webkit have been incorrectly reporting typeof /a/ === 'function' for several versions. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:50:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:50:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812165058.BC02234C1017@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #7 from Adam Treat 2009-08-12 09:50:58 PDT --- Landed with r47118. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:51:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:51:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812165100.4116834C1029@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Bug 27511 depends on bug 28188, which changed state. Bug 28188 Summary: WINCE PORT: Path, PlatformPath https://bugs.webkit.org/show_bug.cgi?id=28188 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:56:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:56:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24289] [Qt] lacks clipToImageBuffer() In-Reply-To: References: Message-ID: <20090812165656.A7EA734C1118@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24289 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ariya.hidayat at trolltech.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:01:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:01:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28076] fast/images/icon-decoding.html needs results for Qt In-Reply-To: References: Message-ID: <20090812170152.7A36134C119C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28076 --- Comment #5 from Peter Kasting 2009-08-12 10:01:51 PDT --- (In reply to comment #4) > Here is a patch for qt which corrects the layout test, but the imlementation > should be changed higher up in QIcon and QPixmap. This is only an expected > behaviour change, which is more compilant to the ICO file format description > (http://www.daubnet.com/en/file-format-ico) which says: > > "For general purpose ICOs there should be at least one 32x32 image using the 16 > Windows colors." That sentence is advisory, to note that if you only include smaller sizes, Windows has to scale them up, and they look bad. However, 32x32 is not a "reference" size, and the first such entry found is not necessarily the best. The layout test is testing that the decoder selects the icon entries in order of largest first, then highest bit depth first after that. This is similar to how Windows itself behaves, especially on newer versions like Vista and 7, where the "typical" icon size is significantly larger than 32x32. Note that for some applications (e.g. displaying favicons in a tab or session history list), you probably want to be able to select a 16x16 icon. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:18:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:18:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28216] [CAIRO] getImageData fails on a given rect bigger than the image rect In-Reply-To: References: Message-ID: <20090812171820.1DDB534C13E6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28216 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34650|review? |review- Flag| | --- Comment #1 from Eric Seidel 2009-08-12 10:18:19 PDT --- (From update of attachment 34650) Test case? Or at least an explanation of why one is impossible. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:18:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:18:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812171833.A17A134C13F8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #4 from Kenneth Rohde Christiansen 2009-08-12 10:18:32 PDT --- Here you have the diffs of the failing tests fast/js/const.html -PASS f() is f +FAIL f() should be function g() { g="FAIL"; return g; } (of type function). Was FAIL (of type string). fast/js/exception-thrown-from-function-with-lazy-activation.html -PASS: args[0] should be 1 and is. +FAIL: args[0] should be 1 but instead is undefined. fast/js/function-call-register-allocation.html -PASS: Recursion did not run out of stack space. +FAIL: Recursion threw an exception: ReferenceError: Can't find variable: f fast/js/function-dot-arguments-and-caller.html -PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS fast/js/named-function-expression.html -PASS var z = 10; var x = eval('(function Named(a,b){ return (!!Named) ? (a + b + z) : -999; })'); x(4,5) is 19 +FAIL var z = 10; var x = eval('(function Named(a,b){ return (!!Named) ? (a + b + z) : -999; })'); x(4,5) should -PASS var ctr = 3; var x = (function Named(a,b){ if(--ctr) return 2 * Named(a,b); else return a + b; }); x(5,6) is 44 +FAIL var ctr = 3; var x = (function Named(a,b){ if(--ctr) return 2 * Named(a,b); else return a + b; }); x(5,6) should be 44. Threw exception ReferenceError: Can't find variable: Named fast/js/static-scope-object.html -PASS namedFunctionExpression() is globalObject +FAIL namedFunctionExpression() should be the global object. Threw exception ReferenceError: Can't find variable: f plugins/netscape-invoke-default.html This tests that it's possible to call NPN_InvokeDefault on a JavaScript object. If this test succeeded, the text "SUCCESS" should be shown below. -SUCCESS +FAILURE -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:18:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:18:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28152] Implement -webkit-linear-gradient and -webkit-radial-gradient In-Reply-To: References: Message-ID: <20090812171838.1E9B934C1405@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28152 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34670| |review? Flag| | --- Comment #1 from Simon Fraser (smfr) 2009-08-12 10:18:37 PDT --- Created an attachment (id=34670) --> (https://bugs.webkit.org/attachment.cgi?id=34670) Patch, testcases, changelog This patch add support for parsing the new gradient types. It does not handle background-repeat, which I'll do separately. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:19:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:19:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812171911.6617A34C1437@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34640|review? |review+, commit-queue+ Flag| | --- Comment #3 from Eric Seidel 2009-08-12 10:19:11 PDT --- (From update of attachment 34640) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:20:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:20:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812172026.2B1D034C145F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34631|review? |review+, commit-queue+ Flag| | --- Comment #2 from Eric Seidel 2009-08-12 10:20:25 PDT --- (From update of attachment 34631) OK. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:22:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:22:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing In-Reply-To: References: Message-ID: <20090812172213.F1A6934C1499@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28133 --- Comment #10 from Eric Seidel 2009-08-12 10:22:12 PDT --- Why don't you need to call: 100 filterContext->clearRect(FloatRect(FloatPoint(), resultImage()->size())); before the first drawImage call? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:23:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:23:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28158] create-bug throws an exception if --cc is not specified In-Reply-To: References: Message-ID: <20090812172323.E4C3D34C14DF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28158 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Adam Roben (aroben) 2009-08-12 10:23:23 PDT --- Fixed in r47120 http://trac.webkit.org/changeset/47120 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:23:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:23:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28159] create-bug throws an exception in Cygwin In-Reply-To: References: Message-ID: <20090812172345.2E4D034C14ED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28159 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Adam Roben (aroben) 2009-08-12 10:23:44 PDT --- Fixed in r47121 http://trac.webkit.org/changeset/47121 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:24:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:24:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28190] Remove support for a window resizer within the WebView In-Reply-To: References: Message-ID: <20090812172418.9454934C14F9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28190 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Adam Roben (aroben) 2009-08-12 10:24:18 PDT --- Fixed in r47122 http://trac.webkit.org/changeset/47122 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:24:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:24:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812172425.9D89334C150F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org, | |pkasting at google.com --- Comment #6 from Eric Seidel 2009-08-12 10:24:24 PDT --- Peter is our Image* guy these days. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:24:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:24:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812172443.AE6F234C1531@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34646|review? |review- Flag| | --- Comment #9 from Alexey Proskuryakov 2009-08-12 10:24:41 PDT --- (From update of attachment 34646) + No new tests. (OOPS!) Please don't say OOPS in ChangeLog - pre-commit script will block such a patch from landing. I think it would be better to say something positive anyway, like "tests will be landed once this code is complete and functional). WebCore/bindings/js/JSWebSocketCustom.cpp \ WebCore/websockets/WebSocket.cpp \ - WebCore/websockets/WebSocket.h + WebCore/websockets/WebSocket.h \ + WebCore/platform/network/SocketStreamErrorBase.cpp \ Looks like this list is supposed to be sorted. children = ( + 510D4A391031665F0049EA54 /* SocketStreamHandleMac.mm */, + 510D4A2D103165EE0049EA54 /* SocketStreamErrorBase.cpp */, + 510D4A2E103165EE0049EA54 /* SocketStreamErrorBase.h */, + 510D4A2F103165EE0049EA54 /* SocketStreamHandle.h */, + 510D4A30103165EE0049EA54 /* SocketStreamHandleBase.cpp */, + 510D4A31103165EE0049EA54 /* SocketStreamHandleBase.h */, + 510D4A32103165EE0049EA54 /* SocketStreamHandleClient.h */, B2F34FE70E82F81700F627CD /* cf */, 656B84E70AEA1DAE00A095B4 /* mac */, Shouldn't SocketStreamHandleMac be in mac folder? And sorry for not realizing this before, but I would actually prefer to have "cf" stubs for SocketStream, not mac ones. + * Copyright (C) 2009 Google Inc. All rights reserved. <...> + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE I'm not sure what template is right for files originally added by Google, but "Apple Computer, Inc." is not even the correct name for Apple any more. You've previously used a different header in WebSocket.h. +const int maxBufferAmount = 524288; I've been thinking of a much larger buffer, something like 100MB (for desktop platforms at least). The idea is to prevent the browser from bringing the whole system to its knees too easily, not to close the connection as soon as it seems that data is sent too quickly. "Buffer amount" doesn't sound like proper English to me - should be either "buffer size" or "maximum buffered amount". + // FIXME: set error code? There is no error code in SocketStreamHandleBase, so I don't understand what this FIXME is about. Could you re-phrase the comment to make it clearer what the concern/bug is? Perhaps an error should just be logged to console via a client didFail () callback. + int bufferedAmount() const { return m_buffer.size(); } + + SocketStreamHandleClient* client() const; It's surprising that one is inline, and the other is not. Not really a problem but was there a reason for this difference? > diff --git a/WebCore/platform/network/SocketStreamHandle.h b/WebCore/platform/network/SocketStreamHandle.h Why is SocketStreamHandle.h in cross-platform directory? The model that e.g. ResourceRequest.h uses seems superior to me - cross-platform parts go into Base, and platforms have both headers and cpp files of their own. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:25:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:25:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812172553.267F134C1567@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34568|review? |review+, commit-queue+ Flag| | --- Comment #7 from Eric Seidel 2009-08-12 10:25:51 PDT --- (From update of attachment 34568) Looks OK. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:28:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:28:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812172815.C2CD634C15D3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34566|review? |review- Flag| | --- Comment #8 from Eric Seidel 2009-08-12 10:28:14 PDT --- (From update of attachment 34566) It seems this is not needed: Icon::Icon() 35 { 36 notImplemented(); 37 } Please remove it from both Icon.h and from Icon.cpp -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:29:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:29:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812172920.7EFB334C1603@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 --- Comment #5 from Hin-Chung Lam 2009-08-12 10:29:19 PDT --- OK, I'll provide a test case with fix shortly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:29:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:29:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28129] [Haiku] Adding three new files to WebCore/platform/haiku. In-Reply-To: References: Message-ID: <20090812172946.8893E34C1629@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28129 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34563|review? |review- Flag| | --- Comment #4 from Eric Seidel 2009-08-12 10:29:45 PDT --- (From update of attachment 34563) None of those virtual methods should be inline. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:30:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:30:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28204] Not possible to build WebCore+V8 with -fno-exceptions on Mac In-Reply-To: References: Message-ID: <20090812173021.7942334C1639@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28204 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34627|commit-queue+ |commit-queue- Flag| | --- Comment #5 from Eric Seidel 2009-08-12 10:30:20 PDT --- (From update of attachment 34627) Rejecting patch 34627 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:31:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:31:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812173105.E0CCB34C165F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #9 from Peter Kasting 2009-08-12 10:31:04 PDT --- (From update of attachment 34570) > diff --git a/WebCore/platform/graphics/haiku/ImageSourceHaiku.cpp b/WebCore/platform/graphics/haiku/ImageSourceHaiku.cpp > new file mode 100644 > index 0000000..ee2184c > --- /dev/null > +++ b/WebCore/platform/graphics/haiku/ImageSourceHaiku.cpp > @@ -0,0 +1,222 @@> +// FIXME: Should use the Haiku translator API. As of yesterday, there's a cross-platform ImageSource.cpp in platform/graphics. It looks at a glance like you could just build with this file (except for one item I note below) instead of adding an ImageSourceHaiku.cpp. > +ImageDecoder* createDecoder(const Vector& data) > +{ > + > + // JPEG > + // FIXME: Add JPEG support. You're using the cross-platform decoders for all other filetypes. Is there something wrong with the cross-platform JPEG decoder that prevents you from even instantiating it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:33:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:33:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28126] [Haiku] Adding SharedTimer to WebCore. In-Reply-To: References: Message-ID: <20090812173307.401DE34C16B5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28126 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34663|review? |review- Flag| | --- Comment #6 from Eric Seidel 2009-08-12 10:33:06 PDT --- (From update of attachment 34663) + bigtime_t interval = fireTime - currentTime(); + + if (interval < 0) + interval = 0; + else + interval *= 1000; Should be something like: bigtime_t millisecondInterval = fireTime - currentTime(); bigtime_t secondInterval = std::max(0, millisecondInterval * 1000); Important to make the variable names clear as to what they're holding. Otherwise looks fine. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:33:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:33:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19131] Can't remove a breakpoint In-Reply-To: References: Message-ID: <20090812173331.DCC5F34C16BF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19131 --- Comment #3 from Timothy Hatcher 2009-08-12 10:33:31 PDT --- Either option seems fine to me. The ideal design that hasn't been implemented yet, would be to allow dragging a breakpoint to move it and dragging out oif the gutter will "poof" it away, like Xcode. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:34:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:34:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22280] CG GIF decoder uses too much CPU In-Reply-To: References: Message-ID: <20090812173429.E641934C16E7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22280 Alexei Yudin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexei.yudin at gmail.com --- Comment #14 from Alexei Yudin 2009-08-12 10:34:27 PDT --- If nobody fixes this annoying bug, i swear I'm going to kill a bunch of innocent people, and Webkit developers will be the ones to blame! Seriously, it's rediculous how one tiny gif freezes the whole browser. It's 2009, goddamnit! Ask the folks from Firefox for fuck's sake, because their browser renders gifs perfectly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:34:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:34:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812173439.C801C34C1700@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 steveblock at google.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34402|0 |1 is obsolete| | Attachment #34671| |review? Flag| | --- Comment #22 from steveblock at google.com 2009-08-12 10:34:38 PDT --- Created an attachment (id=34671) --> (https://bugs.webkit.org/attachment.cgi?id=34671) Patch 5 for bug 27716 > The failure case seems uninteresting. I would checkin the results next to the > tests, and edit the skipped lists of all platforms you expect to fail. Done. I was confused by your earlier comments about maintenance of the skipped lists being the responsibility of the individual platforms. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:35:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:35:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090812173516.89D2F34C1737@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34564|review? |review+, commit-queue+ Flag| | --- Comment #6 from Eric Seidel 2009-08-12 10:35:15 PDT --- (From update of attachment 34564) I wouldn't have bothered to create this variable: 83 IntRect buttonRect(buttonOrigin, buttonSize); 84 85 return buttonRect; Looks fine though. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:37:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:37:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28122] [Haiku] Adding some simple graphic files (IntPoint, =?UTF-8?Q?=20IntRect=E2=80=A6?=) In-Reply-To: References: Message-ID: <20090812173739.D627E34C1791@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28122 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34426|review? |review+, commit-queue+ Flag| | --- Comment #10 from Eric Seidel 2009-08-12 10:37:38 PDT --- (From update of attachment 34426) OK. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:38:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:38:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28204] Not possible to build WebCore+V8 with -fno-exceptions on Mac In-Reply-To: References: Message-ID: <20090812173835.47D9C34C17BB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28204 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34627|commit-queue- |commit-queue+ Flag| | --- Comment #6 from Eric Seidel 2009-08-12 10:38:33 PDT --- (From update of attachment 34627) fast/layers/video-layer.html -> failed media/audio-delete-while-step-button-clicked.html -> failed media/video-controls-transformed.html -> failed media/video-controls-zoomed.html -> failed Test failures caused this regression. I don't think they were caused by this patch. Adding back to commit queue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:38:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:38:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing In-Reply-To: References: Message-ID: <20090812173835.C4BB134C17C1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28133 --- Comment #11 from Dirk Schulze 2009-08-12 10:38:33 PDT --- (In reply to comment #10) > Why don't you need to call: > 100 filterContext->clearRect(FloatRect(FloatPoint(), > resultImage()->size())); > > before the first drawImage call? a new ImageBuffer should always be transparent black.Or am I wrong? Not sure, but it's the transparent black for cg, cairo, qt. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:39:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:39:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28218] New: [Qt] Missing shadow support in Canvas Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28218 Summary: [Qt] Missing shadow support in Canvas Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ariya.hidayat at trolltech.com Ariya Hidayat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34673| |review? Flag| | Created an attachment (id=34673) --> (https://bugs.webkit.org/attachment.cgi?id=34673) Patch v1 Shadow does not work in HTML Canvas. This is for QtWebKit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:40:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:40:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28219] New: platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28219 Summary: platform/mac/accessibility/string-range-contains-listm arker.html fails on SnowLeopard Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cfleizach at apple.com on snow leopard AXLists are present, which change the AX hierarchy slightly -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:41:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:41:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing In-Reply-To: References: Message-ID: <20090812174130.396D934C1825@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28133 --- Comment #12 from Eric Seidel 2009-08-12 10:41:28 PDT --- I take it: GraphicsContext* filterContext = getEffectContext(); is known to create a new image buffer? That's not at all clear from the method naming. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:41:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:41:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28219] platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard In-Reply-To: References: Message-ID: <20090812174136.B8AEA34C1834@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28219 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34674| |review? Flag| | --- Comment #1 from chris fleizach 2009-08-12 10:41:36 PDT --- Created an attachment (id=34674) --> (https://bugs.webkit.org/attachment.cgi?id=34674) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:43:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:43:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27899] [Gtk] Expose a database API In-Reply-To: References: Message-ID: <20090812174336.4CEA634C1873@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27899 Martin Robinson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34544|0 |1 is obsolete| | --- Comment #3 from Martin Robinson 2009-08-12 10:43:35 PDT --- Created an attachment (id=34675) --> (https://bugs.webkit.org/attachment.cgi?id=34675) Updated patch Added an updated patch that: 1. Fixes some bugs 2. Exposes webkit_security_origin_get_database(...) 3. Integrates the database API into DumpRenderLayout, which causes all storage tests to pass now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:44:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:44:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28218] [Qt] Missing shadow support in Canvas In-Reply-To: References: Message-ID: <20090812174456.B203B34C18AD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28218 Ariya Hidayat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34673|review? |review?(hausmann at webkit.org Flag| |) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:45:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:45:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28076] fast/images/icon-decoding.html needs results for Qt In-Reply-To: References: Message-ID: <20090812174558.EAE3934C18D5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28076 --- Comment #6 from Andras Becsi 2009-08-12 10:45:58 PDT --- > The layout test is testing that the decoder selects the icon entries in order > of largest first, then highest bit depth first after that. This is similar to > how Windows itself behaves, especially on newer versions like Vista and 7, > where the "typical" icon size is significantly larger than 32x32. > > Note that for some applications (e.g. displaying favicons in a tab or session > history list), you probably want to be able to select a 16x16 icon. Thank you very much for the information! I din't know which is the preferred order of selecting the icons, how ico exactly has to be handled. I will look into that and correct my patch. According to that the behaviour of the Qt infrastructure is totally wrong, because only the 1st element in the ico file is handed upward to create a QIcon or QPixmap or QImage, and no feature is considered. The only way to handle ICO files correctly is to use QImageLoader an specify how to select the icon. In my opinion at least QIcon sould automatically fill himself with all the icons contained in the ico file, and then select which to retunrt on QIcon::pixmap(...) calls, according to the features and the given arguments. Do you agree? WebKit converts the images to NativeImagePtr, which is QPixmap* in case of QtWebKit if I am not mistaken, so the information that it was an ico and had more entries is lost. I could write a patch to work around the test in QtWebKit, and to specifically handle ico files, but I think this is not a QtWebKit bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:46:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:46:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812174647.AA9AC34C18FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34671|review? |review+, commit-queue+ Flag| | --- Comment #23 from Eric Seidel 2009-08-12 10:46:46 PDT --- (From update of attachment 34671) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:47:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:47:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812174751.5F89934C191F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #5 from Gavin Barraclough 2009-08-12 10:47:50 PDT --- Gah, sorry, it looks like I've broken the interpreter, can repro on Mac with the JIT disabled. Will investigate, & will roll the change out if I can't fix this quickly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:51:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:51:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28219] platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard In-Reply-To: References: Message-ID: <20090812175152.E693D34C19A6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28219 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34674|review? |review+ Flag| | --- Comment #2 from Eric Seidel 2009-08-12 10:51:52 PDT --- (From update of attachment 34674) Looks OK. Technically style violation: + if (testObject.role == "AXRole: AXGroup") { + testObject = testObject.childAtIndex(1); + } + else if (testObject.role == "AXRole: AXListMarker") { -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:53:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:53:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28218] [Qt] Missing shadow support in Canvas In-Reply-To: References: Message-ID: <20090812175318.C308934C19D5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28218 --- Comment #1 from Eric Seidel 2009-08-12 10:53:18 PDT --- (From update of attachment 34673) What does CG have to do with anything? 66 if (m_common->state.shadowsIgnoreTransforms) { 867 // Meaning that this graphics context is associated with a CanvasRenderingContext 868 // We flip the height since CG and HTML5 Canvas have opposite Y axis 869 m_common->state.shadowSize = IntSize(size.width(), -size.height()); 870 } Do you mean GC/GraphicsContext? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:56:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:56:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28219] platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard In-Reply-To: References: Message-ID: <20090812175632.340FD34C1A3B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28219 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from chris fleizach 2009-08-12 10:56:31 PDT --- http://trac.webkit.org/changeset/47123 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:57:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:57:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27051] Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled In-Reply-To: References: Message-ID: <20090812175746.5952034C1A5D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27051 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ggaren at apple.com --- Comment #3 from Geoffrey Garen 2009-08-12 10:57:45 PDT --- (In reply to comment #1) > (From update of attachment 32410 [details]) > I'll have to check into whether this works - I don't remember whether there are > special alignment or lazy commit requirements. The code depends on lazy commit to avoid wasting memory, but not for correctness. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:57:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:57:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812175750.4C81E34C1A71@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 --- Comment #52 from George Staikos 2009-08-12 10:57:48 PDT --- (In reply to comment #50) > (In reply to comment #49) > > I think standard for your for(;;) is really to do: > > > > do { > > } while (0); > > for(;;) is an infinite loop. The above is not an infinite loop, it's a one time > loop, so it can't be used. For infinite loops, the most common pattern in > WebKit is while (true). You got confused in much the same way I was trying to point out. :-) It's -never- supposed to loop. That's what the comment says at the top. That's why it should change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:58:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:58:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28076] fast/images/icon-decoding.html needs results for Qt In-Reply-To: References: Message-ID: <20090812175819.C8FAE34C1A8D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28076 --- Comment #7 from Peter Kasting 2009-08-12 10:58:19 PDT --- (In reply to comment #6) > According to that the behaviour of the Qt infrastructure is totally wrong, > because only the 1st element in the ico file is handed upward to create a QIcon > or QPixmap or QImage, and no feature is considered. If you're only going to select one image, it should probably be the largest (and highest bit depth). > In my > opinion at least QIcon sould automatically fill himself with all the icons > contained in the ico file, and then select which to retunrt on > QIcon::pixmap(...) calls, according to the features and the given arguments. Do > you agree? I am not familiar with the Qt API, so I can't comment usefully. In the abstract, that sounds correct :) > WebKit converts the images to NativeImagePtr, which is QPixmap* in case of > QtWebKit if I am not mistaken, so the information that it was an ico and had > more entries is lost. Things are only converted to a NativeImagePtr at the time when a client requests a frame at a particular index. But an outside client can query ImageSource::frameCount() for the number of frames in an image, and then use ImageSource::frameSizeAtIndex() to determine which frame it wants before requesting the actual frame data. Making this work depends on having your ImageDecoder return the right values for these calls. If your icon decoder sorts the directory entries by size, and bit depth within size, with the highest quality image first, then callers who blindly grab the first frame will get the highest-quality icon (which is what this layout test is testing), and callers who want to pick an icon can use the functions described above. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:00:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:00:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28218] [Qt] Missing shadow support in Canvas In-Reply-To: References: Message-ID: <20090812180009.1774834C1AB7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28218 --- Comment #2 from Ariya Hidayat 2009-08-12 11:00:08 PDT --- CG as in CoreGraphics. Apparently shadow y offset is negative in CanvasRenderingContext2D, likely because it was targeted for CG first. The y-axis inversion can also be found in GraphicsContextSkia, hence why I think the next logical step is to refactor it (and leave out CG as the only one which inverses the axis). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:04:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:04:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812180426.D81AD34C1B4B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34535|review? |review- Flag| | --- Comment #21 from Eric Seidel 2009-08-12 11:04:21 PDT --- (From update of attachment 34535) For the future (this one being in pre-existing code), WebKit code tends to favor early returns instead of long if-blocks: 544545 if (m_document->databaseThread()) { Yes, our style is strange, but comments count as "lines" for multi-line if blocks and shoudl have { } (I used to get this confused myself): 87 if (pendingTransactions.isEmpty()) 88 // No more pending transactions; delete dbIdentifier's queue 89 m_pendingTransactions.remove(it); 90 else 91 // We have more pending transactions; start the next one 92 pendingTransactions.first()->lockAcquired(); No argument names when they don't add clarity: 46 void acquireLock(SQLTransaction* transaction); 47 void releaseLock(SQLTransaction* transaction); Why not add named functions for these: 34 // statement success callback 35 function(result) { log(dbName + " read statement succeeded"); }, 36 37 // statement failure callback 38 function(tx, error) { log(dbName + " read statement failed: " + error.message); }); Then you dont' have to declare them twice, nor do you need the extra lines of comments or spaces because the method names make it obvious what you're doing. function successCallback(testName) { return function(result) { log(dbName + " " + testName + " statement succeeded"); } successCallback("write") If you wanted, you coudl even make them more general and cover the other places you use success/error callbacks too. I'm ready to r+ this, but I think we should go one more round (since iirc you are not yet a committer). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:04:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:04:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812180452.AE75D34C1B6B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #10 from Maxime Simon 2009-08-12 11:04:51 PDT --- (In reply to comment #9) > > +ImageDecoder* createDecoder(const Vector& data) > > +{ > > + > > + // JPEG > > + // FIXME: Add JPEG support. > > You're using the cross-platform decoders for all other filetypes. Is there > something wrong with the cross-platform JPEG decoder that prevents you from > even instantiating it? Indeed, in the default Haiku distribution libjpeg isn't available. Of course we could add it as dependency, but the basic way to handle ImageDecoder in Haiku is to use BTranslators. And we intended to use it for all the other filetypes as well. I may have to discuss it with Ryan. Regards, Maxime -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:08:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:08:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28216] [CAIRO] getImageData fails on a given rect bigger than the image rect In-Reply-To: References: Message-ID: <20090812180802.7438634C1C12@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28216 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34650|0 |1 is obsolete| | Attachment #34677| |review? Flag| | --- Comment #2 from Dirk Schulze 2009-08-12 11:08:01 PDT --- Created an attachment (id=34677) --> (https://bugs.webkit.org/attachment.cgi?id=34677) Cairo fix of getImageData a better Changelog... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:10:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:10:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812181002.322B634C1C69@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pkasting at google.com --- Comment #8 from Eric Seidel 2009-08-12 11:09:59 PDT --- I think this would need a chromium person to try this locally. How would they test if this worked? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:13:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:13:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812181311.77CE634C1CEB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34602|0 |1 is obsolete| | Attachment #34678| |review? Flag| | --- Comment #53 from Yong Li 2009-08-12 11:13:09 PDT --- Created an attachment (id=34678) --> (https://bugs.webkit.org/attachment.cgi?id=34678) mixed a bug changed to do while(0). also fixed a bug that pPubInfo leaked in last patch, because it's defined twice. goto is not good because local object construction after goto doesn't compile. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:13:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:13:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812181331.D34C134C1D03@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|mixed a bug |7) KeygenWince.cpp mixed a description| |bug -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:13:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:13:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812181344.02EE334C1D19@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|application/octet-stream |text/plain mime type| | Attachment #34678|0 |1 is patch| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:14:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:14:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26402] Accessing attributes of an object created with "document.implementation.createDocumentType" causes NULL pointers In-Reply-To: References: Message-ID: <20090812181406.3C5C234C1D6F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26402 Olivier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viapanda at gmail.com --- Comment #4 from Olivier 2009-08-12 11:14:04 PDT --- If I understand well http://www.w3.org/TR/2000/REC-DOM-Level-2-Core-20001113/core.html there is only two cases where Node::document() would be null: * with a document * with a not yet attached documentType If the former, nothing you can access in javascript do crash. If the latter, the following will crash: * Node::childNodes (because of document()->addNodeListCache()) * Node::addEventListener (because of !document->attached()) * Node::removeEventListener And nothing else. Hope that helps... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:17:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:17:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26402] Accessing attributes of an object created with "document.implementation.createDocumentType" causes NULL pointers In-Reply-To: References: Message-ID: <20090812181714.3430234C1DC9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26402 --- Comment #5 from Eric Seidel 2009-08-12 11:17:12 PDT --- I feel like I've seen a dupe of this... possibly even worked on a dupe of this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:17:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:17:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812181720.E6BC934C1DE3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:20:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:20:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26402] Accessing attributes of an object created with "document.implementation.createDocumentType" causes NULL pointers In-Reply-To: References: Message-ID: <20090812182017.C00E234C1E53@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26402 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #6 from Alexey Proskuryakov 2009-08-12 11:20:16 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:21:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:21:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812182115.C76E534C1E91@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 --- Comment #9 from Dirk Schulze 2009-08-12 11:21:13 PDT --- (In reply to comment #8) > I think this would need a chromium person to try this locally. How would they > test if this worked? Hm... a posibility is to apply the last patch of https://bugs.webkit.org/show_bug.cgi?id=28133 replace getImageData with getPremultipliedImageData() and putImageData with putPremultipliedImageData(), build with --filter enabled and look at http://www.w3.org/Graphics/SVG/Test/20061213/htmlObjectHarness/full-filters-blend-01-b.html (ignore the first line, it's a bug in the filter implementation). Sorry, I know that this is a bit complex just for testing, but it was a preperation for SVG filters. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:21:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:21:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812182153.8D28834C1EA7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #11 from Peter Kasting 2009-08-12 11:21:52 PDT --- (In reply to comment #10) > (In reply to comment #9) > > > +ImageDecoder* createDecoder(const Vector& data) > > > +{ > > > + > > > + // JPEG > > > + // FIXME: Add JPEG support. > > > > You're using the cross-platform decoders for all other filetypes. Is there > > something wrong with the cross-platform JPEG decoder that prevents you from > > even instantiating it? > > Indeed, in the default Haiku distribution libjpeg isn't available. > Of course we could add it as dependency, but the basic way to handle > ImageDecoder in Haiku is to use BTranslators. And we intended to use it for all > the other filetypes as well. I may have to discuss it with Ryan. I see. Well, if you want to land the patch in the sort of state it's in now, we could either #if !PLATFORM(HAIKU) (or whatever the appropriate switch is) that block, or add some sort of ENABLE flag (which I am less in favor of). If you want to use a completely different mechanism (I have no idea what BTranslators are :D), we can design for that once you've got code that would work. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:22:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:22:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812182244.9A09F34C1ECB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 --- Comment #10 from Eric Seidel 2009-08-12 11:22:42 PDT --- (From update of attachment 34651) Seems this should be re-posted when it's easier to test. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:24:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:24:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812182401.F1AB934C1EFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 --- Comment #11 from Peter Kasting 2009-08-12 11:24:00 PDT --- Landed a build fix for Skia in r47126 (r47099 did not compile). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:27:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:27:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812182746.06DEB34C1FDB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #11 from Oliver Hunt 2009-08-12 11:27:45 PDT --- (In reply to comment #10) > What was the test against FF? RegExp should return false to IsCallable. > Safari and webkit have been incorrectly reporting typeof /a/ === 'function' for > several versions. RegExps are callable -- eg. /b/("abc") -- the regex is callable, that means that the internal property IsCallable() must return true, which means that regexps should not be serialised. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:29:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:29:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812182925.57EF634C200F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|7) KeygenWince.cpp mixed a |7) KeygenWince.cpp fixed a description|bug |bug -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:31:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:31:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28221] New: REGRESSION (r47110): 4 media regressions on the bots Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28221 Summary: REGRESSION (r47110): 4 media regressions on the bots Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org Depends on: 28220 fast/layers/video-layer.html expected actual diff pretty diff media/audio-delete-while-step-button-clicked.html expected actual diff pretty diff media/video-controls-transformed.html expected actual diff pretty diff media/video-controls-zoomed.html expected actual diff pretty diff -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:33:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:33:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28221] REGRESSION (r47110): 4 media regressions on the bots In-Reply-To: References: Message-ID: <20090812183335.164D734C20C5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28221 --- Comment #1 from Eric Seidel 2009-08-12 11:33:33 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/mac/Skipped Committed r47128 M LayoutTests/platform/mac/Skipped M LayoutTests/ChangeLog r47128 = 69ff4fff8cccc3c23c73062c68b2d34b2a5cc384 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47128 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:35:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:35:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812183524.40A5A34C20F9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #12 from Ryan Leavengood 2009-08-12 11:35:22 PDT --- (In reply to comment #11) > > I see. Well, if you want to land the patch in the sort of state it's in now, > we could either #if !PLATFORM(HAIKU) (or whatever the appropriate switch is) > that block, or add some sort of ENABLE flag (which I am less in favor of). Maxime let's just revert to using their ImageDecoder for now, and we can try using translators later. > If you want to use a completely different mechanism (I have no idea what > BTranslators are :D), we can design for that once you've got code that would > work. Maybe you really don't care, but: Translators are a pretty interesting idea from BeOS (that has been copied in Haiku) which allow file formats to be converted to a common base format to facilitate all kinds of conversions. It is sort of like translating languages into a base language to translate between them (though it works a lot better for binary data than human languages.) The main use at the moment is for images, so that all the image translators can convert to and from a basic bitmap, which allows conversions from PNG to JPG, JPG to GIF, RAW to PNG, etc. It is a pretty cool idea and of course we want to make use of such nice Haiku-only technologies in our WebKit port to make it truly native. The end result of this should be that our WebKit port would be able to render any images we have a translator for, without having to modify or recompile WebKit itself. We can come back to this later when we have something better working. Your willingness to adapt WebKit to help us is very much appreciated! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:36:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:36:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing In-Reply-To: References: Message-ID: <20090812183631.4086E34C211B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28133 --- Comment #13 from Dirk Schulze 2009-08-12 11:36:29 PDT --- (In reply to comment #12) > I take it: > GraphicsContext* filterContext = getEffectContext(); > is known to create a new image buffer? That's not at all clear from the method > naming. hm, right. We can rename it to getEffectContextFromNewImageBuffer() in another patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:36:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:36:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28222] New: bugzilla-tool needs a way to ask build.webkit.org if the bots are passing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28222 Summary: bugzilla-tool needs a way to ask build.webkit.org if the bots are passing Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org, levin at chromium.org bugzilla-tool needs a way to ask build.webkit.org if the bots are passing If they're not passing we should not run the --commit-queue, etc. I'd rather not scrape the buildbot page, but we could. I don't want to put too much extra load on the buildbot master. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:49:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:49:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28204] Not possible to build WebCore+V8 with -fno-exceptions on Mac In-Reply-To: References: Message-ID: <20090812184930.461D234C22DE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28204 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34627|commit-queue+ |commit-queue- Flag| | --- Comment #7 from Eric Seidel 2009-08-12 11:49:29 PDT --- (From update of attachment 34627) Rejecting patch 34627 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:54:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:54:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812185434.6F00434C23A4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #13 from Peter Kasting 2009-08-12 11:54:32 PDT --- (In reply to comment #12) > Translators are a pretty interesting idea from BeOS (that has been copied in > Haiku) which allow file formats to be converted to a common base format to > facilitate all kinds of conversions. It is sort of like translating languages > into a base language to translate between them (though it works a lot better > for binary data than human languages.) The main use at the moment is for > images, so that all the image translators can convert to and from a basic > bitmap, which allows conversions from PNG to JPG, JPG to GIF, RAW to PNG, etc. > > It is a pretty cool idea and of course we want to make use of such nice > Haiku-only technologies in our WebKit port to make it truly native. The end > result of this should be that our WebKit port would be able to render any > images we have a translator for, without having to modify or recompile WebKit > itself. Beware of the potential cost of that, if fitting it into WebCore involves e.g. copying an image's data, or doing more than one conversion. Decoding images has to be really, really fast in a web browser :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:01:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:01:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812190110.C547A34C2483@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:04:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:04:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812190420.C0E2C34C24F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34383|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:06:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:06:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28204] Not possible to build WebCore+V8 with -fno-exceptions on Mac In-Reply-To: References: Message-ID: <20090812190603.0B56634C252D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28204 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #8 from Eric Seidel 2009-08-12 12:06:00 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCorePrefix.h Committed r47131 M WebCore/ChangeLog M WebCore/WebCorePrefix.h r47131 = e75e0df501e7cf6f156c0582d8339c21f55de469 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47131 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:07:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:07:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23817] [QT] Canvas clipping issues In-Reply-To: References: Message-ID: <20090812190716.C588B34C256F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23817 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george.wright at torchmobile.c | |om --- Comment #1 from George Wright 2009-08-12 12:07:15 PDT --- This appears to be a bug in Qt's X11 rendering backend. The problem shows up when using the X11 rendering backend, but not when using Qt's internal raster rendering backend. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:08:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:08:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812190822.33FC434C25AD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34386|review? |review+, commit-queue+ Flag| | --- Comment #54 from George Staikos 2009-08-12 12:08:19 PDT --- (From update of attachment 34386) Seems like a lot of work to be done in these files still, but if we ever want to be building in svn we have to get it checked in, and what is done seems to work well enough. The FIXMEs and notImplemented can be done another day. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:12:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:12:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812191222.6F11C34C263D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34379|review? |review- Flag| | --- Comment #55 from George Staikos 2009-08-12 12:12:19 PDT --- (From update of attachment 34379) > + m_platformDescription = new PlatformMenuItemDescriptionType; > + if (!m_platformDescription) > + return; Don't think we should be checking for null here. > +void ContextMenuItem::setSubMenu(ContextMenu* subMenu) > +{ > + if (!m_platformDescription) > + return; In fact can we remove all of these checks? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:17:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:17:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812191724.00EFF34C26E9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34374|review? |review- Flag| | --- Comment #56 from George Staikos 2009-08-12 12:17:21 PDT --- (From update of attachment 34374) > +static bool getWebLocData(IDataObject* dataObject, String& url, String* title) > +{ > + return false; > +} Should probably add some UNUSED_PARAM() here > + CString cf_html = "Version:0.9"; > + CString startHTML = "\nStartHTML:"; > + CString endHTML = "\nEndHTML:"; > + CString startFragment = "\nStartFragment:"; > + CString endFragment = "\nEndFragment:"; > + CString sourceURL = "\nSourceURL:"; > + > + append(result, cf_html); > + > + bool shouldFillSourceURL = !srcURL.isEmpty() && (srcURL != "about:blank"); > + > + CString startMarkup = "\n\n\n\n"; > + CString endMarkup = "\n\n\n"; all these CString should be "const" right? static too maybe? > +void ClipboardWince::clearData(const String& type) > +{ > + notImplemented(); > +} This file can use lots of UNUSED_PARAM() The rest seems fine -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:21:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:21:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192102.9937E34C276D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380|commit-queue+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:25:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:25:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192532.6D4A134C27FF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380|review+ | Flag| | --- Comment #57 from Adam Treat 2009-08-12 12:25:29 PDT --- (From update of attachment 34380) Clear flag as was landed in r47132. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:26:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:26:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192617.5E68934C2835@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34383|commit-queue+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:28:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:28:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192841.8967134C28B9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34383|review+ | Flag| | --- Comment #58 from Adam Treat 2009-08-12 12:28:38 PDT --- (From update of attachment 34383) Clear flags as landed with r47133. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:29:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:29:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192910.4223C34C28D7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380| |commit-queue- Flag| | --- Comment #59 from Eric Seidel 2009-08-12 12:29:08 PDT --- (From update of attachment 34380) Rejecting patch 34380 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:29:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:29:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192915.DEF4934C28F5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34384|commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:29:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:29:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812192933.011EC34C290D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34671|commit-queue+ |commit-queue- Flag| | --- Comment #24 from Eric Seidel 2009-08-12 12:29:28 PDT --- (From update of attachment 34671) Rejecting patch 34671 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34671 from bug 27716 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:29:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:29:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192946.8934B34C2927@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380|commit-queue- |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:30:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:30:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193032.3362934C2947@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380|review+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:30:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:30:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28223] New: javascript source not reloaded if page is reloaded and breakpoint was set in that source Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28223 Summary: javascript source not reloaded if page is reloaded and breakpoint was set in that source Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pmuellr at yahoo.com Test case: - browser to http://www.nytimes.com/ - bring up web inspector - switch to scripts panel - find "embed.js" in the list of scripts (any script will likely do) - set a breakpoint in some main-line code in that script - back in the browser window, reload the page - focus back on web inspector, you'll see the source file you set the break point SHOULD be displayed, but is a big white empty area instead - breakpoint is actually paused - check your call stack Was able to repeat with a couple of different sites. Seems like this must be relatively new, I reload a lot. Or maybe it's the breakpoint which gets hit during early loading of the page -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:32:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:32:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193244.5E5C734C29B7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34384|review+ | Flag| | --- Comment #60 from Adam Treat 2009-08-12 12:32:42 PDT --- (From update of attachment 34384) Clear flags as landed with r47134. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:34:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:34:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812193414.76F0434C29E5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #14 from Ryan Leavengood 2009-08-12 12:34:12 PDT --- (In reply to comment #13) > > Beware of the potential cost of that, if fitting it into WebCore involves e.g. > copying an image's data, or doing more than one conversion. Decoding images > has to be really, really fast in a web browser :) Good point. There might be some overhead in using the translator system but hopefully not too much. We can do some benchmarks to be sure, but even if using the translators is a bit slower it might still be worth it. At least it shouldn't affect other ports ;) One other issue is that the translator system does not yet (and may never) support animated images. So for GIFs (and other future animated image formats, MNG, APNG, etc) we would have to fallback to using the WebKit decoders. But I'm tempted to try to fix that in Haiku...it is just tricky since translators are for any kind of data not just images. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:34:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:34:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28224] New: Web pages with SVG and map links aren't rendered correctly Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28224 Summary: Web pages with SVG and map links aren't rendered correctly Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: SVG AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: igor.bronstein at gmail.com http://the-bronsteins.net/ru/tree_svg.html ? Web page with SVG (http://the-bronsteins.net/ru/rel_graph.svg) and a map link assigned to this SVG. When opening just an SVG file, it is rendered correctly. But the web page doesn't show the bitmap photo which was a part of an SVG file. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:35:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:35:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193529.E34E034C2A30@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34379|0 |1 is obsolete| | Attachment #34680| |review? Flag| | --- Comment #61 from Yong Li 2009-08-12 12:35:28 PDT --- Created an attachment (id=34680) --> (https://bugs.webkit.org/attachment.cgi?id=34680) 5) ContextMenu (modified) modified according George's suggestion. we have to check m_platformDescription in other functions because it can be cleared by releasePlatformDescription -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:35:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:35:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193530.E554A34C2A3E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34379|0 |1 is obsolete| | Attachment #34680| |review? Flag| | Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34385|review+, commit-queue- | Flag| | --- Comment #61 from Yong Li 2009-08-12 12:35:28 PDT --- Created an attachment (id=34680) --> (https://bugs.webkit.org/attachment.cgi?id=34680) 5) ContextMenu (modified) modified according George's suggestion. we have to check m_platformDescription in other functions because it can be cleared by releasePlatformDescription --- Comment #62 from Adam Treat 2009-08-12 12:35:29 PDT --- (From update of attachment 34385) Clear flags as landed with r47135. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:36:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:36:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193655.D2DBA34C2A66@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34386|commit-queue+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:37:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:37:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812193705.7D9A734C2A7E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #15 from Ryan Leavengood 2009-08-12 12:37:04 PDT --- (In reply to comment #13) > > Beware of the potential cost of that, if fitting it into WebCore involves e.g. > copying an image's data, or doing more than one conversion. Decoding images > has to be really, really fast in a web browser :) Actually this has made me wonder: have you guys ever considered moving image loading and decoding into another thread? Maybe that would add unnecessary complexity and locking issues but at first glance it seems like something that would benefit from parallelism (multiple cores and all being common these days.) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:39:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:39:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193908.530B434C2ACC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34386|review+ | Flag| | --- Comment #63 from Adam Treat 2009-08-12 12:39:06 PDT --- (From update of attachment 34386) Clear flags as landed with r47136. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:41:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:41:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812194135.53CEC34C2B5B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34387|review+, commit-queue- | Flag| | --- Comment #64 from Adam Treat 2009-08-12 12:41:33 PDT --- (From update of attachment 34387) Clearing flags as landed with r47137. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:41:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:41:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812194156.05D2B34C2B81@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|commit-queue+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:44:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:44:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812194450.DD99934C2BF1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 --- Comment #25 from Eric Seidel 2009-08-12 12:44:49 PDT --- Applying 34671 from bug 27716. [snip] patching file LayoutTests/platform/mac/Skipped Hunk #1 FAILED at 89. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej patch -p0 "LayoutTests/platform/mac/Skipped" returned 1. Pass --force to ignore patch failures. Rejecting patch 34671 from commit-queue. This patch will require manual commit. mac/Skipped has changed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:45:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:45:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812194535.53D8834C2C2B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|review+ | Flag| | --- Comment #65 from Adam Treat 2009-08-12 12:45:33 PDT --- (From update of attachment 34678) Clear flags as landed with r47139. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:45:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:45:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22280] CG GIF decoder uses too much CPU In-Reply-To: References: Message-ID: <20090812194539.92D4B34C2C41@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22280 --- Comment #15 from Kevin M. Dean 2009-08-12 12:45:37 PDT --- I'm glad others have finally started to notice this stupidity. I've seen the issue mentioned in discussions of the latest Safari releases as well outside of here. Do we need to send emails to Steve Jobs himself for someone to take notice that we're sick of something as simple as this being an issue. Shame on you Safari/Webkit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:47:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:47:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22280] CG GIF decoder uses too much CPU In-Reply-To: References: Message-ID: <20090812194735.C26BA34C2C9B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22280 --- Comment #16 from Knodi 2009-08-12 12:47:34 PDT --- I have stopped using Safari just before of this bug. It is such a major bug too it FREEZES the whole browser some time for MINUTES! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:52:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:52:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812195203.2BAC034C2D39@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #16 from Peter Kasting 2009-08-12 12:52:01 PDT --- (In reply to comment #15) > Actually this has made me wonder: have you guys ever considered moving image > loading and decoding into another thread? Maybe that would add unnecessary > complexity and locking issues but at first glance it seems like something that > would benefit from parallelism (multiple cores and all being common these > days.) Not sure it'd be a big win since image decoding only happens on-demand, when the image is actually going to be drawn onscreen. Maybe for lots of images that are all visible at once. I haven't given it a lot of thought. Consider asking dhyatt on IRC. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:52:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:52:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812195249.AD0E934C2D6E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34374|0 |1 is obsolete| | Attachment #34681| |review? Flag| | --- Comment #66 from Yong Li 2009-08-12 12:52:48 PDT --- Created an attachment (id=34681) --> (https://bugs.webkit.org/attachment.cgi?id=34681) 1) Clipboard (modified) modified according George's suggestion -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:54:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:54:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28223] javascript source not reloaded if page is reloaded and breakpoint was set in that source In-Reply-To: References: Message-ID: <20090812195435.6979534C2DC1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28223 --- Comment #1 from Patrick Mueller 2009-08-12 12:54:34 PDT --- Additional odd behavior. - run the test case as above - set the breakpoint to disabled - close web inspector - traverse to another web site in the same window - now go back to the site with the breakpoint set - you can now view the source of the file with the breakpoint - the original breakpoint is still in the breakpoint sidebar, but is not annotated in the source - enabling the breakpoint doesn't cause the debugger to stop in that code anymore - the breakpoint is a zombie in the breakpoint sidebar at this point -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:56:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:56:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812195629.0AC7134C2E0D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |darin at apple.com Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:59:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:59:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812195920.8F65934C2E75@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 --- Comment #12 from Brett Wilson (Google) 2009-08-12 12:59:18 PDT --- (From update of attachment 34651) > Index: WebCore/platform/graphics/skia/SkiaUtils.cpp > =================================================================== > --- WebCore/platform/graphics/skia/SkiaUtils.cpp (revision 47098) > +++ WebCore/platform/graphics/skia/SkiaUtils.cpp (working copy) > @@ -80,7 +80,7 @@ static U8CPU InvScaleByte(U8CPU componen > return (component * scale + 0x8000) >> 16; > } > > -SkColor SkPMColorToColor(SkPMColor pm) > +SkColor SkUMColorToColor(SkPMColor pm) > { > if (0 == pm) > return 0; > @@ -94,6 +94,17 @@ SkColor SkPMColorToColor(SkPMColor pm) > InvScaleByte(SkGetPackedB32(pm), scale)); > } > > +SkColor SkPMColorToColor(SkPMColor pm) > +{ > + if (0 == pm) > + return 0; > + > + return SkColorSetARGB(SkGetPackedA32(pm), > + SkGetPackedR32(pm), > + SkGetPackedG32(pm), > + SkGetPackedB32(pm)); > +} It seems like you have the name of this function backwards. UMColor->Color should just be re-ordering the bytes, PMColor->Color needs scaling. Also, having SKUMColorToColor take a PMColor argument is a bit confusing. I actually think writing it out like this is easier to follow, even though it looks longer: unsigned char* destPixel = &destRow[x * 4]; if (multiplied == Unmultiplied) { SkColor color = SkPMColorToColor(srcRow[x]); destPixel[0] = SkColorGetR(color); destPixel[1] = SkColorGetG(color); destPixel[2] = SkColorGetB(color); destPixel[3] = SkColorGetA(color); } else { // Input and output are both pre-multiplied, we just need to re-arrange the bytes from the bitmap format to RGBA. destPixel[0] = SkGetPackedR32(srcRow[x]); destPixel[1] = SkGetPackedG32(srcRow[x]); destPixel[2] = SkGetPackedB32(srcRow[x]); destPixel[3] = SkGetPackedA32(srcRow[x]); } When we want pre-multiplied case, we just need to re-arrange the output. Having the extra function in there (especially one that takes the "wrong" type) makes this harder to see. Brett -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:01:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:01:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19131] Can't remove a breakpoint In-Reply-To: References: Message-ID: <20090812200149.166F434C2EBE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19131 Patrick Mueller changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34682| |review? Flag| | --- Comment #4 from Patrick Mueller 2009-08-12 13:01:47 PDT --- Created an attachment (id=34682) --> (https://bugs.webkit.org/attachment.cgi?id=34682) proposed patch patch as proposed in comment 2 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:07:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:07:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28225] New: check-webkit-style uses python from /usr/bin instead of the PATH Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28225 Summary: check-webkit-style uses python from /usr/bin instead of the PATH Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: carol.szabo at nokia.com check-webkit-style starts with '#!/usr/bin/python'. This prevents usage of the script on computers where /usr/bin/python is absent or is too old even if an appropriate python version exists in the PATH. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:10:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:10:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28226] New: Spinning cursor for 15/20 secs, Sucks. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28226 Summary: Spinning cursor for 15/20 secs, Sucks. Product: WebKit Version: 417.x Platform: Macintosh OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: episodic95 at gmail.com The version I am reporting this from. Figure it out. Spinning cursor for 15/20 secs, Sucks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:16:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:16:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28122] [Haiku] Adding some simple graphic files (IntPoint, =?UTF-8?Q?=20IntRect=E2=80=A6?=) In-Reply-To: References: Message-ID: <20090812201630.8F8A934C305D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28122 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34426|review+, commit-queue+ | Flag| | --- Comment #11 from Eric Seidel 2009-08-12 13:16:28 PDT --- (From update of attachment 34426) Clearing flags on attachment: 34426 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/graphics/haiku/ColorHaiku.cpp A WebCore/platform/graphics/haiku/FloatPointHaiku.cpp A WebCore/platform/graphics/haiku/FloatRectHaiku.cpp A WebCore/platform/graphics/haiku/GradientHaiku.cpp A WebCore/platform/graphics/haiku/IntPointHaiku.cpp A WebCore/platform/graphics/haiku/IntRectHaiku.cpp A WebCore/platform/graphics/haiku/IntSizeHaiku.cpp A WebCore/platform/graphics/haiku/PathHaiku.cpp Committed r47142 M WebCore/ChangeLog A WebCore/platform/graphics/haiku/PathHaiku.cpp A WebCore/platform/graphics/haiku/GradientHaiku.cpp A WebCore/platform/graphics/haiku/ColorHaiku.cpp A WebCore/platform/graphics/haiku/FloatPointHaiku.cpp A WebCore/platform/graphics/haiku/FloatRectHaiku.cpp A WebCore/platform/graphics/haiku/IntPointHaiku.cpp A WebCore/platform/graphics/haiku/IntSizeHaiku.cpp A WebCore/platform/graphics/haiku/IntRectHaiku.cpp r47142 = e4c305eb83f3dda05416b0db9336be7cd0e99ba8 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47142 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:16:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:16:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28122] [Haiku] Adding some simple graphic files (IntPoint, =?UTF-8?Q?=20IntRect=E2=80=A6?=) In-Reply-To: References: Message-ID: <20090812201634.7321334C307F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28122 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #12 from Eric Seidel 2009-08-12 13:16:33 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:17:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:17:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28104] add GDOMTextCustom.cpp In-Reply-To: References: Message-ID: <20090812201733.5205834C30A1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28104 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34452| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:18:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:18:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090812201827.4E45334C30D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 Norbert Leser changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32420|0 |1 is obsolete| | Attachment #34683| |review? Flag| | --- Comment #2 from Norbert Leser 2009-08-12 13:18:25 PDT --- Created an attachment (id=34683) --> (https://bugs.webkit.org/attachment.cgi?id=34683) Updated patch for bug #27060 Symbian compiler for emulator target (WINSCW) fails with "illegal operand" for m_attributesInPrevious in structure.ccp (when calling make_pair functions). This error is apparently due to the compiler not properly resolving the unsigned type of the declared bitfield. Initial patch explicitly casted m_attributesInPrevious to unsigned (at 3 places in structure.cpp), but since bitfield optimization is not critical for the emulator target, this conditional change in header file appears to be least intrusive. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:18:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:18:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090812201859.D595334C310A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34468| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:19:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:19:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812201950.A768A34C3124@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34471| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:19:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:19:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28096] add GDOMCSSRuleCustom.cpp In-Reply-To: References: Message-ID: <20090812201955.4E53634C312E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28096 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34461| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28097] add GDOMCSSValueCustom.cpp In-Reply-To: References: Message-ID: <20090812202008.2978634C313C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28097 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34460| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28098] add GDOMDocumentCustom.cpp In-Reply-To: References: Message-ID: <20090812202019.05C2534C3148@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28098 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34459| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28099] add GDOMElementCustom.cpp In-Reply-To: References: Message-ID: <20090812202019.ABF4134C3154@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28099 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34457| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28101] add GDOMEventTargetCustom.cpp In-Reply-To: References: Message-ID: <20090812202025.EBE6A34C3164@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28101 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34455| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28102] add GDOMHTMLCollectionCustom.cpp In-Reply-To: References: Message-ID: <20090812202031.C793934C317C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28102 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34454| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28103] add GDOMHTMLStyleSheetCustom.cpp In-Reply-To: References: Message-ID: <20090812202036.5B92734C318C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28103 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34453| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:23:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:23:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090812202320.292CC34C31E6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34564|review+, commit-queue+ | Flag| | --- Comment #7 from Eric Seidel 2009-08-12 13:23:19 PDT --- (From update of attachment 34564) Clearing flags on attachment: 34564 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/haiku/ScrollbarThemeHaiku.cpp A WebCore/platform/haiku/ScrollbarThemeHaiku.h Committed r47143 M WebCore/ChangeLog A WebCore/platform/haiku/ScrollbarThemeHaiku.cpp A WebCore/platform/haiku/ScrollbarThemeHaiku.h r47143 = 1e5acb63da2fefd1e799f6c31987d9899a34e057 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47143 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:23:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:23:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090812202323.CCF2634C31F8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #8 from Eric Seidel 2009-08-12 13:23:22 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:24:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:24:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090812202436.CDE4534C3224@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34472| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:24:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:24:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22280] CG GIF decoder uses too much CPU In-Reply-To: References: Message-ID: <20090812202441.A63DB34C3238@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22280 --- Comment #17 from Alexei Yudin 2009-08-12 13:24:40 PDT --- I totally agree with Knodi! I love Safari more than Steve Jobs does, but this bug made me switch to Firefox. I still check out Safari once in a while wondering if they fixed it. I've noticed this bug a long time ago when I started reading LJ community where gifs are used a lot. I sent a bunch of bug reports and wrote about this problem in Apple forums thread (http://discussions.apple.com/thread.jspa?messageID=9601292). Now I'm here, I don't what else to do. A letter to Steve actually seems like a good idea. LOL -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:25:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:25:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090812202551.2477834C3268@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34469| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:29:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:29:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090812202902.AAB7E34C331A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 --- Comment #36 from Eric Seidel 2009-08-12 13:29:00 PDT --- Why does hte ChangeLog diff have no context? Also you should obsolete old patches if you're posting a new one. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:29:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:29:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27410] [Gtk] adding GObject Language bindings auto-generator In-Reply-To: References: Message-ID: <20090812202954.ADD7B34C334A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27410 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34467| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:31:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:31:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28107] gobject code generator library properties In-Reply-To: References: Message-ID: <20090812203125.D8A2D34C337E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28107 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34463| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:31:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:31:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28106] gobject code generator library generate function In-Reply-To: References: Message-ID: <20090812203129.4328334C338A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28106 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34464| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:31:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:31:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28105] gobject code generator library functions In-Reply-To: References: Message-ID: <20090812203133.6A64334C3394@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28105 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34465| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:32:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:32:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28096] add GDOMCSSRuleCustom.cpp In-Reply-To: References: Message-ID: <20090812203236.5F32C34C33BE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28096 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34461|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:33:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:33:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27431] splitting CodeGeneratorGObject.pm into library files In-Reply-To: References: Message-ID: <20090812203323.AC59534C33DE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27431 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34466| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:34:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:34:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28225] check-webkit-style uses python from /usr/bin instead of the PATH In-Reply-To: References: Message-ID: <20090812203450.EFDA034C3425@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28225 Carol Szabo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34686| |review? Flag| | --- Comment #1 from Carol Szabo 2009-08-12 13:34:50 PDT --- Created an attachment (id=34686) --> (https://bugs.webkit.org/attachment.cgi?id=34686) Patch: uses python from $PATH This solution was suggested by kollivier on the #webkit IRC channel. It worked for me and it may be useful to others. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28097] add GDOMCSSValueCustom.cpp In-Reply-To: References: Message-ID: <20090812203513.83B3834C3431@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28097 --- Comment #3 from Eric Seidel 2009-08-12 13:35:13 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28098] add GDOMDocumentCustom.cpp In-Reply-To: References: Message-ID: <20090812203514.363E934C3439@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28098 --- Comment #3 from Eric Seidel 2009-08-12 13:35:13 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28099] add GDOMElementCustom.cpp In-Reply-To: References: Message-ID: <20090812203514.DFE5734C3443@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28099 --- Comment #3 from Eric Seidel 2009-08-12 13:35:14 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28101] add GDOMEventTargetCustom.cpp In-Reply-To: References: Message-ID: <20090812203515.9AA7234C344B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28101 --- Comment #3 from Eric Seidel 2009-08-12 13:35:15 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28102] add GDOMHTMLCollectionCustom.cpp In-Reply-To: References: Message-ID: <20090812203516.4BF2334C3455@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28102 --- Comment #3 from Eric Seidel 2009-08-12 13:35:16 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28103] add GDOMHTMLStyleSheetCustom.cpp In-Reply-To: References: Message-ID: <20090812203517.4CEC234C345D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28103 --- Comment #3 from Eric Seidel 2009-08-12 13:35:16 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28104] add GDOMTextCustom.cpp In-Reply-To: References: Message-ID: <20090812203518.7F57A34C3465@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28104 --- Comment #3 from Eric Seidel 2009-08-12 13:35:18 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28105] gobject code generator library functions In-Reply-To: References: Message-ID: <20090812203519.6096A34C346F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28105 --- Comment #3 from Eric Seidel 2009-08-12 13:35:19 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28106] gobject code generator library generate function In-Reply-To: References: Message-ID: <20090812203520.0B99F34C347F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28106 --- Comment #3 from Eric Seidel 2009-08-12 13:35:19 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812203540.9748134C34A1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34416|review+, commit-queue+ | Flag| | --- Comment #28 from Eric Seidel 2009-08-12 13:35:38 PDT --- (From update of attachment 34416) Clearing flags on attachment: 34416 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/js/ScriptControllerHaiku.cpp M WebCore/loader/CachedFont.cpp M WebCore/page/EventHandler.cpp M WebCore/page/haiku/DragControllerHaiku.cpp M WebCore/platform/image-decoders/ImageDecoder.h M WebCore/platform/text/PlatformString.h M WebCore/platform/text/UnicodeRange.h M WebCore/platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp Committed r47144 M WebCore/ChangeLog M WebCore/page/haiku/DragControllerHaiku.cpp M WebCore/page/EventHandler.cpp M WebCore/platform/text/UnicodeRange.h M WebCore/platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp M WebCore/platform/text/PlatformString.h M WebCore/platform/image-decoders/ImageDecoder.h M WebCore/bindings/js/ScriptControllerHaiku.cpp M WebCore/loader/CachedFont.cpp r47144 = dabd8ddbe25f0c6eb4e9e79ed11b7c7036c7ba22 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47144 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28103] add GDOMHTMLStyleSheetCustom.cpp In-Reply-To: References: Message-ID: <20090812203546.0A1E934C34B7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28103 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34453|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:36:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:36:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28102] add GDOMHTMLCollectionCustom.cpp In-Reply-To: References: Message-ID: <20090812203607.C9F8F34C34DD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28102 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34454|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:36:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:36:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28101] add GDOMEventTargetCustom.cpp In-Reply-To: References: Message-ID: <20090812203641.225C734C34F5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28101 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34455|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:36:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:36:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28099] add GDOMElementCustom.cpp In-Reply-To: References: Message-ID: <20090812203650.BBEBF34C3509@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28099 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34457|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:37:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:37:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28098] add GDOMDocumentCustom.cpp In-Reply-To: References: Message-ID: <20090812203702.66E1F34C3523@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28098 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34459|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:37:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:37:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28097] add GDOMCSSValueCustom.cpp In-Reply-To: References: Message-ID: <20090812203729.A43E934C353B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28097 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34460|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:38:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:38:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27410] [Gtk] adding GObject Language bindings auto-generator In-Reply-To: References: Message-ID: <20090812203811.B8DF934C3583@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27410 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34467|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:38:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:38:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28106] gobject code generator library generate function In-Reply-To: References: Message-ID: <20090812203837.4289034C359F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28106 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34464|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:39:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:39:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28105] gobject code generator library functions In-Reply-To: References: Message-ID: <20090812203905.F3F5734C35C5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28105 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34465|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:39:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:39:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27431] splitting CodeGeneratorGObject.pm into library files In-Reply-To: References: Message-ID: <20090812203955.A8E0134C35EF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27431 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34466|review? |review- Flag| | --- Comment #10 from Mark Rowe (bdash) 2009-08-12 13:39:54 PDT --- (From update of attachment 34466) Numbered files is not a logical way for splitting a Perl module. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:41:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:41:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28104] add GDOMTextCustom.cpp In-Reply-To: References: Message-ID: <20090812204104.B12E934C3620@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28104 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34452|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:44:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:44:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812204422.9D3A834C3696@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34559|review+, commit-queue+ | Flag| | --- Comment #29 from Eric Seidel 2009-08-12 13:44:21 PDT --- (From update of attachment 34559) Clearing flags on attachment: 34559 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/ContextMenuItem.h M WebCore/platform/Cursor.h M WebCore/platform/DragData.h M WebCore/platform/DragImage.h M WebCore/platform/PlatformKeyboardEvent.h M WebCore/platform/PlatformMenuDescription.h M WebCore/platform/PlatformMouseEvent.h M WebCore/platform/PlatformWheelEvent.h M WebCore/platform/PopupMenu.h M WebCore/platform/Widget.h Committed r47145 M WebCore/ChangeLog M WebCore/platform/Cursor.h M WebCore/platform/DragData.h M WebCore/platform/PlatformMenuDescription.h M WebCore/platform/PlatformKeyboardEvent.h M WebCore/platform/DragImage.h M WebCore/platform/PopupMenu.h M WebCore/platform/ContextMenuItem.h M WebCore/platform/PlatformMouseEvent.h M WebCore/platform/PlatformWheelEvent.h M WebCore/platform/Widget.h r47145 = a82dd2e4dac367994e9d09bc33a7aa1ceb3485ce (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47145 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:44:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:44:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812204452.C8C6734C36BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34471|review? |review- Flag| | --- Comment #8 from Eric Seidel 2009-08-12 13:44:52 PDT --- (From update of attachment 34471) See my comments in the mail to you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812204504.7B13634C36C8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812204508.D26C234C36F8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 27430, which changed state. Bug 27430 Summary: adds glib / gobject bindings to webkit gtk port https://bugs.webkit.org/show_bug.cgi?id=27430 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28109] add gobject bindings to WebCore/GNUmakefile.am In-Reply-To: References: Message-ID: <20090812204510.1E5EF34C3706@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28109 Bug 28109 depends on bug 27430, which changed state. Bug 27430 Summary: adds glib / gobject bindings to webkit gtk port https://bugs.webkit.org/show_bug.cgi?id=27430 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28110] add gobject bindings to GNUmakefile.am In-Reply-To: References: Message-ID: <20090812204511.318EC34C370C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28110 Bug 28110 depends on bug 27430, which changed state. Bug 27430 Summary: adds glib / gobject bindings to webkit gtk port https://bugs.webkit.org/show_bug.cgi?id=27430 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28111] make compile succeed with gobject bindings In-Reply-To: References: Message-ID: <20090812204511.B469034C3712@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28111 Bug 28111 depends on bug 27430, which changed state. Bug 27430 Summary: adds glib / gobject bindings to webkit gtk port https://bugs.webkit.org/show_bug.cgi?id=27430 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090812204514.E516434C372E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34469|review? |review- Flag| | --- Comment #21 from Eric Seidel 2009-08-12 13:45:13 PDT --- (From update of attachment 34469) See my comments in the mail to you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090812204524.893FF34C3750@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812204529.7177F34C3786@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 27428, which changed state. Bug 27428 Summary: adding "base class" GdomDOMObject for GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27428 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812204531.2916034C379A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Bug 27430 depends on bug 27428, which changed state. Bug 27428 Summary: adding "base class" GdomDOMObject for GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27428 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090812204546.080EA34C37B0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34468|review? |review- Flag| | --- Comment #14 from Eric Seidel 2009-08-12 13:45:45 PDT --- (From update of attachment 34468) See my comments in the mail to you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090812204548.5D8DB34C37C4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 --- Comment #22 from Mark Rowe (bdash) 2009-08-12 13:45:46 PDT --- (From update of attachment 34469) WEBKIT is not a good prefix for header files like this. The includes don't match our coding style. Is overriding the "finalize" method really necessary here? The overridden version doesn't *do* anything. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090812204554.BBA6334C37D6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812204559.48D7734C3806@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812204601.7910E34C381A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Bug 27430 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28096] add GDOMCSSRuleCustom.cpp In-Reply-To: References: Message-ID: <20090812204602.2036934C3822@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28096 Bug 28096 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28097] add GDOMCSSValueCustom.cpp In-Reply-To: References: Message-ID: <20090812204602.C9BB334C382A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28097 Bug 28097 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28098] add GDOMDocumentCustom.cpp In-Reply-To: References: Message-ID: <20090812204603.6441734C3832@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28098 Bug 28098 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28099] add GDOMElementCustom.cpp In-Reply-To: References: Message-ID: <20090812204604.011A834C383A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28099 Bug 28099 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28101] add GDOMEventTargetCustom.cpp In-Reply-To: References: Message-ID: <20090812204604.982EC34C3842@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28101 Bug 28101 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28103] add GDOMHTMLStyleSheetCustom.cpp In-Reply-To: References: Message-ID: <20090812204605.DF5D734C3854@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28103 Bug 28103 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28104] add GDOMTextCustom.cpp In-Reply-To: References: Message-ID: <20090812204606.7BA9A34C385C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28104 Bug 28104 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28102] add GDOMHTMLCollectionCustom.cpp In-Reply-To: References: Message-ID: <20090812204605.4B88534C384C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28102 Bug 28102 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090812204626.BF80F34C3876@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34472|review? |review- Flag| | --- Comment #37 from Eric Seidel 2009-08-12 13:46:25 PDT --- (From update of attachment 34472) See my comments in the mail to you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:47:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:47:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812204755.2FCA634C38AC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Jim Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jim at yorba.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:53:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:53:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090812205326.589A634C398B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34262|review+, commit-queue- |review- Flag| | --- Comment #38 from Mark Rowe (bdash) 2009-08-12 13:53:25 PDT --- (From update of attachment 34262) > +#die "You must specify a --bindingType e.g. Gdom or JS" unless (length($binding)); > + We don't land commented-out code. > +# FIXME: make_names is being utilised for six different purposes, > +# with generation of HTMLNames.cpp/h being done at the same time > +# as the JS bindings wrapper factories. It's not clear how this comment relates to the code around it. > +# FIXME: this is here because the gobject bindings were created in > +# november 2008, when #ifdef DATAGRID did not exist. to avoid > +# significant extra work in getting the gobject bindings landed, > +# and to also ensure that webkit-gtk will still compile even when > +# DATAGRID is enabled, this workaround skips the #include > +# of headers which the CodeGeneratorGObject.pm does not yet create. Rather than adding a hack like this to the script we should just fix the related issues. > @@ -313,6 +342,8 @@ > > $uniqueTags{$interfaceName} = '1'; > > + next if (temporaryWorkaroundSkipTag($tagName)); > + There are redundant braces here. > my $conditional = $tags{$tagName}{"conditional"}; > if ($conditional) { > my $conditionalString = "ENABLE(" . join(") && ENABLE(", split(/&/, $conditional)) . ")"; > @@ -346,6 +377,8 @@ > > for my $tagName (sort keys %tagConstructorMap) { > > + next if (temporaryWorkaroundSkipTag($tagName)); > + And here. And in other similar places. > +sub printWrapperFunctionGdomInterface > +{ > + my $F = shift; > + my $JSInterfaceName = shift; This seems like a poor choice of variable name. > + } > + if ($binding eq 'Gdom') { > + printWrapperFunctionGdomInterface($F, $JSInterfaceName); > + } As does this. > + if ($binding eq 'Gdom') { > + printWrapperFunctionGdomInterface($F, $JSInterfaceName); > + } > } In general I don't think that a bunch of "if ($binding eq 'Foo')" is a good way to structure this code. Given the number of issues I've mentioned so far I'm marking this as r-. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:55:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:55:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812205558.287CF34C39D9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34576|review+, commit-queue+ | Flag| | --- Comment #30 from Eric Seidel 2009-08-12 13:55:56 PDT --- (From update of attachment 34576) Clearing flags on attachment: 34576 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/BitmapImage.h M WebCore/platform/graphics/Color.h M WebCore/platform/graphics/FloatPoint.h M WebCore/platform/graphics/FloatRect.h M WebCore/platform/graphics/GraphicsContext.cpp M WebCore/platform/graphics/GraphicsContext.h M WebCore/platform/graphics/Icon.h M WebCore/platform/graphics/ImageSource.h M WebCore/platform/graphics/IntPoint.h M WebCore/platform/graphics/IntRect.h M WebCore/platform/graphics/IntSize.h M WebCore/platform/graphics/Path.h M WebCore/platform/graphics/Pattern.h M WebCore/platform/graphics/SimpleFontData.h Committed r47146 M WebCore/ChangeLog M WebCore/platform/graphics/ImageSource.h M WebCore/platform/graphics/GraphicsContext.h M WebCore/platform/graphics/Color.h M WebCore/platform/graphics/FloatPoint.h M WebCore/platform/graphics/FloatRect.h M WebCore/platform/graphics/Icon.h M WebCore/platform/graphics/GraphicsContext.cpp M WebCore/platform/graphics/IntRect.h M WebCore/platform/graphics/IntSize.h M WebCore/platform/graphics/IntPoint.h M WebCore/platform/graphics/SimpleFontData.h M WebCore/platform/graphics/Pattern.h M WebCore/platform/graphics/BitmapImage.h M WebCore/platform/graphics/Path.h r47146 = 573bc04eec4313e26f6b78c3ccfe1a727e962d0b (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47146 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:56:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:56:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812205602.D5DDB34C39F3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #31 from Eric Seidel 2009-08-12 13:56:01 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:56:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:56:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090812205655.C8BF534C3A17@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID --- Comment #39 from Eric Seidel 2009-08-12 13:56:54 PDT --- Given the history and controversy surrounding this bug, I am closing it, and I recommend someone wishing to continue with this work start again with a new bug. See my email to webkit-dev entitled "GDOM patch spam". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:57:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:57:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812205700.4C62734C3A49@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 27425, which changed state. Bug 27425 Summary: adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] https://bugs.webkit.org/show_bug.cgi?id=27425 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:58:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:58:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28225] check-webkit-style uses python from /usr/bin instead of the PATH In-Reply-To: References: Message-ID: <20090812205822.63B9034C3A87@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28225 --- Comment #2 from Mark Rowe (bdash) 2009-08-12 13:58:21 PDT --- None of our existing scripts in WebKitTools/Scripts use this approach. If this is a problem I don't see why we would only fix a single script. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:58:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:58:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28225] check-webkit-style uses python from /usr/bin instead of the PATH In-Reply-To: References: Message-ID: <20090812205852.D3DF534C3A9D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28225 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34686|review? | Flag| | --- Comment #3 from Mark Rowe (bdash) 2009-08-12 13:58:52 PDT --- (From update of attachment 34686) Clearing review flag for reason mentioned. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:59:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:59:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28227] New: Make WebPreferenceKeysPrivate.h available for client use Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28227 Summary: Make WebPreferenceKeysPrivate.h available for client use Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: WebKit API AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: aroben at apple.com Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34687| |review? Flag| | Created an attachment (id=34687) --> (https://bugs.webkit.org/attachment.cgi?id=34687) Patch v1 Reviewed by NOBODY (OOPS!). Need a short description and bug URL (OOPS!) * WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to $WebKitOutputDir, just like we do for a few other headers. Also let VS reorder some XML attributes. * WebPreferenceKeysPrivate.h: Touched this file to force a build. --- 3 files changed, 24 insertions(+), 11 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:59:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:59:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28227] Make WebPreferenceKeysPrivate.h available for client use In-Reply-To: References: Message-ID: <20090812205959.78A2834C3AD2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28227 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34687|review? |review+ Flag| | --- Comment #1 from Dave Hyatt 2009-08-12 13:59:59 PDT --- (From update of attachment 34687) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:00:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:00:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28227] Make WebPreferenceKeysPrivate.h available for client use In-Reply-To: References: Message-ID: <20090812210029.B389C34C3AE6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28227 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Mac OS X 10.5 |Windows XP -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:00:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:00:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812210057.DCF1E34C3AFE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #32 from Yong Li 2009-08-12 14:00:56 PDT --- #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && (PLATFORM(WIN_OS) || PLATFORM(LINUX))) Why was this allowed where we were required to replace with another macro? See bug 27734 ---- Comment #14 From Eric Seidel 2009-08-06 19:48:50 PDT (-) [reply] ------- (From update of attachment 34178 [details]) Please collapse this line into one nicely named define: 35 #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(WIN_OS)) || PLATFORM(WINCE) like STORE_FONT_POINTER or whatever the heck the ifdefed code does. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:02:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:02:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812210237.3F2B434C3B50@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34568|review+, commit-queue+ | Flag| | --- Comment #17 from Eric Seidel 2009-08-12 14:02:35 PDT --- (From update of attachment 34568) Clearing flags on attachment: 34568 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp Committed r47147 M WebCore/ChangeLog A WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp r47147 = 898556fb5c9912a0b53f789ad3e50e439ce26999 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47147 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:02:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:02:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812210241.9FCBE34C3B6C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #18 from Eric Seidel 2009-08-12 14:02:40 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:08:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:08:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28226] Spinning cursor for 15/20 secs, Sucks. In-Reply-To: References: Message-ID: <20090812210845.B4F0834C3C28@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28226 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WORKSFORME --- Comment #1 from Mark Rowe (bdash) 2009-08-12 14:08:45 PDT --- There's no actionable information in this bug report. Some suggestions for future bug reports: 1) Avoid making demands. No-one likes to be bossed around. 2) Avoid insulting the work of the people you're making demands from. It may make them less inclined to help you. 3) Provide information about the version that you're using, and the platform you're using it on. Are you using a WebKit nightly build? If so, which revision is it? Are you using it on Mac OS X or Windows? Which version of Mac OS X or Windows are you using it on? 4) Describe the situation or actions that trigger the incorrect behavior. Does it happen on launch? After visiting any web page? A specific web page? If so, which page? 4) If you're seeing hangs then you should also include a "sample" of the application while it is unresponsive. See for details about using Activity Monitor to do this. Save the output to a text file and then attach it to the bug report that you file. Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:09:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:09:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812210904.D492834C3C3C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34631|commit-queue+ |commit-queue- Flag| | --- Comment #3 from Eric Seidel 2009-08-12 14:09:04 PDT --- (From update of attachment 34631) Rejecting patch 34631 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:09:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:09:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812210916.0137034C3C58@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34640|commit-queue+ |commit-queue- Flag| | --- Comment #4 from Eric Seidel 2009-08-12 14:09:15 PDT --- (From update of attachment 34640) Rejecting patch 34640 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34640 from bug 28213 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:10:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:10:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28227] Make WebPreferenceKeysPrivate.h available for client use In-Reply-To: References: Message-ID: <20090812211051.3387434C3C9A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28227 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Adam Roben (aroben) 2009-08-12 14:10:50 PDT --- Fixed in r47148. http://trac.webkit.org/changeset/47148 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:12:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:12:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] New: Add WebkitDOMObject header files Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28228 Summary: Add WebkitDOMObject header files Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gour at gour-nitai.com Adds header files for WebkitDOMObject.cpp https://bugs.webkit.org/show_bug.cgi?id=27428 Is part of gobject. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:12:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:12:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] Add WebkitDOMObject header files In-Reply-To: References: Message-ID: <20090812211247.4FBA334C3CEC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28228 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16401 Depends on| |27428 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:12:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:12:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812211251.959DD34C3D1C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28228 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:12:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:12:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090812211253.CF9DA34C3D38@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28228 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:13:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:13:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28229] New: Changing size style properties on COLGROUP and TR doesn't affect TDs Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28229 Summary: Changing size style properties on COLGROUP and TR doesn't affect TDs Product: WebKit Version: 412 Platform: Macintosh OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: karinag at yahoo-inc.com I have a table with different TRs and COLGROUPs. When I dynamically set the width of a colgroup or the height of a TR, it changes the elements' width/height accordingly in all other browsers. However, it doesn't work in Safari/Webkit. In order to achieve the desired efect, I have to change the style in the TD elements (style.width or style.height). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:13:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:13:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28225] check-webkit-style uses python from /usr/bin instead of the PATH In-Reply-To: References: Message-ID: <20090812211348.9455934C3D52@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28225 --- Comment #4 from Carol Szabo 2009-08-12 14:13:48 PDT --- (In reply to comment #2) > None of our existing scripts in WebKitTools/Scripts use this approach. If this > is a problem I don't see why we would only fix a single script. Mark, You are right that this would fix only one script and if otherwise the fix is acceptable I am willing to change all scripts in the directory to use the same approach. On the other hand, there is one other script (roll-over-ChangeLogs) which uses the same approach, so it can be argued that since it is ok for that script it should be ok for this script too. I believe that the /usr/bin/env approach does not make sense for standard shells (such as /usr/bin/sh), but may be useful for perl, python and ruby scripts where many incompatible versions may exist in the system. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:14:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:14:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] Add WebkitDOMObject header files In-Reply-To: References: Message-ID: <20090812211428.E7DA534C3D69@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28228 --- Comment #1 from Gour 2009-08-12 14:14:28 PDT --- Created an attachment (id=34688) --> (https://bugs.webkit.org/attachment.cgi?id=34688) uploadded -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:14:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:14:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing In-Reply-To: References: Message-ID: <20090812211437.541A534C3D82@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28133 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34478|review? | Flag| | Attachment #34478|0 |1 is obsolete| | Attachment #34689| |review? Flag| | --- Comment #14 from Dirk Schulze 2009-08-12 14:14:35 PDT --- Created an attachment (id=34689) --> (https://bugs.webkit.org/attachment.cgi?id=34689) SVG Filter feBlend Implementation Many more optimizations. No doubles for colors (now unsigned char). No drawing operations on GraphicsContext. Pick up PixelArray directly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:15:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:15:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] Add WebkitDOMObject header files In-Reply-To: References: Message-ID: <20090812211504.50AAB34C3DAC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28228 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34688| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:17:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:17:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] Add WebkitDOMObject header files In-Reply-To: References: Message-ID: <20090812211706.2318F34C3DEA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28228 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34688|review? | Flag| | --- Comment #2 from Gour 2009-08-12 14:17:05 PDT --- (From update of attachment 34688) I am cancelling the review because it has the same problem as #27428. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:17:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:17:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812211724.35C5934C3E1A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34631|commit-queue- |commit-queue+ Flag| | --- Comment #4 from Eric Seidel 2009-08-12 14:17:23 PDT --- (From update of attachment 34631) The failure was: Testing 11049 test cases. fast/js/global-constructors.html -> failed Which should be unrelated. I expect the bots just went red and I didn't notice. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:18:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:18:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28230] New: bugzilla-tool land-patches will close bugs with patches r=? Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28230 Summary: bugzilla-tool land-patches will close bugs with patches r=? Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org bugzilla-tool land-patches will close bugs with patches r=? Seems we should fix this. :) https://bugs.webkit.org/show_bug.cgi?id=28130 is an example. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:19:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:19:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812211915.E0E2034C3E86@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #19 from Eric Seidel 2009-08-12 14:19:14 PDT --- Sorry for the early closure. We just hit bug 28230. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:19:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:19:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812211923.BF4ED34C3E9E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |eric at webkit.org Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:21:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:21:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812212158.2E94D34C3EEC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #33 from Eric Seidel 2009-08-12 14:21:57 PDT --- (In reply to comment #32) > #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > (PLATFORM(WIN_OS) || PLATFORM(LINUX))) > > Why was this allowed where we were required to replace with another macro? > > See bug 27734 > > ---- Comment #14 From Eric Seidel 2009-08-06 19:48:50 PDT (-) [reply] > ------- > > (From update of attachment 34178 [details] [details]) > Please collapse this line into one nicely named define: > > 35 #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > PLATFORM(WIN_OS)) || PLATFORM(WINCE) > > like STORE_FONT_POINTER or whatever the heck the ifdefed code does. See comment #4 on this bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:23:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:23:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090812212306.95F6434C3F1A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34618|review? |review+ Flag| | --- Comment #8 from Dave Hyatt 2009-08-12 14:23:05 PDT --- (From update of attachment 34618) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:23:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:23:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812212311.2964134C3F2E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #5 from Eric Seidel 2009-08-12 14:23:09 PDT --- Applying 34640 from bug 28213. patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/http/tests/wml/access-target-domain-deny.html patching file LayoutTests/http/tests/wml/access-target-path-deny.html patching file LayoutTests/http/tests/wml/access-target.html patching file WebKitTools/ChangeLog Hunk #1 succeeded at 2 with fuzz 3. can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: WebKitTools/Scripts/make-script-test-wrappers |=================================================================== |--- WebKitTools/Scripts/make-script-test-wrappers |+++ WebKitTools/Scripts/make-script-test-wrappers -------------------------- File to patch: Skip this patch? [y] Skipping patch. 1 out of 1 hunk ignored patch -p0 "WebKitTools/Scripts/make-script-test-wrappers" returned 1. Pass --force to ignore patch failures. Logging in as eric at webkit.org... Rejecting patch 34640 from commit-queue. This patch will require manual commit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:27:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:27:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14997] Support for server-sent DOM events In-Reply-To: References: Message-ID: <20090812212722.339AA34C3FCC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14997 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34665|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:29:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:29:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28231] New: Inspector Resource filtering: keyboard Navigation always uses ALL resources Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28231 Summary: Inspector Resource filtering: keyboard Navigation always uses ALL resources Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mtakacs at yahoo.com CC: timothy at hatcher.name, aroben at apple.com, rik at webkit.org +++ This bug was initially created as a clone of Bug #20629 +++ It'd be nice for the Inspector | Resources Graph panel to support filtering by various things. ++++ Thanks for the commit, enjoying it already! However..... Once you have a complex page loaded (with lots of different type entries) and the filter has been applied, the keyboard shortcuts that allow you to scroll thru the resources are still scrolling thru the "all" list instead of the filtered list. example: 1. Open nightly build of webkit, open Resources tab 2. http://nightly.webkit.org/ 3. Note that there are (currently, aug 2009) nine resources displayed ( a CSS file, a few PNG, an ico and the HTML). 4. Confirm the filter is set to ALL 5. Use the keyboard UP/DOWN key to navigate thru the list of resources (works well) 6. Enable the filter for IMAGES (seems to work, only images shown) 7. Use the cursor UP/DOWN keys to navigate thru the list BUG: seems to still scroll thru the original list of 9 resources, even thru the filter for IMAGES is enabled EXPECTED: only scroll thru the list of IMAGES Behavior gets pretty erratic once the navigation list has been confused by cursoring thru a filtered list of resources. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:33:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:33:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28232] New: "Null after navigation" in major-objects.html is unclear Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28232 Summary: "Null after navigation" in major-objects.html is unclear Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Enhancement Priority: P2 Component: WebKit Website AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: joe.mason at torchmobile.com CC: abarth at webkit.org Adam Barth explains the "null after navigation" comment in major-objects.html like this: > > "NULL after navigation" could be clearer - it suggests that DOMWindow and > > everything below it only exists if you type the URL, but not if a page is > > loaded by clicking a link, which can't be true. > > Oh, I meant navigate to cover both typing in the location bar and > clicking a link. Is there a better word to use for that? > > > Does it mean that it's NULL > > immediately after navigation, while waiting for the load, and is replaced by > > a valid pointer after loading? > > I wasn't sure the best way to represent this in the diagram. > Typically, the edge becomes null in the "up" direction and replaced > with a new object in the "down" direction. If you can think of a nice > way to explain this on the page, please file a bug, CC me, and upload > a patch. I think the best way to represent this is with a footnoted explanation. (Patch forthcoming) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:35:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:35:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28231] Inspector Resource filtering: keyboard Navigation always uses ALL resources In-Reply-To: References: Message-ID: <20090812213538.CD2F734C4111@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28231 --- Comment #1 from Tak 2009-08-12 14:35:38 PDT --- Created an attachment (id=34690) --> (https://bugs.webkit.org/attachment.cgi?id=34690) screenshot of label-less resources extra bonus weirdness if you filter by something that isnt there. eg: http://nightly.webkit.org/ Filter by FONTS then cursor up and down the (blank) list, watch as the resources pops in and out of the blank list. Also managed to get it into a state where the resources names were entirely missing, but the graph was there. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:38:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:38:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28232] "Null after navigation" in major-objects.html is unclear In-Reply-To: References: Message-ID: <20090812213850.DE1AF34C4194@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28232 Joe Mason changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34693| |review? Flag| | --- Comment #1 from Joe Mason 2009-08-12 14:38:49 PDT --- Created an attachment (id=34693) --> (https://bugs.webkit.org/attachment.cgi?id=34693) patch to html file -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:39:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:39:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28233] New: Added symbian specific UID3 identifiers to project files Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28233 Summary: Added symbian specific UID3 identifiers to project files Product: WebKit Version: 528+ (Nightly build) Platform: S60 Hardware OS/Version: S60 3rd edition Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: norbert.leser at nokia.com CC: yongjun.zhang at nokia.com, hausmann at webkit.org, laszlo.1.gombos at nokia.com Norbert Leser changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34694| |review? Flag| | Created an attachment (id=34694) --> (https://bugs.webkit.org/attachment.cgi?id=34694) Symbian UID3 Patch for .pro files Symbian target components (library and executable files) require Unique Identifiers (i.e., UID3). These identifiers are defined in the respective project files, conditionally for "symbian" platform. Also, 2 additional properties need to be specified for the QtLauncher executable in the project file, conditionally for "symbian". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:40:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:40:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28231] Inspector Resource filtering: keyboard Navigation always uses ALL resources In-Reply-To: References: Message-ID: <20090812214056.B47FA34C4201@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28231 --- Comment #2 from Tak 2009-08-12 14:40:56 PDT --- Created an attachment (id=34695) --> (https://bugs.webkit.org/attachment.cgi?id=34695) screenshot of IMAGE filter showing a CSS resources after key navigation Here's a screenshot of a CSS resources bleeding into the IMAGE filter after keyboarding up and down the list of IMAGE filtered resources. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:41:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:41:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812214151.6A86434C4239@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 --- Comment #5 from Xiaomei Ji 2009-08-12 14:41:50 PDT --- (In reply to comment #4) > (From update of attachment 34631 [details]) > The failure was: > Testing 11049 test cases. > fast/js/global-constructors.html -> failed > > Which should be unrelated. I expect the bots just went red and I didn't > notice. you probably right. There is no such failure in my local run with my change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:49:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:49:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812214927.5D81234C434F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34631|review+, commit-queue+ | Flag| | --- Comment #6 from Eric Seidel 2009-08-12 14:49:26 PDT --- (From update of attachment 34631) Clearing flags on attachment: 34631 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/manual-tests/keyboard_select_elements_with_same_beginning.html M WebCore/platform/chromium/PopupMenuChromium.cpp Committed r47150 M WebCore/ChangeLog M WebCore/platform/chromium/PopupMenuChromium.cpp A WebCore/manual-tests/keyboard_select_elements_with_same_beginning.html r47150 = bc763ed3dfd04ac8690009160a8baa8af4d3053e (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47150 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:49:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:49:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812214931.4296934C436F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #7 from Eric Seidel 2009-08-12 14:49:30 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:55:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:55:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24971] Setting style.height = value in javascript doesn't work in tablerows() In-Reply-To: References: Message-ID: <20090812215524.4348C34C449E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24971 Karina Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karinag at yahoo-inc.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:55:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:55:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24971] Setting style.height = value in javascript doesn't work in tablerows() In-Reply-To: References: Message-ID: <20090812215548.F2E8834C44BC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24971 Karina Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mitz at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:56:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:56:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19131] Can't remove a breakpoint In-Reply-To: References: Message-ID: <20090812215630.29F5E34C44D4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19131 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34682|review? |review- Flag| | --- Comment #5 from Timothy Hatcher 2009-08-12 14:56:29 PDT --- (From update of attachment 34682) You will need to remove the "No new tests" line other wise the patch wont commit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:58:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:58:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812215801.75DF534C451E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34615|commit-queue+ |commit-queue- Flag| | --- Comment #4 from Eric Seidel 2009-08-12 14:57:59 PDT --- (From update of attachment 34615) Rejecting patch 34615 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34615 from bug 28196 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:58:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:58:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28234] New: AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRange is wrong in some cases Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28234 Summary: AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRan ge is wrong in some cases Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cfleizach at apple.com When there is a block of text followed by a link, the bounds for certain ranges is wrong (specifcally the ranges retreived when asking for next line ranges) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:58:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:58:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27143] [Gtk][REGRESSION] XHR test failures after r45558 In-Reply-To: References: Message-ID: <20090812215844.1F83A34C456F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27143 --- Comment #2 from Gustavo Noronha (kov) 2009-08-12 14:58:43 PDT --- Created an attachment (id=34696) --> (https://bugs.webkit.org/attachment.cgi?id=34696) disable sniffing when requested LayoutTests/ChangeLog | 11 +++++++++++ LayoutTests/platform/gtk/Skipped | 1 - WebCore/ChangeLog | 13 +++++++++++++ .../platform/network/soup/ResourceHandleSoup.cpp | 3 +++ 4 files changed, 27 insertions(+), 1 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:59:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:59:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27143] [Gtk][REGRESSION] XHR test failures after r45558 In-Reply-To: References: Message-ID: <20090812215953.9373634C4595@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27143 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34696| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:02:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:02:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090812220225.0B7BB34C45DD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34683|review? |review- Flag| | --- Comment #3 from Darin Adler 2009-08-12 15:02:24 PDT --- (From update of attachment 34683) This needs a brief comment, otherwise it's simply too mysterious. I'm going to say review- because I don't think we should land it without a comment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:08:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:08:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090812220822.DE46F34C46D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 Joe Mason changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34697| |review? Flag| | --- Comment #29 from Joe Mason 2009-08-12 15:08:21 PDT --- Created an attachment (id=34697) --> (https://bugs.webkit.org/attachment.cgi?id=34697) just replace the string of PLATFORM(FOO) defines Let's get the easy one out of the way - this is just the STORE_FONT_CUSTOM_PLATFORM_DATA define (with an added explanatory comment). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:09:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:09:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28234] AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRange is wrong in some cases In-Reply-To: References: Message-ID: <20090812220946.436C634C4756@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28234 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34698| |review? Flag| | --- Comment #1 from chris fleizach 2009-08-12 15:09:45 PDT --- Created an attachment (id=34698) --> (https://bugs.webkit.org/attachment.cgi?id=34698) patch I'm no expert about Position(s) but here is what I found comparing two cases. case 1) a block of text case 2) a block of text with a link following the text. Goal: To retrieve the bounds of the second line of text in the block. In the first case, [Position.cpp:983] box = searchAheadForBetterMatch(textRenderer); finds nothing because there's nothing else in the list of siblings. It uses its initial m_offset as the caretPosition.. bounds are then calculated correctly. In the second case, same line position box = searchAheadForBetterMatch(textRenderer); finds the InlineRenderer for the anchor tag. it uses that box's caretMinOffset, which is zero, instead of m_offset. Now the bounds are messed up because we think the caret offset is back to zero My fix, which may be incorrect (but doesn't seem to cause any regression test failures), is that we should only reset the caretOffset to the new box's offset if it's > than the current offset (because we're looking downstream in this case, we shouldn't get a offset less than what we started). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:11:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:11:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812221137.39FF934C47A0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #34 from Ryan Leavengood 2009-08-12 15:11:36 PDT --- (In reply to comment #32) > #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > (PLATFORM(WIN_OS) || PLATFORM(LINUX))) > > Why was this allowed where we were required to replace with another macro? > > See bug 27734 > > ---- Comment #14 From Eric Seidel 2009-08-06 19:48:50 PDT (-) [reply] > ------- > > (From update of attachment 34178 [details] [details]) > Please collapse this line into one nicely named define: > > 35 #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > PLATFORM(WIN_OS)) || PLATFORM(WINCE) > > like STORE_FONT_POINTER or whatever the heck the ifdefed code does. If you WinCE guys want to add this we will modify our patch once yours has landed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:11:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:11:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812221145.4B4FF34C47CA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED CC| |levin at chromium.org Resolution|FIXED | AssignedTo|webkit-unassigned at lists.web |christian.plesner.hansen at gm |kit.org |ail.com --- Comment #5 from David Levin 2009-08-12 15:11:42 PDT --- Had to roll this out http://trac.webkit.org/changeset/47153 due to v8 being rolled back upstream. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:11:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:11:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14997] Support for server-sent DOM events In-Reply-To: References: Message-ID: <20090812221146.DAAFA34C47DE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14997 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34665| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:15:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:15:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090812221516.C13D034C48A9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34648|review+ |review- Flag| | --- Comment #31 from Eric Seidel 2009-08-12 15:15:14 PDT --- (From update of attachment 34648) 157 if (m_layer->renderer()->document()->isXHTMLMPDocument()) { 158 if (m_timer.isActive() || m_layer->renderer()->style()->marqueeIncrement().isZero() || !m_layer->renderer()->style()->marqueeLoopCount()) 159 return; 160 } else { 161 if (m_timer.isActive() || m_layer->renderer()->style()->marqueeIncrement().isZero()) 162 return; 163 } 164 I would have written that as: 161 if (m_timer.isActive() || m_layer->renderer()->style()->marqueeIncrement().isZero() || (m_layer->renderer()->document()->isXHTMLMPDocument() && !m_layer->renderer()->style()->marqueeLoopCount()) 162 return; in fact, that can seasily just be added as part of the existing if: if (m_timer.isActive() || m_layer->renderer()->style()->marqueeIncrement().isZero() #if WCSS || (m_layer->renderer()->document()->isXHTMLMPDocument() && !m_layer->renderer()->style()->marqueeLoopCount() #endif } 156167 return; -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:15:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:15:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090812221551.1CB8C34C48F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34560|review+ | Flag| | --- Comment #102 from Eric Seidel 2009-08-12 15:15:44 PDT --- (From update of attachment 34560) Clearing review flag since a new patch has been posted. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:18:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:18:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26620] Haiku WebKit port In-Reply-To: References: Message-ID: <20090812221801.DB1B234C4971@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26620 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #63 from Eric Seidel 2009-08-12 15:17:59 PDT --- I think it's time to retire this bug. Please post new patches on new bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:19:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:19:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090812221921.E01AC34C49A3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34618| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:20:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:20:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24971] Setting style.height = value in javascript doesn't work in tablerows() In-Reply-To: References: Message-ID: <20090812222017.DF23C34C49D7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24971 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:20:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:20:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27124] let me *edit* css styles in the web inspector. In-Reply-To: References: Message-ID: <20090812222036.447CA34C49F9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27124 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #15 from Eric Seidel 2009-08-12 15:20:33 PDT --- http://trac.webkit.org/changeset/46690 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:20:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:20:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24971] Setting style.height = value in javascript doesn't work in tablerows() In-Reply-To: References: Message-ID: <20090812222042.A067234C4A03@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24971 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #2 from mitz at webkit.org 2009-08-12 15:20:41 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:21:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:21:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812222101.CCF5434C4A1B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #35 from Yong Li 2009-08-12 15:21:00 PDT --- (In reply to comment #34) > (In reply to comment #32) > > #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > > (PLATFORM(WIN_OS) || PLATFORM(LINUX))) > > > > Why was this allowed where we were required to replace with another macro? > > > > See bug 27734 > > > > ---- Comment #14 From Eric Seidel 2009-08-06 19:48:50 PDT (-) [reply] > > ------- > > > > (From update of attachment 34178 [details] [details] [details]) > > Please collapse this line into one nicely named define: > > > > 35 #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > > PLATFORM(WIN_OS)) || PLATFORM(WINCE) > > > > like STORE_FONT_POINTER or whatever the heck the ifdefed code does. > > If you WinCE guys want to add this we will modify our patch once yours has > landed. Don't worry about this. Your patch has already been committed, and ours is still pending. So I had to solve conflicts when I updated our repo. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:21:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:21:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090812222124.10BC734C4A4F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Bug 19264 depends on bug 27458, which changed state. Bug 27458 Summary: Support :default HTML5 CSS selector https://bugs.webkit.org/show_bug.cgi?id=27458 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:22:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:22:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27429] add gdom.h "convenience" header as part of GObject bindings In-Reply-To: References: Message-ID: <20090812222207.3790E34C4A77@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27429 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |INVALID --- Comment #7 from Eric Seidel 2009-08-12 15:22:06 PDT --- Closing out GDOM bugs. Someone else will need to take these on later. See my email to webkit-dev on the subject. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:22:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:22:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812222211.4AF2034C4AA7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 27429, which changed state. Bug 27429 Summary: add gdom.h "convenience" header as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27429 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:22:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:22:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812222213.593E334C4ABD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Bug 27430 depends on bug 27429, which changed state. Bug 27429 Summary: add gdom.h "convenience" header as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27429 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:22:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:22:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812222248.178A134C4AE5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34401| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:25:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:25:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28064] wrong calculation of overflow size for flexbox and table In-Reply-To: References: Message-ID: <20090812222537.1A0A034C4B61@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28064 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34440| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:25:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:25:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812222557.E410134C4B7D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34555|review+ | Flag| | --- Comment #13 from Eric Seidel 2009-08-12 15:25:56 PDT --- (From update of attachment 34555) clearing review flag on this obsolete patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:26:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:26:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090812222624.D16E734C4B99@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 --- Comment #32 from George Staikos 2009-08-12 15:26:24 PDT --- (In reply to comment #31) > (From update of attachment 34648 [details]) > > in fact, that can seasily just be added as part of the existing if: > > if (m_timer.isActive() || > m_layer->renderer()->style()->marqueeIncrement().isZero() > #if WCSS > || (m_layer->renderer()->document()->isXHTMLMPDocument() && > !m_layer->renderer()->style()->marqueeLoopCount() > #endif > } > 156167 return; I'm already on it. Fixed a few other minor style issues and this one, but in the end took your implementation as above. I'm still concerned about the unconditional addition to CSSValueKeywords.in. How can we deal with that, or is it just fine to include it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:26:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:26:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28162] [Qt] QtLauncher crashes when trying to change zoom level In-Reply-To: References: Message-ID: <20090812222648.D18AC34C4BBF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28162 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34513|commit-queue? |commit-queue+ Flag| | --- Comment #2 from Eric Seidel 2009-08-12 15:26:48 PDT --- (From update of attachment 34513) Adam, since you're a committer, you can just mark this commit-queue+ if you want it committed for you. :) cq=? is for folks who are not committed but want to make sure it's added to the cq. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:27:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:27:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] fix a typo in platform/graphics/skia/PlatformContextSkia.cpp In-Reply-To: References: Message-ID: <20090812222706.AC88534C4BC9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28172 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34543| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:29:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:29:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14997] Support for server-sent DOM events In-Reply-To: References: Message-ID: <20090812222945.E591534C4C3B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14997 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34665|commit-queue+ |commit-queue- Flag| | --- Comment #34 from Eric Seidel 2009-08-12 15:29:41 PDT --- (From update of attachment 34665) Testing 11056 test cases. fast/dom/prototype-inheritance-2.html -> failed fast/dom/prototype-inheritance.html -> failed fast/dom/Window/window-properties.html -> failed This needs more tests updated. Either the patch needs to be updated, or someone needs to do that when landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:30:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:30:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] Add WebkitDOMObject header files In-Reply-To: References: Message-ID: <20090812223024.007F334C4C53@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28228 --- Comment #3 from Mark Rowe (bdash) 2009-08-12 15:30:23 PDT --- Gour, rather than continuing along with the same problematic approach that Luke took can you please do as requested and discuss a more productive approach with the maintainers of the GTK port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:31:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:31:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812223111.30CD734C4C7B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28213 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:31:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:31:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812223110.C5B0E34C4C75@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Depends on| |28212 Ever Confirmed|0 |1 --- Comment #6 from Eric Seidel 2009-08-12 15:31:09 PDT --- Oh, this patch depends on bug 28212. It can be re-added to the commit-queue once bug 28212 is landed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:31:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:31:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28235] New: Using QWebFrame::evaluateJavaScript does not relayout Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28235 Summary: Using QWebFrame::evaluateJavaScript does not relayout Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rich at kde.org Created an attachment (id=34700) --> (https://bugs.webkit.org/attachment.cgi?id=34700) Patch to fix the bug It seems that executing javascript code using evaluateJavaScript that changes the visibility of some divs in a page does not cause an immediate relayout of the page. The page instead remains unchanged until the user moves the mouse over it. The problem was found by using js like this: function toggleVisibility(id) { el = document.getElementById(id); if (el.style.display == 'none') { el.style.display = ''; window.silk.GM_log('showing'); } else { el.style.display = 'none'; window.silk.GM_log('hiding'); } } toggleVisibility('sidebar'); toggleVisibility('header'); toggleVisibility('footer'); Executed against a gitorious repository. The same code executed in the inspector functions as expected. I've included what I think should be a patch to fix this issue in master, though since my code has kde dependencies against 4.5 I have been unable to test it so far. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:31:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:31:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812223123.8869034C4C86@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34638| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:32:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:32:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812223208.9593034C4C96@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34638|commit-queue+ |commit-queue- Flag| | --- Comment #5 from Eric Seidel 2009-08-12 15:32:08 PDT --- (From update of attachment 34638) Nm, I'll leave this for Shinichiro to commit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:33:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:33:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812223307.6064F34C4CC2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #6 from Eric Seidel 2009-08-12 15:33:06 PDT --- I can't tell if this is still pending commit. But I think it's not supposed to be, or? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:33:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:33:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812223347.632FF34C4CE0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34615|commit-queue- |commit-queue+ Flag| | --- Comment #5 from Eric Seidel 2009-08-12 15:33:46 PDT --- (From update of attachment 34615) Not sure why this was rejected from the queue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:35:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:35:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812223555.7C5B134C4D24@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #7 from Gavin Barraclough 2009-08-12 15:35:54 PDT --- I'm not sure I understand your question. :-) This patch is committed, currently pending decommit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:37:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:37:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812223722.B4FD134C4D6C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34633|review+ | Flag| | --- Comment #8 from Eric Seidel 2009-08-12 15:37:21 PDT --- (From update of attachment 34633) Ok. Removing the r+ to remove it from the to-be-committed list. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:40:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:40:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812224030.F0F0434C4DED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #22 from Dumitru Daniliuc 2009-08-12 15:40:27 PDT --- (In reply to comment #21) > (From update of attachment 34535 [details]) > For the future (this one being in pre-existing code), WebKit code tends to > favor early returns instead of long if-blocks: > 544545 if (m_document->databaseThread()) { fixed. > Yes, our style is strange, but comments count as "lines" for multi-line if > blocks and shoudl have { } (I used to get this confused myself): > 87 if (pendingTransactions.isEmpty()) > 88 // No more pending transactions; delete dbIdentifier's queue > 89 m_pendingTransactions.remove(it); > 90 else > 91 // We have more pending transactions; start the next one > 92 pendingTransactions.first()->lockAcquired(); fixed. > No argument names when they don't add clarity: > 46 void acquireLock(SQLTransaction* transaction); > 47 void releaseLock(SQLTransaction* transaction); removed. > Why not add named functions for these: > 34 // statement success callback > 35 function(result) { log(dbName + " read statement > succeeded"); }, > 36 > 37 // statement failure callback > 38 function(tx, error) { log(dbName + " read statement > failed: " + error.message); }); > > Then you dont' have to declare them twice, nor do you need the extra lines of > comments or spaces because the method names make it obvious what you're doing. > > function successCallback(testName) { > return function(result) { log(dbName + " " + testName + " statement > succeeded"); } > > successCallback("write") done. > If you wanted, you coudl even make them more general and cover the other places > you use success/error callbacks too. we could do this, but since the messages are quite different (read vs. write, statement vs. transaction, and read/write doesn't even apply in case of a transaction callback), i feel like this would only lead to more complicated and unintuitive implementations for successCallback() and errorCallback(), as well as some pretty cryptic calls to these functions. > I'm ready to r+ this, but I think we should go one more round (since iirc you > are not yet a committer). i'm working my way there. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:41:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:41:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812224106.6D26C34C4E10@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34535|0 |1 is obsolete| | Attachment #34701| |review? Flag| | --- Comment #23 from Dumitru Daniliuc 2009-08-12 15:41:03 PDT --- Created an attachment (id=34701) --> (https://bugs.webkit.org/attachment.cgi?id=34701) patch + test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:41:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:41:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28064] wrong calculation of overflow size for flexbox and table In-Reply-To: References: Message-ID: <20090812224152.71B9934C4E34@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28064 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34440|commit-queue+ |commit-queue- Flag| | --- Comment #6 from Eric Seidel 2009-08-12 15:41:52 PDT --- (From update of attachment 34440) Rejecting patch 34440 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:42:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:42:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812224232.B97A434C4E52@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #9 from Gavin Barraclough 2009-08-12 15:42:31 PDT --- Hmmm, is removing the r+ flag a good idea? :-/ Are we not losing the information from bugzilla as to who reviewed the patch, and which patches have been approved? What problem is this solving, does this related to the commit queue? If so, it seems the commit queue shouldn't care about this bug, since it was not added to the queue. If there is a problem, are we solving it in the right way here? - does the review queue mechanism need to be smarter? (Apologies if I'm just misunderstanding something here). cheers, G. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:45:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:45:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27596] Inspector: Console Object Property Subtitle's Display Poorly In-Reply-To: References: Message-ID: <20090812224507.C336E34C4E95@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27596 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |timothy at hatcher.name -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:47:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:47:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28236] New: Inspector: Doesn't Respect javascript's const keyword Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28236 Summary: Inspector: Doesn't Respect javascript's const keyword Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: joepeck02 at gmail.com CC: timothy at hatcher.name, aroben at apple.com, kmccullough at apple.com It seems a const variable declared in the Console is just a "var" and can change value. > zzz // ensure it doesn't exist ReferenceError: Can't find variable: zzz > const zzz = 10; undefined > zzz = 5; // should do nothing 5 > zzz 5 I would have expected the result to have been 10, since the constant shouldn't change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:49:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:49:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28162] [Qt] QtLauncher crashes when trying to change zoom level In-Reply-To: References: Message-ID: <20090812224924.290B334C4F07@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28162 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34513|review+, commit-queue+ | Flag| | --- Comment #3 from Eric Seidel 2009-08-12 15:49:23 PDT --- (From update of attachment 34513) Clearing flags on attachment: 34513 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/qt/ChangeLog M WebKit/qt/QtLauncher/main.cpp Committed r47156 M WebKit/qt/QtLauncher/main.cpp M WebKit/qt/ChangeLog r47156 = 2a552d79fea80795059ae47a478f535d24093bdd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47156 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:49:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:49:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28162] [Qt] QtLauncher crashes when trying to change zoom level In-Reply-To: References: Message-ID: <20090812224928.91A0534C4F21@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28162 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #4 from Eric Seidel 2009-08-12 15:49:27 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:51:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:51:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28064] wrong calculation of overflow size for flexbox and table In-Reply-To: References: Message-ID: <20090812225137.0E37E34C4F61@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28064 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #7 from Eric Seidel 2009-08-12 15:51:35 PDT --- transitions/transition-end-event-transform.html -> failed Not sure if it was related to your patch or not. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:54:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:54:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28236] Inspector: Doesn't Respect javascript's const keyword In-Reply-To: References: Message-ID: <20090812225431.2154F34C4FDA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28236 --- Comment #1 from Joseph Pecoraro 2009-08-12 15:54:30 PDT --- Maybe this is actually a problem with eval(): Expected Behavior without eval: javascript:const zza = 10; zza = 5; alert(zza) => 10 Bad Behavior with eval: javascript:alert(eval("const zzb = 10; zzb = 5; zzb")) => 5 How should this bug be reclassified? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:56:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:56:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] fix a typo in platform/graphics/skia/PlatformContextSkia.cpp In-Reply-To: References: Message-ID: <20090812225605.E7F4E34C5008@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28172 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34543|review+, commit-queue+ | Flag| | --- Comment #2 from Eric Seidel 2009-08-12 15:56:05 PDT --- (From update of attachment 34543) Clearing flags on attachment: 34543 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/skia/PlatformContextSkia.cpp Committed r47157 M WebCore/ChangeLog M WebCore/platform/graphics/skia/PlatformContextSkia.cpp r47157 = 26175092e7df7fdb43ae216e3e6bcfa058bb59d0 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47157 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:56:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:56:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] fix a typo in platform/graphics/skia/PlatformContextSkia.cpp In-Reply-To: References: Message-ID: <20090812225609.1BBDB34C5016@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28172 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-12 15:56:08 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:57:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:57:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812225714.6CCA034C5038@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #10 from Eric Seidel 2009-08-12 15:57:13 PDT --- The query that Maciej sent to the list months ago for listing which bugs need commit: https://bugs.webkit.org/buglist.cgi?query_format=advanced&short_desc_type=notregexp&short_desc=%5C%5BS60%5C%5D&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&keywords_type=allwords&keywords=&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&emailassigned_to1=1&emailtype1=substring&email1=&emailassigned_to2=1&emailreporter2=1&emailcc2=1&emailtype2=substring&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=review%2B&field0-1-0=noop&type0-1-0=equals&value0-1-0= Show's bugs if they have r+. Nah, the commit-queue is smart enough to only look for bugs which actually have a commit-queue+. It's just we humans who are confused by the r+ on an open bug, and wonder if said open bug should be considered for landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:58:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:58:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28237] New: Pan Scrolling and Panning don't jump out of frames, while mouse wheel events do Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28237 Summary: Pan Scrolling and Panning don't jump out of frames, while mouse wheel events do Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.samisite.com/test-csb2nf/id43.htm OS/Version: Windows 7 Status: NEW Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: bweinstein at apple.com If your mouse is in a frame that can scroll, and you mousewheel to the bottom of the frame, the scrolling action will continue to its parent (usually the document). However, if you are panscrolling, when you scroll to the bottom of the frame, the scrolling does not continue to scroll the parent, and just stops the scrolling when it is done scrolling the frame. I am not sure if this is by design or a bug, but I am filing it here to open up discussion on the proper behavior. Fixing this to continue panscrolling/panning to the parent would have 2 benefits: 1) It would make these ways of scrolling more like mousewheel scrolling. 2) It would make scrolling frames and iFrames functionally equivalent to scrolling divs with overflow. On the attached URL, go into one of the iFrames with scrollbars, and try mouse-wheeling and pan-scrolling to reproduce the behavior that is discussed here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:58:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:58:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812225819.98BB334C506C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #11 from Gavin Barraclough 2009-08-12 15:58:18 PDT --- Ah, I see. Fair enough. :-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:58:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:58:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28237] Pan Scrolling and Panning don't jump out of frames, while mouse wheel events do In-Reply-To: References: Message-ID: <20090812225843.7DA9834C507E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28237 Brian Weinstein changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |bweinstein at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:04:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:04:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812230401.60FD934C510D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #92 from Eric Seidel 2009-08-12 16:03:58 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/graphics/wince/ColorWince.cpp A WebCore/platform/graphics/wince/GradientWince.cpp Committed r47158 M WebCore/ChangeLog A WebCore/platform/graphics/wince/ColorWince.cpp A WebCore/platform/graphics/wince/GradientWince.cpp r47158 = 4c84387c23d3b46cd7698b406d8ce9d740430bcd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47158 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:04:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:04:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090812230404.65E8B34C5133@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Bug 27561 depends on bug 27511, which changed state. Bug 27511 Summary: Add WinCE specific platform/graphics files to WebCore https://bugs.webkit.org/show_bug.cgi?id=27511 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:08:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:08:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28234] AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRange is wrong in some cases In-Reply-To: References: Message-ID: <20090812230821.62A5634C51BF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28234 --- Comment #2 from Darin Adler 2009-08-12 16:08:20 PDT --- (From update of attachment 34698) To me this looks like a workaround for a bug in searchAheadForBetterMatch. Is it possible to fix searchAheadForBetterMatch instead? Are there other calls that would benefit from a fix to that function? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:08:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:08:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812230829.B1E9634C51D1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34615|commit-queue+ |commit-queue- Flag| | --- Comment #6 from Eric Seidel 2009-08-12 16:08:28 PDT --- (From update of attachment 34615) Rejecting patch 34615 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34615 from bug 28196 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:09:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:09:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812230948.E21FC34C520F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #7 from Eric Seidel 2009-08-12 16:09:47 PDT --- Oh, this patch was made from within WebCore instead of the top level directory. that's why it's failing: patching file WebCore/ChangeLog patch: **** malformed patch at line 20: patch -p0 "WebCore/ChangeLog" returned 2. Pass --force to ignore patch failures. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:10:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:10:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28234] AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRange is wrong in some cases In-Reply-To: References: Message-ID: <20090812231012.0BC0D34C521F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28234 --- Comment #3 from chris fleizach 2009-08-12 16:10:11 PDT --- i'll have to look at that method. i'm not sure how many other clients use the bounding boxes of text markers -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:10:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:10:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28234] AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRange is wrong in some cases In-Reply-To: References: Message-ID: <20090812231026.48C1F34C5227@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28234 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |cfleizach at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:10:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:10:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812231045.7CE7334C5235@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 --- Comment #8 from Eric Seidel 2009-08-12 16:10:44 PDT --- It seems that we could teach svn-apply to handle such patches, especially since the full path is actually in the patch. But maybe this patch is truly malformed? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:12:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:12:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812231235.0668034C52B9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #36 from Ryan Leavengood 2009-08-12 16:12:33 PDT --- (In reply to comment #35) > > Don't worry about this. Your patch has already been committed, and ours is > still pending. So I had to solve conflicts when I updated our repo. Sorry I did not realize our patch had already been committed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:14:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:14:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812231431.8CA6734C52FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34401|review+, commit-queue+ | Flag| | --- Comment #93 from Eric Seidel 2009-08-12 16:14:30 PDT --- (From update of attachment 34401) Hit bug 28230 again. multi-patch bugs still confuse our tools. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:15:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:15:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812231500.8559C34C5327@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #94 from Eric Seidel 2009-08-12 16:14:59 PDT --- Hit bug 28230 again. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:15:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:15:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090812231503.613EE34C534B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Bug 27561 depends on bug 27511, which changed state. Bug 27511 Summary: Add WinCE specific platform/graphics files to WebCore https://bugs.webkit.org/show_bug.cgi?id=27511 What |Old Value |New Value ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:20:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:20:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28233] Added symbian specific UID3 identifiers to project files In-Reply-To: References: Message-ID: <20090812232005.6778934C53EF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28233 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34694|review? |review+, commit-queue+ Flag| | --- Comment #1 from Eric Seidel 2009-08-12 16:20:04 PDT --- (From update of attachment 34694) You don't describe these very well: + Also, 2 additional properties need to be specified + for the QtLauncher executable in the project file, + conditionally for "symbian". The patch looks non-harmful though. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:23:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:23:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28107] gobject code generator library properties In-Reply-To: References: Message-ID: <20090812232329.6945034C543D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28107 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34463|review? |review- Flag| | --- Comment #6 from Eric Seidel 2009-08-12 16:23:29 PDT --- (From update of attachment 34463) These patches/bugs are being rejected per my email to webkit-dev regarding GDOM patch spam. Please read and reply as necessary to that email before submitting any further patches. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:23:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:23:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28107] gobject code generator library properties In-Reply-To: References: Message-ID: <20090812232337.B44D434C544B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28107 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:23:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:23:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812232341.C45BD34C547D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 28107, which changed state. Bug 28107 Summary: gobject code generator library properties https://bugs.webkit.org/show_bug.cgi?id=28107 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:25:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:25:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812232523.478BB34C54CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34701|review? |review+, commit-queue+ Flag| | --- Comment #24 from Eric Seidel 2009-08-12 16:25:20 PDT --- (From update of attachment 34701) Passing "read" or "write" instead of a bool would have made the callsites more clear, but this is OK as is. 28 function statementSuccessCallback(dbName, isReadStatement) 29 { 30 log(dbName + " " + (isReadStatement ? "read" : "write") + " statement succeeded"); 31 } 32 33 function statementErrorCallback(dbName, isReadStatement, error) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:40:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:40:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812234005.0986B34C5669@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Hin-Chung Lam changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34647|0 |1 is obsolete| | --- Comment #6 from Hin-Chung Lam 2009-08-12 16:40:04 PDT --- Created an attachment (id=34703) --> (https://bugs.webkit.org/attachment.cgi?id=34703) patch + test -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:40:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:40:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812234041.3213234C5690@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Hin-Chung Lam changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34703| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:41:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:41:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234144.0DD2034C56CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34704| |review? Flag| | --- Comment #3 from Eric Seidel 2009-08-12 16:41:42 PDT --- Created an attachment (id=34704) --> (https://bugs.webkit.org/attachment.cgi?id=34704) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:44:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:44:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234403.B556934C5719@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 --- Comment #4 from Darin Adler 2009-08-12 16:44:02 PDT --- (From update of attachment 34704) > + my $testsWhithDidNotMatch = $count - $counts{match}; Which? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:44:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:44:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234405.77EDC34C5731@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34704|review? | Flag| | Attachment #34704|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:44:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:44:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234409.1B1B234C5742@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34705| |review? Flag| | --- Comment #5 from Eric Seidel 2009-08-12 16:44:08 PDT --- Created an attachment (id=34705) --> (https://bugs.webkit.org/attachment.cgi?id=34705) Removed extra change -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:45:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:45:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234516.8710E34C5776@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34705|review? | Flag| | Attachment #34705|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:45:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:45:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234520.4562734C578B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34706| |review? Flag| | --- Comment #6 from Eric Seidel 2009-08-12 16:45:19 PDT --- Created an attachment (id=34706) --> (https://bugs.webkit.org/attachment.cgi?id=34706) Eric has always been reading disabled -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:46:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:46:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234649.BD64734C57BB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34706|Eric has always been |now with misspelling fixed description|reading disabled | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:48:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:48:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812234814.406FD34C57F0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34701|0 |1 is obsolete| | Attachment #34707| |review? Flag| | --- Comment #25 from Dumitru Daniliuc 2009-08-12 16:48:09 PDT --- Created an attachment (id=34707) --> (https://bugs.webkit.org/attachment.cgi?id=34707) patch + test case Addressed Eric's last comment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:48:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:48:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812234821.037CB34C5810@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34701|commit-queue+ |commit-queue- Flag| | --- Comment #26 from Eric Seidel 2009-08-12 16:48:17 PDT --- (From update of attachment 34701) Rejecting patch 34701 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34701 from bug 27966 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:49:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:49:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17956] possible write to freed memory in EventTargetNode::dispatchSimulatedMouseEvent() In-Reply-To: References: Message-ID: <20090812234943.CE24134C5838@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17956 David Kilzer (ddkilzer) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddkilzer at webkit.org, | |koivisto at iki.fi --- Comment #5 from David Kilzer (ddkilzer) 2009-08-12 16:49:42 PDT --- (In reply to comment #4) > The m_dispatchingSimulatedMouseEvent bool is gone from TOT. This bug can be > closed. The m_dispatchingSimulatedEvent bool was removed in r31767. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:49:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:49:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28239] New: bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28239 Summary: bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode It should not cq- minus patches when not in commit-queue mode. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:51:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:51:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812235127.5A97D34C58A6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34707|review? |review+, commit-queue+ Flag| | --- Comment #27 from Eric Seidel 2009-08-12 16:51:24 PDT --- (From update of attachment 34707) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:51:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:51:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812235141.A34D034C58CE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34707|commit-queue+ |commit-queue- Flag| | --- Comment #28 from Eric Seidel 2009-08-12 16:51:38 PDT --- (From update of attachment 34707) Rejecting patch 34707 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34707 from bug 27966 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:51:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:51:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812235158.6866634C58F2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #29 from Eric Seidel 2009-08-12 16:51:54 PDT --- Hunk #5 FAILED at 19315. 1 out of 5 hunks FAILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej patch -p0 "WebCore/WebCore.xcodeproj/project.pbxproj" returned 1. Pass --force to ignore patch failures. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:54:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:54:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812235433.32CBF34C5953@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34706|review? |review+ Flag| | --- Comment #7 from Mark Rowe (bdash) 2009-08-12 16:54:32 PDT --- (From update of attachment 34706) > diff --git a/WebKitTools/Scripts/run-webkit-tests b/WebKitTools/Scripts/run-webkit-tests > index 1f908ec..003ac8d 100755 > --- a/WebKitTools/Scripts/run-webkit-tests > +++ b/WebKitTools/Scripts/run-webkit-tests > @@ -109,6 +109,7 @@ sub writeToFile($$); > # Argument handling > my $addPlatformExceptions = 0; > my $complexText = 0; > +my $exitAfterNFailures = 0; > my $guardMalloc = ''; > my $httpdPort = 8000; > my $httpdSSLPort = 8443; > @@ -193,6 +194,7 @@ Usage: $programName [options] [testdir|testpath ...] > --complex-text Use the complex text code path for all text (Mac OS X and Windows only) > -c|--configuration config Set DumpRenderTree build configuration > -g|--guard-malloc Enable malloc guard > + --exit-after-n-failures Exit after the first N failures instead of running all the tests The help for this flag should indicate that it takes an argument. Is there any reason to put it at this point in the help? Are they in any specific order? > countFinishedTest($test, $base, $result, $isText); > + > + my $testsWhichDidNotMatch = $count - $counts{match}; > + if ($exitAfterNFailures && $testsWhichDidNotMatch >= $exitAfterNFailures) { > + print "\nExiting early after $testsWhichDidNotMatch failures. $count tests run."; > + closeDumpTool(); > + last; > + } $testsWhichDidNotMatch sounds like an array of tests that didn't match. Perhaps $failureCount would be a clearer variable name? r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:55:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:55:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812235543.D9FCF34C5975@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 --- Comment #8 from Eric Seidel 2009-08-12 16:55:42 PDT --- (In reply to comment #7) > (From update of attachment 34706 [details]) > > diff --git a/WebKitTools/Scripts/run-webkit-tests b/WebKitTools/Scripts/run-webkit-tests > > index 1f908ec..003ac8d 100755 > > --- a/WebKitTools/Scripts/run-webkit-tests > > +++ b/WebKitTools/Scripts/run-webkit-tests > > @@ -109,6 +109,7 @@ sub writeToFile($$); > > # Argument handling > > my $addPlatformExceptions = 0; > > my $complexText = 0; > > +my $exitAfterNFailures = 0; > > my $guardMalloc = ''; > > my $httpdPort = 8000; > > my $httpdSSLPort = 8443; > > @@ -193,6 +194,7 @@ Usage: $programName [options] [testdir|testpath ...] > > --complex-text Use the complex text code path for all text (Mac OS X and Windows only) > > -c|--configuration config Set DumpRenderTree build configuration > > -g|--guard-malloc Enable malloc guard > > + --exit-after-n-failures Exit after the first N failures instead of running all the tests > > The help for this flag should indicate that it takes an argument. Is there any > reason to put it at this point in the help? Are they in any specific order? It seemed they were in alphabetical order. But I'm happy to put it wherever. > > countFinishedTest($test, $base, $result, $isText); > > + > > + my $testsWhichDidNotMatch = $count - $counts{match}; > > + if ($exitAfterNFailures && $testsWhichDidNotMatch >= $exitAfterNFailures) { > > + print "\nExiting early after $testsWhichDidNotMatch failures. $count tests run."; > > + closeDumpTool(); > > + last; > > + } > > $testsWhichDidNotMatch sounds like an array of tests that didn't match. > Perhaps $failureCount would be a clearer variable name? Sounds fine to me. Will change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:59:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:59:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812235906.A599334C59E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34703|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:59:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:59:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] New: Allow applications to register their own local sheme. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28240 Summary: Allow applications to register their own local sheme. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yael.aharon at nokia.com Expose registerURLSchemeAsLocal from Qt API. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:00:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:00:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090813000015.148F234C59FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow applications to |Allow applications to |register their own local |register their own local |sheme. |URL scheme -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:00:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:00:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28233] Added symbian specific UID3 identifiers to project files In-Reply-To: References: Message-ID: <20090813000048.4173F34C5A23@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28233 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34694|commit-queue+ |commit-queue- Flag| | --- Comment #2 from Eric Seidel 2009-08-12 17:00:47 PDT --- (From update of attachment 34694) Rejecting patch 34694 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet --exit-after-n-failures=1 failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:01:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:01:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] [Qt] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090813000107.B99BC34C5A2F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow applications to |[Qt] Allow applications to |register their own local |register their own local |URL scheme |URL scheme -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:03:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:03:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813000358.C0A1034C5AA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34707|0 |1 is obsolete| | Attachment #34708| |review? Flag| | --- Comment #30 from Dumitru Daniliuc 2009-08-12 17:03:54 PDT --- Created an attachment (id=34708) --> (https://bugs.webkit.org/attachment.cgi?id=34708) patch + test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:04:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:04:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090813000400.8F69C34C5AAA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from Eric Seidel 2009-08-12 17:03:58 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/run-webkit-tests Committed r47166 M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/run-webkit-tests r47166 = 581871acba07344f98ea6b67c0be8ed60106d917 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47166 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:05:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:05:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] [Qt] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090813000516.C7EDF34C5AE3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34709| |review? Flag| | --- Comment #1 from Yael 2009-08-12 17:05:16 PDT --- Created an attachment (id=34709) --> (https://bugs.webkit.org/attachment.cgi?id=34709) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:06:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:06:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813000642.40B5534C5B0B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 --- Comment #7 from Simon Fraser (smfr) 2009-08-12 17:06:41 PDT --- Note that layout tests that use eventSender make assumptions about locations of buttons on the media controller that may not hold across platorms. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:09:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:09:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813000933.E480634C5B75@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 --- Comment #8 from Eric Carlson 2009-08-12 17:09:33 PDT --- https://bugs.webkit.org/show_bug.cgi?id=28220 will fix the problem Simon mentioned, but for now you may need to land platform specific test results. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:17:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:17:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813001700.E87D534C5C63@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34708|review? |review+, commit-queue+ Flag| | --- Comment #31 from Eric Seidel 2009-08-12 17:16:57 PDT --- (From update of attachment 34708) We'll try another round. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:17:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:17:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27596] Inspector: Console Object Property Subtitle's Display Poorly In-Reply-To: References: Message-ID: <20090813001739.6A5AE34C5C6B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27596 --- Comment #1 from Timothy Hatcher 2009-08-12 17:17:38 PDT --- I don't fully understand the issue. Screenshots? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:18:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:18:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28236] Inspector: Doesn't Respect javascript's const keyword In-Reply-To: References: Message-ID: <20090813001815.83E5B34C5C7D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28236 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver at apple.com --- Comment #2 from Timothy Hatcher 2009-08-12 17:18:14 PDT --- Oliver, thoughts? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:20:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:20:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28236] Inspector: Doesn't Respect javascript's const keyword In-Reply-To: References: Message-ID: <20090813002050.36D3334C5CB1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28236 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #3 from Oliver Hunt 2009-08-12 17:20:49 PDT --- Yeah this is a known bug with eval -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:21:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:21:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28236] Eval doesn't respect JavaScript's const keyword In-Reply-To: References: Message-ID: <20090813002149.E188534C5CFB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28236 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Web Inspector |JavaScriptCore Summary|Inspector: Doesn't Respect |Eval doesn't respect |javascript's const keyword |JavaScript's const keyword -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:23:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:23:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090813002353.2D7C134C5D3B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #26 from Eric Seidel 2009-08-12 17:23:51 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/dom/Geolocation/enabled-expected.txt A LayoutTests/fast/dom/Geolocation/enabled.html A LayoutTests/fast/dom/Geolocation/resources/TEMPLATE.html A LayoutTests/fast/dom/Geolocation/resources/enabled.js M LayoutTests/platform/mac/Skipped Committed r47168 M LayoutTests/platform/mac/Skipped M LayoutTests/ChangeLog A LayoutTests/fast/dom/Geolocation/enabled-expected.txt A LayoutTests/fast/dom/Geolocation/resources/enabled.js A LayoutTests/fast/dom/Geolocation/resources/TEMPLATE.html A LayoutTests/fast/dom/Geolocation/enabled.html r47168 = 4c2f9fcb3b4be28142507c551e59d825778c701a (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47168 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:26:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:26:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813002651.1F4F734C5D71@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Albert J. Wong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34703| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:31:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:31:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090813003114.23A4234C5DFB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | AssignedTo|webkit-unassigned at lists.web |eric at webkit.org |kit.org | --- Comment #27 from Mark Rowe (bdash) 2009-08-12 17:31:12 PDT --- doesn't include the changes to qt/Skipped or win/Skipped. Presumably this should also be skipped for GTK too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:33:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:33:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] New: Media controls panel does not have a volume control slider Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28241 Summary: Media controls panel does not have a volume control slider Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hclam at google.com Open a page with in WebKit, there should be a volume control slider. It may not need to be turned on by default since WebKit mac port uses the quick time layout, but it should be at least configurable via css. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:39:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:39:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090813003928.8F8E134C5EEB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 --- Comment #9 from Kyle Prete 2009-08-12 17:39:26 PDT --- Is it? This is only my second time submitting a patch to Webkit. If I've made a mistake, please let me know so I can fix it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:51:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:51:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813005105.642AE34C600A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34708|commit-queue+ |commit-queue- Flag| | --- Comment #32 from Eric Seidel 2009-08-12 17:51:01 PDT --- (From update of attachment 34708) Rejecting patch 34708 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:51:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:51:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813005142.7B59934C6034@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #33 from Eric Seidel 2009-08-12 17:51:39 PDT --- The following files contain tab characters: trunk/WebCore/ChangeLog Please use spaces instead to indent. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:53:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:53:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813005305.9258834C6082@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #34 from Eric Seidel 2009-08-12 17:53:01 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/storage/multiple-transactions-on-different-handles-expected.txt A LayoutTests/storage/multiple-transactions-on-different-handles.html M WebCore/ChangeLog M WebCore/GNUmakefile.am M WebCore/WebCore.gypi M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/storage/Database.cpp M WebCore/storage/Database.h M WebCore/storage/DatabaseThread.cpp M WebCore/storage/DatabaseThread.h M WebCore/storage/SQLTransaction.cpp M WebCore/storage/SQLTransaction.h A WebCore/storage/SQLTransactionCoordinator.cpp A WebCore/storage/SQLTransactionCoordinator.h Committed r47170 M WebCore/storage/DatabaseThread.h M WebCore/storage/SQLTransaction.cpp M WebCore/storage/Database.h A WebCore/storage/SQLTransactionCoordinator.cpp M WebCore/storage/DatabaseThread.cpp M WebCore/storage/Database.cpp M WebCore/storage/SQLTransaction.h A WebCore/storage/SQLTransactionCoordinator.h M WebCore/ChangeLog M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/GNUmakefile.am M WebCore/WebCore.gypi M WebCore/WebCore.xcodeproj/project.pbxproj M LayoutTests/ChangeLog A LayoutTests/storage/multiple-transactions-on-different-handles-expected.txt A LayoutTests/storage/multiple-transactions-on-different-handles.html r47170 = 02db11b4350373f83f85041c33de18fb7410ec8b (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47170 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:53:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:53:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813005319.D59CA34C60AF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #35 from Eric Seidel 2009-08-12 17:53:15 PDT --- Fixed and landed manually. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:58:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:58:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20709] Implement HTML 5's HTMLElement.classList property In-Reply-To: References: Message-ID: <20090813005822.ADAE134C6119@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20709 --- Comment #8 from Sylvain Pasche 2009-08-12 17:58:20 PDT --- This feature was recently implemented in Gecko. You may be interested in the automated test [1] that could be easily transformed into a layout test. There are a few Gecko-isms that would need to be removed and you would need to provide is()/ok() implementations. In the current spec the mutating methods (add/remove/toggle) are preserving whitespace. There was some discussions about an alternative approach of normalizing whitespace, which could make implementation more straightforward [2]. That change wasn't made for now, but if you think it would be better to go that way that's something that could be considered. [1] http://hg.mozilla.org/mozilla-central/file/tip/content/base/test/test_classList.html [2] http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-July/021653.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:59:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:59:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090813005953.1989034C6143@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Andre Klapper changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a9016009 at gmx.de --- Comment #9 from Andre Klapper 2009-08-12 17:59:51 PDT --- (In reply to comment #8) > See my comments in the mail to you. I did not receive that email. For the sake of transparency please keep technical debates in public comments. Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:00:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:00:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27596] Inspector: Console Object Property Subtitle's Display Poorly In-Reply-To: References: Message-ID: <20090813010010.91EEC34C615C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27596 --- Comment #2 from Joseph Pecoraro 2009-08-12 18:00:09 PDT --- Created an attachment (id=34710) --> (https://bugs.webkit.org/attachment.cgi?id=34710) Image Showing Problem Here is the problem shown in a few different ways. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:00:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:00:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090813010010.E624234C6162@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 Andre Klapper changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a9016009 at gmx.de --- Comment #15 from Andre Klapper 2009-08-12 18:00:09 PDT --- (In reply to comment #14) > (From update of attachment 34468 [details]) > See my comments in the mail to you. I did not receive that email. For the sake of transparency please keep technical debates in public comments. Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:00:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:00:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813010049.4706234C617A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34703|review+, commit-queue+ | Flag| | --- Comment #9 from Eric Seidel 2009-08-12 18:00:48 PDT --- (From update of attachment 34703) Clearing flags on attachment: 34703 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/media/controls-drag-timebar-expected.txt A LayoutTests/media/controls-drag-timebar.html M WebCore/ChangeLog M WebCore/rendering/MediaControlElements.cpp Committed r47171 M WebCore/ChangeLog M WebCore/rendering/MediaControlElements.cpp A LayoutTests/media/controls-drag-timebar-expected.txt A LayoutTests/media/controls-drag-timebar.html M LayoutTests/ChangeLog r47171 = 5d54d4d1aa0dd34b843952ff291dcdbf59c39a24 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47171 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:00:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:00:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813010053.BDA0234C6196@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #10 from Eric Seidel 2009-08-12 18:00:52 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:04:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:04:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090813010422.6774634C621C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 --- Comment #16 from Eric Seidel 2009-08-12 18:04:21 PDT --- A second mail was sent to webkit-dev, which is public. https://lists.webkit.org/pipermail/webkit-dev/2009-August/009456.html The first mail, mentioned above, was not a technical discussion, but rather a private disparagement for having spammed the patch system. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:07:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:07:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090813010755.B83D634C6284@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34618|review+, commit-queue+ | Flag| | --- Comment #9 from Eric Seidel 2009-08-12 18:07:54 PDT --- (From update of attachment 34618) Clearing flags on attachment: 34618 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/canvas/canvas-zoom.html M WebCore/ChangeLog M WebCore/rendering/RenderHTMLCanvas.cpp M WebCore/rendering/RenderReplaced.cpp Committed r47172 M WebCore/ChangeLog M WebCore/rendering/RenderHTMLCanvas.cpp M WebCore/rendering/RenderReplaced.cpp M LayoutTests/ChangeLog A LayoutTests/fast/canvas/canvas-zoom.html r47172 = 02e5f59486ffcc081f9d82d6bc99a675c2fbe394 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47172 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:08:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:08:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090813010800.1A5C634C629A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #10 from Eric Seidel 2009-08-12 18:07:58 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:13:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:13:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28242] New: [Qt] Crash when performing XHR preflight request Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28242 Summary: [Qt] Crash when performing XHR preflight request Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yael.aharon at nokia.com QtNetwork does not yet support the HTTP method Options, thus a crash occurs when an Options request is made during XHR preflight request. A patch with a temporary fix will be attached soon, to prevent the crash, until QtNetwork does start supporting Options method. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:17:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:17:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28242] [Qt] Crash when performing XHR preflight request In-Reply-To: References: Message-ID: <20090813011754.BD09234C6390@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28242 --- Comment #1 from Yael 2009-08-12 18:17:54 PDT --- Sample test page to reproduce the crash. (should be loaded from the web)

send XHR

-- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:32:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:32:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27596] Inspector: Console Object Property Subtitle's Display Poorly In-Reply-To: References: Message-ID: <20090813013231.BC04834C64D5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27596 --- Comment #3 from Timothy Hatcher 2009-08-12 18:32:31 PDT --- I see, these are ugly and bad. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:36:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:36:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25524] [Gtk] Expose the title attribute to assistive technologies In-Reply-To: References: Message-ID: <20090813013644.1F79B34C6541@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25524 --- Comment #22 from Gustavo Noronha (kov) 2009-08-12 18:36:41 PDT --- (In reply to comment #21) > (In reply to comment #19) > > I'm not familiar with the WebKit regression tests or what's being done in terms > > of WebKitGtk+ accessibility versus platform-independent accessibility, so I'll > > leave it to someone else to comment. > > > > Thanks! > > About this particular bit... we want to be able to run all crossplatform tests > (when bug #25989 is fixed), and we also have some gtk+ specific tests in place > to test our own stuff (for example, I added tests to check that we do the right > thing for the ATK get_text_{at,after,before}_offset methods). In this > particular case it looks like we want to modify the crossplatform behavior, so > we'd need to change the crossplatform tests if we convince everyone else. Though I think it would be OK to ifdef this specific case, if we agree to disagree on this, and keep these themes skipped in GTK+, having GTK+-specific tests instead. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:46:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:46:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28244] New: Logout doesn't work for some sites Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28244 Summary: Logout doesn't work for some sites Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: timmc at microsoft.com On SharePoint and as demonstrated by many posts on the web, Safari has problem handling the logout process for many websites: http://www.the-art-of-web.com/system/safari-broken-logout/ http://bbpress.org/forums/topic/safari-cant-log-out http://www.hostmonsterforum.com/showthread.php?t=5887 http://drupal.org/node/217482 It appears as though Safari is not consistent about refreshing credentials for 401 responses or HTTP Connection: Close. http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 I was unable to find related bugs in the database. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:49:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:49:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813014906.7396B34C6679@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Dmitry Titov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dimich at chromium.org --- Comment #11 from Dmitry Titov 2009-08-12 18:49:04 PDT --- It turned out that expected.txt is different for windows so landed http://trac.webkit.org/changeset/47174 to split the results. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 19:58:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 19:58:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090813025850.5DB1734C6BFB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #33 from George Staikos 2009-08-12 19:58:48 PDT --- Checked in as r47176. If the CSSValueKeywords.in change is an issue, we should back it out and find a solution but right now I can't find a reason against it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 19:59:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 19:59:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28242] [Qt] Crash when performing XHR preflight request In-Reply-To: References: Message-ID: <20090813025940.7812F34C6C0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28242 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE --- Comment #2 from Yael 2009-08-12 19:59:40 PDT --- This crash was actually fixed already. Marking this bug as duplicate. *** This bug has been marked as a duplicate of bug 26969 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 19:59:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 19:59:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26969] Fix ASSERT in WebCore::DocumentThreadableLoader::didFail In-Reply-To: References: Message-ID: <20090813025942.796BC34C6C27@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26969 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yael.aharon at nokia.com --- Comment #11 from Yael 2009-08-12 19:59:40 PDT --- *** Bug 28242 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 20:01:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 20:01:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28232] "Null after navigation" in major-objects.html is unclear In-Reply-To: References: Message-ID: <20090813030125.B93A934C6C4F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28232 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34693|review? |review+ Flag| | --- Comment #2 from Adam Barth 2009-08-12 20:01:24 PDT --- (From update of attachment 34693) Excellent! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 20:04:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 20:04:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28239] bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode In-Reply-To: References: Message-ID: <20090813030412.B0E3034C6C81@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28239 --- Comment #1 from Adam Barth 2009-08-12 20:04:11 PDT --- Sorry. I should caught that when reviewing the earlier change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 20:41:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 20:41:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090813034130.3574C34C6FAC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 --- Comment #10 from David Levin 2009-08-12 20:41:27 PDT --- Kyle, I think you fixed this issue :"It should have WebCore/ prefixed before each file." by hand, which is ok but you need to fix every file name, Note that there is --- ChangeLog (revision 47069) +++ ChangeLog (working copy) in the patch, for example. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:32:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:32:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28245] New: findNextLineBreak crashes when inserting a blank span in front of a long line Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28245 Summary: findNextLineBreak crashes when inserting a blank span in front of a long line Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: parmanoir at gmail.com Created an attachment (id=34714) --> (https://bugs.webkit.org/attachment.cgi?id=34714) Test case, will crash nightly when clicking the button When using range.insertNode to add a SPAN in a DIV containing repeating non-breaking characters and a line break, Safari crashes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:34:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:34:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28245] findNextLineBreak crashes when inserting a blank span in front of a long line In-Reply-To: References: Message-ID: <20090813043430.BF62E34C747F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28245 --- Comment #1 from Patrick Geiller 2009-08-12 21:34:30 PDT --- bug #18282 also crashes in findNextLineBreak, but with a different stack trace. Here's this bug's stack trace. 0 com.apple.WebCore 0x0145bd75 WebCore::RenderBlock::findNextLineBreak(WebCore::BidiResolver&, bool, bool&, bool&, WebCore::EClear*) + 5445 1 com.apple.WebCore 0x0145dce4 WebCore::RenderBlock::layoutInlineChildren(bool, int&, int&) + 2180 2 com.apple.WebCore 0x01451e0a WebCore::RenderBlock::layoutBlock(bool) + 570 3 com.apple.WebCore 0x01443778 WebCore::RenderBlock::layout() + 40 4 com.apple.WebCore 0x01451352 WebCore::RenderBlock::layoutBlockChildren(bool, int&) + 914 5 com.apple.WebCore 0x014522dc WebCore::RenderBlock::layoutBlock(bool) + 1804 6 com.apple.WebCore 0x01443778 WebCore::RenderBlock::layout() + 40 7 com.apple.WebCore 0x01451352 WebCore::RenderBlock::layoutBlockChildren(bool, int&) + 914 8 com.apple.WebCore 0x014522dc WebCore::RenderBlock::layoutBlock(bool) + 1804 9 com.apple.WebCore 0x01443778 WebCore::RenderBlock::layout() + 40 10 com.apple.WebCore 0x01451352 WebCore::RenderBlock::layoutBlockChildren(bool, int&) + 914 11 com.apple.WebCore 0x014522dc WebCore::RenderBlock::layoutBlock(bool) + 1804 12 com.apple.WebCore 0x01443778 WebCore::RenderBlock::layout() + 40 13 com.apple.WebCore 0x01451352 WebCore::RenderBlock::layoutBlockChildren(bool, int&) + 914 14 com.apple.WebCore 0x014522dc WebCore::RenderBlock::layoutBlock(bool) + 1804 15 com.apple.WebCore 0x01443778 WebCore::RenderBlock::layout() + 40 16 com.apple.WebCore 0x014f8b6a WebCore::RenderView::layout() + 250 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:42:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:42:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28246] New: [Qt] storage/SQLTransactionCoordinator.[h, cpp] not in WebCore.pro Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28246 Summary: [Qt] storage/SQLTransactionCoordinator.[h,cpp] not in WebCore.pro Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: george.wright at torchmobile.com WebKitQt fails 15 storage tests as changeset #47170 for bug #27966 omitted the entries for storage/SQLTransactionCoordinator.cpp and storage/SQLTransactionCoordinator.h in WebCore.pro. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:44:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:44:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28246] [Qt] storage/SQLTransactionCoordinator.[h, cpp] not in WebCore.pro In-Reply-To: References: Message-ID: <20090813044455.9862B34C756F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28246 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34715| |review? Flag| | --- Comment #1 from George Wright 2009-08-12 21:44:55 PDT --- Created an attachment (id=34715) --> (https://bugs.webkit.org/attachment.cgi?id=34715) Amend WebCore.pro This patch adds storage/SQLTransactionCoordinator.cpp and storage/SQLTransactionCoordinator.h to WebCore.pro. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:45:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:45:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28246] [Qt] storage/SQLTransactionCoordinator.[h, cpp] not in WebCore.pro In-Reply-To: References: Message-ID: <20090813044537.C4B1534C7583@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28246 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34715|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:45:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:45:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813044553.920E434C7589@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #12 from Luke Smith 2009-08-12 21:45:52 PDT --- I was unaware of this feature until reading your comment. This behavior is not in the spec. section 9.11 specifies IsCallable If the argument object has an [[Call]] internal method, then return true, otherwise return false. The only references in the spec to setting the [[Call]] internal method are 13.2 Creating Function objects 13.2.3 The [[ThrowTypeError]] Function Object 15.3.4.5 Function.prototype.bind (thisArg [, arg1 [, arg2, ?]]) Section 15.10.6, defining RegExp, states The value of the [[Prototype]] internal property of the RegExp prototype object is the standard built-in Object prototype object (15.2.4) I found that /a/("abc") is implemented (inconsistently) in Firefox 3.0, Firefox 3.5, Safari 3.2.1, Safari 4, Opera 9.6.3, Opera 10 beta2, Chrome 3 beta, and the WebKit nightlies. It is not implemented in IE6, IE7, IE8, or Chrome 2. Mozilla identifies this feature as a JavaScript extension https://developer.mozilla.org/en/Core_JavaScript_1.5_Reference/Global_Objects/RegExp#RegExp_instances I infer that such is the case for the others, WebKit included. The difference here being that the other browser vendors prevent the spec deviation from rippling through their implementation to (at least) typeof and recently to JSON.stringify. Currently native JSON support is present in Firefox 3.5, IE8, Chrome 3 beta, and recent WebKit nightlies. All three of the other currently implementing browsers agree both that typeof /a/ == 'object' and JSON.stringify(/a/) == '{}'. There is value in interoperability. If not typeof, please at least stringify RegExp instances as objects for the sake of convention. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:47:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:47:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28246] [Qt] storage/SQLTransactionCoordinator.[h, cpp] not in WebCore.pro In-Reply-To: References: Message-ID: <20090813044704.0EA6434C75A5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28246 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |staikos at kde.org Resolution| |FIXED --- Comment #2 from George Staikos 2009-08-12 21:47:03 PDT --- Checked in r47180 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:52:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:52:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27202] Inspector: Cookies in Storage Panel In-Reply-To: References: Message-ID: <20090813045238.797E634C762B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27202 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |abarth at webkit.org Resolution| |FIXED --- Comment #15 from Adam Barth 2009-08-12 21:52:36 PDT --- http://trac.webkit.org/changeset/47181 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:00:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:00:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28232] "Null after navigation" in major-objects.html is unclear In-Reply-To: References: Message-ID: <20090813050055.602D434C76D4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28232 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34693|review+ | Flag| | --- Comment #3 from Adam Barth 2009-08-12 22:00:54 PDT --- (From update of attachment 34693) Clearing flags on attachment: 34693 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitSite/ChangeLog M WebKitSite/coding/major-objects.html Committed r47182 M WebKitSite/ChangeLog M WebKitSite/coding/major-objects.html r47182 = 9f401117450f829c83ec4f0940e4918f455e7d31 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47182 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:01:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:01:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28232] "Null after navigation" in major-objects.html is unclear In-Reply-To: References: Message-ID: <20090813050107.A787234C76E4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28232 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from Adam Barth 2009-08-12 22:01:06 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:23:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:23:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28174] Profile view status bar buttons are blank In-Reply-To: References: Message-ID: <20090813052351.80A5334C7884@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28174 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck02 at gmail.com --- Comment #4 from Joseph Pecoraro 2009-08-12 22:23:51 PDT --- Mikhail this is pretty awesome! Heads up on a few other buttons. - delete button in DOMStorageItemsView.js. - delete button in CookieItemsView.js. (just added) The Refresh button has not yet been converted to a glyph, but both of those files have a refresh button as well if you feel they are applicable. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:26:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:26:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813052610.A1C3F34C78B6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #13 from Oliver Hunt 2009-08-12 22:26:10 PDT --- > Currently native JSON support is present in Firefox 3.5, IE8, Chrome 3 beta, > and recent WebKit nightlies. All three of the other currently implementing > browsers agree both that typeof /a/ == 'object' and JSON.stringify(/a/) == > '{}'. There is value in interoperability. If not typeof, please at least > stringify RegExp instances as objects for the sake of convention. RegExps are callable -- breaking this would break compatibility with json2.js, and the bug is in mozilla for not correctly treating a callable object as callable. We cannot reasonably serialise regexps as standard objects -- the bug is in firefox, not webkit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:28:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:28:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090813052856.DCE2634C78FA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #12 from Gavin Barraclough 2009-08-12 22:28:55 PDT --- Sorry about that, should be fixed now in r47183. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:30:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:30:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090813053058.60D7334C7944@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34641|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:45:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:45:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28174] Profile view status bar buttons are blank In-Reply-To: References: Message-ID: <20090813054547.B7B8334C7A71@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28174 --- Comment #5 from Pavel Feldman 2009-08-12 22:45:47 PDT --- > The Refresh button has not yet been converted to a glyph, but both of those > files have a refresh button as well if you feel they are applicable. There is an Images/reloadButtonGlyph.png in place, it is just that .refresh-storage-status-bar-item was not updated to use it. Mikhail, could you add the fix into your patch? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:49:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:49:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28247] New: [Chromium] Numpad keys and a manu key don't work in render view Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28247 Summary: [Chromium] Numpad keys and a manu key don't work in render view Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hbono at chromium.org CC: evan at chromium.org, estade at chromium.org (Copied from .) Chrome Version : 3.0.197.11-r22553 OS + version : Debian Lenny CPU architecture (32-bit / 64-bit): 32 window manager : KDE URLs (if applicable) : Behavior in Firefox 3.x (if applicable): Numpad arrow keys work Behavior in Chrome for Windows (optional): Numpad arrow keys work Goto to any page and just try to use the numpad keys to navigate (with the NumLock off). They don't work. They DO however work in the address bar. The numpad arrows work in all other applications, including GTK ones (e.g. Firefox). Please provide any additional information below. Attach a screenshot and backtrace if possible. WebCore::windowsKeyCodeForKeyEvent() (in "WebCore/platform/chromium/KeyCodeConversionGtk.cpp") doesn't have mappings for many numpad keys (e.g. GDK_KP_Up, GDK_KP_Down, etc.) and cannot send numpad-key events to a web page. Neither does "WebCore/platform/gtk/KeyEventGdk.cpp" have them. Also, they map GDK_Menu to VKEY_MENU, which is a virtual key-code for alt keys. To improve compatibility with Windows, it is better to map GDK_Menu to VKEY_APPS, which is a virtual key-code for a menu key. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:49:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:49:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090813054909.CA51A34C7AEC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 Joe Mason changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34307|0 |1 is obsolete| | Attachment #34716| |review? Flag| | --- Comment #30 from Joe Mason 2009-08-12 22:49:08 PDT --- Created an attachment (id=34716) --> (https://bugs.webkit.org/attachment.cgi?id=34716) build fixes and minor bug fixes, with more comments > Are you sure that min will compile on other platforms? I feel like we've > dealt with the min/max issue on windows before in other ways. Please grep the > source to see how it's dealt with elsewhere. The more common methods of dealing with the windows min/max macros won't work here because the two parameters to min have different types (int and UChar32), so Windows gives an error about ambiguous template parameters. min will definitely compile on other platforms (it's just giving the template parameter explicitly instead of letting the compiler work it out), but I changed the fix anyway because I felt it was clearer - now it explicitly casts the UChar32 to an int. > This needs a why comment: > 29 #if !PLATFORM(WINCE) > 227230 mutable SCRIPT_CACHE m_scriptCache; > 228231 mutable SCRIPT_FONTPROPERTIES* m_scriptFontProperties; > 229232 #endif > your note about it saving space in the ChangeLog is a fine comment, just put it > in teh soruce code too. Done. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:58:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:58:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090813055853.E065734C7C38@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #103 from Gavin Barraclough 2009-08-12 22:58:46 PDT --- Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/ARMAssembler.cpp Sending JavaScriptCore/assembler/ARMAssembler.h Sending JavaScriptCore/assembler/ARMv7Assembler.h Sending JavaScriptCore/assembler/AbstractMacroAssembler.h Sending JavaScriptCore/assembler/AssemblerBufferWithConstantPool.h Sending JavaScriptCore/assembler/MacroAssemblerARM.h Sending JavaScriptCore/assembler/X86Assembler.h Sending JavaScriptCore/jit/JIT.h Sending JavaScriptCore/jit/JITCall.cpp Sending JavaScriptCore/jit/JITInlineMethods.h Sending JavaScriptCore/jit/JITPropertyAccess.cpp Transmitting file data ............ Committed revision 47186. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 23:08:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 23:08:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27827] [Chromium] Functions Keys don't work in google spreadsheet. In-Reply-To: References: Message-ID: <20090813060844.E48B734C7D0B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27827 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34444|review? |review- Flag| | --- Comment #5 from Eric Seidel 2009-08-12 23:08:42 PDT --- (From update of attachment 34444) Looks fine. Except the results should not be in platform/mac, but rather right next to the test. At least I don't think this test is platform specific, is it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 23:26:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 23:26:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813062638.395C034C7E7D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #14 from Luke Smith 2009-08-12 23:26:37 PDT --- > breaking this would break compatibility with json2.js Can you explain this? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 23:45:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 23:45:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813064540.E5ABE34C7FF0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 Raphael Speyer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rspeyer at gmail.com --- Comment #15 from Raphael Speyer 2009-08-12 23:45:40 PDT --- (In reply to comment #13) > RegExps are callable -- breaking this would break compatibility with json2.js, > and the bug is in mozilla for not correctly treating a callable object as > callable. I think there is an important distinction between a vendor extension to EcmaScript to allow an object to be treated as a function, and the meaning of IsCallable in the spec. As Luke mentioned above, according to the spec, a IsCallable is false for RegExp's, and thus they should be serialised by JSON.stringify, in 15.12.3 step 10. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 23:48:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 23:48:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813064833.3212A34C8038@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #16 from Raphael Speyer 2009-08-12 23:48:32 PDT --- (In reply to comment #15) > As Luke mentioned above, according to the spec, a IsCallable is false for > RegExp's, and thus they should be serialised by JSON.stringify, in 15.12.3 step > 10. That is, step 10 of the Str operation. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:07:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:07:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090813070709.30D1434C826A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 --- Comment #6 from Shinichiro Hamaji 2009-08-13 00:07:08 PDT --- (In reply to comment #5) > (From update of attachment 34638 [details]) > Nm, I'll leave this for Shinichiro to commit. I still don't have committer access. It's taking surprisingly long time due to several reason... So, could someone check this in? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:19:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:19:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813071921.D551E34C8372@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #17 from Oliver Hunt 2009-08-13 00:19:20 PDT --- (In reply to comment #16) > (In reply to comment #15) > > > As Luke mentioned above, according to the spec, a IsCallable is false for > > RegExp's, and thus they should be serialised by JSON.stringify, in 15.12.3 step > > 10. > > That is, step 10 of the Str operation. json2.js uses typeof holder === "function" to determine whether an object IsCallable, and regexp instances have the type "function". This is correct behaviour, per ES5 (from ES262, v5, 11.4.3) Object (native and doesn?t implement [[Call]]) -> "object" Object (native or host and implements [[Call]]) -> "function" IsCallable is defined in section 9.11: If the argument object has an [[Call]] internal method, then return true, otherwise return false. In other words, a RegExp instance has [[Call]] so typeof should be "function", and [[IsCallable]] is true. You seem to believe that there is value in serialising a regexp object, when there is not -- a serialised regexp object is either undefined (in conforming implementations in which regexps are callable) or as the empty object {} (in conforming implementations in whichs regexps are not callable). Firefox is not conforming in this regard. Arguing will not accopmlish anything as it is pointless to add a slow check which will break behaviour relative to json2, just to handle the specific case of RegExps, when there are numerous other disagreements between different runtimes as to which objects are callable (NodeLists anyone?), especially given the serialisation of RegExps is unhelpful in either case. If you feel really strongly about this, i suggest you go to http://bugs.mozilla.org and file a bug on the spidermonkey RegExp object incorrectly reporting typeof as "object" and claiming not to be callable. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:23:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:23:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code In-Reply-To: References: Message-ID: <20090813072337.6BB3034C83D4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27967 --- Comment #11 from Michael Nordman 2009-08-13 00:23:35 PDT --- 187 'storage/SQLTransactionClientImpl.cpp', Some of the make files make reference to SQLTransactionClientImpl.cpp, did you mean SQLTransactionClient.cpp here? 330 m_transactionClient->databaseSizeChanged(m_database.get()); So this method is invoked on the background db thread. 392 m_shouldRetryCurrentStatement = m_transactionClient->databaseExceedsQuota(...); And this one on the 'apartment' thread of the Database object (the main thread) 426 m_transactionClient->databaseChanged(m_database.get()); And this one on the background thread I would appreciate some indication of the threading usage in the SQLTransactionListener source files. To figure out how it was used, i had to track down the callsites. Not sure how to best indicate the threading rules... either doc comments in the .h file, or runtime asserts in the .cpp file? 38 // A "listener" interface to the SQLTransaction class. Allows 39 // SQLTransaction to notify interested parties when certain things are 40 // happening in a transaction. 41 class SQLTransactionClient { 42 public: 43 // Notifies everybody that the database has changed. Called at the end 44 // end of every successful transaction. 45 void databaseChanged(Database*); 46 47 // Notifies everybody that the size of the database file might have changed. 48 // Called after executing each statement in a transaction 49 void databaseSizeChanged(Database*); 50 51 // Notifies everybody that the size of the database file exceeds its quota. 52 // If this method returns true, the current statement in the transaction is 53 // retried. Otherwise, the transaction is rolled back. 54 // 55 // This method should return true if and only if the quota for this database 56 // file was increased (by the user, for example) since calling this method. 57 bool databaseExceedsQuota(Database*); 58 }; 59 } After reading your doc comments, maybe these methods could be renamed for clarity. void didCommitTransaction(...); // for databaseChanged void didExecuteStatement(...); // for databaseSizeChanged bool didExceedQuota(...); // for databaseExceedsQuota And would it make sense to have the SQLTransaction* be the parameter since it is a transaction listener, the caller can get the Database* from the accessor on the transaction object (i think). Also, the new class (TransactionCoordinator) you just added is also a transaction listener of sorts. Should these two classes be merged? The TransactionCoordinator must be owned by the DBThread to properly serve its purpose. In this patch, you have the new 'listener' object being owned by the Database object, but i think it could just as easily be owned by the DBThread and serve its purpose. Wdyt? 60 RefPtr origin = database->securityOriginCopy(); Making a copy of a refcounted object looks odd? Is it mutable? Is there no database->securityOrigin() accessor? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:35:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:35:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27768] SVG feComponentTransfer needs to be implemented In-Reply-To: References: Message-ID: <20090813073530.2527334C850A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27768 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34427|review? | Flag| | --- Comment #5 from Dirk Schulze 2009-08-13 00:35:28 PDT --- (From update of attachment 34427) clearing review tag. I'll upload a more efficient version after the patch on bug 28133 is ready. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:52:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:52:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28248] New: Reloading frames in Safari 4 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28248 Summary: Reloading frames in Safari 4 Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Frames AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: igd at methyl.demon.co.uk Reloading frames in Safari 4.0.3 still does not work correctly. Try this: 1. Go to the following frames-based test site: http://methyl1.demonweb.co.uk/safari4/safari.html 2. The site opens with the RED page on the right. 3. Click the 'BLUE PAGE' link as an example. 4. When the 'BLUE' page has loaded, click the 'Reload' button. The 'BLUE' page does NOT reload; instead we are taken back to the original 'RED' page !! Reloading these pages works perfectly well in Safari 3 and all other browsers. I have reported this bug to Apple several times but to no avail. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:56:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:56:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813075618.35BBD34C86C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #18 from Raphael Speyer 2009-08-13 00:56:17 PDT --- (In reply to comment #17) > > json2.js uses typeof holder === "function" to determine whether an object > IsCallable, That seems reasonable to me. > and regexp instances have the type "function". I think this is the crux of the issue. I know that webkit gives typeof /a/ === 'function', but I don't understand why. The spec does not say anywhere that a RegExp defines the internal property [[Call]]. > This is correct > behaviour, per ES5 (from ES262, v5, 11.4.3) > Object (native and doesn?t implement [[Call]]) -> "object" > Object (native or host and implements [[Call]]) -> "function" > Exactly. So, wouldn't RegExp's fall into the first category? Yes, they can be treated as functions, but that's a particular vendor extension, it's not how RegExp instances are specified to behave. > IsCallable is defined in section 9.11: > If the argument object has an [[Call]] internal method, then return true, > otherwise > return false. Right, and again, as per the spec, a RegExp does not have a [[Call]] internal method. > > In other words, a RegExp instance has [[Call]] so typeof should be "function", > and [[IsCallable]] is true. > I think we forked back at /a/('a') implying that at a specification level, [[Call]] is defined for RegExp's. > You seem to believe that there is value in serialising a regexp object, when > there is not -- a serialised regexp object is either undefined (in conforming > implementations in which regexps are callable) or as the empty object {} (in > conforming implementations in whichs regexps are not callable). > Granted, it's not going to be typical, and I can't actually think of a very good use case for it myself. However enumerable properties can be defined on RegExp's or their prototype, as can the toJSON method. I think this is more about conformance with the spec. > Firefox is not conforming in this regard. Arguing will not accopmlish anything > as it is pointless to add a slow check which will break behaviour relative to > json2, just to handle the specific case of RegExps, when there are numerous > other disagreements between different runtimes as to which objects are callable > (NodeLists anyone?), especially given the serialisation of RegExps is unhelpful > in either case. > > If you feel really strongly about this, i suggest you go to > http://bugs.mozilla.org and file a bug on the spidermonkey RegExp object > incorrectly reporting typeof as "object" and claiming not to be callable. Well, as I said above, as far as I can tell, the spec says that RegExp is not callable, in the sense that the internal [[Call]] property is not defined, IsCallable will return false and thus at the language level, typeof should return 'object', and stringify should not ignore it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:58:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:58:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28249] New: Missing controls in element seem to be inerited by its
elements, even if the td-backgrounds are explicitely set to transparent. Firefox/Opera don't share this behaviour (see attached file for example). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 04:37:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 04:37:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28300] New: [ARM] Generic ARM and ARMv7 platforms should use JSVALUE32 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28300 Summary: [ARM] Generic ARM and ARMv7 platforms should use JSVALUE32 Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: loki at inf.u-szeged.hu Currently generic ARM and ARMv7 platforms work only with JSVALUE32. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 04:39:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 04:39:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28300] [ARM] Generic ARM and ARMv7 platforms should use JSVALUE32 In-Reply-To: References: Message-ID: <20090814113952.45D9434E0A47@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28300 Gabor Loki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34828| |review? Flag| | --- Comment #1 from Gabor Loki 2009-08-14 04:39:51 PDT --- Created an attachment (id=34828) --> (https://bugs.webkit.org/attachment.cgi?id=34828) Set JSVALUE32 for generic ARM as well -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 04:43:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 04:43:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090814114339.B871F34E0AA6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 --- Comment #6 from Janne Koskinen 2009-08-14 04:43:38 PDT --- Getting there.. It is not the make_pair function that fails, but the HashMap::Contains(). in WTF/StructureTransitionTable.h we define our HashTable to be type: typedef HashMap StructureTransitionTable; where the StructureTransitionTableHashTraits' SecondFirstTraits::TraitType is unsigned. Looks like temporary pair is getting generated with unknown type. From illegal operand we can gather that this is not integer type.I looked at HashTraits.h to see if there was an obvious reason, but cold code reading doesn't help at this point. Unfortunately I don't have src for std so my debugging/preprocessing is limited here. Again casting to unsigned is the easiest way to fix this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 04:49:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 04:49:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28300] [ARM] Generic ARM and ARMv7 platforms should use JSVALUE32 In-Reply-To: References: Message-ID: <20090814114913.B80AF34E0B3C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28300 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34828|review? |review+ Flag| | --- Comment #2 from Simon Hausmann 2009-08-14 04:49:13 PDT --- (From update of attachment 34828) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 04:50:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 04:50:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28300] [ARM] Generic ARM and ARMv7 platforms should use JSVALUE32 In-Reply-To: References: Message-ID: <20090814115008.78D7834E0B64@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28300 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |hausmann at webkit.org Resolution| |FIXED --- Comment #3 from Simon Hausmann 2009-08-14 04:50:07 PDT --- Landed in r47278 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:05:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:05:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090814120527.0919834E0C92@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34538|0 |1 is obsolete| | Attachment #34829| |review? Flag| | --- Comment #18 from Laszlo Gombos 2009-08-14 05:05:25 PDT --- Created an attachment (id=34829) --> (https://bugs.webkit.org/attachment.cgi?id=34829) 5th try Disables LocalStorage for QtWebKit by default by setting QWebSettings::LocalStorageEnabled to false. Sets up a default for the LocalStorage path so that clients would only need to enable the LocalStorageEnabled setting to turn on LocalStoragre support. Turn on LocalStorage support for QtLauncher and the relevant test since LocalStorage is now disabled by default for QtWebkit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:29:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:29:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28301] New: Add our blog to Planet WebKit Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28301 Summary: Add our blog to Planet WebKit Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Website AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: oszi at inf.u-szeged.hu Add the WebKit blog of the University of Szeged to Planet WebKit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:32:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:32:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28301] Add our blog to Planet WebKit In-Reply-To: References: Message-ID: <20090814123220.661C234E0F3F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28301 Csaba Osztrogon?c changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34830| |review? Flag| | --- Comment #1 from Csaba Osztrogon?c 2009-08-14 05:32:19 PDT --- Created an attachment (id=34830) --> (https://bugs.webkit.org/attachment.cgi?id=34830) proposed patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:40:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:40:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists In-Reply-To: References: Message-ID: <20090814124049.34E2334E0FF7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27551 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34831| |review?(mrowe at apple.com) Flag| | --- Comment #21 from Simon Hausmann 2009-08-14 05:40:47 PDT --- Created an attachment (id=34831) --> (https://bugs.webkit.org/attachment.cgi?id=34831) Patch to remove unused WEBKIT_EXPORTDATA macro This patch removes the unused WEBKIT_EXPORTDATA macro. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:41:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:41:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists In-Reply-To: References: Message-ID: <20090814124152.BDC8334E1020@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27551 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33627|0 |1 is obsolete| | Attachment #34737|0 |1 is obsolete| | --- Comment #22 from Simon Hausmann 2009-08-14 05:41:52 PDT --- Created an attachment (id=34832) --> (https://bugs.webkit.org/attachment.cgi?id=34832) Rebased patch to build JSC with JS_EXPORT_PRIVATE to export symbols -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:42:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:42:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists In-Reply-To: References: Message-ID: <20090814124208.0AB1D34E1036@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27551 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34832| |review?(mrowe at apple.com) Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:45:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:45:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists In-Reply-To: References: Message-ID: <20090814124505.78EAC34E107A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27551 --- Comment #23 from Simon Hausmann 2009-08-14 05:45:04 PDT --- (In reply to comment #18) > (From update of attachment 33773 [details]) > A couple of concerns and comments: > JS_EXPORTDATA is a confusing choice of name when the majority of things being > exported are functions. I agree. I've uploaded an updated patch that replaces JS_EXPORTDATA with JS_EXPORT_PRIVATE, for consistency with the existing JS_EXPORT for the public C API. > There are a number of places that an entire class has been marked as being > exported even though only a single symbol is currently listed in > JavaScriptCore.exp and JavaScriptCore.def. ByteCodeGenerator, Parser and > ParserArena are the three that jump out at me for this reason. Yes, it appears a lot simpler and less cluttering to the source code to annotate the class instead of every used function with the export macro. > It's not clear why WEBKIT_EXPORTDATA exists. It doesn't seem to be used > anywhere. Well spotted :). I've attached a patch to remove this macro alltogether. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:50:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:50:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] [Qt] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090814125034.83F6534E10FF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34804|review?(hausmann at webkit.org | Flag|) | Attachment #34804|0 |1 is obsolete| | Attachment #34833| |review?(hausmann at webkit.org Flag| |) --- Comment #5 from Yael 2009-08-14 05:50:32 PDT --- Created an attachment (id=34833) --> (https://bugs.webkit.org/attachment.cgi?id=34833) Patch Added additional automated test at Ariya's request. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:52:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:52:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28301] Add our blog to Planet WebKit In-Reply-To: References: Message-ID: <20090814125255.D6FC534E113D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28301 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34830|review? |review+ Flag| | --- Comment #2 from Simon Hausmann 2009-08-14 05:52:55 PDT --- (From update of attachment 34830) r=me, Welcome to the Planet! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:54:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:54:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28301] Add our blog to Planet WebKit In-Reply-To: References: Message-ID: <20090814125441.C863134E11AA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28301 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |hausmann at webkit.org Resolution| |FIXED --- Comment #3 from Simon Hausmann 2009-08-14 05:54:41 PDT --- Landed in r47281 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:00:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:00:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814130052.6A76134E123F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34776|0 |1 is obsolete| | Attachment #34834| |review? Flag| | --- Comment #13 from Mike Fenton 2009-08-14 06:00:51 PDT --- Created an attachment (id=34834) --> (https://bugs.webkit.org/attachment.cgi?id=34834) Fix Changelog from in patch #34776 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:18:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:18:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814131814.AB5E334E13B8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34777|0 |1 is obsolete| | Attachment #34835| |review? Flag| | --- Comment #14 from Mike Fenton 2009-08-14 06:18:13 PDT --- Created an attachment (id=34835) --> (https://bugs.webkit.org/attachment.cgi?id=34835) Patch for GraphicsContextCG.cpp to use adjustLineToPixelBoundaries to replace duplicated code. Note: This patch is dependent on attachment 34767 in this bug. Patch for GraphicsContextCG.cpp to use adjustLineToPixelBoundaries to replace duplicated code. Note: This patch is dependent on attachment 34767 in this bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:21:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:21:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28302] New: WebInspector: Minor DOMAgent bugfixes. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28302 Summary: WebInspector: Minor DOMAgent bugfixes. Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pfeldman at chromium.org CC: timothy at hatcher.name 1. Fix document.documentElement value 2. Node binding is now 1-based 3. Add guard to focused node updated. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:24:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:24:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28258] [Haiku] Adding RenderTheme to WebCore. In-Reply-To: References: Message-ID: <20090814132401.1CD5B34E1456@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28258 --- Comment #5 from Maxime Simon 2009-08-14 06:23:58 PDT --- (In reply to comment #2) > (From update of attachment 34738 [details]) > This will error out if -wunused is on: > 41 virtual bool supportsHover(const RenderStyle* style) const { return > false; } Actually, with the "-Wall" and "-Wextra" flags I didn't get the error you specified. But when I merged this patch with the version of RenderThemeHaiku I have in my local branch, I got many problems. Looks like I posted the wrong patch ( an old version ). I noticed things like: - "RenderThemeHaiku::function(?" in the header, - "virtual void RenderThemeHaiku::function(?" in the cpp file, - or even "void function(?" in the cpp code for a method of the class. Indeed I can promptly submit another patch to avoid these stupidities. But I should be blamed to not re-read attentively my patch before posting it. Regards, Maxime -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:24:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:24:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28302] WebInspector: Minor DOMAgent bugfixes. In-Reply-To: References: Message-ID: <20090814132427.379EC34E1475@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28302 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34836| |review? Flag| | Status|UNCONFIRMED |ASSIGNED AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | Ever Confirmed|0 |1 --- Comment #1 from Pavel Feldman 2009-08-14 06:24:26 PDT --- Created an attachment (id=34836) --> (https://bugs.webkit.org/attachment.cgi?id=34836) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:33:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:33:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090814133304.B619E34E152E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34829|review? | Flag| | Attachment #34829|0 |1 is obsolete| | Attachment #34837| |review? Flag| | --- Comment #19 from Laszlo Gombos 2009-08-14 06:33:02 PDT --- Created an attachment (id=34837) --> (https://bugs.webkit.org/attachment.cgi?id=34837) 6th try Documentation for LocalStorageEnabled now mentions that it's disabled by default Enable qdocs for setLocalStoragePath and localStoragePath. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:35:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:35:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814133506.6522234E1599@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34778|0 |1 is obsolete| | Attachment #34838| |review? Flag| | --- Comment #15 from Mike Fenton 2009-08-14 06:35:05 PDT --- Created an attachment (id=34838) --> (https://bugs.webkit.org/attachment.cgi?id=34838) Fix Changelog in patch #34778 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:35:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:35:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814133527.1168534E15A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34834|Fix Changelog from in patch |Fix Changelog in patch description|#34776 |#34776 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:42:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:42:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28224] Web pages with SVG and map links aren't rendered correctly In-Reply-To: References: Message-ID: <20090814134238.2A56934E168C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28224 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krit at webkit.org --- Comment #1 from Dirk Schulze 2009-08-14 06:42:37 PDT --- I can see a photo of a person in the html-version. Is this the expected behavior? If so, it works for me on WebKitGtk. Which port do you use? Qt? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:49:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:49:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] New: [Qt] XSLT support with QtXmlPatterns Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28303 Summary: [Qt] XSLT support with QtXmlPatterns Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: faw217 at gmail.com Since the 4.5 release, QtXmlPatterns has supported XSLT 2.0 so it seems to be a good idea for QtWebKit to use that rather than libxslt (which in fact doesn't build now with the Qt port). http://doc.trolltech.com/4.6-snapshot/qtxmlpatterns.html#xslt-2-0 Here is an overview of how much complete the XSLT 2.0 support in QtXmlPatterns is. It's lacking some important features but making QtWebKit use that should help improve it. There is some libxml2/libxslt specific code laying around, not only in the implementations of XSLTProcessor and XSLStyleSheet but also in e.g. Document. For the former, we should provide our own separate implementations, for the latter we would need some #ifdefs. The other files/classes the Qt port doesn't need at all: - XSLImportRule: QtXmlPatterns currently doesn't support xsl:import/xsl:include but even when it does, it will most likely import documents internally (of course we would need to hook that so that we can take care of security and caching), so the XSLImportRule class we don't need. - XSLTExtensions - this is completely a libxslt specific thing, we can't add extra functionality to the QtXmlPatterns module so we don't need it either. - XSLTUnicodeSort - as above, we can't extend QXmlQuery with our own sorting functionality. If we wanted to add missing bits to the xsl:import implementation, we would have to patch QtXmlPatterns. The Qtish implementation of XSLStyleSheet would be pretty basic, we don't support child stylesheets and pre-compiling stylesheets so really there is not much what XSLStyleSheet could do apart from actually holding a stylesheet source. Currently I managed to achieve a result of ~35% passing layout tests. The rest can be skipped with notes about why they fail so they can be investigated in QtXmlPatterns. I'll post the exact results when submitting the patches. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:50:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:50:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28304] New: S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28304 Summary: S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite Product: WebKit Version: 528+ (Nightly build) Platform: S60 Hardware OS/Version: S60 3rd edition Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: Chang.Shu at nokia.com Steps to reproduce: 1.Load the page http://v8.googlecode.com/svn/data/benchmarks/v4/run.html 2.The automated tests start running. Expected result: 1.All the tests run and the score is displayed Actual result: Browser crashes around 87% complete Root cause: JavascriptCore heap memory exhausted -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:58:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:58:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] [Qt] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090814135844.74A7534E1840@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34833|review?(hausmann at webkit.org |review+ Flag|) | --- Comment #6 from Simon Hausmann 2009-08-14 06:58:43 PDT --- (From update of attachment 34833) r=me It would be nice to have \since 4.6 tags in the documentation for the new functions. If you have the time then it would also be nice to have a test that verifies that the local schemes actually work :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:02:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:02:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27658] Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects In-Reply-To: References: Message-ID: <20090814140213.0033234E1890@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27658 Neil Rhodes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33476| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:19:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:19:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090814141908.0B77C34E1A25@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34837|review? |review+ Flag| | --- Comment #20 from Simon Hausmann 2009-08-14 07:19:06 PDT --- (From update of attachment 34837) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:19:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:19:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28304] S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite In-Reply-To: References: Message-ID: <20090814141908.3F60734E1A27@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28304 Chang Shu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34839| |review? Flag| | --- Comment #1 from Chang Shu 2009-08-14 07:19:07 PDT --- Created an attachment (id=34839) --> (https://bugs.webkit.org/attachment.cgi?id=34839) This is the patch to fix the bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:21:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:21:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090814142119.7BA5F34E1A8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #21 from Simon Hausmann 2009-08-14 07:21:18 PDT --- Landed in r47283 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:32:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:32:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27885] Add QNX as supported platform In-Reply-To: References: Message-ID: <20090814143206.ED47B34E1BF5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27885 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34446|review? |review+ Flag| | --- Comment #5 from Simon Hausmann 2009-08-14 07:32:05 PDT --- (From update of attachment 34446) r=me > +static inline void *currentThreadStackBaseQNX() Small coding style buglet here, but I'll fix that when landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:34:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:34:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27658] Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects In-Reply-To: References: Message-ID: <20090814143420.289EB34E1C38@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27658 --- Comment #3 from Neil Rhodes 2009-08-14 07:34:19 PDT --- Created an attachment (id=34840) --> (https://bugs.webkit.org/attachment.cgi?id=34840) Demonstrates bg 27658 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:34:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:34:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27658] Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects In-Reply-To: References: Message-ID: <20090814143451.E38A034E1C4C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27658 Neil Rhodes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34840|Demonstrates bg 27658 |badselect.html description| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:44:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:44:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27885] Add QNX as supported platform In-Reply-To: References: Message-ID: <20090814144453.F272A34E1D51@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27885 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #6 from Simon Hausmann 2009-08-14 07:44:53 PDT --- Landed in r47284 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:48:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:48:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. In-Reply-To: References: Message-ID: <20090814144843.696BE34E1DC1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28181 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34773|review? |review+ Flag| | --- Comment #11 from Simon Hausmann 2009-08-14 07:48:41 PDT --- (From update of attachment 34773) r=me I'll change the url in the comment to the upstream bug url when landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:50:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:50:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. In-Reply-To: References: Message-ID: <20090814145035.7764C34E1E03@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28181 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #12 from Simon Hausmann 2009-08-14 07:50:33 PDT --- Landed in r47285 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:50:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:50:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27065] Port QtWebKit to Symbian In-Reply-To: References: Message-ID: <20090814145038.0EE4534E1E1B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27065 Bug 27065 depends on bug 28181, which changed state. Bug 28181 Summary: RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. https://bugs.webkit.org/show_bug.cgi?id=28181 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:52:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:52:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] [Qt] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090814145251.9E40034E1E75@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #7 from Yael 2009-08-14 07:52:50 PDT --- Landed in r47282 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:57:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:57:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28305] New: When Geolocation permissions are denied, watchers are not stopped Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28305 Summary: When Geolocation permissions are denied, watchers are not stopped Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: steveblock at google.com CC: andreip at google.com, bolsinga at apple.com Currently, when Geolocation permissions are denied, only one-shots are stopped. Since permissions can not be revoked within the lifetime of the page, all requests (both one-shots and watchers) will never obtain a position fix once permissions have been denied. We should therefore stop all requests when permissions are denied. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:16:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:16:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090814151656.21F3D34E2117@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 --- Comment #16 from George Wright 2009-08-14 08:16:54 PDT --- (In reply to comment #15) > Reopening since there was a regression on the bots: > http://build.webkit.org/builders/Tiger%20Intel%20Release/builds/3425 It seems to be working again; did you roll out the patch or not? I can't see in the logs that you did. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:19:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:19:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28280] WebInspector: Evaluating objects while on a breakpoint dumps string representation instead of live object. In-Reply-To: References: Message-ID: <20090814151919.04B8734E216C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28280 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34841| |review? Flag| | --- Comment #1 from Pavel Feldman 2009-08-14 08:19:17 PDT --- Created an attachment (id=34841) --> (https://bugs.webkit.org/attachment.cgi?id=34841) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:27:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:27:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814152727.44DD134E221B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34842| |review? Flag| | --- Comment #16 from Mike Fenton 2009-08-14 08:27:26 PDT --- Created an attachment (id=34842) --> (https://bugs.webkit.org/attachment.cgi?id=34842) Patch for GraphicsContextSkia.cpp to use adjustLineToPixelBoundaries. This patch modifies drawLine in Skia to use adjustLineToPixelBoundaries and should maintain the existing functionality. Note: This patch is dependent on attachment 34767 in this bug and has not been compiled for Skia. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:29:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:29:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814152918.CFAB834E223A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34843| |review? Flag| | --- Comment #17 from Mike Fenton 2009-08-14 08:29:18 PDT --- Created an attachment (id=34843) --> (https://bugs.webkit.org/attachment.cgi?id=34843) Style patch for GraphicsContextSkia.cpp Note: This leaves the header order partially against WebKit style in order to group Skia headers. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:46:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:46:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28280] WebInspector: Evaluating objects while on a breakpoint dumps string representation instead of live object. In-Reply-To: References: Message-ID: <20090814154630.6375034E23E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28280 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34841|review? |review- Flag| | --- Comment #2 from Timothy Hatcher 2009-08-14 08:46:29 PDT --- (From update of attachment 34841) > + function(result, isException) { > + if (!isException) > + result = JSON.parse(result); > + reportCompletions(result, isException); > + }); Can you break this out into a named function so it is easier to read? It took me a second to realize this was being passed as an argument. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:58:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:58:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090814155842.32BF434E2591@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 --- Comment #17 from Eric Seidel 2009-08-14 08:58:40 PDT --- http://trac.webkit.org/changeset/47191 was added to fix the qt bot. I did not roll your change out. I'm not sure why the bot results changed. I have not investigated. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:08:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:08:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28113] QtWebKit (using the Arora browser) displays the border radii (radius) of a button very ugly In-Reply-To: References: Message-ID: <20090814160854.BBDA434E26C7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28113 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george.wright at torchmobile.c | |om --- Comment #2 from George Wright 2009-08-14 09:08:54 PDT --- This appears to be a problem with the Qt rendering backend; it renders correctly when using the raster rendering backend. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:11:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:11:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28224] Web pages with SVG and map links aren't rendered correctly In-Reply-To: References: Message-ID: <20090814161106.232C934E2719@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28224 --- Comment #2 from Igor Bronshteyn 2009-08-14 09:11:05 PDT --- I can see this photo neither in Arora, nor in Midori or Chromium. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:18:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:18:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28306] New: double-clicking a word inside beside newline select two words Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28306 Summary: double-clicking a word inside beside newline select two words Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: HTML Editing AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: morrita at gmail.com Overview: Double-clicking a word to select that word unexpectedly results two-word selected. Steps to Reproduce: 1. open attached file 2. double click "selectme" Actual Result: "foo selectme" is selected(hilightened) Expected Result: "selectme" is selected. Build Date & Platform: trunk r47196, Mac OS 10.5.7 Additional Information: this bug is from chromium http://code.google.com/p/chromium/issues/detail?id=6396 (and privately confirmed at Safari and WebKit trunk) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:19:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:19:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28306] double-clicking a word inside beside newline select two words In-Reply-To: References: Message-ID: <20090814161908.A0F4534E27F2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28306 --- Comment #1 from MORITA Hajime 2009-08-14 09:19:08 PDT --- Created an attachment (id=34845) --> (https://bugs.webkit.org/attachment.cgi?id=34845) html to reproduce. html to reproduce. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:24:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:24:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] New: [Haiku] Fix RenderThemeHaiku build. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28307 Summary: [Haiku] Fix RenderThemeHaiku build. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.maxime at gmail.com CC: leavengood at gmail.com The patch which introduced RenderThemeHaiku was wrong in some places. ( see: https://bugs.webkit.org/show_bug.cgi?id=28258#c5 ) Here is a patch to correct this. Regards, Maxime -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:31:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:31:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814163120.5029134E2916@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34846| |review? Flag| | --- Comment #1 from Maxime Simon 2009-08-14 09:31:19 PDT --- Created an attachment (id=34846) --> (https://bugs.webkit.org/attachment.cgi?id=34846) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:37:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:37:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28306] double-clicking a word inside beside newline select two words In-Reply-To: References: Message-ID: <20090814163721.582BA34E29AD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28306 MORITA Hajime changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34847| |review? Flag| | --- Comment #2 from MORITA Hajime 2009-08-14 09:37:20 PDT --- Created an attachment (id=34847) --> (https://bugs.webkit.org/attachment.cgi?id=34847) a small fix to use string length from RenderText instead of inline box -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:48:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:48:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814164827.654F634E2AD3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34848| |review? Flag| | --- Comment #1 from Jakub Wieczorek 2009-08-14 09:48:26 PDT --- Created an attachment (id=34848) --> (https://bugs.webkit.org/attachment.cgi?id=34848) Move the libxslt specific part of XSLTProcessor to a separate file. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:55:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:55:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28275] media/video-played.html always times out on Windows In-Reply-To: References: Message-ID: <20090814165537.5681834E2B88@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28275 Eric Carlson changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |eric.carlson at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:55:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:55:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814165538.150CD34E2B92@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34848|review? | Flag| | Attachment #34848|0 |1 is obsolete| | Attachment #34849| |review? Flag| | --- Comment #2 from Jakub Wieczorek 2009-08-14 09:55:36 PDT --- Created an attachment (id=34849) --> (https://bugs.webkit.org/attachment.cgi?id=34849) Move the libxslt specific part of XSLTProcessor to a separate file. This one actually fixes the whitespace errors. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:56:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:56:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814165656.DC38A34E2BE5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34772|review? | Flag| | Attachment #34772|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:57:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:57:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814165712.89E6D34E2BF1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34772| |review? Flag| | Attachment #34772|1 |0 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:57:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:57:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814165724.A2E8F34E2BFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34782|review? | Flag| | Attachment #34782|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:57:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:57:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814165733.B527934E2C11@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34783|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:57:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:57:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814165744.1A3BC34E2C27@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34784|review? | Flag| | Attachment #34784|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:59:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:59:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] New: allow down-sampling images during decoding Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28308 Summary: allow down-sampling images during decoding Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yong.li at torchmobile.com CC: staikos at kde.org, treat at kde.org separated from bug 27561 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:04:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:04:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28224] Web pages with SVG and map links aren't rendered correctly In-Reply-To: References: Message-ID: <20090814170402.4664134E2CD1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28224 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #3 from Dirk Schulze 2009-08-14 10:04:01 PDT --- I can see this bug in Chromium and GtkLauncher on trunk too but it works for an older webkitgtk build + epiphany. Maybe it's a regression or it just works with epiphany (don't now how this could be possible). But I don't know the revision of my binary for checking this :-( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:04:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:04:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28309] New: [Haiku] Adding SharedBufferHaiku to WebCore. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28309 Summary: [Haiku] Adding SharedBufferHaiku to WebCore. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.maxime at gmail.com CC: leavengood at gmail.com This patch will add the SharedBuffer::createWithContentsOfFile(const String&) function for Haiku. In the same time I cleaned up TemporaryLinkStubs.cpp Regards, Maxime -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:06:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:06:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814170645.3616734E2D2E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34851| |review? Flag| | --- Comment #1 from Yong Li 2009-08-14 10:06:44 PDT --- Created an attachment (id=34851) --> (https://bugs.webkit.org/attachment.cgi?id=34851) the patch only JPEG and PNG decoders are modified to support this feature. Other decoders just ignore it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:07:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:07:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814170723.A3CE934E2D3F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34852| |review? Flag| | --- Comment #3 from Jakub Wieczorek 2009-08-14 10:07:21 PDT --- Created an attachment (id=34852) --> (https://bugs.webkit.org/attachment.cgi?id=34852) Rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:09:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:09:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28309] [Haiku] Adding SharedBufferHaiku to WebCore. In-Reply-To: References: Message-ID: <20090814170912.2193634E2D74@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28309 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34853| |review? Flag| | --- Comment #1 from Maxime Simon 2009-08-14 10:09:11 PDT --- Created an attachment (id=34853) --> (https://bugs.webkit.org/attachment.cgi?id=34853) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:12:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:12:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814171232.E1A8934E2DEF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34854| |review? Flag| | --- Comment #4 from Jakub Wieczorek 2009-08-14 10:12:31 PDT --- Created an attachment (id=34854) --> (https://bugs.webkit.org/attachment.cgi?id=34854) [Qt] Implement XSLT support with QtXmlPatterns. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:25:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:25:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814172502.2FACD34E2EF8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34855| |review? Flag| | --- Comment #5 from Jakub Wieczorek 2009-08-14 10:25:01 PDT --- Created an attachment (id=34855) --> (https://bugs.webkit.org/attachment.cgi?id=34855) [Qt] Add expected result for fast/xsl/document-function.xml. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:26:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:26:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814172655.E5D3E34E2F2B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34856| |review? Flag| | --- Comment #29 from Yong Li 2009-08-14 10:26:54 PDT --- Created an attachment (id=34856) --> (https://bugs.webkit.org/attachment.cgi?id=34856) 2) Use ImageFrameSink for JPEG, PNG, and GIF -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:37:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:37:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27968] [HTML5][Forms] UI In-Reply-To: References: Message-ID: <20090814173704.99EA534E3013@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27968 --- Comment #5 from Darin Adler 2009-08-14 10:37:03 PDT --- That Windows screenshot seems to be missing a line on top of the top arrow. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:40:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:40:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27612] handling scripts can block UI In-Reply-To: References: Message-ID: <20090814174012.8E6EB34E305A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27612 --- Comment #4 from Yong Li 2009-08-14 10:40:11 PDT --- Created an attachment (id=34857) --> (https://bugs.webkit.org/attachment.cgi?id=34857) test case this is a simple test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:41:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:41:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814174109.D8BA334E3082@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34858| |review? Flag| | --- Comment #6 from Jakub Wieczorek 2009-08-14 10:41:08 PDT --- Created an attachment (id=34858) --> (https://bugs.webkit.org/attachment.cgi?id=34858) [Qt] Update expected result for fast/xsl/xslt_unicode.xml. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:51:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:51:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814175126.E0DB634E31D2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34851|review? |review- Flag| | --- Comment #2 from Adam Treat 2009-08-14 10:51:26 PDT --- (From update of attachment 34851) Looking much, much better! A few issues: > +#if ENABLE(IMAGE_DECODER_DOWN_SAMPLING) > + if (m_decoder) { > +# ifdef IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS > + m_decoder->setMaxNumPixels(IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS); > +# else > + m_decoder->setMaxNumPixels(1024 * 1024); > +# endif > + } > +#endif > + } Shift this block down below to the next 'if (m_decoder)' and you eliminate an extra conditional and a nested one at that. Also, there is weird indenting on the '# ifdef' Please remove. > +namespace { > + enum MatchType{ > + Exact, > + UpperBound, > + LowerBound > + }; > +} More weird indentation. > +template static int getScaledValue(const Vector& scaledValues, int orig, int searchStart) > +{ > + int size = scaledValues.size(); > + const int* dataStart = scaledValues.data(); > + const int* dataEnd = dataStart + size; > + const int* pos = std::lower_bound(dataStart + searchStart, dataEnd, orig); > + switch (type) { > + case Exact: > + return pos != dataEnd && *pos == orig ? pos - dataStart : -1; > + case LowerBound: > + return pos != dataEnd && *pos == orig ? pos - dataStart : pos - dataStart - 1; > + case UpperBound: > + default: > + return pos != dataEnd ? pos - dataStart : -1; > + } > +} More weird indentation and the case labels should line up with switch statement. Please check with check-webkit-style. Why is this templated? > +int ImageDecoder::upperBoundScaledX(int origX, int searchStart) > +{ > + return getScaledValue(m_scaledColumns, origX, searchStart); > +} Is this tabbed indentation? Please remove all tabs and check thoroughly for coding style. > + // ENABLE(IMAGE_DECODER_DOWN_SAMPLING) allows image decoders writedirectly to scaled output buffers Typo. "allows image decoders to write directly to..." > + // by down sampling. Call setMaxNumPixels() to specify the biggest size that decoded images > + // can have. Image decoders will deflate those images that are bigger than m_maxNumPixels. > + // (Not supported by all image decoders yet) > -static void convertCMYKToRGBA(RGBA32Buffer& dest, JSAMPROW src, jpeg_decompress_struct* info) > +static void convertCMYKToRGBA(RGBA32Buffer& dest, int destY, JSAMPROW src, int srcWidth > +#if ENABLE(IMAGE_DECODER_DOWN_SAMPLING) > + , bool scaled, const Vector& scaledColumns > +#endif > + ) > { > - ASSERT(info->out_color_space == JCS_CMYK); Why do you remove this assert and change the behavior of this method even when IMAGE_DECODER_DOWN_SAMPLING is disabled? > @@ -491,21 +507,33 @@ static void convertCMYKToRGBA(RGBA32Buffer& dest, JSAMPROW src, jpeg_decompress_ > > // read_scanlines has increased the scanline counter, so we > // actually mean the previous one. > - dest.setRGBA(x, info->output_scanline - 1, c * k / 255, m * k / 255, y * k / 255, 0xFF); > + dest.setRGBA(x, destY, c * k / 255, m * k / 255, y * k / 255, 0xFF); Same question as above and repeated for hunks below. > while (info->output_scanline < info->output_height) { > /* Request one scanline. Returns 0 or 1 scanlines. */ > - if (jpeg_read_scanlines(info, samples, 1) != 1) > + int sourceY = info->output_scanline; > + int sourceRows = jpeg_read_scanlines(info, samples, 1); > + if (sourceRows != 1) { > + if (sourceRows != 0) > + m_failed = true; > return false; > + } Another change that is not guarded by ENABLE(IMAGE_DECODER_DOWN_SAMPLING) Each of these changes should be described. I simply don't have context to understand them. > +#if ENABLE(IMAGE_DECODER_DOWN_SAMPLING) > + bool setSize(int width, int height) { Brace goes on next line. I'll stop there and say that this still needs coding style cleanups. And if at all possible the patch should have no behavior changes for when ENABLE(IMAGE_DECODER_DOWN_SAMPLING) is false. Any other changes should either have some explanation or broken out into separate patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:51:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:51:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814175154.C4EC534E31EE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #30 from Peter Kasting 2009-08-14 10:51:53 PDT --- (In reply to comment #23) > Created an attachment (id=34772) --> (https://bugs.webkit.org/attachment.cgi?id=34772) [details] > 1) ImageFrameSink Here's a spattering of comments all over this patch, based on a quick glance. I assume that your motive for resurrecting the "decoded height" variable is so that when you paint a SharedBitmap you can do an opaque blit of the valid height (and avoid the undecoded portion entirely) instead of doing a transparent blit of the entire frame size? If so, I'm not necessarily opposed to resurrecting the height member, although no other ports do this and I wonder if it actually saves much time (it's only relevant while an image is half-decoded and being painted, and at that point the user isn't getting high-speed animation or similar anyway). If it doesn't actually buy meaningful performance, then returning true for frameHasAlphaAtIndex() (either using the method it has now, which I think is fine, or pushing this into all the decoders, which I think is unnecessary code duplication for no benefit) seems like a simpler and better way. I don't understand what createInstance() and deleteInstance() buy you. Callers could just use "foo = new ImageFrameSink(bool);" or "delete foo;". Some of the variable names seem problematic to me; e.g. I would change m_expectedHeight to m_height, m_height to m_decodedHeight, m_bmp to m_bitmap, can to canFreeBuffer. I'm skeptical of the utility of m_compositedWithPreviousFrame. The only use for this would be in decoding GIFs, to avoid creating the complete frame at a particular index. But this means you can't use the "large GIF, discard unnecessary frames" memory optimization which makes an enormous difference for large animated GIFs, because you need to keep around an arbitrary number of frames. Why are the data members protected instead of private? Per Darin Adler we should make things as private as possible. Having both setRGB16() and setRGBA() seems like a poor API for callers. Why doesn't setRGBA() just write the data in 16-bit format if the bitmap is 16-bit? If the answer is "we're worried about putting an if() in there for performance reasons", I'd like to see data on the effect of such a thing before prematurely optimizing. Note that there's already an if() in setRGBA(). Not a big fan of things like "foo >> 1 << 1". "foo & ~0x1" would be clearer. Same with "foo >> 3 << 7"; "(foo << 4) & 0xFFFFFF80" seems clearer. Why does getFrame() return 0 when the status is frameEmpty? An empty frame is still a valid one. The proper use of setCanFreeBuffer() is not obvious to me. Overall there seems to be a lot of functions to explicitly allocate and free things inside the ImageFrameSink. This doesn't feel like a particularly friendly API. Note that the existing RGBA32Buffer has only a few functions, mostly to support deep versus shallow copies of the underlying data. This file is also entirely missing a large number of functions from the current RGBA32Buffer, such as clear(), copyRowNTimes(), asNewNativeImage(), etc., which are used in various different cases. I assume this is because you wrote this code quite a while ago. If we wanted to use ImageFrameSink, I think a lot of these would need to be supported, so you wouldn't be massively rewriting the decoders or other cross-platform Image code (especially if such rewrites removed optimizations, like the GIF frame-clearing optimization). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:54:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:54:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814175457.F21F134E324A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #31 from Peter Kasting 2009-08-14 10:54:57 PDT --- (In reply to comment #29) > Created an attachment (id=34856) --> (https://bugs.webkit.org/attachment.cgi?id=34856) [details] > 2) Use ImageFrameSink for JPEG, PNG, and GIF I don't see the point of marking r? on this when it can't land until ImageFrameSink does, and that's a ways away. Much of this patch is a copy-and-paste of old code from the image decoders that has since been changed for both clarity and correctness. You need to discard that and find a way to modify in-line the existing decoding code, instead of completely rewriting entire functions under #ifdefs. We still wouldn't land the patch that way, but it would at least allow a precise understanding of what ImageFrameSink requires, which is impossible with this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:58:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:58:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27612] handling scripts can block UI In-Reply-To: References: Message-ID: <20090814175831.93D5B34E32BD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27612 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33349|0 |1 is obsolete| | Attachment #34859| |review? Flag| | --- Comment #5 from Yong Li 2009-08-14 10:58:30 PDT --- Created an attachment (id=34859) --> (https://bugs.webkit.org/attachment.cgi?id=34859) modified for coding style only changed CACHED_SCRIPT_DELAY_NOTIFICATION into ENABLE(CACHED_SCRIPT_DELAY_NOTIFICATION) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:03:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:03:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814180328.1690834E338F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #32 from George Staikos 2009-08-14 11:03:26 PDT --- (In reply to comment #30) > (In reply to comment #23) > > Created an attachment (id=34772) --> (https://bugs.webkit.org/attachment.cgi?id=34772) [details] [details] > > 1) ImageFrameSink > > Here's a spattering of comments all over this patch, based on a quick glance. > > I assume that your motive for resurrecting the "decoded height" variable is so > that when you paint a SharedBitmap you can do an opaque blit of the valid > height (and avoid the undecoded portion entirely) instead of doing a > transparent blit of the entire frame size? If so, I'm not necessarily opposed > to resurrecting the height member, although no other ports do this and I wonder > if it actually saves much time (it's only relevant while an image is > half-decoded and being painted, and at that point the user isn't getting > high-speed animation or similar anyway). If it doesn't actually buy meaningful > performance, then returning true for frameHasAlphaAtIndex() (either using the > method it has now, which I think is fine, or pushing this into all the > decoders, which I think is unnecessary code duplication for no benefit) seems > like a simpler and better way. The performance issue is very valid for our target platform. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:05:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:05:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814180549.4126D34E3402@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34860| |review? Flag| | --- Comment #7 from Jakub Wieczorek 2009-08-14 11:05:48 PDT --- Created an attachment (id=34860) --> (https://bugs.webkit.org/attachment.cgi?id=34860) Remove the encoding attribute from xsl:stylesheet element in resources/unicode.xsl. This one will have no effect on other ports, it is needed to make Qtish XSLT processor happy: currently it stops evaluating the stylesheet after encountering the misplaced attribute. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:08:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:08:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814180843.81E3534E3458@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 --- Comment #3 from Yong Li 2009-08-14 11:08:42 PDT --- (In reply to comment #2) > (From update of attachment 34851 [details]) > Looking much, much better! A few issues: > Shift this block down below to the next 'if (m_decoder)' and you eliminate an > extra conditional and a nested one at that. They are different. this 'if (m_decoder)' is reached only for the first time, where the below one is reached every time. > Why is this templated? To be faster. template argument is kind of const values. > > Why do you remove this assert and change the behavior of this method even when > IMAGE_DECODER_DOWN_SAMPLING is disabled? info becomes useless except in this ASSERT. I removed 'info' argument. ASSERT is not necessary because the caller takes care of that. > > > while (info->output_scanline < info->output_height) { > > /* Request one scanline. Returns 0 or 1 scanlines. */ > > - if (jpeg_read_scanlines(info, samples, 1) != 1) > > + int sourceY = info->output_scanline; > > + int sourceRows = jpeg_read_scanlines(info, samples, 1); > > + if (sourceRows != 1) { > > + if (sourceRows != 0) > > + m_failed = true; > > return false; > > + } > > Another change that is not guarded by ENABLE(IMAGE_DECODER_DOWN_SAMPLING) I can remove the sourceRows change. sourceY is used to record the current row. With this change, there can be more code shared. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:10:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:10:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814181030.7036134E3495@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34861| |review? Flag| | --- Comment #8 from Jakub Wieczorek 2009-08-14 11:10:29 PDT --- Created an attachment (id=34861) --> (https://bugs.webkit.org/attachment.cgi?id=34861) [Qt] Update the Skipped list. The numbers: 13 test cases (37%) succeeded 19 test cases (54%) had incorrect layout 2 test cases (5%) were new 1 test case (2%) crashed We're passing 13 test cases within the fast/xsl directory and 5 more outside it. They all have been unskipped and the rest skipped with notes about why they're failing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:13:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:13:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814181358.7B90034E34F5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #33 from Peter Kasting 2009-08-14 11:13:57 PDT --- (In reply to comment #32) > (In reply to comment #30) > > I wonder > > if it actually saves much time (it's only relevant while an image is > > half-decoded and being painted, and at that point the user isn't getting > > high-speed animation or similar anyway). If it doesn't actually buy meaningful > > performance, then returning true for frameHasAlphaAtIndex() (either using the > > method it has now, which I think is fine, or pushing this into all the > > decoders, which I think is unnecessary code duplication for no benefit) seems > > like a simpler and better way. > > The performance issue is very valid for our target platform. OK, do you have some data (e.g. page load times or animation frame rates) around this issue? It would be helpful in deciding whether we should also try to convert the other backends over to a similar mechanism. I could be totally overlooking a particular case where this is really useful. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:23:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:23:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814182338.D37B634E3620@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 --- Comment #4 from Adam Treat 2009-08-14 11:23:38 PDT --- (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 34851 [details] [details]) > > Looking much, much better! A few issues: > > > Shift this block down below to the next 'if (m_decoder)' and you eliminate an > > extra conditional and a nested one at that. > > They are different. this 'if (m_decoder)' is reached only for the first time, > where the below one is reached every time. Ahh, the wonders of reading diffs. Sorry! > > Why is this templated? > To be faster. template argument is kind of const values. Ok. > > Why do you remove this assert and change the behavior of this method even when > > IMAGE_DECODER_DOWN_SAMPLING is disabled? > > info becomes useless except in this ASSERT. I removed 'info' argument. ASSERT > is not necessary because the caller takes care of that. Ok, I didn't see the added ASSERT. > > Another change that is not guarded by ENABLE(IMAGE_DECODER_DOWN_SAMPLING) > > I can remove the sourceRows change. Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:25:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:25:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814182556.28F7B34E366B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #34 from George Staikos 2009-08-14 11:25:55 PDT --- (In reply to comment #33) > (In reply to comment #32) > > (In reply to comment #30) > > > I wonder > > > if it actually saves much time (it's only relevant while an image is > > > half-decoded and being painted, and at that point the user isn't getting > > > high-speed animation or similar anyway). If it doesn't actually buy meaningful > > > performance, then returning true for frameHasAlphaAtIndex() (either using the > > > method it has now, which I think is fine, or pushing this into all the > > > decoders, which I think is unnecessary code duplication for no benefit) seems > > > like a simpler and better way. > > > > The performance issue is very valid for our target platform. > > OK, do you have some data (e.g. page load times or animation frame rates) > around this issue? It would be helpful in deciding whether we should also try > to convert the other backends over to a similar mechanism. I could be totally > overlooking a particular case where this is really useful. No numbers right now but alpha blending is ugly, blitting is slow. Every pixel causes pain here. I don't expect it to be an issue in other places. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:29:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:29:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814182939.4FC9634E370D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #35 from Yong Li 2009-08-14 11:29:38 PDT --- (In reply to comment #30) > (In reply to comment #23) > > Created an attachment (id=34772) --> (https://bugs.webkit.org/attachment.cgi?id=34772) [details] [details] > > 1) ImageFrameSink > > Here's a spattering of comments all over this patch, based on a quick glance. > > I assume that your motive for resurrecting the "decoded height" variable is so > that when you paint a SharedBitmap you can do an opaque blit of the valid > height (and avoid the undecoded portion entirely) instead of doing a > transparent blit of the entire frame size? If so, I'm not necessarily opposed > to resurrecting the height member, although no other ports do this and I wonder > if it actually saves much time (it's only relevant while an image is > half-decoded and being painted, and at that point the user isn't getting > high-speed animation or similar anyway). If it doesn't actually buy meaningful > performance, then returning true for frameHasAlphaAtIndex() (either using the > method it has now, which I think is fine, or pushing this into all the > decoders, which I think is unnecessary code duplication for no benefit) seems > like a simpler and better way. > Seems RGBA32Buffer will be modified to support more formats. Are you planning to do this? After that, you will find that JPEG doesn't have alpha channel, so it may use 24bit format or RGB565 to store decoded data. So even you hack frameHasAlphaAtIndex(), it won't work. Also, on some devices, alpha blending may be slow, or even not supported. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:29:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:29:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28310] New: Chromium: Show a "Mute Disabled" button on audio error. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28310 Summary: Chromium: Show a "Mute Disabled" button on audio error. Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P4 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: kylep at chromium.org Load and paint a mediaSoundDisabled image in RenderThemeChromiumSkia::paintMediaMuteButton() to display when the mediaElement cannot load audio. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:37:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:37:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28310] Chromium: Show a "Mute Disabled" button on audio error. In-Reply-To: References: Message-ID: <20090814183756.80B2734E3839@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28310 Kyle Prete changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34864| |review? Flag| | --- Comment #1 from Kyle Prete 2009-08-14 11:37:55 PDT --- Created an attachment (id=34864) --> (https://bugs.webkit.org/attachment.cgi?id=34864) Fix Add methods to ask the mediaplayer if it has audio (by default returning true) and modify chromium theme renderer to paint the disabled button. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:38:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:38:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18546] Can't load some non-latin fonts with pango backend In-Reply-To: References: Message-ID: <20090814183811.ABF6834E3841@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18546 Khaled Hosny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |khaledhosny at eglug.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:38:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:38:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18552] Downloadable fonts don't work with pango backend In-Reply-To: References: Message-ID: <20090814183846.9B59534E384F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18552 Khaled Hosny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |khaledhosny at eglug.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:42:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:42:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814184227.A386534E38D4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #36 from Peter Kasting 2009-08-14 11:42:26 PDT --- (In reply to comment #35) > Seems RGBA32Buffer will be modified to support more formats. Are you planning > to do this? I'm planning to remove the name "RGBA32" from the class, since that class actually doesn't support any formats at all; the underlying native image types do. Though right now none of those native image types uses anything other than 32-bit ARGB (or RGBA, or whatever), they could, and my suspicion is that that decision is best left to those classes. I haven't coded it so I can't be sure, of course, but I think rather than having things like is16Bit() and raw bit-writing ops directly in this header, those should be pushed to places like what you've written as SharedBuffer. Being able to cleanly integrate ports like WinCE that desire lower-bitdepth storage formats is a key motivator to doing this, so whatever solution we land on certainly has to work for you guys. > After that, you will find that JPEG doesn't have alpha channel, so > it may use 24bit format or RGB565 to store decoded data. It could; it's not clear without trying it whether that will be a big win for backends like Skia and Cairo. Backends that did this would also need to ensure that their code doesn't rely on the image storage being 32-bit; I think Skia might, at the moment. > So even you hack frameHasAlphaAtIndex(), it won't work. FWIW, at the moment Cairo uses frameHasAlphaAtIndex() to determine its compositing op, but Skia just uses the real image data inside the SkBitmap, and ignores this function entirely. It might make sense to have that kind of pattern everywhere, since I imagine most native image storage formats can tell you if they use an alpha channel... > Also, on some devices, alpha blending may be slow, or even not supported. Having it not supported entirely would make a platform pretty unusable since not only most of the image formats, but all kinds of other CSS, SVG, etc. operations need alpha. So I'm not as concerned with designing for that case. Slow is another story; we do probably want to make it possible for ports to avoid alpha-blending where possible. I wonder if we need ensureHeight() and friends to do that, though; in the current RGBA32Buffer API, it would be pretty simple to set the decoded height correctly on an underlying native image without needing an explicit call from the decoder. This is because the decoders move monotonically through the rows of an image, and set the status to FrameComplete when they finish. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:43:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:43:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814184328.3044234E3902@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #37 from Yong Li 2009-08-14 11:43:27 PDT --- (In reply to comment #30) > (In reply to comment #23) > > Created an attachment (id=34772) --> (https://bugs.webkit.org/attachment.cgi?id=34772) [details] [details] > > 1) ImageFrameSink > > I don't understand what createInstance() and deleteInstance() buy you. Callers > could just use "foo = new ImageFrameSink(bool);" or "delete foo;". > createInstance is useful in this case: class ImageFrameSinkXxxxWithMoreMembers : public ImageFrameSink { more members here; }; ImageFrameSink* ImageFrameSink::createInstance() { return new ImageFrameSinkXxxxWithMoreMembers ; } > > Some of the variable names seem problematic to me; e.g. I would change > m_expectedHeight to m_height, m_height to m_decodedHeight m_height as RGBA32Buffer defined. Yeah, now it's ok to change the name as m_height has been removed from RGBA32Buffer. > > I'm skeptical of the utility of m_compositedWithPreviousFrame. The only use > for this would be in decoding GIFs, to avoid creating the complete frame at a > particular index. But this means you can't use the "large GIF, discard > unnecessary frames" memory optimization which makes an enormous difference for > large animated GIFs, because you need to keep around an arbitrary number of > frames. m_compositedWithPreviousFrame is not only for "avoiding someting", but also important for transparent effects in GIF animation. > > Why are the data members protected instead of private? Per Darin Adler we > should make things as private as possible. because the subclasses need to access them > > Having both setRGB16() and setRGBA() seems like a poor API for callers. Why > doesn't setRGBA() just write the data in 16-bit format if the bitmap is 16-bit? > If the answer is "we're worried about putting an if() in there for performance > reasons", I'd like to see data on the effect of such a thing before prematurely > optimizing. Note that there's already an if() in setRGBA(). they also have different inputs > > Not a big fan of things like "foo >> 1 << 1". "foo & ~0x1" would be clearer. >> 1 << 1 seems cleaner to. but I'm not sure which one is faster. > Same with "foo >> 3 << 7"; "(foo << 4) & 0xFFFFFF80" seems clearer. Same thing here, I don't think the latter is clean. > > Why does getFrame() return 0 when the status is frameEmpty? An empty frame is > still a valid one. why? Who likes to waste CPU time on empty frame? > > The proper use of setCanFreeBuffer() is not obvious to me. This nofities the buffer that decoder has finished writting to the buffer, so the buffer can be released when it's under memory pressure. > > Overall there seems to be a lot of functions to explicitly allocate and free > things inside the ImageFrameSink. This doesn't feel like a particularly > friendly API. Note that the existing RGBA32Buffer has only a few functions, > mostly to support deep versus shallow copies of the underlying data. > > This file is also entirely missing a large number of functions from the current > RGBA32Buffer, such as clear(), copyRowNTimes(), asNewNativeImage(), etc., which > are used in various different cases. I assume this is because you wrote this > code quite a while ago. If we wanted to use ImageFrameSink, I think a lot of > these would need to be supported, so you wouldn't be massively rewriting the > decoders or other cross-platform Image code (especially if such rewrites > removed optimizations, like the GIF frame-clearing optimization). I still think it's not difficult to replace RGBA32Buffer with ImageFrameSink. Yeah, it needs some work definitely. The one that I'm most concerned is about GIF m_compositedWithPreviousFrame thing. That's complicated, and ImageFrameSink code works in a little different way. Want to talk to somebody on this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:51:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:51:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814185136.5072F34E39E7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34865| |review? Flag| | --- Comment #18 from Mike Fenton 2009-08-14 11:51:35 PDT --- Created an attachment (id=34865) --> (https://bugs.webkit.org/attachment.cgi?id=34865) Refactor patternWidth and patternOffset calculations from GraphicsContextQt/Cairo/CG.cpp into GraphicsContext.cpp. Note: This patch should be applied after other patches in this bug to avoid conflicts. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:54:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:54:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23995] backgound color lost on indent/listify In-Reply-To: References: Message-ID: <20090814185432.602A234E3A2B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23995 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P2 |P3 OS/Version|Mac OS X 10.5 |All Severity|Normal |Minor --- Comment #5 from Ryosuke Niwa 2009-08-14 11:54:30 PDT --- This bug has been fixed by http://trac.webkit.org/changeset/47008. But we still need some test cases to prevent future regression. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:59:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:59:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26317] event-based debugging / profiling In-Reply-To: References: Message-ID: <20090814185904.3C26634E3AA9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26317 Rob Retchless changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |retchless at gmail.com --- Comment #1 from Rob Retchless 2009-08-14 11:59:03 PDT --- Great paper Pat. This passage pretty much sums up the problem: > In the communicating event loops model, there are no > explicit receive operations; rather, each received message > notifies a callback, spawning a sequential call-return > computation which executes to completion. The stack > becomes empty before the next incoming message is > processed. For this style of distributed computation, the > conventional debugger's stack view only reaches back to > the last receive ? the one that spawned the current stack. > Since each received message is processed to completion > separately, these computations are largely independent, so > earlier state within the same process is likely less relevant > than the process that sent the message. The biggest pain areas are with event debugging (like mousemove) or async calls. In terms of interaction, it would be cool if the debugger could record a time period, and then allow me to step through everything that happens during that time period retroactively. It would have to properly connect the various related call stacks to each other though, doing something similar to Causeway, and support watch variables. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:59:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:59:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814185917.6A44134E3AB1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #38 from Peter Kasting 2009-08-14 11:59:16 PDT --- (In reply to comment #37) > (In reply to comment #30) > > I don't understand what createInstance() and deleteInstance() buy you. Callers > > could just use "foo = new ImageFrameSink(bool);" or "delete foo;". > > > createInstance is useful in this case: > > class ImageFrameSinkXxxxWithMoreMembers : public ImageFrameSink > { > more members here; > }; > > ImageFrameSink* ImageFrameSink::createInstance() > { > return new ImageFrameSinkXxxxWithMoreMembers ; > } But does anyone do that? It doesn't look like it from this patch. Why build factory functions unless you need them? > > I'm skeptical of the utility of m_compositedWithPreviousFrame. The only use > > for this would be in decoding GIFs, to avoid creating the complete frame at a > > particular index. But this means you can't use the "large GIF, discard > > unnecessary frames" memory optimization which makes an enormous difference for > > large animated GIFs, because you need to keep around an arbitrary number of > > frames. > > m_compositedWithPreviousFrame is not only for "avoiding someting", but also > important for transparent effects in GIF animation. I don't understand. I know how GIF animation and frame disposal methods work. The existing ports handle them correctly without using this mechanism. Why doesn't the existing mechanism work for you, and how do you deal with not having the frame-clearing optimization for large GIFs? I would think on a memory-constrained platform that'd be even more important than it is on desktops. > > Why are the data members protected instead of private? Per Darin Adler we > > should make things as private as possible. > > because the subclasses need to access them What subclasses? > > Having both setRGB16() and setRGBA() seems like a poor API for callers. Why > > doesn't setRGBA() just write the data in 16-bit format if the bitmap is 16-bit? > > they also have different inputs This response is vague enough that I haven't learned anything. What is the difference and why can't it be created at the SharedBuffer or ImageFrameSink level? > > Why does getFrame() return 0 when the status is frameEmpty? An empty frame is > > still a valid one. > > why? Who likes to waste CPU time on empty frame? What CPU is being wasted? We don't blit anything with empty frames. > > The proper use of setCanFreeBuffer() is not obvious to me. > > This nofities the buffer that decoder has finished writting to the buffer, so > the buffer can be released when it's under memory pressure. Isn't this the same signal as setting the status to FrameComplete? > The one that I'm most concerned is about GIF m_compositedWithPreviousFrame > thing. That's complicated, and ImageFrameSink code works in a little different > way. Want to talk to somebody on this. Maybe you could write up a short doc with descriptions of the existing code and your code, pointing out the differences and why they are valuable? I can guess how someone would implement GIF animation with a flag like this but I can't see how to do it without needing to keep a potentially arbitrary number of frames around, for example if you scroll an animated GIF out of the viewport and then back in (causing the animation to need to spin forward). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 12:17:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 12:17:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814191705.97A7D34E3CD7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #39 from Yong Li 2009-08-14 12:17:03 PDT --- (In reply to comment #38) > (In reply to comment #37) > > (In reply to comment #30) > > But does anyone do that? It doesn't look like it from this patch. Why build > factory functions unless you need them? See first patch. We have ImageFrameSinkWince defined which holds a SharedBitmap as the buffer provider. > > I don't understand. I know how GIF animation and frame disposal methods work. > The existing ports handle them correctly without using this mechanism. Why > doesn't the existing mechanism work for you, and how do you deal with not > having the frame-clearing optimization for large GIFs? I would think on a > memory-constrained platform that'd be even more important than it is on > desktops. I've fixed many bugs on it, and our browser runs OK. Let me review this and get back to you. I did that so long time ago :) > What subclasses? ImageFrameSinkWince, if I am not wrong. > > > > Having both setRGB16() and setRGBA() seems like a poor API for callers. Why > > > doesn't setRGBA() just write the data in 16-bit format if the bitmap is 16-bit? > > > > they also have different inputs > > This response is vague enough that I haven't learned anything. What is the > difference and why can't it be created at the SharedBuffer or ImageFrameSink > level? I'm lost now. I thought you mean why setRGB16 and setRGBA cannot share a same function. If that was the question, I would say separate functions are definitely better. > > > > Why does getFrame() return 0 when the status is frameEmpty? An empty frame is > > > still a valid one. > > > > why? Who likes to waste CPU time on empty frame? > > What CPU is being wasted? We don't blit anything with empty frames. So why cannot it return 0? > > > > The proper use of setCanFreeBuffer() is not obvious to me. > > > > This nofities the buffer that decoder has finished writting to the buffer, so > > the buffer can be released when it's under memory pressure. > > Isn't this the same signal as setting the status to FrameComplete? FrameComplete is just for a single frame. But GIF decoder may still want to read a finished frame when it processes the next one. > > > The one that I'm most concerned is about GIF m_compositedWithPreviousFrame > > thing. That's complicated, and ImageFrameSink code works in a little different > > way. Want to talk to somebody on this. > > Maybe you could write up a short doc with descriptions of the existing code and > your code, pointing out the differences and why they are valuable? ok. but for why they are valuable, I have mentioned in bug 26467, see comment #5 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 12:44:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 12:44:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814194424.E10C434E4036@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34851|0 |1 is obsolete| | Attachment #34867| |review? Flag| | --- Comment #5 from Yong Li 2009-08-14 12:44:23 PDT --- Created an attachment (id=34867) --> (https://bugs.webkit.org/attachment.cgi?id=34867) modified for coding style... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 12:57:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 12:57:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814195709.268FB34E416F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #40 from Peter Kasting 2009-08-14 12:57:08 PDT --- (In reply to comment #39) > (In reply to comment #38) > > (In reply to comment #37) > > > (In reply to comment #30) > > > > But does anyone do that? It doesn't look like it from this patch. Why build > > factory functions unless you need them? > > See first patch. We have ImageFrameSinkWince defined which holds a SharedBitmap > as the buffer provider. I looked at most of the patches and missed any ImageFrameSinkWince class. It looks in this patch like you have an ImageFrameSinkWince.cpp, but it's just filling out the functions of ImageFrameSink and doesn't do any subclassing. Maybe I'm missing something. > > I don't understand. I know how GIF animation and frame disposal methods work. > > The existing ports handle them correctly without using this mechanism. Why > > doesn't the existing mechanism work for you, and how do you deal with not > > having the frame-clearing optimization for large GIFs? I would think on a > > memory-constrained platform that'd be even more important than it is on > > desktops. > > I've fixed many bugs on it, and our browser runs OK. Let me review this and get > back to you. I did that so long time ago :) Try cases like http://www.aintitcool.com/files/HoD2.gif and http://img2.abload.de/img/almost_failedovs.gif and make sure that: * Images animate in the same time as Chrome 2/Safari 4 (not slower) * You don't blow out memory or CPU usage > > > > Having both setRGB16() and setRGBA() seems like a poor API for callers. Why > > > > doesn't setRGBA() just write the data in 16-bit format if the bitmap is 16-bit? > > > > > > they also have different inputs > > > > This response is vague enough that I haven't learned anything. What is the > > difference and why can't it be created at the SharedBuffer or ImageFrameSink > > level? > > I'm lost now. I thought you mean why setRGB16 and setRGBA cannot share a same > function. If that was the question, I would say separate functions are > definitely better. It sounds like we're not understanding each other. My object is to reduce the complexity and special-casing of shared code, especially the decoders themselves. Let's say platform X supports native image storage in various formats (565, 888, 8888, etc.). The pattern that makes sense to me is: Image Decoder reads the pixel values out of the source image and calls setRGBA with them ImageFrameSink/RGBA32Buffer/whatever passes these values along to the backend's underlying NativeImage functions These functions decide how to downsample to an appropriate format With your existing code, the downsampling would need to be done in the decoder, which would need to check whether the image frame claims to be 16-bit. All that seems to do is cause us to plumb more state up through shared code and push the complexity on everyone. > > > > Why does getFrame() return 0 when the status is frameEmpty? An empty frame is > > > > still a valid one. > > > > > > why? Who likes to waste CPU time on empty frame? > > > > What CPU is being wasted? We don't blit anything with empty frames. > > So why cannot it return 0? Practically, it can; there are only two reasons I wouldn't do it: * The API is lying * A backend can't read any data off a NULL pointer, such as the size of the frame, if it wants it If it makes no difference, I don't see why we should lie to callers. It's not a big deal, it just seems like a waste to explicitly check for an empty frame so we can lie. > > > > The proper use of setCanFreeBuffer() is not obvious to me. > > > > > > This nofities the buffer that decoder has finished writting to the buffer, so > > > the buffer can be released when it's under memory pressure. > > > > Isn't this the same signal as setting the status to FrameComplete? > > FrameComplete is just for a single frame. But GIF decoder may still want to > read a finished frame when it processes the next one. So it's _not_ about the decoder being finished writing to the buffer. It's some signal that the decoder is finished reading the buffer too. In that case it seems like a bug that you don't finishBitmap() when we go to FrameComplete. In this case I suggest copying clear() from the existing code, which is designed for precisely this functionality. Note that there are fewer member variables involved (no "should" and "can" distinction). > > > The one that I'm most concerned is about GIF m_compositedWithPreviousFrame > > > thing. That's complicated, and ImageFrameSink code works in a little different > > > way. Want to talk to somebody on this. > > > > Maybe you could write up a short doc with descriptions of the existing code and > > your code, pointing out the differences and why they are valuable? > > ok. but for why they are valuable, I have mentioned in bug 26467, see comment > #5 It's not at all obvious in the code that these are useful for dynamic image scaling. Nor do I see what they buy you for scaling versus the decoding technique in the existing code. I think I'd benefit from a writeup :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:01:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:01:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814200145.4D45E34E41ED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barraclough at apple.com --- Comment #2 from Gavin Barraclough 2009-08-14 13:01:44 PDT --- You seem to be checking in another mozilla test failing? If so, is this intentional, could you not just fix the test? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:02:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:02:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814200227.637F834E41F9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 --- Comment #3 from Oliver Hunt 2009-08-14 13:02:27 PDT --- I suppose i could do that... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:03:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:03:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28313] New: Combine ThreadableLoaderOptions::CrossOriginRequestPolicy and CrossOriginRedirectPolicy Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28313 Summary: Combine ThreadableLoaderOptions::CrossOriginRequestPolicy and CrossOriginRedirectPolicy Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: aa at chromium.org CC: ap at webkit.org, dimich at chromium.org, levin at chromium.org They are always set the same way. Also, I believe that ::resolveURL() no longer has to do the same origin check -- we can rely on ThreadableLoader to do it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:04:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:04:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28313] Combine ThreadableLoaderOptions::CrossOriginRequestPolicy and CrossOriginRedirectPolicy In-Reply-To: References: Message-ID: <20090814200403.E035934E4257@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28313 --- Comment #1 from Aaron Boodman 2009-08-14 13:04:01 PDT --- (In reply to comment #0) > Also, I believe that ::resolveURL() no longer has to do the same origin check Talking here about AbstractWorker::resolveURL(). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:07:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:07:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814200706.83E4634E4281@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #41 from Yong Li 2009-08-14 13:07:05 PDT --- (In reply to comment #40) > (In reply to comment #39) > > (In reply to comment #38) > > > (In reply to comment #37) > > > > (In reply to comment #30) > > > > I looked at most of the patches and missed any ImageFrameSinkWince class. It > looks in this patch like you have an ImageFrameSinkWince.cpp, but it's just > filling out the functions of ImageFrameSink and doesn't do any subclassing. > > Maybe I'm missing something. Hm... Sorry, ImageFrameSinkWince has been removed by refactoring... too long story. But createInstance and deleteInstance are already added, providing ability to subclass ImageFrameSink, which should be fine. > > > > I don't understand. I know how GIF animation and frame disposal methods work. > > > The existing ports handle them correctly without using this mechanism. Why > > > doesn't the existing mechanism work for you, and how do you deal with not > > > having the frame-clearing optimization for large GIFs? I would think on a > > > memory-constrained platform that'd be even more important than it is on > > > desktops. > > > > I've fixed many bugs on it, and our browser runs OK. Let me review this and get > > back to you. I did that so long time ago :) > > Try cases like http://www.aintitcool.com/files/HoD2.gif and > http://img2.abload.de/img/almost_failedovs.gif and make sure that: > * Images animate in the same time as Chrome 2/Safari 4 (not slower) > * You don't blow out memory or CPU usage Thanks for providing this test case. I'm confident our browser won't crash :) Will try it > > My object is to reduce the complexity and special-casing of shared code, > especially the decoders themselves. Let's say platform X supports native image > storage in various formats (565, 888, 8888, etc.). The pattern that makes > sense to me is: > > Image Decoder reads the pixel values out of the source image and calls setRGBA > with them > ImageFrameSink/RGBA32Buffer/whatever passes these values along to the backend's > underlying NativeImage functions > These functions decide how to downsample to an appropriate format > > With your existing code, the downsampling would need to be done in the decoder, > which would need to check whether the image frame claims to be 16-bit. All > that seems to do is cause us to plumb more state up through shared code and > push the complexity on everyone. I think you make a good point here. > > > > > > Why does getFrame() return 0 when the status is frameEmpty? An empty frame is > > > > > still a valid one. > > > > > > > > why? Who likes to waste CPU time on empty frame? > > > > > > What CPU is being wasted? We don't blit anything with empty frames. > > > > So why cannot it return 0? > > Practically, it can; there are only two reasons I wouldn't do it: > * The API is lying > * A backend can't read any data off a NULL pointer, such as the size of the > frame, if it wants it > > If it makes no difference, I don't see why we should lie to callers. It's not > a big deal, it just seems like a waste to explicitly check for an empty frame > so we can lie. The object itself has size and all information. getFrame() just return a platform image, which can be null when it doesn't want to return a valid image. for example, failed to allocated memory for it. > > > > > > The proper use of setCanFreeBuffer() is not obvious to me. > > > > > > > > This nofities the buffer that decoder has finished writting to the buffer, so > > > > the buffer can be released when it's under memory pressure. > > > > > > Isn't this the same signal as setting the status to FrameComplete? > > > > FrameComplete is just for a single frame. But GIF decoder may still want to > > read a finished frame when it processes the next one. > > So it's _not_ about the decoder being finished writing to the buffer. It's > some signal that the decoder is finished reading the buffer too. In that case > it seems like a bug that you don't finishBitmap() when we go to FrameComplete. finisheBitmap() is called when ImageSource is taking the bitmap. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:07:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:07:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814200754.66E6134E429F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34826|review? | Flag| | Attachment #34826|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:07:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:07:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814200759.800F434E42AA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34869| |review? Flag| | --- Comment #4 from Oliver Hunt 2009-08-14 13:07:58 PDT --- Created an attachment (id=34869) --> (https://bugs.webkit.org/attachment.cgi?id=34869) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:08:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:08:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814200819.933F634E42C2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 --- Comment #5 from Oliver Hunt 2009-08-14 13:08:19 PDT --- Gavin i has fixed it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:11:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:11:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28315] New: Update our copy of the mozilla JS regression test suite Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28315 Summary: Update our copy of the mozilla JS regression test suite Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: oliver at apple.com CC: mjs at apple.com, ggaren at apple.com Our testing includes the mozilla js regression suite, however a copy is now quite old so we should update. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:11:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:11:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814201142.DD02834E4330@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34869|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:13:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:13:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28309] [Haiku] Adding SharedBufferHaiku to WebCore. In-Reply-To: References: Message-ID: <20090814201342.40A9934E436E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28309 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34853|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:14:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:14:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814201423.0D0B534E4392@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34846|review? |review+, commit-queue+ Flag| | --- Comment #2 from Oliver Hunt 2009-08-14 13:14:22 PDT --- (From update of attachment 34846) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:19:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:19:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814201905.16A5E34E4426@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #42 from Adam Treat 2009-08-14 13:19:04 PDT --- (In reply to comment #41) > > My object is to reduce the complexity and special-casing of shared code, > > especially the decoders themselves. Let's say platform X supports native image > > storage in various formats (565, 888, 8888, etc.). The pattern that makes > > sense to me is: > > > > Image Decoder reads the pixel values out of the source image and calls setRGBA > > with them > > ImageFrameSink/RGBA32Buffer/whatever passes these values along to the backend's > > underlying NativeImage functions > > These functions decide how to downsample to an appropriate format > > > > With your existing code, the downsampling would need to be done in the decoder, > > which would need to check whether the image frame claims to be 16-bit. All > > that seems to do is cause us to plumb more state up through shared code and > > push the complexity on everyone. > > I think you make a good point here. You both are assuming that the decoder can stream pixels directly into the native image buffer. That simply isn't the case for some of the existing users of the built-in image decoders. This was covered I think by Holger. It might not even be the case that the native image buffer is in main memory. At this point, I think the discussion should move away from WinCE's ImageFrameSink and more towards the path we want to take in the future. I still do not believe we are all on the same page. Perhaps a conference call or two with all interested parties would be in order. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:19:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:19:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814201937.21CF734E443C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #6 from Oliver Hunt 2009-08-14 13:19:36 PDT --- Committed r47292 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:19:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:19:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26317] event-based debugging / profiling In-Reply-To: References: Message-ID: <20090814201956.DD7FB34E445C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26317 --- Comment #2 from Patrick Mueller 2009-08-14 13:19:55 PDT --- started looking into this a bit. I think the idea is going to be to do some logging of events that get fired. Which you could then lead you to a javascript handler you could set a breakpoint on. Not terribly elaborate, but no extensive stack traces required or anything either. Place I'm poking around right now is Node::dispatchEvent() in WebCore/dom, but need to do a bit more debugging to follow the flows. Haven't though too much about the UI for this. I think it needs to go in the Scripts panel somehow. Perhaps another section on the right showing you the events and pointers to the source. Seems like this will need to be an opt-in scenario, which is fine as you prolly won't be needing to use the function all the time. opt-in per session. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:20:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:20:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28306] double-clicking a word inside beside newline select two words In-Reply-To: References: Message-ID: <20090814202001.CD93734E4462@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28306 --- Comment #3 from Darin Adler 2009-08-14 13:20:01 PDT --- (From update of attachment 34847) This does not look like the right fix to me. I don't have time to study the issue at this time, and I could be wrong. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:20:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:20:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814202059.C7FBD34E4484@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #43 from Yong Li 2009-08-14 13:20:59 PDT --- > Try cases like http://www.aintitcool.com/files/HoD2.gif and > http://img2.abload.de/img/almost_failedovs.gif and make sure that: > * Images animate in the same time as Chrome 2/Safari 4 (not slower) > * You don't blow out memory or CPU usage Hm... you're right, these are too big GIF, we have to clean the memory for previous frames. thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:22:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:22:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814202236.AC37634E44C4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34846|commit-queue+ |commit-queue- Flag| | --- Comment #3 from Eric Seidel 2009-08-14 13:22:36 PDT --- (From update of attachment 34846) Rejecting patch 34846 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:23:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:23:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814202314.26A4034E44CE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #44 from Yong Li 2009-08-14 13:23:13 PDT --- (In reply to comment #43) > > Try cases like http://www.aintitcool.com/files/HoD2.gif and > > http://img2.abload.de/img/almost_failedovs.gif and make sure that: > > * Images animate in the same time as Chrome 2/Safari 4 (not slower) > > * You don't blow out memory or CPU usage > > Hm... you're right, these are too big GIF, we have to clean the memory for > previous frames. thanks. seems the crash is due to some changes made in upstream. our previous builds work with them with no problem. investigating -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:25:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:25:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28316] New: bugzilla-tool land-patches needs to know how to run update-webkit when commits fail Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28316 Summary: bugzilla-tool land-patches needs to know how to run update-webkit when commits fail Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org bugzilla-tool land-patches needs to know how to run update-webkit when commits fail If the commit fails due to an out-of-date file. I'm about to write a patch to fix this... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:25:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:25:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814202536.13E4534E4518@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34846|commit-queue- |commit-queue+ Flag| | --- Comment #4 from Eric Seidel 2009-08-14 13:25:35 PDT --- (From update of attachment 34846) Sorry, the commit-queue is dumb. There were 2 commits to the WebCore/ChangeLog between when the commit-queue updated and when it tried to commit. I'm about to teach it how to update itself before commit... bug 28316 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:31:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:31:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814203128.6783234E45CE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 --- Comment #5 from Maxime Simon 2009-08-14 13:31:27 PDT --- (In reply to comment #4) > (From update of attachment 34846 [details]) > Sorry, the commit-queue is dumb. There were 2 commits to the WebCore/ChangeLog > between when the commit-queue updated and when it tried to commit. I'm about > to teach it how to update itself before commit... bug 28316 Okay. I didn't understand why it could fail as there was nothing "exotic" in this patch. But indeed bugzilla-tool is still in a learning phase. ;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:35:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:35:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28309] [Haiku] Adding SharedBufferHaiku to WebCore. In-Reply-To: References: Message-ID: <20090814203542.9BF3134E4626@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28309 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34853|review+, commit-queue+ | Flag| | --- Comment #2 from Eric Seidel 2009-08-14 13:35:42 PDT --- (From update of attachment 34853) Clearing flags on attachment: 34853 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/haiku/SharedBufferHaiku.cpp M WebCore/platform/haiku/TemporaryLinkStubs.cpp Committed r47295 M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool r47294 = ac71e42f212fa9492e2b894e641eb8f4fca95a53 (trunk) M WebCore/ChangeLog M WebCore/platform/haiku/TemporaryLinkStubs.cpp A WebCore/platform/haiku/SharedBufferHaiku.cpp r47295 = 8fb3fb4bf759f54e3920c3b5cbe5c41500cd13d6 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/47295 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:35:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:35:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28309] [Haiku] Adding SharedBufferHaiku to WebCore. In-Reply-To: References: Message-ID: <20090814203545.EB00534E4636@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28309 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-14 13:35:44 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:37:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:37:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27903] [Qt] Text in strike tag not rendered with a strike through it. In-Reply-To: References: Message-ID: <20090814203735.7FFE434E4670@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27903 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george.wright at torchmobile.c | |om --- Comment #1 from George Wright 2009-08-14 13:37:34 PDT --- Seems to work fine here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:39:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:39:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814203914.5529634E46D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34856|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:39:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:39:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28280] WebInspector: Evaluating objects while on a breakpoint dumps string representation instead of live object. In-Reply-To: References: Message-ID: <20090814203937.994FD34E46DF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28280 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34841|0 |1 is obsolete| | Attachment #34870| |review? Flag| | --- Comment #3 from Pavel Feldman 2009-08-14 13:39:36 PDT --- Created an attachment (id=34870) --> (https://bugs.webkit.org/attachment.cgi?id=34870) patch >> Can you break this out into a named function so it is easier to read? It took >> me a second to realize this was being passed as an argument. Done. Thanks for review! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:39:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:39:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814203954.AEA5134E46E9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34772|review? | Flag| | --- Comment #45 from Adam Treat 2009-08-14 13:39:53 PDT --- (From update of attachment 34772) Clearing flags as these need more discussion anyways -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:43:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:43:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28280] WebInspector: Evaluating objects while on a breakpoint dumps string representation instead of live object. In-Reply-To: References: Message-ID: <20090814204331.A69E234E476C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28280 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34870|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:52:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:52:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814205217.93DF634E480A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34846|review+, commit-queue+ | Flag| | --- Comment #6 from Eric Seidel 2009-08-14 13:52:16 PDT --- (From update of attachment 34846) Clearing flags on attachment: 34846 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/haiku/RenderThemeHaiku.cpp M WebCore/platform/haiku/RenderThemeHaiku.h Committed r47296 M WebCore/ChangeLog M WebCore/platform/haiku/RenderThemeHaiku.cpp M WebCore/platform/haiku/RenderThemeHaiku.h r47296 = c0737da3bd221d15fd82b932dc33967859956e54 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47296 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:52:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:52:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814205221.458F034E4822@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #7 from Eric Seidel 2009-08-14 13:52:20 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:02:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:02:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28316] bugzilla-tool land-patches needs to know how to run update-webkit when commits fail In-Reply-To: References: Message-ID: <20090814210210.6BF4A34E491D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28316 --- Comment #1 from Eric Seidel 2009-08-14 14:02:09 PDT --- Created an attachment (id=34871) --> (https://bugs.webkit.org/attachment.cgi?id=34871) First attempt -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:11:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:11:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28316] bugzilla-tool land-patches needs to know how to run update-webkit when commits fail In-Reply-To: References: Message-ID: <20090814211135.17C8F34E49CB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28316 --- Comment #2 from Eric Seidel 2009-08-14 14:11:34 PDT --- I'm testing this patch on the commit-queue bot now. If it works well, I'll mark it for review (with a ChangeLog). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:14:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:14:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814211439.B591D34E4A43@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34400|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:14:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:14:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814211456.257C134E4A65@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34395|review? | Flag| | Attachment #34395|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:15:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:15:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814211535.4DCCF34E4A95@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34393|review? | Flag| | Attachment #34393|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:16:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:16:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814211605.817E434E4ABF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34401| |review+, commit-queue+ Flag| | --- Comment #95 from Yong Li 2009-08-14 14:16:02 PDT --- (From update of attachment 34401) seems already landed? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:18:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:18:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090814211804.428E934E4AF3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34135|review- |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:25:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:25:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28317] New: Assertion being hit on layout tests in debug build Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28317 Summary: Assertion being hit on layout tests in debug build Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gns at gnome.org I am hitting an assertion when running some of the tests that are currently failing in the GTK+ bot: ASSERTION FAILED: differenceBetween(coldPathBegin, call) == patchOffsetGetByIdSlowCaseCall (../../JavaScriptCore/jit/JITPropertyAccess.cpp:1260 void JSC::JIT::compileGetByIdSlowCase(int, int, JSC::Identifier*, JSC::SlowCaseEntry*&, bool)) One such test: http/tests/xmlhttprequest/origin-header-cross-origin-get-async.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:34:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:34:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28317] Assertion being hit on layout tests in debug build In-Reply-To: References: Message-ID: <20090814213410.6C85734E4CBD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28317 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barraclough at apple.com, | |oliver at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:34:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:34:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28318] New: Failed assertion when bringing up Safari's error console Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28318 Summary: Failed assertion when bringing up Safari's error console Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: atwilson at chromium.org CC: simon.fraser at apple.com Run safari bring up the error console (via the Develop menu) Get the following failed assertion: ASSERTION FAILED: m_clients.contains(renderer) (WebCore/css/CSSGradientValue.cpp:109 virtual WebCore::Image* WebCore::CSSGradientValue::image(WebCore::RenderObject*, const WebCore::IntSize&)) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:36:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:36:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28318] Failed assertion when bringing up Safari's error console In-Reply-To: References: Message-ID: <20090814213647.0A12C34E4D10@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28318 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Platform|PC |All AssignedTo|webkit-unassigned at lists.web |simon.fraser at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:47:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:47:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28319] New: [Qt] run-webkit-tests hangs on certain pixel tests with nonfinite tests Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28319 Summary: [Qt] run-webkit-tests hangs on certain pixel tests with nonfinite tests Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://philip.html5.org/tests/canvas/suite/tests/2d.im ageData.create.nonfinite.html OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: george.wright at torchmobile.com The testcase in the URL causes run-webkit-tests to hang when trying to process that file for pixel tests. It seems it is hanging on all test cases that use the Infinity keyword. It seems that DumpRenderTree Qt is reporting an incorrect PNG length when dumping the PNG data (or more likely that the PNG data is being truncated), which is causing run-webkit-tests to hang waiting for more data which doesn't come. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:50:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:50:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28285] Remove non-spec support for callable RegExp In-Reply-To: References: Message-ID: <20090814215033.75AEF34E4E3B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28285 --- Comment #2 from Gavin Barraclough 2009-08-14 14:50:32 PDT --- > Additional ramifications from this are that native JSON.stringify > will ignore RegExp instances as it does Functions. Hmmm, this certainly does sound like a ramification we should consider carefully, and could even be a reason to remove the ability to call RegExp objects. > It seems to me the value of syntactic sugar that shaves 5 characters from > /a/.exec("abc") is not worth the price of creating a development environment > where testing random input to see if it is a function changes from > > if (typeof v === "function") { > > to > if (typeof v === "function" && v.call) { The spec states "Unless specified otherwise, the [[Class]] property of a built-in object is "Function" if that built-in object has a [[Call]] property, or "Object" if that built-in object does not have a [[Call]] property." This would seem to pretty clearly imply that an object of a class other than "Function" can validly implement [[Call]] (provided that it is stated as such), and therefore assuming that an object with a [[Call]] property is specifically of class Function is incorrect. To test for a function you can just use the instaceof operator: if (v instanceof Function) > Because /a/(str) is not supported across all current browsers, it is not > recommended for use in scripts that will live in internet environments > available for public consumption. So currently, there is no benefit to the > extension for IMO the largest consumer base (web developers), but there is a > cost. > > Other js runtimes include support for callable RegExp (Opera 9.6-10 beta2, > Firefox 3.0-3.5, Chrome 3) though they all maintain typeof /a/ == "object". Hmmm, section 11.4.3 seems pretty clear, and I certainly can't agree with FireFox's implementation here. The spec very clearly states that for any native object that implements [[Call]] the typeof operator must return "function". So far as I'm aware, this is the only way within the language to ask this specific question (is this any kind of object that can be called as a function, as opposed to, is this object an instance of "Function"), and it doesn't seem like a capability we'd want to take away. So I can't say that I think we want to unify on FireFox's present behaviour here. I believe WebKit's current behavior is sensible, and is not fundamentally at conflict with the spec (and it would also be a sensible and consistent state to remove the ability to call RegExp objects as functions). I would suggest the FireFox's RegExp implementation is presently noncompliant with the spec in that it violates section 11.4.3 - a native object with a [[Call]] property fails to return "function" from typeof. It would probably be helpful to file a bug with them. > new obj.someRegExp(str) => boom If I'm understanding your test case correctly, you seem to be assuming that all objects that have a [[Call]] property must also have a [[Construct]] property? >From my reading of the spec this is not required (and is not a requirement within WebKit). > someRegExp.call(obj,str) => boom If I'm understanding your test case correctly, you seem to be assuming that all objects that have a [[Call]] property must be of class Function, and have the Function prototype featuring a "call" property? From my reading of the spec this is again not required (and again is not a requirement within WebKit). I'm tempted to close as behaves correctly, though as I say the 'JSON.stringify' issue certainly does seem interesting. :-/ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:52:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:52:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28321] New: bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28321 Summary: bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches bugzilla-tool properly detects when a pach has r+ or cq+ set by someone who does not have proper rights. However it doesn't know how to clean up the bug after that. It should clear flags which have been set erroneously. What makes this tricky is the current architecture is to do that lookups/validation inside the patch fetch function. Which is wrong. We should get all the patch information in one function and validate the patches separately. Or at least have some sort of validate=True flag which is passed to the fetch function. I have a partial patch on my machine, but I'll have to finish it later... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:53:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:53:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28321] bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches In-Reply-To: References: Message-ID: <20090814215309.AFDDD34E4EAB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28321 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abarth at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:53:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:53:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28322] New: fast/borders/border-radius-constraints.html is missing expected png Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28322 Summary: fast/borders/border-radius-constraints.html is missing expected png Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: tony at chromium.org The layout test fast/borders/border-radius-constraints.html doesn't have an expected png checked in. It has a checksum, so the pixel tests can run and verify it hasn't changed, but there's no actual png to visually check against. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:55:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:55:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28322] fast/borders/border-radius-constraints.html is missing expected png In-Reply-To: References: Message-ID: <20090814215502.88F8434E4F02@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28322 --- Comment #1 from Tony Chang (Google) 2009-08-14 14:55:01 PDT --- The same is true for fast/borders/border-radius-split-inline.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:00:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:00:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28317] Assertion being hit on layout tests in debug build In-Reply-To: References: Message-ID: <20090814220054.BDBE234E4F92@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28317 --- Comment #1 from Gustavo Noronha (kov) 2009-08-14 15:00:54 PDT --- Created an attachment (id=34872) --> (https://bugs.webkit.org/attachment.cgi?id=34872) backtrace -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:02:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:02:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code In-Reply-To: References: Message-ID: <20090814220230.6CCE434E4FD4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27967 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34617|review? | Flag| | Attachment #34617|0 |1 is obsolete| | Attachment #34873| |review? Flag| | --- Comment #12 from Dumitru Daniliuc 2009-08-14 15:02:27 PDT --- Created an attachment (id=34873) --> (https://bugs.webkit.org/attachment.cgi?id=34873) patch (In reply to comment #11) > 187 'storage/SQLTransactionClientImpl.cpp', > Some of the make files make reference to SQLTransactionClientImpl.cpp, did you > mean SQLTransactionClient.cpp here? yes, fixed. > 330 m_transactionClient->databaseSizeChanged(m_database.get()); > So this method is invoked on the background db thread. > > 392 m_shouldRetryCurrentStatement = > m_transactionClient->databaseExceedsQuota(...); > And this one on the 'apartment' thread of the Database object (the main thread) > > 426 m_transactionClient->databaseChanged(m_database.get()); > And this one on the background thread > > I would appreciate some indication of the threading usage in the > SQLTransactionListener source files. To figure out how it was used, i had to > track down the callsites. Not sure how to best indicate the threading rules... > either doc comments in the .h file, or runtime asserts in the .cpp file? added ASSERTs in the .cpp file. i don't think we should make assumptions for all ports. > 38 // A "listener" interface to the SQLTransaction class. Allows > 39 // SQLTransaction to notify interested parties when certain things are > 40 // happening in a transaction. > 41 class SQLTransactionClient { > 42 public: > 43 // Notifies everybody that the database has changed. Called at the > end > 44 // end of every successful transaction. > 45 void databaseChanged(Database*); > 46 > 47 // Notifies everybody that the size of the database file might have > changed. > 48 // Called after executing each statement in a transaction > 49 void databaseSizeChanged(Database*); > 50 > 51 // Notifies everybody that the size of the database file exceeds > its quota. > 52 // If this method returns true, the current statement in the > transaction is > 53 // retried. Otherwise, the transaction is rolled back. > 54 // > 55 // This method should return true if and only if the quota for this > database > 56 // file was increased (by the user, for example) since calling this > method. > 57 bool databaseExceedsQuota(Database*); > 58 }; > 59 } > > After reading your doc comments, maybe these methods could be renamed for > clarity. > > void didCommitTransaction(...); // for databaseChanged > void didExecuteStatement(...); // for databaseSizeChanged > bool didExceedQuota(...); // for databaseExceedsQuota changed. > And would it make sense to have the SQLTransaction* be the parameter since it > is a transaction listener, the caller can get the Database* from the accessor > on the transaction object (i think). done. you're right: SQLTransactionCoordinator should work with SQLTransactions. > Also, the new class (TransactionCoordinator) you just added is also a > transaction listener of sorts. Should these two classes be merged? i think we will eventually merge them. for now though, i think it's better to introduce SQLTransactionClient as a separate piece of code (to make it easier to review and understand). > The TransactionCoordinator must be owned by the DBThread to properly serve its > purpose. In this patch, you have the new 'listener' object being owned by the > Database object, but i think it could just as easily be owned by the DBThread > and serve its purpose. > > Wdyt? done. > 60 RefPtr origin = database->securityOriginCopy(); > > Making a copy of a refcounted object looks odd? Is it mutable? Is there no > database->securityOrigin() accessor? this seems to be the only accessor for getting the origin from a Database object. we could probably introduce a new accessor (or replace the existing one), but i wouldn't want to do this before talking to the authors of this code and understanding why they had a copying accessor here in the first place. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:05:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:05:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27371] [WINCE] Add WinCE specific platform/text files to WebCore In-Reply-To: References: Message-ID: <20090814220536.11ED234E5041@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27371 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34875| |review? Flag| | --- Comment #11 from Yong Li 2009-08-14 15:05:34 PDT --- Created an attachment (id=34875) --> (https://bugs.webkit.org/attachment.cgi?id=34875) modified Thai.cpp and Euc_jp.cpp moved out -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:05:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:05:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814220557.2CD8034E5069@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34401|review+, commit-queue+ | Flag| | --- Comment #96 from Eric Seidel 2009-08-14 15:05:55 PDT --- (From update of attachment 34401) bugzilla-tool isn't quite smart enough to know how to reject this patch yet. It is smart enough to know that you're not a reviewer however. :) Only reviewers can set r+. Exception: Committer "Yong Li" does not have review rights. Documentation of the review process is part of the committer agreement that you signed. :) http://webkit.org/quality/lifecycle.html has more information if you need. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:10:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:10:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814221052.37EF834E5111@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 --- Comment #97 from Yong Li 2009-08-14 15:10:50 PDT --- (In reply to comment #96) > (From update of attachment 34401 [details]) > bugzilla-tool isn't quite smart enough to know how to reject this patch yet. > It is smart enough to know that you're not a reviewer however. :) Only > reviewers can set r+. > > Exception: Committer "Yong Li" does not have review > rights. > > Documentation of the review process is part of the committer agreement that you > signed. :) > > http://webkit.org/quality/lifecycle.html has more information if you need. that patch is already landed. just want to mark it with something other than "No flag". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:11:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:11:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28254] [Chromium] Remove legacy code in "WebCore/platform/chromium/PopupMenuChromium.cpp" In-Reply-To: References: Message-ID: <20090814221124.8EDC834E513D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28254 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34825|review? | Flag| | --- Comment #5 from Eric Seidel 2009-08-14 15:11:23 PDT --- (From update of attachment 34825) This bug is resolved. No need for this patch to be marked for review. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:14:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:14:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28310] Chromium: Show a "Mute Disabled" button on audio error. In-Reply-To: References: Message-ID: <20090814221419.466A234E518D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28310 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34864|review? |review- Flag| | --- Comment #2 from Eric Seidel 2009-08-14 15:14:18 PDT --- (From update of attachment 34864) I'm not a media expert, but this patch looks wrong. Mostly because the methods look out of place: One of these does not look like the other: virtual bool isVideo() const { return false; } virtual bool hasVideo() const { return false; } + virtual bool hasAudio() const { return player() && player()->hasAudio(); } And again: virtual bool hasVideo() const = 0; + virtual bool hasAudio() const { return true; } It seems maybe you're not following the design of the rest of the media classes? Please explain. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:19:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:19:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814221930.7F21C34E51F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34867|review? |review- Flag| | --- Comment #6 from Eric Seidel 2009-08-14 15:19:29 PDT --- (From update of attachment 34867) 126 #ifdef IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS 127 m_decoder->setMaxNumPixels(IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS); 128 #else 129 m_decoder->setMaxNumPixels(1024 * 1024); 130 #endif Would be better to check #ifdef IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS at the top fo the file, and define IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS to 1024 * 1024 if not defined. Seems we'd benifit from some nicely named local variables: 47 case Exact: 48 return pos != dataEnd && *pos == orig ? pos - dataStart : -1; 49 case LowerBound: 50 return pos != dataEnd && *pos == orig ? pos - dataStart : pos - dataStart - 1; 51 case UpperBound: 52 default: 53 return pos != dataEnd ? pos - dataStart : -1; Style: 84 double zoom = 1. /shrink; I would have made this a static inline function to prevent copy/paste: 94 m_scaledRows.reserveCapacity(height * shrink + 0.5); 95 for (int scaledY = 0;;) { 96 int y = scaledY * zoom + 0.5; 97 if (y < height) { 98 m_scaledRows.append(y); 99 ++scaledY; 100 } else 101 break; 102 } 64 bool good = ImageDecoder::setSize(width, height); good is not the word you want. success would be better. setSizeOK would be another option. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:20:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:20:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28306] double-clicking a word inside beside newline select two words In-Reply-To: References: Message-ID: <20090814222009.9074A34E5224@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28306 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34847|review? |review- Flag| | --- Comment #4 from Eric Seidel 2009-08-14 15:20:09 PDT --- (From update of attachment 34847) Needs ChangeLog. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:20:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:20:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28325] New: Safari not handling quoted paths correctly in version 1 cookies Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28325 Summary: Safari not handling quoted paths correctly in version 1 cookies Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows XP Status: NEW Severity: Major Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: andrejohn.mas at gmail.com Created an attachment (id=34876) --> (https://bugs.webkit.org/attachment.cgi?id=34876) Test case illustrating the issue. JSP file. Tested with Safari 4.0.2 with Windows XP SP2. If the cookie version is set to '1' in either WebLogic or Tomcat, and the path is set, then the value is quoted: Set-Cookie: Customer="WILE_E_COYOTE"; Version="1"; Path="/" Which is correct behaviour according to RFC 2109 (examples in section 5). The problem is that Safari treats the quotes as if they were part of the part, rather than simply surrounding the path. This can be observed by trying to read the cookie value back on the server when the browser points to the root of the server: http://.../ Also, when looking at the cookies in the preferences, the path shown is: %22/%22 I have attached a JSP file as a test case. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:20:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:20:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28325] Safari not handling quoted paths correctly in version 1 cookies In-Reply-To: References: Message-ID: <20090814222039.F26C234E523F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28325 Andre-John Mas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrejohn.mas at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:21:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:21:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28304] S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite In-Reply-To: References: Message-ID: <20090814222109.C1B0A34E525B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28304 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org, | |oliver at apple.com --- Comment #2 from Eric Seidel 2009-08-14 15:21:08 PDT --- I don't understand this hack. Why can't we fix this for real? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:24:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:24:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814222404.2777F34E52C5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #98 from Eric Seidel 2009-08-14 15:24:02 PDT --- Closing bug since all patches have been landed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:24:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:24:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814222407.6678734E52EB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Bug 27561 depends on bug 27511, which changed state. Bug 27511 Summary: Add WinCE specific platform/graphics files to WebCore https://bugs.webkit.org/show_bug.cgi?id=27511 What |Old Value |New Value ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:24:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:24:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28304] S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite In-Reply-To: References: Message-ID: <20090814222459.2643634E530C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28304 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34839|review? |review- Flag| | --- Comment #3 from Oliver Hunt 2009-08-14 15:24:57 PDT --- (From update of attachment 34839) The Interpreter should not have any platform specific code in it. In general if your patch adds #if PLATFORM(...) to code where there are no existing PLATFORM specific #ifs, your patch is wrong. I'm also unsure why you feel the need to do this here -- there are plenty of places where you can just check for malloc failure and convert to a JS OOM exception. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:29:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:29:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28325] Safari not handling quoted paths correctly in version 1 cookies In-Reply-To: References: Message-ID: <20090814222916.A4A0834E5389@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28325 --- Comment #1 from Andre-John Mas 2009-08-14 15:29:16 PDT --- radar: 7144692 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:45:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:45:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28325] Safari not handling quoted paths correctly in version 1 cookies In-Reply-To: References: Message-ID: <20090814224600.0911934E54E4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28325 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar, ReviewedForRadar Status|NEW |RESOLVED Resolution| |INVALID --- Comment #2 from Mark Rowe (bdash) 2009-08-14 15:45:59 PDT --- Cookie parsing is not handled by WebKit. This issue will be tracked via the Radar that you filed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:50:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:50:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28327] New: Media layout tests should have a way to provide test files in different formats Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28327 Summary: Media layout tests should have a way to provide test files in different formats Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hclam at google.com All media/ layout tests are now using hard-coded file names, and the test files are mostly H264/AAC, if a port doesn't support such formats, the tests will all fail. We should provide a method to swap in test files with different formats easily. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:50:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:50:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] New: javascript execution sequence. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28328 Summary: javascript execution sequence. Product: WebKit Version: 525.x (Safari 3.2) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hartman at videolan.org CC: oliver at apple.com, beidson at apple.com I see a race condition in the following case. Master script in head. This master script changes the DOM (adding spans and divs) after DOMContentLoaded. I import a second script AFTER changing the DOM. with this: function importScriptURI(url) { var s = document.createElement('script'); s.setAttribute('src',url); s.setAttribute('type','text/javascript'); document.getElementsByTagName('head')[0].appendChild(s); return s; } This second script needs to change and see the added DOM elements in order to function. This works just fine on Firefox, but on Safari, it seems that execution of both the master and the "child" javascript are started in paralel. Sometimes, the new dom elements are seen by the child script, sometimes they are missing. It might be that there is a workaround, but I have not been able to find any. This can be a very difficult issue to trigger, and slower computers, high load or very large and complicated multi level javascript inclusions seem often required to be able to actually observe the problem. (On wikipedia, in a complicated situation I see it maybe 1 in 15 page loads.) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:58:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:58:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28310] Chromium: Show a "Mute Disabled" button on audio error. In-Reply-To: References: Message-ID: <20090814225855.6A23C34E5626@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28310 --- Comment #3 from Kyle Prete 2009-08-14 15:58:54 PDT --- Sure. The issue is that hasAudio is being used differently than hasVideo is. hasVideo() returns true if the video has loaded. It could return false if the video isn't loaded yet, but might be loaded later. hasAudio() returns false if the audio will never load, i.e. the hardware doesn't work or (maybe) the source has no audio. It's probably more a naming issue. Should I call it hasAudioError and flip the default return? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:00:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:00:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] javascript execution sequence. In-Reply-To: References: Message-ID: <20090814230042.EF0BB34E5654@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28328 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:01:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:01:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] javascript execution sequence. In-Reply-To: References: Message-ID: <20090814230135.5486734E567A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28328 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org --- Comment #1 from Oliver Hunt 2009-08-14 16:01:34 PDT --- This causes issues with the MS ES5 conformance test -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:01:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:01:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] javascript execution sequence. In-Reply-To: References: Message-ID: <20090814230156.EF80134E568C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28328 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Component|HTML DOM |Page Loading -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:03:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:03:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] javascript execution sequence. In-Reply-To: References: Message-ID: <20090814230357.E784734E56D4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28328 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Page Loading |HTML DOM -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:04:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:04:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] javascript execution sequence. In-Reply-To: References: Message-ID: <20090814230450.3BC6834E56F6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28328 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:05:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:05:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28285] Remove non-spec support for callable RegExp In-Reply-To: References: Message-ID: <20090814230509.A201034E56FA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28285 --- Comment #3 from Luke Smith 2009-08-14 16:05:08 PDT --- (In reply to comment #2) > The spec states "Unless specified otherwise, the [[Class]] property of a > built-in object is "Function" if that built-in object has a [[Call]] property, > or "Object" if that built-in object does not have a [[Call]] property." > > This would seem to pretty clearly imply that an object of a class other than > "Function" can validly implement [[Call]] (provided that it is stated as such), > and therefore assuming that an object with a [[Call]] property is specifically > of class Function is incorrect. > I agree that by that wording it is valid to add [[Call]] to RegExp, as the "Unless stated otherwise" allows for RegExp [[Class]] defined in 15.10.4.1. > To test for a function you can just use the instaceof operator: > > if (v instanceof Function) Unfortunately not true. If v is a function from another frame, it is not instanceof Function as defined in the current frame. > Hmmm, section 11.4.3 seems pretty clear, and I certainly can't agree with > FireFox's implementation here. The spec very clearly states that for any > native object that implements [[Call]] the typeof operator must return > "function". So far as I'm aware, this is the only way within the language to > ask this specific question (is this any kind of object that can be called as a > function, as opposed to, is this object an instance of "Function"), and it > doesn't seem like a capability we'd want to take away. So I can't say that I > think we want to unify on FireFox's present behaviour here. I believe WebKit's > current behavior is sensible, and is not fundamentally at conflict with the > spec (and it would also be a sensible and consistent state to remove the > ability to call RegExp objects as functions). > > I would suggest the FireFox's RegExp implementation is presently noncompliant > with the spec in that it violates section 11.4.3 - a native object with a > [[Call]] property fails to return "function" from typeof. It would probably be > helpful to file a bug with them. This is discussed in the originating bug 28117 (not 281117 as I fat fingered above). https://bugs.webkit.org/show_bug.cgi?id=28117 Specifically, the following bugs were filed with Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=61911 https://bugzilla.mozilla.org/show_bug.cgi?id=289933 I also agree that per the spec, reporting typeof /a/ == "function" is correct if RegExp has been extended with [[Call]] and that Firefox, Opera, and Chrome violate the spec by implementing the feature and reporting "object". However, the practical ramifications of reporting "function" were enough to convince each of these vendors to do so. Callable RegExp were not present in Chrome 2 but are in Chrome 3, and despite its close (historical at least) relationship to WK, it diverged from WK's behavior in favor of FF and Opera's. My concern is that following the spec in this regard when 3 other vendors agree not to creates another inconsistency for developers to deal with. Firefox, Chrome, and Opera's choice also brings their typeof reporting into alignment with IE (in this respect) who do not implement callable RegExp. So of 5 major browser vendors, WebKit's behavior wrt typeof /a/ is unique. There is more active discussion on this topic on es5-discuss: https://mail.mozilla.org/pipermail/es5-discuss/2009-August/003033.html > > > new obj.someRegExp(str) => boom > > If I'm understanding your test case correctly, you seem to be assuming that all > objects that have a [[Call]] property must also have a [[Construct]] property? No, I understand the behavior. I'm just suggesting that it's already challenging to teach the nuances of js function invocation to new developers. Having something else that can look like a function obj(str) but not be a function just muddies the waters. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:05:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:05:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814230551.3C0E634E5722@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #99 from Yong Li 2009-08-14 16:05:48 PDT --- apparently it depends on 3 child bugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:05:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:05:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814230553.DAFAC34E5742@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Bug 27561 depends on bug 27511, which changed state. Bug 27511 Summary: Add WinCE specific platform/graphics files to WebCore https://bugs.webkit.org/show_bug.cgi?id=27511 What |Old Value |New Value ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:09:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:09:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814230902.DF58534E57A4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 --- Comment #7 from Yong Li 2009-08-14 16:09:02 PDT --- (In reply to comment #6) > (From update of attachment 34867 [details]) > 126 #ifdef IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS > 127 > m_decoder->setMaxNumPixels(IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS); > 128 #else > 129 m_decoder->setMaxNumPixels(1024 * 1024); > 130 #endif > > Would be better to check #ifdef > IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS at the top fo the file, and > define IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS to 1024 * 1024 if not > defined. > > Seems we'd benifit from some nicely named local variables: > 47 case Exact: > 48 return pos != dataEnd && *pos == orig ? pos - dataStart : -1; > 49 case LowerBound: > 50 return pos != dataEnd && *pos == orig ? pos - dataStart : pos - > dataStart - 1; > 51 case UpperBound: > 52 default: > 53 return pos != dataEnd ? pos - dataStart : -1; > > Style: > 84 double zoom = 1. /shrink; > > I would have made this a static inline function to prevent copy/paste: for this 1./x ? I think that's sick > 94 m_scaledRows.reserveCapacity(height * shrink + 0.5); > 95 for (int scaledY = 0;;) { > 96 int y = scaledY * zoom + 0.5; > 97 if (y < height) { > 98 m_scaledRows.append(y); > 99 ++scaledY; > 100 } else > 101 break; > 102 } > > 64 bool good = ImageDecoder::setSize(width, height); > > good is not the word you want. success would be better. setSizeOK would be > another option. "good" means the size is good. r- with all these tiny things? BTW, after it's modified to be what you want above, are you going to accept it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:11:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:11:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28329] New: HTML5 canvas's createImageData should raise the NOT_SUPPORTED_ERR exception when either of the arguments are not finite. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28329 Summary: HTML5 canvas's createImageData should raise the NOT_SUPPORTED_ERR exception when either of the arguments are not finite. Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://philip.html5.org/tests/canvas/suite/tests/2d.im ageData.create.nonfinite.html OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ben at meyerhome.net According to http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation: "If any of the arguments to createImageData() or getImageData() are infinite or NaN, or if the createImageData() method is invoked with only one argument but that argument is null, the method must instead raise a NOT_SUPPORTED_ERR exception." Test page: http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:13:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:13:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28329] HTML5 canvas's createImageData should raise the NOT_SUPPORTED_ERR exception when either of the arguments are not finite. In-Reply-To: References: Message-ID: <20090814231330.B305634E582B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28329 Benjamin Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34878| |review? Flag| | --- Comment #1 from Benjamin Meyer 2009-08-14 16:13:29 PDT --- Created an attachment (id=34878) --> (https://bugs.webkit.org/attachment.cgi?id=34878) Patch to solve the issue -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:15:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:15:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28329] HTML5 canvas's createImageData should raise the NOT_SUPPORTED_ERR exception when either of the arguments are not finite. In-Reply-To: References: Message-ID: <20090814231535.9B4B734E5873@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28329 --- Comment #2 from Benjamin Meyer 2009-08-14 16:15:35 PDT --- I have contacted the author of the canvas tests to determine the licensing of the generated tests. If possible it would be nice to integrate them into our pixel tests and I started work in that direction, but before they can go into our repo the licensing needs to be determined. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:21:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:21:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28330] New: Remove AST nodes from use within the Runtime (outside of parsing), stage 1 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28330 Summary: Remove AST nodes from use within the Runtime (outside of parsing), stage 1 Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: barraclough at apple.com Remove the EvalNode and ProgramNode from use in the runtime. They still exist after this patch, but are hidden behind EvalExecutable and FunctionExecutable, and are also still reachable behind CodeBlock::m_ownerNode. The next step will be to beat back FunctionBodyNode in the same fashion. Then remove the usage via CodeBlock, then only construct these nodes only on demand during bytecode generation. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:27:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:27:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28331] New: dbName and originIdentifier parameters are switched in DatabaseTracker when calling SQLiteFileSystem::getFileNameForNewDatabase() Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28331 Summary: dbName and originIdentifier parameters are switched in DatabaseTracker when calling SQLiteFileSystem::getFileNameForNewDatabase() Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P3 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: dumi at chromium.org CC: dglazkov at chromium.org This results in dbName_originIdentifier.db files in Chromium, instead of originIdentifier_dbName.db. This bug has no effect on WebCore/Safari. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:45:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:45:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24866] Cannot pres Enter to escape from bulleted list when height is not honored when there's a marquee with a heading tag Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28641 Summary: the scroll box is too big because height is not honored when there's a marquee with a heading tag Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.tianlongren.cn/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38415) --> (https://bugs.webkit.org/attachment.cgi?id=38415) reduced testcase I Steps: Go to http://www.tianlongren.cn/ II Issue: The scroll box is too big III Conclusion: It looks like webkit doesn't honor the height specified in a table's if the has a marquee with a heading tag. Interestingly, I'm not sure how one of the styles really affects the display of the marquee. The style declaration : h1 a {} doesn't really have anything in it but if I take this style out, then the page displays ok as in Firefox and IE. IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=15279 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:08:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:08:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28641] the scroll box is too big because height is not honored when there's a marquee with a heading tag In-Reply-To: References: Message-ID: <20090822000811.0AADF3535ADB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28641 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:09:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:09:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090822000905.125DD3535B05@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34204|review- | Flag| | Attachment #34204|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:09:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:09:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090822000926.4007D3535B2B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 --- Comment #5 from Eric Seidel 2009-08-21 17:09:25 PDT --- Created an attachment (id=38416) --> (https://bugs.webkit.org/attachment.cgi?id=38416) First attempt, needs revision -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:10:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:10:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090822001029.4C8B33535B67@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 --- Comment #6 from Eric Seidel 2009-08-21 17:10:28 PDT --- I could definitely make the logging code simpler. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:12:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:12:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27043] Mouse-dragged events are not generated for right & middle buttons In-Reply-To: References: Message-ID: <20090822001200.1248C3535B9E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27043 Deirdre Saoirse Moen changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar CC| |desamo at apple.com --- Comment #4 from Deirdre Saoirse Moen 2009-08-21 17:11:59 PDT --- Also filed by originator as rdar://problem/7160923. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:12:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:12:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090822001210.0AC2D3535BB4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 --- Comment #26 from Eric Seidel 2009-08-21 17:12:09 PDT --- (In reply to comment #25) > Except the patches have not all been landed -- one was r-'d, and it was not > obsoleted because 'lo the patch you landed, and the r-'d patch were different > parts of this bug. > > Please do not just automatically close bugs if there are unlanded non-obsolete > attachments. bug 28230 covers some of this. Historically I made bugzilla-tool more aggressive because people don't always obsolete patches when they post a new one, so it was never closing bugs, even though the bug was "done". I'm happy to make it less-aggressive about closing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:13:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:13:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28619] [GTK] Geolocation needs permission API before being enabled by default In-Reply-To: References: Message-ID: <20090822001317.2C1E03535BD3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28619 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38417| |review? Flag| | --- Comment #2 from Jan Alonzo 2009-08-21 17:13:16 PDT --- Created an attachment (id=38417) --> (https://bugs.webkit.org/attachment.cgi?id=38417) enable geolocation on the buildbot build -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:13:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:13:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28642] New: Items spread all over the page due to width of marquee tag's container table Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28642 Summary: Items spread all over the page due to width of marquee tag's container table Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.mofa.gov.sa/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38418) --> (https://bugs.webkit.org/attachment.cgi?id=38418) reduced testcase Steps: Go to http://www.mofa.gov.sa/ II Issue: The content of the page is spread (there are huge gaps between divs/table cells). III Conclusion: The items spread over the page because marquee tag is too long in Chrome and Safari. The width of marquee tag's container table is 416px, so in IE and FF, the marquee is also limited to 416px, but in chrome and safari, the marquee extends its width because of its content table's long width. IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=15326 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:13:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:13:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28642] Items spread all over the page due to width of marquee tag's container table In-Reply-To: References: Message-ID: <20090822001326.51AD33535BED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28642 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:13:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:13:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090822001345.5CB433535BFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35087|commit-queue+ |commit-queue- Flag| | --- Comment #18 from Eric Seidel 2009-08-21 17:13:44 PDT --- (From update of attachment 35087) Rejecting patch 35087 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:15:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:15:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28269] Inspector: Improve Cookie DataGrid to Show Hidden Data In-Reply-To: References: Message-ID: <20090822001503.AAC323535C36@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28269 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck at webkit.org --- Comment #36 from Joseph Pecoraro 2009-08-21 17:15:03 PDT --- (In reply to comment #35) > Another thing is that if you compile webkit without inspector these functions > (and cookie.h) should probably not be included as they are inspector specific. > Wrapping it in the ifdef would be good. I don't think there are any generic ifdefs for the inspector. Although maybe there should be if anyone ever wants to build WebKit without the Inspector (small gains?). Does this patch need anything else? Any more comments on the API? Is it worth putting in the work? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:16:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:16:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090822001644.E57623535C5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 --- Comment #19 from Eric Seidel 2009-08-21 17:16:44 PDT --- Created an attachment (id=38419) --> (https://bugs.webkit.org/attachment.cgi?id=38419) bugzilla-tool failure log Here is the failure log from bugzilla-tool. This is the first per-bug log it's ever made. :) (Feature is in testing.) You'll see from the log that trunk/WebCore/html/HTMLInputElement.idl has a tab in it, which caused the svn pre-commit hook to fail. We really should have svn-create-patch fail for those sorts of things. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:16:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:16:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090822001655.877D83535C6F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38419|application/octet-stream |text/plain mime type| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:19:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:19:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28269] Inspector: Improve Cookie DataGrid to Show Hidden Data In-Reply-To: References: Message-ID: <20090822001948.BB9A03535CBF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28269 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35146|review? |review+ Flag| | --- Comment #37 from Timothy Hatcher 2009-08-21 17:19:48 PDT --- (From update of attachment 35146) Nice clean up. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:21:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:21:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28643] New: All links in category get underlined on mouseover Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28643 Summary: All links in category get underlined on mouseover Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://lista.mercadolivre.com.br/brinquedos-hobbies/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38420) --> (https://bugs.webkit.org/attachment.cgi?id=38420) reduced testcase Steps: Go to http://lista.mercadolivre.com.br/brinquedos-hobbies/ II Issue: Before clicking on a sub-category, all sub-categories get underlined on mouseover, even though the site redirects correctly to the selected category. III Conclusion: The links are enclosed in a where the text decoration is set to underline on hover (for simplicity, I removed the table and changed it to a
). Each link's text-decoration is also set to underline. The issue is caused by the text-decoration set at the
or
(in the original code) level. IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=14420 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:21:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:21:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28643] All links in category get underlined on mouseover In-Reply-To: References: Message-ID: <20090822002148.B54333535CFE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28643 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:26:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:26:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28644] New: Displacement of hyperlinked elements on mouse over Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28644 Summary: Displacement of hyperlinked elements on mouse over Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://banamex.com.mx/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38421) --> (https://bugs.webkit.org/attachment.cgi?id=38421) reduced testcase Steps: Go to http://banamex.com.mx/ II Issue: Hover over footer elements and entire footer container shifts up. III Conclusion: here are 2 issues in this bug. 1) When you hover one link, all links are underlined 2) When you hover, the text moves The issue may be caused by 1) definition of a class 'boton_heder_footer' in the styles in which the
containing the links and the links themselves use the same class id. or 2) in the styles, they have these definitions- .boton_heder_footer:link { text-decoration:none; font-size:9px; } .boton_heder_footer:visited { text-decoration:none; font-size:9px; } .boton_heder_footer:hover { text-decoration:underline; font-size:9px; } .boton_heder_footer:active { text-decoration:none; font-size:9px; } Not sure if these were meant to have (note the a: after the class id to define the anchor tags) .boton_heder_footer a:link { text-decoration:none; font-size:9px; } .boton_heder_footer a:visited { text-decoration:none; font-size:9px; } .boton_heder_footer a:hover { text-decoration:underline; font-size:9px; } .boton_heder_footer a:active { text-decoration:none; font-size:9px; } If I set the styles to be like that of the latter, or remove the class of the
containing the links, then webkit behaves like that of FF and IE IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=14606 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:26:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:26:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28644] Displacement of hyperlinked elements on mouse over In-Reply-To: References: Message-ID: <20090822002607.867513535D7C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28644 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:27:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:27:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28408] WebInspector: Migrate call frames interaction to the InjectedScript-based schema. In-Reply-To: References: Message-ID: <20090822002711.356173535DA7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28408 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38386|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:30:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:30:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28645] New: menu items are mushed together because of white-space:nowrap Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28645 Summary: menu items are mushed together because of white-space:nowrap Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://web.virginmobileusa.com/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38422) --> (https://bugs.webkit.org/attachment.cgi?id=38422) reduced testcase Steps: 1. Go to http://web.virginmobileusa.com/ 2. Put pointer over "My Account" tab/menu II Issue: he menu items are mushed together, making them unreadable. III Conclusion: The issue is caused by the
  • white-space:nowrap style. IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=15528 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:30:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:30:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28645] menu items are mushed together because of white-space:nowrap In-Reply-To: References: Message-ID: <20090822003047.1CB993535E28@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28645 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:34:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:34:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27573] [CSS3 Backgrounds and Borders] Add support for the "contain" value for background-size In-Reply-To: References: Message-ID: <20090822003413.78AE63535E7B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27573 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from mitz at webkit.org 2009-08-21 17:34:12 PDT --- Landed the rendering changes as . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:34:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:34:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27569] [CSS3 Backgrounds and Borders] Tracking bug for spec compliance In-Reply-To: References: Message-ID: <20090822003414.433D63535E8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27569 Bug 27569 depends on bug 27573, which changed state. Bug 27573 Summary: [CSS3 Backgrounds and Borders] Add support for the "contain" value for background-size https://bugs.webkit.org/show_bug.cgi?id=27573 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:34:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:34:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28646] New: CSS focus pseudoclass is not handled correctly Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28646 Summary: CSS focus pseudoclass is not handled correctly Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.cssplay.co.uk/menu/gallery_click OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38423) --> (https://bugs.webkit.org/attachment.cgi?id=38423) reduced testcase Steps: 1. Go to http://www.cssplay.co.uk/menu/gallery_click 2. Try to view gallery (click on thumbnail) II Issue: Gallery doesn't work properly III Conclusion: Code has css style - #container_top a.gallery:active em, #container_top a.gallery:focus em {display:block; position:absolute; width:402px; height:250px; top:160px;} Issue is due to #container_top a.gallery:focus em {display:block;} IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=18018 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:34:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:34:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28646] CSS focus pseudoclass is not handled correctly In-Reply-To: References: Message-ID: <20090822003448.A68FE3535EAA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28646 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:35:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:35:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27574] [CSS3 Backgrounds and Borders] Add support for the "cover" value for background-size In-Reply-To: References: Message-ID: <20090822003503.AAE3B3535EB4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27574 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |mitz at webkit.org Resolution| |FIXED --- Comment #1 from mitz at webkit.org 2009-08-21 17:35:03 PDT --- Fixed along with "backgrond-size: contain" (bug 27573) in r47630 and r47650. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:35:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:35:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27569] [CSS3 Backgrounds and Borders] Tracking bug for spec compliance In-Reply-To: References: Message-ID: <20090822003503.F13C03535EC4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27569 Bug 27569 depends on bug 27574, which changed state. Bug 27574 Summary: [CSS3 Backgrounds and Borders] Add support for the "cover" value for background-size https://bugs.webkit.org/show_bug.cgi?id=27574 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:41:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:41:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28647] New: Weird layout bug when READING clientHeight Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28647 Summary: Weird layout bug when READING clientHeight Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38424) --> (https://bugs.webkit.org/attachment.cgi?id=38424) testcase Steps: Go to attached reduced testcase II Issue: Document is twice as wide as the window. There should be no scrollbar III Conclusion: Put the HTML and CSS of the reduced test case into two separate files. webkit behaves correctly if the test case is anyhow simpified, even when styles are inlined. bug.html:
    bug.css: .bug { float: right; } IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=16626 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:41:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:41:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28647] Weird layout bug when READING clientHeight In-Reply-To: References: Message-ID: <20090822004107.4AFB83535F71@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28647 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:46:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:46:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28648] New: Flash input broken/offset when page is zoomed Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28648 Summary: Flash input broken/offset when page is zoomed Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.myspace.com/freakedfrequency OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Steps: 1. Go to http://www.myspace.com/freakedfrequency or any myspace page with an embedded music player) 2. Zoom page to more than 100% 3. Try clicking on the player controls or hover the mouse over songs II Issue: If zoom != 100% neither the buttons nor the song highlight work. It appears as if the player is picking up offset input. Notice that the player doesn't scale with the zoom, it just moves to the zoomed position. This might be what's causing the problem - feeding flash with input as if it were scaled whereas it actually isn't? III Expected: If you use 100% zoom hovering the mouse over individual songs highlights them. Pressing player/stop buttons or moving the slider also works as it should. IV Other Browsers: IE7: ok FF3: ok Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=9996 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:46:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:46:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28648] Flash input broken/offset when page is zoomed In-Reply-To: References: Message-ID: <20090822004626.8F6563536035@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28648 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:53:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:53:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28649] New: Support for interactive validation of form elements Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28649 Summary: Support for interactive validation of form elements Product: WebKit Version: 528+ (Nightly build) Platform: All URL: http://www.whatwg.org/specs/web-apps/current-work/#int eractively-validate-the-constraints OS/Version: All Status: UNCONFIRMED Severity: Enhancement Priority: P3 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: micdesim at gmail.com CC: adele at apple.com, pkasting at google.com, tkent at chromium.org Support for interactive validation of form elements, HTML5 specs section 4.10.15.2, is necessary. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:03:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:03:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16204] Heap corruption in JS on ARM In-Reply-To: References: Message-ID: <20090822010335.34762353626F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16204 --- Comment #5 from Grace Kloba 2009-08-21 18:03:34 PDT --- Not sure. Feel free to close it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:05:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:05:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28649] Support for interactive validation of form elements In-Reply-To: References: Message-ID: <20090822010551.1430535362AA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28649 Michelangelo De Simone changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19264 Depends on| |28145, 27452 --- Comment #1 from Michelangelo De Simone 2009-08-21 18:05:50 PDT --- Some tip from other bugs this depends on: 1. Form control elements can be in a "no-validate state" that is controlled by "novalidate" and "formNoValidate" attributes, plus some more condition. This snippet could be of help: bool HTMLFormControlElement::isInNoValidateState() const { return (isSuccessfulSubmitButton() && formNoValidate()) || m_form->novalidate(); } 2. HTMLFormElement::checkValidity() needs to be adapted to deal with "unhandled invalid controls" (as per TODO comment). Actually it just iterates over form elements calling checkValidity() (that fires the invalid event, as per specs), but it must also return a list of invalid form controls that haven't been handled through the invalid event. The following snippet might be of some help (was part of the proposed patch for bug 27452): bool checkValidity(Vector* unhandledInvalidControls = 0); bool HTMLFormElement::checkValidity(Vector* unhandledInvalidControls) { Vector invalidControls; for (unsigned i = 0; i < formElements.size(); ++i) { HTMLFormControlElement* control = formElements[i]; if (control->willValidate() && !control->validity()->valid()) invalidControls.append(control); } if (invalidControls.isEmpty()) return true; for (unsigned n = 0; n < invalidControls.size(); ++n) { HTMLFormControlElement* invalidControl = invalidControls[n]; bool eventCanceled = invalidControl->dispatchEvent(eventNames().invalidEvent, false, true); if (eventCanceled && unhandledInvalidControls) unhandledInvalidControls->append(invalidControl); } return false; } -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:05:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:05:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090822010552.4515F35362CA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Michelangelo De Simone changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28649 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:08:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:08:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090822010820.078E63536349@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 Michelangelo De Simone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |micdesim at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:17:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:17:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090822011748.3ED4435365DA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Bug 19264 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:17:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:17:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28649] Support for interactive validation of form elements In-Reply-To: References: Message-ID: <20090822011748.903F53536646@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28649 Bug 28649 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:38:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:38:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28617] Bad CSSKeyframesRule&CSSKeyframeRule .type In-Reply-To: References: Message-ID: <20090822013855.22B4B35368AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28617 --- Comment #1 from LEPESME Jean-Baptiste 2009-08-21 18:38:54 PDT --- Created an attachment (id=38428) --> (https://bugs.webkit.org/attachment.cgi?id=38428) change VARIABLES_RULES to 9, and set the correct value to KEYFRAMES_RULE and KEYFRAME_RULE -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:44:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:44:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28617] Bad CSSKeyframesRule&CSSKeyframeRule .type In-Reply-To: References: Message-ID: <20090822014415.60A9C3536932@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28617 --- Comment #2 from LEPESME Jean-Baptiste 2009-08-21 18:44:14 PDT --- I made some research and I figured out that the css-variables features of webkit is non "standard" and not intended to be a part of CSS3. It seems to be based on http://disruptive-innovations.com/zoo/cssvariables/ wich use RuleType number 7. As css-animations should be in CSS3, i think that webkit had to change VARIABLES_RULES to another value to respect http://www.w3.org/TR/css3-animations/ . Bye, Jiboo. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:49:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:49:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28617] Bad CSSKeyframesRule&CSSKeyframeRule .type In-Reply-To: References: Message-ID: <20090822014913.7DB273536982@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28617 LEPESME Jean-Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Component|WebCore JavaScript |CSS -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:56:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:56:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28269] Inspector: Improve Cookie DataGrid to Show Hidden Data In-Reply-To: References: Message-ID: <20090822015614.A39003536A3A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28269 --- Comment #38 from Joseph Pecoraro 2009-08-21 18:56:14 PDT --- - Added the localizedStrings that were supposed to have landed in the first patch but most have gotten lost when ariya did the commit. - Made "Session" a localizedString as well. Donno how I missed that before. Should I close this bug? --- Landed in r47656 = f0c84dbeb8261b637a75a601fd799530971aa3e5 http://trac.webkit.org/changeset/47656 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:57:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:57:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090822015754.6D8F63536A7E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Bug 19264 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:57:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:57:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28649] Support for interactive validation of form elements In-Reply-To: References: Message-ID: <20090822015754.B1A5A3536A8E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28649 Bug 28649 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 19:12:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 19:12:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090822021245.1BE8F3536BB8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Bug 19264 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 19:12:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 19:12:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28649] Support for interactive validation of form elements In-Reply-To: References: Message-ID: <20090822021245.619F03536BC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28649 Bug 28649 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 19:39:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 19:39:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28269] Inspector: Improve Cookie DataGrid to Show Hidden Data In-Reply-To: References: Message-ID: <20090822023929.A2EA23536DC9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28269 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:18:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:18:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28651] New: Not use deprecated symbols in WebKitWebView example code Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28651 Summary: Not use deprecated symbols in WebKitWebView example code Product: WebKit Version: 528+ (Nightly build) Platform: Other URL: http://webkitgtk.org/reference/webkitgtk-WebKitWebView .html OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: javierjc1982 at gmail.com webkit_web_view_open () was replaced by webkit_web_view_load_uri () since 1.1.1 Patch following -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:36:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:36:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28651] Not use deprecated symbols in WebKitWebView example code In-Reply-To: References: Message-ID: <20090822033650.1FDEE35371C1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28651 Javier Jard?n changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38429| |review? Flag| | --- Comment #1 from Javier Jard?n 2009-08-21 20:36:49 PDT --- Created an attachment (id=38429) --> (https://bugs.webkit.org/attachment.cgi?id=38429) Substitute deprecated symbol in WebKitWebView example code -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:39:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:39:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28651] Not use deprecated symbols in WebKitWebView example code In-Reply-To: References: Message-ID: <20090822033946.0C7593537203@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28651 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38429|review? |review+, commit-queue+ Flag| | --- Comment #2 from Jan Alonzo 2009-08-21 20:39:45 PDT --- (From update of attachment 38429) r=me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:51:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:51:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28651] Not use deprecated symbols in WebKitWebView example code In-Reply-To: References: Message-ID: <20090822035143.4C76435372D5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28651 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38429|review+, commit-queue+ | Flag| | --- Comment #3 from Eric Seidel 2009-08-21 20:51:43 PDT --- (From update of attachment 38429) Clearing flags on attachment: 38429 Committed r47661: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:51:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:51:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28651] Not use deprecated symbols in WebKitWebView example code In-Reply-To: References: Message-ID: <20090822035146.7A08635372E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28651 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #4 from Eric Seidel 2009-08-21 20:51:45 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:56:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:56:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28614] Unnecessary horizontal scrollbar in Gmail under Chromium. ScrollView::updateScrollbars uses stale value for off/on/auto scrollbar mode. In-Reply-To: References: Message-ID: <20090822035647.6BEBA3537363@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28614 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38376|review?(hyatt at apple.com) |review- Flag| | --- Comment #2 from Dave Hyatt 2009-08-21 20:56:47 PDT --- (From update of attachment 38376) I am not convinced this is right. You aren't supposed to just always invoke visibleContentsResized. Also note that any change to this logic has to be replicated in WebDynamicScrollbarsView on Mac to keep the two in sync. Finally I see no reason to change the word "recur" to "recurse." They mean exactly the same thing, and changing around English just because you don't like it pisses me off. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 23:30:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 23:30:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090822063059.B07603537DC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 23:42:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 23:42:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28652] New: Clean up fill image geometry calculation Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28652 Summary: Clean up fill image geometry calculation Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mitz at webkit.org Patch forthcoming. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 23:42:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 23:42:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26064] Typing 'window.location.href = "#content"' in the Console loads the Inspector in the inspected page In-Reply-To: References: Message-ID: <20090822064241.3D9503537EC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26064 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck at webkit.org --- Comment #3 from Joseph Pecoraro 2009-08-21 23:42:41 PDT --- Update. This now shows: > window.location.href https://bugs.webkit.org/show_bug.cgi?id=26064 > window.location.href = '#content' Not allowed to load local resource: file:///Applications/WebKit.app/Contents/Frameworks/10.5/WebCore.framework/Resources/inspector/inspector.html#content This begs the question, why does window.location properly show the inspected window's value, but on setting it seems to use the wrong environment. I did a quick test with iframes and was able to emulate the same weird (or at least unexpected) behavior with an inner iframe and window.top.location: http://bogojoker.com/x/location_test/ JavaScript on an iframe's page shows the outer page's url when it does window.top.location.href, but seems to use its own url when assigning to window.top.location.href. Its too late for me to look at any specifications! Thoughts? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 23:57:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 23:57:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28652] Clean up fill image geometry calculation In-Reply-To: References: Message-ID: <20090822065714.0A3743538017@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28652 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38430| |review? Flag| | --- Comment #1 from mitz at webkit.org 2009-08-21 23:57:13 PDT --- Created an attachment (id=38430) --> (https://bugs.webkit.org/attachment.cgi?id=38430) Cleanup -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 01:11:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 01:11:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28653] New: Safari crashes after most recent nightly update Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28653 Summary: Safari crashes after most recent nightly update Product: WebKit Version: 420+ Platform: Macintosh OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Critical Priority: P1 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: sdudla_uk at yahoo.com After updating Webkit with the new nightly build I could not open the "Thank you" page and Safari crashed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 01:31:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 01:31:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28652] Clean up fill image geometry calculation In-Reply-To: References: Message-ID: <20090822083107.82CF23538715@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28652 --- Comment #2 from mitz at webkit.org 2009-08-22 01:31:07 PDT --- (From update of attachment 38430) I think I should also rename the 2nd parameter to calculateFillTileSize() to positioningAreaSize, to match the call site. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 01:55:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 01:55:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider In-Reply-To: References: Message-ID: <20090822085521.133C135388F7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28241 --- Comment #6 from Hin-Chung Lam 2009-08-22 01:55:20 PDT --- To add a bit more about the behavior of the volume slider: - When mouse over the mute button - Volume slider is shown either above the mute button or below the mute button (They will not overlap) - When mouse out of the volume slider or mute button, the volume slider will disappear The behavior of the volume slider will be similar to youtube. Also in this patch I don't include any theme implementation and by default -webkit-media-controls-volume-slider-container and -webkit-media-controls-volume-slider don't have renderers unless they are defined in css with a "display" value so they won't affect layout tests nor shown. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 02:34:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 02:34:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28653] Safari crashes after most recent nightly update In-Reply-To: References: Message-ID: <20090822093449.1E7AD3538C1A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28653 --- Comment #1 from Mark Rowe (bdash) 2009-08-22 02:34:48 PDT --- Please attach the crash log. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 05:26:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 05:26:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28654] New: MIME handling in qtwebkit network layer case-sensitivity Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28654 Summary: MIME handling in qtwebkit network layer case-sensitivity Product: WebKit Version: 528+ (Nightly build) Platform: All URL: http://www.buienradar.nl/images.aspx?jaar=-3&bliksem=0 &voor=&soort=verwachting1x1 OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rich at kde.org Created an attachment (id=38432) --> (https://bugs.webkit.org/attachment.cgi?id=38432) Patch to fix the bug The code in webkit assumes MIME types will be lower case, but QNetworkAccessManager returns the mime type exactly as it is sent by the remote server. The RFC says mime types are case-insensitive, so in the case of the URL above which sends image/GIF things should work just fine. Unfortunately that is not the case, qtwebkit believes this mime type to be unsupported wheras image/gif is fine. The fix is simply to lowercase the mimetype as it is passed from QNAM to webkit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 05:39:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 05:39:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28391] Incorrect casts in JavaScriptCore with gcc-3.4 In-Reply-To: References: Message-ID: <20090822123925.AB9953539AFB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28391 --- Comment #7 from Kelemen Bal?zs 2009-08-22 05:39:22 PDT --- I did not think I would start such an interesting conversation :) Anyway, my original wish (to be able to compile webkit with gcc-3.x) was not a valid conception, so I would close the bug. Should I close it, or you guys want to move on with the casting debate here? :-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 05:42:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 05:42:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28652] Clean up fill image geometry calculation In-Reply-To: References: Message-ID: <20090822124234.62A8D3539B87@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28652 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38430|review? |review+ Flag| | --- Comment #3 from Darin Adler 2009-08-22 05:42:32 PDT --- (From update of attachment 38430) > + calculateBackgroundSize() to this. Replaced spearate scaledWidth and Misspelling of separate here. r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 07:56:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 07:56:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] New: Webkit Crash on Launch Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28655 Summary: Webkit Crash on Launch Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh PowerPC OS/Version: Mac OS X 10.4 Status: UNCONFIRMED Severity: Blocker Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: john at film2disk.com Created an attachment (id=38433) --> (https://bugs.webkit.org/attachment.cgi?id=38433) Safari Crash Log Webkit crashes immediately on launch or while re-loading tabs. The following versions are failing on PPC in OS X 10.4.11 r47668 r47667 r47660 The last working version is r47639 Crash log attached... only 8/22/09 entries are relevant. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 08:26:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 08:26:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28391] Incorrect casts in JavaScriptCore with gcc-3.4 In-Reply-To: References: Message-ID: <20090822152620.289ED353AD43@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28391 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WONTFIX --- Comment #8 from Eric Seidel 2009-08-22 08:26:19 PDT --- Nah, we can close. Thank you for the patch though! And thanks to Gavin and Joe for following up with the C++ lesson. :) I certainly learned something! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 08:39:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 08:39:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24696] Enable mixed content detection In-Reply-To: References: Message-ID: <20090822153922.6CC3A353AE77@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24696 --- Comment #23 from Adam Barth 2009-08-22 08:39:21 PDT --- I should also say that there are a bunch of mixed content corner cases that these patches don't cover. The goal here is to get the APIs in place and have something minimally functional. We can handle the strange cases (e.g., redirects) in follow up bugs to ensure that we get good test coverage. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 08:52:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 08:52:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28612] Unclickable Links In-Reply-To: References: Message-ID: <20090822155220.6BE1A353B01D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28612 --- Comment #1 from Alexey Proskuryakov 2009-08-22 08:52:20 PDT --- I cannot reproduce this with a local debug build of r47661. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 09:15:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 09:15:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider In-Reply-To: References: Message-ID: <20090822161502.6C7B0353B2D3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28241 --- Comment #7 from Eric Carlson 2009-08-22 09:15:01 PDT --- This looks great to me, thanks Alpha! I think this is ready to land, but I won't r+ it as I am not a reviewer. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 09:33:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 09:33:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28652] Clean up fill image geometry calculation In-Reply-To: References: Message-ID: <20090822163323.8F31B353B47C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28652 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from mitz at webkit.org 2009-08-22 09:33:23 PDT --- Committed . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 09:36:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 09:36:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28609] Buttons are not rendered correctly when scrolling page In-Reply-To: References: Message-ID: <20090822163612.05A16353B4C2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28609 Dimitris Apostolou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Dimitris Apostolou 2009-08-22 09:36:11 PDT --- Verified with 6531.9, r47668 Closing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 09:41:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 09:41:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider In-Reply-To: References: Message-ID: <20090822164131.78CD3353B548@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28241 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38395|review? |review- Flag| | --- Comment #8 from Eric Seidel 2009-08-22 09:41:31 PDT --- (From update of attachment 38395) Strange to have WebCore:: on one and not the other: 03 if (m_isVisible) 204 style->setVisibility(VISIBLE); 205 else 206 style->setVisibility(WebCore::HIDDEN); I might have even written that style->setVisibility(m_visible ? VISIBLE : HIDDEN) Same in the next function below. Don't we only need to clone styles when they're not already shared? 1 RefPtr style = RenderStyle::clone(renderer()->style()); 222 if (visible) 223 style->setVisibility(VISIBLE); 224 else 225 style->setVisibility(WebCore::HIDDEN); Or maybe clone() is smart enough to do that. I don't understand this comment: 216 // This function is used during the RenderMedia::layout() 217 // call, where we cannot change the renderer at this time. 218 if (!renderer() || !renderer()->style()) 219 return; We should figure out if we always need to be cloning, or if there is a similar "make sure this style is not shared" method: 236 RefPtr style = RenderStyle::clone(renderer()->style()); Why not just "1"? 598 setAttribute(maxAttr, String::number(1)); Sometimes we have exception ignoring versions of dom methods which are only used internally: 614 ExceptionCode ec; 615 m_mediaElement->setVolume(volume, ec); I'm surprise we don't have one here. Do we need to ASSERT(!ec)? Isn't this doing a bunch of extra checks? 21 return MediaControlInputElement::rendererIsNeeded(style) && parent() && parent()->renderer() && parent()->renderer()->style()->visibility() == VISIBLE; RenderObject::rendererIsNeeded() takes care of all of that, no? Why do you need to override? Its a little sad that we have so many classes in these files. I'm not sure I fully understand: 494 void RenderMedia::updateVolumeSliderContainer(bool visible) Seems like a lot of code. ;) In general this looks fine, but there are a couple unanswered questions above. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 09:42:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 09:42:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider In-Reply-To: References: Message-ID: <20090822164208.6C293353B55E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28241 --- Comment #9 from Eric Seidel 2009-08-22 09:42:08 PDT --- I'm most concerned with the rendererIsNeeded implementation, and the possibly unecessary clone() calls. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 10:59:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 10:59:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider In-Reply-To: References: Message-ID: <20090822175914.3F00D353BC8E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28241 --- Comment #10 from Eric Carlson 2009-08-22 10:59:13 PDT --- > I don't understand this comment: > 216 // This function is used during the RenderMedia::layout() > 217 // call, where we cannot change the renderer at this time. > 218 if (!renderer() || !renderer()->style()) > 219 return; Looks like the comment was copy/pasted from MediaControlTimeDisplayElement::setVisible and isn't relevant here. > Isn't this doing a bunch of extra checks? > 21 return MediaControlInputElement::rendererIsNeeded(style) && parent() && > parent()->renderer() && parent()->renderer()->style()->visibility() == VISIBLE; > RenderObject::rendererIsNeeded() takes care of all of that, no? Why do you > need to override? I don't see RenderObject::rendererIsNeeded? MediaControlInputElement::rendererIsNeeded does check "parent() && parent()->renderer()" so those aren't needed, but it doesn't check the visibility of the parent (the slider container). The question about whether or not this is needed at all is a fair one though. The other media control elements that override rendererIsNeeded do so because we want to force a re-layout when they appear/disappear, which is not the case with the volume slider since it is position absolute. > Sometimes we have exception ignoring versions of dom methods which are only > used internally: > 614 ExceptionCode ec; > 615 m_mediaElement->setVolume(volume, ec); > I'm surprise we don't have one here. This is the first internal use of setVolume, it seems a bit heavyweight to add a convenience method just yet. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:19:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:19:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28656] New: REGRESSION: r47676 hangs when loading page on Leopard/PPC Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28656 Summary: REGRESSION: r47676 hangs when loading page on Leopard/PPC Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh PowerPC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Blocker Priority: P1 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jon at jonshier.com Since my build last night, I've been getting this hang when trying to use ToT in Safari on Leopard/PPC. Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000008 Crashed Thread: 0 Thread 0 Crashed: 0 com.apple.JavaScriptCore 0x00523630 JSC::JSFunction::~JSFunction() + 48 1 com.apple.JavaScriptCore 0x0060e6a8 JSC::VPtrSet::VPtrSet() + 584 2 com.apple.JavaScriptCore 0x0060e6a8 JSC::VPtrSet::VPtrSet() + 584 3 com.apple.JavaScriptCore 0x0060f6a0 JSC::JSGlobalData::createLeaked() + 32 (JSGlobalData.cpp:105) 4 com.apple.WebCore 0x019d7ecc WebCore::JSDOMWindowBase::commonJSGlobalData() + 44 (JSDOMWindowBase.cpp:168) 5 com.apple.WebCore 0x019e20c4 WebCore::JSDOMWindowShell::operator new(unsigned long) + 20 (JSDOMWindowShell.cpp:152) 6 com.apple.WebCore 0x01d92474 WebCore::ScriptController::initScript() + 68 (ScriptController.cpp:162) 7 com.apple.WebCore 0x01d92984 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) + 340 (ScriptController.h:143) 8 com.apple.WebCore 0x017ebfb8 WebCore::FrameLoader::executeScript(WebCore::ScriptSourceCode const&) + 392 (FrameLoader.cpp:765) 9 com.apple.WebCore 0x018a8494 WebCore::HTMLTokenizer::scriptExecution(WebCore::ScriptSourceCode const&, WebCore::HTMLTokenizer::State) + 932 (HTMLTokenizer.cpp:561) 10 com.apple.WebCore 0x018a9224 WebCore::HTMLTokenizer::scriptHandler(WebCore::HTMLTokenizer::State) + 3380 (HTMLTokenizer.cpp:503) 11 com.apple.WebCore 0x018a98cc WebCore::HTMLTokenizer::parseNonHTMLText(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 476 (HTMLTokenizer.cpp:350) 12 com.apple.WebCore 0x018ac840 WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 10304 (HTMLTokenizer.cpp:1520) 13 com.apple.WebCore 0x018ad2d4 WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool) + 1204 (HTMLTokenizer.cpp:1748) 14 com.apple.WebCore 0x017f1f60 WebCore::FrameLoader::write(char const*, int, bool) + 1424 (FrameLoader.cpp:1020) 15 com.apple.WebKit 0x003209d8 -[WebFrame(WebInternal) _receivedData:textEncodingName:] + 312 (WebFrame.mm:981) 16 com.apple.WebKit 0x003384ec -[WebHTMLRepresentation receivedData:withDataSource:] + 124 (WebHTMLRepresentation.mm:162) 17 com.apple.WebKit 0x003109b4 -[WebDataSource(WebInternal) _receivedData:] + 84 (WebDataSource.mm:222) 18 com.apple.WebKit 0x003279b4 WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) + 116 (WebFrameLoaderClient.mm:801) 19 com.apple.WebCore 0x016cd798 WebCore::DocumentLoader::commitLoad(char const*, int) + 88 (DocumentLoader.cpp:342) 20 com.apple.WebCore 0x01d7c4a4 WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) + 68 (ResourceLoader.cpp:247) 21 com.apple.WebCore 0x01c2d9c4 WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) + 2324 (MainResourceLoader.cpp:352) 22 com.apple.Foundation 0x94bbb2d4 _NSURLConnectionDidReceiveData + 136 23 com.apple.CFNetwork 0x93cdbb48 URLConnectionClient::_clientDidReceiveData(__CFData const*, URLConnectionClient::ClientConnectionEventQueue*) + 256 24 com.apple.CFNetwork 0x93cdcb0c URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo*, long) + 432 25 com.apple.CFNetwork 0x93cdccd8 URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo*, long) + 892 26 com.apple.CFNetwork 0x93cdb500 URLConnectionClient::processEvents() + 132 27 com.apple.CFNetwork 0x93c85020 MultiplexerSource::perform() + 168 28 com.apple.CoreFoundation 0x917950d0 CFRunLoopRunSpecific + 1104 29 com.apple.HIToolbox 0x90033b14 RunCurrentEventLoopInMode + 264 30 com.apple.HIToolbox 0x900338a0 ReceiveNextEventCommon + 260 31 com.apple.HIToolbox 0x90033778 BlockUntilNextEventMatchingListInMode + 84 32 com.apple.AppKit 0x92c08244 _DPSNextEvent + 596 33 com.apple.AppKit 0x92c07bfc -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 112 34 com.apple.SafariTest 0x0000db9c 0x1000 + 52124 35 com.apple.AppKit 0x92c0189c -[NSApplication run] + 744 36 com.apple.AppKit 0x92bd2298 NSApplicationMain + 440 37 com.apple.SafariTest 0x00002fcc 0x1000 + 8140 Application launches fine, but when I try to load a page (I have it set to a blank page by default) it either freezes immediately, or after slightly loading the page. From the look of the trace, probably when it tries JS activity for the first time. I first noticed this problem at r47660. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:22:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:22:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090822182211.B8184353BF0D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38434| |review? Flag| | --- Comment #1 from Xan Lopez 2009-08-22 11:22:11 PDT --- Created an attachment (id=38434) --> (https://bugs.webkit.org/attachment.cgi?id=38434) editingbehavior.patch Turns out there's already a setting to control precisely this stuff, so just expose it and adjust our default value to be more GTK+-like. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:25:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:25:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 4076] Loading www.fed-soc.org causes hang (eventually finishes) In-Reply-To: References: Message-ID: <20090822182556.97FE4353BF78@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=4076 --- Comment #16 from Jon 2009-08-22 11:25:56 PDT --- Although the website has been update to be much more modern, the webarchive David attached still causes a beachball, even with Safari 4.0.3 on Leopard/PPC with a Quad G5. I'm just going through my old bugs and wanted to bump this and see whether it's still something to be fixed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:29:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:29:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28657] New: Form post to IFRAME change browser history Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28657 Summary: Form post to IFRAME change browser history Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://beta.livadnyy.com/demo OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: History AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mikhail.v.gavrilov at gmail.com 1. go to http://beta.livadnyy.com/demo 2. post some data 3. see changes in browser history and press back browser button 4. compare Opera action with action FF and IE Expected that: 1) Back button must be inactive. 2) No extra entry in browser history. Actually happens: 1) Browser 'Back' button is active. 2) In browser history an extra entry. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:30:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:30:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 6070] Yahoo TV listings only render correctly if refreshed/loaded from active cache. In-Reply-To: References: Message-ID: <20090822183038.E6060353BFEB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=6070 Jon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #20 from Jon 2009-08-22 11:30:38 PDT --- I'm going to go ahead and resolve this bug, as Yahoo has significantly change their TV listings page and the webarchive attached to this bug doesn't contain all the resources necessary to reproduce the page. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:33:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:33:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 10024] iBench should be in the repository to be runnable by opensource users In-Reply-To: References: Message-ID: <20090822183337.AD0BE353C03B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=10024 --- Comment #1 from Jon 2009-08-22 11:33:37 PDT --- Although SunSpider has been added, the WebKit repository still lacks a general performance suite that tests more aspects of the rendering system. It may still be useful for WebKit to have a general suite to run regression tests against, but I'll leave that for someone else to decide. If not, you can go ahead and close out this bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:35:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:35:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 4225] please add way to build without symbols for better speed, less memory use, less size on disk In-Reply-To: References: Message-ID: <20090822183507.A330A353C069@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=4225 Jon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #1 from Jon 2009-08-22 11:35:07 PDT --- Closing this out, as I don't think there's really a solution. Besides, I don't use this machine anymore. :D -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 12:15:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 12:15:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28062] Crash on image drag In-Reply-To: References: Message-ID: <20090822191528.D878B353C3BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28062 Kevin Ollivier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED AssignedTo|webkit-unassigned at lists.web |kevino at theolliviers.com |kit.org | Ever Confirmed|0 |1 --- Comment #2 from Kevin Ollivier 2009-08-22 12:15:28 PDT --- assigning to me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 12:54:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 12:54:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26609] Support CSS3 attr() function In-Reply-To: References: Message-ID: <20090822195403.DA10B353C734@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26609 Erik Arvidsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arv at chromium.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 12:58:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 12:58:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28658] New: POST'd forms behave different from Firefox Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28658 Summary: POST'd forms behave different from Firefox Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh URL: http://www.phpbb.com/community/ OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jon at jonshier.com In the phpBB3 forum software, the Jump To: form uses the POST method to grab the forum the user wants. After viewing a topic in the jumped to forum, the back button produces the "resubmit form" dialog in Safari. This doesn't happen in Firefox (3.5). Also, this doesn't seem to be the desired behavior, as the content of the page the user wants to go back to isn't determined by the form data, but by the URL it produces. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 13:29:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 13:29:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090822202945.07D4C353CA4F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38434|review? |review+ Flag| | --- Comment #2 from Jan Alonzo 2009-08-22 13:29:44 PDT --- (From update of attachment 38434) Hi Xan > +WebCore::EditingBehavior core(WebKitEditingBehavior type) > +{ > + return (WebCore::EditingBehavior)type; Is it possible to use c++ style casts here? > > +typedef enum { > + WEBKIT_EDITING_BEHAVIOR_MAC, > + WEBKIT_EDITING_BEHAVIOR_WINDOWS > +} WebKitEditingBehavior; Is it possible to add a COMPILE_ASSERT for these just in case of future changes? Thanks. r=me with those changes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 13:30:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 13:30:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24862] REGRESSION: Backspacing link from new line adds "text-decoration: none" to style In-Reply-To: References: Message-ID: <20090822203022.322BF353CA73@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24862 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rniwa at webkit.org --- Comment #11 from Ryosuke Niwa 2009-08-22 13:30:21 PDT --- I think my patches have fixed this bug. It does not reproduce on Chrome 3.0.195. Could someone with Mac try it on the nightly build of WebKit? And if it passes, please add a test case that fails on old WebKit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 13:53:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 13:53:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28614] Unnecessary horizontal scrollbar in Gmail under Chromium. ScrollView::updateScrollbars uses stale value for off/on/auto scrollbar mode. In-Reply-To: References: Message-ID: <20090822205350.489A1353CCF6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28614 Mark Mentovai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38376|0 |1 is obsolete| | Attachment #38436| |review?(hyatt at apple.com) Flag| | --- Comment #3 from Mark Mentovai 2009-08-22 13:53:49 PDT --- Created an attachment (id=38436) --> (https://bugs.webkit.org/attachment.cgi?id=38436) Perform layout before checking scrollbar modes > I am not convinced this is right. You aren't supposed to just always invoke > visibleContentsResized. The existing code always calls visibleContentsResized, though. I'm just moving the call up earlier to avoid using stale data for the off/on/auto value. There's one additional behavior change. The existing code avoids visibleContentsResized if if both the horizontal and vertical scrollbars are forced on or off. With the proposed patch, this is not taken into account. I considered writing the patch to respect these values, but felt that would be unwise. The bug as it relates to Gmail involves the vertical scrollbar mode being changed from auto to forced-on during the call to visibleContentsResized. It seems just as plausible for forced-on/off scrollbars to change back to auto in that call. > Also note that any change to this logic has to be replicated in > WebDynamicScrollbarsView on Mac to keep the two in sync. This version of the patch takes that into account. It also moves a couple of minor things around, with no functional changes, to keep it synchronized with ScrollView::updateScrollbars. > Finally I see no reason to change the word "recur" to "recurse." They mean > exactly the same thing, and changing around English just because you don't like > it pisses me off. OK. It should be pretty clear that I didn't intend to piss anyone off. I've run this through the layout test suite and it doesn't introduce any regressions. It fixes the Gmail bug in Chromium. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 14:07:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 14:07:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28656] REGRESSION: r47676 hangs when loading page on Leopard/PPC In-Reply-To: References: Message-ID: <20090822210715.2E73D353CE29@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28656 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE --- Comment #1 from Mark Rowe (bdash) 2009-08-22 14:07:14 PDT --- *** This bug has been marked as a duplicate of bug 28655 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 14:07:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 14:07:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] Webkit Crash on Launch In-Reply-To: References: Message-ID: <20090822210715.4878B353CE2F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jon at jonshier.com --- Comment #1 from Mark Rowe (bdash) 2009-08-22 14:07:14 PDT --- *** Bug 28656 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 14:08:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 14:08:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090822210822.B3488353CE43@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Webkit Crash on Launch |REGRESSION(r47639-r47660): | |Webkit crashes on launch on | |PowerPC -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 14:11:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 14:11:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090822211154.E37AC353CEC2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barraclough at apple.com --- Comment #2 from Mark Rowe (bdash) 2009-08-22 14:11:54 PDT --- This is probably due to . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 15:34:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 15:34:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26609] Support CSS3 attr() function In-Reply-To: References: Message-ID: <20090822223443.81DE9353D5C9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26609 Jeff Balogh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbalogh at mozilla.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 16:20:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 16:20:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28612] Unclickable Links In-Reply-To: References: Message-ID: <20090822232013.6BADC353D991@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28612 John Moe changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #2 from John Moe 2009-08-22 16:20:13 PDT --- This reliably happens with r47546, but is fixed by r47639. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 17:17:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 17:17:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28660] New: Thread 0 Crashed: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28660 Summary: Thread 0 Crashed: Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh PowerPC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: shawnzone at gmail.com Builds r47676, r47668, r47660 same crash logs. (r47639 no problems) Process: Safari [69805] Path: /Applications/WebKit.app/Contents/MacOS/WebKit Identifier: org.webkit.nightly.WebKit Version: r47676 (47676) Code Type: PPC (Native) Parent Process: launchd [469] Date/Time: 2009-08-22 18:34:26.156 -0500 OS Version: Mac OS X 10.5.8 (9L30) Report Version: 6 Anonymous UUID: 96548AF0-6A22-4107-9626-B3BEB2435548 Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000008 Crashed Thread: 0 Thread 0 Crashed: 0 com.apple.JavaScriptCore 0x004b2410 JSC::JSFunction::~JSFunction() + 48 1 com.apple.JavaScriptCore 0x005a97e8 JSC::VPtrSet::VPtrSet() + 584 2 com.apple.JavaScriptCore 0x005a97e8 JSC::VPtrSet::VPtrSet() + 584 3 com.apple.JavaScriptCore 0x005aa7e0 JSC::JSGlobalData::createLeaked() + 32 4 com.apple.WebCore 0x0143f66c WebCore::JSDOMWindowBase::commonJSGlobalData() + 44 5 com.apple.WebCore 0x014497f4 WebCore::JSDOMWindowShell::operator new(unsigned long) + 20 6 com.apple.WebCore 0x017f8b64 WebCore::ScriptController::initScript() + 68 7 com.apple.WebCore 0x017f8f24 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) + 340 8 com.apple.WebCore 0x012550d8 WebCore::FrameLoader::executeScript(WebCore::ScriptSourceCode const&) + 392 9 com.apple.WebCore 0x01311c34 WebCore::HTMLTokenizer::scriptExecution(WebCore::ScriptSourceCode const&, WebCore::HTMLTokenizer::State) + 932 10 com.apple.WebCore 0x013129b4 WebCore::HTMLTokenizer::scriptHandler(WebCore::HTMLTokenizer::State) + 3364 11 com.apple.WebCore 0x0131305c WebCore::HTMLTokenizer::parseNonHTMLText(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 476 12 com.apple.WebCore 0x01315fcc WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 10300 13 com.apple.WebCore 0x01316a60 WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool) + 1200 14 com.apple.WebCore 0x0125b6b0 WebCore::FrameLoader::write(char const*, int, bool) + 1424 15 com.apple.WebKit 0x0032e098 -[WebFrame(WebInternal) _receivedData:textEncodingName:] + 312 16 com.apple.WebKit 0x003457dc -[WebHTMLRepresentation receivedData:withDataSource:] + 124 17 com.apple.WebKit 0x0031d594 -[WebDataSource(WebInternal) _receivedData:] + 84 18 com.apple.WebKit 0x00334424 WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) + 116 19 com.apple.WebCore 0x01137cc8 WebCore::DocumentLoader::commitLoad(char const*, int) + 88 20 com.apple.WebCore 0x017e27d4 WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) + 68 21 com.apple.WebCore 0x01694dd4 WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) + 2324 22 com.apple.Foundation 0x940af2d4 _NSURLConnectionDidReceiveData + 136 23 com.apple.CFNetwork 0x9735db48 URLConnectionClient::_clientDidReceiveData(__CFData const*, URLConnectionClient::ClientConnectionEventQueue*) + 256 24 com.apple.CFNetwork 0x9735eb0c URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo*, long) + 432 25 com.apple.CFNetwork 0x9735d500 URLConnectionClient::processEvents() + 132 26 com.apple.CFNetwork 0x97307020 MultiplexerSource::perform() + 168 27 com.apple.CoreFoundation 0x913d80d0 CFRunLoopRunSpecific + 1104 28 com.apple.HIToolbox 0x9228eb14 RunCurrentEventLoopInMode + 264 29 com.apple.HIToolbox 0x9228e938 ReceiveNextEventCommon + 412 30 com.apple.HIToolbox 0x9228e778 BlockUntilNextEventMatchingListInMode + 84 31 com.apple.AppKit 0x95a0a244 _DPSNextEvent + 596 32 com.apple.AppKit 0x95a09bfc -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 112 33 com.apple.Safari 0x0000db9c 0x1000 + 52124 34 com.apple.AppKit 0x95a0389c -[NSApplication run] + 744 35 com.apple.AppKit 0x959d4298 NSApplicationMain + 440 36 com.apple.Safari 0x00002fcc 0x1000 + 8140 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 17:33:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 17:33:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823003325.CAA26353DEB9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shawnzone at gmail.com --- Comment #3 from Mark Rowe (bdash) 2009-08-22 17:33:25 PDT --- *** Bug 28660 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 17:33:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 17:33:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28660] Thread 0 Crashed: In-Reply-To: References: Message-ID: <20090823003325.C5D43353DEB7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28660 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE --- Comment #1 from Mark Rowe (bdash) 2009-08-22 17:33:25 PDT --- *** This bug has been marked as a duplicate of bug 28655 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 17:42:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 17:42:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28653] Safari crashes after most recent nightly update In-Reply-To: References: Message-ID: <20090823004232.DDB83353DF4B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28653 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Alias|sdudla_uk at yahoo.com | --- Comment #2 from Mark Rowe (bdash) 2009-08-22 17:42:32 PDT --- This is probably the same as bug 28655, but since there's no actual information it's impossible to say for sure at this point. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 18:53:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 18:53:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28362] SVG Filter feComposite implementation is missing In-Reply-To: References: Message-ID: <20090823015307.04F6C353E683@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28362 Nikolas Zimmermann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35118|review? |review+, commit-queue- Flag| | --- Comment #4 from Nikolas Zimmermann 2009-08-22 18:53:06 PDT --- (From update of attachment 35118) r+, some comments, before landing; > + 2008 Dirk Schulze 2009. > +inline void arithmetic(const RefPtr& srcPixelArrayA, CanvasPixelArray*& srcPixelArrayB, > + const float& k1, const float& k2, const float& k3, const float& k4) s/const float&/float/. We don't use this style in WebKit, even though it's correct, there's no gain. > + FloatRect srcRect = FloatRect(0, 0, -1, -1); Use (0.0f, 0.0f, -1.0f, -1.0f) to be consistent with other callsites. > + switch (m_type) { > + case FECOMPOSITE_OPERATOR_OVER: > + case FECOMPOSITE_OPERATOR_IN: > + case FECOMPOSITE_OPERATOR_OUT: > + case FECOMPOSITE_OPERATOR_ATOP: > + case FECOMPOSITE_OPERATOR_XOR: > + case FECOMPOSITE_OPERATOR_ARITHMETIC: { Indention, case & switch should be aligned. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 18:56:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 18:56:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28661] New: ANY Flickr.com page with thumbnails, especially the recents and "your homepage" Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28661 Summary: ANY Flickr.com page with thumbnails, especially the recents and "your homepage" Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel URL: http://www.flickr.com/recent/ OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Major Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: alin0steglinski at gmail.com Created an attachment (id=38440) --> (https://bugs.webkit.org/attachment.cgi?id=38440) Flickr failure to load In flickr.com when you immediately log in you are taken to your personal homepage, in current nightlies none of the images are clickable directly unless you click the very bottom edge, this is not normal function. Some images fail to load except the bottom clickable edge alltogether. A web archive of the problem resolves the problem, although when flickr.com is viewed in real time it fails to load images sometimes as seen in the attached screenshot along with the only bottom edge clickable problem as stated above. I am not a developer but this function is not correct and has something to do with rendering / layout. This limits the usability of the browser for me severely and I am sure anyone else with this bug is impacted severely by it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 19:03:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 19:03:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28661] ANY Flickr.com page with thumbnails, especially the recents and "your homepage" In-Reply-To: References: Message-ID: <20090823020355.A109F353E746@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28661 --- Comment #1 from Alin S 2009-08-22 19:03:55 PDT --- in addition requested by bdash in IRC I am using build #47677 I first formally noticed this about 2-3 nights ago, somewhere around build #47546 or the build before it, but no more than 5 days ago. I have 1password installed, I tried this on my fresh install on a different computer and there is no difference. still bugged. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 20:22:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 20:22:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 15133] Repair missing alternative text where possible, allow user labelling where not In-Reply-To: References: Message-ID: <20090823032222.D0C5A353ED02@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=15133 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |cfleizach at apple.com Resolution| |FIXED --- Comment #2 from chris fleizach 2009-08-22 20:22:22 PDT --- WebKit provides VoiceOver with a lot more information about images now, include the URL. VoiceOver makes use of the URL if there's no other information Also in SnowLeopard VoiceOver allows user labeling of images (http://www.apple.com/macosx/accessibility/) So I consider this bug resolved -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 20:28:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 20:28:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 6070] Yahoo TV listings only render correctly if refreshed/loaded from active cache. In-Reply-To: References: Message-ID: <20090823032840.2ED1C353ED71@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=6070 --- Comment #21 from David Kilzer (ddkilzer) 2009-08-22 20:28:39 PDT --- (In reply to comment #20) > I'm going to go ahead and resolve this bug, as Yahoo has significantly change > their TV listings page and the webarchive attached to this bug doesn't contain > all the resources necessary to reproduce the page. Unfortunately, the webarchive didn't contain all the resources necessary to reproduce the issue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 21:45:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 21:45:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28480] Don't let local files access web URLs In-Reply-To: References: Message-ID: <20090823044505.94884353F375@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28480 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | AssignedTo|abarth at webkit.org |webkit-unassigned at lists.web | |kit.org --- Comment #14 from Adam Barth 2009-08-22 21:45:04 PDT --- After a discussion on IRC, I've reverted this change. The consensus was to make this change later after various clients have had a chance to opt into the insecure setting if they need it for some reason. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 21:45:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 21:45:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823044550.13189353F396@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Maciej Stachowiak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38443| |review? Flag| | --- Comment #4 from Maciej Stachowiak 2009-08-22 21:45:49 PDT --- Created an attachment (id=38443) --> (https://bugs.webkit.org/attachment.cgi?id=38443) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 21:49:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 21:49:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823044933.9160E353F3DC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38443|review? |review+ Flag| | --- Comment #5 from Mark Rowe (bdash) 2009-08-22 21:49:33 PDT --- (From update of attachment 38443) r=me (without the Platform.h changes!) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:02:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:02:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823050224.92481353F4EA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Maciej Stachowiak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38443|review+ | Flag| | Attachment #38443|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:02:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:02:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823050228.9D20C353F4F9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Maciej Stachowiak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38444| |review? Flag| | --- Comment #6 from Maciej Stachowiak 2009-08-22 22:02:28 PDT --- Created an attachment (id=38444) --> (https://bugs.webkit.org/attachment.cgi?id=38444) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:04:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:04:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823050408.7EF98353F513@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38444|review? |review+ Flag| | --- Comment #7 from Mark Rowe (bdash) 2009-08-22 22:04:08 PDT --- (From update of attachment 38444) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:05:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:05:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28480] Don't let local files access web URLs In-Reply-To: References: Message-ID: <20090823050503.8CCAA353F541@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28480 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrowe at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:12:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:12:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28662] New: Build r47677 crashes on launch Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28662 Summary: Build r47677 crashes on launch Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Major Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: sdudla_uk at yahoo.com On launching Safari it hangs with "Go to this site" showing n the window then it crashes. Process: Safari [88542] Path: /Applications/WebKit.app/Contents/MacOS/WebKit Identifier: org.webkit.nightly.WebKit Version: r47677 (47677) Code Type: PPC (Native) Parent Process: launchd [97] Interval Since Last Report: 79913 sec Crashes Since Last Report: 7 Per-App Interval Since Last Report: 22 sec Per-App Crashes Since Last Report: 1 Date/Time: 2009-08-23 05:57:54.622 +0100 OS Version: Mac OS X 10.5.8 (9L30) Report Version: 6 Anonymous UUID: 97C14EDF-71F7-4228-AEDF-1A99FE7699B7 Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000008 Crashed Thread: 0 Thread 0 Crashed: 0 com.apple.JavaScriptCore 0x004ac410 JSC::JSFunction::~JSFunction() + 48 1 com.apple.JavaScriptCore 0x005a37e8 JSC::VPtrSet::VPtrSet() + 584 2 com.apple.JavaScriptCore 0x005a37e8 JSC::VPtrSet::VPtrSet() + 584 3 com.apple.JavaScriptCore 0x005a47e0 JSC::JSGlobalData::createLeaked() + 32 4 com.apple.WebCore 0x0143f66c WebCore::JSDOMWindowBase::commonJSGlobalData() + 44 5 com.apple.WebCore 0x014497f4 WebCore::JSDOMWindowShell::operator new(unsigned long) + 20 6 com.apple.WebCore 0x017f8b64 WebCore::ScriptController::initScript() + 68 7 com.apple.WebCore 0x017f8f24 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) + 340 8 com.apple.WebCore 0x012550d8 WebCore::FrameLoader::executeScript(WebCore::ScriptSourceCode const&) + 392 9 com.apple.WebCore 0x01311c34 WebCore::HTMLTokenizer::scriptExecution(WebCore::ScriptSourceCode const&, WebCore::HTMLTokenizer::State) + 932 10 com.apple.WebCore 0x013129b4 WebCore::HTMLTokenizer::scriptHandler(WebCore::HTMLTokenizer::State) + 3364 11 com.apple.WebCore 0x0131305c WebCore::HTMLTokenizer::parseNonHTMLText(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 476 12 com.apple.WebCore 0x01315fcc WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 10300 13 com.apple.WebCore 0x01316a60 WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool) + 1200 14 com.apple.WebCore 0x0125b6b0 WebCore::FrameLoader::write(char const*, int, bool) + 1424 15 com.apple.WebKit 0x00328098 -[WebFrame(WebInternal) _receivedData:textEncodingName:] + 312 16 com.apple.WebKit 0x0033f7dc -[WebHTMLRepresentation receivedData:withDataSource:] + 124 17 com.apple.WebKit 0x00317594 -[WebDataSource(WebInternal) _receivedData:] + 84 18 com.apple.WebKit 0x0032e424 WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) + 116 19 com.apple.WebCore 0x01137cc8 WebCore::DocumentLoader::commitLoad(char const*, int) + 88 20 com.apple.WebCore 0x017e27d4 WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) + 68 21 com.apple.WebCore 0x01694dd4 WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) + 2324 22 com.apple.Foundation 0x9535f2d4 _NSURLConnectionDidReceiveData + 136 23 com.apple.CFNetwork 0x90274b48 URLConnectionClient::_clientDidReceiveData(__CFData const*, URLConnectionClient::ClientConnectionEventQueue*) + 256 24 com.apple.CFNetwork 0x90275b0c URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo*, long) + 432 25 com.apple.CFNetwork 0x90275cd8 URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo*, long) + 892 26 com.apple.CFNetwork 0x90274500 URLConnectionClient::processEvents() + 132 27 com.apple.CFNetwork 0x9021e020 MultiplexerSource::perform() + 168 28 com.apple.CoreFoundation 0x9569419c CFRunLoopRunSpecific + 1308 29 com.apple.HIToolbox 0x90ae6b14 RunCurrentEventLoopInMode + 264 30 com.apple.HIToolbox 0x90ae68a0 ReceiveNextEventCommon + 260 31 com.apple.HIToolbox 0x90ae6778 BlockUntilNextEventMatchingListInMode + 84 32 com.apple.AppKit 0x94625244 _DPSNextEvent + 596 33 com.apple.AppKit 0x94624bfc -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 112 34 com.apple.Safari 0x0000db9c 0x1000 + 52124 35 com.apple.AppKit 0x9461e89c -[NSApplication run] + 744 36 com.apple.AppKit 0x945ef298 NSApplicationMain + 440 37 com.apple.Safari 0x00002fcc 0x1000 + 8140 38 ??? 0xbffff9b0 0 + 3221223856 Thread 1: 0 libSystem.B.dylib 0x92ce0c0c __semwait_signal + 12 1 libSystem.B.dylib 0x92d1d46c _pthread_cond_wait + 1580 2 com.apple.JavaScriptCore 0x004a4808 WTF::TCMalloc_PageHeap::scavengerThread() + 104 3 com.apple.JavaScriptCore 0x004a49dc WTF::TCMalloc_PageHeap::runScavengerThread(void*) + 12 4 libSystem.B.dylib 0x92d1c0c4 _pthread_start + 316 Thread 2: 0 libSystem.B.dylib 0x92ce0c0c __semwait_signal + 12 1 libSystem.B.dylib 0x92d1d46c _pthread_cond_wait + 1580 2 com.apple.WebCore 0x013235c0 WebCore::IconDatabase::syncThreadMainLoop() + 304 3 com.apple.WebCore 0x013241e4 WebCore::IconDatabase::iconDatabaseSyncThread() + 420 4 libSystem.B.dylib 0x92d1c0c4 _pthread_start + 316 Thread 3: 0 libSystem.B.dylib 0x92cda1f8 mach_msg_trap + 8 1 libSystem.B.dylib 0x92ce111c mach_msg + 56 2 com.apple.CoreFoundation 0x95694394 CFRunLoopRunSpecific + 1812 3 com.apple.CFNetwork 0x901f03b0 CFURLCacheWorkerThread(void*) + 288 4 libSystem.B.dylib 0x92d1c0c4 _pthread_start + 316 Thread 4: 0 libSystem.B.dylib 0x92cda1f8 mach_msg_trap + 8 1 libSystem.B.dylib 0x92ce111c mach_msg + 56 2 com.apple.Safari 0x00028254 0x1000 + 160340 Thread 5: 0 libSystem.B.dylib 0x92cda1f8 mach_msg_trap + 8 1 libSystem.B.dylib 0x92ce111c mach_msg + 56 2 com.apple.CoreFoundation 0x95694394 CFRunLoopRunSpecific + 1812 3 com.apple.Foundation 0x9535dd50 +[NSURLConnection(NSURLConnectionReallyInternal) _resourceLoadLoop:] + 280 4 com.apple.Foundation 0x95306d84 __NSThread__main__ + 1004 5 libSystem.B.dylib 0x92d1c0c4 _pthread_start + 316 Thread 0 crashed with PPC Thread State 32: srr0: 0x004ac410 srr1: 0x0000d030 dar: 0x00000008 dsisr: 0x40000000 r0: 0x005a37ec r1: 0xbfffce50 r2: 0x005f9e00 r3: 0x07495000 r4: 0xbfffcf38 r5: 0x00000000 r6: 0xbfffcef0 r7: 0x00000020 r8: 0x006ac278 r9: 0x00000000 r10: 0x004ac1fc r11: 0x00000007 r12: 0x004ac4f0 r13: 0x01a3379c r14: 0x07454a20 r15: 0x01a3379c r16: 0x01313900 r17: 0x00000004 r18: 0x00000001 r19: 0xbfffd710 r20: 0xbfffd67c r21: 0x00000000 r22: 0xbfffd82c r23: 0x00000000 r24: 0xbfffd35c r25: 0xbfffd768 r26: 0xbfffcfa0 r27: 0xfffffffb r28: 0x00000000 r29: 0x07495000 r30: 0x07495000 r31: 0x004ac3ec cr: 0x42444222 xer: 0x20000000 lr: 0x004ac3ec ctr: 0x004ac4f0 vrsave: 0x00000000 Binary Images: 0x1000 - 0x29bff7 com.apple.Safari 4.0.3 (5531.9) <795e1a0d97f24320146a4858c7593cf1> /Applications/Safari.app/Contents/MacOS/Safari 0x2f7000 - 0x2f9ffa +WebKitNightlyEnabler.dylib ??? (???) /Applications/WebKit.app/Contents/Resources/WebKitNightlyEnabler.dylib 0x2fe000 - 0x3e9ff4 com.apple.WebKit r47677 (532.0+) <152e3b762e57602c60c19c8dfba00f6f> /Applications/WebKit.app/Contents/Frameworks/10.5/WebKit.framework/Versions/A/WebKit 0x47c000 - 0x48cffc SyndicationUI ??? (???) /System/Library/PrivateFrameworks/SyndicationUI.framework/Versions/A/SyndicationUI 0x49c000 - 0x5f6ffb com.apple.JavaScriptCore 532+ (532.0+) <541841aeca70f5345391d4cb72e8d5b7> /Applications/WebKit.app/Contents/Frameworks/10.5/JavaScriptCore.framework/Versions/A/JavaScriptCore 0x63f000 - 0x667ff3 +org.andymatuschak.Sparkle 1.5 Beta (git) (830f633) <89470a32f74cddfa6b449f225901c6da> /Applications/WebKit.app/Contents/Frameworks/10.5/Sparkle.framework/Versions/A/Sparkle 0xfcc000 - 0x1a2fff2 com.apple.WebCore 532+ (532.0+) <19a14035d47b3c6e429b2b65c0791450> /Applications/WebKit.app/Contents/Frameworks/10.5/WebCore.framework/Versions/A/WebCore 0x31c6000 - 0x33adff3 com.apple.RawCamera.bundle 2.1.0 (474) /System/Library/CoreServices/RawCamera.bundle/Contents/MacOS/RawCamera 0x719a000 - 0x71a0fff libCGXCoreImage.A.dylib ??? (???) <5720828f2c3c017f1691d10ee6b73915> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGXCoreImage.A.dylib 0x8fe00000 - 0x8fe30c23 dyld 97.1 (???) <89a0055b0e7ea2db881b73c6e63bc774> /usr/lib/dyld 0x90003000 - 0x90003ffa com.apple.CoreServices 32 (32) <42b6dda539f7411606187335d9eae0c5> /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices 0x90004000 - 0x90099ff7 com.apple.framework.IOKit 1.5.2 (???) /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit 0x900a0000 - 0x901ecffb com.apple.ImageIO.framework 2.0.6 (2.0.6) <666390f7230cc01b3366106b8894fc46> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/ImageIO 0x901ed000 - 0x902a0ffc com.apple.CFNetwork 438.14 (438.14) <6e213ab40eabfc276ca46a7c7cfad01a> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork 0x902c4000 - 0x902deffb com.apple.CoreVideo 1.6.0 (20.0) /System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo 0x902df000 - 0x903f3ffa com.apple.vImage 3.0 (3.0) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage 0x904eb000 - 0x904ebfff com.apple.audio.units.AudioUnit 1.5 (1.5) /System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit 0x904ec000 - 0x90658ff9 com.apple.AddressBook.framework 4.1.2 (702) <00009729166ef5c0294f864e1c4e54c9> /System/Library/Frameworks/AddressBook.framework/Versions/A/AddressBook 0x90659000 - 0x9066cfff com.apple.LangAnalysis 1.6.5 (1.6.5) <2a661ad6e432dd62dd831e234904061f> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis 0x9066d000 - 0x90680ffb com.apple.speech.synthesis.framework 3.7.1 (3.7.1) <050180a659a3905ea38f2acddcdf7b40> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis 0x90681000 - 0x9073bfff libcrypto.0.9.7.dylib ??? (???) <4b5031781db984ba920156875ec2a772> /usr/lib/libcrypto.0.9.7.dylib 0x9073c000 - 0x90884ff3 libicucore.A.dylib ??? (???) <07d0cefd48d11d5d5b1817c198013f0b> /usr/lib/libicucore.A.dylib 0x90885000 - 0x90885ffe com.apple.quartzframework 1.5 (1.5) <1477ba992c53f43087c7527c4782fd54> /System/Library/Frameworks/Quartz.framework/Versions/A/Quartz 0x90886000 - 0x90908fff com.apple.print.framework.PrintCore 5.5.4 (245.6) <3cde2550ec10348b7162d2b6cb0dfc67> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore 0x90909000 - 0x90917fff libz.1.dylib ??? (???) <1a70dd3594a8c5ad39d785af5da23237> /usr/lib/libz.1.dylib 0x90918000 - 0x9097dffb com.apple.ISSupport 1.8 (38.3) /System/Library/PrivateFrameworks/ISSupport.framework/Versions/A/ISSupport 0x9097e000 - 0x909c0fff com.apple.quartzfilters 1.5.0 (1.5.0) <3f2dc01a646cd5b5ea55d510583ba4d5> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuartzFilters.framework/Versions/A/QuartzFilters 0x909c1000 - 0x90a57fff com.apple.LaunchServices 291 (291) <37e4296a8c233e90c8990634264c294c> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices 0x90a58000 - 0x90ab5ffb com.apple.HIServices 1.7.1 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices 0x90ab6000 - 0x90defff7 com.apple.HIToolbox 1.5.6 (???) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox 0x90df0000 - 0x90ed3fff libobjc.A.dylib ??? (???) /usr/lib/libobjc.A.dylib 0x90eda000 - 0x911dcffb com.apple.CoreServices.CarbonCore 786.11 (786.13) <550244bb91e27b0fbafe01e1c4371103> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore 0x911e8000 - 0x911f3fff com.apple.speech.recognition.framework 3.7.24 (3.7.24) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition 0x911f4000 - 0x91213fff libresolv.9.dylib ??? (???) /usr/lib/libresolv.9.dylib 0x91214000 - 0x91251ffe com.apple.securityfoundation 3.0.2 (36131) /System/Library/Frameworks/SecurityFoundation.framework/Versions/A/SecurityFoundation 0x91252000 - 0x91325fff com.apple.CoreServices.OSServices 228 (228) <8610aed4edbd5d21e887a68c32b5c216> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices 0x91326000 - 0x9137cfff libGLU.dylib ??? (???) <3418ce7ca0863162847f553c15d08674> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib 0x9137d000 - 0x913e4ffb libstdc++.6.dylib ??? (???) /usr/lib/libstdc++.6.dylib 0x913e5000 - 0x91813ffe libGLProgrammability.dylib ??? (???) <5d52750ec9e438b25d3a4db51361fa2b> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLProgrammability.dylib 0x918fb000 - 0x91930ffb com.apple.LDAPFramework 1.4.5 (110) <48289b2a06039321a6efa75c2f0c0402> /System/Library/Frameworks/LDAP.framework/Versions/A/LDAP 0x91931000 - 0x919b9ffb com.apple.audio.CoreAudio 3.1.2 (3.1.2) <6fc8a8cb43506b57b951da899a55d3b9> /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio 0x919ba000 - 0x919d9fff com.apple.vecLib 3.4.2 (vecLib 3.4.2) /System/Library/Frameworks/vecLib.framework/Versions/A/vecLib 0x919da000 - 0x91a24fff com.apple.QuickLookUIFramework 1.3.1 (170.9) /System/Library/PrivateFrameworks/QuickLookUI.framework/Versions/A/QuickLookUI 0x91a25000 - 0x91a25ff8 com.apple.Cocoa 6.5 (???) /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa 0x91a26000 - 0x91a2cffb com.apple.backup.framework 1.0 (1.0) /System/Library/PrivateFrameworks/Backup.framework/Versions/A/Backup 0x91a2d000 - 0x91a5efff com.apple.coreui 1.2 (62) /System/Library/PrivateFrameworks/CoreUI.framework/Versions/A/CoreUI 0x91a5f000 - 0x91b16fff com.apple.QTKit 7.6.2 (1327) /System/Library/Frameworks/QTKit.framework/Versions/A/QTKit 0x91be7000 - 0x91bf2ffb libgcc_s.1.dylib ??? (???) /usr/lib/libgcc_s.1.dylib 0x91bf3000 - 0x91bf9fff com.apple.DisplayServicesFW 2.0.2 (2.0.2) <7f4de3ca234fdf3f06f25d47d7119e9b> /System/Library/PrivateFrameworks/DisplayServices.framework/Versions/A/DisplayServices 0x91bfa000 - 0x91d41ffb com.apple.audio.toolbox.AudioToolbox 1.5.2 (1.5.2) /System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox 0x91d73000 - 0x91dd4fff com.apple.CoreText 2.0.4 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreText.framework/Versions/A/CoreText 0x91f1b000 - 0x91f37ffb libPng.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib 0x91f38000 - 0x91f48fff libsasl2.2.dylib ??? (???) /usr/lib/libsasl2.2.dylib 0x92bf9000 - 0x92c88ffb com.apple.DesktopServices 1.4.8 (1.4.8) /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv 0x92c89000 - 0x92ca9ff7 libJPEG.dylib ??? (???) <70d3c9e2a22410faa560e87a36a32f2c> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib 0x92cb0000 - 0x92cc7ffb com.apple.ImageCapture 5.0.2 (5.0.2) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture 0x92cd9000 - 0x92e79ff3 libSystem.B.dylib ??? (???) <900415cd2c829b2de9a6cdcdaa6307e3> /usr/lib/libSystem.B.dylib 0x92e7a000 - 0x92e98fff com.apple.QuickLookFramework 1.3.1 (170.9) /System/Library/Frameworks/QuickLook.framework/Versions/A/QuickLook 0x92e99000 - 0x92ea5ff3 com.apple.audio.SoundManager 3.9.2 (3.9.2) <79588842bcaf6c747a95b2120304397a> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CarbonSound.framework/Versions/A/CarbonSound 0x92ea6000 - 0x92f40ff7 com.apple.ApplicationServices.ATS 3.7 (???) <2e748b84ad5232add84d6aaad73b832f> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS 0x92f41000 - 0x92f44ffb com.apple.securityhi 3.0 (30817) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI 0x92f95000 - 0x92f98fff com.apple.CrashReporterSupport 10.5.7 (161) <12938c62930c0c2a22cb68bfc618351e> /System/Library/PrivateFrameworks/CrashReporterSupport.framework/Versions/A/CrashReporterSupport 0x93265000 - 0x93272fff libbz2.1.0.dylib ??? (???) <03227e92407191ff8e754461e842201b> /usr/lib/libbz2.1.0.dylib 0x93273000 - 0x93273ffb com.apple.installserver.framework 1.0 (8) /System/Library/PrivateFrameworks/InstallServer.framework/Versions/A/InstallServer 0x93274000 - 0x93274ffc com.apple.MonitorPanelFramework 1.2.0 (1.2.0) <91aadd6dccda219dd50a6ce06aad5b54> /System/Library/PrivateFrameworks/MonitorPanel.framework/Versions/A/MonitorPanel 0x93275000 - 0x93416ff7 com.apple.QuartzComposer 2.1 (106.13) <6dd1df71cb588b1b9ceb0c5bbf32e842> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuartzComposer.framework/Versions/A/QuartzComposer 0x93417000 - 0x93501fff libxml2.2.dylib ??? (???) /usr/lib/libxml2.2.dylib 0x93502000 - 0x93529fff libcups.2.dylib ??? (???) /usr/lib/libcups.2.dylib 0x9352a000 - 0x935b2fff com.apple.ink.framework 101.3 (86) <66a99ad6bc695390a66dd24789e23dcc> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink 0x935b3000 - 0x93602fff com.apple.Metadata 10.5.8 (398.26) <1a261534027b9d1518327d1fabe1182b> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata 0x93684000 - 0x936c1fff libRIP.A.dylib ??? (???) <321f32426fdb395be9346e9b1e378e60> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libRIP.A.dylib 0x936c2000 - 0x936c2fff com.apple.Accelerate 1.4.2 (Accelerate 1.4.2) /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate 0x936c3000 - 0x936dfffb com.apple.openscripting 1.2.8 (???) <01f86cdb8f7347d2f3f13066e954acb6> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting 0x936f6000 - 0x93809fff com.apple.PubSub 1.0.4 (65.11) <4370815eb840a0892988c28122c05c4b> /System/Library/Frameworks/PubSub.framework/Versions/A/PubSub 0x9380a000 - 0x93825ff3 com.apple.DirectoryService.Framework 3.5.6 (3.5.6) /System/Library/Frameworks/DirectoryService.framework/Versions/A/DirectoryService 0x93826000 - 0x9382dfff com.apple.CommonPanels 1.2.4 (85) <0d1256175c5512c911ede094d767acfe> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels 0x9382e000 - 0x9382fff8 com.apple.ApplicationServices 34 (34) <6aa5ee485bb2e656531b3505932b845f> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices 0x93830000 - 0x93831fff libffi.dylib ??? (???) <11b77dbce4aa0f0b66d40014230abd1d> /usr/lib/libffi.dylib 0x93832000 - 0x938b7fff libsqlite3.0.dylib ??? (???) /usr/lib/libsqlite3.0.dylib 0x938b8000 - 0x93968fff edu.mit.Kerberos 6.0.13 (6.0.13) <2ed20a450576465ee4f9c317b8ce8c44> /System/Library/Frameworks/Kerberos.framework/Versions/A/Kerberos 0x93969000 - 0x9399efff com.apple.AE 402.3 (402.3) <75725936d014fd3ca2553d18b784b99b> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE 0x9399f000 - 0x939c9ff7 libssl.0.9.7.dylib ??? (???) <09e02b0724f19afe9f0fc7e4eb893f0d> /usr/lib/libssl.0.9.7.dylib 0x939ca000 - 0x93a19fff libGLImage.dylib ??? (???) <2e1f2a2625064149d209ec19e52d0384> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib 0x93a1a000 - 0x93a1fff6 libmathCommon.A.dylib ??? (???) /usr/lib/system/libmathCommon.A.dylib 0x93b6f000 - 0x93b72fff com.apple.help 1.1 (36) <7106d6e074a3b9835ebf1e6cc6c822ce> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help 0x93b73000 - 0x93b75ffd libRadiance.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib 0x93ba8000 - 0x93bb0fff libbsm.dylib ??? (???) /usr/lib/libbsm.dylib 0x93bb1000 - 0x93c4afc3 libvDSP.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib 0x93c4b000 - 0x93cb5fff com.apple.PDFKit 2.1.2 (2.1.2) /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/PDFKit.framework/Versions/A/PDFKit 0x93cb6000 - 0x93cc3fff libCSync.A.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCSync.A.dylib 0x93cc4000 - 0x93d26ffb com.apple.htmlrendering 68 (1.1.3) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HTMLRendering.framework/Versions/A/HTMLRendering 0x93d27000 - 0x93d32ff9 com.apple.helpdata 1.0.1 (14.2) /System/Library/PrivateFrameworks/HelpData.framework/Versions/A/HelpData 0x93d33000 - 0x93dbdfff libvMisc.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib 0x93dbe000 - 0x93e86ffb com.apple.CoreData 100.2 (186.2) /System/Library/Frameworks/CoreData.framework/Versions/A/CoreData 0x93e87000 - 0x93ecdff9 com.apple.securityinterface 3.0.3 (36953) <4ce4732461084fe3c4417738666ef737> /System/Library/Frameworks/SecurityInterface.framework/Versions/A/SecurityInterface 0x93ece000 - 0x93f15fff com.apple.NavigationServices 3.5.2 (163) <453fd79dd63debad4908dcc726f9aa04> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/NavigationServices.framework/Versions/A/NavigationServices 0x93f16000 - 0x93f25fff com.apple.DSObjCWrappers.Framework 1.3 (1.3) <305892aafaceb4e31915f0d759ef7e6d> /System/Library/PrivateFrameworks/DSObjCWrappers.framework/Versions/A/DSObjCWrappers 0x93f26000 - 0x93f4ffff com.apple.CoreMediaPrivate 15.0 (15.0) /System/Library/PrivateFrameworks/CoreMediaPrivate.framework/Versions/A/CoreMediaPrivate 0x93f64000 - 0x94089ffb com.apple.imageKit 1.0.2 (1.0) <50dfcbe41b384bd71761c761c3fbfd5e> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/ImageKit.framework/Versions/A/ImageKit 0x9408a000 - 0x94091ffb com.apple.print.framework.Print 218.0.3 (220.2) <021d2263007c538fd9e6b52e66a2623d> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print 0x94092000 - 0x940bafff libxslt.1.dylib ??? (???) /usr/lib/libxslt.1.dylib 0x940bb000 - 0x940d3ffb com.apple.DictionaryServices 1.0.0 (1.0.0) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices 0x9413a000 - 0x94167fff libGL.dylib ??? (???) /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib 0x94168000 - 0x944cdffe com.apple.QuartzCore 1.5.8 (1.5.8) <60e54cfb861dc5e66bb4f263a192d558> /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore 0x944ce000 - 0x944f7ffb com.apple.shortcut 1.0.1 (1.0) <8da20d176ab4cf71cdf4f79b477fe0e7> /System/Library/PrivateFrameworks/Shortcut.framework/Versions/A/Shortcut 0x944f8000 - 0x945a8fff com.apple.QD 3.11.56 (???) <5e3f7cbff6ff025da4ce6ec610845f5e> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD 0x945e9000 - 0x94d5ffff com.apple.AppKit 6.5.9 (949.54) <687f1742c249d7c9268e2eb57713cef6> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x94d60000 - 0x952dcff3 com.apple.CoreGraphics 1.409.3 (???) <42ab271a33fb5cfb6f07e4dff8a5ca76> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics 0x952dd000 - 0x952fcfff com.apple.Accelerate.vecLib 3.4.2 (vecLib 3.4.2) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib 0x952fd000 - 0x95543ffb com.apple.Foundation 6.5.9 (677.26) /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation 0x95544000 - 0x95548ffe libGIF.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib 0x95549000 - 0x95582fff com.apple.SystemConfiguration 1.9.2 (1.9.2) <21dee7ffd93306032f911b5ef3fdbab3> /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration 0x95583000 - 0x955aeff7 libauto.dylib ??? (???) /usr/lib/libauto.dylib 0x955af000 - 0x9562afff com.apple.SearchKit 1.2.2 (1.2.2) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit 0x9562b000 - 0x95750ff3 com.apple.CoreFoundation 6.5.7 (476.19) /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation 0x95751000 - 0x95a83ffb com.apple.QuickTime 7.6.2 (1327) /System/Library/Frameworks/QuickTime.framework/Versions/A/QuickTime 0x95cee000 - 0x95cf7fff com.apple.DiskArbitration 2.2.1 (2.2.1) <682f5c45591e8c4a89c79e384e2c49af> /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration 0x95cf8000 - 0x95cf8fff com.apple.Carbon 136 (136) <6a6a209ec9179368db7ead8382b8ee63> /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon 0x96688000 - 0x969b1fe7 libLAPACK.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib 0x969b2000 - 0x969f0ff7 libtidy.A.dylib ??? (???) /usr/lib/libtidy.A.dylib 0x96ace000 - 0x96b0fffb libTIFF.dylib ??? (???) <3d90effc44de6e218670af9eb8cdee57> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib 0x96b10000 - 0x96b54fff com.apple.CoreMediaIOServicesPrivate 20.0 (20.0) /System/Library/PrivateFrameworks/CoreMediaIOServicesPrivate.framework/Versions/A/CoreMediaIOServicesPrivate 0x96b55000 - 0x96c24fff com.apple.ColorSync 4.5.2 (4.5.2) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync.framework/Versions/A/ColorSync 0x96c25000 - 0x971dffff libBLAS.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib 0x971e0000 - 0x971e8ffb libCGATS.A.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGATS.A.dylib 0x9721c000 - 0x97405ffb com.apple.security 5.0.5 (36371) /System/Library/Frameworks/Security.framework/Versions/A/Security 0x9744b000 - 0x97459ff3 com.apple.opengl 1.5.10 (1.5.10) <54bae289e544387ce7997a4a05e70aa9> /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL 0xfffec000 - 0xfffeffff libobjc.A.dylib ??? (???) /usr/lib/libobjc.A.dylib 0xffff8000 - 0xffff9703 libSystem.B.dylib ??? (???) /usr/lib/libSystem.B.dylib -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:38:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:38:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] New: [Gtk] API for disabling local file access to web URLs Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28663 Summary: [Gtk] API for disabling local file access to web URLs Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Keywords: Gtk Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jmalonzo at gmail.com This is the Gtk component of https://bugs.webkit.org/show_bug.cgi?id=28480. Patch forthcoming.. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:43:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:43:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823054350.8B015353F83D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38445| |review? Flag| | --- Comment #1 from Jan Alonzo 2009-08-22 22:43:50 PDT --- Created an attachment (id=38445) --> (https://bugs.webkit.org/attachment.cgi?id=38445) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:22:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:22:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 10024] iBench should be in the repository to be runnable by opensource users In-Reply-To: References: Message-ID: <20090823062245.6AED5353FA59@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=10024 --- Comment #2 from Alexey Proskuryakov 2009-08-22 23:22:45 PDT --- My understanding is that iBench requires a Windows-based server, so it wouldn't be of much help for most WebKit developers. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:23:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:23:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28657] Form post to IFRAME change browser history In-Reply-To: References: Message-ID: <20090823062336.D9B92353FA6F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28657 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |beidson at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:31:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:31:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28626] WebKit quits (no crash log) when a link to a MPEG-1 file is clicked on. In-Reply-To: References: Message-ID: <20090823063111.3EC2C353FB0A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28626 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org --- Comment #1 from Alexey Proskuryakov 2009-08-22 23:31:11 PDT --- I cannot reproduce this with a local debug build of r47661 on Mac OS X 10.5.8 (Intel). Will upgrading to QuickTime 7.6.2 solve the problem for you? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:37:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:37:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090823063727.E30DA353FBBD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from Xan Lopez 2009-08-22 23:37:27 PDT --- Thanks, committed as r47687 with those changes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:42:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:42:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823064230.2C414353FC1F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38445|review? |review+ Flag| | --- Comment #2 from Xan Lopez 2009-08-22 23:42:29 PDT --- (From update of attachment 38445) > gboolean javascript_can_open_windows_automatically; > gboolean enable_offline_web_application_cache; > + gboolean enable_universal_access_from_file_uri; from_file_uriS ? > }; > > #define WEBKIT_WEB_SETTINGS_GET_PRIVATE(obj) (G_TYPE_INSTANCE_GET_PRIVATE((obj), WEBKIT_TYPE_WEB_SETTINGS, WebKitWebSettingsPrivate)) > @@ -130,7 +131,8 @@ enum { > PROP_ENABLE_XSS_AUDITOR, > PROP_USER_AGENT, > PROP_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY, > - PROP_ENABLE_OFFLINE_WEB_APPLICATION_CACHE > + PROP_ENABLE_OFFLINE_WEB_APPLICATION_CACHE, > + PROP_ENABLE_UNIVERSAL_ACCESS_FROM_FILE_URI URIS ? > }; > > // Create a default user agent string > @@ -597,7 +599,21 @@ static void webkit_web_settings_class_init(WebKitWebSettingsClass* klass) > TRUE, > flags)); > > - > + /** > + * WebKitWebSettings:enable-universal-access-from-file-uri > + * > + * Whether to allow files loaded through file:// URIs universal access to > + * pages loaded through non-file schemes. Isn't it just to all pages? > + * > + * Since 1.1.13 > + */ > + g_object_class_install_property(gobject_class, > + PROP_ENABLE_UNIVERSAL_ACCESS_FROM_FILE_URI, > + g_param_spec_boolean("enable-universal-access-from-file-uri", > + _("Enable universal access from file URI"), URIs ? r=me with the name changes and the doc fixup in case it applies to all pages. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:53:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:53:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] New: Inspector: Throws an Error on "null" Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28665 Summary: Inspector: Throws an Error on "null" Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: joepeck at webkit.org CC: timothy at hatcher.name, aroben at apple.com, pfeldman at chromium.org The Console is throwing an error on "null". This seems to happen because after the result of an eval goes to InspectorController.wrapObject(), which doesn't handle null very well. Current Behavior: > null TypeError: Result of expression 'wrapper' [null] is not an object. > [null, null] [] > var o = { a: null } Object a: null > o.a TypeError: Result of expression 'wrapper' [null] is not an object. Expected Behavior (from Safari 4.0.3): > null null > [null, null] [null, null] > var o = { a:null } undefined > o Object a: null > o.a null -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:04:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:04:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823070404.548A8353FDC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38447| |review? Flag| | --- Comment #1 from Joseph Pecoraro 2009-08-23 00:04:03 PDT --- Created an attachment (id=38447) --> (https://bugs.webkit.org/attachment.cgi?id=38447) [PATCH] One Possible Solution No other falsey value causes wrapObject() to return a null value (NaN, undefined, 0, ''). This solution tackles null before calling wrapObject. Another solution could be checking the result of wrapObject (wrapper). And yet another solution could handle null differently inside InspectorController.wrapObject(). This approach seemed simplest. Pavel, would there be a more appropriate solution? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:04:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:04:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823070420.D2E2D353FDDC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38447|application/octet-stream |text/plain mime type| | Attachment #38447|0 |1 is patch| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:08:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:08:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823070845.6F76F353FE59@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck at webkit.org --- Comment #2 from Joseph Pecoraro 2009-08-23 00:08:45 PDT --- Actually that "exception: false" part isn't necessary, because thats the implicit default if its left out. So I can remove that if this is an okay way to go. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:11:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:11:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28345] [GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly In-Reply-To: References: Message-ID: <20090823071145.1ECE8353FEA3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28345 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35016|review? |review+ Flag| | --- Comment #6 from Xan Lopez 2009-08-23 00:11:44 PDT --- (From update of attachment 35016) This looks good to me, and on top of fixing a bug it manages to do the data conversion on the client side. There's a NULL where we should use 0, but I'll fix that when landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:18:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:18:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090823071854.6FFED353FF42@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Bug 28346 depends on bug 28345, which changed state. Bug 28345 Summary: [GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly https://bugs.webkit.org/show_bug.cgi?id=28345 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:18:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:18:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28345] [GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly In-Reply-To: References: Message-ID: <20090823071854.40D3F353FF3A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28345 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |xan.lopez at gmail.com Resolution| |FIXED --- Comment #7 from Xan Lopez 2009-08-23 00:18:54 PDT --- Committed as r47689, closing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:25:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:25:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28666] New: Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28666 Summary: Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: joepeck at webkit.org CC: timothy at hatcher.name, aroben at apple.com, pfeldman at chromium.org Current Behavior: > Math.sin function sin() { > var o = { a: Math.sin } undefined > o Object a: function sin() { > o.a function sin() { Expected Behavior: (From Safari 4.0.3) > Math.sin function sin() { [native code] } > var o = { a: Math.sin } undefined > o Object a: function sin() { > o.a function sin() { [native code] } The current behavior abbreviates too often (in fact all the time). Specifically when setting the "description" in InjectedScript.createProxyObject. Changing the Object.describe() call inside createProxyObject makes all of the examples above the unabbreviated style. Should abbreviation move out of Object.describe() and instead be used right before showing in the UI? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:27:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:27:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] New: Make XSSAuditor go fast Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28667 Summary: Make XSSAuditor go fast Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Keywords: XSSAuditor Severity: Normal Priority: P2 Component: WebCore JavaScript AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abarth at webkit.org CC: sam at webkit.org, fishd at chromium.org, dbates at webkit.org Enabling the XSSAuditor slows down the intl1 page cycler slightly slower. We should make the auditor go faster. Patch forthcoming. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:31:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:31:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823083136.DCB40354044F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38449| |review? Flag| | --- Comment #1 from Adam Barth 2009-08-23 01:31:36 PDT --- Created an attachment (id=38449) --> (https://bugs.webkit.org/attachment.cgi?id=38449) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:37:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:37:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823083757.668D635404EF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 --- Comment #2 from Adam Barth 2009-08-23 01:37:57 PDT --- Here are the perf numbers from my laptop (two runs for each condition, 15 cycles per run, warm disk cache): XSSAuditor disabled: 187.91, 188.07 XSSAuditor enabled (old): 191.60, 192.17 XSSAuditor enabled (new): 189.14, 189.85 By my calculations, the old auditor slowed down intl1 by 2% whereas the new auditor only slows it down by 0.8%. It's possible there is more room for optimization, but this change seems worth doing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:43:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:43:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823084319.1B871354055B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sdudla_uk at yahoo.com --- Comment #8 from Mark Rowe (bdash) 2009-08-23 01:43:18 PDT --- *** Bug 28662 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:43:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:43:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28662] Build r47677 crashes on launch In-Reply-To: References: Message-ID: <20090823084319.015783540555@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28662 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE Alias|sdudla_uk at yahoo.com | --- Comment #1 from Mark Rowe (bdash) 2009-08-23 01:43:18 PDT --- *** This bug has been marked as a duplicate of bug 28655 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:43:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:43:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823084351.E27F03540577@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 --- Comment #9 from Mark Rowe (bdash) 2009-08-23 01:43:51 PDT --- *** Bug 28653 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:43:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:43:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28653] Safari crashes after most recent nightly update In-Reply-To: References: Message-ID: <20090823084351.AFB8E3540571@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28653 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE --- Comment #3 from Mark Rowe (bdash) 2009-08-23 01:43:51 PDT --- *** This bug has been marked as a duplicate of bug 28655 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:44:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:44:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823084443.4BB993540593@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #10 from Mark Rowe (bdash) 2009-08-23 01:44:43 PDT --- Maciej landed this in r47686, and there's a new nightly build up that contains this fix. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:47:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:47:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823084711.6066B35405BB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Jan Alonzo 2009-08-23 01:47:11 PDT --- (In reply to comment #2) > > r=me with the name changes and the doc fixup in case it applies to all pages. Landed as http://trac.webkit.org/changeset/47690. Thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:48:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:48:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823084823.5C99435405DB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 --- Comment #3 from Mark Rowe (bdash) 2009-08-23 01:48:22 PDT --- (From update of attachment 38449) Rather than dropping the "const" from all of these functions that are conceptually cons I think it make more sense to mark m_memoizer as mutable instead. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:57:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:57:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28340] 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be wrapped In-Reply-To: References: Message-ID: <20090823085735.9EEDE35406D1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28340 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW AssignedTo|pfeldman at chromium.org |webkit-unassigned at lists.web | |kit.org --- Comment #8 from Pavel Feldman 2009-08-23 01:57:35 PDT --- Both scenarios work fine on 32-bit and on Chromium 64-bit. Latter uses another version of DOM bindings including different quarantine code though. So most likely the problem is with the JSC quarantines. I don't feel comfortable owning this bug since I can't reproduce it in the standard WebKit environment. Note that I am working on removing quarantines from the Web Inspector at all, so that the bug might become obsolete some time soon. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:00:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:00:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28668] New: [Gtk] Test for HTTP authentication in Application cache fails Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28668 Summary: [Gtk] Test for HTTP authentication in Application cache fails Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: NEW Keywords: Gtk Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jmalonzo at gmail.com The test http/tests/appcache/auth.html is failing because it's timing out. Related changeset is http://trac.webkit.org/changeset/47439. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:05:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:05:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28668] [Gtk] Test for HTTP authentication in Application cache fails In-Reply-To: References: Message-ID: <20090823090514.AEDBB3540771@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28668 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gns at gnome.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:11:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:11:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823091103.64FA735407DD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #3 from Pavel Feldman 2009-08-23 02:11:03 PDT --- > + return { value: InjectedScript.createProxyObject(null, null), exception: false }; We don't wrap primitive values with proxy objects at the moment, why wrapping null. I would just do return { value: null }; However, that would require fixing ConsoleView's proxy detection: var isProxy = typeof output === "object"; should be replaced with var isProxy = output !== null && typeof output === "object"; -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:18:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:18:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28666] Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often In-Reply-To: References: Message-ID: <20090823091851.D311E35408AF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28666 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #1 from Pavel Feldman 2009-08-23 02:18:51 PDT --- (In reply to comment #0) > The current behavior abbreviates too often (in fact all the time). > Specifically when setting the "description" in > InjectedScript.createProxyObject. Changing the Object.describe() call inside > createProxyObject makes all of the examples above the unabbreviated style. > Should abbreviation move out of Object.describe() and instead be used right > before showing in the UI? Thanks for reporting this. Passing information from the InjectedScript to the UI is going to be slow, especially after we add the JSON serialization there. So we don't want to push information that might not be needed for the UI. I think I just need to find the place where it got regressed and do no abbreviation there. Or do you want to investigate it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:23:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:23:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823092315.F40F13540920@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38445|review+ | Flag| | Attachment #38445|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:23:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:23:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823092321.9FA2F354092B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38450| |review? Flag| | --- Comment #4 from Jan Alonzo 2009-08-23 02:23:21 PDT --- Created an attachment (id=38450) --> (https://bugs.webkit.org/attachment.cgi?id=38450) Enable setting for DRT -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:25:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:25:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823092501.7CBF73540948@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #5 from Jan Alonzo 2009-08-23 02:25:01 PDT --- Reopening as we need the setting enabled in DRT. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:26:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:26:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823092653.436F03540974@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 --- Comment #4 from Pavel Feldman 2009-08-23 02:26:53 PDT --- Additional note: fixing InspectorController.wrapObject would be nicer, but you would need to do that in both bindings (comparing to null are returning argument). It will still require mentioned fix in the console though. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:41:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:41:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28666] Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often In-Reply-To: References: Message-ID: <20090823094103.393023540A81@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28666 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38451| |review? Flag| | Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | --- Comment #2 from Pavel Feldman 2009-08-23 02:41:02 PDT --- Created an attachment (id=38451) --> (https://bugs.webkit.org/attachment.cgi?id=38451) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:54:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:54:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823095419.ADABF3540BAD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38450|review? |review+ Flag| | --- Comment #6 from Xan Lopez 2009-08-23 02:54:19 PDT --- (From update of attachment 38450) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 03:03:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 03:03:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823100301.77A3A3540C73@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38450| |commit-queue- Flag| | --- Comment #7 from Jan Alonzo 2009-08-23 03:03:01 PDT --- (From update of attachment 38450) Rejecting patch 38450 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/build-webkit failed with exit code 2 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 03:03:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 03:03:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823100354.003743540C97@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 --- Comment #8 from Jan Alonzo 2009-08-23 03:03:53 PDT --- (From update of attachment 38450) Rejecting patch 38450 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'rebase']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 03:09:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 03:09:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823100908.7F1C13540D17@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #9 from Jan Alonzo 2009-08-23 03:09:08 PDT --- (In reply to comment #6) > (From update of attachment 38450 [details]) > r=me Landed as http://trac.webkit.org/changeset/47692 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 04:08:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 04:08:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090823110852.D2A943541138@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED CC| |jmalonzo at gmail.com Resolution|FIXED | --- Comment #4 from Jan Alonzo 2009-08-23 04:08:52 PDT --- (In reply to comment #3) > Thanks, committed as r47687 with those changes. This changed introduced a regression in the following test: editing/execCommand/toggle-compound-styles.html -> failed The change in http://trac.webkit.org/changeset/46920 might be helpful. I guess we need to rebaseline the test to match mac? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 04:09:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 04:09:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090823110910.6B55C3541145@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 05:47:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 05:47:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] New: make-script-test-wrappers should be executable Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28669 Summary: make-script-test-wrappers should be executable Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: NEW Severity: Enhancement Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cam at mcc.id.au WebKitTools/Scripts/make-script-test-wrappers should be executable, like nearly all other files in WebKitTools/Scripts/ are. update-sources-list.py probably should be executable too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 05:56:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 05:56:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090823125628.B044B354199F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 --- Comment #1 from Cameron McCormack 2009-08-23 05:56:28 PDT --- Ah, prepare-ChangeLog doesn't work if the only changes I've made are to properties: fox:~/svn/WebKit cam$ ./WebKitTools/Scripts/prepare-ChangeLog Running status to find changed, added, or removed files. M WebKitTools/Scripts/update-sources-list.py M WebKitTools/Scripts/make-script-test-wrappers No changes found. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 06:22:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 06:22:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26304] [GTK] Add controls for playing html5 video. In-Reply-To: References: Message-ID: <20090823132236.57E733541E60@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26304 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38452| |review? Flag| | --- Comment #6 from Zan Dobersek 2009-08-23 06:22:35 PDT --- Created an attachment (id=38452) --> (https://bugs.webkit.org/attachment.cgi?id=38452) Media controls impl., 1. Implements media controls painting. >From ChangeLog entry: Implements controls for media elements. Adds a new initializator to the Color class, which makes it possible to initialize Color with a GdkColor and an alpha channel. Adds a new loading function to the Image class, loadPlatformThemeIcon, which loads only platform theme icons. Available only for the Gtk+ port. Also modifies the whole process of loading platform resources so there is a maximum sharing of code between this new function and the loadPlatformResource function. Adds a stylesheet that overrides some of the default style settings of the media control panel. Changes by this patch in RenderThemeGtk class: - media slider thumb's size gets properly adjusted, - gtkContainer's 'style-set' signal is connected to the appropriate callback, which forces reinitialization of icons and colors on a style change, - implements paintMedia* functions, which now properly paint media controls. I believe there can be some style or naming issues, I'll be glad to fix them. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 06:22:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 06:22:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26304] [GTK] Add controls for playing html5 video. In-Reply-To: References: Message-ID: <20090823132253.79AEE3541E70@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26304 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zandobersek at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 06:29:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 06:29:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26304] [GTK] Add controls for playing html5 video. In-Reply-To: References: Message-ID: <20090823132938.782D03541F0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26304 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Gtk Status|UNCONFIRMED |NEW CC| |jmalonzo at gmail.com Component|New Bugs |WebKit Gtk Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 07:55:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 07:55:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823145524.3033635427C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38447|review? | Flag| | Attachment #38447|0 |1 is obsolete| | Attachment #38453| |review? Flag| | --- Comment #5 from Joseph Pecoraro 2009-08-23 07:55:23 PDT --- Created an attachment (id=38453) --> (https://bugs.webkit.org/attachment.cgi?id=38453) [PATCH] Pavel's JavaScript Approach -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 07:58:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 07:58:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823145850.35DB5354280D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 --- Comment #6 from Joseph Pecoraro 2009-08-23 07:58:49 PDT --- (In reply to comment #4) > Additional note: fixing InspectorController.wrapObject would be nicer, but you > would need to do that in both bindings (comparing to null are returning > argument). It will still require mentioned fix in the console though. What I said earlier was not accurate. wrapObject doesn't have trouble with null, it just ends up returning the value passed in, which was null, and a null value isn't handled well afterwards. I like this approach. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 08:26:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 08:26:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23107] run-in spec violation and rendering differences to Opera/IE In-Reply-To: References: Message-ID: <20090823152654.585A43542B00@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23107 j.j. changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |moz at jeka.info --- Comment #2 from j.j. 2009-08-23 08:26:54 PDT --- Had this changed with bug 27193 ? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 09:26:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 09:26:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28340] 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be wrapped In-Reply-To: References: Message-ID: <20090823162648.4DCD43543129@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28340 --- Comment #9 from Simon Fraser (smfr) 2009-08-23 09:26:47 PDT --- We need to figure out when this regressed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 10:05:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 10:05:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823170525.021FF354351D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38449|review? |review- Flag| | --- Comment #4 from Adam Barth 2009-08-23 10:05:24 PDT --- (From update of attachment 38449) Actually, I screwed up the memoization too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 10:50:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 10:50:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823175045.12495354397F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38449|review- | Flag| | Attachment #38449|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 10:51:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 10:51:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823175118.F3B0835439B6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38454| |review? Flag| | --- Comment #5 from Adam Barth 2009-08-23 10:51:18 PDT --- Created an attachment (id=38454) --> (https://bugs.webkit.org/attachment.cgi?id=38454) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 11:17:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 11:17:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28422] Linking fails with "relocation R_X86_64_PC32 against symbol `cti_vm_throw'" In-Reply-To: References: Message-ID: <20090823181719.120553543C58@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28422 --- Comment #4 from Priit Laes (IRC: plaes) 2009-08-23 11:17:18 PDT --- (In reply to comment #3) > (From update of attachment 35026 [details]) > Hiding/filtering the symbols is not the right fix here. You might as well do a > release build. Have you tried forcing -fPIC in CFLAGS? If that works then we > need to fix our build scripts to do that automatically. Tried with CXXFLAGS="-fPIC" CFLAGS="-fPIC" but it didn't work. I have an alternative patch that seems to fix this issue (at least on my machine): http://plaes.org/files/2009-Q3/webkit-bug-28422-use-plt-segment-for-cti_vm_throw.patch It seems to be the right approach ( See section 1.5.5 in http://people.redhat.com/drepper/dsohowto.pdf paper..) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 12:34:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 12:34:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823193418.AB2DB3544350@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38453|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 12:56:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 12:56:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090823195626.1857D3544576@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zandobersek at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 13:08:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 13:08:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28340] 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be wrapped In-Reply-To: References: Message-ID: <20090823200844.93C6635446A0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28340 --- Comment #10 from Pavel Feldman 2009-08-23 13:08:44 PDT --- (In reply to comment #9) > We need to figure out when this regressed. It is known when it regressed (my Migrate to DOMAgent change), but it is unclear why it is only triggering on 64bit. I can't reproduce it, but I know that it is triggering in the console formatting code. I hope Oliver finishes his analysis and points me to the statement in the javascript code triggering the assertion. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 13:21:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 13:21:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090823202108.C31D535447C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28391|0 |1 is obsolete| | --- Comment #18 from Zan Dobersek 2009-08-23 13:21:08 PDT --- Created an attachment (id=38455) --> (https://bugs.webkit.org/attachment.cgi?id=38455) WIP patch This is a work-in-progress patch and is therefor not bisected into smaller (and better) patches. It also includes diff of the Skipped list. This patch only implements functions and applies modifications necessary for most of the layout tests in LayoutTests/media/ directory to pass. With applied patch, 64 tests apply. Some crashes still occur in webkit_video_sink_idle_func when priv->async_queue is checked. Between g_idle_add_full call in webkit_video_sink_render and webkit_video_sink_idle_func call, a call to webkit_video_sink_dispose is made. This corrupts async queue, therefor crashes occur. In the patch, g_idle_remove_by_data is called in webkit_video_sink_stop to remove these idle calls, but some still appear to slip by. In MediaPlayerPrivateGStreamer.cpp, setEndTime() implementation has been removed, as it seems this is not used anywhere in WebCore. Maybe not the best idea, as it could get used? There are plenty of things still awaiting implementation, such as functions maxTimeLoaded, maxTimeSeekable, maxTimeBuffered, ... There is also a bit of a mess in the updateStates function that could use a bit of a cleanup. Error handling was a bit improved, now calling loadingFailed to the MediaPlayerPrivate with a different error for different error domain that we get in mediaPlayerPrivateErrorCallback. Also, the patch now uses playbin2 as the factory name when creating m_playBin. playbin2 is surely better that playbin, however, according to gst base plugins reference manual [1] it is, at this moment, considered unstable, but Rhythmbox is already using it since 0.12.2.[2][3] That's about it, next step are the http/media tests. Comments, suggestions, anything welcome. [1] http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-plugins/html/gst-plugins-base-plugins-playbin2.html [2] http://bugzilla.gnome.org/show_bug.cgi?id=542922 [3] http://git.gnome.org/cgit/rhythmbox/tree/NEWS#n100 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 13:50:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 13:50:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26304] [GTK] Add controls for playing html5 video. In-Reply-To: References: Message-ID: <20090823205039.DEC753544A8D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26304 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38452|review? | Flag| | Attachment #38452|0 |1 is obsolete| | Attachment #38456| |review? Flag| | --- Comment #7 from Zan Dobersek 2009-08-23 13:50:39 PDT --- Created an attachment (id=38456) --> (https://bugs.webkit.org/attachment.cgi?id=38456) Media controls impl. 2. Removed an unneeded fprintf call. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 13:58:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 13:58:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] New: [Chromium] Multi-value select boxes cannot do non-contiguous selection Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28670 Summary: [Chromium] Multi-value select boxes cannot do non-contiguous selection Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh URL: http://code.google.com/p/chromium/issues/detail?id=159 98 OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rsesek at bluestatic.org CC: playmobil at google.com On Chromium Mac, you cannot perform non-contiguous selection on a multi-value list box in the normal Mac way. On the Mac, you do this kind of selection by holding down the Command key; on Windows, you do this with the Control key. In SelectElement.cpp, the #if guard that determines which of these keys to respect uses PLATFORM(MAC), which is always false for Chromium. The fix is to use PLATFORM(DARWIN). Patch coming shortly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 14:20:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 14:20:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823212008.821373544DE4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38453| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 14:31:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 14:31:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090823213101.60F623544F22@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Robert Sesek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38458| |review?(darin at apple.com) Flag| | --- Comment #1 from Robert Sesek 2009-08-23 14:31:00 PDT --- Created an attachment (id=38458) --> (https://bugs.webkit.org/attachment.cgi?id=38458) Fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 14:42:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 14:42:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823214215.AC3793545046@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38453|review+, commit-queue+ | Flag| | --- Comment #7 from Eric Seidel 2009-08-23 14:42:15 PDT --- (From update of attachment 38453) Clearing flags on attachment: 38453 Committed r47696: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 14:42:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 14:42:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823214218.7C7953545062@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #8 from Eric Seidel 2009-08-23 14:42:18 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 15:13:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 15:13:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28619] [GTK] Geolocation needs permission API before being enabled by default In-Reply-To: References: Message-ID: <20090823221340.CAF5B3545332@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28619 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38417|review? |review+, commit-queue- Flag| | --- Comment #3 from Gustavo Noronha (kov) 2009-08-23 15:13:40 PDT --- (From update of attachment 38417) r=me Can you check that the bot has all the geoclue* packages that you have installed, when landing? =) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 15:21:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 15:21:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090823222131.89D5C354542C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Jeremy Moskovich changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38458|review?(darin at apple.com) |review? Flag| | --- Comment #2 from Jeremy Moskovich 2009-08-23 15:21:31 PDT --- (From update of attachment 38458) WebKit convention is to cc relevant parties and not to assign specific reviewers, thus I'm moving Darin to the cc list. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 15:21:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 15:21:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090823222138.7040A3545434@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Jeremy Moskovich changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 15:51:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 15:51:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090823225128.712C435456A9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 --- Comment #19 from Gustavo Noronha (kov) 2009-08-23 15:51:27 PDT --- (From update of attachment 38455) I like it, keep rocking =) ?222 if (m_errorOccured) ?223 return 0; ?224 ?225 float ret = 0.0; Since you're initializing it here, you don't need to reset this in the else block bellow this. Actually, why not do an early return here instead: 225228 if (gst_element_query(m_playBin, query)) { Make that check to !, print the error log, and return, after unref'ing the object. > - GstElement* audioSink = gst_element_factory_make("gconfaudiosink", 0); > +// GstElement* audioSink = gst_element_factory_make("gconfaudiosink", 0); > m_videoSink = webkit_video_sink_new(m_surface); > > - g_object_set(m_playBin, "audio-sink", audioSink, NULL); > +// g_object_set(m_playBin, "audio-sink", audioSink, NULL); > g_object_set(m_playBin, "video-sink", m_videoSink, NULL); I think this can be removed, indeed, instead of just being commented. We only need to override the video sink. Except for these, I don't see a reason not to r+ this. Anything specific keeping you from setting r? apart from a missing ChangeLog, and lack of 'divinding' the patch into smaller patches? I believe this patch has actually a good size, tbh. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 15:58:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 15:58:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28354] webkitgtk 1.1.12 crashes at the end of loading almost any site In-Reply-To: References: Message-ID: <20090823225810.77DE13545745@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28354 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35116|review? |review+, commit-queue- Flag| | --- Comment #4 from Gustavo Noronha (kov) 2009-08-23 15:58:10 PDT --- (From update of attachment 35116) This sounds like a good oportunity to add a layout test indeed, but since it's a crasher, and we want to release soonish, I better not wait for it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:01:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:01:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090823230158.B7EF635457B1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35022|review? |review+, commit-queue+ Flag| | --- Comment #9 from Gustavo Noronha (kov) 2009-08-23 16:01:58 PDT --- (From update of attachment 35022) Good to see this moving forward =). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:02:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:02:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090823230256.E540435457DB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35022|commit-queue+ |commit-queue- Flag| | --- Comment #10 from Eric Seidel 2009-08-23 16:02:56 PDT --- (From update of attachment 35022) Rejecting patch 35022 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=35022 from bug 28346 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:12:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:12:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28317] Assertion being hit on layout tests in debug build In-Reply-To: References: Message-ID: <20090823231257.43BB435458D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28317 --- Comment #10 from Gustavo Noronha (kov) 2009-08-23 16:12:57 PDT --- Created an attachment (id=38459) --> (https://bugs.webkit.org/attachment.cgi?id=38459) dump of breakpoint Here's a dump I got following gbarra's instructions =). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:17:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:17:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28672] New: logmein.com becomes unresponsive during remote control Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28672 Summary: logmein.com becomes unresponsive during remote control Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel URL: http://logmein.com OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Major Priority: P2 Component: Java AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: prw at widing.com logmein.com - primary log in completed. Clicked on remote computer. Remote session starts - but loading never completes. Loading "x" butt unresponsive - cannot stop loading, cannot close window. FORCE QUIT. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:40:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:40:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090823234021.286833545B78@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam at webkit.org --- Comment #3 from Sam Weinig 2009-08-23 16:40:20 PDT --- This does not seem like a Darwin level idea, it is very specific to the Mac. Is this how we have been solving other cases similar to this? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:53:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:53:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090823235305.8424A3545C7A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 --- Comment #4 from Robert Sesek 2009-08-23 16:53:05 PDT --- We use at the top of the file: #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)) I spoke to Jeremy about hit and he thought we could reduce it to just PLATFORM(DARWIN). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:59:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:59:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090823235915.9D1693545CFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 Cameron McCormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38461| |review? Flag| | --- Comment #2 from Cameron McCormack 2009-08-23 16:59:15 PDT --- Created an attachment (id=38461) --> (https://bugs.webkit.org/attachment.cgi?id=38461) Patch to make these two scripts executable I manually typed in the ChangeLog entry, since prepare-ChangeLog wasn't being cooperative. Hopefully I got the format right. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 17:12:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 17:12:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] New: Modifying doesn't clear the corresponding SVGAnimatedNumberList Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28673 Summary: Modifying doesn't clear the corresponding SVGAnimatedNumberList Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: SVG AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cam at mcc.id.au When script modifies the rotate="" attribute on a (or , etc.) element, the baseVal of the SVGAnimatedNumberList that corresponds to the attribute is not cleared before the attribute is re-parsed. E.g.: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 17:24:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 17:24:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824002428.EAC253545EEE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 Cameron McCormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38462| |review? Flag| | --- Comment #1 from Cameron McCormack 2009-08-23 17:24:28 PDT --- Created an attachment (id=38462) --> (https://bugs.webkit.org/attachment.cgi?id=38462) Fix and test -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 17:43:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 17:43:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20726] File upload failing to set Content-Type: application/octet-stream In-Reply-To: References: Message-ID: <20090824004304.160C935460C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20726 Cuchaz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cuchaz at gmail.com --- Comment #2 from Cuchaz 2009-08-23 17:43:03 PDT --- This is also a problem in Google Chrome for linux, so it might not be a windows-only issue. On the server side, Struts2 thinks the content-type is null for such files. I'm not sure what headers are actually being sent. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 18:34:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 18:34:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28607] Body background color isn't drawn at bottom of page In-Reply-To: References: Message-ID: <20090824013407.F14CD35467A5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28607 Gustaaf Groenendaal (MysteryQuest) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |webkit at mysteryquest.org Ever Confirmed|0 |1 --- Comment #3 from Gustaaf Groenendaal (MysteryQuest) 2009-08-23 18:34:07 PDT --- Experiencing the same problem with one of my own projects. The bug seems to occur most of the time when the site is not cached and not in history, but that may also every. This bug might be completely random however. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 18:50:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 18:50:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090824015043.88B0935468D8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35087|0 |1 is obsolete| | Attachment #38463| |review? Flag| | --- Comment #20 from TAMURA, Kent 2009-08-23 18:50:42 PDT --- Created an attachment (id=38463) --> (https://bugs.webkit.org/attachment.cgi?id=38463) Proposed patch (rev.6) > You'll see from the log that trunk/WebCore/html/HTMLInputElement.idl has a tab > in it, which caused the svn pre-commit hook to fail. Oh, I'm sorry for that. I have updated the patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 19:50:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 19:50:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824025010.54FAD3546E2D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35185|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 19:50:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 19:50:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824025015.36DBC3546E48@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38464| |review? Flag| | --- Comment #15 from Fumitoshi Ukai 2009-08-23 19:50:14 PDT --- Created an attachment (id=38464) --> (https://bugs.webkit.org/attachment.cgi?id=38464) Add SocketStreamHandle interface --- 14 files changed, 839 insertions(+), 0 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 19:52:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 19:52:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090824025259.464C83546EA4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34548|review- | Flag| | Attachment #34548|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 19:53:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 19:53:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090824025303.7D17F3546EB8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38465| |review? Flag| | --- Comment #6 from Fumitoshi Ukai 2009-08-23 19:53:03 PDT --- Created an attachment (id=38465) --> (https://bugs.webkit.org/attachment.cgi?id=38465) WebSocket API implementation. depends on bug 28037 --- 17 files changed, 1276 insertions(+), 78 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 21:15:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 21:15:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28440] background-size: X treated as background-size: X X, not background-size: X auto In-Reply-To: References: Message-ID: <20090824041547.C96113547577@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28440 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com, | |hyatt at apple.com, | |mitz at webkit.org --- Comment #1 from mitz at webkit.org 2009-08-23 21:15:47 PDT --- The draft does say ?If only one value is given the second is assumed to be ?auto??, but this sort of behavior doesn?t make much sense to me, especially given the behavior of background-repeat and the 4-value (top-right-bottom-left) properties, where missing values are filled in with specified values. If the spec isn?t going to change, we will need to fix this bug, but we will also have to undo the aliasing of -webkit-background-size to background-size and have the former maintain the current parsing. We also need to decide what to do about -webkit-mask-size. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:13:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:13:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824051324.0B8183547A38@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 --- Comment #5 from Darin Adler 2009-08-23 22:13:23 PDT --- (In reply to comment #4) > We use at the top of the file: > > #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)) > > I spoke to Jeremy about hit and he thought we could reduce it to just > PLATFORM(DARWIN). Mechanically that's OK, but it's not exactly the right concept. PLATFORM(DARWIN) is really supposed to be an OS-level switch like PLATFORM(WINOS) that tells you what low level OS is on the target machine. PLATFORM(DARWIN) means Apple's Unix variant with things like frameworks and certain libraries expected to be installed. This seems to be more about which style of user interface we want. Chromium creates a non-Mac platform that wants to follow Mac user interface style because while it's virtual it is on a Mac. To make that clear I think we'll probably need a different macro in the long run. Short run, we might be OK saying PLATFORM(DARWIN) here unless there's some other port running with PLATFORM(DARWIN) defined that doesn't want this behavior. For example, it's not too farfetched to imagine trouble if you were compiling for QT or GTK on a Mac. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:13:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:13:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824051347.04ADA3547A4E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38461|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:14:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:14:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824051419.256083547A5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #3 from Darin Adler 2009-08-23 22:14:18 PDT --- (In reply to comment #1) > prepare-ChangeLog doesn't work if the only changes I've made are to > properties Right, it doesn't consider property changes as something it should list in the change log. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:18:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:18:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824051844.2FC7C3547ACC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 --- Comment #4 from Cameron McCormack 2009-08-23 22:18:43 PDT --- (In reply to comment #3) > Right, it doesn't consider property changes as something it should list in the > change log. Should it? It might make generating patches like this one easier if prepare-ChangeLog could be used. If so, I can file a bug and supply a patch for prepare-ChangeLog if you like. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:20:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:20:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824052052.A18693547AF4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38462|review? |review+ Flag| | --- Comment #2 from Darin Adler 2009-08-23 22:20:52 PDT --- (From update of attachment 38462) > + * svg/dom/resources/text-rotate-live.js: Added. > + (getRotate): > + (getAndSetRotate): If you're not commenting on these functions individually and the file is new, then there's no need to leave this list of functions in the change log. The idea of prepare-ChangeLog is that it helps you write the ChangeLog entry, not that you should use that it generates as-is. The test code doesn't follow our usual brace style. Open braces for functions go on their own lines. Single line for loop bodies don't get braces around them. I would have put the "var" for the "i" variable inside the for loop. I believe the function results could be arrays rather than strings -- the shouldBe macro knows how to check arrays for equality. We don't use "get" in the names of functions that simply return results. None of these are significant issues, r=me on this patch as it is. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:23:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:23:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824052354.6AFF23547B3A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 --- Comment #5 from Darin Adler 2009-08-23 22:23:54 PDT --- (In reply to comment #4) > (In reply to comment #3) > > Right, it doesn't consider property changes as something it should list in the > > change log. > > Should it? It might make generating patches like this one easier if > prepare-ChangeLog could be used. If so, I can file a bug and supply a patch > for prepare-ChangeLog if you like. Sure, it would be OK. As with newly-added files we could consider pre-adding a comment to the generated file to say what the change is. For example, changing the state of the executable flag is one of the most common changes and it would be good to do it automatically. On the flip side, when changing flags on tons of files, having a list of the files with flags changed is probably not helpful in the way that listing files with contents changed is in typical patches. I have a slight fear that we'll have change log entries that are largely vacuous. Contributors don't seem to treat the change log as a communication tool as much as I'd like; those lists of files and functions are supposed to be for human consumption, and folks should read them and change anything that does not seem helpful. But yes, that would be a nice thing to fix. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:30:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:30:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824053010.BFC5F3547BC9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 --- Comment #3 from Cameron McCormack 2009-08-23 22:30:10 PDT --- (In reply to comment #2) > If you're not commenting on these functions individually and the file is new, > then there's no need to leave this list of functions in the change log. The > idea of prepare-ChangeLog is that it helps you write the ChangeLog entry, not > that you should use that it generates as-is. I will keep that in mind for future patches. > The test code doesn't follow our usual brace style. OK. I see there's no mention of JS style in http://webkit.org/coding/coding-style.html but I'll admit I didn't check it before writing the code. > Open braces for functions > go on their own lines. Single line for loop bodies don't get braces around > them. I would have put the "var" for the "i" variable inside the for loop. I used to too, but now tend to put vars at the top of functions to emphasise that their scope is indeed the whole function and not just the loop. > I believe the function results could be arrays rather than strings -- the > shouldBe macro knows how to check arrays for equality. Acknowledged. I didn't look up shouldBe to see exactly what it was checking; I just copied another test that was doing string comparisons and thought that it was just safer to do that. > We don't use "get" in the names of functions that simply return results. I guess that's Java style rubbing off on me. :) > None of these are significant issues, r=me on this patch as it is. Thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:31:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:31:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24300] Add CSSKeepVisitedLinksPrivate option to WebCore In-Reply-To: References: Message-ID: <20090824053138.A92373547BFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24300 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tkent at chromium.org --- Comment #29 from TAMURA, Kent 2009-08-23 22:31:38 PDT --- FYI: a similar bug entry for Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=147777 They have discussed this issue for 7 years. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:33:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:33:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28674] New: background-size fails to parse if a single length/percentage/auto is followed by a comma Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28674 Summary: background-size fails to parse if a single length/percentage/auto is followed by a comma Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mitz at webkit.org WebKit successfully parses ?background-size: 100px;", but fails to parse ?background-size: 100px, 200px 300px;?. The comma confuses parseFillSize(). Patch forthcoming. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:40:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:40:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28674] background-size fails to parse if a single length/percentage/auto is followed by a comma In-Reply-To: References: Message-ID: <20090824054008.429E13547CE0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28674 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38466| |review? Flag| | --- Comment #1 from mitz at webkit.org 2009-08-23 22:40:07 PDT --- Created an attachment (id=38466) --> (https://bugs.webkit.org/attachment.cgi?id=38466) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:40:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:40:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824054036.8170E3547D0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34534|0 |1 is obsolete| | Attachment #38467| |review? Flag| | --- Comment #16 from TAMURA, Kent 2009-08-23 22:40:35 PDT --- Created an attachment (id=38467) --> (https://bugs.webkit.org/attachment.cgi?id=38467) Proposed patch (rev.5) Updated test cases. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:46:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:46:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824054624.ED4CB3547DB0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38467|review? | Flag| | Attachment #38467|0 |1 is obsolete| | Attachment #38468| |review? Flag| | --- Comment #17 from TAMURA, Kent 2009-08-23 22:46:24 PDT --- Created an attachment (id=38468) --> (https://bugs.webkit.org/attachment.cgi?id=38468) Proposed patch (rev.6) Oops, I found LayoutTests/ChangeLog in the rev.5 was incomplete. Corrected it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:49:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:49:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824054919.120943547E12@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 --- Comment #18 from TAMURA, Kent 2009-08-23 22:49:18 PDT --- (In reply to comment #13) > I'm going to approve this as is. I would like you to consider a follow-up > patch to share more of this code. Sure. I'll try it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 23:00:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 23:00:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28293] [Chromium] event.datatransfer.getdata("text/uri-list") treated the same as getdata("URL") In-Reply-To: References: Message-ID: <20090824060024.668BA3547F0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28293 Roland Steiner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34819|0 |1 is obsolete| | Attachment #38469| |review? Flag| | --- Comment #3 from Roland Steiner 2009-08-23 23:00:23 PDT --- Created an attachment (id=38469) --> (https://bugs.webkit.org/attachment.cgi?id=38469) patch: handle "text/uri-list" (Windows only atm), updated Changed patch according to review notes. Also removed a superfluous #include. Note on layout tests: I actually wrote a test for the functionality that works fine on Safari Mac, but haven't included it here since Chromium doesn't (yet) support the necessary interfaces (and it felt strange to include a layout test and immediately disable it for the platform for which one submits the patch). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 23:37:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 23:37:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 5863] feMorphology filter is not implemented In-Reply-To: References: Message-ID: <20090824063714.8984D3548273@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=5863 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38470| |review? Flag| | --- Comment #1 from Dirk Schulze 2009-08-23 23:37:14 PDT --- Created an attachment (id=38470) --> (https://bugs.webkit.org/attachment.cgi?id=38470) feMorphologyElement Added feMorphologyElement as preparation for FEMorphology filter effect. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:12:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:12:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090824071224.5060A354860F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Xan Lopez 2009-08-24 00:12:23 PDT --- (In reply to comment #4) > (In reply to comment #3) > > Thanks, committed as r47687 with those changes. > > This changed introduced a regression in the following test: > editing/execCommand/toggle-compound-styles.html -> failed > > The change in http://trac.webkit.org/changeset/46920 might be helpful. I guess > we need to rebaseline the test to match mac? Yeah, I just did this and the bot is green again, thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:16:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:16:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090824071628.96E8B354869D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38465|review? | Flag| | Attachment #38465|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:16:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:16:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090824071633.4237235486AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38471| |review? Flag| | --- Comment #7 from Fumitoshi Ukai 2009-08-24 00:16:32 PDT --- Created an attachment (id=38471) --> (https://bugs.webkit.org/attachment.cgi?id=38471) WebSocket API implementation. depends on bug 28037 --- 16 files changed, 1278 insertions(+), 78 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:23:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:23:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28675] New: Make prepare-ChangeLog notice property changes Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28675 Summary: Make prepare-ChangeLog notice property changes Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cam at mcc.id.au It would be good if prepare-ChangeLog would not bail if only properties have been modified. It would be handy too if the property changes are noticed and included in the ChangeLog entry. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:36:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:36:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28675] Make prepare-ChangeLog notice property changes In-Reply-To: References: Message-ID: <20090824073632.3EDAA354893F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28675 --- Comment #1 from Cameron McCormack 2009-08-24 00:36:31 PDT --- Created an attachment (id=38472) --> (https://bugs.webkit.org/attachment.cgi?id=38472) Make prepare-ChangeLog work as described This causes prepare-ChangeLog to add ChangeLog entries like this: * path/to/file: Added xxx property. * path/to/file: Modified xxx property. * path/to/file: Removed xxx property. if one property was changed on the file, and: * path/to/file: Changed properties. if more than one property was changed. These descriptions are only inserted if there is no change to the file contents itself. Also, now if the only changes to the repository are property changes, a ChangeLog entry will still be prepared, whereas currently it will bail and say "No changes found". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:37:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:37:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28675] Make prepare-ChangeLog notice property changes In-Reply-To: References: Message-ID: <20090824073718.BAC59354895B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28675 Cameron McCormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38472| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:38:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:38:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824073848.2B9363548979@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 --- Comment #6 from Cameron McCormack 2009-08-24 00:38:47 PDT --- (In reply to comment #5) > As with newly-added files we could consider pre-adding a comment to the > generated file to say what the change is. For example, changing the state of > the executable flag is one of the most common changes and it would be good to > do it automatically. > > On the flip side, when changing flags on tons of files, having a list of the > files with flags changed is probably not helpful in the way that listing files > with contents changed is in typical patches. I have a slight fear that we'll > have change log entries that are largely vacuous. Contributors don't seem to > treat the change log as a communication tool as much as I'd like; those lists > of files and functions are supposed to be for human consumption, and folks > should read them and change anything that does not seem helpful. > > But yes, that would be a nice thing to fix. Filed https://bugs.webkit.org/show_bug.cgi?id=28675 for this. Agreed with the chance for creating large, useless ChangeLog entries, but hopefully contributors will use common sense and pare them down if necessary. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:42:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:42:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28675] Make prepare-ChangeLog notice property changes In-Reply-To: References: Message-ID: <20090824074245.8949D35489D7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28675 --- Comment #2 from Cameron McCormack 2009-08-24 00:42:45 PDT --- BTW I haven't tested this on a git checkout, where there should be no change in behaviour, since git doesn't have properties. A small additional note: older versions of svn have output like this: Property changes on: blah ----------------------------- Name: svn:executable + * where it doesn't explicitly note if the property was added/modified/deleted. The patch here falls back in this case to the description "Changed properties". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 01:15:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 01:15:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824081545.9ADDF3548CED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38468|review? |review+, commit-queue+ Flag| | --- Comment #19 from Eric Seidel 2009-08-24 01:15:44 PDT --- (From update of attachment 38468) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 01:28:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 01:28:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824082859.3BAD43548E4A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38468|review+, commit-queue+ | Flag| | --- Comment #20 from Eric Seidel 2009-08-24 01:28:58 PDT --- (From update of attachment 38468) Clearing flags on attachment: 38468 Committed r47702: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 01:29:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 01:29:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824082902.C278E3548E6C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #21 from Eric Seidel 2009-08-24 01:29:01 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 01:29:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 01:29:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090824082903.8B70A3548E88@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Bug 19264 depends on bug 21248, which changed state. Bug 21248 Summary: Support placeholder on textarea https://bugs.webkit.org/show_bug.cgi?id=21248 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 02:10:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 02:10:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28676] New: Safari 4 not releasing memory back to the operating system Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28676 Summary: Safari 4 not releasing memory back to the operating system Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://farm3.static.flickr.com/2552/3851167461_d56de44 d47_o.png OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jaffathecake at gmail.com Once Safari has claimed memory from the operating system, it doesn't seem to give it back, even though it's no longer using it. Running the first test on the following page http://www.jakearchibald.co.uk/jsperformance/closurememory/1.html, this creates a 1mb string every second. http://www.flickr.com/photos/jaffathecake/3851167461/sizes/o/ Chrome (and other browsers) release the memory back to the operating system when the test is ended, whereas Safari keeps it, even if the tab is closed. Safari will reuse the memory it has reserved, but it doesn't give it back to the operating system, even if it has claimed 700mb+. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 02:35:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 02:35:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28676] Safari 4 not releasing memory back to the operating system In-Reply-To: References: Message-ID: <20090824093554.CE3693549452@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28676 Jake Archibald changed: What |Removed |Added ---------------------------------------------------------------------------- Component|JavaScriptCore |New Bugs --- Comment #1 from Jake Archibald 2009-08-24 02:35:54 PDT --- This is an issue in 526 (not tested the nightly builds) but the option wasn't available. Not sure which component this should be part of either. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 02:37:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 02:37:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 5863] feMorphology filter is not implemented In-Reply-To: References: Message-ID: <20090824093751.2565F3549485@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=5863 --- Comment #2 from Dirk Schulze 2009-08-24 02:37:50 PDT --- Created an attachment (id=38473) --> (https://bugs.webkit.org/attachment.cgi?id=38473) feMorphology filter effect This is the filter effect feMorphology. I hope that I can make the algorithm more efficient. So this is just for testing atm. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 03:10:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 03:10:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28408] WebInspector: Migrate call frames interaction to the InjectedScript-based schema. In-Reply-To: References: Message-ID: <20090824101003.681553549781@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28408 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #2 from Pavel Feldman 2009-08-24 03:10:02 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/CallStackSidebarPane.js M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/DOMAgent.js M WebCore/inspector/front-end/ElementsPanel.js M WebCore/inspector/front-end/InjectedScript.js M WebCore/inspector/front-end/ObjectPropertiesSection.js M WebCore/inspector/front-end/ObjectProxy.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/ScopeChainSidebarPane.js M WebCore/inspector/front-end/ScriptsPanel.js Committed r47703 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 03:19:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 03:19:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090824101937.ADA603549869@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38455|0 |1 is obsolete| | Attachment #38474| |review? Flag| | --- Comment #20 from Zan Dobersek 2009-08-24 03:19:37 PDT --- Created an attachment (id=38474) --> (https://bugs.webkit.org/attachment.cgi?id=38474) Implementations, modifications, improvements. Basically the last WIP patch with ChangeLogs, an early return used in MediaPlayerPrivate::currentTime() and audio sink creation and application to the playbin removed, as recommended by kov. Also puts some style back to the media section of the Skipped list (was a mess in WIP patch). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 03:25:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 03:25:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28677] New: Allow excluding certain plugins from loading Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28677 Summary: Allow excluding certain plugins from loading Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Enhancement Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: damarvy at gmail.com Marius Renn changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38475| |review? Flag| | Created an attachment (id=38475) --> (https://bugs.webkit.org/attachment.cgi?id=38475) Proposed patch to implement the plugin loading delegation described in the feature request. (Note, this is a re-post as the original got lost in a bugzilla crash). It is well-known that plugins can cause problems, in the worst case leading to a crash. Unfortunately, this can happen as early as plugin-loading, as code may be executed on the plugin during this stage. One way this can be worked around is by using the recently introduced patch to change the plugin directory. However, in some applications it may not be desirable to switch to a different directory. Instead, a client may wish to filter the list of plugins to load. Therefore I propose adding a client callback class (or delegate), which allows filtering plugins based on its path or other attributes such as name, version, etc. I have included a proposed patch that implements this functionality, by introducing an abstract base class PluginDatabaseClient with two pure virtual methods shouldLoadPluginAtPath() and shouldLoadPluginPackage(). These are called in sequence, and if any of these return false, the current plugin is not loaded. For instance, if shouldLoadPluginAtPath() returns false, no further inspection of the plugin is performed. Such a client can be set (optionally) by calling setClient() on the PluginDatabase singleton instance. Note, that the instance must be created without populating as the following example shows (where myPluginLoaderClient denote some PluginDatabaseClient implementation): PluginDatabase* db = PluginDatabase::installedPlugins(false); // Do not load plugins db->setClient(myPluginLoaderClient); // Set client instance db->setPluginDirectories(PluginDatabase::defaultPluginDirectories()); db->refresh(); // Load plugins with client in place -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 04:10:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 04:10:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18027] CSS3 Selector Test: combination of hover and multiple chained sibling selector fails in Webkit In-Reply-To: References: Message-ID: <20090824111047.D34283549CA8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18027 Yusuke Sato changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33521|review- | Flag| | Attachment #33521|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 04:10:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 04:10:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18027] CSS3 Selector Test: combination of hover and multiple chained sibling selector fails in Webkit In-Reply-To: References: Message-ID: <20090824111052.70EFC3549CBB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18027 Yusuke Sato changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38476| |review? Flag| | --- Comment #8 from Yusuke Sato 2009-08-24 04:10:52 PDT --- Created an attachment (id=38476) --> (https://bugs.webkit.org/attachment.cgi?id=38476) hover-adjacent-v2 --- 9 files changed, 238 insertions(+), 5 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 04:14:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 04:14:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18027] CSS3 Selector Test: combination of hover and multiple chained sibling selector fails in Webkit In-Reply-To: References: Message-ID: <20090824111436.CE0D73549D0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18027 --- Comment #9 from Yusuke Sato 2009-08-24 04:14:36 PDT --- Thanks for your review! I've attached the v2 patch: - added dumpAsText(). - removed PNGs and its checksums. - fixed indent level. Could you take another look? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:10:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:10:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28340] 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be wrapped In-Reply-To: References: Message-ID: <20090824121035.915D4354A1F7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28340 --- Comment #11 from Pavel Feldman 2009-08-24 05:10:35 PDT --- Created an attachment (id=38477) --> (https://bugs.webkit.org/attachment.cgi?id=38477) MiniBrowser 64-bit -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:18:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:18:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090824121850.98041354A2B7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 Norbert Leser changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34683|review- |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:24:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:24:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28340] 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be wrapped In-Reply-To: References: Message-ID: <20090824122436.528FF354A33F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28340 --- Comment #12 from Pavel Feldman 2009-08-24 05:24:35 PDT --- (In reply to comment #11) > Created an attachment (id=38477) --> (https://bugs.webkit.org/attachment.cgi?id=38477) [details] > MiniBrowser 64-bit I see no problems running MiniBrowser 64-bit. All test cases behave as in Safari 4, I see no assertions triggered. See screenshot attached. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:28:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:28:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824122847.9343D354A39A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 --- Comment #6 from Robert Sesek 2009-08-24 05:28:47 PDT --- (In reply to comment #5) > Mechanically that's OK, but it's not exactly the right concept. > PLATFORM(DARWIN) is really supposed to be an OS-level switch like > PLATFORM(WINOS) that tells you what low level OS is on the target machine. > PLATFORM(DARWIN) means Apple's Unix variant with things like frameworks and > certain libraries expected to be installed. > > This seems to be more about which style of user interface we want. Chromium > creates a non-Mac platform that wants to follow Mac user interface style > because while it's virtual it is on a Mac. > > To make that clear I think we'll probably need a different macro in the long > run. Short run, we might be OK saying PLATFORM(DARWIN) here unless there's some > other port running with PLATFORM(DARWIN) defined that doesn't want this > behavior. For example, it's not too farfetched to imagine trouble if you were > compiling for QT or GTK on a Mac. Then to be on the safe side, I think the answer is to use, like we do earlier in the same file, PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)). >From what I've discovered on mailing lists, PLATFORM(MAC) is used pretty much for Safari on OS X. Perhaps the right answer long-term is to make a PLATFORM(SAFARI) so that PLATFORM(MAC) can be used in instances like this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:34:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:34:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824123400.15D38354A425@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Robert Sesek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38458|review? | Flag| | Attachment #38458|0 |1 is obsolete| | Attachment #38478| |review? Flag| | --- Comment #7 from Robert Sesek 2009-08-24 05:33:59 PDT --- Created an attachment (id=38478) --> (https://bugs.webkit.org/attachment.cgi?id=38478) Adjusted condition per comment 6 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:56:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:56:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25620] REGRESSION (r43007): In MobileMe Calendar, New Event text is displayed offset when it's first created In-Reply-To: References: Message-ID: <20090824125617.7FE62354A601@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25620 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:56:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:56:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20494] REGRESSION: MLB Gameday doesn't load In-Reply-To: References: Message-ID: <20090824125650.7F546354A60B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20494 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:57:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:57:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20966] "New" corner out of place at Apple iTunes overview page In-Reply-To: References: Message-ID: <20090824125751.AA009354A629@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20966 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:57:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:57:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20587] WebKit eats CPU on http://uk.sun.com/tryandbuy/products.jsp In-Reply-To: References: Message-ID: <20090824125755.E6044354A62F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20587 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:58:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:58:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20964] Huge memory usage on Dromaeo test In-Reply-To: References: Message-ID: <20090824125805.DFDF6354A63D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20964 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:58:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:58:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 8753] REGRESSION (r14032): Incorrect and non-uniform text zoom applied after going forward and backward In-Reply-To: References: Message-ID: <20090824125854.8CBDE354A65B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=8753 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:59:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:59:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 9254] Quirksmode: Safari ignores window.close() after form submission In-Reply-To: References: Message-ID: <20090824125908.45C72354A673@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=9254 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 06:57:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 06:57:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28422] Linking fails with "relocation R_X86_64_PC32 against symbol `cti_vm_throw'" In-Reply-To: References: Message-ID: <20090824135749.AB5F1354AF6F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28422 Priit Laes (IRC: plaes) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35026|0 |1 is obsolete| | --- Comment #5 from Priit Laes (IRC: plaes) 2009-08-24 06:57:49 PDT --- Created an attachment (id=38479) --> (https://bugs.webkit.org/attachment.cgi?id=38479) webkit-bug-28422-use-plt-segment-for-cti_vm_throw-v2.patch Added #if PLATFORM(LINUX) guards suggested by bdash. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 07:27:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 07:27:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27211] fastMalloc and fastFree mismatch correction In-Reply-To: References: Message-ID: <20090824142751.8829A354B3CA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27211 Kelemen Bal?zs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Kelemen.Balazs.3 at stud.u-sze | |ged.hu --- Comment #4 from Kelemen Bal?zs 2009-08-24 07:27:51 PDT --- I think there is no problem freeing with fastFree here, since Vector allocates it's storage with fastMalloc. What have I missed? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 07:27:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 07:27:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090824142752.289D4354B3E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38474|review? |review+, commit-queue- Flag| | --- Comment #21 from Gustavo Noronha (kov) 2009-08-24 07:27:51 PDT --- (From update of attachment 38474) > + // Splitting the capability by comma and taking the first part > + // as capability can be something like "audio/x-wavpack, framed=(boolean)false" > + gchar** capability = g_strsplit(gst_caps_to_string(caps), ",", 2); There's a small leak here - gst_caps_to_string returns a string that needs to be freed. I will turn this into a GOwnPtr when landing. Other than that, r=me. I'll land it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 07:31:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 07:31:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090824143148.87D40354B475@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38474|review+, commit-queue- | Flag| | --- Comment #22 from Gustavo Noronha (kov) 2009-08-24 07:31:48 PDT --- (From update of attachment 38474) Landed as r47710. Is there any reason for this bug to remain open, Zan? If you feel not, please close it =). Clearing flags. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 07:56:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 07:56:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090824145615.802AD354B7FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35022|review+, commit-queue- | Flag| | --- Comment #11 from Gustavo Noronha (kov) 2009-08-24 07:56:15 PDT --- (From update of attachment 35022) Landed as r47712. I had overlooked the fact that I could not determine the origin of the .cur file. I replaced the one you provided with a cell.cur from Mozilla sources, that I know is licensed in a good way. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 08:05:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 08:05:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090824150514.68209354B910@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |gns at gnome.org Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 08:39:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 08:39:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28678] New: WebInspector: Only expand local scope when hitting the break Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28678 Summary: WebInspector: Only expand local scope when hitting the break Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pfeldman at chromium.org CC: timothy at hatcher.name Currently all the scopes are being expanded (CallFrame change regression). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 08:41:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 08:41:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28678] WebInspector: Only expand local scope when hitting the break In-Reply-To: References: Message-ID: <20090824154102.73452354BD69@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28678 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38480| |review? Flag| | Status|UNCONFIRMED |ASSIGNED AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | Ever Confirmed|0 |1 --- Comment #1 from Pavel Feldman 2009-08-24 08:41:02 PDT --- Created an attachment (id=38480) --> (https://bugs.webkit.org/attachment.cgi?id=38480) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 09:01:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 09:01:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824160155.F1B2A354C053@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38464|review? |review+ Flag| | --- Comment #16 from Alexey Proskuryakov 2009-08-24 09:01:55 PDT --- (From update of attachment 38464) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 09:13:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 09:13:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28668] [Gtk] Test for HTTP authentication in Application cache fails In-Reply-To: References: Message-ID: <20090824161339.A2E46354C1B0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28668 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 09:15:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 09:15:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28674] background-size fails to parse if a single length/percentage/auto is followed by a comma In-Reply-To: References: Message-ID: <20090824161519.1DD76354C1F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28674 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38466|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 09:27:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 09:27:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28674] background-size fails to parse if a single length/percentage/auto is followed by a comma In-Reply-To: References: Message-ID: <20090824162732.00FF7354C340@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28674 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from mitz at webkit.org 2009-08-24 09:27:31 PDT --- Fixed in . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:18:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:18:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28679] New: Touch and do not play well Product: WebKit Version: 528+ (Nightly build) Platform: S60 Emulator OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: carol.szabo at nokia.com It is impossible to select multiple elements in a multiple selection SELECT element by using only the touch screen (no control or shift keys). Is there support for this on other platforms? Is it acceptable to add a build flag such as USE_TOUCH_UI, that would change the behavior on mouse click of the SELECT element under WebCore/dom/SelectElement? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:27:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:27:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26541] CSS property value serialization order is out of whack In-Reply-To: References: Message-ID: <20090824172709.038BB354CA75@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26541 yaar at google.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38486| |review? Flag| | --- Comment #4 from yaar at google.com 2009-08-24 10:27:08 PDT --- Created an attachment (id=38486) --> (https://bugs.webkit.org/attachment.cgi?id=38486) A Fix Yuta's fix is correct and the layout test is wrong. WebKit implements CSS3's layered backgrounds, as described here: http://www.w3.org/TR/2008/WD-css3-background-20080910/#layering With layers, repeat-x, repeat-y isn't equivalent to repeat. Rather, it means layer 1 should repeat-x and layer 2 should repeat-y. Also, background-image is by default applied to the last layer. Therefore, the style "background-color:white; background-repeat: repeat-x,repeat-y" should inded serialize into: "repeat-x, white repeat-y". The change list includes Yuta's fix as well as the changes to the layout test that broke. p.s. This is my first submission to WebKit. I hope I adhered to all guidelines. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:28:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:28:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 10214] Can't break on funcations that you call from the console In-Reply-To: References: Message-ID: <20090824172828.A1779354CA9F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=10214 Chris Seaton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at chrisseaton.com --- Comment #2 from Chris Seaton 2009-08-24 10:28:28 PDT --- The worst thing about this is that it isn't documented anywhere, unless you looked for this bug report like I did. I was trying out the WebKit debugger and was assuming the breakpoints were just broken. Running a function from the console is an obvious way to test code and to get to breakpoints. I don't think it's a minor bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:33:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:33:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27658] Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects In-Reply-To: References: Message-ID: <20090824173310.10C5C354CB48@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27658 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33476|review? |review- Flag| | --- Comment #4 from David Levin 2009-08-24 10:33:09 PDT --- (From update of attachment 33476) > WebCore/dom/SelectElement.cpp (working copy) > =================================================================== > +// Returns the index of the next valid list item |skip| items past |listIndex| in direction |direction|. This isn't really correct as it could return listIndex or listIndex + 1, etc. even if skip = 10. > +// returns the index of the next valid item one page away from |startIndex| in direction |direction|. (Many instances) Make comments looks like sentences. (Start with a capital and end with a period.) > +int SelectElement::selectableListIndexPageFrom(SelectElementData& data, Element* element, int startIndex, SkipDirection direction) I can't make sense of this function name. It seems like it should stat with "next". Perhaps "nextSelectableListIndexPageAway". Also, after having read through this function it is unclear what it is trying to do and if it is correct. I think it attempts to find a "valid index" that is in this range (startIndex, startIndex + pageSize * direction] but if that fails, it tries to find a valid index (startIndex + pageSize * direction, direction == SkipForwards ? MAXINT : 0], so that's what I'll use as my guide. > + int pageSize = static_cast(element->renderer())->size() - 1; // -1 so we still show context 1 space before end of line comments. > + int index = nextValidIndex(items, indexOnePageAway + oppositeDirection, direction, 1); Relying on the enum value to be -1, +1 seems like a bad practice here. I know that "nextValidIndex" does but ideally it is only relied on there. > + if (index < 0 || index >= listSize ||(!isOptionElement(items[index]) || items[index]->disabled())) { Add a space after || here: "||(!isOptionElement". Unnecessary () around the last two items. At a higher level, this isn't correct because "index" may be valid but not in this range (startIndex, startIndex + pageSize * direction]. Add a test which exposes this issue. > +int SelectElement::firstSelectableListIndex(SelectElementData& data, Element* element) > +{ > + const Vector& items = data.listItems(element); > + int index = 0; > + while (index >= 0 && (unsigned) index < items.size() && (!isOptionElement(items[index]) || items[index]->disabled())) (Multiple places) Use c++ style casts. > void SelectElement::menuListDefaultEventHandler(SelectElementData& data, Element* element, Event* event, HTMLFormElement* htmlForm) > { ... > + if (endIndex >= 0 && Please move the && to the next line. > + (keyIdentifier == "Down" || keyIdentifier == "Up" || keyIdentifier == "Home" > + || keyIdentifier == "End" || keyIdentifier == "PageDown" || keyIdentifier == "PageUp")) { The || should be aligned with the ( from the previous line. > Index: WebCore/dom/SelectElement.h > =================================================================== > + static int selectableListIndexPageFrom(SelectElementData& data, Element* element, int startIndex, SkipDirection direction); Can this be moved out of the class and solely be defined within the SelectElement.cpp file? > Index: LayoutTests/fast/events/select-element.html > =================================================================== > + function log(s) Ideally use whole words for variables: "s" > + function sendKeyAndExpectIndex(selectId, key, initialIndex, expectedIndex) { ... > + if (select.selectedIndex != initialIndex) { > + log("can't set selectedIndex to " + initialIndex + ' (is ' > + + select.selectedIndex + ')'); Would be nice to align with ( > + return false; > + } > + if (window.layoutTestController) > + eventSender.keyDown(key); > + if (select.selectedIndex != expectedIndex) { > + log('selectedIndex should be ' + expectedIndex + ' (is ' + In keeping with the moving the &&, etc to the beginning of the next line, move the + to the next line would be nice. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:33:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:33:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27658] Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects In-Reply-To: References: Message-ID: <20090824173319.EB7F5354CB5D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27658 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |levin at chromium.org Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:42:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:42:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090824174222.80D7B354CC8D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34683|review? |review+ Flag| | --- Comment #8 from Darin Adler 2009-08-24 10:42:22 PDT --- (From update of attachment 34683) Seems fine. Would be better with a brief comment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:49:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:49:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824174948.B2549354CD86@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 --- Comment #8 from Darin Adler 2009-08-24 10:47:37 PDT --- (In reply to comment #6) > From what I've discovered on mailing lists, PLATFORM(MAC) is used pretty much > for Safari on OS X. Perhaps the right answer long-term is to make a > PLATFORM(SAFARI) so that PLATFORM(MAC) can be used in instances like this. This is a great oversimplification and would not be correct. For example, Safari works on Windows. And tons of Mac OS X applications use the PLATFORM(MAC) version of WebKit, not just Safari. PLATFORM(MAC) is about having WebKit on top of Mac OS X frameworks like AppKit. The Chromium port is peculiar because it's WebKit on Mac OS X, but striving to not be on top of something like AppKit because of the particular architecture of the Chrome browser, and instead of being on top of the OS frameworks, it's on top a special Chromium layer. We do have a plan to fix the platform macros and make various more specific names, which should solve this problem. Maciej Stachowiak sent mail to webkit-dev a couple months ago about it. But PLATFORM(SAFARI) would be terrible and a step in the wrong direction! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:52:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:52:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28418] changeVersion() doesn't seem to work In-Reply-To: References: Message-ID: <20090824175258.8CC0B354CDF4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28418 Andrew Grieve changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agrieve at google.com --- Comment #1 from Andrew Grieve 2009-08-24 10:52:58 PDT --- Not sure how to mark it as such, but looks to be a dupe of https://bugs.webkit.org/show_bug.cgi?id=27836 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:53:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:53:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27836] Stale database version persists through browser refresh In-Reply-To: References: Message-ID: <20090824175332.40DB8354CE1B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27836 Andrew Grieve changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agrieve at google.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:55:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:55:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27211] fastMalloc and fastFree mismatch correction In-Reply-To: References: Message-ID: <20090824175542.18CBB354CE6A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27211 --- Comment #5 from Darin Adler 2009-08-24 10:55:41 PDT --- (In reply to comment #4) > I think there is no problem freeing with fastFree here, since Vector allocates > it's storage with fastMalloc. What have I missed? How Vector allocates its storage is irrelevant, since is not the vector storage being freed. The vector storage is a pointer in selectorVector.m_buffer.m_buffer. What's being freed here is selectorVector[i]. If you trace the flow of the code back you'll see that it's a CSSSelector object that was allocated by the CSSParser::createFloatingSelector function. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:59:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:59:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28632] Unable to drag Keepvid.com bookmarklet (to bookmarks bar) In-Reply-To: References: Message-ID: <20090824175905.C1D38354CEEC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28632 Victor Wang changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victorw at chromium.org --- Comment #1 from Victor Wang 2009-08-24 10:59:04 PDT --- The reason why this bookmark can't be dragged is because it has child node. The current webkit code does not allow a node to be dragged if it has child node: bool EventHandler::shouldDragAutoNode(Node* node, const IntPoint& point) const { if (!node || node->hasChildNodes() || !m_frame->view()) return false; ... } -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:01:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:01:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090824180128.B61B5354CF4F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38471|review? |review- Flag| | --- Comment #8 from Alexey Proskuryakov 2009-08-24 11:01:28 PDT --- (From update of attachment 38471) +static bool IsValidProtocolString(const WebCore::String& protocol) Function names should start with lowercase letters. + if (!protocol.isEmpty() && !IsValidProtocolString(protocol)) { Would it make sense to move isEmpty() check to the helper function? +WebSocketChannel::WebSocketChannel(ScriptExecutionContext* context, WebSocketChannelClient* client, const KURL& url, const String& protocol) + : m_context(context) + , m_client(client) + , m_handshaker(WebSocketHandshaker(url, protocol, context)) + , m_buffer(0) + , m_buffer_size(0) Please use 4 spaces for indentation. + static const char frame_type[1] = {'\0'}; + static const char frame_end[1] = {'\xff'}; No need to have these static arrays - there's a version of Vector::append that takes const U&. + virtual void didReceivedData(SocketStreamHandle*, const char*, int); Typo: should be didReceiveData. + ASSERT(handle == m_handle.get() || !m_handle.get()); What are the situations when callbacks are called with null m_handle? Is it normal, or could it indicate problems? + KURL url(location); + m_handshaker.setURL(url); I'd write this in one line. +void WebSocketChannel::authenticate(const String& www_authenticate) This will break the build, because www_authenticate is unused. Also, this is wrong style, we use camelCase, not underlines for function and variable names. Please grep your patch with some expression like "[a-ln-z]_" to catch all cases, I won't point out each of them, as there are too many. +#include "WebSocketHandshaker.h" I had to google "handshaker", and although it's a word indeed, it seems to have too many unrelated meanings :). I think that "WebSocketHandshake" would be just fine. +#include "StringBuilder.h" + +#include No need for an empty line here. + return WebCore::String(); This code is already in WebCore namespace, no need for the prefix. Same issue below. +bool WebSocketHandshaker::headerProcess(const HTTPHeaderMap& headers) Maybe this should be processHeader()? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:11:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:11:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824181102.0065E354D09E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.fraser at apple.com --- Comment #22 from Simon Fraser (smfr) 2009-08-24 11:11:01 PDT --- 4 textarea tests are still failing after this change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:12:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:12:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28623] svn-[un]apply should change directories to the repository root before [un]applying In-Reply-To: References: Message-ID: <20090824181237.1FE1E354D0E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28623 --- Comment #9 from Geoffrey Garen 2009-08-24 11:12:36 PDT --- Hi Joseph. Thanks for looking into this! It looks like the use of VCSUtils is incompatible with my system: ~/webkit/WebKitTools/mangleme$ svn-create-patch > ro.txt ? ro.txt ~/webkit/WebKitTools/mangleme$ svn-unapply !$ svn-unapply ro.txt Can't locate VCSUtils.pm in @INC (@INC contains: /Library/Perl/Updates/5.10.0 /System/Library/Perl/5.10.0/darwin-thread-multi-2level /System/Library/Perl/5.10.0 /Library/Perl/5.10.0/darwin-thread-multi-2level /Library/Perl/5.10.0 /Network/Library/Perl/5.10.0/darwin-thread-multi-2level /Network/Library/Perl/5.10.0 /Network/Library/Perl /System/Library/Perl/Extras/5.10.0/darwin-thread-multi-2level /System/Library/Perl/Extras/5.10.0 .) at /Users/ggaren/webkit/WebKitTools/Scripts/svn-unapply line 67. BEGIN failed--compilation aborted at /Users/ggaren/webkit/WebKitTools/Scripts/svn-unapply line 67. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:15:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:15:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090824181534.43166354D149@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #12 from Eric Seidel 2009-08-24 11:15:33 PDT --- Sadly svn-apply can't handle git binary patches: patch: **** Only garbage was found in the patch input. patch -p0 "WebCore/manual-tests/gtk/resources/redcursor.cur" returned 2. Pass --force to ignore patch failures. Logging in as eric at webkit.org... Rejecting patch 35022 from commit-queue. This patch will require manual commit. bug 26830. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:15:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:15:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28623] svn-[un]apply should change directories to the repository root before [un]applying In-Reply-To: References: Message-ID: <20090824181552.D87AB354D170@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28623 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38399|review? |review- Flag| | --- Comment #10 from Geoffrey Garen 2009-08-24 11:15:52 PDT --- (From update of attachment 38399) I guess I'll r- this for now to remove it from the queue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:25:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:25:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824182523.198FA354D2CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38462| |commit-queue+ Flag| | --- Comment #4 from Eric Seidel 2009-08-24 11:25:22 PDT --- (From update of attachment 38462) Looks good to me too. I wonder if other "parse" implementations are missing a clear() call. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:26:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:26:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824182620.371DD354D2FB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38461| |commit-queue- Flag| | --- Comment #7 from Eric Seidel 2009-08-24 11:26:19 PDT --- (From update of attachment 38461) Since the commit-queue is currently running from a git checkout, it won't be able to handle this. Someone will have to land this manually. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:26:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:26:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824182656.02851354D324@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38464| |commit-queue+ Flag| | --- Comment #17 from Eric Seidel 2009-08-24 11:26:55 PDT --- (From update of attachment 38464) Fumitoshi doesn't have commit bit, so marking cq+ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:28:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:28:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090824182813.3ABE6354D372@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34683|review+ |review- Flag| | --- Comment #9 from Eric Seidel 2009-08-24 11:28:12 PDT --- (From update of attachment 34683) Norbert isn't a committer, and darin is asking for a comment in the comment above, so marking this r- since no one can land this as is. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:35:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:35:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824183528.F18CB354D465@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38462|review+, commit-queue+ | Flag| | --- Comment #5 from Eric Seidel 2009-08-24 11:35:28 PDT --- (From update of attachment 38462) Clearing flags on attachment: 38462 Committed r47720: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:35:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:35:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824183531.4F6ED354D471@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #6 from Eric Seidel 2009-08-24 11:35:30 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:36:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:36:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824183618.EE86D354D48F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38464|commit-queue+ |commit-queue- Flag| | --- Comment #18 from Eric Seidel 2009-08-24 11:36:18 PDT --- (From update of attachment 38464) Rejecting patch 38464 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/build-webkit failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:39:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:39:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824183919.993B5354D51D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 --- Comment #9 from Jeremy Moskovich 2009-08-24 11:39:19 PDT --- Robert: The discussion of the right macros to use for cases like this seems to come up every time we need some code to be used on both Chrome/OS X & Safari since the current situation is sub-optimal. I think in the long term we need to fix this but I think the discussion of what that solution is belongs in a separate bug or on webkit-dev. Per-Darin's comment could you resubmit your first patch and use PLATFORM(DARWIN). Sam: Up till now we've resolved these issues by changing these to PLATFORM(DARWIN). Darin & Sam: Thanks for your comments, I don't want to sound like we don't care about doing the right thing for this, we most certain do want a good long term solution here! But as mentioned above, I think we should discuss this in another scope. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:39:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:39:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28623] svn-[un]apply should change directories to the repository root before [un]applying In-Reply-To: References: Message-ID: <20090824183923.9247D354D533@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28623 --- Comment #11 from Eric Seidel 2009-08-24 11:39:23 PDT --- This patch is missing the Find::Bin trick: use FindBin; use lib $FindBin::Bin; Will make it possible to include perl modules form the same directory. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:40:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:40:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824184028.BD933354D57F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 --- Comment #23 from Eric Seidel 2009-08-24 11:40:28 PDT --- (In reply to comment #22) > 4 textarea tests are still failing after this change. On what platform? I assume windows since mac is green. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:41:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:41:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824184155.45154354D5CE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 --- Comment #24 from Eric Seidel 2009-08-24 11:41:54 PDT --- http://build.webkit.org/results/Windows%20Release%20(Tests)/r47719%20(3707)/results.html Looks like windows will need new baselines or these tests will need to be converted not to be render tree dumps. tkent could do the test conversion, or we can just land the windows results from the bots. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:44:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:44:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824184428.85101354D613@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #19 from Eric Seidel 2009-08-24 11:44:28 PDT --- Since this fails release build on the Mac, the patch will likely need more modification. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:46:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:46:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824184622.3769A354D659@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 --- Comment #25 from Eric Seidel 2009-08-24 11:46:21 PDT --- Will land windows results from the bot, shortly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:54:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:54:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28626] WebKit quits (no crash log) when a link to a MPEG-1 file is clicked on. In-Reply-To: References: Message-ID: <20090824185411.610B6354D795@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28626 --- Comment #2 from Michael Pook 2009-08-24 11:54:10 PDT --- (In reply to comment #1) > I cannot reproduce this with a local debug build of r47661 on Mac OS X 10.5.8 > (Intel). Will upgrading to QuickTime 7.6.2 solve the problem for you? The version of QuickTime is NOT the issue, as both Presto and Gecko based browsers behave normally. I have removed the newer WebKit 530.20 based versions and replaced them with older WebKit 530.19 based versions. These older versions also behave normally. Clearly this issue is with WebKit based browsers using version 530.20 or higher. Perhaps the issue only affects systems running 10.4.11 Tiger (perhaps only on PowerPC machines)? I have verified that this is a problem on my eMac M8950LL/A, my iBook M9848LL/A and on my Mac Mini M9971LL/B. All the above are configured with the same OS and software. I do not own any Intel hardware or 10.5.8 Leopard to verify the issue on. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:56:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:56:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824185614.0483F354D7E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Robert Sesek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38478|review? | Flag| | Attachment #38478|0 |1 is obsolete| | Attachment #38489| |review? Flag| | --- Comment #10 from Robert Sesek 2009-08-24 11:56:13 PDT --- Created an attachment (id=38489) --> (https://bugs.webkit.org/attachment.cgi?id=38489) Using just PLATFORM(DARWIN) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 12:07:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 12:07:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28680] New: WebInspector: Simplify findTreeElement code, get rid of potential infinite loop. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28680 Summary: WebInspector: Simplify findTreeElement code, get rid of potential infinite loop. Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pfeldman at chromium.org CC: timothy at hatcher.name Currently searching for inline node text can lead to infinite loop. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 12:09:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 12:09:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28680] WebInspector: Simplify findTreeElement code, get rid of potential infinite loop. In-Reply-To: References: Message-ID: <20090824190926.B217A354D995@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28680 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38490| |review? Flag| | Status|UNCONFIRMED |ASSIGNED AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | Ever Confirmed|0 |1 --- Comment #1 from Pavel Feldman 2009-08-24 12:09:26 PDT --- Created an attachment (id=38490) --> (https://bugs.webkit.org/attachment.cgi?id=38490) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 12:10:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 12:10:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824191025.26D83354D9D7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 --- Comment #26 from Eric Seidel 2009-08-24 12:10:24 PDT --- Committed r47721: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 12:18:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 12:18:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28679] Touch and tag), but how about the text display directionality? Should it be >different from autofill popup? I was making that point because the code for the popup is shared by the autofill and should not trim initial value to maxLength Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28001 Summary: should not trim initial value to maxLength Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://software.hixie.ch/utilities/js/live-dom-viewer/ saved/190 OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pkasting at google.com Blocks: 27454 In WebKit, displays a textfield containing "foo". In Firefox, IE, and Opera, it displays "foobar". We should match this. (Testcase at the URL above.) This probably also applies to values set by scripting the DOM. When the value is longer than maxLength, and the user attempts to modify the value in place, IE and Firefox apply the following algorithm: * Delete the selected character(s) * If the value is now shorter than maxLength, insert characters from the user's attempted insertion value, stopping when the length of the element's value equals maxLength. Opera is stranger; its first step is: * If deleting the selected character(s) will not make the resulting value shorter than maxLength, abort without doing anything; otherwise, delete the selected character(s) and proceed. As a result, when the element contains "foobar" with maxLength 3, and the clipboard contains "zyx": * On IE and Firefox, selecting "r" and typing a key or pasting will delete "r". On Opera, this will do nothing. * On IE and Firefox, selecting "foo" and typing a key or pasting will delete "foo". On Opera, this will do nothing. * On all three browsers, selecting "ooba" and pasting will result in "fzr". I think the IE and Firefox behavior, while at first stranger, is more consistent. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:22:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:22:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27988] word-spacing style seems not to be honored In-Reply-To: References: Message-ID: <20090804222205.A85E1345E9B3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27988 --- Comment #1 from Mark Rowe (bdash) 2009-08-04 15:22:05 PDT --- With which port of WebKit? The page renders as expected on Mac OS X. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:22:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:22:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28001] should not trim initial value to maxLength In-Reply-To: References: Message-ID: <20090804222230.8DCC0345E9C9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28001 --- Comment #1 from Peter Kasting 2009-08-04 15:22:30 PDT --- Note: WebKit already does the second step above, where it pastes in as much as will fit. To see this, visit the example URL, select one character of "foo", and try pasting "maxLength". You'll see the selected character replaced by "m". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:25:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:25:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] New: Add pkasting to bugzilla-tool as a committer Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28002 Summary: Add pkasting to bugzilla-tool as a committer Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abarth at webkit.org CC: eric at webkit.org, pkasting at google.com Peter asked to be added to the bugzilla-tool list of committers. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:28:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:28:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804222825.043C0345EA5D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34093| |review? Flag| | --- Comment #1 from Adam Barth 2009-08-04 15:28:24 PDT --- Created an attachment (id=34093) --> (https://bugs.webkit.org/attachment.cgi?id=34093) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:30:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:30:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090804223040.3A72C345EA89@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34088|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:31:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:31:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804223114.529CC345EAAD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34093|review? |review+ Flag| | --- Comment #2 from Darin Adler 2009-08-04 15:31:13 PDT --- (From update of attachment 34093) Does this kind of change need review? r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:33:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:33:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804223359.58C5F345EAEB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34093| |commit-queue+ Flag| | --- Comment #3 from Adam Barth 2009-08-04 15:33:58 PDT --- (From update of attachment 34093) Not sure. I can make these changes unreviewed in the future if you like. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:36:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:36:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23993] Underline formatting bleeds into other formatting during delete/backspace In-Reply-To: References: Message-ID: <20090804223631.1E505345EB65@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23993 --- Comment #7 from Ryosuke Niwa 2009-08-04 15:36:29 PDT --- Around the line 865, we have insertNodeAtAndUpdateNodesInserted(refNode, insertionPos); And refNode->showTreeForThis() results in: SPAN 0x1af7ee50 CLASS=Apple-style-span STYLE=border-collapse: separate; color: rgb(0, 0, 0); font-family: Times; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; #text 0x1af7f170 "world" Is it even correct to have "-webkit-text-decoration: none" here? If so, when are you taking care of it? handleStyleSpans? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:42:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:42:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28003] New: Cleanup: ResourceResponse should be a class, not a struct Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28003 Summary: Cleanup: ResourceResponse should be a class, not a struct Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: michaeln at google.com This 'struct' really should be a 'class'. Here's how things are defined for various ports... C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\cf\ResourceRequest.h(37): struct ResourceRequest : ResourceRequestBase { C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\curl\ResourceRequest.h(36): struct ResourceRequest : ResourceRequestBase { C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\qt\ResourceRequest.h(38): struct ResourceRequest : ResourceRequestBase { C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\soup\ResourceRequest.h(36): struct ResourceRequest : ResourceRequestBase { C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\chromium\ResourceRequest.h(38): struct ResourceRequest : public ResourceRequestBase { C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\mac\ResourceRequest.h(41): class ResourceRequest : public ResourceRequestBase { Here's how many of the forward declarations are declared... C:\chrome\1\src\third_party\WebKit\WebCore\history\HistoryItem.h(53):struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\inspector\InspectorController.h(67):struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\inspector\InspectorResource.h(54): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\appcache\ApplicationCache.h(45):struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\appcache\ApplicationCacheHost.h(51): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\DocumentThreadableLoader.h(42): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\FrameLoaderClient.h(65): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\MainResourceLoader.h(43): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\SubresourceLoader.h(36): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\SubresourceLoaderClient.h(36):struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\ThreadableLoader.h(41): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\loader\WorkerThreadableLoader.h(50): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\cf\ResourceRequestCFNet.h(33): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\ResourceHandleClient.h(53): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\platform\network\ResourceRequestBase.h(49): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\platform\CrossThreadCopier.h(44): struct ResourceRequest; C:\chrome\1\src\third_party\WebKit\WebCore\xml\XMLHttpRequest.h(37):struct ResourceRequest; -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:43:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:43:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28001] should not trim initial value to maxLength In-Reply-To: References: Message-ID: <20090804224304.9A46F345EBF8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28001 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |micdesim at gmail.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:46:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:46:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804224635.F2060345EC58@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34091|review+ | Flag| | --- Comment #15 from Adam Barth 2009-08-04 15:46:34 PDT --- (From update of attachment 34091) Clearing review flag on attachment: 34091 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog A WebKitTools/Scripts/run-webkit-unittests Committed r46781 M WebKit/wx/WebKitSupport/InspectorClientWx.cpp M WebKit/wx/WebKitSupport/InspectorClientWx.h M WebKit/wx/ChangeLog r46780 = dc5b52be13b15b6b4e3e9773f1780412f01881f2 (trunk) M WebKitTools/ChangeLog A WebKitTools/Scripts/run-webkit-unittests r46781 = 2282d863ec463529cb2b4182d652cb02ba484a38 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46781 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:46:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:46:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27977] bugzilla-tool unit tests need a test harness In-Reply-To: References: Message-ID: <20090804224640.A0160345EC76@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27977 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #16 from Adam Barth 2009-08-04 15:46:39 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:53:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:53:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26915] [HTML5][Forms] Part 1 of datalist&list: element support In-Reply-To: References: Message-ID: <20090804225321.ECF10345ED2D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26915 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com, | |pkasting at google.com --- Comment #13 from Peter Kasting 2009-08-04 15:53:21 PDT --- dhyatt was working on support, he should be CCed on all bugs about it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:54:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:54:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090804225419.E637E345ED84@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com, | |pkasting at google.com --- Comment #8 from Peter Kasting 2009-08-04 15:54:18 PDT --- dhyatt was working on support, he should be CCed on all bugs about it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:55:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:55:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090804225552.BC21E345EDB4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27756, 27794, 27800 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:55:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:55:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090804225554.1DEE3345EDCA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19264 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:55:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:55:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27794] [HTML5][Forms] Part 3 of datalist&list: Introduce new pseudo selector, new appearance, and new control part for the list attribute support In-Reply-To: References: Message-ID: <20090804225554.9CD08345EDD2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27794 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19264 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:55:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:55:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27800] [HTML5][Forms] Part 4 of datalist&list: Move controlClip from RenderTextControlSingleLine to TextControlElements.cpp In-Reply-To: References: Message-ID: <20090804225554.E8921345EDD8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27800 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19264 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:58:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:58:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090804225826.C97B2345EE20@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC|pkasting at google.com | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:58:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:58:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26915] [HTML5][Forms] Part 1 of datalist&list: element support In-Reply-To: References: Message-ID: <20090804225840.D64A6345EE30@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26915 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC|pkasting at google.com | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:59:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:59:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27794] [HTML5][Forms] Part 3 of datalist&list: Introduce new pseudo selector, new appearance, and new control part for the list attribute support In-Reply-To: References: Message-ID: <20090804225919.AFFC9345EE42@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27794 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com --- Comment #2 from Peter Kasting 2009-08-04 15:59:19 PDT --- dhyatt was working on support, he should be CCed on all bugs about it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:59:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:59:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27800] [HTML5][Forms] Part 4 of datalist&list: Move controlClip from RenderTextControlSingleLine to TextControlElements.cpp In-Reply-To: References: Message-ID: <20090804225927.9FE17345EE52@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27800 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com --- Comment #2 from Peter Kasting 2009-08-04 15:59:27 PDT --- dhyatt was working on support, he should be CCed on all bugs about it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 15:59:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 15:59:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27247] [HTML5][Forms] [HTML5][Forms] Part 5 of datalist&list: UI of `list' attribute of In-Reply-To: References: Message-ID: <20090804225936.A5668345EE66@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27247 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com --- Comment #5 from Peter Kasting 2009-08-04 15:59:35 PDT --- dhyatt was working on support, he should be CCed on all bugs about it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:03:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:03:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27985] ASSERTION FAILED: m_frame->document()->parsing() In-Reply-To: References: Message-ID: <20090804230304.CADC8345EEC0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27985 Antonio Gomes (tonikitoo) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tonikitoo at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:03:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:03:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804230343.8D094345EED6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 --- Comment #4 from Peter Kasting 2009-08-04 16:03:42 PDT --- *** Bug 28000 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:06:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:06:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090804230609.306CB345EF2E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Kevin Ollivier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33374|review? | Flag| | Attachment #33374|0 |1 is obsolete| | Attachment #34096| |review? Flag| | --- Comment #20 from Kevin Ollivier 2009-08-04 16:06:07 PDT --- Created an attachment (id=34096) --> (https://bugs.webkit.org/attachment.cgi?id=34096) Changes to build-webkit needed for wx to use the waf build process - second patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:16:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:16:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27393] Optimize string operations in GraphicsLayerCA In-Reply-To: References: Message-ID: <20090804231643.D97F2345F06D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27393 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #1 from Simon Fraser (smfr) 2009-08-04 16:16:43 PDT --- Fixed via bug 27884. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:20:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:20:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28004] New: [chromium] setting listeners on MessagePorts doesn't work in the worker process Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28004 Summary: [chromium] setting listeners on MessagePorts doesn't work in the worker process Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Platform AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jam at chromium.org Bindings need to be updated. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:24:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:24:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28004] [chromium] setting listeners on MessagePorts doesn't work in the worker process In-Reply-To: References: Message-ID: <20090804232447.72D3A345F13C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28004 John Abd-El-Malek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34098| |review? Flag| | --- Comment #1 from John Abd-El-Malek 2009-08-04 16:24:47 PDT --- Created an attachment (id=34098) --> (https://bugs.webkit.org/attachment.cgi?id=34098) Proposed patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:31:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:31:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804233135.49B91345F1ED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34093|review+ | Flag| | --- Comment #5 from Adam Barth 2009-08-04 16:31:34 PDT --- (From update of attachment 34093) Clearing review flag on attachment: 34093 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/committers.py Committed r46785 M WebCore/ChangeLog M WebCore/bindings/v8/V8AbstractEventListener.cpp M WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp r46784 = 07e35744c34059ea6688b9761498f8e35a9d77d7 (trunk) M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/committers.py r46785 = b3c485049ce83fed61111e10ce0a46f8b5c31c41 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46785 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:31:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:31:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28002] Add pkasting to bugzilla-tool as a committer In-Reply-To: References: Message-ID: <20090804233138.9E153345F1FF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28002 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Adam Barth 2009-08-04 16:31:37 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:48:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:48:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28003] Cleanup: ResourceResponse should be a class, not a struct In-Reply-To: References: Message-ID: <20090804234801.0332F345F413@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28003 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |ap at webkit.org Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 16:55:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 16:55:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27986] sunspider contains error on --parse-only path In-Reply-To: References: Message-ID: <20090804235547.719EF345F4C1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27986 Jeff Walden (remove +bwo to email) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwalden+bwo at mit.edu -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:07:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:07:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23993] Underline formatting bleeds into other formatting during delete/backspace In-Reply-To: References: Message-ID: <20090805000711.84C1E345F5B1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23993 --- Comment #8 from Ryosuke Niwa 2009-08-04 17:07:10 PDT --- Justin and I talked on IRC, and it's maybe sensible to delete all style-spans and reapply ApplyStyleCommand because we need to push down text decoration and other styles and apply them again. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:12:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:12:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26981] Keyframe animations on border don't always work. In-Reply-To: References: Message-ID: <20090805001258.2261D345F63E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26981 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME --- Comment #1 from Simon Fraser (smfr) 2009-08-04 17:12:57 PDT --- This is actually working as designed. The border animations don't show because border-style is not set outside the keyframes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:14:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:14:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28006] New: REGRESSION: run-webkit-tests errors out if you have two copies of perl installed Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28006 Summary: REGRESSION: run-webkit-tests errors out if you have two copies of perl installed Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org REGRESSION: run-webkit-tests errors out if you have two copies of perl installed -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:15:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:15:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28006] REGRESSION: run-webkit-tests errors out if you have two copies of perl installed In-Reply-To: References: Message-ID: <20090805001517.2FC63345F68D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28006 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34102| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-04 17:15:16 PDT --- Created an attachment (id=34102) --> (https://bugs.webkit.org/attachment.cgi?id=34102) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:15:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:15:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28006] REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH In-Reply-To: References: Message-ID: <20090805001555.14398345F6A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28006 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Platform|PC |Macintosh Summary|REGRESSION: |REGRESSION: |run-webkit-tests errors out |run-webkit-tests crashes if |if you have two copies of |you have non-system perl in |perl installed |PATH -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:16:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:16:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26981] Keyframe animations on border don't always work. In-Reply-To: References: Message-ID: <20090805001609.C44EA345F6BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26981 --- Comment #2 from Simon Fraser (smfr) 2009-08-04 17:16:09 PDT --- Created an attachment (id=34103) --> (https://bugs.webkit.org/attachment.cgi?id=34103) LayoutTest for posterity -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:16:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:16:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28006] REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH In-Reply-To: References: Message-ID: <20090805001642.9B1FA345F6E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28006 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34102|review? |review+ Flag| | --- Comment #2 from Mark Rowe (bdash) 2009-08-04 17:16:41 PDT --- (From update of attachment 34102) r=me. Can you update the ChangeLog to use the more accurate title please? :-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:22:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:22:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28006] REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH In-Reply-To: References: Message-ID: <20090805002205.7E4FD345F782@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28006 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-04 17:22:04 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/DumpRenderTree/mac/PerlSupport/Makefile Committed r46787 M WebKit/mac/ChangeLog M WebKit/mac/WebView/WebDataSource.mm M WebCore/ChangeLog M WebCore/WebCore.base.exp M WebCore/html/HTMLHtmlElement.cpp M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/loader/FrameLoader.cpp M WebCore/loader/DocumentLoader.h M WebCore/loader/ResourceLoader.cpp M WebCore/loader/appcache/ApplicationCacheStorage.h M WebCore/loader/appcache/ApplicationCacheGroup.cpp M WebCore/loader/appcache/ApplicationCacheHost.cpp M WebCore/loader/appcache/DOMApplicationCache.cpp M WebCore/loader/appcache/ApplicationCacheGroup.h M WebCore/loader/appcache/ApplicationCacheHost.h M WebCore/loader/appcache/ApplicationCacheStorage.cpp M WebCore/loader/appcache/DOMApplicationCache.h M WebCore/loader/MainResourceLoader.cpp M WebCore/loader/DocumentLoader.cpp r46786 = f5b167df15909cc5ebf8b6b6769d05671556829f (trunk) M WebKitTools/DumpRenderTree/mac/PerlSupport/Makefile M WebKitTools/ChangeLog r46787 = 854e0f64b2ef7dc4c570b1ae7009a2ef61432b4b (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46787 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:35:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:35:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 3749] XHTML 1.1 Ruby Annotation In-Reply-To: References: Message-ID: <20090805003553.2E5B5345F976@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=3749 --- Comment #26 from Roland Steiner 2009-08-04 17:35:50 PDT --- Re-reading the bug description, and given the change of focus in my implementation towards HTML5, I wonder if it wouldn't be more correct to open a new bug entry "HTML5 Ruby Annotation" (?). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:56:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:56:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code In-Reply-To: References: Message-ID: <20090805005611.2B9A2345FC13@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27967 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34104| |review? Flag| | --- Comment #1 from Dumitru Daniliuc 2009-08-04 17:56:09 PDT --- Created an attachment (id=34104) --> (https://bugs.webkit.org/attachment.cgi?id=34104) SQLTransactionClient Introducing SQLTransactionClient, a "listener" interface that allows us to remove dependencies on DatabaseTracker and OriginQuotaManager from SQLTransaction. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 17:57:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 17:57:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805005706.823A2345FC32@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 --- Comment #4 from Eric Seidel 2009-08-04 17:57:05 PDT --- Created an attachment (id=34105) --> (https://bugs.webkit.org/attachment.cgi?id=34105) slowest 1000 tests (Debug build on a Mac Pro) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:00:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:00:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28007] New: Cannot focus area element of an image map Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28007 Summary: Cannot focus area element of an image map Product: WebKit Version: 528+ (Nightly build) Platform: All URL: http://www.w3schools.com/TAGS/tryit_view.asp?filename= tryhtml_areamap OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: arv at chromium.org It is currently impossible to tab or click to focus an area element of an image map. Area elements are semantically just links so they should be focusable by default (just like a elements) This works in Firefox and IE. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:07:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:07:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27247] [HTML5][Forms] Part 5 of datalist&list: UI of `list' attribute of In-Reply-To: References: Message-ID: <20090805010711.003FD345FD29@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27247 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[HTML5][Forms] |[HTML5][Forms] Part 5 of |[HTML5][Forms] Part 5 of |datalist&list: UI of `list' |datalist&list: UI of `list' |attribute of |attribute of | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:11:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:11:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805011153.D9CFF345FD9B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34085|review+ | Flag| | Attachment #34085|0 |1 is obsolete| | --- Comment #5 from Eric Seidel 2009-08-04 18:11:53 PDT --- (From update of attachment 34085) @bdash: agreed. I'll make this a meta bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:12:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:12:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805011232.3506C345FDAD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 --- Comment #6 from Eric Seidel 2009-08-04 18:12:31 PDT --- This bug only serves a temporary purpose. It can be closed when most of the dependent bugs are closed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:14:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:14:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28008] New: fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28008 Summary: fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org Blocks: 27995 fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay This layout test is from another era. I've updated it to be dumpAsText and not need a 5-second delay to test dragging. I validated that I didn't break the test by temporarily removing the "disabled" flag from the and checking that the drag succeeded (i.e. the test failed) with disabled removed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:14:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:14:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805011438.49414345FDE1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28008 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:16:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:16:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28008] fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay In-Reply-To: References: Message-ID: <20090805011628.79CBC345FE14@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28008 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34106| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-04 18:16:27 PDT --- Created an attachment (id=34106) --> (https://bugs.webkit.org/attachment.cgi?id=34106) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:17:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:17:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28008] fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay In-Reply-To: References: Message-ID: <20090805011741.C2893345FE3C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28008 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34106|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:24:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:24:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805012438.C2C19345FEC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 --- Comment #7 from Eric Seidel 2009-08-04 18:24:37 PDT --- Created an attachment (id=34108) --> (https://bugs.webkit.org/attachment.cgi?id=34108) slowest 1000 tests (Release build on a Mac Pro) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:25:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:25:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27998] http/tests/cache/subresource-expiration.html uses 4.5 seconds of delay In-Reply-To: References: Message-ID: <20090805012558.29AA5345FEE2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27998 --- Comment #1 from Eric Seidel 2009-08-04 18:25:57 PDT --- Actually, this is the slowest test in Release mode :( 6.22 secs: http/tests/cache/subresource-expiration.html See list https://bugs.webkit.org/attachment.cgi?id=34108 on bug 27995. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:34:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:34:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28008] fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay In-Reply-To: References: Message-ID: <20090805013450.39250345FFB7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28008 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Eric Seidel 2009-08-04 18:34:49 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.png D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/win/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/ChangeLog A LayoutTests/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/fast/forms/textfield-drag-into-disabled.html Committed r46790 D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.png D LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum D LayoutTests/platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt D LayoutTests/platform/win/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/ChangeLog A LayoutTests/fast/forms/textfield-drag-into-disabled-expected.txt M LayoutTests/fast/forms/textfield-drag-into-disabled.html r46790 = 0e2037c9047382a8aee9bdbd132f550c58725acd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46790 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:34:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:34:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090805013450.D0AE6345FFC1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Bug 27995 depends on bug 28008, which changed state. Bug 28008 Summary: fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay https://bugs.webkit.org/show_bug.cgi?id=28008 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 18:42:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 18:42:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28009] New: Browser app is forced to terminate when access to a site with a 10MB gif image Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28009 Summary: Browser app is forced to terminate when access to a site with a 10MB gif image Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Other Status: UNCONFIRMED Severity: Critical Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ugashi35 at gmail.com Steps to reproduce: 1.Access to a site with a 10MB gif image 2.Wait for completed loading the site Browser Version: Mozilla/5.0(Linux U; Android 1.5; en-us; sdk Build/CUPCAKE) AppleWebkit/528.5(KHTML,like Gecko) Version/3.1.2 Mobile Safari/525.20.1 Actual behavior: Browser app is forced to terminate during loading a page *This site is possible to complete loading with the Safari browser(Ver. 530.17) Expected result: The browser app is not forced to terminate, at least display the error pop up before terminate -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:02:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:02:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28010] New: willCacheResponse tests should be split from the main dumpResourceLoadCallbacks() dumps Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28010 Summary: willCacheResponse tests should be split from the main dumpResourceLoadCallbacks() dumps Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: beidson at apple.com willCacheResponse tests should be split from the main dumpResourceLoadCallbacks() dumps. >From email on webkit-dev: On Aug 4, 2009, at 5:35 PM, Darin Fisher wrote: There is a Mac-only willCacheResponse notification that gets recorded by several of the layout tests when layoutTestController.dumpResourceLoadCallbacks(true) is called. However, this notification which originates at the ResourceHandle level is currently #if PLATFORM(MAC). I noticed that the tests which depend on this notification are currently skipped on platform/win. For Chromium, we have simply rebaselined with the willCacheResponse events excluded. Having a separate baseline is unfortunate and not running the tests on platform/win seems even worse. I wonder if it wouldn't be better to exclude willCacheResponse by default, and then only enable it selectively for tests that are about testing it. That way, we can un-skip the other tests that only fail on non-Mac as a side-effect of this notification not being supported. We could also try to support willCacheResponse on all platforms, but that seems like a lot of work for little gain. Afterall, it is a notification that WebKit doesn't itself care about. It is just something provided to the embedder of the WebKit Framework on Mac. I didn't see any bugs on file about this issue. -Darin My reply: willCacheResponse was lumped in with dumpResourceLoadCallbacks() solely for convenience based on the situation at the time. As you point out, it is only interesting for embedders of mainline WebKit on Mac. My two proposals are to either split off a new dumpWillCacheResponse() callback or change dumpResourceLoadCallbacks() to take a second argument that is false by default. I slightly prefer the latter. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:17:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:17:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26787] REGRESSION (r45064): Drop caret remains in text control after the mouse exits In-Reply-To: References: Message-ID: <20090805021700.BB0F634603F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26787 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abarth at webkit.org AssignedTo|webkit-unassigned at lists.web |eric at webkit.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:18:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:18:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090805021831.0D75F3460427@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34088| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:28:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:28:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 3749] XHTML 1.1 Ruby Annotation In-Reply-To: References: Message-ID: <20090805022858.ADD613460523@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=3749 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #27 from Eric Seidel 2009-08-04 19:28:57 PDT --- Too big for me to review, but possibly Hyatt can help you. No need to set commit-queue=? I'm sure Adam will write up some docs on commit-queue soon. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:30:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:30:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090805023052.41B9B3460567@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34088|commit-queue+ |commit-queue- Flag| | --- Comment #17 from Adam Barth 2009-08-04 19:30:51 PDT --- (From update of attachment 34088) I don't know what this error means, but the commit queue can't handle this patch: patching file WebCore/dom/SelectElement.cpp patch: **** malformed patch at line 15: @@ -502,8 +503,11 @@ void SelectElement::reset(SelectElementD -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 19:45:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 19:45:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805024545.87F0E346074A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33993|review? |review- Flag| | --- Comment #9 from Eric Seidel 2009-08-04 19:45:44 PDT --- (From update of attachment 33993) These are two separate changes. 1. to change queue to evaluate. 2. to fix ScheduledAction. I don't really know what this does, but I trust you do: 51 m_context.makeWeak(); These changes look both fine, but should be split into two. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 20:14:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 20:14:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805031446.65B7E3460A6D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33993|review- | Flag| | Attachment #33993|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 20:14:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 20:14:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805031450.F2D513460A8C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34113| |review? Flag| | --- Comment #10 from Adam Barth 2009-08-04 20:14:49 PDT --- Created an attachment (id=34113) --> (https://bugs.webkit.org/attachment.cgi?id=34113) Rename queueScriptInIsolatedWorld --- 18 files changed, 47 insertions(+), 17 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 20:14:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 20:14:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805031455.DD9FC3460AAF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34114| |review? Flag| | --- Comment #11 from Adam Barth 2009-08-04 20:14:54 PDT --- Created an attachment (id=34114) --> (https://bugs.webkit.org/attachment.cgi?id=34114) Scheduled action --- 10 files changed, 129 insertions(+), 18 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 20:25:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 20:25:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28011] New: Javascript core in webkit seems not work under 2 "window.location" issued Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28011 Summary: Javascript core in webkit seems not work under 2 "window.location" issued Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Critical Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yu.tsunghua at gmail.com CC: yu.tsunghua at gmail.com Dear Webkit Experts: Right now we are using Linux x86 + qt embedded 4.5.2 to build a VOD client. The problem what we met is that if contiguous two "window.location=" be issued in a javascript code section, QT webkit moudle seems can't send out the first one window.location. in other word, the first window.location was overwrite by the second one. the first window.location is an RTSP URL. the second is an HTTP URL. we build a test enviroment to simulate the whole process. here is the followings. 1. for first page, just an index page. index.html RTSP 2. for second page, launch the rtsp url via javascript in body tag onload action. rtsp.html RTSP URL Test 3. for third page, just show the current program end. In On Back Page Back Page when we using the QWebView to test the three pages, we can't get the RTSP URL request via qt's way. and we got the trolltech's expert advise to seek webkit experts to find out a workaround way to address this problem. the trolltech's expert tell us the problem seems come from the webkit's javascript core. would any body to do us a favor to show us how to trace the window.location was be handled? we want to know where the window.location was be handled and add some debug message to see what is really happened. Thanks in advance. Best Regards, Albert -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 20:28:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 20:28:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28011] Javascript core in webkit seems not work under 2 "window.location" issued In-Reply-To: References: Message-ID: <20090805032805.F1CC63460BC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28011 --- Comment #1 from AlbertYu 2009-08-04 20:28:05 PDT --- Created an attachment (id=34115) --> (https://bugs.webkit.org/attachment.cgi?id=34115) A test web page for webkit -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 21:20:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 21:20:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805042035.172A43461093@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34113|review? |review+ Flag| | --- Comment #12 from Eric Seidel 2009-08-04 21:20:33 PDT --- (From update of attachment 34113) LGTM. I assume this has a corresponding change in Chromium's test_shell? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 21:21:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 21:21:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805042152.2B93634610CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34114|review? |review+ Flag| | --- Comment #13 from Eric Seidel 2009-08-04 21:21:50 PDT --- (From update of attachment 34114) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 21:54:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 21:54:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27968] [HTML5][Forms] UI In-Reply-To: References: Message-ID: <20090805045448.A21A734613F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27968 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27451 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 23:16:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 23:16:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds In-Reply-To: References: Message-ID: <20090805061653.7DBF63461B3C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27703 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |abarth at webkit.org |kit.org | --- Comment #14 from Adam Barth 2009-08-04 23:16:52 PDT --- Assigned for landing. Landing this is a tricky dance. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 4 23:46:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 4 Aug 2009 23:46:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28010] willCacheResponse tests should be split from the main dumpResourceLoadCallbacks() dumps In-Reply-To: References: Message-ID: <20090805064643.2E9103461E06@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28010 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fishd at chromium.org --- Comment #1 from Darin Fisher (:fishd, Google) 2009-08-04 23:46:42 PDT --- I'm happy to help implement this, and either of your suggestions are fine by me. Would we only enable willCacheResponse for the http/tests/misc/willCacheResponse-delegate-callback.html layout test? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 00:17:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 00:17:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27874] Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp In-Reply-To: References: Message-ID: <20090805071719.6B48B346215C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27874 --- Comment #7 from Zoltan Horvath 2009-08-05 00:17:18 PDT --- Weird. Was it on a MAC, wasn't it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 00:28:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 00:28:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090805072820.25E76346225A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Charles Wei changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34119| |review?(zimmermann at kde.org) Flag| | --- Comment #27 from Charles Wei 2009-08-05 00:28:17 PDT --- Created an attachment (id=34119) --> (https://bugs.webkit.org/attachment.cgi?id=34119) new patch with seperate .in file for the new WCSS properties. This is a new patch for the code changes, the most important change is that it seperates the WCSS specific CSS properties in a seperate .in file, and can be conditionally picked up by webkit with ENABLE(WCSS) . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 00:32:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 00:32:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28008] fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay In-Reply-To: References: Message-ID: <20090805073211.60A3834622C4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28008 --- Comment #3 from Mark Rowe (bdash) 2009-08-05 00:32:10 PDT --- Another good example of why bug 26920 should be addressed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 00:44:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 00:44:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28012] New: WebKit crashes because of Slashdot.org main page Javascript. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28012 Summary: WebKit crashes because of Slashdot.org main page Javascript. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Critical Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: red47514f7 at yandex.ru CC: red47514f7 at yandex.ru If I wget http://slashdot.org/ and just open it in a WebKit-based browser, everything is OK; of course, JavaScript loaded by relative URLs is not working. If I open http://slashdot.org/ in a webkit browser built against latest nightly (I tried two different browsers - uzbl and midori, both have the same regression when the same browser code is linked against too fresh WebKit instead of slightly older one), I see the Slashdot scripts composing a page, for a brief moment I even see nearly-complete rendering and then browser crashes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:03:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:03:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28013] New: Add my name to committers.py Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28013 Summary: Add my name to committers.py Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jorlow at chromium.org CC: abarth at webkit.org Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34120| |review? Flag| | Created an attachment (id=34120) --> (https://bugs.webkit.org/attachment.cgi?id=34120) Patch v1 Add my name to committers.py -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:06:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:06:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28013] Add my name to committers.py In-Reply-To: References: Message-ID: <20090805080654.789433462636@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28013 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34120|review? | Flag| | Attachment #34120|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:07:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:07:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28013] Add my name to committers.py In-Reply-To: References: Message-ID: <20090805080712.A30F93462649@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28013 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34122| |review? Flag| | --- Comment #1 from Jeremy Orlow 2009-08-05 01:07:11 PDT --- Created an attachment (id=34122) --> (https://bugs.webkit.org/attachment.cgi?id=34122) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:07:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:07:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28013] Add my name to committers.py In-Reply-To: References: Message-ID: <20090805080748.3D8E23462667@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28013 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |jorlow at chromium.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:14:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:14:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27929] [Gtk] macros in webkit.m4 should be defined once only In-Reply-To: References: Message-ID: <20090805081434.4A35D346274A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27929 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |xan.lopez at gmail.com Resolution|FIXED | --- Comment #4 from Xan Lopez 2009-08-05 01:14:33 PDT --- I had to revert this, since it was making us build debug images by default... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:14:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:14:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27929] [Gtk] macros in webkit.m4 should be defined once only In-Reply-To: References: Message-ID: <20090805081451.59C343462760@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27929 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33946|review+ | Flag| | --- Comment #5 from Xan Lopez 2009-08-05 01:14:51 PDT --- (From update of attachment 33946) Clearing flags. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:42:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:42:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28015] New: [Chromium] @font-face is not supported on Linux Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28015 Summary: [Chromium] @font-face is not supported on Linux Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yusukes at chromium.org (copied from http://crbug.com/18490) Chrome Version: r21365 URLs (if applicable) : http://www.alistapart.com/d/cssatten/poen.html Behavior in Chrome for Windows (optional): no problem CSS3 Web font (aka @font-face, dynamic font, or remote font) is not supported on Chromium Linux, even when --enable-remote-fonts command line flag is used. What steps will reproduce the problem? 1. start chromium for linux with --enable-remote-fonts 2. visit http://www.alistapart.com/d/cssatten/poen.html What is the expected result? The page is rendered using web fonts (scrrenshot:http://www.alistapart.com/d/cssatten/poen.png). What happens instead? The page is rendered without using web fonts (screenshot: http://www.alistapart.com/d/cssatten/nowf.png). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 01:52:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 01:52:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27490] Web Sockets Test Infrastructure Part 1/3: Server In-Reply-To: References: Message-ID: <20090805085215.0659D3462ACF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27490 Yuzo Fujishima changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34053|0 |1 is obsolete| | Attachment #34124| |review? Flag| | --- Comment #8 from Yuzo Fujishima 2009-08-05 01:52:13 PDT --- Created an attachment (id=34124) --> (https://bugs.webkit.org/attachment.cgi?id=34124) Web Socket Server, in desired coding style, with shorter file names. Thank you for your reviews. - I've changed the coding style to conform with PEP 8. - I've changed the #! line and other parts of the code such that the scripts will run with Python 2.3 and later. (I've tested with Python 2.3, 2.4, and 2.5) - I've removed 'websocket_' from the file names except for websocket_http_server.py, for which the prefix is meaningful, IMHO. - I've changed the protocol_version to HTTP/1.1. - I've defined two kinds of "default port". One is as defined by the spec. The other is for testing. Yuzo -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 02:18:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 02:18:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090805091832.D52EA3462D6B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #7 from Aharon (Vladimir) Lanin 2009-08-05 02:18:31 PDT --- To prevent confusion on the directionality issue, I would suggest using simpler test strings: "hi!" and "אא!". The directionality is LTR if the exclamation mark comes out on the right, and RTL if it comes out on the left. > 1. In windows, Safari, FireFox, and IE all behave the same. They all display > the items in the popup list in left-to-right direction, no matter whether the > input field is an LTR or RTL field. That is not the result that I get: Firefox 3.0.11: always in browser language directionality (i.e. LTR) Safari 4.0.2: always in element directionality (i.e. RTL for the test page) Opera 9.64: did not auto-complete IE 7: did not auto-complete Thus, Firefox, Safari, and Chrome on Windows all do different things. It is important to point out that displaying a value in the right directionality is not a nice-to-have. In the wrong directionality, the value often comes out simply garbled. For example, displaying "17 Main St." as ".Main St 17", which is what comes out when it is displayed RTL, is simply wrong. BTW, the current Chrome bug that the drop-down is always left-aligned, even for a dir=rtl align=right element, is also a bug. No one else does that. Chrome has the same bug for Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28017 Summary: box-shadow's spread is ignored with
    Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hamaji at chromium.org Created an attachment (id=34132) --> (https://bugs.webkit.org/attachment.cgi?id=34132) Test case The change for Bug 27811 is needed for RenderTable as well. See the test case. I'll send a patch soon later. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 06:03:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 06:03:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090805130301.08A233464782@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34133| |review? Flag| | --- Comment #1 from Shinichiro Hamaji 2009-08-05 06:03:00 PDT --- Created an attachment (id=34133) --> (https://bugs.webkit.org/attachment.cgi?id=34133) Patch v1 --- 6 files changed, 164 insertions(+), 7 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 06:03:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 06:03:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090805130348.6B130346479A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mitz at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 06:27:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 06:27:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28012] WebKit crashes because of Slashdot.org main page Javascript/CSS. In-Reply-To: References: Message-ID: <20090805132705.F17983464A72@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28012 red47514f7 at yandex.ru changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|WebKit crashes because of |WebKit crashes because of |Slashdot.org main page |Slashdot.org main page |Javascript. |Javascript/CSS. --- Comment #1 from red47514f7 at yandex.ru 2009-08-05 06:27:05 PDT --- Maybe I misclassified the bug because disabling one CSS file ( http://c.fsdn.com/sd/idlecore-tidied.css?T_2_5_0_266b ) fixes the problem. Bug was first filed when r46770 was fresh nightly. It appeared a few days earlier. gdb reports WebCore::RenderFieldset::findLegend Full backtrace minus paths and application part: #0 0xb7a0b9bf in WebCore::RenderFieldset::findLegend () #1 0xb7a0c83d in WebCore::RenderFieldset::calcPrefWidths () #2 0xb79f6d9b in WebCore::RenderBox::minPrefWidth () #3 0xb7a003d3 in WebCore::RenderBox::calcWidth () #4 0xb79e8cba in WebCore::RenderBlock::layoutBlock () #5 0xb79d6b18 in WebCore::RenderBlock::layout () #6 0xb79e865b in WebCore::RenderBlock::layoutBlockChildren () #7 0xb79e9311 in WebCore::RenderBlock::layoutBlock () #8 0xb79d6b18 in WebCore::RenderBlock::layout () #9 0xb79e865b in WebCore::RenderBlock::layoutBlockChildren () #10 0xb79e9311 in WebCore::RenderBlock::layoutBlock () #11 0xb79d6b18 in WebCore::RenderBlock::layout () #12 0xb79e865b in WebCore::RenderBlock::layoutBlockChildren () #13 0xb79e9311 in WebCore::RenderBlock::layoutBlock () #14 0xb79d6b18 in WebCore::RenderBlock::layout () #15 0xb79e865b in WebCore::RenderBlock::layoutBlockChildren () #16 0xb79e9311 in WebCore::RenderBlock::layoutBlock () #17 0xb79d6b18 in WebCore::RenderBlock::layout () #18 0xb79d896c in WebCore::RenderBlock::insertFloatingObject () #19 0xb79e3377 in WebCore::RenderBlock::handleFloatingChild () #20 0xb79e6313 in WebCore::RenderBlock::handleSpecialChild () #21 0xb79e84b9 in WebCore::RenderBlock::layoutBlockChildren () #22 0xb79e9311 in WebCore::RenderBlock::layoutBlock () #23 0xb79d6b18 in WebCore::RenderBlock::layout () #24 0xb79e865b in WebCore::RenderBlock::layoutBlockChildren () #25 0xb79e9311 in WebCore::RenderBlock::layoutBlock () #26 0xb79d6b18 in WebCore::RenderBlock::layout () #27 0xb79e865b in WebCore::RenderBlock::layoutBlockChildren () #28 0xb79e9311 in WebCore::RenderBlock::layoutBlock () #29 0xb79d6b18 in WebCore::RenderBlock::layout () #30 0xb79e865b in WebCore::RenderBlock::layoutBlockChildren () #31 0xb79e9311 in WebCore::RenderBlock::layoutBlock () #32 0xb79d6b18 in WebCore::RenderBlock::layout () #33 0xb79e865b in WebCore::RenderBlock::layoutBlockChildren () #34 0xb79e9311 in WebCore::RenderBlock::layoutBlock () #35 0xb79d6b18 in WebCore::RenderBlock::layout () #36 0xb7a6ff17 in WebCore::RenderView::layout () #37 0xb7932682 in WebCore::FrameView::layout () #38 0xb773c250 in WebCore::Document::updateLayout () #39 0xb774f5d9 in WebCore::Document::updateLayoutIgnorePendingStylesheets () #40 0xb76b684b in WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue () #41 0xb76bcf98 in WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue () #42 0xb76b5446 in WebCore::CSSComputedStyleDeclaration::getPropertyValue () #43 0xb76f6353 in WebCore::CSSStyleDeclaration::getPropertyValue () #44 0xb7cb66c4 in WebCore::jsCSSStyleDeclarationPrototypeFunctionGetPropertyValue () -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 06:45:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 06:45:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090805134508.3E3903464CBE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #12 from Zoltan Herczeg 2009-08-05 06:45:06 PDT --- Unfortunately there are several ways to define global variables, I don't think it is possible to merge them into a single preprocessor define: - using DEFINE_STATIC_LOCAL * creates static global variables inside a function * the object is created before the first call of the function - using DEFINE_GLOBAL (WebCore/platform/StaticConstructors.h) * these variables cannot be freed, since they are allocated on the heap * workaround: wrapper classes Any better idea? * fortunately it is a rarely used directive (only two classes: AtomicString and QualifiedName) - Plain global variables [static] class* [class_name::]variable; * I will try to use a static alayzer tool to find these objects * my propose: use '[static] WTF::StaticPtr [class_name::]variable;' instead of them in the future WTF::StaticPtr similar to OwnPtr, except: - only one object can be assigned to it. The object can be passed to the constructor, or assigned later. > Is the goal here to make memory leak debugging tools work better? Or is there > value beyond that? Ok, you win here :) tonikitoo and ddkilzer mentioned they could use this feature. I also plan to use it for embedded devices, but first I would like to know whether it is possible to do it. But right know they are just plans, nothing more. > Could you write a document about how to use StaticPtr correctly? I'd like to > review that to get an idea how we would make sure we were using it properly on > various platforms. Would we consider it a coding style violation to make a > global that doesn't use StaticPtr? "WTF::StaticPtr" would be a substitution of "class*", and it would mimic the default C++ pointer behaviour as possible (with operator overloading). I hope "class&" definitions are rare except for DEFINE_STATIC_LOCAL. > As part of this are you proposing that DEFINE_STATIC_LOCAL be the only legal > way to make global variables? No. DEFINE_STATIC_LOCAL has a special purpose, and looks like not cover all global variables. > I do not want to sign up everyone on the project to write a lot of code to > deallocate every last object if this code isn't actually useful to someone on > one of the ports. I need to hear more justification about why to take on all > this additional complexity. Making all the global data structures practical to > delete is an enormous task that this patch barely scratches the surface of. Well I think a global policy can be: - either do not write destructors (someone else can do later) - or write a working, and tested constructor. > > +#if !PLATFORM(QT) > > delete data; > > +#endif This delete cause a segmentation fault in Qt. It has not appeared until now, since this destructor is never called. (Although this code may have worked, when the destructor was implemented, but it was not covered by regression tests, and has gone wrong eventually). I think if we write a destructor, we have to maintain it as the other codes, and should cover them in regression tests. This may be a good aim for this project. I have fixed the typos and other things (the looks much better now), except: > > + PtrType operator=(PtrType); > > This seems like bad style. Since values stored in this pointer will be freed, I > think we want this to use some explicit style like OwnPtr rather than plain > assignment. Could you show me an example here? Anyway, a plain QtLauncher now frees 761 objects (without crash). After some browsing it grows to 812. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 07:02:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 07:02:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27939] WebInspector: Extract style editing into a separate file that is going to be loaded in page context. In-Reply-To: References: Message-ID: <20090805140209.A86A13464E8E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27939 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33973|review? | Flag| | Attachment #33973|0 |1 is obsolete| | Attachment #34134| |review? Flag| | --- Comment #8 from Pavel Feldman 2009-08-05 07:02:08 PDT --- Created an attachment (id=34134) --> (https://bugs.webkit.org/attachment.cgi?id=34134) patch I updated the change to do all the edits for styles and metrics in a serialized way. I've also merged with the changes panel. I'd like to submit it if possible in order to avoid painful merging. I will not close the bug though unless this new file runs in a separate context. What do you think? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 07:19:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 07:19:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27874] Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp In-Reply-To: References: Message-ID: <20090805141956.42CA7346505E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27874 --- Comment #8 from Eric Seidel 2009-08-05 07:19:55 PDT --- It sounds like either the conversion to fastMalloc/fastFree was incomplete here, or that by changing over to fastMalloc we've tripped some other subtle bug in the regexp engine. The latter is bad news and requires further investigation. I worry that the current use of malloc/free could just be papering over some underlying bug, given Gavin's above comment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 07:57:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 07:57:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] New: WINCE PORT: modified files in WebCore/storage Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28019 Summary: WINCE PORT: modified files in WebCore/storage Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Platform AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yong.li at torchmobile.com CC: staikos at kde.org, treat at kde.org, joe.mason at torchmobile.com The patch works with those files in WebCore/storage/wince, and provide a single-thread Storage solution with timers. See bug 27657 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 07:57:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 07:57:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090805145726.8BB9434654A2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23154 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 08:05:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 08:05:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27998] http/tests/cache/subresource-expiration.html uses 4.5 seconds of delay In-Reply-To: References: Message-ID: <20090805150515.CFD313465576@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27998 Antti Koivisto changed: What |Removed |Added ---------------------------------------------------------------------------- CC|koivisto at iki.fi | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 08:10:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 08:10:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090805151015.70C8C346560D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34135| |review? Flag| | --- Comment #1 from Yong Li 2009-08-05 08:10:14 PDT --- Created an attachment (id=34135) --> (https://bugs.webkit.org/attachment.cgi?id=34135) the patch This patch is actually a single-thread solution. Probably PLATFORM(WINCE) should be replaced with USE(XXXX_SINGLE_THREAD)? ENABLE(JSC_MULTIPLE_THREADS) seems not suitable here, because they are not JSC files. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 08:24:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 08:24:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090805152440.8CF7F34657C7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #13 from Adam Treat 2009-08-05 08:24:38 PDT --- (In reply to comment #12) > - using DEFINE_GLOBAL (WebCore/platform/StaticConstructors.h) > * these variables cannot be freed, since they are allocated on the heap > * workaround: wrapper classes > Any better idea? > * fortunately it is a rarely used directive (only two classes: AtomicString > and QualifiedName) And those classes have lots of instances. In fact, I'd wager the majority of static globals you'll find in WebCore are of this type. What's more, have fun trying to destruct them in the right order. One other concern I don't think you've considered is what happens when these global statics are allocated on the heap with placement new? This occurs right now in WebCore if you look carefully :) With placement new allocated global statics you'll have to explicitly call the destructor. Not sure how you are going to automate that one. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 08:35:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 08:35:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27939] WebInspector: Extract style editing into a separate file that is going to be loaded in page context. In-Reply-To: References: Message-ID: <20090805153503.0F2AC346589E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27939 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34134|review? | Flag| | Attachment #34134|0 |1 is obsolete| | Attachment #34136| |review? Flag| | --- Comment #9 from Pavel Feldman 2009-08-05 08:35:01 PDT --- Created an attachment (id=34136) --> (https://bugs.webkit.org/attachment.cgi?id=34136) Same, but access to injected script is done via InspectorController -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 08:36:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 08:36:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27988] word-spacing style seems not to be honored In-Reply-To: References: Message-ID: <20090805153656.26D7034658E0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27988 --- Comment #2 from Carol Szabo 2009-08-05 08:36:55 PDT --- The bug is reported against the Qt Linux port and apparently is due to a lack of implementation of custom text rendering. The drawComplexText method ignores most flags except for shadow and justification and renders the text using the default spacing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 08:39:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 08:39:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27984] cpp_style.py lacks checks for pointer and reference declaration style. In-Reply-To: References: Message-ID: <20090805153918.BFF803465939@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27984 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34072|0 |1 is obsolete| | Attachment #34137| |review? Flag| | --- Comment #4 from Mike Fenton 2009-08-05 08:39:17 PDT --- Created an attachment (id=34137) --> (https://bugs.webkit.org/attachment.cgi?id=34137) Updated patch for cpp_style validation of pointer / references. Patch has been updated with the following chanages. 1) Add unit tests. 2) Update unit test for c style cast to be processed as c style code (ie. don't complain about the int *b) 3) Divide logic for C/C++ validation to properly support each style. 4) Tighten up logic of regex to compare to beginnings of lines only (greatly reduces false matches) 5) Add extra check for references to avoid return &variable; matching. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 08:53:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 08:53:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17869] REGRESSION: menu bar renders incorrectly In-Reply-To: References: Message-ID: <20090805155323.24F383465AC5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17869 Jerome Leclanche changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh at gmail.com --- Comment #3 from Jerome Leclanche 2009-08-05 08:53:22 PDT --- (In reply to comment #2) > No idea -- i was merely filing a bug to cover a "report" at > http://www.phillyblog.com/philly/suggestion-box/53443-safari-webkit-front-page-display-problem.html The page is 404. Got another page somewhere? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 08:56:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 08:56:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090805155652.A37093465B4A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Carol Szabo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34088|0 |1 is obsolete| | Attachment #34138| |commit-queue? Flag| | --- Comment #18 from Carol Szabo 2009-08-05 08:56:51 PDT --- Created an attachment (id=34138) --> (https://bugs.webkit.org/attachment.cgi?id=34138) Regenerated patch should yield the same result as previous. This patch only differs from previous version in some of the control information for patching the only modified source file. Hopefully this goes through the patching process. I used svn-apply to test this patch and apparently it works. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 08:57:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 08:57:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090805155727.50F5D3465B62@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Carol Szabo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34138|0 |1 is patch| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 09:15:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 09:15:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27939] WebInspector: Extract style editing into a separate file that is going to be loaded in page context. In-Reply-To: References: Message-ID: <20090805161532.B671C3465D7B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27939 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34136|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 09:17:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 09:17:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27939] WebInspector: Extract style editing into a separate file that is going to be loaded in page context. In-Reply-To: References: Message-ID: <20090805161720.711393465DB4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27939 --- Comment #10 from Pavel Feldman 2009-08-05 09:17:19 PDT --- Thanks for review! Please do not land this since I would like to synchronize this with the Chromium build cycle. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 09:17:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 09:17:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14997] Support for server-sent DOM events In-Reply-To: References: Message-ID: <20090805161722.26DB53465DD0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14997 Adam Bergkvist changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31160|0 |1 is obsolete| | Attachment #34139| |review? Flag| | --- Comment #31 from Adam Bergkvist 2009-08-05 09:17:17 PDT --- Created an attachment (id=34139) --> (https://bugs.webkit.org/attachment.cgi?id=34139) updated patch Updated patch to reflect recent changes in the spec as well as in WebKit. Fixes: * Renamed disconnect to close according to spec changes (and updated tests) * Added connection limit counting fix (nonCacheRequestInFlight/Complete) * Updated calls to set/unsetPendingActivity according to new garbage collection rules in the spec * Added EventSource to the Qt build system Since r45558 events are delayed until 512 bytes have been received with the Soup backend due to content sniffing always being enabled (see https://bugs.webkit.org/show_bug.cgi?id=27981). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 09:21:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 09:21:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18255] Positioned UL+LIs menu shifts when LI id attribute is referenced (link to it clicked) In-Reply-To: References: Message-ID: <20090805162153.98DAF3465E8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18255 --- Comment #3 from Jerome Leclanche 2009-08-05 09:21:52 PDT --- Created an attachment (id=34140) --> (https://bugs.webkit.org/attachment.cgi?id=34140) Reduced testcase Reduced testcase attached. Something to do with overflow: hidden and absolute displays with a negative value... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 09:24:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 09:24:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090805162449.AF81D3465EC9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 --- Comment #2 from George Staikos 2009-08-05 09:24:49 PDT --- (From update of attachment 34135) Should we use WINCE or a special USE(SINGLETHREADED_STORAGE)? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 09:26:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 09:26:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090805162626.4839A3465EF7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 --- Comment #3 from Yong Li 2009-08-05 09:26:25 PDT --- (In reply to comment #2) > (From update of attachment 34135 [details]) > Should we use WINCE or a special USE(SINGLETHREADED_STORAGE)? That's my question, too :) See above -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 09:28:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 09:28:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090805162852.4C7303465F69@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 --- Comment #4 from Yong Li 2009-08-05 09:28:51 PDT --- (In reply to comment #2) > (From update of attachment 34135 [details]) > Should we use WINCE or a special USE(SINGLETHREADED_STORAGE)? WebCore/storage/wince has already been committed. If we change to USE(SINGLETHREADED_STORAGE), then we also should change WebCore/storage/wince to WebCore/storage/singlethreaded, and also change the file names. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 09:33:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 09:33:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090805163359.15950346600D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34138| |review+ Flag| | --- Comment #19 from Darin Adler 2009-08-05 09:33:57 PDT --- (From update of attachment 34138) > Property changes on: LayoutTests/fast/forms/select-reset-multiple-selections-4-single-selection-expected.txt > ___________________________________________________________________ > Added: svn:executable > + * New text files should not be marked executable! I'll mark this r=me because that's minor and should be harmless. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 09:54:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 09:54:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090805165435.0E0A23466247@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #14 from Zoltan Herczeg 2009-08-05 09:54:33 PDT --- > And those classes have lots of instances. In fact, I'd wager the majority of > static globals you'll find in WebCore are of this type. What's more, have fun > trying to destruct them in the right order. > > One other concern I don't think you've considered is what happens when these > global statics are allocated on the heap with placement new? This occurs right > now in WebCore if you look carefully :) With placement new allocated global > statics you'll have to explicitly call the destructor. Not sure how you are > going to automate that one. In may patch a specialized wrapper class inherited from StaticPtrBase solves this problem (in WebCore at least). See GlobalAtomicString and GlobalQualifiedName. The placement news are replaced by a macro call (INIT_GLOBAL) which has a different behaviour depending on ENABLE(FREE_STATIC_PTRS). (I belive placement news are ugly, and now it looks much better) Adam, if you really want I can stop this task. I don't want to force anything if you don't like it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 09:54:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 09:54:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17635] Page content shifted too high In-Reply-To: References: Message-ID: <20090805165456.99ACB346625D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17635 Jerome Leclanche changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh at gmail.com --- Comment #4 from Jerome Leclanche 2009-08-05 09:54:56 PDT --- Domain is now parked, original URL unreachable. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:00:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:00:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17717] FOUC on mirrordot.org link In-Reply-To: References: Message-ID: <20090805170049.1FF5C3466300@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17717 Jerome Leclanche changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh at gmail.com --- Comment #1 from Jerome Leclanche 2009-08-05 10:00:48 PDT --- Can't reproduce on 532; site seems to be have been dead since a while. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:09:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:09:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28010] willCacheResponse tests should be split from the main dumpResourceLoadCallbacks() dumps In-Reply-To: References: Message-ID: <20090805170938.583783466415@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28010 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |fishd at chromium.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:11:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:11:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090805171127.EA4023466452@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Kevin Ollivier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34141| |review? Flag| | --- Comment #21 from Kevin Ollivier 2009-08-05 10:11:26 PDT --- Created an attachment (id=34141) --> (https://bugs.webkit.org/attachment.cgi?id=34141) WebCore build script for waf Somehow I missed uploading this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:17:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:17:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090805171740.67087346652B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Kevin Ollivier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34142| |review? Flag| | --- Comment #22 from Kevin Ollivier 2009-08-05 10:17:39 PDT --- Created an attachment (id=34142) --> (https://bugs.webkit.org/attachment.cgi?id=34142) Python bindings build support for waf build system The last piece. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:22:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:22:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22547] Problem Rendering In-Reply-To: References: Message-ID: <20090805172244.9A23E34665A8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22547 --- Comment #3 from Jerome Leclanche 2009-08-05 10:22:44 PDT --- Created an attachment (id=34143) --> (https://bugs.webkit.org/attachment.cgi?id=34143) Further reduction Attached further reduction. More concise, using base64 files instead of embedding external images. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:29:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:29:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090805172925.E33E834666A4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 --- Comment #5 from George Staikos 2009-08-05 10:29:25 PDT --- (In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 34135 [details] [details]) > > Should we use WINCE or a special USE(SINGLETHREADED_STORAGE)? > > WebCore/storage/wince has already been committed. > > If we change to USE(SINGLETHREADED_STORAGE), then we also should change > WebCore/storage/wince to WebCore/storage/singlethreaded, and also change the > file names. Well let's see if anyone else actually wants this feature, otherwise I see no reason to bother changing it just yet. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:38:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:38:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17717] FOUC on mirrordot.org link In-Reply-To: References: Message-ID: <20090805173830.C7FEB3466816@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17717 --- Comment #2 from David Kilzer (ddkilzer) 2009-08-05 10:38:30 PDT --- (In reply to comment #1) > Can't reproduce on 532; site seems to be have been dead since a while. The FOUC still reproduces for me, and the URL still works for me as well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:39:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:39:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090805173907.092553466846@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #15 from Adam Treat 2009-08-05 10:39:05 PDT --- (In reply to comment #14) > > And those classes have lots of instances. In fact, I'd wager the majority of > > static globals you'll find in WebCore are of this type. What's more, have fun > > trying to destruct them in the right order. > > > > One other concern I don't think you've considered is what happens when these > > global statics are allocated on the heap with placement new? This occurs right > > now in WebCore if you look carefully :) With placement new allocated global > > statics you'll have to explicitly call the destructor. Not sure how you are > > going to automate that one. > > In may patch a specialized wrapper class inherited from StaticPtrBase solves > this problem (in WebCore at least). See GlobalAtomicString and > GlobalQualifiedName. The placement news are replaced by a macro call > (INIT_GLOBAL) which has a different behaviour depending on > ENABLE(FREE_STATIC_PTRS). (I belive placement news are ugly, and now it looks > much better) I see your second patch is special casing them, but it is not deleting them as you are not explicitly calling the destructor you are just deleting them as normal. > Adam, if you really want I can stop this task. I don't want to force anything > if you don't like it. No, feel free to continue I just have doubts that this method of dealing with it will be robust enough to deal with the stated goal without encuring a lot of new requirements. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:44:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:44:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17717] FOUC on mirrordot.org link In-Reply-To: References: Message-ID: <20090805174437.2ADD934668EA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17717 --- Comment #3 from David Kilzer (ddkilzer) 2009-08-05 10:44:36 PDT --- Created an attachment (id=34147) --> (https://bugs.webkit.org/attachment.cgi?id=34147) Movie of the FOUC in action Here's a movie of the FOUC in action while the page is loaded. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:47:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:47:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28020] New: Floated span not redrawn after content changes Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28020 Summary: Floated span not redrawn after content changes Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows Vista Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: djrichard at gmail.com Created an attachment (id=34148) --> (https://bugs.webkit.org/attachment.cgi?id=34148) Simple test case. In the attached test case, an empty span (floated left) is followed by some text and a button. Clicking the button adds a textbox to the floated span, but the floated span is not redrawn and thus the textbox is not shown. Resizing the window forces a redraw and the page appears as expected. In IE6, IE8, Firefox 3.5 and Opera 9.51 the textbox is visible as soon as it is added. The bug manifests in Safari 4, WebKit nightly and Chrome. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:48:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:48:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28021] New: WINCE PORT: enable CachedFont Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28021 Summary: WINCE PORT: enable CachedFont Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Platform AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yong.li at torchmobile.com CC: staikos at kde.org, treat at kde.org, joe.mason at torchmobile.com the patch follows -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:48:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:48:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28021] WINCE PORT: enable CachedFont In-Reply-To: References: Message-ID: <20090805174852.D2F05346696F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28021 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23154 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 10:53:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 10:53:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28021] WINCE PORT: enable CachedFont In-Reply-To: References: Message-ID: <20090805175325.621F53466A42@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28021 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34150| |review? Flag| | --- Comment #1 from Yong Li 2009-08-05 10:53:24 PDT --- Created an attachment (id=34150) --> (https://bugs.webkit.org/attachment.cgi?id=34150) the patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 11:15:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 11:15:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090805181535.834DD3466D11@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34138|commit-queue? |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 11:18:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 11:18:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27051] Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled In-Reply-To: References: Message-ID: <20090805181803.E1B693466D73@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27051 --- Comment #2 from Norbert Leser 2009-08-05 11:18:02 PDT --- (In reply to comment #1) > (From update of attachment 32410 [details]) > I'll have to check into whether this works - I don't remember whether there are > special alignment or lazy commit requirements. > > But I also noticed that PLATFORM(SYMBIAN) uses fastMalloc in place of VM > allocation inside Collector.cpp. That's definitely bugus - the GC counts on the > guaranteed alignment provided by vm_map, VirtualAlloc and posix_memalign. > Failing to meet the alignment requirements will lead to random crashes. If > Symbian has no way to get aligned memory chunks, it needs to do a trick to fix > up the alignment, like the mmap() code path. Maciej, did you have a chance, in the meantime, to verify whether there are special requirements for alignment, etc? I could not find any just by looking at the code, and we are running my patch here for a while already without seeing any impact. It would be great if we can resolve this issue soon. If you can point me to alignment issues, I could easily submit my initial code that mimics alignment via fastMalloc() but otherwise it would certainly be cleaner to leave that overhead out and just implement my patch as is. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 11:19:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 11:19:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28021] WINCE PORT: enable CachedFont In-Reply-To: References: Message-ID: <20090805181957.24D513466DB1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28021 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34150|review? |review- Flag| | --- Comment #2 from George Staikos 2009-08-05 11:19:56 PDT --- (From update of attachment 34150) > +#if PLATFORM(WINCE) > + m_fontData = createFontCustomPlatformData(this); > + m_data = 0; > +#else > m_fontData = createFontCustomPlatformData(m_data.get()); > +#endif This change should not be necessary. We need to improve it in the platform dependent code. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 11:39:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 11:39:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090805183907.EA6B23466FE1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34138|review+ | Flag| | --- Comment #20 from Adam Barth 2009-08-05 11:39:06 PDT --- (From update of attachment 34138) Clearing review flag on attachment: 34138 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/forms/select-reset-multiple-selections-4-single-selection-expected.txt A LayoutTests/fast/forms/select-reset-multiple-selections-4-single-selection.html M WebCore/ChangeLog M WebCore/dom/SelectElement.cpp Committed r46806 M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/committers.py r46805 = 40ace582a5cfa5bb9bcd358a3747e3323f3c4a43 (trunk) M WebCore/dom/SelectElement.cpp M WebCore/ChangeLog M LayoutTests/ChangeLog A LayoutTests/fast/forms/select-reset-multiple-selections-4-single-selection-expected.txt A LayoutTests/fast/forms/select-reset-multiple-selections-4-single-selection.html r46806 = 8a73293fc161d96e48f967b087cf3131c3b11f62 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46806 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 11:39:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 11:39:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. In-Reply-To: References: Message-ID: <20090805183913.4A0353467003@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27942 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |abarth at webkit.org Resolution| |FIXED --- Comment #21 from Adam Barth 2009-08-05 11:39:11 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:00:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:00:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27939] WebInspector: Extract style editing into a separate file that is going to be loaded in page context. In-Reply-To: References: Message-ID: <20090805190042.0A3543467280@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27939 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34136| |commit-queue- Flag| | --- Comment #11 from Adam Barth 2009-08-05 12:00:41 PDT --- (From update of attachment 34136) Marking to avoid landing because of comment #11. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:01:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:01:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27939] WebInspector: Extract style editing into a separate file that is going to be loaded in page context. In-Reply-To: References: Message-ID: <20090805190112.D90DA34672B0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27939 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abarth at webkit.org --- Comment #12 from Adam Barth 2009-08-05 12:01:11 PDT --- Or rather Commit #10... (Silly self-referential bug comments.) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:11:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:11:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20028] Dynamically created elements do not animate upon document insertion as they should In-Reply-To: References: Message-ID: <20090805191102.D3ACA346742C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20028 Brad Neuberg changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bradneuberg at gmail.com --- Comment #2 from Brad Neuberg 2009-08-05 12:11:01 PDT --- I confirm that I'm encountering this bug as well with dynamically created SMIL animate elements: rect = document.createElementNS(svgns, 'rect'); rect.setAttribute('x', 50); rect.setAttribute('y', 50); rect.setAttribute('width', 50); rect.setAttribute('height', 50); rect.setAttribute('fill', '#0f5'); rect.setAttribute('stroke', '#085'); rect.setAttribute('stroke-width', '4'); anim = document.createElementNS(svgns, 'animate'); anim.setAttribute('attributeName', 'x'); anim.setAttribute('calcMode', 'linear'); anim.setAttribute('additive', 'replace'); anim.setAttribute('accumulate', 'none'); anim.setAttribute('from', 50); anim.setAttribute('to', 100); anim.setAttribute('begin', '2s; 5s'); anim.setAttribute('dur', '2s'); anim.setAttribute('fill', 'remove'); rect.appendChild(anim); svg.appendChild(rect); -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:18:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:18:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28024] New: Need AtomicStrings for the various font family names Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28024 Summary: Need AtomicStrings for the various font family names Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org Need AtomicStrings for the various font family names In: static int identifierForFamily(const AtomicString& family) { DEFINE_STATIC_LOCAL(AtomicString, cursiveFamily, ("-webkit-cursive")); DEFINE_STATIC_LOCAL(AtomicString, fantasyFamily, ("-webkit-fantasy")); DEFINE_STATIC_LOCAL(AtomicString, monospaceFamily, ("-webkit-monospace")); DEFINE_STATIC_LOCAL(AtomicString, sansSerifFamily, ("-webkit-sans-serif")); DEFINE_STATIC_LOCAL(AtomicString, serifFamily, ("-webkit-serif")); we use static locals. A bunch of other places we just use c-string constants: void CSSFontSelector::addFontFaceRule(const CSSFontFaceRule* fontFaceRule) static FontData* fontDataForGenericFamily(Document* document, const FontDescription& fontDescription, const AtomicString& familyName) void CSSStyleSelector::applyProperty(int id, CSSValue *value) This is error-prone and slower than necessary. Should be easy to fix with a little .in file wired up through make_names.pl in DerivedSources.make. Also need to make sure that Page() calls FontFamilyNames::init(). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:37:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:37:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26467] Cross-platform image system architecture cleanup metabug In-Reply-To: References: Message-ID: <20090805193737.B9AAE34677C9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26467 Bug 26467 depends on bug 26460, which changed state. Bug 26460 Summary: Cross-platform ICO decoder should return all icons in file as separate frames, sorted by decreasing quality https://bugs.webkit.org/show_bug.cgi?id=26460 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 12:43:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 12:43:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090805194348.2CBD934678D5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #8 from Xiaomei Ji 2009-08-05 12:43:46 PDT --- Hi Aharon, Thanks for your reply. Please see my comments inline. (In reply to comment #7) > To prevent confusion on the directionality issue, I would suggest using simpler > test strings: "hi!" and "אא!". The directionality is LTR if the exclamation > mark comes out on the right, and RTL if it comes out on the left. > > > 1. In windows, Safari, FireFox, and IE all behave the same. They all display > > the items in the popup list in left-to-right direction, no matter whether the > > input field is an LTR or RTL field. > > That is not the result that I get: > > Firefox 3.0.11: always in browser language directionality (i.e. LTR) > Safari 4.0.2: always in element directionality (i.e. RTL for the test page) > Opera 9.64: did not auto-complete > IE 7: did not auto-complete I attached the display of "שש!" in Safari 4.0.2 in Windows. It is displayed as RTL (the element directionality) in input field, but it is displayed as LTR in the pop-up list. Looks IE8 supports auto-complete, but it displays "hi!" and "שש!" in the pop-up list as LTR using the test page. > > Thus, Firefox, Safari, and Chrome on Windows all do different things. > > It is important to point out that displaying a value in the right > directionality is not a nice-to-have. In the wrong directionality, the value > often comes out simply garbled. For example, displaying "17 Main St." as ".Main > St 17", which is what comes out when it is displayed RTL, is simply wrong. > > BTW, the current Chrome bug that the drop-down is always left-aligned, even for > a dir=rtl align=right element, is also a bug. No one else does that. Chrome has > the same bug for , and I will fix them in another patch. > > In my opinion, it is Chrome's current behavior re directionality here that is > the most useful. In most cases, a text input needs to be capable of accepting > and displaying correctly - both LTR and RTL values. > Thus, our BiDi support > recommendations for web pages is to add directionality auto-detection scripts > to most inputs that after each keystroke check the directionality of the > current input value and adjust its dir and align values accordingly. Thus, both > LTR and RTL values could have been submitted in the past, and all need to be > displayed correctly, so checking the directionality of each value in the > dropdown as Chrome does is the best. Do you mean even if the text input field is marked as RTL, it should display "hi!" in such input field as LTR? and/or it should displayed "hi!" as LTR in the pop-up list? If that is the case, what is the point of setting "dir" in the input field? Or you mean "dir" should not be needed for autofill and box) and text displayed in the the pop-up list. For example, the following is LTR), and the same text in the pop-up list is displayed as RTL (because directionality is auto-detected using the first strong directional character's directionality). In such case, what should be the correct behavior? (In fact, Safari 4.0.2 display the text in RTL directionality in both option box and pop-up list, although I do not know how Safari does it? And why it can do such in
    as its parent elements Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28031 Summary: image doesn't render when width and height are defined in percentage with
    as its parent elements Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://thedlpgroup.com/index.htm OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=34189) --> (https://bugs.webkit.org/attachment.cgi?id=34189) reduced testcase I Steps: Go to http://thedlpgroup.com/index.htm II Issue: background image not loading III Conclusion: width and height defined in percentage of image tag which is defined in
    elements is causing this issue. Removing the percentage values work fine. Note: quirks mode doesn't work in IE either. IV Other Browsers: IE7: ok FF3: ok V Nightly tested: 46809 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=14949 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:01:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:01:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28031] image doesn't render when width and height are defined in percentage with
    as its parent elements In-Reply-To: References: Message-ID: <20090805230122.3729A346960A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28031 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:15:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:15:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28032] New: [www.problematique.ru]: Navigation panel is not rendered Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28032 Summary: [www.problematique.ru]: Navigation panel is not rendered Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.problematique.ru/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=34190) --> (https://bugs.webkit.org/attachment.cgi?id=34190) reduced testcase I Steps: Go to http://www.problematique.ru/ II Issue: right navigation column not loading III Conclusion: the second div(red-border) is not visible in webkit because its left margin is set to -230px. while with this setting in IE and Firefox, the div floats to the end of first div (green border). IV Other Browsers: IE7: ok FF3: ok V Nightly tested: 46809 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=14246 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:15:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:15:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28032] [www.problematique.ru]: Navigation panel is not rendered In-Reply-To: References: Message-ID: <20090805231541.1F2CE34697DD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28032 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:16:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:16:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28028] Webkit nightlies occasionally claim not to support Mac OS X 10.5 In-Reply-To: References: Message-ID: <20090805231605.A29F434697EB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28028 --- Comment #2 from Peter KORTGE 2009-08-05 16:16:05 PDT --- (In reply to comment #1) > r46809 works fine on my Mac OS X 10.5.8 machine. Do you still have the version > of WebKit.app that causes this problem? Does it still reproduce? If so, > please keep that version of the build around so that I can take a look at it. > Does it reproduce if you re-download that build? Unfortunately, I deleted the updated build when it wouldn't load and reverted back to build 46770. Have now again run the "Check for Webkit Updates ..." and the r46809 patch has been applied and all works OK. May have been a problem with the updater (I was also downloading the 10.5.8 & Garage Band patches at the same time)? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:17:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:17:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090805231728.D69BF346985B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34129|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:18:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:18:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090805231823.AA2C834698B7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 --- Comment #93 from Gavin Barraclough 2009-08-05 16:18:18 PDT --- (From update of attachment 34129) (1) ensureSpaceFor The basic design of this I'm happy with, the idea of enumerating the sequences seems nice and clean, but I do have two small concerns. First is the method name - I think it could be clearer, and more explicit. The method name makes sense in the context of ARM, where you have a constant pool, but for developers on other platforms it is unclear as to the purpose of the call.I'd suggest a better name would include something like UninterruptedInstructionSequence, which would be more descriptive of *why* this is being called. Also, I'm uncomfortable with the use of magic constants that are unchecked (note that all the 'patchOffset' constants in the JIT are guarded by ASSERTs). If someone changes the code generation in a way that could break on ARM, why should have an automatic way of detecting this. I'd suggest that you can fix this by having 'begin' and 'end' methods in the MacroAssemberARM, and #ifndef NDEBUG check that the values passed are correct. I'd suggest something like this (with MacroAssemblerARM::beginUninterruptedInstructionSequence replacing MacroAssemblerARM::ensureSpace, and MacroAssemblerARM::endUninterruptedInstructionSequence called at the end of the sequence as appropriate - both method names just suggestions, I'm open to improvements), would both be more explicitly named, and would provide checking of at least one of the magic constants: void beginUninterruptedInstructionSequence(int insnSpace, int constSpace) { #ifndef NDEBUG m_uninterruptedInstructionsBegin = label(); m_uninterruptedInstructionSpace = insnSpace; #endif m_assembler.ensureSpace(insnSpace, constSpace); } void endUninterruptedInstructionSequence() { ASSERT(differenceBetween(m_uninterruptedInstructionsBegin, label()) == m_uninterruptedInstructionSpace); } #ifndef NDEBUG Label m_uninterruptedInstructionsBegin; int m_uninterruptedInstructionSpace; #endif If you could also preserve and test 'constSpace' in a similar fashion (could you record the number of entries in the pool in 'begin', and again check the difference in 'end'?), then that would be even better. (2) enableLatePatch This seems to be tied to an assembler specific internal optimization, I don't think that explicitly exposing this in common code in this fashion is the right API here. The purpose of this flag appears to be to force calls to be generated using a constant pool entry, rather than as a relative branch. A simple short-term solution would seem to replace the 'm_latePatch' bit with a flag indicating whether the JmpSrc is a jump or a call, and to only plant relative branches for jumps. With this change the calls to enableLatePatch() should be unnecessary - all calls can be repatched. (As a note on a longer term direction, we expect at some point to be able to move the Label, Jump, Call, etc classes out of AbstractMacroAssembler and into their own header, then push these types down into the assemblers so that each assembler does not need define its own JmpSrc & JmpDst types - so in the long run I think we'd expect to be able to distinguish between jumps & calls anyway). This suggested change is based on the assumption that the ability to link branches without a constant pool entry is an optimization that only really benefits jumps, not calls. I'd be resistant to introduce any additional API unless there is a demonstrable benefit here. If there is a measurable performance benefit from doing so, then I'd suggest the right place to add API would be in LinkBuffer::link(Call, FunctionPtr). Ultimately this is not about the call instruction itself being different, but the way that the link will be performed being different. I'd suggest adding a third argument to this method - ", bool isFinal = false" (I've inverted the logic from 'enable' here - I'd suggest the default behaviour should be to allow the call to be relinked, and if we do need to do so we should explicitly specify cases where optimization can take place). For calls that are *not* currently being marked as 'enableLatePatch', you could instead pass isFinal as true when linking, which should result in exactly the same code generation from the ARM JIT as you are presently producing. But I'd like to see performance numbers to back up any API change, since I do expect that the benefit is really coming from planting relative branches for jumps rather than calls. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:18:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:18:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28003] Cleanup: ResourceResponse should be a class, not a struct In-Reply-To: References: Message-ID: <20090805231836.D645334698D3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28003 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34184|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:19:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:19:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28028] Webkit nightlies occasionally claim not to support Mac OS X 10.5 In-Reply-To: References: Message-ID: <20090805231913.C56CD34698EB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28028 --- Comment #3 from Mark Rowe (bdash) 2009-08-05 16:19:13 PDT --- It seems like there must be a race condition. I've heard one or two reports of this before, but no-one has been able to reproduce which makes this tricky to investigate :-( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:21:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:21:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090805232145.9717B3469941@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Nikolas Zimmermann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34119|review?(zimmermann at kde.org) |review- Flag| | --- Comment #28 from Nikolas Zimmermann 2009-08-05 16:21:44 PDT --- (From update of attachment 34119) Hi Charles, r-, because the old review comments still apply. Still hardcoded things in CSSStyleSelector that should go in a .css file, and the RenderMarquee changes that affect HTML. These are the only remaining issues, the introduction of the new .in files look good. Have a nice day, NIko -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:21:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:21:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090805232159.A4182346995B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Nikolas Zimmermann changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zimmermann at kde.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:23:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:23:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] New: Win DRT is missing implementations for some resource load delegate callbacks Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28033 Summary: Win DRT is missing implementations for some resource load delegate callbacks Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows XP Status: NEW Keywords: InRadar Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: beidson at apple.com Win DRT is missing implementations for some resource load delegate callbacks. Has been tracked in radar by -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:23:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:23:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090805232342.B4CAB34699CD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34130|review? |review- Flag| | --- Comment #94 from Gavin Barraclough 2009-08-05 16:23:39 PDT --- (From update of attachment 34130) This patch is dependent on the call patch that I've just reviewed & asked for changes. I have no objections to this patch and expect this patch to be a simple r+ as soon as the call patch gets okayed. But since this is blocked on the other patch, and since I think you're going to need a new version of this to update some behaviour here (re the comments on the call patch), I'm going to r- for now to take this out of the review queue. G. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:31:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:31:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28009] [Android] Browser app is forced to terminate when access to a site with a 10MB gif image In-Reply-To: References: Message-ID: <20090805233138.4BD713469AD5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28009 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Browser app is forced to |[Android] Browser app is |terminate when access to a |forced to terminate when |site with a 10MB gif image |access to a site with a | |10MB gif image --- Comment #1 from Mark Rowe (bdash) 2009-08-05 16:31:37 PDT --- You're probably better off reporting this issue to the Android developers directly. I don't think they're working out of our SVN repository at this point, so they may not be following Bugzilla. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:34:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:34:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] Win DRT is missing implementations for some resource load delegate callbacks In-Reply-To: References: Message-ID: <20090805233454.920FC3469B4A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28033 Brady Eidson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34191| |review? Flag| | --- Comment #1 from Brady Eidson 2009-08-05 16:34:53 PDT --- Created an attachment (id=34191) --> (https://bugs.webkit.org/attachment.cgi?id=34191) didReceiveResponse (other missing ones can come later) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:38:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:38:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] Win DRT is missing implementations for some resource load delegate callbacks In-Reply-To: References: Message-ID: <20090805233805.1B55F3469BA5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28033 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34191|review? |review+ Flag| | --- Comment #2 from Darin Adler 2009-08-05 16:38:04 PDT --- (From update of attachment 34191) Can't we use smart pointers for the BSTR? r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:43:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:43:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] Win DRT is missing implementations for some resource load delegate callbacks In-Reply-To: References: Message-ID: <20090805234347.298BE3469C5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28033 --- Comment #3 from Brady Eidson 2009-08-05 16:43:46 PDT --- I don't think we use any sort of BSTR smart pointer anywhere else in WinDRT - Do we have one available? I know that - at least at one time - there wasn't one available. Thanks for the review! Sending LayoutTests/ChangeLog Sending LayoutTests/platform/win/Skipped Deleting LayoutTests/platform/win/http/tests/security Sending WebKitTools/ChangeLog Sending WebKitTools/DumpRenderTree/win/ResourceLoadDelegate.cpp Sending WebKitTools/DumpRenderTree/win/ResourceLoadDelegate.h Transmitting file data ..... Committed revision 46820. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:45:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:45:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27059] Exclude Symbian platform from define of MIDDLE_ENDIAN In-Reply-To: References: Message-ID: <20090805234512.B55D83469CA4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27059 --- Comment #3 from Darin Adler 2009-08-05 16:45:11 PDT --- (From update of attachment 34180) Seems unfortunate to define something that begins with two underscores, since that's supposed to be reserved for the environment, not the library. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:59:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:59:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28034] New: layout issue due to float:left of

    preceding table Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28034 Summary: layout issue due to float:left of

    preceding table Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.forum.magnifiquelingerie.com/viewtopic.php? f=6&t=107 OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=34192) --> (https://bugs.webkit.org/attachment.cgi?id=34192) reduced testcase I Steps: Go to http://www.forum.magnifiquelingerie.com/viewtopic.php?f=6&t=107 II Issue: posts should be aligned below Print view and more towards right side III Conclusion: The issue is caused by the float:left of the

    preceding the

    that has the page contents. IV Other Browsers: IE7: ok FF3: ok V Nightly tested: 46809 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=18001 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 16:59:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 16:59:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28034] layout issue due to float:left of

    preceding table In-Reply-To: References: Message-ID: <20090805235923.C76FD3469E10@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28034 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 17:09:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 17:09:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28035] New: Bad rendering of web page because of image's height is set to 100% Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28035 Summary: Bad rendering of web page because of image's height is set to 100% Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://rapid.tvphp.net/?q=margulis+%22professional+pho toshop%22 OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=34193) --> (https://bugs.webkit.org/attachment.cgi?id=34193) reduced testcase I Steps: Go to http://rapid.tvphp.net/?q=margulis+%22professional+photoshop%22 II Issue: The entries are successively further and further to the right and the red arrows appear much to large as a kind of backdrop. III Conclusion: The issue is caused by the float:left of the

    preceding the

    that has the page contents. IV Other Browsers: IE7: ok FF3: ok V Nightly tested: 46809 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=17770 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 17:09:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 17:09:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28035] Bad rendering of web page because of image's height is set to 100% In-Reply-To: References: Message-ID: <20090806000918.01A1E3469EFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28035 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 17:36:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 17:36:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27895] [XSSAuditor] Inline Event Handler with single-line JavaScript comment can bypass XSSAuditor In-Reply-To: References: Message-ID: <20090806003659.CEC49346A1E4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27895 --- Comment #5 from Daniel Bates 2009-08-05 17:36:58 PDT --- Let "Proposed Patch 1" be called Patch 1, and "Alternative patch" be called Patch 2. I am tending to favor the Patch 1, because it has the advantage of fixing the issue without clobbering the value of the inline event handler or base href. Thus, a JavaScript DOM traversal matches the structure seen when you View Source, even though the inline event handler and base href are ignored. Additionally, it does not produce any false positives compared to Patch 2 (though, from a conversation with Adam, we can probably get away with it since such false positives are detected as part of an injection attempt). Examples: 1) Inline Event Handler http://good.webblaze.org/dbates/xsstest-printDOM.php?q=%3Cimg%20src=%22about:blank%22%20onerror=%22alert(/XSS/)%22/%3E 2) Base Href http://good.webblaze.org/dbates/xsstest-printDOM-basehref.php?q= Notice, either patch prevents the execution of the above, but Patch 1 does not nullify neither the onerror nor href attributes so the the DOM traversal matches the View Source structure. False positive for Patch 2: http://good.webblaze.org/dbates/xsstest.php?q= Because Patch 2 only looks for attributes that start with "on" and whose length is >= 5 characters (*), this is detected as an attack, even though ondummy is not a valid attribute Difference between "Proposed Patch 1" (Patch 1) and "Alternative patch" (Patch 2): Patch 1 defines a subclass of MappedAttribute, called MappedAttributeWithRawCharacters (I'm open to name suggestions) that stores the value of |m_rawAttributeBeforeValue| extracted in the HTMLTokenizer. The HTMLTokenizer creates attributes of class MappedAttributeWithRawCharacter. So, such attributes are passed along through the WebKit framework. If the attribute A corresponds to an inline event handler and A->isMappedAttributeWithRawCharacters() is true then in ScriptEventListener we cast it to MappedAttributeWithRawCharacter and pass the stored | m_rawAttributeBeforeValue| to the XSSAuditor. Similarly, we do the same in HTMLBaseElement. Patch 2 is implemented in the HTMLTokenizer. It detects attributes described by (*) or detects the href attribute of a tag. It then passes this information to the XSSAuditor. If the XSSAuditor methods return false then the corresponding attribute is set to the empty string (hence the clobbered result). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 17:40:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 17:40:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27895] [XSSAuditor] Inline Event Handler with single-line JavaScript comment can bypass XSSAuditor In-Reply-To: References: Message-ID: <20090806004016.AEBB3346A225@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27895 --- Comment #6 from Daniel Bates 2009-08-05 17:40:15 PDT --- Oh, forgot to mention. An alternative implementation of Patch 1, to get rid of the static_cast Adam brought up, is to add the method rawAttributeBeforeValue() directly to the MappedAttribute class. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 18:03:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 18:03:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27836] Stale database version persists through browser refresh In-Reply-To: References: Message-ID: <20090806010326.08EB7346A4B6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27836 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #1 from Alexey Proskuryakov 2009-08-05 18:03:25 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 18:03:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 18:03:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27836] Stale database version persists through browser refresh In-Reply-To: References: Message-ID: <20090806010351.CD623346A4C6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27836 --- Comment #2 from Alexey Proskuryakov 2009-08-05 18:03:51 PDT --- even. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 18:31:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 18:31:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] Win DRT is missing implementations for some resource load delegate callbacks In-Reply-To: References: Message-ID: <20090806013110.C148D346A729@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28033 --- Comment #4 from Brady Eidson 2009-08-05 18:31:10 PDT --- Darin reviewed this in person. Added 3 more missing methods, and removed a skipped test. Sending LayoutTests/ChangeLog Sending LayoutTests/platform/win/Skipped Sending WebKitTools/ChangeLog Sending WebKitTools/DumpRenderTree/win/FrameLoadDelegate.cpp Sending WebKitTools/DumpRenderTree/win/FrameLoadDelegate.h Transmitting file data ..... Committed revision 46824. Maybe we should leave this bugzilla open as there are still many missing delegate methods. Maybe some other tests on the skipped list are related. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:20:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:20:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] New: [Qt] Public API to configure the storage path for HTML5 localStorage Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28036 Summary: [Qt] Public API to configure the storage path for HTML5 localStorage Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: laszlo.1.gombos at nokia.com This API allows to change the path for the HTML5 localstorage per page. The proposal essentially converts the existing private API into a public API. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:27:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:27:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090806042758.5C9B2346B848@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34198| |review? Flag| | --- Comment #1 from Laszlo Gombos 2009-08-05 21:27:57 PDT --- Created an attachment (id=34198) --> (https://bugs.webkit.org/attachment.cgi?id=34198) proposed api -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:28:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:28:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090806042856.A19F8346B856@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hausmann at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:29:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:29:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090806042923.552BE346B864@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenneth.christiansen at openbo | |ssa.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:53:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:53:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28033] Win DRT is missing implementations for some resource load delegate callbacks In-Reply-To: References: Message-ID: <20090806045323.3D681346BA70@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28033 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |fishd at chromium.org Resolution| |FIXED AssignedTo|webkit-unassigned at lists.web |beidson at apple.com |kit.org | --- Comment #5 from Darin Fisher (:fishd, Google) 2009-08-05 21:53:21 PDT --- Looks like this can be closed as FIXED. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 21:55:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 21:55:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28003] Cleanup: ResourceResponse should be a class, not a struct In-Reply-To: References: Message-ID: <20090806045520.A5017346BA9F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28003 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34184| |commit-queue- Flag| | --- Comment #2 from Darin Fisher (:fishd, Google) 2009-08-05 21:55:19 PDT --- (From update of attachment 34184) commit-queue- because I need to land this in conjunction with a chromium patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:01:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:01:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27939] WebInspector: Extract style editing into a separate file that is going to be loaded in page context. In-Reply-To: References: Message-ID: <20090806050142.58C90346BB26@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27939 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fishd at chromium.org AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:02:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:02:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28003] Cleanup: ResourceResponse should be a class, not a struct In-Reply-To: References: Message-ID: <20090806050204.2B097346BB42@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28003 Darin Fisher (:fishd, Google) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fishd at chromium.org AssignedTo|webkit-unassigned at lists.web |michaeln at google.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:23:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:23:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090806052324.DFE12346BD5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 --- Comment #95 from Gavin Barraclough 2009-08-05 22:23:19 PDT --- Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/ARMAssembler.cpp Sending JavaScriptCore/assembler/AbstractMacroAssembler.h Sending JavaScriptCore/assembler/MacroAssemblerARM.h Sending JavaScriptCore/bytecode/CodeBlock.h Sending JavaScriptCore/jit/JIT.h Sending JavaScriptCore/jit/JITInlineMethods.h Sending JavaScriptCore/jit/JITOpcodes.cpp Sending JavaScriptCore/jit/JITStubs.cpp Sending JavaScriptCore/jit/JITStubs.h Sending JavaScriptCore/wtf/Platform.h Transmitting file data ........... Committed revision 46831. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:33:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:33:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] ARM JIT port In-Reply-To: References: Message-ID: <20090806053343.7E7FD346BE32@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 --- Comment #96 from Gavin Barraclough 2009-08-05 22:33:40 PDT --- Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/ARMAssembler.cpp Sending JavaScriptCore/assembler/ARMAssembler.h Sending JavaScriptCore/assembler/MacroAssemblerARM.h Sending JavaScriptCore/jit/JIT.h Transmitting file data ..... Committed revision 46832. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:34:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:34:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] New: SocketStreamHandle interface for WebSocket API Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28037 Summary: SocketStreamHandle interface for WebSocket API Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ukai at chromium.org SocketStreamHandle will be used for backend of WebSocket API. These will be added in WebCore/platform/network -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:37:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:37:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] New: WebSocket API implementation Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28038 Summary: WebSocket API implementation Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ukai at chromium.org WebSocket API implementation based on SocketStreamHandle (cf. http://bugs.webkit.org/show_bug.cgi?id=28037) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:50:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:50:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27659] IMGs don't animate in Safari In-Reply-To: References: Message-ID: <20090806055021.6CE77346BF8C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27659 --- Comment #4 from Aditya Mukherjee 2009-08-05 22:50:20 PDT --- They're being animated by Javascript (jQuery's "animate()" function). I believe it's a simple change of width and height from 0 to the final value with "setIntervals". [I hope that's the answer you were looking for?] -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:54:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:54:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28039] New: Show inherited styles for a selected DOM element Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28039 Summary: Show inherited styles for a selected DOM element Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Enhancement Priority: P3 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: aditya.vm at gmail.com When an element is selected in the "Elements" tab, the styles shown on the right are only the ones that directly affect the particular element. For example, when inspecting a "div#first", the styles shown will only be for "#first" and "div". Firebug shows all the styles that the current element inherits as well, so you would see those two, along with "body" and any other parent element. This is very useful in figuring out where a particular style is coming from when working with complicated hierarchies. I suggest Firebug's behaviour be added to Web Inspector. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:56:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:56:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28039] Show inherited styles for a selected DOM element In-Reply-To: References: Message-ID: <20090806055627.7EB53346C038@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28039 --- Comment #1 from Aditya Mukherjee 2009-08-05 22:56:27 PDT --- Created an attachment (id=34199) --> (https://bugs.webkit.org/attachment.cgi?id=34199) Web Inspector's display of styles for an element div#eyebrowwide -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 22:57:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 22:57:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28039] Show inherited styles for a selected DOM element In-Reply-To: References: Message-ID: <20090806055723.8DCDE346C04F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28039 --- Comment #2 from Aditya Mukherjee 2009-08-05 22:57:23 PDT --- Created an attachment (id=34200) --> (https://bugs.webkit.org/attachment.cgi?id=34200) Firebug's display of styles for element div#eyebrowwide -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:09:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:09:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28012] WebKit crashes because of Slashdot.org main page Javascript/CSS. In-Reply-To: References: Message-ID: <20090806060934.0855B346C1AD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28012 --- Comment #2 from red47514f7 at yandex.ru 2009-08-05 23:09:33 PDT --- Still crashes in r46809 nightly (just in case..) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:09:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:09:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28039] Show inherited styles for a selected DOM element In-Reply-To: References: Message-ID: <20090806060943.E7BA5346C1BD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28039 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hyatt at apple.com, | |timothy at hatcher.name --- Comment #3 from Timothy Hatcher 2009-08-05 23:09:43 PDT --- Hyatt, what would be the best way to get this info out of the engine? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:26:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:26:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27879] Allow custom memory allocation control for JavaScriptCore's Noncopyable class In-Reply-To: References: Message-ID: <20090806062656.7F596346C3A9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27879 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33875| |commit-queue+ Flag| | --- Comment #6 from Adam Barth 2009-08-05 23:26:54 PDT --- (From update of attachment 33875) Olliej said this was fine on IRC. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:27:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:27:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27877] Allow custom memory allocation control for JavaScriptCore's PolymorphicAccessStructureList struct In-Reply-To: References: Message-ID: <20090806062733.70A6E346C3CD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27877 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33874| |commit-queue+ Flag| | --- Comment #3 from Adam Barth 2009-08-05 23:27:32 PDT --- (From update of attachment 33874) Olliej says this one is fine too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:28:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:28:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27875] Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct In-Reply-To: References: Message-ID: <20090806062807.EB3C5346C3F3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27875 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33872| |commit-queue+ Flag| | --- Comment #3 from Adam Barth 2009-08-05 23:28:07 PDT --- (From update of attachment 33872) As is this one. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:45:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:45:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28015] [Chromium] @font-face is not supported on Linux In-Reply-To: References: Message-ID: <20090806064550.9BF8F346C68F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28015 Yusuke Sato changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34125|review? | Flag| | Attachment #34125|0 |1 is obsolete| | --- Comment #3 from Yusuke Sato 2009-08-05 23:45:49 PDT --- Created an attachment (id=34203) --> (https://bugs.webkit.org/attachment.cgi?id=34203) Proposed fix for 28015 (v2) Thanks! Replaced all defined(__linux__)s with PLATFORM(LINUX). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:46:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:46:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28015] [Chromium] @font-face is not supported on Linux In-Reply-To: References: Message-ID: <20090806064649.AF4D4346C6B3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28015 Yusuke Sato changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34203| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:58:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:58:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27875] Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct In-Reply-To: References: Message-ID: <20090806065802.2B343346C7EE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27875 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33872|review+ | Flag| | --- Comment #4 from Adam Barth 2009-08-05 23:58:00 PDT --- (From update of attachment 33872) Clearing review flag on attachment: 33872 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/parser/Nodes.h Committed r46837 M LayoutTests/platform/gtk/Skipped M LayoutTests/ChangeLog r46836 = 75353465f722f91d89afde0ce2a14f7179576a66 (trunk) M JavaScriptCore/ChangeLog M JavaScriptCore/parser/Nodes.h r46837 = c4b3d98c6a56bb0a0b54922f9c686624656ddf8e (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46837 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 5 23:58:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 5 Aug 2009 23:58:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27875] Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct In-Reply-To: References: Message-ID: <20090806065807.74DDB346C806@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27875 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Adam Barth 2009-08-05 23:58:06 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 00:39:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 00:39:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27984] cpp_style.py lacks checks for pointer and reference declaration style. In-Reply-To: References: Message-ID: <20090806073923.9140F346CC1B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27984 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34137|review? |review- Flag| | --- Comment #5 from David Levin 2009-08-06 00:39:21 PDT --- (From update of attachment 34137) Although less comprehensive, it has far less false positives than before which is awesome. Just a few comments to consider and then we'll be all done! > diff --git a/WebKitTools/Scripts/modules/cpp_style.py b/WebKitTools/Scripts/modules/cpp_style.py > + if filename.endswith('.cpp'): > + # C++ Pointer declaration should have the * beside the type not the variable name. > + matched = search(r'^\s*\w+\s\*\w+', line) It seems like this should have the return in its as well. Also match works well here since this always starts at the beginning of the string. The second \s would match more if it were \s+ Or in code (added a word break before the return) matched = match(r'\s*\w+(? + if matched: > + error(filename, line_number, 'whitespace/declaration', 3, > + 'Pointer declaration has space between type name and * ( in %s' % matched.group(0).strip()) I don't understand the "(" in error message. All of these comments apply to the "&" block as well, so it just seems better if it were the same code like this: # C++ should have the & or * beside the type not the variable name. matched = match(r'\s*\w+(?\*|\&)\w+', line) if matched: error(filename, line_number, 'whitespace/declaration', 3, 'Reference declaration has space between type name and %s in %s' % (matched.group('pointer_operator'), matched.group(0).strip())) > + > + elif filename.endswith('.c'): > + # C Pointer declaration should have the * beside the variable not the type name. > + matched = search(r'^\s*\w+\*\s\w+', line) Suggested: matched = match(r'\s*\w+\*\s+\w+', line) > + if matched: > + error(filename, line_number, 'whitespace/declaration', 3, > + 'Pointer declaration has space between * and variable name( in %s' % matched.group(0).strip()) I don't understand the "(" in error message. > diff --git a/WebKitTools/Scripts/modules/cpp_style_unittest.py b/WebKitTools/Scripts/modules/cpp_style_unittest.py Please add test for return *b; -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 00:57:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 00:57:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28015] [Chromium] @font-face is not supported on Linux In-Reply-To: References: Message-ID: <20090806075735.7BDC7346CDB7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28015 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34203|review? |review- Flag| | --- Comment #4 from David Levin 2009-08-06 00:57:34 PDT --- (From update of attachment 34203) These are only style comments but enough adjustments to r- for now. Would you ask someone on the linux team (maybe agl@) to code review this for substance (and put their comments into this bug)? Then please wait to put your patch up for r? until you get their feedback and address it. And together with their review, I'll feel comfortable with this. > Index: WebCore/platform/graphics/chromium/FontCustomPlatformData.cpp > + return FontPlatformData(m_fontReference, > + size, > + bold && !m_fontReference->isBold(), > + italic && !m_fontReference->isItalic()); There is no line length restriction in WebKit so feel free to unwrap this but only if you think it will read better. > #else > notImplemented(); > return FontPlatformData(); > @@ -186,6 +200,51 @@ static String createUniqueFontName() > } > #endif > > +#if PLATFORM(LINUX) > +class RemoteFontStream : public SkStream { > +public: > + explicit RemoteFontStream(RefPtr buffer) Use PassRefPtr instead of RefPtr for parameters. > + virtual bool rewind() > + { > + offset_ = 0; > + return true; indent by 4 spaces. (I think check-webkit-style would catch this.) > +private: > + RefPtr buffer_; > + size_t offset_; Use m_ for member variables. Not variable_. > +#elif PLATFORM(LINUX) > + RemoteFontStream stream(buffer); > + SkTypeface* tf = SkTypeface::CreateFromStream(&stream); Use full words for variable names (not "tf"). > Index: WebCore/platform/graphics/chromium/FontCustomPlatformData.h > #define FontCustomPlatformData_h > > #include > +#include "FontRenderingMode.h" This include is out of place (check-webkit-style should catch this.) > +#elif PLATFORM(LINUX) > + explicit FontCustomPlatformData(SkTypeface* tf) > + : m_fontReference(tf) Use full words for variable names (not "tf"). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:09:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:09:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] New: commit-queue needs a master process Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28040 Summary: commit-queue needs a master process Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abarth at webkit.org CC: eric at webkit.org, ddkilzer at webkit.org To make the commit queue more robust, I'm using a master process that call bugzilla-tool. We should add the master process to the repository so other folks can use it too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:11:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:11:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090806081133.487C4346CF44@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34204| |review? Flag| | --- Comment #1 from Adam Barth 2009-08-06 01:11:32 PDT --- Created an attachment (id=34204) --> (https://bugs.webkit.org/attachment.cgi?id=34204) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:17:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:17:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090806081736.DE927346CFFE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jorlow at chromium.org --- Comment #2 from Jeremy Orlow 2009-08-06 01:17:36 PDT --- I know this is really simple at the moment, but can we please make this Python from the start? I've seen plenty of scripts start out this size and then balloon over time. The second we try to do something like integrate with the waterfall, other try bots, etc, we'll be happy we did. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:21:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:21:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090806082110.1EF55346D09E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34204|review? |review- Flag| | --- Comment #3 from Adam Barth 2009-08-06 01:21:08 PDT --- (From update of attachment 34204) Ok. It's good for me to learn more python anyway. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:26:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:26:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28015] [Chromium] @font-face is not supported on Linux In-Reply-To: References: Message-ID: <20090806082653.2A5D3346D15C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28015 --- Comment #5 from Yusuke Sato 2009-08-06 01:26:52 PDT --- Thanks for your comment. I've asked Adam to review this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:28:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:28:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090806082838.EEBEB346D1D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 --- Comment #28 from Luke Kenneth Casson Leighton 2009-08-06 01:28:37 PDT --- great. will add a TODO for #ifdef DATAGRID. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 01:37:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 01:37:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28041] New: ecma/Date/15.9.5.12-1.js fails every night at midnight Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28041 Summary: ecma/Date/15.9.5.12-1.js fails every night at midnight Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abarth at webkit.org CC: mrowe at apple.com, oliver at apple.com ecma/Date/15.9.5.12-1.js fails every night between midnight and 1am pacific. This annoys the pants off me. Can we either fix this test or turn it off? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 02:49:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 02:49:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090806094920.0FD7A346DB3E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #10 from Aharon (Vladimir) Lanin 2009-08-06 02:49:16 PDT --- (In reply to comment #8) Please see my comments inline. > I attached the display of "שש!" in Safari 4.0.2 in Windows. > It is displayed as RTL (the element directionality) in input field, but it is > displayed as LTR in the pop-up list. My mistake, you are right. I was looking at the input itself - I did not get the dropdown until I entered a few more values starting the same way. > Looks IE8 supports auto-complete, but it displays "hi!" and "שש!" in the pop-up > list as LTR using the test page. I don't have IE8 yet. I guess it looks like all the browsers are using the browser language directionality, which I think is just terrible. > > In my opinion, it is Chrome's current behavior re directionality here that is > > the most useful. In most cases, a text input needs to be capable of accepting > > and displaying correctly - both LTR and RTL values. > > Thus, our BiDi support > > recommendations for web pages is to add directionality auto-detection scripts > > to most inputs that after each keystroke check the directionality of the > > current input value and adjust its dir and align values accordingly. Thus, both > > LTR and RTL values could have been submitted in the past, and all need to be > > displayed correctly, so checking the directionality of each value in the > > dropdown as Chrome does is the best. > > > > Do you mean even if the text input field is marked as RTL, > it should display "hi!" in such input field as LTR? > and/or it should displayed "hi!" as LTR in the pop-up list? I meant that it should be displayed as LTR in the autofill dropdown, but RTL in the input - unless a page script changes input's dir at that point - as it does now. > If that is the case, what is the point of setting "dir" in the input field? To control how the input itself is displayed, not the dropdown. That, of course raises the logical question: if that browser does directionality auto-detection on the dropdown values, shouldn't it do it for the input itself? Jeremy raised this question outside of the dropdown context. My response was and is that this would be a good thing - but only if the page requested that the browser do so, e.g. via a new dir=auto value. There is a discussion going on re adding dir=auto or something like that to HTML5. I do not think it would be a good idea to do directionality auto-detection on input values without dir=auto, since it would interfere with the scripts that we put in to do that right now, and we would have to modify the scripts to make an exception for Chrome. Furthermore, doing auto-detection in inputs does not do anything for when the value is later displayed in another page. And I do not think it would be a good idea to implement dir=auto in Chrome before its design has been completed, since it would interfere with whatever the eventual standard will be. The reason that I do like directionality auto-detection on the autofill dropdown values is that unlike the input itself, the page has absolutely no control over these, and can not do auto-detection for them in script. > Or you mean "dir" should not be needed for autofill and , whoever prepares the HTML of the
    In-Reply-To: References: Message-ID: <20090806214621.9B1F234738AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34133|review? |review- Flag| | --- Comment #2 from Eric Seidel 2009-08-06 14:46:21 PDT --- (From update of attachment 34133) If you're going to edit the generated template like this, you need to also modify make-js-test-wrappers so ignore your .js file so that it doens't try to re-gen a new version every time someone else runs make-js-test-wrappers. (Yes, I know this is all very poorly documented.) Seems silly to leave this in the output: You should see no red. 16 div: 17 18 flexbox: 19 20 table: 21 If you wrap it all in a div, you can easily remove that div before ending your script. Otherwise the change looks fine to me. r- for those nits. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 14:47:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 14:47:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090806214732.ADCDC34738E2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34135|review? |review- Flag| | --- Comment #6 from Eric Seidel 2009-08-06 14:47:32 PDT --- (From update of attachment 34135) This seems like the wrong approach. Please engage some of the other Database hackers and get them to make positive comments on the bug first before proceeding. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 14:49:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 14:49:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28051] [WINCE] make JPEGImageDecoder.cpp build for WINCE In-Reply-To: References: Message-ID: <20090806214920.8D2A73473928@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28051 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34213|review? |review+ Flag| | --- Comment #2 from Eric Seidel 2009-08-06 14:49:20 PDT --- (From update of attachment 34213) Seems OK. the copyright line seems like a strange place. Also, you're releasing this in 2009, so I don't see how you can claim copyright 2007. :) Not that it matters... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 14:58:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 14:58:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090806215826.799C23473A1D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 --- Comment #7 from Yong Li 2009-08-06 14:58:26 PDT --- (In reply to comment #6) > (From update of attachment 34135 [details]) > This seems like the wrong approach. Please engage some of the other Database > hackers and get them to make positive comments on the bug first before > proceeding. Any more information about why it's wrong approach? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:23:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:23:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24388] Web Inspector- Resources should show parameters and response In-Reply-To: References: Message-ID: <20090806222312.AA75B3473C8C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24388 Steel Fu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |steelfu at gmail.com --- Comment #1 from Steel Fu 2009-08-06 15:23:12 PDT --- Definitely would be nice. With this, I could completely rid myself of Firebug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:24:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:24:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28052] Photo browser doesn't display enlarged versions of photos In-Reply-To: References: Message-ID: <20090806222406.C2C6D3473CA6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28052 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |NeedsRadar, | |ReviewedForRadar -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:24:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:24:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28052] Photo browser doesn't display enlarged versions of photos In-Reply-To: References: Message-ID: <20090806222421.AF2943473CB6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28052 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Mark Rowe (bdash) 2009-08-06 15:24:20 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:24:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:24:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28052] Photo browser doesn't display enlarged versions of photos In-Reply-To: References: Message-ID: <20090806222423.6275D3473CC0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28052 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|NeedsRadar | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:32:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:32:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28051] [WINCE] make JPEGImageDecoder.cpp build for WINCE In-Reply-To: References: Message-ID: <20090806223252.182C23473D8C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28051 --- Comment #3 from Joe Mason 2009-08-06 15:32:51 PDT --- Well, because we wrote it in 2007... (Also, this isn't the first release - the source has been available from our web site ever since we released the first binaries. We just missed this in the first batch of patches we submitted.) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:33:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:33:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28046] Windows credentials not automatically passed to proxy/website. In-Reply-To: References: Message-ID: <20090806223305.88EDE3473DA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28046 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |NeedsRadar, | |ReviewedForRadar -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:33:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:33:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28046] Windows credentials not automatically passed to proxy/website. In-Reply-To: References: Message-ID: <20090806223317.A16A43473DA8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28046 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Mark Rowe (bdash) 2009-08-06 15:33:17 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:33:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:33:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28046] Windows credentials not automatically passed to proxy/website. In-Reply-To: References: Message-ID: <20090806223318.E23A83473DAE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28046 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|NeedsRadar | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:39:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:39:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27879] Allow custom memory allocation control for JavaScriptCore's Noncopyable class In-Reply-To: References: Message-ID: <20090806223920.EA67A3473E6F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27879 Zoltan Horvath changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33875|0 |1 is obsolete| | Attachment #34232| |review? Flag| | --- Comment #8 from Zoltan Horvath 2009-08-06 15:39:19 PDT --- Created an attachment (id=34232) --> (https://bugs.webkit.org/attachment.cgi?id=34232) updated proposed patch I didn't see the tabs in my previous patch. Anyway, I've filed this new one. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 15:44:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 15:44:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27879] Allow custom memory allocation control for JavaScriptCore's Noncopyable class In-Reply-To: References: Message-ID: <20090806224425.821123473F00@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27879 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34232|review? |review+, commit-queue+ Flag| | --- Comment #9 from Adam Barth 2009-08-06 15:44:24 PDT --- (From update of attachment 34232) Thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 16:03:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 16:03:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090806230321.DF925347408E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34075|0 |1 is obsolete| | Attachment #34233| |review? Flag| | --- Comment #3 from Dumitru Daniliuc 2009-08-06 16:03:19 PDT --- Created an attachment (id=34233) --> (https://bugs.webkit.org/attachment.cgi?id=34233) transaction coordinator + test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 16:29:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 16:29:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090806232938.DBD85347432F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34234| |review? Flag| | --- Comment #11 from Xiaomei Ji 2009-08-06 16:29:36 PDT --- Created an attachment (id=34234) --> (https://bugs.webkit.org/attachment.cgi?id=34234) patch w/ manual test Since the change only affects Chromium's
    as its parent elements In-Reply-To: References: Message-ID: <20090807001712.43826347490C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28031 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Platform|PC |All Ever Confirmed|0 |1 OS/Version|Windows XP |All -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:19:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:19:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14479] Slow script warning, Safari potentially unresponsive In-Reply-To: References: Message-ID: <20090807001949.391023474942@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14479 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |oliver at apple.com Resolution| |WORKSFORME -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:22:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:22:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27978] getBoundingClientRect method of DOM element return wrong value for some page In-Reply-To: References: Message-ID: <20090807002206.213B03474982@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27978 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |ap at webkit.org, | |sam at webkit.org Platform|PC |All Ever Confirmed|0 |1 OS/Version|Windows Vista |All -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:23:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:23:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14823] Some XRegExp regular expressions are syntax errors in WebKit In-Reply-To: References: Message-ID: <20090807002354.D8A4434749C4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14823 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |oliver at apple.com Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:49:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:49:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19161] wrong font size when css font-family includes monospace In-Reply-To: References: Message-ID: <20090807004935.BEEF53475513@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19161 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |eric at webkit.org |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:51:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:51:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090807005145.254683475555@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34133|review- | Flag| | Attachment #34133|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:51:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:51:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090807005150.2840D3475560@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34237| |review? Flag| | --- Comment #3 from Shinichiro Hamaji 2009-08-06 17:51:49 PDT --- Created an attachment (id=34237) --> (https://bugs.webkit.org/attachment.cgi?id=34237) Patch v2 --- 8 files changed, 160 insertions(+), 7 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 17:59:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 17:59:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27909] WebKit cannot decode jpegs that are in CMYK or YCCK format In-Reply-To: References: Message-ID: <20090807005959.31AD53475673@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27909 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33957|review? |review- Flag| | --- Comment #10 from Eric Seidel 2009-08-06 17:59:58 PDT --- (From update of attachment 33957) This does not follow WebKit style. Maybe it's not supposed to? spacing: 481 dest.setRGBA(x, info->output_scanline - 1, c*k/255, m*k/255, y*k/255, 0xFF); spacing: 513 JSAMPLE *j1 = samples[0]; extra { }: 2 } else if (info->out_color_space == JCS_CMYK) { 523 cmyk_convert_rgb(buffer, *samples, info); 524 } else { See: http://webkit.org/coding/coding-style.html check-webkit-style should also help you. Seems cmyk_convert_rgb should ASSERT output colorspace is JCS_CMYK? You should consider throwing the rgb stuff in a similar static inline. r- for the style violiations (or lack of informations as to why we would not want to match WebKit style in this file). please run check-webkit-style, there is a diff option I'm told. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:01:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:01:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090807010123.54A19347569B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34237|review? | Flag| | Attachment #34237|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:01:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:01:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090807010128.0D3B334756A6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34239| |review? Flag| | --- Comment #4 from Shinichiro Hamaji 2009-08-06 18:01:27 PDT --- Created an attachment (id=34239) --> (https://bugs.webkit.org/attachment.cgi?id=34239) Patch v3 --- 8 files changed, 168 insertions(+), 7 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:03:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:03:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27920] Right click on timeline of media controls panel cause seek In-Reply-To: References: Message-ID: <20090807010316.5BD753475706@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27920 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33934|review? |review- Flag| | Attachment #33934|review? |review- Flag| | --- Comment #2 from Eric Seidel 2009-08-06 18:03:14 PDT --- (From update of attachment 33934) Looks fine. Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button. Style viloation: 1 if (window.eventSender) 12 { If you were a committer I would just r+ and you could fix this when landing. Since I don't think you are, please re-post with the two above fixes --- Comment #3 from Eric Seidel 2009-08-06 18:03:14 PDT --- (From update of attachment 33934) Looks fine. Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button. Style viloation: 1 if (window.eventSender) 12 { If you were a committer I would just r+ and you could fix this when landing. Since I don't think you are, please re-post with the two above fixes -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:03:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:03:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27920] Right click on timeline of media controls panel cause seek In-Reply-To: References: Message-ID: <20090807010316.8D5693475708@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27920 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33934|review? |review- Flag| | Attachment #33934|review? |review- Flag| | --- Comment #2 from Eric Seidel 2009-08-06 18:03:14 PDT --- (From update of attachment 33934) Looks fine. Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button. Style viloation: 1 if (window.eventSender) 12 { If you were a committer I would just r+ and you could fix this when landing. Since I don't think you are, please re-post with the two above fixes --- Comment #3 from Eric Seidel 2009-08-06 18:03:14 PDT --- (From update of attachment 33934) Looks fine. Your if should use == LefButton (if that exists), or a comment to explain that 0 is the left button. Style viloation: 1 if (window.eventSender) 12 { If you were a committer I would just r+ and you could fix this when landing. Since I don't think you are, please re-post with the two above fixes -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:05:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:05:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090807010536.E054A347573E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 --- Comment #5 from Shinichiro Hamaji 2009-08-06 18:05:36 PDT --- Thanks for the quick review! I modified my patch as you commented (please just ignore Patch v2). I also modified a few things: - Change the filename of layout test. resources/overflow-scroll.js may be too general to put it into make-js-test-wrappers. - Make the color of shadow green. People may see the test is passing easily. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:09:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:09:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27879] Allow custom memory allocation control for JavaScriptCore's Noncopyable class In-Reply-To: References: Message-ID: <20090807010922.B48F034757AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27879 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34232|review+ | Flag| | --- Comment #10 from Adam Barth 2009-08-06 18:09:21 PDT --- (From update of attachment 34232) Clearing review flag on attachment: 34232 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/Noncopyable.h M WebCore/ChangeLog M WebCore/platform/graphics/wince/GraphicsContextWince.cpp M WebKit/win/COMPropertyBag.h M WebKit/win/ChangeLog Committed r46877 M JavaScriptCore/wtf/Noncopyable.h M JavaScriptCore/ChangeLog M WebKit/win/ChangeLog M WebKit/win/COMPropertyBag.h M WebCore/ChangeLog M WebCore/platform/graphics/wince/GraphicsContextWince.cpp r46877 = 5cd67bb8bf95afdfedae7a0d1f5568cc7b9ef674 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46877 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:09:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:09:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27879] Allow custom memory allocation control for JavaScriptCore's Noncopyable class In-Reply-To: References: Message-ID: <20090807010927.2AF4634757CC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27879 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #11 from Adam Barth 2009-08-06 18:09:25 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:11:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:11:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090807011110.5512F3475804@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34037|review? |review- Flag| | --- Comment #2 from Eric Seidel 2009-08-06 18:11:09 PDT --- (From update of attachment 34037) +== Rolled over to ChangeLog-2009-06-16 ==SVG Filter premultiplied color support for getImageDate/putImageData ?? is "NotPreMultiplied" the normal terminolgy? "unmultiplied"? Google seems to suggest that "straight" is the opposite of PreMultiplied I'm not sure that would be more clear here though. Unmultiplied might be clearer than NotPreMultiplied. I'm not a graphics expert though. No argument names: PassRefPtr getNotPreMultipliedImageData(const IntRect& rect) const; 73 PassRefPtr getPreMultipliedImageData(const IntRect& rect) const; they don't add anything. Likewise here: ImageData* source Seems we should add a "colorFrom..." for whatever type of pixel this is: destRows[basex] = (*pixel & 0x00FF0000) >> 16; 171 destRows[basex + 1] = (*pixel & 0x0000FF00) >> 8; 172 destRows[basex + 2] = (*pixel & 0x0000FF00); 173 destRows[basex + 3] = (*pixel & 0xFF000000) >> 24; Then we just create the Color in an if and the pixel assignment is shared. Same here: *pixel = srcRows[basex + 3] << 24 | srcRows[basex] << 16 | srcRows[basex + 1] << 8 | srcRows[basex + 2]; Better to use inlines to share more code. They also are are more self-documenting. Seems the toImage() result could be in a local: if (multiplied == NotPreMultiplied) 134 image = data.m_pixmap.toImage().convertToFormat(QImage::Format_ARGB32); 135 else 136 image = data.m_pixmap.toImage().convertToFormat(QImage::Format_ARGB32_Premultiplied) How do we test this? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:11:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:11:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090807011151.77916347582D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34240| |review? Flag| | --- Comment #12 from Xiaomei Ji 2009-08-06 18:11:49 PDT --- Created an attachment (id=34240) --> (https://bugs.webkit.org/attachment.cgi?id=34240) patch w/ manual test 1. Since the change only affects Chromium's , I leave the directionality of item in drop-down list as auto-detected (as first strong directional character's direction). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:17:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:17:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27971] Externally referenced fonts break with back button due to aggressive protection In-Reply-To: References: Message-ID: <20090807011746.DA09E3475893@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27971 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |ap at webkit.org Summary|externally referenced fonts |Externally referenced fonts |break with back button |break with back button due |(possibly incorrect |to aggressive protection |referrer) | Ever Confirmed|0 |1 --- Comment #1 from Alexey Proskuryakov 2009-08-06 18:17:46 PDT --- We do send a correct Referer on Back. The problem here is that the page references a CSS file that's different on each reload, and it has one-time URLs for fonts. I.e., each URL can only be used once, then it becomes "Not found". On Back, we don't reload the CSS, but try to reload fonts using original URLs. This happens because the page is in page cache, so neither it nor its stylesheets are reloaded on Back. But fonts (and probably other subresources) are re-requested from WebCore memory cache, which in turn tries to revalidate from network, due at all those no-cache and must-revalidate pragmas sent with original response. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:17:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:17:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090807011747.C0BE834758A1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34071|review? |review+ Flag| | --- Comment #10 from Eric Seidel 2009-08-06 18:17:47 PDT --- (From update of attachment 34071) Still extra junk at the end of the test text output. But looks fine. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:19:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:19:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090807011906.3737634758E4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34233|review? | Flag| | Attachment #34233|0 |1 is obsolete| | Attachment #34241| |review? Flag| | --- Comment #5 from Dumitru Daniliuc 2009-08-06 18:19:02 PDT --- Created an attachment (id=34241) --> (https://bugs.webkit.org/attachment.cgi?id=34241) patch + test case (In reply to comment #4) good comments! > 50 OwnPtr*> > > m_pendingTransactions; > > I think you could put RefPtr's in the Deque to eliminate the manual > refcounting. done. any way to do the same for the Deques? that is, can we wrap them into something that would delete them as soon as we exit the block of code that removes them from the hash map? > 51 Mutex m_pendingTransactionsGuard; > > I think this should only be called on a particular DB thread, is the Mutex > really needed? good catch, removed. > 47 SQLTransactionCoordinator::~SQLTransactionCoordinator() > 48 { > 49 } > > What happens to transactions that don't actually start prior to the thread > being killed. How do they get derefed? added code to clean up all pending transactions. i left it empty mostly because i wasn't sure what to do here and was hoping for some comments. is there anything else we might need to do other than cleaning up the transaction queues? > 210 void SQLTransaction::lockAquired() > 211 { > 212 m_nextStep = > &SQLTransaction::deliverOpenTransactionAndPreflightCallback; > 213 LOG(StorageAPI, "Scheduling deliverOpenTransactionAndPreflight for > transaction %p\n", this); > 214 m_database->scheduleTransactionCallback(this); > 215 } > > A the lockAcquired point, the system pings-pongs to the main thread and back > again to the db thread. What is the reason for the > 'deliverOpenTransactionAndPreflightCallback' step? I'm wondering if we can we > skip straight to the openTransactionAndPreflight step at this point, without > ping/ponging to the main thread. changed lockAquired() to call openTransactionAndPreflight() directly. i scheduled a task on the main thread only because i wanted to release the lock on SQLTransactionCoordinator::m_pendingTransactions as soon as possible (even though i guess it didn't matter, because the DB thread was doing the same amount of work in one order or another). but now that the lock is gone i don't think there's any reason to do this anymore. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:19:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:19:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27971] Externally referenced fonts break with back button due to aggressive protection In-Reply-To: References: Message-ID: <20090807011918.3E73834758EA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27971 --- Comment #2 from Alexey Proskuryakov 2009-08-06 18:19:17 PDT --- Note that this is also a performance problem, not just something that breaks this particular kind of DRM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:19:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:19:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27255] Geolocation incorrectly calls error callback in case of exception in success callback In-Reply-To: References: Message-ID: <20090807011942.C28763475900@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27255 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33532|review? |review+ Flag| | --- Comment #7 from Eric Seidel 2009-08-06 18:19:42 PDT --- (From update of attachment 33532) OK. That information/justification from the spec really should go in the ChangeLog. Please update it when landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:20:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:20:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27255] Geolocation incorrectly calls error callback in case of exception in success callback In-Reply-To: References: Message-ID: <20090807012044.C8381347591E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27255 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33532|review+ |review- Flag| | --- Comment #8 from Eric Seidel 2009-08-06 18:20:44 PDT --- (From update of attachment 33532) Oh. You can't land your own yet, can you. Please post one final patch with the justification information from the spec. Something like "these are marked [NoInterfaceObject] in the spec:" with the links you provided Thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:21:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:21:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27971] Externally referenced fonts break with back button due to aggressive protection In-Reply-To: References: Message-ID: <20090807012106.E5D8C347593E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27971 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #3 from Alexey Proskuryakov 2009-08-06 18:21:06 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:25:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:25:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27305] [WINCE] add WinCE-specific unicode implementation In-Reply-To: References: Message-ID: <20090807012536.6525734759DA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27305 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34225|review? |review- Flag| | --- Comment #12 from Eric Seidel 2009-08-06 18:25:35 PDT --- (From update of attachment 34225) Style: 1 const UChar *sourceIterator = source; 82 const UChar *sourceEnd = source + sourceLength; 83 UChar *resultIterator = result; 84 UChar *resultEnd = result + resultLength; Argument names which don't provide clarity should be removed from headers per our style: 160 bool isSpace(wchar_t c); 161 bool isLetter(wchar_t c); 162 bool isPrintableChar(wchar_t c); 163 bool isUpper(wchar_t c); 164 bool isLower(wchar_t c); 165 bool isPunct(wchar_t c); 166 bool isDigit(wchar_t c); I assume these are already covered by other tests? Thank you very much for posting this much smaller patch. Unless george is volunteering to fix these when landing, I'm going to r- this and ask you to post a copy with fixed style since you don't have commit-bit yet (to my knowledge). You will find the "check-webkit-style" script helpful in validating that the style is correct in these files. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:29:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:29:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27371] [WINCE] Add WinCE specific platform/text files to WebCore In-Reply-To: References: Message-ID: <20090807012952.5CBD93475A54@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27371 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33203|review? |review- Flag| | --- Comment #7 from Eric Seidel 2009-08-06 18:29:51 PDT --- (From update of attachment 33203) This is too large for me to review. Why are we adding: platform/text/wince/Euc_jp.cpp ? Now that you all have your magical UnicodeCE library, is this something that shoudl go in that? Does the rest of WebCore want this Euc_jp.cpp file? How is it generated, where does it come from? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:34:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:34:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27842] Implement GraphicsContext::fillRoundRect() for WINCE port In-Reply-To: References: Message-ID: <20090807013429.3D95B3475B0E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27842 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33809|review? |review- Flag| | --- Comment #7 from Eric Seidel 2009-08-06 18:34:28 PDT --- (From update of attachment 33809) No no no. This is a bunch of copy/paste code. Please use functions (static inline perhaps?) instead. George should be able to help you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:35:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:35:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090807013535.CBE7A3475B1E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34239|review? |review+ Flag| | --- Comment #6 from Eric Seidel 2009-08-06 18:35:35 PDT --- (From update of attachment 34239) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:36:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:36:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27960] cygwin-downloader missing various necessary packages In-Reply-To: References: Message-ID: <20090807013615.123A03475B54@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27960 --- Comment #1 from Alexey Proskuryakov 2009-08-06 18:36:14 PDT --- I did a clean installation a couple of weeks ago, and I got the aforementioned packages with cygwin-downloader, no manual tweaking was necessary. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:36:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:36:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090807013638.BB16A3475B6A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34234|0 |1 is obsolete| | --- Comment #13 from Eric Seidel 2009-08-06 18:36:37 PDT --- (From update of attachment 34234) Please obsolete old patches when uploading new ones. bugzilla-tool will do this for you if you use it to post your patches. See bugzilla-tool post-diff and bugzilla-tool post-commits. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:38:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:38:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27960] cygwin-downloader missing various necessary packages In-Reply-To: References: Message-ID: <20090807013805.98B703475BA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27960 Peter Kasting changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME --- Comment #2 from Peter Kasting 2009-08-06 18:38:05 PDT --- OK, I'm willing to believe that something went wrong on my end somehow. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:40:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:40:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090807014004.258953475BC9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34240|review? |review- Flag| | --- Comment #14 from Eric Seidel 2009-08-06 18:40:02 PDT --- (From update of attachment 34240) This constructor will run at library load time and slow down Chromium's launch time: +static const String kEllipses = "..."; Style violation: 55 : label(label), type(type), yOffset(0), ellipsesWidth(0) { } Style: 349 if ( totalWidth > width) Style violations, no argument names when not needed: 410 void drawBidiTextWithinWidth(const Font& font, const TextRun& run, const FloatPoint& point, int width); I don't think I can actually review the code here. I would need to study these files more. r- for the style stuff. Make sure to run check-webkit-style if you haven't already. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:48:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:48:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090807014846.3BF073475CED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34096|review? |review- Flag| | --- Comment #23 from Eric Seidel 2009-08-06 18:48:45 PDT --- (From update of attachment 34096) I think the huge wx() if block shoudl be moved elsewhere. No need to make build-webkit even bigger! Maybe a function in webkitdirs.pm? Maybe some sort of ensureWafInstalled() or similar. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:52:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:52:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090807015229.452963475D67@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34141|review? |review+ Flag| | --- Comment #24 from Eric Seidel 2009-08-06 18:52:28 PDT --- (From update of attachment 34141) I don't see why wx would want to switch build systems again away from the masses. But I'm not gonna stand in your way. Nor do I have time to review these line by line. Rubber Stamp. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:52:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:52:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090807015246.7846C3475D85@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34142|review? |review+ Flag| | --- Comment #25 from Eric Seidel 2009-08-06 18:52:45 PDT --- (From update of attachment 34142) Rubber Stamp. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 18:55:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 18:55:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27424] adding ConvertToGCharPrivate.h In-Reply-To: References: Message-ID: <20090807015515.41A093475DF6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27424 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33979|review?(eric at webkit.org) |review+ Flag| | --- Comment #12 from Eric Seidel 2009-08-06 18:55:14 PDT --- (From update of attachment 33979) LGTM. I still don't understand why these are named "Private.h" -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:01:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:01:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090807020107.03EB13475EA4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33972|review? |review- Flag| | --- Comment #5 from Eric Seidel 2009-08-06 19:01:06 PDT --- (From update of attachment 33972) Bunch of Style violations. Please don't post patches with #if 0 code. There are a billion includes in this file. maybe we should split some of this out into separate files? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:01:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:01:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27427] add event listener classes for gobject bindings In-Reply-To: References: Message-ID: <20090807020151.BA3943475EB2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27427 --- Comment #2 from Eric Seidel 2009-08-06 19:01:51 PDT --- (From update of attachment 33054) Please get a gtk reviewer to review this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:02:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:02:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090807020226.1FDA23475EC0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33971|review? |review+ Flag| | --- Comment #4 from Eric Seidel 2009-08-06 19:02:25 PDT --- (From update of attachment 33971) Looks sane enough. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:03:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:03:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090807020312.5BE5C3475EDA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33965|review?(eric at webkit.org) | Flag| | --- Comment #5 from Eric Seidel 2009-08-06 19:03:11 PDT --- (From update of attachment 33965) Please get a gtk reviewer to review this. I've cleared the review flag. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:03:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:03:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27437] make HTMLAppletElement and HTMLEmbedElement compliant with de-facto JS-based standards under gobject bindings In-Reply-To: References: Message-ID: <20090807020351.45D333475EEE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27437 --- Comment #14 from Eric Seidel 2009-08-06 19:03:50 PDT --- (From update of attachment 33377) Please get Mark Rowe to sign off on this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:04:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:04:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27250] Geolocation callback function IDL files are superfluous In-Reply-To: References: Message-ID: <20090807020448.012E83475F24@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27250 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33433|review? |review- Flag| | --- Comment #6 from Eric Seidel 2009-08-06 19:04:46 PDT --- (From update of attachment 33433) Please add those comments above to the ChangeLog, with spec references. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:05:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:05:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27437] make HTMLAppletElement and HTMLEmbedElement compliant with de-facto JS-based standards under gobject bindings In-Reply-To: References: Message-ID: <20090807020530.529E43475F30@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27437 --- Comment #15 from Eric Seidel 2009-08-06 19:05:29 PDT --- (From update of attachment 33377) Please get Mark Rowe to sign off on this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:08:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:08:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27885] Add QNX as supported platform In-Reply-To: References: Message-ID: <20090807020800.78CD43475F6C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27885 --- Comment #2 from Eric Seidel 2009-08-06 19:07:59 PDT --- (From update of attachment 33880) Can't we use a ThreadingQNX abstraction here to get the stack base instead? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:14:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:14:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090807021416.08E84347602B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #6 from Eric Seidel 2009-08-06 19:14:14 PDT --- (From update of attachment 34241) Please avoid combining style cleanup with functional changes when possible. :) By the time I got to TransactionCoordinator my eyes were sagging. ;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:16:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:16:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27787] The type information about the resource loading is not forwarded to the network layer In-Reply-To: References: Message-ID: <20090807021651.F3D123476081@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27787 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #5 from Eric Seidel 2009-08-06 19:16:51 PDT --- Extra space before the :. Please run check-webkit-style if you have not already. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:22:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:22:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28050] Qt Port does not use style colour as configured for input text and menu lists In-Reply-To: References: Message-ID: <20090807022224.6D4013476101@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28050 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenneth.christiansen at openbo | |ssa.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:22:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:22:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28050] Qt Port does not use style colour as configured for input text and menu lists In-Reply-To: References: Message-ID: <20090807022256.726463476115@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28050 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hausmann at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:24:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:24:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27768] SVG feComponentTransfer needs to be implemented In-Reply-To: References: Message-ID: <20090807022404.DA68A3476133@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27768 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33662|review? |review- Flag| | --- Comment #3 from Eric Seidel 2009-08-06 19:24:04 PDT --- (From update of attachment 33662) Sad that we don't have a Color based get/set: 5 srcPixelArray->get(pixelByteOffset, r); 196 srcPixelArray->get(pixelByteOffset + 1, g); 197 srcPixelArray->get(pixelByteOffset + 2, b); 198 srcPixelArray->get(pixelByteOffset + 3, a); This should just be an array of these function pointers: 168 switch (channel) { 169 case 0: 170 transferFunction = redFunction(); 171 break; 172 case 1: 173 transferFunction = greenFunction(); 174 break; 175 case 2: 176 transferFunction = blueFunction(); 177 break; 178 case 3: 179 transferFunction = alphaFunction(); 180 break; 181 default: 182 break; 183 } probably quicker than a switch, and much, much less code. :) We need to find a way to share more of these for loops. I think that we should use function pointers indexed in an array by transferFunction.type. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:27:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:27:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090807022751.41FC73476199@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 --- Comment #32 from Kenneth Rohde Christiansen 2009-08-06 19:27:50 PDT --- Simon, didn't you actually land this last patch? Please clear tag then. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:29:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:29:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090807022930.56A7534761CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33863|review? |review- Flag| | --- Comment #9 from Eric Seidel 2009-08-06 19:29:29 PDT --- (From update of attachment 33863) This is not safe: 1811 RefPtr options = static_cast(sourceElement)->options(); (at least not if we add more list() types). I think until we add more list() types we could just make it return HTMLDataListElement*. But checking at each callsite is OK too. Seems this needs to be guarded by DATAGRID defines, no? Or do we have a DataList? This doesn't look like a complete implementation, or? I can't remember if you're a committer yet or not. so r- assuming you'll need someone else to land after you fix those nits. This doesn't seem very useful w/o UI... but this is OK to land for now if it's guarded by and ENABLE. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:30:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:30:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28050] Qt Port does not use style colour as configured for input text and menu lists In-Reply-To: References: Message-ID: <20090807023009.2095534761E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28050 --- Comment #3 from Kenneth Rohde Christiansen 2009-08-06 19:30:08 PDT --- Seems right to me. Simon do you have any objections to these patches? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:30:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:30:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28050] Qt Port does not use style colour as configured for input text and menu lists In-Reply-To: References: Message-ID: <20090807023028.EA31634761F3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28050 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:41:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:41:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27059] Exclude Symbian platform from define of MIDDLE_ENDIAN In-Reply-To: References: Message-ID: <20090807024134.B6DC83476313@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27059 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34216| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:44:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:44:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27424] adding ConvertToGCharPrivate.h In-Reply-To: References: Message-ID: <20090807024418.EEF633476361@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27424 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33979| |commit-queue- Flag| | --- Comment #13 from Adam Barth 2009-08-06 19:44:18 PDT --- (From update of attachment 33979) This file does not have the usual license block. Is that ok? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:45:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:45:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090807024556.1DA1F3476383@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34164| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:46:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:46:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090807024645.A1BFE34763A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33971| |commit-queue- Flag| | --- Comment #5 from Adam Barth 2009-08-06 19:46:45 PDT --- (From update of attachment 33971) Same question about the license block. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:47:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:47:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090807024741.C813834763B9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34071| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:48:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:48:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090807024803.980A134763C9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34239| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:48:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:48:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28051] [WINCE] make JPEGImageDecoder.cpp build for WINCE In-Reply-To: References: Message-ID: <20090807024850.556B434763F3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28051 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34213| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:48:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:48:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090807024850.EAF2134763FF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34178|review? |review- Flag| | --- Comment #14 from Eric Seidel 2009-08-06 19:48:50 PDT --- (From update of attachment 34178) Please collapse this line into one nicely named define: 35 #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(WIN_OS)) || PLATFORM(WINCE) like STORE_FONT_POINTER or whatever the heck the ifdefed code does. Please add more indetifying information than just "comment above": 179 // see comment above otherwise if someone adds a comment between your two comments the latter comment will be confusing. // See comment about WINCE GDI handling near setGlyphDataForCharacter above. or something. Does WINCE only support horrizontal text? 3 #elif PLATFORM(WINCE) 64 typedef float GlyphBufferAdvance; 6065 #else A comment is need there to explain why it's just a float. No need for arg name: 51 FontCustomPlatformData* createFontCustomPlatformData(const SharedBuffer* buffer); Can you split this out? r- mostly for the unexplained advances change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:49:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:49:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090807024952.B79443476447@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ARM JIT port |[multi-patch] ARM JIT port -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 19:54:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 19:54:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27711] SVG Filter need feColorMatrix implementation In-Reply-To: References: Message-ID: <20090807025457.E46A534764E6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27711 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34041|review? |review+ Flag| | --- Comment #6 from Eric Seidel 2009-08-06 19:54:56 PDT --- (From update of attachment 34041) Sigh. We totally need Color accessors to: 127 srcPixelArray->get(pixelByteOffset, r); 128 srcPixelArray->get(pixelByteOffset + 1, g); 129 srcPixelArray->get(pixelByteOffset + 2, b); 130 srcPixelArray->get(pixelByteOffset + 3, a); Sigh. I still think function pointers would be cleaner than templates. I'll r+ this, but I definitely would prefer function pointers for this sort of thing. Modern compilers should be able to handle the jump prediction. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:06:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:06:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists In-Reply-To: References: Message-ID: <20090807030601.7F859347660C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27551 --- Comment #14 from Eric Seidel 2009-08-06 20:06:00 PDT --- (From update of attachment 33773) This patch will require buy-in from some of the Mac build experts like Mark Rowe, and whoever does build submissions for Apple these days. I think it should be possible to work this way, but I remember the export lists being a conscious choice back in the day. Please make sure you talk to Mark and ask him who the right Apple people to ask are these days. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:18:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:18:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27603] updating Document.idl to match HTML5 spec: domain read-write and access to getSelection In-Reply-To: References: Message-ID: <20090807031801.971083476741@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27603 --- Comment #6 from Eric Seidel 2009-08-06 20:18:00 PDT --- (From update of attachment 33384) I believe getSelection is intentionally avoided for Obj-C bindings, but I"m not sure. Please have an Apple person, like Mark Rowe or Tim Hatcher comment as to if this change is correct or not. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:24:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:24:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090807032433.789053476809@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34071|review+ | Flag| | Attachment #34071|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:24:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:24:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27979] Cannot scroll for box-reflect:right In-Reply-To: References: Message-ID: <20090807032438.11C2E3476810@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27979 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34244| |review? Flag| | --- Comment #11 from Shinichiro Hamaji 2009-08-06 20:24:37 PDT --- Created an attachment (id=34244) --> (https://bugs.webkit.org/attachment.cgi?id=34244) Patch v5 --- 10 files changed, 121 insertions(+), 4 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:29:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:29:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090807032921.67124347686C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34239|review+ | Flag| | Attachment #34239|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:29:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:29:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090807032926.D7B863476875@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34245| |review? Flag| | --- Comment #7 from Shinichiro Hamaji 2009-08-06 20:29:25 PDT --- Created an attachment (id=34245) --> (https://bugs.webkit.org/attachment.cgi?id=34245) Patch v4 --- 8 files changed, 168 insertions(+), 7 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:31:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:31:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28017] box-shadow's spread is ignored with
    In-Reply-To: References: Message-ID: <20090807033102.AD3F634768A3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28017 --- Comment #8 from Shinichiro Hamaji 2009-08-06 20:31:02 PDT --- Oops, I used wrong email addresses... Hmm I should check why prepare-ChangeLog obtained the addresses. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 6 20:31:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 6 Aug 2009 20:31:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27612] handling scripts can block UI In-Reply-To: References: Message-ID: <20090807033117.3870834768B9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27612 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33349|review? |review- Flag| | --- Comment #1 from Eric Seidel 2009-08-06 20:31:16 PDT --- (From update of attachment 33349) For example. When a script tag finishes loading, I think js can get a "on load" event sent. If that's true, then that event will be sent before execution instead of after execution in your port. I would have to look to confirm if there is an onload for
    and upload.php When used 'upload method 2' parameter tag "input type='file'" not imported to iframe. In Opera and Mozilla both method worked. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:00:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:00:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28123] WebKit could not copy the form with this parameter in the iframe In-Reply-To: References: Message-ID: <20090811020001.40A25349B32F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28123 --- Comment #3 from Mikhail 2009-08-10 19:00:00 PDT --- Sorry in function AJAXRequest2 when copied got extra row ").contentWindow.document.getElementById( 'idElement' )" please remove it before test. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:00:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:00:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27842] Implement GraphicsContext::fillRoundRect() for WINCE port In-Reply-To: References: Message-ID: <20090811020003.08712349B33F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27842 --- Comment #21 from Eric Seidel 2009-08-10 19:00:01 PDT --- The commit queue isn't capable of any manual merging. If the commit fails, it will just be marked as commit-queue- and a committer (like yourself) will have to land it manually. "bugzilla-tool apply-patches" can help with this. If you're worry about it getting stale or needing manual intervention, probably best to just do it yourself. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:03:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:03:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090811020338.2C2E5349B3A2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #11 from TAMURA, Kent 2009-08-10 19:03:34 PDT --- Thank you for the comments! (In reply to comment #10) > (From update of attachment 32114 [details]) > Looks really good. Just a few comments. > > > +String HTMLTextAreaElement::placeholder() const > > +{ > > + return getAttribute(placeholderAttr).string(); > > +} > > + > > +void HTMLTextAreaElement::setPlaceholder(const String& value) > > +{ > > + setAttribute(placeholderAttr, value); > > +} > > These are not great. There's no need to convert to a plain string here, and in > fact it's bad for performance. The right way to do this nowadays is to just put > [Reflect] in the IDL file and not define a setPlaceholder function in the .h > and .cpp file at all, so that should be done here. Ok, I changed this to [Reflect]. > Indenting here is awkward. Fixed. > > + bool placeholderShouldBeVisible() const { return m_placeholderShouldBeVisible; } > > I think it would be a better design for the HTMLTextAreaElement to tell the I agree. When I looked at the existing placeholder code first time, I had an impression that the code was complex. I think the reason is that both of a DOM node and a renderer have flags for placeholder visibility. I have removed the flag of InputElemntData, and updated many place to tell the visibility from a DOM node to a renderer. > > + virtual void dispatchFocusEvent(); > > + virtual void dispatchBlurEvent(); > > These overrides should be private, not public, because we generally want all > functions to be as private as possible. Fixed. > > + void setPlaceholderShouldBeVisible(bool visible) { m_placeholderShouldBeVisible = visible; } > > I don't think you need this setter function. It doesn't seem to add any > abstraction. Removed. > > +void RenderTextControl::updatePlaceholderVisibility() > > +{ > > + RefPtr textBlockStyle = createInnerTextStyle(parentStyle()); > > + HTMLElement* innerText = innerTextElement(); > > + innerText->renderer()->setStyle(textBlockStyle); > > + > > + for (Node* n = innerText->firstChild(); n; n = n->traverseNextNode(innerText)) { > > + if (RenderObject* renderer = n->renderer()) > > + renderer->setStyle(textBlockStyle); > > + } > > + > > + updateFromElement(); > > +} > > I know you must moved this from one class to another, but this function needs > some comments. It's unclear why updatePlaceholderVisibility needs to update the > style of all the renderers and then call updateFromElement. A comment could > explain the relationship. Also, we could consider moving code to set the text > block style into a separate function, since the name of that function would > help document it. I have addded a new method, setInnerTextStyle(). > > - if (result.innerNode() == node() || result.innerNode() == innerTextElement()) > > + HTMLTextAreaElement* textArea = static_cast(node()); > > + if (result.innerNode() == node() > > + || !textArea->placeholderShouldBeVisible() && result.innerNode() == innerTextElement() > > + || textArea->placeholderShouldBeVisible() && result.innerNode()->isDescendantOf(innerTextElement())) > > hitInnerTextElement(result, x, y, tx, ty); > > The way the formatting makes the clauses of the if statement line up with its > body makes things like this hard to read. > > I think you could consider fixing that by using a boolean local variable; the > name of the boolean could even help document a bit. I think the code also needs > a comment. The rule here is slightly unclear unless the reader really aware of > how placeholders should behave. Done. > I'm not so sure that it's great to move the m_placeholderVisible data member > into the RenderTextControl base class. While it's true that both derived > classes use it, the base class does not. In the next patch, RenderTextControl refers m_placeholderVisible. > > +RenderStyle* RenderTextControlMultiLine::parentStyle() Renamed it to textBaseStyle(). > > +protected: > > + virtual RenderStyle* parentStyle(); > > This can and should be private instead of protected. You can override a > function with a private function, and we should make things as private as > possible. If we ever did want to derive from this class we could make it > protected at that time. Fixed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:03:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:03:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27619] Switch wx to using waf for builds In-Reply-To: References: Message-ID: <20090811020338.B27A2349B3AC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27619 Kevin Ollivier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34326|0 |1 is obsolete| | --- Comment #31 from Kevin Ollivier 2009-08-10 19:03:35 PDT --- Created an attachment (id=34533) --> (https://bugs.webkit.org/attachment.cgi?id=34533) Changes to build-webkit, with Mark's comments addressed Should have all the pointed out issues addressed now. Note that I removed the svg option defaults code entirely in this revision because I only added it to silence the SVG feature print outs at the end of the build, which themselves were removed in r46641, meaning I no longer need to worry about the values they are set term in the short term. I'll revisit the options code when I make the options more configurable for wx. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:08:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:08:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27842] Implement GraphicsContext::fillRoundRect() for WINCE port In-Reply-To: References: Message-ID: <20090811020850.E6689349B44A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27842 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34516|commit-queue+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:11:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:11:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090811021114.DA5D7349B4A5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32114|0 |1 is obsolete| | Attachment #34534| |review? Flag| | --- Comment #12 from TAMURA, Kent 2009-08-10 19:11:12 PDT --- Created an attachment (id=34534) --> (https://bugs.webkit.org/attachment.cgi?id=34534) Proposed patch (rev.4) Sorry for the large patch. * The most of changes in HTMLInputElment, InputElment, WMLInputElement are trivial. (removal of unused parameters) * We have a bug about maxlength. The patch accidentally fixes it because of RenderTextControlSingleLine::updateFromElement() change. input-text-maxlength-expected.txt had wrong expected data. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:23:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:23:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090811022359.3B190349B5BC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34512|review? | Flag| | Attachment #34512|0 |1 is obsolete| | Attachment #34535| |review? Flag| | --- Comment #19 from Dumitru Daniliuc 2009-08-10 19:23:56 PDT --- Created an attachment (id=34535) --> (https://bugs.webkit.org/attachment.cgi?id=34535) patch Addressed Michael's comments. Also, Michael suggested that it might be better to make SQLTransaction::lockAcquire() schedule an immediate task on the DB thread for SQLTransaction::openTransactionAndPreflight(), instead of directly calling this method. I agreed and made this change too, by adding a bool parameter to Database::scheduleTransactionStep() that defaults to false (true = scheduleImmediateTask(), false = scheduleTask()). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:30:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:30:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811023019.7E0F8349B69C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #19 from Xiaomei Ji 2009-08-10 19:30:16 PDT --- Hi Jay, Thanks for your comments! Please see my reply inline. (In reply to comment #18) > Here are my comments on the patch: > > WebCore/platform/chromium/PopupMenuChromium.cpp > I think it would be better to make the RTL detection behavior not dependent on > m_settings.restrictWidthOfListBox and instead being a new parameter of > m_settings. > The idea would be to keep PopupMenuChromium generic and let the client decides > which heuristic to use. Make sense. I've updated. > > In paintRow() regarding the ellipsis code. That code seems non-specific to the > autofill. Would it make sense to have > GraphicsContext::drawBidiTextWithinWidth() draw the ellipsis (may be the method > could have an extra-parameter specifying whether or not an ellipsis is > desired)? > I am assuming the ellipsis ... is the same in all languages. If it is not, may > be the extra-param could be a string of the ellipsis to use? (empty string for > no ellipsis) Make sense. I've moved the code inside GraphaicsContext::drawBidiText(WithinWidth). And per Mitz's suggestion, I used StringTruncator instead of manually truncating the string and placing ellipses. The code is much elegant. One thing to note is that in StringTruncator, horizontal ellipses (U+2026) will always be drawn when text is truncated. I think that should be fine. Thanks, Xiaomei -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:36:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:36:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811023618.7B87B349B753@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34536| |review? Flag| | --- Comment #20 from Xiaomei Ji 2009-08-10 19:36:16 PDT --- Created an attachment (id=34536) --> (https://bugs.webkit.org/attachment.cgi?id=34536) patch w/ manual test updated patch per Jay and Mitz's suggestions: 1. add a new flag to indicate in what directionality text in popup will be drawn. 2. move draw ellispses with draw truncated text from PopupMenuChromium to GraphicsContext 3. use StringTruncator to prepare truncated text along with ellipses to be drawn. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 19:44:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 19:44:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090811024445.78E98349B800@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 --- Comment #3 from Ryan Leavengood 2009-08-10 19:44:45 PDT --- Maxime, You should also add yourself above Apple in the copyright section of this code (and other code you have written or modified.) Though since Eric alread r+ this, you can make some new patches later to fix up the copyrights. Or consider also making the change Eric suggested and make a new patch. It's up to you ;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 20:01:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 20:01:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811030112.3C147349B99D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #7 from Ryan Leavengood 2009-08-10 20:01:11 PDT --- (In reply to comment #6) > (From update of attachment 34418 [details]) > What is: > 85 BPoint m_point; > here? Is it the top-left of the menu? Is it the click-point? Seems it needs > a better member name. > > Otherwise this change looks fine. r- for lack of useful name or explanation > for m_point. If you were a committer I would just ask you to rename it to > something when you landed it instead of r-ing. As far as I can tell it isn't really used. It is assigned in the ContextMenu contructor but is otherwise not used. This is probably just more cruft from the old port that I should have helped Maxime purge :/ I'm not sure this context menu code even works at all at this point. I guess it is a start though. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 20:12:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 20:12:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090811031203.5EC11349BAA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34448|review? | Flag| | Attachment #34448|0 |1 is obsolete| | Attachment #34537| |review? Flag| | --- Comment #12 from Laszlo Gombos 2009-08-10 20:12:01 PDT --- Created an attachment (id=34537) --> (https://bugs.webkit.org/attachment.cgi?id=34537) 3rd try Additional changes in the 3rd revision of the patch: - LocalStorageDatabaseEnabled enum value is now deprecated, the new name is LocalStorageEnabled - LocalStoragePath now has a default (/LocalStorage/) Here are some reasons to keep the LocalStorage name (instead of switching to WebStorage). - The LocalStorageEnabled setting does not control SessionStorage and as such WebStorageEnabled name would be misleading - WebStorage is indeed the name of the specification, but the relevant JS interface is called window.localStrorage - I believe the JS interface name is equally/more relevant - WebStorage spec is referenced not only in the HTML5 spec but also in Widgets APIs and Events spec (see http://www.w3.org/TR/widgets-apis, widget.preferences). Since the interface that is defined in this patch is only for the HTML5 LocalStorage I think the name of the interface should be also specific to HTML5 to distinguish it from other WebStorage use-cases -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 20:22:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 20:22:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811032251.C4A92349BB72@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #8 from Ryan Leavengood 2009-08-10 20:22:50 PDT --- (In reply to comment #5) > (From update of attachment 34417 [details]) > Why virtual? > #if PLATFORM(HAIKU) > 175 virtual BBitmap* getBitmap() const; > 176 #endif > > Seems it should be createBBitmap()? Or is it actually a getter? in which case > it can be just bitmap(), no? Well all the other platforms seem to use the same pattern for their native bitmap getters: #if PLATFORM(MAC) // Accessors for native image formats. virtual NSImage* getNSImage(); virtual CFDataRef getTIFFRepresentation(); #endif #if PLATFORM(CG) virtual CGImageRef getCGImageRef(); #endif #if PLATFORM(WIN) virtual bool getHBITMAP(HBITMAP); virtual bool getHBITMAPOfSize(HBITMAP, LPSIZE); #endif #if PLATFORM(GTK) virtual GdkPixbuf* getGdkPixbuf(); #endif Maybe we just need to move ours up with these, I'm not sure why it is down on that line. > We generally don't use "get" in getters: > 388 pattern getHaikuStrokeStyle(); > > haikuStrokeStyle() > > unless that's createing something in which case it should be create. It looks > like it's just returning a stack object though, so it doesn't need "create" in > the name. That is generally the philosophy in Haiku's API for getters too, but in this case this is more of a converter function (to convert WebKit stroke styles into Haiku stroke styles.) I guess haikuStrokeStyle() would still be OK in this case. Or to be explicit: convertToHaikuStrokeStyle()? > Why is this needed? > #elif PLATFORM(HAIKU) > 82 Icon(); > 8183 #endif > please explain in the ChangeLog. Declaring a default constructor for a currently unimplemented class? > Seems like a bad idea: > #elif PLATFORM(HAIKU) > 127 IntPoint(const BPoint&); > 128 operator BPoint() const; > 124129 #endif > You don't wan implicit conversion of floating point points to integer points. > > Again, probably bad idea: > #elif PLATFORM(HAIKU) > 150 IntRect(const BRect&); > 151 operator BRect() const; > 147152 #endif > > Again: > #if PLATFORM(HAIKU) > 119 IntSize(const BSize&); > 120 operator BSize() const; > 121 #endif > > (this is all assuming that B* are floating point based). Yes all the B* classes above use floats. I guess it is better to make all these explicit? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 20:24:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 20:24:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090811032415.8D702349BBA5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34537|review? | Flag| | Attachment #34537|0 |1 is obsolete| | Attachment #34538| |review? Flag| | --- Comment #13 from Laszlo Gombos 2009-08-10 20:24:14 PDT --- Created an attachment (id=34538) --> (https://bugs.webkit.org/attachment.cgi?id=34538) 4th try. Found a typo in the 3rd path, please review this one instead. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:09:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:09:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811040900.C9CFA349BFCE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 Viet-Trung Luu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viettrungluu at gmail.com --- Comment #25 from Viet-Trung Luu 2009-08-10 21:08:56 PDT --- Darin, Safari/Mac appears to generate extra mouse move events for lots of things (including, e.g., mouse downs/ups), thereby avoiding a host of bugs. When scrolling using the keyboard, in Safari/Mac, the cursor (and tooltip) disappear, thereby eliminating a bunch of problems; actually, now that Chromium/Mac also makes the cursor (and consequently the tooltip, apparently) disappear, those same problems go away. Now, unfortunately, the mouse moving code (EventHandler::mouseMoved()/handleMouseMoveEvent()) are very tightly coupled with PlatformMouseEvent. To handle "virtual mouse moves", we need to at least do either (1) send fake mouse move events (ugly, but expedient) or (2) decouple the aforementioned code so that it can handle such "virtual mouse moves" without a PlatformMouseEvent (make an "EventHandler::mouseMovedVirtually()" method or some such). In some sense, the difference between (1) and (2) is cosmetic. You could decouple so far as to push a lot of the logic down into the layout, but that would be drastic and you'd have to make the layout aware of the mouse position. My first instinct to fix the scrolling-related issues is to hook up (1) or (2) in FrameView::valueChanged() (probably inside the "if (offset != scrollOffset())"). Similarly, you could do the same in FrameView::performPostLayoutTasks() -- I think this would probably handle any possible resize-related issues. (There are also possible window-movement issues -- i.e., the window moves without the mouse moving -- though I don't know offhand where that would get hooked up.) Hooking up a fake mouse event is expedient, if a little repugnant; decoupling the code is a bit fragile and goes pretty deep. (E.g., on resize, the mouse may end up over a scrollbar, so you can't just ignore the scrollbars.) Maybe I'll come up with a patch which sends a fake mouse event, and see if it works. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:09:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:09:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811040908.3A97F349BFF0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34536|review? |review- Flag| | --- Comment #21 from mitz at webkit.org 2009-08-10 21:09:06 PDT --- (From update of attachment 34536) Switching to StringTruncator is a move in the right direction, but I don’t think the GraphicsContext changes are good or necessary. GraphicsContext is not the place to create Strings and truncate them. The logical structure where drawBidiText calls drawBidiTextWithinWidth, which calls back into drawBidiText does not make much sense either. Also, if width != -1 (that is, the caller wants truncation), calling Font::floatWidth() once seems wasteful, as the StringTruncator should have the smarts to detect the case where no truncation is necessary. I think your PopupListBox should handle the truncation, create a TextRun from the potentially-truncated String, and call drawBidiText with that. I also don’t understand why you need the ellipsesNeeded member. It seems like you could just always use the StringTruncator. It won’t truncate when unnecessary. If you find out that you need to optimize, then you can cache the actual truncated strings (rather than just a bit telling you whether to truncate). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:11:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:11:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27790] XMLHTTPRequest Status Code 0 Bug In-Reply-To: References: Message-ID: <20090811041116.8D720349C024@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27790 Steve changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|INVALID | --- Comment #2 from Steve 2009-08-10 21:11:15 PDT --- I believe that your opinion that this is not actually a bug is incorrect. jQuery and Prototype's ajax functions also experience the exact same issue I've described in this bug report. I merely used my code to have something that ran self-contained. And the code I used has a javascript closure in it that should avoid the issue you pointed out. Regardless of that however, I just went back and tried again with the very latest copy of both prototype and jquery and this bug still exists. If an ajax request created via jquery or prototype is in progress, and you reload the page at the same time, Safari will cause the error handler to fire in both libraries. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:34:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:34:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27790] XMLHTTPRequest Status Code 0 Bug In-Reply-To: References: Message-ID: <20090811043438.B56D1349C188@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27790 --- Comment #3 from Alexey Proskuryakov 2009-08-10 21:34:38 PDT --- > And the code I used has a javascript closure in it that should avoid the issue > you pointed out. You don't get a new closure each time you call a function, no. > If an ajax request created via jquery or prototype is in progress, and you > reload the page at the same time, Safari will cause the error handler to fire > in both libraries. This sounds like something different than reported originally. The linked test doesn't even have an error event handler. Please clarify what exactly you report as a bug. If it's something different than reported originally, it's best to resolve this issue as INVALID and file a new one to avoid further confusion. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:36:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:36:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28170] New: SharedWorkers do not exit when the last parent document exits Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28170 Summary: SharedWorkers do not exit when the last parent document exits Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: WebCore JavaScript AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: atwilson at google.com Depends on: 28136 The SharedWorker lifecycle is tied to the lifecycle of its associated documents. When the last document associated with a SharedWorker exits, the worker needs to be shut down. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 21:51:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 21:51:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28170] SharedWorkers do not exit when the last parent document exits In-Reply-To: References: Message-ID: <20090811045103.B3D07349C2BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28170 Andrew Wilson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34539| |review? Flag| | AssignedTo|webkit-unassigned at lists.web |atwilson at google.com |kit.org | --- Comment #1 from Andrew Wilson 2009-08-10 21:51:03 PDT --- Created an attachment (id=34539) --> (https://bugs.webkit.org/attachment.cgi?id=34539) proposed patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:26:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:26:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811052615.70D3C349C57A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 --- Comment #26 from Viet-Trung Luu 2009-08-10 22:26:12 PDT --- Created an attachment (id=34540) --> (https://bugs.webkit.org/attachment.cgi?id=34540) Quick and dirty patch, as per my comments. For commentary only; no changelog entries. Only tested on Chromium/Mac. Hmm. The effect seems to be different from what happens in Safari/Mac (not for scrolling with arrow keys, but with trackpad/mousewheel -- see ). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:29:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:29:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27904] notImplemented() is too subtle In-Reply-To: References: Message-ID: <20090811052945.9AC6B349C5DC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27904 Jeremy Orlow changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:37:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:37:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27790] XMLHTTPRequest Status Code 0 Bug In-Reply-To: References: Message-ID: <20090811053751.73890349C652@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27790 Steve changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:40:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:40:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28123] WebKit could not copy the form with this parameter in the iframe In-Reply-To: References: Message-ID: <20090811054026.5ED50349C694@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28123 --- Comment #4 from Alexey Proskuryakov 2009-08-10 22:40:25 PDT --- Created an attachment (id=34541) --> (https://bugs.webkit.org/attachment.cgi?id=34541) reduction OK, I think that this is a reduction of the issue at hand. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:44:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:44:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20968] Crash in JSC::ProgramNode::~ProgramNode() in r36712 In-Reply-To: References: Message-ID: <20090811054411.375F7349C6F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20968 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WORKSFORME --- Comment #2 from Alexey Proskuryakov 2009-08-10 22:44:10 PDT --- JavaScriptCore has been all but rewritten since the bug was filed, so it doesn't look useful now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 22:45:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 22:45:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28123] File input value is not cloned by importNode() In-Reply-To: References: Message-ID: <20090811054514.D8E57349C6FE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28123 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 |P2 Status|UNCONFIRMED |NEW Component|JavaScriptCore |Forms Platform|PC |All Summary|WebKit could not copy the |File input value is not |form with this parameter in |cloned by importNode() |the iframe | Ever Confirmed|0 |1 OS/Version|Windows Server 2003 |All -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 23:43:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 23:43:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17730] Allows Windows version to use Curl In-Reply-To: References: Message-ID: <20090811064315.AA30C349CB25@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17730 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #13 from Brent Fulgham 2009-08-10 23:43:13 PDT --- This bug is no longer relevant. The cURL components are now fully building and running under the redistributable Windows port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 23:54:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 23:54:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20098] Cairo building - curl errors ResourceHandleManager.cpp In-Reply-To: References: Message-ID: <20090811065405.7AEFB349CC11@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20098 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from Brent Fulgham 2009-08-10 23:54:04 PDT --- I believe this bug is corrected in the current release. Please reopen if you continue to encounter this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 23:56:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 23:56:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18471] Fix WebDownload.cpp compile problems for cairo/curl build In-Reply-To: References: Message-ID: <20090811065614.94833349CC3D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18471 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED CC| |bfulgham at webkit.org AssignedTo|webkit-unassigned at lists.web |bfulgham at webkit.org |kit.org | Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 10 23:56:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 10 Aug 2009 23:56:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20732] -lws2_32 not -lWs2_32 In-Reply-To: References: Message-ID: <20090811065653.01259349CC67@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20732 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bfulgham at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 00:12:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 00:12:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28146] Allow Inspector's Number.toString to print low-resolution values In-Reply-To: References: Message-ID: <20090811071221.11BE0349CDE8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28146 --- Comment #3 from Mikhail Naganov 2009-08-11 00:12:19 PDT --- I'm working on the heap profiling page for Chromium. I have one place where I'm displaying memory stats (as a subtitle for memory snapshot items), and there I don't need excessive precision provided by the default version of Number.bytesToString. That's why I decided to provide 'low-res' argument to it. You can check out the current look of the Heap page here: http://build.chromium.org/buildbot/continuous/mac/2009-08-10/22915/chrome-mac.zip As I'm planning to upstream it to WebKit some day, so let's discuss it. The current view is very simple, I have more functionality to add. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 00:37:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 00:37:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] New: fix a typo in platform/graphics/skia/PlatformContextSkia.cpp Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28172 Summary: fix a typo in platform/graphics/skia/PlatformContextSkia.cpp Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hamaji at chromium.org If has the following line: #ifdef SK_DEBUGx The macro should be SK_DEBUG, I think. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 00:38:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 00:38:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] fix a typo in platform/graphics/skia/PlatformContextSkia.cpp In-Reply-To: References: Message-ID: <20090811073843.6B15D349D0A1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28172 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34543| |review? Flag| | --- Comment #1 from Shinichiro Hamaji 2009-08-11 00:38:42 PDT --- Created an attachment (id=34543) --> (https://bugs.webkit.org/attachment.cgi?id=34543) Patch v1 --- 2 files changed, 13 insertions(+), 1 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 00:41:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 00:41:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] fix a typo in platform/graphics/skia/PlatformContextSkia.cpp In-Reply-To: References: Message-ID: <20090811074142.406BE349D0DC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28172 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34543|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 01:09:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 01:09:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27899] [Gtk] Expose a database API In-Reply-To: References: Message-ID: <20090811080914.EB1D3349D39C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27899 --- Comment #2 from Martin Robinson 2009-08-11 01:09:14 PDT --- Created an attachment (id=34544) --> (https://bugs.webkit.org/attachment.cgi?id=34544) First pass at a database API I'm attaching my first pass to solicit comments from more experienced people. I'd love to get some feedback before I start preparing this patch for review. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 01:49:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 01:49:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090811084917.E657F349D69D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 Ariya Hidayat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ariya.hidayat at trolltech.com --- Comment #5 from Ariya Hidayat 2009-08-11 01:49:16 PDT --- I just added pixel tests support some time ago, so it is possible to add a test case to this patch. Check e.g. LayoutTests/fast/canvas/shadow-offset-* tests. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 02:32:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 02:32:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090811093237.6258C349DAB6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 Ariya Hidayat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34521|review? |review- Flag| | --- Comment #6 from Ariya Hidayat 2009-08-11 02:32:36 PDT --- (From update of attachment 34521) r- for now because of the missing pixel tests. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 02:42:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 02:42:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090811094221.6D683349DBAE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34545| |review? Flag| | --- Comment #1 from Fumitoshi Ukai 2009-08-11 02:42:20 PDT --- Created an attachment (id=34545) --> (https://bugs.webkit.org/attachment.cgi?id=34545) Add SocketStreamHandle interface --- 13 files changed, 736 insertions(+), 1 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 02:44:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 02:44:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28173] New: [GTK] Remove keyring optional features Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28173 Summary: [GTK] Remove keyring optional features Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: xan.lopez at gmail.com Per bug #26242, providing optional keyring support in webkitgtk+ itself can be quite problematic for distributors and application developers, and would force us to ship a runtime introspection system to see the features the library you are using has enabled. For that reason I propose to move the keyring support to libsoup instead, which already has a system like that, and where applications will be able to trivially choose to enable it or not. The only downside of this is that we'll need to figure out a way to store auth data from forms in keyring from applications/libsoup, since webkit won't be able to depend on it directly. I think that will be doable though, since other ports are already doing it. Attached is a first patch to use the extra auth support available in the 'keyring' branch in libsoup git. If this is approved we'll commit both this patch and that branch to master at the same time. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 02:51:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 02:51:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28173] [GTK] Remove keyring optional features In-Reply-To: References: Message-ID: <20090811095122.07A5A349DCAB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28173 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34546| |review? Flag| | AssignedTo|webkit-unassigned at lists.web |xan.lopez at gmail.com |kit.org | --- Comment #1 from Xan Lopez 2009-08-11 02:51:21 PDT --- Created an attachment (id=34546) --> (https://bugs.webkit.org/attachment.cgi?id=34546) removekeyring.patch Remove optional keyring support from WebKit, move it to libsoup. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 03:05:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 03:05:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090811100519.C9D3A349DE1A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34548| |review? Flag| | --- Comment #1 from Fumitoshi Ukai 2009-08-11 03:05:19 PDT --- Created an attachment (id=34548) --> (https://bugs.webkit.org/attachment.cgi?id=34548) WebSocket API implementation. depends on bug 28037 --- 20 files changed, 1277 insertions(+), 71 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 04:19:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 04:19:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090811111933.AA756349E6B2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 --- Comment #7 from Ariya Hidayat 2009-08-11 04:19:32 PDT --- Sorry, I pasted the wrong path. The pixel tests for this should be in LayoutTests/platform/mac/fast/box-shadow/ instead. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 04:39:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 04:39:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26390] WebKitGtk+/JavaScriptCore segfault on a specific page when built with gcc 4.4 In-Reply-To: References: Message-ID: <20090811113944.20A1B349E898@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26390 Adrian Bunk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #2 from Adrian Bunk 2009-08-11 04:39:42 PDT --- Just checked the status of this issue: Crashes still happen with 1.1.10. No crashes with 1.1.11 and 1.1.12. It seems whatever caused it was fixed in WebKitGTK+ 1.1.11. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 04:42:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 04:42:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811114218.D0061349E8EC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Zoltan Herczeg changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34265|review? | Flag| | Attachment #34265|0 |1 is obsolete| | Attachment #34549| |review?(darin at apple.com) Flag| | --- Comment #18 from Zoltan Herczeg 2009-08-11 04:42:13 PDT --- Created an attachment (id=34549) --> (https://bugs.webkit.org/attachment.cgi?id=34549) Fourth patch Actually WebCore is much better written than I expected, so uniforming the constant pointer handling is not that hard. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 04:45:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 04:45:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811114537.9ADCD349E964@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #19 from Zoltan Herczeg 2009-08-11 04:45:35 PDT --- After starting and quiting from QtLauncher, the leak reduced from: ==18154== LEAK SUMMARY: ==18154== definitely lost: 66,632 bytes in 496 blocks. ==18154== possibly lost: 25,536 bytes in 7 blocks. ==18154== still reachable: 241,690 bytes in 5,595 blocks. ==18154== suppressed: 0 bytes in 0 blocks. Number of loss records: 295 To: ==6905== LEAK SUMMARY: ==6905== definitely lost: 344 bytes in 2 blocks. ==6905== indirectly lost: 20 bytes in 1 blocks. ==6905== possibly lost: 744 bytes in 3 blocks. ==6905== still reachable: 117,418 bytes in 2,859 blocks. ==6905== suppressed: 0 bytes in 0 blocks. Number of loss records: 131 And 50k from this space is a debug structure used by StructureID-s. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:12:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:12:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28016] Web page freezes Qt Webkit In-Reply-To: References: Message-ID: <20090811121251.DE73A34A6B68@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28016 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laszlo.1.gombos at nokia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:13:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:13:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090811121335.0DEB134A72BF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laszlo.1.gombos at nokia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:27:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:27:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090811122748.3A31934ADB14@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34410|0 |1 is obsolete| | Attachment #34550| |review? Flag| | --- Comment #4 from Maxime Simon 2009-08-11 05:27:46 PDT --- Created an attachment (id=34550) --> (https://bugs.webkit.org/attachment.cgi?id=34550) Patch to add the ScrollbarTheme files for Haiku. Make some changes as suggested by Eric and Ryan, even if the previous patches was r+. I also made some style cleanup. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:49:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:49:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28174] New: Profile view status bar buttons are blank Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28174 Summary: Profile view status bar buttons are blank Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mnaganov at chromium.org CC: timothy at hatcher.name, pfeldman at chromium.org This bug was introduced in r46979. Profile view buttons (those shown below a profile view) wasn't updated to use createStatusBarButton method. As a result, they are blank. Trying to fix it naively, I've found that as profile view doesn't have a reference to a Profiles panel, it would need to access the createStatusBarButton function through WebInspector.panels.profiler, which isn't good. So I've decided to encapsulate glyph-based buttons into a new class. As an additional benifit, this allowed to encapsulate toggling and hiding functionality. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:55:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:55:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811125526.DDCD734AE66D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #9 from Maxime Simon 2009-08-11 05:55:25 PDT --- (In reply to comment #8) > (In reply to comment #5) > > (From update of attachment 34417 [details] [details]) > > Why virtual? > > #if PLATFORM(HAIKU) > > 175 virtual BBitmap* getBitmap() const; > > 176 #endif > > > > Seems it should be createBBitmap()? Or is it actually a getter? in which case > > it can be just bitmap(), no? > > Well all the other platforms seem to use the same pattern for their native > bitmap getters: > […] > > Maybe we just need to move ours up with these, I'm not sure why it is down on > that line. Even if we keep the "get" prefix, we should rename this function from getBitmap to getBBitmap (I can't see why I removed the B). Concerning the virtual, all other ports use it… (Yes I like mimicry.) > > Why is this needed? > > #elif PLATFORM(HAIKU) > > 82 Icon(); > > 8183 #endif > > please explain in the ChangeLog. > > Declaring a default constructor for a currently unimplemented class? Actually, I didn't check why we have this constructor. :-/ > > Seems like a bad idea: > > #elif PLATFORM(HAIKU) > > 127 IntPoint(const BPoint&); > > 128 operator BPoint() const; > > 124129 #endif > > You don't wan implicit conversion of floating point points to integer points. > > > > Again, probably bad idea: > > #elif PLATFORM(HAIKU) > > 150 IntRect(const BRect&); > > 151 operator BRect() const; > > 147152 #endif > > > > Again: > > #if PLATFORM(HAIKU) > > 119 IntSize(const BSize&); > > 120 operator BSize() const; > > 121 #endif > > > > (this is all assuming that B* are floating point based). > > Yes all the B* classes above use floats. I guess it is better to make all these > explicit? I changed this, it will be included in the next patches. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:55:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:55:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811125554.8B9A934AE693@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hamaji at chromium.org --- Comment #3 from Shinichiro Hamaji 2009-08-11 05:55:52 PDT --- I'd like to help this! Before I actually start, I'd like to check if I understand the requirements correctly. I think the first step of this bug is moving all resources/*.js files which aren't excluded by the list in make-js-test-wrappers into somewhere, fix all layout tests so that they reference the new location, and make-js-test-wrappers look the destination directory. Am I understanding correctly? Also, I'd like to know the better name for them. Maybe "js" or "scripts" ? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 05:59:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 05:59:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28174] Profile view status bar buttons are blank In-Reply-To: References: Message-ID: <20090811125919.58D3C34AE6EE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28174 Mikhail Naganov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34552| |review? Flag| | --- Comment #1 from Mikhail Naganov 2009-08-11 05:59:18 PDT --- Created an attachment (id=34552) --> (https://bugs.webkit.org/attachment.cgi?id=34552) Proposed change -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 06:21:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 06:21:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28175] New: HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28175 Summary: HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: laszlo.1.gombos at nokia.com The path separators in the path that is being passed to sqlite is not the native OS path; instead it is always the "/" - the Qt universal directory separator. Most OS (even Windows I think) understands the "/" separator - but not Symbian. The problem could be solved by calling QDir::toNativeSeparators() before the path is passed to the OS. The problem and the possible solution was brought to my attention by David Leong. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 06:27:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 06:27:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28175] HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit In-Reply-To: References: Message-ID: <20090811132744.C28E234AEA57@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28175 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34553| |review? Flag| | --- Comment #1 from Laszlo Gombos 2009-08-11 06:27:44 PDT --- Created an attachment (id=34553) --> (https://bugs.webkit.org/attachment.cgi?id=34553) proposed patch. WebCore::pathByAppendingComponent() seems to be a good place to call QDir::toNativeSeparators before the path is passed to the OS. All the path construction to sqlite DBs are going trough this function. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 06:42:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 06:42:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090811134251.436D234AEBE3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 --- Comment #14 from Kenneth Rohde Christiansen 2009-08-11 06:42:50 PDT --- I guess on Mac you should add the organization name to the path? like mentioned in the docs for QString QDesktopServices::storageLocation ( StandardLocation type ) Any mac guy have some input? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 06:48:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 06:48:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090811134852.DEBEA34AEC8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 --- Comment #15 from Kenneth Rohde Christiansen 2009-08-11 06:48:52 PDT --- (From update of attachment 34538) > + // Set HTML5 Application Cache default location > + QWebSettings::setOfflineWebApplicationCachePath(defaultCachePath()); I think we want to append /ApplicationCache or so. Simon, how do we hide the deprecated methods from the docs? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:08:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:08:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811140844.17B8334AEE86@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #10 from Maxime Simon 2009-08-11 07:08:42 PDT --- (In reply to comment #7) > (In reply to comment #6) > > (From update of attachment 34418 [details] [details]) > > What is: > > 85 BPoint m_point; > > here? Is it the top-left of the menu? Is it the click-point? Seems it needs > > a better member name. > > > > Otherwise this change looks fine. r- for lack of useful name or explanation > > for m_point. If you were a committer I would just ask you to rename it to > > something when you landed it instead of r-ing. > > As far as I can tell it isn't really used. It is assigned in the ContextMenu > contructor but is otherwise not used. This is probably just more cruft from the > old port that I should have helped Maxime purge :/ > > I'm not sure this context menu code even works at all at this point. I guess it > is a start though. Indeed, it's an unused variable. I removed it. It calculated the origin of each BMenuItem (if I'm right). But it seems not to be necessary now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:09:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:09:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090811140952.6799D34AEEA6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 --- Comment #8 from Ariya Hidayat 2009-08-11 07:09:50 PDT --- But of course, for the Qt port, we need LayoutTests/platform/qt/fast/box-shadow for the pixel test result. The actual test is in LayoutTests/fast/box-shadow/. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:19:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:19:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27842] Implement GraphicsContext::fillRoundRect() for WINCE port In-Reply-To: References: Message-ID: <20090811141947.4D67034AEFD2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27842 Crystal Zhang changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #22 from Crystal Zhang 2009-08-11 07:19:45 PDT --- Has been fixed and committed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:22:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:22:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811142237.8D33434AF039@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34418|0 |1 is obsolete| | Attachment #34554| |review? Flag| | --- Comment #11 from Maxime Simon 2009-08-11 07:22:36 PDT --- Created an attachment (id=34554) --> (https://bugs.webkit.org/attachment.cgi?id=34554) Patch to modify some WebCore/platform/ files to allow the Haiku port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:23:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:23:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28176] New: "document.documentElement.removeAttribute("style"); " occasionally silently fails. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28176 Summary: "document.documentElement.removeAttribute("style");" occasionally silently fails. Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptGlue AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: vincent at shoopz.com This bug happens on both releases of Safari 3.2.3 (Windows XP/Intel) and Safari 4.0.2 (Mac OS X 10.5.8/Intel and Windows XP/Intel). When first loaded my script does ----------------------------- document.documentElement.style.display = "none"; ----------------------------- to delay the display of the page. Later it does ----------------------------- document.documentElement.removeAttribute("style"); ----------------------------- This makes the page display correctly on IE 7,8 and FF3 but on Safari 3 and 4 the page stays blank as if the instruction had been discarded. This bug mysteriously disapears if the page is loaded while the Error Console is enabled under Safari 4 (both Win and Mac). In that case the page displays correctly. Suggested workaround: replacing the above line with ----------------------------- document.documentElement.style.display = ""; ----------------------------- makes it work, both with and without the Error Console enabled. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:28:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:28:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28176] "document.documentElement.removeAttribute("style"); " occasionally silently fails. In-Reply-To: References: Message-ID: <20090811142829.E992634AF0ED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28176 Jean-Noel Rivasseau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elvanor at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:34:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:34:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811143455.F3DCE34AF1A9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 --- Comment #5 from Maxime Simon 2009-08-11 07:34:54 PDT --- (In reply to comment #3) > Why does FontPlatformData use FontDescription at all? the Mac version doesn't > at least. Shouldn't this just wrap a BFont? At least the gtk port does it. But with some simple tests it seems that the type of FontDescription is always NoFamily. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:36:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:36:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090811143631.2BB3334AF1E6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34504|review? | Flag| | Attachment #34504|0 |1 is obsolete| | Attachment #34555| |review? Flag| | --- Comment #3 from Mike Fenton 2009-08-11 07:36:30 PDT --- Created an attachment (id=34555) --> (https://bugs.webkit.org/attachment.cgi?id=34555) Fix missing brace in previous patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:41:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:41:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28147] Qt build skips fast/borders/border-radius-split-inline.html when it is unnecessary In-Reply-To: References: Message-ID: <20090811144117.0C80434AF27C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28147 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34477|review? |review+, commit-queue? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:44:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:44:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811144454.9016134AF2E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34421|0 |1 is obsolete| | Attachment #34556| |review? Flag| | --- Comment #6 from Maxime Simon 2009-08-11 07:44:53 PDT --- Created an attachment (id=34556) --> (https://bugs.webkit.org/attachment.cgi?id=34556) Patch to add four font-specific files to WebCore/platform/graphics/haiku/. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:51:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:51:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090811145159.5E4E534AF3A0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34500|review? |review- Flag| | --- Comment #4 from Adam Treat 2009-08-11 07:51:58 PDT --- (From update of attachment 34500) This is awesome! I imagine this will fix quite a few tests :) A few comments: > + } else { > + qDebug() << ">>>>>>>>> keyDown" << string; Is this necessary? > + // map special keycode strings used by the tests to something that works for Qt/X11 > + if (string == "leftArrow") { string == QLatin1String("leftArrow") I think. r- to change. And then I'll land :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:55:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:55:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811145554.7FFBD34AF41F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34554|review? |review- Flag| | --- Comment #12 from Eric Seidel 2009-08-11 07:55:52 PDT --- (From update of attachment 34554) m_ for member variables: #if PLATFORM(MAC) 213218 WidgetPrivate* m_data; 219 #elif PLATFORM(HAIKU) 220 WidgetPrivate* data; 214221 #endif Otherwise this looks fine. If you were a committer I would r+ this and you could fix and land it yourself. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:58:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:58:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811145818.E438734AF484@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34554|0 |1 is obsolete| | Attachment #34557| |review? Flag| | --- Comment #13 from Maxime Simon 2009-08-11 07:58:17 PDT --- Created an attachment (id=34557) --> (https://bugs.webkit.org/attachment.cgi?id=34557) Patch to modify some WebCore/platform/ files to allow the Haiku port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 07:59:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 07:59:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090811145936.4F3F734AF4D3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 --- Comment #97 from Gabor Loki 2009-08-11 07:59:28 PDT --- Created an attachment (id=34558) --> (https://bugs.webkit.org/attachment.cgi?id=34558) a -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:01:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:01:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811150100.CF5EC34AF523@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34557|review? |review- Flag| | --- Comment #14 from Eric Seidel 2009-08-11 08:00:59 PDT --- (From update of attachment 34557) 220 WidgetPrivate* m_data; WidgetPrivate is never declared... so that won't compile, or? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:02:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:02:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811150216.E934034AF551@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34557|review- |review+, commit-queue+ Flag| | --- Comment #15 from Eric Seidel 2009-08-11 08:02:16 PDT --- (From update of attachment 34557) Nevermind. Looks fine. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:04:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:04:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811150415.7D4A734AF5A5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #16 from Maxime Simon 2009-08-11 08:04:14 PDT --- (In reply to comment #14) > (From update of attachment 34557 [details]) > 220 WidgetPrivate* m_data; > > WidgetPrivate is never declared... so that won't compile, or? Indeed… As I was changing data to m_data I saw that WidgetPrivate is never declared, but what it compiles without problem anyway… :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:05:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:05:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811150558.D2E6934AF5E5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #17 from Eric Seidel 2009-08-11 08:05:57 PDT --- It's forward declared at the top of the file. I hope you're not just adding these members because other ports have them? Code should only be added when it's actually used.... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:07:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:07:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811150742.7FB8B34AF62F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #18 from Maxime Simon 2009-08-11 08:07:41 PDT --- (In reply to comment #17) > It's forward declared at the top of the file. > > I hope you're not just adding these members because other ports have them? > Code should only be added when it's actually used.... No, that's because we used to have it. Since then I modify the port I forgot to remove it. I'll submit a new patch without this WidgetPrivate. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:10:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:10:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811151050.78D5F34AF699@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #19 from Eric Seidel 2009-08-11 08:10:49 PDT --- It seems like you all are close to having all of your files upstreamed. Have you started work on build-webkit integration and a DumpRenderTree? Having working layout tests (aka having a DumpRenderTree implementation) is an essential part of being a port which is long-term successful. w/o layout tests the port will be broken again in a matter of weeks. :( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:14:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:14:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811151412.F24E434AF72D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #20 from Maxime Simon 2009-08-11 08:14:11 PDT --- (In reply to comment #19) > It seems like you all are close to having all of your files upstreamed. Have > you started work on build-webkit integration and a DumpRenderTree? Having > working layout tests (aka having a DumpRenderTree implementation) is an > essential part of being a port which is long-term successful. w/o layout tests > the port will be broken again in a matter of weeks. :( I have a working version of DumpRenderTree but I didn't implement all the tests. Concerning build-webkit I didn't make anything. Currently we are using Jamfiles, but we want to change this and use GYP instead (we must write a backend to generate Jamfiles). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:18:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:18:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811151815.86DF234AF7CC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34557|0 |1 is obsolete| | Attachment #34559| |review? Flag| | --- Comment #21 from Maxime Simon 2009-08-11 08:18:14 PDT --- Created an attachment (id=34559) --> (https://bugs.webkit.org/attachment.cgi?id=34559) Patch to modify some WebCore/platform/ files to allow the Haiku port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:22:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:22:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090811152227.2A78A34AF879@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gabor Loki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34129|0 |1 is obsolete| | Attachment #34130|0 |1 is obsolete| | Attachment #34558|0 |1 is obsolete| | Attachment #34560| |review? Flag| | --- Comment #98 from Gabor Loki 2009-08-11 08:22:20 PDT --- Created an attachment (id=34560) --> (https://bugs.webkit.org/attachment.cgi?id=34560) Add optimize call and property access support for ARM JIT I have done the requested changes from comment #93. - The 'latePatch' method is removed. It looks like that forcing the address of calls on constant pool does not hurt much. Wash on SunSpider (slightly slower but not statistically significant). - The {BEGIN,END}_UNINTERRUPTED_SEQUENCE macros have been introduced for tightly coupled sequences. I try to keep the code as platform independent as possible. - The optimize call and property access patches are combined. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:27:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:27:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811152749.51A1C34AF917@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 --- Comment #7 from Maxime Simon 2009-08-11 08:27:48 PDT --- (In reply to comment #4) > It seems the handling of m_smallCapsFontData is wrong on other ports. But I'm > not convinced your handling is correct either. It certainly is strange that > SimpleFontData.cpp would try to delete it too. I took a look on other ports. It seems that gtk, win, wince, wx and mac are handling m_smallCapsFontData the same way I do (if I'm right). But in fact it could be wrong. > What is an "escapement"? Wow a B-only term it seems: > http://www.acm.uiuc.edu/bug/Be%20Book/The%20Interface%20Kit/Font.html Eh Eh, an escapement is the B-term to design the width of a glyph. ;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:34:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:34:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811153439.C0FF634AF9BB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 --- Comment #8 from Maxime Simon 2009-08-11 08:34:38 PDT --- (In reply to comment #4) > Shouldn't char* out be char[4]& out? I tried with char[4]& but it didn't compile. I got this output "error: 'out' was not declared in this scope." > Why is the const_cast needed? > 79 GlyphBufferGlyph* glyphs = > const_cast(glyphBuffer.glyphs(from)); This const_cast is needed because the glyphBuffer argument of the function is const, and the glyphs we are creating will be modified. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:38:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:38:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090811153848.B73BC34AFA29@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 --- Comment #2 from David Levin 2009-08-11 08:38:47 PDT --- (From update of attachment 34545) Simply a style pass. I looked at this and saw a few style issues to clean up. > diff --git a/WebCore/platform/network/SocketStreamErrorBase.h b/WebCore/platform/network/SocketStreamErrorBase.h > + class SocketStreamErrorBase { > + public: public:, private:, protected: should be aligned with "class". There are multiple instances but I'm only commenting on this one. > + SocketStreamErrorBase() > + : m_errorCode(0) > + , m_isNull(true) These should only be indented 4 spaces (not 8). There are multiple instances but I'm only commenting on this one. > diff --git a/WebCore/platform/network/SocketStreamHandle.h b/WebCore/platform/network/SocketStreamHandle.h > + virtual int platformSend(const char*, int); Please include parameter names for this method. Parameter names are omitted when they don't add information. In this case, they would add information. > diff --git a/WebCore/platform/network/SocketStreamHandleBase.cpp b/WebCore/platform/network/SocketStreamHandleBase.cpp > +bool SocketStreamHandleBase::send(const char* buf, int size) s/buf/buffer/ Use full words for variables. > + int num_written = 0; s/num_written/bytesWritten/ bad casing. > +void SocketStreamHandleBase::setClient(SocketStreamHandleClient* client) > +{ Consider adding asserts here. Can this be called in any state? Can it be called after a client has already been set? > +bool SocketStreamHandleBase::sendPendingData() > +{ > + if (m_state != Open) > + return false; > + if (m_buffer.isEmpty()) > + return false; > + int num_written = platformSend(m_buffer.data(), m_buffer.size()); s/num_written/bytesWritten/ bad casing. > + Vector remaining_data; s/remaining_data/remainingData/ bad casing. > + remaining_data.append(m_buffer.data() + num_written, > + m_buffer.size() - num_written); Indentation mistake. > diff --git a/WebCore/platform/network/SocketStreamHandleBase.h b/WebCore/platform/network/SocketStreamHandleBase.h > + virtual ~SocketStreamHandleBase() {} s/{}/{ }/ Add a space in the {} > + bool send(const char*, int); Please include parameter names for this method. > + virtual int platformSend(const char*, int) = 0; Please include parameter names for this method. > diff --git a/WebCore/platform/network/SocketStreamHandleClient.h b/WebCore/platform/network/SocketStreamHandleClient.h > + virtual void willSendData(SocketStreamHandle*, const char*, int) { } Please include parameter names for the char* and int. > + virtual void didReceivedData(SocketStreamHandle*, const char*, int) { } Please include parameter names for the char* and int. > diff --git a/WebCore/platform/network/mac/SocketStreamError.h b/WebCore/platform/network/mac/SocketStreamError.h > + SocketStreamError() {} s/{}/{ }/ > diff --git a/WebCore/platform/network/mac/SocketStreamHandleMac.mm b/WebCore/platform/network/mac/SocketStreamHandleMac.mm > + SocketStreamHandleInternal() {} > + ~SocketStreamHandleInternal() {} s/{}/{ }/ > diff --git a/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp b/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp > +class SocketStreamHandleInternal { > +public: > + SocketStreamHandleInternal() {} > + ~SocketStreamHandleInternal() {} s/{}/{ }/ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:44:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:44:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811154430.BC08234AFACB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34422|0 |1 is obsolete| | Attachment #34561| |review? Flag| | --- Comment #9 from Maxime Simon 2009-08-11 08:44:30 PDT --- Created an attachment (id=34561) --> (https://bugs.webkit.org/attachment.cgi?id=34561) Patch to add four other font-specific files to WebCore/platform/graphics/haiku/. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:49:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:49:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090811154950.6BA6A34AFB34@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34500|0 |1 is obsolete| | Attachment #34562| |review? Flag| | --- Comment #5 from Mike Fenton 2009-08-11 08:49:49 PDT --- Created an attachment (id=34562) --> (https://bugs.webkit.org/attachment.cgi?id=34562) Revised code change wrapping strings with QLatin1String() -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:50:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:50:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811155040.D2EEC34AFB5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yong.li at torchmobile.com --- Comment #20 from Yong Li 2009-08-11 08:50:37 PDT --- Is there a specified webkit name pattern for global variables? In this patch, I've seen both "foo" (same as local variables) and "gFoo". I use "g_Foo" in my code, but Eric says it's wrong. So what pattern should be used for global variables? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 08:51:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 08:51:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811155129.6D8E334AFBA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #21 from Yong Li 2009-08-11 08:51:27 PDT --- (In reply to comment #20) > Is there a specified webkit name pattern for global variables? In this patch, > I've seen both "foo" (same as local variables) and "gFoo". I use "g_Foo" in my > code, but Eric says it's wrong. So what pattern should be used for global > variables? correction: should be "g_foo" -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:03:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:03:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090811160350.59D0434AFD3D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 --- Comment #3 from David Levin 2009-08-11 09:03:49 PDT --- (From update of attachment 34545) Two more style comments: > + /* static */ WebKit doesn't do this. > + int SocketStreamHandle::platformSend(const char *, int) * goes near the type -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:04:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:04:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28129] [Haiku] Adding three new files to WebCore/platform/haiku. In-Reply-To: References: Message-ID: <20090811160415.7352334AFD52@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28129 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34419|0 |1 is obsolete| | Attachment #34563| |review? Flag| | --- Comment #3 from Maxime Simon 2009-08-11 09:04:14 PDT --- Created an attachment (id=34563) --> (https://bugs.webkit.org/attachment.cgi?id=34563) Patch to add three new files to WebCore/platform/haiku/ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:04:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:04:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28177] New: WebInspector: Migrate to DOMAgent (serialized access to DOM) Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28177 Summary: WebInspector: Migrate to DOMAgent (serialized access to DOM) Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pfeldman at chromium.org CC: timothy at hatcher.name This is a large change that wires all the pieces of the migration together. What we already have: - There is a InspectorDOMAgent / DOMAgent infrastructure that replicates DOM structure to the Web Inspector's Elements Pane. - There is a Styles and Properties sidebar panels that interact with the page in serialized way. What is missing: 1) We are using quarantined nodes, not DOMAgent yet 2) Console evaluation and console.log push quarantined JS objects into the frontend. They should push proxy objects instead This change is supposed to fix these. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:08:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:08:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090811160812.1212A34AFDEA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34545|review? |review- Flag| | --- Comment #4 from Alexey Proskuryakov 2009-08-11 09:08:11 PDT --- (From update of attachment 34545) > + if (num_written < size) > + m_buffer.append(buf + num_written, size - num_written); I think that we need a (large) upper limit on buffer size - it's too easy to send data faster than network permits, exhausting system memory and making the system unresponsive. Certainly, there are many other ways to exhaust memory via JavaScript, so it would be just a safety net, not a real security measure. > + remaining_data.append(m_buffer.data() + num_written, > + m_buffer.size() - num_written); As David pointed out, this is an indentation mistake - but there's no need to split the line anyway, it's quite short. Looks good to me in general. I'm not sure if I'm not stepping on Dave's toes here, but r- to address the comments. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:12:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:12:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090811161238.6F66834AFE7D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34550|review? | Flag| | Attachment #34550|0 |1 is obsolete| | Attachment #34564| |review? Flag| | --- Comment #5 from Maxime Simon 2009-08-11 09:12:37 PDT --- Created an attachment (id=34564) --> (https://bugs.webkit.org/attachment.cgi?id=34564) Patch to add the ScrollbarTheme files for Haiku. Sorry, the previous had a mistake. I changed scrollbar->height() to scrollbar->width(), so it didn't display correctly the back button. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:13:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:13:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28177] WebInspector: Migrate to DOMAgent (serialized access to DOM) In-Reply-To: References: Message-ID: <20090811161311.B712534AFE96@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28177 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34565| |review? Flag| | Status|UNCONFIRMED |ASSIGNED AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | Ever Confirmed|0 |1 --- Comment #1 from Pavel Feldman 2009-08-11 09:13:10 PDT --- Created an attachment (id=34565) --> (https://bugs.webkit.org/attachment.cgi?id=34565) Step1: Most of the work done. Call for your comments. The general idea of this patch is that we stop pushing live objects into the frontend upon evaluation and console.dir requests. It also migrates to WebInspector.DOMAgent. Patch is not complete: - it does not implement DOM search - it breaks commandLineAPI's inspect(o). But it already has a lot of changes and I would like to get initial feedback on it. I am fixing the ones above in the meanwhile. What will happen after this change: - More bugfixes if I miss anything - Move search worker into the InjectedScript - Look at debugging, database and the rest of the places that still push live objects into the frontend - Move InjectedScript into the isolated context and get rid of all the "quarantine*" calls and support. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:16:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:16:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811161627.ABB2534AFF12@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34559|review? |review+, commit-queue+ Flag| | --- Comment #22 from Eric Seidel 2009-08-11 09:16:26 PDT --- (From update of attachment 34559) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:17:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:17:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090811161732.292C634AFF46@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |levin at chromium.org Ever Confirmed|0 |1 --- Comment #5 from David Levin 2009-08-11 09:17:30 PDT --- > I'm not sure if I'm not stepping on Dave's toes... Not at all. I simply noticed some styling issues and thought I'd point them out (in case he was able to get to them before the "real" review). I should have made this more clear. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:30:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:30:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28146] Allow Inspector's Number.toString to print low-resolution values In-Reply-To: References: Message-ID: <20090811163008.0C87434B00BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28146 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34450|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:33:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:33:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28174] Profile view status bar buttons are blank In-Reply-To: References: Message-ID: <20090811163310.99D9634B010A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28174 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34552|review? |review- Flag| | --- Comment #2 from Timothy Hatcher 2009-08-11 09:33:10 PDT --- (From update of attachment 34552) I like the new class, but it should go into it's own file and not part of Panel.js. Also I think toggled would be a better name for the getter/setter than toggledOn. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:34:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:34:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811163406.A3F2D34B0145@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34420|0 |1 is obsolete| | Attachment #34566| |review? Flag| | --- Comment #3 from Maxime Simon 2009-08-11 09:34:05 PDT --- Created an attachment (id=34566) --> (https://bugs.webkit.org/attachment.cgi?id=34566) Patch to add four image-specific files to WebCore/platform/graphics/. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:37:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:37:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090811163732.8DD7434B0174@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34567| |review? Flag| | --- Comment #1 from George Wright 2009-08-11 09:37:31 PDT --- Created an attachment (id=34567) --> (https://bugs.webkit.org/attachment.cgi?id=34567) Fix zooming This patch makes the canvas element parser add CSS properties for the width and height in the same manner as the image element parser does, thus allowing the canvas to scale properly. It also removes a superfluous zoomedSize declaration which is never used. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:43:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:43:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811164325.2076434B0232@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34568| |review? Flag| | --- Comment #4 from Maxime Simon 2009-08-11 09:43:24 PDT --- Created an attachment (id=34568) --> (https://bugs.webkit.org/attachment.cgi?id=34568) Patch to add GraphicsContext to WebCore/platform/graphics/haiku. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:44:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:44:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] New: WINCE PORT: implement MediaPlayerProxy Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28178 Summary: WINCE PORT: implement MediaPlayerProxy Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Platform AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yong.li at torchmobile.com CC: staikos at kde.org, treat at kde.org, crystal.zhang at torchmobile.com separated from bug 27511 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:44:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:44:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] WINCE PORT: implement MediaPlayerProxy In-Reply-To: References: Message-ID: <20090811164455.2344B34B0272@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28178 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27511 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:44:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:44:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090811164456.CCB1A34B0286@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28178 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:45:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:45:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090811164515.98C3634B02A2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34396|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:48:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:48:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28147] Qt build skips fast/borders/border-radius-split-inline.html when it is unnecessary In-Reply-To: References: Message-ID: <20090811164852.31DD534B0314@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28147 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34477|review+, commit-queue? | Flag| | Attachment #34477|0 |1 is obsolete| | --- Comment #4 from Kenneth Rohde Christiansen 2009-08-11 09:48:51 PDT --- (From update of attachment 34477) Landed in 47034 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:49:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:49:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] WINCE PORT: implement MediaPlayerProxy In-Reply-To: References: Message-ID: <20090811164908.BC05B34B0321@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28178 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34569| |review? Flag| | --- Comment #1 from Yong Li 2009-08-11 09:49:08 PDT --- Created an attachment (id=34569) --> (https://bugs.webkit.org/attachment.cgi?id=34569) The patch with more coding style modification including George's suggestions. explicit Vector::clear() on local Vector objects are removed because they are not necessary. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:49:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:49:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28147] Qt build skips fast/borders/border-radius-split-inline.html when it is unnecessary In-Reply-To: References: Message-ID: <20090811164911.896F734B032D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28147 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |kenneth.christiansen at openbo | |ssa.org Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:49:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:49:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811164920.333B934B033B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #23 from Eric Seidel 2009-08-11 09:49:18 PDT --- I've updated https://trac.webkit.org/wiki/SuccessfulPortHowTo for Haiku (and other ports) benefit. You should feel encouraged to update it further! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:50:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:50:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811165033.C7DD534B0381@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34549|review?(darin at apple.com) |review- Flag| | --- Comment #22 from Darin Adler 2009-08-11 09:50:30 PDT --- (From update of attachment 34549) > +#include "wtf/StaticPtr.h" Includes of wtf from WebCore use angle brackets. , not "wtf/StaticPtr.h". > +static WTF::StaticPtr sharedInstancePtr; This won't work with the restrictions we need to work as a Mac OS X framework. We can't have any static destructors in our Mac OS X system frameworks as a matter of policy to make process exit fast. No objects with destructors as globals or statics. That's the reason for the DEFINE_STATIC_LOCAL macro. A major reason this patch is unacceptable is that this creates many global objects with destructors. I didn't review further because that's a major problem with the current version. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:50:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:50:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28150] WINCE PORT: Image Encoders In-Reply-To: References: Message-ID: <20090811165052.4D3AC34B039D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28150 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pkasting at google.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:51:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:51:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27255] Geolocation incorrectly calls error callback in case of exception in success callback In-Reply-To: References: Message-ID: <20090811165113.30B8934B03B5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27255 --- Comment #10 from Eric Seidel 2009-08-11 09:51:12 PDT --- (From update of attachment 33532) This needs a layout test. Otherwise it looks fine. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:51:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:51:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090811165141.9A3E734B03D7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34548|review? |review- Flag| | --- Comment #2 from Alexey Proskuryakov 2009-08-11 09:51:40 PDT --- (From update of attachment 34548) + $(WebCore)/websockets \ $(WebCore)/svg \ $(WebCore)/websockets \ It's already there. + WebCore/websockets/WebSocketRequest.cpp \ + WebCore/websockets/WebSocketRequest.h \ + WebCore/websockets/WebSocketResponse.cpp \ + WebCore/websockets/WebSocketResponse.h This looks quite wrong - WebSocket does not use a request/response model, so such class names are highly misguiding. +#if ENABLE(WEB_SOCKETS) +#include "JSWebSocket.h" +#include "WebSocket.h" In some places, generated files are included without guards, and in others, with guards. The guards are only needed if the headers are not generated in ports that do not have this feature enabled - otherwise, similar guards within headers themselves would do the job. There's never a need to protect e.g. WebSocket.h with external include guards. +bool IsValidProtocolString(const WebCore::String& protocol) This should be static, and inside the WebCore namespace. We don't normally use anonymous namespaces. + // FIXME: need dispatchEvent? Absolutely - it will dispatch to handlers installed via addEventListener(), as opposed to setting socket.onopen or similar. +bool CheckWebSocketHandshake(const WebCore::WebSocketRequest &req, const WebCore::WebSocketResponse& resp) Capitalization, argument naming, '&' positioning. This should also be static. There are many style issues in protocol implementation, I'm not pointing out most, because they are the same as in other patches. + // FIXME: handle overflow. Please do! +KURL WebSocketRequest::URLoverHTTP() const In WebKit style, this would be urlOverHTTP. I'm not sure what this is use for though, hopefully an even better name can be found. + if (url().hasFragmentIdentifier()) { + builder.append("#"); + builder.append(url().fragmentIdentifier()); + } What are fragment identifiers good for when using WebSockets? Seems that they should be forbidden, or dropped immediately when passed in. +const char* WebSocketResponse::parseHeader(const char* start, const char* end, Vector >* headers) Are WebSockets headers case sensitive? Otherwise, it may be better to use HTTPHeaderMap. I didn't closely review all the code; please fix style, possibly using check-webkit-style script. The direction looks good to me, except for request/response classes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:52:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:52:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090811165218.B6CBD34B041F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenneth.christiansen at openbo | |ssa.org --- Comment #99 from Kenneth Rohde Christiansen 2009-08-11 09:52:12 PDT --- Aint the two r+ patches already committed? If so, please clear the flag. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:52:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:52:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811165226.74E5734B0437@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org, | |yong.li at torchmobile.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:53:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:53:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090811165300.633C334B044F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34567|review? |review- Flag| | --- Comment #2 from Dave Hyatt 2009-08-11 09:52:59 PDT --- (From update of attachment 34567) I think it's better to patch the initial intrinsic size on the rendering side. I don't think you have to touch the DOM element. This patch is flawed since it doesn't zoom omitted attributes (that should default to 300 and 150 but then be zoomed). Need a test case also obviously. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:54:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:54:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811165445.6118434B04AC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 --- Comment #2 from Eric Seidel 2009-08-11 09:54:44 PDT --- (From update of attachment 34519) You mentioned in the other bug, that BufferedImage could be implemented by BitmapImage by implementing a BitmapImage(NativeImagePtr) constructor. Why would we not want to do that? I expect you could encounter later porting problems being the only port with a special BitmapImage-like-thing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 09:59:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 09:59:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090811165919.2C62434B0527@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34570| |review? Flag| | --- Comment #5 from Maxime Simon 2009-08-11 09:59:18 PDT --- Created an attachment (id=34570) --> (https://bugs.webkit.org/attachment.cgi?id=34570) Patch to add ImageSource to WebCore/platform/graphics/haiku. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:02:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:02:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27255] Geolocation incorrectly calls error callback in case of exception in success callback In-Reply-To: References: Message-ID: <20090811170229.2CF0134B0581@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27255 --- Comment #11 from steveblock at google.com 2009-08-11 10:02:28 PDT --- > This needs a layout test. Adding a layout test for this change requires a mock implementation of GeolocationService such that we can guarantee that the success callback is called. I plan to add such a mock implementation (and hooks for DumpRenderTree) as part of Bug 27716, but it might take a while to get the whole framework in place. Would it be OK to submit this patch now, but leave the bug open to add the layout tests once the mock GeolocationService is in place? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:04:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:04:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811170433.5099434B05E1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 --- Comment #3 from Yong Li 2009-08-11 10:04:31 PDT --- (In reply to comment #2) > (From update of attachment 34519 [details]) > You mentioned in the other bug, that BufferedImage could be implemented by > BitmapImage by implementing a BitmapImage(NativeImagePtr) constructor. Why > would we not want to do that? I expect you could encounter later porting > problems being the only port with a special BitmapImage-like-thing. Because I think that is ugly. BitmapImage is too powerful. It is designed to receive encoded image data, decode the data with ImageSource, display the frames even they are just partially decoded, and animate with multiple frames and correct time intervals... All of these are not necessary for ImageBuffer. ImageBuffer just holds a single-frame flat decoded buffer (or platform native image). That's why ImageBuffer::image() returns Image* but not BitmapImage*, because BitmapImage is much more than necessary. So I think other ports should also do the similiar thing: using a light class like BufferedImage. It is very simple, and doesn't required too much coding. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:04:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:04:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811170458.6516334B05F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pkasting at google.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:13:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:13:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811171347.AF87C34B0736@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 --- Comment #4 from Yong Li 2009-08-11 10:13:46 PDT --- Furthermore, I think the best way is let ImageBuffer be a subclass of Image. It's just used for rendering purpose -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:13:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:13:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27995] LayoutTests are too slow In-Reply-To: References: Message-ID: <20090811171340.29C1934B0728@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27995 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34105|0 |1 is obsolete| | Attachment #34108|0 |1 is obsolete| | --- Comment #9 from Eric Seidel 2009-08-11 10:13:38 PDT --- Created an attachment (id=34573) --> (https://bugs.webkit.org/attachment.cgi?id=34573) r47037, slowest 1000 tests (Release build on a Mac Pro) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:14:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:14:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27998] http/tests/cache/subresource-expiration.html uses 4.5 seconds of delay In-Reply-To: References: Message-ID: <20090811171432.0005D34B076D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27998 --- Comment #2 from Eric Seidel 2009-08-11 10:14:31 PDT --- Yup, still the slowest test by over a second. :) https://bugs.webkit.org/attachment.cgi?id=34573 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:20:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:20:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811172014.47F0034B0817@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #4 from Darin Adler 2009-08-11 10:20:12 PDT --- (In reply to comment #3) > I think the first step of this bug is moving all resources/*.js files which > aren't excluded by the list in make-js-test-wrappers into somewhere, fix all > layout tests so that they reference the new location, and make-js-test-wrappers > look the destination directory. Am I understanding correctly? > > Also, I'd like to know the better name for them. Maybe "js" or "scripts" ? I think "scripts" is not a good name, because the whole point is that these are "script tests", not just scripts. Maybe "jstests" is OK, or "js-tests" or "script-tests". The way I'd do it is: 1) Change make-js-test-wrappers to work for tests in directories either named "resources" or the new name. 2) Move one test with "svn mv". Run make-js-test-wrappers. Check in the new top level .html file and the test in the new location. 3) If everything went well after (2), then repeat (2) for all other tests. As you say above, all the resources/*.js files that are not in the excluded list. 4) Remove the support for directories named "resources" in make-js-test-wrappers and remove the exception list as well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:20:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:20:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] New: Shortcuts on webpages don't work if the Qt application has the same shortcut Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28179 Summary: Shortcuts on webpages don't work if the Qt application has the same shortcut Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ben at meyerhome.net Google docs has the shortcut Ctrl+s to save your document, but if the application using QWebPage has a shortcut for Ctrl+S (Save As typically) the QWebPage will not get the key press and the QShortcut will be fired instead. Manualtest: Using arora where ctrl+s is set to Save As Notes: This was the Google Docs bug reported in the Arora review on cnet http://crave.cnet.co.uk/software/0,39029471,49303237-3,00.htm -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:22:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:22:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27904] notImplemented() is too subtle In-Reply-To: References: Message-ID: <20090811172221.B650234B0855@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27904 --- Comment #3 from Alexey Proskuryakov 2009-08-11 10:22:20 PDT --- My understanding is that even ports that are quite mature still hit notImplemented() fairly often - in particular, on notification calls for Web Inspector and such. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:23:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:23:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811172341.52F7134B08AF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #5 from Eric Seidel 2009-08-11 10:23:39 PDT --- Obviously step 2 can be scripted once it's tested. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:24:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:24:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811172417.5B6CD34B08CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #6 from Eric Seidel 2009-08-11 10:24:15 PDT --- I vote for "script-tests" as the name. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:25:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:25:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811172503.9C78034B08EE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #7 from Eric Seidel 2009-08-11 10:25:02 PDT --- (Although eventually we'll want to rename make-js-test-wrappers if we use "script-tests".) Thanks again for looking at this! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:25:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:25:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090811172505.0336E34B08FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 Benjamin Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34575| |review? Flag| | --- Comment #1 from Benjamin Meyer 2009-08-11 10:25:04 PDT --- Created an attachment (id=34575) --> (https://bugs.webkit.org/attachment.cgi?id=34575) possible fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:25:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:25:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090811172519.22E2F34B0909@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 Benjamin Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hausmann at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:25:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:25:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090811172537.CCF5234B0919@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 Benjamin Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenneth.christiansen at openbo | |ssa.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:26:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:26:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811172607.7680A34B0932@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34417|0 |1 is obsolete| | Attachment #34576| |review? Flag| | --- Comment #24 from Maxime Simon 2009-08-11 10:26:05 PDT --- Created an attachment (id=34576) --> (https://bugs.webkit.org/attachment.cgi?id=34576) Patch to modify some WebCore/platform/graphics files to allow the Haiku port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:27:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:27:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28167] WINCE PORT: Implement ImageBuffer In-Reply-To: References: Message-ID: <20090811172708.79E9034B0962@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28167 --- Comment #5 from Eric Seidel 2009-08-11 10:27:07 PDT --- ImageBuffer and Image are used for different things. ImageBuffer is a bag of bytes, designed to store image data, and used for things which need direct access to bit maps. Image is an opaque image pointer which could be backed by an ImageBuffer, or any other sort of storage. Image might also not even be a bitmap image (in the case of SVG or PDF), so it might not have a fixed size. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:28:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:28:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811172857.A5D5234B0998@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #25 from Maxime Simon 2009-08-11 10:28:56 PDT --- (In reply to comment #24) > Created an attachment (id=34576) --> (https://bugs.webkit.org/attachment.cgi?id=34576) [details] > Patch to modify some WebCore/platform/graphics files to allow the Haiku port. I forgot some comments on this patch, - I renamed getBitmap to getBBitmap. - I didn't change the getHaikuStrokeStyle name. - I put some explanations for the empty Icon constructor. - I changed the Int* constructors so they are explicit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:29:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:29:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090811172911.9715134B09A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34577| |review? Flag| | --- Comment #6 from Mike Fenton 2009-08-11 10:29:10 PDT --- Created an attachment (id=34577) --> (https://bugs.webkit.org/attachment.cgi?id=34577) Remove working tests from qt/Skipped associated with DRT update. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:29:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:29:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811172945.DF30F34B09BD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34576|review? |review+, commit-queue+ Flag| | --- Comment #26 from Eric Seidel 2009-08-11 10:29:45 PDT --- (From update of attachment 34576) Looks OK. I thought you decided Icon() was not used? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:29:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:29:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] WINCE PORT: implement MediaPlayerProxy In-Reply-To: References: Message-ID: <20090811172951.427D534B09CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28178 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34569|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:29:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:29:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090811172957.D517F34B09E5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 --- Comment #2 from Kenneth Rohde Christiansen 2009-08-11 10:29:56 PDT --- Simon had some concerns about web apps being able to "overwrite" shortcuts. Would be good to see if the HTML5 have a say in this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:30:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:30:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090811173020.59D3434B09FB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #27 from Eric Seidel 2009-08-11 10:30:19 PDT --- OK. re-read the ChangeLog. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:33:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:33:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20393] Add WML support to WebKit In-Reply-To: References: Message-ID: <20090811173315.85B1034B0A57@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20393 Nikolas Zimmermann changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28180 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:41:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:41:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] New: RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28181 Summary: RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. Product: WebKit Version: 528+ (Nightly build) Platform: S60 Emulator OS/Version: S60 3rd edition Status: NEW Keywords: Qt Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yongjun.zhang at nokia.com QWebView::RenderHints property makes QWebView::staticMetaObject depends on QPainter::staticMetaObject with breaks RVCT elftran linking. We have to remove this property now, until the right symbol is exported. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:49:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:49:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811174916.8F98C34B0C7C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #23 from Zoltan Herczeg 2009-08-11 10:49:13 PDT --- > This won't work with the restrictions we need to work as a Mac OS X framework. > We can't have any static destructors in our Mac OS X system frameworks as a > matter of policy to make process exit fast. No objects with destructors as > globals or statics. That's the reason for the DEFINE_STATIC_LOCAL macro. I have realized why DEFINE_STATIC_LOCAL (probably DEFINE_GLOBAL is even better example, which use placement new to hide the destructor) defined, so the destructor of WTF::StaticPtr is empty of course, and never intended to do anything... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:50:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:50:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090811175021.38EA134B0CB8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 --- Comment #3 from Benjamin Meyer 2009-08-11 10:50:20 PDT --- These two arora bug reports look like they might also be for this bug: http://code.google.com/p/arora/issues/detail?id=515 http://code.google.com/p/arora/issues/detail?id=230 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:53:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:53:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811175347.773CA34B0D33@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #8 from Darin Adler 2009-08-11 10:53:44 PDT --- (In reply to comment #7) > (Although eventually we'll want to rename make-js-test-wrappers if we use > "script-tests".) Thanks again for looking at this! I think we could rename make-js-test-wrappers to make-script-tests-wrappers right away as step (0). I also think that eventually we could teach run-webkit-tests to run these tests without checking in wrappers. But that would have a downside since it would be harder to open one of these tests directly from a browser. Further, I think that in the future we might want to run some of these tests as pure JavaScript tests, using the "jsc" command line tool instead of "DumpRenderTree" -- some can't work that way but others can't, and I wonder how we could distinguish those. Finally, I'd love to convert the Mozilla tests for JavaScript in the JavaScriptCore tree into these style tests so they all run with run-webkit-tests. Not all relevant to this task, but since you asked I thought I'd talk a bit about more of the road map in my mind. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 10:54:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 10:54:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090811175405.ECCBD34B0D5F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #9 from Darin Adler 2009-08-11 10:54:04 PDT --- (In reply to comment #8) > (In reply to comment #7) > > (Although eventually we'll want to rename make-js-test-wrappers if we use > > "script-tests".) Thanks again for looking at this! > > I think we could rename make-js-test-wrappers to make-script-tests-wrappers > right away as step (0). make-script-test-wrappers -- an "s" crept in there -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:13:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:13:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811181314.E3C7534B0F65@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 --- Comment #27 from Darin Adler 2009-08-11 11:13:08 PDT --- There are at least three distinct related questions in my opinion: a) How we detect that there's a change that requires some mouse position processing. There are many different types of changes that could trigger the need for this, such as an element moving that has a CSS cursor associated with it so that it's no longer under the mouse, any kind of scrolling, or even a change to the CSS cursor property without any geometry change at all. We need a good architecture so that the new processing gets done. I don't think it necessarily has to be done right away. We could use a zero duration or small duration timer to coalesce these so that multiple changes don't require multiple attempts to process things, and so that the processing can happen after layout has occurred. In fact, when it comes to status bar messages, even changes in the keyboard state are relevant. For example, if you press the option key on the Mac, we need to recompute the status message. I believe this is currently done by simulating a "mousemove" when there is change in the state of modifier keys, done in the Mac-specific WebKit code. b) What should be seen at the DOM level. For example, if an element moved and that changes the cursor, then presumably ideally we don't want DOM event handlers to see a DOM "mousemove" event since the mouse didn't move. Or maybe we do, but if so it's an intentional choice, not just a side effect of how our code works internally. We might be willing to live with an excess "mousemove" event, but it's probably not working as designed if we send one. On the other hand, if an element moves so it's no longer under the mouse, we probably *do* want to send that object a "mouseout" event even if we would not have sent a "mousemove" event. What do we want seen at the DOM level when the option key goes down? Probably not a "mouse move" event, so that's a minor bug on the Mac that would be nice to fix. Unless we decide it's a feature rather than a bug. c) Once we detect a change, how we trigger the additional processing. It may be expedient to use what looks like a "mousemove" event to minimize refactoring of the existing code. But I think that sort of lack of clarity and logic in the code is unnecessary. We should be willing to make some changes to make this logical unless it's so difficult that it makes the problem a lot harder to fix. (In reply to comment #25) > Safari/Mac appears to generate extra mouse move events for lots of things > (including, e.g., mouse downs/ups), thereby avoiding a host of bugs. It would be very useful to determine where those events come from. Is it the Mac OS X AppKit that is providing these events? Or is it the Mac-specific WebKit code that creates them? If the former, then we should just live with them as is. If it's the latter, maybe we can solve this in a platform independent way and get rid of the unneeded code. > When > scrolling using the keyboard, in Safari/Mac, the cursor (and tooltip) > disappear, thereby eliminating a bunch of problems; actually, now that > Chromium/Mac also makes the cursor (and consequently the tooltip, apparently) > disappear, those same problems go away. This is an interesting point. It hides some problems (cursor and tooltip) but doesn't affect others at all (status bar, DOM events as seen on the web page, hover effects in the page). Why don't other platforms have this behavior? Is this really a unique feature of Mac OS X, or is this something we'd want on Windows and Unix desktop systems too? > Now, unfortunately, the mouse moving code > (EventHandler::mouseMoved()/handleMouseMoveEvent()) are very tightly coupled > with PlatformMouseEvent. To handle "virtual mouse moves", we need to at least > do either (1) send fake mouse move events (ugly, but expedient) or (2) decouple > the aforementioned code so that it can handle such "virtual mouse moves" > without a PlatformMouseEvent (make an "EventHandler::mouseMovedVirtually()" > method or some such). In some sense, the difference between (1) and (2) is > cosmetic. You could decouple so far as to push a lot of the logic down into the > layout, but that would be drastic and you'd have to make the layout aware of > the mouse position. You're talking about my issue (c) here. But I think that my issue (b) also comes up. Do we want actual mouse moves to show up in the DOM or not? I don't think this refactoring and clean-up is particularly difficult, and I'd love to see it done for code clarity either before or after this bug is fixed. I agree that it doesn't have to be done to fix the bug. > My first instinct to fix the scrolling-related issues is to hook up (1) or (2) > in FrameView::valueChanged() (probably inside the "if (offset != > scrollOffset())"). Similarly, you could do the same in > FrameView::performPostLayoutTasks() -- I think this would probably handle any > possible resize-related issues. (There are also possible window-movement issues > -- i.e., the window moves without the mouse moving -- though I don't know > offhand where that would get hooked up.) This seems to cover only a tiny fraction of problem (a). It's true that a FrameView scrolling can move an element. But also, changes to the element's geometry can move it. And overflow area scrolling can also move it. I'd like to understand our general strategy to detecting when elements move out from under the mouse. It may be that once we cover the general case we don't need anything separate for FrameView. > Hooking up a fake mouse event is expedient, if a little repugnant; decoupling > the code is a bit fragile and goes pretty deep. (E.g., on resize, the mouse may > end up over a scrollbar, so you can't just ignore the scrollbars.) My main complaint about your initial patch was that making a fake mouse event in response to a real wheel event is wrong. The major way it's wrong is (a). It's wrong to say that a wheel event is causing this. It's the *response* to the wheel event that creates the need to update things like cursors and makes you want to send a simulated mouse move event. You're focusing on issue (c), which is whether a fake mouse event is the best way to trigger the new processing. We can be flexible on this, but ideally the code is clear and not full of "fake" anything. I really don't think it's all that difficult to clean this up and make it right. The degree to which updating cursors is tied to a PlatformEvent for a mouse move event is actually pretty small in my opinion. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:15:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:15:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811181527.35C4434B0FDF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #24 from Darin Adler 2009-08-11 11:15:23 PDT --- (In reply to comment #23) > I have realized why DEFINE_STATIC_LOCAL (probably DEFINE_GLOBAL is even better > example, which use placement new to hide the destructor) defined, so the > destructor of WTF::StaticPtr is empty of course, and never intended to do > anything... Please check and see what the compiler generates for this before giving a patch that deploys it in tons of places. I'm pretty sure that an empty virtual function will indeed generate a static destructor, although a pointless empty one. There's a good chance it will even change the virtual pointer on the object. Anyway, if the technique works that's fine but it's pointless to review a patch to deploy the technique before you've tested it! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:24:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:24:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27962] Exception in land-patches In-Reply-To: References: Message-ID: <20090811182412.3CAFD34B10F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27962 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34578| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-11 11:24:10 PDT --- Created an attachment (id=34578) --> (https://bugs.webkit.org/attachment.cgi?id=34578) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:26:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:26:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27962] Exception in land-patches In-Reply-To: References: Message-ID: <20090811182635.4959034B1136@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27962 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34578|review? |review+ Flag| | --- Comment #2 from Darin Adler 2009-08-11 11:26:34 PDT --- (From update of attachment 34578) rs=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:27:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:27:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27962] Exception in land-patches In-Reply-To: References: Message-ID: <20090811182755.1E35534B1160@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27962 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-11 11:27:53 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... C WebKitTools/Scripts/run-webkit-unittests => WebKitTools/Scripts/modules/logging_unittest.py M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/logging.py M WebKitTools/Scripts/run-webkit-unittests Committed r47040 M WebKitTools/ChangeLog A WebKitTools/Scripts/modules/logging_unittest.py M WebKitTools/Scripts/modules/logging.py M WebKitTools/Scripts/run-webkit-unittests r47040 = 9ed18775ec0ae3c5667b23995d10b1874c1c65fe (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47040 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:30:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:30:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. In-Reply-To: References: Message-ID: <20090811183017.1A8B934B11C9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28181 Yongjun Zhang changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34579| |review? Flag| | --- Comment #1 from Yongjun Zhang 2009-08-11 11:30:16 PDT --- Created an attachment (id=34579) --> (https://bugs.webkit.org/attachment.cgi?id=34579) don't use RenderHint property when building for symbian. It is a temporary fix, should be reverted when the right symbol is exported from QT lib. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:42:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:42:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28182] New: The setter for CSSStyleRule.selectorText doesn't actually do anything. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28182 Summary: The setter for CSSStyleRule.selectorText doesn't actually do anything. Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: andy at andymatuschak.org One might expect that calling someCSSStyleRule.selectorText = ".someOtherClass" might actually cause someCSSStyleRule's selector to change. That would be a foolish assumption indeed! See the attached sample .html; clicking the "foo" link should turn it black. Also, the rule's cssText is logged to the console after being changed from "foo" to "bar"; note that its selector is still ".foo". Firefox doesn't seem to implement this setter either, but the property is marked as readwrite in the spec: http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSStyleRule -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:44:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:44:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28182] The setter for CSSStyleRule.selectorText doesn't actually do anything. In-Reply-To: References: Message-ID: <20090811184442.1656034B136A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28182 --- Comment #1 from Andy Matuschak 2009-08-11 11:44:41 PDT --- Created an attachment (id=34581) --> (https://bugs.webkit.org/attachment.cgi?id=34581) Demonstration of selectorText's setter's fail. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:56:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:56:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27587] Searching for "=?UTF-8?Q?=E3=81=97?=" also finds "=?UTF-8?Q?=E3=81=98?=" In-Reply-To: References: Message-ID: <20090811185647.682D634B151A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27587 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #4 from Darin Adler 2009-08-11 11:56:46 PDT --- The matching is based on ICU. The folding is due to code in ICU. In the released Safari 4 the behavior is the same no matter what the user’s locale is, but in the TOT WebKit it respects the user’s locale choice so will work differently for different users. If we don’t like the behavior we can ask ICU to change its behavior, which in some cases would mean changes to the Unicode specification, or we can add workarounds to WebKit’s TextIterator class. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:57:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:57:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27202] Inspector: Cookies in Storage Panel In-Reply-To: References: Message-ID: <20090811185700.3F2FC34B1530@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34377|commit-queue+ |commit-queue- Flag| | --- Comment #13 from Eric Seidel 2009-08-11 11:56:58 PDT --- (From update of attachment 34377) Rejecting patch from commit queue: 34377 Failure, rejecting patch from commit queue. This patch will require manual landing. Patch https://bugs.webkit.org/attachment.cgi?id=34377 from bug 27202 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 11:58:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 11:58:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27202] Inspector: Cookies in Storage Panel In-Reply-To: References: Message-ID: <20090811185807.C482C34B155C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #14 from Eric Seidel 2009-08-11 11:58:06 PDT --- Here is the log. Sorry the commit-queue/bugzilla-tool is not smart enough to know how to post the log yet: patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/inspector/front-end/Cookie.js patching file WebCore/inspector/front-end/CookieItemsView.js patching file WebCore/inspector/front-end/DatabasesPanel.js patch: **** Only garbage was found in the patch input. patch -p0 "WebCore/inspector/front-end/Images/cookie.png" returned 2. Pass --force to ignore patch failures. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:00:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:00:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27065] Port QtWebKit to Symbian In-Reply-To: References: Message-ID: <20090811190045.2A45B34B15C0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27065 Yongjun Zhang changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28181 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:00:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:00:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. In-Reply-To: References: Message-ID: <20090811190046.36E2734B15CE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28181 Yongjun Zhang changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27065 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:02:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:02:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811190245.EEFF434B1616@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #25 from Yong Li 2009-08-11 12:02:42 PDT --- (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=34058) --> (https://bugs.webkit.org/attachment.cgi?id=34058) [details] [details] > > First draft patch > > This patch is intended to be a draft. I would like to hear your opinion about > this solution: > - two new files are added to wtf directory: StaticPtr.h and StaticPtr.cpp > - enabling FREE_STATIC_PTRS allows to free the pointers in a reversed > creation order > - Although c++ supports automatic destructors, I think it would not be wise > to free the pointers in random order. Why not just let ~StaticPtr() to free memory? Static objects should be destructed in the reverse order of construction, as when a static object is constructed, atexit will be pushed to onexit queue. Also, you can always destruct all static objects by calling _cexit() explicitly. The only benefit of using a chain I can see is that it destructs all object first, and then frees all the memory, so that when a destructor accesses to another destructed static object, it won't result segment fault... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:03:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:03:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090811190351.DFFBD34B167A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 --- Comment #26 from Yong Li 2009-08-11 12:03:49 PDT --- (In reply to comment #25) > (In reply to comment #2) > > (In reply to comment #1) > > > Created an attachment (id=34058) --> (https://bugs.webkit.org/attachment.cgi?id=34058) [details] [details] [details] > > > First draft patch > > > > This patch is intended to be a draft. I would like to hear your opinion about > > this solution: > > - two new files are added to wtf directory: StaticPtr.h and StaticPtr.cpp > > - enabling FREE_STATIC_PTRS allows to free the pointers in a reversed > > creation order > > - Although c++ supports automatic destructors, I think it would not be wise > > to free the pointers in random order. > > Why not just let ~StaticPtr() to free memory? Static objects should be > destructed in the reverse order of construction, as when a static object is > constructed, atexit will be pushed to onexit queue. Also, you can always > destruct all static objects by calling _cexit() explicitly. The only benefit of > using a chain I can see is that it destructs all object first, and then frees > all the memory, so that when a destructor accesses to another destructed static > object, it won't result segment fault... correction: atexit pushes the destructor to the onexit stack -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:07:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:07:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090811190753.1AFE434B1736@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34365|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:29:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:29:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811192913.BFFF134B1AA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 --- Comment #28 from Viet-Trung Luu 2009-08-11 12:29:09 PDT --- [Just for clarity, I'm not the originator of the original patch....] (In reply to comment #27) > a) How we detect that there's a change that requires some mouse position > processing. I guess there are two approaches to this (and intermediates between the two extremes): (i) Code which does anything which causes changes which require such processing initiate the processing. Advantages: efficient (no extra checking needed). Disadvantages: need to carefully wire up lots of code. (ii) Check whether such processing is needed very often (possibly prompted by code which does anything which remotely *may* cause such a need), and do the processing if necessary. Advantages: no need to wire up other code so carefully. Disadvantages: nontrivial processing and possibly inefficient. In my quick-and-dirty patch, I've taken route (i): EventHandler::mouseMovedVirtually() is a stub which tells the EventHandler that something happened which caused the mouse to move "virtually". Currently, this immediately fires off a fake mouse event (ugh), but upon decoupling the code it could do something better; it could also be set to start a timer (to coalesce), etc. > b) What should be seen at the DOM level. [...] Right. I (as opposed to the original patch's author) wired up a fake mouse move purely out of expediency -- it's clearly not right. It forces a policy decision (send mouse move events on "virtual" mouse moves), but we shouldn't let a hack make policy. That said, sending a DOM mouse move may be desired, after all. > What do we want seen at the DOM level when the option key goes down? Probably > not a "mouse move" event, so that's a minor bug on the Mac that would be nice > to fix. Unless we decide it's a feature rather than a bug. Seems unlikely that that's a feature! I wouldn't want the option key to be hooked up to virtual mouse moves either, so that processing should probably be separated. > It may be expedient to use what looks like a "mousemove" event to minimize > refactoring of the existing code. But I think that sort of lack of clarity and > logic in the code is unnecessary. We should be willing to make some changes to > make this logical unless it's so difficult that it makes the problem a lot > harder to fix. It's a little painful since we have ugly scrollbar, etc. code which would also need to be rewired, the details which are a bit painful to get right. Currently, a lot of code is wired up to take a PlatformMouseEvent, probably unnecessarily. > It would be very useful to determine where those events come from. Is it the > Mac OS X AppKit that is providing these events? Or is it the Mac-specific > WebKit code that creates them? If the former, then we should just live with > them as is. If it's the latter, maybe we can solve this in a platform > independent way and get rid of the unneeded code. I wouldn't want to bet my life on it, but I would guess the former, or actually code in Safari itself. I don't think I've seen code that does this in WebKit (and Chromium/Mac doesn't get extra events). > > When > > scrolling using the keyboard, in Safari/Mac, the cursor (and tooltip) > > disappear, thereby eliminating a bunch of problems; [...] > > This is an interesting point. It hides some problems (cursor and tooltip) but > doesn't affect others at all (status bar, DOM events as seen on the web page, > hover effects in the page). True, and of course it doesn't help with scrolling with trackpad/mousewheel/other either. > Why don't other platforms have this behavior? Is this really a unique feature > of Mac OS X, or is this something we'd want on Windows and Unix desktop systems > too? It's standard on Mac, doesn't happen on Windows (in any browser that I know of, at least). I don't know about Unix desktops.... > I don't think this refactoring and clean-up is particularly difficult, and I'd > love to see it done for code clarity either before or after this bug is fixed. > I agree that it doesn't have to be done to fix the bug. Agreed, which is why my (even quick-and-dirty) patch is written as it is. For the mouse-related stuff (I don't know about the option key, etc.), I would separate out the code in mouseMoved() and handleMouseMoveEvent(), and have them (and mouseMovedVirtually()) call down to the common code appropriately. > This seems to cover only a tiny fraction of problem (a). It's true that a > FrameView scrolling can move an element. But also, changes to the element's > geometry can move it. And overflow area scrolling can also move it. I'd like to > understand our general strategy to detecting when elements move out from under > the mouse. It may be that once we cover the general case we don't need anything > separate for FrameView. I suppose that, adopting my tactic (i), we'd have to wire up all these other things explicitly as well. Our "general strategy for detecting when elements move out from under the mouse" rests right now entirely in EventHandler (not so great, but everything else seems mostly unaware of the mouse!), and in handleMouseMoveEvent() in particular (at least that should be changed). A further possible issue is that we may need to know whenever the mouse moves relative to anything (leaving an element); this would be the case if we want to send DOM mouse moves when scrolling, for example. > My main complaint about your initial patch was that making a fake mouse event > in response to a real wheel event is wrong. The major way it's wrong is (a). > It's wrong to say that a wheel event is causing this. It's the *response* to > the wheel event that creates the need to update things like cursors and makes > you want to send a simulated mouse move event. [Not my original patch, which is why I wired up to the scrolling instead....] So what do you think of having a separate mouseMovedVirtually() method in EventHandler? As I said, it and mouseMoved()/etc. should be refactored, but the semantics of mouseMovedVirtually() are quite clear -- whenever the mouse moves relative to any elements (without the mouse actually moving -- i.e., the elements move!), it should be called. Currently, I call it from the scrolling code, but it should be called from elsewhere as well; it may need to be made more sophisticated to work correctly in those cases, but it's a start. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:29:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:29:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20393] Add WML support to WebKit In-Reply-To: References: Message-ID: <20090811192944.DEECF34B1AD0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20393 Bug 20393 depends on bug 28180, which changed state. Bug 28180 Summary: [WML] WMLPageState is not allowed to store the active card, it needs to be done per document https://bugs.webkit.org/show_bug.cgi?id=28180 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:35:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:35:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090811193542.BD0DD34B1BB6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lyon.chen at torchmobile.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:37:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:37:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28115] Inspector: Console Drawer is Toggling instead of Staying Open In-Reply-To: References: Message-ID: <20090811193745.9A68834B1C26@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28115 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34403|review+ | Flag| | --- Comment #2 from Eric Seidel 2009-08-11 12:37:45 PDT --- (From update of attachment 34403) Clearing review flag on attachment: 34403 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/Drawer.js M WebCore/inspector/front-end/inspector.js Committed r47049 M WebCore/ChangeLog M WebCore/inspector/front-end/inspector.js M WebCore/inspector/front-end/Drawer.js r47049 = 5847ea6bf7fc1d9f761b3363a847a0978fc69389 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47049 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:37:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:37:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28115] Inspector: Console Drawer is Toggling instead of Staying Open In-Reply-To: References: Message-ID: <20090811193748.E7EA934B1C36@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28115 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-11 12:37:48 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:49:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:49:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28184] New: JavaScript: keypress not fired with DELETE key Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28184 Summary: JavaScript: keypress not fired with DELETE key Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gaddis at apple.com Created an attachment (id=34583) --> (https://bugs.webkit.org/attachment.cgi?id=34583) test case html file The scenario: Event listeners are attached to the document for keydown, keypress, and keyup events. In the attached file, input_document.html, watch the console for evidence of the events fired from inside an text input. When "1" is pressed: onkeydown charCode = 0 onkeypress charCode = 49 onkeyup charCode = 0 When DELETE is pressed: onkeydown charCode = 0 onkeyup charCode = 0 (note the missing onkeypress) Other observations: This behavior does not change when the listeners are attached to the text input. Safari 3 reports all three events: onkeydown, onkeypress, onkeyup when the DELETE key is pressed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:51:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:51:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28121] [Haiku] Modifications on JavaScriptCore. In-Reply-To: References: Message-ID: <20090811195122.340CE34B1DF7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28121 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34424|review+ | Flag| | --- Comment #8 from Eric Seidel 2009-08-11 12:51:20 PDT --- (From update of attachment 34424) Clearing review flag on attachment: 34424 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/runtime/Collector.cpp M JavaScriptCore/wtf/Platform.h M JavaScriptCore/wtf/haiku/MainThreadHaiku.cpp Committed r47050 M JavaScriptCore/runtime/Collector.cpp M JavaScriptCore/wtf/haiku/MainThreadHaiku.cpp M JavaScriptCore/wtf/Platform.h M JavaScriptCore/ChangeLog r47050 = b11f14b641a8c5357b1ee13ba14846834ae2311e (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47050 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:51:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:51:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28121] [Haiku] Modifications on JavaScriptCore. In-Reply-To: References: Message-ID: <20090811195125.64ABB34B1E07@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28121 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #9 from Eric Seidel 2009-08-11 12:51:24 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:52:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:52:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811195212.5EB6F34B1E3F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 --- Comment #29 from Darin Adler 2009-08-11 12:52:08 PDT --- Sorry for confusing you with the earlier person working on this bug! (In reply to comment #28) > So what do you think of having a separate mouseMovedVirtually() method in > EventHandler? I would name it simulateMouseMove() or simulateMouseMotion() since I don't really think "virtually" is quite as good a way of saying what the function does. > but the > semantics of mouseMovedVirtually() are quite clear -- whenever the mouse moves > relative to any elements (without the mouse actually moving -- i.e., the > elements move!), it should be called. If that’s true, then perhaps we should name it for when it should be called rather than for what it does. Maybe contentMovedUnderMouse() or something along those lines? > Currently, I call it from the scrolling > code, but it should be called from elsewhere as well; it may need to be made > more sophisticated to work correctly in those cases, but it's a start. Seems like a reasonable first step. Lets not set our sights too low though. Lets try to fix this all the way! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:58:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:58:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811195808.EEFF434B1F90@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34585| |review? Flag| | --- Comment #22 from Xiaomei Ji 2009-08-11 12:58:04 PDT --- Created an attachment (id=34585) --> (https://bugs.webkit.org/attachment.cgi?id=34585) patch w/ manual test updated per Mitz's suggestion: 1. revert changes in GraphicsContext 2. remove ellipseseNeeded in PopupItem. When restrcitWidthOfListBox, truncate string first and drawBidiText on truncated string in PopupMenuChromium. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 12:58:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 12:58:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811195843.B975234B1FB4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34536|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 13:16:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 13:16:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21945] (https://bugs.webkit.org/attachment.cgi?id=34590) 7) Keygen (Security) refactored by Yong -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:12:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:12:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28169] REGRESSION: Hang/crash in BytecodeGenerator::constRegisterFor loading simple page In-Reply-To: References: Message-ID: <20090811211250.DC63834B294D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28169 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34591| |review? Flag| | --- Comment #2 from Oliver Hunt 2009-08-11 14:12:49 PDT --- Created an attachment (id=34591) --> (https://bugs.webkit.org/attachment.cgi?id=34591) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:17:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:17:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28186] New: Web Inspector scope bar not quite right Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28186 Summary: Web Inspector scope bar not quite right Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: sam at webkit.org CC: timothy at hatcher.name The Web Inspectors new scope bar for the resources pane seems to be too dark. It could use some tweaking. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:19:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:19:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090811211912.90E1334B2AA3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 --- Comment #46 from George Staikos 2009-08-11 14:19:09 PDT --- (In reply to comment #45) > Created an attachment (id=34590) --> (https://bugs.webkit.org/attachment.cgi?id=34590) [details] > 7) Keygen (Security) > > refactored by Yong Are you sure? It looks the same to me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:20:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:20:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] New: "Double-click to add" new style button does not always show up Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28187 Summary: "Double-click to add" new style button does not always show up Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://webkit.org OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: sam at webkit.org CC: timothy at hatcher.name On http://webkit.org, the "Double-click to add" button does not show up for the body element in the elements pane. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:20:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:20:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28186] Web Inspector scope bar not quite right In-Reply-To: References: Message-ID: <20090811212040.5C9FC34B2AE7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28186 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrowe at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:20:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:20:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090811212044.183F334B2AF4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34592| |review? Flag| | --- Comment #1 from Joseph Pecoraro 2009-08-11 14:20:43 PDT --- Created an attachment (id=34592) --> (https://bugs.webkit.org/attachment.cgi?id=34592) Working on OS X Leopard This is pretty much my first experience with C++, so I'd appreciate it if you be explicit about any of the C++ mistakes I made, or build fixes that will be needed for other platforms. I changed the CookieJar.h header so I expect that I will need to fix a number of other files. Thanks in advance. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:23:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:23:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090811212330.B26E134B2B66@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck02 at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:24:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:24:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090811212414.3669C34B2B84@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck02 at gmail.com --- Comment #1 from Joseph Pecoraro 2009-08-11 14:24:13 PDT --- Seems to be due to "could not parse color" warnings. I'll work on this right now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:25:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:25:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090811212509.2BBF634B2BB2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 --- Comment #2 from Timothy Hatcher 2009-08-11 14:25:08 PDT --- Patch looks pretty good. I think rawCookies will be better named as cookies. And rename the existing cookies to cokkiesString or somthing more specific. I'll review more later and provide guidance o nwhat files to edit for other platforms. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:26:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:26:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28169] REGRESSION: Hang/crash in BytecodeGenerator::constRegisterFor loading simple page In-Reply-To: References: Message-ID: <20090811212602.E591F34B2BE0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28169 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34591|review? |review+ Flag| | --- Comment #3 from Geoffrey Garen 2009-08-11 14:26:02 PDT --- (From update of attachment 34591) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:30:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:30:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28169] REGRESSION: Hang/crash in BytecodeGenerator::constRegisterFor loading simple page In-Reply-To: References: Message-ID: <20090811213031.EF53634B2C9D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28169 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Oliver Hunt 2009-08-11 14:30:31 PDT --- Committed r47062 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:30:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:30:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] New: WINCE PORT: Path, PlatformPath Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28188 Summary: WINCE PORT: Path, PlatformPath Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Platform AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yong.li at torchmobile.com CC: staikos at kde.org, treat at kde.org taken out from 27511 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:30:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:30:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090811213058.0C82B34B2CB7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27511 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:30:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:30:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090811213059.9985F34B2CCB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28188 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:31:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:31:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] New: run-webkit-tests --quiet should not output build-dumprendertree output Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28189 Summary: run-webkit-tests --quiet should not output build-dumprendertree output Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org run-webkit-tests --quiet should not output build-dumprendertree output This required a surprising amount of perl ninjary. I will be so glad when that wicked old language is dead. :( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:31:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:31:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090811213117.427EA34B2D0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34398|review? | Flag| | Attachment #34398|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:33:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:33:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811213306.D34CB34B2D6E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34594| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-11 14:33:05 PDT --- Created an attachment (id=34594) --> (https://bugs.webkit.org/attachment.cgi?id=34594) Make run-webkit-tests --quiet actually quiet --- 2 files changed, 22 insertions(+), 3 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:38:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:38:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811213854.316D634B2E31@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34594|review? | Flag| | Attachment #34594|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:38:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:38:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811213857.3BD8334B2E3E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34596| |review? Flag| | --- Comment #2 from Eric Seidel 2009-08-11 14:38:55 PDT --- Created an attachment (id=34596) --> (https://bugs.webkit.org/attachment.cgi?id=34596) Updated patch --- 2 files changed, 21 insertions(+), 2 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:39:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:39:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090811213956.BD0A034B2E5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 --- Comment #2 from Joseph Pecoraro 2009-08-11 14:39:56 PDT --- Interesting. The incoming CSS of: url(/images/green.png) Has the string "green" inside it and "green" swatch is (incorrectly) made for it: http://tr.im/wdZz?grabup WebInspector.Color is invoked if there was a swatch on the massaged CSS value, and it throws an error because it cannot parse the following as a valid color: url(http://webkit.org/images/green-background.png) Since this affects the WebKit Nightly right now I will throw up a "quick fix" patch that catches the WebInspector.Color error and therefore takes us back to the expected old behavior with the swatch still incorrectly showing. I'll then work on cleaning this up in general. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:46:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:46:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811214617.A974B34B2F1D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #23 from Xiaomei Ji 2009-08-11 14:46:14 PDT --- Hi Mitz: One question on the ellipses appended in StringTruncator. StringTruncator always append horizontal ellipses (U+2026) along with the truncated string. Will the Unicode character cause display problem? Thanks, xiaomei -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:49:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:49:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090811214901.35BBE34B2F7A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34597| |review? Flag| | --- Comment #3 from Joseph Pecoraro 2009-08-11 14:49:00 PDT --- Created an attachment (id=34597) --> (https://bugs.webkit.org/attachment.cgi?id=34597) Quick Fix This is the quick fix for the Nightly Build. --- I think a more optimal solution would be to avoid throwing an error at all. Instead something like WebInspector.Color.parseColor() factory method which would return either 'null' or a WebInspector.Color object. That way we won't have to worry about any throw/catch. Along with the other improvements mentioned previously, including: - swatch shows up accidentally - all swatches should be clickable to toggle colors - swatches should be clickable in shorthand properties -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:50:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:50:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. In-Reply-To: References: Message-ID: <20090811215039.46E4F34B2FCE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27889 --- Comment #24 from mitz at webkit.org 2009-08-11 14:50:37 PDT --- (In reply to comment #23) > StringTruncator always append horizontal ellipses (U+2026) along with the > truncated string. Will the Unicode character cause display problem? drawBidiText() will use a fallback font if the specific font does not have a horizontal ellipses glyph. Text truncation in the render tree is also implemented using horizontal ellipses. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:53:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:53:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090811215307.D950634B3004@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34598| |review? Flag| | --- Comment #1 from Yong Li 2009-08-11 14:53:07 PDT --- Created an attachment (id=34598) --> (https://bugs.webkit.org/attachment.cgi?id=34598) the patch (modified a little) modified a little bit. added some comments to contains() -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:55:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:55:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28190] New: Remove support for a window resizer within the WebView Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28190 Summary: Remove support for a window resizer within the WebView Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: aroben at apple.com CC: hyatt at apple.com, sfalken at apple.com Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34599| |review? Flag| | Created an attachment (id=34599) --> (https://bugs.webkit.org/attachment.cgi?id=34599) Patch v1 Starting with Safari 4, there is never a window resizer inside the WebView, so we no longer need to support that functionality. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 14:56:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 14:56:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28190] Remove support for a window resizer within the WebView In-Reply-To: References: Message-ID: <20090811215611.83BEC34B304B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28190 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Mac OS X 10.5 |Windows XP -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:00:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:00:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28191] New: Mixing absolute and relative table widths causes mis-sized TDs Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28191 Summary: Mixing absolute and relative table widths causes mis-sized TDs Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://ratemyserver.net/ OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tables AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gwilson at google.com Created an attachment (id=34600) --> (https://bugs.webkit.org/attachment.cgi?id=34600) Reduction When a table contains a mix of absolute widths and relative widths in one row, and a colspan with no widths specified, the TDs mis-size themselves. Specifically, there seems to be some "extra padding" around those elements that have absolute sizes. FF3: OK IE: OK Chrome2/3: Not OK Safari 4: Not OK -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:01:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:01:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28190] Remove support for a window resizer within the WebView In-Reply-To: References: Message-ID: <20090811220107.95FAD34B30E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28190 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34599|review? |review+ Flag| | --- Comment #1 from Dave Hyatt 2009-08-11 15:01:07 PDT --- (From update of attachment 34599) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:01:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:01:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811220159.6285D34B310E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34596|review? | Flag| | Attachment #34596|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:02:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:02:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811220202.7F09334B311D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34601| |review? Flag| | --- Comment #3 from Eric Seidel 2009-08-11 15:02:01 PDT --- Created an attachment (id=34601) --> (https://bugs.webkit.org/attachment.cgi?id=34601) Update comments --- 2 files changed, 21 insertions(+), 2 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:02:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:02:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811220252.47DC634B3143@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34601|review? |review+ Flag| | --- Comment #4 from Adam Barth 2009-08-11 15:02:51 PDT --- (From update of attachment 34601) Seems reasonable, assuming the Perl magic does what it looks like it should do. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:05:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:05:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27124] [commit+] let me *edit* css styles in the web inspector. In-Reply-To: References: Message-ID: <20090811220520.24FB834B3185@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27124 ryankshaw+webkitbugzilla at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #12 from ryankshaw+webkitbugzilla at gmail.com 2009-08-11 15:05:16 PDT --- I just got the latest webkit nightly and tried it out. if you double click to create a new style rule, add something like color:red; , It makes that thing red. now, reload the page, inspect the same thing, double click to add a new style rule that is the same as before with color:red; and it does not change anything on the page, even though in the web inspector it thinks that it is because it crosses out the rule coming from the stylesheet. this shows what I am talking about: http://screencast.com/t/MsmXR6Icm -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:05:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:05:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28189] run-webkit-tests --quiet should not output build-dumprendertree output In-Reply-To: References: Message-ID: <20090811220538.3EA0234B319D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28189 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Eric Seidel 2009-08-11 15:05:37 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests Committed r47066 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests r47066 = 47f317d3a54a8c0eba39936bac967272116a6580 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47066 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:12:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:12:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090811221227.E68EB34B322B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 --- Comment #47 from Yong Li 2009-08-11 15:12:26 PDT --- (In reply to comment #46) > (In reply to comment #45) > > Created an attachment (id=34590) --> (https://bugs.webkit.org/attachment.cgi?id=34590) [details] [details] > > 7) Keygen (Security) > > > > refactored by Yong > > Are you sure? It looks the same to me. hm... a mistake -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:15:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:15:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] New: run-webkit-tests needs a --fail-fast option Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28192 Summary: run-webkit-tests needs a --fail-fast option Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org I'm not sure --fail-fast is the right name. But I want a mode where run-webkit-tests exits after the first failure or new result. This is useful for bugzilla-tool (or possibly some bots) when validating that everything still passes before committing. In some cases we don't care to know all of the failures, only that something failed (and want to know as fast as possible). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:17:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:17:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090811221731.1EBFA34B32F6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34590|review? | Flag| | Attachment #34590|0 |1 is obsolete| | Attachment #34602| |review? Flag| | --- Comment #48 from Yong Li 2009-08-11 15:17:29 PDT --- Created an attachment (id=34602) --> (https://bugs.webkit.org/attachment.cgi?id=34602) 7) KeyGen (modified) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:18:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:18:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090811221807.89A6934B331C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34597|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:18:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:18:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090811221808.E8A1A34B332C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34402|commit-queue+ |commit-queue- Flag| | --- Comment #17 from Eric Seidel 2009-08-11 15:18:07 PDT --- (From update of attachment 34402) This is missing new results and cannot be landed by the commit-queue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:22:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:22:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27124] [commit+] let me *edit* css styles in the web inspector. In-Reply-To: References: Message-ID: <20090811222206.9EF4434B33AF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27124 --- Comment #13 from Timothy Hatcher 2009-08-11 15:22:03 PDT --- I think what is happeneing here is that we have a reference to the style element we created for the previous page still, so we think we don't need to make a new one and just append to the old one in the previous page. This reference should be cleared in the ElementsPanel reset method. Can you file a new bug about this? (And close this bug.) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:23:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:23:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --fail-fast option In-Reply-To: References: Message-ID: <20090811222314.9957334B33DF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 --- Comment #1 from Mark Rowe (bdash) 2009-08-11 15:23:13 PDT --- The build bots would be better served by a mode that gave up after a certain number of crashes or failures. Perhaps a --exit-after-n-failures flag could fill both of these needs? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:25:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:25:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28193] New: bugzilla-tool: Re-factor shared landing logic into helper class to share more code Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28193 Summary: bugzilla-tool: Re-factor shared landing logic into helper class to share more code Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org bugzilla-tool: Re-factor shared landing logic into helper class to share more code I did this originally a part of bug 26715, but it really should be a separate issue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:25:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:25:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28127] [Haiku] Use Clipboard::create instead of its constructor. In-Reply-To: References: Message-ID: <20090811222529.DDB5234B3439@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28127 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34415|review+, commit-queue+ | Flag| | --- Comment #3 from Eric Seidel 2009-08-11 15:25:29 PDT --- (From update of attachment 34415) Clearing review flag on attachment: 34415 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/editing/haiku/EditorHaiku.cpp M WebCore/page/haiku/EventHandlerHaiku.cpp M WebCore/platform/haiku/ClipboardHaiku.cpp M WebCore/platform/haiku/DragDataHaiku.cpp Committed r47068 M WebCore/editing/haiku/EditorHaiku.cpp M WebCore/ChangeLog M WebCore/page/haiku/EventHandlerHaiku.cpp M WebCore/platform/haiku/ClipboardHaiku.cpp M WebCore/platform/haiku/DragDataHaiku.cpp r47068 = a6669f4fb846d758f172b3974b9f79bcd5242a69 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47068 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:25:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:25:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28127] [Haiku] Use Clipboard::create instead of its constructor. In-Reply-To: References: Message-ID: <20090811222534.32D3734B344D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28127 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #4 from Eric Seidel 2009-08-11 15:25:32 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:25:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:25:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26388] WebKit should allow cross-site scripts to set top.opener.location to a different URL In-Reply-To: References: Message-ID: <20090811222552.3112B34B3467@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26388 --- Comment #5 from Yuan Qi 2009-08-11 15:25:50 PDT --- Have you been able to reproduce this bug using my test case? Again, Safari appears to be only browser to have adopted this behaviour. IE8, Firefox 3.5 and Chrome all have no problems with the my bank's website. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:27:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:27:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090811222730.C187834B34A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|run-webkit-tests needs a |run-webkit-tests needs a |--fail-fast option |--exit-after-failures=N | |option --- Comment #2 from Eric Seidel 2009-08-11 15:27:29 PDT --- Excellent idea! (and that's a much better name) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:29:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:29:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24218] Safari 4 javascript window resize inconsistency In-Reply-To: References: Message-ID: <20090811222958.0328734B34E1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24218 Sam Garfield changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stopsendingmejunk at gmail.com --- Comment #6 from Sam Garfield 2009-08-11 15:29:56 PDT --- Are we sure this isn't a webkit problem? The same bug exists in webkit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:30:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:30:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28193] bugzilla-tool: Re-factor shared landing logic into helper class to share more code In-Reply-To: References: Message-ID: <20090811223009.3AD9534B34FA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28193 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34604| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-11 15:30:08 PDT --- Created an attachment (id=34604) --> (https://bugs.webkit.org/attachment.cgi?id=34604) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:33:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:33:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28193] bugzilla-tool: Re-factor shared landing logic into helper class to share more code In-Reply-To: References: Message-ID: <20090811223308.81D8C34B3560@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28193 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34604|review? |review+ Flag| | --- Comment #2 from Adam Barth 2009-08-11 15:33:07 PDT --- (From update of attachment 34604) Would be nice to factor out all the WebKit stuff into modules/webkit.py at some point. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:33:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:33:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28193] bugzilla-tool: Re-factor shared landing logic into helper class to share more code In-Reply-To: References: Message-ID: <20090811223340.C728D34B358A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28193 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-11 15:33:39 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool Committed r47069 M WebCore/editing/haiku/EditorHaiku.cpp M WebCore/ChangeLog M WebCore/page/haiku/EventHandlerHaiku.cpp M WebCore/platform/haiku/ClipboardHaiku.cpp M WebCore/platform/haiku/DragDataHaiku.cpp r47068 = a6669f4fb846d758f172b3974b9f79bcd5242a69 (trunk) M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool r47069 = 67e74353dfc8c4855ce730e06c50d05018528641 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/47069 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:34:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:34:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27124] let me *edit* css styles in the web inspector. In-Reply-To: References: Message-ID: <20090811223455.73ADD34B35D8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27124 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[commit+] let me *edit* css |let me *edit* css styles in |styles in the web |the web inspector. |inspector. | --- Comment #14 from Adam Barth 2009-08-11 15:34:51 PDT --- We don't need the [commit+] fake flag any more. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:35:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:35:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26715] bugzilla-tool should automate rollouts In-Reply-To: References: Message-ID: <20090811223535.995B834B35F8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26715 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28193 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:35:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:35:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28193] bugzilla-tool: Re-factor shared landing logic into helper class to share more code In-Reply-To: References: Message-ID: <20090811223537.3228634B360E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28193 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26715 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:37:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:37:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28195] New: Inline style wrapped in noscript not applied when added to the DOM via innerHTML Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28195 Summary: Inline style wrapped in noscript not applied when added to the DOM via innerHTML Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hohle at amazon.com CC: hohle at amazon.com Created an attachment (id=34605) --> (https://bugs.webkit.org/attachment.cgi?id=34605) HTML to reproduce issue. If an HTML fragment which contains an inline stylesheet and is wrapped in a noscript tag is added to the DOM by setting innerHTML on a DOM node in JavaScript, those styles are applied to the DOM. In my use case an external library is blindly copying HTML fragments which may have reuse elsewhere. Styles that are expected not to be applied when JavaScript is enabled are being applied due to this library using innerHTML to copy this HTML fragment. In other browsers this works as expected, but in Safari, the styles wrapped in noscript are applied causing undesired rendering. Expected behavior -------------- Styles wrapped in noscript should be ignored no matter how they are added to the DOM if JavaScript is enabled. Actual Behavior ------------ Styles wrapped in noscript added to the DOM via innerHTML are applied to the DOM. Styles wrapped in noscript are not applied if they are added to the DOM in an HTML file or via document.write Reproduction ---------- This has been reproduced in Safari 3.2.x, Safari 4.0.x, and with a current Webkit nightly. I've attached a minimal HTML file which illustrates the problem. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:39:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:39:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28195] Inline style wrapped in noscript not applied when added to the DOM via innerHTML In-Reply-To: References: Message-ID: <20090811223900.7C5E334B367A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28195 --- Comment #1 from Jonathan Hohle 2009-08-11 15:39:00 PDT --- Created an attachment (id=34606) --> (https://bugs.webkit.org/attachment.cgi?id=34606) Actual result when rendering the attached HTML. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:39:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:39:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28195] Inline style wrapped in noscript not applied when added to the DOM via innerHTML In-Reply-To: References: Message-ID: <20090811223928.3300D34B3687@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28195 --- Comment #2 from Jonathan Hohle 2009-08-11 15:39:27 PDT --- Created an attachment (id=34607) --> (https://bugs.webkit.org/attachment.cgi?id=34607) Expected result when rendering the attached HTML -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:39:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:39:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17052] Scrolling with arrow keys does not update cursor In-Reply-To: References: Message-ID: <20090811223933.63FF734B36A5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17052 --- Comment #30 from Viet-Trung Luu 2009-08-11 15:39:28 PDT --- (In reply to comment #29) > Sorry for confusing you with the earlier person working on this bug! No worries. :-) > If that’s true, then perhaps we should name it for when it should be called > rather than for what it does. Maybe contentMovedUnderMouse() or something along > those lines? That sounds like a good name. > Seems like a reasonable first step. Lets not set our sights too low though. > Lets try to fix this all the way! So an issue is that, as I said, the PlatformMouseEvent's go fairly deep. In particular, we need to tell our Scrollbar's that the mouse position has changed relative to them. (This isn't true for the window scrollbars for the scrolling case, but is needed for a resize; for example, if the resize causes the mouse to be over or to leave the scrollbar, it may need to update its hover state.) Now, the stuff in Scrollbar.cpp isn't a problem, but it calls down to ScrollbarTheme ... which involves code in many places. There's also the mouse event dispatch code (going down into the DOM code), though that looks more easily manageable. Possible solutions: (1) Refactor everything, ditching PlatformMouseEvent's where possible. (Seems a bit like overkill? This would affect code in many places, including platform code.) (2) Add methods which don't require PlatformMouseEvent's alongside the current ones. (Adds either hard-to-maintain redundancy -- or complexity, if code is refactored to make things common. Not really any better than (1), since it would also touch platform code.) (3) Add an event type to PlatformMouseEvent -- "MouseEventUpdatePosition" or some such; code which cares can look for it. (Possible bugs in code which assumes all data are valid, but that would happen with fake mouse moves anyway.) (4) Generate fake PlatformMouseEvent's (with a fake MouseEventMoved). Obviously "works", but it's a pack of lies. I'm kind of inclined towards (3). For things like keyboard flags, one could similarly have "MouseEventUpdateKeys". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:52:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:52:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] New: Chromium: Show a "Playback Disabled" button on media error. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28196 Summary: Chromium: Show a "Playback Disabled" button on media error. Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P4 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: kylep at chromium.org Load and paint a mediaPlayDisabled image in RenderThemeChromiumSkia::paintMediaPlayButton() to display when the mediaElement cannot load. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 15:54:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 15:54:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090811225451.BDD2134B3830@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Kyle Prete changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34608| |review? Flag| | --- Comment #1 from Kyle Prete 2009-08-11 15:54:51 PDT --- Created an attachment (id=34608) --> (https://bugs.webkit.org/attachment.cgi?id=34608) Fix Loads and paints a disabled playback image. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:02:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:02:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090811230201.093DE34B38B5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34567|0 |1 is obsolete| | Attachment #34609| |review? Flag| | --- Comment #3 from George Wright 2009-08-11 16:02:00 PDT --- Created an attachment (id=34609) --> (https://bugs.webkit.org/attachment.cgi?id=34609) Canvas zooming fix using intrinsic coordinates New patch which updates the intrinsic coordinates instead of adding to the CSS properties. This also fixes the intrinsic coordinates not being updated for an initial style setting to a renderer. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:02:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:02:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28197] New: Changing the page encoding clears all forms Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28197 Summary: Changing the page encoding clears all forms Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Keywords: InChromiumBugs Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jshin at chromium.org 1. Type something in textarea of text input field 2. Change the character encoding 3. All forms are cleared. There's a very long standing gecko bug on this (almost 10 years old). IE also has the same issue. I was bitten by this issue multiple times here and mozilla bugzilla (before it switched to UTF-8). It's also http://crbug.com/18868 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:05:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:05:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090811230543.8610C34B3943@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34609|review? |review- Flag| | --- Comment #4 from Dave Hyatt 2009-08-11 16:05:42 PDT --- (From update of attachment 34609) Everything looks fine to me except for the if (!parent()) check in RenderReplaced::layout(). It's not clear to me why you would need that...are you sure you didn't just need to patch the intrinsicSizeChanged method for other replaced elements in a fashion similar to what you did in RenderHTMLCanvas? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:07:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:07:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] New: bugzilla-tool : various improvements for running the commit-queue Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28199 Summary: bugzilla-tool : various improvements for running the commit-queue Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org bugzilla-tool : various improvements for running the commit-queue I've been running the commit-queue today and found a bunch of little bugs in bugzilla-tool which I will post a patch here to fix. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:14:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:14:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] bugzilla-tool : various improvements for running the commit-queue In-Reply-To: References: Message-ID: <20090811231442.4079134B3A48@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28199 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34610| |review? Flag| | --- Comment #1 from Eric Seidel 2009-08-11 16:14:41 PDT --- Created an attachment (id=34610) --> (https://bugs.webkit.org/attachment.cgi?id=34610) Various little fixes for the commit-queue -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:18:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:18:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] bugzilla-tool : various improvements for running the commit-queue In-Reply-To: References: Message-ID: <20090811231839.4D52834B3AC2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28199 --- Comment #2 from Adam Barth 2009-08-11 16:18:38 PDT --- I'll review this in detail after dinner. For the moment, you should use os.devnull instead of "/dev/null" -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:25:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:25:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090811232508.AA1F634B3B7C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34608|review? |review- Flag| | --- Comment #2 from David Levin 2009-08-11 16:25:08 PDT --- (From update of attachment 34608) The diff here is odd. It should have WebCore/ prefixed before each file. I suspect that you are working from a chromium directory and that's why you have this problem. (I don't do that so I don't know the fix.) At worst fix it by hand to aid in landing your patch. > Index: ChangeLog > +2009-08-11 Kyle Prete > + > + Reviewed by NOBODY (OOPS!). > + You need the bug title and a link to the bug here. (see other changelog entries.) prepare-ChangeLog -bug # will give the you the right format. > + Use a disabled play button when the media file cannot be played. > + > + No new tests. (OOPS!) This shouldn't be here. Either add a test or indicate if existing tests cover this. > Index: rendering/RenderThemeChromiumSkia.cpp > static Image* mediaPlay = Image::loadPlatformResource("mediaPlay").releaseRef(); > static Image* mediaPause = Image::loadPlatformResource("mediaPause").releaseRef(); > + static Image* mediaPlayDisabled = Image::loadPlatformResource("mediaPlayDisabled").releaseRef(); > > + if (mediaElement->networkState() == HTMLMediaElement::NETWORK_NO_SOURCE) > + return paintMediaButtonInternal(paintInfo.context, rect, mediaPlayDisabled); This needs a 4 space indent. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:25:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:25:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28200] New: ListMarker should be included as part of the text value to parse Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28200 Summary: ListMarker should be included as part of the text value to parse Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cfleizach at apple.com If a list includes list markers, the list marker values need to be included as part of the text string. As an example, if bullet character is at the beginning of every list item, then each one of those bullet character needs to be part of the AXValue of the AXWebArea. And asking any of the text parsing SPIs, such as AXStringForRange, should include the bullet character. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:25:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:25:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090811232519.D126A34B3B94@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |levin at chromium.org Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:25:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:25:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28200] ListMarker should be included as part of the text value to parse In-Reply-To: References: Message-ID: <20090811232523.5F96934B3BB8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28200 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |cfleizach at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:38:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:38:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090811233824.9C3F934B3D2E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Viet-Trung Luu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34523|review? | Flag| | Attachment #34523|0 |1 is obsolete| | Attachment #34612| |review? Flag| | --- Comment #18 from Viet-Trung Luu 2009-08-11 16:38:20 PDT --- Created an attachment (id=34612) --> (https://bugs.webkit.org/attachment.cgi?id=34612) Updated with Jeremy's suggested comment (more or less). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:42:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:42:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090811234250.C008B34B3DDE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 --- Comment #19 from Jeremy Moskovich 2009-08-11 16:42:48 PDT --- Looks Good -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:48:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:48:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28201] New: Input fields with more than 65k characters are rendered incorrectly Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28201 Summary: Input fields with more than 65k characters are rendered incorrectly Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: vandebo-webkitbugzilla at nerdbox.net Created an attachment (id=34613) --> (https://bugs.webkit.org/attachment.cgi?id=34613) Html with >65k input field Safari and Chrome incorrectly render text fields that have more than 65,535 characters. Only the first (length mod 2^16) characters are rendered and are editable. However, when there are 2^16 or more characters in a text field, they are all properly sent to the server on submit. The attached test case demonstrates this problem. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:49:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:49:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] New: run-webkit-tests --quiet hangs Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28202 Summary: run-webkit-tests --quiet hangs Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org run-webkit-tests --quiet hangs My perl-fu is not strong. :( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:49:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:49:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] run-webkit-tests --quiet hangs In-Reply-To: References: Message-ID: <20090811234936.9B0FC34B3EB1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28202 --- Comment #1 from Eric Seidel 2009-08-11 16:49:35 PDT --- I talked this out with "buu" in #perl, and this was the best we came up with. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:50:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:50:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] run-webkit-tests --quiet hangs In-Reply-To: References: Message-ID: <20090811235051.A4C2A34B3ED8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34614| |review? Flag| | --- Comment #2 from Eric Seidel 2009-08-11 16:50:50 PDT --- Created an attachment (id=34614) --> (https://bugs.webkit.org/attachment.cgi?id=34614) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:57:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:57:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090811235726.DB66634B3F96@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Kyle Prete changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34608|0 |1 is obsolete| | Attachment #34615| |review? Flag| | --- Comment #3 from Kyle Prete 2009-08-11 16:57:25 PDT --- Created an attachment (id=34615) --> (https://bugs.webkit.org/attachment.cgi?id=34615) Fix Thanks for the review. Your comments should be covered by this revision. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 16:59:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 16:59:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090811235931.758E934B3FC2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34615|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:00:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:00:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812000002.4B3B934B3FD2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34615| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:07:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:07:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code In-Reply-To: References: Message-ID: <20090812000733.35E3A34B408C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27967 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34496|review? | Flag| | Attachment #34496|0 |1 is obsolete| | Attachment #34617| |review? Flag| | --- Comment #10 from Dumitru Daniliuc 2009-08-11 17:07:30 PDT --- Created an attachment (id=34617) --> (https://bugs.webkit.org/attachment.cgi?id=34617) patch Same patch, SQLTransactionClient's methods are no longer virtual as suggested by Michael. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:20:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:20:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090812002029.B737934B41A1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34609|0 |1 is obsolete| | Attachment #34618| |review? Flag| | --- Comment #5 from George Wright 2009-08-11 17:20:28 PDT --- Created an attachment (id=34618) --> (https://bugs.webkit.org/attachment.cgi?id=34618) Removed unnecessary null pointer check You're right - that null pointer check was an artifact left over from testing. It works fine without it. I have also added the new test which I forgot to put in my last patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:44:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:44:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27656] REGRESSION: Clicking on popup menu changes layout In-Reply-To: References: Message-ID: <20090812004431.698FF34B43E9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27656 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.fraser at apple.com --- Comment #3 from Simon Fraser (smfr) 2009-08-11 17:44:30 PDT --- It's focus, not clicking that is the issue; the focus ring is affecting layout. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:54:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:54:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812005444.4407734B457D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34592|review? |review- Flag| | --- Comment #3 from Darin Adler 2009-08-11 17:54:43 PDT --- (From update of attachment 34592) > + Vector cookies; > + Document* document = ic->inspectedPage()->mainFrame()->domWindow()->document(); > + cookies = rawCookies(document, document->cookieURL()); You should declare the cookies vector on the same line where you initialize it. But, you should not use Vector for a return value; copying it to return it is very inefficient. Instead you should name this function getRawCookies and use a Vector& as an out parameter. > + Cookie cookie = cookies[i]; To avoid making an extra copy of each cookie in the vector this can be a "const Cookie&" instead of Cookie. > + JSObject* cookieObj = constructEmptyObject(exec); We prefer not to abbreviate, so please say cookieObject. > + cookieObj->putDirect(Identifier(exec, "name"), jsString(exec, cookie.name())); > + cookieObj->putDirect(Identifier(exec, "value"), jsString(exec, cookie.value())); > + cookieObj->putDirect(Identifier(exec, "domain"), jsString(exec, cookie.domain())); > + cookieObj->putDirect(Identifier(exec, "path"), jsString(exec, cookie.path())); > + cookieObj->putDirect(Identifier(exec, "expires"), jsString(exec, cookie.expires())); > + cookieObj->putDirect(Identifier(exec, "httpOnly"), jsBoolean(cookie.isHttpOnly())); > + cookieObj->putDirect(Identifier(exec, "secure"), jsBoolean(cookie.isSecure())); > + cookieObj->putDirect(Identifier(exec, "session"), jsBoolean(cookie.isSession())); This will be relatively slow since it's going to create each of these identifiers from the constant string each time through the loop, which is a hash table lookup every time. It might be good to instead create local variables for each identifier so each will be created exactly once. On the other hand, the jsString operations are relatively costly too, so it's probably not all that important to optimize. > + result.append( cookieObj ); The spaces around the argument are not the correct style. > + // return jsNumber(exec, cookies.size()); Oops, left in this commented code! > + class Cookie { > + public: > + Cookie(const String& name, const String& value, const String& domain, > + const String& path, const String& expires, const bool httpOnly, > + const bool secure, const bool session) No need for the "const" in "const bool". Would be nice to indent this so the lines don't exactly line up with the ":". I often use indent by an extra tab stop. For a pure data holder like this, you might want to consider just using a struct instead of a class with getter functions. > class KURL; > class String; > class Document; > + class Cookie; These should be sorted alphabetically. Not sure why Document wasn't already. > #import "config.h" > +#import "Cookie.h" > #import "CookieJar.h" The new include should be added to the paragraph below, not put above the file's own header. The file's own header always comes first. > + NSString* name = [cookie name]; > + NSString* value = [cookie value]; > + NSString* domain = [cookie domain]; > + NSString* path = [cookie path]; > + NSString* expires = [[cookie expiresDate] description]; It's a bit strange to put this date into this string form, but I don't have a better suggestion at the moment. Our coding style is to put the * next to the variable name for Objective-C types like this one. > + bool httpOnly = [cookie isHTTPOnly]; > + bool secure = [cookie isSecure]; > + bool session = [cookie isSessionOnly]; > + Cookie cookieData = Cookie(name, value, domain, path, expires, httpOnly, secure, session); > + rawCookies.append(cookieData); > + } > + > + return rawCookies; You shouldn't need this return statement here. It's OK to fall through to the return outside the block exceptions macro. This patch will break all platforms other than Mac OS X. You can't land it like that, so you'll need to figure out what to do for those other platforms. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:54:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:54:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] New: [Chromium] drop down menu letter selection, skip selections Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28205 Summary: [Chromium] drop down menu letter selection, skip selections Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.njtransit.com/sf/sf_servlet.srv?hdnPageActi on=TrainSchedulesTo OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: xji at chromium.org steps to reproduce the problem? 1. go to the above website with a dropdown selection menu 2. click the drop down menu to show selections 3. press a letter (such as 'A') to skip to the selection you want 4. it will automatically skip to the 2nd corresponding lettered selection 5. continue press 'A', it selects every other item. Chromium bug: http://code.google.com/p/chromium/issues/detail?id=18950 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:55:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:55:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812005528.C292034B45A9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InChromiumBugs CC| |xji at chromium.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:56:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:56:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812005605.DE88634B45D9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34562|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 17:56:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 17:56:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812005621.C3C1034B45F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34577|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:06:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:06:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812010605.3FE1A34B4725@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34562|review+ | Flag| | --- Comment #7 from Adam Treat 2009-08-11 18:06:04 PDT --- (From update of attachment 34562) Landed with r47077, clearing review flag. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:18:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:18:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28206] New: onbeforeunload not called at window close + frame or iframe focused Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28206 Summary: onbeforeunload not called at window close + frame or iframe focused Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=34628) --> (https://bugs.webkit.org/attachment.cgi?id=34628) testcase I Steps: 1. open a page with a frameset or an iframe (attached files) 2. focus the frame 3. close the window II Issue: onbeforeunload is not executed. Related Webkit bugs https://bugs.webkit.org/show_bug.cgi?id=19418 as well as https://bugs.webkit.org/show_bug.cgi?id=21669 are about an onbeforeunload handler when it is assigned to the frame content or the iframe itself. This bug is about onbeforeonload assigned to a window which contain an iframe or a frameset. The handler is properly called if we back the document or if we load the document and immediately close the window. Yet if the contained frame or iframe is focused (using JS as in the attached reduction) when the window is closed then, the window beforeonload handler is not called. III Browsers info: Chrome 3.x : NOT OK Safari 3/Win: NOT OK Safari 3/Mac: OK Safari 4/Mac: OK Firefox 3.x: OK IE 8: OK Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=17157 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:19:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:19:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28206] onbeforeunload not called at window close + frame or iframe focused In-Reply-To: References: Message-ID: <20090812011923.095A334B574E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28206 --- Comment #1 from jasneet 2009-08-11 18:19:21 PDT --- Created an attachment (id=34629) --> (https://bugs.webkit.org/attachment.cgi?id=34629) testcase -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:19:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:19:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28206] onbeforeunload not called at window close + frame or iframe focused In-Reply-To: References: Message-ID: <20090812011934.9696034B5766@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28206 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:26:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:26:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812012649.BBFEA34B5BF7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Xiaomei Ji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34631| |review? Flag| | --- Comment #1 from Xiaomei Ji 2009-08-11 18:26:48 PDT --- Created an attachment (id=34631) --> (https://bugs.webkit.org/attachment.cgi?id=34631) patch w/ manual test -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 18:33:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 18:33:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28207] New: Another deadlock in the DB code Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28207 Summary: Another deadlock in the DB code Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: dumi at chromium.org CC: andersca at apple.com, beidson at apple.com, aroben at apple.com, michaeln at google.com, dglazkov at chromium.org Bug 27966 describes how 2 transactions run on 2 different handles to the same DB can deadlock the DB thread. Here's an example of how a transaction combined with a openDatabase() call can deadlock the DB thread and block the main thread at the same time: 1: var db1 = openDatabase("SomeDB", "1.0", "Blah", 10000); 2: db1.transaction(function(tx) { 3: tx.executeSql("SomeWriteStatement", [args], 4: function(result) { var db2 = openDatabase("SomeDB", "1.0", "Blah", 10000); }, 5: function(tx, error) { }); 6: }, 7: function(error) { }, 8: function() { } 9: ); Description: 1. The user opens a handle to a database (line #1). 2. The user starts running a transaction on that handle (line #2). The transaction must have a "write" statement, that will make SQLite acquire an exclusive lock on the DB file (line #3). 3. Eventually, we get to running the statement callback (line #4). 4. openDatabase() is called on the main thread (line #4). 5. The main thread creates a new SQLite connection to the same DB file, schedules a task on the DB thread (to make sure the version is correct), and blocks waiting for this task to complete (openDatabase() is a sync call according to the spec). 6. In order to check the version, the new task needs to acquire a "read" lock on the DB file first and check if the __WebKitDatabaseInfoTable__ table exists. 7. This "read" lock cannot be acquired because the transaction has an exclusive lock on the DB file. At the same time, the transaction cannot release the exclusive lock until the statement callback is executed. So the DB thread is deadlocked, and the main thread is blocked too, because it waits for the openDatabase() call to finish. Safari's debug build from trunk deadlocks for 30 seconds (SQLite's busy_timeout) and then crashes. PROPOSED FIX: It's OK for the first call to openDatabase(SomeDB, ...) to execute SQL statements, because we know there are no in-flight transactions on other DB handles to the same database. However, the 2nd, 3rd, ... calls to openDatabase(SomeDB, ...) cannot run any SQL statements without risking a deadlock. So in addition to caching the DB version (this is what WebCore does now), we need to also cache a flag that tells us if the __WebKitDatabaseInfoTable__ exists in the database. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:16:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:16:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] bugzilla-tool : various improvements for running the commit-queue In-Reply-To: References: Message-ID: <20090812021633.B1C9E34B8A78@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28199 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34610|review? |review+ Flag| | --- Comment #3 from Adam Barth 2009-08-11 19:16:32 PDT --- (From update of attachment 34610) These are all good bugs to fix. Two minor things to fix before landing: 1) "/dev/null" -> os.devnull 2) "Clearing review flag on attachment" -> this text now doesn't quite match what we're doing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:22:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:22:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26854] [GTK] Needs API to allow more control over outgoing requests In-Reply-To: References: Message-ID: <20090812022200.8433C34B8E06@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26854 --- Comment #11 from Gustavo Noronha (kov) 2009-08-11 19:21:59 PDT --- (In reply to comment #9) > I think instead of sending the identifier, we can do a WebResource lookup by > identifier and send the resource instead. Thoughts? That sounds good to me, yeah =D -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:42:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:42:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28208] New: Typo in FastMalloc.h causes build to fail Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28208 Summary: Typo in FastMalloc.h causes build to fail Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: thomas at cranksoftware.com Trying to get a stock version built for Windows I ran across this typo in WebKit/JavaScriptCore/wtf/FastMalloc.h that caused the compile to stop dead. I'm just using the stock build procedure from the website, no extra arguments, so I'm surprised this isn't hitting others. The patch is a simple typo fix in an inline declaration s -> size Patch is attached -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:43:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:43:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] New: Restrict use of FuncDeclNode & FuncExprNode to the parser. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28209 Summary: Restrict use of FuncDeclNode & FuncExprNode to the parser. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: barraclough at apple.com These objects were also being referenced from the CodeBlock. By changing this to just retain pointers to FunctionBodyNodes these classes can be restricted to use during parsing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:50:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:50:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812025055.686D234B90B6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34633| |review? Flag| | --- Comment #1 from Gavin Barraclough 2009-08-11 19:50:54 PDT --- Created an attachment (id=34633) --> (https://bugs.webkit.org/attachment.cgi?id=34633) The Patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 19:54:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 19:54:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812025458.869A034B9121@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34633|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 20:32:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 20:32:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812033234.8DB2534B9440@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34592|0 |1 is obsolete| | Attachment #34634| |review? Flag| | --- Comment #4 from Joseph Pecoraro 2009-08-11 20:32:33 PDT --- Created an attachment (id=34634) --> (https://bugs.webkit.org/attachment.cgi?id=34634) Fixed Based on Review This is an attempt at a real workable version that hopefully won't break the build. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 20:35:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 20:35:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28208] Typo in FastMalloc.h causes build to fail In-Reply-To: References: Message-ID: <20090812033546.9C32134B948E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28208 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrowe at apple.com --- Comment #1 from Mark Rowe (bdash) 2009-08-11 20:35:45 PDT --- There's no patch attached, and I don't see any references to "s" in FastMalloc.h in . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 20:40:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 20:40:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812034054.50F7834B94F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 --- Comment #5 from Joseph Pecoraro 2009-08-11 20:40:53 PDT --- (In reply to comment #3) > You should declare the cookies vector on the same line where you initialize it. > But, you should not use Vector for a return value; copying it to return it is > very inefficient. Instead you should name this function getRawCookies and use a > Vector& as an out parameter. Done. Made the Vector an out parameter, but that requires the declaration to again be on another line. > To avoid making an extra copy of each cookie in the vector this can be a "const > Cookie&" instead of Cookie. Done. > We prefer not to abbreviate, so please say cookieObject. Done. Noted. > This will be relatively slow since it's going to create each of these > identifiers from the constant string each time through the loop, which is a > hash table lookup every time. It might be good to instead create local > variables for each identifier so each will be created exactly once. On the > other hand, the jsString operations are relatively costly too, so it's probably > not all that important to optimize. Done. I moved Initializers out and made them const. > The spaces around the argument are not the correct style. Done. Including all other style fixes. > No need for the "const" in "const bool". Would be nice to indent this so the > lines don't exactly line up with the ":". I often use indent by an extra tab > stop. Done. > For a pure data holder like this, you might want to consider just using a > struct instead of a class with getter functions. Done. Made a struct. Including a new field "size" (see below). > The new include should be added to the paragraph below, not put above the > file's own header. The file's own header always comes first. Done. Noted. > It's a bit strange to put this date into this string form, but I don't have a > better suggestion at the moment. Done. Noted. > Our coding style is to put the * next to the variable name for Objective-C > types like this one. Done. Noted. > This patch will break all platforms other than Mac OS X. You can't land it like > that, so you'll need to figure out what to do for those other platforms. Attempted. I searched and identified, hopefully all, other platforms. Most don't really make support for this easy, and I have no way of testing on them at all. What is the best course of action for something like this? ------------ I added another field to the Cookie struct, "size". Firebug's "size" parameter seems to be the (size of the name + size of the value). I decided to put this into the struct, and then make it available in the constructed jsObjects for the inspector. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 20:44:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 20:44:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812034415.8B65C34B954D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #20 from Michael Nordman 2009-08-11 20:44:12 PDT --- The code LGTM. Possibly some names could be tweeked to better fit webkit conventions? In all cases, you'll need a webkit reviewer to take a peek. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 20:46:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 20:46:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812034623.A23CD34B957D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 --- Comment #6 from Joseph Pecoraro 2009-08-11 20:46:23 PDT --- Oh, one final question. Inside CookieJar.h I include . This seems to make it unnecessary to include again in each of the platform specific implementations... but I included them anyways. I could probably do the same for Cookie.h What is the proper way to go about this? - Include in just the header - Include in both the header and the implementation Seeing as it compiled for me without declaring in both places I'm guessing this is a style issue, and I'm guessing certain editors might work better with the declaration in both files. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:30:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:30:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] New: Document relation between major objects in WebCore Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28210 Summary: Document relation between major objects in WebCore Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: WebKit Website AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abarth at webkit.org We should create a page on the web site that explains the relation between the major objects in webcore, especially when those relations can be null. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:32:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:32:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] New: Can't click and drag the media controller thumb Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28211 Summary: Can't click and drag the media controller thumb Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.fraser at apple.com With TOT, the media slider doesn't move with the cursor when I mouse down and drag it over the controller. The media slider only updates it's position after I mouse up after I drag it. This is a regression on TOT since this doesn't happen on stock SL 10A342. This regression was caused by http://trac.webkit.org/changeset/46915 since it doesn't happen with previous checkin 46914. * STEPS TO REPRODUCE 1. Launch a nightly webkit build and go to http://www.mirageband.tv/Night%20and%20Day.mp3 2. Wait for entire file to load then pause it 3. Mouse down directly on the slider and drag the mouse to another section on the controller. Notice the slider doesn't move until you mouse up. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:32:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:32:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812043258.336D534B996A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.carlson at apple.com, | |simon.fraser at apple.com Platform|PC |All -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:33:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:33:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812043314.D853334B997C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #1 from Simon Fraser (smfr) 2009-08-11 21:33:14 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:34:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:34:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27920] Right click on timeline of media controls panel cause seek In-Reply-To: References: Message-ID: <20090812043400.B5E4A34B99A0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27920 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.fraser at apple.com --- Comment #9 from Simon Fraser (smfr) 2009-08-11 21:33:58 PDT --- This caused a bad regression in mouse handling (bug 28211). Please address as soon as possible, or revert this change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:36:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:36:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22280] CG GIF decoder uses too much CPU In-Reply-To: References: Message-ID: <20090812043602.F11E134B99CA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22280 Knodi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcobra at gmail.com --- Comment #13 from Knodi 2009-08-11 21:36:00 PDT --- Are you kidding me wait for OS upgrade for fix your browser freezing up on gifs?? What are you fucking microsoft?? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:39:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:39:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812043944.CFA6534B9A17@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34635| |review? Flag| | --- Comment #1 from Adam Barth 2009-08-11 21:39:43 PDT --- Created an attachment (id=34635) --> (https://bugs.webkit.org/attachment.cgi?id=34635) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:40:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:40:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812044027.98A5834B9A2C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34635|review? | Flag| | Attachment #34635|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:40:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:40:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812044037.9DA7B34B9A49@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34636| |review? Flag| | --- Comment #2 from Adam Barth 2009-08-11 21:40:36 PDT --- Created an attachment (id=34636) --> (https://bugs.webkit.org/attachment.cgi?id=34636) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:43:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:43:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812044355.7AA8834B9A9A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34637| |review? Flag| | --- Comment #6 from Oliver Hunt 2009-08-11 21:43:54 PDT --- Created an attachment (id=34637) --> (https://bugs.webkit.org/attachment.cgi?id=34637) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:48:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:48:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812044827.00A4B34B9AF6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34636|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:55:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:55:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812045501.7C40334B9B9F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34637|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:55:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:55:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812045538.A3EB834B9BC5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Adam Barth 2009-08-11 21:55:37 PDT --- Sending WebKitSite/ChangeLog Adding WebKitSite/coding/major-objects.html Transmitting file data .. Committed revision 47085. http://trac.webkit.org/changeset/47085 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 21:57:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 21:57:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812045736.EB15534B9BFB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #7 from Oliver Hunt 2009-08-11 21:57:36 PDT --- Committed r47086 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:13:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:13:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28207] Another deadlock in the DB code In-Reply-To: References: Message-ID: <20090812051328.0158C34B9D62@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28207 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:13:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:13:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812051339.A600434B9D6A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:14:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:14:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27920] Right click on timeline of media controls panel cause seek In-Reply-To: References: Message-ID: <20090812051406.5ED1C34B9D94@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27920 --- Comment #10 from Hin-Chung Lam 2009-08-11 22:14:04 PDT --- I'm looking into the regression now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:16:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:16:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28206] onbeforeunload not called at window close + frame or iframe focused In-Reply-To: References: Message-ID: <20090812051610.DF50B34B9DD0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28206 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE --- Comment #2 from Alexey Proskuryakov 2009-08-11 22:16:09 PDT --- *** This bug has been marked as a duplicate of bug 27481 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:16:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:16:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27481] onbeforeunload not called at window close + frame or iframe focused In-Reply-To: References: Message-ID: <20090812051611.EC53834B9DDE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27481 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jasneet at chromium.org --- Comment #2 from Alexey Proskuryakov 2009-08-11 22:16:09 PDT --- *** Bug 28206 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:18:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:18:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28197] Changing the page encoding clears all forms In-Reply-To: References: Message-ID: <20090812051805.913A334B9E06@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28197 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:21:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:21:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21945] (https://bugs.webkit.org/attachment.cgi?id=34638) Patch v1 --- 3 files changed, 184 insertions(+), 175 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:36:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:36:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19146] [CURL] https pages not loading. In-Reply-To: References: Message-ID: <20090812053642.3545F34BA047@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19146 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |bfulgham at webkit.org Resolution| |FIXED --- Comment #4 from Brent Fulgham 2009-08-11 22:36:41 PDT --- I believe the cause of this bug was resolved by Bug 28171. The point may be moot, now that the Linux port is using SOUP. Please reopen if the problem is still valid for your platform using the current WebKit revision. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:41:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:41:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090812054120.96C2334BA0C1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #10 from Shinichiro Hamaji 2009-08-11 22:41:18 PDT --- Filed Bug 28212 as the step 0. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:46:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:46:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812054623.6AC2C34BA136@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34638|review? |review+ Flag| | --- Comment #2 from Eric Seidel 2009-08-11 22:46:23 PDT --- (From update of attachment 34638) Assuming this is just a simple rename. LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:47:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:47:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23092] Conditionalize CFNetwork-specific logic in WebKit.dll In-Reply-To: References: Message-ID: <20090812054751.A84B534BA15A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23092 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zucker at wake3.com --- Comment #13 from Brent Fulgham 2009-08-11 22:47:50 PDT --- *** Bug 18471 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:47:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:47:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17730] Allows Windows version to use Curl In-Reply-To: References: Message-ID: <20090812054752.225A234BA160@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17730 Bug 17730 depends on bug 18471, which changed state. Bug 18471 Summary: Fix WebDownload.cpp compile problems for cairo/curl build https://bugs.webkit.org/show_bug.cgi?id=18471 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Status|ASSIGNED |RESOLVED Resolution| |DUPLICATE -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:48:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:48:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090812054818.C2FDE34BA17C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #11 from Shinichiro Hamaji 2009-08-11 22:48:17 PDT --- Thanks for the detailed comments on this task and future road maps! The steps Darin suggest sounds definitely better than my "change at once" plan. I'd like to follow the steps. The future road maps also sound nice. I'll be happy if I can help any of them. By the way, I've noticed that running make-js-test-wrappers change 4 HTMLs which are slightly modified from the original TEMPLATE. I think we need to fix this before the step 1. I'll send a patch soon later. I hope my change makes sense. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:52:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:52:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812055204.1805734BA1CC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34634|review? |review+ Flag| | --- Comment #7 from Darin Adler 2009-08-11 22:52:03 PDT --- (From update of attachment 34634) > + Document* document = ic->inspectedPage()->mainFrame()->domWindow()->document(); >From mainFrame() you can get to the document directly. No need to go through domWindow(). > + const Identifier nameIdentifier = Identifier(exec, "name"); > + const Identifier valueIdentifier = Identifier(exec, "value"); > + const Identifier domainIdentifier = Identifier(exec, "domain"); > + const Identifier pathIdentifier = Identifier(exec, "path"); > + const Identifier expiresIdentifier = Identifier(exec, "expires"); > + const Identifier sizeIdentifier = Identifier(exec, "size"); > + const Identifier httpOnlyIdentifier = Identifier(exec, "httpOnly"); > + const Identifier secureIdentifier = Identifier(exec, "secure"); > + const Identifier sessionIdentifier = Identifier(exec, "session"); You can use construction syntax instead of assignment for these. Also, no real reason to make them const. After all, almost any local variable in most programs could be marked const, and for brevity we normally don't do it unless there's a special reason to. Identifier nameIdentifier(exec, "name"); and so on. > + const String name; > + const String value; > + const String domain; > + const String path; > + const String expires; > + const bool httpOnly; > + const bool secure; > + const bool session; > + const unsigned size; Making all these data members const isn't really all that good an idea. If someone wants to use a Cookie in some non-const way, perhaps modifying one of these, then declaring it this way would get in the way, for no good reason. On the other hand, clients who don't want to modify a Cookie object get the same effect you got here by just saying "const Cookie". I'd leave off all the const on the individual members. > +void getRawCookies(const Document*, const KURL& url, Vector& rawCookies) > +{ > + rawCookies.clear(); > + BEGIN_BLOCK_OBJC_EXCEPTIONS; > + > + NSURL *cookieURL = url; > + NSArray *cookies = [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:cookieURL]; > + > + NSUInteger count = [cookies count]; For best memory use and performance, you will want to do this here: rawCookies.reserveCapacity(count); This allocates the memory for the vector rather than sizing it up each time you hit the limit while appending. It's faster and saves a bit on extra storage. Once you've done that change, it is then safe to use the slightly faster uncheckedAppend function below inside the loop instead of append. But even if you chose not to do uncheckedAppend, reserveCapacity is a good idea. > + for (NSUInteger i = 0; i < count; ++i) { > + NSHTTPCookie *cookie = (NSHTTPCookie *)[cookies objectAtIndex:i]; > + NSString *name = [cookie name]; > + NSString *value = [cookie value]; > + NSString *domain = [cookie domain]; > + NSString *path = [cookie path]; > + NSString *expires = [[cookie expiresDate] description]; > + bool httpOnly = [cookie isHTTPOnly]; > + bool secure = [cookie isSecure]; > + bool session = [cookie isSessionOnly]; > + Cookie cookieData = Cookie(name, value, domain, path, expires, httpOnly, secure, session); Again could use construction syntax here: Cookie cookieData(name, value, domain, path, expires, httpOnly, secure, session); > + rawCookies.append(cookieData); Or you could construct right in the append function call: rawCookies.uncheckedAppend(Cookie(name, value, domain, path, expires, httpOnly, secure, session)); Otherwise this looks really great. None of my comments are critical, so I'll say r=me on this version, but feel free to do a revised version if you like some of the things I propose above. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:52:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:52:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28185] Inspector: Show Hidden Cookie Data In-Reply-To: References: Message-ID: <20090812055222.4DBF834BA1DE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28185 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED CC| |darin at apple.com AssignedTo|webkit-unassigned at lists.web |joepeck02 at gmail.com |kit.org | Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:53:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:53:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812055300.9A39B34BA202@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #4 from Darin Adler 2009-08-11 22:52:59 PDT --- This diagram shows DOMWindow between Frame and Document. But it's not really like that. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:54:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:54:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812055434.176CC34BA251@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #8 from Darin Adler 2009-08-11 22:54:33 PDT --- (From update of attachment 34637) Why not use inherits(&InternalFunction::info) instead of calling getCallData and then special-casing JSArray? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:56:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:56:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20732] -lws2_32 not -lWs2_32 In-Reply-To: References: Message-ID: <20090812055607.1396534BA299@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20732 Brent Fulgham changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #1 from Brent Fulgham 2009-08-11 22:56:06 PDT --- The GTK builds no longer use cURL. The WinCairo link flags have the desired capitalization. I also double-checked the source archive and can't find any instances of -lWs2_32 anywhere, so I believe this issue has been resolved. Please reopen if you are still seeing this problem. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:56:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:56:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25880] js tests should move into jstests subdirectory instead of resources/ In-Reply-To: References: Message-ID: <20090812055634.CB70D34BA2B3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25880 --- Comment #12 from Eric Seidel 2009-08-11 22:56:33 PDT --- Yes, it's common the .js files get added to resources/ and not ignored in make-js-test-wrappers. That's why we're doing this! To make that problem go away. Once we have a separate directory for the script-tests then we won't need this silly ignore list. So yes, please feel encouraged to add those 4 files to the ignore list. You have my rubber-stamp already and do no need to post such a change for review. I might also add that further in my personal roadmap would be moving all of the js-test-pre.js stuff out of fast/js/resources and into a LayoutTests/script-tests-harness directory, or some other nicely-named top-level directory where we can put more of this testing framework in an easily accessible place. I would also like to add more support to make-js-test-wrappers, including some sort of template system. So that either via a comment in the script-test/my-test.js file or via a an otherwise-ignored template("name.html") call, that we can have custom templates on a per-file basis. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 22:56:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 22:56:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812055649.2DE6934BA2BD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 --- Comment #3 from Darin Adler 2009-08-11 22:56:48 PDT --- (From update of attachment 34638) Did you use "svn mv"? If not, why not? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:05:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:05:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812060500.62D1634BA361@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #9 from Oliver Hunt 2009-08-11 23:04:59 PDT --- (In reply to comment #8) > (From update of attachment 34637 [details]) > Why not use inherits(&InternalFunction::info) instead of calling getCallData > and then special-casing JSArray? The uses the IsCallable internal function -- inheriting from InternalFunction is not a sufficient check, but now i've tested firefox with a regex, /a/, they clearly are ignoring IsCallable *yay* -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:10:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:10:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812061039.A917F34BA41D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 --- Comment #4 from Shinichiro Hamaji 2009-08-11 23:10:39 PDT --- (In reply to comment #3) > (From update of attachment 34638 [details]) > Did you use "svn mv"? If not, why not? Ah, I'm using git and I used git mv and it seems to make the patch big. Is it better to use svn when we should rename files? Or, are there any equivalents in git world? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:13:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:13:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27656] REGRESSION: Clicking on popup menu changes layout In-Reply-To: References: Message-ID: <20090812061330.70D1834BA46B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27656 --- Comment #4 from Ton Voon 2009-08-11 23:13:29 PDT --- (In reply to comment #3) > It's focus, not clicking that is the issue; the focus ring is affecting layout. I don't think it is the focus ring (unless there is something happening in the background). If I add this to the CSS: input[type=text]:focus, input[type=password]:focus, textarea:focus, select:focus { outline: 0 none; } This removes the blue ring, but the layout still changes on click. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:16:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:16:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26715] bugzilla-tool should automate rollouts In-Reply-To: References: Message-ID: <20090812061606.5942734BA4B9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26715 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33930|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:16:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:16:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26715] bugzilla-tool should automate rollouts In-Reply-To: References: Message-ID: <20090812061615.1F6F334BA4D2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26715 --- Comment #11 from Eric Seidel 2009-08-11 23:16:13 PDT --- Created an attachment (id=34639) --> (https://bugs.webkit.org/attachment.cgi?id=34639) Updated to ToT --- 4 files changed, 123 insertions(+), 3 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:16:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:16:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090812061638.ED43134BA512@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Zoltan Herczeg changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34127|review+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:17:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:17:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090812061702.EEEA634BA546@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Zoltan Herczeg changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34128|review+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:23:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:23:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26755] bugzilla-tool's commit messages are lacking for patches with multiple ChangeLogs In-Reply-To: References: Message-ID: <20090812062334.BE0E534BA5E2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26755 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|eric at webkit.org |webkit-unassigned at lists.web | |kit.org --- Comment #6 from Eric Seidel 2009-08-11 23:23:33 PDT --- Ideally what will happen is we'll convert commit-log-editor to a python module and re-use it from within bugzilla-tool. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:31:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:31:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090812063104.9343134BA6AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34560|review? |review+ Flag| | --- Comment #100 from Gavin Barraclough 2009-08-11 23:30:58 PDT --- (From update of attachment 34560) > #define WTF_USE_CONSTANT_POOL 1 Gah, I'm really sorry, but I'm going to have to pick you up on an annoying technicality. We should not be defining WTF_USE_ macros outside of Platform.h (there is another example of this being done, but it's a bug. you'll see that ENABLE_, WTF_PLATFORM_, etc are only defined in Platform.h). The problem generally with defining these values in other headers is that the macros allow the value no to be defined, which could lead to unexpected behaviour. Consider, for example, if '#define ENABLE_JIT 1' was defined in JIT.h, rather than Platform.h. For any .cpp files that include JIT.h the expression 'ENABLE(JIT)' will be true, but for any files that happen not to include JIT.h this will evaluate to false. Whilst there is no bug in the way you've used this, or any clear way that it could lead to a bug in this case, I think we want to keep the design rule that the USE() etc marco are only used with values defined in Platform.h. The way that you've structured the macros (defining the value in AssemblerBufferWithConstantPool.h) seems perfectly sensible, so rather than trying to move this up into Platform.h I'd suggest you may just want to consider a quick rename & stop using the USE macro in this case - just switch '#define WTF_USE_CONSTANT_POOL 1' to something like '#define ASSEMBLER_HAS_CONSTANT_POOL 1' and replace 'USE(CONSTANT_POOL)' with 'defined(ASSEMBLER_HAS_CONSTANT_POOL)'. I'm going to call this an r+-with-changes, since everything else looks good. If you update a new patch with the macro name fixed one way or another I'll get it landed for you. BTW, I'm guessing this may be your intention already, but let's make this the last change on this über-bug - from now on I think all future patch should get a bug of their own, as per normal process. cheers, G. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:34:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:34:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] New: Some HTMLs are modified by make-script-test-wrappers Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28213 Summary: Some HTMLs are modified by make-script-test-wrappers Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hamaji at chromium.org We should do either re-generate them or add them into exclude list in make-script-test-wrappers. I believe only fast/js/resources/const.js should be in the excluded list and other HTMLs should be re-generated. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:38:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:38:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812063833.9BE6134BA753@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 Shinichiro Hamaji changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34640| |review? Flag| | --- Comment #1 from Shinichiro Hamaji 2009-08-11 23:38:32 PDT --- Created an attachment (id=34640) --> (https://bugs.webkit.org/attachment.cgi?id=34640) Patch v1 --- 6 files changed, 28 insertions(+), 3 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:40:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:40:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812064023.3BDE234BA77A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 --- Comment #2 from Shinichiro Hamaji 2009-08-11 23:40:22 PDT --- (In reply to comment #1) > Created an attachment (id=34640) --> (https://bugs.webkit.org/attachment.cgi?id=34640) [details] Note that this patch is intended to be applied after Bug 28212. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Tue Aug 11 23:48:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Tue, 11 Aug 2009 23:48:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27656] REGRESSION: Clicking on popup menu changes layout In-Reply-To: References: Message-ID: <20090812064817.B48E934BA82C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27656 --- Comment #5 from Ton Voon 2009-08-11 23:48:17 PDT --- A comment at doctype.com (http://doctype.com/questions/whats-best-way-overcome-safari-4-bug-css-tableless-form) suggests that a partial redraw could be occuring which is missing the
    tag from the field prior to the popup. This appears to be correct when I run Quartz Debug. On Safari 3, the redraw flash appears over the previous text box, the popup and the button, whereas in webkit nightly, the redraw flashes for the popup and the button. It seems to me like the previous
    tag is not considered for redrawing the layout on the popup click, hence missing the clear:left and the label floats are then aligned together. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 00:25:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 00:25:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090812072553.62E7634BABD3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gabor Loki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34560|0 |1 is obsolete| | Attachment #34641| |review? Flag| | --- Comment #101 from Gabor Loki 2009-08-12 00:25:49 PDT --- Created an attachment (id=34641) --> (https://bugs.webkit.org/attachment.cgi?id=34641) Add optimize call and property access support for ARM JIT v2 I have did the requested changes from comment #100 :-), and marked the attachment 34560 with obsolete flag which was r+-with-changes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 00:34:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 00:34:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28214] New: -webkit-box-shadow forces image to display at low resolution Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28214 Summary: -webkit-box-shadow forces image to display at low resolution Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: charles_ying at yahoo.com CC: simon.fraser at apple.com, cmarrin at apple.com Created an attachment (id=34642) --> (https://bugs.webkit.org/attachment.cgi?id=34642) test case and reduction In the following test reduction, having a -webkit-box-shadow on a DIV containing an image forces the image to stay at a lower resolution when zoomed in. To toggle the zoom, press the Space bar. The image in question is 300x300. The image is sized down to 50px and scaled up by a factor of 6. When the image does not have a box-shadow applied, the image shows at its native resolution of 300x300 when zoomed in. When the image has a box-shadow applied, the image shows at a pixellated 50x50 but bitmap scaled up, along with a pixellated box shadow. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 00:42:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 00:42:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28148] Requests through the SOUP layer leaks memory In-Reply-To: References: Message-ID: <20090812074246.BA2E134BAD8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28148 --- Comment #2 from John Kjellberg 2009-08-12 00:42:46 PDT --- As an additional note. Revision 41128 did not have this specific leak(but it did have the https://bugs.webkit.org/show_bug.cgi?id=26716 leak). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 01:00:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 01:00:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28146] Allow Inspector's Number.toString to print low-resolution values In-Reply-To: References: Message-ID: <20090812080025.7305834BAF8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28146 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |pfeldman at chromium.org Resolution| |FIXED --- Comment #4 from Pavel Feldman 2009-08-12 01:00:24 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/utilities.js Committed r47095 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 01:01:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 01:01:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090812080123.8669A34BAFA3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 --- Comment #5 from Simon Hausmann 2009-08-12 01:01:22 PDT --- I agree that this change a test, even an autotest would be sufficient. But more generally speaking I admit I don't like this solution: shortcutOverrideEvent is not a substitute for handling key events. Handling it means accepting or rejecting the event, but not processing the actual keys. That belongs into keyPressEvent. But with this patch it is just a matter of time until someone complains that their application shortcuts are overridden by web pages, and that's harder to control and we have to tell them to re-implement shortcutOverrideEvent? I would prefer to see Arora handle its shortcuts in a re-implementation of keyPressEvents. Another option might be to make QWebPage's behaviour of overriding all shortcuts configurable. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 01:55:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 01:55:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28076] fast/images/icon-decoding.html needs results for Qt In-Reply-To: References: Message-ID: <20090812085559.35FA434BB4FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28076 --- Comment #4 from Andras Becsi 2009-08-12 01:55:58 PDT --- Here is a patch for qt which corrects the layout test, but the imlementation should be changed higher up in QIcon and QPixmap. This is only an expected behaviour change, which is more compilant to the ICO file format description (http://www.daubnet.com/en/file-format-ico) which says: "For general purpose ICOs there should be at least one 32x32 image using the 16 Windows colors." diff --git a/src/plugins/imageformats/ico/qicohandler.cpp b/src/plugins/imageformats/ico/qicohandler.cpp index c9e04a4..77c68b7 100644 --- a/src/plugins/imageformats/ico/qicohandler.cpp +++ b/src/plugins/imageformats/ico/qicohandler.cpp @@ -802,7 +802,25 @@ bool QtIcoHandler::canRead(QIODevice *device) bool QtIcoHandler::read(QImage *image) { bool bSuccess = false; - QImage img = m_pICOReader->iconAt(m_currentIconIndex); + + QIODevice *d = device(); + + QList imgs = m_pICOReader->read(d); + QImage img = imgs[m_currentIconIndex]; + QSize requestedSize(32,32); + + if ( imgs.size() > 1 ){ + + // if we have multiple icons in the file we return the first with 32x32 resolution because it is the reference size + // FIXME: there should be a proper way of handling all the files in an ICO file higher up in the abstraction + // ie. to fill the caller QIcon with the icons in the ICO file automatically, and let the user decide which to use + for ( int i=0; i References: Message-ID: <20090812090022.74E8034BB597@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28174 Mikhail Naganov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34552|0 |1 is obsolete| | Attachment #34644| |review? Flag| | --- Comment #3 from Mikhail Naganov 2009-08-12 02:00:21 PDT --- Created an attachment (id=34644) --> (https://bugs.webkit.org/attachment.cgi?id=34644) Updated patch---comments addressed -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:02:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:02:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812090203.94F6C34BB5C7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34545|review- | Flag| | Attachment #34545|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:02:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:02:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812090209.B7B6D34BB5DE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34645| |review? Flag| | --- Comment #6 from Fumitoshi Ukai 2009-08-12 02:02:07 PDT --- Created an attachment (id=34645) --> (https://bugs.webkit.org/attachment.cgi?id=34645) Add SocketStreamHandle interface --- 13 files changed, 748 insertions(+), 1 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:03:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:03:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812090337.1C98534BB60A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 --- Comment #7 from Fumitoshi Ukai 2009-08-12 02:03:35 PDT --- Thanks for review. I believe I fixed all comments. Could you take a look again, please? Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:09:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:09:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812090940.24AFB34BB6B0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34645|review? | Flag| | Attachment #34645|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:09:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:09:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812090946.24CF534BB6C9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34646| |review? Flag| | --- Comment #8 from Fumitoshi Ukai 2009-08-12 02:09:44 PDT --- Created an attachment (id=34646) --> (https://bugs.webkit.org/attachment.cgi?id=34646) Add SocketStreamHandle interface --- 13 files changed, 748 insertions(+), 1 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:29:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:29:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812092909.0987D34BB890@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 --- Comment #2 from Hin-Chung Lam 2009-08-12 02:29:08 PDT --- Created an attachment (id=34647) --> (https://bugs.webkit.org/attachment.cgi?id=34647) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:29:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:29:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812092937.2D93934BB8A2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Hin-Chung Lam changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34647| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:33:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:33:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812093316.6D65334BB8F8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Hin-Chung Lam changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hclam at google.com --- Comment #3 from Hin-Chung Lam 2009-08-12 02:33:15 PDT --- The cause of the regression is that r46915 rejects non mouse actions and mouse actions not from left button. This logic caused trouble because it discards a lot of mouse move events during drag. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:35:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:35:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090812093534.22A4D34BB92C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 --- Comment #3 from Fumitoshi Ukai 2009-08-12 02:35:33 PDT --- (In reply to comment #2) > (From update of attachment 34548 [details]) > + $(WebCore)/websockets \ > $(WebCore)/svg \ > $(WebCore)/websockets \ > > It's already there. > > + WebCore/websockets/WebSocketRequest.cpp \ > + WebCore/websockets/WebSocketRequest.h \ > + WebCore/websockets/WebSocketResponse.cpp \ > + WebCore/websockets/WebSocketResponse.h > > This looks quite wrong - WebSocket does not use a request/response model, so > such class names are highly misguiding. Hmm, how about WebSocketClientHandshake and WebSocketServerHandshake? What name do you recommend? > > +#if ENABLE(WEB_SOCKETS) > +#include "JSWebSocket.h" > +#include "WebSocket.h" > > In some places, generated files are included without guards, and in others, > with guards. The guards are only needed if the headers are not generated in > ports that do not have this feature enabled - otherwise, similar guards within > headers themselves would do the job. > > There's never a need to protect e.g. WebSocket.h with external include guards. > > +bool IsValidProtocolString(const WebCore::String& protocol) > > This should be static, and inside the WebCore namespace. We don't normally use > anonymous namespaces. > > + // FIXME: need dispatchEvent? > > Absolutely - it will dispatch to handlers installed via addEventListener(), as > opposed to setting socket.onopen or similar. Should I add the implementation in this patch, or ok in another patch? > > +bool CheckWebSocketHandshake(const WebCore::WebSocketRequest &req, const > WebCore::WebSocketResponse& resp) > > Capitalization, argument naming, '&' positioning. This should also be static. > > There are many style issues in protocol implementation, I'm not pointing out > most, because they are the same as in other patches. > > + // FIXME: handle overflow. > > Please do! What is the good way to handle overflow? May I close the connection if too long length is detected? Do we need to set maximum length of m_buffer? (512KB or so?) > > +KURL WebSocketRequest::URLoverHTTP() const > > In WebKit style, this would be urlOverHTTP. I'm not sure what this is use for > though, hopefully an even better name can be found. > > + if (url().hasFragmentIdentifier()) { > + builder.append("#"); > + builder.append(url().fragmentIdentifier()); > + } > > What are fragment identifiers good for when using WebSockets? Seems that they > should be forbidden, or dropped immediately when passed in. Sure. > +const char* WebSocketResponse::parseHeader(const char* start, const char* end, > Vector >* headers) > > Are WebSockets headers case sensitive? Otherwise, it may be better to use > HTTPHeaderMap. Thanks for suggestion. > > I didn't closely review all the code; please fix style, possibly using > check-webkit-style script. The direction looks good to me, except for > request/response classes. I used check-webkit-style script, but it didn't catch some style issues. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:36:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:36:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090812093614.2865A34BB957@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Charles Wei changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34648| |review?(zimmermann at kde.org) Flag| | --- Comment #29 from Charles Wei 2009-08-12 02:36:11 PDT --- Created an attachment (id=34648) --> (https://bugs.webkit.org/attachment.cgi?id=34648) resubmit the patch to address comments This patch differes from the patch submitted on Aug 8 , 2009 is that : For the changes for RenderMarquee, it only applys when the WCSS and XHTMLMP are enabled, and the document is of XHTMLMP type, no impacts to the HTML documents. For the other comment from Niko to have a .css file to replace the hard-coded codes that initializes the marquee status with : *[display="-wap-marquee"] {overflow=...} Actually this doesn't work. The above universal selector works for something like display as an attribute like: There's no such an attribute for HTML/xHTML tags, actually the WCSS marquee is an extension to WCSS display and it works like this : So the universal selector *[display="-wap-marquee"] {...} doesn't work. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:38:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:38:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] New: [v8] Fix atomic string externalization crash Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28215 Summary: [v8] Fix atomic string externalization crash Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: christian.plesner.hansen at gmail.com Atomic string externalization assumes that all non-empty strings can be externalized which is untrue on 64-bit. This change fixed that. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 02:39:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 02:39:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812093956.4103E34BB9D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 Christian Plesner Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34649| |review? Flag| | --- Comment #1 from Christian Plesner Hansen 2009-08-12 02:39:55 PDT --- Created an attachment (id=34649) --> (https://bugs.webkit.org/attachment.cgi?id=34649) "Initial" -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 03:27:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 03:27:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28216] New: [CAIRO] getImageData fails on a given rect bigger than the image rect Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28216 Summary: [CAIRO] getImageData fails on a given rect bigger than the image rect Product: WebKit Version: 525.x (Safari 3.1) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: krit at webkit.org Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34650| |review? Flag| | Created an attachment (id=34650) --> (https://bugs.webkit.org/attachment.cgi?id=34650) Cairo fix of getImageData [CAIRO] getImageData fails on a given rect bigger than the image rect. I found this bug during my work on SVG feGaussianBlur. Currently only canvas could test it, but we don't allow the it there to make a bigger rect then the image rect. The problem is, that the destination image and source image were mixed up on creating the imageData. This patch just follows to the behavior of the other ports. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 03:33:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 03:33:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812103358.5E89234BBEE2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 --- Comment #5 from Dirk Schulze 2009-08-12 03:33:57 PDT --- landed in r47099. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 03:52:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 03:52:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812105251.6307634BC0CA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34651| |review? Flag| | --- Comment #6 from Dirk Schulze 2009-08-12 03:52:49 PDT --- Created an attachment (id=34651) --> (https://bugs.webkit.org/attachment.cgi?id=34651) premultiplied color support for Skia This is a untested suggestion for Skia. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 03:53:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 03:53:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812105328.B016A34BC0FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34365|review+ | Flag| | --- Comment #7 from Dirk Schulze 2009-08-12 03:53:27 PDT --- (From update of attachment 34365) clearing review flag. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:13:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:13:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28186] Web Inspector scope bar not quite right In-Reply-To: References: Message-ID: <20090812111347.7E74934BC30B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28186 Anthony Ricaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rik at webkit.org, | |webkit at mattlilek.com --- Comment #1 from Anthony Ricaud 2009-08-12 04:13:46 PDT --- I tried to find some resources to get it right but can't find them. I ended up using a demo that Matt Lillek gave me. No problem for tweaking the color, I just don't know the exact colors. If you have any pointer, I'll be glad to update that. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:14:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:14:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812111454.AE16734BC34F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 Christian Plesner Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34649|review? | Flag| | Attachment #34649|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:17:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:17:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812111754.13A1734BC4F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 Christian Plesner Hansen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34652| |review? Flag| | --- Comment #2 from Christian Plesner Hansen 2009-08-12 04:15:00 PDT --- Created an attachment (id=34652) --> (https://bugs.webkit.org/attachment.cgi?id=34652) Tabs-fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:43:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:43:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812114316.5F7A134BC905@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33895|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:43:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:43:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812114353.A425D34BC923@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33941|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:47:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:47:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812114753.26CF434BC990@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34653| |review? Flag| | --- Comment #35 from Jakub Wieczorek 2009-08-12 04:47:50 PDT --- Created an attachment (id=34653) --> (https://bugs.webkit.org/attachment.cgi?id=34653) Remove the private classes from QWebPluginDatabase. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:49:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:49:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812114944.D058634BC9DD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34654| |review? Flag| | --- Comment #36 from Jakub Wieczorek 2009-08-12 04:49:43 PDT --- Created an attachment (id=34654) --> (https://bugs.webkit.org/attachment.cgi?id=34654) Optimize the QWebPluginInfo::supportsMimeType() function. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:51:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:51:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812115100.448A134BCA18@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34655| |review? Flag| | --- Comment #37 from Jakub Wieczorek 2009-08-12 04:50:59 PDT --- Created an attachment (id=34655) --> (https://bugs.webkit.org/attachment.cgi?id=34655) Optimize the QWebPluginInfo::mimeTypes() function. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:53:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:53:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API In-Reply-To: References: Message-ID: <20090812115345.099A934BCA86@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27651 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34656| |review? Flag| | --- Comment #38 from Jakub Wieczorek 2009-08-12 04:53:44 PDT --- Created an attachment (id=34656) --> (https://bugs.webkit.org/attachment.cgi?id=34656) Move the PluginDatabase::setPluginDirectories() function definition out of the header. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 04:54:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 04:54:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090812115449.85E1B34BCAA6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 Antonio Gomes (tonikitoo) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tonikitoo at gmail.com --- Comment #6 from Antonio Gomes (tonikitoo) 2009-08-12 04:54:48 PDT --- if i understood this bug correctly, I the path mozilla is taking to support this kind of situation: in bug https://bugzilla.mozilla.org/show_bug.cgi?id=448602 they implementing a way to verify if there is a default key listener for a given key (in this case control+s), but application could verify that before setting their own, avoiding conflicts in a safe way. we could consider implementing something similar in webkit ... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 05:01:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 05:01:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23291] -webkit-box-shadow doesn't work on Qt-WebKit In-Reply-To: References: Message-ID: <20090812120141.DA17A34BCB73@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23291 Ariya Hidayat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34521|0 |1 is obsolete| | Attachment #34657| |review? Flag| | Status|UNCONFIRMED |NEW AssignedTo|webkit-unassigned at lists.web |ariya.hidayat at trolltech.com |kit.org | Ever Confirmed|0 |1 --- Comment #9 from Ariya Hidayat 2009-08-12 05:01:39 PDT --- Created an attachment (id=34657) --> (https://bugs.webkit.org/attachment.cgi?id=34657) Improved patch that also updates LayoutTest -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 05:44:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 05:44:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812124455.B376634BCFF3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34577|review+ | Flag| | --- Comment #9 from Adam Treat 2009-08-12 05:44:54 PDT --- (From update of attachment 34577) Clear flags as this has landed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:03:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:03:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812130338.1CF0134BD214@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34400|review? |review- Flag| | --- Comment #90 from Adam Treat 2009-08-12 06:03:32 PDT --- (From update of attachment 34400) ImageSource is no longer a forked file for each port. Rather, all ports that are use the built-in image decoders are moving to a cross-platform ImageSource.cpp file. Please refactor to use this new file and (only if necessary) add #if/#else for any behavior changes need by WINCE port for this file. See: https://bugs.webkit.org/show_bug.cgi?id=27965 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:13:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:13:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090812131356.5EAFE34BD391@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Nikolas Zimmermann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34648|review?(zimmermann at kde.org) |review+ Flag| | --- Comment #30 from Nikolas Zimmermann 2009-08-12 06:13:54 PDT --- (From update of attachment 34648) Hi Charles, patch looks great, along with your comments (regarding the impossiblity to not-hardcode the stuff.) One last question: > Index: WebCore/css/WCSSValueKeywords.in > =================================================================== > --- WebCore/css/WCSSValueKeywords.in (revision 0) > +++ WebCore/css/WCSSValueKeywords.in (revision 0) > @@ -0,0 +1 @@ > +# place holder for all WCSS specific CSS value keywords Do we need this file? I suspect you _may_ need it for the build process? If not, please remove this file completly, and reupload a patch, then I'll set "commit-queue +" as well. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:28:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:28:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. In-Reply-To: References: Message-ID: <20090812132816.8DBEE34BD5AB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28181 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hausmann at webkit.org, | |laszlo.1.gombos at nokia.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:32:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:32:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28208] Typo in FastMalloc.h causes build to fail In-Reply-To: References: Message-ID: <20090812133225.77D4134BD641@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28208 Thomas Fletcher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #2 from Thomas Fletcher 2009-08-12 06:32:24 PDT --- Sorry ... IE dropped the patch off for some reason. Looks like it is an irrelevant issue now though since it has been changed already in rev 47000. Sorry for the noise. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:39:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:39:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27051] Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled In-Reply-To: References: Message-ID: <20090812133907.821C634BD6EB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27051 Norbert Leser changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32410| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:57:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:57:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812135753.58B3234BD940@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 --- Comment #2 from Adam Treat 2009-08-12 06:57:52 PDT --- (From update of attachment 34598) > +Path& Path::operator=(const Path& other) > +{ > + m_path = new PlatformPath(*other.m_path); > + return *this; > +} Delete the possibly existing m_path unless &other == this? > +bool Path::hasCurrentPoint() const > +{ > + return !isEmpty(); > +} I see this is duplicated by most other ports, but not all. Perhaps it should be refactored and implemented in Path.cpp? Maybe after this goes in? About PathWince.cpp in general... I'm curious why you don't just implement methods here rather than breaking it out into another class: PlatformPathWince. Any reason or just following other ports example of having a 'native' PlatformPath type... Not a biggy, but one extra level of indirection that might not be necessary. > +// Implemented in GraphicsContextWince.cpp > +void getEllipsePointByAngle(double angle, double a, double b, float& x, float& y); > + ... > +static inline int stableRound(double d) > +{ > + if (d > 0) > + return static_cast(d + 0.5); > + > + int i = static_cast(d); > + return i - d > 0.5 ? i - 1 : i; > +} This is also implemented in GraphicsContextWince.cpp. Any reason this is duplicated here? I think this should probably be shared rather than copy&paste... > +static bool containsPoint(const FloatRect& r, const FloatPoint& p) > +{ > + return p.x() >= r.x() && p.y() >= r.y() && p.x() < r.right() && p.y() < r.bottom(); > +} This should be added to FloatRect. > +#define PI 3.14159265358979323846 This is a part of MathExtras.h. Please use that instead of duplicating. > +static void normalizeAngle(float& angle) > +{ > + while (angle < 0) > + angle += 2 * PI; > + while (angle >= 2 * PI) > + angle -= 2 * PI; > + if (angle < 0.00001) > + angle = 0; > +} This is used by addEllipse, but I'm not sure I understand. If the angles given are invalid, then why not just return or fix the calling site? > +// return 0-based value: 0 - first Quadrant ( 0 - 90 degree) > +static inline int quadrant(const PathPoint& point, const PathPoint& origPoint) > +{ > + return point.m_x < origPoint.m_x ? > + (point.m_y < origPoint.m_y ? 2 : 1) > + : (point.m_y < origPoint.m_y ? 3 : 0); > +} Heh, origin, originPoint, originalPoint? I think all three are better than 'origPoint' depending on context :) > +static void drawPolygons(HDC dc, const Vector& polygons, bool fill, const TransformationMatrix* tr) tr should be matrix or transform. Keep the variable names well named. > + MemoryAllocationCanFail canFail; Will this compile? > +void PlatformPathElement::inflateRectToContainMe(FloatRect& r, const FloatPoint& lastPoint) const Cute :) > +PlatformPath::PlatformPath() > +: m_penLifted(true) Indentation. > + // FIXME: magic number? > + quadCurve(50, m_subpaths.last(), control); What does this mean? > +} > + > + Extra space. > +#ifndef PlatformPathWince_h > +#define PlatformPathWince_h No includes? How does this work? Only forward declaration is GraphicsContext, but you are using lots more WebCore classes... General thoughts: There are some style issues and minor nitpicks, but not very many. I'm not concerned about them as much as I'd like the questions above figured out. I would also like to know if you've run this code with the relevant LayoutTests and what the results were. You mention in the ChangeLog that this could become cross-platform code for ports which do not have any native version of this functionality. That is possible, but only if the code is refactored and probably broken out into one class per file as well as aggressive layout tests confirm. Finally, the diff looks corrupted: see top of patch file. r- mostly for the above questions. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 06:58:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 06:58:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812135835.8A67434BD972@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34598|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:03:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:03:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28148] Requests through the SOUP layer leaks memory In-Reply-To: References: Message-ID: <20090812140358.6292034BDA50@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28148 Priit Laes (IRC: plaes) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amd at store20.com --- Comment #3 from Priit Laes (IRC: plaes) 2009-08-12 07:03:57 PDT --- (In reply to comment #0) > Created an attachment (id=34451) --> (https://bugs.webkit.org/attachment.cgi?id=34451) [details] > Code making one XMLHttpRequest every 0.1s > > The attached test case makes one XMLHttpRequest() call each 0.1s. As times goes > by it uses more and more memory. This will most likely also affect any type of > HTTP request made. > > I have found a code change that will stop the leak. However, that isn't really > a solution, but it might be a hint to someone that knows the code better. I > based the change on how it worked in earlier revisions of the code that didn't > have this leak. > (Why the "m_isWebSecurityEnabled" change is needed I have no idea. Only found > it by a lucky coincident) Hmm.. this is actually causing crash when closing the page after a few requests... :S -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:12:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:12:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28148] Requests through the SOUP layer leaks memory In-Reply-To: References: Message-ID: <20090812141237.7E19434BDB58@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28148 --- Comment #4 from John Kjellberg 2009-08-12 07:12:37 PDT --- (In reply to comment #3) > (In reply to comment #0) > > Created an attachment (id=34451) --> (https://bugs.webkit.org/attachment.cgi?id=34451) [details] [details] > > Code making one XMLHttpRequest every 0.1s > > > > The attached test case makes one XMLHttpRequest() call each 0.1s. As times goes > > by it uses more and more memory. This will most likely also affect any type of > > HTTP request made. > > > > I have found a code change that will stop the leak. However, that isn't really > > a solution, but it might be a hint to someone that knows the code better. I > > based the change on how it worked in earlier revisions of the code that didn't > > have this leak. > > (Why the "m_isWebSecurityEnabled" change is needed I have no idea. Only found > > it by a lucky coincident) > > Hmm.. this is actually causing crash when closing the page after a few > requests... :S That's interesting. I have been running it for quite long time and then closed the whole GtkLauncher window without any indication of a crash. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:14:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:14:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28210] Document relation between major objects in WebCore In-Reply-To: References: Message-ID: <20090812141411.64E6534BDBA2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28210 --- Comment #5 from Adam Barth 2009-08-12 07:14:10 PDT --- (In reply to comment #4) > This diagram shows DOMWindow between Frame and Document. But it's not really > like that. Ok. I'll see what I can do to fix that. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:16:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:16:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28204] Not possible to build WebCore+V8 with -fno-exceptions on Mac In-Reply-To: References: Message-ID: <20090812141647.A122934BDC0C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28204 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abarth at webkit.org AssignedTo|mark at chromium.org |webkit-unassigned at lists.web | |kit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:25:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:25:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26409] [GTK] Glitches in new progress/load-status system In-Reply-To: References: Message-ID: <20090812142533.5062A34BDD49@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26409 Benjamin Otte changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |otte at gnome.org --- Comment #9 from Benjamin Otte 2009-08-12 07:25:32 PDT --- (In reply to comment #0) > - A weird 10% progress is reported for pages before the status even reaches > PROVISIONAL. Not sure where this comes from, but it should either go away or > come after PROVISIONAL or COMMITTED I think. > This is wanted behavior. See WebCore/loader/ProgressTracker.cpp. The current implementation clamps progress values to always be inside [0.1, 0.9] during an active load, so that you can actually see that something is happening. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:30:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:30:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812143046.A709834BDDD7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 --- Comment #3 from Yong Li 2009-08-12 07:30:45 PDT --- (In reply to comment #2) > (From update of attachment 34598 [details]) > > +Path& Path::operator=(const Path& other) > > +{ > > + m_path = new PlatformPath(*other.m_path); > > + return *this; > > +} > > Delete the possibly existing m_path unless &other == this? > I think you've found a bug here. Thanks! :) > > +bool Path::hasCurrentPoint() const > > +{ > > + return !isEmpty(); > > +} > > I see this is duplicated by most other ports, but not all. Perhaps it should > be refactored and implemented in Path.cpp? Maybe after this goes in? No. There's at least one port that does differently. That's why this method was introduced. And I'm not sure !isEmpty() is absolutely correct. There have been some discussions on this thing. I forgot the bug number. At the meantime, I just do this as most ports do, because I haven't got a better idea. Keeping an eye on other ports... :) > > About PathWince.cpp in general... I'm curious why you don't just implement > methods here rather than breaking it out into another class: PlatformPathWince. > Any reason or just following other ports example of having a 'native' > PlatformPath type... Not a biggy, but one extra level of indirection that > might not be necessary. I could do that. But then I would have to add a lot of members into Path.h with #if PLATFORM(WINCE), which may be harder to get r+ :) > > > +// Implemented in GraphicsContextWince.cpp > > +void getEllipsePointByAngle(double angle, double a, double b, float& x, float& y); > > + > ... > > +static inline int stableRound(double d) > > +{ > > + if (d > 0) > > + return static_cast(d + 0.5); > > + > > + int i = static_cast(d); > > + return i - d > 0.5 ? i - 1 : i; > > +} > > This is also implemented in GraphicsContextWince.cpp. Any reason this is > duplicated here? I think this should probably be shared rather than > copy&paste... Yeah... This stableRound is defined in many files. Not sure if it's a good idea to add it into MathExtra.h. The differences between stableRound() and lround() is: 1) stableRound() rounds -0.5 to 0, where lround() round -0.5 to -1. Consider the case that the transformation has a shift -1, and 0.5 changes to -0.5. With lround, the rounded value 1 changes to -1, so that the rounded shift is -2. Probably the name should be changed to lowerRound() or leftRound(). 2) stableRound() doesn't call other function like ceil() where lround() does Can we do this later? Because some landed file like GraphicsContextWince.cpp needs to be changed, too. This patch just contains new source files, and doesn't include the changes to any existing file. > > > +static bool containsPoint(const FloatRect& r, const FloatPoint& p) > > +{ > > + return p.x() >= r.x() && p.y() >= r.y() && p.x() < r.right() && p.y() < r.bottom(); > > +} > > This should be added to FloatRect. Agree with this. but can we do this later? > > > +#define PI 3.14159265358979323846 > > This is a part of MathExtras.h. Please use that instead of duplicating. Agree. > > > +static void normalizeAngle(float& angle) > > +{ > > + while (angle < 0) > > + angle += 2 * PI; > > + while (angle >= 2 * PI) > > + angle -= 2 * PI; > > + if (angle < 0.00001) > > + angle = 0; > > +} > > This is used by addEllipse, but I'm not sure I understand. If the angles given > are invalid, then why not just return or fix the calling site? Don't know if an angle bigger than 2*PI is valid or invalid. I think it should still be handled. > > + > > Extra space. > > > +#ifndef PlatformPathWince_h > > +#define PlatformPathWince_h > > No includes? How does this work? Only forward declaration is GraphicsContext, > but you are using lots more WebCore classes... > Yeah, I'll add some header files like FloatPoint.h -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:33:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:33:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812143354.26F2734BDE45@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 --- Comment #18 from steveblock at google.com 2009-08-12 07:33:52 PDT --- > This is missing new results and cannot be landed by the commit-queue. The patch includes expected results for GTK at LayoutTests/platform/gtk/fast/dom/Geolocation/enabled-expected.txt. Perhaps I misinterpreted your earlier comment ... > It's the individual platforms responsibility to manage their skipped lists and > turn on/off tests accordingly. > > I thikn it's also OK to have a "is geolocation enabled" test, expect enabled, > and check in "PASS" results on the platforms which have it, and skip it on all > other platforms. Did you mean that it's the platform's responsibility for all platforms other than mac? Should I add a 'fail' result for mac or add this test to the mac skipped list? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 07:51:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 07:51:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090812145142.21DEC34BE087@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 --- Comment #16 from Laszlo Gombos 2009-08-12 07:51:40 PDT --- (In reply to comment #15) > (From update of attachment 34538 [details]) > > + // Set HTML5 Application Cache default location > > + QWebSettings::setOfflineWebApplicationCachePath(defaultCachePath()); > I think we want to append /ApplicationCache or so. > Simon, how do we hide the deprecated methods from the docs? Kenneth, I'd like to keep this patch focused on LocalStorage. I would prefer to create a separate patch for the HTML5 Application Cache changes (which I plan to do). My proposal for deprecating follows Qt conventions I belive (see for example http://qt.gitorious.org/+qt-s60-developers/qt/qt-s60/blobs/master/src/gui/dialogs/qfiledialog.h ) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:08:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:08:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28179] Shortcuts on webpages don't work if the Qt application has the same shortcut In-Reply-To: References: Message-ID: <20090812150833.AD64D34BE2B6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28179 --- Comment #7 from Benjamin Meyer 2009-08-12 08:08:32 PDT --- Some more notes from looking things up: The documentation for ShortcutOverride is very slim and I am not exactly sure how it is suppose to be used, when it is called, or if this is even the Qt way to handle this bug. Looking through Qt's source it looked like when a widget overrides a global shortcut (like many do such as QLineEdit, QComboBox etc) they should handle this event saying that they should eat the keyevent and not allow a shortcut to. Is this correct? If we could know that there is a listener for a key without having to actually pass a key event then we could accept the event on ShortcutOverride without having to send the key event. This seems like the correct approach to solving this. Tested Safari and it behaves as expected; ctrl+s doesn't do Save As, but passes it to the DOM and GoogleDocs so there might be some code in WebKit already to handle this. Simon, you mentioned that Arora could handle its shortcuts in a re-implementation of keyPressEvents. To do this were you thinking to overload ShortcutOverrideEvent, always accept the event and then in the KeyPressEvent if the key isn't accepted walk up the parent tree find all QShortcut children, and test their QKeySequence if it matches call that shortcut and return? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:20:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:20:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812152046.85E7D34BF16F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Kenneth Rohde Christiansen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |kenneth.christiansen at openbo | |ssa.org Resolution|FIXED | --- Comment #3 from Kenneth Rohde Christiansen 2009-08-12 08:20:45 PDT --- Hi there, You commit https://trac.webkit.org/changeset/47089 JavaScriptCore: Restrict use of FuncDeclNode & FuncExprNode to the parser. https://bugs.webkit.org/show_bug.cgi?id=28209 seems to break the fast/js tests for Qt 64bit linux. The tests breaking are: fast/js/const.html expected fast/js/exception-thrown-from-function-with-lazy-activation.html fast/js/function-call-register-allocation.html fast/js/function-dot-arguments-and-caller.html fast/js/named-function-expression.html fast/js/static-scope-object.html plugins/netscape-invoke-default.html Cheers, Kenneth -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:37:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:37:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812153739.08A1A34C0300@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34647|review? |review- Flag| | --- Comment #4 from Simon Fraser (smfr) 2009-08-12 08:37:37 PDT --- (From update of attachment 34647) Patch looks reasonable but you can make a testcase; in DumpRenderTree, there is an eventSender API that you can use to synthesize mouse events. I think it's important to add a testcase so that this doesn't regress again. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:38:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:38:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812153832.202C734C0342@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34612|review? |review- Flag| | --- Comment #20 from Dimitri Glazkov (Google) 2009-08-12 08:38:28 PDT --- (From update of attachment 34612) >From the style patrol: Needs a ChangeLog entry. > +void RenderThemeChromiumMac::updateActiveState(NSCell* cell, const RenderObject* o) { Opening brace on new line. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:40:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:40:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28214] -webkit-box-shadow forces image to display at low resolution In-Reply-To: References: Message-ID: <20090812154053.0419234C038D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28214 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |simon.fraser at apple.com |kit.org | --- Comment #1 from Simon Fraser (smfr) 2009-08-12 08:40:52 PDT --- Any box decoration on the image seems to cause this (e.g. border). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:44:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:44:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812154425.42D4034C0418@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34598|0 |1 is obsolete| | Attachment #34662| |review? Flag| | --- Comment #4 from Yong Li 2009-08-12 08:44:24 PDT --- Created an attachment (id=34662) --> (https://bugs.webkit.org/attachment.cgi?id=34662) refactored modified according to Adam's suggestions. stableRound() is separated out to WinceGraphicsExtras.h Afterward, we'll let other files that define stableRound() by themself use this header file. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:44:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:44:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28126] [Haiku] Adding SharedTimer to WebCore. In-Reply-To: References: Message-ID: <20090812154426.E4AC734C0427@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28126 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34412|0 |1 is obsolete| | Attachment #34663| |review? Flag| | --- Comment #5 from Maxime Simon 2009-08-12 08:44:25 PDT --- Created an attachment (id=34663) --> (https://bugs.webkit.org/attachment.cgi?id=34663) Patch to add the SharedTimer file for Haiku. I still used a BMessageFilter, but as static variable. We now use the generic SharedTimer. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:46:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:46:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090812154638.78A0E34C046D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 --- Comment #6 from Dave Hyatt 2009-08-12 08:46:37 PDT --- (From update of attachment 34618) You are sure that other types of replaced elements aren't going to crash without a parent null check somewhere? I'd recommend browsing in a zoomed window for a bit to make sure. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:48:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:48:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812154813.F187D34C04AD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34652|review? |review+ Flag| | --- Comment #3 from Dimitri Glazkov (Google) 2009-08-12 08:48:13 PDT --- (From update of attachment 34652) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:48:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:48:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812154858.A18EE34C04E0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Viet-Trung Luu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34612|0 |1 is obsolete| | Attachment #34664| |review? Flag| | --- Comment #21 from Viet-Trung Luu 2009-08-12 08:48:55 PDT --- Created an attachment (id=34664) --> (https://bugs.webkit.org/attachment.cgi?id=34664) Changelog entry back, style fix. Ack! -- the directory from which you run svn-create-patch actually matters. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:50:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:50:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812155029.48F4B34C0535@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Viet-Trung Luu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34664|review? |review?(dglazkov at chromium.o Flag| |rg) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:53:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:53:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812155348.F3A6D34C05E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34662|review? |review+ Flag| | --- Comment #5 from Adam Treat 2009-08-12 08:53:48 PDT --- (From update of attachment 34662) Ok, please file a bug and patch for moving 'containsPoint' into FloatRect after this lands. Thanks! Otherwise, LGTM. r+ :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:54:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:54:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812155409.198B534C0604@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |dglazkov at chromium.org Resolution| |FIXED --- Comment #4 from Dimitri Glazkov (Google) 2009-08-12 08:54:08 PDT --- Landed as http://trac.webkit.org/changeset/47106. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:57:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:57:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090812155724.EF81D34C064A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 --- Comment #7 from George Wright 2009-08-12 08:57:24 PDT --- (In reply to comment #6) > (From update of attachment 34618 [details]) > You are sure that other types of replaced elements aren't going to crash > without a parent null check somewhere? I'd recommend browsing in a zoomed > window for a bit to make sure. Seems fine here. I tested it with images and media (from http://webkit.org/blog/140/html5-media-support/) and it didn't crash when zoomed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 08:59:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 08:59:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812155907.58FD434C06C2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34664|review?(dglazkov at chromium.o |review+ Flag|rg) | --- Comment #22 from Dimitri Glazkov (Google) 2009-08-12 08:59:01 PDT --- (From update of attachment 34664) r=me, based on Mac-ies' comments above. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:01:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:01:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812160114.413A934C0746@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 --- Comment #23 from Dimitri Glazkov (Google) 2009-08-12 09:01:10 PDT --- (From update of attachment 34664) r=me, based on Mac-ies' comments above. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:01:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:01:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28108] Tint of checkboxes/radio buttons/etc. not correctly updated on Chromium/Mac In-Reply-To: References: Message-ID: <20090812160137.4B3EB34C0770@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28108 Dimitri Glazkov (Google) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #24 from Dimitri Glazkov (Google) 2009-08-12 09:01:34 PDT --- Landed as http://trac.webkit.org/changeset/47108. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:07:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:07:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14997] Support for server-sent DOM events In-Reply-To: References: Message-ID: <20090812160710.2279734C0837@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14997 Adam Bergkvist changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34139|0 |1 is obsolete| | Attachment #34665| |review? Flag| | --- Comment #33 from Adam Bergkvist 2009-08-12 09:07:03 PDT --- Created an attachment (id=34665) --> (https://bugs.webkit.org/attachment.cgi?id=34665) updated patch Thank you for the quick review and sorry for not noticing the recent addition of the DOMConstructorObject class. Here is an updated patch that also adds EventSource to the mac and win builds (untested). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:08:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:08:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812160845.CF48134C0871@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 --- Comment #19 from Eric Seidel 2009-08-12 09:08:44 PDT --- The commit-queue runs from a mac. Should these results be the same for all platforms? If so, then they should be placed right next to the original test and platforms which want to check in platform-specific failing results can do so. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:11:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:11:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] REGRESSION: run-webkit-tests --quiet hangs In-Reply-To: References: Message-ID: <20090812161145.5F1E434C08E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|run-webkit-tests --quiet |REGRESSION: |hangs |run-webkit-tests --quiet | |hangs --- Comment #3 from Eric Seidel 2009-08-12 09:11:44 PDT --- I'm going to check this in w/o review to fix the regression that --quiet now hangs. (Alternatively I could roll out my other patch which caused it to hang.) If anyone has suggestions as to how I should improve this code, I'm happy to change it further. This code is specifically trying to avoid turning the args array back into a string. Perl doesn't seem to have an elegant way to deal with an args array *and* route stderr to /dev/null. Another way I could handle this would be to override the parent's stdout/stderr before running the normal "system" call. But that's also pretty nasty (although slightly less code). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:15:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:15:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812161552.6AC2334C0941@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 --- Comment #20 from steveblock at google.com 2009-08-12 09:15:51 PDT --- > The commit-queue runs from a mac. Should these results be the same for all > platforms? The 'pass' results should be the same for all platforms that support Geolocation. Currently, this is only GTK. On platforms that don't support Geolocation (which includes mac), all tests will fail. Should I add 'failed' results to LayoutTests/fast/dom/ and 'pass' results to LayoutTests/platform/gtk/fast/dom/Geolocation/? Or should I add the 'pass' results to LayoutTests/fast/dom/ and add 'failed' results to LayoutTests/platform/mac/fast/dom/Geolocation/ to keep the build happy? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:17:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:17:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] REGRESSION: run-webkit-tests --quiet hangs In-Reply-To: References: Message-ID: <20090812161729.4F44E34C0975@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Eric Seidel 2009-08-12 09:17:28 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests Committed r47109 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests r47109 = 86eae88a818613b99c22db8d9631abf4c36eca43 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47109 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:17:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:17:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28202] REGRESSION: run-webkit-tests --quiet hangs In-Reply-To: References: Message-ID: <20090812161737.3DF7034C09A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28202 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34614|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:18:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:18:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812161837.45B7234C09C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 --- Comment #21 from Eric Seidel 2009-08-12 09:18:36 PDT --- The failure case seems uninteresting. I would checkin the results next to the tests, and edit the skipped lists of all platforms you expect to fail. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:19:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:19:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812161932.94ED534C09FA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34662|0 |1 is obsolete| | Attachment #34666| |review? Flag| | --- Comment #6 from Yong Li 2009-08-12 09:19:31 PDT --- Created an attachment (id=34666) --> (https://bugs.webkit.org/attachment.cgi?id=34666) fix a bug in last patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:22:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:22:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] bugzilla-tool : various improvements for running the commit-queue In-Reply-To: References: Message-ID: <20090812162216.29DFD34C0AC2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28199 --- Comment #4 from Eric Seidel 2009-08-12 09:22:15 PDT --- Thanks. FIxed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:26:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:26:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28199] bugzilla-tool : various improvements for running the commit-queue In-Reply-To: References: Message-ID: <20090812162627.BDC9D34C0B6C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28199 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Eric Seidel 2009-08-12 09:26:26 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/bugzilla.py M WebKitTools/Scripts/modules/scm.py Committed r47111 M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py M WebKitTools/Scripts/modules/scm.py M WebKitTools/Scripts/bugzilla-tool r47111 = 431ef60608c95da88d3bc13bae5b7663484f029f (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47111 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:29:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:29:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812162915.3B0DE34C0BD2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34602|review? |review- Flag| | --- Comment #49 from George Staikos 2009-08-12 09:29:13 PDT --- (From update of attachment 34602) I think standard for your for(;;) is really to do: do { } while (0); Best to change to that and then your comment isn't necessary. Also you have a double semicolon in your first if (). Those minor fixes and the rest is fine with me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:33:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:33:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812163342.5EF1634C0C66@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #50 from Darin Adler 2009-08-12 09:33:40 PDT --- (In reply to comment #49) > I think standard for your for(;;) is really to do: > > do { > } while (0); for(;;) is an infinite loop. The above is not an infinite loop, it's a one time loop, so it can't be used. For infinite loops, the most common pattern in WebKit is while (true). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:34:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:34:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090812163451.0060634C0C8C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #4 from Alexey Proskuryakov 2009-08-12 09:34:49 PDT --- > Hmm, how about WebSocketClientHandshake and WebSocketServerHandshake? > What name do you recommend? That's less misleading. I was thinking of having a single class to handle handshake, not a pair of classes, but I didn't fully think it through, so it may be a bad idea. > > + // FIXME: need dispatchEvent? > > Should I add the implementation in this patch, or ok in another patch? I think it would be easiest to do it now, while this incomplete code is clearly visible in a patch - hunting it down in trunk will be more difficult. Please also make a test for addEventListener-installed listeners (as usual, to be landed once the code becomes functional). > What is the good way to handle overflow? > May I close the connection if too long length is detected? Sounds good to me. We probably want to log something to console in this case (and in other error cases that can occur in WebSocket lifetime). > Do we need to set maximum length of m_buffer? (512KB or so?) It would probably be nice to use tryFastMalloc (to close the connection instead of crashing if the server sends too large frame). If we were to add an artificial limit on received frame size, I think that it should be impractically huge, dozens of megabytes on desktop platforms - all we want is to prevent crashing the browser with an incorrect frame size, right? This doesn't seem like something that could happen during normal operation, it's just a protection from server bugs, and it makes DoS'ing the browser via WebSocket protocol more difficult. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:35:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:35:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28148] Requests through the SOUP layer leaks memory In-Reply-To: References: Message-ID: <20090812163529.A24ED34C0CC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28148 --- Comment #5 from Priit Laes (IRC: plaes) 2009-08-12 09:35:28 PDT --- This happens in epiphany when I have at least two tabs open. 1) open the example code in another tab ie. by clicking the middle button. 2) close the tab 3) Wait for crash PS. And sorry for hijacking your bug report ;) Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7f561a467760 (LWP 13232)] 0x00007f5618735d99 in WebCore::FrameLoader::loadResourceSynchronously (this=0x7f560115b850, request=, storedCredentials=WebCore::AllowStoredCredentials, error=@0x7fff47a2f930, response=@0x7fff47a2f870, data=@0x7fff47a2f960) at WebCore/loader/FrameLoader.cpp:3728 3728 documentLoader()->applicationCacheHost()->maybeLoadFallbackSynchronously(newRequest, error, response, data); (gdb) bt #0 0x00007f5618735d99 in WebCore::FrameLoader::loadResourceSynchronously (this=0x7f560115b850, request=, storedCredentials=WebCore::AllowStoredCredentials, error=@0x7fff47a2f930, response=@0x7fff47a2f870, data=@0x7fff47a2f960) at WebCore/loader/FrameLoader.cpp:3728 #1 0x00007f5618719890 in WebCore::DocumentThreadableLoader::loadResourceSynchronously (document=0x7f560110f800, request=@0x7fff47a2f9f0, client=@0x7f5601087d90, storedCredentials=WebCore::AllowStoredCredentials) at WebCore/loader/DocumentThreadableLoader.cpp:55 #2 0x00007f56188d19ea in WebCore::XMLHttpRequest::loadRequestSynchronously (this=0x7f5601087d80, request=@0x7fff47a2f9f0, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:663 #3 0x00007f56188d4e1d in WebCore::XMLHttpRequest::makeSameOriginRequest (this=0x7f5601087d80, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:510 #4 0x00007f56188d7c33 in WebCore::XMLHttpRequest::send (this=0x7f5601087d80, body=@0x7fff47a2fbb0, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:446 #5 0x00007f56188d7e0b in WebCore::XMLHttpRequest::send (this=0x7f560cfc2e60, ec=@0x0) at WebCore/xml/XMLHttpRequest.cpp:389 #6 0x00007f56184fbda6 in WebCore::JSXMLHttpRequest::send (this=0x7f5600ec7600, exec=0x7f56012900a0, args=@0x7fff47a2f930) at WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:125 #7 0x00007f5618bab0d2 in WebCore::jsXMLHttpRequestPrototypeFunctionSend (exec=0x7f56012900a0, thisValue={m_ptr = 0x7f5600ec7600}, args=@0x7fff47a2fc80) at DerivedSources/JSXMLHttpRequest.cpp:373 #8 0x00007f561a5a21d4 in ?? () #9 0x00007f5601290058 in ?? () #10 0x0000000000000001 in ?? () #11 0x000000000188fac4 in ?? () #12 0x00007f5600ec9cc0 in ?? () #13 0x00007f560107cb20 in ?? () #14 0x0000000000000000 in ?? () (gdb) bt full #0 0x00007f5618735d99 in WebCore::FrameLoader::loadResourceSynchronously (this=0x7f560115b850, request=, storedCredentials=WebCore::AllowStoredCredentials, error=@0x7fff47a2f930, response=@0x7fff47a2f870, data=@0x7fff47a2f960) at WebCore/loader/FrameLoader.cpp:3728 referrer = {m_impl = { = {}, m_ptr = 0x7f56010fdea0}} initialRequest = { = {m_url = {m_string = {m_impl = { = {}, m_ptr = 0x7f5600f37380}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 36, m_queryEnd = 36, m_fragmentEnd = 36}, m_cachePolicy = WebCore::UseProtocolCachePolicy, m_timeoutInterval = 10, m_firstPartyForCookies = {m_string = {m_impl = { = {}, m_ptr = 0x7f5601206a28}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 38, m_queryEnd = 47, m_fragmentEnd = 47}, m_httpMethod = {m_impl = { = {}, m_ptr = 0x7f5602740000}}, m_httpHeaderFields = {, WTF::HashTraits >> = { = {}, m_impl = {static m_minTableSize = 64, static m_maxLoad = , static m_minLoad = 6, m_table = 0x7f56010c4400, m_tableSize = 64, m_tableSizeMask = 63, m_keyCount = 2, m_deletedCount = 0}}, }, m_responseContentDispositionEncodingFallbackArray = { = {}, m_size = 0, m_buffer = {> = { = { = {}, }, m_buffer = 0x7f560112c320, m_capacity = 0}, }}, m_httpBody = { = {}, m_ptr = 0x0}, m_allowHTTPCookies = true, m_resourceRequestUpdated = true, m_platformRequestUpdated = false, m_reportUploadProgress = false}, } identifier = 11 newRequest = { = {m_url = {m_string = {m_impl = { = {}, m_ptr = 0x7f5600f37380}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 36, m_queryEnd = 36, m_fragmentEnd = 36}, m_cachePolicy = WebCore::UseProtocolCachePolicy, m_timeoutInterval = 10, m_firstPartyForCookies = {m_string = {m_impl = { = {}, m_ptr = 0x7f5601206a28}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 38, m_queryEnd = 47, m_fragmentEnd = 47}, m_httpMethod = {m_impl = { = {}, m_ptr = 0x7f5602740000}}, m_httpHeaderFields = {, WTF::HashTraits >> = { = {}, m_impl = {static m_minTableSize = 64, static m_maxLoad = , static m_minLoad = 6, m_table = 0x7f56011c6800, m_tableSize = 64, m_tableSizeMask = 63, m_keyCount = 2, m_deletedCount = 0}}, }, m_responseContentDispositionEncodingFallbackArray = { = {}, m_size = 0, m_buffer = {> = { = { = {}, }, m_buffer = 0x7f560112c1c8, m_capacity = 0}, }}, m_httpBody = { = {}, m_ptr = 0x0}, m_allowHTTPCookies = true, m_resourceRequestUpdated = true, m_platformRequestUpdated = false, m_reportUploadProgress = false}, } #1 0x00007f5618719890 in WebCore::DocumentThreadableLoader::loadResourceSynchronously (document=0x7f560110f800, request=@0x7fff47a2f9f0, client=@0x7f5601087d90, storedCredentials=WebCore::AllowStoredCredentials) at WebCore/loader/DocumentThreadableLoader.cpp:55 sameOriginRequest = true data = { = {}, m_size = 210, m_buffer = {> = { = { = {}, }, m_buffer = 0x7f56010f3460 "\n\n404 Not Found\n\n

    Not Found

    \n

    The requested URL /mem_test.htm was not found on this server.

    \n}} error = { = {m_domain = {m_impl = { = {}, m_ptr = 0x0}}, m_errorCode = 0, m_failingURL = { m_impl = { = {}, m_ptr = 0x0}}, m_localizedDescription = {m_impl = { = {}, m_ptr = 0x0}}, m_isNull = true, m_isCancellation = false}, } response = { = {m_url = {m_string = {m_impl = { = {}, m_ptr = 0x7f5600f37460}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 36, m_queryEnd = 36, m_fragmentEnd = 36}, m_mimeType = {m_impl = { = {}, m_ptr = 0x7f5601249cc0}}, m_expectedContentLength = 210, m_textEncodingName = {m_impl = { = {}, m_ptr = 0x7f5601250580}}, m_suggestedFilename = {m_impl = { = {}, m_ptr = 0x0}}, m_httpStatusCode = 404, m_httpStatusText = {m_impl = { = {}, m_ptr = 0x7f5601249c80}}, m_httpHeaderFields = {, WTF::HashTraits >> = { = {}, m_impl = {static m_minTableSize = 64, static m_maxLoad = , static m_minLoad = 6, m_table = 0x7f56010a9400, m_tableSize = 64, m_tableSizeMask = 63, m_keyCount = 6, m_deletedCount = 0}}, }, m_lastModifiedDate = 0, m_isNull = false, m_haveParsedCacheControlHeader = false, m_haveParsedAgeHeader = false, m_haveParsedDateHeader = false, m_haveParsedExpiresHeader = false, m_haveParsedLastModifiedHeader = false, m_cacheControlContainsNoCache = false, m_cacheControlContainsNoStore = false, m_cacheControlContainsMustRevalidate = false, m_cacheControlMaxAge = 0, m_age = 0, m_date = 0, m_expires = 0, m_lastModified = 0}, } identifier = 18446744073709551615 #2 0x00007f56188d19ea in WebCore::XMLHttpRequest::loadRequestSynchronously (this=0x7f5601087d80, request=@0x7fff47a2f9f0, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:663 No locals. #3 0x00007f56188d4e1d in WebCore::XMLHttpRequest::makeSameOriginRequest (this=0x7f5601087d80, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:510 request = { = {m_url = {m_string = {m_impl = { = {}, m_ptr = 0x7f5600f37380}}, m_isValid = true, m_protocolInHTTPFamily = true, m_schemeEnd = 5, m_userStart = 8, m_userEnd = 8, m_passwordEnd = 8, m_hostEnd = 23, m_portEnd = 23, m_pathAfterLastSlash = 24, m_pathEnd = 36, m_queryEnd = 36, m_fragmentEnd = 36}, m_cachePolicy = WebCore::UseProtocolCachePolicy, m_timeoutInterval = 2147483647, m_firstPartyForCookies = {m_string = {m_impl = { = {}, m_ptr = 0x0}}, m_isValid = false, m_protocolInHTTPFamily = false, m_schemeEnd = 0, m_userStart = 0, m_userEnd = 0, m_passwordEnd = 0, m_hostEnd = 0, m_portEnd = 0, m_pathAfterLastSlash = 0, m_pathEnd = 0, m_queryEnd = 0, m_fragmentEnd = 0}, m_httpMethod = {m_impl = { = {}, m_ptr = 0x7f5602740000}}, m_httpHeaderFields = {, WTF::HashTraits >> = { = {}, m_impl = {static m_minTableSize = 64, static m_maxLoad = , static m_minLoad = 6, m_table = 0x0, m_tableSize = 0, m_tableSizeMask = 0, m_keyCount = 0, m_deletedCount = 0}}, }, m_responseContentDispositionEncodingFallbackArray = { = {}, m_size = 0, m_buffer = {> = { = { = {}, }, m_buffer = 0x0, m_capacity = 0}, }}, m_httpBody = { = {}, m_ptr = 0x0}, m_allowHTTPCookies = true, m_resourceRequestUpdated = true, m_platformRequestUpdated = false, m_reportUploadProgress = false}, } #4 0x00007f56188d7c33 in WebCore::XMLHttpRequest::send (this=0x7f5601087d80, body=@0x7fff47a2fbb0, ec=@0x7fff47a2fc2c) at WebCore/xml/XMLHttpRequest.cpp:446 No locals. #5 0x00007f56188d7e0b in WebCore::XMLHttpRequest::send (this=0x7f560cfc2e60, ec=@0x0) at WebCore/xml/XMLHttpRequest.cpp:389 No locals. #6 0x00007f56184fbda6 in WebCore::JSXMLHttpRequest::send (this=0x7f5600ec7600, exec=0x7f56012900a0, args=@0x7fff47a2f930) at WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:125 ec = 0 signedLineNumber = sourceID = 140734395251744 sourceURL = {m_rep = { = {}, m_ptr = 0x7f5600f6baa0}, static nullUString = 0x7f56027330f8} function = {m_ptr = 0x7f560113d7e0} #7 0x00007f5618bab0d2 in WebCore::jsXMLHttpRequestPrototypeFunctionSend (exec=0x7f56012900a0, thisValue={m_ptr = 0x7f5600ec7600}, args=@0x7fff47a2fc80) at DerivedSources/JSXMLHttpRequest.cpp:373 No locals. #8 0x00007f561a5a21d4 in ?? () -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:36:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:36:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812163645.1ED3534C0CE8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brettw at chromium.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:40:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:40:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812164003.7E8D434C0D48@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34555|commit-queue+ |commit-queue- Flag| | --- Comment #10 from Eric Seidel 2009-08-12 09:40:02 PDT --- (From update of attachment 34555) Rejecting patch 34555 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:41:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:41:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812164110.7676834C0D79@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #11 from Eric Seidel 2009-08-12 09:41:09 PDT --- ChangeLog diff is malformed. bugzilla-tool/svn-apply don't know how to fix it, hence the commit-queue rejected it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28175] HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit In-Reply-To: References: Message-ID: <20090812164205.F321F34C0DBB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28175 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34553|review+, commit-queue+ | Flag| | --- Comment #3 from Eric Seidel 2009-08-12 09:42:05 PDT --- (From update of attachment 34553) Clearing flags on attachment: 34553 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/qt/FileSystemQt.cpp Committed r47114 M WebCore/ChangeLog M WebCore/platform/qt/FileSystemQt.cpp r47114 = 7f2ff9356922227e477417a6efb09c9d854e485e (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47114 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28175] HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit In-Reply-To: References: Message-ID: <20090812164209.06AF434C0DCB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28175 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #4 from Eric Seidel 2009-08-12 09:42:08 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812164213.E2CAD34C0DE3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 --- Comment #51 from Yong Li 2009-08-12 09:42:12 PDT --- I like for (;;) so much personally :), but seems not allowed in webkit? Probably I'd better change it back to goto. Another way to avoid goto is if (...) { if (...) { ... // free resources } // free resources } I also like this way, but I'm afraid that someone will say there're too many indentations. I also planed to create wrapper classes for HCRYPTKEY and HCRYPTPROV that release resource automatically, but probably it's a waste for this single usage. Sadly, OwnPtr<> doesn't work in this case because HCRYPTKEY and HCRYPTPROV are just "void*". I considered a lot about this. I'm going to use goto, which makes everyone understand -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] WINCE PORT: implement MediaPlayerProxy In-Reply-To: References: Message-ID: <20090812164251.E0B8934C0E13@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28178 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34569|review+, commit-queue+ | Flag| | --- Comment #2 from Eric Seidel 2009-08-12 09:42:51 PDT --- (From update of attachment 34569) Clearing flags on attachment: 34569 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/graphics/wince/MediaPlayerPrivateWince.h A WebCore/platform/graphics/wince/MediaPlayerProxy.cpp A WebCore/platform/graphics/wince/MediaPlayerProxy.h Committed r47115 M WebCore/ChangeLog A WebCore/platform/graphics/wince/MediaPlayerProxy.cpp A WebCore/platform/graphics/wince/MediaPlayerPrivateWince.h A WebCore/platform/graphics/wince/MediaPlayerProxy.h r47115 = cad9e667af33d4301c670e5813e15a31752f9f45 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47115 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28178] WINCE PORT: implement MediaPlayerProxy In-Reply-To: References: Message-ID: <20090812164255.9EB7534C0E29@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28178 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-12 09:42:54 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:42:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:42:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812164257.8035434C0E3F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Bug 27511 depends on bug 28178, which changed state. Bug 28178 Summary: WINCE PORT: implement MediaPlayerProxy https://bugs.webkit.org/show_bug.cgi?id=28178 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:43:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:43:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090812164335.035C634C0E67@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34597|review+, commit-queue+ | Flag| | --- Comment #4 from Eric Seidel 2009-08-12 09:43:34 PDT --- (From update of attachment 34597) Clearing flags on attachment: 34597 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/StylesSidebarPane.js Committed r47116 M WebCore/ChangeLog M WebCore/inspector/front-end/StylesSidebarPane.js r47116 = 339ebebf103c8020a3164de2578c2171389b539a (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47116 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:43:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:43:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28187] "Double-click to add" new style button does not always show up In-Reply-To: References: Message-ID: <20090812164338.C7D7134C0E7F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28187 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #5 from Eric Seidel 2009-08-12 09:43:37 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:44:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:44:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19131] Can't remove a breakpoint In-Reply-To: References: Message-ID: <20090812164416.24EC034C0EC1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19131 --- Comment #2 from Patrick Mueller 2009-08-12 09:44:14 PDT --- The inability to delete breakpoints continues to bug me. At one point recently, one of my source files was just splattered with blue turds as I kept moving breakpoints around, reloading the file, etc. Here's a patch to change the enable/disable breakpoint click states to enable/disable/remove. ie, as you click on the line number in a source view, the breakpoint gets added, then disabled, then removed, then added, ... This seems fairly natural to me. Another option would be to only add/remove via the click, and allow enable/disable in the new breakpoints sidebar. Not clear whether removing breakpoints from the sidebar is required - I think I'd argue that if we want to add that, we may well want more function in the sidebar like "disable all/remove all", etc, and so should look at "remove a breakpoint from sidebar" as part of a larger design effort for that sidebar. I'm happy to kosher this up as a patch, if folks agree the current patch is useful. Index: WebCore/inspector/front-end/SourceFrame.js =================================================================== --- WebCore/inspector/front-end/SourceFrame.js (revision 47011) +++ WebCore/inspector/front-end/SourceFrame.js (working copy) @@ -289,8 +289,10 @@ return; var sourceRow = event.target.enclosingNodeOrSelfWithNodeName("tr"); - if (sourceRow._breakpointObject) - sourceRow._breakpointObject.enabled = !sourceRow._breakpointObject.enabled; + if (sourceRow._breakpointObject && sourceRow._breakpointObject.enabled) + sourceRow._breakpointObject.enabled = false; + else if (sourceRow._breakpointObject) + WebInspector.panels.scripts.removeBreakpoint(sourceRow._breakpointObject); else if (this.addBreakpointDelegate) this.addBreakpointDelegate(this.lineNumberForSourceRow(sourceRow)); }, -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:46:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:46:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812164612.5439A34C0F17@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34666|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:46:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:46:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812164655.8534034C0F45@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 --- Comment #91 from Peter Kasting 2009-08-12 09:46:52 PDT --- (In reply to comment #90) > ImageSource is no longer a forked file for each port. Rather, all ports that > are use the built-in image decoders are moving to a cross-platform > ImageSource.cpp file. Please refactor to use this new file and (only if > necessary) add #if/#else for any behavior changes need by WINCE port for this > file. See: https://bugs.webkit.org/show_bug.cgi?id=27965 And if behavior differences are needed, chat with me/Adam; maybe we can find a better way than #ifdefs (one or two virtual functions, or splitting ImageSource.cpp into a couple pieces, for example). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:47:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:47:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812164707.E348B34C0F6A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34555|0 |1 is obsolete| | Attachment #34667| |review? Flag| | --- Comment #12 from Mike Fenton 2009-08-12 09:47:06 PDT --- Created an attachment (id=34667) --> (https://bugs.webkit.org/attachment.cgi?id=34667) Replacement patch with proper ChangeLog Entry Here's a fixed patch with the changeLog entry complete. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:49:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:49:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812164927.1E77134C0FD7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #10 from Luke Smith 2009-08-12 09:49:26 PDT --- What was the test against FF? RegExp should return false to IsCallable. Safari and webkit have been incorrectly reporting typeof /a/ === 'function' for several versions. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:50:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:50:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28188] WINCE PORT: Path, PlatformPath In-Reply-To: References: Message-ID: <20090812165058.BC02234C1017@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28188 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #7 from Adam Treat 2009-08-12 09:50:58 PDT --- Landed with r47118. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:51:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:51:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812165100.4116834C1029@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Bug 27511 depends on bug 28188, which changed state. Bug 28188 Summary: WINCE PORT: Path, PlatformPath https://bugs.webkit.org/show_bug.cgi?id=28188 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 09:56:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 09:56:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24289] [Qt] lacks clipToImageBuffer() In-Reply-To: References: Message-ID: <20090812165656.A7EA734C1118@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24289 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ariya.hidayat at trolltech.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:01:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:01:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28076] fast/images/icon-decoding.html needs results for Qt In-Reply-To: References: Message-ID: <20090812170152.7A36134C119C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28076 --- Comment #5 from Peter Kasting 2009-08-12 10:01:51 PDT --- (In reply to comment #4) > Here is a patch for qt which corrects the layout test, but the imlementation > should be changed higher up in QIcon and QPixmap. This is only an expected > behaviour change, which is more compilant to the ICO file format description > (http://www.daubnet.com/en/file-format-ico) which says: > > "For general purpose ICOs there should be at least one 32x32 image using the 16 > Windows colors." That sentence is advisory, to note that if you only include smaller sizes, Windows has to scale them up, and they look bad. However, 32x32 is not a "reference" size, and the first such entry found is not necessarily the best. The layout test is testing that the decoder selects the icon entries in order of largest first, then highest bit depth first after that. This is similar to how Windows itself behaves, especially on newer versions like Vista and 7, where the "typical" icon size is significantly larger than 32x32. Note that for some applications (e.g. displaying favicons in a tab or session history list), you probably want to be able to select a 16x16 icon. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:18:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:18:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28216] [CAIRO] getImageData fails on a given rect bigger than the image rect In-Reply-To: References: Message-ID: <20090812171820.1DDB534C13E6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28216 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34650|review? |review- Flag| | --- Comment #1 from Eric Seidel 2009-08-12 10:18:19 PDT --- (From update of attachment 34650) Test case? Or at least an explanation of why one is impossible. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:18:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:18:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812171833.A17A134C13F8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #4 from Kenneth Rohde Christiansen 2009-08-12 10:18:32 PDT --- Here you have the diffs of the failing tests fast/js/const.html -PASS f() is f +FAIL f() should be function g() { g="FAIL"; return g; } (of type function). Was FAIL (of type string). fast/js/exception-thrown-from-function-with-lazy-activation.html -PASS: args[0] should be 1 and is. +FAIL: args[0] should be 1 but instead is undefined. fast/js/function-call-register-allocation.html -PASS: Recursion did not run out of stack space. +FAIL: Recursion threw an exception: ReferenceError: Can't find variable: f fast/js/function-dot-arguments-and-caller.html -PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS,PASS fast/js/named-function-expression.html -PASS var z = 10; var x = eval('(function Named(a,b){ return (!!Named) ? (a + b + z) : -999; })'); x(4,5) is 19 +FAIL var z = 10; var x = eval('(function Named(a,b){ return (!!Named) ? (a + b + z) : -999; })'); x(4,5) should -PASS var ctr = 3; var x = (function Named(a,b){ if(--ctr) return 2 * Named(a,b); else return a + b; }); x(5,6) is 44 +FAIL var ctr = 3; var x = (function Named(a,b){ if(--ctr) return 2 * Named(a,b); else return a + b; }); x(5,6) should be 44. Threw exception ReferenceError: Can't find variable: Named fast/js/static-scope-object.html -PASS namedFunctionExpression() is globalObject +FAIL namedFunctionExpression() should be the global object. Threw exception ReferenceError: Can't find variable: f plugins/netscape-invoke-default.html This tests that it's possible to call NPN_InvokeDefault on a JavaScript object. If this test succeeded, the text "SUCCESS" should be shown below. -SUCCESS +FAILURE -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:18:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:18:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28152] Implement -webkit-linear-gradient and -webkit-radial-gradient In-Reply-To: References: Message-ID: <20090812171838.1E9B934C1405@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28152 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34670| |review? Flag| | --- Comment #1 from Simon Fraser (smfr) 2009-08-12 10:18:37 PDT --- Created an attachment (id=34670) --> (https://bugs.webkit.org/attachment.cgi?id=34670) Patch, testcases, changelog This patch add support for parsing the new gradient types. It does not handle background-repeat, which I'll do separately. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:19:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:19:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812171911.6617A34C1437@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34640|review? |review+, commit-queue+ Flag| | --- Comment #3 from Eric Seidel 2009-08-12 10:19:11 PDT --- (From update of attachment 34640) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:20:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:20:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812172026.2B1D034C145F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34631|review? |review+, commit-queue+ Flag| | --- Comment #2 from Eric Seidel 2009-08-12 10:20:25 PDT --- (From update of attachment 34631) OK. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:22:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:22:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing In-Reply-To: References: Message-ID: <20090812172213.F1A6934C1499@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28133 --- Comment #10 from Eric Seidel 2009-08-12 10:22:12 PDT --- Why don't you need to call: 100 filterContext->clearRect(FloatRect(FloatPoint(), resultImage()->size())); before the first drawImage call? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:23:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:23:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28158] create-bug throws an exception if --cc is not specified In-Reply-To: References: Message-ID: <20090812172323.E4C3D34C14DF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28158 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Adam Roben (aroben) 2009-08-12 10:23:23 PDT --- Fixed in r47120 http://trac.webkit.org/changeset/47120 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:23:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:23:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28159] create-bug throws an exception in Cygwin In-Reply-To: References: Message-ID: <20090812172345.2E4D034C14ED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28159 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Adam Roben (aroben) 2009-08-12 10:23:44 PDT --- Fixed in r47121 http://trac.webkit.org/changeset/47121 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:24:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:24:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28190] Remove support for a window resizer within the WebView In-Reply-To: References: Message-ID: <20090812172418.9454934C14F9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28190 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Adam Roben (aroben) 2009-08-12 10:24:18 PDT --- Fixed in r47122 http://trac.webkit.org/changeset/47122 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:24:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:24:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812172425.9D89334C150F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org, | |pkasting at google.com --- Comment #6 from Eric Seidel 2009-08-12 10:24:24 PDT --- Peter is our Image* guy these days. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:24:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:24:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090812172443.AE6F234C1531@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34646|review? |review- Flag| | --- Comment #9 from Alexey Proskuryakov 2009-08-12 10:24:41 PDT --- (From update of attachment 34646) + No new tests. (OOPS!) Please don't say OOPS in ChangeLog - pre-commit script will block such a patch from landing. I think it would be better to say something positive anyway, like "tests will be landed once this code is complete and functional). WebCore/bindings/js/JSWebSocketCustom.cpp \ WebCore/websockets/WebSocket.cpp \ - WebCore/websockets/WebSocket.h + WebCore/websockets/WebSocket.h \ + WebCore/platform/network/SocketStreamErrorBase.cpp \ Looks like this list is supposed to be sorted. children = ( + 510D4A391031665F0049EA54 /* SocketStreamHandleMac.mm */, + 510D4A2D103165EE0049EA54 /* SocketStreamErrorBase.cpp */, + 510D4A2E103165EE0049EA54 /* SocketStreamErrorBase.h */, + 510D4A2F103165EE0049EA54 /* SocketStreamHandle.h */, + 510D4A30103165EE0049EA54 /* SocketStreamHandleBase.cpp */, + 510D4A31103165EE0049EA54 /* SocketStreamHandleBase.h */, + 510D4A32103165EE0049EA54 /* SocketStreamHandleClient.h */, B2F34FE70E82F81700F627CD /* cf */, 656B84E70AEA1DAE00A095B4 /* mac */, Shouldn't SocketStreamHandleMac be in mac folder? And sorry for not realizing this before, but I would actually prefer to have "cf" stubs for SocketStream, not mac ones. + * Copyright (C) 2009 Google Inc. All rights reserved. <...> + * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY + * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE I'm not sure what template is right for files originally added by Google, but "Apple Computer, Inc." is not even the correct name for Apple any more. You've previously used a different header in WebSocket.h. +const int maxBufferAmount = 524288; I've been thinking of a much larger buffer, something like 100MB (for desktop platforms at least). The idea is to prevent the browser from bringing the whole system to its knees too easily, not to close the connection as soon as it seems that data is sent too quickly. "Buffer amount" doesn't sound like proper English to me - should be either "buffer size" or "maximum buffered amount". + // FIXME: set error code? There is no error code in SocketStreamHandleBase, so I don't understand what this FIXME is about. Could you re-phrase the comment to make it clearer what the concern/bug is? Perhaps an error should just be logged to console via a client didFail () callback. + int bufferedAmount() const { return m_buffer.size(); } + + SocketStreamHandleClient* client() const; It's surprising that one is inline, and the other is not. Not really a problem but was there a reason for this difference? > diff --git a/WebCore/platform/network/SocketStreamHandle.h b/WebCore/platform/network/SocketStreamHandle.h Why is SocketStreamHandle.h in cross-platform directory? The model that e.g. ResourceRequest.h uses seems superior to me - cross-platform parts go into Base, and platforms have both headers and cpp files of their own. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:25:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:25:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812172553.267F134C1567@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34568|review? |review+, commit-queue+ Flag| | --- Comment #7 from Eric Seidel 2009-08-12 10:25:51 PDT --- (From update of attachment 34568) Looks OK. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:28:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:28:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812172815.C2CD634C15D3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34566|review? |review- Flag| | --- Comment #8 from Eric Seidel 2009-08-12 10:28:14 PDT --- (From update of attachment 34566) It seems this is not needed: Icon::Icon() 35 { 36 notImplemented(); 37 } Please remove it from both Icon.h and from Icon.cpp -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:29:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:29:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812172920.7EFB334C1603@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 --- Comment #5 from Hin-Chung Lam 2009-08-12 10:29:19 PDT --- OK, I'll provide a test case with fix shortly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:29:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:29:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28129] [Haiku] Adding three new files to WebCore/platform/haiku. In-Reply-To: References: Message-ID: <20090812172946.8893E34C1629@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28129 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34563|review? |review- Flag| | --- Comment #4 from Eric Seidel 2009-08-12 10:29:45 PDT --- (From update of attachment 34563) None of those virtual methods should be inline. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:30:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:30:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28204] Not possible to build WebCore+V8 with -fno-exceptions on Mac In-Reply-To: References: Message-ID: <20090812173021.7942334C1639@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28204 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34627|commit-queue+ |commit-queue- Flag| | --- Comment #5 from Eric Seidel 2009-08-12 10:30:20 PDT --- (From update of attachment 34627) Rejecting patch 34627 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:31:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:31:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812173105.E0CCB34C165F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #9 from Peter Kasting 2009-08-12 10:31:04 PDT --- (From update of attachment 34570) > diff --git a/WebCore/platform/graphics/haiku/ImageSourceHaiku.cpp b/WebCore/platform/graphics/haiku/ImageSourceHaiku.cpp > new file mode 100644 > index 0000000..ee2184c > --- /dev/null > +++ b/WebCore/platform/graphics/haiku/ImageSourceHaiku.cpp > @@ -0,0 +1,222 @@> +// FIXME: Should use the Haiku translator API. As of yesterday, there's a cross-platform ImageSource.cpp in platform/graphics. It looks at a glance like you could just build with this file (except for one item I note below) instead of adding an ImageSourceHaiku.cpp. > +ImageDecoder* createDecoder(const Vector& data) > +{ > + > + // JPEG > + // FIXME: Add JPEG support. You're using the cross-platform decoders for all other filetypes. Is there something wrong with the cross-platform JPEG decoder that prevents you from even instantiating it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:33:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:33:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28126] [Haiku] Adding SharedTimer to WebCore. In-Reply-To: References: Message-ID: <20090812173307.401DE34C16B5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28126 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34663|review? |review- Flag| | --- Comment #6 from Eric Seidel 2009-08-12 10:33:06 PDT --- (From update of attachment 34663) + bigtime_t interval = fireTime - currentTime(); + + if (interval < 0) + interval = 0; + else + interval *= 1000; Should be something like: bigtime_t millisecondInterval = fireTime - currentTime(); bigtime_t secondInterval = std::max(0, millisecondInterval * 1000); Important to make the variable names clear as to what they're holding. Otherwise looks fine. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:33:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:33:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19131] Can't remove a breakpoint In-Reply-To: References: Message-ID: <20090812173331.DCC5F34C16BF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19131 --- Comment #3 from Timothy Hatcher 2009-08-12 10:33:31 PDT --- Either option seems fine to me. The ideal design that hasn't been implemented yet, would be to allow dragging a breakpoint to move it and dragging out oif the gutter will "poof" it away, like Xcode. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:34:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:34:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22280] CG GIF decoder uses too much CPU In-Reply-To: References: Message-ID: <20090812173429.E641934C16E7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22280 Alexei Yudin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexei.yudin at gmail.com --- Comment #14 from Alexei Yudin 2009-08-12 10:34:27 PDT --- If nobody fixes this annoying bug, i swear I'm going to kill a bunch of innocent people, and Webkit developers will be the ones to blame! Seriously, it's rediculous how one tiny gif freezes the whole browser. It's 2009, goddamnit! Ask the folks from Firefox for fuck's sake, because their browser renders gifs perfectly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:34:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:34:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812173439.C801C34C1700@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 steveblock at google.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34402|0 |1 is obsolete| | Attachment #34671| |review? Flag| | --- Comment #22 from steveblock at google.com 2009-08-12 10:34:38 PDT --- Created an attachment (id=34671) --> (https://bugs.webkit.org/attachment.cgi?id=34671) Patch 5 for bug 27716 > The failure case seems uninteresting. I would checkin the results next to the > tests, and edit the skipped lists of all platforms you expect to fail. Done. I was confused by your earlier comments about maintenance of the skipped lists being the responsibility of the individual platforms. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:35:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:35:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090812173516.89D2F34C1737@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34564|review? |review+, commit-queue+ Flag| | --- Comment #6 from Eric Seidel 2009-08-12 10:35:15 PDT --- (From update of attachment 34564) I wouldn't have bothered to create this variable: 83 IntRect buttonRect(buttonOrigin, buttonSize); 84 85 return buttonRect; Looks fine though. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:37:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:37:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28122] [Haiku] Adding some simple graphic files (IntPoint, =?UTF-8?Q?=20IntRect=E2=80=A6?=) In-Reply-To: References: Message-ID: <20090812173739.D627E34C1791@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28122 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34426|review? |review+, commit-queue+ Flag| | --- Comment #10 from Eric Seidel 2009-08-12 10:37:38 PDT --- (From update of attachment 34426) OK. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:38:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:38:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28204] Not possible to build WebCore+V8 with -fno-exceptions on Mac In-Reply-To: References: Message-ID: <20090812173835.47D9C34C17BB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28204 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34627|commit-queue- |commit-queue+ Flag| | --- Comment #6 from Eric Seidel 2009-08-12 10:38:33 PDT --- (From update of attachment 34627) fast/layers/video-layer.html -> failed media/audio-delete-while-step-button-clicked.html -> failed media/video-controls-transformed.html -> failed media/video-controls-zoomed.html -> failed Test failures caused this regression. I don't think they were caused by this patch. Adding back to commit queue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:38:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:38:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing In-Reply-To: References: Message-ID: <20090812173835.C4BB134C17C1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28133 --- Comment #11 from Dirk Schulze 2009-08-12 10:38:33 PDT --- (In reply to comment #10) > Why don't you need to call: > 100 filterContext->clearRect(FloatRect(FloatPoint(), > resultImage()->size())); > > before the first drawImage call? a new ImageBuffer should always be transparent black.Or am I wrong? Not sure, but it's the transparent black for cg, cairo, qt. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:39:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:39:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28218] New: [Qt] Missing shadow support in Canvas Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28218 Summary: [Qt] Missing shadow support in Canvas Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ariya.hidayat at trolltech.com Ariya Hidayat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34673| |review? Flag| | Created an attachment (id=34673) --> (https://bugs.webkit.org/attachment.cgi?id=34673) Patch v1 Shadow does not work in HTML Canvas. This is for QtWebKit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:40:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:40:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28219] New: platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28219 Summary: platform/mac/accessibility/string-range-contains-listm arker.html fails on SnowLeopard Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cfleizach at apple.com on snow leopard AXLists are present, which change the AX hierarchy slightly -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:41:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:41:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing In-Reply-To: References: Message-ID: <20090812174130.396D934C1825@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28133 --- Comment #12 from Eric Seidel 2009-08-12 10:41:28 PDT --- I take it: GraphicsContext* filterContext = getEffectContext(); is known to create a new image buffer? That's not at all clear from the method naming. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:41:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:41:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28219] platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard In-Reply-To: References: Message-ID: <20090812174136.B8AEA34C1834@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28219 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34674| |review? Flag| | --- Comment #1 from chris fleizach 2009-08-12 10:41:36 PDT --- Created an attachment (id=34674) --> (https://bugs.webkit.org/attachment.cgi?id=34674) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:43:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:43:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27899] [Gtk] Expose a database API In-Reply-To: References: Message-ID: <20090812174336.4CEA634C1873@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27899 Martin Robinson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34544|0 |1 is obsolete| | --- Comment #3 from Martin Robinson 2009-08-12 10:43:35 PDT --- Created an attachment (id=34675) --> (https://bugs.webkit.org/attachment.cgi?id=34675) Updated patch Added an updated patch that: 1. Fixes some bugs 2. Exposes webkit_security_origin_get_database(...) 3. Integrates the database API into DumpRenderLayout, which causes all storage tests to pass now. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:44:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:44:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28218] [Qt] Missing shadow support in Canvas In-Reply-To: References: Message-ID: <20090812174456.B203B34C18AD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28218 Ariya Hidayat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34673|review? |review?(hausmann at webkit.org Flag| |) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:45:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:45:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28076] fast/images/icon-decoding.html needs results for Qt In-Reply-To: References: Message-ID: <20090812174558.EAE3934C18D5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28076 --- Comment #6 from Andras Becsi 2009-08-12 10:45:58 PDT --- > The layout test is testing that the decoder selects the icon entries in order > of largest first, then highest bit depth first after that. This is similar to > how Windows itself behaves, especially on newer versions like Vista and 7, > where the "typical" icon size is significantly larger than 32x32. > > Note that for some applications (e.g. displaying favicons in a tab or session > history list), you probably want to be able to select a 16x16 icon. Thank you very much for the information! I din't know which is the preferred order of selecting the icons, how ico exactly has to be handled. I will look into that and correct my patch. According to that the behaviour of the Qt infrastructure is totally wrong, because only the 1st element in the ico file is handed upward to create a QIcon or QPixmap or QImage, and no feature is considered. The only way to handle ICO files correctly is to use QImageLoader an specify how to select the icon. In my opinion at least QIcon sould automatically fill himself with all the icons contained in the ico file, and then select which to retunrt on QIcon::pixmap(...) calls, according to the features and the given arguments. Do you agree? WebKit converts the images to NativeImagePtr, which is QPixmap* in case of QtWebKit if I am not mistaken, so the information that it was an ico and had more entries is lost. I could write a patch to work around the test in QtWebKit, and to specifically handle ico files, but I think this is not a QtWebKit bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:46:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:46:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812174647.AA9AC34C18FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34671|review? |review+, commit-queue+ Flag| | --- Comment #23 from Eric Seidel 2009-08-12 10:46:46 PDT --- (From update of attachment 34671) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:47:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:47:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812174751.5F89934C191F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #5 from Gavin Barraclough 2009-08-12 10:47:50 PDT --- Gah, sorry, it looks like I've broken the interpreter, can repro on Mac with the JIT disabled. Will investigate, & will roll the change out if I can't fix this quickly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:51:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:51:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28219] platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard In-Reply-To: References: Message-ID: <20090812175152.E693D34C19A6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28219 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34674|review? |review+ Flag| | --- Comment #2 from Eric Seidel 2009-08-12 10:51:52 PDT --- (From update of attachment 34674) Looks OK. Technically style violation: + if (testObject.role == "AXRole: AXGroup") { + testObject = testObject.childAtIndex(1); + } + else if (testObject.role == "AXRole: AXListMarker") { -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:53:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:53:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28218] [Qt] Missing shadow support in Canvas In-Reply-To: References: Message-ID: <20090812175318.C308934C19D5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28218 --- Comment #1 from Eric Seidel 2009-08-12 10:53:18 PDT --- (From update of attachment 34673) What does CG have to do with anything? 66 if (m_common->state.shadowsIgnoreTransforms) { 867 // Meaning that this graphics context is associated with a CanvasRenderingContext 868 // We flip the height since CG and HTML5 Canvas have opposite Y axis 869 m_common->state.shadowSize = IntSize(size.width(), -size.height()); 870 } Do you mean GC/GraphicsContext? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:56:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:56:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28219] platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard In-Reply-To: References: Message-ID: <20090812175632.340FD34C1A3B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28219 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from chris fleizach 2009-08-12 10:56:31 PDT --- http://trac.webkit.org/changeset/47123 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:57:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:57:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27051] Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled In-Reply-To: References: Message-ID: <20090812175746.5952034C1A5D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27051 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ggaren at apple.com --- Comment #3 from Geoffrey Garen 2009-08-12 10:57:45 PDT --- (In reply to comment #1) > (From update of attachment 32410 [details]) > I'll have to check into whether this works - I don't remember whether there are > special alignment or lazy commit requirements. The code depends on lazy commit to avoid wasting memory, but not for correctness. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:57:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:57:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812175750.4C81E34C1A71@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 --- Comment #52 from George Staikos 2009-08-12 10:57:48 PDT --- (In reply to comment #50) > (In reply to comment #49) > > I think standard for your for(;;) is really to do: > > > > do { > > } while (0); > > for(;;) is an infinite loop. The above is not an infinite loop, it's a one time > loop, so it can't be used. For infinite loops, the most common pattern in > WebKit is while (true). You got confused in much the same way I was trying to point out. :-) It's -never- supposed to loop. That's what the comment says at the top. That's why it should change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 10:58:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 10:58:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28076] fast/images/icon-decoding.html needs results for Qt In-Reply-To: References: Message-ID: <20090812175819.C8FAE34C1A8D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28076 --- Comment #7 from Peter Kasting 2009-08-12 10:58:19 PDT --- (In reply to comment #6) > According to that the behaviour of the Qt infrastructure is totally wrong, > because only the 1st element in the ico file is handed upward to create a QIcon > or QPixmap or QImage, and no feature is considered. If you're only going to select one image, it should probably be the largest (and highest bit depth). > In my > opinion at least QIcon sould automatically fill himself with all the icons > contained in the ico file, and then select which to retunrt on > QIcon::pixmap(...) calls, according to the features and the given arguments. Do > you agree? I am not familiar with the Qt API, so I can't comment usefully. In the abstract, that sounds correct :) > WebKit converts the images to NativeImagePtr, which is QPixmap* in case of > QtWebKit if I am not mistaken, so the information that it was an ico and had > more entries is lost. Things are only converted to a NativeImagePtr at the time when a client requests a frame at a particular index. But an outside client can query ImageSource::frameCount() for the number of frames in an image, and then use ImageSource::frameSizeAtIndex() to determine which frame it wants before requesting the actual frame data. Making this work depends on having your ImageDecoder return the right values for these calls. If your icon decoder sorts the directory entries by size, and bit depth within size, with the highest quality image first, then callers who blindly grab the first frame will get the highest-quality icon (which is what this layout test is testing), and callers who want to pick an icon can use the functions described above. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:00:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:00:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28218] [Qt] Missing shadow support in Canvas In-Reply-To: References: Message-ID: <20090812180009.1774834C1AB7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28218 --- Comment #2 from Ariya Hidayat 2009-08-12 11:00:08 PDT --- CG as in CoreGraphics. Apparently shadow y offset is negative in CanvasRenderingContext2D, likely because it was targeted for CG first. The y-axis inversion can also be found in GraphicsContextSkia, hence why I think the next logical step is to refactor it (and leave out CG as the only one which inverses the axis). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:04:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:04:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812180426.D81AD34C1B4B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34535|review? |review- Flag| | --- Comment #21 from Eric Seidel 2009-08-12 11:04:21 PDT --- (From update of attachment 34535) For the future (this one being in pre-existing code), WebKit code tends to favor early returns instead of long if-blocks: 544545 if (m_document->databaseThread()) { Yes, our style is strange, but comments count as "lines" for multi-line if blocks and shoudl have { } (I used to get this confused myself): 87 if (pendingTransactions.isEmpty()) 88 // No more pending transactions; delete dbIdentifier's queue 89 m_pendingTransactions.remove(it); 90 else 91 // We have more pending transactions; start the next one 92 pendingTransactions.first()->lockAcquired(); No argument names when they don't add clarity: 46 void acquireLock(SQLTransaction* transaction); 47 void releaseLock(SQLTransaction* transaction); Why not add named functions for these: 34 // statement success callback 35 function(result) { log(dbName + " read statement succeeded"); }, 36 37 // statement failure callback 38 function(tx, error) { log(dbName + " read statement failed: " + error.message); }); Then you dont' have to declare them twice, nor do you need the extra lines of comments or spaces because the method names make it obvious what you're doing. function successCallback(testName) { return function(result) { log(dbName + " " + testName + " statement succeeded"); } successCallback("write") If you wanted, you coudl even make them more general and cover the other places you use success/error callbacks too. I'm ready to r+ this, but I think we should go one more round (since iirc you are not yet a committer). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:04:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:04:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812180452.AE75D34C1B6B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #10 from Maxime Simon 2009-08-12 11:04:51 PDT --- (In reply to comment #9) > > +ImageDecoder* createDecoder(const Vector& data) > > +{ > > + > > + // JPEG > > + // FIXME: Add JPEG support. > > You're using the cross-platform decoders for all other filetypes. Is there > something wrong with the cross-platform JPEG decoder that prevents you from > even instantiating it? Indeed, in the default Haiku distribution libjpeg isn't available. Of course we could add it as dependency, but the basic way to handle ImageDecoder in Haiku is to use BTranslators. And we intended to use it for all the other filetypes as well. I may have to discuss it with Ryan. Regards, Maxime -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:08:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:08:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28216] [CAIRO] getImageData fails on a given rect bigger than the image rect In-Reply-To: References: Message-ID: <20090812180802.7438634C1C12@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28216 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34650|0 |1 is obsolete| | Attachment #34677| |review? Flag| | --- Comment #2 from Dirk Schulze 2009-08-12 11:08:01 PDT --- Created an attachment (id=34677) --> (https://bugs.webkit.org/attachment.cgi?id=34677) Cairo fix of getImageData a better Changelog... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:10:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:10:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812181002.322B634C1C69@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pkasting at google.com --- Comment #8 from Eric Seidel 2009-08-12 11:09:59 PDT --- I think this would need a chromium person to try this locally. How would they test if this worked? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:13:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:13:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812181311.77CE634C1CEB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34602|0 |1 is obsolete| | Attachment #34678| |review? Flag| | --- Comment #53 from Yong Li 2009-08-12 11:13:09 PDT --- Created an attachment (id=34678) --> (https://bugs.webkit.org/attachment.cgi?id=34678) mixed a bug changed to do while(0). also fixed a bug that pPubInfo leaked in last patch, because it's defined twice. goto is not good because local object construction after goto doesn't compile. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:13:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:13:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812181331.D34C134C1D03@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|mixed a bug |7) KeygenWince.cpp mixed a description| |bug -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:13:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:13:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812181344.02EE334C1D19@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|application/octet-stream |text/plain mime type| | Attachment #34678|0 |1 is patch| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:14:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:14:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26402] Accessing attributes of an object created with "document.implementation.createDocumentType" causes NULL pointers In-Reply-To: References: Message-ID: <20090812181406.3C5C234C1D6F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26402 Olivier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viapanda at gmail.com --- Comment #4 from Olivier 2009-08-12 11:14:04 PDT --- If I understand well http://www.w3.org/TR/2000/REC-DOM-Level-2-Core-20001113/core.html there is only two cases where Node::document() would be null: * with a document * with a not yet attached documentType If the former, nothing you can access in javascript do crash. If the latter, the following will crash: * Node::childNodes (because of document()->addNodeListCache()) * Node::addEventListener (because of !document->attached()) * Node::removeEventListener And nothing else. Hope that helps... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:17:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:17:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26402] Accessing attributes of an object created with "document.implementation.createDocumentType" causes NULL pointers In-Reply-To: References: Message-ID: <20090812181714.3430234C1DC9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26402 --- Comment #5 from Eric Seidel 2009-08-12 11:17:12 PDT --- I feel like I've seen a dupe of this... possibly even worked on a dupe of this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:17:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:17:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812181720.E6BC934C1DE3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:20:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:20:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26402] Accessing attributes of an object created with "document.implementation.createDocumentType" causes NULL pointers In-Reply-To: References: Message-ID: <20090812182017.C00E234C1E53@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26402 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #6 from Alexey Proskuryakov 2009-08-12 11:20:16 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:21:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:21:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812182115.C76E534C1E91@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 --- Comment #9 from Dirk Schulze 2009-08-12 11:21:13 PDT --- (In reply to comment #8) > I think this would need a chromium person to try this locally. How would they > test if this worked? Hm... a posibility is to apply the last patch of https://bugs.webkit.org/show_bug.cgi?id=28133 replace getImageData with getPremultipliedImageData() and putImageData with putPremultipliedImageData(), build with --filter enabled and look at http://www.w3.org/Graphics/SVG/Test/20061213/htmlObjectHarness/full-filters-blend-01-b.html (ignore the first line, it's a bug in the filter implementation). Sorry, I know that this is a bit complex just for testing, but it was a preperation for SVG filters. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:21:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:21:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812182153.8D28834C1EA7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #11 from Peter Kasting 2009-08-12 11:21:52 PDT --- (In reply to comment #10) > (In reply to comment #9) > > > +ImageDecoder* createDecoder(const Vector& data) > > > +{ > > > + > > > + // JPEG > > > + // FIXME: Add JPEG support. > > > > You're using the cross-platform decoders for all other filetypes. Is there > > something wrong with the cross-platform JPEG decoder that prevents you from > > even instantiating it? > > Indeed, in the default Haiku distribution libjpeg isn't available. > Of course we could add it as dependency, but the basic way to handle > ImageDecoder in Haiku is to use BTranslators. And we intended to use it for all > the other filetypes as well. I may have to discuss it with Ryan. I see. Well, if you want to land the patch in the sort of state it's in now, we could either #if !PLATFORM(HAIKU) (or whatever the appropriate switch is) that block, or add some sort of ENABLE flag (which I am less in favor of). If you want to use a completely different mechanism (I have no idea what BTranslators are :D), we can design for that once you've got code that would work. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:22:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:22:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812182244.9A09F34C1ECB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 --- Comment #10 from Eric Seidel 2009-08-12 11:22:42 PDT --- (From update of attachment 34651) Seems this should be re-posted when it's easier to test. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:24:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:24:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812182401.F1AB934C1EFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 --- Comment #11 from Peter Kasting 2009-08-12 11:24:00 PDT --- Landed a build fix for Skia in r47126 (r47099 did not compile). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:27:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:27:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090812182746.06DEB34C1FDB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #11 from Oliver Hunt 2009-08-12 11:27:45 PDT --- (In reply to comment #10) > What was the test against FF? RegExp should return false to IsCallable. > Safari and webkit have been incorrectly reporting typeof /a/ === 'function' for > several versions. RegExps are callable -- eg. /b/("abc") -- the regex is callable, that means that the internal property IsCallable() must return true, which means that regexps should not be serialised. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:29:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:29:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812182925.57EF634C200F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|7) KeygenWince.cpp mixed a |7) KeygenWince.cpp fixed a description|bug |bug -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:31:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:31:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28221] New: REGRESSION (r47110): 4 media regressions on the bots Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28221 Summary: REGRESSION (r47110): 4 media regressions on the bots Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org Depends on: 28220 fast/layers/video-layer.html expected actual diff pretty diff media/audio-delete-while-step-button-clicked.html expected actual diff pretty diff media/video-controls-transformed.html expected actual diff pretty diff media/video-controls-zoomed.html expected actual diff pretty diff -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:33:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:33:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28221] REGRESSION (r47110): 4 media regressions on the bots In-Reply-To: References: Message-ID: <20090812183335.164D734C20C5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28221 --- Comment #1 from Eric Seidel 2009-08-12 11:33:33 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/mac/Skipped Committed r47128 M LayoutTests/platform/mac/Skipped M LayoutTests/ChangeLog r47128 = 69ff4fff8cccc3c23c73062c68b2d34b2a5cc384 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47128 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:35:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:35:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812183524.40A5A34C20F9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #12 from Ryan Leavengood 2009-08-12 11:35:22 PDT --- (In reply to comment #11) > > I see. Well, if you want to land the patch in the sort of state it's in now, > we could either #if !PLATFORM(HAIKU) (or whatever the appropriate switch is) > that block, or add some sort of ENABLE flag (which I am less in favor of). Maxime let's just revert to using their ImageDecoder for now, and we can try using translators later. > If you want to use a completely different mechanism (I have no idea what > BTranslators are :D), we can design for that once you've got code that would > work. Maybe you really don't care, but: Translators are a pretty interesting idea from BeOS (that has been copied in Haiku) which allow file formats to be converted to a common base format to facilitate all kinds of conversions. It is sort of like translating languages into a base language to translate between them (though it works a lot better for binary data than human languages.) The main use at the moment is for images, so that all the image translators can convert to and from a basic bitmap, which allows conversions from PNG to JPG, JPG to GIF, RAW to PNG, etc. It is a pretty cool idea and of course we want to make use of such nice Haiku-only technologies in our WebKit port to make it truly native. The end result of this should be that our WebKit port would be able to render any images we have a translator for, without having to modify or recompile WebKit itself. We can come back to this later when we have something better working. Your willingness to adapt WebKit to help us is very much appreciated! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:36:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:36:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing In-Reply-To: References: Message-ID: <20090812183631.4086E34C211B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28133 --- Comment #13 from Dirk Schulze 2009-08-12 11:36:29 PDT --- (In reply to comment #12) > I take it: > GraphicsContext* filterContext = getEffectContext(); > is known to create a new image buffer? That's not at all clear from the method > naming. hm, right. We can rename it to getEffectContextFromNewImageBuffer() in another patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:36:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:36:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28222] New: bugzilla-tool needs a way to ask build.webkit.org if the bots are passing Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28222 Summary: bugzilla-tool needs a way to ask build.webkit.org if the bots are passing Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org, levin at chromium.org bugzilla-tool needs a way to ask build.webkit.org if the bots are passing If they're not passing we should not run the --commit-queue, etc. I'd rather not scrape the buildbot page, but we could. I don't want to put too much extra load on the buildbot master. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:49:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:49:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28204] Not possible to build WebCore+V8 with -fno-exceptions on Mac In-Reply-To: References: Message-ID: <20090812184930.461D234C22DE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28204 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34627|commit-queue+ |commit-queue- Flag| | --- Comment #7 from Eric Seidel 2009-08-12 11:49:29 PDT --- (From update of attachment 34627) Rejecting patch 34627 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 11:54:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 11:54:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812185434.6F00434C23A4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #13 from Peter Kasting 2009-08-12 11:54:32 PDT --- (In reply to comment #12) > Translators are a pretty interesting idea from BeOS (that has been copied in > Haiku) which allow file formats to be converted to a common base format to > facilitate all kinds of conversions. It is sort of like translating languages > into a base language to translate between them (though it works a lot better > for binary data than human languages.) The main use at the moment is for > images, so that all the image translators can convert to and from a basic > bitmap, which allows conversions from PNG to JPG, JPG to GIF, RAW to PNG, etc. > > It is a pretty cool idea and of course we want to make use of such nice > Haiku-only technologies in our WebKit port to make it truly native. The end > result of this should be that our WebKit port would be able to render any > images we have a translator for, without having to modify or recompile WebKit > itself. Beware of the potential cost of that, if fitting it into WebCore involves e.g. copying an image's data, or doing more than one conversion. Decoding images has to be really, really fast in a web browser :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:01:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:01:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812190110.C547A34C2483@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:04:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:04:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812190420.C0E2C34C24F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34383|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:06:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:06:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28204] Not possible to build WebCore+V8 with -fno-exceptions on Mac In-Reply-To: References: Message-ID: <20090812190603.0B56634C252D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28204 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #8 from Eric Seidel 2009-08-12 12:06:00 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/WebCorePrefix.h Committed r47131 M WebCore/ChangeLog M WebCore/WebCorePrefix.h r47131 = e75e0df501e7cf6f156c0582d8339c21f55de469 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47131 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:07:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:07:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23817] [QT] Canvas clipping issues In-Reply-To: References: Message-ID: <20090812190716.C588B34C256F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23817 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george.wright at torchmobile.c | |om --- Comment #1 from George Wright 2009-08-12 12:07:15 PDT --- This appears to be a bug in Qt's X11 rendering backend. The problem shows up when using the X11 rendering backend, but not when using Qt's internal raster rendering backend. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:08:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:08:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812190822.33FC434C25AD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34386|review? |review+, commit-queue+ Flag| | --- Comment #54 from George Staikos 2009-08-12 12:08:19 PDT --- (From update of attachment 34386) Seems like a lot of work to be done in these files still, but if we ever want to be building in svn we have to get it checked in, and what is done seems to work well enough. The FIXMEs and notImplemented can be done another day. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:12:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:12:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812191222.6F11C34C263D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34379|review? |review- Flag| | --- Comment #55 from George Staikos 2009-08-12 12:12:19 PDT --- (From update of attachment 34379) > + m_platformDescription = new PlatformMenuItemDescriptionType; > + if (!m_platformDescription) > + return; Don't think we should be checking for null here. > +void ContextMenuItem::setSubMenu(ContextMenu* subMenu) > +{ > + if (!m_platformDescription) > + return; In fact can we remove all of these checks? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:17:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:17:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812191724.00EFF34C26E9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34374|review? |review- Flag| | --- Comment #56 from George Staikos 2009-08-12 12:17:21 PDT --- (From update of attachment 34374) > +static bool getWebLocData(IDataObject* dataObject, String& url, String* title) > +{ > + return false; > +} Should probably add some UNUSED_PARAM() here > + CString cf_html = "Version:0.9"; > + CString startHTML = "\nStartHTML:"; > + CString endHTML = "\nEndHTML:"; > + CString startFragment = "\nStartFragment:"; > + CString endFragment = "\nEndFragment:"; > + CString sourceURL = "\nSourceURL:"; > + > + append(result, cf_html); > + > + bool shouldFillSourceURL = !srcURL.isEmpty() && (srcURL != "about:blank"); > + > + CString startMarkup = "\n\n\n\n"; > + CString endMarkup = "\n\n\n"; all these CString should be "const" right? static too maybe? > +void ClipboardWince::clearData(const String& type) > +{ > + notImplemented(); > +} This file can use lots of UNUSED_PARAM() The rest seems fine -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:21:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:21:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192102.9937E34C276D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380|commit-queue+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:25:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:25:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192532.6D4A134C27FF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380|review+ | Flag| | --- Comment #57 from Adam Treat 2009-08-12 12:25:29 PDT --- (From update of attachment 34380) Clear flag as was landed in r47132. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:26:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:26:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192617.5E68934C2835@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34383|commit-queue+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:28:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:28:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192841.8967134C28B9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34383|review+ | Flag| | --- Comment #58 from Adam Treat 2009-08-12 12:28:38 PDT --- (From update of attachment 34383) Clear flags as landed with r47133. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:29:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:29:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192910.4223C34C28D7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380| |commit-queue- Flag| | --- Comment #59 from Eric Seidel 2009-08-12 12:29:08 PDT --- (From update of attachment 34380) Rejecting patch 34380 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:29:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:29:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192915.DEF4934C28F5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34384|commit-queue- | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:29:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:29:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812192933.011EC34C290D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34671|commit-queue+ |commit-queue- Flag| | --- Comment #24 from Eric Seidel 2009-08-12 12:29:28 PDT --- (From update of attachment 34671) Rejecting patch 34671 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34671 from bug 27716 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:29:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:29:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812192946.8934B34C2927@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380|commit-queue- |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:30:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:30:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193032.3362934C2947@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34380|review+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:30:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:30:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28223] New: javascript source not reloaded if page is reloaded and breakpoint was set in that source Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28223 Summary: javascript source not reloaded if page is reloaded and breakpoint was set in that source Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pmuellr at yahoo.com Test case: - browser to http://www.nytimes.com/ - bring up web inspector - switch to scripts panel - find "embed.js" in the list of scripts (any script will likely do) - set a breakpoint in some main-line code in that script - back in the browser window, reload the page - focus back on web inspector, you'll see the source file you set the break point SHOULD be displayed, but is a big white empty area instead - breakpoint is actually paused - check your call stack Was able to repeat with a couple of different sites. Seems like this must be relatively new, I reload a lot. Or maybe it's the breakpoint which gets hit during early loading of the page -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:32:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:32:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193244.5E5C734C29B7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34384|review+ | Flag| | --- Comment #60 from Adam Treat 2009-08-12 12:32:42 PDT --- (From update of attachment 34384) Clear flags as landed with r47134. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:34:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:34:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812193414.76F0434C29E5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #14 from Ryan Leavengood 2009-08-12 12:34:12 PDT --- (In reply to comment #13) > > Beware of the potential cost of that, if fitting it into WebCore involves e.g. > copying an image's data, or doing more than one conversion. Decoding images > has to be really, really fast in a web browser :) Good point. There might be some overhead in using the translator system but hopefully not too much. We can do some benchmarks to be sure, but even if using the translators is a bit slower it might still be worth it. At least it shouldn't affect other ports ;) One other issue is that the translator system does not yet (and may never) support animated images. So for GIFs (and other future animated image formats, MNG, APNG, etc) we would have to fallback to using the WebKit decoders. But I'm tempted to try to fix that in Haiku...it is just tricky since translators are for any kind of data not just images. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:34:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:34:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28224] New: Web pages with SVG and map links aren't rendered correctly Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28224 Summary: Web pages with SVG and map links aren't rendered correctly Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: SVG AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: igor.bronstein at gmail.com http://the-bronsteins.net/ru/tree_svg.html — Web page with SVG (http://the-bronsteins.net/ru/rel_graph.svg) and a map link assigned to this SVG. When opening just an SVG file, it is rendered correctly. But the web page doesn't show the bitmap photo which was a part of an SVG file. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:35:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:35:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193529.E34E034C2A30@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34379|0 |1 is obsolete| | Attachment #34680| |review? Flag| | --- Comment #61 from Yong Li 2009-08-12 12:35:28 PDT --- Created an attachment (id=34680) --> (https://bugs.webkit.org/attachment.cgi?id=34680) 5) ContextMenu (modified) modified according George's suggestion. we have to check m_platformDescription in other functions because it can be cleared by releasePlatformDescription -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:35:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:35:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193530.E554A34C2A3E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34379|0 |1 is obsolete| | Attachment #34680| |review? Flag| | Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34385|review+, commit-queue- | Flag| | --- Comment #61 from Yong Li 2009-08-12 12:35:28 PDT --- Created an attachment (id=34680) --> (https://bugs.webkit.org/attachment.cgi?id=34680) 5) ContextMenu (modified) modified according George's suggestion. we have to check m_platformDescription in other functions because it can be cleared by releasePlatformDescription --- Comment #62 from Adam Treat 2009-08-12 12:35:29 PDT --- (From update of attachment 34385) Clear flags as landed with r47135. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:36:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:36:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193655.D2DBA34C2A66@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34386|commit-queue+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:37:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:37:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812193705.7D9A734C2A7E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #15 from Ryan Leavengood 2009-08-12 12:37:04 PDT --- (In reply to comment #13) > > Beware of the potential cost of that, if fitting it into WebCore involves e.g. > copying an image's data, or doing more than one conversion. Decoding images > has to be really, really fast in a web browser :) Actually this has made me wonder: have you guys ever considered moving image loading and decoding into another thread? Maybe that would add unnecessary complexity and locking issues but at first glance it seems like something that would benefit from parallelism (multiple cores and all being common these days.) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:39:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:39:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812193908.530B434C2ACC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34386|review+ | Flag| | --- Comment #63 from Adam Treat 2009-08-12 12:39:06 PDT --- (From update of attachment 34386) Clear flags as landed with r47136. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:41:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:41:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812194135.53CEC34C2B5B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34387|review+, commit-queue- | Flag| | --- Comment #64 from Adam Treat 2009-08-12 12:41:33 PDT --- (From update of attachment 34387) Clearing flags as landed with r47137. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:41:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:41:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812194156.05D2B34C2B81@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|commit-queue+ | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:44:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:44:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812194450.DD99934C2BF1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 --- Comment #25 from Eric Seidel 2009-08-12 12:44:49 PDT --- Applying 34671 from bug 27716. [snip] patching file LayoutTests/platform/mac/Skipped Hunk #1 FAILED at 89. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej patch -p0 "LayoutTests/platform/mac/Skipped" returned 1. Pass --force to ignore patch failures. Rejecting patch 34671 from commit-queue. This patch will require manual commit. mac/Skipped has changed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:45:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:45:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812194535.53D8834C2C2B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34678|review+ | Flag| | --- Comment #65 from Adam Treat 2009-08-12 12:45:33 PDT --- (From update of attachment 34678) Clear flags as landed with r47139. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:45:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:45:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22280] CG GIF decoder uses too much CPU In-Reply-To: References: Message-ID: <20090812194539.92D4B34C2C41@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22280 --- Comment #15 from Kevin M. Dean 2009-08-12 12:45:37 PDT --- I'm glad others have finally started to notice this stupidity. I've seen the issue mentioned in discussions of the latest Safari releases as well outside of here. Do we need to send emails to Steve Jobs himself for someone to take notice that we're sick of something as simple as this being an issue. Shame on you Safari/Webkit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:47:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:47:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22280] CG GIF decoder uses too much CPU In-Reply-To: References: Message-ID: <20090812194735.C26BA34C2C9B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22280 --- Comment #16 from Knodi 2009-08-12 12:47:34 PDT --- I have stopped using Safari just before of this bug. It is such a major bug too it FREEZES the whole browser some time for MINUTES! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:52:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:52:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812195203.2BAC034C2D39@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 --- Comment #16 from Peter Kasting 2009-08-12 12:52:01 PDT --- (In reply to comment #15) > Actually this has made me wonder: have you guys ever considered moving image > loading and decoding into another thread? Maybe that would add unnecessary > complexity and locking issues but at first glance it seems like something that > would benefit from parallelism (multiple cores and all being common these > days.) Not sure it'd be a big win since image decoding only happens on-demand, when the image is actually going to be drawn onscreen. Maybe for lots of images that are all visible at once. I haven't given it a lot of thought. Consider asking dhyatt on IRC. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:52:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:52:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27543] Add platform/wince/ files for WINCE port In-Reply-To: References: Message-ID: <20090812195249.AD0E934C2D6E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27543 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34374|0 |1 is obsolete| | Attachment #34681| |review? Flag| | --- Comment #66 from Yong Li 2009-08-12 12:52:48 PDT --- Created an attachment (id=34681) --> (https://bugs.webkit.org/attachment.cgi?id=34681) 1) Clipboard (modified) modified according George's suggestion -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:54:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:54:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28223] javascript source not reloaded if page is reloaded and breakpoint was set in that source In-Reply-To: References: Message-ID: <20090812195435.6979534C2DC1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28223 --- Comment #1 from Patrick Mueller 2009-08-12 12:54:34 PDT --- Additional odd behavior. - run the test case as above - set the breakpoint to disabled - close web inspector - traverse to another web site in the same window - now go back to the site with the breakpoint set - you can now view the source of the file with the breakpoint - the original breakpoint is still in the breakpoint sidebar, but is not annotated in the source - enabling the breakpoint doesn't cause the debugger to stop in that code anymore - the breakpoint is a zombie in the breakpoint sidebar at this point -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:56:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:56:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090812195629.0AC7134C2E0D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |darin at apple.com Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 12:59:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 12:59:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27933] SVG Filter premultiplied color support for getImageDate/putImageData In-Reply-To: References: Message-ID: <20090812195920.8F65934C2E75@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27933 --- Comment #12 from Brett Wilson (Google) 2009-08-12 12:59:18 PDT --- (From update of attachment 34651) > Index: WebCore/platform/graphics/skia/SkiaUtils.cpp > =================================================================== > --- WebCore/platform/graphics/skia/SkiaUtils.cpp (revision 47098) > +++ WebCore/platform/graphics/skia/SkiaUtils.cpp (working copy) > @@ -80,7 +80,7 @@ static U8CPU InvScaleByte(U8CPU componen > return (component * scale + 0x8000) >> 16; > } > > -SkColor SkPMColorToColor(SkPMColor pm) > +SkColor SkUMColorToColor(SkPMColor pm) > { > if (0 == pm) > return 0; > @@ -94,6 +94,17 @@ SkColor SkPMColorToColor(SkPMColor pm) > InvScaleByte(SkGetPackedB32(pm), scale)); > } > > +SkColor SkPMColorToColor(SkPMColor pm) > +{ > + if (0 == pm) > + return 0; > + > + return SkColorSetARGB(SkGetPackedA32(pm), > + SkGetPackedR32(pm), > + SkGetPackedG32(pm), > + SkGetPackedB32(pm)); > +} It seems like you have the name of this function backwards. UMColor->Color should just be re-ordering the bytes, PMColor->Color needs scaling. Also, having SKUMColorToColor take a PMColor argument is a bit confusing. I actually think writing it out like this is easier to follow, even though it looks longer: unsigned char* destPixel = &destRow[x * 4]; if (multiplied == Unmultiplied) { SkColor color = SkPMColorToColor(srcRow[x]); destPixel[0] = SkColorGetR(color); destPixel[1] = SkColorGetG(color); destPixel[2] = SkColorGetB(color); destPixel[3] = SkColorGetA(color); } else { // Input and output are both pre-multiplied, we just need to re-arrange the bytes from the bitmap format to RGBA. destPixel[0] = SkGetPackedR32(srcRow[x]); destPixel[1] = SkGetPackedG32(srcRow[x]); destPixel[2] = SkGetPackedB32(srcRow[x]); destPixel[3] = SkGetPackedA32(srcRow[x]); } When we want pre-multiplied case, we just need to re-arrange the output. Having the extra function in there (especially one that takes the "wrong" type) makes this harder to see. Brett -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:01:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:01:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19131] Can't remove a breakpoint In-Reply-To: References: Message-ID: <20090812200149.166F434C2EBE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19131 Patrick Mueller changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34682| |review? Flag| | --- Comment #4 from Patrick Mueller 2009-08-12 13:01:47 PDT --- Created an attachment (id=34682) --> (https://bugs.webkit.org/attachment.cgi?id=34682) proposed patch patch as proposed in comment 2 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:07:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:07:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28225] New: check-webkit-style uses python from /usr/bin instead of the PATH Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28225 Summary: check-webkit-style uses python from /usr/bin instead of the PATH Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: carol.szabo at nokia.com check-webkit-style starts with '#!/usr/bin/python'. This prevents usage of the script on computers where /usr/bin/python is absent or is too old even if an appropriate python version exists in the PATH. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:10:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:10:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28226] New: Spinning cursor for 15/20 secs, Sucks. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28226 Summary: Spinning cursor for 15/20 secs, Sucks. Product: WebKit Version: 417.x Platform: Macintosh OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: episodic95 at gmail.com The version I am reporting this from. Figure it out. Spinning cursor for 15/20 secs, Sucks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:16:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:16:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28122] [Haiku] Adding some simple graphic files (IntPoint, =?UTF-8?Q?=20IntRect=E2=80=A6?=) In-Reply-To: References: Message-ID: <20090812201630.8F8A934C305D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28122 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34426|review+, commit-queue+ | Flag| | --- Comment #11 from Eric Seidel 2009-08-12 13:16:28 PDT --- (From update of attachment 34426) Clearing flags on attachment: 34426 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/graphics/haiku/ColorHaiku.cpp A WebCore/platform/graphics/haiku/FloatPointHaiku.cpp A WebCore/platform/graphics/haiku/FloatRectHaiku.cpp A WebCore/platform/graphics/haiku/GradientHaiku.cpp A WebCore/platform/graphics/haiku/IntPointHaiku.cpp A WebCore/platform/graphics/haiku/IntRectHaiku.cpp A WebCore/platform/graphics/haiku/IntSizeHaiku.cpp A WebCore/platform/graphics/haiku/PathHaiku.cpp Committed r47142 M WebCore/ChangeLog A WebCore/platform/graphics/haiku/PathHaiku.cpp A WebCore/platform/graphics/haiku/GradientHaiku.cpp A WebCore/platform/graphics/haiku/ColorHaiku.cpp A WebCore/platform/graphics/haiku/FloatPointHaiku.cpp A WebCore/platform/graphics/haiku/FloatRectHaiku.cpp A WebCore/platform/graphics/haiku/IntPointHaiku.cpp A WebCore/platform/graphics/haiku/IntSizeHaiku.cpp A WebCore/platform/graphics/haiku/IntRectHaiku.cpp r47142 = e4c305eb83f3dda05416b0db9336be7cd0e99ba8 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47142 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:16:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:16:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28122] [Haiku] Adding some simple graphic files (IntPoint, =?UTF-8?Q?=20IntRect=E2=80=A6?=) In-Reply-To: References: Message-ID: <20090812201634.7321334C307F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28122 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #12 from Eric Seidel 2009-08-12 13:16:33 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:17:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:17:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28104] add GDOMTextCustom.cpp In-Reply-To: References: Message-ID: <20090812201733.5205834C30A1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28104 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34452| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:18:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:18:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090812201827.4E45334C30D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 Norbert Leser changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32420|0 |1 is obsolete| | Attachment #34683| |review? Flag| | --- Comment #2 from Norbert Leser 2009-08-12 13:18:25 PDT --- Created an attachment (id=34683) --> (https://bugs.webkit.org/attachment.cgi?id=34683) Updated patch for bug #27060 Symbian compiler for emulator target (WINSCW) fails with "illegal operand" for m_attributesInPrevious in structure.ccp (when calling make_pair functions). This error is apparently due to the compiler not properly resolving the unsigned type of the declared bitfield. Initial patch explicitly casted m_attributesInPrevious to unsigned (at 3 places in structure.cpp), but since bitfield optimization is not critical for the emulator target, this conditional change in header file appears to be least intrusive. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:18:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:18:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090812201859.D595334C310A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34468| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:19:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:19:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812201950.A768A34C3124@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34471| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:19:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:19:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28096] add GDOMCSSRuleCustom.cpp In-Reply-To: References: Message-ID: <20090812201955.4E53634C312E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28096 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34461| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28097] add GDOMCSSValueCustom.cpp In-Reply-To: References: Message-ID: <20090812202008.2978634C313C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28097 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34460| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28098] add GDOMDocumentCustom.cpp In-Reply-To: References: Message-ID: <20090812202019.05C2534C3148@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28098 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34459| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28099] add GDOMElementCustom.cpp In-Reply-To: References: Message-ID: <20090812202019.ABF4134C3154@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28099 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34457| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28101] add GDOMEventTargetCustom.cpp In-Reply-To: References: Message-ID: <20090812202025.EBE6A34C3164@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28101 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34455| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28102] add GDOMHTMLCollectionCustom.cpp In-Reply-To: References: Message-ID: <20090812202031.C793934C317C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28102 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34454| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:20:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:20:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28103] add GDOMHTMLStyleSheetCustom.cpp In-Reply-To: References: Message-ID: <20090812202036.5B92734C318C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28103 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34453| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:23:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:23:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090812202320.292CC34C31E6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34564|review+, commit-queue+ | Flag| | --- Comment #7 from Eric Seidel 2009-08-12 13:23:19 PDT --- (From update of attachment 34564) Clearing flags on attachment: 34564 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/haiku/ScrollbarThemeHaiku.cpp A WebCore/platform/haiku/ScrollbarThemeHaiku.h Committed r47143 M WebCore/ChangeLog A WebCore/platform/haiku/ScrollbarThemeHaiku.cpp A WebCore/platform/haiku/ScrollbarThemeHaiku.h r47143 = 1e5acb63da2fefd1e799f6c31987d9899a34e057 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47143 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:23:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:23:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28125] [Haiku] Adding ScrollbarTheme to WebCore. In-Reply-To: References: Message-ID: <20090812202323.CCF2634C31F8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28125 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #8 from Eric Seidel 2009-08-12 13:23:22 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:24:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:24:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090812202436.CDE4534C3224@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34472| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:24:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:24:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 22280] CG GIF decoder uses too much CPU In-Reply-To: References: Message-ID: <20090812202441.A63DB34C3238@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=22280 --- Comment #17 from Alexei Yudin 2009-08-12 13:24:40 PDT --- I totally agree with Knodi! I love Safari more than Steve Jobs does, but this bug made me switch to Firefox. I still check out Safari once in a while wondering if they fixed it. I've noticed this bug a long time ago when I started reading LJ community where gifs are used a lot. I sent a bunch of bug reports and wrote about this problem in Apple forums thread (http://discussions.apple.com/thread.jspa?messageID=9601292). Now I'm here, I don't what else to do. A letter to Steve actually seems like a good idea. LOL -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:25:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:25:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090812202551.2477834C3268@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34469| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:29:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:29:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090812202902.AAB7E34C331A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 --- Comment #36 from Eric Seidel 2009-08-12 13:29:00 PDT --- Why does hte ChangeLog diff have no context? Also you should obsolete old patches if you're posting a new one. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:29:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:29:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27410] [Gtk] adding GObject Language bindings auto-generator In-Reply-To: References: Message-ID: <20090812202954.ADD7B34C334A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27410 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34467| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:31:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:31:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28107] gobject code generator library properties In-Reply-To: References: Message-ID: <20090812203125.D8A2D34C337E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28107 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34463| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:31:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:31:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28106] gobject code generator library generate function In-Reply-To: References: Message-ID: <20090812203129.4328334C338A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28106 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34464| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:31:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:31:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28105] gobject code generator library functions In-Reply-To: References: Message-ID: <20090812203133.6A64334C3394@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28105 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34465| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:32:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:32:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28096] add GDOMCSSRuleCustom.cpp In-Reply-To: References: Message-ID: <20090812203236.5F32C34C33BE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28096 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34461|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:33:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:33:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27431] splitting CodeGeneratorGObject.pm into library files In-Reply-To: References: Message-ID: <20090812203323.AC59534C33DE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27431 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34466| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:34:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:34:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28225] check-webkit-style uses python from /usr/bin instead of the PATH In-Reply-To: References: Message-ID: <20090812203450.EFDA034C3425@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28225 Carol Szabo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34686| |review? Flag| | --- Comment #1 from Carol Szabo 2009-08-12 13:34:50 PDT --- Created an attachment (id=34686) --> (https://bugs.webkit.org/attachment.cgi?id=34686) Patch: uses python from $PATH This solution was suggested by kollivier on the #webkit IRC channel. It worked for me and it may be useful to others. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28097] add GDOMCSSValueCustom.cpp In-Reply-To: References: Message-ID: <20090812203513.83B3834C3431@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28097 --- Comment #3 from Eric Seidel 2009-08-12 13:35:13 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28098] add GDOMDocumentCustom.cpp In-Reply-To: References: Message-ID: <20090812203514.363E934C3439@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28098 --- Comment #3 from Eric Seidel 2009-08-12 13:35:13 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28099] add GDOMElementCustom.cpp In-Reply-To: References: Message-ID: <20090812203514.DFE5734C3443@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28099 --- Comment #3 from Eric Seidel 2009-08-12 13:35:14 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28101] add GDOMEventTargetCustom.cpp In-Reply-To: References: Message-ID: <20090812203515.9AA7234C344B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28101 --- Comment #3 from Eric Seidel 2009-08-12 13:35:15 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28102] add GDOMHTMLCollectionCustom.cpp In-Reply-To: References: Message-ID: <20090812203516.4BF2334C3455@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28102 --- Comment #3 from Eric Seidel 2009-08-12 13:35:16 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28103] add GDOMHTMLStyleSheetCustom.cpp In-Reply-To: References: Message-ID: <20090812203517.4CEC234C345D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28103 --- Comment #3 from Eric Seidel 2009-08-12 13:35:16 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28104] add GDOMTextCustom.cpp In-Reply-To: References: Message-ID: <20090812203518.7F57A34C3465@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28104 --- Comment #3 from Eric Seidel 2009-08-12 13:35:18 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28105] gobject code generator library functions In-Reply-To: References: Message-ID: <20090812203519.6096A34C346F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28105 --- Comment #3 from Eric Seidel 2009-08-12 13:35:19 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28106] gobject code generator library generate function In-Reply-To: References: Message-ID: <20090812203520.0B99F34C347F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28106 --- Comment #3 from Eric Seidel 2009-08-12 13:35:19 PDT --- Please don't mark patches for review on closed bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812203540.9748134C34A1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34416|review+, commit-queue+ | Flag| | --- Comment #28 from Eric Seidel 2009-08-12 13:35:38 PDT --- (From update of attachment 34416) Clearing flags on attachment: 34416 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/js/ScriptControllerHaiku.cpp M WebCore/loader/CachedFont.cpp M WebCore/page/EventHandler.cpp M WebCore/page/haiku/DragControllerHaiku.cpp M WebCore/platform/image-decoders/ImageDecoder.h M WebCore/platform/text/PlatformString.h M WebCore/platform/text/UnicodeRange.h M WebCore/platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp Committed r47144 M WebCore/ChangeLog M WebCore/page/haiku/DragControllerHaiku.cpp M WebCore/page/EventHandler.cpp M WebCore/platform/text/UnicodeRange.h M WebCore/platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp M WebCore/platform/text/PlatformString.h M WebCore/platform/image-decoders/ImageDecoder.h M WebCore/bindings/js/ScriptControllerHaiku.cpp M WebCore/loader/CachedFont.cpp r47144 = dabd8ddbe25f0c6eb4e9e79ed11b7c7036c7ba22 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47144 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:35:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:35:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28103] add GDOMHTMLStyleSheetCustom.cpp In-Reply-To: References: Message-ID: <20090812203546.0A1E934C34B7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28103 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34453|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:36:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:36:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28102] add GDOMHTMLCollectionCustom.cpp In-Reply-To: References: Message-ID: <20090812203607.C9F8F34C34DD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28102 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34454|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:36:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:36:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28101] add GDOMEventTargetCustom.cpp In-Reply-To: References: Message-ID: <20090812203641.225C734C34F5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28101 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34455|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:36:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:36:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28099] add GDOMElementCustom.cpp In-Reply-To: References: Message-ID: <20090812203650.BBEBF34C3509@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28099 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34457|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:37:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:37:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28098] add GDOMDocumentCustom.cpp In-Reply-To: References: Message-ID: <20090812203702.66E1F34C3523@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28098 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34459|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:37:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:37:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28097] add GDOMCSSValueCustom.cpp In-Reply-To: References: Message-ID: <20090812203729.A43E934C353B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28097 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34460|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:38:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:38:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27410] [Gtk] adding GObject Language bindings auto-generator In-Reply-To: References: Message-ID: <20090812203811.B8DF934C3583@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27410 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34467|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:38:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:38:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28106] gobject code generator library generate function In-Reply-To: References: Message-ID: <20090812203837.4289034C359F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28106 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34464|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:39:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:39:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28105] gobject code generator library functions In-Reply-To: References: Message-ID: <20090812203905.F3F5734C35C5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28105 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34465|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:39:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:39:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27431] splitting CodeGeneratorGObject.pm into library files In-Reply-To: References: Message-ID: <20090812203955.A8E0134C35EF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27431 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34466|review? |review- Flag| | --- Comment #10 from Mark Rowe (bdash) 2009-08-12 13:39:54 PDT --- (From update of attachment 34466) Numbered files is not a logical way for splitting a Perl module. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:41:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:41:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28104] add GDOMTextCustom.cpp In-Reply-To: References: Message-ID: <20090812204104.B12E934C3620@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28104 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34452|review? |review- Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:44:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:44:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812204422.9D3A834C3696@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34559|review+, commit-queue+ | Flag| | --- Comment #29 from Eric Seidel 2009-08-12 13:44:21 PDT --- (From update of attachment 34559) Clearing flags on attachment: 34559 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/ContextMenuItem.h M WebCore/platform/Cursor.h M WebCore/platform/DragData.h M WebCore/platform/DragImage.h M WebCore/platform/PlatformKeyboardEvent.h M WebCore/platform/PlatformMenuDescription.h M WebCore/platform/PlatformMouseEvent.h M WebCore/platform/PlatformWheelEvent.h M WebCore/platform/PopupMenu.h M WebCore/platform/Widget.h Committed r47145 M WebCore/ChangeLog M WebCore/platform/Cursor.h M WebCore/platform/DragData.h M WebCore/platform/PlatformMenuDescription.h M WebCore/platform/PlatformKeyboardEvent.h M WebCore/platform/DragImage.h M WebCore/platform/PopupMenu.h M WebCore/platform/ContextMenuItem.h M WebCore/platform/PlatformMouseEvent.h M WebCore/platform/PlatformWheelEvent.h M WebCore/platform/Widget.h r47145 = a82dd2e4dac367994e9d09bc33a7aa1ceb3485ce (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47145 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:44:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:44:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812204452.C8C6734C36BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34471|review? |review- Flag| | --- Comment #8 from Eric Seidel 2009-08-12 13:44:52 PDT --- (From update of attachment 34471) See my comments in the mail to you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812204504.7B13634C36C8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812204508.D26C234C36F8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 27430, which changed state. Bug 27430 Summary: adds glib / gobject bindings to webkit gtk port https://bugs.webkit.org/show_bug.cgi?id=27430 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28109] add gobject bindings to WebCore/GNUmakefile.am In-Reply-To: References: Message-ID: <20090812204510.1E5EF34C3706@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28109 Bug 28109 depends on bug 27430, which changed state. Bug 27430 Summary: adds glib / gobject bindings to webkit gtk port https://bugs.webkit.org/show_bug.cgi?id=27430 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28110] add gobject bindings to GNUmakefile.am In-Reply-To: References: Message-ID: <20090812204511.318EC34C370C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28110 Bug 28110 depends on bug 27430, which changed state. Bug 27430 Summary: adds glib / gobject bindings to webkit gtk port https://bugs.webkit.org/show_bug.cgi?id=27430 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28111] make compile succeed with gobject bindings In-Reply-To: References: Message-ID: <20090812204511.B469034C3712@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28111 Bug 28111 depends on bug 27430, which changed state. Bug 27430 Summary: adds glib / gobject bindings to webkit gtk port https://bugs.webkit.org/show_bug.cgi?id=27430 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090812204514.E516434C372E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34469|review? |review- Flag| | --- Comment #21 from Eric Seidel 2009-08-12 13:45:13 PDT --- (From update of attachment 34469) See my comments in the mail to you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090812204524.893FF34C3750@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812204529.7177F34C3786@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 27428, which changed state. Bug 27428 Summary: adding "base class" GdomDOMObject for GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27428 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812204531.2916034C379A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Bug 27430 depends on bug 27428, which changed state. Bug 27428 Summary: adding "base class" GdomDOMObject for GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27428 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090812204546.080EA34C37B0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34468|review? |review- Flag| | --- Comment #14 from Eric Seidel 2009-08-12 13:45:45 PDT --- (From update of attachment 34468) See my comments in the mail to you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090812204548.5D8DB34C37C4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 --- Comment #22 from Mark Rowe (bdash) 2009-08-12 13:45:46 PDT --- (From update of attachment 34469) WEBKIT is not a good prefix for header files like this. The includes don't match our coding style. Is overriding the "finalize" method really necessary here? The overridden version doesn't *do* anything. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090812204554.BBA6334C37D6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:45:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:45:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812204559.48D7734C3806@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812204601.7910E34C381A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Bug 27430 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28096] add GDOMCSSRuleCustom.cpp In-Reply-To: References: Message-ID: <20090812204602.2036934C3822@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28096 Bug 28096 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28097] add GDOMCSSValueCustom.cpp In-Reply-To: References: Message-ID: <20090812204602.C9BB334C382A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28097 Bug 28097 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28098] add GDOMDocumentCustom.cpp In-Reply-To: References: Message-ID: <20090812204603.6441734C3832@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28098 Bug 28098 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28099] add GDOMElementCustom.cpp In-Reply-To: References: Message-ID: <20090812204604.011A834C383A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28099 Bug 28099 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28101] add GDOMEventTargetCustom.cpp In-Reply-To: References: Message-ID: <20090812204604.982EC34C3842@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28101 Bug 28101 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28103] add GDOMHTMLStyleSheetCustom.cpp In-Reply-To: References: Message-ID: <20090812204605.DF5D734C3854@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28103 Bug 28103 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28104] add GDOMTextCustom.cpp In-Reply-To: References: Message-ID: <20090812204606.7BA9A34C385C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28104 Bug 28104 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28102] add GDOMHTMLCollectionCustom.cpp In-Reply-To: References: Message-ID: <20090812204605.4B88534C384C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28102 Bug 28102 depends on bug 27426, which changed state. Bug 27426 Summary: adding GDOMBinding.cpp/h as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27426 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:46:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:46:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090812204626.BF80F34C3876@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34472|review? |review- Flag| | --- Comment #37 from Eric Seidel 2009-08-12 13:46:25 PDT --- (From update of attachment 34472) See my comments in the mail to you. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:47:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:47:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812204755.2FCA634C38AC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Jim Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jim at yorba.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:53:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:53:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090812205326.589A634C398B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34262|review+, commit-queue- |review- Flag| | --- Comment #38 from Mark Rowe (bdash) 2009-08-12 13:53:25 PDT --- (From update of attachment 34262) > +#die "You must specify a --bindingType e.g. Gdom or JS" unless (length($binding)); > + We don't land commented-out code. > +# FIXME: make_names is being utilised for six different purposes, > +# with generation of HTMLNames.cpp/h being done at the same time > +# as the JS bindings wrapper factories. It's not clear how this comment relates to the code around it. > +# FIXME: this is here because the gobject bindings were created in > +# november 2008, when #ifdef DATAGRID did not exist. to avoid > +# significant extra work in getting the gobject bindings landed, > +# and to also ensure that webkit-gtk will still compile even when > +# DATAGRID is enabled, this workaround skips the #include > +# of headers which the CodeGeneratorGObject.pm does not yet create. Rather than adding a hack like this to the script we should just fix the related issues. > @@ -313,6 +342,8 @@ > > $uniqueTags{$interfaceName} = '1'; > > + next if (temporaryWorkaroundSkipTag($tagName)); > + There are redundant braces here. > my $conditional = $tags{$tagName}{"conditional"}; > if ($conditional) { > my $conditionalString = "ENABLE(" . join(") && ENABLE(", split(/&/, $conditional)) . ")"; > @@ -346,6 +377,8 @@ > > for my $tagName (sort keys %tagConstructorMap) { > > + next if (temporaryWorkaroundSkipTag($tagName)); > + And here. And in other similar places. > +sub printWrapperFunctionGdomInterface > +{ > + my $F = shift; > + my $JSInterfaceName = shift; This seems like a poor choice of variable name. > + } > + if ($binding eq 'Gdom') { > + printWrapperFunctionGdomInterface($F, $JSInterfaceName); > + } As does this. > + if ($binding eq 'Gdom') { > + printWrapperFunctionGdomInterface($F, $JSInterfaceName); > + } > } In general I don't think that a bunch of "if ($binding eq 'Foo')" is a good way to structure this code. Given the number of issues I've mentioned so far I'm marking this as r-. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:55:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:55:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812205558.287CF34C39D9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34576|review+, commit-queue+ | Flag| | --- Comment #30 from Eric Seidel 2009-08-12 13:55:56 PDT --- (From update of attachment 34576) Clearing flags on attachment: 34576 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/BitmapImage.h M WebCore/platform/graphics/Color.h M WebCore/platform/graphics/FloatPoint.h M WebCore/platform/graphics/FloatRect.h M WebCore/platform/graphics/GraphicsContext.cpp M WebCore/platform/graphics/GraphicsContext.h M WebCore/platform/graphics/Icon.h M WebCore/platform/graphics/ImageSource.h M WebCore/platform/graphics/IntPoint.h M WebCore/platform/graphics/IntRect.h M WebCore/platform/graphics/IntSize.h M WebCore/platform/graphics/Path.h M WebCore/platform/graphics/Pattern.h M WebCore/platform/graphics/SimpleFontData.h Committed r47146 M WebCore/ChangeLog M WebCore/platform/graphics/ImageSource.h M WebCore/platform/graphics/GraphicsContext.h M WebCore/platform/graphics/Color.h M WebCore/platform/graphics/FloatPoint.h M WebCore/platform/graphics/FloatRect.h M WebCore/platform/graphics/Icon.h M WebCore/platform/graphics/GraphicsContext.cpp M WebCore/platform/graphics/IntRect.h M WebCore/platform/graphics/IntSize.h M WebCore/platform/graphics/IntPoint.h M WebCore/platform/graphics/SimpleFontData.h M WebCore/platform/graphics/Pattern.h M WebCore/platform/graphics/BitmapImage.h M WebCore/platform/graphics/Path.h r47146 = 573bc04eec4313e26f6b78c3ccfe1a727e962d0b (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47146 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:56:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:56:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812205602.D5DDB34C39F3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #31 from Eric Seidel 2009-08-12 13:56:01 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:56:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:56:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] In-Reply-To: References: Message-ID: <20090812205655.C8BF534C3A17@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27425 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID --- Comment #39 from Eric Seidel 2009-08-12 13:56:54 PDT --- Given the history and controversy surrounding this bug, I am closing it, and I recommend someone wishing to continue with this work start again with a new bug. See my email to webkit-dev entitled "GDOM patch spam". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:57:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:57:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812205700.4C62734C3A49@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 27425, which changed state. Bug 27425 Summary: adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] https://bugs.webkit.org/show_bug.cgi?id=27425 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:58:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:58:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28225] check-webkit-style uses python from /usr/bin instead of the PATH In-Reply-To: References: Message-ID: <20090812205822.63B9034C3A87@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28225 --- Comment #2 from Mark Rowe (bdash) 2009-08-12 13:58:21 PDT --- None of our existing scripts in WebKitTools/Scripts use this approach. If this is a problem I don't see why we would only fix a single script. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:58:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:58:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28225] check-webkit-style uses python from /usr/bin instead of the PATH In-Reply-To: References: Message-ID: <20090812205852.D3DF534C3A9D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28225 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34686|review? | Flag| | --- Comment #3 from Mark Rowe (bdash) 2009-08-12 13:58:52 PDT --- (From update of attachment 34686) Clearing review flag for reason mentioned. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:59:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:59:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28227] New: Make WebPreferenceKeysPrivate.h available for client use Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28227 Summary: Make WebPreferenceKeysPrivate.h available for client use Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: WebKit API AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: aroben at apple.com Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34687| |review? Flag| | Created an attachment (id=34687) --> (https://bugs.webkit.org/attachment.cgi?id=34687) Patch v1 Reviewed by NOBODY (OOPS!). Need a short description and bug URL (OOPS!) * WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to $WebKitOutputDir, just like we do for a few other headers. Also let VS reorder some XML attributes. * WebPreferenceKeysPrivate.h: Touched this file to force a build. --- 3 files changed, 24 insertions(+), 11 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 13:59:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 13:59:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28227] Make WebPreferenceKeysPrivate.h available for client use In-Reply-To: References: Message-ID: <20090812205959.78A2834C3AD2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28227 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34687|review? |review+ Flag| | --- Comment #1 from Dave Hyatt 2009-08-12 13:59:59 PDT --- (From update of attachment 34687) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:00:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:00:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28227] Make WebPreferenceKeysPrivate.h available for client use In-Reply-To: References: Message-ID: <20090812210029.B389C34C3AE6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28227 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Mac OS X 10.5 |Windows XP -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:00:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:00:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812210057.DCF1E34C3AFE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #32 from Yong Li 2009-08-12 14:00:56 PDT --- #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && (PLATFORM(WIN_OS) || PLATFORM(LINUX))) Why was this allowed where we were required to replace with another macro? See bug 27734 ---- Comment #14 From Eric Seidel 2009-08-06 19:48:50 PDT (-) [reply] ------- (From update of attachment 34178 [details]) Please collapse this line into one nicely named define: 35 #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(WIN_OS)) || PLATFORM(WINCE) like STORE_FONT_POINTER or whatever the heck the ifdefed code does. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:02:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:02:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812210237.3F2B434C3B50@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34568|review+, commit-queue+ | Flag| | --- Comment #17 from Eric Seidel 2009-08-12 14:02:35 PDT --- (From update of attachment 34568) Clearing flags on attachment: 34568 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp Committed r47147 M WebCore/ChangeLog A WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp r47147 = 898556fb5c9912a0b53f789ad3e50e439ce26999 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47147 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:02:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:02:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812210241.9FCBE34C3B6C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #18 from Eric Seidel 2009-08-12 14:02:40 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:08:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:08:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28226] Spinning cursor for 15/20 secs, Sucks. In-Reply-To: References: Message-ID: <20090812210845.B4F0834C3C28@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28226 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WORKSFORME --- Comment #1 from Mark Rowe (bdash) 2009-08-12 14:08:45 PDT --- There's no actionable information in this bug report. Some suggestions for future bug reports: 1) Avoid making demands. No-one likes to be bossed around. 2) Avoid insulting the work of the people you're making demands from. It may make them less inclined to help you. 3) Provide information about the version that you're using, and the platform you're using it on. Are you using a WebKit nightly build? If so, which revision is it? Are you using it on Mac OS X or Windows? Which version of Mac OS X or Windows are you using it on? 4) Describe the situation or actions that trigger the incorrect behavior. Does it happen on launch? After visiting any web page? A specific web page? If so, which page? 4) If you're seeing hangs then you should also include a "sample" of the application while it is unresponsive. See for details about using Activity Monitor to do this. Save the output to a text file and then attach it to the bug report that you file. Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:09:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:09:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812210904.D492834C3C3C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34631|commit-queue+ |commit-queue- Flag| | --- Comment #3 from Eric Seidel 2009-08-12 14:09:04 PDT --- (From update of attachment 34631) Rejecting patch 34631 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:09:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:09:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812210916.0137034C3C58@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34640|commit-queue+ |commit-queue- Flag| | --- Comment #4 from Eric Seidel 2009-08-12 14:09:15 PDT --- (From update of attachment 34640) Rejecting patch 34640 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34640 from bug 28213 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:10:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:10:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28227] Make WebPreferenceKeysPrivate.h available for client use In-Reply-To: References: Message-ID: <20090812211051.3387434C3C9A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28227 Adam Roben (aroben) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Adam Roben (aroben) 2009-08-12 14:10:50 PDT --- Fixed in r47148. http://trac.webkit.org/changeset/47148 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:12:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:12:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] New: Add WebkitDOMObject header files Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28228 Summary: Add WebkitDOMObject header files Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gour at gour-nitai.com Adds header files for WebkitDOMObject.cpp https://bugs.webkit.org/show_bug.cgi?id=27428 Is part of gobject. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:12:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:12:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] Add WebkitDOMObject header files In-Reply-To: References: Message-ID: <20090812211247.4FBA334C3CEC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28228 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16401 Depends on| |27428 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:12:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:12:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812211251.959DD34C3D1C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28228 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:12:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:12:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27428] adding "base class" GdomDOMObject for GObject bindings In-Reply-To: References: Message-ID: <20090812211253.CF9DA34C3D38@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27428 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28228 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:13:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:13:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28229] New: Changing size style properties on COLGROUP and TR doesn't affect TDs Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28229 Summary: Changing size style properties on COLGROUP and TR doesn't affect TDs Product: WebKit Version: 412 Platform: Macintosh OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: karinag at yahoo-inc.com I have a table with different TRs and COLGROUPs. When I dynamically set the width of a colgroup or the height of a TR, it changes the elements' width/height accordingly in all other browsers. However, it doesn't work in Safari/Webkit. In order to achieve the desired efect, I have to change the style in the TD elements (style.width or style.height). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:13:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:13:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28225] check-webkit-style uses python from /usr/bin instead of the PATH In-Reply-To: References: Message-ID: <20090812211348.9455934C3D52@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28225 --- Comment #4 from Carol Szabo 2009-08-12 14:13:48 PDT --- (In reply to comment #2) > None of our existing scripts in WebKitTools/Scripts use this approach. If this > is a problem I don't see why we would only fix a single script. Mark, You are right that this would fix only one script and if otherwise the fix is acceptable I am willing to change all scripts in the directory to use the same approach. On the other hand, there is one other script (roll-over-ChangeLogs) which uses the same approach, so it can be argued that since it is ok for that script it should be ok for this script too. I believe that the /usr/bin/env approach does not make sense for standard shells (such as /usr/bin/sh), but may be useful for perl, python and ruby scripts where many incompatible versions may exist in the system. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:14:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:14:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] Add WebkitDOMObject header files In-Reply-To: References: Message-ID: <20090812211428.E7DA534C3D69@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28228 --- Comment #1 from Gour 2009-08-12 14:14:28 PDT --- Created an attachment (id=34688) --> (https://bugs.webkit.org/attachment.cgi?id=34688) uploadded -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:14:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:14:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28133] SVG Filter feBlend implementation missing In-Reply-To: References: Message-ID: <20090812211437.541A534C3D82@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28133 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34478|review? | Flag| | Attachment #34478|0 |1 is obsolete| | Attachment #34689| |review? Flag| | --- Comment #14 from Dirk Schulze 2009-08-12 14:14:35 PDT --- Created an attachment (id=34689) --> (https://bugs.webkit.org/attachment.cgi?id=34689) SVG Filter feBlend Implementation Many more optimizations. No doubles for colors (now unsigned char). No drawing operations on GraphicsContext. Pick up PixelArray directly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:15:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:15:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] Add WebkitDOMObject header files In-Reply-To: References: Message-ID: <20090812211504.50AAB34C3DAC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28228 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34688| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:17:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:17:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] Add WebkitDOMObject header files In-Reply-To: References: Message-ID: <20090812211706.2318F34C3DEA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28228 Gour changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34688|review? | Flag| | --- Comment #2 from Gour 2009-08-12 14:17:05 PDT --- (From update of attachment 34688) I am cancelling the review because it has the same problem as #27428. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:17:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:17:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812211724.35C5934C3E1A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34631|commit-queue- |commit-queue+ Flag| | --- Comment #4 from Eric Seidel 2009-08-12 14:17:23 PDT --- (From update of attachment 34631) The failure was: Testing 11049 test cases. fast/js/global-constructors.html -> failed Which should be unrelated. I expect the bots just went red and I didn't notice. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:18:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:18:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28230] New: bugzilla-tool land-patches will close bugs with patches r=? Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28230 Summary: bugzilla-tool land-patches will close bugs with patches r=? Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org bugzilla-tool land-patches will close bugs with patches r=? Seems we should fix this. :) https://bugs.webkit.org/show_bug.cgi?id=28130 is an example. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:19:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:19:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28130] [Haiku] Adding Image-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812211915.E0E2034C3E86@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28130 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #19 from Eric Seidel 2009-08-12 14:19:14 PDT --- Sorry for the early closure. We just hit bug 28230. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:19:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:19:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090812211923.BF4ED34C3E9E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |eric at webkit.org Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:21:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:21:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812212158.2E94D34C3EEC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #33 from Eric Seidel 2009-08-12 14:21:57 PDT --- (In reply to comment #32) > #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > (PLATFORM(WIN_OS) || PLATFORM(LINUX))) > > Why was this allowed where we were required to replace with another macro? > > See bug 27734 > > ---- Comment #14 From Eric Seidel 2009-08-06 19:48:50 PDT (-) [reply] > ------- > > (From update of attachment 34178 [details] [details]) > Please collapse this line into one nicely named define: > > 35 #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > PLATFORM(WIN_OS)) || PLATFORM(WINCE) > > like STORE_FONT_POINTER or whatever the heck the ifdefed code does. See comment #4 on this bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:23:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:23:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090812212306.95F6434C3F1A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34618|review? |review+ Flag| | --- Comment #8 from Dave Hyatt 2009-08-12 14:23:05 PDT --- (From update of attachment 34618) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:23:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:23:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812212311.2964134C3F2E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #5 from Eric Seidel 2009-08-12 14:23:09 PDT --- Applying 34640 from bug 28213. patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/http/tests/wml/access-target-domain-deny.html patching file LayoutTests/http/tests/wml/access-target-path-deny.html patching file LayoutTests/http/tests/wml/access-target.html patching file WebKitTools/ChangeLog Hunk #1 succeeded at 2 with fuzz 3. can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: WebKitTools/Scripts/make-script-test-wrappers |=================================================================== |--- WebKitTools/Scripts/make-script-test-wrappers |+++ WebKitTools/Scripts/make-script-test-wrappers -------------------------- File to patch: Skip this patch? [y] Skipping patch. 1 out of 1 hunk ignored patch -p0 "WebKitTools/Scripts/make-script-test-wrappers" returned 1. Pass --force to ignore patch failures. Logging in as eric at webkit.org... Rejecting patch 34640 from commit-queue. This patch will require manual commit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:27:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:27:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14997] Support for server-sent DOM events In-Reply-To: References: Message-ID: <20090812212722.339AA34C3FCC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14997 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34665|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:29:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:29:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28231] New: Inspector Resource filtering: keyboard Navigation always uses ALL resources Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28231 Summary: Inspector Resource filtering: keyboard Navigation always uses ALL resources Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mtakacs at yahoo.com CC: timothy at hatcher.name, aroben at apple.com, rik at webkit.org +++ This bug was initially created as a clone of Bug #20629 +++ It'd be nice for the Inspector | Resources Graph panel to support filtering by various things. ++++ Thanks for the commit, enjoying it already! However..... Once you have a complex page loaded (with lots of different type entries) and the filter has been applied, the keyboard shortcuts that allow you to scroll thru the resources are still scrolling thru the "all" list instead of the filtered list. example: 1. Open nightly build of webkit, open Resources tab 2. http://nightly.webkit.org/ 3. Note that there are (currently, aug 2009) nine resources displayed ( a CSS file, a few PNG, an ico and the HTML). 4. Confirm the filter is set to ALL 5. Use the keyboard UP/DOWN key to navigate thru the list of resources (works well) 6. Enable the filter for IMAGES (seems to work, only images shown) 7. Use the cursor UP/DOWN keys to navigate thru the list BUG: seems to still scroll thru the original list of 9 resources, even thru the filter for IMAGES is enabled EXPECTED: only scroll thru the list of IMAGES Behavior gets pretty erratic once the navigation list has been confused by cursoring thru a filtered list of resources. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:33:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:33:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28232] New: "Null after navigation" in major-objects.html is unclear Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28232 Summary: "Null after navigation" in major-objects.html is unclear Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Enhancement Priority: P2 Component: WebKit Website AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: joe.mason at torchmobile.com CC: abarth at webkit.org Adam Barth explains the "null after navigation" comment in major-objects.html like this: > > "NULL after navigation" could be clearer - it suggests that DOMWindow and > > everything below it only exists if you type the URL, but not if a page is > > loaded by clicking a link, which can't be true. > > Oh, I meant navigate to cover both typing in the location bar and > clicking a link. Is there a better word to use for that? > > > Does it mean that it's NULL > > immediately after navigation, while waiting for the load, and is replaced by > > a valid pointer after loading? > > I wasn't sure the best way to represent this in the diagram. > Typically, the edge becomes null in the "up" direction and replaced > with a new object in the "down" direction. If you can think of a nice > way to explain this on the page, please file a bug, CC me, and upload > a patch. I think the best way to represent this is with a footnoted explanation. (Patch forthcoming) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:35:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:35:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28231] Inspector Resource filtering: keyboard Navigation always uses ALL resources In-Reply-To: References: Message-ID: <20090812213538.CD2F734C4111@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28231 --- Comment #1 from Tak 2009-08-12 14:35:38 PDT --- Created an attachment (id=34690) --> (https://bugs.webkit.org/attachment.cgi?id=34690) screenshot of label-less resources extra bonus weirdness if you filter by something that isnt there. eg: http://nightly.webkit.org/ Filter by FONTS then cursor up and down the (blank) list, watch as the resources pops in and out of the blank list. Also managed to get it into a state where the resources names were entirely missing, but the graph was there. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:38:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:38:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28232] "Null after navigation" in major-objects.html is unclear In-Reply-To: References: Message-ID: <20090812213850.DE1AF34C4194@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28232 Joe Mason changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34693| |review? Flag| | --- Comment #1 from Joe Mason 2009-08-12 14:38:49 PDT --- Created an attachment (id=34693) --> (https://bugs.webkit.org/attachment.cgi?id=34693) patch to html file -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:39:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:39:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28233] New: Added symbian specific UID3 identifiers to project files Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28233 Summary: Added symbian specific UID3 identifiers to project files Product: WebKit Version: 528+ (Nightly build) Platform: S60 Hardware OS/Version: S60 3rd edition Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: norbert.leser at nokia.com CC: yongjun.zhang at nokia.com, hausmann at webkit.org, laszlo.1.gombos at nokia.com Norbert Leser changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34694| |review? Flag| | Created an attachment (id=34694) --> (https://bugs.webkit.org/attachment.cgi?id=34694) Symbian UID3 Patch for .pro files Symbian target components (library and executable files) require Unique Identifiers (i.e., UID3). These identifiers are defined in the respective project files, conditionally for "symbian" platform. Also, 2 additional properties need to be specified for the QtLauncher executable in the project file, conditionally for "symbian". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:40:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:40:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28231] Inspector Resource filtering: keyboard Navigation always uses ALL resources In-Reply-To: References: Message-ID: <20090812214056.B47FA34C4201@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28231 --- Comment #2 from Tak 2009-08-12 14:40:56 PDT --- Created an attachment (id=34695) --> (https://bugs.webkit.org/attachment.cgi?id=34695) screenshot of IMAGE filter showing a CSS resources after key navigation Here's a screenshot of a CSS resources bleeding into the IMAGE filter after keyboarding up and down the list of IMAGE filtered resources. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:41:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:41:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812214151.6A86434C4239@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 --- Comment #5 from Xiaomei Ji 2009-08-12 14:41:50 PDT --- (In reply to comment #4) > (From update of attachment 34631 [details]) > The failure was: > Testing 11049 test cases. > fast/js/global-constructors.html -> failed > > Which should be unrelated. I expect the bots just went red and I didn't > notice. you probably right. There is no such failure in my local run with my change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:49:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:49:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812214927.5D81234C434F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34631|review+, commit-queue+ | Flag| | --- Comment #6 from Eric Seidel 2009-08-12 14:49:26 PDT --- (From update of attachment 34631) Clearing flags on attachment: 34631 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/manual-tests/keyboard_select_elements_with_same_beginning.html M WebCore/platform/chromium/PopupMenuChromium.cpp Committed r47150 M WebCore/ChangeLog M WebCore/platform/chromium/PopupMenuChromium.cpp A WebCore/manual-tests/keyboard_select_elements_with_same_beginning.html r47150 = bc763ed3dfd04ac8690009160a8baa8af4d3053e (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47150 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:49:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:49:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28205] [Chromium] drop down menu letter selection, skip selections In-Reply-To: References: Message-ID: <20090812214931.4296934C436F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28205 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #7 from Eric Seidel 2009-08-12 14:49:30 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:55:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:55:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24971] Setting style.height = value in javascript doesn't work in tablerows(    ) In-Reply-To: References: Message-ID: <20090812215524.4348C34C449E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24971 Karina Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karinag at yahoo-inc.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:55:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:55:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24971] Setting style.height = value in javascript doesn't work in tablerows() In-Reply-To: References: Message-ID: <20090812215548.F2E8834C44BC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24971 Karina Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mitz at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:56:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:56:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19131] Can't remove a breakpoint In-Reply-To: References: Message-ID: <20090812215630.29F5E34C44D4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19131 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34682|review? |review- Flag| | --- Comment #5 from Timothy Hatcher 2009-08-12 14:56:29 PDT --- (From update of attachment 34682) You will need to remove the "No new tests" line other wise the patch wont commit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:58:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:58:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812215801.75DF534C451E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34615|commit-queue+ |commit-queue- Flag| | --- Comment #4 from Eric Seidel 2009-08-12 14:57:59 PDT --- (From update of attachment 34615) Rejecting patch 34615 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34615 from bug 28196 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:58:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:58:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28234] New: AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRange is wrong in some cases Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28234 Summary: AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRan ge is wrong in some cases Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Accessibility AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cfleizach at apple.com When there is a block of text followed by a link, the bounds for certain ranges is wrong (specifcally the ranges retreived when asking for next line ranges) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:58:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:58:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27143] [Gtk][REGRESSION] XHR test failures after r45558 In-Reply-To: References: Message-ID: <20090812215844.1F83A34C456F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27143 --- Comment #2 from Gustavo Noronha (kov) 2009-08-12 14:58:43 PDT --- Created an attachment (id=34696) --> (https://bugs.webkit.org/attachment.cgi?id=34696) disable sniffing when requested LayoutTests/ChangeLog | 11 +++++++++++ LayoutTests/platform/gtk/Skipped | 1 - WebCore/ChangeLog | 13 +++++++++++++ .../platform/network/soup/ResourceHandleSoup.cpp | 3 +++ 4 files changed, 27 insertions(+), 1 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 14:59:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 14:59:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27143] [Gtk][REGRESSION] XHR test failures after r45558 In-Reply-To: References: Message-ID: <20090812215953.9373634C4595@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27143 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34696| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:02:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:02:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090812220225.0B7BB34C45DD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34683|review? |review- Flag| | --- Comment #3 from Darin Adler 2009-08-12 15:02:24 PDT --- (From update of attachment 34683) This needs a brief comment, otherwise it's simply too mysterious. I'm going to say review- because I don't think we should land it without a comment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:08:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:08:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090812220822.DE46F34C46D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 Joe Mason changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34697| |review? Flag| | --- Comment #29 from Joe Mason 2009-08-12 15:08:21 PDT --- Created an attachment (id=34697) --> (https://bugs.webkit.org/attachment.cgi?id=34697) just replace the string of PLATFORM(FOO) defines Let's get the easy one out of the way - this is just the STORE_FONT_CUSTOM_PLATFORM_DATA define (with an added explanatory comment). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:09:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:09:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28234] AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRange is wrong in some cases In-Reply-To: References: Message-ID: <20090812220946.436C634C4756@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28234 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34698| |review? Flag| | --- Comment #1 from chris fleizach 2009-08-12 15:09:45 PDT --- Created an attachment (id=34698) --> (https://bugs.webkit.org/attachment.cgi?id=34698) patch I'm no expert about Position(s) but here is what I found comparing two cases. case 1) a block of text case 2) a block of text with a link following the text. Goal: To retrieve the bounds of the second line of text in the block. In the first case, [Position.cpp:983] box = searchAheadForBetterMatch(textRenderer); finds nothing because there's nothing else in the list of siblings. It uses its initial m_offset as the caretPosition.. bounds are then calculated correctly. In the second case, same line position box = searchAheadForBetterMatch(textRenderer); finds the InlineRenderer for the anchor tag. it uses that box's caretMinOffset, which is zero, instead of m_offset. Now the bounds are messed up because we think the caret offset is back to zero My fix, which may be incorrect (but doesn't seem to cause any regression test failures), is that we should only reset the caretOffset to the new box's offset if it's > than the current offset (because we're looking downstream in this case, we shouldn't get a offset less than what we started). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:11:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:11:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812221137.39FF934C47A0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #34 from Ryan Leavengood 2009-08-12 15:11:36 PDT --- (In reply to comment #32) > #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > (PLATFORM(WIN_OS) || PLATFORM(LINUX))) > > Why was this allowed where we were required to replace with another macro? > > See bug 27734 > > ---- Comment #14 From Eric Seidel 2009-08-06 19:48:50 PDT (-) [reply] > ------- > > (From update of attachment 34178 [details] [details]) > Please collapse this line into one nicely named define: > > 35 #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > PLATFORM(WIN_OS)) || PLATFORM(WINCE) > > like STORE_FONT_POINTER or whatever the heck the ifdefed code does. If you WinCE guys want to add this we will modify our patch once yours has landed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:11:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:11:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28215] [v8] Fix atomic string externalization crash In-Reply-To: References: Message-ID: <20090812221145.4B4FF34C47CA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28215 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED CC| |levin at chromium.org Resolution|FIXED | AssignedTo|webkit-unassigned at lists.web |christian.plesner.hansen at gm |kit.org |ail.com --- Comment #5 from David Levin 2009-08-12 15:11:42 PDT --- Had to roll this out http://trac.webkit.org/changeset/47153 due to v8 being rolled back upstream. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:11:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:11:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14997] Support for server-sent DOM events In-Reply-To: References: Message-ID: <20090812221146.DAAFA34C47DE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14997 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34665| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:15:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:15:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090812221516.C13D034C48A9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34648|review+ |review- Flag| | --- Comment #31 from Eric Seidel 2009-08-12 15:15:14 PDT --- (From update of attachment 34648) 157 if (m_layer->renderer()->document()->isXHTMLMPDocument()) { 158 if (m_timer.isActive() || m_layer->renderer()->style()->marqueeIncrement().isZero() || !m_layer->renderer()->style()->marqueeLoopCount()) 159 return; 160 } else { 161 if (m_timer.isActive() || m_layer->renderer()->style()->marqueeIncrement().isZero()) 162 return; 163 } 164 I would have written that as: 161 if (m_timer.isActive() || m_layer->renderer()->style()->marqueeIncrement().isZero() || (m_layer->renderer()->document()->isXHTMLMPDocument() && !m_layer->renderer()->style()->marqueeLoopCount()) 162 return; in fact, that can seasily just be added as part of the existing if: if (m_timer.isActive() || m_layer->renderer()->style()->marqueeIncrement().isZero() #if WCSS || (m_layer->renderer()->document()->isXHTMLMPDocument() && !m_layer->renderer()->style()->marqueeLoopCount() #endif } 156167 return; -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:15:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:15:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090812221551.1CB8C34C48F1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34560|review+ | Flag| | --- Comment #102 from Eric Seidel 2009-08-12 15:15:44 PDT --- (From update of attachment 34560) Clearing review flag since a new patch has been posted. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:18:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:18:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26620] Haiku WebKit port In-Reply-To: References: Message-ID: <20090812221801.DB1B234C4971@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26620 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #63 from Eric Seidel 2009-08-12 15:17:59 PDT --- I think it's time to retire this bug. Please post new patches on new bugs. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:19:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:19:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090812221921.E01AC34C49A3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34618| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:20:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:20:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24971] Setting style.height = value in javascript doesn't work in tablerows() In-Reply-To: References: Message-ID: <20090812222017.DF23C34C49D7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24971 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:20:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:20:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27124] let me *edit* css styles in the web inspector. In-Reply-To: References: Message-ID: <20090812222036.447CA34C49F9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27124 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #15 from Eric Seidel 2009-08-12 15:20:33 PDT --- http://trac.webkit.org/changeset/46690 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:20:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:20:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24971] Setting style.height = value in javascript doesn't work in tablerows() In-Reply-To: References: Message-ID: <20090812222042.A067234C4A03@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24971 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar --- Comment #2 from mitz at webkit.org 2009-08-12 15:20:41 PDT --- -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:21:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:21:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812222101.CCF5434C4A1B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #35 from Yong Li 2009-08-12 15:21:00 PDT --- (In reply to comment #34) > (In reply to comment #32) > > #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > > (PLATFORM(WIN_OS) || PLATFORM(LINUX))) > > > > Why was this allowed where we were required to replace with another macro? > > > > See bug 27734 > > > > ---- Comment #14 From Eric Seidel 2009-08-06 19:48:50 PDT (-) [reply] > > ------- > > > > (From update of attachment 34178 [details] [details] [details]) > > Please collapse this line into one nicely named define: > > > > 35 #if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && > > PLATFORM(WIN_OS)) || PLATFORM(WINCE) > > > > like STORE_FONT_POINTER or whatever the heck the ifdefed code does. > > If you WinCE guys want to add this we will modify our patch once yours has > landed. Don't worry about this. Your patch has already been committed, and ours is still pending. So I had to solve conflicts when I updated our repo. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:21:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:21:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090812222124.10BC734C4A4F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Bug 19264 depends on bug 27458, which changed state. Bug 27458 Summary: Support :default HTML5 CSS selector https://bugs.webkit.org/show_bug.cgi?id=27458 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:22:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:22:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27429] add gdom.h "convenience" header as part of GObject bindings In-Reply-To: References: Message-ID: <20090812222207.3790E34C4A77@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27429 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |INVALID --- Comment #7 from Eric Seidel 2009-08-12 15:22:06 PDT --- Closing out GDOM bugs. Someone else will need to take these on later. See my email to webkit-dev on the subject. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:22:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:22:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812222211.4AF2034C4AA7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 27429, which changed state. Bug 27429 Summary: add gdom.h "convenience" header as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27429 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:22:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:22:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090812222213.593E334C4ABD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Bug 27430 depends on bug 27429, which changed state. Bug 27429 Summary: add gdom.h "convenience" header as part of GObject bindings https://bugs.webkit.org/show_bug.cgi?id=27429 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:22:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:22:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812222248.178A134C4AE5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34401| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:25:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:25:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28064] wrong calculation of overflow size for flexbox and table In-Reply-To: References: Message-ID: <20090812222537.1A0A034C4B61@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28064 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34440| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:25:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:25:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28161] Qt DumpRenderTree does not process named events. In-Reply-To: References: Message-ID: <20090812222557.E410134C4B7D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28161 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34555|review+ | Flag| | --- Comment #13 from Eric Seidel 2009-08-12 15:25:56 PDT --- (From update of attachment 34555) clearing review flag on this obsolete patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:26:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:26:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090812222624.D16E734C4B99@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 --- Comment #32 from George Staikos 2009-08-12 15:26:24 PDT --- (In reply to comment #31) > (From update of attachment 34648 [details]) > > in fact, that can seasily just be added as part of the existing if: > > if (m_timer.isActive() || > m_layer->renderer()->style()->marqueeIncrement().isZero() > #if WCSS > || (m_layer->renderer()->document()->isXHTMLMPDocument() && > !m_layer->renderer()->style()->marqueeLoopCount() > #endif > } > 156167 return; I'm already on it. Fixed a few other minor style issues and this one, but in the end took your implementation as above. I'm still concerned about the unconditional addition to CSSValueKeywords.in. How can we deal with that, or is it just fine to include it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:26:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:26:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28162] [Qt] QtLauncher crashes when trying to change zoom level In-Reply-To: References: Message-ID: <20090812222648.D18AC34C4BBF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28162 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34513|commit-queue? |commit-queue+ Flag| | --- Comment #2 from Eric Seidel 2009-08-12 15:26:48 PDT --- (From update of attachment 34513) Adam, since you're a committer, you can just mark this commit-queue+ if you want it committed for you. :) cq=? is for folks who are not committed but want to make sure it's added to the cq. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:27:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:27:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] fix a typo in platform/graphics/skia/PlatformContextSkia.cpp In-Reply-To: References: Message-ID: <20090812222706.AC88534C4BC9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28172 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34543| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:29:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:29:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 14997] Support for server-sent DOM events In-Reply-To: References: Message-ID: <20090812222945.E591534C4C3B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=14997 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34665|commit-queue+ |commit-queue- Flag| | --- Comment #34 from Eric Seidel 2009-08-12 15:29:41 PDT --- (From update of attachment 34665) Testing 11056 test cases. fast/dom/prototype-inheritance-2.html -> failed fast/dom/prototype-inheritance.html -> failed fast/dom/Window/window-properties.html -> failed This needs more tests updated. Either the patch needs to be updated, or someone needs to do that when landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:30:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:30:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28228] Add WebkitDOMObject header files In-Reply-To: References: Message-ID: <20090812223024.007F334C4C53@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28228 --- Comment #3 from Mark Rowe (bdash) 2009-08-12 15:30:23 PDT --- Gour, rather than continuing along with the same problematic approach that Luke took can you please do as requested and discuss a more productive approach with the maintainers of the GTK port. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:31:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:31:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812223111.30CD734C4C7B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28213 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:31:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:31:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28213] Some HTMLs are modified by make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812223110.C5B0E34C4C75@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28213 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Depends on| |28212 Ever Confirmed|0 |1 --- Comment #6 from Eric Seidel 2009-08-12 15:31:09 PDT --- Oh, this patch depends on bug 28212. It can be re-added to the commit-queue once bug 28212 is landed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:31:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:31:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28235] New: Using QWebFrame::evaluateJavaScript does not relayout Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28235 Summary: Using QWebFrame::evaluateJavaScript does not relayout Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rich at kde.org Created an attachment (id=34700) --> (https://bugs.webkit.org/attachment.cgi?id=34700) Patch to fix the bug It seems that executing javascript code using evaluateJavaScript that changes the visibility of some divs in a page does not cause an immediate relayout of the page. The page instead remains unchanged until the user moves the mouse over it. The problem was found by using js like this: function toggleVisibility(id) { el = document.getElementById(id); if (el.style.display == 'none') { el.style.display = ''; window.silk.GM_log('showing'); } else { el.style.display = 'none'; window.silk.GM_log('hiding'); } } toggleVisibility('sidebar'); toggleVisibility('header'); toggleVisibility('footer'); Executed against a gitorious repository. The same code executed in the inspector functions as expected. I've included what I think should be a patch to fix this issue in master, though since my code has kde dependencies against 4.5 I have been unable to test it so far. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:31:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:31:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812223123.8869034C4C86@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34638| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:32:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:32:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090812223208.9593034C4C96@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34638|commit-queue+ |commit-queue- Flag| | --- Comment #5 from Eric Seidel 2009-08-12 15:32:08 PDT --- (From update of attachment 34638) Nm, I'll leave this for Shinichiro to commit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:33:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:33:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812223307.6064F34C4CC2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #6 from Eric Seidel 2009-08-12 15:33:06 PDT --- I can't tell if this is still pending commit. But I think it's not supposed to be, or? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:33:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:33:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812223347.632FF34C4CE0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34615|commit-queue- |commit-queue+ Flag| | --- Comment #5 from Eric Seidel 2009-08-12 15:33:46 PDT --- (From update of attachment 34615) Not sure why this was rejected from the queue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:35:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:35:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812223555.7C5B134C4D24@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #7 from Gavin Barraclough 2009-08-12 15:35:54 PDT --- I'm not sure I understand your question. :-) This patch is committed, currently pending decommit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:37:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:37:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812223722.B4FD134C4D6C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34633|review+ | Flag| | --- Comment #8 from Eric Seidel 2009-08-12 15:37:21 PDT --- (From update of attachment 34633) Ok. Removing the r+ to remove it from the to-be-committed list. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:40:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:40:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812224030.F0F0434C4DED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #22 from Dumitru Daniliuc 2009-08-12 15:40:27 PDT --- (In reply to comment #21) > (From update of attachment 34535 [details]) > For the future (this one being in pre-existing code), WebKit code tends to > favor early returns instead of long if-blocks: > 544545 if (m_document->databaseThread()) { fixed. > Yes, our style is strange, but comments count as "lines" for multi-line if > blocks and shoudl have { } (I used to get this confused myself): > 87 if (pendingTransactions.isEmpty()) > 88 // No more pending transactions; delete dbIdentifier's queue > 89 m_pendingTransactions.remove(it); > 90 else > 91 // We have more pending transactions; start the next one > 92 pendingTransactions.first()->lockAcquired(); fixed. > No argument names when they don't add clarity: > 46 void acquireLock(SQLTransaction* transaction); > 47 void releaseLock(SQLTransaction* transaction); removed. > Why not add named functions for these: > 34 // statement success callback > 35 function(result) { log(dbName + " read statement > succeeded"); }, > 36 > 37 // statement failure callback > 38 function(tx, error) { log(dbName + " read statement > failed: " + error.message); }); > > Then you dont' have to declare them twice, nor do you need the extra lines of > comments or spaces because the method names make it obvious what you're doing. > > function successCallback(testName) { > return function(result) { log(dbName + " " + testName + " statement > succeeded"); } > > successCallback("write") done. > If you wanted, you coudl even make them more general and cover the other places > you use success/error callbacks too. we could do this, but since the messages are quite different (read vs. write, statement vs. transaction, and read/write doesn't even apply in case of a transaction callback), i feel like this would only lead to more complicated and unintuitive implementations for successCallback() and errorCallback(), as well as some pretty cryptic calls to these functions. > I'm ready to r+ this, but I think we should go one more round (since iirc you > are not yet a committer). i'm working my way there. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:41:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:41:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812224106.6D26C34C4E10@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34535|0 |1 is obsolete| | Attachment #34701| |review? Flag| | --- Comment #23 from Dumitru Daniliuc 2009-08-12 15:41:03 PDT --- Created an attachment (id=34701) --> (https://bugs.webkit.org/attachment.cgi?id=34701) patch + test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:41:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:41:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28064] wrong calculation of overflow size for flexbox and table In-Reply-To: References: Message-ID: <20090812224152.71B9934C4E34@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28064 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34440|commit-queue+ |commit-queue- Flag| | --- Comment #6 from Eric Seidel 2009-08-12 15:41:52 PDT --- (From update of attachment 34440) Rejecting patch 34440 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:42:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:42:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812224232.B97A434C4E52@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #9 from Gavin Barraclough 2009-08-12 15:42:31 PDT --- Hmmm, is removing the r+ flag a good idea? :-/ Are we not losing the information from bugzilla as to who reviewed the patch, and which patches have been approved? What problem is this solving, does this related to the commit queue? If so, it seems the commit queue shouldn't care about this bug, since it was not added to the queue. If there is a problem, are we solving it in the right way here? - does the review queue mechanism need to be smarter? (Apologies if I'm just misunderstanding something here). cheers, G. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:45:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:45:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27596] Inspector: Console Object Property Subtitle's Display Poorly In-Reply-To: References: Message-ID: <20090812224507.C336E34C4E95@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27596 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |timothy at hatcher.name -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:47:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:47:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28236] New: Inspector: Doesn't Respect javascript's const keyword Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28236 Summary: Inspector: Doesn't Respect javascript's const keyword Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: joepeck02 at gmail.com CC: timothy at hatcher.name, aroben at apple.com, kmccullough at apple.com It seems a const variable declared in the Console is just a "var" and can change value. > zzz // ensure it doesn't exist ReferenceError: Can't find variable: zzz > const zzz = 10; undefined > zzz = 5; // should do nothing 5 > zzz 5 I would have expected the result to have been 10, since the constant shouldn't change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:49:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:49:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28162] [Qt] QtLauncher crashes when trying to change zoom level In-Reply-To: References: Message-ID: <20090812224924.290B334C4F07@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28162 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34513|review+, commit-queue+ | Flag| | --- Comment #3 from Eric Seidel 2009-08-12 15:49:23 PDT --- (From update of attachment 34513) Clearing flags on attachment: 34513 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/qt/ChangeLog M WebKit/qt/QtLauncher/main.cpp Committed r47156 M WebKit/qt/QtLauncher/main.cpp M WebKit/qt/ChangeLog r47156 = 2a552d79fea80795059ae47a478f535d24093bdd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47156 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:49:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:49:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28162] [Qt] QtLauncher crashes when trying to change zoom level In-Reply-To: References: Message-ID: <20090812224928.91A0534C4F21@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28162 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #4 from Eric Seidel 2009-08-12 15:49:27 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:51:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:51:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28064] wrong calculation of overflow size for flexbox and table In-Reply-To: References: Message-ID: <20090812225137.0E37E34C4F61@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28064 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #7 from Eric Seidel 2009-08-12 15:51:35 PDT --- transitions/transition-end-event-transform.html -> failed Not sure if it was related to your patch or not. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:54:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:54:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28236] Inspector: Doesn't Respect javascript's const keyword In-Reply-To: References: Message-ID: <20090812225431.2154F34C4FDA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28236 --- Comment #1 from Joseph Pecoraro 2009-08-12 15:54:30 PDT --- Maybe this is actually a problem with eval(): Expected Behavior without eval: javascript:const zza = 10; zza = 5; alert(zza) => 10 Bad Behavior with eval: javascript:alert(eval("const zzb = 10; zzb = 5; zzb")) => 5 How should this bug be reclassified? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:56:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:56:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] fix a typo in platform/graphics/skia/PlatformContextSkia.cpp In-Reply-To: References: Message-ID: <20090812225605.E7F4E34C5008@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28172 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34543|review+, commit-queue+ | Flag| | --- Comment #2 from Eric Seidel 2009-08-12 15:56:05 PDT --- (From update of attachment 34543) Clearing flags on attachment: 34543 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/skia/PlatformContextSkia.cpp Committed r47157 M WebCore/ChangeLog M WebCore/platform/graphics/skia/PlatformContextSkia.cpp r47157 = 26175092e7df7fdb43ae216e3e6bcfa058bb59d0 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47157 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:56:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:56:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28172] fix a typo in platform/graphics/skia/PlatformContextSkia.cpp In-Reply-To: References: Message-ID: <20090812225609.1BBDB34C5016@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28172 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-12 15:56:08 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:57:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:57:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812225714.6CCA034C5038@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #10 from Eric Seidel 2009-08-12 15:57:13 PDT --- The query that Maciej sent to the list months ago for listing which bugs need commit: https://bugs.webkit.org/buglist.cgi?query_format=advanced&short_desc_type=notregexp&short_desc=%5C%5BS60%5C%5D&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&keywords_type=allwords&keywords=&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&emailassigned_to1=1&emailtype1=substring&email1=&emailassigned_to2=1&emailreporter2=1&emailcc2=1&emailtype2=substring&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=review%2B&field0-1-0=noop&type0-1-0=equals&value0-1-0= Show's bugs if they have r+. Nah, the commit-queue is smart enough to only look for bugs which actually have a commit-queue+. It's just we humans who are confused by the r+ on an open bug, and wonder if said open bug should be considered for landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:58:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:58:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28237] New: Pan Scrolling and Panning don't jump out of frames, while mouse wheel events do Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28237 Summary: Pan Scrolling and Panning don't jump out of frames, while mouse wheel events do Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.samisite.com/test-csb2nf/id43.htm OS/Version: Windows 7 Status: NEW Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: bweinstein at apple.com If your mouse is in a frame that can scroll, and you mousewheel to the bottom of the frame, the scrolling action will continue to its parent (usually the document). However, if you are panscrolling, when you scroll to the bottom of the frame, the scrolling does not continue to scroll the parent, and just stops the scrolling when it is done scrolling the frame. I am not sure if this is by design or a bug, but I am filing it here to open up discussion on the proper behavior. Fixing this to continue panscrolling/panning to the parent would have 2 benefits: 1) It would make these ways of scrolling more like mousewheel scrolling. 2) It would make scrolling frames and iFrames functionally equivalent to scrolling divs with overflow. On the attached URL, go into one of the iFrames with scrollbars, and try mouse-wheeling and pan-scrolling to reproduce the behavior that is discussed here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:58:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:58:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090812225819.98BB334C506C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 --- Comment #11 from Gavin Barraclough 2009-08-12 15:58:18 PDT --- Ah, I see. Fair enough. :-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 15:58:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 15:58:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28237] Pan Scrolling and Panning don't jump out of frames, while mouse wheel events do In-Reply-To: References: Message-ID: <20090812225843.7DA9834C507E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28237 Brian Weinstein changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |bweinstein at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:04:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:04:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812230401.60FD934C510D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #92 from Eric Seidel 2009-08-12 16:03:58 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/graphics/wince/ColorWince.cpp A WebCore/platform/graphics/wince/GradientWince.cpp Committed r47158 M WebCore/ChangeLog A WebCore/platform/graphics/wince/ColorWince.cpp A WebCore/platform/graphics/wince/GradientWince.cpp r47158 = 4c84387c23d3b46cd7698b406d8ce9d740430bcd (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47158 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:04:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:04:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090812230404.65E8B34C5133@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Bug 27561 depends on bug 27511, which changed state. Bug 27511 Summary: Add WinCE specific platform/graphics files to WebCore https://bugs.webkit.org/show_bug.cgi?id=27511 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:08:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:08:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28234] AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRange is wrong in some cases In-Reply-To: References: Message-ID: <20090812230821.62A5634C51BF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28234 --- Comment #2 from Darin Adler 2009-08-12 16:08:20 PDT --- (From update of attachment 34698) To me this looks like a workaround for a bug in searchAheadForBetterMatch. Is it possible to fix searchAheadForBetterMatch instead? Are there other calls that would benefit from a fix to that function? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:08:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:08:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812230829.B1E9634C51D1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34615|commit-queue+ |commit-queue- Flag| | --- Comment #6 from Eric Seidel 2009-08-12 16:08:28 PDT --- (From update of attachment 34615) Rejecting patch 34615 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34615 from bug 28196 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:09:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:09:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812230948.E21FC34C520F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #7 from Eric Seidel 2009-08-12 16:09:47 PDT --- Oh, this patch was made from within WebCore instead of the top level directory. that's why it's failing: patching file WebCore/ChangeLog patch: **** malformed patch at line 20: patch -p0 "WebCore/ChangeLog" returned 2. Pass --force to ignore patch failures. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:10:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:10:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28234] AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRange is wrong in some cases In-Reply-To: References: Message-ID: <20090812231012.0BC0D34C521F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28234 --- Comment #3 from chris fleizach 2009-08-12 16:10:11 PDT --- i'll have to look at that method. i'm not sure how many other clients use the bounding boxes of text markers -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:10:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:10:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28234] AXTextMarkers: AccessibilityRenderObject::boundsForVisiblePositionRange is wrong in some cases In-Reply-To: References: Message-ID: <20090812231026.48C1F34C5227@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28234 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |cfleizach at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:10:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:10:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090812231045.7CE7334C5235@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 --- Comment #8 from Eric Seidel 2009-08-12 16:10:44 PDT --- It seems that we could teach svn-apply to handle such patches, especially since the full path is actually in the patch. But maybe this patch is truly malformed? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:12:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:12:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28128] [Haiku] Modifications on WebCore. In-Reply-To: References: Message-ID: <20090812231235.0668034C52B9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28128 --- Comment #36 from Ryan Leavengood 2009-08-12 16:12:33 PDT --- (In reply to comment #35) > > Don't worry about this. Your patch has already been committed, and ours is > still pending. So I had to solve conflicts when I updated our repo. Sorry I did not realize our patch had already been committed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:14:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:14:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812231431.8CA6734C52FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34401|review+, commit-queue+ | Flag| | --- Comment #93 from Eric Seidel 2009-08-12 16:14:30 PDT --- (From update of attachment 34401) Hit bug 28230 again. multi-patch bugs still confuse our tools. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:15:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:15:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090812231500.8559C34C5327@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #94 from Eric Seidel 2009-08-12 16:14:59 PDT --- Hit bug 28230 again. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:15:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:15:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090812231503.613EE34C534B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Bug 27561 depends on bug 27511, which changed state. Bug 27511 Summary: Add WinCE specific platform/graphics files to WebCore https://bugs.webkit.org/show_bug.cgi?id=27511 What |Old Value |New Value ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:20:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:20:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28233] Added symbian specific UID3 identifiers to project files In-Reply-To: References: Message-ID: <20090812232005.6778934C53EF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28233 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34694|review? |review+, commit-queue+ Flag| | --- Comment #1 from Eric Seidel 2009-08-12 16:20:04 PDT --- (From update of attachment 34694) You don't describe these very well: + Also, 2 additional properties need to be specified + for the QtLauncher executable in the project file, + conditionally for "symbian". The patch looks non-harmful though. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:23:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:23:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28107] gobject code generator library properties In-Reply-To: References: Message-ID: <20090812232329.6945034C543D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28107 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34463|review? |review- Flag| | --- Comment #6 from Eric Seidel 2009-08-12 16:23:29 PDT --- (From update of attachment 34463) These patches/bugs are being rejected per my email to webkit-dev regarding GDOM patch spam. Please read and reply as necessary to that email before submitting any further patches. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:23:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:23:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28107] gobject code generator library properties In-Reply-To: References: Message-ID: <20090812232337.B44D434C544B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28107 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:23:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:23:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding In-Reply-To: References: Message-ID: <20090812232341.C45BD34C547D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16401 Bug 16401 depends on bug 28107, which changed state. Bug 28107 Summary: gobject code generator library properties https://bugs.webkit.org/show_bug.cgi?id=28107 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:25:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:25:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812232523.478BB34C54CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34701|review? |review+, commit-queue+ Flag| | --- Comment #24 from Eric Seidel 2009-08-12 16:25:20 PDT --- (From update of attachment 34701) Passing "read" or "write" instead of a bool would have made the callsites more clear, but this is OK as is. 28 function statementSuccessCallback(dbName, isReadStatement) 29 { 30 log(dbName + " " + (isReadStatement ? "read" : "write") + " statement succeeded"); 31 } 32 33 function statementErrorCallback(dbName, isReadStatement, error) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:40:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:40:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812234005.0986B34C5669@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Hin-Chung Lam changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34647|0 |1 is obsolete| | --- Comment #6 from Hin-Chung Lam 2009-08-12 16:40:04 PDT --- Created an attachment (id=34703) --> (https://bugs.webkit.org/attachment.cgi?id=34703) patch + test -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:40:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:40:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812234041.3213234C5690@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Hin-Chung Lam changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34703| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:41:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:41:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234144.0DD2034C56CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34704| |review? Flag| | --- Comment #3 from Eric Seidel 2009-08-12 16:41:42 PDT --- Created an attachment (id=34704) --> (https://bugs.webkit.org/attachment.cgi?id=34704) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:44:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:44:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234403.B556934C5719@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 --- Comment #4 from Darin Adler 2009-08-12 16:44:02 PDT --- (From update of attachment 34704) > + my $testsWhithDidNotMatch = $count - $counts{match}; Which? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:44:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:44:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234405.77EDC34C5731@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34704|review? | Flag| | Attachment #34704|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:44:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:44:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234409.1B1B234C5742@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34705| |review? Flag| | --- Comment #5 from Eric Seidel 2009-08-12 16:44:08 PDT --- Created an attachment (id=34705) --> (https://bugs.webkit.org/attachment.cgi?id=34705) Removed extra change -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:45:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:45:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234516.8710E34C5776@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34705|review? | Flag| | Attachment #34705|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:45:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:45:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234520.4562734C578B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34706| |review? Flag| | --- Comment #6 from Eric Seidel 2009-08-12 16:45:19 PDT --- Created an attachment (id=34706) --> (https://bugs.webkit.org/attachment.cgi?id=34706) Eric has always been reading disabled -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:46:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:46:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812234649.BD64734C57BB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34706|Eric has always been |now with misspelling fixed description|reading disabled | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:48:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:48:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812234814.406FD34C57F0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34701|0 |1 is obsolete| | Attachment #34707| |review? Flag| | --- Comment #25 from Dumitru Daniliuc 2009-08-12 16:48:09 PDT --- Created an attachment (id=34707) --> (https://bugs.webkit.org/attachment.cgi?id=34707) patch + test case Addressed Eric's last comment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:48:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:48:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812234821.037CB34C5810@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34701|commit-queue+ |commit-queue- Flag| | --- Comment #26 from Eric Seidel 2009-08-12 16:48:17 PDT --- (From update of attachment 34701) Rejecting patch 34701 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34701 from bug 27966 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:49:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:49:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 17956] possible write to freed memory in EventTargetNode::dispatchSimulatedMouseEvent() In-Reply-To: References: Message-ID: <20090812234943.CE24134C5838@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=17956 David Kilzer (ddkilzer) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddkilzer at webkit.org, | |koivisto at iki.fi --- Comment #5 from David Kilzer (ddkilzer) 2009-08-12 16:49:42 PDT --- (In reply to comment #4) > The m_dispatchingSimulatedMouseEvent bool is gone from TOT. This bug can be > closed. The m_dispatchingSimulatedEvent bool was removed in r31767. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:49:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:49:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28239] New: bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28239 Summary: bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode It should not cq- minus patches when not in commit-queue mode. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:51:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:51:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812235127.5A97D34C58A6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34707|review? |review+, commit-queue+ Flag| | --- Comment #27 from Eric Seidel 2009-08-12 16:51:24 PDT --- (From update of attachment 34707) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:51:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:51:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812235141.A34D034C58CE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34707|commit-queue+ |commit-queue- Flag| | --- Comment #28 from Eric Seidel 2009-08-12 16:51:38 PDT --- (From update of attachment 34707) Rejecting patch 34707 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=34707 from bug 27966 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:51:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:51:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090812235158.6866634C58F2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #29 from Eric Seidel 2009-08-12 16:51:54 PDT --- Hunk #5 FAILED at 19315. 1 out of 5 hunks FAILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej patch -p0 "WebCore/WebCore.xcodeproj/project.pbxproj" returned 1. Pass --force to ignore patch failures. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:54:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:54:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812235433.32CBF34C5953@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34706|review? |review+ Flag| | --- Comment #7 from Mark Rowe (bdash) 2009-08-12 16:54:32 PDT --- (From update of attachment 34706) > diff --git a/WebKitTools/Scripts/run-webkit-tests b/WebKitTools/Scripts/run-webkit-tests > index 1f908ec..003ac8d 100755 > --- a/WebKitTools/Scripts/run-webkit-tests > +++ b/WebKitTools/Scripts/run-webkit-tests > @@ -109,6 +109,7 @@ sub writeToFile($$); > # Argument handling > my $addPlatformExceptions = 0; > my $complexText = 0; > +my $exitAfterNFailures = 0; > my $guardMalloc = ''; > my $httpdPort = 8000; > my $httpdSSLPort = 8443; > @@ -193,6 +194,7 @@ Usage: $programName [options] [testdir|testpath ...] > --complex-text Use the complex text code path for all text (Mac OS X and Windows only) > -c|--configuration config Set DumpRenderTree build configuration > -g|--guard-malloc Enable malloc guard > + --exit-after-n-failures Exit after the first N failures instead of running all the tests The help for this flag should indicate that it takes an argument. Is there any reason to put it at this point in the help? Are they in any specific order? > countFinishedTest($test, $base, $result, $isText); > + > + my $testsWhichDidNotMatch = $count - $counts{match}; > + if ($exitAfterNFailures && $testsWhichDidNotMatch >= $exitAfterNFailures) { > + print "\nExiting early after $testsWhichDidNotMatch failures. $count tests run."; > + closeDumpTool(); > + last; > + } $testsWhichDidNotMatch sounds like an array of tests that didn't match. Perhaps $failureCount would be a clearer variable name? r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:55:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:55:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090812235543.D9FCF34C5975@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 --- Comment #8 from Eric Seidel 2009-08-12 16:55:42 PDT --- (In reply to comment #7) > (From update of attachment 34706 [details]) > > diff --git a/WebKitTools/Scripts/run-webkit-tests b/WebKitTools/Scripts/run-webkit-tests > > index 1f908ec..003ac8d 100755 > > --- a/WebKitTools/Scripts/run-webkit-tests > > +++ b/WebKitTools/Scripts/run-webkit-tests > > @@ -109,6 +109,7 @@ sub writeToFile($$); > > # Argument handling > > my $addPlatformExceptions = 0; > > my $complexText = 0; > > +my $exitAfterNFailures = 0; > > my $guardMalloc = ''; > > my $httpdPort = 8000; > > my $httpdSSLPort = 8443; > > @@ -193,6 +194,7 @@ Usage: $programName [options] [testdir|testpath ...] > > --complex-text Use the complex text code path for all text (Mac OS X and Windows only) > > -c|--configuration config Set DumpRenderTree build configuration > > -g|--guard-malloc Enable malloc guard > > + --exit-after-n-failures Exit after the first N failures instead of running all the tests > > The help for this flag should indicate that it takes an argument. Is there any > reason to put it at this point in the help? Are they in any specific order? It seemed they were in alphabetical order. But I'm happy to put it wherever. > > countFinishedTest($test, $base, $result, $isText); > > + > > + my $testsWhichDidNotMatch = $count - $counts{match}; > > + if ($exitAfterNFailures && $testsWhichDidNotMatch >= $exitAfterNFailures) { > > + print "\nExiting early after $testsWhichDidNotMatch failures. $count tests run."; > > + closeDumpTool(); > > + last; > > + } > > $testsWhichDidNotMatch sounds like an array of tests that didn't match. > Perhaps $failureCount would be a clearer variable name? Sounds fine to me. Will change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:59:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:59:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090812235906.A599334C59E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34703|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 16:59:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 16:59:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] New: Allow applications to register their own local sheme. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28240 Summary: Allow applications to register their own local sheme. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yael.aharon at nokia.com Expose registerURLSchemeAsLocal from Qt API. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:00:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:00:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090813000015.148F234C59FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow applications to |Allow applications to |register their own local |register their own local |sheme. |URL scheme -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:00:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:00:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28233] Added symbian specific UID3 identifiers to project files In-Reply-To: References: Message-ID: <20090813000048.4173F34C5A23@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28233 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34694|commit-queue+ |commit-queue- Flag| | --- Comment #2 from Eric Seidel 2009-08-12 17:00:47 PDT --- (From update of attachment 34694) Rejecting patch 34694 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/run-webkit-tests --no-launch-safari --quiet --exit-after-n-failures=1 failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:01:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:01:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] [Qt] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090813000107.B99BC34C5A2F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow applications to |[Qt] Allow applications to |register their own local |register their own local |URL scheme |URL scheme -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:03:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:03:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813000358.C0A1034C5AA0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34707|0 |1 is obsolete| | Attachment #34708| |review? Flag| | --- Comment #30 from Dumitru Daniliuc 2009-08-12 17:03:54 PDT --- Created an attachment (id=34708) --> (https://bugs.webkit.org/attachment.cgi?id=34708) patch + test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:04:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:04:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28192] run-webkit-tests needs a --exit-after-failures=N option In-Reply-To: References: Message-ID: <20090813000400.8F69C34C5AAA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28192 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from Eric Seidel 2009-08-12 17:03:58 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/run-webkit-tests Committed r47166 M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/run-webkit-tests r47166 = 581871acba07344f98ea6b67c0be8ed60106d917 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47166 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:05:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:05:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] [Qt] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090813000516.C7EDF34C5AE3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34709| |review? Flag| | --- Comment #1 from Yael 2009-08-12 17:05:16 PDT --- Created an attachment (id=34709) --> (https://bugs.webkit.org/attachment.cgi?id=34709) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:06:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:06:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813000642.40B5534C5B0B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 --- Comment #7 from Simon Fraser (smfr) 2009-08-12 17:06:41 PDT --- Note that layout tests that use eventSender make assumptions about locations of buttons on the media controller that may not hold across platorms. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:09:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:09:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813000933.E480634C5B75@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 --- Comment #8 from Eric Carlson 2009-08-12 17:09:33 PDT --- https://bugs.webkit.org/show_bug.cgi?id=28220 will fix the problem Simon mentioned, but for now you may need to land platform specific test results. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:17:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:17:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813001700.E87D534C5C63@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34708|review? |review+, commit-queue+ Flag| | --- Comment #31 from Eric Seidel 2009-08-12 17:16:57 PDT --- (From update of attachment 34708) We'll try another round. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:17:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:17:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27596] Inspector: Console Object Property Subtitle's Display Poorly In-Reply-To: References: Message-ID: <20090813001739.6A5AE34C5C6B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27596 --- Comment #1 from Timothy Hatcher 2009-08-12 17:17:38 PDT --- I don't fully understand the issue. Screenshots? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:18:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:18:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28236] Inspector: Doesn't Respect javascript's const keyword In-Reply-To: References: Message-ID: <20090813001815.83E5B34C5C7D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28236 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver at apple.com --- Comment #2 from Timothy Hatcher 2009-08-12 17:18:14 PDT --- Oliver, thoughts? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:20:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:20:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28236] Inspector: Doesn't Respect javascript's const keyword In-Reply-To: References: Message-ID: <20090813002050.36D3334C5CB1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28236 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #3 from Oliver Hunt 2009-08-12 17:20:49 PDT --- Yeah this is a known bug with eval -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:21:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:21:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28236] Eval doesn't respect JavaScript's const keyword In-Reply-To: References: Message-ID: <20090813002149.E188534C5CFB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28236 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Web Inspector |JavaScriptCore Summary|Inspector: Doesn't Respect |Eval doesn't respect |javascript's const keyword |JavaScript's const keyword -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:23:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:23:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090813002353.2D7C134C5D3B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #26 from Eric Seidel 2009-08-12 17:23:51 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/dom/Geolocation/enabled-expected.txt A LayoutTests/fast/dom/Geolocation/enabled.html A LayoutTests/fast/dom/Geolocation/resources/TEMPLATE.html A LayoutTests/fast/dom/Geolocation/resources/enabled.js M LayoutTests/platform/mac/Skipped Committed r47168 M LayoutTests/platform/mac/Skipped M LayoutTests/ChangeLog A LayoutTests/fast/dom/Geolocation/enabled-expected.txt A LayoutTests/fast/dom/Geolocation/resources/enabled.js A LayoutTests/fast/dom/Geolocation/resources/TEMPLATE.html A LayoutTests/fast/dom/Geolocation/enabled.html r47168 = 4c2f9fcb3b4be28142507c551e59d825778c701a (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47168 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:26:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:26:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813002651.1F4F734C5D71@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Albert J. Wong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34703| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:31:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:31:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27716] Add Geolocation layout tests. In-Reply-To: References: Message-ID: <20090813003114.23A4234C5DFB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27716 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | AssignedTo|webkit-unassigned at lists.web |eric at webkit.org |kit.org | --- Comment #27 from Mark Rowe (bdash) 2009-08-12 17:31:12 PDT --- doesn't include the changes to qt/Skipped or win/Skipped. Presumably this should also be skipped for GTK too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:33:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:33:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] New: Media controls panel does not have a volume control slider Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28241 Summary: Media controls panel does not have a volume control slider Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hclam at google.com Open a page with in WebKit, there should be a volume control slider. It may not need to be turned on by default since WebKit mac port uses the quick time layout, but it should be at least configurable via css. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:39:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:39:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090813003928.8F8E134C5EEB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 --- Comment #9 from Kyle Prete 2009-08-12 17:39:26 PDT --- Is it? This is only my second time submitting a patch to Webkit. If I've made a mistake, please let me know so I can fix it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:51:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:51:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813005105.642AE34C600A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34708|commit-queue+ |commit-queue- Flag| | --- Comment #32 from Eric Seidel 2009-08-12 17:51:01 PDT --- (From update of attachment 34708) Rejecting patch 34708 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:51:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:51:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813005142.7B59934C6034@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #33 from Eric Seidel 2009-08-12 17:51:39 PDT --- The following files contain tab characters: trunk/WebCore/ChangeLog Please use spaces instead to indent. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:53:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:53:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813005305.9258834C6082@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #34 from Eric Seidel 2009-08-12 17:53:01 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/storage/multiple-transactions-on-different-handles-expected.txt A LayoutTests/storage/multiple-transactions-on-different-handles.html M WebCore/ChangeLog M WebCore/GNUmakefile.am M WebCore/WebCore.gypi M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/storage/Database.cpp M WebCore/storage/Database.h M WebCore/storage/DatabaseThread.cpp M WebCore/storage/DatabaseThread.h M WebCore/storage/SQLTransaction.cpp M WebCore/storage/SQLTransaction.h A WebCore/storage/SQLTransactionCoordinator.cpp A WebCore/storage/SQLTransactionCoordinator.h Committed r47170 M WebCore/storage/DatabaseThread.h M WebCore/storage/SQLTransaction.cpp M WebCore/storage/Database.h A WebCore/storage/SQLTransactionCoordinator.cpp M WebCore/storage/DatabaseThread.cpp M WebCore/storage/Database.cpp M WebCore/storage/SQLTransaction.h A WebCore/storage/SQLTransactionCoordinator.h M WebCore/ChangeLog M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/GNUmakefile.am M WebCore/WebCore.gypi M WebCore/WebCore.xcodeproj/project.pbxproj M LayoutTests/ChangeLog A LayoutTests/storage/multiple-transactions-on-different-handles-expected.txt A LayoutTests/storage/multiple-transactions-on-different-handles.html r47170 = 02db11b4350373f83f85041c33de18fb7410ec8b (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47170 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:53:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:53:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27966] Race condition in the database code In-Reply-To: References: Message-ID: <20090813005319.D59CA34C60AF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27966 --- Comment #35 from Eric Seidel 2009-08-12 17:53:15 PDT --- Fixed and landed manually. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:58:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:58:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20709] Implement HTML 5's HTMLElement.classList property In-Reply-To: References: Message-ID: <20090813005822.ADAE134C6119@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20709 --- Comment #8 from Sylvain Pasche 2009-08-12 17:58:20 PDT --- This feature was recently implemented in Gecko. You may be interested in the automated test [1] that could be easily transformed into a layout test. There are a few Gecko-isms that would need to be removed and you would need to provide is()/ok() implementations. In the current spec the mutating methods (add/remove/toggle) are preserving whitespace. There was some discussions about an alternative approach of normalizing whitespace, which could make implementation more straightforward [2]. That change wasn't made for now, but if you think it would be better to go that way that's something that could be considered. [1] http://hg.mozilla.org/mozilla-central/file/tip/content/base/test/test_classList.html [2] http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-July/021653.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 17:59:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 17:59:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27430] adds glib / gobject bindings to webkit gtk port In-Reply-To: References: Message-ID: <20090813005953.1989034C6143@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27430 Andre Klapper changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a9016009 at gmx.de --- Comment #9 from Andre Klapper 2009-08-12 17:59:51 PDT --- (In reply to comment #8) > See my comments in the mail to you. I did not receive that email. For the sake of transparency please keep technical debates in public comments. Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:00:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:00:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27596] Inspector: Console Object Property Subtitle's Display Poorly In-Reply-To: References: Message-ID: <20090813010010.91EEC34C615C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27596 --- Comment #2 from Joseph Pecoraro 2009-08-12 18:00:09 PDT --- Created an attachment (id=34710) --> (https://bugs.webkit.org/attachment.cgi?id=34710) Image Showing Problem Here is the problem shown in a few different ways. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:00:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:00:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090813010010.E624234C6162@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 Andre Klapper changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a9016009 at gmx.de --- Comment #15 from Andre Klapper 2009-08-12 18:00:09 PDT --- (In reply to comment #14) > (From update of attachment 34468 [details]) > See my comments in the mail to you. I did not receive that email. For the sake of transparency please keep technical debates in public comments. Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:00:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:00:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813010049.4706234C617A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34703|review+, commit-queue+ | Flag| | --- Comment #9 from Eric Seidel 2009-08-12 18:00:48 PDT --- (From update of attachment 34703) Clearing flags on attachment: 34703 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/media/controls-drag-timebar-expected.txt A LayoutTests/media/controls-drag-timebar.html M WebCore/ChangeLog M WebCore/rendering/MediaControlElements.cpp Committed r47171 M WebCore/ChangeLog M WebCore/rendering/MediaControlElements.cpp A LayoutTests/media/controls-drag-timebar-expected.txt A LayoutTests/media/controls-drag-timebar.html M LayoutTests/ChangeLog r47171 = 5d54d4d1aa0dd34b843952ff291dcdbf59c39a24 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47171 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:00:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:00:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813010053.BDA0234C6196@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #10 from Eric Seidel 2009-08-12 18:00:52 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:04:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:04:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings In-Reply-To: References: Message-ID: <20090813010422.6774634C621C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27426 --- Comment #16 from Eric Seidel 2009-08-12 18:04:21 PDT --- A second mail was sent to webkit-dev, which is public. https://lists.webkit.org/pipermail/webkit-dev/2009-August/009456.html The first mail, mentioned above, was not a technical discussion, but rather a private disparagement for having spammed the patch system. :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:07:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:07:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090813010755.B83D634C6284@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34618|review+, commit-queue+ | Flag| | --- Comment #9 from Eric Seidel 2009-08-12 18:07:54 PDT --- (From update of attachment 34618) Clearing flags on attachment: 34618 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/canvas/canvas-zoom.html M WebCore/ChangeLog M WebCore/rendering/RenderHTMLCanvas.cpp M WebCore/rendering/RenderReplaced.cpp Committed r47172 M WebCore/ChangeLog M WebCore/rendering/RenderHTMLCanvas.cpp M WebCore/rendering/RenderReplaced.cpp M LayoutTests/ChangeLog A LayoutTests/fast/canvas/canvas-zoom.html r47172 = 02e5f59486ffcc081f9d82d6bc99a675c2fbe394 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47172 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:08:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:08:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090813010800.1A5C634C629A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #10 from Eric Seidel 2009-08-12 18:07:58 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:13:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:13:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28242] New: [Qt] Crash when performing XHR preflight request Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28242 Summary: [Qt] Crash when performing XHR preflight request Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yael.aharon at nokia.com QtNetwork does not yet support the HTTP method Options, thus a crash occurs when an Options request is made during XHR preflight request. A patch with a temporary fix will be attached soon, to prevent the crash, until QtNetwork does start supporting Options method. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:17:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:17:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28242] [Qt] Crash when performing XHR preflight request In-Reply-To: References: Message-ID: <20090813011754.BD09234C6390@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28242 --- Comment #1 from Yael 2009-08-12 18:17:54 PDT --- Sample test page to reproduce the crash. (should be loaded from the web)

    send XHR

    -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:32:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:32:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27596] Inspector: Console Object Property Subtitle's Display Poorly In-Reply-To: References: Message-ID: <20090813013231.BC04834C64D5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27596 --- Comment #3 from Timothy Hatcher 2009-08-12 18:32:31 PDT --- I see, these are ugly and bad. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:36:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:36:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25524] [Gtk] Expose the title attribute to assistive technologies In-Reply-To: References: Message-ID: <20090813013644.1F79B34C6541@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25524 --- Comment #22 from Gustavo Noronha (kov) 2009-08-12 18:36:41 PDT --- (In reply to comment #21) > (In reply to comment #19) > > I'm not familiar with the WebKit regression tests or what's being done in terms > > of WebKitGtk+ accessibility versus platform-independent accessibility, so I'll > > leave it to someone else to comment. > > > > Thanks! > > About this particular bit... we want to be able to run all crossplatform tests > (when bug #25989 is fixed), and we also have some gtk+ specific tests in place > to test our own stuff (for example, I added tests to check that we do the right > thing for the ATK get_text_{at,after,before}_offset methods). In this > particular case it looks like we want to modify the crossplatform behavior, so > we'd need to change the crossplatform tests if we convince everyone else. Though I think it would be OK to ifdef this specific case, if we agree to disagree on this, and keep these themes skipped in GTK+, having GTK+-specific tests instead. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:46:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:46:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28244] New: Logout doesn't work for some sites Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28244 Summary: Logout doesn't work for some sites Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: timmc at microsoft.com On SharePoint and as demonstrated by many posts on the web, Safari has problem handling the logout process for many websites: http://www.the-art-of-web.com/system/safari-broken-logout/ http://bbpress.org/forums/topic/safari-cant-log-out http://www.hostmonsterforum.com/showthread.php?t=5887 http://drupal.org/node/217482 It appears as though Safari is not consistent about refreshing credentials for 401 responses or HTTP Connection: Close. http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.10 I was unable to find related bugs in the database. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 18:49:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 18:49:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28211] Can't click and drag the media controller thumb In-Reply-To: References: Message-ID: <20090813014906.7396B34C6679@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28211 Dmitry Titov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dimich at chromium.org --- Comment #11 from Dmitry Titov 2009-08-12 18:49:04 PDT --- It turned out that expected.txt is different for windows so landed http://trac.webkit.org/changeset/47174 to split the results. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 19:58:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 19:58:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP In-Reply-To: References: Message-ID: <20090813025850.5DB1734C6BFB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23727 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #33 from George Staikos 2009-08-12 19:58:48 PDT --- Checked in as r47176. If the CSSValueKeywords.in change is an issue, we should back it out and find a solution but right now I can't find a reason against it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 19:59:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 19:59:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28242] [Qt] Crash when performing XHR preflight request In-Reply-To: References: Message-ID: <20090813025940.7812F34C6C0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28242 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE --- Comment #2 from Yael 2009-08-12 19:59:40 PDT --- This crash was actually fixed already. Marking this bug as duplicate. *** This bug has been marked as a duplicate of bug 26969 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 19:59:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 19:59:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26969] Fix ASSERT in WebCore::DocumentThreadableLoader::didFail In-Reply-To: References: Message-ID: <20090813025942.796BC34C6C27@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26969 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yael.aharon at nokia.com --- Comment #11 from Yael 2009-08-12 19:59:40 PDT --- *** Bug 28242 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 20:01:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 20:01:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28232] "Null after navigation" in major-objects.html is unclear In-Reply-To: References: Message-ID: <20090813030125.B93A934C6C4F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28232 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34693|review? |review+ Flag| | --- Comment #2 from Adam Barth 2009-08-12 20:01:24 PDT --- (From update of attachment 34693) Excellent! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 20:04:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 20:04:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28239] bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode In-Reply-To: References: Message-ID: <20090813030412.B0E3034C6C81@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28239 --- Comment #1 from Adam Barth 2009-08-12 20:04:11 PDT --- Sorry. I should caught that when reviewing the earlier change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 20:41:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 20:41:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28196] Chromium: Show a "Playback Disabled" button on media error. In-Reply-To: References: Message-ID: <20090813034130.3574C34C6FAC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28196 --- Comment #10 from David Levin 2009-08-12 20:41:27 PDT --- Kyle, I think you fixed this issue :"It should have WebCore/ prefixed before each file." by hand, which is ok but you need to fix every file name, Note that there is --- ChangeLog (revision 47069) +++ ChangeLog (working copy) in the patch, for example. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:32:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:32:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28245] New: findNextLineBreak crashes when inserting a blank span in front of a long line Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28245 Summary: findNextLineBreak crashes when inserting a blank span in front of a long line Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: parmanoir at gmail.com Created an attachment (id=34714) --> (https://bugs.webkit.org/attachment.cgi?id=34714) Test case, will crash nightly when clicking the button When using range.insertNode to add a SPAN in a DIV containing repeating non-breaking characters and a line break, Safari crashes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:34:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:34:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28245] findNextLineBreak crashes when inserting a blank span in front of a long line In-Reply-To: References: Message-ID: <20090813043430.BF62E34C747F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28245 --- Comment #1 from Patrick Geiller 2009-08-12 21:34:30 PDT --- bug #18282 also crashes in findNextLineBreak, but with a different stack trace. Here's this bug's stack trace. 0 com.apple.WebCore 0x0145bd75 WebCore::RenderBlock::findNextLineBreak(WebCore::BidiResolver&, bool, bool&, bool&, WebCore::EClear*) + 5445 1 com.apple.WebCore 0x0145dce4 WebCore::RenderBlock::layoutInlineChildren(bool, int&, int&) + 2180 2 com.apple.WebCore 0x01451e0a WebCore::RenderBlock::layoutBlock(bool) + 570 3 com.apple.WebCore 0x01443778 WebCore::RenderBlock::layout() + 40 4 com.apple.WebCore 0x01451352 WebCore::RenderBlock::layoutBlockChildren(bool, int&) + 914 5 com.apple.WebCore 0x014522dc WebCore::RenderBlock::layoutBlock(bool) + 1804 6 com.apple.WebCore 0x01443778 WebCore::RenderBlock::layout() + 40 7 com.apple.WebCore 0x01451352 WebCore::RenderBlock::layoutBlockChildren(bool, int&) + 914 8 com.apple.WebCore 0x014522dc WebCore::RenderBlock::layoutBlock(bool) + 1804 9 com.apple.WebCore 0x01443778 WebCore::RenderBlock::layout() + 40 10 com.apple.WebCore 0x01451352 WebCore::RenderBlock::layoutBlockChildren(bool, int&) + 914 11 com.apple.WebCore 0x014522dc WebCore::RenderBlock::layoutBlock(bool) + 1804 12 com.apple.WebCore 0x01443778 WebCore::RenderBlock::layout() + 40 13 com.apple.WebCore 0x01451352 WebCore::RenderBlock::layoutBlockChildren(bool, int&) + 914 14 com.apple.WebCore 0x014522dc WebCore::RenderBlock::layoutBlock(bool) + 1804 15 com.apple.WebCore 0x01443778 WebCore::RenderBlock::layout() + 40 16 com.apple.WebCore 0x014f8b6a WebCore::RenderView::layout() + 250 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:42:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:42:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28246] New: [Qt] storage/SQLTransactionCoordinator.[h, cpp] not in WebCore.pro Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28246 Summary: [Qt] storage/SQLTransactionCoordinator.[h,cpp] not in WebCore.pro Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: george.wright at torchmobile.com WebKitQt fails 15 storage tests as changeset #47170 for bug #27966 omitted the entries for storage/SQLTransactionCoordinator.cpp and storage/SQLTransactionCoordinator.h in WebCore.pro. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:44:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:44:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28246] [Qt] storage/SQLTransactionCoordinator.[h, cpp] not in WebCore.pro In-Reply-To: References: Message-ID: <20090813044455.9862B34C756F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28246 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34715| |review? Flag| | --- Comment #1 from George Wright 2009-08-12 21:44:55 PDT --- Created an attachment (id=34715) --> (https://bugs.webkit.org/attachment.cgi?id=34715) Amend WebCore.pro This patch adds storage/SQLTransactionCoordinator.cpp and storage/SQLTransactionCoordinator.h to WebCore.pro. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:45:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:45:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28246] [Qt] storage/SQLTransactionCoordinator.[h, cpp] not in WebCore.pro In-Reply-To: References: Message-ID: <20090813044537.C4B1534C7583@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28246 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34715|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:45:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:45:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813044553.920E434C7589@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #12 from Luke Smith 2009-08-12 21:45:52 PDT --- I was unaware of this feature until reading your comment. This behavior is not in the spec. section 9.11 specifies IsCallable If the argument object has an [[Call]] internal method, then return true, otherwise return false. The only references in the spec to setting the [[Call]] internal method are 13.2 Creating Function objects 13.2.3 The [[ThrowTypeError]] Function Object 15.3.4.5 Function.prototype.bind (thisArg [, arg1 [, arg2, …]]) Section 15.10.6, defining RegExp, states The value of the [[Prototype]] internal property of the RegExp prototype object is the standard built-in Object prototype object (15.2.4) I found that /a/("abc") is implemented (inconsistently) in Firefox 3.0, Firefox 3.5, Safari 3.2.1, Safari 4, Opera 9.6.3, Opera 10 beta2, Chrome 3 beta, and the WebKit nightlies. It is not implemented in IE6, IE7, IE8, or Chrome 2. Mozilla identifies this feature as a JavaScript extension https://developer.mozilla.org/en/Core_JavaScript_1.5_Reference/Global_Objects/RegExp#RegExp_instances I infer that such is the case for the others, WebKit included. The difference here being that the other browser vendors prevent the spec deviation from rippling through their implementation to (at least) typeof and recently to JSON.stringify. Currently native JSON support is present in Firefox 3.5, IE8, Chrome 3 beta, and recent WebKit nightlies. All three of the other currently implementing browsers agree both that typeof /a/ == 'object' and JSON.stringify(/a/) == '{}'. There is value in interoperability. If not typeof, please at least stringify RegExp instances as objects for the sake of convention. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:47:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:47:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28246] [Qt] storage/SQLTransactionCoordinator.[h, cpp] not in WebCore.pro In-Reply-To: References: Message-ID: <20090813044704.0EA6434C75A5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28246 George Staikos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |staikos at kde.org Resolution| |FIXED --- Comment #2 from George Staikos 2009-08-12 21:47:03 PDT --- Checked in r47180 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 21:52:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 21:52:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27202] Inspector: Cookies in Storage Panel In-Reply-To: References: Message-ID: <20090813045238.797E634C762B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27202 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |abarth at webkit.org Resolution| |FIXED --- Comment #15 from Adam Barth 2009-08-12 21:52:36 PDT --- http://trac.webkit.org/changeset/47181 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:00:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:00:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28232] "Null after navigation" in major-objects.html is unclear In-Reply-To: References: Message-ID: <20090813050055.602D434C76D4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28232 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34693|review+ | Flag| | --- Comment #3 from Adam Barth 2009-08-12 22:00:54 PDT --- (From update of attachment 34693) Clearing flags on attachment: 34693 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitSite/ChangeLog M WebKitSite/coding/major-objects.html Committed r47182 M WebKitSite/ChangeLog M WebKitSite/coding/major-objects.html r47182 = 9f401117450f829c83ec4f0940e4918f455e7d31 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47182 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:01:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:01:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28232] "Null after navigation" in major-objects.html is unclear In-Reply-To: References: Message-ID: <20090813050107.A787234C76E4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28232 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from Adam Barth 2009-08-12 22:01:06 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:23:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:23:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28174] Profile view status bar buttons are blank In-Reply-To: References: Message-ID: <20090813052351.80A5334C7884@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28174 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck02 at gmail.com --- Comment #4 from Joseph Pecoraro 2009-08-12 22:23:51 PDT --- Mikhail this is pretty awesome! Heads up on a few other buttons. - delete button in DOMStorageItemsView.js. - delete button in CookieItemsView.js. (just added) The Refresh button has not yet been converted to a glyph, but both of those files have a refresh button as well if you feel they are applicable. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:26:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:26:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813052610.A1C3F34C78B6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #13 from Oliver Hunt 2009-08-12 22:26:10 PDT --- > Currently native JSON support is present in Firefox 3.5, IE8, Chrome 3 beta, > and recent WebKit nightlies. All three of the other currently implementing > browsers agree both that typeof /a/ == 'object' and JSON.stringify(/a/) == > '{}'. There is value in interoperability. If not typeof, please at least > stringify RegExp instances as objects for the sake of convention. RegExps are callable -- breaking this would break compatibility with json2.js, and the bug is in mozilla for not correctly treating a callable object as callable. We cannot reasonably serialise regexps as standard objects -- the bug is in firefox, not webkit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:28:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:28:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28209] Restrict use of FuncDeclNode & FuncExprNode to the parser. In-Reply-To: References: Message-ID: <20090813052856.DCE2634C78FA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28209 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #12 from Gavin Barraclough 2009-08-12 22:28:55 PDT --- Sorry about that, should be fixed now in r47183. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:30:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:30:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090813053058.60D7334C7944@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34641|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:45:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:45:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28174] Profile view status bar buttons are blank In-Reply-To: References: Message-ID: <20090813054547.B7B8334C7A71@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28174 --- Comment #5 from Pavel Feldman 2009-08-12 22:45:47 PDT --- > The Refresh button has not yet been converted to a glyph, but both of those > files have a refresh button as well if you feel they are applicable. There is an Images/reloadButtonGlyph.png in place, it is just that .refresh-storage-status-bar-item was not updated to use it. Mikhail, could you add the fix into your patch? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:49:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:49:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28247] New: [Chromium] Numpad keys and a manu key don't work in render view Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28247 Summary: [Chromium] Numpad keys and a manu key don't work in render view Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hbono at chromium.org CC: evan at chromium.org, estade at chromium.org (Copied from .) Chrome Version : 3.0.197.11-r22553 OS + version : Debian Lenny CPU architecture (32-bit / 64-bit): 32 window manager : KDE URLs (if applicable) : Behavior in Firefox 3.x (if applicable): Numpad arrow keys work Behavior in Chrome for Windows (optional): Numpad arrow keys work Goto to any page and just try to use the numpad keys to navigate (with the NumLock off). They don't work. They DO however work in the address bar. The numpad arrows work in all other applications, including GTK ones (e.g. Firefox). Please provide any additional information below. Attach a screenshot and backtrace if possible. WebCore::windowsKeyCodeForKeyEvent() (in "WebCore/platform/chromium/KeyCodeConversionGtk.cpp") doesn't have mappings for many numpad keys (e.g. GDK_KP_Up, GDK_KP_Down, etc.) and cannot send numpad-key events to a web page. Neither does "WebCore/platform/gtk/KeyEventGdk.cpp" have them. Also, they map GDK_Menu to VKEY_MENU, which is a virtual key-code for alt keys. To improve compatibility with Windows, it is better to map GDK_Menu to VKEY_APPS, which is a virtual key-code for a menu key. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:49:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:49:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27734] WINCE PORT: font related changes In-Reply-To: References: Message-ID: <20090813054909.CA51A34C7AEC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27734 Joe Mason changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34307|0 |1 is obsolete| | Attachment #34716| |review? Flag| | --- Comment #30 from Joe Mason 2009-08-12 22:49:08 PDT --- Created an attachment (id=34716) --> (https://bugs.webkit.org/attachment.cgi?id=34716) build fixes and minor bug fixes, with more comments > Are you sure that min will compile on other platforms? I feel like we've > dealt with the min/max issue on windows before in other ways. Please grep the > source to see how it's dealt with elsewhere. The more common methods of dealing with the windows min/max macros won't work here because the two parameters to min have different types (int and UChar32), so Windows gives an error about ambiguous template parameters. min will definitely compile on other platforms (it's just giving the template parameter explicitly instead of letting the compiler work it out), but I changed the fix anyway because I felt it was clearer - now it explicitly casts the UChar32 to an int. > This needs a why comment: > 29 #if !PLATFORM(WINCE) > 227230 mutable SCRIPT_CACHE m_scriptCache; > 228231 mutable SCRIPT_FONTPROPERTIES* m_scriptFontProperties; > 229232 #endif > your note about it saving space in the ChangeLog is a fine comment, just put it > in teh soruce code too. Done. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 22:58:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 22:58:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24986] [multi-patch] ARM JIT port In-Reply-To: References: Message-ID: <20090813055853.E065734C7C38@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24986 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #103 from Gavin Barraclough 2009-08-12 22:58:46 PDT --- Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/ARMAssembler.cpp Sending JavaScriptCore/assembler/ARMAssembler.h Sending JavaScriptCore/assembler/ARMv7Assembler.h Sending JavaScriptCore/assembler/AbstractMacroAssembler.h Sending JavaScriptCore/assembler/AssemblerBufferWithConstantPool.h Sending JavaScriptCore/assembler/MacroAssemblerARM.h Sending JavaScriptCore/assembler/X86Assembler.h Sending JavaScriptCore/jit/JIT.h Sending JavaScriptCore/jit/JITCall.cpp Sending JavaScriptCore/jit/JITInlineMethods.h Sending JavaScriptCore/jit/JITPropertyAccess.cpp Transmitting file data ............ Committed revision 47186. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 23:08:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 23:08:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27827] [Chromium] Functions Keys don't work in google spreadsheet. In-Reply-To: References: Message-ID: <20090813060844.E48B734C7D0B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27827 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34444|review? |review- Flag| | --- Comment #5 from Eric Seidel 2009-08-12 23:08:42 PDT --- (From update of attachment 34444) Looks fine. Except the results should not be in platform/mac, but rather right next to the test. At least I don't think this test is platform specific, is it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 23:26:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 23:26:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813062638.395C034C7E7D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #14 from Luke Smith 2009-08-12 23:26:37 PDT --- > breaking this would break compatibility with json2.js Can you explain this? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 23:45:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 23:45:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813064540.E5ABE34C7FF0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 Raphael Speyer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rspeyer at gmail.com --- Comment #15 from Raphael Speyer 2009-08-12 23:45:40 PDT --- (In reply to comment #13) > RegExps are callable -- breaking this would break compatibility with json2.js, > and the bug is in mozilla for not correctly treating a callable object as > callable. I think there is an important distinction between a vendor extension to EcmaScript to allow an object to be treated as a function, and the meaning of IsCallable in the spec. As Luke mentioned above, according to the spec, a IsCallable is false for RegExp's, and thus they should be serialised by JSON.stringify, in 15.12.3 step 10. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Wed Aug 12 23:48:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Wed, 12 Aug 2009 23:48:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813064833.3212A34C8038@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #16 from Raphael Speyer 2009-08-12 23:48:32 PDT --- (In reply to comment #15) > As Luke mentioned above, according to the spec, a IsCallable is false for > RegExp's, and thus they should be serialised by JSON.stringify, in 15.12.3 step > 10. That is, step 10 of the Str operation. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:07:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:07:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28212] rename make-js-test-wrappers to make-script-test-wrappers In-Reply-To: References: Message-ID: <20090813070709.30D1434C826A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28212 --- Comment #6 from Shinichiro Hamaji 2009-08-13 00:07:08 PDT --- (In reply to comment #5) > (From update of attachment 34638 [details]) > Nm, I'll leave this for Shinichiro to commit. I still don't have committer access. It's taking surprisingly long time due to several reason... So, could someone check this in? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:19:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:19:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813071921.D551E34C8372@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #17 from Oliver Hunt 2009-08-13 00:19:20 PDT --- (In reply to comment #16) > (In reply to comment #15) > > > As Luke mentioned above, according to the spec, a IsCallable is false for > > RegExp's, and thus they should be serialised by JSON.stringify, in 15.12.3 step > > 10. > > That is, step 10 of the Str operation. json2.js uses typeof holder === "function" to determine whether an object IsCallable, and regexp instances have the type "function". This is correct behaviour, per ES5 (from ES262, v5, 11.4.3) Object (native and doesn‘t implement [[Call]]) -> "object" Object (native or host and implements [[Call]]) -> "function" IsCallable is defined in section 9.11: If the argument object has an [[Call]] internal method, then return true, otherwise return false. In other words, a RegExp instance has [[Call]] so typeof should be "function", and [[IsCallable]] is true. You seem to believe that there is value in serialising a regexp object, when there is not -- a serialised regexp object is either undefined (in conforming implementations in which regexps are callable) or as the empty object {} (in conforming implementations in whichs regexps are not callable). Firefox is not conforming in this regard. Arguing will not accopmlish anything as it is pointless to add a slow check which will break behaviour relative to json2, just to handle the specific case of RegExps, when there are numerous other disagreements between different runtimes as to which objects are callable (NodeLists anyone?), especially given the serialisation of RegExps is unhelpful in either case. If you feel really strongly about this, i suggest you go to http://bugs.mozilla.org and file a bug on the spidermonkey RegExp object incorrectly reporting typeof as "object" and claiming not to be callable. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:23:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:23:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code In-Reply-To: References: Message-ID: <20090813072337.6BB3034C83D4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27967 --- Comment #11 from Michael Nordman 2009-08-13 00:23:35 PDT --- 187 'storage/SQLTransactionClientImpl.cpp', Some of the make files make reference to SQLTransactionClientImpl.cpp, did you mean SQLTransactionClient.cpp here? 330 m_transactionClient->databaseSizeChanged(m_database.get()); So this method is invoked on the background db thread. 392 m_shouldRetryCurrentStatement = m_transactionClient->databaseExceedsQuota(...); And this one on the 'apartment' thread of the Database object (the main thread) 426 m_transactionClient->databaseChanged(m_database.get()); And this one on the background thread I would appreciate some indication of the threading usage in the SQLTransactionListener source files. To figure out how it was used, i had to track down the callsites. Not sure how to best indicate the threading rules... either doc comments in the .h file, or runtime asserts in the .cpp file? 38 // A "listener" interface to the SQLTransaction class. Allows 39 // SQLTransaction to notify interested parties when certain things are 40 // happening in a transaction. 41 class SQLTransactionClient { 42 public: 43 // Notifies everybody that the database has changed. Called at the end 44 // end of every successful transaction. 45 void databaseChanged(Database*); 46 47 // Notifies everybody that the size of the database file might have changed. 48 // Called after executing each statement in a transaction 49 void databaseSizeChanged(Database*); 50 51 // Notifies everybody that the size of the database file exceeds its quota. 52 // If this method returns true, the current statement in the transaction is 53 // retried. Otherwise, the transaction is rolled back. 54 // 55 // This method should return true if and only if the quota for this database 56 // file was increased (by the user, for example) since calling this method. 57 bool databaseExceedsQuota(Database*); 58 }; 59 } After reading your doc comments, maybe these methods could be renamed for clarity. void didCommitTransaction(...); // for databaseChanged void didExecuteStatement(...); // for databaseSizeChanged bool didExceedQuota(...); // for databaseExceedsQuota And would it make sense to have the SQLTransaction* be the parameter since it is a transaction listener, the caller can get the Database* from the accessor on the transaction object (i think). Also, the new class (TransactionCoordinator) you just added is also a transaction listener of sorts. Should these two classes be merged? The TransactionCoordinator must be owned by the DBThread to properly serve its purpose. In this patch, you have the new 'listener' object being owned by the Database object, but i think it could just as easily be owned by the DBThread and serve its purpose. Wdyt? 60 RefPtr origin = database->securityOriginCopy(); Making a copy of a refcounted object looks odd? Is it mutable? Is there no database->securityOrigin() accessor? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:35:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:35:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27768] SVG feComponentTransfer needs to be implemented In-Reply-To: References: Message-ID: <20090813073530.2527334C850A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27768 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34427|review? | Flag| | --- Comment #5 from Dirk Schulze 2009-08-13 00:35:28 PDT --- (From update of attachment 34427) clearing review tag. I'll upload a more efficient version after the patch on bug 28133 is ready. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:52:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:52:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28248] New: Reloading frames in Safari 4 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28248 Summary: Reloading frames in Safari 4 Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Frames AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: igd at methyl.demon.co.uk Reloading frames in Safari 4.0.3 still does not work correctly. Try this: 1. Go to the following frames-based test site: http://methyl1.demonweb.co.uk/safari4/safari.html 2. The site opens with the RED page on the right. 3. Click the 'BLUE PAGE' link as an example. 4. When the 'BLUE' page has loaded, click the 'Reload' button. The 'BLUE' page does NOT reload; instead we are taken back to the original 'RED' page !! Reloading these pages works perfectly well in Safari 3 and all other browsers. I have reported this bug to Apple several times but to no avail. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:56:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:56:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28117] Native JSON.stringify does not omit functions In-Reply-To: References: Message-ID: <20090813075618.35BBD34C86C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28117 --- Comment #18 from Raphael Speyer 2009-08-13 00:56:17 PDT --- (In reply to comment #17) > > json2.js uses typeof holder === "function" to determine whether an object > IsCallable, That seems reasonable to me. > and regexp instances have the type "function". I think this is the crux of the issue. I know that webkit gives typeof /a/ === 'function', but I don't understand why. The spec does not say anywhere that a RegExp defines the internal property [[Call]]. > This is correct > behaviour, per ES5 (from ES262, v5, 11.4.3) > Object (native and doesn‘t implement [[Call]]) -> "object" > Object (native or host and implements [[Call]]) -> "function" > Exactly. So, wouldn't RegExp's fall into the first category? Yes, they can be treated as functions, but that's a particular vendor extension, it's not how RegExp instances are specified to behave. > IsCallable is defined in section 9.11: > If the argument object has an [[Call]] internal method, then return true, > otherwise > return false. Right, and again, as per the spec, a RegExp does not have a [[Call]] internal method. > > In other words, a RegExp instance has [[Call]] so typeof should be "function", > and [[IsCallable]] is true. > I think we forked back at /a/('a') implying that at a specification level, [[Call]] is defined for RegExp's. > You seem to believe that there is value in serialising a regexp object, when > there is not -- a serialised regexp object is either undefined (in conforming > implementations in which regexps are callable) or as the empty object {} (in > conforming implementations in whichs regexps are not callable). > Granted, it's not going to be typical, and I can't actually think of a very good use case for it myself. However enumerable properties can be defined on RegExp's or their prototype, as can the toJSON method. I think this is more about conformance with the spec. > Firefox is not conforming in this regard. Arguing will not accopmlish anything > as it is pointless to add a slow check which will break behaviour relative to > json2, just to handle the specific case of RegExps, when there are numerous > other disagreements between different runtimes as to which objects are callable > (NodeLists anyone?), especially given the serialisation of RegExps is unhelpful > in either case. > > If you feel really strongly about this, i suggest you go to > http://bugs.mozilla.org and file a bug on the spidermonkey RegExp object > incorrectly reporting typeof as "object" and claiming not to be callable. Well, as I said above, as far as I can tell, the spec says that RegExp is not callable, in the sense that the internal [[Call]] property is not defined, IsCallable will return false and thus at the language level, typeof should return 'object', and stringify should not ignore it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Thu Aug 13 00:58:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Thu, 13 Aug 2009 00:58:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28249] New: Missing controls in element seem to be inerited by its
    elements, even if the td-backgrounds are explicitely set to transparent. Firefox/Opera don't share this behaviour (see attached file for example). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 04:37:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 04:37:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28300] New: [ARM] Generic ARM and ARMv7 platforms should use JSVALUE32 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28300 Summary: [ARM] Generic ARM and ARMv7 platforms should use JSVALUE32 Product: WebKit Version: 528+ (Nightly build) Platform: Other OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: loki at inf.u-szeged.hu Currently generic ARM and ARMv7 platforms work only with JSVALUE32. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 04:39:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 04:39:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28300] [ARM] Generic ARM and ARMv7 platforms should use JSVALUE32 In-Reply-To: References: Message-ID: <20090814113952.45D9434E0A47@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28300 Gabor Loki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34828| |review? Flag| | --- Comment #1 from Gabor Loki 2009-08-14 04:39:51 PDT --- Created an attachment (id=34828) --> (https://bugs.webkit.org/attachment.cgi?id=34828) Set JSVALUE32 for generic ARM as well -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 04:43:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 04:43:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090814114339.B871F34E0AA6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 --- Comment #6 from Janne Koskinen 2009-08-14 04:43:38 PDT --- Getting there.. It is not the make_pair function that fails, but the HashMap::Contains(). in WTF/StructureTransitionTable.h we define our HashTable to be type: typedef HashMap StructureTransitionTable; where the StructureTransitionTableHashTraits' SecondFirstTraits::TraitType is unsigned. Looks like temporary pair is getting generated with unknown type. From illegal operand we can gather that this is not integer type.I looked at HashTraits.h to see if there was an obvious reason, but cold code reading doesn't help at this point. Unfortunately I don't have src for std so my debugging/preprocessing is limited here. Again casting to unsigned is the easiest way to fix this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 04:49:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 04:49:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28300] [ARM] Generic ARM and ARMv7 platforms should use JSVALUE32 In-Reply-To: References: Message-ID: <20090814114913.B80AF34E0B3C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28300 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34828|review? |review+ Flag| | --- Comment #2 from Simon Hausmann 2009-08-14 04:49:13 PDT --- (From update of attachment 34828) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 04:50:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 04:50:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28300] [ARM] Generic ARM and ARMv7 platforms should use JSVALUE32 In-Reply-To: References: Message-ID: <20090814115008.78D7834E0B64@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28300 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |hausmann at webkit.org Resolution| |FIXED --- Comment #3 from Simon Hausmann 2009-08-14 04:50:07 PDT --- Landed in r47278 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:05:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:05:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090814120527.0919834E0C92@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34538|0 |1 is obsolete| | Attachment #34829| |review? Flag| | --- Comment #18 from Laszlo Gombos 2009-08-14 05:05:25 PDT --- Created an attachment (id=34829) --> (https://bugs.webkit.org/attachment.cgi?id=34829) 5th try Disables LocalStorage for QtWebKit by default by setting QWebSettings::LocalStorageEnabled to false. Sets up a default for the LocalStorage path so that clients would only need to enable the LocalStorageEnabled setting to turn on LocalStoragre support. Turn on LocalStorage support for QtLauncher and the relevant test since LocalStorage is now disabled by default for QtWebkit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:29:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:29:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28301] New: Add our blog to Planet WebKit Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28301 Summary: Add our blog to Planet WebKit Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Website AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: oszi at inf.u-szeged.hu Add the WebKit blog of the University of Szeged to Planet WebKit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:32:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:32:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28301] Add our blog to Planet WebKit In-Reply-To: References: Message-ID: <20090814123220.661C234E0F3F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28301 Csaba Osztrogonác changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34830| |review? Flag| | --- Comment #1 from Csaba Osztrogonác 2009-08-14 05:32:19 PDT --- Created an attachment (id=34830) --> (https://bugs.webkit.org/attachment.cgi?id=34830) proposed patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:40:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:40:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists In-Reply-To: References: Message-ID: <20090814124049.34E2334E0FF7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27551 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34831| |review?(mrowe at apple.com) Flag| | --- Comment #21 from Simon Hausmann 2009-08-14 05:40:47 PDT --- Created an attachment (id=34831) --> (https://bugs.webkit.org/attachment.cgi?id=34831) Patch to remove unused WEBKIT_EXPORTDATA macro This patch removes the unused WEBKIT_EXPORTDATA macro. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:41:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:41:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists In-Reply-To: References: Message-ID: <20090814124152.BDC8334E1020@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27551 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33627|0 |1 is obsolete| | Attachment #34737|0 |1 is obsolete| | --- Comment #22 from Simon Hausmann 2009-08-14 05:41:52 PDT --- Created an attachment (id=34832) --> (https://bugs.webkit.org/attachment.cgi?id=34832) Rebased patch to build JSC with JS_EXPORT_PRIVATE to export symbols -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:42:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:42:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists In-Reply-To: References: Message-ID: <20090814124208.0AB1D34E1036@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27551 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34832| |review?(mrowe at apple.com) Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:45:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:45:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists In-Reply-To: References: Message-ID: <20090814124505.78EAC34E107A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27551 --- Comment #23 from Simon Hausmann 2009-08-14 05:45:04 PDT --- (In reply to comment #18) > (From update of attachment 33773 [details]) > A couple of concerns and comments: > JS_EXPORTDATA is a confusing choice of name when the majority of things being > exported are functions. I agree. I've uploaded an updated patch that replaces JS_EXPORTDATA with JS_EXPORT_PRIVATE, for consistency with the existing JS_EXPORT for the public C API. > There are a number of places that an entire class has been marked as being > exported even though only a single symbol is currently listed in > JavaScriptCore.exp and JavaScriptCore.def. ByteCodeGenerator, Parser and > ParserArena are the three that jump out at me for this reason. Yes, it appears a lot simpler and less cluttering to the source code to annotate the class instead of every used function with the export macro. > It's not clear why WEBKIT_EXPORTDATA exists. It doesn't seem to be used > anywhere. Well spotted :). I've attached a patch to remove this macro alltogether. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:50:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:50:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] [Qt] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090814125034.83F6534E10FF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34804|review?(hausmann at webkit.org | Flag|) | Attachment #34804|0 |1 is obsolete| | Attachment #34833| |review?(hausmann at webkit.org Flag| |) --- Comment #5 from Yael 2009-08-14 05:50:32 PDT --- Created an attachment (id=34833) --> (https://bugs.webkit.org/attachment.cgi?id=34833) Patch Added additional automated test at Ariya's request. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:52:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:52:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28301] Add our blog to Planet WebKit In-Reply-To: References: Message-ID: <20090814125255.D6FC534E113D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28301 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34830|review? |review+ Flag| | --- Comment #2 from Simon Hausmann 2009-08-14 05:52:55 PDT --- (From update of attachment 34830) r=me, Welcome to the Planet! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 05:54:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 05:54:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28301] Add our blog to Planet WebKit In-Reply-To: References: Message-ID: <20090814125441.C863134E11AA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28301 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |hausmann at webkit.org Resolution| |FIXED --- Comment #3 from Simon Hausmann 2009-08-14 05:54:41 PDT --- Landed in r47281 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:00:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:00:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814130052.6A76134E123F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34776|0 |1 is obsolete| | Attachment #34834| |review? Flag| | --- Comment #13 from Mike Fenton 2009-08-14 06:00:51 PDT --- Created an attachment (id=34834) --> (https://bugs.webkit.org/attachment.cgi?id=34834) Fix Changelog from in patch #34776 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:18:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:18:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814131814.AB5E334E13B8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34777|0 |1 is obsolete| | Attachment #34835| |review? Flag| | --- Comment #14 from Mike Fenton 2009-08-14 06:18:13 PDT --- Created an attachment (id=34835) --> (https://bugs.webkit.org/attachment.cgi?id=34835) Patch for GraphicsContextCG.cpp to use adjustLineToPixelBoundaries to replace duplicated code. Note: This patch is dependent on attachment 34767 in this bug. Patch for GraphicsContextCG.cpp to use adjustLineToPixelBoundaries to replace duplicated code. Note: This patch is dependent on attachment 34767 in this bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:21:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:21:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28302] New: WebInspector: Minor DOMAgent bugfixes. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28302 Summary: WebInspector: Minor DOMAgent bugfixes. Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pfeldman at chromium.org CC: timothy at hatcher.name 1. Fix document.documentElement value 2. Node binding is now 1-based 3. Add guard to focused node updated. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:24:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:24:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28258] [Haiku] Adding RenderTheme to WebCore. In-Reply-To: References: Message-ID: <20090814132401.1CD5B34E1456@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28258 --- Comment #5 from Maxime Simon 2009-08-14 06:23:58 PDT --- (In reply to comment #2) > (From update of attachment 34738 [details]) > This will error out if -wunused is on: > 41 virtual bool supportsHover(const RenderStyle* style) const { return > false; } Actually, with the "-Wall" and "-Wextra" flags I didn't get the error you specified. But when I merged this patch with the version of RenderThemeHaiku I have in my local branch, I got many problems. Looks like I posted the wrong patch ( an old version ). I noticed things like: - "RenderThemeHaiku::function(…" in the header, - "virtual void RenderThemeHaiku::function(…" in the cpp file, - or even "void function(…" in the cpp code for a method of the class. Indeed I can promptly submit another patch to avoid these stupidities. But I should be blamed to not re-read attentively my patch before posting it. Regards, Maxime -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:24:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:24:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28302] WebInspector: Minor DOMAgent bugfixes. In-Reply-To: References: Message-ID: <20090814132427.379EC34E1475@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28302 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34836| |review? Flag| | Status|UNCONFIRMED |ASSIGNED AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | Ever Confirmed|0 |1 --- Comment #1 from Pavel Feldman 2009-08-14 06:24:26 PDT --- Created an attachment (id=34836) --> (https://bugs.webkit.org/attachment.cgi?id=34836) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:33:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:33:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090814133304.B619E34E152E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Laszlo Gombos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34829|review? | Flag| | Attachment #34829|0 |1 is obsolete| | Attachment #34837| |review? Flag| | --- Comment #19 from Laszlo Gombos 2009-08-14 06:33:02 PDT --- Created an attachment (id=34837) --> (https://bugs.webkit.org/attachment.cgi?id=34837) 6th try Documentation for LocalStorageEnabled now mentions that it's disabled by default Enable qdocs for setLocalStoragePath and localStoragePath. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:35:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:35:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814133506.6522234E1599@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34778|0 |1 is obsolete| | Attachment #34838| |review? Flag| | --- Comment #15 from Mike Fenton 2009-08-14 06:35:05 PDT --- Created an attachment (id=34838) --> (https://bugs.webkit.org/attachment.cgi?id=34838) Fix Changelog in patch #34778 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:35:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:35:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814133527.1168534E15A7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34834|Fix Changelog from in patch |Fix Changelog in patch description|#34776 |#34776 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:42:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:42:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28224] Web pages with SVG and map links aren't rendered correctly In-Reply-To: References: Message-ID: <20090814134238.2A56934E168C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28224 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krit at webkit.org --- Comment #1 from Dirk Schulze 2009-08-14 06:42:37 PDT --- I can see a photo of a person in the html-version. Is this the expected behavior? If so, it works for me on WebKitGtk. Which port do you use? Qt? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:49:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:49:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] New: [Qt] XSLT support with QtXmlPatterns Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28303 Summary: [Qt] XSLT support with QtXmlPatterns Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: faw217 at gmail.com Since the 4.5 release, QtXmlPatterns has supported XSLT 2.0 so it seems to be a good idea for QtWebKit to use that rather than libxslt (which in fact doesn't build now with the Qt port). http://doc.trolltech.com/4.6-snapshot/qtxmlpatterns.html#xslt-2-0 Here is an overview of how much complete the XSLT 2.0 support in QtXmlPatterns is. It's lacking some important features but making QtWebKit use that should help improve it. There is some libxml2/libxslt specific code laying around, not only in the implementations of XSLTProcessor and XSLStyleSheet but also in e.g. Document. For the former, we should provide our own separate implementations, for the latter we would need some #ifdefs. The other files/classes the Qt port doesn't need at all: - XSLImportRule: QtXmlPatterns currently doesn't support xsl:import/xsl:include but even when it does, it will most likely import documents internally (of course we would need to hook that so that we can take care of security and caching), so the XSLImportRule class we don't need. - XSLTExtensions - this is completely a libxslt specific thing, we can't add extra functionality to the QtXmlPatterns module so we don't need it either. - XSLTUnicodeSort - as above, we can't extend QXmlQuery with our own sorting functionality. If we wanted to add missing bits to the xsl:import implementation, we would have to patch QtXmlPatterns. The Qtish implementation of XSLStyleSheet would be pretty basic, we don't support child stylesheets and pre-compiling stylesheets so really there is not much what XSLStyleSheet could do apart from actually holding a stylesheet source. Currently I managed to achieve a result of ~35% passing layout tests. The rest can be skipped with notes about why they fail so they can be investigated in QtXmlPatterns. I'll post the exact results when submitting the patches. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:50:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:50:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28304] New: S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28304 Summary: S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite Product: WebKit Version: 528+ (Nightly build) Platform: S60 Hardware OS/Version: S60 3rd edition Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: Chang.Shu at nokia.com Steps to reproduce: 1.Load the page http://v8.googlecode.com/svn/data/benchmarks/v4/run.html 2.The automated tests start running. Expected result: 1.All the tests run and the score is displayed Actual result: Browser crashes around 87% complete Root cause: JavascriptCore heap memory exhausted -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 06:58:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 06:58:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] [Qt] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090814135844.74A7534E1840@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34833|review?(hausmann at webkit.org |review+ Flag|) | --- Comment #6 from Simon Hausmann 2009-08-14 06:58:43 PDT --- (From update of attachment 34833) r=me It would be nice to have \since 4.6 tags in the documentation for the new functions. If you have the time then it would also be nice to have a test that verifies that the local schemes actually work :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:02:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:02:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27658] Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects In-Reply-To: References: Message-ID: <20090814140213.0033234E1890@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27658 Neil Rhodes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33476| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:19:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:19:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090814141908.0B77C34E1A25@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34837|review? |review+ Flag| | --- Comment #20 from Simon Hausmann 2009-08-14 07:19:06 PDT --- (From update of attachment 34837) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:19:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:19:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28304] S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite In-Reply-To: References: Message-ID: <20090814141908.3F60734E1A27@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28304 Chang Shu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34839| |review? Flag| | --- Comment #1 from Chang Shu 2009-08-14 07:19:07 PDT --- Created an attachment (id=34839) --> (https://bugs.webkit.org/attachment.cgi?id=34839) This is the patch to fix the bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:21:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:21:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage In-Reply-To: References: Message-ID: <20090814142119.7BA5F34E1A8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28036 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #21 from Simon Hausmann 2009-08-14 07:21:18 PDT --- Landed in r47283 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:32:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:32:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27885] Add QNX as supported platform In-Reply-To: References: Message-ID: <20090814143206.ED47B34E1BF5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27885 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34446|review? |review+ Flag| | --- Comment #5 from Simon Hausmann 2009-08-14 07:32:05 PDT --- (From update of attachment 34446) r=me > +static inline void *currentThreadStackBaseQNX() Small coding style buglet here, but I'll fix that when landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:34:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:34:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27658] Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects In-Reply-To: References: Message-ID: <20090814143420.289EB34E1C38@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27658 --- Comment #3 from Neil Rhodes 2009-08-14 07:34:19 PDT --- Created an attachment (id=34840) --> (https://bugs.webkit.org/attachment.cgi?id=34840) Demonstrates bg 27658 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:34:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:34:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27658] Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects In-Reply-To: References: Message-ID: <20090814143451.E38A034E1C4C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27658 Neil Rhodes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34840|Demonstrates bg 27658 |badselect.html description| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:44:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:44:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27885] Add QNX as supported platform In-Reply-To: References: Message-ID: <20090814144453.F272A34E1D51@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27885 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #6 from Simon Hausmann 2009-08-14 07:44:53 PDT --- Landed in r47284 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:48:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:48:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. In-Reply-To: References: Message-ID: <20090814144843.696BE34E1DC1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28181 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34773|review? |review+ Flag| | --- Comment #11 from Simon Hausmann 2009-08-14 07:48:41 PDT --- (From update of attachment 34773) r=me I'll change the url in the comment to the upstream bug url when landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:50:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:50:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28181] RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. In-Reply-To: References: Message-ID: <20090814145035.7764C34E1E03@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28181 Simon Hausmann changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #12 from Simon Hausmann 2009-08-14 07:50:33 PDT --- Landed in r47285 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:50:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:50:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27065] Port QtWebKit to Symbian In-Reply-To: References: Message-ID: <20090814145038.0EE4534E1E1B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27065 Bug 27065 depends on bug 28181, which changed state. Bug 28181 Summary: RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. https://bugs.webkit.org/show_bug.cgi?id=28181 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:52:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:52:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28240] [Qt] Allow applications to register their own local URL scheme In-Reply-To: References: Message-ID: <20090814145251.9E40034E1E75@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28240 Yael changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #7 from Yael 2009-08-14 07:52:50 PDT --- Landed in r47282 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 07:57:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 07:57:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28305] New: When Geolocation permissions are denied, watchers are not stopped Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28305 Summary: When Geolocation permissions are denied, watchers are not stopped Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: steveblock at google.com CC: andreip at google.com, bolsinga at apple.com Currently, when Geolocation permissions are denied, only one-shots are stopped. Since permissions can not be revoked within the lifetime of the page, all requests (both one-shots and watchers) will never obtain a position fix once permissions have been denied. We should therefore stop all requests when permissions are denied. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:16:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:16:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090814151656.21F3D34E2117@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 --- Comment #16 from George Wright 2009-08-14 08:16:54 PDT --- (In reply to comment #15) > Reopening since there was a regression on the bots: > http://build.webkit.org/builders/Tiger%20Intel%20Release/builds/3425 It seems to be working again; did you roll out the patch or not? I can't see in the logs that you did. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:19:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:19:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28280] WebInspector: Evaluating objects while on a breakpoint dumps string representation instead of live object. In-Reply-To: References: Message-ID: <20090814151919.04B8734E216C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28280 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34841| |review? Flag| | --- Comment #1 from Pavel Feldman 2009-08-14 08:19:17 PDT --- Created an attachment (id=34841) --> (https://bugs.webkit.org/attachment.cgi?id=34841) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:27:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:27:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814152727.44DD134E221B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34842| |review? Flag| | --- Comment #16 from Mike Fenton 2009-08-14 08:27:26 PDT --- Created an attachment (id=34842) --> (https://bugs.webkit.org/attachment.cgi?id=34842) Patch for GraphicsContextSkia.cpp to use adjustLineToPixelBoundaries. This patch modifies drawLine in Skia to use adjustLineToPixelBoundaries and should maintain the existing functionality. Note: This patch is dependent on attachment 34767 in this bug and has not been compiled for Skia. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:29:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:29:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814152918.CFAB834E223A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34843| |review? Flag| | --- Comment #17 from Mike Fenton 2009-08-14 08:29:18 PDT --- Created an attachment (id=34843) --> (https://bugs.webkit.org/attachment.cgi?id=34843) Style patch for GraphicsContextSkia.cpp Note: This leaves the header order partially against WebKit style in order to group Skia headers. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:46:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:46:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28280] WebInspector: Evaluating objects while on a breakpoint dumps string representation instead of live object. In-Reply-To: References: Message-ID: <20090814154630.6375034E23E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28280 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34841|review? |review- Flag| | --- Comment #2 from Timothy Hatcher 2009-08-14 08:46:29 PDT --- (From update of attachment 34841) > + function(result, isException) { > + if (!isException) > + result = JSON.parse(result); > + reportCompletions(result, isException); > + }); Can you break this out into a named function so it is easier to read? It took me a second to realize this was being passed as an argument. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 08:58:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 08:58:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26908] without CSS width/height is unaffected by full page zoom In-Reply-To: References: Message-ID: <20090814155842.32BF434E2591@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26908 --- Comment #17 from Eric Seidel 2009-08-14 08:58:40 PDT --- http://trac.webkit.org/changeset/47191 was added to fix the qt bot. I did not roll your change out. I'm not sure why the bot results changed. I have not investigated. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:08:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:08:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28113] QtWebKit (using the Arora browser) displays the border radii (radius) of a button very ugly In-Reply-To: References: Message-ID: <20090814160854.BBDA434E26C7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28113 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george.wright at torchmobile.c | |om --- Comment #2 from George Wright 2009-08-14 09:08:54 PDT --- This appears to be a problem with the Qt rendering backend; it renders correctly when using the raster rendering backend. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:11:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:11:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28224] Web pages with SVG and map links aren't rendered correctly In-Reply-To: References: Message-ID: <20090814161106.232C934E2719@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28224 --- Comment #2 from Igor Bronshteyn 2009-08-14 09:11:05 PDT --- I can see this photo neither in Arora, nor in Midori or Chromium. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:18:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:18:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28306] New: double-clicking a word inside beside newline select two words Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28306 Summary: double-clicking a word inside beside newline select two words Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: HTML Editing AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: morrita at gmail.com Overview: Double-clicking a word to select that word unexpectedly results two-word selected. Steps to Reproduce: 1. open attached file 2. double click "selectme" Actual Result: "foo selectme" is selected(hilightened) Expected Result: "selectme" is selected. Build Date & Platform: trunk r47196, Mac OS 10.5.7 Additional Information: this bug is from chromium http://code.google.com/p/chromium/issues/detail?id=6396 (and privately confirmed at Safari and WebKit trunk) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:19:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:19:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28306] double-clicking a word inside beside newline select two words In-Reply-To: References: Message-ID: <20090814161908.A0F4534E27F2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28306 --- Comment #1 from MORITA Hajime 2009-08-14 09:19:08 PDT --- Created an attachment (id=34845) --> (https://bugs.webkit.org/attachment.cgi?id=34845) html to reproduce. html to reproduce. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:24:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:24:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] New: [Haiku] Fix RenderThemeHaiku build. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28307 Summary: [Haiku] Fix RenderThemeHaiku build. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.maxime at gmail.com CC: leavengood at gmail.com The patch which introduced RenderThemeHaiku was wrong in some places. ( see: https://bugs.webkit.org/show_bug.cgi?id=28258#c5 ) Here is a patch to correct this. Regards, Maxime -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:31:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:31:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814163120.5029134E2916@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34846| |review? Flag| | --- Comment #1 from Maxime Simon 2009-08-14 09:31:19 PDT --- Created an attachment (id=34846) --> (https://bugs.webkit.org/attachment.cgi?id=34846) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:37:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:37:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28306] double-clicking a word inside beside newline select two words In-Reply-To: References: Message-ID: <20090814163721.582BA34E29AD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28306 MORITA Hajime changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34847| |review? Flag| | --- Comment #2 from MORITA Hajime 2009-08-14 09:37:20 PDT --- Created an attachment (id=34847) --> (https://bugs.webkit.org/attachment.cgi?id=34847) a small fix to use string length from RenderText instead of inline box -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:48:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:48:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814164827.654F634E2AD3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34848| |review? Flag| | --- Comment #1 from Jakub Wieczorek 2009-08-14 09:48:26 PDT --- Created an attachment (id=34848) --> (https://bugs.webkit.org/attachment.cgi?id=34848) Move the libxslt specific part of XSLTProcessor to a separate file. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:55:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:55:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28275] media/video-played.html always times out on Windows In-Reply-To: References: Message-ID: <20090814165537.5681834E2B88@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28275 Eric Carlson changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|webkit-unassigned at lists.web |eric.carlson at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:55:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:55:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814165538.150CD34E2B92@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34848|review? | Flag| | Attachment #34848|0 |1 is obsolete| | Attachment #34849| |review? Flag| | --- Comment #2 from Jakub Wieczorek 2009-08-14 09:55:36 PDT --- Created an attachment (id=34849) --> (https://bugs.webkit.org/attachment.cgi?id=34849) Move the libxslt specific part of XSLTProcessor to a separate file. This one actually fixes the whitespace errors. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:56:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:56:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814165656.DC38A34E2BE5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34772|review? | Flag| | Attachment #34772|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:57:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:57:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814165712.89E6D34E2BF1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34772| |review? Flag| | Attachment #34772|1 |0 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:57:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:57:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814165724.A2E8F34E2BFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34782|review? | Flag| | Attachment #34782|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:57:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:57:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814165733.B527934E2C11@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34783|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:57:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:57:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814165744.1A3BC34E2C27@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34784|review? | Flag| | Attachment #34784|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 09:59:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 09:59:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] New: allow down-sampling images during decoding Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28308 Summary: allow down-sampling images during decoding Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: yong.li at torchmobile.com CC: staikos at kde.org, treat at kde.org separated from bug 27561 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:04:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:04:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28224] Web pages with SVG and map links aren't rendered correctly In-Reply-To: References: Message-ID: <20090814170402.4664134E2CD1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28224 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #3 from Dirk Schulze 2009-08-14 10:04:01 PDT --- I can see this bug in Chromium and GtkLauncher on trunk too but it works for an older webkitgtk build + epiphany. Maybe it's a regression or it just works with epiphany (don't now how this could be possible). But I don't know the revision of my binary for checking this :-( -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:04:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:04:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28309] New: [Haiku] Adding SharedBufferHaiku to WebCore. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28309 Summary: [Haiku] Adding SharedBufferHaiku to WebCore. Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Other Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: simon.maxime at gmail.com CC: leavengood at gmail.com This patch will add the SharedBuffer::createWithContentsOfFile(const String&) function for Haiku. In the same time I cleaned up TemporaryLinkStubs.cpp Regards, Maxime -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:06:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:06:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814170645.3616734E2D2E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34851| |review? Flag| | --- Comment #1 from Yong Li 2009-08-14 10:06:44 PDT --- Created an attachment (id=34851) --> (https://bugs.webkit.org/attachment.cgi?id=34851) the patch only JPEG and PNG decoders are modified to support this feature. Other decoders just ignore it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:07:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:07:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814170723.A3CE934E2D3F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34852| |review? Flag| | --- Comment #3 from Jakub Wieczorek 2009-08-14 10:07:21 PDT --- Created an attachment (id=34852) --> (https://bugs.webkit.org/attachment.cgi?id=34852) Rename XSLStyleSheet.cpp to XSLStyleSheetLibxslt.cpp. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:09:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:09:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28309] [Haiku] Adding SharedBufferHaiku to WebCore. In-Reply-To: References: Message-ID: <20090814170912.2193634E2D74@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28309 Maxime Simon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34853| |review? Flag| | --- Comment #1 from Maxime Simon 2009-08-14 10:09:11 PDT --- Created an attachment (id=34853) --> (https://bugs.webkit.org/attachment.cgi?id=34853) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:12:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:12:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814171232.E1A8934E2DEF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34854| |review? Flag| | --- Comment #4 from Jakub Wieczorek 2009-08-14 10:12:31 PDT --- Created an attachment (id=34854) --> (https://bugs.webkit.org/attachment.cgi?id=34854) [Qt] Implement XSLT support with QtXmlPatterns. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:25:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:25:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814172502.2FACD34E2EF8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34855| |review? Flag| | --- Comment #5 from Jakub Wieczorek 2009-08-14 10:25:01 PDT --- Created an attachment (id=34855) --> (https://bugs.webkit.org/attachment.cgi?id=34855) [Qt] Add expected result for fast/xsl/document-function.xml. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:26:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:26:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814172655.E5D3E34E2F2B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34856| |review? Flag| | --- Comment #29 from Yong Li 2009-08-14 10:26:54 PDT --- Created an attachment (id=34856) --> (https://bugs.webkit.org/attachment.cgi?id=34856) 2) Use ImageFrameSink for JPEG, PNG, and GIF -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:37:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:37:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27968] [HTML5][Forms] UI In-Reply-To: References: Message-ID: <20090814173704.99EA534E3013@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27968 --- Comment #5 from Darin Adler 2009-08-14 10:37:03 PDT --- That Windows screenshot seems to be missing a line on top of the top arrow. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:40:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:40:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27612] handling scripts can block UI In-Reply-To: References: Message-ID: <20090814174012.8E6EB34E305A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27612 --- Comment #4 from Yong Li 2009-08-14 10:40:11 PDT --- Created an attachment (id=34857) --> (https://bugs.webkit.org/attachment.cgi?id=34857) test case this is a simple test case -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:41:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:41:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814174109.D8BA334E3082@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34858| |review? Flag| | --- Comment #6 from Jakub Wieczorek 2009-08-14 10:41:08 PDT --- Created an attachment (id=34858) --> (https://bugs.webkit.org/attachment.cgi?id=34858) [Qt] Update expected result for fast/xsl/xslt_unicode.xml. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:51:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:51:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814175126.E0DB634E31D2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34851|review? |review- Flag| | --- Comment #2 from Adam Treat 2009-08-14 10:51:26 PDT --- (From update of attachment 34851) Looking much, much better! A few issues: > +#if ENABLE(IMAGE_DECODER_DOWN_SAMPLING) > + if (m_decoder) { > +# ifdef IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS > + m_decoder->setMaxNumPixels(IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS); > +# else > + m_decoder->setMaxNumPixels(1024 * 1024); > +# endif > + } > +#endif > + } Shift this block down below to the next 'if (m_decoder)' and you eliminate an extra conditional and a nested one at that. Also, there is weird indenting on the '# ifdef' Please remove. > +namespace { > + enum MatchType{ > + Exact, > + UpperBound, > + LowerBound > + }; > +} More weird indentation. > +template static int getScaledValue(const Vector& scaledValues, int orig, int searchStart) > +{ > + int size = scaledValues.size(); > + const int* dataStart = scaledValues.data(); > + const int* dataEnd = dataStart + size; > + const int* pos = std::lower_bound(dataStart + searchStart, dataEnd, orig); > + switch (type) { > + case Exact: > + return pos != dataEnd && *pos == orig ? pos - dataStart : -1; > + case LowerBound: > + return pos != dataEnd && *pos == orig ? pos - dataStart : pos - dataStart - 1; > + case UpperBound: > + default: > + return pos != dataEnd ? pos - dataStart : -1; > + } > +} More weird indentation and the case labels should line up with switch statement. Please check with check-webkit-style. Why is this templated? > +int ImageDecoder::upperBoundScaledX(int origX, int searchStart) > +{ > + return getScaledValue(m_scaledColumns, origX, searchStart); > +} Is this tabbed indentation? Please remove all tabs and check thoroughly for coding style. > + // ENABLE(IMAGE_DECODER_DOWN_SAMPLING) allows image decoders writedirectly to scaled output buffers Typo. "allows image decoders to write directly to..." > + // by down sampling. Call setMaxNumPixels() to specify the biggest size that decoded images > + // can have. Image decoders will deflate those images that are bigger than m_maxNumPixels. > + // (Not supported by all image decoders yet) > -static void convertCMYKToRGBA(RGBA32Buffer& dest, JSAMPROW src, jpeg_decompress_struct* info) > +static void convertCMYKToRGBA(RGBA32Buffer& dest, int destY, JSAMPROW src, int srcWidth > +#if ENABLE(IMAGE_DECODER_DOWN_SAMPLING) > + , bool scaled, const Vector& scaledColumns > +#endif > + ) > { > - ASSERT(info->out_color_space == JCS_CMYK); Why do you remove this assert and change the behavior of this method even when IMAGE_DECODER_DOWN_SAMPLING is disabled? > @@ -491,21 +507,33 @@ static void convertCMYKToRGBA(RGBA32Buffer& dest, JSAMPROW src, jpeg_decompress_ > > // read_scanlines has increased the scanline counter, so we > // actually mean the previous one. > - dest.setRGBA(x, info->output_scanline - 1, c * k / 255, m * k / 255, y * k / 255, 0xFF); > + dest.setRGBA(x, destY, c * k / 255, m * k / 255, y * k / 255, 0xFF); Same question as above and repeated for hunks below. > while (info->output_scanline < info->output_height) { > /* Request one scanline. Returns 0 or 1 scanlines. */ > - if (jpeg_read_scanlines(info, samples, 1) != 1) > + int sourceY = info->output_scanline; > + int sourceRows = jpeg_read_scanlines(info, samples, 1); > + if (sourceRows != 1) { > + if (sourceRows != 0) > + m_failed = true; > return false; > + } Another change that is not guarded by ENABLE(IMAGE_DECODER_DOWN_SAMPLING) Each of these changes should be described. I simply don't have context to understand them. > +#if ENABLE(IMAGE_DECODER_DOWN_SAMPLING) > + bool setSize(int width, int height) { Brace goes on next line. I'll stop there and say that this still needs coding style cleanups. And if at all possible the patch should have no behavior changes for when ENABLE(IMAGE_DECODER_DOWN_SAMPLING) is false. Any other changes should either have some explanation or broken out into separate patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:51:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:51:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814175154.C4EC534E31EE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #30 from Peter Kasting 2009-08-14 10:51:53 PDT --- (In reply to comment #23) > Created an attachment (id=34772) --> (https://bugs.webkit.org/attachment.cgi?id=34772) [details] > 1) ImageFrameSink Here's a spattering of comments all over this patch, based on a quick glance. I assume that your motive for resurrecting the "decoded height" variable is so that when you paint a SharedBitmap you can do an opaque blit of the valid height (and avoid the undecoded portion entirely) instead of doing a transparent blit of the entire frame size? If so, I'm not necessarily opposed to resurrecting the height member, although no other ports do this and I wonder if it actually saves much time (it's only relevant while an image is half-decoded and being painted, and at that point the user isn't getting high-speed animation or similar anyway). If it doesn't actually buy meaningful performance, then returning true for frameHasAlphaAtIndex() (either using the method it has now, which I think is fine, or pushing this into all the decoders, which I think is unnecessary code duplication for no benefit) seems like a simpler and better way. I don't understand what createInstance() and deleteInstance() buy you. Callers could just use "foo = new ImageFrameSink(bool);" or "delete foo;". Some of the variable names seem problematic to me; e.g. I would change m_expectedHeight to m_height, m_height to m_decodedHeight, m_bmp to m_bitmap, can to canFreeBuffer. I'm skeptical of the utility of m_compositedWithPreviousFrame. The only use for this would be in decoding GIFs, to avoid creating the complete frame at a particular index. But this means you can't use the "large GIF, discard unnecessary frames" memory optimization which makes an enormous difference for large animated GIFs, because you need to keep around an arbitrary number of frames. Why are the data members protected instead of private? Per Darin Adler we should make things as private as possible. Having both setRGB16() and setRGBA() seems like a poor API for callers. Why doesn't setRGBA() just write the data in 16-bit format if the bitmap is 16-bit? If the answer is "we're worried about putting an if() in there for performance reasons", I'd like to see data on the effect of such a thing before prematurely optimizing. Note that there's already an if() in setRGBA(). Not a big fan of things like "foo >> 1 << 1". "foo & ~0x1" would be clearer. Same with "foo >> 3 << 7"; "(foo << 4) & 0xFFFFFF80" seems clearer. Why does getFrame() return 0 when the status is frameEmpty? An empty frame is still a valid one. The proper use of setCanFreeBuffer() is not obvious to me. Overall there seems to be a lot of functions to explicitly allocate and free things inside the ImageFrameSink. This doesn't feel like a particularly friendly API. Note that the existing RGBA32Buffer has only a few functions, mostly to support deep versus shallow copies of the underlying data. This file is also entirely missing a large number of functions from the current RGBA32Buffer, such as clear(), copyRowNTimes(), asNewNativeImage(), etc., which are used in various different cases. I assume this is because you wrote this code quite a while ago. If we wanted to use ImageFrameSink, I think a lot of these would need to be supported, so you wouldn't be massively rewriting the decoders or other cross-platform Image code (especially if such rewrites removed optimizations, like the GIF frame-clearing optimization). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:54:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:54:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814175457.F21F134E324A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #31 from Peter Kasting 2009-08-14 10:54:57 PDT --- (In reply to comment #29) > Created an attachment (id=34856) --> (https://bugs.webkit.org/attachment.cgi?id=34856) [details] > 2) Use ImageFrameSink for JPEG, PNG, and GIF I don't see the point of marking r? on this when it can't land until ImageFrameSink does, and that's a ways away. Much of this patch is a copy-and-paste of old code from the image decoders that has since been changed for both clarity and correctness. You need to discard that and find a way to modify in-line the existing decoding code, instead of completely rewriting entire functions under #ifdefs. We still wouldn't land the patch that way, but it would at least allow a precise understanding of what ImageFrameSink requires, which is impossible with this patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 10:58:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 10:58:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27612] handling scripts can block UI In-Reply-To: References: Message-ID: <20090814175831.93D5B34E32BD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27612 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33349|0 |1 is obsolete| | Attachment #34859| |review? Flag| | --- Comment #5 from Yong Li 2009-08-14 10:58:30 PDT --- Created an attachment (id=34859) --> (https://bugs.webkit.org/attachment.cgi?id=34859) modified for coding style only changed CACHED_SCRIPT_DELAY_NOTIFICATION into ENABLE(CACHED_SCRIPT_DELAY_NOTIFICATION) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:03:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:03:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814180328.1690834E338F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #32 from George Staikos 2009-08-14 11:03:26 PDT --- (In reply to comment #30) > (In reply to comment #23) > > Created an attachment (id=34772) --> (https://bugs.webkit.org/attachment.cgi?id=34772) [details] [details] > > 1) ImageFrameSink > > Here's a spattering of comments all over this patch, based on a quick glance. > > I assume that your motive for resurrecting the "decoded height" variable is so > that when you paint a SharedBitmap you can do an opaque blit of the valid > height (and avoid the undecoded portion entirely) instead of doing a > transparent blit of the entire frame size? If so, I'm not necessarily opposed > to resurrecting the height member, although no other ports do this and I wonder > if it actually saves much time (it's only relevant while an image is > half-decoded and being painted, and at that point the user isn't getting > high-speed animation or similar anyway). If it doesn't actually buy meaningful > performance, then returning true for frameHasAlphaAtIndex() (either using the > method it has now, which I think is fine, or pushing this into all the > decoders, which I think is unnecessary code duplication for no benefit) seems > like a simpler and better way. The performance issue is very valid for our target platform. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:05:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:05:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814180549.4126D34E3402@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34860| |review? Flag| | --- Comment #7 from Jakub Wieczorek 2009-08-14 11:05:48 PDT --- Created an attachment (id=34860) --> (https://bugs.webkit.org/attachment.cgi?id=34860) Remove the encoding attribute from xsl:stylesheet element in resources/unicode.xsl. This one will have no effect on other ports, it is needed to make Qtish XSLT processor happy: currently it stops evaluating the stylesheet after encountering the misplaced attribute. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:08:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:08:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814180843.81E3534E3458@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 --- Comment #3 from Yong Li 2009-08-14 11:08:42 PDT --- (In reply to comment #2) > (From update of attachment 34851 [details]) > Looking much, much better! A few issues: > Shift this block down below to the next 'if (m_decoder)' and you eliminate an > extra conditional and a nested one at that. They are different. this 'if (m_decoder)' is reached only for the first time, where the below one is reached every time. > Why is this templated? To be faster. template argument is kind of const values. > > Why do you remove this assert and change the behavior of this method even when > IMAGE_DECODER_DOWN_SAMPLING is disabled? info becomes useless except in this ASSERT. I removed 'info' argument. ASSERT is not necessary because the caller takes care of that. > > > while (info->output_scanline < info->output_height) { > > /* Request one scanline. Returns 0 or 1 scanlines. */ > > - if (jpeg_read_scanlines(info, samples, 1) != 1) > > + int sourceY = info->output_scanline; > > + int sourceRows = jpeg_read_scanlines(info, samples, 1); > > + if (sourceRows != 1) { > > + if (sourceRows != 0) > > + m_failed = true; > > return false; > > + } > > Another change that is not guarded by ENABLE(IMAGE_DECODER_DOWN_SAMPLING) I can remove the sourceRows change. sourceY is used to record the current row. With this change, there can be more code shared. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:10:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:10:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28303] [Qt] XSLT support with QtXmlPatterns In-Reply-To: References: Message-ID: <20090814181030.7036134E3495@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28303 Jakub Wieczorek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34861| |review? Flag| | --- Comment #8 from Jakub Wieczorek 2009-08-14 11:10:29 PDT --- Created an attachment (id=34861) --> (https://bugs.webkit.org/attachment.cgi?id=34861) [Qt] Update the Skipped list. The numbers: 13 test cases (37%) succeeded 19 test cases (54%) had incorrect layout 2 test cases (5%) were new 1 test case (2%) crashed We're passing 13 test cases within the fast/xsl directory and 5 more outside it. They all have been unskipped and the rest skipped with notes about why they're failing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:13:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:13:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814181358.7B90034E34F5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #33 from Peter Kasting 2009-08-14 11:13:57 PDT --- (In reply to comment #32) > (In reply to comment #30) > > I wonder > > if it actually saves much time (it's only relevant while an image is > > half-decoded and being painted, and at that point the user isn't getting > > high-speed animation or similar anyway). If it doesn't actually buy meaningful > > performance, then returning true for frameHasAlphaAtIndex() (either using the > > method it has now, which I think is fine, or pushing this into all the > > decoders, which I think is unnecessary code duplication for no benefit) seems > > like a simpler and better way. > > The performance issue is very valid for our target platform. OK, do you have some data (e.g. page load times or animation frame rates) around this issue? It would be helpful in deciding whether we should also try to convert the other backends over to a similar mechanism. I could be totally overlooking a particular case where this is really useful. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:23:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:23:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814182338.D37B634E3620@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 --- Comment #4 from Adam Treat 2009-08-14 11:23:38 PDT --- (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 34851 [details] [details]) > > Looking much, much better! A few issues: > > > Shift this block down below to the next 'if (m_decoder)' and you eliminate an > > extra conditional and a nested one at that. > > They are different. this 'if (m_decoder)' is reached only for the first time, > where the below one is reached every time. Ahh, the wonders of reading diffs. Sorry! > > Why is this templated? > To be faster. template argument is kind of const values. Ok. > > Why do you remove this assert and change the behavior of this method even when > > IMAGE_DECODER_DOWN_SAMPLING is disabled? > > info becomes useless except in this ASSERT. I removed 'info' argument. ASSERT > is not necessary because the caller takes care of that. Ok, I didn't see the added ASSERT. > > Another change that is not guarded by ENABLE(IMAGE_DECODER_DOWN_SAMPLING) > > I can remove the sourceRows change. Thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:25:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:25:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814182556.28F7B34E366B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #34 from George Staikos 2009-08-14 11:25:55 PDT --- (In reply to comment #33) > (In reply to comment #32) > > (In reply to comment #30) > > > I wonder > > > if it actually saves much time (it's only relevant while an image is > > > half-decoded and being painted, and at that point the user isn't getting > > > high-speed animation or similar anyway). If it doesn't actually buy meaningful > > > performance, then returning true for frameHasAlphaAtIndex() (either using the > > > method it has now, which I think is fine, or pushing this into all the > > > decoders, which I think is unnecessary code duplication for no benefit) seems > > > like a simpler and better way. > > > > The performance issue is very valid for our target platform. > > OK, do you have some data (e.g. page load times or animation frame rates) > around this issue? It would be helpful in deciding whether we should also try > to convert the other backends over to a similar mechanism. I could be totally > overlooking a particular case where this is really useful. No numbers right now but alpha blending is ugly, blitting is slow. Every pixel causes pain here. I don't expect it to be an issue in other places. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:29:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:29:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814182939.4FC9634E370D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #35 from Yong Li 2009-08-14 11:29:38 PDT --- (In reply to comment #30) > (In reply to comment #23) > > Created an attachment (id=34772) --> (https://bugs.webkit.org/attachment.cgi?id=34772) [details] [details] > > 1) ImageFrameSink > > Here's a spattering of comments all over this patch, based on a quick glance. > > I assume that your motive for resurrecting the "decoded height" variable is so > that when you paint a SharedBitmap you can do an opaque blit of the valid > height (and avoid the undecoded portion entirely) instead of doing a > transparent blit of the entire frame size? If so, I'm not necessarily opposed > to resurrecting the height member, although no other ports do this and I wonder > if it actually saves much time (it's only relevant while an image is > half-decoded and being painted, and at that point the user isn't getting > high-speed animation or similar anyway). If it doesn't actually buy meaningful > performance, then returning true for frameHasAlphaAtIndex() (either using the > method it has now, which I think is fine, or pushing this into all the > decoders, which I think is unnecessary code duplication for no benefit) seems > like a simpler and better way. > Seems RGBA32Buffer will be modified to support more formats. Are you planning to do this? After that, you will find that JPEG doesn't have alpha channel, so it may use 24bit format or RGB565 to store decoded data. So even you hack frameHasAlphaAtIndex(), it won't work. Also, on some devices, alpha blending may be slow, or even not supported. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:29:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:29:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28310] New: Chromium: Show a "Mute Disabled" button on audio error. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28310 Summary: Chromium: Show a "Mute Disabled" button on audio error. Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P4 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: kylep at chromium.org Load and paint a mediaSoundDisabled image in RenderThemeChromiumSkia::paintMediaMuteButton() to display when the mediaElement cannot load audio. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:37:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:37:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28310] Chromium: Show a "Mute Disabled" button on audio error. In-Reply-To: References: Message-ID: <20090814183756.80B2734E3839@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28310 Kyle Prete changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34864| |review? Flag| | --- Comment #1 from Kyle Prete 2009-08-14 11:37:55 PDT --- Created an attachment (id=34864) --> (https://bugs.webkit.org/attachment.cgi?id=34864) Fix Add methods to ask the mediaplayer if it has audio (by default returning true) and modify chromium theme renderer to paint the disabled button. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:38:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:38:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18546] Can't load some non-latin fonts with pango backend In-Reply-To: References: Message-ID: <20090814183811.ABF6834E3841@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18546 Khaled Hosny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |khaledhosny at eglug.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:38:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:38:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18552] Downloadable fonts don't work with pango backend In-Reply-To: References: Message-ID: <20090814183846.9B59534E384F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18552 Khaled Hosny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |khaledhosny at eglug.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:42:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:42:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814184227.A386534E38D4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #36 from Peter Kasting 2009-08-14 11:42:26 PDT --- (In reply to comment #35) > Seems RGBA32Buffer will be modified to support more formats. Are you planning > to do this? I'm planning to remove the name "RGBA32" from the class, since that class actually doesn't support any formats at all; the underlying native image types do. Though right now none of those native image types uses anything other than 32-bit ARGB (or RGBA, or whatever), they could, and my suspicion is that that decision is best left to those classes. I haven't coded it so I can't be sure, of course, but I think rather than having things like is16Bit() and raw bit-writing ops directly in this header, those should be pushed to places like what you've written as SharedBuffer. Being able to cleanly integrate ports like WinCE that desire lower-bitdepth storage formats is a key motivator to doing this, so whatever solution we land on certainly has to work for you guys. > After that, you will find that JPEG doesn't have alpha channel, so > it may use 24bit format or RGB565 to store decoded data. It could; it's not clear without trying it whether that will be a big win for backends like Skia and Cairo. Backends that did this would also need to ensure that their code doesn't rely on the image storage being 32-bit; I think Skia might, at the moment. > So even you hack frameHasAlphaAtIndex(), it won't work. FWIW, at the moment Cairo uses frameHasAlphaAtIndex() to determine its compositing op, but Skia just uses the real image data inside the SkBitmap, and ignores this function entirely. It might make sense to have that kind of pattern everywhere, since I imagine most native image storage formats can tell you if they use an alpha channel... > Also, on some devices, alpha blending may be slow, or even not supported. Having it not supported entirely would make a platform pretty unusable since not only most of the image formats, but all kinds of other CSS, SVG, etc. operations need alpha. So I'm not as concerned with designing for that case. Slow is another story; we do probably want to make it possible for ports to avoid alpha-blending where possible. I wonder if we need ensureHeight() and friends to do that, though; in the current RGBA32Buffer API, it would be pretty simple to set the decoded height correctly on an underlying native image without needing an explicit call from the decoder. This is because the decoders move monotonically through the rows of an image, and set the status to FrameComplete when they finish. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:43:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:43:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814184328.3044234E3902@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #37 from Yong Li 2009-08-14 11:43:27 PDT --- (In reply to comment #30) > (In reply to comment #23) > > Created an attachment (id=34772) --> (https://bugs.webkit.org/attachment.cgi?id=34772) [details] [details] > > 1) ImageFrameSink > > I don't understand what createInstance() and deleteInstance() buy you. Callers > could just use "foo = new ImageFrameSink(bool);" or "delete foo;". > createInstance is useful in this case: class ImageFrameSinkXxxxWithMoreMembers : public ImageFrameSink { more members here; }; ImageFrameSink* ImageFrameSink::createInstance() { return new ImageFrameSinkXxxxWithMoreMembers ; } > > Some of the variable names seem problematic to me; e.g. I would change > m_expectedHeight to m_height, m_height to m_decodedHeight m_height as RGBA32Buffer defined. Yeah, now it's ok to change the name as m_height has been removed from RGBA32Buffer. > > I'm skeptical of the utility of m_compositedWithPreviousFrame. The only use > for this would be in decoding GIFs, to avoid creating the complete frame at a > particular index. But this means you can't use the "large GIF, discard > unnecessary frames" memory optimization which makes an enormous difference for > large animated GIFs, because you need to keep around an arbitrary number of > frames. m_compositedWithPreviousFrame is not only for "avoiding someting", but also important for transparent effects in GIF animation. > > Why are the data members protected instead of private? Per Darin Adler we > should make things as private as possible. because the subclasses need to access them > > Having both setRGB16() and setRGBA() seems like a poor API for callers. Why > doesn't setRGBA() just write the data in 16-bit format if the bitmap is 16-bit? > If the answer is "we're worried about putting an if() in there for performance > reasons", I'd like to see data on the effect of such a thing before prematurely > optimizing. Note that there's already an if() in setRGBA(). they also have different inputs > > Not a big fan of things like "foo >> 1 << 1". "foo & ~0x1" would be clearer. >> 1 << 1 seems cleaner to. but I'm not sure which one is faster. > Same with "foo >> 3 << 7"; "(foo << 4) & 0xFFFFFF80" seems clearer. Same thing here, I don't think the latter is clean. > > Why does getFrame() return 0 when the status is frameEmpty? An empty frame is > still a valid one. why? Who likes to waste CPU time on empty frame? > > The proper use of setCanFreeBuffer() is not obvious to me. This nofities the buffer that decoder has finished writting to the buffer, so the buffer can be released when it's under memory pressure. > > Overall there seems to be a lot of functions to explicitly allocate and free > things inside the ImageFrameSink. This doesn't feel like a particularly > friendly API. Note that the existing RGBA32Buffer has only a few functions, > mostly to support deep versus shallow copies of the underlying data. > > This file is also entirely missing a large number of functions from the current > RGBA32Buffer, such as clear(), copyRowNTimes(), asNewNativeImage(), etc., which > are used in various different cases. I assume this is because you wrote this > code quite a while ago. If we wanted to use ImageFrameSink, I think a lot of > these would need to be supported, so you wouldn't be massively rewriting the > decoders or other cross-platform Image code (especially if such rewrites > removed optimizations, like the GIF frame-clearing optimization). I still think it's not difficult to replace RGBA32Buffer with ImageFrameSink. Yeah, it needs some work definitely. The one that I'm most concerned is about GIF m_compositedWithPreviousFrame thing. That's complicated, and ImageFrameSink code works in a little different way. Want to talk to somebody on this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:51:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:51:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28268] adjustLineToPixelBoundaries used in platform/GraphicsContext drawLine needs refactoring finished. In-Reply-To: References: Message-ID: <20090814185136.5072F34E39E7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28268 Mike Fenton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34865| |review? Flag| | --- Comment #18 from Mike Fenton 2009-08-14 11:51:35 PDT --- Created an attachment (id=34865) --> (https://bugs.webkit.org/attachment.cgi?id=34865) Refactor patternWidth and patternOffset calculations from GraphicsContextQt/Cairo/CG.cpp into GraphicsContext.cpp. Note: This patch should be applied after other patches in this bug to avoid conflicts. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:54:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:54:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23995] backgound color lost on indent/listify In-Reply-To: References: Message-ID: <20090814185432.602A234E3A2B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23995 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P2 |P3 OS/Version|Mac OS X 10.5 |All Severity|Normal |Minor --- Comment #5 from Ryosuke Niwa 2009-08-14 11:54:30 PDT --- This bug has been fixed by http://trac.webkit.org/changeset/47008. But we still need some test cases to prevent future regression. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:59:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:59:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26317] event-based debugging / profiling In-Reply-To: References: Message-ID: <20090814185904.3C26634E3AA9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26317 Rob Retchless changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |retchless at gmail.com --- Comment #1 from Rob Retchless 2009-08-14 11:59:03 PDT --- Great paper Pat. This passage pretty much sums up the problem: > In the communicating event loops model, there are no > explicit receive operations; rather, each received message > notifies a callback, spawning a sequential call-return > computation which executes to completion. The stack > becomes empty before the next incoming message is > processed. For this style of distributed computation, the > conventional debugger's stack view only reaches back to > the last receive – the one that spawned the current stack. > Since each received message is processed to completion > separately, these computations are largely independent, so > earlier state within the same process is likely less relevant > than the process that sent the message. The biggest pain areas are with event debugging (like mousemove) or async calls. In terms of interaction, it would be cool if the debugger could record a time period, and then allow me to step through everything that happens during that time period retroactively. It would have to properly connect the various related call stacks to each other though, doing something similar to Causeway, and support watch variables. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 11:59:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 11:59:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814185917.6A44134E3AB1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #38 from Peter Kasting 2009-08-14 11:59:16 PDT --- (In reply to comment #37) > (In reply to comment #30) > > I don't understand what createInstance() and deleteInstance() buy you. Callers > > could just use "foo = new ImageFrameSink(bool);" or "delete foo;". > > > createInstance is useful in this case: > > class ImageFrameSinkXxxxWithMoreMembers : public ImageFrameSink > { > more members here; > }; > > ImageFrameSink* ImageFrameSink::createInstance() > { > return new ImageFrameSinkXxxxWithMoreMembers ; > } But does anyone do that? It doesn't look like it from this patch. Why build factory functions unless you need them? > > I'm skeptical of the utility of m_compositedWithPreviousFrame. The only use > > for this would be in decoding GIFs, to avoid creating the complete frame at a > > particular index. But this means you can't use the "large GIF, discard > > unnecessary frames" memory optimization which makes an enormous difference for > > large animated GIFs, because you need to keep around an arbitrary number of > > frames. > > m_compositedWithPreviousFrame is not only for "avoiding someting", but also > important for transparent effects in GIF animation. I don't understand. I know how GIF animation and frame disposal methods work. The existing ports handle them correctly without using this mechanism. Why doesn't the existing mechanism work for you, and how do you deal with not having the frame-clearing optimization for large GIFs? I would think on a memory-constrained platform that'd be even more important than it is on desktops. > > Why are the data members protected instead of private? Per Darin Adler we > > should make things as private as possible. > > because the subclasses need to access them What subclasses? > > Having both setRGB16() and setRGBA() seems like a poor API for callers. Why > > doesn't setRGBA() just write the data in 16-bit format if the bitmap is 16-bit? > > they also have different inputs This response is vague enough that I haven't learned anything. What is the difference and why can't it be created at the SharedBuffer or ImageFrameSink level? > > Why does getFrame() return 0 when the status is frameEmpty? An empty frame is > > still a valid one. > > why? Who likes to waste CPU time on empty frame? What CPU is being wasted? We don't blit anything with empty frames. > > The proper use of setCanFreeBuffer() is not obvious to me. > > This nofities the buffer that decoder has finished writting to the buffer, so > the buffer can be released when it's under memory pressure. Isn't this the same signal as setting the status to FrameComplete? > The one that I'm most concerned is about GIF m_compositedWithPreviousFrame > thing. That's complicated, and ImageFrameSink code works in a little different > way. Want to talk to somebody on this. Maybe you could write up a short doc with descriptions of the existing code and your code, pointing out the differences and why they are valuable? I can guess how someone would implement GIF animation with a flag like this but I can't see how to do it without needing to keep a potentially arbitrary number of frames around, for example if you scroll an animated GIF out of the viewport and then back in (causing the animation to need to spin forward). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 12:17:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 12:17:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814191705.97A7D34E3CD7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #39 from Yong Li 2009-08-14 12:17:03 PDT --- (In reply to comment #38) > (In reply to comment #37) > > (In reply to comment #30) > > But does anyone do that? It doesn't look like it from this patch. Why build > factory functions unless you need them? See first patch. We have ImageFrameSinkWince defined which holds a SharedBitmap as the buffer provider. > > I don't understand. I know how GIF animation and frame disposal methods work. > The existing ports handle them correctly without using this mechanism. Why > doesn't the existing mechanism work for you, and how do you deal with not > having the frame-clearing optimization for large GIFs? I would think on a > memory-constrained platform that'd be even more important than it is on > desktops. I've fixed many bugs on it, and our browser runs OK. Let me review this and get back to you. I did that so long time ago :) > What subclasses? ImageFrameSinkWince, if I am not wrong. > > > > Having both setRGB16() and setRGBA() seems like a poor API for callers. Why > > > doesn't setRGBA() just write the data in 16-bit format if the bitmap is 16-bit? > > > > they also have different inputs > > This response is vague enough that I haven't learned anything. What is the > difference and why can't it be created at the SharedBuffer or ImageFrameSink > level? I'm lost now. I thought you mean why setRGB16 and setRGBA cannot share a same function. If that was the question, I would say separate functions are definitely better. > > > > Why does getFrame() return 0 when the status is frameEmpty? An empty frame is > > > still a valid one. > > > > why? Who likes to waste CPU time on empty frame? > > What CPU is being wasted? We don't blit anything with empty frames. So why cannot it return 0? > > > > The proper use of setCanFreeBuffer() is not obvious to me. > > > > This nofities the buffer that decoder has finished writting to the buffer, so > > the buffer can be released when it's under memory pressure. > > Isn't this the same signal as setting the status to FrameComplete? FrameComplete is just for a single frame. But GIF decoder may still want to read a finished frame when it processes the next one. > > > The one that I'm most concerned is about GIF m_compositedWithPreviousFrame > > thing. That's complicated, and ImageFrameSink code works in a little different > > way. Want to talk to somebody on this. > > Maybe you could write up a short doc with descriptions of the existing code and > your code, pointing out the differences and why they are valuable? ok. but for why they are valuable, I have mentioned in bug 26467, see comment #5 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 12:44:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 12:44:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814194424.E10C434E4036@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34851|0 |1 is obsolete| | Attachment #34867| |review? Flag| | --- Comment #5 from Yong Li 2009-08-14 12:44:23 PDT --- Created an attachment (id=34867) --> (https://bugs.webkit.org/attachment.cgi?id=34867) modified for coding style... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 12:57:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 12:57:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814195709.268FB34E416F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #40 from Peter Kasting 2009-08-14 12:57:08 PDT --- (In reply to comment #39) > (In reply to comment #38) > > (In reply to comment #37) > > > (In reply to comment #30) > > > > But does anyone do that? It doesn't look like it from this patch. Why build > > factory functions unless you need them? > > See first patch. We have ImageFrameSinkWince defined which holds a SharedBitmap > as the buffer provider. I looked at most of the patches and missed any ImageFrameSinkWince class. It looks in this patch like you have an ImageFrameSinkWince.cpp, but it's just filling out the functions of ImageFrameSink and doesn't do any subclassing. Maybe I'm missing something. > > I don't understand. I know how GIF animation and frame disposal methods work. > > The existing ports handle them correctly without using this mechanism. Why > > doesn't the existing mechanism work for you, and how do you deal with not > > having the frame-clearing optimization for large GIFs? I would think on a > > memory-constrained platform that'd be even more important than it is on > > desktops. > > I've fixed many bugs on it, and our browser runs OK. Let me review this and get > back to you. I did that so long time ago :) Try cases like http://www.aintitcool.com/files/HoD2.gif and http://img2.abload.de/img/almost_failedovs.gif and make sure that: * Images animate in the same time as Chrome 2/Safari 4 (not slower) * You don't blow out memory or CPU usage > > > > Having both setRGB16() and setRGBA() seems like a poor API for callers. Why > > > > doesn't setRGBA() just write the data in 16-bit format if the bitmap is 16-bit? > > > > > > they also have different inputs > > > > This response is vague enough that I haven't learned anything. What is the > > difference and why can't it be created at the SharedBuffer or ImageFrameSink > > level? > > I'm lost now. I thought you mean why setRGB16 and setRGBA cannot share a same > function. If that was the question, I would say separate functions are > definitely better. It sounds like we're not understanding each other. My object is to reduce the complexity and special-casing of shared code, especially the decoders themselves. Let's say platform X supports native image storage in various formats (565, 888, 8888, etc.). The pattern that makes sense to me is: Image Decoder reads the pixel values out of the source image and calls setRGBA with them ImageFrameSink/RGBA32Buffer/whatever passes these values along to the backend's underlying NativeImage functions These functions decide how to downsample to an appropriate format With your existing code, the downsampling would need to be done in the decoder, which would need to check whether the image frame claims to be 16-bit. All that seems to do is cause us to plumb more state up through shared code and push the complexity on everyone. > > > > Why does getFrame() return 0 when the status is frameEmpty? An empty frame is > > > > still a valid one. > > > > > > why? Who likes to waste CPU time on empty frame? > > > > What CPU is being wasted? We don't blit anything with empty frames. > > So why cannot it return 0? Practically, it can; there are only two reasons I wouldn't do it: * The API is lying * A backend can't read any data off a NULL pointer, such as the size of the frame, if it wants it If it makes no difference, I don't see why we should lie to callers. It's not a big deal, it just seems like a waste to explicitly check for an empty frame so we can lie. > > > > The proper use of setCanFreeBuffer() is not obvious to me. > > > > > > This nofities the buffer that decoder has finished writting to the buffer, so > > > the buffer can be released when it's under memory pressure. > > > > Isn't this the same signal as setting the status to FrameComplete? > > FrameComplete is just for a single frame. But GIF decoder may still want to > read a finished frame when it processes the next one. So it's _not_ about the decoder being finished writing to the buffer. It's some signal that the decoder is finished reading the buffer too. In that case it seems like a bug that you don't finishBitmap() when we go to FrameComplete. In this case I suggest copying clear() from the existing code, which is designed for precisely this functionality. Note that there are fewer member variables involved (no "should" and "can" distinction). > > > The one that I'm most concerned is about GIF m_compositedWithPreviousFrame > > > thing. That's complicated, and ImageFrameSink code works in a little different > > > way. Want to talk to somebody on this. > > > > Maybe you could write up a short doc with descriptions of the existing code and > > your code, pointing out the differences and why they are valuable? > > ok. but for why they are valuable, I have mentioned in bug 26467, see comment > #5 It's not at all obvious in the code that these are useful for dynamic image scaling. Nor do I see what they buy you for scaling versus the decoding technique in the existing code. I think I'd benefit from a writeup :) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:01:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:01:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814200145.4D45E34E41ED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barraclough at apple.com --- Comment #2 from Gavin Barraclough 2009-08-14 13:01:44 PDT --- You seem to be checking in another mozilla test failing? If so, is this intentional, could you not just fix the test? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:02:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:02:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814200227.637F834E41F9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 --- Comment #3 from Oliver Hunt 2009-08-14 13:02:27 PDT --- I suppose i could do that... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:03:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:03:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28313] New: Combine ThreadableLoaderOptions::CrossOriginRequestPolicy and CrossOriginRedirectPolicy Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28313 Summary: Combine ThreadableLoaderOptions::CrossOriginRequestPolicy and CrossOriginRedirectPolicy Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: aa at chromium.org CC: ap at webkit.org, dimich at chromium.org, levin at chromium.org They are always set the same way. Also, I believe that ::resolveURL() no longer has to do the same origin check -- we can rely on ThreadableLoader to do it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:04:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:04:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28313] Combine ThreadableLoaderOptions::CrossOriginRequestPolicy and CrossOriginRedirectPolicy In-Reply-To: References: Message-ID: <20090814200403.E035934E4257@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28313 --- Comment #1 from Aaron Boodman 2009-08-14 13:04:01 PDT --- (In reply to comment #0) > Also, I believe that ::resolveURL() no longer has to do the same origin check Talking here about AbstractWorker::resolveURL(). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:07:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:07:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814200706.83E4634E4281@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #41 from Yong Li 2009-08-14 13:07:05 PDT --- (In reply to comment #40) > (In reply to comment #39) > > (In reply to comment #38) > > > (In reply to comment #37) > > > > (In reply to comment #30) > > > > I looked at most of the patches and missed any ImageFrameSinkWince class. It > looks in this patch like you have an ImageFrameSinkWince.cpp, but it's just > filling out the functions of ImageFrameSink and doesn't do any subclassing. > > Maybe I'm missing something. Hm... Sorry, ImageFrameSinkWince has been removed by refactoring... too long story. But createInstance and deleteInstance are already added, providing ability to subclass ImageFrameSink, which should be fine. > > > > I don't understand. I know how GIF animation and frame disposal methods work. > > > The existing ports handle them correctly without using this mechanism. Why > > > doesn't the existing mechanism work for you, and how do you deal with not > > > having the frame-clearing optimization for large GIFs? I would think on a > > > memory-constrained platform that'd be even more important than it is on > > > desktops. > > > > I've fixed many bugs on it, and our browser runs OK. Let me review this and get > > back to you. I did that so long time ago :) > > Try cases like http://www.aintitcool.com/files/HoD2.gif and > http://img2.abload.de/img/almost_failedovs.gif and make sure that: > * Images animate in the same time as Chrome 2/Safari 4 (not slower) > * You don't blow out memory or CPU usage Thanks for providing this test case. I'm confident our browser won't crash :) Will try it > > My object is to reduce the complexity and special-casing of shared code, > especially the decoders themselves. Let's say platform X supports native image > storage in various formats (565, 888, 8888, etc.). The pattern that makes > sense to me is: > > Image Decoder reads the pixel values out of the source image and calls setRGBA > with them > ImageFrameSink/RGBA32Buffer/whatever passes these values along to the backend's > underlying NativeImage functions > These functions decide how to downsample to an appropriate format > > With your existing code, the downsampling would need to be done in the decoder, > which would need to check whether the image frame claims to be 16-bit. All > that seems to do is cause us to plumb more state up through shared code and > push the complexity on everyone. I think you make a good point here. > > > > > > Why does getFrame() return 0 when the status is frameEmpty? An empty frame is > > > > > still a valid one. > > > > > > > > why? Who likes to waste CPU time on empty frame? > > > > > > What CPU is being wasted? We don't blit anything with empty frames. > > > > So why cannot it return 0? > > Practically, it can; there are only two reasons I wouldn't do it: > * The API is lying > * A backend can't read any data off a NULL pointer, such as the size of the > frame, if it wants it > > If it makes no difference, I don't see why we should lie to callers. It's not > a big deal, it just seems like a waste to explicitly check for an empty frame > so we can lie. The object itself has size and all information. getFrame() just return a platform image, which can be null when it doesn't want to return a valid image. for example, failed to allocated memory for it. > > > > > > The proper use of setCanFreeBuffer() is not obvious to me. > > > > > > > > This nofities the buffer that decoder has finished writting to the buffer, so > > > > the buffer can be released when it's under memory pressure. > > > > > > Isn't this the same signal as setting the status to FrameComplete? > > > > FrameComplete is just for a single frame. But GIF decoder may still want to > > read a finished frame when it processes the next one. > > So it's _not_ about the decoder being finished writing to the buffer. It's > some signal that the decoder is finished reading the buffer too. In that case > it seems like a bug that you don't finishBitmap() when we go to FrameComplete. finisheBitmap() is called when ImageSource is taking the bitmap. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:07:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:07:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814200754.66E6134E429F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34826|review? | Flag| | Attachment #34826|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:07:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:07:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814200759.800F434E42AA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34869| |review? Flag| | --- Comment #4 from Oliver Hunt 2009-08-14 13:07:58 PDT --- Created an attachment (id=34869) --> (https://bugs.webkit.org/attachment.cgi?id=34869) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:08:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:08:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814200819.933F634E42C2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 --- Comment #5 from Oliver Hunt 2009-08-14 13:08:19 PDT --- Gavin i has fixed it -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:11:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:11:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28315] New: Update our copy of the mozilla JS regression test suite Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28315 Summary: Update our copy of the mozilla JS regression test suite Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: oliver at apple.com CC: mjs at apple.com, ggaren at apple.com Our testing includes the mozilla js regression suite, however a copy is now quite old so we should update. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:11:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:11:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814201142.DD02834E4330@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 Gavin Barraclough changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34869|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:13:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:13:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28309] [Haiku] Adding SharedBufferHaiku to WebCore. In-Reply-To: References: Message-ID: <20090814201342.40A9934E436E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28309 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34853|review? |review+, commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:14:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:14:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814201423.0D0B534E4392@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34846|review? |review+, commit-queue+ Flag| | --- Comment #2 from Oliver Hunt 2009-08-14 13:14:22 PDT --- (From update of attachment 34846) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:19:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:19:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814201905.16A5E34E4426@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #42 from Adam Treat 2009-08-14 13:19:04 PDT --- (In reply to comment #41) > > My object is to reduce the complexity and special-casing of shared code, > > especially the decoders themselves. Let's say platform X supports native image > > storage in various formats (565, 888, 8888, etc.). The pattern that makes > > sense to me is: > > > > Image Decoder reads the pixel values out of the source image and calls setRGBA > > with them > > ImageFrameSink/RGBA32Buffer/whatever passes these values along to the backend's > > underlying NativeImage functions > > These functions decide how to downsample to an appropriate format > > > > With your existing code, the downsampling would need to be done in the decoder, > > which would need to check whether the image frame claims to be 16-bit. All > > that seems to do is cause us to plumb more state up through shared code and > > push the complexity on everyone. > > I think you make a good point here. You both are assuming that the decoder can stream pixels directly into the native image buffer. That simply isn't the case for some of the existing users of the built-in image decoders. This was covered I think by Holger. It might not even be the case that the native image buffer is in main memory. At this point, I think the discussion should move away from WinCE's ImageFrameSink and more towards the path we want to take in the future. I still do not believe we are all on the same page. Perhaps a conference call or two with all interested parties would be in order. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:19:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:19:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28298] [ES5] Arguments object should inherit from Array In-Reply-To: References: Message-ID: <20090814201937.21CF734E443C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28298 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #6 from Oliver Hunt 2009-08-14 13:19:36 PDT --- Committed r47292 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:19:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:19:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26317] event-based debugging / profiling In-Reply-To: References: Message-ID: <20090814201956.DD7FB34E445C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26317 --- Comment #2 from Patrick Mueller 2009-08-14 13:19:55 PDT --- started looking into this a bit. I think the idea is going to be to do some logging of events that get fired. Which you could then lead you to a javascript handler you could set a breakpoint on. Not terribly elaborate, but no extensive stack traces required or anything either. Place I'm poking around right now is Node::dispatchEvent() in WebCore/dom, but need to do a bit more debugging to follow the flows. Haven't though too much about the UI for this. I think it needs to go in the Scripts panel somehow. Perhaps another section on the right showing you the events and pointers to the source. Seems like this will need to be an opt-in scenario, which is fine as you prolly won't be needing to use the function all the time. opt-in per session. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:20:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:20:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28306] double-clicking a word inside beside newline select two words In-Reply-To: References: Message-ID: <20090814202001.CD93734E4462@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28306 --- Comment #3 from Darin Adler 2009-08-14 13:20:01 PDT --- (From update of attachment 34847) This does not look like the right fix to me. I don't have time to study the issue at this time, and I could be wrong. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:20:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:20:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814202059.C7FBD34E4484@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #43 from Yong Li 2009-08-14 13:20:59 PDT --- > Try cases like http://www.aintitcool.com/files/HoD2.gif and > http://img2.abload.de/img/almost_failedovs.gif and make sure that: > * Images animate in the same time as Chrome 2/Safari 4 (not slower) > * You don't blow out memory or CPU usage Hm... you're right, these are too big GIF, we have to clean the memory for previous frames. thanks. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:22:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:22:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814202236.AC37634E44C4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34846|commit-queue+ |commit-queue- Flag| | --- Comment #3 from Eric Seidel 2009-08-14 13:22:36 PDT --- (From update of attachment 34846) Rejecting patch 34846 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:23:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:23:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814202314.26A4034E44CE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 --- Comment #44 from Yong Li 2009-08-14 13:23:13 PDT --- (In reply to comment #43) > > Try cases like http://www.aintitcool.com/files/HoD2.gif and > > http://img2.abload.de/img/almost_failedovs.gif and make sure that: > > * Images animate in the same time as Chrome 2/Safari 4 (not slower) > > * You don't blow out memory or CPU usage > > Hm... you're right, these are too big GIF, we have to clean the memory for > previous frames. thanks. seems the crash is due to some changes made in upstream. our previous builds work with them with no problem. investigating -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:25:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:25:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28316] New: bugzilla-tool land-patches needs to know how to run update-webkit when commits fail Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28316 Summary: bugzilla-tool land-patches needs to know how to run update-webkit when commits fail Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org CC: abarth at webkit.org bugzilla-tool land-patches needs to know how to run update-webkit when commits fail If the commit fails due to an out-of-date file. I'm about to write a patch to fix this... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:25:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:25:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814202536.13E4534E4518@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34846|commit-queue- |commit-queue+ Flag| | --- Comment #4 from Eric Seidel 2009-08-14 13:25:35 PDT --- (From update of attachment 34846) Sorry, the commit-queue is dumb. There were 2 commits to the WebCore/ChangeLog between when the commit-queue updated and when it tried to commit. I'm about to teach it how to update itself before commit... bug 28316 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:31:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:31:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814203128.6783234E45CE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 --- Comment #5 from Maxime Simon 2009-08-14 13:31:27 PDT --- (In reply to comment #4) > (From update of attachment 34846 [details]) > Sorry, the commit-queue is dumb. There were 2 commits to the WebCore/ChangeLog > between when the commit-queue updated and when it tried to commit. I'm about > to teach it how to update itself before commit... bug 28316 Okay. I didn't understand why it could fail as there was nothing "exotic" in this patch. But indeed bugzilla-tool is still in a learning phase. ;) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:35:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:35:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28309] [Haiku] Adding SharedBufferHaiku to WebCore. In-Reply-To: References: Message-ID: <20090814203542.9BF3134E4626@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28309 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34853|review+, commit-queue+ | Flag| | --- Comment #2 from Eric Seidel 2009-08-14 13:35:42 PDT --- (From update of attachment 34853) Clearing flags on attachment: 34853 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog A WebCore/platform/haiku/SharedBufferHaiku.cpp M WebCore/platform/haiku/TemporaryLinkStubs.cpp Committed r47295 M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool r47294 = ac71e42f212fa9492e2b894e641eb8f4fca95a53 (trunk) M WebCore/ChangeLog M WebCore/platform/haiku/TemporaryLinkStubs.cpp A WebCore/platform/haiku/SharedBufferHaiku.cpp r47295 = 8fb3fb4bf759f54e3920c3b5cbe5c41500cd13d6 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/47295 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:35:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:35:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28309] [Haiku] Adding SharedBufferHaiku to WebCore. In-Reply-To: References: Message-ID: <20090814203545.EB00534E4636@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28309 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #3 from Eric Seidel 2009-08-14 13:35:44 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:37:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:37:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27903] [Qt] Text in strike tag not rendered with a strike through it. In-Reply-To: References: Message-ID: <20090814203735.7FFE434E4670@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27903 George Wright changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george.wright at torchmobile.c | |om --- Comment #1 from George Wright 2009-08-14 13:37:34 PDT --- Seems to work fine here. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:39:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:39:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814203914.5529634E46D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34856|review? | Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:39:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:39:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28280] WebInspector: Evaluating objects while on a breakpoint dumps string representation instead of live object. In-Reply-To: References: Message-ID: <20090814203937.994FD34E46DF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28280 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34841|0 |1 is obsolete| | Attachment #34870| |review? Flag| | --- Comment #3 from Pavel Feldman 2009-08-14 13:39:36 PDT --- Created an attachment (id=34870) --> (https://bugs.webkit.org/attachment.cgi?id=34870) patch >> Can you break this out into a named function so it is easier to read? It took >> me a second to realize this was being passed as an argument. Done. Thanks for review! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:39:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:39:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814203954.AEA5134E46E9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Adam Treat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34772|review? | Flag| | --- Comment #45 from Adam Treat 2009-08-14 13:39:53 PDT --- (From update of attachment 34772) Clearing flags as these need more discussion anyways -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:43:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:43:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28280] WebInspector: Evaluating objects while on a breakpoint dumps string representation instead of live object. In-Reply-To: References: Message-ID: <20090814204331.A69E234E476C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28280 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34870|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:52:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:52:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814205217.93DF634E480A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34846|review+, commit-queue+ | Flag| | --- Comment #6 from Eric Seidel 2009-08-14 13:52:16 PDT --- (From update of attachment 34846) Clearing flags on attachment: 34846 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/haiku/RenderThemeHaiku.cpp M WebCore/platform/haiku/RenderThemeHaiku.h Committed r47296 M WebCore/ChangeLog M WebCore/platform/haiku/RenderThemeHaiku.cpp M WebCore/platform/haiku/RenderThemeHaiku.h r47296 = c0737da3bd221d15fd82b932dc33967859956e54 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47296 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 13:52:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 13:52:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28307] [Haiku] Fix RenderThemeHaiku build. In-Reply-To: References: Message-ID: <20090814205221.458F034E4822@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28307 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #7 from Eric Seidel 2009-08-14 13:52:20 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:02:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:02:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28316] bugzilla-tool land-patches needs to know how to run update-webkit when commits fail In-Reply-To: References: Message-ID: <20090814210210.6BF4A34E491D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28316 --- Comment #1 from Eric Seidel 2009-08-14 14:02:09 PDT --- Created an attachment (id=34871) --> (https://bugs.webkit.org/attachment.cgi?id=34871) First attempt -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:11:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:11:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28316] bugzilla-tool land-patches needs to know how to run update-webkit when commits fail In-Reply-To: References: Message-ID: <20090814211135.17C8F34E49CB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28316 --- Comment #2 from Eric Seidel 2009-08-14 14:11:34 PDT --- I'm testing this patch on the commit-queue bot now. If it works well, I'll mark it for review (with a ChangeLog). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:14:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:14:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814211439.B591D34E4A43@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34400|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:14:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:14:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814211456.257C134E4A65@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34395|review? | Flag| | Attachment #34395|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:15:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:15:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814211535.4DCCF34E4A95@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34393|review? | Flag| | Attachment #34393|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:16:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:16:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814211605.817E434E4ABF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34401| |review+, commit-queue+ Flag| | --- Comment #95 from Yong Li 2009-08-14 14:16:02 PDT --- (From update of attachment 34401) seems already landed? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:18:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:18:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage In-Reply-To: References: Message-ID: <20090814211804.428E934E4AF3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28019 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34135|review- |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:25:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:25:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28317] New: Assertion being hit on layout tests in debug build Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28317 Summary: Assertion being hit on layout tests in debug build Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: gns at gnome.org I am hitting an assertion when running some of the tests that are currently failing in the GTK+ bot: ASSERTION FAILED: differenceBetween(coldPathBegin, call) == patchOffsetGetByIdSlowCaseCall (../../JavaScriptCore/jit/JITPropertyAccess.cpp:1260 void JSC::JIT::compileGetByIdSlowCase(int, int, JSC::Identifier*, JSC::SlowCaseEntry*&, bool)) One such test: http/tests/xmlhttprequest/origin-header-cross-origin-get-async.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:34:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:34:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28317] Assertion being hit on layout tests in debug build In-Reply-To: References: Message-ID: <20090814213410.6C85734E4CBD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28317 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barraclough at apple.com, | |oliver at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:34:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:34:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28318] New: Failed assertion when bringing up Safari's error console Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28318 Summary: Failed assertion when bringing up Safari's error console Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Images AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: atwilson at chromium.org CC: simon.fraser at apple.com Run safari bring up the error console (via the Develop menu) Get the following failed assertion: ASSERTION FAILED: m_clients.contains(renderer) (WebCore/css/CSSGradientValue.cpp:109 virtual WebCore::Image* WebCore::CSSGradientValue::image(WebCore::RenderObject*, const WebCore::IntSize&)) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:36:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:36:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28318] Failed assertion when bringing up Safari's error console In-Reply-To: References: Message-ID: <20090814213647.0A12C34E4D10@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28318 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Platform|PC |All AssignedTo|webkit-unassigned at lists.web |simon.fraser at apple.com |kit.org | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:47:06 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:47:06 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28319] New: [Qt] run-webkit-tests hangs on certain pixel tests with nonfinite tests Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28319 Summary: [Qt] run-webkit-tests hangs on certain pixel tests with nonfinite tests Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://philip.html5.org/tests/canvas/suite/tests/2d.im ageData.create.nonfinite.html OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: george.wright at torchmobile.com The testcase in the URL causes run-webkit-tests to hang when trying to process that file for pixel tests. It seems it is hanging on all test cases that use the Infinity keyword. It seems that DumpRenderTree Qt is reporting an incorrect PNG length when dumping the PNG data (or more likely that the PNG data is being truncated), which is causing run-webkit-tests to hang waiting for more data which doesn't come. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:50:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:50:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28285] Remove non-spec support for callable RegExp In-Reply-To: References: Message-ID: <20090814215033.75AEF34E4E3B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28285 --- Comment #2 from Gavin Barraclough 2009-08-14 14:50:32 PDT --- > Additional ramifications from this are that native JSON.stringify > will ignore RegExp instances as it does Functions. Hmmm, this certainly does sound like a ramification we should consider carefully, and could even be a reason to remove the ability to call RegExp objects. > It seems to me the value of syntactic sugar that shaves 5 characters from > /a/.exec("abc") is not worth the price of creating a development environment > where testing random input to see if it is a function changes from > > if (typeof v === "function") { > > to > if (typeof v === "function" && v.call) { The spec states "Unless specified otherwise, the [[Class]] property of a built-in object is "Function" if that built-in object has a [[Call]] property, or "Object" if that built-in object does not have a [[Call]] property." This would seem to pretty clearly imply that an object of a class other than "Function" can validly implement [[Call]] (provided that it is stated as such), and therefore assuming that an object with a [[Call]] property is specifically of class Function is incorrect. To test for a function you can just use the instaceof operator: if (v instanceof Function) > Because /a/(str) is not supported across all current browsers, it is not > recommended for use in scripts that will live in internet environments > available for public consumption. So currently, there is no benefit to the > extension for IMO the largest consumer base (web developers), but there is a > cost. > > Other js runtimes include support for callable RegExp (Opera 9.6-10 beta2, > Firefox 3.0-3.5, Chrome 3) though they all maintain typeof /a/ == "object". Hmmm, section 11.4.3 seems pretty clear, and I certainly can't agree with FireFox's implementation here. The spec very clearly states that for any native object that implements [[Call]] the typeof operator must return "function". So far as I'm aware, this is the only way within the language to ask this specific question (is this any kind of object that can be called as a function, as opposed to, is this object an instance of "Function"), and it doesn't seem like a capability we'd want to take away. So I can't say that I think we want to unify on FireFox's present behaviour here. I believe WebKit's current behavior is sensible, and is not fundamentally at conflict with the spec (and it would also be a sensible and consistent state to remove the ability to call RegExp objects as functions). I would suggest the FireFox's RegExp implementation is presently noncompliant with the spec in that it violates section 11.4.3 - a native object with a [[Call]] property fails to return "function" from typeof. It would probably be helpful to file a bug with them. > new obj.someRegExp(str) => boom If I'm understanding your test case correctly, you seem to be assuming that all objects that have a [[Call]] property must also have a [[Construct]] property? >From my reading of the spec this is not required (and is not a requirement within WebKit). > someRegExp.call(obj,str) => boom If I'm understanding your test case correctly, you seem to be assuming that all objects that have a [[Call]] property must be of class Function, and have the Function prototype featuring a "call" property? From my reading of the spec this is again not required (and again is not a requirement within WebKit). I'm tempted to close as behaves correctly, though as I say the 'JSON.stringify' issue certainly does seem interesting. :-/ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:52:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:52:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28321] New: bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28321 Summary: bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: eric at webkit.org bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches bugzilla-tool properly detects when a pach has r+ or cq+ set by someone who does not have proper rights. However it doesn't know how to clean up the bug after that. It should clear flags which have been set erroneously. What makes this tricky is the current architecture is to do that lookups/validation inside the patch fetch function. Which is wrong. We should get all the patch information in one function and validate the patches separately. Or at least have some sort of validate=True flag which is passed to the fetch function. I have a partial patch on my machine, but I'll have to finish it later... -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:53:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:53:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28321] bugzilla-tool --commit-queue needs to know how to reject mis-reviewed patches In-Reply-To: References: Message-ID: <20090814215309.AFDDD34E4EAB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28321 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abarth at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:53:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:53:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28322] New: fast/borders/border-radius-constraints.html is missing expected png Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28322 Summary: fast/borders/border-radius-constraints.html is missing expected png Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: tony at chromium.org The layout test fast/borders/border-radius-constraints.html doesn't have an expected png checked in. It has a checksum, so the pixel tests can run and verify it hasn't changed, but there's no actual png to visually check against. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 14:55:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 14:55:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28322] fast/borders/border-radius-constraints.html is missing expected png In-Reply-To: References: Message-ID: <20090814215502.88F8434E4F02@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28322 --- Comment #1 from Tony Chang (Google) 2009-08-14 14:55:01 PDT --- The same is true for fast/borders/border-radius-split-inline.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:00:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:00:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28317] Assertion being hit on layout tests in debug build In-Reply-To: References: Message-ID: <20090814220054.BDBE234E4F92@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28317 --- Comment #1 from Gustavo Noronha (kov) 2009-08-14 15:00:54 PDT --- Created an attachment (id=34872) --> (https://bugs.webkit.org/attachment.cgi?id=34872) backtrace -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:02:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:02:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27967] Decouple the code that deals with the main DB and quota management from the rest of the DB code In-Reply-To: References: Message-ID: <20090814220230.6CCE434E4FD4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27967 Dumitru Daniliuc changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34617|review? | Flag| | Attachment #34617|0 |1 is obsolete| | Attachment #34873| |review? Flag| | --- Comment #12 from Dumitru Daniliuc 2009-08-14 15:02:27 PDT --- Created an attachment (id=34873) --> (https://bugs.webkit.org/attachment.cgi?id=34873) patch (In reply to comment #11) > 187 'storage/SQLTransactionClientImpl.cpp', > Some of the make files make reference to SQLTransactionClientImpl.cpp, did you > mean SQLTransactionClient.cpp here? yes, fixed. > 330 m_transactionClient->databaseSizeChanged(m_database.get()); > So this method is invoked on the background db thread. > > 392 m_shouldRetryCurrentStatement = > m_transactionClient->databaseExceedsQuota(...); > And this one on the 'apartment' thread of the Database object (the main thread) > > 426 m_transactionClient->databaseChanged(m_database.get()); > And this one on the background thread > > I would appreciate some indication of the threading usage in the > SQLTransactionListener source files. To figure out how it was used, i had to > track down the callsites. Not sure how to best indicate the threading rules... > either doc comments in the .h file, or runtime asserts in the .cpp file? added ASSERTs in the .cpp file. i don't think we should make assumptions for all ports. > 38 // A "listener" interface to the SQLTransaction class. Allows > 39 // SQLTransaction to notify interested parties when certain things are > 40 // happening in a transaction. > 41 class SQLTransactionClient { > 42 public: > 43 // Notifies everybody that the database has changed. Called at the > end > 44 // end of every successful transaction. > 45 void databaseChanged(Database*); > 46 > 47 // Notifies everybody that the size of the database file might have > changed. > 48 // Called after executing each statement in a transaction > 49 void databaseSizeChanged(Database*); > 50 > 51 // Notifies everybody that the size of the database file exceeds > its quota. > 52 // If this method returns true, the current statement in the > transaction is > 53 // retried. Otherwise, the transaction is rolled back. > 54 // > 55 // This method should return true if and only if the quota for this > database > 56 // file was increased (by the user, for example) since calling this > method. > 57 bool databaseExceedsQuota(Database*); > 58 }; > 59 } > > After reading your doc comments, maybe these methods could be renamed for > clarity. > > void didCommitTransaction(...); // for databaseChanged > void didExecuteStatement(...); // for databaseSizeChanged > bool didExceedQuota(...); // for databaseExceedsQuota changed. > And would it make sense to have the SQLTransaction* be the parameter since it > is a transaction listener, the caller can get the Database* from the accessor > on the transaction object (i think). done. you're right: SQLTransactionCoordinator should work with SQLTransactions. > Also, the new class (TransactionCoordinator) you just added is also a > transaction listener of sorts. Should these two classes be merged? i think we will eventually merge them. for now though, i think it's better to introduce SQLTransactionClient as a separate piece of code (to make it easier to review and understand). > The TransactionCoordinator must be owned by the DBThread to properly serve its > purpose. In this patch, you have the new 'listener' object being owned by the > Database object, but i think it could just as easily be owned by the DBThread > and serve its purpose. > > Wdyt? done. > 60 RefPtr origin = database->securityOriginCopy(); > > Making a copy of a refcounted object looks odd? Is it mutable? Is there no > database->securityOrigin() accessor? this seems to be the only accessor for getting the origin from a Database object. we could probably introduce a new accessor (or replace the existing one), but i wouldn't want to do this before talking to the authors of this code and understanding why they had a copying accessor here in the first place. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:05:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:05:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27371] [WINCE] Add WinCE specific platform/text files to WebCore In-Reply-To: References: Message-ID: <20090814220536.11ED234E5041@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27371 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34875| |review? Flag| | --- Comment #11 from Yong Li 2009-08-14 15:05:34 PDT --- Created an attachment (id=34875) --> (https://bugs.webkit.org/attachment.cgi?id=34875) modified Thai.cpp and Euc_jp.cpp moved out -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:05:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:05:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814220557.2CD8034E5069@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34401|review+, commit-queue+ | Flag| | --- Comment #96 from Eric Seidel 2009-08-14 15:05:55 PDT --- (From update of attachment 34401) bugzilla-tool isn't quite smart enough to know how to reject this patch yet. It is smart enough to know that you're not a reviewer however. :) Only reviewers can set r+. Exception: Committer "Yong Li" does not have review rights. Documentation of the review process is part of the committer agreement that you signed. :) http://webkit.org/quality/lifecycle.html has more information if you need. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:10:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:10:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814221052.37EF834E5111@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 --- Comment #97 from Yong Li 2009-08-14 15:10:50 PDT --- (In reply to comment #96) > (From update of attachment 34401 [details]) > bugzilla-tool isn't quite smart enough to know how to reject this patch yet. > It is smart enough to know that you're not a reviewer however. :) Only > reviewers can set r+. > > Exception: Committer "Yong Li" does not have review > rights. > > Documentation of the review process is part of the committer agreement that you > signed. :) > > http://webkit.org/quality/lifecycle.html has more information if you need. that patch is already landed. just want to mark it with something other than "No flag". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:11:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:11:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28254] [Chromium] Remove legacy code in "WebCore/platform/chromium/PopupMenuChromium.cpp" In-Reply-To: References: Message-ID: <20090814221124.8EDC834E513D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28254 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34825|review? | Flag| | --- Comment #5 from Eric Seidel 2009-08-14 15:11:23 PDT --- (From update of attachment 34825) This bug is resolved. No need for this patch to be marked for review. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:14:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:14:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28310] Chromium: Show a "Mute Disabled" button on audio error. In-Reply-To: References: Message-ID: <20090814221419.466A234E518D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28310 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34864|review? |review- Flag| | --- Comment #2 from Eric Seidel 2009-08-14 15:14:18 PDT --- (From update of attachment 34864) I'm not a media expert, but this patch looks wrong. Mostly because the methods look out of place: One of these does not look like the other: virtual bool isVideo() const { return false; } virtual bool hasVideo() const { return false; } + virtual bool hasAudio() const { return player() && player()->hasAudio(); } And again: virtual bool hasVideo() const = 0; + virtual bool hasAudio() const { return true; } It seems maybe you're not following the design of the rest of the media classes? Please explain. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:19:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:19:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814221930.7F21C34E51F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34867|review? |review- Flag| | --- Comment #6 from Eric Seidel 2009-08-14 15:19:29 PDT --- (From update of attachment 34867) 126 #ifdef IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS 127 m_decoder->setMaxNumPixels(IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS); 128 #else 129 m_decoder->setMaxNumPixels(1024 * 1024); 130 #endif Would be better to check #ifdef IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS at the top fo the file, and define IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS to 1024 * 1024 if not defined. Seems we'd benifit from some nicely named local variables: 47 case Exact: 48 return pos != dataEnd && *pos == orig ? pos - dataStart : -1; 49 case LowerBound: 50 return pos != dataEnd && *pos == orig ? pos - dataStart : pos - dataStart - 1; 51 case UpperBound: 52 default: 53 return pos != dataEnd ? pos - dataStart : -1; Style: 84 double zoom = 1. /shrink; I would have made this a static inline function to prevent copy/paste: 94 m_scaledRows.reserveCapacity(height * shrink + 0.5); 95 for (int scaledY = 0;;) { 96 int y = scaledY * zoom + 0.5; 97 if (y < height) { 98 m_scaledRows.append(y); 99 ++scaledY; 100 } else 101 break; 102 } 64 bool good = ImageDecoder::setSize(width, height); good is not the word you want. success would be better. setSizeOK would be another option. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:20:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:20:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28306] double-clicking a word inside beside newline select two words In-Reply-To: References: Message-ID: <20090814222009.9074A34E5224@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28306 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34847|review? |review- Flag| | --- Comment #4 from Eric Seidel 2009-08-14 15:20:09 PDT --- (From update of attachment 34847) Needs ChangeLog. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:20:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:20:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28325] New: Safari not handling quoted paths correctly in version 1 cookies Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28325 Summary: Safari not handling quoted paths correctly in version 1 cookies Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows XP Status: NEW Severity: Major Priority: P2 Component: WebKit Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: andrejohn.mas at gmail.com Created an attachment (id=34876) --> (https://bugs.webkit.org/attachment.cgi?id=34876) Test case illustrating the issue. JSP file. Tested with Safari 4.0.2 with Windows XP SP2. If the cookie version is set to '1' in either WebLogic or Tomcat, and the path is set, then the value is quoted: Set-Cookie: Customer="WILE_E_COYOTE"; Version="1"; Path="/" Which is correct behaviour according to RFC 2109 (examples in section 5). The problem is that Safari treats the quotes as if they were part of the part, rather than simply surrounding the path. This can be observed by trying to read the cookie value back on the server when the browser points to the root of the server: http://.../ Also, when looking at the cookies in the preferences, the path shown is: %22/%22 I have attached a JSP file as a test case. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:20:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:20:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28325] Safari not handling quoted paths correctly in version 1 cookies In-Reply-To: References: Message-ID: <20090814222039.F26C234E523F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28325 Andre-John Mas changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrejohn.mas at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:21:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:21:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28304] S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite In-Reply-To: References: Message-ID: <20090814222109.C1B0A34E525B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28304 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org, | |oliver at apple.com --- Comment #2 from Eric Seidel 2009-08-14 15:21:08 PDT --- I don't understand this hack. Why can't we fix this for real? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:24:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:24:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814222404.2777F34E52C5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #98 from Eric Seidel 2009-08-14 15:24:02 PDT --- Closing bug since all patches have been landed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:24:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:24:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814222407.6678734E52EB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Bug 27561 depends on bug 27511, which changed state. Bug 27511 Summary: Add WinCE specific platform/graphics files to WebCore https://bugs.webkit.org/show_bug.cgi?id=27511 What |Old Value |New Value ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:24:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:24:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28304] S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite In-Reply-To: References: Message-ID: <20090814222459.2643634E530C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28304 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34839|review? |review- Flag| | --- Comment #3 from Oliver Hunt 2009-08-14 15:24:57 PDT --- (From update of attachment 34839) The Interpreter should not have any platform specific code in it. In general if your patch adds #if PLATFORM(...) to code where there are no existing PLATFORM specific #ifs, your patch is wrong. I'm also unsure why you feel the need to do this here -- there are plenty of places where you can just check for malloc failure and convert to a JS OOM exception. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:29:16 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:29:16 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28325] Safari not handling quoted paths correctly in version 1 cookies In-Reply-To: References: Message-ID: <20090814222916.A4A0834E5389@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28325 --- Comment #1 from Andre-John Mas 2009-08-14 15:29:16 PDT --- radar: 7144692 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:45:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:45:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28325] Safari not handling quoted paths correctly in version 1 cookies In-Reply-To: References: Message-ID: <20090814224600.0911934E54E4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28325 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar, ReviewedForRadar Status|NEW |RESOLVED Resolution| |INVALID --- Comment #2 from Mark Rowe (bdash) 2009-08-14 15:45:59 PDT --- Cookie parsing is not handled by WebKit. This issue will be tracked via the Radar that you filed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:50:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:50:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28327] New: Media layout tests should have a way to provide test files in different formats Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28327 Summary: Media layout tests should have a way to provide test files in different formats Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hclam at google.com All media/ layout tests are now using hard-coded file names, and the test files are mostly H264/AAC, if a port doesn't support such formats, the tests will all fail. We should provide a method to swap in test files with different formats easily. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:50:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:50:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] New: javascript execution sequence. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28328 Summary: javascript execution sequence. Product: WebKit Version: 525.x (Safari 3.2) Platform: Macintosh Intel OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: HTML DOM AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: hartman at videolan.org CC: oliver at apple.com, beidson at apple.com I see a race condition in the following case. Master script in head. This master script changes the DOM (adding spans and divs) after DOMContentLoaded. I import a second script AFTER changing the DOM. with this: function importScriptURI(url) { var s = document.createElement('script'); s.setAttribute('src',url); s.setAttribute('type','text/javascript'); document.getElementsByTagName('head')[0].appendChild(s); return s; } This second script needs to change and see the added DOM elements in order to function. This works just fine on Firefox, but on Safari, it seems that execution of both the master and the "child" javascript are started in paralel. Sometimes, the new dom elements are seen by the child script, sometimes they are missing. It might be that there is a workaround, but I have not been able to find any. This can be a very difficult issue to trigger, and slower computers, high load or very large and complicated multi level javascript inclusions seem often required to be able to actually observe the problem. (On wikipedia, in a complicated situation I see it maybe 1 in 15 page loads.) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 15:58:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 15:58:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28310] Chromium: Show a "Mute Disabled" button on audio error. In-Reply-To: References: Message-ID: <20090814225855.6A23C34E5626@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28310 --- Comment #3 from Kyle Prete 2009-08-14 15:58:54 PDT --- Sure. The issue is that hasAudio is being used differently than hasVideo is. hasVideo() returns true if the video has loaded. It could return false if the video isn't loaded yet, but might be loaded later. hasAudio() returns false if the audio will never load, i.e. the hardware doesn't work or (maybe) the source has no audio. It's probably more a naming issue. Should I call it hasAudioError and flip the default return? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:00:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:00:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] javascript execution sequence. In-Reply-To: References: Message-ID: <20090814230042.EF0BB34E5654@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28328 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:01:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:01:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] javascript execution sequence. In-Reply-To: References: Message-ID: <20090814230135.5486734E567A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28328 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org --- Comment #1 from Oliver Hunt 2009-08-14 16:01:34 PDT --- This causes issues with the MS ES5 conformance test -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:01:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:01:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] javascript execution sequence. In-Reply-To: References: Message-ID: <20090814230156.EF80134E568C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28328 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Component|HTML DOM |Page Loading -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:03:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:03:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] javascript execution sequence. In-Reply-To: References: Message-ID: <20090814230357.E784734E56D4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28328 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Page Loading |HTML DOM -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:04:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:04:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28328] javascript execution sequence. In-Reply-To: References: Message-ID: <20090814230450.3BC6834E56F6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28328 Oliver Hunt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:05:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:05:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28285] Remove non-spec support for callable RegExp In-Reply-To: References: Message-ID: <20090814230509.A201034E56FA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28285 --- Comment #3 from Luke Smith 2009-08-14 16:05:08 PDT --- (In reply to comment #2) > The spec states "Unless specified otherwise, the [[Class]] property of a > built-in object is "Function" if that built-in object has a [[Call]] property, > or "Object" if that built-in object does not have a [[Call]] property." > > This would seem to pretty clearly imply that an object of a class other than > "Function" can validly implement [[Call]] (provided that it is stated as such), > and therefore assuming that an object with a [[Call]] property is specifically > of class Function is incorrect. > I agree that by that wording it is valid to add [[Call]] to RegExp, as the "Unless stated otherwise" allows for RegExp [[Class]] defined in 15.10.4.1. > To test for a function you can just use the instaceof operator: > > if (v instanceof Function) Unfortunately not true. If v is a function from another frame, it is not instanceof Function as defined in the current frame. > Hmmm, section 11.4.3 seems pretty clear, and I certainly can't agree with > FireFox's implementation here. The spec very clearly states that for any > native object that implements [[Call]] the typeof operator must return > "function". So far as I'm aware, this is the only way within the language to > ask this specific question (is this any kind of object that can be called as a > function, as opposed to, is this object an instance of "Function"), and it > doesn't seem like a capability we'd want to take away. So I can't say that I > think we want to unify on FireFox's present behaviour here. I believe WebKit's > current behavior is sensible, and is not fundamentally at conflict with the > spec (and it would also be a sensible and consistent state to remove the > ability to call RegExp objects as functions). > > I would suggest the FireFox's RegExp implementation is presently noncompliant > with the spec in that it violates section 11.4.3 - a native object with a > [[Call]] property fails to return "function" from typeof. It would probably be > helpful to file a bug with them. This is discussed in the originating bug 28117 (not 281117 as I fat fingered above). https://bugs.webkit.org/show_bug.cgi?id=28117 Specifically, the following bugs were filed with Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=61911 https://bugzilla.mozilla.org/show_bug.cgi?id=289933 I also agree that per the spec, reporting typeof /a/ == "function" is correct if RegExp has been extended with [[Call]] and that Firefox, Opera, and Chrome violate the spec by implementing the feature and reporting "object". However, the practical ramifications of reporting "function" were enough to convince each of these vendors to do so. Callable RegExp were not present in Chrome 2 but are in Chrome 3, and despite its close (historical at least) relationship to WK, it diverged from WK's behavior in favor of FF and Opera's. My concern is that following the spec in this regard when 3 other vendors agree not to creates another inconsistency for developers to deal with. Firefox, Chrome, and Opera's choice also brings their typeof reporting into alignment with IE (in this respect) who do not implement callable RegExp. So of 5 major browser vendors, WebKit's behavior wrt typeof /a/ is unique. There is more active discussion on this topic on es5-discuss: https://mail.mozilla.org/pipermail/es5-discuss/2009-August/003033.html > > > new obj.someRegExp(str) => boom > > If I'm understanding your test case correctly, you seem to be assuming that all > objects that have a [[Call]] property must also have a [[Construct]] property? No, I understand the behavior. I'm just suggesting that it's already challenging to teach the nuances of js function invocation to new developers. Having something else that can look like a function obj(str) but not be a function just muddies the waters. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:05:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:05:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore In-Reply-To: References: Message-ID: <20090814230551.3C0E634E5722@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27511 Yong Li changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #99 from Yong Li 2009-08-14 16:05:48 PDT --- apparently it depends on 3 child bugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:05:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:05:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27561] ImageDecoder enhancements for WINCE port In-Reply-To: References: Message-ID: <20090814230553.DAFAC34E5742@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27561 Bug 27561 depends on bug 27511, which changed state. Bug 27511 Summary: Add WinCE specific platform/graphics files to WebCore https://bugs.webkit.org/show_bug.cgi?id=27511 What |Old Value |New Value ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:09:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:09:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28308] allow down-sampling images during decoding In-Reply-To: References: Message-ID: <20090814230902.DF58534E57A4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28308 --- Comment #7 from Yong Li 2009-08-14 16:09:02 PDT --- (In reply to comment #6) > (From update of attachment 34867 [details]) > 126 #ifdef IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS > 127 > m_decoder->setMaxNumPixels(IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS); > 128 #else > 129 m_decoder->setMaxNumPixels(1024 * 1024); > 130 #endif > > Would be better to check #ifdef > IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS at the top fo the file, and > define IMAGE_DECODER_DOWN_SAMPLING_MAX_NUMBER_OF_PIXELS to 1024 * 1024 if not > defined. > > Seems we'd benifit from some nicely named local variables: > 47 case Exact: > 48 return pos != dataEnd && *pos == orig ? pos - dataStart : -1; > 49 case LowerBound: > 50 return pos != dataEnd && *pos == orig ? pos - dataStart : pos - > dataStart - 1; > 51 case UpperBound: > 52 default: > 53 return pos != dataEnd ? pos - dataStart : -1; > > Style: > 84 double zoom = 1. /shrink; > > I would have made this a static inline function to prevent copy/paste: for this 1./x ? I think that's sick > 94 m_scaledRows.reserveCapacity(height * shrink + 0.5); > 95 for (int scaledY = 0;;) { > 96 int y = scaledY * zoom + 0.5; > 97 if (y < height) { > 98 m_scaledRows.append(y); > 99 ++scaledY; > 100 } else > 101 break; > 102 } > > 64 bool good = ImageDecoder::setSize(width, height); > > good is not the word you want. success would be better. setSizeOK would be > another option. "good" means the size is good. r- with all these tiny things? BTW, after it's modified to be what you want above, are you going to accept it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:11:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:11:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28329] New: HTML5 canvas's createImageData should raise the NOT_SUPPORTED_ERR exception when either of the arguments are not finite. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28329 Summary: HTML5 canvas's createImageData should raise the NOT_SUPPORTED_ERR exception when either of the arguments are not finite. Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://philip.html5.org/tests/canvas/suite/tests/2d.im ageData.create.nonfinite.html OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: ben at meyerhome.net According to http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation: "If any of the arguments to createImageData() or getImageData() are infinite or NaN, or if the createImageData() method is invoked with only one argument but that argument is null, the method must instead raise a NOT_SUPPORTED_ERR exception." Test page: http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:13:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:13:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28329] HTML5 canvas's createImageData should raise the NOT_SUPPORTED_ERR exception when either of the arguments are not finite. In-Reply-To: References: Message-ID: <20090814231330.B305634E582B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28329 Benjamin Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34878| |review? Flag| | --- Comment #1 from Benjamin Meyer 2009-08-14 16:13:29 PDT --- Created an attachment (id=34878) --> (https://bugs.webkit.org/attachment.cgi?id=34878) Patch to solve the issue -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:15:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:15:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28329] HTML5 canvas's createImageData should raise the NOT_SUPPORTED_ERR exception when either of the arguments are not finite. In-Reply-To: References: Message-ID: <20090814231535.9B4B734E5873@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28329 --- Comment #2 from Benjamin Meyer 2009-08-14 16:15:35 PDT --- I have contacted the author of the canvas tests to determine the licensing of the generated tests. If possible it would be nice to integrate them into our pixel tests and I started work in that direction, but before they can go into our repo the licensing needs to be determined. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:21:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:21:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28330] New: Remove AST nodes from use within the Runtime (outside of parsing), stage 1 Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28330 Summary: Remove AST nodes from use within the Runtime (outside of parsing), stage 1 Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Mac OS X 10.5 Status: NEW Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: barraclough at apple.com Remove the EvalNode and ProgramNode from use in the runtime. They still exist after this patch, but are hidden behind EvalExecutable and FunctionExecutable, and are also still reachable behind CodeBlock::m_ownerNode. The next step will be to beat back FunctionBodyNode in the same fashion. Then remove the usage via CodeBlock, then only construct these nodes only on demand during bytecode generation. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:27:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:27:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28331] New: dbName and originIdentifier parameters are switched in DatabaseTracker when calling SQLiteFileSystem::getFileNameForNewDatabase() Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28331 Summary: dbName and originIdentifier parameters are switched in DatabaseTracker when calling SQLiteFileSystem::getFileNameForNewDatabase() Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P3 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: dumi at chromium.org CC: dglazkov at chromium.org This results in dbName_originIdentifier.db files in Chromium, instead of originIdentifier_dbName.db. This bug has no effect on WebCore/Safari. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 14 16:45:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 14 Aug 2009 16:45:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24866] Cannot pres Enter to escape from bulleted list when height is not honored when there's a marquee with a heading tag Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28641 Summary: the scroll box is too big because height is not honored when there's a marquee with a heading tag Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.tianlongren.cn/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38415) --> (https://bugs.webkit.org/attachment.cgi?id=38415) reduced testcase I Steps: Go to http://www.tianlongren.cn/ II Issue: The scroll box is too big III Conclusion: It looks like webkit doesn't honor the height specified in a table's if the has a marquee with a heading tag. Interestingly, I'm not sure how one of the styles really affects the display of the marquee. The style declaration : h1 a {} doesn't really have anything in it but if I take this style out, then the page displays ok as in Firefox and IE. IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=15279 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:08:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:08:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28641] the scroll box is too big because height is not honored when there's a marquee with a heading tag In-Reply-To: References: Message-ID: <20090822000811.0AADF3535ADB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28641 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:09:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:09:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090822000905.125DD3535B05@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34204|review- | Flag| | Attachment #34204|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:09:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:09:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090822000926.4007D3535B2B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 --- Comment #5 from Eric Seidel 2009-08-21 17:09:25 PDT --- Created an attachment (id=38416) --> (https://bugs.webkit.org/attachment.cgi?id=38416) First attempt, needs revision -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:10:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:10:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28040] commit-queue needs a master process In-Reply-To: References: Message-ID: <20090822001029.4C8B33535B67@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28040 --- Comment #6 from Eric Seidel 2009-08-21 17:10:28 PDT --- I could definitely make the logging code simpler. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:12:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:12:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27043] Mouse-dragged events are not generated for right & middle buttons In-Reply-To: References: Message-ID: <20090822001200.1248C3535B9E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27043 Deirdre Saoirse Moen changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InRadar CC| |desamo at apple.com --- Comment #4 from Deirdre Saoirse Moen 2009-08-21 17:11:59 PDT --- Also filed by originator as rdar://problem/7160923. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:12:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:12:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore. In-Reply-To: References: Message-ID: <20090822001210.0AC2D3535BB4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28131 --- Comment #26 from Eric Seidel 2009-08-21 17:12:09 PDT --- (In reply to comment #25) > Except the patches have not all been landed -- one was r-'d, and it was not > obsoleted because 'lo the patch you landed, and the r-'d patch were different > parts of this bug. > > Please do not just automatically close bugs if there are unlanded non-obsolete > attachments. bug 28230 covers some of this. Historically I made bugzilla-tool more aggressive because people don't always obsolete patches when they post a new one, so it was never closing bugs, even though the bug was "done". I'm happy to make it less-aggressive about closing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:13:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:13:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28619] [GTK] Geolocation needs permission API before being enabled by default In-Reply-To: References: Message-ID: <20090822001317.2C1E03535BD3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28619 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38417| |review? Flag| | --- Comment #2 from Jan Alonzo 2009-08-21 17:13:16 PDT --- Created an attachment (id=38417) --> (https://bugs.webkit.org/attachment.cgi?id=38417) enable geolocation on the buildbot build -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:13:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:13:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28642] New: Items spread all over the page due to width of marquee tag's container table Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28642 Summary: Items spread all over the page due to width of marquee tag's container table Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.mofa.gov.sa/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38418) --> (https://bugs.webkit.org/attachment.cgi?id=38418) reduced testcase Steps: Go to http://www.mofa.gov.sa/ II Issue: The content of the page is spread (there are huge gaps between divs/table cells). III Conclusion: The items spread over the page because marquee tag is too long in Chrome and Safari. The width of marquee tag's container table is 416px, so in IE and FF, the marquee is also limited to 416px, but in chrome and safari, the marquee extends its width because of its content table's long width. IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=15326 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:13:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:13:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28642] Items spread all over the page due to width of marquee tag's container table In-Reply-To: References: Message-ID: <20090822001326.51AD33535BED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28642 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:13:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:13:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090822001345.5CB433535BFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35087|commit-queue+ |commit-queue- Flag| | --- Comment #18 from Eric Seidel 2009-08-21 17:13:44 PDT --- (From update of attachment 35087) Rejecting patch 35087 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:15:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:15:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28269] Inspector: Improve Cookie DataGrid to Show Hidden Data In-Reply-To: References: Message-ID: <20090822001503.AAC323535C36@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28269 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck at webkit.org --- Comment #36 from Joseph Pecoraro 2009-08-21 17:15:03 PDT --- (In reply to comment #35) > Another thing is that if you compile webkit without inspector these functions > (and cookie.h) should probably not be included as they are inspector specific. > Wrapping it in the ifdef would be good. I don't think there are any generic ifdefs for the inspector. Although maybe there should be if anyone ever wants to build WebKit without the Inspector (small gains?). Does this patch need anything else? Any more comments on the API? Is it worth putting in the work? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:16:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:16:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090822001644.E57623535C5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 --- Comment #19 from Eric Seidel 2009-08-21 17:16:44 PDT --- Created an attachment (id=38419) --> (https://bugs.webkit.org/attachment.cgi?id=38419) bugzilla-tool failure log Here is the failure log from bugzilla-tool. This is the first per-bug log it's ever made. :) (Feature is in testing.) You'll see from the log that trunk/WebCore/html/HTMLInputElement.idl has a tab in it, which caused the svn pre-commit hook to fail. We really should have svn-create-patch fail for those sorts of things. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:16:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:16:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090822001655.877D83535C6F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38419|application/octet-stream |text/plain mime type| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:19:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:19:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28269] Inspector: Improve Cookie DataGrid to Show Hidden Data In-Reply-To: References: Message-ID: <20090822001948.BB9A03535CBF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28269 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35146|review? |review+ Flag| | --- Comment #37 from Timothy Hatcher 2009-08-21 17:19:48 PDT --- (From update of attachment 35146) Nice clean up. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:21:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:21:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28643] New: All links in category get underlined on mouseover Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28643 Summary: All links in category get underlined on mouseover Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://lista.mercadolivre.com.br/brinquedos-hobbies/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38420) --> (https://bugs.webkit.org/attachment.cgi?id=38420) reduced testcase Steps: Go to http://lista.mercadolivre.com.br/brinquedos-hobbies/ II Issue: Before clicking on a sub-category, all sub-categories get underlined on mouseover, even though the site redirects correctly to the selected category. III Conclusion: The links are enclosed in a where the text decoration is set to underline on hover (for simplicity, I removed the table and changed it to a
    ). Each link's text-decoration is also set to underline. The issue is caused by the text-decoration set at the
    or
    		(in the original code) level. IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=14420 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:21:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:21:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28643] All links in category get underlined on mouseover In-Reply-To: References: Message-ID: <20090822002148.B54333535CFE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28643 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:26:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:26:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28644] New: Displacement of hyperlinked elements on mouse over Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28644 Summary: Displacement of hyperlinked elements on mouse over Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://banamex.com.mx/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38421) --> (https://bugs.webkit.org/attachment.cgi?id=38421) reduced testcase Steps: Go to http://banamex.com.mx/ II Issue: Hover over footer elements and entire footer container shifts up. III Conclusion: here are 2 issues in this bug. 1) When you hover one link, all links are underlined 2) When you hover, the text moves The issue may be caused by 1) definition of a class 'boton_heder_footer' in the styles in which the
    containing the links and the links themselves use the same class id. or 2) in the styles, they have these definitions- .boton_heder_footer:link { text-decoration:none; font-size:9px; } .boton_heder_footer:visited { text-decoration:none; font-size:9px; } .boton_heder_footer:hover { text-decoration:underline; font-size:9px; } .boton_heder_footer:active { text-decoration:none; font-size:9px; } Not sure if these were meant to have (note the a: after the class id to define the anchor tags) .boton_heder_footer a:link { text-decoration:none; font-size:9px; } .boton_heder_footer a:visited { text-decoration:none; font-size:9px; } .boton_heder_footer a:hover { text-decoration:underline; font-size:9px; } .boton_heder_footer a:active { text-decoration:none; font-size:9px; } If I set the styles to be like that of the latter, or remove the class of the
    containing the links, then webkit behaves like that of FF and IE IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=14606 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:26:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:26:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28644] Displacement of hyperlinked elements on mouse over In-Reply-To: References: Message-ID: <20090822002607.867513535D7C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28644 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:27:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:27:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28408] WebInspector: Migrate call frames interaction to the InjectedScript-based schema. In-Reply-To: References: Message-ID: <20090822002711.356173535DA7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28408 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38386|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:30:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:30:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28645] New: menu items are mushed together because of white-space:nowrap Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28645 Summary: menu items are mushed together because of white-space:nowrap Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://web.virginmobileusa.com/ OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38422) --> (https://bugs.webkit.org/attachment.cgi?id=38422) reduced testcase Steps: 1. Go to http://web.virginmobileusa.com/ 2. Put pointer over "My Account" tab/menu II Issue: he menu items are mushed together, making them unreadable. III Conclusion: The issue is caused by the
  • white-space:nowrap style. IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=15528 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:30:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:30:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28645] menu items are mushed together because of white-space:nowrap In-Reply-To: References: Message-ID: <20090822003047.1CB993535E28@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28645 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:34:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:34:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27573] [CSS3 Backgrounds and Borders] Add support for the "contain" value for background-size In-Reply-To: References: Message-ID: <20090822003413.78AE63535E7B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27573 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from mitz at webkit.org 2009-08-21 17:34:12 PDT --- Landed the rendering changes as . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:34:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:34:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27569] [CSS3 Backgrounds and Borders] Tracking bug for spec compliance In-Reply-To: References: Message-ID: <20090822003414.433D63535E8B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27569 Bug 27569 depends on bug 27573, which changed state. Bug 27573 Summary: [CSS3 Backgrounds and Borders] Add support for the "contain" value for background-size https://bugs.webkit.org/show_bug.cgi?id=27573 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:34:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:34:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28646] New: CSS focus pseudoclass is not handled correctly Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28646 Summary: CSS focus pseudoclass is not handled correctly Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.cssplay.co.uk/menu/gallery_click OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38423) --> (https://bugs.webkit.org/attachment.cgi?id=38423) reduced testcase Steps: 1. Go to http://www.cssplay.co.uk/menu/gallery_click 2. Try to view gallery (click on thumbnail) II Issue: Gallery doesn't work properly III Conclusion: Code has css style - #container_top a.gallery:active em, #container_top a.gallery:focus em {display:block; position:absolute; width:402px; height:250px; top:160px;} Issue is due to #container_top a.gallery:focus em {display:block;} IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=18018 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:34:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:34:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28646] CSS focus pseudoclass is not handled correctly In-Reply-To: References: Message-ID: <20090822003448.A68FE3535EAA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28646 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:35:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:35:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27574] [CSS3 Backgrounds and Borders] Add support for the "cover" value for background-size In-Reply-To: References: Message-ID: <20090822003503.AAE3B3535EB4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27574 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |mitz at webkit.org Resolution| |FIXED --- Comment #1 from mitz at webkit.org 2009-08-21 17:35:03 PDT --- Fixed along with "backgrond-size: contain" (bug 27573) in r47630 and r47650. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:35:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:35:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27569] [CSS3 Backgrounds and Borders] Tracking bug for spec compliance In-Reply-To: References: Message-ID: <20090822003503.F13C03535EC4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27569 Bug 27569 depends on bug 27574, which changed state. Bug 27574 Summary: [CSS3 Backgrounds and Borders] Add support for the "cover" value for background-size https://bugs.webkit.org/show_bug.cgi?id=27574 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:41:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:41:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28647] New: Weird layout bug when READING clientHeight Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28647 Summary: Weird layout bug when READING clientHeight Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Created an attachment (id=38424) --> (https://bugs.webkit.org/attachment.cgi?id=38424) testcase Steps: Go to attached reduced testcase II Issue: Document is twice as wide as the window. There should be no scrollbar III Conclusion: Put the HTML and CSS of the reduced test case into two separate files. webkit behaves correctly if the test case is anyhow simpified, even when styles are inlined. bug.html:
    bug.css: .bug { float: right; } IV Other Browsers: IE7: ok FF3: ok V Nightly tested : 47639 Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=16626 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:41:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:41:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28647] Weird layout bug when READING clientHeight In-Reply-To: References: Message-ID: <20090822004107.4AFB83535F71@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28647 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |HasReduction, | |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:46:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:46:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28648] New: Flash input broken/offset when page is zoomed Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28648 Summary: Flash input broken/offset when page is zoomed Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://www.myspace.com/freakedfrequency OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jasneet at chromium.org CC: jasneet at chromium.org Steps: 1. Go to http://www.myspace.com/freakedfrequency or any myspace page with an embedded music player) 2. Zoom page to more than 100% 3. Try clicking on the player controls or hover the mouse over songs II Issue: If zoom != 100% neither the buttons nor the song highlight work. It appears as if the player is picking up offset input. Notice that the player doesn't scale with the zoom, it just moves to the zoomed position. This might be what's causing the problem - feeding flash with input as if it were scaled whereas it actually isn't? III Expected: If you use 100% zoom hovering the mouse over individual songs highlights them. Pressing player/stop buttons or moving the slider also works as it should. IV Other Browsers: IE7: ok FF3: ok Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=9996 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:46:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:46:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28648] Flash input broken/offset when page is zoomed In-Reply-To: References: Message-ID: <20090822004626.8F6563536035@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28648 jasneet changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |InChromiumBugs -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 17:53:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 17:53:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28649] New: Support for interactive validation of form elements Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28649 Summary: Support for interactive validation of form elements Product: WebKit Version: 528+ (Nightly build) Platform: All URL: http://www.whatwg.org/specs/web-apps/current-work/#int eractively-validate-the-constraints OS/Version: All Status: UNCONFIRMED Severity: Enhancement Priority: P3 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: micdesim at gmail.com CC: adele at apple.com, pkasting at google.com, tkent at chromium.org Support for interactive validation of form elements, HTML5 specs section 4.10.15.2, is necessary. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:03:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:03:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16204] Heap corruption in JS on ARM In-Reply-To: References: Message-ID: <20090822010335.34762353626F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16204 --- Comment #5 from Grace Kloba 2009-08-21 18:03:34 PDT --- Not sure. Feel free to close it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:05:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:05:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28649] Support for interactive validation of form elements In-Reply-To: References: Message-ID: <20090822010551.1430535362AA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28649 Michelangelo De Simone changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19264 Depends on| |28145, 27452 --- Comment #1 from Michelangelo De Simone 2009-08-21 18:05:50 PDT --- Some tip from other bugs this depends on: 1. Form control elements can be in a "no-validate state" that is controlled by "novalidate" and "formNoValidate" attributes, plus some more condition. This snippet could be of help: bool HTMLFormControlElement::isInNoValidateState() const { return (isSuccessfulSubmitButton() && formNoValidate()) || m_form->novalidate(); } 2. HTMLFormElement::checkValidity() needs to be adapted to deal with "unhandled invalid controls" (as per TODO comment). Actually it just iterates over form elements calling checkValidity() (that fires the invalid event, as per specs), but it must also return a list of invalid form controls that haven't been handled through the invalid event. The following snippet might be of some help (was part of the proposed patch for bug 27452): bool checkValidity(Vector* unhandledInvalidControls = 0); bool HTMLFormElement::checkValidity(Vector* unhandledInvalidControls) { Vector invalidControls; for (unsigned i = 0; i < formElements.size(); ++i) { HTMLFormControlElement* control = formElements[i]; if (control->willValidate() && !control->validity()->valid()) invalidControls.append(control); } if (invalidControls.isEmpty()) return true; for (unsigned n = 0; n < invalidControls.size(); ++n) { HTMLFormControlElement* invalidControl = invalidControls[n]; bool eventCanceled = invalidControl->dispatchEvent(eventNames().invalidEvent, false, true); if (eventCanceled && unhandledInvalidControls) unhandledInvalidControls->append(invalidControl); } return false; } -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:05:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:05:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090822010552.4515F35362CA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Michelangelo De Simone changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28649 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:08:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:08:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090822010820.078E63536349@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 Michelangelo De Simone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |micdesim at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:17:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:17:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090822011748.3ED4435365DA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Bug 19264 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:17:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:17:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28649] Support for interactive validation of form elements In-Reply-To: References: Message-ID: <20090822011748.903F53536646@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28649 Bug 28649 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:38:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:38:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28617] Bad CSSKeyframesRule&CSSKeyframeRule .type In-Reply-To: References: Message-ID: <20090822013855.22B4B35368AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28617 --- Comment #1 from LEPESME Jean-Baptiste 2009-08-21 18:38:54 PDT --- Created an attachment (id=38428) --> (https://bugs.webkit.org/attachment.cgi?id=38428) change VARIABLES_RULES to 9, and set the correct value to KEYFRAMES_RULE and KEYFRAME_RULE -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:44:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:44:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28617] Bad CSSKeyframesRule&CSSKeyframeRule .type In-Reply-To: References: Message-ID: <20090822014415.60A9C3536932@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28617 --- Comment #2 from LEPESME Jean-Baptiste 2009-08-21 18:44:14 PDT --- I made some research and I figured out that the css-variables features of webkit is non "standard" and not intended to be a part of CSS3. It seems to be based on http://disruptive-innovations.com/zoo/cssvariables/ wich use RuleType number 7. As css-animations should be in CSS3, i think that webkit had to change VARIABLES_RULES to another value to respect http://www.w3.org/TR/css3-animations/ . Bye, Jiboo. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:49:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:49:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28617] Bad CSSKeyframesRule&CSSKeyframeRule .type In-Reply-To: References: Message-ID: <20090822014913.7DB273536982@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28617 LEPESME Jean-Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Component|WebCore JavaScript |CSS -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:56:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:56:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28269] Inspector: Improve Cookie DataGrid to Show Hidden Data In-Reply-To: References: Message-ID: <20090822015614.A39003536A3A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28269 --- Comment #38 from Joseph Pecoraro 2009-08-21 18:56:14 PDT --- - Added the localizedStrings that were supposed to have landed in the first patch but most have gotten lost when ariya did the commit. - Made "Session" a localizedString as well. Donno how I missed that before. Should I close this bug? --- Landed in r47656 = f0c84dbeb8261b637a75a601fd799530971aa3e5 http://trac.webkit.org/changeset/47656 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:57:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:57:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090822015754.6D8F63536A7E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Bug 19264 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 18:57:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 18:57:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28649] Support for interactive validation of form elements In-Reply-To: References: Message-ID: <20090822015754.B1A5A3536A8E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28649 Bug 28649 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 19:12:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 19:12:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090822021245.1BE8F3536BB8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Bug 19264 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 19:12:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 19:12:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28649] Support for interactive validation of form elements In-Reply-To: References: Message-ID: <20090822021245.619F03536BC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28649 Bug 28649 depends on bug 28145, which changed state. Bug 28145 Summary: novalidate/formnovalidate support https://bugs.webkit.org/show_bug.cgi?id=28145 What |Old Value |New Value ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 19:39:29 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 19:39:29 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28269] Inspector: Improve Cookie DataGrid to Show Hidden Data In-Reply-To: References: Message-ID: <20090822023929.A2EA23536DC9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28269 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:18:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:18:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28651] New: Not use deprecated symbols in WebKitWebView example code Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28651 Summary: Not use deprecated symbols in WebKitWebView example code Product: WebKit Version: 528+ (Nightly build) Platform: Other URL: http://webkitgtk.org/reference/webkitgtk-WebKitWebView .html OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: javierjc1982 at gmail.com webkit_web_view_open () was replaced by webkit_web_view_load_uri () since 1.1.1 Patch following -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:36:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:36:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28651] Not use deprecated symbols in WebKitWebView example code In-Reply-To: References: Message-ID: <20090822033650.1FDEE35371C1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28651 Javier Jardón changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38429| |review? Flag| | --- Comment #1 from Javier Jardón 2009-08-21 20:36:49 PDT --- Created an attachment (id=38429) --> (https://bugs.webkit.org/attachment.cgi?id=38429) Substitute deprecated symbol in WebKitWebView example code -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:39:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:39:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28651] Not use deprecated symbols in WebKitWebView example code In-Reply-To: References: Message-ID: <20090822033946.0C7593537203@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28651 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38429|review? |review+, commit-queue+ Flag| | --- Comment #2 from Jan Alonzo 2009-08-21 20:39:45 PDT --- (From update of attachment 38429) r=me. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:51:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:51:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28651] Not use deprecated symbols in WebKitWebView example code In-Reply-To: References: Message-ID: <20090822035143.4C76435372D5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28651 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38429|review+, commit-queue+ | Flag| | --- Comment #3 from Eric Seidel 2009-08-21 20:51:43 PDT --- (From update of attachment 38429) Clearing flags on attachment: 38429 Committed r47661: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:51:46 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:51:46 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28651] Not use deprecated symbols in WebKitWebView example code In-Reply-To: References: Message-ID: <20090822035146.7A08635372E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28651 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #4 from Eric Seidel 2009-08-21 20:51:45 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 20:56:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 20:56:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28614] Unnecessary horizontal scrollbar in Gmail under Chromium. ScrollView::updateScrollbars uses stale value for off/on/auto scrollbar mode. In-Reply-To: References: Message-ID: <20090822035647.6BEBA3537363@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28614 Dave Hyatt changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38376|review?(hyatt at apple.com) |review- Flag| | --- Comment #2 from Dave Hyatt 2009-08-21 20:56:47 PDT --- (From update of attachment 38376) I am not convinced this is right. You aren't supposed to just always invoke visibleContentsResized. Also note that any change to this logic has to be replicated in WebDynamicScrollbarsView on Mac to keep the two in sync. Finally I see no reason to change the word "recur" to "recurse." They mean exactly the same thing, and changing around English just because you don't like it pisses me off. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 23:30:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 23:30:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit In-Reply-To: References: Message-ID: <20090822063059.B07603537DC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27980 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 23:42:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 23:42:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28652] New: Clean up fill image geometry calculation Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28652 Summary: Clean up fill image geometry calculation Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mitz at webkit.org Patch forthcoming. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 23:42:41 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 23:42:41 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26064] Typing 'window.location.href = "#content"' in the Console loads the Inspector in the inspected page In-Reply-To: References: Message-ID: <20090822064241.3D9503537EC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26064 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck at webkit.org --- Comment #3 from Joseph Pecoraro 2009-08-21 23:42:41 PDT --- Update. This now shows: > window.location.href https://bugs.webkit.org/show_bug.cgi?id=26064 > window.location.href = '#content' Not allowed to load local resource: file:///Applications/WebKit.app/Contents/Frameworks/10.5/WebCore.framework/Resources/inspector/inspector.html#content This begs the question, why does window.location properly show the inspected window's value, but on setting it seems to use the wrong environment. I did a quick test with iframes and was able to emulate the same weird (or at least unexpected) behavior with an inner iframe and window.top.location: http://bogojoker.com/x/location_test/ JavaScript on an iframe's page shows the outer page's url when it does window.top.location.href, but seems to use its own url when assigning to window.top.location.href. Its too late for me to look at any specifications! Thoughts? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Fri Aug 21 23:57:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Fri, 21 Aug 2009 23:57:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28652] Clean up fill image geometry calculation In-Reply-To: References: Message-ID: <20090822065714.0A3743538017@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28652 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38430| |review? Flag| | --- Comment #1 from mitz at webkit.org 2009-08-21 23:57:13 PDT --- Created an attachment (id=38430) --> (https://bugs.webkit.org/attachment.cgi?id=38430) Cleanup -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 01:11:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 01:11:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28653] New: Safari crashes after most recent nightly update Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28653 Summary: Safari crashes after most recent nightly update Product: WebKit Version: 420+ Platform: Macintosh OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Critical Priority: P1 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: sdudla_uk at yahoo.com After updating Webkit with the new nightly build I could not open the "Thank you" page and Safari crashed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 01:31:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 01:31:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28652] Clean up fill image geometry calculation In-Reply-To: References: Message-ID: <20090822083107.82CF23538715@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28652 --- Comment #2 from mitz at webkit.org 2009-08-22 01:31:07 PDT --- (From update of attachment 38430) I think I should also rename the 2nd parameter to calculateFillTileSize() to positioningAreaSize, to match the call site. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 01:55:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 01:55:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider In-Reply-To: References: Message-ID: <20090822085521.133C135388F7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28241 --- Comment #6 from Hin-Chung Lam 2009-08-22 01:55:20 PDT --- To add a bit more about the behavior of the volume slider: - When mouse over the mute button - Volume slider is shown either above the mute button or below the mute button (They will not overlap) - When mouse out of the volume slider or mute button, the volume slider will disappear The behavior of the volume slider will be similar to youtube. Also in this patch I don't include any theme implementation and by default -webkit-media-controls-volume-slider-container and -webkit-media-controls-volume-slider don't have renderers unless they are defined in css with a "display" value so they won't affect layout tests nor shown. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 02:34:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 02:34:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28653] Safari crashes after most recent nightly update In-Reply-To: References: Message-ID: <20090822093449.1E7AD3538C1A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28653 --- Comment #1 from Mark Rowe (bdash) 2009-08-22 02:34:48 PDT --- Please attach the crash log. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 05:26:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 05:26:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28654] New: MIME handling in qtwebkit network layer case-sensitivity Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28654 Summary: MIME handling in qtwebkit network layer case-sensitivity Product: WebKit Version: 528+ (Nightly build) Platform: All URL: http://www.buienradar.nl/images.aspx?jaar=-3&bliksem=0 &voor=&soort=verwachting1x1 OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: WebKit Qt AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rich at kde.org Created an attachment (id=38432) --> (https://bugs.webkit.org/attachment.cgi?id=38432) Patch to fix the bug The code in webkit assumes MIME types will be lower case, but QNetworkAccessManager returns the mime type exactly as it is sent by the remote server. The RFC says mime types are case-insensitive, so in the case of the URL above which sends image/GIF things should work just fine. Unfortunately that is not the case, qtwebkit believes this mime type to be unsupported wheras image/gif is fine. The fix is simply to lowercase the mimetype as it is passed from QNAM to webkit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 05:39:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 05:39:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28391] Incorrect casts in JavaScriptCore with gcc-3.4 In-Reply-To: References: Message-ID: <20090822123925.AB9953539AFB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28391 --- Comment #7 from Kelemen Balázs 2009-08-22 05:39:22 PDT --- I did not think I would start such an interesting conversation :) Anyway, my original wish (to be able to compile webkit with gcc-3.x) was not a valid conception, so I would close the bug. Should I close it, or you guys want to move on with the casting debate here? :-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 05:42:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 05:42:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28652] Clean up fill image geometry calculation In-Reply-To: References: Message-ID: <20090822124234.62A8D3539B87@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28652 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38430|review? |review+ Flag| | --- Comment #3 from Darin Adler 2009-08-22 05:42:32 PDT --- (From update of attachment 38430) > + calculateBackgroundSize() to this. Replaced spearate scaledWidth and Misspelling of separate here. r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 07:56:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 07:56:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] New: Webkit Crash on Launch Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28655 Summary: Webkit Crash on Launch Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh PowerPC OS/Version: Mac OS X 10.4 Status: UNCONFIRMED Severity: Blocker Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: john at film2disk.com Created an attachment (id=38433) --> (https://bugs.webkit.org/attachment.cgi?id=38433) Safari Crash Log Webkit crashes immediately on launch or while re-loading tabs. The following versions are failing on PPC in OS X 10.4.11 r47668 r47667 r47660 The last working version is r47639 Crash log attached... only 8/22/09 entries are relevant. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 08:26:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 08:26:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28391] Incorrect casts in JavaScriptCore with gcc-3.4 In-Reply-To: References: Message-ID: <20090822152620.289ED353AD43@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28391 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WONTFIX --- Comment #8 from Eric Seidel 2009-08-22 08:26:19 PDT --- Nah, we can close. Thank you for the patch though! And thanks to Gavin and Joe for following up with the C++ lesson. :) I certainly learned something! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 08:39:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 08:39:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24696] Enable mixed content detection In-Reply-To: References: Message-ID: <20090822153922.6CC3A353AE77@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24696 --- Comment #23 from Adam Barth 2009-08-22 08:39:21 PDT --- I should also say that there are a bunch of mixed content corner cases that these patches don't cover. The goal here is to get the APIs in place and have something minimally functional. We can handle the strange cases (e.g., redirects) in follow up bugs to ensure that we get good test coverage. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 08:52:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 08:52:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28612] Unclickable Links In-Reply-To: References: Message-ID: <20090822155220.6BE1A353B01D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28612 --- Comment #1 from Alexey Proskuryakov 2009-08-22 08:52:20 PDT --- I cannot reproduce this with a local debug build of r47661. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 09:15:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 09:15:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider In-Reply-To: References: Message-ID: <20090822161502.6C7B0353B2D3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28241 --- Comment #7 from Eric Carlson 2009-08-22 09:15:01 PDT --- This looks great to me, thanks Alpha! I think this is ready to land, but I won't r+ it as I am not a reviewer. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 09:33:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 09:33:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28652] Clean up fill image geometry calculation In-Reply-To: References: Message-ID: <20090822163323.8F31B353B47C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28652 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from mitz at webkit.org 2009-08-22 09:33:23 PDT --- Committed . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 09:36:12 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 09:36:12 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28609] Buttons are not rendered correctly when scrolling page In-Reply-To: References: Message-ID: <20090822163612.05A16353B4C2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28609 Dimitris Apostolou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Dimitris Apostolou 2009-08-22 09:36:11 PDT --- Verified with 6531.9, r47668 Closing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 09:41:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 09:41:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider In-Reply-To: References: Message-ID: <20090822164131.78CD3353B548@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28241 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38395|review? |review- Flag| | --- Comment #8 from Eric Seidel 2009-08-22 09:41:31 PDT --- (From update of attachment 38395) Strange to have WebCore:: on one and not the other: 03 if (m_isVisible) 204 style->setVisibility(VISIBLE); 205 else 206 style->setVisibility(WebCore::HIDDEN); I might have even written that style->setVisibility(m_visible ? VISIBLE : HIDDEN) Same in the next function below. Don't we only need to clone styles when they're not already shared? 1 RefPtr style = RenderStyle::clone(renderer()->style()); 222 if (visible) 223 style->setVisibility(VISIBLE); 224 else 225 style->setVisibility(WebCore::HIDDEN); Or maybe clone() is smart enough to do that. I don't understand this comment: 216 // This function is used during the RenderMedia::layout() 217 // call, where we cannot change the renderer at this time. 218 if (!renderer() || !renderer()->style()) 219 return; We should figure out if we always need to be cloning, or if there is a similar "make sure this style is not shared" method: 236 RefPtr style = RenderStyle::clone(renderer()->style()); Why not just "1"? 598 setAttribute(maxAttr, String::number(1)); Sometimes we have exception ignoring versions of dom methods which are only used internally: 614 ExceptionCode ec; 615 m_mediaElement->setVolume(volume, ec); I'm surprise we don't have one here. Do we need to ASSERT(!ec)? Isn't this doing a bunch of extra checks? 21 return MediaControlInputElement::rendererIsNeeded(style) && parent() && parent()->renderer() && parent()->renderer()->style()->visibility() == VISIBLE; RenderObject::rendererIsNeeded() takes care of all of that, no? Why do you need to override? Its a little sad that we have so many classes in these files. I'm not sure I fully understand: 494 void RenderMedia::updateVolumeSliderContainer(bool visible) Seems like a lot of code. ;) In general this looks fine, but there are a couple unanswered questions above. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 09:42:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 09:42:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider In-Reply-To: References: Message-ID: <20090822164208.6C293353B55E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28241 --- Comment #9 from Eric Seidel 2009-08-22 09:42:08 PDT --- I'm most concerned with the rendererIsNeeded implementation, and the possibly unecessary clone() calls. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 10:59:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 10:59:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28241] Media controls panel does not have a volume control slider In-Reply-To: References: Message-ID: <20090822175914.3F00D353BC8E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28241 --- Comment #10 from Eric Carlson 2009-08-22 10:59:13 PDT --- > I don't understand this comment: > 216 // This function is used during the RenderMedia::layout() > 217 // call, where we cannot change the renderer at this time. > 218 if (!renderer() || !renderer()->style()) > 219 return; Looks like the comment was copy/pasted from MediaControlTimeDisplayElement::setVisible and isn't relevant here. > Isn't this doing a bunch of extra checks? > 21 return MediaControlInputElement::rendererIsNeeded(style) && parent() && > parent()->renderer() && parent()->renderer()->style()->visibility() == VISIBLE; > RenderObject::rendererIsNeeded() takes care of all of that, no? Why do you > need to override? I don't see RenderObject::rendererIsNeeded? MediaControlInputElement::rendererIsNeeded does check "parent() && parent()->renderer()" so those aren't needed, but it doesn't check the visibility of the parent (the slider container). The question about whether or not this is needed at all is a fair one though. The other media control elements that override rendererIsNeeded do so because we want to force a re-layout when they appear/disappear, which is not the case with the volume slider since it is position absolute. > Sometimes we have exception ignoring versions of dom methods which are only > used internally: > 614 ExceptionCode ec; > 615 m_mediaElement->setVolume(volume, ec); > I'm surprise we don't have one here. This is the first internal use of setVolume, it seems a bit heavyweight to add a convenience method just yet. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:19:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:19:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28656] New: REGRESSION: r47676 hangs when loading page on Leopard/PPC Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28656 Summary: REGRESSION: r47676 hangs when loading page on Leopard/PPC Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh PowerPC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Blocker Priority: P1 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jon at jonshier.com Since my build last night, I've been getting this hang when trying to use ToT in Safari on Leopard/PPC. Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000008 Crashed Thread: 0 Thread 0 Crashed: 0 com.apple.JavaScriptCore 0x00523630 JSC::JSFunction::~JSFunction() + 48 1 com.apple.JavaScriptCore 0x0060e6a8 JSC::VPtrSet::VPtrSet() + 584 2 com.apple.JavaScriptCore 0x0060e6a8 JSC::VPtrSet::VPtrSet() + 584 3 com.apple.JavaScriptCore 0x0060f6a0 JSC::JSGlobalData::createLeaked() + 32 (JSGlobalData.cpp:105) 4 com.apple.WebCore 0x019d7ecc WebCore::JSDOMWindowBase::commonJSGlobalData() + 44 (JSDOMWindowBase.cpp:168) 5 com.apple.WebCore 0x019e20c4 WebCore::JSDOMWindowShell::operator new(unsigned long) + 20 (JSDOMWindowShell.cpp:152) 6 com.apple.WebCore 0x01d92474 WebCore::ScriptController::initScript() + 68 (ScriptController.cpp:162) 7 com.apple.WebCore 0x01d92984 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) + 340 (ScriptController.h:143) 8 com.apple.WebCore 0x017ebfb8 WebCore::FrameLoader::executeScript(WebCore::ScriptSourceCode const&) + 392 (FrameLoader.cpp:765) 9 com.apple.WebCore 0x018a8494 WebCore::HTMLTokenizer::scriptExecution(WebCore::ScriptSourceCode const&, WebCore::HTMLTokenizer::State) + 932 (HTMLTokenizer.cpp:561) 10 com.apple.WebCore 0x018a9224 WebCore::HTMLTokenizer::scriptHandler(WebCore::HTMLTokenizer::State) + 3380 (HTMLTokenizer.cpp:503) 11 com.apple.WebCore 0x018a98cc WebCore::HTMLTokenizer::parseNonHTMLText(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 476 (HTMLTokenizer.cpp:350) 12 com.apple.WebCore 0x018ac840 WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 10304 (HTMLTokenizer.cpp:1520) 13 com.apple.WebCore 0x018ad2d4 WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool) + 1204 (HTMLTokenizer.cpp:1748) 14 com.apple.WebCore 0x017f1f60 WebCore::FrameLoader::write(char const*, int, bool) + 1424 (FrameLoader.cpp:1020) 15 com.apple.WebKit 0x003209d8 -[WebFrame(WebInternal) _receivedData:textEncodingName:] + 312 (WebFrame.mm:981) 16 com.apple.WebKit 0x003384ec -[WebHTMLRepresentation receivedData:withDataSource:] + 124 (WebHTMLRepresentation.mm:162) 17 com.apple.WebKit 0x003109b4 -[WebDataSource(WebInternal) _receivedData:] + 84 (WebDataSource.mm:222) 18 com.apple.WebKit 0x003279b4 WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) + 116 (WebFrameLoaderClient.mm:801) 19 com.apple.WebCore 0x016cd798 WebCore::DocumentLoader::commitLoad(char const*, int) + 88 (DocumentLoader.cpp:342) 20 com.apple.WebCore 0x01d7c4a4 WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) + 68 (ResourceLoader.cpp:247) 21 com.apple.WebCore 0x01c2d9c4 WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) + 2324 (MainResourceLoader.cpp:352) 22 com.apple.Foundation 0x94bbb2d4 _NSURLConnectionDidReceiveData + 136 23 com.apple.CFNetwork 0x93cdbb48 URLConnectionClient::_clientDidReceiveData(__CFData const*, URLConnectionClient::ClientConnectionEventQueue*) + 256 24 com.apple.CFNetwork 0x93cdcb0c URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo*, long) + 432 25 com.apple.CFNetwork 0x93cdccd8 URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo*, long) + 892 26 com.apple.CFNetwork 0x93cdb500 URLConnectionClient::processEvents() + 132 27 com.apple.CFNetwork 0x93c85020 MultiplexerSource::perform() + 168 28 com.apple.CoreFoundation 0x917950d0 CFRunLoopRunSpecific + 1104 29 com.apple.HIToolbox 0x90033b14 RunCurrentEventLoopInMode + 264 30 com.apple.HIToolbox 0x900338a0 ReceiveNextEventCommon + 260 31 com.apple.HIToolbox 0x90033778 BlockUntilNextEventMatchingListInMode + 84 32 com.apple.AppKit 0x92c08244 _DPSNextEvent + 596 33 com.apple.AppKit 0x92c07bfc -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 112 34 com.apple.SafariTest 0x0000db9c 0x1000 + 52124 35 com.apple.AppKit 0x92c0189c -[NSApplication run] + 744 36 com.apple.AppKit 0x92bd2298 NSApplicationMain + 440 37 com.apple.SafariTest 0x00002fcc 0x1000 + 8140 Application launches fine, but when I try to load a page (I have it set to a blank page by default) it either freezes immediately, or after slightly loading the page. From the look of the trace, probably when it tries JS activity for the first time. I first noticed this problem at r47660. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:22:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:22:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090822182211.B8184353BF0D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38434| |review? Flag| | --- Comment #1 from Xan Lopez 2009-08-22 11:22:11 PDT --- Created an attachment (id=38434) --> (https://bugs.webkit.org/attachment.cgi?id=38434) editingbehavior.patch Turns out there's already a setting to control precisely this stuff, so just expose it and adjust our default value to be more GTK+-like. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:25:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:25:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 4076] Loading www.fed-soc.org causes hang (eventually finishes) In-Reply-To: References: Message-ID: <20090822182556.97FE4353BF78@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=4076 --- Comment #16 from Jon 2009-08-22 11:25:56 PDT --- Although the website has been update to be much more modern, the webarchive David attached still causes a beachball, even with Safari 4.0.3 on Leopard/PPC with a Quad G5. I'm just going through my old bugs and wanted to bump this and see whether it's still something to be fixed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:29:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:29:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28657] New: Form post to IFRAME change browser history Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28657 Summary: Form post to IFRAME change browser history Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://beta.livadnyy.com/demo OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: History AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mikhail.v.gavrilov at gmail.com 1. go to http://beta.livadnyy.com/demo 2. post some data 3. see changes in browser history and press back browser button 4. compare Opera action with action FF and IE Expected that: 1) Back button must be inactive. 2) No extra entry in browser history. Actually happens: 1) Browser 'Back' button is active. 2) In browser history an extra entry. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:30:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:30:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 6070] Yahoo TV listings only render correctly if refreshed/loaded from active cache. In-Reply-To: References: Message-ID: <20090822183038.E6060353BFEB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=6070 Jon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #20 from Jon 2009-08-22 11:30:38 PDT --- I'm going to go ahead and resolve this bug, as Yahoo has significantly change their TV listings page and the webarchive attached to this bug doesn't contain all the resources necessary to reproduce the page. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:33:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:33:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 10024] iBench should be in the repository to be runnable by opensource users In-Reply-To: References: Message-ID: <20090822183337.AD0BE353C03B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=10024 --- Comment #1 from Jon 2009-08-22 11:33:37 PDT --- Although SunSpider has been added, the WebKit repository still lacks a general performance suite that tests more aspects of the rendering system. It may still be useful for WebKit to have a general suite to run regression tests against, but I'll leave that for someone else to decide. If not, you can go ahead and close out this bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 11:35:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 11:35:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 4225] please add way to build without symbols for better speed, less memory use, less size on disk In-Reply-To: References: Message-ID: <20090822183507.A330A353C069@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=4225 Jon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #1 from Jon 2009-08-22 11:35:07 PDT --- Closing this out, as I don't think there's really a solution. Besides, I don't use this machine anymore. :D -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 12:15:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 12:15:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28062] Crash on image drag In-Reply-To: References: Message-ID: <20090822191528.D878B353C3BA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28062 Kevin Ollivier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED AssignedTo|webkit-unassigned at lists.web |kevino at theolliviers.com |kit.org | Ever Confirmed|0 |1 --- Comment #2 from Kevin Ollivier 2009-08-22 12:15:28 PDT --- assigning to me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 12:54:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 12:54:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26609] Support CSS3 attr() function In-Reply-To: References: Message-ID: <20090822195403.DA10B353C734@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26609 Erik Arvidsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arv at chromium.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 12:58:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 12:58:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28658] New: POST'd forms behave different from Firefox Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28658 Summary: POST'd forms behave different from Firefox Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh URL: http://www.phpbb.com/community/ OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jon at jonshier.com In the phpBB3 forum software, the Jump To: form uses the POST method to grab the forum the user wants. After viewing a topic in the jumped to forum, the back button produces the "resubmit form" dialog in Safari. This doesn't happen in Firefox (3.5). Also, this doesn't seem to be the desired behavior, as the content of the page the user wants to go back to isn't determined by the form data, but by the URL it produces. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 13:29:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 13:29:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090822202945.07D4C353CA4F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38434|review? |review+ Flag| | --- Comment #2 from Jan Alonzo 2009-08-22 13:29:44 PDT --- (From update of attachment 38434) Hi Xan > +WebCore::EditingBehavior core(WebKitEditingBehavior type) > +{ > + return (WebCore::EditingBehavior)type; Is it possible to use c++ style casts here? > > +typedef enum { > + WEBKIT_EDITING_BEHAVIOR_MAC, > + WEBKIT_EDITING_BEHAVIOR_WINDOWS > +} WebKitEditingBehavior; Is it possible to add a COMPILE_ASSERT for these just in case of future changes? Thanks. r=me with those changes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 13:30:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 13:30:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24862] REGRESSION: Backspacing link from new line adds "text-decoration: none" to style In-Reply-To: References: Message-ID: <20090822203022.322BF353CA73@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24862 Ryosuke Niwa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rniwa at webkit.org --- Comment #11 from Ryosuke Niwa 2009-08-22 13:30:21 PDT --- I think my patches have fixed this bug. It does not reproduce on Chrome 3.0.195. Could someone with Mac try it on the nightly build of WebKit? And if it passes, please add a test case that fails on old WebKit. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 13:53:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 13:53:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28614] Unnecessary horizontal scrollbar in Gmail under Chromium. ScrollView::updateScrollbars uses stale value for off/on/auto scrollbar mode. In-Reply-To: References: Message-ID: <20090822205350.489A1353CCF6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28614 Mark Mentovai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38376|0 |1 is obsolete| | Attachment #38436| |review?(hyatt at apple.com) Flag| | --- Comment #3 from Mark Mentovai 2009-08-22 13:53:49 PDT --- Created an attachment (id=38436) --> (https://bugs.webkit.org/attachment.cgi?id=38436) Perform layout before checking scrollbar modes > I am not convinced this is right. You aren't supposed to just always invoke > visibleContentsResized. The existing code always calls visibleContentsResized, though. I'm just moving the call up earlier to avoid using stale data for the off/on/auto value. There's one additional behavior change. The existing code avoids visibleContentsResized if if both the horizontal and vertical scrollbars are forced on or off. With the proposed patch, this is not taken into account. I considered writing the patch to respect these values, but felt that would be unwise. The bug as it relates to Gmail involves the vertical scrollbar mode being changed from auto to forced-on during the call to visibleContentsResized. It seems just as plausible for forced-on/off scrollbars to change back to auto in that call. > Also note that any change to this logic has to be replicated in > WebDynamicScrollbarsView on Mac to keep the two in sync. This version of the patch takes that into account. It also moves a couple of minor things around, with no functional changes, to keep it synchronized with ScrollView::updateScrollbars. > Finally I see no reason to change the word "recur" to "recurse." They mean > exactly the same thing, and changing around English just because you don't like > it pisses me off. OK. It should be pretty clear that I didn't intend to piss anyone off. I've run this through the layout test suite and it doesn't introduce any regressions. It fixes the Gmail bug in Chromium. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 14:07:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 14:07:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28656] REGRESSION: r47676 hangs when loading page on Leopard/PPC In-Reply-To: References: Message-ID: <20090822210715.2E73D353CE29@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28656 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE --- Comment #1 from Mark Rowe (bdash) 2009-08-22 14:07:14 PDT --- *** This bug has been marked as a duplicate of bug 28655 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 14:07:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 14:07:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] Webkit Crash on Launch In-Reply-To: References: Message-ID: <20090822210715.4878B353CE2F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jon at jonshier.com --- Comment #1 from Mark Rowe (bdash) 2009-08-22 14:07:14 PDT --- *** Bug 28656 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 14:08:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 14:08:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090822210822.B3488353CE43@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Webkit Crash on Launch |REGRESSION(r47639-r47660): | |Webkit crashes on launch on | |PowerPC -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 14:11:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 14:11:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090822211154.E37AC353CEC2@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barraclough at apple.com --- Comment #2 from Mark Rowe (bdash) 2009-08-22 14:11:54 PDT --- This is probably due to . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 15:34:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 15:34:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26609] Support CSS3 attr() function In-Reply-To: References: Message-ID: <20090822223443.81DE9353D5C9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26609 Jeff Balogh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbalogh at mozilla.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 16:20:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 16:20:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28612] Unclickable Links In-Reply-To: References: Message-ID: <20090822232013.6BADC353D991@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28612 John Moe changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #2 from John Moe 2009-08-22 16:20:13 PDT --- This reliably happens with r47546, but is fixed by r47639. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 17:17:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 17:17:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28660] New: Thread 0 Crashed: Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28660 Summary: Thread 0 Crashed: Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh PowerPC OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: shawnzone at gmail.com Builds r47676, r47668, r47660 same crash logs. (r47639 no problems) Process: Safari [69805] Path: /Applications/WebKit.app/Contents/MacOS/WebKit Identifier: org.webkit.nightly.WebKit Version: r47676 (47676) Code Type: PPC (Native) Parent Process: launchd [469] Date/Time: 2009-08-22 18:34:26.156 -0500 OS Version: Mac OS X 10.5.8 (9L30) Report Version: 6 Anonymous UUID: 96548AF0-6A22-4107-9626-B3BEB2435548 Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000008 Crashed Thread: 0 Thread 0 Crashed: 0 com.apple.JavaScriptCore 0x004b2410 JSC::JSFunction::~JSFunction() + 48 1 com.apple.JavaScriptCore 0x005a97e8 JSC::VPtrSet::VPtrSet() + 584 2 com.apple.JavaScriptCore 0x005a97e8 JSC::VPtrSet::VPtrSet() + 584 3 com.apple.JavaScriptCore 0x005aa7e0 JSC::JSGlobalData::createLeaked() + 32 4 com.apple.WebCore 0x0143f66c WebCore::JSDOMWindowBase::commonJSGlobalData() + 44 5 com.apple.WebCore 0x014497f4 WebCore::JSDOMWindowShell::operator new(unsigned long) + 20 6 com.apple.WebCore 0x017f8b64 WebCore::ScriptController::initScript() + 68 7 com.apple.WebCore 0x017f8f24 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) + 340 8 com.apple.WebCore 0x012550d8 WebCore::FrameLoader::executeScript(WebCore::ScriptSourceCode const&) + 392 9 com.apple.WebCore 0x01311c34 WebCore::HTMLTokenizer::scriptExecution(WebCore::ScriptSourceCode const&, WebCore::HTMLTokenizer::State) + 932 10 com.apple.WebCore 0x013129b4 WebCore::HTMLTokenizer::scriptHandler(WebCore::HTMLTokenizer::State) + 3364 11 com.apple.WebCore 0x0131305c WebCore::HTMLTokenizer::parseNonHTMLText(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 476 12 com.apple.WebCore 0x01315fcc WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 10300 13 com.apple.WebCore 0x01316a60 WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool) + 1200 14 com.apple.WebCore 0x0125b6b0 WebCore::FrameLoader::write(char const*, int, bool) + 1424 15 com.apple.WebKit 0x0032e098 -[WebFrame(WebInternal) _receivedData:textEncodingName:] + 312 16 com.apple.WebKit 0x003457dc -[WebHTMLRepresentation receivedData:withDataSource:] + 124 17 com.apple.WebKit 0x0031d594 -[WebDataSource(WebInternal) _receivedData:] + 84 18 com.apple.WebKit 0x00334424 WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) + 116 19 com.apple.WebCore 0x01137cc8 WebCore::DocumentLoader::commitLoad(char const*, int) + 88 20 com.apple.WebCore 0x017e27d4 WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) + 68 21 com.apple.WebCore 0x01694dd4 WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) + 2324 22 com.apple.Foundation 0x940af2d4 _NSURLConnectionDidReceiveData + 136 23 com.apple.CFNetwork 0x9735db48 URLConnectionClient::_clientDidReceiveData(__CFData const*, URLConnectionClient::ClientConnectionEventQueue*) + 256 24 com.apple.CFNetwork 0x9735eb0c URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo*, long) + 432 25 com.apple.CFNetwork 0x9735d500 URLConnectionClient::processEvents() + 132 26 com.apple.CFNetwork 0x97307020 MultiplexerSource::perform() + 168 27 com.apple.CoreFoundation 0x913d80d0 CFRunLoopRunSpecific + 1104 28 com.apple.HIToolbox 0x9228eb14 RunCurrentEventLoopInMode + 264 29 com.apple.HIToolbox 0x9228e938 ReceiveNextEventCommon + 412 30 com.apple.HIToolbox 0x9228e778 BlockUntilNextEventMatchingListInMode + 84 31 com.apple.AppKit 0x95a0a244 _DPSNextEvent + 596 32 com.apple.AppKit 0x95a09bfc -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 112 33 com.apple.Safari 0x0000db9c 0x1000 + 52124 34 com.apple.AppKit 0x95a0389c -[NSApplication run] + 744 35 com.apple.AppKit 0x959d4298 NSApplicationMain + 440 36 com.apple.Safari 0x00002fcc 0x1000 + 8140 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 17:33:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 17:33:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823003325.CAA26353DEB9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shawnzone at gmail.com --- Comment #3 from Mark Rowe (bdash) 2009-08-22 17:33:25 PDT --- *** Bug 28660 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 17:33:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 17:33:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28660] Thread 0 Crashed: In-Reply-To: References: Message-ID: <20090823003325.C5D43353DEB7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28660 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE --- Comment #1 from Mark Rowe (bdash) 2009-08-22 17:33:25 PDT --- *** This bug has been marked as a duplicate of bug 28655 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 17:42:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 17:42:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28653] Safari crashes after most recent nightly update In-Reply-To: References: Message-ID: <20090823004232.DDB83353DF4B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28653 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Alias|sdudla_uk at yahoo.com | --- Comment #2 from Mark Rowe (bdash) 2009-08-22 17:42:32 PDT --- This is probably the same as bug 28655, but since there's no actual information it's impossible to say for sure at this point. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 18:53:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 18:53:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28362] SVG Filter feComposite implementation is missing In-Reply-To: References: Message-ID: <20090823015307.04F6C353E683@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28362 Nikolas Zimmermann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35118|review? |review+, commit-queue- Flag| | --- Comment #4 from Nikolas Zimmermann 2009-08-22 18:53:06 PDT --- (From update of attachment 35118) r+, some comments, before landing; > + 2008 Dirk Schulze 2009. > +inline void arithmetic(const RefPtr& srcPixelArrayA, CanvasPixelArray*& srcPixelArrayB, > + const float& k1, const float& k2, const float& k3, const float& k4) s/const float&/float/. We don't use this style in WebKit, even though it's correct, there's no gain. > + FloatRect srcRect = FloatRect(0, 0, -1, -1); Use (0.0f, 0.0f, -1.0f, -1.0f) to be consistent with other callsites. > + switch (m_type) { > + case FECOMPOSITE_OPERATOR_OVER: > + case FECOMPOSITE_OPERATOR_IN: > + case FECOMPOSITE_OPERATOR_OUT: > + case FECOMPOSITE_OPERATOR_ATOP: > + case FECOMPOSITE_OPERATOR_XOR: > + case FECOMPOSITE_OPERATOR_ARITHMETIC: { Indention, case & switch should be aligned. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 18:56:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 18:56:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28661] New: ANY Flickr.com page with thumbnails, especially the recents and "your homepage" Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28661 Summary: ANY Flickr.com page with thumbnails, especially the recents and "your homepage" Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel URL: http://www.flickr.com/recent/ OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Major Priority: P2 Component: Layout and Rendering AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: alin0steglinski at gmail.com Created an attachment (id=38440) --> (https://bugs.webkit.org/attachment.cgi?id=38440) Flickr failure to load In flickr.com when you immediately log in you are taken to your personal homepage, in current nightlies none of the images are clickable directly unless you click the very bottom edge, this is not normal function. Some images fail to load except the bottom clickable edge alltogether. A web archive of the problem resolves the problem, although when flickr.com is viewed in real time it fails to load images sometimes as seen in the attached screenshot along with the only bottom edge clickable problem as stated above. I am not a developer but this function is not correct and has something to do with rendering / layout. This limits the usability of the browser for me severely and I am sure anyone else with this bug is impacted severely by it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 19:03:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 19:03:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28661] ANY Flickr.com page with thumbnails, especially the recents and "your homepage" In-Reply-To: References: Message-ID: <20090823020355.A109F353E746@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28661 --- Comment #1 from Alin S 2009-08-22 19:03:55 PDT --- in addition requested by bdash in IRC I am using build #47677 I first formally noticed this about 2-3 nights ago, somewhere around build #47546 or the build before it, but no more than 5 days ago. I have 1password installed, I tried this on my fresh install on a different computer and there is no difference. still bugged. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 20:22:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 20:22:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 15133] Repair missing alternative text where possible, allow user labelling where not In-Reply-To: References: Message-ID: <20090823032222.D0C5A353ED02@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=15133 chris fleizach changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |cfleizach at apple.com Resolution| |FIXED --- Comment #2 from chris fleizach 2009-08-22 20:22:22 PDT --- WebKit provides VoiceOver with a lot more information about images now, include the URL. VoiceOver makes use of the URL if there's no other information Also in SnowLeopard VoiceOver allows user labeling of images (http://www.apple.com/macosx/accessibility/) So I consider this bug resolved -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 20:28:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 20:28:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 6070] Yahoo TV listings only render correctly if refreshed/loaded from active cache. In-Reply-To: References: Message-ID: <20090823032840.2ED1C353ED71@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=6070 --- Comment #21 from David Kilzer (ddkilzer) 2009-08-22 20:28:39 PDT --- (In reply to comment #20) > I'm going to go ahead and resolve this bug, as Yahoo has significantly change > their TV listings page and the webarchive attached to this bug doesn't contain > all the resources necessary to reproduce the page. Unfortunately, the webarchive didn't contain all the resources necessary to reproduce the issue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 21:45:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 21:45:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28480] Don't let local files access web URLs In-Reply-To: References: Message-ID: <20090823044505.94884353F375@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28480 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | AssignedTo|abarth at webkit.org |webkit-unassigned at lists.web | |kit.org --- Comment #14 from Adam Barth 2009-08-22 21:45:04 PDT --- After a discussion on IRC, I've reverted this change. The consensus was to make this change later after various clients have had a chance to opt into the insecure setting if they need it for some reason. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 21:45:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 21:45:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823044550.13189353F396@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Maciej Stachowiak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38443| |review? Flag| | --- Comment #4 from Maciej Stachowiak 2009-08-22 21:45:49 PDT --- Created an attachment (id=38443) --> (https://bugs.webkit.org/attachment.cgi?id=38443) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 21:49:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 21:49:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823044933.9160E353F3DC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38443|review? |review+ Flag| | --- Comment #5 from Mark Rowe (bdash) 2009-08-22 21:49:33 PDT --- (From update of attachment 38443) r=me (without the Platform.h changes!) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:02:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:02:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823050224.92481353F4EA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Maciej Stachowiak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38443|review+ | Flag| | Attachment #38443|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:02:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:02:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823050228.9D20C353F4F9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Maciej Stachowiak changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38444| |review? Flag| | --- Comment #6 from Maciej Stachowiak 2009-08-22 22:02:28 PDT --- Created an attachment (id=38444) --> (https://bugs.webkit.org/attachment.cgi?id=38444) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:04:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:04:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823050408.7EF98353F513@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38444|review? |review+ Flag| | --- Comment #7 from Mark Rowe (bdash) 2009-08-22 22:04:08 PDT --- (From update of attachment 38444) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:05:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:05:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28480] Don't let local files access web URLs In-Reply-To: References: Message-ID: <20090823050503.8CCAA353F541@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28480 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrowe at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:12:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:12:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28662] New: Build r47677 crashes on launch Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28662 Summary: Build r47677 crashes on launch Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Major Priority: P2 Component: New Bugs AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: sdudla_uk at yahoo.com On launching Safari it hangs with "Go to this site" showing n the window then it crashes. Process: Safari [88542] Path: /Applications/WebKit.app/Contents/MacOS/WebKit Identifier: org.webkit.nightly.WebKit Version: r47677 (47677) Code Type: PPC (Native) Parent Process: launchd [97] Interval Since Last Report: 79913 sec Crashes Since Last Report: 7 Per-App Interval Since Last Report: 22 sec Per-App Crashes Since Last Report: 1 Date/Time: 2009-08-23 05:57:54.622 +0100 OS Version: Mac OS X 10.5.8 (9L30) Report Version: 6 Anonymous UUID: 97C14EDF-71F7-4228-AEDF-1A99FE7699B7 Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000008 Crashed Thread: 0 Thread 0 Crashed: 0 com.apple.JavaScriptCore 0x004ac410 JSC::JSFunction::~JSFunction() + 48 1 com.apple.JavaScriptCore 0x005a37e8 JSC::VPtrSet::VPtrSet() + 584 2 com.apple.JavaScriptCore 0x005a37e8 JSC::VPtrSet::VPtrSet() + 584 3 com.apple.JavaScriptCore 0x005a47e0 JSC::JSGlobalData::createLeaked() + 32 4 com.apple.WebCore 0x0143f66c WebCore::JSDOMWindowBase::commonJSGlobalData() + 44 5 com.apple.WebCore 0x014497f4 WebCore::JSDOMWindowShell::operator new(unsigned long) + 20 6 com.apple.WebCore 0x017f8b64 WebCore::ScriptController::initScript() + 68 7 com.apple.WebCore 0x017f8f24 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) + 340 8 com.apple.WebCore 0x012550d8 WebCore::FrameLoader::executeScript(WebCore::ScriptSourceCode const&) + 392 9 com.apple.WebCore 0x01311c34 WebCore::HTMLTokenizer::scriptExecution(WebCore::ScriptSourceCode const&, WebCore::HTMLTokenizer::State) + 932 10 com.apple.WebCore 0x013129b4 WebCore::HTMLTokenizer::scriptHandler(WebCore::HTMLTokenizer::State) + 3364 11 com.apple.WebCore 0x0131305c WebCore::HTMLTokenizer::parseNonHTMLText(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 476 12 com.apple.WebCore 0x01315fcc WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 10300 13 com.apple.WebCore 0x01316a60 WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool) + 1200 14 com.apple.WebCore 0x0125b6b0 WebCore::FrameLoader::write(char const*, int, bool) + 1424 15 com.apple.WebKit 0x00328098 -[WebFrame(WebInternal) _receivedData:textEncodingName:] + 312 16 com.apple.WebKit 0x0033f7dc -[WebHTMLRepresentation receivedData:withDataSource:] + 124 17 com.apple.WebKit 0x00317594 -[WebDataSource(WebInternal) _receivedData:] + 84 18 com.apple.WebKit 0x0032e424 WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) + 116 19 com.apple.WebCore 0x01137cc8 WebCore::DocumentLoader::commitLoad(char const*, int) + 88 20 com.apple.WebCore 0x017e27d4 WebCore::ResourceLoader::didReceiveData(char const*, int, long long, bool) + 68 21 com.apple.WebCore 0x01694dd4 WebCore::MainResourceLoader::didReceiveData(char const*, int, long long, bool) + 2324 22 com.apple.Foundation 0x9535f2d4 _NSURLConnectionDidReceiveData + 136 23 com.apple.CFNetwork 0x90274b48 URLConnectionClient::_clientDidReceiveData(__CFData const*, URLConnectionClient::ClientConnectionEventQueue*) + 256 24 com.apple.CFNetwork 0x90275b0c URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo*, long) + 432 25 com.apple.CFNetwork 0x90275cd8 URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload(XConnectionEventInfo*, long) + 892 26 com.apple.CFNetwork 0x90274500 URLConnectionClient::processEvents() + 132 27 com.apple.CFNetwork 0x9021e020 MultiplexerSource::perform() + 168 28 com.apple.CoreFoundation 0x9569419c CFRunLoopRunSpecific + 1308 29 com.apple.HIToolbox 0x90ae6b14 RunCurrentEventLoopInMode + 264 30 com.apple.HIToolbox 0x90ae68a0 ReceiveNextEventCommon + 260 31 com.apple.HIToolbox 0x90ae6778 BlockUntilNextEventMatchingListInMode + 84 32 com.apple.AppKit 0x94625244 _DPSNextEvent + 596 33 com.apple.AppKit 0x94624bfc -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 112 34 com.apple.Safari 0x0000db9c 0x1000 + 52124 35 com.apple.AppKit 0x9461e89c -[NSApplication run] + 744 36 com.apple.AppKit 0x945ef298 NSApplicationMain + 440 37 com.apple.Safari 0x00002fcc 0x1000 + 8140 38 ??? 0xbffff9b0 0 + 3221223856 Thread 1: 0 libSystem.B.dylib 0x92ce0c0c __semwait_signal + 12 1 libSystem.B.dylib 0x92d1d46c _pthread_cond_wait + 1580 2 com.apple.JavaScriptCore 0x004a4808 WTF::TCMalloc_PageHeap::scavengerThread() + 104 3 com.apple.JavaScriptCore 0x004a49dc WTF::TCMalloc_PageHeap::runScavengerThread(void*) + 12 4 libSystem.B.dylib 0x92d1c0c4 _pthread_start + 316 Thread 2: 0 libSystem.B.dylib 0x92ce0c0c __semwait_signal + 12 1 libSystem.B.dylib 0x92d1d46c _pthread_cond_wait + 1580 2 com.apple.WebCore 0x013235c0 WebCore::IconDatabase::syncThreadMainLoop() + 304 3 com.apple.WebCore 0x013241e4 WebCore::IconDatabase::iconDatabaseSyncThread() + 420 4 libSystem.B.dylib 0x92d1c0c4 _pthread_start + 316 Thread 3: 0 libSystem.B.dylib 0x92cda1f8 mach_msg_trap + 8 1 libSystem.B.dylib 0x92ce111c mach_msg + 56 2 com.apple.CoreFoundation 0x95694394 CFRunLoopRunSpecific + 1812 3 com.apple.CFNetwork 0x901f03b0 CFURLCacheWorkerThread(void*) + 288 4 libSystem.B.dylib 0x92d1c0c4 _pthread_start + 316 Thread 4: 0 libSystem.B.dylib 0x92cda1f8 mach_msg_trap + 8 1 libSystem.B.dylib 0x92ce111c mach_msg + 56 2 com.apple.Safari 0x00028254 0x1000 + 160340 Thread 5: 0 libSystem.B.dylib 0x92cda1f8 mach_msg_trap + 8 1 libSystem.B.dylib 0x92ce111c mach_msg + 56 2 com.apple.CoreFoundation 0x95694394 CFRunLoopRunSpecific + 1812 3 com.apple.Foundation 0x9535dd50 +[NSURLConnection(NSURLConnectionReallyInternal) _resourceLoadLoop:] + 280 4 com.apple.Foundation 0x95306d84 __NSThread__main__ + 1004 5 libSystem.B.dylib 0x92d1c0c4 _pthread_start + 316 Thread 0 crashed with PPC Thread State 32: srr0: 0x004ac410 srr1: 0x0000d030 dar: 0x00000008 dsisr: 0x40000000 r0: 0x005a37ec r1: 0xbfffce50 r2: 0x005f9e00 r3: 0x07495000 r4: 0xbfffcf38 r5: 0x00000000 r6: 0xbfffcef0 r7: 0x00000020 r8: 0x006ac278 r9: 0x00000000 r10: 0x004ac1fc r11: 0x00000007 r12: 0x004ac4f0 r13: 0x01a3379c r14: 0x07454a20 r15: 0x01a3379c r16: 0x01313900 r17: 0x00000004 r18: 0x00000001 r19: 0xbfffd710 r20: 0xbfffd67c r21: 0x00000000 r22: 0xbfffd82c r23: 0x00000000 r24: 0xbfffd35c r25: 0xbfffd768 r26: 0xbfffcfa0 r27: 0xfffffffb r28: 0x00000000 r29: 0x07495000 r30: 0x07495000 r31: 0x004ac3ec cr: 0x42444222 xer: 0x20000000 lr: 0x004ac3ec ctr: 0x004ac4f0 vrsave: 0x00000000 Binary Images: 0x1000 - 0x29bff7 com.apple.Safari 4.0.3 (5531.9) <795e1a0d97f24320146a4858c7593cf1> /Applications/Safari.app/Contents/MacOS/Safari 0x2f7000 - 0x2f9ffa +WebKitNightlyEnabler.dylib ??? (???) /Applications/WebKit.app/Contents/Resources/WebKitNightlyEnabler.dylib 0x2fe000 - 0x3e9ff4 com.apple.WebKit r47677 (532.0+) <152e3b762e57602c60c19c8dfba00f6f> /Applications/WebKit.app/Contents/Frameworks/10.5/WebKit.framework/Versions/A/WebKit 0x47c000 - 0x48cffc SyndicationUI ??? (???) /System/Library/PrivateFrameworks/SyndicationUI.framework/Versions/A/SyndicationUI 0x49c000 - 0x5f6ffb com.apple.JavaScriptCore 532+ (532.0+) <541841aeca70f5345391d4cb72e8d5b7> /Applications/WebKit.app/Contents/Frameworks/10.5/JavaScriptCore.framework/Versions/A/JavaScriptCore 0x63f000 - 0x667ff3 +org.andymatuschak.Sparkle 1.5 Beta (git) (830f633) <89470a32f74cddfa6b449f225901c6da> /Applications/WebKit.app/Contents/Frameworks/10.5/Sparkle.framework/Versions/A/Sparkle 0xfcc000 - 0x1a2fff2 com.apple.WebCore 532+ (532.0+) <19a14035d47b3c6e429b2b65c0791450> /Applications/WebKit.app/Contents/Frameworks/10.5/WebCore.framework/Versions/A/WebCore 0x31c6000 - 0x33adff3 com.apple.RawCamera.bundle 2.1.0 (474) /System/Library/CoreServices/RawCamera.bundle/Contents/MacOS/RawCamera 0x719a000 - 0x71a0fff libCGXCoreImage.A.dylib ??? (???) <5720828f2c3c017f1691d10ee6b73915> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGXCoreImage.A.dylib 0x8fe00000 - 0x8fe30c23 dyld 97.1 (???) <89a0055b0e7ea2db881b73c6e63bc774> /usr/lib/dyld 0x90003000 - 0x90003ffa com.apple.CoreServices 32 (32) <42b6dda539f7411606187335d9eae0c5> /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices 0x90004000 - 0x90099ff7 com.apple.framework.IOKit 1.5.2 (???) /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit 0x900a0000 - 0x901ecffb com.apple.ImageIO.framework 2.0.6 (2.0.6) <666390f7230cc01b3366106b8894fc46> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/ImageIO 0x901ed000 - 0x902a0ffc com.apple.CFNetwork 438.14 (438.14) <6e213ab40eabfc276ca46a7c7cfad01a> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork 0x902c4000 - 0x902deffb com.apple.CoreVideo 1.6.0 (20.0) /System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo 0x902df000 - 0x903f3ffa com.apple.vImage 3.0 (3.0) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage 0x904eb000 - 0x904ebfff com.apple.audio.units.AudioUnit 1.5 (1.5) /System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit 0x904ec000 - 0x90658ff9 com.apple.AddressBook.framework 4.1.2 (702) <00009729166ef5c0294f864e1c4e54c9> /System/Library/Frameworks/AddressBook.framework/Versions/A/AddressBook 0x90659000 - 0x9066cfff com.apple.LangAnalysis 1.6.5 (1.6.5) <2a661ad6e432dd62dd831e234904061f> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis 0x9066d000 - 0x90680ffb com.apple.speech.synthesis.framework 3.7.1 (3.7.1) <050180a659a3905ea38f2acddcdf7b40> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis 0x90681000 - 0x9073bfff libcrypto.0.9.7.dylib ??? (???) <4b5031781db984ba920156875ec2a772> /usr/lib/libcrypto.0.9.7.dylib 0x9073c000 - 0x90884ff3 libicucore.A.dylib ??? (???) <07d0cefd48d11d5d5b1817c198013f0b> /usr/lib/libicucore.A.dylib 0x90885000 - 0x90885ffe com.apple.quartzframework 1.5 (1.5) <1477ba992c53f43087c7527c4782fd54> /System/Library/Frameworks/Quartz.framework/Versions/A/Quartz 0x90886000 - 0x90908fff com.apple.print.framework.PrintCore 5.5.4 (245.6) <3cde2550ec10348b7162d2b6cb0dfc67> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore 0x90909000 - 0x90917fff libz.1.dylib ??? (???) <1a70dd3594a8c5ad39d785af5da23237> /usr/lib/libz.1.dylib 0x90918000 - 0x9097dffb com.apple.ISSupport 1.8 (38.3) /System/Library/PrivateFrameworks/ISSupport.framework/Versions/A/ISSupport 0x9097e000 - 0x909c0fff com.apple.quartzfilters 1.5.0 (1.5.0) <3f2dc01a646cd5b5ea55d510583ba4d5> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuartzFilters.framework/Versions/A/QuartzFilters 0x909c1000 - 0x90a57fff com.apple.LaunchServices 291 (291) <37e4296a8c233e90c8990634264c294c> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices 0x90a58000 - 0x90ab5ffb com.apple.HIServices 1.7.1 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices 0x90ab6000 - 0x90defff7 com.apple.HIToolbox 1.5.6 (???) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox 0x90df0000 - 0x90ed3fff libobjc.A.dylib ??? (???) /usr/lib/libobjc.A.dylib 0x90eda000 - 0x911dcffb com.apple.CoreServices.CarbonCore 786.11 (786.13) <550244bb91e27b0fbafe01e1c4371103> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore 0x911e8000 - 0x911f3fff com.apple.speech.recognition.framework 3.7.24 (3.7.24) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition 0x911f4000 - 0x91213fff libresolv.9.dylib ??? (???) /usr/lib/libresolv.9.dylib 0x91214000 - 0x91251ffe com.apple.securityfoundation 3.0.2 (36131) /System/Library/Frameworks/SecurityFoundation.framework/Versions/A/SecurityFoundation 0x91252000 - 0x91325fff com.apple.CoreServices.OSServices 228 (228) <8610aed4edbd5d21e887a68c32b5c216> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices 0x91326000 - 0x9137cfff libGLU.dylib ??? (???) <3418ce7ca0863162847f553c15d08674> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib 0x9137d000 - 0x913e4ffb libstdc++.6.dylib ??? (???) /usr/lib/libstdc++.6.dylib 0x913e5000 - 0x91813ffe libGLProgrammability.dylib ??? (???) <5d52750ec9e438b25d3a4db51361fa2b> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLProgrammability.dylib 0x918fb000 - 0x91930ffb com.apple.LDAPFramework 1.4.5 (110) <48289b2a06039321a6efa75c2f0c0402> /System/Library/Frameworks/LDAP.framework/Versions/A/LDAP 0x91931000 - 0x919b9ffb com.apple.audio.CoreAudio 3.1.2 (3.1.2) <6fc8a8cb43506b57b951da899a55d3b9> /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio 0x919ba000 - 0x919d9fff com.apple.vecLib 3.4.2 (vecLib 3.4.2) /System/Library/Frameworks/vecLib.framework/Versions/A/vecLib 0x919da000 - 0x91a24fff com.apple.QuickLookUIFramework 1.3.1 (170.9) /System/Library/PrivateFrameworks/QuickLookUI.framework/Versions/A/QuickLookUI 0x91a25000 - 0x91a25ff8 com.apple.Cocoa 6.5 (???) /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa 0x91a26000 - 0x91a2cffb com.apple.backup.framework 1.0 (1.0) /System/Library/PrivateFrameworks/Backup.framework/Versions/A/Backup 0x91a2d000 - 0x91a5efff com.apple.coreui 1.2 (62) /System/Library/PrivateFrameworks/CoreUI.framework/Versions/A/CoreUI 0x91a5f000 - 0x91b16fff com.apple.QTKit 7.6.2 (1327) /System/Library/Frameworks/QTKit.framework/Versions/A/QTKit 0x91be7000 - 0x91bf2ffb libgcc_s.1.dylib ??? (???) /usr/lib/libgcc_s.1.dylib 0x91bf3000 - 0x91bf9fff com.apple.DisplayServicesFW 2.0.2 (2.0.2) <7f4de3ca234fdf3f06f25d47d7119e9b> /System/Library/PrivateFrameworks/DisplayServices.framework/Versions/A/DisplayServices 0x91bfa000 - 0x91d41ffb com.apple.audio.toolbox.AudioToolbox 1.5.2 (1.5.2) /System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox 0x91d73000 - 0x91dd4fff com.apple.CoreText 2.0.4 (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreText.framework/Versions/A/CoreText 0x91f1b000 - 0x91f37ffb libPng.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib 0x91f38000 - 0x91f48fff libsasl2.2.dylib ??? (???) /usr/lib/libsasl2.2.dylib 0x92bf9000 - 0x92c88ffb com.apple.DesktopServices 1.4.8 (1.4.8) /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv 0x92c89000 - 0x92ca9ff7 libJPEG.dylib ??? (???) <70d3c9e2a22410faa560e87a36a32f2c> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib 0x92cb0000 - 0x92cc7ffb com.apple.ImageCapture 5.0.2 (5.0.2) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture 0x92cd9000 - 0x92e79ff3 libSystem.B.dylib ??? (???) <900415cd2c829b2de9a6cdcdaa6307e3> /usr/lib/libSystem.B.dylib 0x92e7a000 - 0x92e98fff com.apple.QuickLookFramework 1.3.1 (170.9) /System/Library/Frameworks/QuickLook.framework/Versions/A/QuickLook 0x92e99000 - 0x92ea5ff3 com.apple.audio.SoundManager 3.9.2 (3.9.2) <79588842bcaf6c747a95b2120304397a> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CarbonSound.framework/Versions/A/CarbonSound 0x92ea6000 - 0x92f40ff7 com.apple.ApplicationServices.ATS 3.7 (???) <2e748b84ad5232add84d6aaad73b832f> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS 0x92f41000 - 0x92f44ffb com.apple.securityhi 3.0 (30817) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI 0x92f95000 - 0x92f98fff com.apple.CrashReporterSupport 10.5.7 (161) <12938c62930c0c2a22cb68bfc618351e> /System/Library/PrivateFrameworks/CrashReporterSupport.framework/Versions/A/CrashReporterSupport 0x93265000 - 0x93272fff libbz2.1.0.dylib ??? (???) <03227e92407191ff8e754461e842201b> /usr/lib/libbz2.1.0.dylib 0x93273000 - 0x93273ffb com.apple.installserver.framework 1.0 (8) /System/Library/PrivateFrameworks/InstallServer.framework/Versions/A/InstallServer 0x93274000 - 0x93274ffc com.apple.MonitorPanelFramework 1.2.0 (1.2.0) <91aadd6dccda219dd50a6ce06aad5b54> /System/Library/PrivateFrameworks/MonitorPanel.framework/Versions/A/MonitorPanel 0x93275000 - 0x93416ff7 com.apple.QuartzComposer 2.1 (106.13) <6dd1df71cb588b1b9ceb0c5bbf32e842> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/QuartzComposer.framework/Versions/A/QuartzComposer 0x93417000 - 0x93501fff libxml2.2.dylib ??? (???) /usr/lib/libxml2.2.dylib 0x93502000 - 0x93529fff libcups.2.dylib ??? (???) /usr/lib/libcups.2.dylib 0x9352a000 - 0x935b2fff com.apple.ink.framework 101.3 (86) <66a99ad6bc695390a66dd24789e23dcc> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink 0x935b3000 - 0x93602fff com.apple.Metadata 10.5.8 (398.26) <1a261534027b9d1518327d1fabe1182b> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata 0x93684000 - 0x936c1fff libRIP.A.dylib ??? (???) <321f32426fdb395be9346e9b1e378e60> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libRIP.A.dylib 0x936c2000 - 0x936c2fff com.apple.Accelerate 1.4.2 (Accelerate 1.4.2) /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate 0x936c3000 - 0x936dfffb com.apple.openscripting 1.2.8 (???) <01f86cdb8f7347d2f3f13066e954acb6> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting 0x936f6000 - 0x93809fff com.apple.PubSub 1.0.4 (65.11) <4370815eb840a0892988c28122c05c4b> /System/Library/Frameworks/PubSub.framework/Versions/A/PubSub 0x9380a000 - 0x93825ff3 com.apple.DirectoryService.Framework 3.5.6 (3.5.6) /System/Library/Frameworks/DirectoryService.framework/Versions/A/DirectoryService 0x93826000 - 0x9382dfff com.apple.CommonPanels 1.2.4 (85) <0d1256175c5512c911ede094d767acfe> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels 0x9382e000 - 0x9382fff8 com.apple.ApplicationServices 34 (34) <6aa5ee485bb2e656531b3505932b845f> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices 0x93830000 - 0x93831fff libffi.dylib ??? (???) <11b77dbce4aa0f0b66d40014230abd1d> /usr/lib/libffi.dylib 0x93832000 - 0x938b7fff libsqlite3.0.dylib ??? (???) /usr/lib/libsqlite3.0.dylib 0x938b8000 - 0x93968fff edu.mit.Kerberos 6.0.13 (6.0.13) <2ed20a450576465ee4f9c317b8ce8c44> /System/Library/Frameworks/Kerberos.framework/Versions/A/Kerberos 0x93969000 - 0x9399efff com.apple.AE 402.3 (402.3) <75725936d014fd3ca2553d18b784b99b> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE 0x9399f000 - 0x939c9ff7 libssl.0.9.7.dylib ??? (???) <09e02b0724f19afe9f0fc7e4eb893f0d> /usr/lib/libssl.0.9.7.dylib 0x939ca000 - 0x93a19fff libGLImage.dylib ??? (???) <2e1f2a2625064149d209ec19e52d0384> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib 0x93a1a000 - 0x93a1fff6 libmathCommon.A.dylib ??? (???) /usr/lib/system/libmathCommon.A.dylib 0x93b6f000 - 0x93b72fff com.apple.help 1.1 (36) <7106d6e074a3b9835ebf1e6cc6c822ce> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help 0x93b73000 - 0x93b75ffd libRadiance.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib 0x93ba8000 - 0x93bb0fff libbsm.dylib ??? (???) /usr/lib/libbsm.dylib 0x93bb1000 - 0x93c4afc3 libvDSP.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib 0x93c4b000 - 0x93cb5fff com.apple.PDFKit 2.1.2 (2.1.2) /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/PDFKit.framework/Versions/A/PDFKit 0x93cb6000 - 0x93cc3fff libCSync.A.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCSync.A.dylib 0x93cc4000 - 0x93d26ffb com.apple.htmlrendering 68 (1.1.3) /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HTMLRendering.framework/Versions/A/HTMLRendering 0x93d27000 - 0x93d32ff9 com.apple.helpdata 1.0.1 (14.2) /System/Library/PrivateFrameworks/HelpData.framework/Versions/A/HelpData 0x93d33000 - 0x93dbdfff libvMisc.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib 0x93dbe000 - 0x93e86ffb com.apple.CoreData 100.2 (186.2) /System/Library/Frameworks/CoreData.framework/Versions/A/CoreData 0x93e87000 - 0x93ecdff9 com.apple.securityinterface 3.0.3 (36953) <4ce4732461084fe3c4417738666ef737> /System/Library/Frameworks/SecurityInterface.framework/Versions/A/SecurityInterface 0x93ece000 - 0x93f15fff com.apple.NavigationServices 3.5.2 (163) <453fd79dd63debad4908dcc726f9aa04> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/NavigationServices.framework/Versions/A/NavigationServices 0x93f16000 - 0x93f25fff com.apple.DSObjCWrappers.Framework 1.3 (1.3) <305892aafaceb4e31915f0d759ef7e6d> /System/Library/PrivateFrameworks/DSObjCWrappers.framework/Versions/A/DSObjCWrappers 0x93f26000 - 0x93f4ffff com.apple.CoreMediaPrivate 15.0 (15.0) /System/Library/PrivateFrameworks/CoreMediaPrivate.framework/Versions/A/CoreMediaPrivate 0x93f64000 - 0x94089ffb com.apple.imageKit 1.0.2 (1.0) <50dfcbe41b384bd71761c761c3fbfd5e> /System/Library/Frameworks/Quartz.framework/Versions/A/Frameworks/ImageKit.framework/Versions/A/ImageKit 0x9408a000 - 0x94091ffb com.apple.print.framework.Print 218.0.3 (220.2) <021d2263007c538fd9e6b52e66a2623d> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print 0x94092000 - 0x940bafff libxslt.1.dylib ??? (???) /usr/lib/libxslt.1.dylib 0x940bb000 - 0x940d3ffb com.apple.DictionaryServices 1.0.0 (1.0.0) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices 0x9413a000 - 0x94167fff libGL.dylib ??? (???) /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib 0x94168000 - 0x944cdffe com.apple.QuartzCore 1.5.8 (1.5.8) <60e54cfb861dc5e66bb4f263a192d558> /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore 0x944ce000 - 0x944f7ffb com.apple.shortcut 1.0.1 (1.0) <8da20d176ab4cf71cdf4f79b477fe0e7> /System/Library/PrivateFrameworks/Shortcut.framework/Versions/A/Shortcut 0x944f8000 - 0x945a8fff com.apple.QD 3.11.56 (???) <5e3f7cbff6ff025da4ce6ec610845f5e> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD 0x945e9000 - 0x94d5ffff com.apple.AppKit 6.5.9 (949.54) <687f1742c249d7c9268e2eb57713cef6> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x94d60000 - 0x952dcff3 com.apple.CoreGraphics 1.409.3 (???) <42ab271a33fb5cfb6f07e4dff8a5ca76> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics 0x952dd000 - 0x952fcfff com.apple.Accelerate.vecLib 3.4.2 (vecLib 3.4.2) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib 0x952fd000 - 0x95543ffb com.apple.Foundation 6.5.9 (677.26) /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation 0x95544000 - 0x95548ffe libGIF.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib 0x95549000 - 0x95582fff com.apple.SystemConfiguration 1.9.2 (1.9.2) <21dee7ffd93306032f911b5ef3fdbab3> /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration 0x95583000 - 0x955aeff7 libauto.dylib ??? (???) /usr/lib/libauto.dylib 0x955af000 - 0x9562afff com.apple.SearchKit 1.2.2 (1.2.2) /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit 0x9562b000 - 0x95750ff3 com.apple.CoreFoundation 6.5.7 (476.19) /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation 0x95751000 - 0x95a83ffb com.apple.QuickTime 7.6.2 (1327) /System/Library/Frameworks/QuickTime.framework/Versions/A/QuickTime 0x95cee000 - 0x95cf7fff com.apple.DiskArbitration 2.2.1 (2.2.1) <682f5c45591e8c4a89c79e384e2c49af> /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration 0x95cf8000 - 0x95cf8fff com.apple.Carbon 136 (136) <6a6a209ec9179368db7ead8382b8ee63> /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon 0x96688000 - 0x969b1fe7 libLAPACK.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib 0x969b2000 - 0x969f0ff7 libtidy.A.dylib ??? (???) /usr/lib/libtidy.A.dylib 0x96ace000 - 0x96b0fffb libTIFF.dylib ??? (???) <3d90effc44de6e218670af9eb8cdee57> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib 0x96b10000 - 0x96b54fff com.apple.CoreMediaIOServicesPrivate 20.0 (20.0) /System/Library/PrivateFrameworks/CoreMediaIOServicesPrivate.framework/Versions/A/CoreMediaIOServicesPrivate 0x96b55000 - 0x96c24fff com.apple.ColorSync 4.5.2 (4.5.2) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync.framework/Versions/A/ColorSync 0x96c25000 - 0x971dffff libBLAS.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib 0x971e0000 - 0x971e8ffb libCGATS.A.dylib ??? (???) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGATS.A.dylib 0x9721c000 - 0x97405ffb com.apple.security 5.0.5 (36371) /System/Library/Frameworks/Security.framework/Versions/A/Security 0x9744b000 - 0x97459ff3 com.apple.opengl 1.5.10 (1.5.10) <54bae289e544387ce7997a4a05e70aa9> /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL 0xfffec000 - 0xfffeffff libobjc.A.dylib ??? (???) /usr/lib/libobjc.A.dylib 0xffff8000 - 0xffff9703 libSystem.B.dylib ??? (???) /usr/lib/libSystem.B.dylib -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:38:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:38:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] New: [Gtk] API for disabling local file access to web URLs Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28663 Summary: [Gtk] API for disabling local file access to web URLs Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Keywords: Gtk Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jmalonzo at gmail.com This is the Gtk component of https://bugs.webkit.org/show_bug.cgi?id=28480. Patch forthcoming.. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 22:43:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 22:43:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823054350.8B015353F83D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38445| |review? Flag| | --- Comment #1 from Jan Alonzo 2009-08-22 22:43:50 PDT --- Created an attachment (id=38445) --> (https://bugs.webkit.org/attachment.cgi?id=38445) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:22:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:22:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 10024] iBench should be in the repository to be runnable by opensource users In-Reply-To: References: Message-ID: <20090823062245.6AED5353FA59@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=10024 --- Comment #2 from Alexey Proskuryakov 2009-08-22 23:22:45 PDT --- My understanding is that iBench requires a Windows-based server, so it wouldn't be of much help for most WebKit developers. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:23:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:23:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28657] Form post to IFRAME change browser history In-Reply-To: References: Message-ID: <20090823062336.D9B92353FA6F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28657 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |beidson at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:31:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:31:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28626] WebKit quits (no crash log) when a link to a MPEG-1 file is clicked on. In-Reply-To: References: Message-ID: <20090823063111.3EC2C353FB0A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28626 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org --- Comment #1 from Alexey Proskuryakov 2009-08-22 23:31:11 PDT --- I cannot reproduce this with a local debug build of r47661 on Mac OS X 10.5.8 (Intel). Will upgrading to QuickTime 7.6.2 solve the problem for you? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:37:27 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:37:27 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090823063727.E30DA353FBBD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from Xan Lopez 2009-08-22 23:37:27 PDT --- Thanks, committed as r47687 with those changes. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:42:30 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:42:30 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823064230.2C414353FC1F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38445|review? |review+ Flag| | --- Comment #2 from Xan Lopez 2009-08-22 23:42:29 PDT --- (From update of attachment 38445) > gboolean javascript_can_open_windows_automatically; > gboolean enable_offline_web_application_cache; > + gboolean enable_universal_access_from_file_uri; from_file_uriS ? > }; > > #define WEBKIT_WEB_SETTINGS_GET_PRIVATE(obj) (G_TYPE_INSTANCE_GET_PRIVATE((obj), WEBKIT_TYPE_WEB_SETTINGS, WebKitWebSettingsPrivate)) > @@ -130,7 +131,8 @@ enum { > PROP_ENABLE_XSS_AUDITOR, > PROP_USER_AGENT, > PROP_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY, > - PROP_ENABLE_OFFLINE_WEB_APPLICATION_CACHE > + PROP_ENABLE_OFFLINE_WEB_APPLICATION_CACHE, > + PROP_ENABLE_UNIVERSAL_ACCESS_FROM_FILE_URI URIS ? > }; > > // Create a default user agent string > @@ -597,7 +599,21 @@ static void webkit_web_settings_class_init(WebKitWebSettingsClass* klass) > TRUE, > flags)); > > - > + /** > + * WebKitWebSettings:enable-universal-access-from-file-uri > + * > + * Whether to allow files loaded through file:// URIs universal access to > + * pages loaded through non-file schemes. Isn't it just to all pages? > + * > + * Since 1.1.13 > + */ > + g_object_class_install_property(gobject_class, > + PROP_ENABLE_UNIVERSAL_ACCESS_FROM_FILE_URI, > + g_param_spec_boolean("enable-universal-access-from-file-uri", > + _("Enable universal access from file URI"), URIs ? r=me with the name changes and the doc fixup in case it applies to all pages. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sat Aug 22 23:53:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sat, 22 Aug 2009 23:53:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] New: Inspector: Throws an Error on "null" Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28665 Summary: Inspector: Throws an Error on "null" Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: joepeck at webkit.org CC: timothy at hatcher.name, aroben at apple.com, pfeldman at chromium.org The Console is throwing an error on "null". This seems to happen because after the result of an eval goes to InspectorController.wrapObject(), which doesn't handle null very well. Current Behavior: > null TypeError: Result of expression 'wrapper' [null] is not an object. > [null, null] [] > var o = { a: null } Object a: null > o.a TypeError: Result of expression 'wrapper' [null] is not an object. Expected Behavior (from Safari 4.0.3): > null null > [null, null] [null, null] > var o = { a:null } undefined > o Object a: null > o.a null -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:04:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:04:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823070404.548A8353FDC8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38447| |review? Flag| | --- Comment #1 from Joseph Pecoraro 2009-08-23 00:04:03 PDT --- Created an attachment (id=38447) --> (https://bugs.webkit.org/attachment.cgi?id=38447) [PATCH] One Possible Solution No other falsey value causes wrapObject() to return a null value (NaN, undefined, 0, ''). This solution tackles null before calling wrapObject. Another solution could be checking the result of wrapObject (wrapper). And yet another solution could handle null differently inside InspectorController.wrapObject(). This approach seemed simplest. Pavel, would there be a more appropriate solution? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:04:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:04:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823070420.D2E2D353FDDC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38447|application/octet-stream |text/plain mime type| | Attachment #38447|0 |1 is patch| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:08:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:08:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823070845.6F76F353FE59@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joepeck at webkit.org --- Comment #2 from Joseph Pecoraro 2009-08-23 00:08:45 PDT --- Actually that "exception: false" part isn't necessary, because thats the implicit default if its left out. So I can remove that if this is an okay way to go. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:11:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:11:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28345] [GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly In-Reply-To: References: Message-ID: <20090823071145.1ECE8353FEA3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28345 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35016|review? |review+ Flag| | --- Comment #6 from Xan Lopez 2009-08-23 00:11:44 PDT --- (From update of attachment 35016) This looks good to me, and on top of fixing a bug it manages to do the data conversion on the client side. There's a NULL where we should use 0, but I'll fix that when landing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:18:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:18:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090823071854.6FFED353FF42@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Bug 28346 depends on bug 28345, which changed state. Bug 28345 Summary: [GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly https://bugs.webkit.org/show_bug.cgi?id=28345 What |Old Value |New Value ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:18:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:18:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28345] [GTK] BitmapImage::getGdkPixbuf does not handle alpha channels properly In-Reply-To: References: Message-ID: <20090823071854.40D3F353FF3A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28345 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |xan.lopez at gmail.com Resolution| |FIXED --- Comment #7 from Xan Lopez 2009-08-23 00:18:54 PDT --- Committed as r47689, closing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 00:25:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 00:25:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28666] New: Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28666 Summary: Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: joepeck at webkit.org CC: timothy at hatcher.name, aroben at apple.com, pfeldman at chromium.org Current Behavior: > Math.sin function sin() { > var o = { a: Math.sin } undefined > o Object a: function sin() { > o.a function sin() { Expected Behavior: (From Safari 4.0.3) > Math.sin function sin() { [native code] } > var o = { a: Math.sin } undefined > o Object a: function sin() { > o.a function sin() { [native code] } The current behavior abbreviates too often (in fact all the time). Specifically when setting the "description" in InjectedScript.createProxyObject. Changing the Object.describe() call inside createProxyObject makes all of the examples above the unabbreviated style. Should abbreviation move out of Object.describe() and instead be used right before showing in the UI? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:27:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:27:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] New: Make XSSAuditor go fast Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28667 Summary: Make XSSAuditor go fast Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Keywords: XSSAuditor Severity: Normal Priority: P2 Component: WebCore JavaScript AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: abarth at webkit.org CC: sam at webkit.org, fishd at chromium.org, dbates at webkit.org Enabling the XSSAuditor slows down the intl1 page cycler slightly slower. We should make the auditor go faster. Patch forthcoming. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:31:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:31:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823083136.DCB40354044F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38449| |review? Flag| | --- Comment #1 from Adam Barth 2009-08-23 01:31:36 PDT --- Created an attachment (id=38449) --> (https://bugs.webkit.org/attachment.cgi?id=38449) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:37:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:37:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823083757.668D635404EF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 --- Comment #2 from Adam Barth 2009-08-23 01:37:57 PDT --- Here are the perf numbers from my laptop (two runs for each condition, 15 cycles per run, warm disk cache): XSSAuditor disabled: 187.91, 188.07 XSSAuditor enabled (old): 191.60, 192.17 XSSAuditor enabled (new): 189.14, 189.85 By my calculations, the old auditor slowed down intl1 by 2% whereas the new auditor only slows it down by 0.8%. It's possible there is more room for optimization, but this change seems worth doing. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:43:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:43:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823084319.1B871354055B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sdudla_uk at yahoo.com --- Comment #8 from Mark Rowe (bdash) 2009-08-23 01:43:18 PDT --- *** Bug 28662 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:43:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:43:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28662] Build r47677 crashes on launch In-Reply-To: References: Message-ID: <20090823084319.015783540555@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28662 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE Alias|sdudla_uk at yahoo.com | --- Comment #1 from Mark Rowe (bdash) 2009-08-23 01:43:18 PDT --- *** This bug has been marked as a duplicate of bug 28655 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:43:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:43:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823084351.E27F03540577@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 --- Comment #9 from Mark Rowe (bdash) 2009-08-23 01:43:51 PDT --- *** Bug 28653 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:43:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:43:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28653] Safari crashes after most recent nightly update In-Reply-To: References: Message-ID: <20090823084351.AFB8E3540571@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28653 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |DUPLICATE --- Comment #3 from Mark Rowe (bdash) 2009-08-23 01:43:51 PDT --- *** This bug has been marked as a duplicate of bug 28655 *** -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:44:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:44:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28655] REGRESSION(r47639-r47660): Webkit crashes on launch on PowerPC In-Reply-To: References: Message-ID: <20090823084443.4BB993540593@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28655 Mark Rowe (bdash) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #10 from Mark Rowe (bdash) 2009-08-23 01:44:43 PDT --- Maciej landed this in r47686, and there's a new nightly build up that contains this fix. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:47:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:47:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823084711.6066B35405BB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #3 from Jan Alonzo 2009-08-23 01:47:11 PDT --- (In reply to comment #2) > > r=me with the name changes and the doc fixup in case it applies to all pages. Landed as http://trac.webkit.org/changeset/47690. Thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:48:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:48:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823084823.5C99435405DB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 --- Comment #3 from Mark Rowe (bdash) 2009-08-23 01:48:22 PDT --- (From update of attachment 38449) Rather than dropping the "const" from all of these functions that are conceptually cons I think it make more sense to mark m_memoizer as mutable instead. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 01:57:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 01:57:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28340] 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be wrapped In-Reply-To: References: Message-ID: <20090823085735.9EEDE35406D1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28340 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW AssignedTo|pfeldman at chromium.org |webkit-unassigned at lists.web | |kit.org --- Comment #8 from Pavel Feldman 2009-08-23 01:57:35 PDT --- Both scenarios work fine on 32-bit and on Chromium 64-bit. Latter uses another version of DOM bindings including different quarantine code though. So most likely the problem is with the JSC quarantines. I don't feel comfortable owning this bug since I can't reproduce it in the standard WebKit environment. Note that I am working on removing quarantines from the Web Inspector at all, so that the bug might become obsolete some time soon. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:00:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:00:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28668] New: [Gtk] Test for HTTP authentication in Application cache fails Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28668 Summary: [Gtk] Test for HTTP authentication in Application cache fails Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: NEW Keywords: Gtk Severity: Normal Priority: P2 Component: WebKit Gtk AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jmalonzo at gmail.com The test http/tests/appcache/auth.html is failing because it's timing out. Related changeset is http://trac.webkit.org/changeset/47439. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:05:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:05:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28668] [Gtk] Test for HTTP authentication in Application cache fails In-Reply-To: References: Message-ID: <20090823090514.AEDBB3540771@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28668 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gns at gnome.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:11:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:11:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823091103.64FA735407DD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #3 from Pavel Feldman 2009-08-23 02:11:03 PDT --- > + return { value: InjectedScript.createProxyObject(null, null), exception: false }; We don't wrap primitive values with proxy objects at the moment, why wrapping null. I would just do return { value: null }; However, that would require fixing ConsoleView's proxy detection: var isProxy = typeof output === "object"; should be replaced with var isProxy = output !== null && typeof output === "object"; -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:18:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:18:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28666] Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often In-Reply-To: References: Message-ID: <20090823091851.D311E35408AF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28666 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #1 from Pavel Feldman 2009-08-23 02:18:51 PDT --- (In reply to comment #0) > The current behavior abbreviates too often (in fact all the time). > Specifically when setting the "description" in > InjectedScript.createProxyObject. Changing the Object.describe() call inside > createProxyObject makes all of the examples above the unabbreviated style. > Should abbreviation move out of Object.describe() and instead be used right > before showing in the UI? Thanks for reporting this. Passing information from the InjectedScript to the UI is going to be slow, especially after we add the JSON serialization there. So we don't want to push information that might not be needed for the UI. I think I just need to find the place where it got regressed and do no abbreviation there. Or do you want to investigate it? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:23:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:23:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823092315.F40F13540920@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38445|review+ | Flag| | Attachment #38445|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:23:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:23:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823092321.9FA2F354092B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38450| |review? Flag| | --- Comment #4 from Jan Alonzo 2009-08-23 02:23:21 PDT --- Created an attachment (id=38450) --> (https://bugs.webkit.org/attachment.cgi?id=38450) Enable setting for DRT -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:25:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:25:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823092501.7CBF73540948@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #5 from Jan Alonzo 2009-08-23 02:25:01 PDT --- Reopening as we need the setting enabled in DRT. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:26:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:26:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823092653.436F03540974@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 --- Comment #4 from Pavel Feldman 2009-08-23 02:26:53 PDT --- Additional note: fixing InspectorController.wrapObject would be nicer, but you would need to do that in both bindings (comparing to null are returning argument). It will still require mentioned fix in the console though. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:41:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:41:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28666] Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often In-Reply-To: References: Message-ID: <20090823094103.393023540A81@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28666 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38451| |review? Flag| | Status|NEW |ASSIGNED AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | --- Comment #2 from Pavel Feldman 2009-08-23 02:41:02 PDT --- Created an attachment (id=38451) --> (https://bugs.webkit.org/attachment.cgi?id=38451) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 02:54:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 02:54:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823095419.ADABF3540BAD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38450|review? |review+ Flag| | --- Comment #6 from Xan Lopez 2009-08-23 02:54:19 PDT --- (From update of attachment 38450) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 03:03:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 03:03:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823100301.77A3A3540C73@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38450| |commit-queue- Flag| | --- Comment #7 from Jan Alonzo 2009-08-23 03:03:01 PDT --- (From update of attachment 38450) Rejecting patch 38450 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/build-webkit failed with exit code 2 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 03:03:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 03:03:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823100354.003743540C97@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 --- Comment #8 from Jan Alonzo 2009-08-23 03:03:53 PDT --- (From update of attachment 38450) Rejecting patch 38450 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'rebase']" exit_code: 1 cwd: None -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 03:09:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 03:09:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28663] [Gtk] API for disabling local file access to web URLs In-Reply-To: References: Message-ID: <20090823100908.7F1C13540D17@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28663 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #9 from Jan Alonzo 2009-08-23 03:09:08 PDT --- (In reply to comment #6) > (From update of attachment 38450 [details]) > r=me Landed as http://trac.webkit.org/changeset/47692 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 04:08:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 04:08:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090823110852.D2A943541138@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED CC| |jmalonzo at gmail.com Resolution|FIXED | --- Comment #4 from Jan Alonzo 2009-08-23 04:08:52 PDT --- (In reply to comment #3) > Thanks, committed as r47687 with those changes. This changed introduced a regression in the following test: editing/execCommand/toggle-compound-styles.html -> failed The change in http://trac.webkit.org/changeset/46920 might be helpful. I guess we need to rebaseline the test to match mac? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 04:09:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 04:09:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090823110910.6B55C3541145@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 05:47:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 05:47:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] New: make-script-test-wrappers should be executable Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28669 Summary: make-script-test-wrappers should be executable Product: WebKit Version: 528+ (Nightly build) Platform: PC OS/Version: All Status: NEW Severity: Enhancement Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cam at mcc.id.au WebKitTools/Scripts/make-script-test-wrappers should be executable, like nearly all other files in WebKitTools/Scripts/ are. update-sources-list.py probably should be executable too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 05:56:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 05:56:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090823125628.B044B354199F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 --- Comment #1 from Cameron McCormack 2009-08-23 05:56:28 PDT --- Ah, prepare-ChangeLog doesn't work if the only changes I've made are to properties: fox:~/svn/WebKit cam$ ./WebKitTools/Scripts/prepare-ChangeLog Running status to find changed, added, or removed files. M WebKitTools/Scripts/update-sources-list.py M WebKitTools/Scripts/make-script-test-wrappers No changes found. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 06:22:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 06:22:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26304] [GTK] Add controls for playing html5 video. In-Reply-To: References: Message-ID: <20090823132236.57E733541E60@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26304 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38452| |review? Flag| | --- Comment #6 from Zan Dobersek 2009-08-23 06:22:35 PDT --- Created an attachment (id=38452) --> (https://bugs.webkit.org/attachment.cgi?id=38452) Media controls impl., 1. Implements media controls painting. >From ChangeLog entry: Implements controls for media elements. Adds a new initializator to the Color class, which makes it possible to initialize Color with a GdkColor and an alpha channel. Adds a new loading function to the Image class, loadPlatformThemeIcon, which loads only platform theme icons. Available only for the Gtk+ port. Also modifies the whole process of loading platform resources so there is a maximum sharing of code between this new function and the loadPlatformResource function. Adds a stylesheet that overrides some of the default style settings of the media control panel. Changes by this patch in RenderThemeGtk class: - media slider thumb's size gets properly adjusted, - gtkContainer's 'style-set' signal is connected to the appropriate callback, which forces reinitialization of icons and colors on a style change, - implements paintMedia* functions, which now properly paint media controls. I believe there can be some style or naming issues, I'll be glad to fix them. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 06:22:53 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 06:22:53 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26304] [GTK] Add controls for playing html5 video. In-Reply-To: References: Message-ID: <20090823132253.79AEE3541E70@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26304 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zandobersek at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 06:29:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 06:29:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26304] [GTK] Add controls for playing html5 video. In-Reply-To: References: Message-ID: <20090823132938.782D03541F0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26304 Jan Alonzo changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Gtk Status|UNCONFIRMED |NEW CC| |jmalonzo at gmail.com Component|New Bugs |WebKit Gtk Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 07:55:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 07:55:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823145524.3033635427C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38447|review? | Flag| | Attachment #38447|0 |1 is obsolete| | Attachment #38453| |review? Flag| | --- Comment #5 from Joseph Pecoraro 2009-08-23 07:55:23 PDT --- Created an attachment (id=38453) --> (https://bugs.webkit.org/attachment.cgi?id=38453) [PATCH] Pavel's JavaScript Approach -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 07:58:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 07:58:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823145850.35DB5354280D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 --- Comment #6 from Joseph Pecoraro 2009-08-23 07:58:49 PDT --- (In reply to comment #4) > Additional note: fixing InspectorController.wrapObject would be nicer, but you > would need to do that in both bindings (comparing to null are returning > argument). It will still require mentioned fix in the console though. What I said earlier was not accurate. wrapObject doesn't have trouble with null, it just ends up returning the value passed in, which was null, and a null value isn't handled well afterwards. I like this approach. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 08:26:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 08:26:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 23107] run-in spec violation and rendering differences to Opera/IE In-Reply-To: References: Message-ID: <20090823152654.585A43542B00@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=23107 j.j. changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |moz at jeka.info --- Comment #2 from j.j. 2009-08-23 08:26:54 PDT --- Had this changed with bug 27193 ? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 09:26:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 09:26:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28340] 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be wrapped In-Reply-To: References: Message-ID: <20090823162648.4DCD43543129@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28340 --- Comment #9 from Simon Fraser (smfr) 2009-08-23 09:26:47 PDT --- We need to figure out when this regressed. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 10:05:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 10:05:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823170525.021FF354351D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38449|review? |review- Flag| | --- Comment #4 from Adam Barth 2009-08-23 10:05:24 PDT --- (From update of attachment 38449) Actually, I screwed up the memoization too. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 10:50:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 10:50:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823175045.12495354397F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38449|review- | Flag| | Attachment #38449|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 10:51:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 10:51:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28667] Make XSSAuditor go fast In-Reply-To: References: Message-ID: <20090823175118.F3B0835439B6@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28667 Adam Barth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38454| |review? Flag| | --- Comment #5 from Adam Barth 2009-08-23 10:51:18 PDT --- Created an attachment (id=38454) --> (https://bugs.webkit.org/attachment.cgi?id=38454) Patch v1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 11:17:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 11:17:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28422] Linking fails with "relocation R_X86_64_PC32 against symbol `cti_vm_throw'" In-Reply-To: References: Message-ID: <20090823181719.120553543C58@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28422 --- Comment #4 from Priit Laes (IRC: plaes) 2009-08-23 11:17:18 PDT --- (In reply to comment #3) > (From update of attachment 35026 [details]) > Hiding/filtering the symbols is not the right fix here. You might as well do a > release build. Have you tried forcing -fPIC in CFLAGS? If that works then we > need to fix our build scripts to do that automatically. Tried with CXXFLAGS="-fPIC" CFLAGS="-fPIC" but it didn't work. I have an alternative patch that seems to fix this issue (at least on my machine): http://plaes.org/files/2009-Q3/webkit-bug-28422-use-plt-segment-for-cti_vm_throw.patch It seems to be the right approach ( See section 1.5.5 in http://people.redhat.com/drepper/dsohowto.pdf paper..) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 12:34:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 12:34:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823193418.AB2DB3544350@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Timothy Hatcher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38453|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 12:56:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 12:56:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090823195626.1857D3544576@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zandobersek at gmail.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 13:08:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 13:08:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28340] 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be wrapped In-Reply-To: References: Message-ID: <20090823200844.93C6635446A0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28340 --- Comment #10 from Pavel Feldman 2009-08-23 13:08:44 PDT --- (In reply to comment #9) > We need to figure out when this regressed. It is known when it regressed (my Migrate to DOMAgent change), but it is unclear why it is only triggering on 64bit. I can't reproduce it, but I know that it is triggering in the console formatting code. I hope Oliver finishes his analysis and points me to the statement in the javascript code triggering the assertion. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 13:21:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 13:21:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090823202108.C31D535447C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28391|0 |1 is obsolete| | --- Comment #18 from Zan Dobersek 2009-08-23 13:21:08 PDT --- Created an attachment (id=38455) --> (https://bugs.webkit.org/attachment.cgi?id=38455) WIP patch This is a work-in-progress patch and is therefor not bisected into smaller (and better) patches. It also includes diff of the Skipped list. This patch only implements functions and applies modifications necessary for most of the layout tests in LayoutTests/media/ directory to pass. With applied patch, 64 tests apply. Some crashes still occur in webkit_video_sink_idle_func when priv->async_queue is checked. Between g_idle_add_full call in webkit_video_sink_render and webkit_video_sink_idle_func call, a call to webkit_video_sink_dispose is made. This corrupts async queue, therefor crashes occur. In the patch, g_idle_remove_by_data is called in webkit_video_sink_stop to remove these idle calls, but some still appear to slip by. In MediaPlayerPrivateGStreamer.cpp, setEndTime() implementation has been removed, as it seems this is not used anywhere in WebCore. Maybe not the best idea, as it could get used? There are plenty of things still awaiting implementation, such as functions maxTimeLoaded, maxTimeSeekable, maxTimeBuffered, ... There is also a bit of a mess in the updateStates function that could use a bit of a cleanup. Error handling was a bit improved, now calling loadingFailed to the MediaPlayerPrivate with a different error for different error domain that we get in mediaPlayerPrivateErrorCallback. Also, the patch now uses playbin2 as the factory name when creating m_playBin. playbin2 is surely better that playbin, however, according to gst base plugins reference manual [1] it is, at this moment, considered unstable, but Rhythmbox is already using it since 0.12.2.[2][3] That's about it, next step are the http/media tests. Comments, suggestions, anything welcome. [1] http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-plugins/html/gst-plugins-base-plugins-playbin2.html [2] http://bugzilla.gnome.org/show_bug.cgi?id=542922 [3] http://git.gnome.org/cgit/rhythmbox/tree/NEWS#n100 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 13:50:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 13:50:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26304] [GTK] Add controls for playing html5 video. In-Reply-To: References: Message-ID: <20090823205039.DEC753544A8D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26304 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38452|review? | Flag| | Attachment #38452|0 |1 is obsolete| | Attachment #38456| |review? Flag| | --- Comment #7 from Zan Dobersek 2009-08-23 13:50:39 PDT --- Created an attachment (id=38456) --> (https://bugs.webkit.org/attachment.cgi?id=38456) Media controls impl. 2. Removed an unneeded fprintf call. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 13:58:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 13:58:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] New: [Chromium] Multi-value select boxes cannot do non-contiguous selection Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28670 Summary: [Chromium] Multi-value select boxes cannot do non-contiguous selection Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh URL: http://code.google.com/p/chromium/issues/detail?id=159 98 OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: rsesek at bluestatic.org CC: playmobil at google.com On Chromium Mac, you cannot perform non-contiguous selection on a multi-value list box in the normal Mac way. On the Mac, you do this kind of selection by holding down the Command key; on Windows, you do this with the Control key. In SelectElement.cpp, the #if guard that determines which of these keys to respect uses PLATFORM(MAC), which is always false for Chromium. The fix is to use PLATFORM(DARWIN). Patch coming shortly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 14:20:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 14:20:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823212008.821373544DE4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Joseph Pecoraro changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38453| |commit-queue+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 14:31:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 14:31:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090823213101.60F623544F22@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Robert Sesek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38458| |review?(darin at apple.com) Flag| | --- Comment #1 from Robert Sesek 2009-08-23 14:31:00 PDT --- Created an attachment (id=38458) --> (https://bugs.webkit.org/attachment.cgi?id=38458) Fix -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 14:42:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 14:42:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823214215.AC3793545046@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38453|review+, commit-queue+ | Flag| | --- Comment #7 from Eric Seidel 2009-08-23 14:42:15 PDT --- (From update of attachment 38453) Clearing flags on attachment: 38453 Committed r47696: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 14:42:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 14:42:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28665] Inspector: Throws an Error on "null" In-Reply-To: References: Message-ID: <20090823214218.7C7953545062@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28665 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #8 from Eric Seidel 2009-08-23 14:42:18 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 15:13:40 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 15:13:40 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28619] [GTK] Geolocation needs permission API before being enabled by default In-Reply-To: References: Message-ID: <20090823221340.CAF5B3545332@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28619 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38417|review? |review+, commit-queue- Flag| | --- Comment #3 from Gustavo Noronha (kov) 2009-08-23 15:13:40 PDT --- (From update of attachment 38417) r=me Can you check that the bot has all the geoclue* packages that you have installed, when landing? =) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 15:21:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 15:21:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090823222131.89D5C354542C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Jeremy Moskovich changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38458|review?(darin at apple.com) |review? Flag| | --- Comment #2 from Jeremy Moskovich 2009-08-23 15:21:31 PDT --- (From update of attachment 38458) WebKit convention is to cc relevant parties and not to assign specific reviewers, thus I'm moving Darin to the cc list. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 15:21:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 15:21:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090823222138.7040A3545434@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Jeremy Moskovich changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 15:51:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 15:51:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090823225128.712C435456A9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 --- Comment #19 from Gustavo Noronha (kov) 2009-08-23 15:51:27 PDT --- (From update of attachment 38455) I like it, keep rocking =)  222 if (m_errorOccured)  223 return 0;  224  225 float ret = 0.0; Since you're initializing it here, you don't need to reset this in the else block bellow this. Actually, why not do an early return here instead: 225228 if (gst_element_query(m_playBin, query)) { Make that check to !, print the error log, and return, after unref'ing the object. > - GstElement* audioSink = gst_element_factory_make("gconfaudiosink", 0); > +// GstElement* audioSink = gst_element_factory_make("gconfaudiosink", 0); > m_videoSink = webkit_video_sink_new(m_surface); > > - g_object_set(m_playBin, "audio-sink", audioSink, NULL); > +// g_object_set(m_playBin, "audio-sink", audioSink, NULL); > g_object_set(m_playBin, "video-sink", m_videoSink, NULL); I think this can be removed, indeed, instead of just being commented. We only need to override the video sink. Except for these, I don't see a reason not to r+ this. Anything specific keeping you from setting r? apart from a missing ChangeLog, and lack of 'divinding' the patch into smaller patches? I believe this patch has actually a good size, tbh. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 15:58:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 15:58:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28354] webkitgtk 1.1.12 crashes at the end of loading almost any site In-Reply-To: References: Message-ID: <20090823225810.77DE13545745@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28354 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35116|review? |review+, commit-queue- Flag| | --- Comment #4 from Gustavo Noronha (kov) 2009-08-23 15:58:10 PDT --- (From update of attachment 35116) This sounds like a good oportunity to add a layout test indeed, but since it's a crasher, and we want to release soonish, I better not wait for it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:01:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:01:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090823230158.B7EF635457B1@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35022|review? |review+, commit-queue+ Flag| | --- Comment #9 from Gustavo Noronha (kov) 2009-08-23 16:01:58 PDT --- (From update of attachment 35022) Good to see this moving forward =). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:02:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:02:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090823230256.E540435457DB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35022|commit-queue+ |commit-queue- Flag| | --- Comment #10 from Eric Seidel 2009-08-23 16:02:56 PDT --- (From update of attachment 35022) Rejecting patch 35022 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=35022 from bug 28346 failed to download and apply. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:12:57 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:12:57 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28317] Assertion being hit on layout tests in debug build In-Reply-To: References: Message-ID: <20090823231257.43BB435458D0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28317 --- Comment #10 from Gustavo Noronha (kov) 2009-08-23 16:12:57 PDT --- Created an attachment (id=38459) --> (https://bugs.webkit.org/attachment.cgi?id=38459) dump of breakpoint Here's a dump I got following gbarra's instructions =). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:17:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:17:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28672] New: logmein.com becomes unresponsive during remote control Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28672 Summary: logmein.com becomes unresponsive during remote control Product: WebKit Version: 528+ (Nightly build) Platform: Macintosh Intel URL: http://logmein.com OS/Version: Mac OS X 10.5 Status: UNCONFIRMED Severity: Major Priority: P2 Component: Java AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: prw at widing.com logmein.com - primary log in completed. Clicked on remote computer. Remote session starts - but loading never completes. Loading "x" butt unresponsive - cannot stop loading, cannot close window. FORCE QUIT. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:40:21 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:40:21 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090823234021.286833545B78@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Sam Weinig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam at webkit.org --- Comment #3 from Sam Weinig 2009-08-23 16:40:20 PDT --- This does not seem like a Darwin level idea, it is very specific to the Mac. Is this how we have been solving other cases similar to this? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:53:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:53:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090823235305.8424A3545C7A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 --- Comment #4 from Robert Sesek 2009-08-23 16:53:05 PDT --- We use at the top of the file: #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)) I spoke to Jeremy about hit and he thought we could reduce it to just PLATFORM(DARWIN). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 16:59:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 16:59:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090823235915.9D1693545CFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 Cameron McCormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38461| |review? Flag| | --- Comment #2 from Cameron McCormack 2009-08-23 16:59:15 PDT --- Created an attachment (id=38461) --> (https://bugs.webkit.org/attachment.cgi?id=38461) Patch to make these two scripts executable I manually typed in the ChangeLog entry, since prepare-ChangeLog wasn't being cooperative. Hopefully I got the format right. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 17:12:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 17:12:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] New: Modifying doesn't clear the corresponding SVGAnimatedNumberList Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28673 Summary: Modifying doesn't clear the corresponding SVGAnimatedNumberList Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: SVG AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cam at mcc.id.au When script modifies the rotate="" attribute on a (or , etc.) element, the baseVal of the SVGAnimatedNumberList that corresponds to the attribute is not cleared before the attribute is re-parsed. E.g.: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 17:24:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 17:24:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824002428.EAC253545EEE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 Cameron McCormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38462| |review? Flag| | --- Comment #1 from Cameron McCormack 2009-08-23 17:24:28 PDT --- Created an attachment (id=38462) --> (https://bugs.webkit.org/attachment.cgi?id=38462) Fix and test -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 17:43:04 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 17:43:04 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20726] File upload failing to set Content-Type: application/octet-stream In-Reply-To: References: Message-ID: <20090824004304.160C935460C3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20726 Cuchaz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cuchaz at gmail.com --- Comment #2 from Cuchaz 2009-08-23 17:43:03 PDT --- This is also a problem in Google Chrome for linux, so it might not be a windows-only issue. On the server side, Struts2 thinks the content-type is null for such files. I'm not sure what headers are actually being sent. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 18:34:07 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 18:34:07 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28607] Body background color isn't drawn at bottom of page In-Reply-To: References: Message-ID: <20090824013407.F14CD35467A5@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28607 Gustaaf Groenendaal (MysteryQuest) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |webkit at mysteryquest.org Ever Confirmed|0 |1 --- Comment #3 from Gustaaf Groenendaal (MysteryQuest) 2009-08-23 18:34:07 PDT --- Experiencing the same problem with one of my own projects. The bug seems to occur most of the time when the site is not cached and not in history, but that may also every. This bug might be completely random however. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 18:50:43 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 18:50:43 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption In-Reply-To: References: Message-ID: <20090824015043.88B0935468D8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27756 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35087|0 |1 is obsolete| | Attachment #38463| |review? Flag| | --- Comment #20 from TAMURA, Kent 2009-08-23 18:50:42 PDT --- Created an attachment (id=38463) --> (https://bugs.webkit.org/attachment.cgi?id=38463) Proposed patch (rev.6) > You'll see from the log that trunk/WebCore/html/HTMLInputElement.idl has a tab > in it, which caused the svn pre-commit hook to fail. Oh, I'm sorry for that. I have updated the patch. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 19:50:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 19:50:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824025010.54FAD3546E2D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35185|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 19:50:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 19:50:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824025015.36DBC3546E48@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38464| |review? Flag| | --- Comment #15 from Fumitoshi Ukai 2009-08-23 19:50:14 PDT --- Created an attachment (id=38464) --> (https://bugs.webkit.org/attachment.cgi?id=38464) Add SocketStreamHandle interface --- 14 files changed, 839 insertions(+), 0 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 19:52:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 19:52:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090824025259.464C83546EA4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34548|review- | Flag| | Attachment #34548|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 19:53:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 19:53:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090824025303.7D17F3546EB8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38465| |review? Flag| | --- Comment #6 from Fumitoshi Ukai 2009-08-23 19:53:03 PDT --- Created an attachment (id=38465) --> (https://bugs.webkit.org/attachment.cgi?id=38465) WebSocket API implementation. depends on bug 28037 --- 17 files changed, 1276 insertions(+), 78 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 21:15:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 21:15:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28440] background-size: X treated as background-size: X X, not background-size: X auto In-Reply-To: References: Message-ID: <20090824041547.C96113547577@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28440 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdakin at apple.com, | |hyatt at apple.com, | |mitz at webkit.org --- Comment #1 from mitz at webkit.org 2009-08-23 21:15:47 PDT --- The draft does say “If only one value is given the second is assumed to be ‘auto’”, but this sort of behavior doesn’t make much sense to me, especially given the behavior of background-repeat and the 4-value (top-right-bottom-left) properties, where missing values are filled in with specified values. If the spec isn’t going to change, we will need to fix this bug, but we will also have to undo the aliasing of -webkit-background-size to background-size and have the former maintain the current parsing. We also need to decide what to do about -webkit-mask-size. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:13:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:13:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824051324.0B8183547A38@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 --- Comment #5 from Darin Adler 2009-08-23 22:13:23 PDT --- (In reply to comment #4) > We use at the top of the file: > > #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)) > > I spoke to Jeremy about hit and he thought we could reduce it to just > PLATFORM(DARWIN). Mechanically that's OK, but it's not exactly the right concept. PLATFORM(DARWIN) is really supposed to be an OS-level switch like PLATFORM(WINOS) that tells you what low level OS is on the target machine. PLATFORM(DARWIN) means Apple's Unix variant with things like frameworks and certain libraries expected to be installed. This seems to be more about which style of user interface we want. Chromium creates a non-Mac platform that wants to follow Mac user interface style because while it's virtual it is on a Mac. To make that clear I think we'll probably need a different macro in the long run. Short run, we might be OK saying PLATFORM(DARWIN) here unless there's some other port running with PLATFORM(DARWIN) defined that doesn't want this behavior. For example, it's not too farfetched to imagine trouble if you were compiling for QT or GTK on a Mac. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:13:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:13:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824051347.04ADA3547A4E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38461|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:14:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:14:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824051419.256083547A5E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |darin at apple.com --- Comment #3 from Darin Adler 2009-08-23 22:14:18 PDT --- (In reply to comment #1) > prepare-ChangeLog doesn't work if the only changes I've made are to > properties Right, it doesn't consider property changes as something it should list in the change log. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:18:44 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:18:44 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824051844.2FC7C3547ACC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 --- Comment #4 from Cameron McCormack 2009-08-23 22:18:43 PDT --- (In reply to comment #3) > Right, it doesn't consider property changes as something it should list in the > change log. Should it? It might make generating patches like this one easier if prepare-ChangeLog could be used. If so, I can file a bug and supply a patch for prepare-ChangeLog if you like. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:20:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:20:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824052052.A18693547AF4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38462|review? |review+ Flag| | --- Comment #2 from Darin Adler 2009-08-23 22:20:52 PDT --- (From update of attachment 38462) > + * svg/dom/resources/text-rotate-live.js: Added. > + (getRotate): > + (getAndSetRotate): If you're not commenting on these functions individually and the file is new, then there's no need to leave this list of functions in the change log. The idea of prepare-ChangeLog is that it helps you write the ChangeLog entry, not that you should use that it generates as-is. The test code doesn't follow our usual brace style. Open braces for functions go on their own lines. Single line for loop bodies don't get braces around them. I would have put the "var" for the "i" variable inside the for loop. I believe the function results could be arrays rather than strings -- the shouldBe macro knows how to check arrays for equality. We don't use "get" in the names of functions that simply return results. None of these are significant issues, r=me on this patch as it is. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:23:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:23:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824052354.6AFF23547B3A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 --- Comment #5 from Darin Adler 2009-08-23 22:23:54 PDT --- (In reply to comment #4) > (In reply to comment #3) > > Right, it doesn't consider property changes as something it should list in the > > change log. > > Should it? It might make generating patches like this one easier if > prepare-ChangeLog could be used. If so, I can file a bug and supply a patch > for prepare-ChangeLog if you like. Sure, it would be OK. As with newly-added files we could consider pre-adding a comment to the generated file to say what the change is. For example, changing the state of the executable flag is one of the most common changes and it would be good to do it automatically. On the flip side, when changing flags on tons of files, having a list of the files with flags changed is probably not helpful in the way that listing files with contents changed is in typical patches. I have a slight fear that we'll have change log entries that are largely vacuous. Contributors don't seem to treat the change log as a communication tool as much as I'd like; those lists of files and functions are supposed to be for human consumption, and folks should read them and change anything that does not seem helpful. But yes, that would be a nice thing to fix. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:30:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:30:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824053010.BFC5F3547BC9@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 --- Comment #3 from Cameron McCormack 2009-08-23 22:30:10 PDT --- (In reply to comment #2) > If you're not commenting on these functions individually and the file is new, > then there's no need to leave this list of functions in the change log. The > idea of prepare-ChangeLog is that it helps you write the ChangeLog entry, not > that you should use that it generates as-is. I will keep that in mind for future patches. > The test code doesn't follow our usual brace style. OK. I see there's no mention of JS style in http://webkit.org/coding/coding-style.html but I'll admit I didn't check it before writing the code. > Open braces for functions > go on their own lines. Single line for loop bodies don't get braces around > them. I would have put the "var" for the "i" variable inside the for loop. I used to too, but now tend to put vars at the top of functions to emphasise that their scope is indeed the whole function and not just the loop. > I believe the function results could be arrays rather than strings -- the > shouldBe macro knows how to check arrays for equality. Acknowledged. I didn't look up shouldBe to see exactly what it was checking; I just copied another test that was doing string comparisons and thought that it was just safer to do that. > We don't use "get" in the names of functions that simply return results. I guess that's Java style rubbing off on me. :) > None of these are significant issues, r=me on this patch as it is. Thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:31:38 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:31:38 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 24300] Add CSSKeepVisitedLinksPrivate option to WebCore In-Reply-To: References: Message-ID: <20090824053138.A92373547BFF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=24300 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tkent at chromium.org --- Comment #29 from TAMURA, Kent 2009-08-23 22:31:38 PDT --- FYI: a similar bug entry for Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=147777 They have discussed this issue for 7 years. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:33:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:33:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28674] New: background-size fails to parse if a single length/percentage/auto is followed by a comma Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28674 Summary: background-size fails to parse if a single length/percentage/auto is followed by a comma Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Normal Priority: P2 Component: CSS AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: mitz at webkit.org WebKit successfully parses “background-size: 100px;", but fails to parse “background-size: 100px, 200px 300px;”. The comma confuses parseFillSize(). Patch forthcoming. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:40:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:40:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28674] background-size fails to parse if a single length/percentage/auto is followed by a comma In-Reply-To: References: Message-ID: <20090824054008.429E13547CE0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28674 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38466| |review? Flag| | --- Comment #1 from mitz at webkit.org 2009-08-23 22:40:07 PDT --- Created an attachment (id=38466) --> (https://bugs.webkit.org/attachment.cgi?id=38466) Patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:40:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:40:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824054036.8170E3547D0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34534|0 |1 is obsolete| | Attachment #38467| |review? Flag| | --- Comment #16 from TAMURA, Kent 2009-08-23 22:40:35 PDT --- Created an attachment (id=38467) --> (https://bugs.webkit.org/attachment.cgi?id=38467) Proposed patch (rev.5) Updated test cases. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:46:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:46:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824054624.ED4CB3547DB0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 TAMURA, Kent changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38467|review? | Flag| | Attachment #38467|0 |1 is obsolete| | Attachment #38468| |review? Flag| | --- Comment #17 from TAMURA, Kent 2009-08-23 22:46:24 PDT --- Created an attachment (id=38468) --> (https://bugs.webkit.org/attachment.cgi?id=38468) Proposed patch (rev.6) Oops, I found LayoutTests/ChangeLog in the rev.5 was incomplete. Corrected it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 22:49:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 22:49:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824054919.120943547E12@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 --- Comment #18 from TAMURA, Kent 2009-08-23 22:49:18 PDT --- (In reply to comment #13) > I'm going to approve this as is. I would like you to consider a follow-up > patch to share more of this code. Sure. I'll try it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 23:00:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 23:00:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28293] [Chromium] event.datatransfer.getdata("text/uri-list") treated the same as getdata("URL") In-Reply-To: References: Message-ID: <20090824060024.668BA3547F0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28293 Roland Steiner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34819|0 |1 is obsolete| | Attachment #38469| |review? Flag| | --- Comment #3 from Roland Steiner 2009-08-23 23:00:23 PDT --- Created an attachment (id=38469) --> (https://bugs.webkit.org/attachment.cgi?id=38469) patch: handle "text/uri-list" (Windows only atm), updated Changed patch according to review notes. Also removed a superfluous #include. Note on layout tests: I actually wrote a test for the functionality that works fine on Safari Mac, but haven't included it here since Chromium doesn't (yet) support the necessary interfaces (and it felt strange to include a layout test and immediately disable it for the platform for which one submits the patch). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Sun Aug 23 23:37:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Sun, 23 Aug 2009 23:37:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 5863] feMorphology filter is not implemented In-Reply-To: References: Message-ID: <20090824063714.8984D3548273@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=5863 Dirk Schulze changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38470| |review? Flag| | --- Comment #1 from Dirk Schulze 2009-08-23 23:37:14 PDT --- Created an attachment (id=38470) --> (https://bugs.webkit.org/attachment.cgi?id=38470) feMorphologyElement Added feMorphologyElement as preparation for FEMorphology filter effect. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:12:24 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:12:24 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28154] clicking below end of text in a textarea moves cursor to wrong position In-Reply-To: References: Message-ID: <20090824071224.5060A354860F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28154 Xan Lopez changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from Xan Lopez 2009-08-24 00:12:23 PDT --- (In reply to comment #4) > (In reply to comment #3) > > Thanks, committed as r47687 with those changes. > > This changed introduced a regression in the following test: > editing/execCommand/toggle-compound-styles.html -> failed > > The change in http://trac.webkit.org/changeset/46920 might be helpful. I guess > we need to rebaseline the test to match mac? Yeah, I just did this and the bot is green again, thanks! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:16:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:16:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090824071628.96E8B354869D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38465|review? | Flag| | Attachment #38465|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:16:33 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:16:33 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090824071633.4237235486AE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Fumitoshi Ukai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38471| |review? Flag| | --- Comment #7 from Fumitoshi Ukai 2009-08-24 00:16:32 PDT --- Created an attachment (id=38471) --> (https://bugs.webkit.org/attachment.cgi?id=38471) WebSocket API implementation. depends on bug 28037 --- 16 files changed, 1278 insertions(+), 78 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:23:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:23:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28675] New: Make prepare-ChangeLog notice property changes Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28675 Summary: Make prepare-ChangeLog notice property changes Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: P2 Component: Tools / Tests AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: cam at mcc.id.au It would be good if prepare-ChangeLog would not bail if only properties have been modified. It would be handy too if the property changes are noticed and included in the ChangeLog entry. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:36:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:36:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28675] Make prepare-ChangeLog notice property changes In-Reply-To: References: Message-ID: <20090824073632.3EDAA354893F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28675 --- Comment #1 from Cameron McCormack 2009-08-24 00:36:31 PDT --- Created an attachment (id=38472) --> (https://bugs.webkit.org/attachment.cgi?id=38472) Make prepare-ChangeLog work as described This causes prepare-ChangeLog to add ChangeLog entries like this: * path/to/file: Added xxx property. * path/to/file: Modified xxx property. * path/to/file: Removed xxx property. if one property was changed on the file, and: * path/to/file: Changed properties. if more than one property was changed. These descriptions are only inserted if there is no change to the file contents itself. Also, now if the only changes to the repository are property changes, a ChangeLog entry will still be prepared, whereas currently it will bail and say "No changes found". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:37:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:37:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28675] Make prepare-ChangeLog notice property changes In-Reply-To: References: Message-ID: <20090824073718.BAC59354895B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28675 Cameron McCormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38472| |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:38:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:38:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824073848.2B9363548979@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 --- Comment #6 from Cameron McCormack 2009-08-24 00:38:47 PDT --- (In reply to comment #5) > As with newly-added files we could consider pre-adding a comment to the > generated file to say what the change is. For example, changing the state of > the executable flag is one of the most common changes and it would be good to > do it automatically. > > On the flip side, when changing flags on tons of files, having a list of the > files with flags changed is probably not helpful in the way that listing files > with contents changed is in typical patches. I have a slight fear that we'll > have change log entries that are largely vacuous. Contributors don't seem to > treat the change log as a communication tool as much as I'd like; those lists > of files and functions are supposed to be for human consumption, and folks > should read them and change anything that does not seem helpful. > > But yes, that would be a nice thing to fix. Filed https://bugs.webkit.org/show_bug.cgi?id=28675 for this. Agreed with the chance for creating large, useless ChangeLog entries, but hopefully contributors will use common sense and pare them down if necessary. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 00:42:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 00:42:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28675] Make prepare-ChangeLog notice property changes In-Reply-To: References: Message-ID: <20090824074245.8949D35489D7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28675 --- Comment #2 from Cameron McCormack 2009-08-24 00:42:45 PDT --- BTW I haven't tested this on a git checkout, where there should be no change in behaviour, since git doesn't have properties. A small additional note: older versions of svn have output like this: Property changes on: blah ----------------------------- Name: svn:executable + * where it doesn't explicitly note if the property was added/modified/deleted. The patch here falls back in this case to the description "Changed properties". -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 01:15:45 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 01:15:45 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824081545.9ADDF3548CED@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38468|review? |review+, commit-queue+ Flag| | --- Comment #19 from Eric Seidel 2009-08-24 01:15:44 PDT --- (From update of attachment 38468) LGTM. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 01:28:59 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 01:28:59 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824082859.3BAD43548E4A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38468|review+, commit-queue+ | Flag| | --- Comment #20 from Eric Seidel 2009-08-24 01:28:58 PDT --- (From update of attachment 38468) Clearing flags on attachment: 38468 Committed r47702: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 01:29:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 01:29:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824082902.C278E3548E6C@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #21 from Eric Seidel 2009-08-24 01:29:01 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 01:29:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 01:29:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 19264] HTML5 Forms Implementation - Master bug In-Reply-To: References: Message-ID: <20090824082903.8B70A3548E88@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=19264 Bug 19264 depends on bug 21248, which changed state. Bug 21248 Summary: Support placeholder on textarea https://bugs.webkit.org/show_bug.cgi?id=21248 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 02:10:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 02:10:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28676] New: Safari 4 not releasing memory back to the operating system Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28676 Summary: Safari 4 not releasing memory back to the operating system Product: WebKit Version: 528+ (Nightly build) Platform: PC URL: http://farm3.static.flickr.com/2552/3851167461_d56de44 d47_o.png OS/Version: Windows XP Status: UNCONFIRMED Severity: Normal Priority: P2 Component: JavaScriptCore AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: jaffathecake at gmail.com Once Safari has claimed memory from the operating system, it doesn't seem to give it back, even though it's no longer using it. Running the first test on the following page http://www.jakearchibald.co.uk/jsperformance/closurememory/1.html, this creates a 1mb string every second. http://www.flickr.com/photos/jaffathecake/3851167461/sizes/o/ Chrome (and other browsers) release the memory back to the operating system when the test is ended, whereas Safari keeps it, even if the tab is closed. Safari will reuse the memory it has reserved, but it doesn't give it back to the operating system, even if it has claimed 700mb+. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 02:35:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 02:35:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28676] Safari 4 not releasing memory back to the operating system In-Reply-To: References: Message-ID: <20090824093554.CE3693549452@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28676 Jake Archibald changed: What |Removed |Added ---------------------------------------------------------------------------- Component|JavaScriptCore |New Bugs --- Comment #1 from Jake Archibald 2009-08-24 02:35:54 PDT --- This is an issue in 526 (not tested the nightly builds) but the option wasn't available. Not sure which component this should be part of either. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 02:37:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 02:37:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 5863] feMorphology filter is not implemented In-Reply-To: References: Message-ID: <20090824093751.2565F3549485@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=5863 --- Comment #2 from Dirk Schulze 2009-08-24 02:37:50 PDT --- Created an attachment (id=38473) --> (https://bugs.webkit.org/attachment.cgi?id=38473) feMorphology filter effect This is the filter effect feMorphology. I hope that I can make the algorithm more efficient. So this is just for testing atm. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 03:10:03 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 03:10:03 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28408] WebInspector: Migrate call frames interaction to the InjectedScript-based schema. In-Reply-To: References: Message-ID: <20090824101003.681553549781@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28408 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #2 from Pavel Feldman 2009-08-24 03:10:02 PDT --- Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/CallStackSidebarPane.js M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/DOMAgent.js M WebCore/inspector/front-end/ElementsPanel.js M WebCore/inspector/front-end/InjectedScript.js M WebCore/inspector/front-end/ObjectPropertiesSection.js M WebCore/inspector/front-end/ObjectProxy.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/ScopeChainSidebarPane.js M WebCore/inspector/front-end/ScriptsPanel.js Committed r47703 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 03:19:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 03:19:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090824101937.ADA603549869@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 Zan Dobersek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38455|0 |1 is obsolete| | Attachment #38474| |review? Flag| | --- Comment #20 from Zan Dobersek 2009-08-24 03:19:37 PDT --- Created an attachment (id=38474) --> (https://bugs.webkit.org/attachment.cgi?id=38474) Implementations, modifications, improvements. Basically the last WIP patch with ChangeLogs, an early return used in MediaPlayerPrivate::currentTime() and audio sink creation and application to the playbin removed, as recommended by kov. Also puts some style back to the media section of the Skipped list (was a mess in WIP patch). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 03:25:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 03:25:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28677] New: Allow excluding certain plugins from loading Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28677 Summary: Allow excluding certain plugins from loading Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Enhancement Priority: P2 Component: WebCore Misc. AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: damarvy at gmail.com Marius Renn changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38475| |review? Flag| | Created an attachment (id=38475) --> (https://bugs.webkit.org/attachment.cgi?id=38475) Proposed patch to implement the plugin loading delegation described in the feature request. (Note, this is a re-post as the original got lost in a bugzilla crash). It is well-known that plugins can cause problems, in the worst case leading to a crash. Unfortunately, this can happen as early as plugin-loading, as code may be executed on the plugin during this stage. One way this can be worked around is by using the recently introduced patch to change the plugin directory. However, in some applications it may not be desirable to switch to a different directory. Instead, a client may wish to filter the list of plugins to load. Therefore I propose adding a client callback class (or delegate), which allows filtering plugins based on its path or other attributes such as name, version, etc. I have included a proposed patch that implements this functionality, by introducing an abstract base class PluginDatabaseClient with two pure virtual methods shouldLoadPluginAtPath() and shouldLoadPluginPackage(). These are called in sequence, and if any of these return false, the current plugin is not loaded. For instance, if shouldLoadPluginAtPath() returns false, no further inspection of the plugin is performed. Such a client can be set (optionally) by calling setClient() on the PluginDatabase singleton instance. Note, that the instance must be created without populating as the following example shows (where myPluginLoaderClient denote some PluginDatabaseClient implementation): PluginDatabase* db = PluginDatabase::installedPlugins(false); // Do not load plugins db->setClient(myPluginLoaderClient); // Set client instance db->setPluginDirectories(PluginDatabase::defaultPluginDirectories()); db->refresh(); // Load plugins with client in place -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 04:10:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 04:10:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18027] CSS3 Selector Test: combination of hover and multiple chained sibling selector fails in Webkit In-Reply-To: References: Message-ID: <20090824111047.D34283549CA8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18027 Yusuke Sato changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33521|review- | Flag| | Attachment #33521|0 |1 is obsolete| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 04:10:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 04:10:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18027] CSS3 Selector Test: combination of hover and multiple chained sibling selector fails in Webkit In-Reply-To: References: Message-ID: <20090824111052.70EFC3549CBB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18027 Yusuke Sato changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38476| |review? Flag| | --- Comment #8 from Yusuke Sato 2009-08-24 04:10:52 PDT --- Created an attachment (id=38476) --> (https://bugs.webkit.org/attachment.cgi?id=38476) hover-adjacent-v2 --- 9 files changed, 238 insertions(+), 5 deletions(-) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 04:14:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 04:14:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 18027] CSS3 Selector Test: combination of hover and multiple chained sibling selector fails in Webkit In-Reply-To: References: Message-ID: <20090824111436.CE0D73549D0F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=18027 --- Comment #9 from Yusuke Sato 2009-08-24 04:14:36 PDT --- Thanks for your review! I've attached the v2 patch: - added dumpAsText(). - removed PNGs and its checksums. - fixed indent level. Could you take another look? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:10:35 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:10:35 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28340] 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be wrapped In-Reply-To: References: Message-ID: <20090824121035.915D4354A1F7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28340 --- Comment #11 from Pavel Feldman 2009-08-24 05:10:35 PDT --- Created an attachment (id=38477) --> (https://bugs.webkit.org/attachment.cgi?id=38477) MiniBrowser 64-bit -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:18:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:18:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090824121850.98041354A2B7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 Norbert Leser changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34683|review- |review? Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:24:36 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:24:36 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28340] 64-bit: ASSERTION FAILED: Objects passed to JSInspectedObjectWrapper must be wrapped In-Reply-To: References: Message-ID: <20090824122436.528FF354A33F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28340 --- Comment #12 from Pavel Feldman 2009-08-24 05:24:35 PDT --- (In reply to comment #11) > Created an attachment (id=38477) --> (https://bugs.webkit.org/attachment.cgi?id=38477) [details] > MiniBrowser 64-bit I see no problems running MiniBrowser 64-bit. All test cases behave as in Safari 4, I see no assertions triggered. See screenshot attached. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:28:47 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:28:47 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824122847.9343D354A39A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 --- Comment #6 from Robert Sesek 2009-08-24 05:28:47 PDT --- (In reply to comment #5) > Mechanically that's OK, but it's not exactly the right concept. > PLATFORM(DARWIN) is really supposed to be an OS-level switch like > PLATFORM(WINOS) that tells you what low level OS is on the target machine. > PLATFORM(DARWIN) means Apple's Unix variant with things like frameworks and > certain libraries expected to be installed. > > This seems to be more about which style of user interface we want. Chromium > creates a non-Mac platform that wants to follow Mac user interface style > because while it's virtual it is on a Mac. > > To make that clear I think we'll probably need a different macro in the long > run. Short run, we might be OK saying PLATFORM(DARWIN) here unless there's some > other port running with PLATFORM(DARWIN) defined that doesn't want this > behavior. For example, it's not too farfetched to imagine trouble if you were > compiling for QT or GTK on a Mac. Then to be on the safe side, I think the answer is to use, like we do earlier in the same file, PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)). >From what I've discovered on mailing lists, PLATFORM(MAC) is used pretty much for Safari on OS X. Perhaps the right answer long-term is to make a PLATFORM(SAFARI) so that PLATFORM(MAC) can be used in instances like this. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:34:00 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:34:00 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824123400.15D38354A425@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Robert Sesek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38458|review? | Flag| | Attachment #38458|0 |1 is obsolete| | Attachment #38478| |review? Flag| | --- Comment #7 from Robert Sesek 2009-08-24 05:33:59 PDT --- Created an attachment (id=38478) --> (https://bugs.webkit.org/attachment.cgi?id=38478) Adjusted condition per comment 6 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:56:17 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:56:17 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 25620] REGRESSION (r43007): In MobileMe Calendar, New Event text is displayed offset when it's first created In-Reply-To: References: Message-ID: <20090824125617.7FE62354A601@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=25620 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:56:50 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:56:50 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20494] REGRESSION: MLB Gameday doesn't load In-Reply-To: References: Message-ID: <20090824125650.7F546354A60B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20494 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:57:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:57:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20966] "New" corner out of place at Apple iTunes overview page In-Reply-To: References: Message-ID: <20090824125751.AA009354A629@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20966 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:57:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:57:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20587] WebKit eats CPU on http://uk.sun.com/tryandbuy/products.jsp In-Reply-To: References: Message-ID: <20090824125755.E6044354A62F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20587 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:58:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:58:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 20964] Huge memory usage on Dromaeo test In-Reply-To: References: Message-ID: <20090824125805.DFDF6354A63D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=20964 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:58:54 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:58:54 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 8753] REGRESSION (r14032): Incorrect and non-uniform text zoom applied after going forward and backward In-Reply-To: References: Message-ID: <20090824125854.8CBDE354A65B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=8753 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 05:59:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 05:59:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 9254] Quirksmode: Safari ignores window.close() after form submission In-Reply-To: References: Message-ID: <20090824125908.45C72354A673@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=9254 Evan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emacemac7 at mac.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 06:57:49 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 06:57:49 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28422] Linking fails with "relocation R_X86_64_PC32 against symbol `cti_vm_throw'" In-Reply-To: References: Message-ID: <20090824135749.AB5F1354AF6F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28422 Priit Laes (IRC: plaes) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35026|0 |1 is obsolete| | --- Comment #5 from Priit Laes (IRC: plaes) 2009-08-24 06:57:49 PDT --- Created an attachment (id=38479) --> (https://bugs.webkit.org/attachment.cgi?id=38479) webkit-bug-28422-use-plt-segment-for-cti_vm_throw-v2.patch Added #if PLATFORM(LINUX) guards suggested by bdash. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 07:27:51 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 07:27:51 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27211] fastMalloc and fastFree mismatch correction In-Reply-To: References: Message-ID: <20090824142751.8829A354B3CA@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27211 Kelemen Balázs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Kelemen.Balazs.3 at stud.u-sze | |ged.hu --- Comment #4 from Kelemen Balázs 2009-08-24 07:27:51 PDT --- I think there is no problem freeing with fastFree here, since Vector allocates it's storage with fastMalloc. What have I missed? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 07:27:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 07:27:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090824142752.289D4354B3E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38474|review? |review+, commit-queue- Flag| | --- Comment #21 from Gustavo Noronha (kov) 2009-08-24 07:27:51 PDT --- (From update of attachment 38474) > + // Splitting the capability by comma and taking the first part > + // as capability can be something like "audio/x-wavpack, framed=(boolean)false" > + gchar** capability = g_strsplit(gst_caps_to_string(caps), ",", 2); There's a small leak here - gst_caps_to_string returns a string that needs to be freed. I will turn this into a GOwnPtr when landing. Other than that, r=me. I'll land it. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 07:31:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 07:31:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 16356] [GTK] Integrate GStreamer video with the graphics backend In-Reply-To: References: Message-ID: <20090824143148.87D40354B475@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=16356 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38474|review+, commit-queue- | Flag| | --- Comment #22 from Gustavo Noronha (kov) 2009-08-24 07:31:48 PDT --- (From update of attachment 38474) Landed as r47710. Is there any reason for this bug to remain open, Zan? If you feel not, please close it =). Clearing flags. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 07:56:15 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 07:56:15 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090824145615.802AD354B7FD@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35022|review+, commit-queue- | Flag| | --- Comment #11 from Gustavo Noronha (kov) 2009-08-24 07:56:15 PDT --- (From update of attachment 35022) Landed as r47712. I had overlooked the fact that I could not determine the origin of the .cur file. I replaced the one you provided with a cell.cur from Mozilla sources, that I know is licensed in a good way. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 08:05:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 08:05:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090824150514.68209354B910@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Gustavo Noronha (kov) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |gns at gnome.org Resolution| |FIXED -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 08:39:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 08:39:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28678] New: WebInspector: Only expand local scope when hitting the break Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28678 Summary: WebInspector: Only expand local scope when hitting the break Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pfeldman at chromium.org CC: timothy at hatcher.name Currently all the scopes are being expanded (CallFrame change regression). -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 08:41:02 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 08:41:02 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28678] WebInspector: Only expand local scope when hitting the break In-Reply-To: References: Message-ID: <20090824154102.73452354BD69@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28678 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38480| |review? Flag| | Status|UNCONFIRMED |ASSIGNED AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | Ever Confirmed|0 |1 --- Comment #1 from Pavel Feldman 2009-08-24 08:41:02 PDT --- Created an attachment (id=38480) --> (https://bugs.webkit.org/attachment.cgi?id=38480) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 09:01:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 09:01:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824160155.F1B2A354C053@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38464|review? |review+ Flag| | --- Comment #16 from Alexey Proskuryakov 2009-08-24 09:01:55 PDT --- (From update of attachment 38464) r=me -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 09:13:39 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 09:13:39 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28668] [Gtk] Test for HTTP authentication in Application cache fails In-Reply-To: References: Message-ID: <20090824161339.A2E46354C1B0@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28668 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ap at webkit.org -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 09:15:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 09:15:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28674] background-size fails to parse if a single length/percentage/auto is followed by a comma In-Reply-To: References: Message-ID: <20090824161519.1DD76354C1F4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28674 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38466|review? |review+ Flag| | -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 09:27:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 09:27:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28674] background-size fails to parse if a single length/percentage/auto is followed by a comma In-Reply-To: References: Message-ID: <20090824162732.00FF7354C340@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28674 mitz at webkit.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from mitz at webkit.org 2009-08-24 09:27:31 PDT --- Fixed in . -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:18:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:18:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28679] New: Touch and do not play well Product: WebKit Version: 528+ (Nightly build) Platform: S60 Emulator OS/Version: Linux Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Forms AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: carol.szabo at nokia.com It is impossible to select multiple elements in a multiple selection SELECT element by using only the touch screen (no control or shift keys). Is there support for this on other platforms? Is it acceptable to add a build flag such as USE_TOUCH_UI, that would change the behavior on mouse click of the SELECT element under WebCore/dom/SelectElement? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:27:09 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:27:09 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 26541] CSS property value serialization order is out of whack In-Reply-To: References: Message-ID: <20090824172709.038BB354CA75@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=26541 yaar at google.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38486| |review? Flag| | --- Comment #4 from yaar at google.com 2009-08-24 10:27:08 PDT --- Created an attachment (id=38486) --> (https://bugs.webkit.org/attachment.cgi?id=38486) A Fix Yuta's fix is correct and the layout test is wrong. WebKit implements CSS3's layered backgrounds, as described here: http://www.w3.org/TR/2008/WD-css3-background-20080910/#layering With layers, repeat-x, repeat-y isn't equivalent to repeat. Rather, it means layer 1 should repeat-x and layer 2 should repeat-y. Also, background-image is by default applied to the last layer. Therefore, the style "background-color:white; background-repeat: repeat-x,repeat-y" should inded serialize into: "repeat-x, white repeat-y". The change list includes Yuta's fix as well as the changes to the layout test that broke. p.s. This is my first submission to WebKit. I hope I adhered to all guidelines. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:28:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:28:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 10214] Can't break on funcations that you call from the console In-Reply-To: References: Message-ID: <20090824172828.A1779354CA9F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=10214 Chris Seaton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at chrisseaton.com --- Comment #2 from Chris Seaton 2009-08-24 10:28:28 PDT --- The worst thing about this is that it isn't documented anywhere, unless you looked for this bug report like I did. I was trying out the WebKit debugger and was assuming the breakpoints were just broken. Running a function from the console is an obvious way to test code and to get to breakpoints. I don't think it's a minor bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:33:10 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:33:10 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27658] Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects In-Reply-To: References: Message-ID: <20090824173310.10C5C354CB48@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27658 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33476|review? |review- Flag| | --- Comment #4 from David Levin 2009-08-24 10:33:09 PDT --- (From update of attachment 33476) > WebCore/dom/SelectElement.cpp (working copy) > =================================================================== > +// Returns the index of the next valid list item |skip| items past |listIndex| in direction |direction|. This isn't really correct as it could return listIndex or listIndex + 1, etc. even if skip = 10. > +// returns the index of the next valid item one page away from |startIndex| in direction |direction|. (Many instances) Make comments looks like sentences. (Start with a capital and end with a period.) > +int SelectElement::selectableListIndexPageFrom(SelectElementData& data, Element* element, int startIndex, SkipDirection direction) I can't make sense of this function name. It seems like it should stat with "next". Perhaps "nextSelectableListIndexPageAway". Also, after having read through this function it is unclear what it is trying to do and if it is correct. I think it attempts to find a "valid index" that is in this range (startIndex, startIndex + pageSize * direction] but if that fails, it tries to find a valid index (startIndex + pageSize * direction, direction == SkipForwards ? MAXINT : 0], so that's what I'll use as my guide. > + int pageSize = static_cast(element->renderer())->size() - 1; // -1 so we still show context 1 space before end of line comments. > + int index = nextValidIndex(items, indexOnePageAway + oppositeDirection, direction, 1); Relying on the enum value to be -1, +1 seems like a bad practice here. I know that "nextValidIndex" does but ideally it is only relied on there. > + if (index < 0 || index >= listSize ||(!isOptionElement(items[index]) || items[index]->disabled())) { Add a space after || here: "||(!isOptionElement". Unnecessary () around the last two items. At a higher level, this isn't correct because "index" may be valid but not in this range (startIndex, startIndex + pageSize * direction]. Add a test which exposes this issue. > +int SelectElement::firstSelectableListIndex(SelectElementData& data, Element* element) > +{ > + const Vector& items = data.listItems(element); > + int index = 0; > + while (index >= 0 && (unsigned) index < items.size() && (!isOptionElement(items[index]) || items[index]->disabled())) (Multiple places) Use c++ style casts. > void SelectElement::menuListDefaultEventHandler(SelectElementData& data, Element* element, Event* event, HTMLFormElement* htmlForm) > { ... > + if (endIndex >= 0 && Please move the && to the next line. > + (keyIdentifier == "Down" || keyIdentifier == "Up" || keyIdentifier == "Home" > + || keyIdentifier == "End" || keyIdentifier == "PageDown" || keyIdentifier == "PageUp")) { The || should be aligned with the ( from the previous line. > Index: WebCore/dom/SelectElement.h > =================================================================== > + static int selectableListIndexPageFrom(SelectElementData& data, Element* element, int startIndex, SkipDirection direction); Can this be moved out of the class and solely be defined within the SelectElement.cpp file? > Index: LayoutTests/fast/events/select-element.html > =================================================================== > + function log(s) Ideally use whole words for variables: "s" > + function sendKeyAndExpectIndex(selectId, key, initialIndex, expectedIndex) { ... > + if (select.selectedIndex != initialIndex) { > + log("can't set selectedIndex to " + initialIndex + ' (is ' > + + select.selectedIndex + ')'); Would be nice to align with ( > + return false; > + } > + if (window.layoutTestController) > + eventSender.keyDown(key); > + if (select.selectedIndex != expectedIndex) { > + log('selectedIndex should be ' + expectedIndex + ' (is ' + In keeping with the moving the &&, etc to the beginning of the next line, move the + to the next line would be nice. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:33:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:33:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27658] Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects In-Reply-To: References: Message-ID: <20090824173319.EB7F5354CB5D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27658 David Levin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |levin at chromium.org Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:42:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:42:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090824174222.80D7B354CC8D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 Darin Adler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34683|review? |review+ Flag| | --- Comment #8 from Darin Adler 2009-08-24 10:42:22 PDT --- (From update of attachment 34683) Seems fine. Would be better with a brief comment. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:49:48 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:49:48 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824174948.B2549354CD86@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 --- Comment #8 from Darin Adler 2009-08-24 10:47:37 PDT --- (In reply to comment #6) > From what I've discovered on mailing lists, PLATFORM(MAC) is used pretty much > for Safari on OS X. Perhaps the right answer long-term is to make a > PLATFORM(SAFARI) so that PLATFORM(MAC) can be used in instances like this. This is a great oversimplification and would not be correct. For example, Safari works on Windows. And tons of Mac OS X applications use the PLATFORM(MAC) version of WebKit, not just Safari. PLATFORM(MAC) is about having WebKit on top of Mac OS X frameworks like AppKit. The Chromium port is peculiar because it's WebKit on Mac OS X, but striving to not be on top of something like AppKit because of the particular architecture of the Chrome browser, and instead of being on top of the OS frameworks, it's on top a special Chromium layer. We do have a plan to fix the platform macros and make various more specific names, which should solve this problem. Maciej Stachowiak sent mail to webkit-dev a couple months ago about it. But PLATFORM(SAFARI) would be terrible and a step in the wrong direction! -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:52:58 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:52:58 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28418] changeVersion() doesn't seem to work In-Reply-To: References: Message-ID: <20090824175258.8CC0B354CDF4@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28418 Andrew Grieve changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agrieve at google.com --- Comment #1 from Andrew Grieve 2009-08-24 10:52:58 PDT --- Not sure how to mark it as such, but looks to be a dupe of https://bugs.webkit.org/show_bug.cgi?id=27836 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:53:32 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:53:32 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27836] Stale database version persists through browser refresh In-Reply-To: References: Message-ID: <20090824175332.40DB8354CE1B@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27836 Andrew Grieve changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agrieve at google.com -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:55:42 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:55:42 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27211] fastMalloc and fastFree mismatch correction In-Reply-To: References: Message-ID: <20090824175542.18CBB354CE6A@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27211 --- Comment #5 from Darin Adler 2009-08-24 10:55:41 PDT --- (In reply to comment #4) > I think there is no problem freeing with fastFree here, since Vector allocates > it's storage with fastMalloc. What have I missed? How Vector allocates its storage is irrelevant, since is not the vector storage being freed. The vector storage is a pointer in selectorVector.m_buffer.m_buffer. What's being freed here is selectorVector[i]. If you trace the flow of the code back you'll see that it's a CSSSelector object that was allocated by the CSSParser::createFloatingSelector function. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 10:59:05 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 10:59:05 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28632] Unable to drag Keepvid.com bookmarklet (to bookmarks bar) In-Reply-To: References: Message-ID: <20090824175905.C1D38354CEEC@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28632 Victor Wang changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victorw at chromium.org --- Comment #1 from Victor Wang 2009-08-24 10:59:04 PDT --- The reason why this bookmark can't be dragged is because it has child node. The current webkit code does not allow a node to be dragged if it has child node: bool EventHandler::shouldDragAutoNode(Node* node, const IntPoint& point) const { if (!node || node->hasChildNodes() || !m_frame->view()) return false; ... } -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:01:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:01:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28038] WebSocket API implementation In-Reply-To: References: Message-ID: <20090824180128.B61B5354CF4F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28038 Alexey Proskuryakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38471|review? |review- Flag| | --- Comment #8 from Alexey Proskuryakov 2009-08-24 11:01:28 PDT --- (From update of attachment 38471) +static bool IsValidProtocolString(const WebCore::String& protocol) Function names should start with lowercase letters. + if (!protocol.isEmpty() && !IsValidProtocolString(protocol)) { Would it make sense to move isEmpty() check to the helper function? +WebSocketChannel::WebSocketChannel(ScriptExecutionContext* context, WebSocketChannelClient* client, const KURL& url, const String& protocol) + : m_context(context) + , m_client(client) + , m_handshaker(WebSocketHandshaker(url, protocol, context)) + , m_buffer(0) + , m_buffer_size(0) Please use 4 spaces for indentation. + static const char frame_type[1] = {'\0'}; + static const char frame_end[1] = {'\xff'}; No need to have these static arrays - there's a version of Vector::append that takes const U&. + virtual void didReceivedData(SocketStreamHandle*, const char*, int); Typo: should be didReceiveData. + ASSERT(handle == m_handle.get() || !m_handle.get()); What are the situations when callbacks are called with null m_handle? Is it normal, or could it indicate problems? + KURL url(location); + m_handshaker.setURL(url); I'd write this in one line. +void WebSocketChannel::authenticate(const String& www_authenticate) This will break the build, because www_authenticate is unused. Also, this is wrong style, we use camelCase, not underlines for function and variable names. Please grep your patch with some expression like "[a-ln-z]_" to catch all cases, I won't point out each of them, as there are too many. +#include "WebSocketHandshaker.h" I had to google "handshaker", and although it's a word indeed, it seems to have too many unrelated meanings :). I think that "WebSocketHandshake" would be just fine. +#include "StringBuilder.h" + +#include No need for an empty line here. + return WebCore::String(); This code is already in WebCore namespace, no need for the prefix. Same issue below. +bool WebSocketHandshaker::headerProcess(const HTTPHeaderMap& headers) Maybe this should be processHeader()? -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:11:01 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:11:01 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824181102.0065E354D09E@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 Simon Fraser (smfr) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.fraser at apple.com --- Comment #22 from Simon Fraser (smfr) 2009-08-24 11:11:01 PDT --- 4 textarea tests are still failing after this change. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:12:37 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:12:37 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28623] svn-[un]apply should change directories to the repository root before [un]applying In-Reply-To: References: Message-ID: <20090824181237.1FE1E354D0E3@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28623 --- Comment #9 from Geoffrey Garen 2009-08-24 11:12:36 PDT --- Hi Joseph. Thanks for looking into this! It looks like the use of VCSUtils is incompatible with my system: ~/webkit/WebKitTools/mangleme$ svn-create-patch > ro.txt ? ro.txt ~/webkit/WebKitTools/mangleme$ svn-unapply !$ svn-unapply ro.txt Can't locate VCSUtils.pm in @INC (@INC contains: /Library/Perl/Updates/5.10.0 /System/Library/Perl/5.10.0/darwin-thread-multi-2level /System/Library/Perl/5.10.0 /Library/Perl/5.10.0/darwin-thread-multi-2level /Library/Perl/5.10.0 /Network/Library/Perl/5.10.0/darwin-thread-multi-2level /Network/Library/Perl/5.10.0 /Network/Library/Perl /System/Library/Perl/Extras/5.10.0/darwin-thread-multi-2level /System/Library/Perl/Extras/5.10.0 .) at /Users/ggaren/webkit/WebKitTools/Scripts/svn-unapply line 67. BEGIN failed--compilation aborted at /Users/ggaren/webkit/WebKitTools/Scripts/svn-unapply line 67. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:15:34 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:15:34 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28346] [GTK] Support for cursors that are images In-Reply-To: References: Message-ID: <20090824181534.43166354D149@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28346 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #12 from Eric Seidel 2009-08-24 11:15:33 PDT --- Sadly svn-apply can't handle git binary patches: patch: **** Only garbage was found in the patch input. patch -p0 "WebCore/manual-tests/gtk/resources/redcursor.cur" returned 2. Pass --force to ignore patch failures. Logging in as eric at webkit.org... Rejecting patch 35022 from commit-queue. This patch will require manual commit. bug 26830. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:15:52 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:15:52 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28623] svn-[un]apply should change directories to the repository root before [un]applying In-Reply-To: References: Message-ID: <20090824181552.D87AB354D170@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28623 Geoffrey Garen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38399|review? |review- Flag| | --- Comment #10 from Geoffrey Garen 2009-08-24 11:15:52 PDT --- (From update of attachment 38399) I guess I'll r- this for now to remove it from the queue. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:25:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:25:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824182523.198FA354D2CF@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38462| |commit-queue+ Flag| | --- Comment #4 from Eric Seidel 2009-08-24 11:25:22 PDT --- (From update of attachment 38462) Looks good to me too. I wonder if other "parse" implementations are missing a clear() call. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:26:20 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:26:20 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable In-Reply-To: References: Message-ID: <20090824182620.371DD354D2FB@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28669 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38461| |commit-queue- Flag| | --- Comment #7 from Eric Seidel 2009-08-24 11:26:19 PDT --- (From update of attachment 38461) Since the commit-queue is currently running from a git checkout, it won't be able to handle this. Someone will have to land this manually. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:26:56 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:26:56 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824182656.02851354D324@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38464| |commit-queue+ Flag| | --- Comment #17 from Eric Seidel 2009-08-24 11:26:55 PDT --- (From update of attachment 38464) Fumitoshi doesn't have commit bit, so marking cq+ -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:28:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:28:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 27060] Type cast for first argument in make_pair() In-Reply-To: References: Message-ID: <20090824182813.3ABE6354D372@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=27060 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34683|review+ |review- Flag| | --- Comment #9 from Eric Seidel 2009-08-24 11:28:12 PDT --- (From update of attachment 34683) Norbert isn't a committer, and darin is asking for a comment in the comment above, so marking this r- since no one can land this as is. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:35:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:35:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824183528.F18CB354D465@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38462|review+, commit-queue+ | Flag| | --- Comment #5 from Eric Seidel 2009-08-24 11:35:28 PDT --- (From update of attachment 38462) Clearing flags on attachment: 38462 Committed r47720: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:35:31 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:35:31 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28673] Modifying doesn't clear the corresponding SVGAnimatedNumberList In-Reply-To: References: Message-ID: <20090824183531.4F6ED354D471@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28673 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |eric at webkit.org Resolution| |FIXED --- Comment #6 from Eric Seidel 2009-08-24 11:35:30 PDT --- All reviewed patches have been landed. Closing bug. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:36:18 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:36:18 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824183618.EE86D354D48F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38464|commit-queue+ |commit-queue- Flag| | --- Comment #18 from Eric Seidel 2009-08-24 11:36:18 PDT --- (From update of attachment 38464) Rejecting patch 38464 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/build-webkit failed with exit code 1 -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:39:19 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:39:19 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824183919.993B5354D51D@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 --- Comment #9 from Jeremy Moskovich 2009-08-24 11:39:19 PDT --- Robert: The discussion of the right macros to use for cases like this seems to come up every time we need some code to be used on both Chrome/OS X & Safari since the current situation is sub-optimal. I think in the long term we need to fix this but I think the discussion of what that solution is belongs in a separate bug or on webkit-dev. Per-Darin's comment could you resubmit your first patch and use PLATFORM(DARWIN). Sam: Up till now we've resolved these issues by changing these to PLATFORM(DARWIN). Darin & Sam: Thanks for your comments, I don't want to sound like we don't care about doing the right thing for this, we most certain do want a good long term solution here! But as mentioned above, I think we should discuss this in another scope. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:39:23 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:39:23 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28623] svn-[un]apply should change directories to the repository root before [un]applying In-Reply-To: References: Message-ID: <20090824183923.9247D354D533@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28623 --- Comment #11 from Eric Seidel 2009-08-24 11:39:23 PDT --- This patch is missing the Find::Bin trick: use FindBin; use lib $FindBin::Bin; Will make it possible to include perl modules form the same directory. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:40:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:40:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824184028.BD933354D57F@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 --- Comment #23 from Eric Seidel 2009-08-24 11:40:28 PDT --- (In reply to comment #22) > 4 textarea tests are still failing after this change. On what platform? I assume windows since mac is green. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:41:55 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:41:55 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824184155.45154354D5CE@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 --- Comment #24 from Eric Seidel 2009-08-24 11:41:54 PDT --- http://build.webkit.org/results/Windows%20Release%20(Tests)/r47719%20(3707)/results.html Looks like windows will need new baselines or these tests will need to be converted not to be render tree dumps. tkent could do the test conversion, or we can just land the windows results from the bots. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:44:28 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:44:28 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28037] SocketStreamHandle interface for WebSocket API In-Reply-To: References: Message-ID: <20090824184428.85101354D613@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28037 Eric Seidel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric at webkit.org --- Comment #19 from Eric Seidel 2009-08-24 11:44:28 PDT --- Since this fails release build on the Mac, the patch will likely need more modification. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:46:22 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:46:22 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824184622.3769A354D659@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 --- Comment #25 from Eric Seidel 2009-08-24 11:46:21 PDT --- Will land windows results from the bot, shortly. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:54:11 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:54:11 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28626] WebKit quits (no crash log) when a link to a MPEG-1 file is clicked on. In-Reply-To: References: Message-ID: <20090824185411.610B6354D795@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28626 --- Comment #2 from Michael Pook 2009-08-24 11:54:10 PDT --- (In reply to comment #1) > I cannot reproduce this with a local debug build of r47661 on Mac OS X 10.5.8 > (Intel). Will upgrading to QuickTime 7.6.2 solve the problem for you? The version of QuickTime is NOT the issue, as both Presto and Gecko based browsers behave normally. I have removed the newer WebKit 530.20 based versions and replaced them with older WebKit 530.19 based versions. These older versions also behave normally. Clearly this issue is with WebKit based browsers using version 530.20 or higher. Perhaps the issue only affects systems running 10.4.11 Tiger (perhaps only on PowerPC machines)? I have verified that this is a problem on my eMac M8950LL/A, my iBook M9848LL/A and on my Mac Mini M9971LL/B. All the above are configured with the same OS and software. I do not own any Intel hardware or 10.5.8 Leopard to verify the issue on. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 11:56:14 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 11:56:14 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection In-Reply-To: References: Message-ID: <20090824185614.0483F354D7E8@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28670 Robert Sesek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38478|review? | Flag| | Attachment #38478|0 |1 is obsolete| | Attachment #38489| |review? Flag| | --- Comment #10 from Robert Sesek 2009-08-24 11:56:13 PDT --- Created an attachment (id=38489) --> (https://bugs.webkit.org/attachment.cgi?id=38489) Using just PLATFORM(DARWIN) -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 12:07:08 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 12:07:08 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28680] New: WebInspector: Simplify findTreeElement code, get rid of potential infinite loop. Message-ID: https://bugs.webkit.org/show_bug.cgi?id=28680 Summary: WebInspector: Simplify findTreeElement code, get rid of potential infinite loop. Product: WebKit Version: 528+ (Nightly build) Platform: All OS/Version: All Status: UNCONFIRMED Severity: Normal Priority: P2 Component: Web Inspector AssignedTo: webkit-unassigned at lists.webkit.org ReportedBy: pfeldman at chromium.org CC: timothy at hatcher.name Currently searching for inline node text can lead to infinite loop. -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 12:09:26 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 12:09:26 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28680] WebInspector: Simplify findTreeElement code, get rid of potential infinite loop. In-Reply-To: References: Message-ID: <20090824190926.B217A354D995@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=28680 Pavel Feldman changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38490| |review? Flag| | Status|UNCONFIRMED |ASSIGNED AssignedTo|webkit-unassigned at lists.web |pfeldman at chromium.org |kit.org | Ever Confirmed|0 |1 --- Comment #1 from Pavel Feldman 2009-08-24 12:09:26 PDT --- Created an attachment (id=38490) --> (https://bugs.webkit.org/attachment.cgi?id=38490) patch -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 12:10:25 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 12:10:25 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 21248] Support placeholder on textarea In-Reply-To: References: Message-ID: <20090824191025.26D83354D9D7@gamma.macosforge.org> https://bugs.webkit.org/show_bug.cgi?id=21248 --- Comment #26 from Eric Seidel 2009-08-24 12:10:24 PDT --- Committed r47721: -- Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. From bugzilla-daemon at webkit.org Mon Aug 24 12:18:13 2009 From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org) Date: Mon, 24 Aug 2009 12:18:13 -0700 (PDT) Subject: [Webkit-unassigned] [Bug 28679] Touch and