[Webkit-unassigned] [Bug 25500] New: Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 30 16:58:42 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25500

           Summary: Remove Range::compareBoundaryPoints(Position, Position)
                    per Darin's suggestion in bug 25056
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
OtherBugsDependingO 25056
             nThis:


Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion
in bug 25056

Darin indicated the Range should deal only with primitive DOM node/offset
pairs, and that Position (which is a more robust editing construct) should have
its own comparison functions and that Range.h should not mention Position at
all.

Turns out that Position already has a comparePositions() function (which knows
how to additionally handled positions in shadow trees).  So I've just changed
all callers of compareBoundaryPoints(Position, Position) to use the existing
comparePositions() function.  I've also added a comparePositions which takes
VisiblePositions for convenience.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list