[Webkit-unassigned] [Bug 25431] Simplify how SVG containers paint (and likely fix bugs by doing so)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25431





------- Comment #5 from eric at webkit.org  2009-04-28 12:04 PDT -------
(In reply to comment #4)
> (From update of attachment 29827 [review])
> Can we start to optimize painting by skipping children that are entirely
> clipped out?

Would we do that by clipping the damage rect and then checking against the
clipped damage rect?

> It's a shame we can't just fall back on RenderBox::computeRectForRepaint(). If
> we fixed that to be more HTML-agnostic, could we?

We could, I think that's fodder for a separate bug though.  And actually, I'm
not sure it will matter as the goal is to move all SVG renderers onto
RenderSVGModelObject, and then they'll all share one computeRectForRepaint
anyway.

> >  void RenderSVGRoot::calcViewport()
> Does this logic deserve to be wrapped in its own method?

Which logic?  calcViewport is the wrapper.  I do wonder if the SVGRoot for the
SVGImage case shouldn't be a different renderer all together...

> Some tests with <svg> inside transformed HTML would be good to see if this all
> works.

I don't think there are any of those yet.  I've never dealt with transformed
HTML, but yes, I expect much of this works.

> > +    bool calculateLocalTransform();
>
> What does the return value mean?

No clue.  That's all legacy code.  I'll remove the return value.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.