[Webkit-unassigned] [Bug 25432] Simplify SVG hit testing (and make it floating point precise)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 28 11:27:27 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25432





------- Comment #2 from simon.fraser at apple.com  2009-04-28 11:27 PDT -------
(From update of attachment 29829)


> +TransformationMatrix RenderForeignObject::localToParentTransform() const
> +{
> +    // FIXME: This trasition is backwards!
> +    // It should be localTransform() * translationForAttributes()
> +    // but leaving it backwards for now for LayoutTest result compatibility
> +    return translationForAttributes() * localTransform();
> +}

Reference the bug you filed in the comment.

> +    // SVG uses a different hit-testing system from CSS
> +    virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const FloatPoint& pointInParent, HitTestAction);

I'd rather the new nodeAtPoint got a different name to make it easier to fix
bug 23120.

Looks OK to me but I'd like hyatt to give the final word on whether we should
add nodeAtPoint proliferation.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list