[Webkit-unassigned] [Bug 16135] [GTK] Support caret browsing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16135





------- Comment #28 from xan.lopez at gmail.com  2009-04-28 00:48 PDT -------
(In reply to comment #26)
> (From update of attachment 29645 [review])
> +    bool caretBrowsing = settings() && settings()->caretBrowsingEnabled();
>      bool shouldBlink = m_caretVisible
> -        && selection()->isCaret() && selection()->isContentEditable();
> +        && selection()->isCaret() && (selection()->isContentEditable() ||
> caretBrowsing);
> 
> I was under the impression that we would not blink when caret browsing.  To
> provide a cue that the content is non editable.
> 

Hum, it seems that we actually need this in order for the caret to be visible.
Also, FWIW, in Gecko the caret actually blinks, most probably to make it easier
(or possible) to figure out where it is.

> 
> +    if (!selection()->isNone() || !(isContentEditable() || caretBrowsing))
> 
> You don't need the ()s here.
>

Mmm, are you sure? You mean like !isContentEditable() || !caretBrowsing ?
That's not really the same... 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.