[Webkit-unassigned] [Bug 16135] [GTK] Support caret browsing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16135





------- Comment #26 from justin.garcia at apple.com  2009-04-27 23:44 PDT -------
(From update of attachment 29645)
+    bool caretBrowsing = settings() && settings()->caretBrowsingEnabled();
     bool shouldBlink = m_caretVisible
-        && selection()->isCaret() && selection()->isContentEditable();
+        && selection()->isCaret() && (selection()->isContentEditable() ||
caretBrowsing);

I was under the impression that we would not blink when caret browsing.  To
provide a cue that the content is non editable.


+    if (!selection()->isNone() || !(isContentEditable() || caretBrowsing))

You don't need the ()s here.


         // If this is a change in selection resulting from a delete operation,
         // oldSelection may no longer be in the document.
-        if (closeTyping && oldSelection.isContentEditable() &&
oldSelection.start().node() && oldSelection.start().node()->inDocument()) {
+        if (closeTyping && (oldSelection.isContentEditable() || caretBrowsing)
 && oldSelection.start().node() && oldSelection.start().node()->inDocument()) {
             VisiblePosition oldStart(oldSelection.visibleStart());

Do you really want to mark misspelled words if they are non-editable?  The user
can't do anything about them.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.