[Webkit-unassigned] [Bug 25438] New: tcmalloc/Windows bug can cause random GetLastError() failures.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25438

           Summary: tcmalloc/Windows bug can cause random GetLastError()
                    failures.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mike at belshe.com


The latest release of tcmalloc for windows picks up an easy bug fix which can
effect windows builds:

TlsGetValue() will call SetLastError(0).  If you have code which looks like:

   MakeSomeWindowsCall(foo());
   if (GetLastError()) { ... }

if foo() returns something which needs to be destructed, that can call into
tcmalloc, which will use thread-local-storage, which will SetLastError(0).

Fix:  When calling TlsGetValue, do this:
    err = GetLastError()
    TlsGetValue()
    SetLastError(err)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.