[Webkit-unassigned] [Bug 16135] [GTK] Support caret browsing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 24 19:06:09 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=16135


gns at gnome.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29737|review?                     |review+
               Flag|                            |




------- Comment #19 from gns at gnome.org  2009-04-24 19:06 PDT -------
(From update of attachment 29737)
(In reply to comment #18)
> The GtkBinding thing would be nice, but I don't see an issue way of doing it
> here, since for the bindings to work you need to go the parent class of the
> view in keypress, which happens quite a bit later than this.
> 
> Also, the code for up/down/etc in caretBrowsing here is actually different than
> the one in EventHandler, so I've left it here for now. We may unify it, but I
> think it should be done in a different patch.

Those sound sane to me. This one is go in my opinion, too. So r=me. Now let's
find someone to get the first one looked at.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list