[Webkit-unassigned] [Bug 25380] LayoutTests/media/video-played.html has a race condition when starting the test.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25380


simon.fraser at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29768|review?(simon.fraser at apple.c|review+
               Flag|om)                         |




------- Comment #2 from simon.fraser at apple.com  2009-04-24 15:41 PDT -------
(From update of attachment 29768)
> Index: LayoutTests/ChangeLog
> ===================================================================
> --- LayoutTests/ChangeLog	(revision 42845)
> +++ LayoutTests/ChangeLog	(working copy)
> @@ -1,3 +1,16 @@
> +2009-04-24  Pierre d'Herbemont  <pdherbemont at apple.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fixed a race condition on the first 'played' attribute test start.
> +
> +        Previously we were starting nearly right away to play, and probably
> +        before receiving the 'canplay' event. Now we ensure we'll wait for
> +        that 'canplay' event before attempting to play.

"...before starting the tests."

>                  waitForEvent("loadedmetadata");
> -                waitForEvent("canplay", canplay);
> +                waitForEvent("canplay", canplay); // Will triggers nextTest() which launches the tests.

"Will trigger"

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.