[Webkit-unassigned] [Bug 24168] RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24168


xji at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29748|                            |review?
               Flag|                            |




------- Comment #13 from xji at chromium.org  2009-04-24 10:43 PDT -------
Created an attachment (id=29748)
 --> (https://bugs.webkit.org/attachment.cgi?id=29748&action=view)
patch w/ Layout test (version 5)

I've incorporated all the changes except that:

1. I am leaving the following block in logicalStartOfLine()
    // Make sure the start of line is not greater than the given input
position.  ....
    Position p = visPos.deepEquivalent();
    if (p.m_offset > c.deepEquivalent().m_offset &&
p.node()->isSameNode(c.deepEquivalent().node())) {
        ....
    }

2. I changed the inSameLogicalLine() block in logicalEndOfLine() to
    if (!inSameLogicalLine(c, visPos))
        visPos = visPos.previous();

Thanks,
Xiaomei


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.