[Webkit-unassigned] [Bug 15616] [GTK] Add spell checking (and grammar?)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 23 18:42:53 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=15616


gns at gnome.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29700|                            |review-
               Flag|                            |




------- Comment #27 from gns at gnome.org  2009-04-23 18:42 PDT -------
(From update of attachment 29700)
>  bool EditorClient::isContinuousSpellCheckingEnabled()
>  {
> -    notImplemented();
> -    return false;
> +    WebKitWebSettings* settings;
> +    gboolean enabled;
> +
> +    settings = webkit_web_view_get_settings(m_webView);
> +    g_object_get(settings, "enable-spell-checking", &enabled, NULL);

Move the initialization of settins to where it is declared; there is another
ocurrence of this a few lines down, fix it too =). Otherwise looks good. Please
fix this, and upload another patch adding a ChangeLog entry, too.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list