[Webkit-unassigned] [Bug 24900] Render empty optgroup elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24900


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29559|review?(hyatt at apple.com)    |review-
               Flag|                            |




------- Comment #13 from eric at webkit.org  2009-04-23 17:06 PDT -------
(From update of attachment 29559)
+        // Odd tags like <div> will already have been removed from the tree.
+        current = current->traverseNextSibling(this);

This needs a "so what?" explanation. 

// We traverse nextSibling instead of nextNode because... why?

Otherwise this looks fine.  If you update that comment you're good to land IMO.

If you post an updated comment I'm happy to land this for you.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.