[Webkit-unassigned] [Bug 17267] [GTK] Primary selection/clipboard support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17267


gns at gnome.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24698|review?(alp at nuanti.com)     |review+
               Flag|                            |




------- Comment #13 from gns at gnome.org  2009-04-22 19:38 PDT -------
(From update of attachment 24698)
> +        WARNING: NO TEST CASES ADDED OR CHANGED

This warning should be removed. There is no behavior change for webcore; we
could probably add GTK+ unit tests for this, though, in WebKit/gtk.

> +GtkClipboard* PasteboardHelperGtk::getPrimary(Frame* frame) const {
> +    WebKitWebView* webView = webkit_web_frame_get_web_view(kit(frame));
> +    return gtk_widget_get_clipboard(GTK_WIDGET (webView),
> +                                    GDK_SELECTION_PRIMARY);
> +}
> +

I believe the only problem with this patch is the incorrect placement of braces
here. Whoever lands, please fix this, and rs=me on a second commit to fix the
other braces in this file.

I wonder if we should review the PasteBoard files placements as a whole,
sometime.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.