[Webkit-unassigned] [Bug 24977] InspectorController is difficult to get to on the Page

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 22 11:17:46 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=24977


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29150|review?                     |review+
               Flag|                            |




------- Comment #2 from eric at webkit.org  2009-04-22 11:17 PDT -------
(From update of attachment 29150)
This looks fine.  I assume that Page::inspectorController() can never be null?

Also, you should consider adding a comment to Frame::inspectorController() in
the header, noting that it can return 0.

Otherwise looks good.  r+.  If you don't have commit bit, please upload a new
patch if you act on the above comments (or need to make other changes).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list