[Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16401





------- Comment #192 from xan.lopez at gmail.com  2009-04-22 04:27 PDT -------
> > +inline gchar * gdom_gstring_convert(WebCore::String const& s) { return g_strdup(s.utf8().data()); }
> > +inline gchar * gdom_gstring_convert(WebCore::KURL const& s) { return g_strdup(s.string().utf8().data()); }
> > +inline gchar * gdom_gstring_convert(const JSC::UString & s) { return g_strdup(s.UTF8String().c_str()); }
> > +inline gchar * gdom_gstring_convert(WebCore::AtomicString const&s) { return g_strdup(s.string().utf8().data()); }
> 
> This doesn't follow our coding style.  The spacing around operators is
> inconsistent, and the function names are using lower case with underscores.
> 

BTW, I think I said this once already in the bug, but IMHO those functions
sholdn't be prefixed with 'gdom', since they are not specific to the DOM
bindings and could be used all over the GTK+ port code. Not sure what would be
a good alternative, perhaps something  like gwebcore or something...


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.