[Webkit-unassigned] [Bug 22551] [GTK] API to start inspector for a WebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22551





------- Comment #17 from zuh at iki.fi  2009-04-22 01:19 PDT -------
(In reply to comment #16)
> (In reply to comment #14)
> > /**
> >  * webkit_web_inspector_inspect:
> >  * @web_inspector: a #WebKitWebInspector
> >  * @inspector_panel: a string identifying the panel to show
> >  *
> >  * Activates the #WebKitWebInspector and switches it to the specified inspector
> >  * panel. The inspector is activated with the document node of the currently
> >  * focused or the main frame of the associated #WebKitWebView. If the panel
> >  * string is NULL or specifies an unkown panel, no switching will occur.
> >  *
> >  * Since: 1.1.6
> >  **/
> > void webkit_web_inspector_inspect(WebKitWebInspector *web_inspector,
> >                                   const gchar *inspector_panel)
> 
> That sounds good to me, but I think the verb has to be changed from inspect to
> something else.

Oh, good point. It worked for the view API but is clearly wrong here.

> The best option I could come up with up to now is 'start'; I
> had considered things such as 'show', 'launch', 'present', but these have
> well-defined meanings in GTK+ already, so I propose using 'start' or 'open' as
> suggested by Christian, whatever works best for you.

What about _activate()? It would then make sense to use this method to switch
the panel in the already visible inspector. And maybe then provide
_activate_panel() if someone wants a version that doesn't imply activating the
inspector itself. Though _open() works for that too...


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.