[Webkit-unassigned] [Bug 25309] Use AtomicStrings more effectively in the V8 bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25309


dglazkov at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29648|review?(dglazkov at chromium.or|review-
               Flag|g)                          |




------- Comment #2 from dglazkov at chromium.org  2009-04-21 09:31 PDT -------
(From update of attachment 29648)
> Index: bindings/v8/V8Binding.h
> ===================================================================
> --- bindings/v8/V8Binding.h	(revision 42710)
> +++ bindings/v8/V8Binding.h	(working copy)
> @@ -34,7 +34,7 @@
>  // FIXME: This is a temporary forwarding header until all bindings have migrated
>  // over and v8_binding actually becomes V8Binding.
>  #include "v8_binding.h"
> -
> +#include "AtomicString.h"
>  namespace WebCore {
>  
>      // FIXME: Remove once migration is complete.
> @@ -51,7 +51,13 @@ namespace WebCore {
>      // FIXME: Remove once migration is complete.
>      inline String toWebCoreString(v8::Handle<v8::Value> obj)
>      {
> -        return ToWebCoreString(obj);
> +      return ToWebCoreString(obj);
> +    }
> +
> +    // FIXME: Remove once migration is complete.
> +    inline String toWebCoreString(v8::Handle<v8::String> obj)
> +    {
> +      return ToWebCoreString(obj);
>      }

Did you mean to put this file into this change? It's just reformatting to
2-space indent, which ain't good for WebKit anyway.

Otherwise, looks good.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.