[Webkit-unassigned] [Bug 24862] REGRESSION: Backspacing link from new line adds "text-decoration: none" to style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 20 17:40:12 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=24862





------- Comment #6 from jparent at google.com  2009-04-20 17:40 PDT -------
I've identified where this regression came from.  It was introduced with the
changes in trunk/WebCore/editing/CompositeEditCommand.cpp to preserve empty
paragraph style when moving paragraphs in
http://trac.webkit.org/changeset/34681/trunk/WebCore/editing.

Given my original example HTML (<a
href="http://www.test.com">test</a><div><br></div>), with the cursor in the
last div, in move paragraphs, the style is calculated for that empty paragraph
(it has no special styles, so text-decoration:none), the empty paragraph is
removed, and then the empty paragraph style is applied to the move destination
(the text node inside the anchor) by applyInlineStyle, which calls
removeInlineStyle, which sees text-decoration:none, which calls
pushDownTextDecorationStyleAtBoundaries, which calls
pushDownTextDecorationStyleAroundNode(start.node(), true) (start is the text
node inside the anchor).  This code finds the anchor ancestor which does have
text decoration, and calls extractAndNegateTextDecorationStyle, which negates
it, setting text-decoration:none on the anchor.  Thus, we wind up with
text-decoration:none on the anchor.

Anyway, that is what is happening.  I don't really know which part is the
actual *bug* though.  I'm happy to keep digging, but since I don't know this
code at all, I'd love advice from Justin or Eric on how to proceed here ...


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list