[Webkit-unassigned] [Bug 25243] Crash when data:// loads are cancelled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25243


xan.lopez at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xan.lopez at gmail.com




------- Comment #2 from xan.lopez at gmail.com  2009-04-20 06:53 PDT -------
(In reply to comment #1)
> Created an attachment (id=29549)
 --> (https://bugs.webkit.org/attachment.cgi?id=29549&action=view) [review]
> fix plugin crash
> 
>  WebCore/ChangeLog                                  |   15 +++++++++++++++
>  .../platform/network/soup/ResourceHandleSoup.cpp   |   15 ++++++++++++++-
>  WebKit/gtk/ChangeLog                               |   10 ++++++++++
>  WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp |    7 +++++++
>  4 files changed, 46 insertions(+), 1 deletions(-)
> 

+        Properly handle cancellation of the load for data:// loads. This
+        fixes crashing in the followin test:
+
+         
plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html

Extra indentation?

+    ResourceHandleInternal* d = handle->getInternal();
+    if (d->m_cancelled)
+      return false;

Wrong indentation.

So, all the checks are needed for the crash to go away, or you are just being
extra careful? And the FrameLoaderClientGtk change is for the same bug?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.