[Webkit-unassigned] [Bug 25259] AX: VoiceOver cmd-cntl-space does not follow the google.com->more link

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25259


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29569|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2009-04-17 05:17 PDT -------
(From update of attachment 29569)
> +            bool visibilityChanged = (m_style->visibility() != newStyle->visibility() ||
> +                                            m_style->zIndex() != newStyle->zIndex() ||
> +                                            m_style->hasAutoZIndex() != newStyle->hasAutoZIndex());

The formatting here retains strange indenting and parentheses from the if
statement. I would use this format:

    bool visibilityChanged = m_style->visibility() != newStyle->visibility()
        || m_style->zIndex() != newStyle->zIndex()
        || m_style->hasAutoZIndex() != newStyle->hasAutoZIndex();

Partly this is because I prefer the "operators at beginning of line" style
because I think it makes it clearer that subsequent lines are continuations of
the expression. And partly because I think the entire expression is easier to
read if we don't do excessive indentation.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.