[Webkit-unassigned] [Bug 25260] Finish V8 custom bindings for InspectorController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25260


fishd at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29571|review?                     |review+
               Flag|                            |




------- Comment #2 from fishd at chromium.org  2009-04-16 21:02 PDT -------
(From update of attachment 29571)
> +++ b/WebCore/bindings/v8/custom/V8InspectorControllerCustom.cpp

> +    Node* node = V8Proxy::DOMWrapperToNode<Node>(args[0]);
> +    if (!node)
> +        return v8::Undefined();
> +
> +   InspectorController* inspectorController = V8Proxy::ToNativeObject<InspectorController>(V8ClassIndex::INSPECTORCONTROLLER, args.Holder());
> +   inspectorController->highlight(node);
> +
> +    return v8::Undefined();
> +}

^^^ indentation is off by one there.

otherwise, LGTM


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.