[Webkit-unassigned] [Bug 24849] Implement HTMLMediaElement 'played' attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24849





------- Comment #12 from pdherbemont at apple.com  2009-04-16 15:22 PDT -------
(In reply to comment #11)
> (From update of attachment 29552 [review])
> 
> 
> > +    if (m_playing)
> > +    {
> 
> Still a style violation here.
> And here.

Fixed.

> > +        if (addedRange.isOverlappingRange(m_ranges[overlappingArcIndex])
> > +         || addedRange.isContiguousWithRange(m_ranges[overlappingArcIndex])) {
> 
> > +                if (m_ranges[overlappingArcIndex - 1].isBeforeRange(addedRange)
> > +                    && addedRange.isBeforeRange(m_ranges[overlappingArcIndex])) {
> 
> The indentation should be consistent. I prefer the second one.

The guidelines seems to say that first one should be preferred.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.