[Webkit-unassigned] [Bug 25244] <option> elements inside an <optgroup> are bold on Chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25244


adele at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29550|review?(adele at apple.com)    |review-
               Flag|                            |




------- Comment #2 from adele at apple.com  2009-04-16 15:01 PDT -------
(From update of attachment 29550)
The code change is fine.

I don't think those comments belong in html4.css though.  If anything, we need
a comment in themeWin.css about why we're forcing the font to be inherited. 
Something like "Option font must be inherited because we depend on computing
the size of the <select> based on the size of the options, and they must use
the same font for that computation to be correct".

I hesitate to say anything about the Changelog, because I think we all usually
say too little in the logs, but I think you can probably have a more concise
explanation here.

This is really an r+, but I'd like you to edit the comments & ChangeLog before
you checkin.  If you do that, pretty much anyone can give you the final r+.

Nice work!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.