[Webkit-unassigned] [Bug 25066] Video controls misplaced when dynamically adding reflection or opacity

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25066





------- Comment #3 from simon.fraser at apple.com  2009-04-15 23:06 PDT -------
The problem here is that RenderMedia lies about the RenderObject hierarchy. It
overrides RenderMedia::children() to return the children of the
m_controlsShadowRoot renderer, thus skipping that renderer itself. This
confuses RenderLayer::insertOnlyThisLayer(), which iterates through its child
renderers, calling RenderObject::moveLayers() on each one. For RenderMedia,
this finds the wrong renderers (which is important because the
m_controlsShadowRoot has a layer!).

If we actually add the m_controlsShadowRoot renderer as a child of the
RenderMedia, and don't like about the render hierarchy, it works fine.

Antti, was there a reason for faking the renderer hierarchy here?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.