[Webkit-unassigned] [Bug 21794] Middle-click panning should be springloaded while dragging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21794


fishd at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29506|review?(fishd at chromium.org) |review-
               Flag|                            |




------- Comment #14 from fishd at chromium.org  2009-04-15 11:32 PDT -------
(From update of attachment 29506)
> Index: WebCore/ChangeLog
...
> +2009-04-15  Itai Danan  <set EMAIL_ADDRESS environment variable>
> +        As per Bug 21794 (https://bugs.webkit.org/show_bug.cgi?id=21794),
> +	added an option for springloaded panscroll instead of sticky
> +	scroll. To understand why this is required see the discussion in
> +	issue 24722 (https://bugs.webkit.org/show_bug.cgi?id=24722).	

^^^ please replace tab characters with spaces.


> Index: WebCore/page/EventHandler.cpp
...
>      m_currentMousePosition = mouseEvent.pos();
>  
> +    if (!m_frame->settings()->stickyPanScroll())
> +      if (m_frame->page() && m_frame->page()->mainFrame()->eventHandler()->panScrollInProgress() || m_autoscrollInProgress) {
> +        stopAutoscrollTimer();
> +        invalidateClick();
> +        return true;
> +      }
> +

^^^ please change to use 4 space indentation


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.