[Webkit-unassigned] [Bug 25211] New: Navigation policy delegate performs the action on the second time through regardless of policy decision

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 15 10:36:59 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25211

           Summary: Navigation policy delegate performs the action on the
                    second time through regardless of policy decision
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Page Loading
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dacarson at gmail.com


In the FrameLoader.cpp:
void FrameLoader::checkNavigationPolicy(const ResourceRequest& request,
DocumentLoader* loader,
    PassRefPtr<FormState> formState, NavigationPolicyDecisionFunction function,
void* argument)
{
....
    // Don't ask more than once for the same request or if we are loading an
empty URL.
    // This avoids confusion on the part of the client.
    if (equalIgnoringHeaderFields(request, loader->lastCheckedRequest()) ||
(!request.isNull() && request.url().isEmpty())) {
        function(argument, request, 0, true);
        loader->setLastCheckedRequest(request);
        return;
    }
...
   
m_client->dispatchDecidePolicyForNavigationAction(&FrameLoader::continueAfterNavigationPolicy,
        action, request, formState);
...
}
On the second call to checkNavigationPolicy(), the action is just taken.

This is specifically noticeable with HTML that jumps to a fragment. If the user
clicks a link such as <a href="#page2"> and the client application responded
Ignore to the policy and the user clicks the same link again, we will scroll to
the anchor position.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list