[Webkit-unassigned] [Bug 25175] It is possible for unique anonymous functions to hash to the same value, thus showing up as one function in the profiler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 15 07:43:49 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25175





------- Comment #10 from darin at apple.com  2009-04-15 07:43 PDT -------
(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 29474 [review] [review])
> > The function pointer should be JSFunction*, not JSObject*. We always want to
> > use as specific a type as possible.
> > 
> > > +        ProtectedPtr<JSObject> m_function;
> It cannot be a JSFunction because being callable does not imply being a
> JSFunction

I know that being callable does not imply JSFunction, but all the call sites in
this patch *do* have a JSFunction.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list