[Webkit-unassigned] [Bug 25201] Add ScriptFunctionCall/ScriptObject for V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25201


fishd at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29488|review?                     |review+
               Flag|                            |




------- Comment #2 from fishd at chromium.org  2009-04-14 21:13 PDT -------
(From update of attachment 29488)
> +++ b/WebCore/bindings/v8/ScriptObject.cpp
...
> +#include "config.h"
> +#include "ScriptObject.h"
> +#include "ScriptScope.h"
> +#include "ScriptState.h"

nit: insert newline after ScriptObject.h


> +++ b/WebCore/bindings/v8/ScriptObject.h
...
> +    class ScriptObject : public ScriptValue {
...
> +        static ScriptObject createNew(ScriptState*);

nit: isn't it more common to just call a function like this "create" instead?


> +++ b/WebCore/bindings/v8/ScriptObjectQuarantine.cpp
...
> +bool getQuarantinedScriptObject(Database* database, ScriptObject& quarantinedObject)
> +{
> +    ASSERT(database);
> +
> +    // FIXME: Implement when Database V8 bindings are enabled

nit: maybe add an ASSERT_NOT_REACHED?


> +    // FIXME: Implement when DOM Storage V8 bindings are enabled

ditto


LGTM


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.