[Webkit-unassigned] [Bug 25149] Geolocation should start timer after permission is granted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25149


bolsinga at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #4 from bolsinga at apple.com  2009-04-12 15:42 PDT -------
(In reply to comment #3)
> (From update of attachment 29423 [review])
> r-.  Some concerns below.

> > +
> > +void Geolocation::startTimersForOneShots()
> > +{
> > +    Vector<RefPtr<GeoNotifier> > copy;
> > +    copyToVector(m_oneShots, copy);
> 
> If starting the timer cannot alter m_oneShot, I don't think there is any reason
> to copy the set into a vector. 
> 
> > +void Geolocation::startTimersForWatchers()
> > +{
> > +    Vector<RefPtr<GeoNotifier> > copy;
> > +    copyValuesToVector(m_watchers, copy);
> 
> Same comment.
> 

Each of these are not Vectors, and this allows me to have a common startTimers
call between the two.

I'm addressing your other comments, and will have a new patch shortly.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.