[Webkit-unassigned] [Bug 22898] [GTK] need proper API for printing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22898





------- Comment #47 from gns at gnome.org  2009-04-12 14:49 PDT -------
(In reply to comment #46)
> > +     * Emitted when printing is requested by the frame, usually
> > +     * because of a javascript call. While handling this signal you
> > +     * should call webkit_web_frame_print() to do the actual printing.
> 
> s/While/When/ ???

Yep =) 

> > +    webkit_web_view_signals[PRINT_REQUESTED] = g_signal_new("print-requested",
> > +            G_TYPE_FROM_CLASS(webViewClass),
> > +            (GSignalFlags)(G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION),
> > +            0,
> > +            NULL,
> > +            NULL,
> > +            webkit_marshal_BOOLEAN__OBJECT,
> > +            G_TYPE_BOOLEAN, 1,
> > +            WEBKIT_TYPE_WEB_FRAME);
> 
> Should we use g_signal_accumulator_true_handled to stop the signal emission?

Yes, indeed. Adding it =).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.