[Webkit-unassigned] [Bug 15616] [GTK] Add spell checking (and grammar?)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=15616





------- Comment #18 from zecke at selfish.org  2009-04-11 20:45 PDT -------
(From update of attachment 29380)
A ChangeLog entry is missing. :)


>  bool EditorClient::isContinuousSpellCheckingEnabled()
>  {
> -    notImplemented();
> -    return false;
> +    WebKitWebSettings* settings;
> +    gboolean enabled;
> +
> +    settings = webkit_web_view_get_settings(m_webView);
> +    g_object_get(settings, "enable-spell-checking", &enabled, NULL);

NULL or 0... the old question :)


> +    g_object_class_install_property(gobject_class,
> +                                    PROP_ENABLE_SPELL_CHECKING,
> +                                    g_param_spec_boolean(
> +                                    "enable-spell-checking",
> +                                    "Enable Spell Checking",
> +                                    "Enables check-as-you-type spell checking",
> +                                    FALSE,
> +                                    flags));

There is a patch from Gustavo that is adding i18n to the properties as well, it
might make sense to assume this patch was landed (if it wasn't) and use the
glorious _() gettext macro for the summary and description.


> +    case PROP_ENABLE_SPELL_CHECKING:
> +        g_value_set_boolean(value, priv->enable_spell_checking);
> +	break;

break is misplaced.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.