[Webkit-unassigned] [Bug 16122] When posting to these boards, all Safari users have "webkitformboundary-gibberish" appended to their name and message

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16122


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28964|review?                     |review-
               Flag|                            |




------- Comment #20 from ap at webkit.org  2009-04-10 23:02 PDT -------
(From update of attachment 28964)
> I think the patch probably went unnoticed

Looks like that, sorry!

+        WARNING: NO TEST CASES ADDED OR CHANGED

This line is just a reminder to the person making the patch, please remove it,
or replace with a short explanation of why a test is not possible, or better
yet, add a test. I realize that the behavior is random, but it's acceptable to
have tests that are not 100% reliable.

It's not often that I have a chance to say this, but I think that the ChangeLog
has a bit too much information - for a full discussion, one can always refer to
this bug.

This patch has a lot of tab characters, please replace them with spaces.

+        // Note: it may be better to not restore the / character, based on the
regex escaping issues
+        // documented in https://bugs.webkit.org/show_bug.cgi?id=16122// 

Yes, please remove the FIXME, and change this whole comment to just explain the
behavior.

The substance of the patch looks good.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.