[Webkit-unassigned] [Bug 25132] help prevent crash in chromium event handling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25132


dglazkov at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29395|review?(dglazkov at chromium.or|review-
               Flag|g)                          |




------- Comment #2 from dglazkov at chromium.org  2009-04-10 13:37 PDT -------
(From update of attachment 29395)
Just some styling nits.

> +This is some cleanup motivated by the  crash in http://crbug.com/9775 , which
> +happens because of calling window.open inside a window.onload handler. 
> +
> +These changes are just part of the fix, along with some asserts to help prevent
> +breakage on future changes. 

We usually indent these to the same col as "Reviewed By".

> +            // TODO(asargent) this check for hidden value being !empty is a workaround for

TODO(asargent) -> FIXME:in WebKit world.

> +            // Once the fix for that is pulled into chromium we can remove the check here.
> +            if (!object->GetHiddenValue(key).IsEmpty()) {
> +              object->DeleteHiddenValue(getKey(listener->isInline()));
> +            }

no brackets around one-liners.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.