[Webkit-unassigned] [Bug 25121] Upstream changes to handle error messages from V8 when running worker script.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25121


jianli at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jianli at chromium.org




------- Comment #3 from jianli at chromium.org  2009-04-10 13:03 PDT -------
It is now possible since we turn on v8 preemption although the chance is
extremely small. I am working on a fix for this one. Thanks.

(In reply to comment #2)
> (From update of attachment 29384 [review])
> LGTM
> 
> > +    // Do the one-time initialization.
> > +    static bool v8Initialized = false;
> > +    if (!v8Initialized) {
> > +        // Tells V8 not to call the default OOM handler, binding code will handle it.
> > +        v8::V8::IgnoreOutOfMemoryException();
> > +        v8::V8::SetFatalErrorHandler(reportFatalErrorInV8);
> > +        
> > +        v8::V8::AddMessageListener(handleConsoleMessage);
> > +        
> > +        v8Initialized = true;
> > +    }
> 
> Is there really no worry about multiple threads running this code at the same
> time?
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.