[Webkit-unassigned] [Bug 20722] localtime_r and gmtime_r not present in mingw32

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20722





------- Comment #4 from lkcl at lkcl.net  2009-04-10 03:52 PDT -------
(In reply to comment #3)
> A patch originally described as "badly-hacked get-it-to-compile jobbie" needs
> to be reworked to have a chance of going in.

:)

all it needs is someone else to review it, and come up with either a yes/no
or an alternative.

for example, why does Win32 native build succeed (or does it?)

does MSVC have localtime_r

does MingW32 _native_ have localtime_r ?

so - should this be #ifndef MINGW32 (or equiv) rather than #ifndef WIN32?

is the non-thread-safe version of localtime and gmtime acceptable to use?

should there be thread-locking around the use of localtime and gmtime?

is memcpy acceptable?

empirical evidence suggests that "yes" is the correct answer to the last
three of these questions.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.